Re: [PR] NIFI-12231 FetchSmb supports Move and Delete Completion Strategies [nifi]
asfgit closed pull request #8617: NIFI-12231 FetchSmb supports Move and Delete Completion Strategies URL: https://github.com/apache/nifi/pull/8617 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] NIFI-12231 FetchSmb supports Move and Delete Completion Strategies [nifi]
turcsanyip commented on PR #8617: URL: https://github.com/apache/nifi/pull/8617#issuecomment-2094368629 @exceptionfactory I managed to fix the tests by changing the logic in FetchSmb. There were 2 overlapping sessions to the SMB server: one for reading the file and the other for executing the completions strategy (move or delete) in `commitAsync()`. I moved the commit out of the TWR block of the first session, so the "read" session gets closed before the "move/delete" session starts. Parallel sessions should not cause issues as the file handles are closed properly and it worked in my environments (ran flows connecting to Windows share and Samba share, ran integrations tests on Mac and Linux). Not sure what the docker environment is doing in Github CI but this change fixed it. I re-ran the integrations tests 3 times and all were green. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] NIFI-12231 FetchSmb supports Move and Delete Completion Strategies [nifi]
turcsanyip commented on PR #8617: URL: https://github.com/apache/nifi/pull/8617#issuecomment-2057533064 > The integration tests workflow failed on `FetchSmbIT` for the following tests: > > ``` > FetchSmbIT.testCompletionStrategyDelete:114 expected: but was: > FetchSmbIT.testCompletionStrategyMoveWithCreatingDirectory:149 expected: but was: > ``` Thanks for the heads-up @exceptionfactory! I rerun the integration test on GitHub and got the same errors. So they are not intermittent. However, I did not manage to replicate it in my environments. It worked on Mac and now I also set up a similar environment to GitHub Actions (same OS, Java and Docker versions) but no luck. I pushed some changes in order to get more info and also modified the logic a bit (just trial-and-error approach). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
