[GitHub] Terry-Shi commented on issue #92: Error when list action
Terry-Shi commented on issue #92: Error when list action URL: https://github.com/apache/incubator-openwhisk-deploy-kube/issues/92#issuecomment-347768085 re-tried with newest image and yaml, still got same result. [2017-11-29T06:41:15.609Z] [INFO] [#tid_111] GET /api/v1/namespaces/_/actions limit=30=0 [2017-11-29T06:41:15.627Z] [INFO] [#tid_111] [RestAPIVersion] authenticate: 23bc46b1-71f6-4ed5-8c54-816aa4f8c502 [2017-11-29T06:41:15.630Z] [INFO] [#tid_111] [Identity] [GET] serving from datastore: CacheKey(23bc46b1-71f6-4ed5-8c54-816aa4f8c502) [marker:database_cacheMiss_count:24] [2017-11-29T06:41:15.631Z] [INFO] [#tid_111] [CouchDbRestStore] [QUERY] 'test_subjects' searching 'subjects/identities [marker:database_queryView_start:24] [2017-11-29T06:41:16.573Z] [INFO] [#tid_111] [CouchDbRestStore] [QUERY] 'test_subjects' completed: matched 1 [marker:database_queryView_finish:967:943] [2017-11-29T06:41:16.574Z] [INFO] [#tid_111] [RestAPIVersion] authentication valid [2017-11-29T06:41:16.591Z] [INFO] [#tid_111] [LocalEntitlementProvider] checking user 'guest' has privilege 'READ' for 'actions/guest' [2017-11-29T06:41:16.594Z] [INFO] [#tid_111] [ActivationThrottler] concurrent activations in system = 0, below limit = 5000 [2017-11-29T06:41:16.597Z] [INFO] [#tid_111] [LocalEntitlementProvider] authorized [2017-11-29T06:41:16.597Z] [INFO] [#tid_111] [ActionsApi] [LIST] exclude private entities: required == false [2017-11-29T06:41:16.608Z] [INFO] [#tid_111] [CouchDbRestStore] [QUERY] 'test_whisks' searching 'whisks/actions [marker:database_queryView_start:1002] [2017-11-29T06:41:16.617Z] [ERROR] [#tid_111] [CouchDbRestStore] Unexpected http response code: 404 Not Found [marker:database_queryView_error:1008:6] [2017-11-29T06:41:16.617Z] [ERROR] [#tid_111] [CouchDbRestStore] [QUERY] 'test_whisks' internal error, failure: 'Unexpected http response code: 404 Not Found' [marker:database_queryView_error:1010:8] [2017-11-29T06:41:16.656Z] [ERROR] [#tid_111] [ActionsApi] [LIST] entity failed: Unexpected http response code: 404 Not Found [2017-11-29T06:41:16.666Z] [INFO] [#tid_111] [BasicHttpService] [marker:http_get.500_count:1060:1060] This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] style95 commented on issue #3015: [Feature request] Hide codes or parameters from shared package
style95 commented on issue #3015: [Feature request] Hide codes or parameters from shared package URL: https://github.com/apache/incubator-openwhisk/issues/3015#issuecomment-347754222 I am fine to close this issue. Could you explain more about what you mentioned or have me get any reference? I think I am not aware of `final`, `composition` and `API discovery`. What are those use-cases? Is it already supported by OW now? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] sungjunyoung opened a new issue #3024: Action using dockerfile without going through dockerhub
sungjunyoung opened a new issue #3024: Action using dockerfile without going through dockerhub URL: https://github.com/apache/incubator-openwhisk/issues/3024 Openwhisk can create an action through a docker image in the dockerhub. But the process of uploading and pulling images on the dockerhub seemed cumbersome. Is there a way to create an action with the `Dockerfile` itself without going through dockerhub? It seems to be possible by building a docker locally on user's openwhisk server. User will be able to administrate by build own `Dockerfile` with tag like `wsk create action example exec --dockerfile ./Dockerfile --tag user/example` This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] csantanapr commented on issue #64: Add ddoc and controller_ha env variables
csantanapr commented on issue #64: Add ddoc and controller_ha env variables URL: https://github.com/apache/incubator-openwhisk-devtools/pull/64#issuecomment-347748839 no longer valid, #63 made updates to make build work again This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] csantanapr closed pull request #64: Add ddoc and controller_ha env variables
csantanapr closed pull request #64: Add ddoc and controller_ha env variables
URL: https://github.com/apache/incubator-openwhisk-devtools/pull/64
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/docker-compose/docker-whisk-controller.env
b/docker-compose/docker-whisk-controller.env
index f94817a..5a9ef71 100644
--- a/docker-compose/docker-whisk-controller.env
+++ b/docker-compose/docker-whisk-controller.env
@@ -13,6 +13,9 @@ DB_PREFIX=local_
DB_WHISK_ACTIONS=local_whisks
DB_WHISK_AUTHS=local_subjects
DB_WHISK_ACTIVATIONS=local_activations
+DB_WHISK_ACTIONS_DDOC=whisks.v2
+DB_WHISK_ACTIVATIONS_DDOC=whisks.v2
+DB_WHISK_ACTIVATIONS_FILTER_DDOC=whisks-filters.v2
KAFKA_NUMPARTITIONS=1
@@ -32,6 +35,7 @@ WHISK_SYSTEM_KEY=whisk.system
RUNTIMES_MANIFEST={"runtimes":{"nodejs":[{"kind":"nodejs","image":{"name":"nodejsaction"},"deprecated":true},{"kind":"nodejs:6","default":true,"image":{"name":"nodejs6action"}}],"python":[{"kind":"python","image":{"name":"python2action"}},{"kind":"python:2","default":true,"image":{"name":"python2action"}},{"kind":"python:3","image":{"name":"python3action"}}],"swift":[{"kind":"swift","image":{"name":"swiftaction"},"deprecated":true},{"kind":"swift:3","default":true,"image":{"name":"swift3action"}}],"java":[{"kind":"java","attached":{"attachmentName":"jarfile","attachmentType":"application/java-archive"},"sentinelledLogs":false,"requireMain":true,"image":{"name":"java8action"},"default":true}]}}
CONTROLLER_LOCALBOOKKEEPING=true
+CONTROLLER_HA=false
AKKA_CLUSTER_HOST=localhost
AKKA_CLUSTER_SEED_NODES=[]
AKKA_CLUSTER_BIND_PORT=5221
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] csantanapr closed pull request #40: Controller was failing to start using make run script
csantanapr closed pull request #40: Controller was failing to start using make
run script
URL: https://github.com/apache/incubator-openwhisk-devtools/pull/40
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/docker-compose/docker-whisk-controller.env
b/docker-compose/docker-whisk-controller.env
index 5941f7c..b989100 100644
--- a/docker-compose/docker-whisk-controller.env
+++ b/docker-compose/docker-whisk-controller.env
@@ -28,6 +28,7 @@ LIMITS_TRIGGERS_FIRES_PERMINUTE=6
LIMITS_ACTIONS_INVOKES_CONCURRENTINSYSTEM=5000
LOADBALANCER_ACTIVATIONCOUNTBEFORENEXTINVOKER=10
+LOADBALANCER_INVOKERBUSYTHRESHOLD=16
WHISK_SYSTEM_KEY=whisk.system
RUNTIMES_MANIFEST={"runtimes":{"nodejs":[{"kind":"nodejs","image":{"name":"nodejsaction"},"deprecated":true},{"kind":"nodejs:6","default":true,"image":{"name":"nodejs6action"}}],"python":[{"kind":"python","image":{"name":"python2action"}},{"kind":"python:2","default":true,"image":{"name":"python2action"}},{"kind":"python:3","image":{"name":"python3action"}}],"swift":[{"kind":"swift","image":{"name":"swiftaction"},"deprecated":true},{"kind":"swift:3","default":true,"image":{"name":"swift3action"}}],"java":[{"kind":"java","attached":{"attachmentName":"jarfile","attachmentType":"application/java-archive"},"sentinelledLogs":false,"requireMain":true,"image":{"name":"java8action"},"default":true}]}}
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] csantanapr commented on issue #40: Controller was failing to start using make run script
csantanapr commented on issue #40: Controller was failing to start using make run script URL: https://github.com/apache/incubator-openwhisk-devtools/pull/40#issuecomment-347748787 no longer valid, #63 made updates to make build work again This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rabbah opened a new issue #3023: Kamon configuration issues in controller
rabbah opened a new issue #3023: Kamon configuration issues in controller URL: https://github.com/apache/incubator-openwhisk/issues/3023 note the warnings: ```bash ansible-playbook -i environments/docker-machine controller.yml -e mode=clean [WARNING]: While constructing a mapping from /Users/rabbah/projects/openwhisk/ansible/roles/controller/tasks/deploy.yml, line 43, column 7, found a duplicate dict key (METRICS_KAMON). Using last defined value only. [WARNING]: While constructing a mapping from /Users/rabbah/projects/openwhisk/ansible/roles/controller/tasks/deploy.yml, line 43, column 7, found a duplicate dict key (METRICS_LOG). Using last defined value only. ``` @mhenke1 @vvraskin This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] ServoKvd commented on issue #2911: Proposal to to reorganize core/ and root(openwhisk/) folders to reflect existing architecture better
ServoKvd commented on issue #2911: Proposal to to reorganize core/ and root(openwhisk/) folders to reflect existing architecture better URL: https://github.com/apache/incubator-openwhisk/issues/2911#issuecomment-347746759 I was leaning towards keeping core/routemanagement ( the code for get/delete/create) in apigw repo and put the install scripts in cli, that means cli will have to do a "git clone on the apigw" repo to get to the modules to install. Had a lengthy discussion offline with Carlos - if we view "routemgmt code" as part of cli interface to install some actions needed for tests rather than "apigw or backend" functionality, then Carlos proposal makes sense, but if "routemgmt apis" are to be viewed as apigw functionality ( like I was also inclined to view them initially), then atleast core/routemgm belongs to apigw. Also is "incubator-openwhisk-cli" a client repo? , in the sense, is it on par with "js-client" "python-client" repos? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] ServoKvd commented on issue #2911: Proposal to to reorganize core/ and root(openwhisk/) folders to reflect existing architecture better
ServoKvd commented on issue #2911: Proposal to to reorganize core/ and root(openwhisk/) folders to reflect existing architecture better URL: https://github.com/apache/incubator-openwhisk/issues/2911#issuecomment-347746759 I was leaning towards keeping core/routemanagement ( the code for get/delete/create) in apigw repo and put the install scripts in cli, that means cli will have to do a "git clone on the apigw" repo to get to the modules to install. Had a lengthy discussion offline with Carlos - if we view "routemgmt code" as part of cli interface to install some actions, needed for tests rather than apigw or backend functionality, then Carlos proposal makes sense, but if "routemgmt apis" are to be viewed as apigw functionality ( like I was also inclined to view them), then atleast core/routemgm belongs to apigw. Also is "incubator-openwhisk-cli" a client repo? , in the sense, is it on par with "js-client" "python-client" repos? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rabbah commented on a change in pull request #3019: WIP: Trigger activation reduction
rabbah commented on a change in pull request #3019: WIP: Trigger activation
reduction
URL:
https://github.com/apache/incubator-openwhisk/pull/3019#discussion_r153685700
##
File path: core/controller/src/main/scala/whisk/core/controller/Triggers.scala
##
@@ -143,71 +144,81 @@ trait WhiskTriggersApi extends WhiskCollectionAPI {
response = ActivationResponse.success(payload orElse
Some(JsObject())),
version = trigger.version,
duration = None)
- logging.info(this, s"[POST] trigger activated, writing activation
record to datastore: $triggerActivationId")
- val saveTriggerActivation = WhiskActivation.put(activationStore,
triggerActivation) map { _ =>
-triggerActivationId
- }
val url = Uri(s"http://localhost:${whiskConfig.servicePort};)
- trigger.rules.map {
-_.filter {
- case (ruleName, rule) => rule.status == Status.ACTIVE
-} foreach {
- case (ruleName, rule) =>
-val ruleActivation = WhiskActivation(
- namespace = user.namespace.toPath, // all activations should
end up in the one space regardless trigger.namespace,
- ruleName.name,
- user.subject,
- activationIdFactory.make(),
- Instant.now(Clock.systemUTC()),
- Instant.EPOCH,
- cause = Some(triggerActivationId),
- response = ActivationResponse.success(),
- version = trigger.version,
- duration = None)
-logging.info(this, s"[POST] rule ${ruleName} activated,
writing activation record to datastore")
-WhiskActivation.put(activationStore, ruleActivation)
-
-val actionNamespace = rule.action.path.root.asString
-val actionPath = {
- rule.action.path.relativePath.map { pkg =>
-(Path.SingleSlash + pkg.namespace) /
rule.action.name.asString
- } getOrElse {
-Path.SingleSlash + rule.action.name.asString
- }
-}.toString
-
-val actionUrl = Path("/api/v1") / "namespaces" /
actionNamespace / "actions"
-val request = HttpRequest(
- method = POST,
- uri = url.withPath(actionUrl + actionPath),
- headers =
-
List(Authorization(BasicHttpCredentials(user.authkey.uuid.asString,
user.authkey.key.asString))),
- entity = HttpEntity(MediaTypes.`application/json`,
args.getOrElse(JsObject()).compactPrint))
-
-Http().singleRequest(request).map {
- response =>
-response.status match {
- case OK | Accepted =>
-Unmarshal(response.entity).to[JsObject].map { a =>
- logging.info(this, s"${rule.action} activated
${a.fields("activationId")}")
-}
- case NotFound =>
-response.discardEntityBytes()
-logging.info(this, s"${rule.action} failed, action not
found")
- case _ =>
-Unmarshal(response.entity).to[String].map { error =>
- logging.warn(this, s"${rule.action} failed due to
$error")
-}
-}
-}
+ val activeRules = trigger.rules map { _.filter((r) => r._2.status ==
Status.ACTIVE) } getOrElse Map[
+FullyQualifiedEntityName,
+whisk.core.entity.ReducedRule]()
+
+ val saveTriggerActivation = if (activeRules.size > 0) {
+logging.info(
+ this,
+ s"[POST] trigger activated against active rule(s), writing
activation record to datastore: $triggerActivationId")
+WhiskActivation.put(activationStore, triggerActivation) map { _ =>
+ triggerActivationId
}
+ } else {
+logging.info(this, s"[POST] trigger activated against no active
rule(s)")
+Future.failed(NoDocumentException("trigger has no active rules"))
+ }
+
+ activeRules.foreach {
+case (ruleName, rule) =>
+ val ruleActivation = WhiskActivation(
+namespace = user.namespace.toPath, // all activations should
end up in the one space regardless trigger.namespace,
+ruleName.name,
+user.subject,
+activationIdFactory.make(),
+Instant.now(Clock.systemUTC()),
+Instant.EPOCH,
+cause = Some(triggerActivationId),
+response = ActivationResponse.success(),
+version = trigger.version,
+duration = None)
+
[GitHub] rabbah commented on issue #3019: WIP: Trigger activation reduction
rabbah commented on issue #3019: WIP: Trigger activation reduction URL: https://github.com/apache/incubator-openwhisk/pull/3019#issuecomment-347745526 Take a look at this as an alternative: https://github.com/apache/incubator-openwhisk/compare/master...rabbah:trigger-activations?expand=1 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] xingzhou opened a new issue #98: Enable to use a fixed port instead of a dynamic assigned port for nginx service.
xingzhou opened a new issue #98: Enable to use a fixed port instead of a dynamic assigned port for nginx service. URL: https://github.com/apache/incubator-openwhisk-deploy-kube/issues/98 Considering nginx service is exposing the endpoint to the outside, it's better to enable user to use a fixed port instead of a dynamic K8s assigned port for Nginx service. I've added a `nodePort` field to the Nginx service object, as shown in Helm project here: https://github.com/xingzhou/Deploy_OpenWhisk_with_Helm/blob/master/charts/nginx/templates/service.yaml#L13-L30 /cc @dgrove-oss & @daisy-ycguo This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] Terry-Shi opened a new issue #97: couldn't create topic in Kafka
Terry-Shi opened a new issue #97: couldn't create topic in Kafka URL: https://github.com/apache/incubator-openwhisk-deploy-kube/issues/97 error log from controller-0 [2017-11-29T03:44:02.766Z] [ERROR] [??] [KafkaMessagingProvider] exception during creation of topic completed0 [2017-11-29T03:44:02.768Z] [ERROR] [??] [Controller] failure during msgProvider.ensureTopic for topic completed0 error log from invoker-0 [2017-11-29T03:50:04.156Z] [ERROR] [??] [KafkaMessagingProvider] exception during creation of topic invoker0 [2017-11-29T03:50:04.234Z] [ERROR] [#sid_100] [Invoker] failure during msgProvider.ensureTopic for topic invoker0 log from Kafka: [2017-11-29 03:21:12,941] INFO Kafka version : 0.10.0.1 (org.apache.kafka.common.utils.AppInfoParser) [2017-11-29 03:21:12,941] INFO Kafka commitId : a7a17cdec9eaa6c5 (org.apache.kafka.common.utils.AppInfoParser) [2017-11-29 03:21:12,942] INFO [Kafka Server 0], started (kafka.server.KafkaServer) Create completed topics Create invoker topics /start.sh This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] lee212 opened a new issue #96: Unable to connect to zookeeper.openwhisk:2181
lee212 opened a new issue #96: Unable to connect to zookeeper.openwhisk:2181
URL: https://github.com/apache/incubator-openwhisk-deploy-kube/issues/96
Hi,
It seems zookeeper is deployed but kafka is failing to connect.
```
$ kubectl get pods,services --all-namespaces=true -o wide
NAMESPACE NAME READY STATUS
RESTARTS AGE IP NODE
default po/kube-apiserver-127.0.0.11/1 Running
0 9h127.0.0.1127.0.0.1
default po/kube-controller-manager-127.0.0.1 1/1 Running
0 9h127.0.0.1127.0.0.1
default po/kube-scheduler-127.0.0.11/1 Running
0 9h127.0.0.1127.0.0.1
openwhisk po/apigateway-3311085443-mbc4c 1/1 Running
0 3h172.17.0.4 127.0.0.1
openwhisk po/controller-00/1
CrashLoopBackOff 79 3h172.17.0.7 127.0.0.1
openwhisk po/controller-10/1
CrashLoopBackOff 79 3h172.17.0.8 127.0.0.1
openwhisk po/couchdb-710020075-gfqdf 1/1 Running
0 8h172.17.0.2 127.0.0.1
openwhisk po/kafka-1473765933-v4p3c 0/1
CrashLoopBackOff 9 25m 172.17.0.6 127.0.0.1
openwhisk po/redis-1106165648-zgxcs 1/1 Running
0 3h172.17.0.3 127.0.0.1
openwhisk po/zookeeper-1304892743-0zw8h 1/1 Running
0 29m 172.17.0.5 127.0.0.1
NAMESPACE NAME CLUSTER-IP EXTERNAL-IP PORT(S)
AGE SELECTOR
default svc/kubernetes 10.254.0.1 443/TCP
9h
openwhisk svc/apigateway 10.254.90.227 8080/TCP,9000/TCP
3hname=apigateway
openwhisk svc/controller None8080/TCP
3hname=controller
openwhisk svc/couchdb 10.254.249.61 5984/TCP
8hname=couchdb
openwhisk svc/kafka10.254.67.719092/TCP
28m name=kafka
openwhisk svc/redis10.254.10.167 6379/TCP
3hname=redis
openwhisk svc/zookeeper10.254.144.28
2181/TCP,2888/TCP,3888/TCP 3hname=zookeeper
```
The log of kafka:
```
waiting for kafka to be available
+ '[' -n 10.254.144.28 ']'
+ ZOOKEEPER_IP=10.254.144.28
+ '[' -n 2181 ']'
+ ZOOKEEPER_PORT=2181
++ grep '\skafka-1473765933-v4p3c$' /etc/hosts
++ head -n 1
++ awk '{print $1}'
+ IP=172.17.0.6
+ '[' -z '' ']'
+ ZOOKEEPER_CONNECTION_STRING=10.254.144.28:2181
+ cat /kafka/config/server.properties.template
+ sed -e 's|{{KAFKA_ADVERTISED_HOST_NAME}}|kafka.openwhisk|g' -e
's|{{KAFKA_ADVERTISED_PORT}}|9092|g' -e
's|{{KAFKA_AUTO_CREATE_TOPICS_ENABLE}}|true|g' -e 's|{{KAFKA_BROKER_ID}}|0|g'
-e 's|{{KAFKA_DEFAULT_REPLICATION_FACTOR}}|1|g' -e
's|{{KAFKA_DELETE_TOPIC_ENABLE}}|false|g' -e
's|{{KAFKA_GROUP_MAX_SESSION_TIMEOUT_MS}}|30|g' -e
's|{{KAFKA_INTER_BROKER_PROTOCOL_VERSION}}|0.10.2.1|g' -e
's|{{KAFKA_LOG_MESSAGE_FORMAT_VERSION}}|0.10.2.1|g' -e
's|{{KAFKA_LOG_RETENTION_HOURS}}|168|g' -e 's|{{KAFKA_NUM_PARTITIONS}}|1|g' -e
's|{{KAFKA_PORT}}|9092|g' -e 's|{{ZOOKEEPER_CHROOT}}||g' -e
's|{{ZOOKEEPER_CONNECTION_STRING}}|10.254.144.28:2181|g' -e
's|{{ZOOKEEPER_CONNECTION_TIMEOUT_MS}}|1|g' -e
's|{{ZOOKEEPER_SESSION_TIMEOUT_MS}}|1|g'
+ '[' -z ']'
+ KAFKA_JMX_OPTS=-Dcom.sun.management.jmxremote=true
+ KAFKA_JMX_OPTS='-Dcom.sun.management.jmxremote=true
-Dcom.sun.management.jmxremote.authenticate=false'
+ KAFKA_JMX_OPTS='-Dcom.sun.management.jmxremote=true
-Dcom.sun.management.jmxremote.authenticate=false
-Dcom.sun.management.jmxremote.ssl=false'
+ KAFKA_JMX_OPTS='-Dcom.sun.management.jmxremote=true
-Dcom.sun.management.jmxremote.authenticate=false
-Dcom.sun.management.jmxremote.ssl=false
-Dcom.sun.management.jmxremote.rmi.port=7203'
+ KAFKA_JMX_OPTS='-Dcom.sun.management.jmxremote=true
-Dcom.sun.management.jmxremote.authenticate=false
-Dcom.sun.management.jmxremote.ssl=false
-Dcom.sun.management.jmxremote.rmi.port=7203
-Djava.rmi.server.hostname=kafka.openwhisk '
+ export KAFKA_JMX_OPTS
+ echo 'Starting kafka'
+ exec /kafka/bin/kafka-server-start.sh /kafka/config/server.properties
Starting kafka
waiting for kafka to be available
waiting for kafka to be available
waiting for kafka to be available
waiting for kafka to be available
[2017-11-29 03:25:42,564] INFO KafkaConfig values:
advertised.host.name = kafka.openwhisk
advertised.listeners = null
advertised.port = 9092
[GitHub] rabbah commented on a change in pull request #3019: WIP: Trigger activation reduction
rabbah commented on a change in pull request #3019: WIP: Trigger activation
reduction
URL:
https://github.com/apache/incubator-openwhisk/pull/3019#discussion_r153685127
##
File path: core/controller/src/main/scala/whisk/core/controller/Triggers.scala
##
@@ -143,71 +144,81 @@ trait WhiskTriggersApi extends WhiskCollectionAPI {
response = ActivationResponse.success(payload orElse
Some(JsObject())),
version = trigger.version,
duration = None)
- logging.info(this, s"[POST] trigger activated, writing activation
record to datastore: $triggerActivationId")
- val saveTriggerActivation = WhiskActivation.put(activationStore,
triggerActivation) map { _ =>
-triggerActivationId
- }
val url = Uri(s"http://localhost:${whiskConfig.servicePort};)
- trigger.rules.map {
-_.filter {
- case (ruleName, rule) => rule.status == Status.ACTIVE
-} foreach {
- case (ruleName, rule) =>
-val ruleActivation = WhiskActivation(
- namespace = user.namespace.toPath, // all activations should
end up in the one space regardless trigger.namespace,
- ruleName.name,
- user.subject,
- activationIdFactory.make(),
- Instant.now(Clock.systemUTC()),
- Instant.EPOCH,
- cause = Some(triggerActivationId),
- response = ActivationResponse.success(),
- version = trigger.version,
- duration = None)
-logging.info(this, s"[POST] rule ${ruleName} activated,
writing activation record to datastore")
-WhiskActivation.put(activationStore, ruleActivation)
-
-val actionNamespace = rule.action.path.root.asString
-val actionPath = {
- rule.action.path.relativePath.map { pkg =>
-(Path.SingleSlash + pkg.namespace) /
rule.action.name.asString
- } getOrElse {
-Path.SingleSlash + rule.action.name.asString
- }
-}.toString
-
-val actionUrl = Path("/api/v1") / "namespaces" /
actionNamespace / "actions"
-val request = HttpRequest(
- method = POST,
- uri = url.withPath(actionUrl + actionPath),
- headers =
-
List(Authorization(BasicHttpCredentials(user.authkey.uuid.asString,
user.authkey.key.asString))),
- entity = HttpEntity(MediaTypes.`application/json`,
args.getOrElse(JsObject()).compactPrint))
-
-Http().singleRequest(request).map {
- response =>
-response.status match {
- case OK | Accepted =>
-Unmarshal(response.entity).to[JsObject].map { a =>
- logging.info(this, s"${rule.action} activated
${a.fields("activationId")}")
-}
- case NotFound =>
-response.discardEntityBytes()
-logging.info(this, s"${rule.action} failed, action not
found")
- case _ =>
-Unmarshal(response.entity).to[String].map { error =>
- logging.warn(this, s"${rule.action} failed due to
$error")
-}
-}
-}
+ val activeRules = trigger.rules map { _.filter((r) => r._2.status ==
Status.ACTIVE) } getOrElse Map[
+FullyQualifiedEntityName,
+whisk.core.entity.ReducedRule]()
+
+ val saveTriggerActivation = if (activeRules.size > 0) {
+logging.info(
+ this,
+ s"[POST] trigger activated against active rule(s), writing
activation record to datastore: $triggerActivationId")
+WhiskActivation.put(activationStore, triggerActivation) map { _ =>
+ triggerActivationId
}
+ } else {
+logging.info(this, s"[POST] trigger activated against no active
rule(s)")
+Future.failed(NoDocumentException("trigger has no active rules"))
+ }
+
+ activeRules.foreach {
+case (ruleName, rule) =>
+ val ruleActivation = WhiskActivation(
+namespace = user.namespace.toPath, // all activations should
end up in the one space regardless trigger.namespace,
+ruleName.name,
+user.subject,
+activationIdFactory.make(),
+Instant.now(Clock.systemUTC()),
+Instant.EPOCH,
+cause = Some(triggerActivationId),
+response = ActivationResponse.success(),
+version = trigger.version,
+duration = None)
+
[GitHub] rabbah commented on issue #2911: Proposal to to reorganize core/ and root(openwhisk/) folders to reflect existing architecture better
rabbah commented on issue #2911: Proposal to to reorganize core/ and root(openwhisk/) folders to reflect existing architecture better URL: https://github.com/apache/incubator-openwhisk/issues/2911#issuecomment-347739972 Seems wrong to put a backend/server side deployment in a client repo. Why not the API gw repo? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rabbah opened a new issue #3022: services.KafkaConnectorTests.Kafka heisenbug
rabbah opened a new issue #3022: services.KafkaConnectorTests.Kafka heisenbug URL: https://github.com/apache/incubator-openwhisk/issues/3022 Observed one failure in jenkins: ```bash services.KafkaConnectorTests.Kafka connector should send and receive a kafka message even after shutdown one of instances Error Message org.apache.kafka.common.errors.NotLeaderForPartitionException: This server is not the leader for that topic-partition. Stacktrace org.apache.kafka.common.errors.NotLeaderForPartitionException: This server is not the leader for that topic-partition. Standard Output [2017-11-28T15:07:19.923Z] [INFO] Slf4jLogger started Received 1. Took 407 msec: List(Tue Nov 28 15:07:20 EST 2017) Received 1. Took 4 msec: List(Tue Nov 28 15:07:20 EST 2017) Received 1. Took 4 msec: List(Tue Nov 28 15:07:20 EST 2017) Received 1. Took 4 msec: List(Tue Nov 28 15:07:20 EST 2017) Received 1. Took 3 msec: List(Tue Nov 28 15:07:20 EST 2017) Received 1. Took 4 msec: List(Tue Nov 28 15:07:20 EST 2017) Received 2. Took 11 msec: List(Tue Nov 28 15:07:20 EST 2017, Tue Nov 28 15:07:31 EST 2017) Received 3. Took 9 msec: List(Tue Nov 28 15:07:20 EST 2017, Tue Nov 28 15:07:31 EST 2017, Tue Nov 28 15:07:42 EST 2017) Received 1. Took 4 msec: List(Tue Nov 28 15:07:42 EST 2017) Received 1. Took 7 msec: List(Tue Nov 28 15:07:42 EST 2017) Received 1. Took 10 msec: List(Tue Nov 28 15:07:42 EST 2017) Received 1. Took 22 msec: List(Tue Nov 28 15:07:52 EST 2017) ``` This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rabbah commented on issue #3021: Concurrency issue brought in by commit https://github.com/apache/incubator-openwhisk/commit/21d37a1af329544e245d376ad613d1a603fc104c
rabbah commented on issue #3021: Concurrency issue brought in by commit https://github.com/apache/incubator-openwhisk/commit/21d37a1af329544e245d376ad613d1a603fc104c URL: https://github.com/apache/incubator-openwhisk/issues/3021#issuecomment-347739416 Can you clarify and add some details to make this actionable? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] Terry-Shi commented on issue #92: Error when list action
Terry-Shi commented on issue #92: Error when list action URL: https://github.com/apache/incubator-openwhisk-deploy-kube/issues/92#issuecomment-347733238 I suggest use specific version for the docker image in yaml file instead of "latest". I understand "latest" is a easy choice since every time it will pull the new image from registry. but It may cause issue if yaml file and image's version didn't match. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] houshengbo closed pull request #654: WIP: Pin to openwhisk commit 0f679adcf8cf1f29fde8f99c16f66a98e3ec021f
houshengbo closed pull request #654: WIP: Pin to openwhisk commit 0f679adcf8cf1f29fde8f99c16f66a98e3ec021f URL: https://github.com/apache/incubator-openwhisk-wskdeploy/pull/654 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/tools/travis/script.sh b/tools/travis/script.sh index 07aa8aa..d9033e3 100755 --- a/tools/travis/script.sh +++ b/tools/travis/script.sh @@ -12,7 +12,9 @@ HOMEDIR="$(dirname "$TRAVIS_BUILD_DIR")" cd $HOMEDIR # OpenWhisk clone to fixed directory location -git clone --depth 3 https://github.com/apache/incubator-openwhisk.git openwhisk +git clone https://github.com/apache/incubator-openwhisk.git openwhisk +cd openwhisk +git reset --hard 0f679adcf8cf1f29fde8f99c16f66a98e3ec021f # Build script for Travis-CI. WHISKDIR="$HOMEDIR/openwhisk" @@ -20,7 +22,8 @@ WHISKDIR="$HOMEDIR/openwhisk" cd $WHISKDIR ./tools/travis/setup.sh -ANSIBLE_CMD="ansible-playbook -i environments/local -e docker_image_prefix=openwhisk" +ANSIBLE_CMD="ansible-playbook -i environments/local -e docker_image_prefix=testing" +TERM=dumb ./gradlew distDocker -PdockerImagePrefix=testing cd $WHISKDIR/ansible $ANSIBLE_CMD setup.yml This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] houshengbo opened a new issue #3021: Concurrency issue brought in by commit https://github.com/apache/incubator-openwhisk/commit/21d37a1af329544e245d376ad613d1a603fc104c
houshengbo opened a new issue #3021: Concurrency issue brought in by commit https://github.com/apache/incubator-openwhisk/commit/21d37a1af329544e245d376ad613d1a603fc104c URL: https://github.com/apache/incubator-openwhisk/issues/3021 https://github.com/apache/incubator-openwhisk/commit/21d37a1af329544e245d376ad613d1a603fc104c This commit makes openwhisk unstable, including unstable travis build, concurrency issue raised in wskdeploy integration tests. I have no idea about the detailed reason, but this commit makes Travis vulnerable. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] houshengbo commented on issue #651: Concurrency error: Error code: 153: Concurrent modification to resource detected. (code 379)
houshengbo commented on issue #651: Concurrency error: Error code: 153: Concurrent modification to resource detected. (code 379) URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/651#issuecomment-34773 @mrutkows @pritidesai https://github.com/apache/incubator-openwhisk/commit/21d37a1af329544e245d376ad613d1a603fc104c it is the above commit that brings in the concurrency issue. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] houshengbo opened a new pull request #657: Pin to openwhisk commit 21d37a1af329544e245d376ad613d1a603fc104c
houshengbo opened a new pull request #657: Pin to openwhisk commit 21d37a1af329544e245d376ad613d1a603fc104c URL: https://github.com/apache/incubator-openwhisk-wskdeploy/pull/657 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] pritidesai opened a new pull request #655: an attempt to fix concurrency issue by enforcing to run tests in sequence
pritidesai opened a new pull request #655: an attempt to fix concurrency issue by enforcing to run tests in sequence URL: https://github.com/apache/incubator-openwhisk-wskdeploy/pull/655 Closes #651 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] steven-zhangyuan opened a new issue #3020: Docs: mac group_vars folder not exist, document need update
steven-zhangyuan opened a new issue #3020: Docs: mac group_vars folder not exist, document need update URL: https://github.com/apache/incubator-openwhisk/issues/3020 In ./ansible/README.md: These values may be changed by modifying the group_vars for your environment. For example, mac users will find the limits in this file ./environments/mac/group_vars/all: .. Such file is already removed from project and this README.md need update. Maybe delete this part. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] csantanapr commented on issue #3018: remove swift3.0 support
csantanapr commented on issue #3018: remove swift3.0 support URL: https://github.com/apache/incubator-openwhisk/pull/3018#issuecomment-347686782 docker-compose PR https://github.com/apache/incubator-openwhisk-devtools/pull/67 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] houshengbo opened a new pull request #654: Pin to openwhisk commit 0f679adcf8cf1f29fde8f99c16f66a98e3ec021f
houshengbo opened a new pull request #654: Pin to openwhisk commit 0f679adcf8cf1f29fde8f99c16f66a98e3ec021f URL: https://github.com/apache/incubator-openwhisk-wskdeploy/pull/654 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] csantanapr opened a new pull request #67: remove swift:3 support
csantanapr opened a new pull request #67: remove swift:3 support URL: https://github.com/apache/incubator-openwhisk-devtools/pull/67 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] dgrove-oss commented on a change in pull request #95: remove swift:3 support
dgrove-oss commented on a change in pull request #95: remove swift:3 support
URL:
https://github.com/apache/incubator-openwhisk-deploy-kube/pull/95#discussion_r153642979
##
File path: kubernetes/controller/controller.yml
##
@@ -54,7 +54,7 @@ spec:
# This needs to stay up to date with the lates runtime in Ansible
Groupvars
- name: "RUNTIMES_MANIFEST"
- value: '{ "defaultImagePrefix": "openwhisk", "defaultImageTag":
"latest", "runtimes": { "nodejs": [ { "kind": "nodejs", "image": { "name":
"nodejsaction" }, "deprecated": true }, { "kind": "nodejs:6", "default": true,
"image": { "name": "nodejs6action" }, "deprecated": false } ], "python": [ {
"kind": "python", "image": { "name": "python2action" }, "deprecated": false },
{ "kind": "python:2", "default": true, "image": { "name": "python2action" },
"deprecated": false }, { "kind": "python:3", "image": { "name": "python3action"
}, "deprecated": false } ], "swift": [ { "kind": "swift", "image": { "name":
"swiftaction" }, "deprecated": true }, { "kind": "swift:3", "image": { "name":
"swift3action" }, "deprecated": false }, { "kind": "swift:3.1.1", "default":
true, "image": { "name": "action-swift-v3.1.1" }, "deprecated": false } ],
"java": [ { "kind": "java", "default": true, "image": { "name": "java8action"
}, "deprecated": false, "attached": { "attachmentName": "jarfile",
"attachmentType": "application/java-archive" }, "sentinelledLogs": false,
"requireMain": true } ] }, "blackboxes": [ { "name": "dockerskeleton" } ] }'
+ value: '{ "defaultImagePrefix": "openwhisk", "defaultImageTag":
"latest", "runtimes": { "nodejs": [ { "kind": "nodejs", "image": { "name":
"nodejsaction" }, "deprecated": true }, { "kind": "nodejs:6", "default": true,
"image": { "name": "nodejs6action" }, "deprecated": false } ], "python": [ {
"kind": "python", "image": { "name": "python2action" }, "deprecated": false },
{ "kind": "python:2", "default": true, "image": { "name": "python2action" },
"deprecated": false }, { "kind": "python:3", "image": { "name": "python3action"
}, "deprecated": false } ], "swift": [ { "kind": "swift", "image": { "name":
"swiftaction" }, "deprecated": true }, { "kind": "swift:3", "image": { "name":
"swift3action" }, "deprecated": true }, { "kind": "swift:3.1.1", "default":
true, "image": { "name": "action-swift-v3.1.1" }, "deprecated": false } ],
"java": [ { "kind": "java", "default": true, "image": { "name": "java8action"
}, "deprecated": false, "attached": { "attachmentName": "jarfile",
"attachmentType": "application/java-archive" }, "sentinelledLogs": false,
"requireMain": true } ] }, "blackboxes": [ { "name": "dockerskeleton" } ] }'
Review comment:
thanks. I think you need the same change to kubernetes/invoker/invoker.yml
too.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] houshengbo commented on issue #649: Support custom errors that pass in lower-level errors.
houshengbo commented on issue #649: Support custom errors that pass in lower-level errors. URL: https://github.com/apache/incubator-openwhisk-wskdeploy/pull/649#issuecomment-347681635 @mrutkows @pritidesai I believe that perhaps the recent changes to openwhisk core have led to the concurrent issues, since I am using the latest openwhisk to deploy, wskdeploy will randomly raise errors for different cases. Let's find out the last good commit for openwhisk core. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] houshengbo opened a new pull request #653: Pin to openwhisk commit 83982f6687252e793c3e0862e8a23a656f76fc2c
houshengbo opened a new pull request #653: Pin to openwhisk commit 83982f6687252e793c3e0862e8a23a656f76fc2c URL: https://github.com/apache/incubator-openwhisk-wskdeploy/pull/653 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] houshengbo commented on issue #649: Support custom errors that pass in lower-level errors.
houshengbo commented on issue #649: Support custom errors that pass in lower-level errors. URL: https://github.com/apache/incubator-openwhisk-wskdeploy/pull/649#issuecomment-347681635 @mrutkows @pritidesai I believe that either Travis and perhaps the recent changes to openwhisk core have led to the concurrent issues, since I am using the latest openwhisk to deploy, wskdeploy will randomly raise errors for different cases. Let's find out the last good commit for openwhisk core. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mrutkows commented on issue #649: Support custom errors that pass in lower-level errors.
mrutkows commented on issue #649: Support custom errors that pass in lower-level errors. URL: https://github.com/apache/incubator-openwhisk-wskdeploy/pull/649#issuecomment-347671786 @houshengbo @pritidesai opened issue https://github.com/apache/incubator-openwhisk-wskdeploy/issues/651 which showed has different errors on different tests after each restart of Travis. Need to look at the failing tests and grep to see any of their package/action/trigger/rule names are duplicated in other places as a first step. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mrutkows commented on issue #649: Support custom errors that pass in lower-level errors.
mrutkows commented on issue #649: Support custom errors that pass in lower-level errors. URL: https://github.com/apache/incubator-openwhisk-wskdeploy/pull/649#issuecomment-347672174 Need to look at the failing tests and grep to see any of their package/action/trigger/rule names are duplicated in other places as a first step. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mrutkows commented on issue #649: Support custom errors that pass in lower-level errors.
mrutkows commented on issue #649: Support custom errors that pass in lower-level errors. URL: https://github.com/apache/incubator-openwhisk-wskdeploy/pull/649#issuecomment-347671786 @houshengbo @pritidesai opened issue https://github.com/apache/incubator-openwhisk-wskdeploy/issues/651 which showed has different errors on different tests after each restart of Travis. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mrutkows commented on issue #651: Concurrency error: Error code: 153: Concurrent modification to resource detected. (code 379)
mrutkows commented on issue #651: Concurrency error: Error code: 153: Concurrent modification to resource detected. (code 379) URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/651#issuecomment-347680390 another one ``` === RUN TestInvalidActionAnnotations ==> Executing: wskdeploy -m /home/travis/gopath/src/github.com/apache/incubator-openwhisk-wskdeploy/tests/src/integration/validate-action-annotations/manifest.yaml -d /home/travis/gopath/src/github.com/apache/incubator-openwhisk-wskdeploy/tests/src/integration/validate-action-annotations/deployment-with-invalid-annotations.yaml ==> Output: WARNING: The authentication key was retrieved from whisk.properties which will soon be deprecated please do not use it outside of Travis builds. WARNING: The API host was retrieved from whisk.properties which will soon be deprecated please do not use it outside of Travis builds. . ==> Error: wskdeploy.go [125]: [ERROR_COMMAND_FAILED]: Command: [wskdeploy]: Error: deploymentreader.go [241]: [ERROR_YAML_FILE_FORMAT_ERROR]: File: [deployment-with-invalid-annotations.yaml]: ==> Annotation key "action_annotation_5" does not exist in manifest file but specified in deployment file. . --- PASS: TestInvalidActionAnnotations (0.09s) PASS ok github.com/apache/incubator-openwhisk-wskdeploy/tests/src/integration/validate-action-annotations 3.987s ``` This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] csantanapr commented on issue #3018: remove swift3.0 support
csantanapr commented on issue #3018: remove swift3.0 support URL: https://github.com/apache/incubator-openwhisk/pull/3018#issuecomment-347682272 Kube PR here https://github.com/apache/incubator-openwhisk-deploy-kube/pull/95 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] csantanapr commented on a change in pull request #95: remove swift:3 support
csantanapr commented on a change in pull request #95: remove swift:3 support
URL:
https://github.com/apache/incubator-openwhisk-deploy-kube/pull/95#discussion_r153639957
##
File path: kubernetes/controller/controller.yml
##
@@ -54,7 +54,7 @@ spec:
# This needs to stay up to date with the lates runtime in Ansible
Groupvars
- name: "RUNTIMES_MANIFEST"
- value: '{ "defaultImagePrefix": "openwhisk", "defaultImageTag":
"latest", "runtimes": { "nodejs": [ { "kind": "nodejs", "image": { "name":
"nodejsaction" }, "deprecated": true }, { "kind": "nodejs:6", "default": true,
"image": { "name": "nodejs6action" }, "deprecated": false } ], "python": [ {
"kind": "python", "image": { "name": "python2action" }, "deprecated": false },
{ "kind": "python:2", "default": true, "image": { "name": "python2action" },
"deprecated": false }, { "kind": "python:3", "image": { "name": "python3action"
}, "deprecated": false } ], "swift": [ { "kind": "swift", "image": { "name":
"swiftaction" }, "deprecated": true }, { "kind": "swift:3", "image": { "name":
"swift3action" }, "deprecated": false }, { "kind": "swift:3.1.1", "default":
true, "image": { "name": "action-swift-v3.1.1" }, "deprecated": false } ],
"java": [ { "kind": "java", "default": true, "image": { "name": "java8action"
}, "deprecated": false, "attached": { "attachmentName": "jarfile",
"attachmentType": "application/java-archive" }, "sentinelledLogs": false,
"requireMain": true } ] }, "blackboxes": [ { "name": "dockerskeleton" } ] }'
+ value: '{ "defaultImagePrefix": "openwhisk", "defaultImageTag":
"latest", "runtimes": { "nodejs": [ { "kind": "nodejs", "image": { "name":
"nodejsaction" }, "deprecated": true }, { "kind": "nodejs:6", "default": true,
"image": { "name": "nodejs6action" }, "deprecated": false } ], "python": [ {
"kind": "python", "image": { "name": "python2action" }, "deprecated": false },
{ "kind": "python:2", "default": true, "image": { "name": "python2action" },
"deprecated": false }, { "kind": "python:3", "image": { "name": "python3action"
}, "deprecated": false } ], "swift": [ { "kind": "swift", "image": { "name":
"swiftaction" }, "deprecated": true }, { "kind": "swift:3", "image": { "name":
"swift3action" }, "deprecated": true }, { "kind": "swift:3.1.1", "default":
true, "image": { "name": "action-swift-v3.1.1" }, "deprecated": false } ],
"java": [ { "kind": "java", "default": true, "image": { "name": "java8action"
}, "deprecated": false, "attached": { "attachmentName": "jarfile",
"attachmentType": "application/java-archive" }, "sentinelledLogs": false,
"requireMain": true } ] }, "blackboxes": [ { "name": "dockerskeleton" } ] }'
Review comment:
what a mess to diff.
I changed `swift:3` kind to `"deprecated": true`
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] csantanapr opened a new pull request #95: remove swift:3 support
csantanapr opened a new pull request #95: remove swift:3 support URL: https://github.com/apache/incubator-openwhisk-deploy-kube/pull/95 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] houshengbo commented on issue #649: Support custom errors that pass in lower-level errors.
houshengbo commented on issue #649: Support custom errors that pass in lower-level errors. URL: https://github.com/apache/incubator-openwhisk-wskdeploy/pull/649#issuecomment-347681635 @mrutkows @pritidesai I believe that the recent changes to openwhisk core have led to the concurrent issues, since I am using the latest openwhisk to deploy, wskdeploy will randomly raise errors for different cases. Let's find out the last good commit for openwhisk core. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] houshengbo commented on issue #649: Support custom errors that pass in lower-level errors.
houshengbo commented on issue #649: Support custom errors that pass in lower-level errors. URL: https://github.com/apache/incubator-openwhisk-wskdeploy/pull/649#issuecomment-347681635 @mrutkows I believe that the recent changes to openwhisk core have led to the concurrent issues, since I am using the latest openwhisk to deploy, wskdeploy will randomly raise errors for different cases. Let's find out the last good commit for openwhisk core. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] csantanapr commented on issue #3018: remove swift3.0 support
csantanapr commented on issue #3018: remove swift3.0 support URL: https://github.com/apache/incubator-openwhisk/pull/3018#issuecomment-347680856 Related PR from runtime-swift repo https://github.com/apache/incubator-openwhisk-runtime-swift/pull/8 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] csantanapr commented on issue #3018: remove swift3.0 support
csantanapr commented on issue #3018: remove swift3.0 support URL: https://github.com/apache/incubator-openwhisk/pull/3018#issuecomment-347680668 @dgrove-oss I guess same for docker-compose This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mrutkows commented on issue #651: Concurrency error: Error code: 153: Concurrent modification to resource detected. (code 379)
mrutkows commented on issue #651: Concurrency error: Error code: 153: Concurrent modification to resource detected. (code 379) URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/651#issuecomment-347680636 It looks like some tests are repeating in repeated restarts/rebuilds. We should look for name duplication and then see if timing may be an issue. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] csantanapr opened a new pull request #8: remove swift:3 runtime
csantanapr opened a new pull request #8: remove swift:3 runtime URL: https://github.com/apache/incubator-openwhisk-runtime-swift/pull/8 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mrutkows commented on issue #651: Concurrency error: Error code: 153: Concurrent modification to resource detected. (code 379)
mrutkows commented on issue #651: Concurrency error: Error code: 153: Concurrent modification to resource detected. (code 379) URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/651#issuecomment-347680390 another one ``` === RUN TestInvalidActionAnnotations ==> Executing: wskdeploy -m /home/travis/gopath/src/github.com/apache/incubator-openwhisk-wskdeploy/tests/src/integration/validate-action-annotations/manifest.yaml -d /home/travis/gopath/src/github.com/apache/incubator-openwhisk-wskdeploy/tests/src/integration/validate-action-annotations/deployment-with-invalid-annotations.yaml ==> Output: WARNING: The authentication key was retrieved from whisk.properties which will soon be deprecated please do not use it outside of Travis builds. WARNING: The API host was retrieved from whisk.properties which will soon be deprecated please do not use it outside of Travis builds. . ==> Error: wskdeploy.go [125]: [ERROR_COMMAND_FAILED]: Command: [wskdeploy]: Error: deploymentreader.go [241]: [ERROR_YAML_FILE_FORMAT_ERROR]: File: [deployment-with-invalid-annotations.yaml]: ==> Annotation key "action_annotation_5" does not exist in manifest file but specified in deployment file. . --- PASS: TestInvalidActionAnnotations (0.09s) PASS ok github.com/apache/incubator-openwhisk-wskdeploy/tests/src/integration/validate-action-annotations 3.987s ``` This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mrutkows commented on issue #651: Concurrency error: Error code: 153: Concurrent modification to resource detected. (code 379)
mrutkows commented on issue #651: Concurrency error: Error code: 153:
Concurrent modification to resource detected. (code 379)
URL:
https://github.com/apache/incubator-openwhisk-wskdeploy/issues/651#issuecomment-347679613
3rd and 4th attempt:
```
=== RUN TestSupportProjectPathTrailingSlash
==> Executing: wskdeploy -p
/home/travis/gopath/src/github.com/apache/incubator-openwhisk-wskdeploy/tests/src/integration/flagstests/
==> Output: WARNING: The authentication key was retrieved from
whisk.properties which will soon be deprecated please do not use it outside of
Travis builds.
WARNING: The API host was retrieved from whisk.properties which will soon be
deprecated please do not use it outside of Travis builds.
Deployment completed successfully.
.
==> Executing: wskdeploy undeploy -p
/home/travis/gopath/src/github.com/apache/incubator-openwhisk-wskdeploy/tests/src/integration/flagstests/
==> Output: Using
/home/travis/gopath/src/github.com/apache/incubator-openwhisk-wskdeploy/tests/src/integration/flagstests/deployment.yml
for undeployment
WARNING: The authentication key was retrieved from whisk.properties which
will soon be deprecated please do not use it outside of Travis builds.
WARNING: The API host was retrieved from whisk.properties which will soon be
deprecated please do not use it outside of Travis builds.
.
==> Error: wskdeploy.go [125]: [ERROR_COMMAND_FAILED]: Command: [wskdeploy]:
Error: servicedeployer.go [1169]: [ERROR_WHISK_CLIENT_ERROR]: Error code: 153:
Concurrent modification to resource detected. (code 68)
.
--- FAIL: TestSupportProjectPathTrailingSlash (2.57s)
Error Trace:flags_test.go:48
Error: Not equal:
expected: ()
actual:
*utils.CommandError({WskDeployBaseErr:utils.WskDeployBaseErr{ErrorType:"ERROR_COMMAND_FAILED",
FileName:"wskdeploy.go", LineNum:125, Message:"Command: [wskdeploy]: Error:
servicedeployer.go [1169]: [ERROR_WHISK_CLIENT_ERROR]: Error code: 153:
Concurrent modification to resource detected. (code 68)\n"},
Command:"wskdeploy"})
Messages: Failed to undeploy based on the projectpath
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] csantanapr closed pull request #45: WIP: Adding support for path parameters for api gateway
csantanapr closed pull request #45: WIP: Adding support for path parameters for
api gateway
URL: https://github.com/apache/incubator-openwhisk-client-go/pull/45
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/.gitignore b/.gitignore
index b3cb8d53..e2a8d365 100644
--- a/.gitignore
+++ b/.gitignore
@@ -1 +1,2 @@
Godeps/_workspace
+.idea
diff --git a/whisk/api.go b/whisk/api.go
index 4a30118d..6d695a68 100644
--- a/whisk/api.go
+++ b/whisk/api.go
@@ -71,6 +71,33 @@ type Api struct {
GatewayFullPath string`json:"gatewayFullPath,omitempty"`
Swagger string`json:"swagger,omitempty"`
Action *ApiAction `json:"action,omitempty"`
+PathParameters []ApiParameter `json:"pathParameters,omitempty"`
+}
+
+type ApiParameter struct {
+Name string `json:"name"`
+Instring `json:"in"`
+Description string `json:"description,omitempty"`
+Required bool`json:"required,omitempty"`
+Type string `json:"type,omitempty"`
+Formatstring `json:"format,omitempty"`
+AllowEmptyValue bool`json:"allowEmptyValue,omitempty"`
+Items map[string]interface{}`json:"items,omitempty"`
+CollectionFormat string `json:"collectionFormat,omitempty"`
+Default interface{} `json:"default,omitempty"`
+Maximum int `json:"maximum,omitempty"`
+ExclusiveMaximum bool`json:"exclusiveMaximum,omitempty"`
+Minimum int `json:"minimum,omitempty"`
+ExclusiveMinimum bool`json:"exclusiveMinimum,omitempty"`
+MaxLength int `json:"maxLength,omitempty"`
+MinLength int `json:"minLength,omitempty"`
+Pattern string `json:"pattern,omitempty"`
+MaxItems int `json:"maxItems,omitempty"`
+MinItems int `json:"minItems,omitempty"`
+UniqueItems bool`json:"uniqueItems,omitempty"`
+MultipleOfint `json:"multipleOf,omitempty"`
+Enum interface{} `json:"enum,omitempty"`
+Ref string `json:"$ref,omitempty"`
}
type ApiAction struct {
@@ -132,8 +159,9 @@ type ApiSwaggerInfo struct {
}
type ApiSwaggerOperation struct {
-OperationId string`json:"operationId"`
-Responses interface{} `json:"responses"`
+OperationId string `json:"operationId"`
+Parameters []ApiParameter `json:"parameters,omitempty"`
+Responses interface{} `json:"responses"`
XOpenWhisk *ApiSwaggerOpXOpenWhisk `json:"x-openwhisk,omitempty"`
}
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] dgrove-oss commented on issue #3018: remove swift3.0 support
dgrove-oss commented on issue #3018: remove swift3.0 support URL: https://github.com/apache/incubator-openwhisk/pull/3018#issuecomment-347675899 will need a companion in kube-deployment project; RUNTIME_MANIFESTS is replicated into controller.yml and invoker.yml This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] dgrove-oss commented on issue #94: travis changes: use minikube and adjust sleep times
dgrove-oss commented on issue #94: travis changes: use minikube and adjust sleep times URL: https://github.com/apache/incubator-openwhisk-deploy-kube/pull/94#issuecomment-347675235 Reduces travis times from 20-25 minutes down to 9-10 minutes. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mrutkows commented on issue #649: Support custom errors that pass in lower-level errors.
mrutkows commented on issue #649: Support custom errors that pass in lower-level errors. URL: https://github.com/apache/incubator-openwhisk-wskdeploy/pull/649#issuecomment-347672174 Need to look at the failing tests and grep to see any of their package/action/trigger/rule names are duplicated in other places as a first step. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mrutkows commented on issue #649: Support custom errors that pass in lower-level errors.
mrutkows commented on issue #649: Support custom errors that pass in lower-level errors. URL: https://github.com/apache/incubator-openwhisk-wskdeploy/pull/649#issuecomment-347671786 @houshengbo @pritidesai opened issue https://github.com/apache/incubator-openwhisk-wskdeploy/issues/651 which showed has different errors on different tests after each restart of Travis. and after a 3rd restart... the errors moved again... ``` === RUN TestInvalidActionAnnotations ==> Executing: wskdeploy -m /home/travis/gopath/src/github.com/apache/incubator-openwhisk-wskdeploy/tests/src/integration/validate-action-annotations/manifest.yaml -d /home/travis/gopath/src/github.com/apache/incubator-openwhisk-wskdeploy/tests/src/integration/validate-action-annotations/deployment-with-invalid-annotations.yaml ==> Output: WARNING: The authentication key was retrieved from whisk.properties which will soon be deprecated please do not use it outside of Travis builds. WARNING: The API host was retrieved from whisk.properties which will soon be deprecated please do not use it outside of Travis builds. . ==> Error: wskdeploy.go [125]: [ERROR_COMMAND_FAILED]: Command: [wskdeploy]: Error: deploymentreader.go [241]: [ERROR_YAML_FILE_FORMAT_ERROR]: File: [deployment-with-invalid-annotations.yaml]: ==> Annotation key "action_annotation_5" does not exist in manifest file but specified in deployment file. ``` This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mrutkows commented on issue #649: Support custom errors that pass in lower-level errors.
mrutkows commented on issue #649: Support custom errors that pass in lower-level errors. URL: https://github.com/apache/incubator-openwhisk-wskdeploy/pull/649#issuecomment-347671786 opened issue https://github.com/apache/incubator-openwhisk-wskdeploy/issues/651 which showed has different errors on different tests after each restart of Travis. and after a 3rd restart... the errors moved again... ``` === RUN TestInvalidActionAnnotations ==> Executing: wskdeploy -m /home/travis/gopath/src/github.com/apache/incubator-openwhisk-wskdeploy/tests/src/integration/validate-action-annotations/manifest.yaml -d /home/travis/gopath/src/github.com/apache/incubator-openwhisk-wskdeploy/tests/src/integration/validate-action-annotations/deployment-with-invalid-annotations.yaml ==> Output: WARNING: The authentication key was retrieved from whisk.properties which will soon be deprecated please do not use it outside of Travis builds. WARNING: The API host was retrieved from whisk.properties which will soon be deprecated please do not use it outside of Travis builds. . ==> Error: wskdeploy.go [125]: [ERROR_COMMAND_FAILED]: Command: [wskdeploy]: Error: deploymentreader.go [241]: [ERROR_YAML_FILE_FORMAT_ERROR]: File: [deployment-with-invalid-annotations.yaml]: ==> Annotation key "action_annotation_5" does not exist in manifest file but specified in deployment file. ``` This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mrutkows commented on issue #649: Support custom errors that pass in lower-level errors.
mrutkows commented on issue #649: Support custom errors that pass in lower-level errors. URL: https://github.com/apache/incubator-openwhisk-wskdeploy/pull/649#issuecomment-347670982 @houshengbo these errors are not mine... these are concurrency issues (that are happening just today). AND they are moving around between different testcases. As you saw, the PR built fine yesterday; today I just removed 2 comment lines. NO CODE CHANGES This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mdeuser commented on issue #3019: WIP: Trigger activation reduction
mdeuser commented on issue #3019: WIP: Trigger activation reduction URL: https://github.com/apache/incubator-openwhisk/pull/3019#issuecomment-347668679 Early look at controller code for comments. CLI changes are also likely needed. Test updates forthcoming as well.. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mdeuser opened a new pull request #3019: WIP: Trigger activation reduction
mdeuser opened a new pull request #3019: WIP: Trigger activation reduction URL: https://github.com/apache/incubator-openwhisk/pull/3019 - If trigger has at least one corresponding active rule - save activation record - return 202 (Accepted); response body has activation id - If trigger has no corresponding active rule - do not save activation record - return 204 (No Content) response code; no response body See - https://lists.apache.org/thread.html/199c9a75349cc217f2d9731ceea14bc6caa738bde4dc9cb1e3de47c3@%3Cdev.openwhisk.apache.org%3E - https://github.com/apache/incubator-openwhisk/issues/512 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] jessealva commented on issue #45: WIP: Adding support for path parameters for api gateway
jessealva commented on issue #45: WIP: Adding support for path parameters for api gateway URL: https://github.com/apache/incubator-openwhisk-client-go/pull/45#issuecomment-347666847 or maybe @csantanapr This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] jessealva commented on issue #45: WIP: Adding support for path parameters for api gateway
jessealva commented on issue #45: WIP: Adding support for path parameters for api gateway URL: https://github.com/apache/incubator-openwhisk-client-go/pull/45#issuecomment-347666720 @dubeejw Can you look at this so it can get merged? Its blocking my changes in the incubator-openwhisk-cli repo... This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] jessealva commented on issue #45: WIP: Adding support for path parameters for api gateway
jessealva commented on issue #45: WIP: Adding support for path parameters for api gateway URL: https://github.com/apache/incubator-openwhisk-client-go/pull/45#issuecomment-347663320 @mdeuser Any other comments? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mrutkows opened a new issue #652: Test not being run
mrutkows opened a new issue #652: Test not being run URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/652 "tests/dat/manifest_validate_trigger_action_rule_grammar.yaml" is not being run in automation tests Running it manually results in: ``` $ ./wskdeploy -m tests/dat/manifest_validate_trigger_action_rule_grammar.yaml Error: manifestreader.go [255]: [ERROR_FILE_READ_ERROR]: File: [.]: Error: Action first_action has no source code location set. ``` This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] csantanapr opened a new pull request #3018: remove swift3.0 support
csantanapr opened a new pull request #3018: remove swift3.0 support URL: https://github.com/apache/incubator-openwhisk/pull/3018 Closes #2897 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mrutkows commented on issue #651: Concurrency error: Error code: 153: Concurrent modification to resource detected. (code 379)
mrutkows commented on issue #651: Concurrency error: Error code: 153:
Concurrent modification to resource detected. (code 379)
URL:
https://github.com/apache/incubator-openwhisk-wskdeploy/issues/651#issuecomment-347654572
and now on a different test...
```
=== RUN TestSupportProjectPath
==> Executing: wskdeploy -p
/home/travis/gopath/src/github.com/apache/incubator-openwhisk-wskdeploy/tests/src/integration/flagstests
==> Output: WARNING: The authentication key was retrieved from
whisk.properties which will soon be deprecated please do not use it outside of
Travis builds.
WARNING: The API host was retrieved from whisk.properties which will soon be
deprecated please do not use it outside of Travis builds.
Deployment completed successfully.
.
==> Executing: wskdeploy undeploy -p
/home/travis/gopath/src/github.com/apache/incubator-openwhisk-wskdeploy/tests/src/integration/flagstests
==> Output: Using
/home/travis/gopath/src/github.com/apache/incubator-openwhisk-wskdeploy/tests/src/integration/flagstests/deployment.yml
for undeployment
WARNING: The authentication key was retrieved from whisk.properties which
will soon be deprecated please do not use it outside of Travis builds.
WARNING: The API host was retrieved from whisk.properties which will soon be
deprecated please do not use it outside of Travis builds.
.
==> Error: wskdeploy.go [125]: [ERROR_COMMAND_FAILED]: Command: [wskdeploy]:
Error: servicedeployer.go [1169]: [ERROR_WHISK_CLIENT_ERROR]: Error code: 153:
Concurrent modification to resource detected. (code 39)
.
--- FAIL: TestSupportProjectPath (1.86s)
Error Trace:flags_test.go:38
Error: Not equal:
expected: ()
actual:
*utils.CommandError({WskDeployBaseErr:utils.WskDeployBaseErr{ErrorType:"ERROR_COMMAND_FAILED",
FileName:"wskdeploy.go", LineNum:125, Message:"Command: [wskdeploy]: Error:
servicedeployer.go [1169]: [ERROR_WHISK_CLIENT_ERROR]: Error code: 153:
Concurrent modification to resource detected. (code 39)\n"},
Command:"wskdeploy"})
Messages: Failed to undeploy based on the projectpath
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] dgrove-oss opened a new pull request #3017: log exception when ensureTopic fails with unexpected exception
dgrove-oss opened a new pull request #3017: log exception when ensureTopic fails with unexpected exception URL: https://github.com/apache/incubator-openwhisk/pull/3017 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] csantanapr commented on issue #2897: Deprecate swift:3.0 kind, direct users to use swift:3.1.1 kind instead
csantanapr commented on issue #2897: Deprecate swift:3.0 kind, direct users to use swift:3.1.1 kind instead URL: https://github.com/apache/incubator-openwhisk/issues/2897#issuecomment-339399226 >After a period (maybe 4 weeks) update manifest in invoker to mark it deprecated, meaning user can only read, update, and delete actions with swift:3.0 not invoke. Small clarification only can read, update and delete, (it can't be invoke). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] csantanapr closed pull request #63: docker-compose: switch to download cli remote
csantanapr closed pull request #63: docker-compose: switch to download cli
remote
URL: https://github.com/apache/incubator-openwhisk-devtools/pull/63
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/docker-compose/Makefile b/docker-compose/Makefile
index 1f9ca78..7081ab0 100644
--- a/docker-compose/Makefile
+++ b/docker-compose/Makefile
@@ -10,6 +10,9 @@ DOCKER_KERNEL ?= $(shell docker version --format
"{{.Server.KernelVersion}}")
RUNC_BINARY ?= $(shell if [[ $(DOCKER_KERNEL) == *-moby || $(DOCKER_KERNEL)
== *-boot2docker ]]; then (docker run --rm --privileged --pid=host debian
nsenter -t 1 -m -u -n -i sh -c "which runc || which docker-runc"); else (which
runc || which docker-runc); fi)
DOCKER_BINARY ?= $(shell if [[ $(DOCKER_KERNEL) == *-moby || $(DOCKER_KERNEL)
== *-boot2docker ]]; then (docker run --rm --privileged --pid=host debian
nsenter -t 1 -m -u -n -i sh -c "which docker"); else (which docker); fi)
+
+UNAME_STR ?= $(shell uname)
+
ifndef VERBOSE
.SILENT:
endif
@@ -19,7 +22,7 @@ endif
# 2. then it starts all components using docker-compose
# 3. it runs a sample hello-world function
# To stop and cleanup the environment use: make destroy
-quick-start: download build-cli run quick-start-pause hello-world
quick-start-info
+quick-start: download download-cli run quick-start-pause hello-world
quick-start-info
.PHONY: download
download:
@@ -48,10 +51,20 @@ docker:
cd $(PROJECT_HOME) && \
./gradlew distdocker -x :core:swift3Action:distDocker -x
:core:swiftAction:distDocker
-build-cli:
- echo "building the CLI tool ... "
- cd $(PROJECT_HOME) && \
- ./gradlew :tools:cli:distDocker
+download-cli:
+ echo "downloading the CLI tool ... "
+ if [ "$(UNAME_STR)" = "Darwin" ]; then \
+ echo "downloading cli for mac" ; \
+ curl -o $(PROJECT_HOME)/bin/wsk.zip -L
https://github.com/apache/incubator-openwhisk-cli/releases/download/latest/OpenWhisk_CLI-latest-mac-amd64.zip
; \
+ cd $(PROJECT_HOME)/bin ; \
+unzip -o wsk.zip; \
+ elif [ "$(UNAME_STR)" = "Linux" ]; then \
+ echo "downloading cli for linux" ; \
+ curl -o $(PROJECT_HOME)/bin/wsk.tgz -L
https://github.com/apache/incubator-openwhisk-cli/releases/download/latest/OpenWhisk_CLI-latest-linux-amd64.tgz
; \
+ cd $(PROJECT_HOME)/bin ; \
+ tar -xf wsk.tgz ; \
+ fi;
+
.PHONY: run
run: check-required-ports setup start-docker-compose init-couchdb
init-whisk-cli
diff --git a/docker-compose/docker-compose.yml
b/docker-compose/docker-compose.yml
index bad9335..28249de 100644
--- a/docker-compose/docker-compose.yml
+++ b/docker-compose/docker-compose.yml
@@ -12,11 +12,16 @@ services:
# KAFKA SERVICES
zookeeper:
-image: wurstmeister/zookeeper
+image: zookeeper:3.4
ports:
- "2181:2181"
+ - "2888:2888"
+ - "3888:3888"
+environment:
+ ZOO_SERVERS: server.1=0.0.0.0:2888:3888
+ ZOO_MY_ID: 1
kafka:
-image: wurstmeister/kafka
+image: wurstmeister/kafka:0.11.0.1
links:
- zookeeper
depends_on:
@@ -25,17 +30,19 @@ services:
- "9092:9092"
environment:
KAFKA_ZOOKEEPER_CONNECT: zookeeper:2181
+ KAFKA_ADVERTISED_HOST_NAME: kafka
volumes:
- /var/run/docker.sock:/var/run/docker.sock
- ~/tmp/openwhisk/kafka:/kafka:rw
# WHISK CONTROLLER
controller:
-image: openwhisk/controller:latest
+image: openwhisk/controller
command: /bin/sh -c "controller/bin/controller 0 >>
/logs/controller-local_logs.log 2>&1"
links:
- db:db.docker
- kafka:kafka.docker
+ - zookeeper:zookeeper.docker
depends_on:
- db
- kafka
@@ -46,8 +53,8 @@ services:
COMPONENT_NAME: controller
PORT:
- KAFKA_HOST: kafka.docker
- KAFKA_HOST_PORT: 9092
+ KAFKA_HOSTS: kafka.docker:9092
+ ZOOKEEPER_HOSTS: zookeeper.docker:2181
DB_PROVIDER: CouchDB
DB_PROTOCOL: http
@@ -55,6 +62,9 @@ services:
DB_HOST: db.docker
DB_USERNAME: whisk_admin
DB_PASSWORD: some_passw0rd
+ CONFIG_akka_remote_netty_tcp_hostname: controller
+ CONFIG_akka_remote_netty_tcp_port: 2551
+ CONFIG_akka_remote_netty_tcp_bindPort: 2551
LOADBALANCER_HOST: ${DOCKER_COMPOSE_HOST}
LOADBALANCER_HOST_PORT: 443
@@ -62,10 +72,11 @@ services:
- ~/tmp/openwhisk/controller/logs:/logs
ports:
- ":"
+ - "2551:2551"
# WHISK INVOKER AGENT
invoker:
-image: openwhisk/invoker:latest
+image: openwhisk/invoker
command: /bin/sh -c "/invoker/bin/invoker 0 >>
/logs/invoker-local_logs.log 2>&1"
privileged: true
[GitHub] mrutkows opened a new issue #651: Concurrency error: Error code: 153: Concurrent modification to resource detected. (code 379)
mrutkows opened a new issue #651: Concurrency error: Error code: 153:
Concurrent modification to resource detected. (code 379)
URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/651
Travis:
```
==> Executing: wskdeploy undeploy -m
/home/travis/gopath/src/github.com/apache/incubator-openwhisk-wskdeploy/tests/src/integration/validate-manifest-deployment-file-extensions/not-standard-manifest.yaml
-d
/home/travis/gopath/src/github.com/apache/incubator-openwhisk-wskdeploy/tests/src/integration/validate-manifest-deployment-file-extensions/not-standard-deployment.yaml
==> Output: WARNING: The authentication key was retrieved from
whisk.properties which will soon be deprecated please do not use it outside of
Travis builds.
WARNING: The API host was retrieved from whisk.properties which will soon be
deprecated please do not use it outside of Travis builds.
.
==> Error: wskdeploy.go [125]: [ERROR_COMMAND_FAILED]: Command: [wskdeploy]:
Error: servicedeployer.go [1169]: [ERROR_WHISK_CLIENT_ERROR]: Error code: 153:
Concurrent modification to resource detected. (code 379)
.
--- FAIL: TestNonStandardFileNames (0.65s)
Error Trace:validate-file-extensions_test.go:58
Error: Not equal:
expected: ()
actual:
*utils.CommandError({WskDeployBaseErr:utils.WskDeployBaseErr{ErrorType:"ERROR_COMMAND_FAILED",
FileName:"wskdeploy.go", LineNum:125, Message:"Command: [wskdeploy]: Error:
servicedeployer.go [1169]: [ERROR_WHISK_CLIENT_ERROR]: Error code: 153:
Concurrent modification to resource detected. (code 379)\n"},
Command:"wskdeploy"})
Messages: Failed to undeploy based on the manifest and deployment
files with non standard names.
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] houshengbo commented on issue #649: Support custom errors that pass in lower-level errors.
houshengbo commented on issue #649: Support custom errors that pass in lower-level errors. URL: https://github.com/apache/incubator-openwhisk-wskdeploy/pull/649#issuecomment-347638594 @mrutkows Two tests failed in Travis due to "Concurrent modification to resource detected". You probably need to change the entity name in the yaml files for the tests. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] houshengbo opened a new issue #3016: WskRestSequenceTests occasionally failed the test case "execute a sequence in blocking fashion and finish execution even if longer than blocking response
houshengbo opened a new issue #3016: WskRestSequenceTests occasionally failed the test case "execute a sequence in blocking fashion and finish execution even if longer than blocking response timeout" URL: https://github.com/apache/incubator-openwhisk/issues/3016 system.basic.WskRestSequenceTests.Wsk Sequence should execute a sequence in blocking fashion and finish execution even if longer than blocking response timeout org.scalatest.exceptions.TestFailedException: The future returned an exception of type: akka.stream.scaladsl.TcpIdleTimeoutException, with message: TCP idle-timeout encountered on connection to [cusina24.rtp.raleigh.ibm.com:443], no bytes passed in the last 1 minute. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] dgrove-oss opened a new pull request #94: travis changes: use kube 1.7.4 and adjust sleep times
dgrove-oss opened a new pull request #94: travis changes: use kube 1.7.4 and adjust sleep times URL: https://github.com/apache/incubator-openwhisk-deploy-kube/pull/94 1. Upgrade to newer version of kubernetes to 1.7.4 to stay current. 2. Reduce sleep times in health check loops to reduce build latency 3. Increase sleep time after creating nginx config map and secrets to try to reduce frequency of failures when deploying nginx.yml. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] jessealva commented on issue #122: If you specify --kind and --docker, --docker is silently ignored
jessealva commented on issue #122: If you specify --kind and --docker, --docker is silently ignored URL: https://github.com/apache/incubator-openwhisk-cli/issues/122#issuecomment-347609568 So it looks like theres is very little/no validation in the Go around flag combinations. Just looks like theres a specific order in which we set the `kind` for each action. Once the first condition is met, kind is set and we move on to other things This looks like something that we could easily add for this particular issue, but might need more investigation is we wanted to be more complete @csantanapr thinking we could just error out quickly on this issue and then maybe open another issue around looking at validating all the flag combinations? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mrutkows commented on a change in pull request #649: Support custom errors that pass in lower-level errors.
mrutkows commented on a change in pull request #649: Support custom errors that
pass in lower-level errors.
URL:
https://github.com/apache/incubator-openwhisk-wskdeploy/pull/649#discussion_r153565622
##
File path: utils/wskdeployerror_test.go
##
@@ -133,52 +137,62 @@ func TestCustomErrorOutputFormat(t *testing.T) {
TEST_PARAM_TYPE_FLOAT)
actualResult = strings.TrimSpace(err8.Error())
msg8 := fmt.Sprintf("%s [%s]: %s %s: [%s], %s: [%s]",
- PARAMETER, TEST_PARAM_NAME,
- TYPE,
- EXPECTED, TEST_PARAM_TYPE_INT,
- ACTUAL, TEST_PARAM_TYPE_FLOAT)
- expectedResult = fmt.Sprintf("%s [%d]: [%s]: " + FILE + ": [%s]: %s",
+ STR_PARAMETER, TEST_PARAM_NAME,
+ STR_TYPE,
+ STR_EXPECTED, TEST_PARAM_TYPE_INT,
+ STR_ACTUAL, TEST_PARAM_TYPE_FLOAT)
+ expectedResult = fmt.Sprintf("%s [%d]: [%s]: %s: [%s]: %s",
packageName,
err8.LineNum,
ERROR_YAML_PARAMETER_TYPE_MISMATCH,
+ STR_FILE,
filepath.Base(TEST_EXISTANT_MANIFEST_FILE),
msg8 )
- assert.Equal(t, expectedResult, actualResult, "Expected [" +
expectedResult + "] but got [" + actualResult + "]")
+ assert.Equal(t, expectedResult, actualResult)
/*
* InvalidParameterType
*/
err9 := NewInvalidParameterTypeError(TEST_EXISTANT_MANIFEST_FILE,
TEST_PARAM_NAME, TEST_PARAM_TYPE_FOO)
actualResult = strings.TrimSpace(err9.Error())
msg9 := fmt.Sprintf("%s [%s]: %s [%s]",
- PARAMETER, TEST_PARAM_NAME,
- TYPE, TEST_PARAM_TYPE_FOO)
- expectedResult = fmt.Sprintf("%s [%d]: [%s]: " + FILE + ": [%s]: %s",
+ STR_PARAMETER, TEST_PARAM_NAME,
+ STR_TYPE, TEST_PARAM_TYPE_FOO)
+ expectedResult = fmt.Sprintf("%s [%d]: [%s]: " + STR_FILE + ": [%s]:
%s",
packageName,
err9.LineNum,
ERROR_YAML_INVALID_PARAMETER_TYPE,
filepath.Base(TEST_EXISTANT_MANIFEST_FILE),
msg9 )
- assert.Equal(t, expectedResult, actualResult, "Expected [" +
expectedResult + "] but got [" + actualResult + "]")
+ assert.Equal(t, expectedResult, actualResult)
/*
* YAMLParserErr
*/
- var TEST_LINES= []string{"40", LINE_UNKNOWN, "123"}
- var TEST_MESSAGES = []string{"did not find expected key", "did not find
expected ',' or ']'", "found duplicate %YAML directive"}
- err10 := NewYAMLParserErr(TEST_EXISTANT_MANIFEST_FILE, TEST_LINES,
TEST_MESSAGES)
- actualResult = strings.TrimSpace(err10.Error())
-
- msgs := "\n==> Line [40]: did not find expected key" +
- "\n==> Line [Unknown]: did not find expected ',' or ']'" +
- "\n==> Line [123]: found duplicate %YAML directive"
-
- expectedResult = fmt.Sprintf("%s [%d]: [%s]: " + FILE + ": [%s]: %s",
- packageName,
- err10.LineNum,
- ERROR_YAML_PARSER_ERROR,
- filepath.Base(TEST_EXISTANT_MANIFEST_FILE),
- msgs)
- assert.Equal(t, expectedResult, actualResult, "Expected [" +
expectedResult + "] but got [" + actualResult + "]")
+ // TODO add a unit test once we re-factor error related modules into a
new package
Review comment:
This is intentional see referenced issue 650. I do not want to refactor
using this issue.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] bbrowning commented on issue #82: add configuration of Ingress and restructure docs accordingly
bbrowning commented on issue #82: add configuration of Ingress and restructure docs accordingly URL: https://github.com/apache/incubator-openwhisk-deploy-kube/pull/82#issuecomment-347587348 This looks good to me. We do something similar today by creating OpenShift Routes (similar to Ingress but not quite the same) to expose Nginx. We could add our definition here alongside the vanilla Kube and IBM examples, but there are numerous other config and image tweaks we need for OpenShift. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] csantanapr commented on issue #2911: Proposal to to reorganize core/ and root(openwhisk/) folders to reflect existing architecture better
csantanapr commented on issue #2911: Proposal to to reorganize core/ and
root(openwhisk/) folders to reflect existing architecture better
URL:
https://github.com/apache/incubator-openwhisk/issues/2911#issuecomment-347584400
I will prefer we don't do a one off for setup.sh in Travis.
I propose we keep using ansible, this allows for similar integrations and
deployments we have today in different environments.
Blueprint:
1. Move core/routemgmt to cli repo openwhisk-cli/routemgmt/
2. Move ansible/role/routemgmt/[installRouteMgmt.sh, uninstallRouteMgmt] to
cli repo openwhisk-cli/routemgmt/
Adjust scripts based on new location and how they are called from ansible
now (i.e. no need for OPENWHISK HOME
3. Update ansible/group_vars/all with location of routemgmt actions/package
```yaml
routemgt:
url: https://github.com/apache/incubator-openwhisk-cli.git
# Set the local location as the same level as openwhisk home, but it can
be changed.
location: "{{ openwhisk_home }}/../openwhisk-cli-apigw"
version: "HEAD"
repo_update: "no"
```
4. Update ansible/role/routemgmt/deploy.yml to git clone and run install
script
```yaml
- name: download the catalog repository to the catalog location if necessary
git:
repo: "{{ routemgmt.url }}"
dest: "{{ routemgmt.location }}"
update: "{{ routemgmt.repo_update }}"
version: "{{ routemgmt.version }}"
- name: install route management actions
shell: ./installRouteMgmt.sh {{ catalog_auth_key }} {{ api_host }} {{
cli.path }} chdir="{{ routemgmt.location }}/routemgmt"
```
5. Update ansible/role/routemgmt/clean.yml to call uninstall script from
cloned location
```yaml
- name: remove route management actions
shell: ./uninstallRouteMgmt.sh {{ catalog_auth_key }} {{ api_host }} {{
cli.path }} chdir="{{ routemgmt.location }}/routemgmt"
```
6. Refactor deploy.yml and installRouteMgm.sh to not depend on file
whisk.properties, instead pass in to script more arguments with ansible
variables {{apigw_auth_user}} {{apigw_auth_pwd}} {{apigw_host_v2}}
```yaml
- name: install route management actions
shell: ./installRouteMgmt.sh {{ catalog_auth_key }} {{ api_host }} {{
cli.path }} {{apigw_auth_user}} {{apigw_auth_pwd}} {{apigw_host_v2}} chdir="{{
routemgmt.location }}/routemgmt"
```
Doing this will not require any changes to Travis deployment in apigateway
repo, cli repo, or openwhisk repo.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] csantanapr commented on issue #2911: Proposal to to reorganize core/ and root(openwhisk/) folders to reflect existing architecture better
csantanapr commented on issue #2911: Proposal to to reorganize core/ and
root(openwhisk/) folders to reflect existing architecture better
URL:
https://github.com/apache/incubator-openwhisk/issues/2911#issuecomment-347584400
I will prefer we don't do a one off for setup.sh in Travis.
I propose we keep using ansible, this allows for similar integrations and
deployments we have today in different environments.
Blueprint:
1. Move core/routemgmt to cli repo openwhisk-cli/routemgmt/
2. Move ansible/role/routemgmt/[installRouteMgmt.sh, uninstallRouteMgmt] to
cli repo openwhisk-cli/routemgmt/
Adjust scripts based on new location and how they are called from ansible
now (i.e. no need for OPENWHISK HOME
3. Update ansible/group_vars/all with location of routemgmt actions/package
```yaml
routemgt:
url: https://github.com/apache/incubator-openwhisk-cli.git
# Set the local location as the same level as openwhisk home, but it can
be changed.
location: "{{ openwhisk_home }}/../openwhisk-cli-apigw"
version: "HEAD"
repo_update: "no"
```
4. Update ansible/role/routemgmt/deploy.yml to git clone and run install
script
```yaml
- name: download the catalog repository to the catalog location if necessary
git:
repo: "{{ routemgmt.url }}"
dest: "{{ routemgmt.location }}"
update: "{{ routemgmt.repo_update }}"
version: "{{ routemgmt.version }}"
- name: install route management actions
shell: ./installRouteMgmt.sh {{ catalog_auth_key }} {{ api_host }} {{
cli.path }} chdir="{{ routemgmt.location }}/routemgmt"
```
5. Update ansible/role/routemgmt/clean.yml to call uninstall script from
cloned location
```
- name: remove route management actions
shell: ./uninstallRouteMgmt.sh {{ catalog_auth_key }} {{ api_host }} {{
cli.path }} chdir="{{ routemgmt.location }}/routemgmt"
```
6. Refactor deploy.yml and installRouteMgm.sh to not depend on file
whisk.properties, instead pass in to script more arguments with ansible
variables {{apigw_auth_user}} {{apigw_auth_pwd}} {{apigw_host_v2}}
```
- name: install route management actions
shell: ./installRouteMgmt.sh {{ catalog_auth_key }} {{ api_host }} {{
cli.path }} {{apigw_auth_user}} {{apigw_auth_pwd}} {{apigw_host_v2}} chdir="{{
routemgmt.location }}/routemgmt"
```
Doing this will not require any changes to Travis deployment in apigateway
repo, cli repo, or openwhisk repo.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] dgrove-oss commented on issue #82: add configuration of Ingress and restructure docs accordingly
dgrove-oss commented on issue #82: add configuration of Ingress and restructure docs accordingly URL: https://github.com/apache/incubator-openwhisk-deploy-kube/pull/82#issuecomment-347567671 rebased to latest master. @bbrowning @DanLavine, any comments before I ask @rabbah to review and merge? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] dgrove-oss commented on issue #2991: controller creates health and cacheInvalidation topics
dgrove-oss commented on issue #2991: controller creates health and cacheInvalidation topics URL: https://github.com/apache/incubator-openwhisk/pull/2991#issuecomment-347558761 correction. missed a piece of the kafka cluster change to carry through replication factor. fixing. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] cbickel commented on a change in pull request #2810: Add couchdb clustering
cbickel commented on a change in pull request #2810: Add couchdb clustering
URL:
https://github.com/apache/incubator-openwhisk/pull/2810#discussion_r153528486
##
File path: tests/src/test/scala/ha/ShootComponentsTests.scala
##
@@ -63,18 +60,61 @@ class ShootComponentsTests extends FlatSpec with Matchers
with WskTestHelpers wi
val controller0DockerHost = WhiskProperties.getBaseControllerHost() + ":" +
WhiskProperties.getProperty(
WhiskConfig.dockerPort)
- def restartComponent(host: String, component: String) = {
+ val couchDB0DockerHost = WhiskProperties.getBaseDBHost() + ":" +
WhiskProperties.getProperty(
+WhiskConfig.dockerPort)
+
+ val dbProtocol = WhiskProperties.getProperty(WhiskConfig.dbProtocol)
+ val dbHostsList = WhiskProperties.getProperty(WhiskConfig.dbHostsList)
+ val dbPort = WhiskProperties.getProperty(WhiskConfig.dbPort)
+ val dbUsername = WhiskProperties.getProperty(WhiskConfig.dbUsername)
+ val dbPassword = WhiskProperties.getProperty(WhiskConfig.dbPassword)
+ val dbPrefix = WhiskProperties.getProperty(WhiskConfig.dbPrefix)
+ val dbWhiskAuth = WhiskProperties.getProperty(WhiskConfig.dbAuths)
+
+ private def getDockerCommand(host: String, component: String, cmd: String) =
{
def file(path: String) = Try(new
File(path)).filter(_.exists).map(_.getAbsolutePath).toOption
+
val docker = (file("/usr/bin/docker") orElse
file("/usr/local/bin/docker")).getOrElse("docker")
-val cmd = Seq(docker, "--host", host, "restart", component)
+Seq(docker, "--host", host, cmd, component)
+ }
+
+ def restartComponent(host: String, component: String) = {
+val cmd: Seq[String] = getDockerCommand(host, component, "restart")
+println(s"Running command: ${cmd.mkString(" ")}")
+
+TestUtils.runCmd(0, new File("."), cmd: _*)
+ }
+
+ def stopComponent(host: String, component: String) = {
+val cmd: Seq[String] = getDockerCommand(host, component, "stop")
+println(s"Running command: ${cmd.mkString(" ")}")
+
+TestUtils.runCmd(0, new File("."), cmd: _*)
+ }
+
+
+ def startComponent(host: String, component: String) = {
+val cmd: Seq[String] = getDockerCommand(host, component, "start")
println(s"Running command: ${cmd.mkString(" ")}")
TestUtils.runCmd(0, new File("."), cmd: _*)
}
def ping(host: String, port: Int) = {
-val response = Try { Http().singleRequest(HttpRequest(uri =
s"http://$host:$port/ping;)).futureValue }.toOption
+val response = Try {
+ Http().singleRequest(HttpRequest(uri =
s"http://$host:$port/ping;)).futureValue
+}.toOption
+
+response.map { res =>
+ (res.status, Unmarshal(res).to[String].futureValue)
+}
+ }
+
+ def pingDB(host: String, port: Int) = {
Review comment:
what do you think about using one ping method and passing the `path` as an
argument.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] cbickel commented on a change in pull request #2810: Add couchdb clustering
cbickel commented on a change in pull request #2810: Add couchdb clustering
URL:
https://github.com/apache/incubator-openwhisk/pull/2810#discussion_r153527393
##
File path: ansible/templates/whisk.properties.j2
##
@@ -94,6 +94,8 @@ db.whisk.activations={{ db.whisk.activations }}
db.whisk.actions.ddoc={{ db.whisk.actions_ddoc }}
db.whisk.activations.ddoc={{ db.whisk.activations_ddoc }}
db.whisk.activations.filter.ddoc={{ db.whisk.activations_filter_ddoc }}
+db.hosts={{ groups["db"] | map('extract', hostvars, 'ansible_host') | list |
join(",") }}
Review comment:
what about renaming this value to `db.hostsList` as well? In the following
code you always use dbHostsList.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] dgrove-oss commented on issue #2991: controller creates health and cacheInvalidation topics
dgrove-oss commented on issue #2991: controller creates health and cacheInvalidation topics URL: https://github.com/apache/incubator-openwhisk/pull/2991#issuecomment-347558761 correction. missed a piece of the kafka cluster change to carry through replication factor. Not ready for review. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] dgrove-oss commented on issue #2991: controller creates health and cacheInvalidation topics
dgrove-oss commented on issue #2991: controller creates health and cacheInvalidation topics URL: https://github.com/apache/incubator-openwhisk/pull/2991#issuecomment-347558156 rebased to resolve merge conflicts. Ready for review. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] dubeejw commented on issue #2832: Do not cache invalidate when adding a DB attachment
dubeejw commented on issue #2832: Do not cache invalidate when adding a DB attachment URL: https://github.com/apache/incubator-openwhisk/pull/2832#issuecomment-347556547 PG3 1406 ? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rabbah closed pull request #93: mirror PR 3010 "adapt timeouts of controller and nginx"
rabbah closed pull request #93: mirror PR 3010 "adapt timeouts of controller
and nginx"
URL: https://github.com/apache/incubator-openwhisk-deploy-kube/pull/93
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/kubernetes/controller/controller.yml
b/kubernetes/controller/controller.yml
index a696a70..4038f4c 100644
--- a/kubernetes/controller/controller.yml
+++ b/kubernetes/controller/controller.yml
@@ -68,10 +68,8 @@ spec:
value: "-Xmx2g"
# Kafka properties
-- name: "KAFKA_HOST"
- value: "kafka.openwhisk"
-- name: "KAFKA_HOST_PORT"
- value: "9092"
+- name: "KAFKA_HOSTS"
+ value: "kafka.openwhisk:9092"
# specific controller arguments
- name: "CONTROLLER_INSTANCES"
diff --git a/kubernetes/invoker/invoker.yml b/kubernetes/invoker/invoker.yml
index e79be7b..57d1c38 100644
--- a/kubernetes/invoker/invoker.yml
+++ b/kubernetes/invoker/invoker.yml
@@ -85,16 +85,12 @@ spec:
value: ""
# Kafka properties
- - name: "KAFKA_HOST"
-value: "kafka.openwhisk"
- - name: "KAFKA_HOST_PORT"
-value: "9092"
+ - name: "KAFKA_HOSTS"
+value: "kafka.openwhisk:9092"
# zookeeper info
- - name: "ZOOKEEPER_HOST"
-value: "zookeeper.openwhisk"
- - name: "ZOOKEEPER_PORT"
-value: "2181"
+ - name: "ZOOKEEPER_HOSTS"
+value: "zookeeper.openwhisk:2181"
# This property can change since it is generated via Ansible
GroupVars
- name: "RUNTIMES_MANIFEST"
diff --git a/kubernetes/nginx/nginx.conf b/kubernetes/nginx/nginx.conf
index 1f586fa..c32a432 100644
--- a/kubernetes/nginx/nginx.conf
+++ b/kubernetes/nginx/nginx.conf
@@ -40,7 +40,7 @@ http {
rewrite/(.*) /api/v1/web/${namespace}/$1 break;
}
proxy_pass http://$controller:8080;
-proxy_read_timeout 70s; # 60+10 additional seconds to allow
controller to terminate request
+proxy_read_timeout 75s; # 70+5 additional seconds to allow
controller to terminate request
}
# proxy to 'public/html' web action by convention
@@ -49,7 +49,7 @@ http {
rewrite^ /api/v1/web/${namespace}/public/index.html break;
}
proxy_pass http://$controller:8080;
-proxy_read_timeout 70s; # 60+10 additional seconds to allow
controller to terminate request
+proxy_read_timeout 75s; # 70+5 additional seconds to allow
controller to terminate request
}
location /blackbox-0.1.0.tar.gz {
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] dubeejw commented on issue #2832: Do not cache invalidate when adding a DB attachment
dubeejw commented on issue #2832: Do not cache invalidate when adding a DB attachment URL: https://github.com/apache/incubator-openwhisk/pull/2832#issuecomment-347548497 @rabbah, made updates based on your comments. Can you take another look? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] dgrove-oss commented on issue #93: mirror PR 3010 "adapt timeouts of controller and nginx"
dgrove-oss commented on issue #93: mirror PR 3010 "adapt timeouts of controller and nginx" URL: https://github.com/apache/incubator-openwhisk-deploy-kube/pull/93#issuecomment-347541798 timeout waiting for nginx pod to deploy again. @rabbah can you kick travis to try again. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] jonpspri opened a new pull request #171: Add s390x architecture; better build loop control.
jonpspri opened a new pull request #171: Add s390x architecture; better build loop control. URL: https://github.com/apache/incubator-openwhisk-cli/pull/171 As part of preparing OpenWhisk builds for multi-architecture deployment, it's necessary to cross-compile the 'wsk' binary for target architectures. This adds a cross-compile for s390x architecture. I've tested that the cross-compile works appropriately from a command-line build; I'm working through the remote deployment approach here. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] dgrove-oss closed pull request #2981: bump kafka broker version to 0.11.0.1
dgrove-oss closed pull request #2981: bump kafka broker version to 0.11.0.1
URL: https://github.com/apache/incubator-openwhisk/pull/2981
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/ansible/group_vars/all b/ansible/group_vars/all
index 6ed6a86c99..5518dc0d86 100644
--- a/ansible/group_vars/all
+++ b/ansible/group_vars/all
@@ -129,7 +129,7 @@ registry:
confdir: "{{ config_root_dir }}/registry"
kafka:
- version: 0.10.2.1
+ version: 0.11.0.1
port: 9092
ras:
port: 9093
diff --git a/ansible/roles/kafka/tasks/deploy.yml
b/ansible/roles/kafka/tasks/deploy.yml
index f410cc3502..a8939f9e6a 100644
--- a/ansible/roles/kafka/tasks/deploy.yml
+++ b/ansible/roles/kafka/tasks/deploy.yml
@@ -23,15 +23,15 @@
retries: 36
delay: 5
-- name: "pull the ches/kafka:{{ kafka.version }} image"
- shell: "docker pull ches/kafka:{{ kafka.version }}"
+- name: "pull the wurstmeister/kafka:{{ kafka.version }} image"
+ shell: "docker pull wurstmeister/kafka:{{ kafka.version }}"
retries: "{{ docker.pull.retries }}"
delay: "{{ docker.pull.delay }}"
- name: (re)start kafka
docker_container:
name: kafka
-image: ches/kafka:{{ kafka.version }}
+image: wurstmeister/kafka:{{ kafka.version }}
state: started
recreate: true
restart_policy: "{{ docker.restart.policy }}"
@@ -40,6 +40,8 @@
env:
"KAFKA_ADVERTISED_HOST_NAME": "{{ ansible_host }}"
"KAFKA_HEAP_OPTS": "-Xmx{{ kafka.heap }} -Xms{{ kafka.heap }}"
+ "KAFKA_ZOOKEEPER_CONNECT": "{{ ansible_host }}:{{zookeeper.port}}"
+ "KAFKA_BROKER_ID": "0"
ports:
- "{{ kafka.port }}:9092"
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] dgrove-oss commented on issue #2981: bump kafka broker version to 0.11.0.1
dgrove-oss commented on issue #2981: bump kafka broker version to 0.11.0.1 URL: https://github.com/apache/incubator-openwhisk/pull/2981#issuecomment-347529911 Redundant with #2744. Closing. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rabbah commented on issue #3015: [Feature request] Hide codes or parameters from shared package
rabbah commented on issue #3015: [Feature request] Hide codes or parameters from shared package URL: https://github.com/apache/incubator-openwhisk/issues/3015#issuecomment-347522761 I propose to close this issue as a duplicate of https://github.com/apache/incubator-openwhisk/issues/2155. The log issue is a bigger deal than hijacking parameters (for which we have a mechanism to protect values with `final`) and we should think of the implications carefully. In general, I think what you gain from having an execute only action is convenience for composition. Otherwise, it's just an API and there are other mechanisms for API discovery that we can be applied. That said, more fine grain entitlement is something that's been discussed before so it's worth keeping the discussion up. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] dgrove-oss opened a new pull request #93: mirror PR 3010 "adapt timeouts of controller and nginx"
dgrove-oss opened a new pull request #93: mirror PR 3010 "adapt timeouts of controller and nginx" URL: https://github.com/apache/incubator-openwhisk-deploy-kube/pull/93 mirror change to kube copy of nginix.conf from OW PR 3010. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] style95 commented on issue #3015: [Feature request] Hide codes or parameters from shared package
style95 commented on issue #3015: [Feature request] Hide codes or parameters from shared package URL: https://github.com/apache/incubator-openwhisk/issues/3015#issuecomment-347486112 If "pays" means cost for activation(invoking the action), I think it is reasonable that belongs to caller. Activation for bound action will go to binding namespace. So it might be enough. And sharing package is great and consistent way to distribute the features. User can navigate all shared packages and just bind desired one and use it in his namespace. (Though currently it is not possible to navigate all shared packages via OW API.) I just want to follow this whole process. So exposing a web action may not be appropriate for this case.(I should manually let them know the url for my web action) I just naively thought, it would be great if there are flags for `hiding codes` or `hiding parameters` when I share my package. Regarding information exposed in log, I think it is quite similar to the one in default parameters. Someone who shares his package should take care for that risk. Also sometime, caller want to see what happens. Specifically, if he can't see the internals and got error response, highly likely he will want to look into the logs. So I think it might be enough to have options for hiding codes only. Since storing codes as attachment is in progress, we may just filter out codes from the response. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] jeremiaswerner closed pull request #2744: Deploy kafka & zookeeper cluster with ansible
jeremiaswerner closed pull request #2744: Deploy kafka & zookeeper cluster with
ansible
URL: https://github.com/apache/incubator-openwhisk/pull/2744
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/ansible/environments/distributed/hosts
b/ansible/environments/distributed/hosts
index 0880e6d77c..9c9045b01e 100755
--- a/ansible/environments/distributed/hosts
+++ b/ansible/environments/distributed/hosts
@@ -18,9 +18,12 @@ edge
[controllers]
10.3.2.155 ansible_host=10.3.2.155
-[kafka]
+[kafkas]
10.3.2.156 ansible_host=10.3.2.156
+[zookeepers:children]
+kafkas
+
[invokers]
10.3.2.158 ansible_host=10.3.2.158
10.3.2.159 ansible_host=10.3.2.159
diff --git a/ansible/environments/docker-machine/hosts.j2.ini
b/ansible/environments/docker-machine/hosts.j2.ini
index 4301576768..a4990ae359 100644
--- a/ansible/environments/docker-machine/hosts.j2.ini
+++ b/ansible/environments/docker-machine/hosts.j2.ini
@@ -10,9 +10,12 @@ ansible ansible_connection=local
controller0 ansible_host={{ docker_machine_ip }}
controller1 ansible_host={{ docker_machine_ip }}
-[kafka]
+[kafkas]
{{ docker_machine_ip }} ansible_host={{ docker_machine_ip }}
+[zookeepers:children]
+kafkas
+
[invokers]
invoker0ansible_host={{ docker_machine_ip }}
invoker1ansible_host={{ docker_machine_ip }}
diff --git a/ansible/environments/local/group_vars/all
b/ansible/environments/local/group_vars/all
index 3860f33a2a..c3b3c12160 100755
--- a/ansible/environments/local/group_vars/all
+++ b/ansible/environments/local/group_vars/all
@@ -23,3 +23,12 @@ controller_arguments: '-Dcom.sun.management.jmxremote
-Dcom.sun.management.jmxre
invoker_arguments: "{{ controller_arguments }}"
invoker_allow_multiple_instances: true
+
+# Set kafka topic retention
+kafka_heap: '512m'
+kafka_topics_completed_retentionBytes: 104857600
+kafka_topics_completed_retentionMS: 30
+kafka_topics_health_retentionBytes: 104857600
+kafka_topics_health_retentionMS: 30
+kafka_topics_invoker_retentionBytes: 104857600
+kafka_topics_invoker_retentionMS: 30
diff --git a/ansible/environments/local/hosts b/ansible/environments/local/hosts
index 00702f397d..516340861a 100644
--- a/ansible/environments/local/hosts
+++ b/ansible/environments/local/hosts
@@ -10,8 +10,12 @@ ansible ansible_connection=local
controller0 ansible_host=172.17.0.1 ansible_connection=local
controller1 ansible_host=172.17.0.1 ansible_connection=local
-[kafka]
-172.17.0.1 ansible_host=172.17.0.1 ansible_connection=local
+[kafkas]
+kafka0 ansible_host=172.17.0.1 ansible_connection=local
+kafka1 ansible_host=172.17.0.1 ansible_connection=local
+
+[zookeepers:children]
+kafkas
[invokers]
invoker0ansible_host=172.17.0.1 ansible_connection=local
diff --git a/ansible/group_vars/all b/ansible/group_vars/all
index 02c2b08ad1..f1a746d5b1 100644
--- a/ansible/group_vars/all
+++ b/ansible/group_vars/all
@@ -129,33 +129,46 @@ registry:
confdir: "{{ config_root_dir }}/registry"
kafka:
- version: 0.10.2.1
+ version: 0.11.0.1
port: 9092
ras:
-port: 9093
+port: 8093
heap: "{{ kafka_heap | default('1g') }}"
+ replicationFactor: "{{ kafka_replicationFactor |
default((groups['kafkas']|length)|int) }}"
topics:
completed:
segmentBytes: 536870912
retentionBytes: "{{ kafka_topics_completed_retentionBytes |
default(1073741824) }}"
- retentionMS: 360
+ retentionMS: "{{ kafka_topics_completed_retentionMS | default(360)
}}"
health:
segmentBytes: 536870912
retentionBytes: "{{ kafka_topics_health_retentionBytes |
default(1073741824) }}"
- retentionMS: 360
+ retentionMS: "{{ kafka_topics_health_retentionMS | default(360) }}"
invoker:
segmentBytes: 536870912
retentionBytes: "{{ kafka_topics_invoker_retentionBytes |
default(1073741824) }}"
- retentionMS: 17280
+ retentionMS: "{{ kafka_topics_invoker_retentionMS | default(17280)
}}"
cacheInvalidation:
segmentBytes: 536870912
- retentionBytes: 1073741824
- retentionMS: 30
+ retentionBytes: "{{ kafka_topics_cacheInvalidation_retentionBytes |
default(1073741824) }}"
+ retentionMS: "{{ kafka_topics_cacheInvalidation_retentionMS |
default(30) }}"
+
+kafka_connect_string: "{% set ret = [] %}\
+ {% for host in groups['kafkas'] %}\
+ {{ ret.append( hostvars[host].ansible_host + ':' +
((kafka.port+loop.index-1)|string) ) }}\
+ {% endfor %}\
+ {{ ret | join(',') }}"
[GitHub] rabbah commented on issue #92: Error when list action
rabbah commented on issue #92: Error when list action URL: https://github.com/apache/incubator-openwhisk-deploy-kube/issues/92#issuecomment-347474734 I merged https://github.com/apache/incubator-openwhisk-deploy-kube/pull/91 which should fix this. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rabbah closed pull request #91: update for pureconfig (OpenWhisk PR 2576)
rabbah closed pull request #91: update for pureconfig (OpenWhisk PR 2576)
URL: https://github.com/apache/incubator-openwhisk-deploy-kube/pull/91
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/kubernetes/controller/controller.yml
b/kubernetes/controller/controller.yml
index 7e5e1b3..a696a70 100644
--- a/kubernetes/controller/controller.yml
+++ b/kubernetes/controller/controller.yml
@@ -36,7 +36,7 @@ spec:
- name: controller
imagePullPolicy: Always
image: openwhisk/controller
-command: ["/bin/bash", "-c", "COMPONENT_NAME=$(hostname | cut -d'-'
-f2) /controller/bin/controller `hostname | cut -d'-' -f2`"]
+command: ["/bin/bash", "-c", "COMPONENT_NAME=$(hostname | cut -d'-'
-f2) /init.sh `hostname | cut -d'-' -f2`"]
ports:
- name: controller
containerPort: 8080
@@ -52,10 +52,6 @@ spec:
- name: "PORT"
value: "8080"
-# Loadbalancer options
-- name: "LOADBALANCER_INVOKERBUSYTHRESHOLD"
- value: "16"
-
# This needs to stay up to date with the lates runtime in Ansible
Groupvars
- name: "RUNTIMES_MANIFEST"
value: '{ "defaultImagePrefix": "openwhisk", "defaultImageTag":
"latest", "runtimes": { "nodejs": [ { "kind": "nodejs", "image": { "name":
"nodejsaction" }, "deprecated": true }, { "kind": "nodejs:6", "default": true,
"image": { "name": "nodejs6action" }, "deprecated": false } ], "python": [ {
"kind": "python", "image": { "name": "python2action" }, "deprecated": false },
{ "kind": "python:2", "default": true, "image": { "name": "python2action" },
"deprecated": false }, { "kind": "python:3", "image": { "name": "python3action"
}, "deprecated": false } ], "swift": [ { "kind": "swift", "image": { "name":
"swiftaction" }, "deprecated": true }, { "kind": "swift:3", "image": { "name":
"swift3action" }, "deprecated": false }, { "kind": "swift:3.1.1", "default":
true, "image": { "name": "action-swift-v3.1.1" }, "deprecated": false } ],
"java": [ { "kind": "java", "default": true, "image": { "name": "java8action"
}, "deprecated": false, "attached": { "attachmentName": "jarfile",
"attachmentType": "application/java-archive" }, "sentinelledLogs": false,
"requireMain": true } ] }, "blackboxes": [ { "name": "dockerskeleton" } ] }'
@@ -102,15 +98,13 @@ spec:
value: "5000"
- name: "LIMITS_ACTIONS_INVOKES_CONCURRENT"
value: "30"
-- name: "CONTROLLER_BLACKBOXFRACTION"
- value: "0.10"
- name: "CONTROLLER_LOCALBOOKKEEPING"
value: "FALSE"
- name: "CONTROLLER_HA"
value: "TRUE"
- name: "AKKA_CLUSTER_SEED_NODES"
value: "controller-0.controller.openwhisk
controller-1.controller.openwhisk"
-- name: "AKKA_ACTOR_PROVIDER"
+- name: "CONFIG_akka_actor_provider"
value: "cluster"
# properties for DB connection
@@ -130,6 +124,8 @@ spec:
value: "whisks"
- name: "DB_WHISK_ACTIVATIONS_DDOC"
value: "whisks"
+- name: "DB_WHISK_ACTIVATIONS_FILTER_DDOC"
+ value: "whisks-filters.v2"
- name: "DB_WHISK_ACTIVATIONS"
value: "test_activations"
- name: "DB_WHISK_ACTIONS"
diff --git a/kubernetes/invoker/invoker.yml b/kubernetes/invoker/invoker.yml
index 3e63b70..e79be7b 100644
--- a/kubernetes/invoker/invoker.yml
+++ b/kubernetes/invoker/invoker.yml
@@ -37,7 +37,7 @@ spec:
- name: invoker
imagePullPolicy: Always
image: openwhisk/invoker
-command: [ "/bin/bash", "-c", "COMPONENT_NAME=$(hostname | cut -d'-'
-f2) /invoker/bin/invoker `hostname | cut -d'-' -f2`" ]
+command: [ "/bin/bash", "-c", "COMPONENT_NAME=$(hostname | cut -d'-'
-f2) /init.sh `hostname | cut -d'-' -f2`" ]
env:
- name: "PORT"
value: "8080"
@@ -125,6 +125,8 @@ spec:
value: "whisks"
- name: "DB_WHISK_ACTIVATIONS_DDOC"
value: "whisks"
+ - name: "DB_WHISK_ACTIVATIONS_FILTER_DDOC"
+value: "whisks-filters.v2"
- name: "DB_WHISK_ACTIVATIONS"
value: "test_activations"
- name: "DB_WHISK_ACTIONS"
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] Terry-Shi opened a new issue #92: Error when list action
Terry-Shi opened a new issue #92: Error when list action URL: https://github.com/apache/incubator-openwhisk-deploy-kube/issues/92 after I setup the OpenWhisk in Kubernetes, I got below error message: $wsk action list --insecure error: Unable to obtain the list of actions for namespace 'default': There was an internal server error. (code 7) I check the log of controller, I got this: [2017-11-28T07:32:48.415Z] [INFO] [#tid_16478] GET /api/v1/namespaces/_/actions limit=30=0 [2017-11-28T07:32:48.415Z] [INFO] [#tid_16478] [RestAPIVersion] authenticate: 23bc46b1-71f6-4ed5-8c54-816aa4f8c502 [2017-11-28T07:32:48.415Z] [INFO] [#tid_16478] [Identity] [GET] serving from cache: CacheKey(23bc46b1-71f6-4ed5-8c54-816aa4f8c502) [marker:database_cacheHit_count:1] [2017-11-28T07:32:48.415Z] [INFO] [#tid_16478] [RestAPIVersion] authentication valid [2017-11-28T07:32:48.416Z] [INFO] [#tid_16478] [LocalEntitlementProvider] checking user 'guest' has privilege 'READ' for 'actions/guest' [2017-11-28T07:32:48.416Z] [INFO] [#tid_16478] [ActivationThrottler] concurrent activations in system = 0, below limit = 5000 [2017-11-28T07:32:48.416Z] [INFO] [#tid_16478] [LocalEntitlementProvider] authorized [2017-11-28T07:32:48.416Z] [INFO] [#tid_16478] [ActionsApi] [LIST] exclude private entities: required == false [2017-11-28T07:32:48.417Z] [INFO] [#tid_16478] [CouchDbRestStore] [QUERY] 'test_whisks' searching 'whisks/actions [marker:database_queryView_start:2] [2017-11-28T07:32:48.420Z] [ERROR] [#tid_16478] [CouchDbRestStore] Unexpected http response code: 404 Not Found [marker:database_queryView_error:6:3] [2017-11-28T07:32:48.420Z] [ERROR] [#tid_16478] [CouchDbRestStore] [QUERY] 'test_whisks' internal error, failure: 'Unexpected http response code: 404 Not Found' [marker:database_queryView_error:6:3] [2017-11-28T07:32:48.420Z] [ERROR] [#tid_16478] [ActionsApi] [LIST] entity failed: Unexpected http response code: 404 Not Found [2017-11-28T07:32:48.421Z] [INFO] [#tid_16478] [BasicHttpService] [marker:http_get.500_count:7:7] is there any data missing in couchDB ? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rabbah commented on issue #3015: [Feature request] Hide codes or parameters from shared package
rabbah commented on issue #3015: [Feature request] Hide codes or parameters from shared package URL: https://github.com/apache/incubator-openwhisk/issues/3015#issuecomment-347473383 I don?t understand the question. Today the caller namespace owns the activation record for any action invoked via the POST API. And the owning namespace owns the activation for a web action. When you?re granting execute only writes it?s like a web action except in this case it is also desirable to defer the activation cost to the caller. So we could implement it this way, for example. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rabbah commented on issue #3015: [Feature request] Hide codes or parameters from shared package
rabbah commented on issue #3015: [Feature request] Hide codes or parameters from shared package URL: https://github.com/apache/incubator-openwhisk/issues/3015#issuecomment-347468870 You?d need to be careful not to log anything that would leak details (eg better not log parameters) so in general the entitlement has to extend to the activation record to restrict log access. Another indirect point related to the activation record is that the caller ?pays?. An option could be using an authenticated web action with the activation owned by the caller (but not logs). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rabbah commented on issue #3015: [Feature request] Hide codes or parameters from shared package
rabbah commented on issue #3015: [Feature request] Hide codes or parameters from shared package URL: https://github.com/apache/incubator-openwhisk/issues/3015#issuecomment-347468870 You?d need to be careful not to log anything that would leak details (eg better not log parameters) so in general the entitlement has to extend to the activation record to restrict log access. Another indirect point related to the activation record is that the caller ?pays?. An option could be using an authenticated web action with the activation owned by the caller. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rabbah commented on issue #3015: [Feature request] Hide codes or parameters from shared package
rabbah commented on issue #3015: [Feature request] Hide codes or parameters from shared package URL: https://github.com/apache/incubator-openwhisk/issues/3015#issuecomment-347468870 You?d need to be careful not to log anything that would leak details (eg better not log parameters) so in general the entitlement has to extend to the activation record to restrict log access. Another indirect point related to the activation record is that the caller ?pays?. An option would be using an authenticated web action with the activation owned by the caller. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] style95 commented on issue #3015: [Feature request] Hide codes or parameters from shared package
style95 commented on issue #3015: [Feature request] Hide codes or parameters from shared package URL: https://github.com/apache/incubator-openwhisk/issues/3015#issuecomment-347469734 If user bind the package and invoke a bound action, would activation be stored in original namespace? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
