[GitHub] dubeejw commented on issue #216: i18n resource file modified during build
dubeejw commented on issue #216: i18n resource file modified during build URL: https://github.com/apache/incubator-openwhisk-cli/issues/216#issuecomment-361486543 @jonpspri, FYI. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] dubeejw closed pull request #215: Prevent execution of 'incubator-openwhisk' tests when './gradlew test' is run
dubeejw closed pull request #215: Prevent execution of 'incubator-openwhisk'
tests when './gradlew test' is run
URL: https://github.com/apache/incubator-openwhisk-cli/pull/215
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/.gitignore b/.gitignore
index c1d724d9..de768504 100644
--- a/.gitignore
+++ b/.gitignore
@@ -11,6 +11,6 @@ Godeps/_workspace
# Gradle build working directories
/.gradle/
/.gogradle/
-/build/
+build
/release/
/vendor/
diff --git a/tests/build.gradle b/tests/build.gradle
index c11a0f97..ec54e0fc 100644
--- a/tests/build.gradle
+++ b/tests/build.gradle
@@ -3,6 +3,10 @@ apply plugin: 'eclipse'
compileTestScala.options.encoding = 'UTF-8'
evaluationDependsOn(':clitests')
+evaluationDependsOn(':common:scala')
+
+project(':clitests').test.onlyIf = {false}
+compileTestScala.dependsOn(':clitests:compileTestScala')
repositories {
mavenCentral()
@@ -27,6 +31,10 @@ dependencies {
compile "org.scala-lang:scala-library:${gradle.scala.version}"
compile project(':clitests')
compile project(':clitests').sourceSets.test.output
+
+compile project(':common:scala')
+compile project(':core:controller')
+compile project(':core:invoker')
}
tasks.withType(ScalaCompile) {
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] jonpspri opened a new pull request #215: Override whisk test
jonpspri opened a new pull request #215: Override whisk test URL: https://github.com/apache/incubator-openwhisk-cli/pull/215 Per issue #211, this PR removes execution of the 'incubator-openwhisk' test tests when './gradlew test' is executed, while retaining the ability to execute all scala tests in the 'incubator-openwhisk-cli' repository. This is an incremental improvement to the testing framework; more refinements are likely to follow but this can (and should) be committed once passing Travis and reviewed. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] hsane2001 commented on issue #3232: Making prewarm kind (and count) configurable
hsane2001 commented on issue #3232: Making prewarm kind (and count) configurable URL: https://github.com/apache/incubator-openwhisk/pull/3232#issuecomment-361446318 This will be a great addition. I believe the prewarm conditions include memory limits besides kind of container, can this be configurable as well? Will this code be checked in? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rabbah commented on a change in pull request #3219: Kubernetes ContainerFactoryProvider implementation
rabbah commented on a change in pull request #3219: Kubernetes
ContainerFactoryProvider implementation
URL:
https://github.com/apache/incubator-openwhisk/pull/3219#discussion_r164616971
##
File path:
core/invoker/src/main/scala/whisk/core/containerpool/kubernetes/KubernetesClient.scala
##
@@ -0,0 +1,222 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package whisk.core.containerpool.kubernetes
+
+import java.io.FileNotFoundException
+import java.net.URL
+import java.nio.file.Files
+import java.nio.file.Paths
+
+import akka.actor.ActorSystem
+import akka.event.Logging.ErrorLevel
+import akka.stream.scaladsl.Source
+import akka.util.ByteString
+import pureconfig.loadConfigOrThrow
+import whisk.common.Logging
+import whisk.common.LoggingMarkers
+import whisk.common.TransactionId
+import whisk.core.containerpool.ContainerId
+import whisk.core.containerpool.ContainerAddress
+import whisk.core.containerpool.docker.ProcessRunner
+import scala.concurrent.duration.Duration
+import scala.concurrent.ExecutionContext
+import scala.concurrent.Future
+import scala.concurrent.blocking
+import scala.concurrent.duration._
+import scala.util.Failure
+import scala.util.Success
+import scala.util.Try
+
+import io.fabric8.kubernetes.client.ConfigBuilder
+import spray.json._
+import spray.json.DefaultJsonProtocol._
+import io.fabric8.kubernetes.client.DefaultKubernetesClient
+import io.fabric8.kubernetes.client.utils.URLUtils
+import okhttp3.Request
+
+/**
+ * Configuration for kubernetes client command timeouts.
+ */
+case class KubernetesClientTimeoutConfig(run: Duration, rm: Duration, inspect:
Duration, logs: Duration)
+
+/**
+ * Serves as interface to the kubectl CLI tool.
+ *
+ * Be cautious with the ExecutionContext passed to this, as the
+ * calls to the CLI are blocking.
+ *
+ * You only need one instance (and you shouldn't get more).
+ */
+class KubernetesClient(
+ timeouts: KubernetesClientTimeoutConfig =
loadConfigOrThrow[KubernetesClientTimeoutConfig](
+"whisk.kubernetes.timeouts"))(executionContext: ExecutionContext)(implicit
log: Logging, as: ActorSystem)
+extends KubernetesApi
+with ProcessRunner {
+ implicit private val ec = executionContext
+ implicit private val kubeRestClient = new DefaultKubernetesClient(
+new ConfigBuilder()
+ .withConnectionTimeout(timeouts.logs.toMillis.toInt)
+ .withRequestTimeout(timeouts.logs.toMillis.toInt)
+ .build())
+
+ // Determines how to run kubectl. Failure to find a kubectl binary implies
+ // a failure to initialize this instance of KubernetesClient.
+ protected val kubectlCmd: Seq[String] = {
+val alternatives = List("/usr/bin/kubectl", "/usr/local/bin/kubectl")
+
+val kubectlBin = Try {
+ alternatives.find(a => Files.isExecutable(Paths.get(a))).get
+} getOrElse {
+ throw new FileNotFoundException(s"Couldn't locate kubectl binary (tried:
${alternatives.mkString(", ")}).")
+}
+
+Seq(kubectlBin)
+ }
+
+ def run(image: String, name: String, environment: Map[String, String] =
Map(), labels: Map[String, String] = Map())(
+implicit transid: TransactionId): Future[ContainerId] = {
+val environmentArgs = environment.flatMap {
+ case (key, value) => Seq("--env", s"$key=$value")
+}.toSeq
+
+val labelArgs = labels.map {
+ case (key, value) => s"$key=$value"
+} match {
+ case Seq() => Seq()
+ case pairs => Seq("-l") ++ pairs
+}
+
+val runArgs = Seq(
+ "run",
+ name,
+ "--image",
+ image,
+ "--generator",
+ "run-pod/v1",
+ "--restart",
+ "Always",
+ "--limits",
+ "memory=256Mi") ++ environmentArgs ++ labelArgs
+
+runCmd(runArgs, timeouts.run)
+ .map { _ =>
+name
+ }
+ .map(ContainerId.apply)
+ }
+
+ def inspectIPAddress(id: ContainerId)(implicit transid: TransactionId):
Future[ContainerAddress] = {
+Future {
+ blocking {
+val pod =
+
kubeRestClient.pods().withName(id.asString).waitUntilReady(timeouts.inspect.length,
timeouts.inspect.unit)
+ContainerAddress(pod.getStatus().getPodIP())
+ }
+}.recoverWith {
+ case e =>
+log.error(this, s"Failed
[GitHub] rabbah commented on a change in pull request #3219: Kubernetes ContainerFactoryProvider implementation
rabbah commented on a change in pull request #3219: Kubernetes
ContainerFactoryProvider implementation
URL:
https://github.com/apache/incubator-openwhisk/pull/3219#discussion_r164615824
##
File path:
core/invoker/src/main/scala/whisk/core/containerpool/docker/DockerContainer.scala
##
@@ -37,7 +37,7 @@ import akka.stream.scaladsl.{Framing, Source}
import akka.stream.stage._
import akka.util.ByteString
import spray.json._
-import whisk.core.containerpool.logging.LogLine
+import whisk.core.containerpool.logging.{LogLine => CoreLogLine}
import whisk.http.Messages
Review comment:
Why this import remapping?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] rabbah closed pull request #3225: reduce fillInStackTrace expenses due to ArgNormalizer
rabbah closed pull request #3225: reduce fillInStackTrace expenses due to
ArgNormalizer
URL: https://github.com/apache/incubator-openwhisk/pull/3225
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/common/scala/src/main/scala/whisk/core/entity/DocInfo.scala
b/common/scala/src/main/scala/whisk/core/entity/DocInfo.scala
index b6e635a22c..fa107a6bde 100644
--- a/common/scala/src/main/scala/whisk/core/entity/DocInfo.scala
+++ b/common/scala/src/main/scala/whisk/core/entity/DocInfo.scala
@@ -37,7 +37,7 @@ import whisk.core.entity.ArgNormalizer.trim
*
* @param id the document id, required not null
*/
-protected[core] class DocId private (val id: String) extends AnyVal {
+protected[core] class DocId(val id: String) extends AnyVal {
def asString = id // to make explicit that this is a string conversion
protected[core] def asDocInfo = DocInfo(this)
protected[core] def asDocInfo(rev: DocRevision) = DocInfo(this, rev)
diff --git
a/common/scala/src/main/scala/whisk/core/entity/FullyQualifiedEntityName.scala
b/common/scala/src/main/scala/whisk/core/entity/FullyQualifiedEntityName.scala
index a78045d4cb..c52af75284 100644
---
a/common/scala/src/main/scala/whisk/core/entity/FullyQualifiedEntityName.scala
+++
b/common/scala/src/main/scala/whisk/core/entity/FullyQualifiedEntityName.scala
@@ -48,7 +48,7 @@ protected[core] case class FullyQualifiedEntityName(path:
EntityPath, name: Enti
*/
def add(n: EntityName) = FullyQualifiedEntityName(path.addPath(name), n)
- def toDocId = DocId(qualifiedName)
+ def toDocId = new DocId(qualifiedName)
def namespace: EntityName = path.root
def qualifiedNameWithLeadingSlash: String = EntityPath.PATHSEP +
qualifiedName
def asString = path.addPath(name) + version.map("@" +
_.toString).getOrElse("")
diff --git
a/core/controller/src/main/scala/whisk/core/controller/actions/PrimitiveActions.scala
b/core/controller/src/main/scala/whisk/core/controller/actions/PrimitiveActions.scala
index 9302f4c9a9..2e9d6b0644 100644
---
a/core/controller/src/main/scala/whisk/core/controller/actions/PrimitiveActions.scala
+++
b/core/controller/src/main/scala/whisk/core/controller/actions/PrimitiveActions.scala
@@ -159,7 +159,7 @@ protected[actions] trait PrimitiveActions {
// 2. failing active ack (due to active ack timeout), fall over to db
polling
// 3. timeout on db polling => converts activation to non-blocking
(returns activation id only)
// 4. internal error message
-val docid = DocId(WhiskEntity.qualifiedName(user.namespace.toPath,
activationId))
+val docid = new DocId(WhiskEntity.qualifiedName(user.namespace.toPath,
activationId))
val (promise, finisher) = ActivationFinisher.props({ () =>
WhiskActivation.get(activationStore, docid)
})
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] gorkem commented on issue #80: Test environment for local Openwhisk Java functions
gorkem commented on issue #80: Test environment for local Openwhisk Java functions URL: https://github.com/apache/incubator-openwhisk-devtools/pull/80#issuecomment-361442784 @dubeejw I think that was because master was already broken. Seems to be fixed can you kick the build again? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] dubeejw commented on a change in pull request #170: WIP: Initial code checkin for path parameter support
dubeejw commented on a change in pull request #170: WIP: Initial code checkin for path parameter support URL: https://github.com/apache/incubator-openwhisk-cli/pull/170#discussion_r164611369 ## File path: wski18n/i18n_resources.go ## @@ -1,463 +0,0 @@ -/* - * Licensed to the Apache Software Foundation (ASF) under one or more Review comment: Hmm, why don't we need this file anymore? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] dubeejw commented on a change in pull request #170: WIP: Initial code checkin for path parameter support
dubeejw commented on a change in pull request #170: WIP: Initial code checkin
for path parameter support
URL:
https://github.com/apache/incubator-openwhisk-cli/pull/170#discussion_r164612778
##
File path: commands/api.go
##
@@ -728,6 +745,34 @@ func getLargestApiNameSize(retApiArray
*whisk.RetApiArray, apiPath string, apiVe
return maxNameSize
}
+func validatePathParameters(relativePath string) error {
Review comment:
Are path parameters JSON? Can we just attempt a JSON parse instead?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] dubeejw commented on a change in pull request #170: WIP: Initial code checkin for path parameter support
dubeejw commented on a change in pull request #170: WIP: Initial code checkin
for path parameter support
URL:
https://github.com/apache/incubator-openwhisk-cli/pull/170#discussion_r164613195
##
File path: commands/api.go
##
@@ -93,6 +93,22 @@ func isValidRelpath(relpath string) (error, bool) {
return nil, true
}
+func hasPathParameters(path string) bool {
+ return (strings.Count(path, "{") > 0) || (strings.Count(path, "}") > 0)
Review comment:
Is `path` just JSON?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] dubeejw commented on a change in pull request #170: WIP: Initial code checkin for path parameter support
dubeejw commented on a change in pull request #170: WIP: Initial code checkin
for path parameter support
URL:
https://github.com/apache/incubator-openwhisk-cli/pull/170#discussion_r164612532
##
File path: wski18n/resources/en_US.all.json
##
@@ -1558,5 +1558,21 @@
{
"id": "Cannot specify both --kind and --docker at the same time.",
"translation": "Cannot specify both --kind and --docker at the same time."
+ },
+ {
+"id": "Relative path '{{.path}}' does not include valid path parameters.
Each parameter must be enclosed in curly braces{}.",
+"translation": "Relative path '{{.path}}' does not include valid path
parameters. Each parameter must be enclosed in curly braces{}."
+ },
+ {
+"id": "Default description for {{.name}}",
Review comment:
`'` around arguments, and remove double spaces for consistency. How can we
representing `curly braces{}` better?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] dubeejw commented on a change in pull request #170: WIP: Initial code checkin for path parameter support
dubeejw commented on a change in pull request #170: WIP: Initial code checkin
for path parameter support
URL:
https://github.com/apache/incubator-openwhisk-cli/pull/170#discussion_r164611787
##
File path: wski18n/resources/en_US.all.json
##
@@ -1558,5 +1558,21 @@
{
"id": "Cannot specify both --kind and --docker at the same time.",
"translation": "Cannot specify both --kind and --docker at the same time."
+ },
+ {
+"id": "Relative path '{{.path}}' does not include valid path parameters.
Each parameter must be enclosed in curly braces{}.",
+"translation": "Relative path '{{.path}}' does not include valid path
parameters. Each parameter must be enclosed in curly braces{}."
+ },
+ {
+"id": "Default description for {{.name}}",
+"translation": "Default description for {{.name}}"
+ },
+ {
+"id": "The base path ({{.path}}) cannot have parameters. Only the relative
path supports path parameters.",
Review comment:
`'` around arguments for consistency.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] jessealva commented on issue #170: WIP: Initial code checkin for path parameter support
jessealva commented on issue #170: WIP: Initial code checkin for path parameter support URL: https://github.com/apache/incubator-openwhisk-cli/pull/170#issuecomment-361429390 @dubeejw yep, ready for review This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mrutkows closed pull request #15: Add the specs to implement the release process
mrutkows closed pull request #15: Add the specs to implement the release process URL: https://github.com/apache/incubator-openwhisk-release/pull/15 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/README.md b/README.md index 51c2a00..0471157 100644 --- a/README.md +++ b/README.md @@ -34,6 +34,13 @@ repository and the release package, and adding Licensing headers to each source ## Release distribution We need to upload all artifacts to project?s subdirectory in Apache channel. This step needs to be implemented in Travis build. +# Specifications to implement the above release process + +To find the specifications about how to implement the Apache Release process for OpenWhisk project set, please visit the +following page. + +- [General Specification](docs/general_spec.md) + # Reference [Apache release policy](http://www.apache.org/legal/release-policy.html) diff --git a/docs/general_spec.md b/docs/general_spec.md new file mode 100644 index 000..5fad19f --- /dev/null +++ b/docs/general_spec.md @@ -0,0 +1,142 @@ +# General plan to implement the Apache release process for OpenWhisk + +The purpose of this repository is to provide a one-stop entry tool to manage the release process of OpenWhisk in an automated +way. 1,000 people will probably have 1,000 ideas about how to fulfill it, since we are living in such an innovative world. +We believe they are all the valid routes, directing to our final destination, as long as they are compliant with the Apache +release process. This specification just gives us one proposal, which may not be perfect, but will be proven to be capable of +leading OpenWhisk team to the paradise, the release of shipped, packaged, Apache-compliant, able-to-run OpenWhisk source +code and compiled artifacts. + +Long story short, Apache generally needs two type of packages to be publicly available after the declaration of the release: +source code and the compiled artifacts. We would like to divide the work into two major phases: release of source code and +release of compiled artifacts. + +## Release of OpenWhisk artifacts + +Please click on the work items listed as belows to access the detailed information: +- [1. Download the source code](work_items.md#1-download-the-source-code-open-issue) ([open issue](https://github.com/apache/incubator-openwhisk-release/issues/16)) +- [2. Verify the compliance of the source code](work_items.md#2-verify-the-compliance-of-the-source-code-open-issue) ([open issue](https://github.com/apache/incubator-openwhisk-release/issues/17)) +- [3. Deploy OpenWhisk based on the source code](work_items.md#3-deploy-openwhisk-based-on-the-source-code-open-issue) ([open issue](https://github.com/apache/incubator-openwhisk-release/issues/18)) +- [4. Test each OpenWhisk component](work_items.md#4-test-each-openwhisk-component-open-issue) ([open issue](https://github.com/apache/incubator-openwhisk-release/issues/19)) +- [5. Add NOTICE, LICENSE, and CHANGELOG to each OpenWhisk project](work_items.md#5-add-notice-license-and-changelog-to-each-openwhisk-project-open-issue) ([open issue](https://github.com/apache/incubator-openwhisk-release/issues/13)) +- [6. Package the artifacts](work_items.md#6-package-the-artifacts-open-issue) ([open issue](https://github.com/apache/incubator-openwhisk-release/issues/20)) +- [7. Upload the artifacts to staging repository](work_items.md#7-upload-the-artifacts-into-staging-repository-for-release-vote-open-issue) ([open issue](https://github.com/apache/incubator-openwhisk-release/issues/21)) +- After the above 7 steps, note will be sent out to the commonuty for vote. Before we reach enough votes, Step 1 to 7 +can be re-iterated to update the artifacts in staging repository. + +- [8. Release the artifacts](work_items.md#8-release-the-artifacts-open-issue) ([open issue](https://github.com/apache/incubator-openwhisk-release/issues/22)) + +# Proposed implementation +## How to automate the release process for OpenWhisk? + +Travis CI is proposed as the pipeline to walk through the download, verify, build and publish processes. + +As we can predict, OpenWhisk is going to release continuously in the future, so we propose to create directories in a +hierarchical structure with configuration files inside to map different releases and sub-releases of OpenWhisk. One major +advantage of this plan is to provide the release manager a clear and straightforward overview for the historic releases +of OpenWhisk, which is convenient to navigate and manage. Once this repository is checked-out, the footprint +of each release's configuration files can be found on the master branch. + +OpenWhisk consists of dozens of projects, which means we need to manage a series of hash
[GitHub] dubeejw closed issue #54: http/https proxy support is broken
dubeejw closed issue #54: http/https proxy support is broken URL: https://github.com/apache/incubator-openwhisk-client-go/issues/54 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mdeuser commented on issue #55: Use a HTTP transport based on the DefaultTransport to pick up proxy support
mdeuser commented on issue #55: Use a HTTP transport based on the DefaultTransport to pick up proxy support URL: https://github.com/apache/incubator-openwhisk-client-go/pull/55#issuecomment-361382640 @dubeejw - ready for review This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] ddragosd commented on issue #92: update env vars to latest OW code
ddragosd commented on issue #92: update env vars to latest OW code URL: https://github.com/apache/incubator-openwhisk-devtools/pull/92#issuecomment-361380993 @mcdan thanks for the extra check ! This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] ddragosd commented on a change in pull request #92: update env vars to latest OW code
ddragosd commented on a change in pull request #92: update env vars to latest OW code URL: https://github.com/apache/incubator-openwhisk-devtools/pull/92#discussion_r164558405 ## File path: docker-compose/Makefile ## @@ -67,17 +67,21 @@ docker: download-cli: echo "downloading the CLI tool ... " - if [ "$(UNAME_STR)" = "Darwin" ]; then \ - echo "downloading cli for mac" ; \ - curl -o $(PROJECT_HOME)/bin/wsk.zip -L https://github.com/apache/incubator-openwhisk-cli/releases/download/latest/OpenWhisk_CLI-latest-mac-amd64.zip ; \ - cd $(PROJECT_HOME)/bin ; \ -unzip -o wsk.zip; \ - elif [ "$(UNAME_STR)" = "Linux" ]; then \ - echo "downloading cli for linux" ; \ - curl -o $(PROJECT_HOME)/bin/wsk.tgz -L https://github.com/apache/incubator-openwhisk-cli/releases/download/latest/OpenWhisk_CLI-latest-linux-amd64.tgz ; \ - cd $(PROJECT_HOME)/bin ; \ - tar -xf wsk.tgz ; \ - fi; + if [ "$(PROJECT_HOME)" = "./openwhisk-master" ]; then \ +if [ "$(UNAME_STR)" = "Darwin" ]; then \ Review comment: :+1: This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mrutkows commented on issue #700: Go format source code
mrutkows commented on issue #700: Go format source code URL: https://github.com/apache/incubator-openwhisk-wskdeploy/pull/700#issuecomment-361373208 @dubeejw was this debated elsewhere (go client?)? If we adopt this, how do we assure developers adhere to the format using IDEs? Do we have a .MD file somewhere (which considers VS Code, GoLand, IntelliJ for example)? Effectively, where is the pointer to the rules we must follow (apart from running the tool) and are there settings we convey to in .md format for use in IDEs? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mrutkows commented on issue #700: Go format source code
mrutkows commented on issue #700: Go format source code URL: https://github.com/apache/incubator-openwhisk-wskdeploy/pull/700#issuecomment-361373208 @dubeejw was this debated elsewhere (go client?)? If we adopt this, how do we assure developers adhere to the format using IDEs? Do we have a .MD file somewhere (which considers VS Code, GoLand, IntelliJ for example)? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] dubeejw commented on issue #80: Test environment for local Openwhisk Java functions
dubeejw commented on issue #80: Test environment for local Openwhisk Java functions URL: https://github.com/apache/incubator-openwhisk-devtools/pull/80#issuecomment-361367109 @gorkem, Travis failed. I restarted it just to verify if the failure happens again. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] dubeejw closed pull request #239: add logging for errors
dubeejw closed pull request #239: add logging for errors URL: https://github.com/apache/incubator-openwhisk-package-kafka/pull/239 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/provider/consumer.py b/provider/consumer.py index 2a0c65a..4728d27 100644 --- a/provider/consumer.py +++ b/provider/consumer.py @@ -481,6 +481,7 @@ def __encodeKeyIfNeeded(self, key): return key def __error_callback(self, error): +logging.warning(error) if not self.connected and error.code() == KafkaError._AUTHENTICATION: self.authErrors = self.authErrors + 1 if self.authErrors > self.maxAuthErrors: This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] abaruni opened a new pull request #239: add logging for errors
abaruni opened a new pull request #239: add logging for errors URL: https://github.com/apache/incubator-openwhisk-package-kafka/pull/239 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] dubeejw closed pull request #238: Adjust threshold of authentication errors with brokers before disabling consumer
dubeejw closed pull request #238: Adjust threshold of authentication errors
with brokers before disabling consumer
URL: https://github.com/apache/incubator-openwhisk-package-kafka/pull/238
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/provider/consumer.py b/provider/consumer.py
index d80ad6b..2a0c65a 100644
--- a/provider/consumer.py
+++ b/provider/consumer.py
@@ -133,6 +133,18 @@ def __init__(self, trigger, params, sharedDictionary):
self.authErrors = 0
+# We want to account for the number of brokers when deciding the
maximum number
+# number of auth errors to allow
+self.maxAuthErrors = len(self.brokers) * 30
+
+# There is the possibility of being disconnected from one or more
brokers while
+# still maintaining a connection to one or more others. We'll use this
flag to
+# signal when we have been disconnected from all brokers. Value will
be set to
+# 'True' when we have received a partition assignment and 'False' when
our
+# partition assignment has been revoked. When disconnected we will
begin to
+# increment the 'authErrors' counter.
+self.connected = False
+
self.sharedDictionary = sharedDictionary
if 'status' in params and params['status']['active'] == False:
@@ -269,7 +281,7 @@ def __createConsumer(self):
})
consumer = KafkaConsumer(config)
-consumer.subscribe([self.topic])
+consumer.subscribe([self.topic], self.__on_assign,
self.__on_revoke)
logging.info("[{}] Now listening in order to fire
trigger".format(self.trigger))
return consumer
@@ -368,6 +380,25 @@ def __fireTrigger(self, messages):
retry = False
elif self.__shouldDisable(status_code):
logging.error('[{}] Error talking to OpenWhisk, status
code {}'.format(self.trigger, status_code))
+response_dump = {
+'request': {
+'method': response.request.method,
+'url': response.request.url,
+'path_url': response.request.path_url,
+'headers': response.request.headers,
+'body': response.request.body
+},
+'response': {
+'status_code': response.status_code,
+'ok': response.ok,
+'reason': response.reason,
+'url': response.url,
+'headers': response.headers,
+'content': response.content
+}
+}
+
+logging.error('[{}] Dumping the content of the request
and response:\n{}'.format(self.trigger, response_dump))
# abandon all hope?
self.setDesiredState(Consumer.State.Disabled)
@@ -450,10 +481,20 @@ def __encodeKeyIfNeeded(self, key):
return key
def __error_callback(self, error):
-logging.warning(error)
-if error.code() == KafkaError._AUTHENTICATION:
+if not self.connected and error.code() == KafkaError._AUTHENTICATION:
self.authErrors = self.authErrors + 1
-if self.authErrors > 5:
+if self.authErrors > self.maxAuthErrors:
self.setDesiredState(Consumer.State.Disabled)
-message = 'Automatically disabled trigger. Consumer failed to
authentication with broker(s) more than 5 times with apikey
{}:{}'.format(self.username, self.password)
+message = 'Automatically disabled trigger. Consumer failed to
authenticate with broker(s) after more than 30 attempts with apikey
{}:{}'.format(self.username, self.password)
self.database.disableTrigger(self.trigger, 403, message)
+
+def __on_assign(self, consumer, partitions):
+topicPartition = partitions[0]
+logging.info('[{}] Completed partition assignment. topic: {},
partition: {}, offset: {}'.format(self.trigger, topicPartition.topic,
topicPartition.partition, topicPartition.offset))
+self.authErrors = 0
+self.connected = True
+
+def __on_revoke(self, consumer, partitions):
+topicPartition = partitions[0]
+logging.info('[{}] Partition assignment has been revoked. topic: {},
partition: {}, offset: {}'.format(self.trigger, topicPartition.topic,
topicPartition.partition, topicPartition.offset))
+self.connected = False
[GitHub] pritidesai commented on issue #700: Go format source code
pritidesai commented on issue #700: Go format source code URL: https://github.com/apache/incubator-openwhisk-wskdeploy/pull/700#issuecomment-361337785 @dubeejw wow, this is a huge PR, which tool are you using to format go files? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] csantanapr commented on issue #2077: Add NodeJS 8 initial support for Serverless OpenWhisk
csantanapr commented on issue #2077: Add NodeJS 8 initial support for
Serverless OpenWhisk
URL:
https://github.com/apache/incubator-openwhisk/issues/2077#issuecomment-361337103
Nodejs 8 runtime details here and `--kind nodejs:8`
https://github.com/apache/incubator-openwhisk/blob/master/docs/reference.md#nodejs-version-8-environment
A cool example on async/await
```javascript
const { promisify } = require('util');
const request = promisify(require('request'));
async function main({
location='Vermont',
url=`https://query.yahooapis.com/v1/public/yql?q=select item.condition
from weather.forecast where woeid in (select woeid from geo.places(1) where
text="'${location}'")=json`
}){
let response
try {
response = await request(url)
} catch (err) {
console.error('Http error', err)
return Promise.reject({Error:err});
}
return JSON.parse(response.body).query.results.channel.item.condition;
}
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] csantanapr commented on issue #2077: Add NodeJS 8 initial support for Serverless OpenWhisk
csantanapr commented on issue #2077: Add NodeJS 8 initial support for
Serverless OpenWhisk
URL:
https://github.com/apache/incubator-openwhisk/issues/2077#issuecomment-361337103
Nodejs 8 runtime details here and `--kind nodejs:8`
https://github.com/apache/incubator-openwhisk/blob/master/docs/reference.md#nodejs-version-8-environment
A cool example on async/await
```javascript
const { promisify } = require('util');
const request = promisify(require('request'));
async function main({
location='Vermont',
url=`https://query.yahooapis.com/v1/public/yql?q=select item.condition
from weather.forecast where woeid in (select woeid from geo.places(1) where
text="'${location}'")=json`
}){
let response
try {
response = await request(url)
} catch (err) {
console.error('Http error', err)
return Promise.reject({Error:err});
}
return JSON.parse(response.body).query.results.channel.item.condition;
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] csantanapr opened a new pull request #3234: print url for swagger UI on Vagrant deploy
csantanapr opened a new pull request #3234: print url for swagger UI on Vagrant deploy URL: https://github.com/apache/incubator-openwhisk/pull/3234 Closes #2950 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] abaruni commented on a change in pull request #238: Adjust threshold of authentication errors with brokers before disabling consumer
abaruni commented on a change in pull request #238: Adjust threshold of authentication errors with brokers before disabling consumer URL: https://github.com/apache/incubator-openwhisk-package-kafka/pull/238#discussion_r164499648 ## File path: provider/consumer.py ## @@ -133,6 +133,18 @@ def __init__(self, trigger, params, sharedDictionary): self.authErrors = 0 +# We want to account for the number of brokers when deciding the maximum number +# number of auth errors to allow +self.maxAuthErrors = len(self.brokers) * 30 Review comment: is this enough? should it be 50 attempts per broker? 100? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] houshengbo opened a new issue #22: Step 8: Release the artifacts
houshengbo opened a new issue #22: Step 8: Release the artifacts URL: https://github.com/apache/incubator-openwhisk-release/issues/22 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] houshengbo opened a new issue #21: Step 7: Upload the artifacts into staging repository for release vote
houshengbo opened a new issue #21: Step 7: Upload the artifacts into staging repository for release vote URL: https://github.com/apache/incubator-openwhisk-release/issues/21 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] houshengbo opened a new issue #20: Step 6: Package the artifacts
houshengbo opened a new issue #20: Step 6: Package the artifacts URL: https://github.com/apache/incubator-openwhisk-release/issues/20 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] abaruni commented on issue #238: Adjust threshold of authentication errors with brokers before disabling consumer
abaruni commented on issue #238: Adjust threshold of authentication errors with brokers before disabling consumer URL: https://github.com/apache/incubator-openwhisk-package-kafka/pull/238#issuecomment-361314590 @dubeejw @csantanapr would you mind giving this some ? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rabbah commented on issue #2077: Add NodeJS 8 initial support for Serverless OpenWhisk
rabbah commented on issue #2077: Add NodeJS 8 initial support for Serverless OpenWhisk URL: https://github.com/apache/incubator-openwhisk/issues/2077#issuecomment-361313673 Can you add a link to dockerhub image or doc link for what to specify the kind as? Also you had some examples using async/await... would be nice to have links for posterity. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rabbah commented on issue #3232: Making prewarm kind (and count) configurable
rabbah commented on issue #3232: Making prewarm kind (and count) configurable URL: https://github.com/apache/incubator-openwhisk/pull/3232#issuecomment-361312490 Thanks for the contribution - do you have an Apache ICLA on file? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rabbah commented on issue #3232: Making prewarm kind (and count) configurable
rabbah commented on issue #3232: Making prewarm kind (and count) configurable
URL:
https://github.com/apache/incubator-openwhisk/pull/3232#issuecomment-361311688
I'd suggest in addition making the configuration a set of stem cells (vs a
single kind). It might look something like this: `prewarm: [{ "kind":
"nodejs:6", "stemcells": 2}, { "kind": "python:3", "stemcells": 2}]`. Future
additions could also set the default limit for memory.
I'm OK with making either of these suggestions separate PRs; as this PR
isn't intended to be semantic changing otherwise.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] rabbah commented on issue #3232: Making prewarm kind (and count) configurable
rabbah commented on issue #3232: Making prewarm kind (and count) configurable
URL:
https://github.com/apache/incubator-openwhisk/pull/3232#issuecomment-361311688
I'd suggest in addition making the configuration a set of stem cells (vs a
single kind). It might look something like this: `prewarm: [{ "kind":
"nodejs:6", "stemcells": 2}, { "kind": "python:3", "stemcells": 2}]`. Future
additions could also set the default limit for memory.
I'm OK with making that either of these a separate PR as well. As this PR
isn't intended to be semantic changing otherwise.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] abaruni opened a new pull request #238: Adjust threshold of authentication errors with brokers before disabling consumer
abaruni opened a new pull request #238: Adjust threshold of authentication errors with brokers before disabling consumer URL: https://github.com/apache/incubator-openwhisk-package-kafka/pull/238 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rabbah commented on issue #3232: Making prewarm kind (and count) configurable
rabbah commented on issue #3232: Making prewarm kind (and count) configurable
URL:
https://github.com/apache/incubator-openwhisk/pull/3232#issuecomment-361311688
I'd suggest in addition making the configuration a set of stem cells (vs a
single kind). It might look something like this: `prewarm: [{ "kind":
"nodejs:6", "stemcells": 2}, { "kind": "python:3", "stemcells": 2}]`. Future
additions could also set the default limit for memory.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] rabbah commented on issue #3232: Making prewarm kind (and count) configurable
rabbah commented on issue #3232: Making prewarm kind (and count) configurable
URL:
https://github.com/apache/incubator-openwhisk/pull/3232#issuecomment-361311688
I'd suggest in addition making the configuration a set of stem cells (vs a
single kind). It might look something like this: `prewarm: [{ "kind":
"nodejs:6", "stemcells": 2}, { "kind": "python:3", "stemcells": 2}]`
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] houshengbo opened a new issue #19: 4. Test each OpenWhisk component
houshengbo opened a new issue #19: 4. Test each OpenWhisk component URL: https://github.com/apache/incubator-openwhisk-release/issues/19 This step is optional for the release process, but important for the release manager to guarantee the code quality. After Step 3, deploy openwhisk services, we need to have a way to check whether the test cases are able to pass for all openwhisk components to be released, including, core service, catalog, runtimes, api gateway, cli, wskdeploy, etc. Suggestions: develop a series of scripts separately to run the test cases for different projects. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] csantanapr commented on issue #2077: Add NodeJS 8 initial support for Serverless OpenWhisk
csantanapr commented on issue #2077: Add NodeJS 8 initial support for Serverless OpenWhisk URL: https://github.com/apache/incubator-openwhisk/issues/2077#issuecomment-361311205 This is complete now This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] csantanapr closed issue #2077: Add NodeJS 8 initial support for Serverless OpenWhisk
csantanapr closed issue #2077: Add NodeJS 8 initial support for Serverless OpenWhisk URL: https://github.com/apache/incubator-openwhisk/issues/2077 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] csantanapr closed issue #2538: vagrant "hello" script fails
csantanapr closed issue #2538: vagrant "hello" script fails URL: https://github.com/apache/incubator-openwhisk/issues/2538 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] csantanapr commented on issue #2538: vagrant "hello" script fails
csantanapr commented on issue #2538: vagrant "hello" script fails URL: https://github.com/apache/incubator-openwhisk/issues/2538#issuecomment-361311044 Closing as now the controller and invokers are built from the clone so they should not be out of sync anymore This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rabbah commented on a change in pull request #3232: Making prewarm kind (and count) configurable
rabbah commented on a change in pull request #3232: Making prewarm kind (and
count) configurable
URL:
https://github.com/apache/incubator-openwhisk/pull/3232#discussion_r164492994
##
File path: ansible/group_vars/all
##
@@ -36,6 +36,11 @@ whisk:
#
runtimesManifest: "{{ runtimes_manifest | default(lookup('file', '{{
openwhisk_home }}/ansible/files/runtimes.json') | from_json) }}"
+##
+# Prewarm configuration
+prewarmKind: "{{prewarm_kind | default('nodejs:6')}}"
Review comment:
we've increasingly moved away from ansible configs to use pure config: refer
to this doc
https://github.com/apache/incubator-openwhisk/blob/master/docs/dev/configuration.md
it makes it more convenient in general for kube and mesos based deployments
downstream.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] rabbah commented on a change in pull request #3232: Making prewarm kind (and count) configurable
rabbah commented on a change in pull request #3232: Making prewarm kind (and
count) configurable
URL:
https://github.com/apache/incubator-openwhisk/pull/3232#discussion_r164493108
##
File path: ansible/templates/whisk.properties.j2
##
@@ -35,6 +35,9 @@ whisk.api.vanity.subdomain.parts=1
runtimes.manifest={{ runtimesManifest | to_json }}
+prewarm.kind={{ prewarmKind | default('nodejs:6') }}
Review comment:
don't think we'll need these until they play into a test which shouldn't be
the case.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] rabbah commented on issue #3233: update component png to remove swiglies
rabbah commented on issue #3233: update component png to remove swiglies URL: https://github.com/apache/incubator-openwhisk/pull/3233#issuecomment-361310100 we should add sources per #3208 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] houshengbo opened a new issue #18: Step 3: Deploy OpenWhisk based on the source code
houshengbo opened a new issue #18: Step 3: Deploy OpenWhisk based on the source code URL: https://github.com/apache/incubator-openwhisk-release/issues/18 Based on the source code downloaded in Step 1, we should have a script named "deploy_openwhisk.sh" to build and deploy openwhisk services. For other openwhisk projects, we need to have separate commands to deploy their services or build their tools as well, e.g. catalog, cli, wskdeploy, runtimes, api gateway, etc. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] csantanapr opened a new pull request #3233: update component png to remove swiglies
csantanapr opened a new pull request #3233: update component png to remove swiglies URL: https://github.com/apache/incubator-openwhisk/pull/3233 Closes #3197 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] Himavanth opened a new pull request #3232: Making prewarm kind (and count) configurable
Himavanth opened a new pull request #3232: Making prewarm kind (and count) configurable URL: https://github.com/apache/incubator-openwhisk/pull/3232 This is to make configurable the prewarm kind (ex:nodejs:6) and prewarm count (number of containers the invoker prewarms) which is hardcoded to 2 right now. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] houshengbo opened a new issue #17: Step 2: Verify the compliance of the source code
houshengbo opened a new issue #17: Step 2: Verify the compliance of the source code URL: https://github.com/apache/incubator-openwhisk-release/issues/17 Each source code file needs to have Apache licensing header at the top. We need to implement a script called "verify_source_code.sh", to check the valid headers, after Step 1: download the source code. We should use the directory where all the source code is saved, and the list of project names parsed in Step 1, as the input to this script. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] houshengbo opened a new issue #16: Step 1: Implement the script to download the source code
houshengbo opened a new issue #16: Step 1: Implement the script to download the source code URL: https://github.com/apache/incubator-openwhisk-release/issues/16 The script can be named "download_source_code.sh". By giving the list of project names, and the hash values or tags, the source code should be downloaded to specified local directory. We can use a JSON-format configuration file to save the above information There should be a default local directory, and default list of projects. If hash value or tag is not provided, we can clone the whole git history. The script should be able to run on a local machine and on a Travis build. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] csantanapr closed issue #3201: Quick Start is broken: Oracle removed Java it depends on
csantanapr closed issue #3201: Quick Start is broken: Oracle removed Java it depends on URL: https://github.com/apache/incubator-openwhisk/issues/3201 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] csantanapr commented on issue #3201: Quick Start is broken: Oracle removed Java it depends on
csantanapr commented on issue #3201: Quick Start is broken: Oracle removed Java it depends on URL: https://github.com/apache/incubator-openwhisk/issues/3201#issuecomment-361298969 It looks like `sudo apt-get install -y software-properties-common sudo add-apt-repository -y ppa:webupd8team/java` it's working again This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mcdan commented on issue #92: update env vars to latest OW code
mcdan commented on issue #92: update env vars to latest OW code URL: https://github.com/apache/incubator-openwhisk-devtools/pull/92#issuecomment-361291649 @tysonnorris This built cleanly for me thanks. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] houshengbo commented on issue #211: How shall we deal with the traditional commands: ./gradlew test and ./gradlew build
houshengbo commented on issue #211: How shall we deal with the traditional commands: ./gradlew test and ./gradlew build URL: https://github.com/apache/incubator-openwhisk-cli/issues/211#issuecomment-361282043 Only the test cases under incubator-openwhisk-cli are what we need to run. We should not bother the the test cases located in incubator-openwhisk. Rewriting the test cases in Go is definitely going to remove the dependency on incubator-openwhisk code. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rabbah commented on a change in pull request #3202: Support action continuations in the controller
rabbah commented on a change in pull request #3202: Support action
continuations in the controller
URL:
https://github.com/apache/incubator-openwhisk/pull/3202#discussion_r164463731
##
File path:
core/controller/src/main/scala/whisk/core/controller/actions/PrimitiveActions.scala
##
@@ -139,6 +199,356 @@ protected[actions] trait PrimitiveActions {
}
}
+ /**
+ * Mutable cumulative accounting of what happened during the execution of a
composition.
+ *
+ * Compositions are aborted if the number of action invocations exceeds a
limit.
+ * The permitted max is n component invocations plus 2n+1 conductor
invocations (where n is the actionSequenceLimit).
+ * The max is chosen to permit a sequence with up to n primitive actions.
+ *
+ * NOTE:
+ * A sequence invocation counts as one invocation irrespective of the number
of action invocations in the sequence.
+ * If one component of a composition is also a composition, the caller and
callee share the same accounting object.
+ * The counts are shared between callers and callees so the limit applies
globally.
+ *
+ * @param components the current count of component actions already invoked
+ * @param conductors the current count of conductor actions already invoked
+ */
+ private case class CompositionAccounting(var components: Int = 0, var
conductors: Int = 0)
+
+ /**
+ * A mutable session object to keep track of the execution of one
composition.
+ *
+ * NOTE:
+ * The session object is not shared between callers and callees.
+ * A callee has a reference to the session object for the caller.
+ * This permits the callee to return to the caller when done.
+ *
+ * @param activationId the activationId for the composition (ie the
activation record for the composition)
+ * @param start the start time for the composition
+ * @param action the conductor action responsible for the execution of the
composition
+ * @param cause the cause of the composition (activationId of the enclosing
sequence or composition if any)
+ * @param duration the "user" time so far executing the composition (sum of
durations for
+ *all actions invoked so far which is different from the total time
spent executing the composition)
+ * @param maxMemory the maximum memory annotation observed so far for the
conductor action and components
+ * @param state the json state object to inject in the parameter object of
the next conductor invocation
+ * @param accounting the global accounting object used to abort compositions
requiring too many action invocations
+ * @param logs a mutable buffer that is appended with new activation ids as
the composition unfolds
+ * (in contrast with sequences, the logs of a hierarchy of
compositions is not flattened)
+ * @param caller the session object for the parent composition (caller) if
any
+ * @param result a placeholder for returning the result of the composition
invocation (blocking invocation only)
+ */
+ private case class Session(activationId: ActivationId,
+ start: Instant,
+ action: ExecutableWhiskActionMetaData,
+ cause: Option[ActivationId],
+ var duration: Long,
+ var maxMemory: Int,
+ var state: Option[JsObject],
+ accounting: CompositionAccounting,
+ logs: Buffer[ActivationId],
+ caller: Option[Session],
+ result: Option[Promise[Either[ActivationId,
WhiskActivation]]])
+
+ /**
+ * A method that knows how to invoke a composition.
+ *
+ * The method instantiates the session object for the composition, invokes
the conductor action for the composition,
+ * and waits for the composition result (resulting activation) if the
invocation is blocking (up to timeout).
+ *
+ * @param user the identity invoking the action
+ * @param action the conductor action to invoke for the composition
+ * @param payload the dynamic arguments for the activation
+ * @param waitForResponse if not empty, wait upto specified duration for a
response (this is used for blocking activations)
+ * @param cause the activation id that is responsible for this
invoke/activation
+ * @param caller the session object for the caller if any
+ * @param transid a transaction id for logging
+ * @return a promise that completes with one of the following successful
cases:
+ *Right(WhiskActivation) if waiting for a response and response
is ready within allowed duration,
+ *Left(ActivationId) if not waiting for a response, or allowed
duration has elapsed without a result ready
+ * or an error
+ */
+ private def invokeComposition(
+user: Identity,
+action: ExecutableWhiskActionMetaData,
+payload:
[GitHub] csantanapr commented on a change in pull request #3231: update docs for ulimit and pid-limit
csantanapr commented on a change in pull request #3231: update docs for ulimit and pid-limit URL: https://github.com/apache/incubator-openwhisk/pull/3231#discussion_r164464079 ## File path: docs/reference.md ## @@ -484,14 +484,14 @@ The following table lists the default limits for actions. * The limit cannot be changed by the user. * An entity with too big parameters will be rejected on trying to create or update it. -### Per Docker action open files ulimit (Fixed: 64:64) -* The maximum number of open file is 64 (for both hard and soft limits). -* The docker run command use the argument `--ulimit nofile=64:64`. +### Per Docker action open files ulimit (Fixed: 1024:1024) +* The maximum number of open files is 1024 (for both hard and soft limits). +* The docker run command use the argument `--ulimit nofile=1024:1024`. * For more information about the ulimit for open files see the [docker run](https://docs.docker.com/engine/reference/commandline/run) documentation. -### Per Docker action processes ulimit (Fixed: 512:512) -* The maximum number of processes available to a user is 512 (for both hard and soft limits). -* The docker run command use the argument `--ulimit nproc=512:512`. +### Per Docker action processes ulimit (Fixed: 1024) +* The maximum number of processes available to the action container is 1024. +* The docker run command use the argument `--pids-limit 1024`. Review comment: It doesn't have `=` it's space This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] jpkessle commented on a change in pull request #3231: update docs for ulimit and pid-limit
jpkessle commented on a change in pull request #3231: update docs for ulimit and pid-limit URL: https://github.com/apache/incubator-openwhisk/pull/3231#discussion_r164462755 ## File path: docs/reference.md ## @@ -484,14 +484,14 @@ The following table lists the default limits for actions. * The limit cannot be changed by the user. * An entity with too big parameters will be rejected on trying to create or update it. -### Per Docker action open files ulimit (Fixed: 64:64) -* The maximum number of open file is 64 (for both hard and soft limits). -* The docker run command use the argument `--ulimit nofile=64:64`. +### Per Docker action open files ulimit (Fixed: 1024:1024) +* The maximum number of open files is 1024 (for both hard and soft limits). +* The docker run command use the argument `--ulimit nofile=1024:1024`. * For more information about the ulimit for open files see the [docker run](https://docs.docker.com/engine/reference/commandline/run) documentation. -### Per Docker action processes ulimit (Fixed: 512:512) -* The maximum number of processes available to a user is 512 (for both hard and soft limits). -* The docker run command use the argument `--ulimit nproc=512:512`. +### Per Docker action processes ulimit (Fixed: 1024) +* The maximum number of processes available to the action container is 1024. +* The docker run command use the argument `--pids-limit 1024`. Review comment: Should the argument contain an `=` sign ? Like this: The docker run command use the argument `--pids-limit=1024`. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rabbah commented on issue #3072: Enhance kafka message provider
rabbah commented on issue #3072: Enhance kafka message provider URL: https://github.com/apache/incubator-openwhisk/pull/3072#issuecomment-361270171 LGTM in general; although I don't understand why the poll interrupt is needed and want to investigate that on my own. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rabbah commented on a change in pull request #3072: Enhance kafka message provider
rabbah commented on a change in pull request #3072: Enhance kafka message
provider
URL:
https://github.com/apache/incubator-openwhisk/pull/3072#discussion_r16571
##
File path:
common/scala/src/main/scala/whisk/connector/kafka/KafkaConsumerConnector.scala
##
@@ -21,46 +21,91 @@ import java.util.Properties
import scala.collection.JavaConversions.iterableAsScalaIterable
import scala.collection.JavaConversions.seqAsJavaList
-import scala.concurrent.duration.Duration
-import scala.concurrent.duration.DurationInt
-import scala.concurrent.duration.FiniteDuration
-
+import scala.concurrent.duration._
+import scala.concurrent.{ExecutionContext, Future}
import org.apache.kafka.clients.consumer.ConsumerConfig
import org.apache.kafka.clients.consumer.KafkaConsumer
import org.apache.kafka.common.serialization.ByteArrayDeserializer
-
+import org.apache.kafka.common.errors.{RetriableException, WakeupException}
+import akka.actor.ActorSystem
import whisk.common.Logging
import whisk.core.connector.MessageConsumer
-class KafkaConsumerConnector(kafkahost: String,
- groupid: String,
- topic: String,
- override val maxPeek: Int = Int.MaxValue,
- readeos: Boolean = true,
- sessionTimeout: FiniteDuration = 30.seconds,
- autoCommitInterval: FiniteDuration = 10.seconds,
- maxPollInterval: FiniteDuration =
5.minutes)(implicit logging: Logging)
+class KafkaConsumerConnector(
+ kafkahost: String,
+ groupid: String,
+ topic: String,
+ override val maxPeek: Int = Int.MaxValue,
+ readeos: Boolean = true,
+ sessionTimeout: FiniteDuration = 30.seconds,
+ autoCommitInterval: FiniteDuration = 10.seconds,
+ maxPollInterval: FiniteDuration = 5.minutes)(implicit logging: Logging,
actorSystem: ActorSystem)
extends MessageConsumer {
+ implicit val ec: ExecutionContext = actorSystem.dispatcher
+ private val gracefulWaitTime = 100.milliseconds.toMillis
+
/**
* Long poll for messages. Method returns once message are available but no
later than given
* duration.
*
* @param duration the maximum duration for the long poll
*/
- override def peek(duration: Duration = 500.milliseconds) = {
-val records = consumer.poll(duration.toMillis)
-records map { r =>
- (r.topic, r.partition, r.offset, r.value)
-}
+ override def peek(duration: Duration = 500.milliseconds,
+retry: Int = 3): Iterable[(String, Int, Long,
Array[Byte])] = {
+// Since kafka client can be infinitely blocked in poll(timeout), we
should interrupt it using the wakeup() method
+val wakeUpTask =
+ actorSystem.scheduler.scheduleOnce(sessionTimeout +
gracefulWaitTime.milliseconds)(consumer.wakeup())
+
+try {
+ consumer.poll(duration.toMillis).map(r => (r.topic, r.partition,
r.offset, r.value))
+} catch {
+ // Happens if the peek hangs.
+ case e: WakeupException =>
+if (retry > 0) {
+ logging.error(this, s"poll timeout occurred. Retrying $retry more
times.")
+ Thread.sleep(gracefulWaitTime) // using Thread.sleep is okay, since
`poll` is blocking anyway
+ peek(duration, retry - 1)
+} else {
+ recreateConsumer()
+ throw e
+}
+ case e: RetriableException =>
+if (retry > 0) {
+ logging.error(this, s"$e: Retrying $retry more times")
+ wakeUpTask.cancel()
+ Thread.sleep(gracefulWaitTime) // using Thread.sleep is okay, since
`poll` is blocking anyway
+ peek(duration, retry - 1)
+} else {
+ recreateConsumer()
+ throw e
+}
+ // Every other error results in a restart of the consumer
+ case e: Throwable =>
+recreateConsumer()
+throw e
+} finally wakeUpTask.cancel()
}
/**
* Commits offsets from last poll.
*/
- def commit() = consumer.commitSync()
+ def commit(retry: Int = 3): Unit =
+try {
+ consumer.commitSync()
+} catch {
+ case e: RetriableException =>
+if (retry > 0) {
+ logging.error(this, s"$e: retrying $retry more times")
Review comment:
(nit warning ahead): how about `retries left: $retry` to avoid this reading
`retrying 1 more times` here and elsewhere above and below.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] rabbah commented on a change in pull request #3072: Enhance kafka message provider
rabbah commented on a change in pull request #3072: Enhance kafka message
provider
URL:
https://github.com/apache/incubator-openwhisk/pull/3072#discussion_r164443383
##
File path: ansible/group_vars/all
##
@@ -135,6 +135,7 @@ kafka:
port: 8093
heap: "{{ kafka_heap | default('1g') }}"
replicationFactor: "{{ kafka_replicationFactor |
default((groups['kafkas']|length)|int) }}"
+ sessionTimeout: 3
Review comment:
do these values make sense as pure config props as well?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] rabbah commented on a change in pull request #3072: Enhance kafka message provider
rabbah commented on a change in pull request #3072: Enhance kafka message
provider
URL:
https://github.com/apache/incubator-openwhisk/pull/3072#discussion_r164447348
##
File path:
common/scala/src/main/scala/whisk/connector/kafka/KafkaConsumerConnector.scala
##
@@ -89,9 +134,18 @@ class KafkaConsumerConnector(kafkahost: String,
val keyDeserializer = new ByteArrayDeserializer
val valueDeserializer = new ByteArrayDeserializer
val consumer = new KafkaConsumer(props, keyDeserializer, valueDeserializer)
-topics foreach { consumer.subscribe(_) }
+topics.foreach(consumer.subscribe(_))
consumer
}
- private val consumer = getConsumer(getProps, Some(List(topic)))
+ private def recreateConsumer(): Unit = {
+val oldConsumer = consumer
+Future {
+ oldConsumer.close()
+ logging.info(this, s"old consumer closed")
+}
+consumer = getConsumer(getProps, Some(List(topic)))
+ }
+
+ @volatile private var consumer = getConsumer(getProps, Some(List(topic)))
Review comment:
i'm not sure that this needs to be volatile (and hence incur the performance
implications); in the architecture (controller's pings and active acks, or
invoker activation feed) there is one actor that is connected to the message
consumer and it serializes all the reads from the message bus.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] rabbah commented on a change in pull request #3072: Enhance kafka message provider
rabbah commented on a change in pull request #3072: Enhance kafka message
provider
URL:
https://github.com/apache/incubator-openwhisk/pull/3072#discussion_r164449615
##
File path:
common/scala/src/main/scala/whisk/core/database/RemoteCacheInvalidation.scala
##
@@ -60,8 +60,9 @@ class RemoteCacheInvalidation(config: WhiskConfig,
component: String, instance:
private val instanceId = s"$component${instance.toInt}"
private val msgProvider = SpiLoader.get[MessagingProvider]
- private val cacheInvalidationConsumer = msgProvider.getConsumer(config,
s"$topic$instanceId", topic, maxPeek = 128)
- private val cacheInvalidationProducer = msgProvider.getProducer(config, ec)
+ private val cacheInvalidationConsumer =
Review comment:
no change on this line, can the RHS move back to same line?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] csantanapr opened a new pull request #3231: update docs for ulimit and pid-limit
csantanapr opened a new pull request #3231: update docs for ulimit and pid-limit URL: https://github.com/apache/incubator-openwhisk/pull/3231 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] jonpspri commented on issue #212: Is there is reverse populate command opposite to ./gradlew goVendor
jonpspri commented on issue #212: Is there is reverse populate command opposite to ./gradlew goVendor URL: https://github.com/apache/incubator-openwhisk-cli/issues/212#issuecomment-361251421 I don't think the goVendor task is the problem. goTest needs to be tagged for 'unit', 'native' or 'integration' or else it will not run anything. Use '-PbuildTags=unit' for example to tag it. It's non-trivial to build a default tag into the gogradle build because the tags are global and the project only uses them during the testing phase. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] jonpspri commented on issue #212: Is there is reverse populate command opposite to ./gradlew goVendor
jonpspri commented on issue #212: Is there is reverse populate command opposite to ./gradlew goVendor URL: https://github.com/apache/incubator-openwhisk-cli/issues/212#issuecomment-361251421 Hmm... I need to do a little digging here... Let me see if I can reproduce the behavior. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] jonpspri commented on issue #211: How shall we deal with the traditional commands: ./gradlew test and ./gradlew build
jonpspri commented on issue #211: How shall we deal with the traditional commands: ./gradlew test and ./gradlew build URL: https://github.com/apache/incubator-openwhisk-cli/issues/211#issuecomment-361251186 Which tests are valid? In the travis build we run a subset of openwhisk tests to be sure CLI integration runs correctly, which is why test remains configured as it is. In my ideal world, we'd move the needed code for those tests into the 'incubator-openwhisk-cli' repository and eliminate the need for the Scala in the 'incubator-openwhisk' repository, but that may not be feasible -- I'll look for others' opinion on that. If we could do that relocation, that would make life easier. Otherwise, we can do some tinkering to overwrite the behavior of the :clitests:test task. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] markusthoemmes opened a new pull request #3230: Make HA tests for controller more lenient.
markusthoemmes opened a new pull request #3230: Make HA tests for controller more lenient. URL: https://github.com/apache/incubator-openwhisk/pull/3230 - Adjusts the value of allowed failures slightly. - Corrects no longer valid comment. - Uses the right value for limit calculation. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] shazron commented on issue #3208: Source files for images in docs folder
shazron commented on issue #3208: Source files for images in docs folder URL: https://github.com/apache/incubator-openwhisk/issues/3208#issuecomment-361195454 Since source files might be missing, what is an acceptable source format if we recreate? I'm biased to Adobe formats (surprise) but here's what I suggest: 1. Logos/icons (PSD, EPS) 2. Diagrams -- not sure. I'm avoiding some free "text to diagram" tools like [Mermaid](https://mermaidjs.github.io/) for perhaps something graphical like: a. [Dia](http://dia-installer.de/) - standalone cross platform app b. [LibreOffice Draw](https://www.libreoffice.org/discover/draw/) - standalone cross platform app c. [OpenOffice Draw](https://www.openoffice.org/product/draw.html) - standalone cross platform app d. [Diagramo](http://diagramo.com/) -- needs a PHP server to run in the browser (buggy, can't save on Mac) e. [draw.io](https://github.com/jgraph/drawio) Apachev2 - [online demo](https://draw.io), [offline demo](https://draw.io/app), [draw.io desktop](https://github.com/jgraph/drawio-desktop) ? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] shazron commented on issue #3208: Source files for images in docs folder
shazron commented on issue #3208: Source files for images in docs folder URL: https://github.com/apache/incubator-openwhisk/issues/3208#issuecomment-361195454 Since source files might be missing, what is an acceptable source format if we recreate? I'm biased to Adobe formats (surprise) but here's what I suggest: 1. Logos/icons (PSD, EPS) 2. Diagrams -- not sure. I'm avoiding some free "text to diagram" tools like [Mermaid](https://mermaidjs.github.io/) for perhaps something graphical like: a. [Dia](http://dia-installer.de/) - standalone cross platform app b. [LibreOffice Draw](https://www.libreoffice.org/discover/draw/) - standalone cross platform app c. [OpenOffice Draw](https://www.openoffice.org/product/draw.html) - standalone cross platform app d. [Diagramo](http://diagramo.com/) -- needs a PHP server to run in the browser (buggy, can't save on Mac) e. [draw.io](https://github.com/jgraph/drawio) Apachev2 - [online demo](https://draw.io), [draw.io desktop](https://github.com/jgraph/drawio-desktop) ? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] shazron commented on issue #3208: Source files for images in docs folder
shazron commented on issue #3208: Source files for images in docs folder URL: https://github.com/apache/incubator-openwhisk/issues/3208#issuecomment-361195454 Since source files might be missing, what is an acceptable source format if we recreate? I'm biased to Adobe formats (surprise) but here's what I suggest: 1. Logos/icons (PSD, EPS) 2. Diagrams -- not sure. I'm avoiding some free "text to diagram" tools like [Mermaid](https://mermaidjs.github.io/) for perhaps something graphical like: a. [Dia](http://dia-installer.de/) - standalone cross platform app b. [LibreOffice Draw](https://www.libreoffice.org/discover/draw/) - standalone cross platform app c. [OpenOffice Draw](https://www.openoffice.org/product/draw.html) - standalone cross platform app d. [Diagramo](http://diagramo.com/) -- needs a PHP server to run in the browser (buggy, can't save on Mac) e. [draw.io](https://github.com/jgraph/drawio) Apachev2 - [online demo](https://draw.io) [draw.io desktop](https://github.com/jgraph/drawio-desktop) ? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] shazron commented on issue #3208: Source files for images in docs folder
shazron commented on issue #3208: Source files for images in docs folder URL: https://github.com/apache/incubator-openwhisk/issues/3208#issuecomment-361195454 Since source files might be missing, what is an acceptable source format if we recreate? I'm biased to Adobe formats (surprise) but here's what I suggest: 1. Logos/icons (PSD, EPS) 2. Diagrams -- not sure. I'm avoiding some free "text to diagram" tools like [Mermaid](https://mermaidjs.github.io/) for perhaps something graphical like: a. [Dia](http://dia-installer.de/) - standalone cross platform app b. [LibreOffice Draw](https://www.libreoffice.org/discover/draw/) - standalone cross platform app c. [OpenOffice Draw](https://www.openoffice.org/product/draw.html) - standalone cross platform app d. [Diagramo](http://diagramo.com/) -- needs a PHP server to run in the browser (buggy, can't save on Mac) e. [draw.io](https://github.com/jgraph/drawio) Apachev2 - [demo](https://draw.io) ? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] shazron commented on issue #3208: Source files for images in docs folder
shazron commented on issue #3208: Source files for images in docs folder URL: https://github.com/apache/incubator-openwhisk/issues/3208#issuecomment-361195454 Since source files might be missing, what is an acceptable source format if we recreate? I'm biased to Adobe formats (surprise) but here's what I suggest: 1. Logos/icons (PSD, EPS) 2. Diagrams -- not sure. I'm avoiding some free "text to diagram" tools like Mermaid for perhaps something graphical like: a. [Dia](http://dia-installer.de/) - standalone cross platform app b. [LibreOffice Draw](https://www.libreoffice.org/discover/draw/) - standalone cross platform app c. [OpenOffice Draw](https://www.openoffice.org/product/draw.html) - standalone cross platform app d. [Diagramo](http://diagramo.com/) -- needs a PHP server to run in the browser (buggy, can't save on Mac) e. [draw.io](https://github.com/jgraph/drawio) Apachev2 - [demo](https://draw.io) ? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] shazron commented on issue #3208: Source files for images in docs folder
shazron commented on issue #3208: Source files for images in docs folder URL: https://github.com/apache/incubator-openwhisk/issues/3208#issuecomment-361195454 Since source files might be missing, what is an acceptable source format if we recreate? I'm biased to Adobe formats (surprise) but here's what I suggest: 1. Logos/icons (PSD, EPS) 2. Diagrams -- not sure. I'm avoiding some free "text to diagram" tools like Mermaid for perhaps something graphical like: a. [Dia](http://dia-installer.de/) - standalone cross platform app b. [LibreOffice Draw](https://www.libreoffice.org/discover/draw/) - standalone cross platform app c. [OpenOffice Draw](https://www.openoffice.org/product/draw.html) - standalone cross platform app d. [Diagramo](http://diagramo.com/) -- needs a PHP server to run in the browser (buggy, can't save on Mac) e. [draw.io](https://github.com/jgraph/drawio) Apachev2 - [demo](https://draw.io) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] shazron commented on issue #3208: Source files for images in docs folder
shazron commented on issue #3208: Source files for images in docs folder URL: https://github.com/apache/incubator-openwhisk/issues/3208#issuecomment-361195454 Since source files might be missing, what is an acceptable source format if we recreate? I'm biased to Adobe formats (surprise) but here's what I suggest: 1. Logos/icons (PSD, EPS) 2. Diagrams -- not sure. I'm avoiding some free "text to diagram" tools like Mermaid for perhaps something graphical like: a. [Dia](http://dia-installer.de/) - standalone cross platform app b. [LibreOffice Draw](https://www.libreoffice.org/discover/draw/) - standalone cross platform app c. [OpenOffice Draw](https://www.openoffice.org/product/draw.html) - standalone cross platform app d. [Diagramo](http://diagramo.com/) -- needs a PHP server to run in the browser (buggy, can't save on Mac) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
