[GitHub] [incubator-openwhisk-runtime-swift] ianpartridge opened a new issue #99: Support Swift 5

[GitBox]

ianpartridge opened a new issue #99: Support Swift 5
URL: https://github.com/apache/incubator-openwhisk-runtime-swift/issues/99
 
 
   Currently this runtime does not support Swift 5.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-openwhisk-runtime-swift] jthomas opened a new issue #98: Build is failing due to using `latest` image.

[GitBox]

jthomas opened a new issue #98: Build is failing due to using `latest` image.
URL: https://github.com/apache/incubator-openwhisk-runtime-swift/issues/98
 
 
   Need to be updated to use `nightly` per the recent changes.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-openwhisk] codecov-io commented on issue #4555: [WIP] [Scheduler] Add Etcd installation & modules

[GitBox]

codecov-io commented on issue #4555: [WIP] [Scheduler] Add Etcd installation & 
modules
URL: 
https://github.com/apache/incubator-openwhisk/pull/4555#issuecomment-512224534
 
 
   # 
[Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/4555?src=pr&el=h1)
 Report
   > Merging 
[#4555](https://codecov.io/gh/apache/incubator-openwhisk/pull/4555?src=pr&el=desc)
 into 
[master](https://codecov.io/gh/apache/incubator-openwhisk/commit/322d832857667a825ed4a3a0aa892a4a3fbce9f3?src=pr&el=desc)
 will **decrease** coverage by `5.45%`.
   > The diff coverage is `21.42%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/incubator-openwhisk/pull/4555/graphs/tree.svg?width=650&token=l0YmsiSAso&height=150&src=pr)](https://codecov.io/gh/apache/incubator-openwhisk/pull/4555?src=pr&el=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master#4555  +/-   ##
   ==
   - Coverage84.8%   79.35%   -5.46% 
   ==
 Files 176  178   +2 
 Lines8100 8170  +70 
 Branches  550  553   +3 
   ==
   - Hits 6869 6483 -386 
   - Misses   1231 1687 +456
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/incubator-openwhisk/pull/4555?src=pr&el=tree)
 | Coverage Δ | |
   |---|---|---|
   | 
[.../scala/org/apache/openwhisk/core/WhiskConfig.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/4555/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvV2hpc2tDb25maWcuc2NhbGE=)
 | `94.73% <100%> (+0.03%)` | :arrow_up: |
   | 
[...la/org/apache/openwhisk/core/etcd/EtcdClient.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/4555/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvZXRjZC9FdGNkQ2xpZW50LnNjYWxh)
 | `24.07% <24.07%> (ø)` | |
   | 
[...ala/org/apache/openwhisk/core/etcd/EtcdUtils.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/4555/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvZXRjZC9FdGNkVXRpbHMuc2NhbGE=)
 | `6.66% <6.66%> (ø)` | |
   | 
[...core/database/cosmosdb/RxObservableImplicits.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/4555/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvUnhPYnNlcnZhYmxlSW1wbGljaXRzLnNjYWxh)
 | `0% <0%> (-100%)` | :arrow_down: |
   | 
[...core/database/cosmosdb/CosmosDBArtifactStore.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/4555/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvQ29zbW9zREJBcnRpZmFjdFN0b3JlLnNjYWxh)
 | `0% <0%> (-95.89%)` | :arrow_down: |
   | 
[...sk/core/database/cosmosdb/CosmosDBViewMapper.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/4555/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvQ29zbW9zREJWaWV3TWFwcGVyLnNjYWxh)
 | `0% <0%> (-92.6%)` | :arrow_down: |
   | 
[...whisk/core/database/cosmosdb/CosmosDBSupport.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/4555/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvQ29zbW9zREJTdXBwb3J0LnNjYWxh)
 | `0% <0%> (-74.08%)` | :arrow_down: |
   | 
[...abase/cosmosdb/CosmosDBArtifactStoreProvider.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/4555/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvQ29zbW9zREJBcnRpZmFjdFN0b3JlUHJvdmlkZXIuc2NhbGE=)
 | `4% <0%> (-52%)` | :arrow_down: |
   | 
[...re/database/cosmosdb/CollectionResourceUsage.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/4555/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvQ29sbGVjdGlvblJlc291cmNlVXNhZ2Uuc2NhbGE=)
 | `72.22% <0%> (-27.78%)` | :arrow_down: |
   | 
[...in/scala/org/apache/openwhisk/common/Counter.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/4555/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvbW1vbi9Db3VudGVyLnNjYWxh)
 | `40% <0%> (-20%)` | :arrow_down: |
   | ... and [10 
more](https://codecov.io/gh/apache/incubator-openwhisk/pull/4555/diff?src=pr&el=tree-more)
 | |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/4555?src=pr&el=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/incubator-

[GitHub] [incubator-openwhisk-devtools] pepiparaskev30 opened a new issue #274: OPENWHISK MAKE QUICK START FALLS

[GitBox]

pepiparaskev30 opened a new issue #274: OPENWHISK MAKE QUICK START FALLS
URL: https://github.com/apache/incubator-openwhisk-devtools/issues/274
 
 
   Hello, please help me with the installation of Openwhisk:
   I have the below problem:
   I installed docker as it is referred in the instructions, after that i 
installed docker compose and java 8. 
   After that i made:
   git clone https://github.com/apache/incubator-openwhisk-devtools.git
   cd incubator-openwhisk-devtools/docker-compose
   make quick-start
   
   BUT ! THE INSTALLATION OF MAKE QUICK-START FALLS AND THE PROBLEM IS THE 
BELOW:
   Installing apimgmt package
   error: Package update failed: Put 
https://83.212.97.203/api/v1/namespaces/whisk.system/packages/apimgmt?overwrite=true:
 dial tcp 83.212.97.203:443: getsockopt: connection refused
   Makefile:352: recipe for target 'init-api-management' failed
   make: *** [init-api-management] Error 3
PLEASE HELP!!


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-openwhisk-release] rabbah commented on issue #265: document signing releases with "own" pgp key

[GitBox]

rabbah commented on issue #265: document signing releases with "own" pgp key
URL: 
https://github.com/apache/incubator-openwhisk-release/issues/265#issuecomment-511935851
 
 
   Instead of Travis, the semi-automatic build should be moved to our Apache 
Infra jenkins instead. The updated the documentation should disable the 
automatic Travis builds since they don't permit proper signing and a release 
manager must use the manual steps.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-openwhisk] rabbah opened a new pull request #4559: Allow parameters to be designated as init time properties

[GitBox]

rabbah opened a new pull request #4559: Allow parameters to be designated as 
init time properties
URL: https://github.com/apache/incubator-openwhisk/pull/4559
 
 
   As discussed on the [dev 
list](https://lists.apache.org/thread.html/7e03e6fc965d972882f4c76e34b2e9aa28579a0c3004d63d546e2611@%3Cdev.openwhisk.apache.org%3E)
 this patch allows parameters to be designated as init time parameters. The 
result of such a designation is that the corresponding parameters are 
communicated to the action at initialization time and should be exported to the 
action's environment accordingly. This change requires updates to the action 
runtimes for the latter details and will be done separately.
   
   This PR does not yet update the documentation since the CLI is also not 
updated and until we have all the runtime support in place, it doesn't make 
sense to document the feature yet. 
   
   The commit history shows the implementation evolution from using a heuristic 
to a parameter modifier. Each commit is self-contained and can be reviewed on 
its own.
   
   
   ## Description
   
   
   
   ## Related issue and scope
   
   - [x] I opened an issue to propose and discuss this change (#4558)
   
   ## My changes affect the following components
   
   
   - [x] API
   - [x] Controller
   - [ ] Message Bus (e.g., Kafka)
   - [ ] Loadbalancer
   - [x] Invoker
   - [ ] Intrinsic actions (e.g., sequences, conductors)
   - [ ] Data stores (e.g., CouchDB)
   - [ ] Tests
   - [ ] Deployment
   - [ ] CLI
   - [ ] General tooling
   - [ ] Documentation
   
   ## Types of changes
   
   - [ ] Bug fix (generally a non-breaking change which closes an issue).
   - [x] Enhancement or new feature (adds new functionality).
   - [ ] Breaking change (a bug fix or enhancement which changes existing 
behavior).
   
   ## Checklist:
   
   
   - [x] I signed an [Apache 
CLA](https://github.com/apache/incubator-openwhisk/blob/master/CONTRIBUTING.md).
   - [x] I reviewed the [style 
guides](https://github.com/apache/incubator-openwhisk/wiki/Contributing:-Git-guidelines#code-readiness)
 and followed the recommendations (Travis CI will check :).
   - [x] I added tests to cover my changes.
   - [x] My changes require further changes to the documentation.
   - [x] I updated the documentation where necessary.
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-openwhisk] rabbah opened a new issue #4558: Allow parameters to be designated as init time properties

[GitBox]

rabbah opened a new issue #4558: Allow parameters to be designated as init time 
properties
URL: https://github.com/apache/incubator-openwhisk/issues/4558
 
 
   As discussed on the [dev 
list](https://lists.apache.org/thread.html/7e03e6fc965d972882f4c76e34b2e9aa28579a0c3004d63d546e2611@%3Cdev.openwhisk.apache.org%3E),
 allows parameters to be designated as init time parameters. The result of such 
a designation is that the corresponding parameters are communicated to the 
action at initialization time and should be exported to the action's 
environment accordingly. This change requires updates to the action runtimes 
for the latter details and will be done separately. Additonal changes are 
required to the documentation once all the details are in place.
   
   1. [x] implement the core API change
   2. [ ] extends all the runtimes
   1. [x] nodejs
   2. [ ] c#
   3. [ ] all action loop related runtimes
   3. [ ] update cli (Add `-e`)
   4. [ ] update documentation (include examples of using this capability with 
`wsk` and functions)
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-openwhisk] KeonHee opened a new pull request #4555: [WIP] [Scheduler] Add Etcd installation & modules

[GitBox]

KeonHee opened a new pull request #4555: [WIP] [Scheduler] Add Etcd 
installation & modules
URL: https://github.com/apache/incubator-openwhisk/pull/4555
 
 
   
   
   ## Description
   
   
   
   This pr covers the [etcd](https://etcd.io/) installation and module 
implementation. And the etcd will be the coordinator of cluster members and the 
metadata store in the new scheduler.
   
   We will implement modules based on the order defined in this page and add 
design documents under the page as well:
   https://cwiki.apache.org/confluence/display/OPENWHISK/Component+Design
   
   But I can not write wiki document because I do not have write access to the 
wiki :(
   If you give me write access, I will write a document related to the etcd 
modules.
   
   ## My changes affect the following components
   
   
   - [ ] API
   - [ ] Controller
   - [ ] Message Bus (e.g., Kafka)
   - [ ] Loadbalancer
   - [ ] Invoker
   - [ ] Intrinsic actions (e.g., sequences, conductors)
   - [x] Data stores (e.g., CouchDB)
   - [x] Tests
   - [x] Deployment
   - [ ] CLI
   - [ ] General tooling
   - [ ] Documentation
   
   ## Types of changes
   
   - [ ] Bug fix (generally a non-breaking change which closes an issue).
   - [x] Enhancement or new feature (adds new functionality).
   - [ ] Breaking change (a bug fix or enhancement which changes existing 
behavior).
   
   ## Checklist:
   
   
   - [x] I signed an [Apache 
CLA](https://github.com/apache/incubator-openwhisk/blob/master/CONTRIBUTING.md).
   - [x] I reviewed the [style 
guides](https://github.com/apache/incubator-openwhisk/wiki/Contributing:-Git-guidelines#code-readiness)
 and followed the recommendations (Travis CI will check :).
   - [x] I added tests to cover my changes.
   - [x] My changes require further changes to the documentation.
   - [x] I updated the documentation where necessary.
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-openwhisk] KeonHee closed pull request #4555: [WIP] [Scheduler] Add Etcd installation & modules

[GitBox]

KeonHee closed pull request #4555: [WIP] [Scheduler] Add Etcd installation & 
modules
URL: https://github.com/apache/incubator-openwhisk/pull/4555
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-openwhisk-client-js] jthomas closed issue #165: Support passing annotations for rules

[GitBox]

jthomas closed issue #165: Support passing annotations for rules
URL: https://github.com/apache/incubator-openwhisk-client-js/issues/165
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-openwhisk-client-js] jthomas merged pull request #186: Add annotation support for rules, triggers and packages.

[GitBox]

jthomas merged pull request #186: Add annotation support for rules, triggers 
and packages.
URL: https://github.com/apache/incubator-openwhisk-client-js/pull/186
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-openwhisk-client-js] jthomas commented on issue #137: Error.captureStackTrace is not supported by firefox

[GitBox]

jthomas commented on issue #137: Error.captureStackTrace is not supported by 
firefox
URL: 
https://github.com/apache/incubator-openwhisk-client-js/issues/137#issuecomment-511823502
 
 
   This is now fixed. 
   
https://github.com/apache/incubator-openwhisk-client-js/blob/master/lib/openwhisk_error.js#L21-L24


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-openwhisk-client-js] jthomas closed issue #137: Error.captureStackTrace is not supported by firefox

[GitBox]

jthomas closed issue #137: Error.captureStackTrace is not supported by firefox
URL: https://github.com/apache/incubator-openwhisk-client-js/issues/137
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-openwhisk-client-js] jthomas commented on issue #179: Add CI/CD tools for NPM module dependency management.

[GitBox]

jthomas commented on issue #179: Add CI/CD tools for NPM module dependency 
management.
URL: 
https://github.com/apache/incubator-openwhisk-client-js/issues/179#issuecomment-511822838
 
 
   INFRA said no. Waiting for clarification on this rule after emailing the 
mailing list...


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-openwhisk-client-js] jthomas opened a new pull request #186: Add annotation support for rules, triggers and packages.

[GitBox]

jthomas opened a new pull request #186: Add annotation support for rules, 
triggers and packages.
URL: https://github.com/apache/incubator-openwhisk-client-js/pull/186
 
 
   This was missing but looking at the API and CLI should can be used with the 
following resources.
   
   Fixes #165


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-openwhisk-client-js] jthomas closed issue #181: CI/CD pipeline should test on all Node.js versions in runtime-nodejs

[GitBox]

jthomas closed issue #181: CI/CD pipeline should test on all Node.js versions 
in runtime-nodejs
URL: https://github.com/apache/incubator-openwhisk-client-js/issues/181
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-openwhisk-client-js] jthomas commented on issue #185: Run tests on node 8, 10, 12

[GitBox]

jthomas commented on issue #185: Run tests on node 8,10,12
URL: 
https://github.com/apache/incubator-openwhisk-client-js/pull/185#issuecomment-511739819
 
 
   @purplecabbage Thanks for the help on this!


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-openwhisk-client-js] jthomas merged pull request #185: Run tests on node 8, 10, 12

[GitBox]

jthomas merged pull request #185: Run tests on node 8,10,12
URL: https://github.com/apache/incubator-openwhisk-client-js/pull/185
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-openwhisk-client-js] jthomas closed issue #145: How to set http proxy in openwhisk sdk through nodejs js client

[GitBox]

jthomas closed issue #145: How to set http proxy in openwhisk sdk through 
nodejs js client 
URL: https://github.com/apache/incubator-openwhisk-client-js/issues/145
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-openwhisk-client-js] jthomas commented on issue #173: main.d.ts (typescript declarations) are a missing some optional arguments

[GitBox]

jthomas commented on issue #173: main.d.ts (typescript declarations) are a 
missing some optional arguments
URL: 
https://github.com/apache/incubator-openwhisk-client-js/issues/173#issuecomment-511738826
 
 
   @starpit I'm working on the next release shortly - if you want to submit a 
PR for this - I can get it merged and released...


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-openwhisk-client-js] jthomas closed issue #35: TypeScript Typings

[GitBox]

jthomas closed issue #35: TypeScript Typings
URL: https://github.com/apache/incubator-openwhisk-client-js/issues/35
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-openwhisk-client-js] jthomas commented on issue #183: Allow environment level set of default user-agent

[GitBox]

jthomas commented on issue #183: Allow environment level set of default 
user-agent
URL: 
https://github.com/apache/incubator-openwhisk-client-js/pull/183#issuecomment-511725435
 
 
   no problem - will be pushing out a new release of the library soon.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-openwhisk] KeonHee opened a new pull request #4555: [WIP] [Scheduler] Add Etcd installation & modules

[GitBox]

KeonHee opened a new pull request #4555: [WIP] [Scheduler] Add Etcd 
installation & modules
URL: https://github.com/apache/incubator-openwhisk/pull/4555
 
 
   
   
   ## Description
   
   
   
   This pr covers the [etcd](https://etcd.io/) installation and module 
implementation. And the etcd will be the coordinator of cluster members and the 
metadata store in the new scheduler.
   
   We will implement modules based on the order defined in this page and add 
design documents under the page as well:
   https://cwiki.apache.org/confluence/display/OPENWHISK/Component+Design
   
   But I can not write wiki document because I do not have write access to the 
wiki :(
   If you give me write access, I will write a document related to the etcd 
modules.
   
   ## My changes affect the following components
   
   
   - [ ] API
   - [ ] Controller
   - [ ] Message Bus (e.g., Kafka)
   - [ ] Loadbalancer
   - [ ] Invoker
   - [ ] Intrinsic actions (e.g., sequences, conductors)
   - [x] Data stores (e.g., CouchDB)
   - [x] Tests
   - [x] Deployment
   - [ ] CLI
   - [ ] General tooling
   - [ ] Documentation
   
   ## Types of changes
   
   - [ ] Bug fix (generally a non-breaking change which closes an issue).
   - [x] Enhancement or new feature (adds new functionality).
   - [ ] Breaking change (a bug fix or enhancement which changes existing 
behavior).
   
   ## Checklist:
   
   
   - [x] I signed an [Apache 
CLA](https://github.com/apache/incubator-openwhisk/blob/master/CONTRIBUTING.md).
   - [x] I reviewed the [style 
guides](https://github.com/apache/incubator-openwhisk/wiki/Contributing:-Git-guidelines#code-readiness)
 and followed the recommendations (Travis CI will check :).
   - [x] I added tests to cover my changes.
   - [x] My changes require further changes to the documentation.
   - [x] I updated the documentation where necessary.
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-openwhisk] KeonHee closed pull request #4555: [WIP] [Scheduler] Add Etcd installation & modules

[GitBox]

KeonHee closed pull request #4555: [WIP] [Scheduler] Add Etcd installation & 
modules
URL: https://github.com/apache/incubator-openwhisk/pull/4555
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-openwhisk] ningyougang opened a new pull request #4557: Activation grpc service

[GitBox]

ningyougang opened a new pull request #4557: Activation grpc service
URL: https://github.com/apache/incubator-openwhisk/pull/4557
 
 
   
   
   ## Description
   New scheduler design consideration
   https://cwiki.apache.org/confluence/display/OPENWHISK/Design+consideration
   
   System architecture
   https://cwiki.apache.org/confluence/display/OPENWHISK/System+Architecture
   
   This patch's design document
   https://cwiki.apache.org/confluence/display/OPENWHISK/ActivationServiceImpl
   
   ## Related issue and scope
   
   - [ ] I opened an issue to propose and discuss this change (#)
   
   ## My changes affect the following components
   This is new scheduler's one small component: ActivationServiceImpl, this 
provides akka-grpc service, Container(Proxy) can use akka-gprc framework to get 
ActivationMessage from ActivationServiceImpl
   
   ## Types of changes
   
   - [ ] Bug fix (generally a non-breaking change which closes an issue).
   - [x] Enhancement or new feature (adds new functionality).
   - [ ] Breaking change (a bug fix or enhancement which changes existing 
behavior).
   
   ## Checklist:
   
   
   - [x] I signed an [Apache 
CLA](https://github.com/apache/incubator-openwhisk/blob/master/CONTRIBUTING.md).
   - [ ] I reviewed the [style 
guides](https://github.com/apache/incubator-openwhisk/wiki/Contributing:-Git-guidelines#code-readiness)
 and followed the recommendations (Travis CI will check :).
   - [x] I added tests to cover my changes.
   - [ ] My changes require further changes to the documentation.
   - [ ] I updated the documentation where necessary.
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-openwhisk-client-js] purplecabbage opened a new pull request #185: Run tests on node 8, 10, 12

[GitBox]

purplecabbage opened a new pull request #185: Run tests on node 8,10,12
URL: https://github.com/apache/incubator-openwhisk-client-js/pull/185
 
 
   #181


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-openwhisk-client-js] purplecabbage commented on issue #183: Allow environment level set of default user-agent

[GitBox]

purplecabbage commented on issue #183: Allow environment level set of default 
user-agent
URL: 
https://github.com/apache/incubator-openwhisk-client-js/pull/183#issuecomment-511577054
 
 
   Thanks @jthomas !


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-openwhisk-devtools] rabbah commented on issue #273: Minio image tag not found in docker-compose.yaml

[GitBox]

rabbah commented on issue #273: Minio image tag not found in docker-compose.yaml
URL: 
https://github.com/apache/incubator-openwhisk-devtools/issues/273#issuecomment-511571012
 
 
   @c5haw thank you for the report and feedback. 
   
   > On a separate note, will these builds eventually be versioned or will they 
continue to be tagged in a backwards incompatible way? I am trying to create a 
build process that is deterministic and currently I am unable to achieve this.
   
   Yes, we need to do that as there are many developers depending on this now 
and we have released all the dependent components (modulo one more update to 
the main repo). 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-openwhisk] rabbah commented on issue #4525: Publish OpenWhisk standalone jar to Github release

[GitBox]

rabbah commented on issue #4525: Publish OpenWhisk standalone jar to Github 
release
URL: 
https://github.com/apache/incubator-openwhisk/issues/4525#issuecomment-511570251
 
 
   We should also update the our top level README to point to this path as the 
quick start imo.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-openwhisk] rabbah closed issue #4549: make quick-start doesn't work

[GitBox]

rabbah closed issue #4549: make quick-start doesn't work
URL: https://github.com/apache/incubator-openwhisk/issues/4549
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-openwhisk] rabbah commented on issue #4549: make quick-start doesn't work

[GitBox]

rabbah commented on issue #4549: make quick-start doesn't work
URL: 
https://github.com/apache/incubator-openwhisk/issues/4549#issuecomment-511570026
 
 
   @SamChb72 please update devtools and try again.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-openwhisk] style95 commented on issue #4555: [WIP] [Scheduler] Add Etcd installation & modules

[GitBox]

style95 commented on issue #4555: [WIP] [Scheduler] Add Etcd installation & 
modules
URL: 
https://github.com/apache/incubator-openwhisk/pull/4555#issuecomment-511516140
 
 
   @mhenke1 
   Thank you for the feedback.
   I have wanted this kind of discussion so that I shared my proposal via the 
mailing list and bi-weekly meeting.
   
https://lists.apache.org/list.html?d...@openwhisk.apache.org:lte=1M:Dominic%20Kim
   https://www.youtube.com/watch?v=cPQ_UOEK9d8
   
   Regarding etcd and zookeeper, I don't want to list up all the differences 
between them here because there are already many articles and materials out 
there.
   
   I have used and loved zookeeper for many years.
   But IMHO etcd is more lightweight and easy to operate than zookeeper.
   
   And IIRC, we are using zookeeper only for Kafka.
   Since my proposal is based on the assumption that we will rule out the kafka 
from the critical path in the future, so I believe we can replace zookeeper 
with etcd at some point.
   
   @sven-lange-last 
   Yes, we will definitely add switches to toggle our implementation and all 
modules will be disabled by default. Most of the modules are written in new 
files and based on SPI, I think we can easily achieve it.
   Thank you for the good suggestion.
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-openwhisk-wskdeploy] mrutkows opened a new issue #1061: Update HomeBrew release to have Apache prefix in name

[GitBox]

mrutkows opened a new issue #1061: Update HomeBrew release to have Apache 
prefix in name
URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/1061
 
 
   See thread here:
   https://lists.apache.org/list.html?d...@openwhisk.apache.org


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-openwhisk-client-go] rabbah commented on issue #124: Add documentation

[GitBox]

rabbah commented on issue #124: Add documentation
URL: 
https://github.com/apache/incubator-openwhisk-client-go/issues/124#issuecomment-511469123
 
 
   Thanks @tawalaya - I agree. If you are inclined to add documentation and 
send a PR, we'd be happy to accept it. You don't need a CLA for documentation 
changes.
   
   I think the client can benefit from some refactoring also but that's a 
separate topic.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-openwhisk-client-js] jthomas commented on issue #169: NPM package must follow all ASF guidelines

[GitBox]

jthomas commented on issue #169: NPM package must follow all ASF guidelines
URL: 
https://github.com/apache/incubator-openwhisk-client-js/issues/169#issuecomment-511467154
 
 
   Sent an email to the dev-list about the naming issue. All other requirements 
have been satisfied.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-openwhisk-client-go] tawalaya opened a new issue #124: Add documentation

[GitBox]

tawalaya opened a new issue #124: Add documentation
URL: https://github.com/apache/incubator-openwhisk-client-go/issues/124
 
 
   I was tiring to invoke a function using the this lib. I had to jump between 
the wsk client code and this to figure out what to do here. For instance 
[here](https://github.com/apache/incubator-openwhisk-client-go/blob/7862108c109b7f1bbb47d66edb0a35d4a3c080a7/whisk/action.go#L287)
 it would have been really helpful to know that prams should be a 
`map[string]interface{}` to send data.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-openwhisk-client-js] jthomas merged pull request #184: Replacing short-form license headers & fixing code lint issues.

[GitBox]

jthomas merged pull request #184: Replacing short-form license headers & fixing 
code lint issues.
URL: https://github.com/apache/incubator-openwhisk-client-js/pull/184
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-openwhisk-client-js] jthomas closed issue #162: Source files should have full rather than short license header.

[GitBox]

jthomas closed issue #162: Source files should have full rather than short 
license header.
URL: https://github.com/apache/incubator-openwhisk-client-js/issues/162
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-openwhisk-client-js] jthomas edited a comment on issue #169: NPM package must follow all ASF guidelines

[GitBox]

jthomas edited a comment on issue #169: NPM package must follow all ASF 
guidelines
URL: 
https://github.com/apache/incubator-openwhisk-client-js/issues/169#issuecomment-511443645
 
 
   - [x]  The readme tab needs to include the text of the incubation disclaimer.
   - [x]  npm install apache should not install an artefact containing 
unapproved code.
   - [x]  The latest release should not point to an artefact containing 
unapproved code e.g. a release candidate or snapshot.
   - [x]  Release candidates, nightlys or snapshots need to be clearly tagged.
   - [ ]  The license field should display the ALv2 license. 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-openwhisk-client-js] jthomas edited a comment on issue #169: NPM package must follow all ASF guidelines

[GitBox]

jthomas edited a comment on issue #169: NPM package must follow all ASF 
guidelines
URL: 
https://github.com/apache/incubator-openwhisk-client-js/issues/169#issuecomment-511443645
 
 
   - [x]  The readme tab needs to include the text of the incubation disclaimer.
   - [x]  npm install apache should not install an artefact containing 
unapproved code.
   - [x]  The latest release should not point to an artefact containing 
unapproved code e.g. a release candidate or snapshot.
   - [x]  Release candidates, nightlys or snapshots need to be clearly tagged.
   - [x]  The license field should display the ALv2 license. 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-openwhisk-client-js] jthomas edited a comment on issue #169: NPM package must follow all ASF guidelines

[GitBox]

jthomas edited a comment on issue #169: NPM package must follow all ASF 
guidelines
URL: 
https://github.com/apache/incubator-openwhisk-client-js/issues/169#issuecomment-511443645
 
 
   - [x]  The readme tab needs to include the text of the incubation disclaimer.
   - [x]  npm install apache should not install an artefact containing 
unapproved code.
   - [x]  The latest release should not point to an artefact containing 
unapproved code e.g. a release candidate or snapshot.
   - [ ]  Release candidates, nightlys or snapshots need to be clearly tagged.
   - [ ]  The license field should display the ALv2 license. 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-openwhisk-client-js] jthomas edited a comment on issue #169: NPM package must follow all ASF guidelines

[GitBox]

jthomas edited a comment on issue #169: NPM package must follow all ASF 
guidelines
URL: 
https://github.com/apache/incubator-openwhisk-client-js/issues/169#issuecomment-511443645
 
 
   - [x]  The readme tab needs to include the text of the incubation disclaimer.
   - [ ]  npm install apache should not install an artefact containing 
unapproved code.
   - [ ]  The latest release should not point to an artefact containing 
unapproved code e.g. a release candidate or snapshot.
   - [ ]  Release candidates, nightlys or snapshots need to be clearly tagged.
   - [ ]  The license field should display the ALv2 license. 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-openwhisk-client-js] jthomas edited a comment on issue #169: NPM package must follow all ASF guidelines

[GitBox]

jthomas edited a comment on issue #169: NPM package must follow all ASF 
guidelines
URL: 
https://github.com/apache/incubator-openwhisk-client-js/issues/169#issuecomment-511443645
 
 
   - [x]  The readme tab needs to include the text of the incubation disclaimer.
   - [x]  npm install apache should not install an artefact containing 
unapproved code.
   - [ ]  The latest release should not point to an artefact containing 
unapproved code e.g. a release candidate or snapshot.
   - [ ]  Release candidates, nightlys or snapshots need to be clearly tagged.
   - [ ]  The license field should display the ALv2 license. 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-openwhisk-client-js] jthomas commented on issue #169: NPM package must follow all ASF guidelines

[GitBox]

jthomas commented on issue #169: NPM package must follow all ASF guidelines
URL: 
https://github.com/apache/incubator-openwhisk-client-js/issues/169#issuecomment-511443645
 
 
   - [ ]  The readme tab needs to include the text of the incubation disclaimer.
   - [ ]  npm install apache should not install an artefact containing 
unapproved code.
   - [ ]  The latest release should not point to an artefact containing 
unapproved code e.g. a release candidate or snapshot.
   - [ ]  Release candidates, nightlys or snapshots need to be clearly tagged.
   - [ ]  The license field should display the ALv2 license. 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-openwhisk-client-js] jthomas closed issue #160: Should we ship "built" version of library to NPM?

[GitBox]

jthomas closed issue #160: Should we ship "built" version of library to NPM?
URL: https://github.com/apache/incubator-openwhisk-client-js/issues/160
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-openwhisk-client-js] jthomas commented on issue #160: Should we ship "built" version of library to NPM?

[GitBox]

jthomas commented on issue #160: Should we ship "built" version of library to 
NPM?
URL: 
https://github.com/apache/incubator-openwhisk-client-js/issues/160#issuecomment-511441776
 
 
   Doing some more research into this... I don't think it's worth it. 
   
   Most of the package size (<95%) comes from the external dependency (needle) 
and its dependencies, rather than the the project code. Bundling and shipping 
external dependencies in the published library code is not compatible with ASF 
rules on releases. This means there will be minimal benefits from doing the 
bundling for the project code. 
   
   I'm going to close this issue as it doesn't seem worth doing. 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-openwhisk-client-js] jthomas opened a new pull request #184: Replacing short-form license headers & fixing code lint issues.

[GitBox]

jthomas opened a new pull request #184: Replacing short-form license headers & 
fixing code lint issues.
URL: https://github.com/apache/incubator-openwhisk-client-js/pull/184
 
 
   Correct license headers in JS files with full header. Fixes #162.
   This was raised in the last release vote from the mentors.
   
   Also, ran the `standard --fix` tool to resolve all minor code lint issues 
discovered.
   
   This PR has no functional changes to the code.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-openwhisk] duynguyen commented on issue #4503: Add option for appending runtimes registry to user provided images

[GitBox]

duynguyen commented on issue #4503: Add option for appending runtimes registry 
to user provided images
URL: 
https://github.com/apache/incubator-openwhisk/pull/4503#issuecomment-511362941
 
 
   sorry I was out of office for a while, and catching up with this PR now. 
Will make new changes according to review comments.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-openwhisk-client-js] jthomas merged pull request #183: Allow environment level set of default user-agent

[GitBox]

jthomas merged pull request #183: Allow environment level set of default 
user-agent
URL: https://github.com/apache/incubator-openwhisk-client-js/pull/183
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-openwhisk] Guoyoyo closed issue #4554: openwhisk Hello World error!! wsk api list error !!

[GitBox]

Guoyoyo closed issue #4554: openwhisk Hello World error!! wsk api list error !!
URL: https://github.com/apache/incubator-openwhisk/issues/4554
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-openwhisk] sven-lange-last edited a comment on issue #4556: Execute OpenWhisk action via Ignite and Firecracker VM

[GitBox]

sven-lange-last edited a comment on issue #4556: Execute OpenWhisk action via 
Ignite and Firecracker VM
URL: 
https://github.com/apache/incubator-openwhisk/pull/4556#issuecomment-511227672
 
 
   @chetanmeh thanks a lot for providing this Ignite / Firecracker starter.
   
   * Would you know how network connectivity is realized for the created VMs?
   * Is it possible to run Firecracker VMs within a virtualization like Xen / 
KVM / VirtualBox or is a bare metal Linux system required?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-openwhisk] sven-lange-last commented on issue #4556: Execute OpenWhisk action via Ignite and Firecracker VM

[GitBox]

sven-lange-last commented on issue #4556: Execute OpenWhisk action via Ignite 
and Firecracker VM
URL: 
https://github.com/apache/incubator-openwhisk/pull/4556#issuecomment-511227672
 
 
   @chetanmeh thanks a lot for providing this Ignite / Firecracker starter.
   
   * Would you know how network connectivity is realized for the created VMs?
   * Is it possible to run Firecracker VMs within a virtualization like Xen / 
VirtualBox or is a bare metal Linux system required?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-openwhisk-runtime-python] mrutkows merged pull request #65: Fix some typos and syntax errors on README.md

[GitBox]

mrutkows merged pull request #65: Fix some typos and syntax errors on README.md
URL: https://github.com/apache/incubator-openwhisk-runtime-python/pull/65
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-openwhisk-client-js] codecov-io edited a comment on issue #183: Allow environment level set of default user-agent

[GitBox]

codecov-io edited a comment on issue #183: Allow environment level set of 
default user-agent
URL: 
https://github.com/apache/incubator-openwhisk-client-js/pull/183#issuecomment-510779244
 
 
   # 
[Codecov](https://codecov.io/gh/apache/incubator-openwhisk-client-js/pull/183?src=pr&el=h1)
 Report
   > Merging 
[#183](https://codecov.io/gh/apache/incubator-openwhisk-client-js/pull/183?src=pr&el=desc)
 into 
[master](https://codecov.io/gh/apache/incubator-openwhisk-client-js/commit/feb6a887e8c613106713fbf414228d139fc14b20?src=pr&el=desc)
 will **not change** coverage.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/incubator-openwhisk-client-js/pull/183/graphs/tree.svg?width=650&token=j2mPEx0Tkq&height=150&src=pr)](https://codecov.io/gh/apache/incubator-openwhisk-client-js/pull/183?src=pr&el=tree)
   
   ```diff
   @@   Coverage Diff   @@
   ##   master #183   +/-   ##
   ===
 Coverage   99.26%   99.26%   
   ===
 Files  14   14   
 Lines 409  409   
   ===
 Hits  406  406   
 Misses  33
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/incubator-openwhisk-client-js/pull/183?src=pr&el=tree)
 | Coverage Δ | |
   |---|---|---|
   | 
[lib/client.js](https://codecov.io/gh/apache/incubator-openwhisk-client-js/pull/183/diff?src=pr&el=tree#diff-bGliL2NsaWVudC5qcw==)
 | `98.85% <ø> (ø)` | :arrow_up: |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/incubator-openwhisk-client-js/pull/183?src=pr&el=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/incubator-openwhisk-client-js/pull/183?src=pr&el=footer).
 Last update 
[feb6a88...478c413](https://codecov.io/gh/apache/incubator-openwhisk-client-js/pull/183?src=pr&el=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-openwhisk-apigateway] rabbah commented on issue #345: container cannot resolve http://host.docker.internal

[GitBox]

rabbah commented on issue #345: container cannot resolve 
http://host.docker.internal
URL: 
https://github.com/apache/incubator-openwhisk-apigateway/issues/345#issuecomment-511002000
 
 
   i'll verify but i believe my steps were: `wskdev apigw 
-e"whisk_api_host_name=host.docker.internal"`
   and then i uses the `sls` cli but it failed with the issue above but i found 
that `wsk` actually worked (i do not recall if i had to do anything special for 
`wsk`).
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-openwhisk-apigateway] ddragosd commented on issue #345: container cannot resolve http://host.docker.internal

[GitBox]

ddragosd commented on issue #345: container cannot resolve 
http://host.docker.internal
URL: 
https://github.com/apache/incubator-openwhisk-apigateway/issues/345#issuecomment-510997977
 
 
   @rabbah how can I simulate your local setup so I can debug more ? Do I just 
simply `docker run` the OW GW ? 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-openwhisk-client-js] jthomas closed issue #159: Add CI check to validate install size?

[GitBox]

jthomas closed issue #159: Add CI check to validate install size?
URL: https://github.com/apache/incubator-openwhisk-client-js/issues/159
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-openwhisk-client-js] jthomas closed issue #177: Update package dependencies to latest versions.

[GitBox]

jthomas closed issue #177: Update package dependencies to latest versions.
URL: https://github.com/apache/incubator-openwhisk-client-js/issues/177
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-openwhisk-devtools] c5haw opened a new issue #273: Minio image tag not found in docker-compose.yaml

[GitBox]

c5haw opened a new issue #273: Minio image tag not found in docker-compose.yaml
URL: https://github.com/apache/incubator-openwhisk-devtools/issues/273
 
 
   
https://github.com/apache/incubator-openwhisk-devtools/blob/c3ce36d2086d06427e73df35a9370c55269c2ded/docker-compose/docker-compose.yml#L134
   
   I am trying to run your `make start-docker-compose` script which executes 
docker-compose up on `docker-compose.yaml`. I am getting the following error:
   
   ```
   .Pulling minio (minio/minio:RELEASE.2018-07-13T00-09-07Z)...
   ..ERROR: Get 
https://registry-1.docker.io/v2/minio/minio/manifests/RELEASE.2018-07-13T00-09-07Z:
 Get 
https://auth.docker.io/token?scope=repository%3Aminio%2Fminio%3Apull&service=registry.docker.io:
 EOF
   ```
   
   I have looked on the builds for minio on Docker Hub and I can see that the 
tag referenced does not exist:
   [Minio tags](https://hub.docker.com/r/minio/minio/builds?page=10)
   
   This is one of a number of issues that seem to have cropped up, that I am 
finding, since a recent update to the repository, such as having changed how 
you tag your images, which has broken older versions of the docker-compose 
process using the `Makefile`.
   
   On a separate note, will these builds eventually be versioned or will they 
continue to be tagged in a backwards incompatible way? I am trying to create a 
build process that is deterministic and currently I am unable to achieve this.
   
   Thanks!


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-openwhisk] rabbah commented on issue #4301: add firecracker container factory implementation

[GitBox]

rabbah commented on issue #4301: add firecracker container factory 
implementation 
URL: 
https://github.com/apache/incubator-openwhisk/issues/4301#issuecomment-510893035
 
 
   @chetanmeh already has a prototype! 
https://github.com/apache/incubator-openwhisk/pull/4556


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-openwhisk] chetanmeh opened a new pull request #4556: Execute OpenWhisk action via Ignite and Firecracker VM

[GitBox]

chetanmeh opened a new pull request #4556: Execute OpenWhisk action via Ignite 
and Firecracker VM
URL: https://github.com/apache/incubator-openwhisk/pull/4556
 
 
   This is a proof of concept to execute OpenWhisk actions via [Weave 
Ignite][1] which uses [Firecracker MicroVMs][2]
   
   Recently [Weave works announced Ignite][3] project which supports running 
compatible docker images as [Firecracker MicroVMs][4]. Such an execution can 
provide better security compared to simple container based execution. 
   
   ## Objective
   
   Some of the key aspects here are
   
   1. Rebuild OpenWhisk runtime as Ignote compatible docker image
   2. Execute action via vm build from those images
   
   ## Usage
   
   ### 1. Install Ignite
   
   Follow the [Ignite installation steps][6] and ensure that required 
[dependencies][7] are met. OpenWhisk would check for `ignite` cli  at 
`/usr/local/bin/ignite`
   
   ### 2. Build a Ignite compatible docker image for nodejs. 
   
   Currently a docker file is provided for nodejs 12 [here][5]
   
   ```bash
   $ cd tools/ignite/nodejs
   $ docker build -t whisk/ignite-nodejs-v12:latest  .
   ```
   
   ### 3. Build the standalone OpenWhisk
   
   ```bash
   $ ./gradlew :core:standalone:build
   ```
   
   ### 4. Start the server
   
   Start the server passing a custom runtime manifest which refers to new 
nodejs docker image build in previous steps
   
   ```
   $ sudo java 
-Dwhisk.spi.ContainerFactoryProvider=org.apache.openwhisk.core.containerpool.ignite.IgniteContainerFactoryProvider
 \
 -jar bin/openwhisk-standalone.jar \
 -m tools/ignite/ignite-runtimes.json 
   ```
   
   Note that this is run with `sudo` as `ignite` needs root access to run. Once 
started it would launch 2 pre warm containers (vms!)
   
   In startup logs you can see the vm being created
   
   ```
   [2019-07-12T18:12:07.811Z] [INFO] [#tid_sid_unknown] [IgniteClient] Detected 
ignite client version Ignite version: version.Info{Major:"0", Minor:"4", 
GitVersion:"v0.4.0", GitCommit:"e0e7e8c50cd3c6532486625393dff4d415081829", 
GitTreeState:"clean", BuildDate:"2019-07-10T12:30:11Z", GoVersion:"go1.12.1", 
Compiler:"gc", Platform:"linux/amd64"}
   Firecracker version: v0.17.0
   [2019-07-12T18:12:08.080Z] [INFO] [#tid_sid_invokerWarmup] [IgniteClient] 
running /usr/local/bin/ignite -q image import whisk/ignite-nodejs-v12:latest 
(timeout: 10 minutes) [marker:invoker_ignite.image_start:1384]
   [2019-07-12T18:12:08.101Z] [INFO] [#tid_sid_invokerWarmup] [IgniteClient] 
running /usr/local/bin/ignite -q run whisk/ignite-nodejs-v12:latest --cpus 1 
--memory 256m --size 1GB --name wsk0_1_prewarm_nodejs12 (timeout: 5 minutes) 
[marker:invoker_ignite.run_start:1406]
   ```
   
   Checking running vms
   
   ```
   # ignite vm ps 
   VM ID   IMAGE   KERNEL   
   CREATED SIZECPUSMEMORY  STATE   IPS  
   PORTS   NAME
   296c4f2fd75bf834whisk/ignite-nodejs-v12:latest  
weaveworks/ignite-kernel:4.19.4717s ago 1024.0 MB   1   256.0 
MBRunning 172.17.0.10wsk0_1_prewarm_nodejs12
   e9c77eb3f95e7d7cwhisk/ignite-nodejs-v12:latest  
weaveworks/ignite-kernel:4.19.4717s ago 1024.0 MB   1   256.0 
MBRunning 172.17.0.11wsk0_2_prewarm_nodejs12
   ```
   
   There would also be 2 "proxy" docker container for these 2 vm
   
   ```
   # docker ps
   CONTAINER IDIMAGE COMMAND
  CREATED STATUS  PORTS 
NAMES
   f94d7c15ed90weaveworks/ignite:v0.4.0  
"/usr/local/bin/igni…"   28 seconds ago  Up 24 seconds  

   ignite-e9c77eb3f95e7d7c
   be939a1e2d5aweaveworks/ignite:v0.4.0  
"/usr/local/bin/igni…"   29 seconds ago  Up 25 seconds
   ```
   
   Now you can invoke js action
   
   ```json
   {
   "namespace": "guest",
   "name": "hello",
   "version": "0.0.1",
   "subject": "guest",
   "activationId": "1b86c507e4df4b6286c507e4df3b62ea",
   "start": 1562937307810,
   "end": 1562937323341,
   "duration": 15531,
   "statusCode": 0,
   "response": {
   "status": "success",
   "statusCode": 0,
   "success": true,
   "result": {
   "LANG": "en_US.UTF-8",
   "PATH": "/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin",
   "__OW_ACTION_NAME": "/guest/hello",
   "__OW_ACTIVATION_ID": "1b86c507e4df4b6286c507e4df3b62ea",
   "__OW_DEADLINE": "1562937383336",
   "__OW_NAMESPACE": "guest",
   "payload": "hello, world"
   }
   },
   "logs": [],
   "annot

[GitHub] [incubator-openwhisk-client-js] jthomas commented on a change in pull request #183: Allow environment level set of default user-agent

[GitBox]

jthomas commented on a change in pull request #183: Allow environment level set 
of default user-agent
URL: 
https://github.com/apache/incubator-openwhisk-client-js/pull/183#discussion_r302933173
 
 

 ##
 File path: lib/client.js
 ##
 @@ -141,7 +141,7 @@ class Client {
 url: this.pathUrl(path),
 rejectUnauthorized: !this.options.ignoreCerts,
 headers: {
-  'User-Agent': (options && options['User-Agent']) || 
'openwhisk-client-js',
+  'User-Agent': (options && options['User-Agent']) || 
process.env['USER_AGENT'] || 'openwhisk-client-js',
 
 Review comment:
   Environment variable name should follow existing configuration pattern for 
the library and start with `__OW` prefix, e.g. `__OW_USER_AGENT`. 
   https://github.com/apache/incubator-openwhisk-client-js#environment-variables


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-openwhisk-client-js] jthomas commented on issue #183: Allow environment level set of default user-agent

[GitBox]

jthomas commented on issue #183: Allow environment level set of default 
user-agent
URL: 
https://github.com/apache/incubator-openwhisk-client-js/pull/183#issuecomment-510844494
 
 
   This makes sense to me (once the code review changes has been implemented).


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-openwhisk] sven-lange-last commented on issue #4555: [WIP] [Scheduler] Add Etcd installation & modules

[GitBox]

sven-lange-last commented on issue #4555: [WIP] [Scheduler] Add Etcd 
installation & modules
URL: 
https://github.com/apache/incubator-openwhisk/pull/4555#issuecomment-510825951
 
 
   My general comment on this PR is that it unconditionally adds system tests 
like `EtcdClientTests` that require a deployed etcd. In the dev mailing list 
discussion, a feature flag was requested for the architecture change: 
https://lists.apache.org/thread.html/63696c7bee9effb57118fe24513789d5538ea3a64af1204fccde73e8@%3Cdev.openwhisk.apache.org%3E.
   
   By default, etcd should not be deployed and tests requiring etcd should not 
be run.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-openwhisk] mhenke1 commented on issue #4555: [WIP] [Scheduler] Add Etcd installation & modules

[GitBox]

mhenke1 commented on issue #4555: [WIP] [Scheduler] Add Etcd installation & 
modules
URL: 
https://github.com/apache/incubator-openwhisk/pull/4555#issuecomment-510819259
 
 
   @KeonHee  @style95  Was the usage of another "distributed state store" 
beside Zookeeper discussed on the mailing list or somewhere else ? On a first 
glance this feels wrong to add more complexity into the system.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-openwhisk] mhenke1 commented on issue #4555: [WIP] [Scheduler] Add Etcd installation & modules

[GitBox]

mhenke1 commented on issue #4555: [WIP] [Scheduler] Add Etcd installation & 
modules
URL: 
https://github.com/apache/incubator-openwhisk/pull/4555#issuecomment-510818245
 
 
   @KeonHee As discussed before, please put the new test code behind a feature 
toggle in a way that they are not executed as long the "new architecture" is 
not exploited (you could use the "assume" assertion of Scalatest based on a 
Ansible property).


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-openwhisk] KeonHee opened a new pull request #4555: [Scheduler] Add Etcd installation & modules

[GitBox]

KeonHee opened a new pull request #4555: [Scheduler] Add Etcd installation & 
modules
URL: https://github.com/apache/incubator-openwhisk/pull/4555
 
 
   
   
   ## Description
   
   
   
   This pr covers the [etcd](https://etcd.io/) installation and module 
implementation. And the etcd will be the coordinator of cluster members and the 
metadata store in the new scheduler.
   
   We will implement modules based on the order defined in this page and add 
design documents under the page as well:
   https://cwiki.apache.org/confluence/display/OPENWHISK/Component+Design
   
   But I can not write wiki document because I do not have write access to the 
wiki :(
   If you give me write access, I will write a document related to the etcd 
modules.
   
   ## My changes affect the following components
   
   
   - [ ] API
   - [ ] Controller
   - [ ] Message Bus (e.g., Kafka)
   - [ ] Loadbalancer
   - [ ] Invoker
   - [ ] Intrinsic actions (e.g., sequences, conductors)
   - [x] Data stores (e.g., CouchDB)
   - [x] Tests
   - [x] Deployment
   - [ ] CLI
   - [ ] General tooling
   - [ ] Documentation
   
   ## Types of changes
   
   - [ ] Bug fix (generally a non-breaking change which closes an issue).
   - [x] Enhancement or new feature (adds new functionality).
   - [ ] Breaking change (a bug fix or enhancement which changes existing 
behavior).
   
   ## Checklist:
   
   
   - [x] I signed an [Apache 
CLA](https://github.com/apache/incubator-openwhisk/blob/master/CONTRIBUTING.md).
   - [x] I reviewed the [style 
guides](https://github.com/apache/incubator-openwhisk/wiki/Contributing:-Git-guidelines#code-readiness)
 and followed the recommendations (Travis CI will check :).
   - [x] I added tests to cover my changes.
   - [x] My changes require further changes to the documentation.
   - [x] I updated the documentation where necessary.
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-openwhisk-client-js] codecov-io commented on issue #183: Allow environment level set of default user-agent

[GitBox]

codecov-io commented on issue #183: Allow environment level set of default 
user-agent
URL: 
https://github.com/apache/incubator-openwhisk-client-js/pull/183#issuecomment-510779244
 
 
   # 
[Codecov](https://codecov.io/gh/apache/incubator-openwhisk-client-js/pull/183?src=pr&el=h1)
 Report
   > Merging 
[#183](https://codecov.io/gh/apache/incubator-openwhisk-client-js/pull/183?src=pr&el=desc)
 into 
[master](https://codecov.io/gh/apache/incubator-openwhisk-client-js/commit/feb6a887e8c613106713fbf414228d139fc14b20?src=pr&el=desc)
 will **not change** coverage.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/incubator-openwhisk-client-js/pull/183/graphs/tree.svg?width=650&token=j2mPEx0Tkq&height=150&src=pr)](https://codecov.io/gh/apache/incubator-openwhisk-client-js/pull/183?src=pr&el=tree)
   
   ```diff
   @@   Coverage Diff   @@
   ##   master #183   +/-   ##
   ===
 Coverage   99.26%   99.26%   
   ===
 Files  14   14   
 Lines 409  409   
   ===
 Hits  406  406   
 Misses  33
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/incubator-openwhisk-client-js/pull/183?src=pr&el=tree)
 | Coverage Δ | |
   |---|---|---|
   | 
[lib/client.js](https://codecov.io/gh/apache/incubator-openwhisk-client-js/pull/183/diff?src=pr&el=tree#diff-bGliL2NsaWVudC5qcw==)
 | `98.85% <ø> (ø)` | :arrow_up: |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/incubator-openwhisk-client-js/pull/183?src=pr&el=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/incubator-openwhisk-client-js/pull/183?src=pr&el=footer).
 Last update 
[feb6a88...c7353d4](https://codecov.io/gh/apache/incubator-openwhisk-client-js/pull/183?src=pr&el=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-openwhisk-client-js] purplecabbage opened a new pull request #183: Allow environment level set of default user-agent

[GitBox]

purplecabbage opened a new pull request #183: Allow environment level set of 
default user-agent
URL: https://github.com/apache/incubator-openwhisk-client-js/pull/183
 
 
   Currently it is very difficult to set the user agent globally.
   We have a library which is using this library, and changing the user-agent 
to something we can track requires modifying the options to every client call.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-openwhisk-deploy-kube] dgrove-oss commented on issue #473: Deployment into OpenShift

[GitBox]

dgrove-oss commented on issue #473: Deployment into OpenShift
URL: 
https://github.com/apache/incubator-openwhisk-deploy-kube/issues/473#issuecomment-510622042
 
 
   Merged #465.  Please give it a try.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-openwhisk-deploy-kube] dgrove-oss closed issue #473: Deployment into OpenShift

[GitBox]

dgrove-oss closed issue #473: Deployment into OpenShift
URL: https://github.com/apache/incubator-openwhisk-deploy-kube/issues/473
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-openwhisk-deploy-kube] dgrove-oss merged pull request #491: Use most recent release for runtimes and apigateway

[GitBox]

dgrove-oss merged pull request #491: Use most recent release for runtimes and 
apigateway
URL: https://github.com/apache/incubator-openwhisk-deploy-kube/pull/491
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-openwhisk-deploy-kube] dgrove-oss merged pull request #465: first pass at OKD/OpenShift documentation

[GitBox]

dgrove-oss merged pull request #465: first pass at OKD/OpenShift documentation
URL: https://github.com/apache/incubator-openwhisk-deploy-kube/pull/465
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-openwhisk-devtools] rabbah merged pull request #272: Fixed Kafka provider setup

[GitBox]

rabbah merged pull request #272: Fixed Kafka provider setup
URL: https://github.com/apache/incubator-openwhisk-devtools/pull/272
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-openwhisk-devtools] rabbah closed issue #271: Error setup Kafka provider

[GitBox]

rabbah closed issue #271: Error setup Kafka provider
URL: https://github.com/apache/incubator-openwhisk-devtools/issues/271
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-openwhisk-devtools] rabbah commented on issue #271: Error setup Kafka provider

[GitBox]

rabbah commented on issue #271: Error setup Kafka provider
URL: 
https://github.com/apache/incubator-openwhisk-devtools/issues/271#issuecomment-510562220
 
 
   closed by #272 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-openwhisk-devtools] rabbah commented on issue #272: Fixed Kafka provider setup

[GitBox]

rabbah commented on issue #272: Fixed Kafka provider setup
URL: 
https://github.com/apache/incubator-openwhisk-devtools/pull/272#issuecomment-510562073
 
 
   Thanks @phlucas96!


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-openwhisk-devtools] rabbah commented on a change in pull request #272: Fixed Kafka provider setup

[GitBox]

rabbah commented on a change in pull request #272: Fixed Kafka provider setup
URL: 
https://github.com/apache/incubator-openwhisk-devtools/pull/272#discussion_r302615681
 
 

 ##
 File path: docker-compose/Makefile
 ##
 @@ -450,6 +450,8 @@ setup-providers:
printf "ENDPOINT_AUTH=`cat $(realpath 
$(OPENWHISK_PROJECT_HOME))/ansible/files/auth.whisk.system`\n" >> 
$(TMP_HOME)/tmp/openwhisk/providers.env
printf "HOST_MACHINE=$(DOCKER_HOST_IP)\n" >> 
$(TMP_HOME)/tmp/openwhisk/providers.env
printf "DOCKER_COMPOSE_HOST=$(DOCKER_HOST_IP)\n" >> 
$(TMP_HOME)/tmp/openwhisk/providers.env
+   printf "DOCKER_IMAGE_PREFIX"="openwhisk\n" >> 
$(TMP_HOME)/tmp/openwhisk/providers.env
+   printf "DOCKER_IMAGE_TAG"="nightly\n" >> 
$(TMP_HOME)/tmp/openwhisk/providers.env
 
 Review comment:
   ```suggestion
 printf "DOCKER_IMAGE_TAG=$(DOCKER_IMAGE_TAG)\n" >> 
$(TMP_HOME)/tmp/openwhisk/local.env
   ```


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-openwhisk-devtools] rabbah commented on a change in pull request #272: Fixed Kafka provider setup

[GitBox]

rabbah commented on a change in pull request #272: Fixed Kafka provider setup
URL: 
https://github.com/apache/incubator-openwhisk-devtools/pull/272#discussion_r302615681
 
 

 ##
 File path: docker-compose/Makefile
 ##
 @@ -450,6 +450,8 @@ setup-providers:
printf "ENDPOINT_AUTH=`cat $(realpath 
$(OPENWHISK_PROJECT_HOME))/ansible/files/auth.whisk.system`\n" >> 
$(TMP_HOME)/tmp/openwhisk/providers.env
printf "HOST_MACHINE=$(DOCKER_HOST_IP)\n" >> 
$(TMP_HOME)/tmp/openwhisk/providers.env
printf "DOCKER_COMPOSE_HOST=$(DOCKER_HOST_IP)\n" >> 
$(TMP_HOME)/tmp/openwhisk/providers.env
+   printf "DOCKER_IMAGE_PREFIX"="openwhisk\n" >> 
$(TMP_HOME)/tmp/openwhisk/providers.env
+   printf "DOCKER_IMAGE_TAG"="nightly\n" >> 
$(TMP_HOME)/tmp/openwhisk/providers.env
 
 Review comment:
   ```suggestion
printf "DOCKER_IMAGE_TAG=$(DOCKER_IMAGE_TAG)\n" >> 
$(TMP_HOME)/tmp/openwhisk/providers.env
   ```


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-openwhisk-devtools] rabbah commented on a change in pull request #272: Fixed Kafka provider setup

[GitBox]

rabbah commented on a change in pull request #272: Fixed Kafka provider setup
URL: 
https://github.com/apache/incubator-openwhisk-devtools/pull/272#discussion_r302615166
 
 

 ##
 File path: docker-compose/Makefile
 ##
 @@ -450,6 +450,8 @@ setup-providers:
printf "ENDPOINT_AUTH=`cat $(realpath 
$(OPENWHISK_PROJECT_HOME))/ansible/files/auth.whisk.system`\n" >> 
$(TMP_HOME)/tmp/openwhisk/providers.env
printf "HOST_MACHINE=$(DOCKER_HOST_IP)\n" >> 
$(TMP_HOME)/tmp/openwhisk/providers.env
printf "DOCKER_COMPOSE_HOST=$(DOCKER_HOST_IP)\n" >> 
$(TMP_HOME)/tmp/openwhisk/providers.env
+   printf "DOCKER_IMAGE_PREFIX"="openwhisk\n" >> 
$(TMP_HOME)/tmp/openwhisk/providers.env
 
 Review comment:
   ```suggestion
printf "DOCKER_IMAGE_PREFIX=$(DOCKER_IMAGE_PREFIX)\n" >> 
$(TMP_HOME)/tmp/openwhisk/providers.env
   ```


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-openwhisk-devtools] rabbah commented on a change in pull request #272: Fixed Kafka provider setup

[GitBox]

rabbah commented on a change in pull request #272: Fixed Kafka provider setup
URL: 
https://github.com/apache/incubator-openwhisk-devtools/pull/272#discussion_r302615681
 
 

 ##
 File path: docker-compose/Makefile
 ##
 @@ -450,6 +450,8 @@ setup-providers:
printf "ENDPOINT_AUTH=`cat $(realpath 
$(OPENWHISK_PROJECT_HOME))/ansible/files/auth.whisk.system`\n" >> 
$(TMP_HOME)/tmp/openwhisk/providers.env
printf "HOST_MACHINE=$(DOCKER_HOST_IP)\n" >> 
$(TMP_HOME)/tmp/openwhisk/providers.env
printf "DOCKER_COMPOSE_HOST=$(DOCKER_HOST_IP)\n" >> 
$(TMP_HOME)/tmp/openwhisk/providers.env
+   printf "DOCKER_IMAGE_PREFIX"="openwhisk\n" >> 
$(TMP_HOME)/tmp/openwhisk/providers.env
+   printf "DOCKER_IMAGE_TAG"="nightly\n" >> 
$(TMP_HOME)/tmp/openwhisk/providers.env
 
 Review comment:
   ```suggestion
printf "DOCKER_IMAGE_TAG=$(DOCKER_IMAGE_TAG)\n" >> 
$(TMP_HOME)/tmp/openwhisk/local.env
   ```


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-openwhisk-devtools] rabbah commented on a change in pull request #272: Fixed Kafka provider setup

[GitBox]

rabbah commented on a change in pull request #272: Fixed Kafka provider setup
URL: 
https://github.com/apache/incubator-openwhisk-devtools/pull/272#discussion_r302615681
 
 

 ##
 File path: docker-compose/Makefile
 ##
 @@ -450,6 +450,8 @@ setup-providers:
printf "ENDPOINT_AUTH=`cat $(realpath 
$(OPENWHISK_PROJECT_HOME))/ansible/files/auth.whisk.system`\n" >> 
$(TMP_HOME)/tmp/openwhisk/providers.env
printf "HOST_MACHINE=$(DOCKER_HOST_IP)\n" >> 
$(TMP_HOME)/tmp/openwhisk/providers.env
printf "DOCKER_COMPOSE_HOST=$(DOCKER_HOST_IP)\n" >> 
$(TMP_HOME)/tmp/openwhisk/providers.env
+   printf "DOCKER_IMAGE_PREFIX"="openwhisk\n" >> 
$(TMP_HOME)/tmp/openwhisk/providers.env
+   printf "DOCKER_IMAGE_TAG"="nightly\n" >> 
$(TMP_HOME)/tmp/openwhisk/providers.env
 
 Review comment:
   ```suggestion
  printf "DOCKER_IMAGE_TAG=$(DOCKER_IMAGE_TAG)\n" >> 
$(TMP_HOME)/tmp/openwhisk/local.env
   ```


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-openwhisk-devtools] rabbah commented on a change in pull request #272: Fixed Kafka provider setup

[GitBox]

rabbah commented on a change in pull request #272: Fixed Kafka provider setup
URL: 
https://github.com/apache/incubator-openwhisk-devtools/pull/272#discussion_r302615166
 
 

 ##
 File path: docker-compose/Makefile
 ##
 @@ -450,6 +450,8 @@ setup-providers:
printf "ENDPOINT_AUTH=`cat $(realpath 
$(OPENWHISK_PROJECT_HOME))/ansible/files/auth.whisk.system`\n" >> 
$(TMP_HOME)/tmp/openwhisk/providers.env
printf "HOST_MACHINE=$(DOCKER_HOST_IP)\n" >> 
$(TMP_HOME)/tmp/openwhisk/providers.env
printf "DOCKER_COMPOSE_HOST=$(DOCKER_HOST_IP)\n" >> 
$(TMP_HOME)/tmp/openwhisk/providers.env
+   printf "DOCKER_IMAGE_PREFIX"="openwhisk\n" >> 
$(TMP_HOME)/tmp/openwhisk/providers.env
 
 Review comment:
   ```suggestion
printf "DOCKER_IMAGE_PREFIX=$(DOCKER_IMAGE_PREFIX)\n" >> 
$(TMP_HOME)/tmp/openwhisk/local.env
   ```


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-openwhisk-devtools] rabbah commented on a change in pull request #272: Fixed Kafka provider setup

[GitBox]

rabbah commented on a change in pull request #272: Fixed Kafka provider setup
URL: 
https://github.com/apache/incubator-openwhisk-devtools/pull/272#discussion_r302614808
 
 

 ##
 File path: docker-compose/Makefile
 ##
 @@ -450,6 +450,8 @@ setup-providers:
printf "ENDPOINT_AUTH=`cat $(realpath 
$(OPENWHISK_PROJECT_HOME))/ansible/files/auth.whisk.system`\n" >> 
$(TMP_HOME)/tmp/openwhisk/providers.env
printf "HOST_MACHINE=$(DOCKER_HOST_IP)\n" >> 
$(TMP_HOME)/tmp/openwhisk/providers.env
printf "DOCKER_COMPOSE_HOST=$(DOCKER_HOST_IP)\n" >> 
$(TMP_HOME)/tmp/openwhisk/providers.env
+   printf "DOCKER_IMAGE_PREFIX"="openwhisk\n" >> 
$(TMP_HOME)/tmp/openwhisk/providers.env
+   printf "DOCKER_IMAGE_TAG"="nightly\n" >> 
$(TMP_HOME)/tmp/openwhisk/providers.env
 
 Review comment:
   Actually, can you replace these with 
   ```
   DOCKER_IMAGE_PREFIX ?= openwhisk
   DOCKER_IMAGE_TAG ?= nightly
   ```
   
   which are already defined?
   
   ```
 printf "DOCKER_IMAGE_PREFIX=$(DOCKER_IMAGE_PREFIX)\n" >> 
$(TMP_HOME)/tmp/openwhisk/local.env
 printf "DOCKER_IMAGE_TAG=$(DOCKER_IMAGE_TAG)\n" >> 
$(TMP_HOME)/tmp/openwhisk/local.env
   ```


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-openwhisk-devtools] rabbah commented on a change in pull request #272: Fixed Kafka provider setup

[GitBox]

rabbah commented on a change in pull request #272: Fixed Kafka provider setup
URL: 
https://github.com/apache/incubator-openwhisk-devtools/pull/272#discussion_r302614808
 
 

 ##
 File path: docker-compose/Makefile
 ##
 @@ -450,6 +450,8 @@ setup-providers:
printf "ENDPOINT_AUTH=`cat $(realpath 
$(OPENWHISK_PROJECT_HOME))/ansible/files/auth.whisk.system`\n" >> 
$(TMP_HOME)/tmp/openwhisk/providers.env
printf "HOST_MACHINE=$(DOCKER_HOST_IP)\n" >> 
$(TMP_HOME)/tmp/openwhisk/providers.env
printf "DOCKER_COMPOSE_HOST=$(DOCKER_HOST_IP)\n" >> 
$(TMP_HOME)/tmp/openwhisk/providers.env
+   printf "DOCKER_IMAGE_PREFIX"="openwhisk\n" >> 
$(TMP_HOME)/tmp/openwhisk/providers.env
+   printf "DOCKER_IMAGE_TAG"="nightly\n" >> 
$(TMP_HOME)/tmp/openwhisk/providers.env
 
 Review comment:
   Actually, can you replace these with 
   ```
   DOCKER_IMAGE_PREFIX ?= openwhisk
   DOCKER_IMAGE_TAG ?= nightly
   ```
   
   which are already defined?
   
   ```
 printf "DOCKER_IMAGE_PREFIX=$(DOCKER_IMAGE_PREFIX)\n" >> 
$(TMP_HOME)/tmp/openwhisk/local.env
 printf "DOCKER_IMAGE_TAG=$(DOCKER_IMAGE_TAG)\n" >> 
$(TMP_HOME)/tmp/openwhisk/local.env
   ```


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-openwhisk-devtools] phlucas96 opened a new pull request #272: Fixed Kafka provider setup

[GitBox]

phlucas96 opened a new pull request #272: Fixed Kafka provider setup
URL: https://github.com/apache/incubator-openwhisk-devtools/pull/272
 
 
   Fixes the setup of the Kafka provider. Currently, it gives an error because 
docker-compose tries to pull the docker container with the "latest" tag instead 
of the "nightly" one. 
   
   The changes in the pull request fix this issue.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-openwhisk-devtools] phlucas96 commented on issue #271: Error setup Kafka provider

[GitBox]

phlucas96 commented on issue #271: Error setup Kafka provider
URL: 
https://github.com/apache/incubator-openwhisk-devtools/issues/271#issuecomment-510527918
 
 
   Ok, I will. Thanks.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-openwhisk-devtools] rabbah removed a comment on issue #271: Error setup Kafka provider

[GitBox]

rabbah removed a comment on issue #271: Error setup Kafka provider
URL: 
https://github.com/apache/incubator-openwhisk-devtools/issues/271#issuecomment-510527088
 
 
   @phlucas96 are you on master/head?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-openwhisk-devtools] rabbah commented on issue #271: Error setup Kafka provider

[GitBox]

rabbah commented on issue #271: Error setup Kafka provider
URL: 
https://github.com/apache/incubator-openwhisk-devtools/issues/271#issuecomment-510527574
 
 
   Thanks @phlucas96 I see the delta. Do you want to submit a PR?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-openwhisk-devtools] rabbah commented on issue #271: Error setup Kafka provider

[GitBox]

rabbah commented on issue #271: Error setup Kafka provider
URL: 
https://github.com/apache/incubator-openwhisk-devtools/issues/271#issuecomment-510527088
 
 
   @phlucas96 are you on master/head?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-openwhisk-devtools] phlucas96 opened a new issue #271: Error setup Kafka provider

[GitBox]

phlucas96 opened a new issue #271: Error setup Kafka provider
URL: https://github.com/apache/incubator-openwhisk-devtools/issues/271
 
 
   During the installation of the kafka provider, docker-compose tries to pull 
the openwhisk/controller:"latest" image instead of the "nightly" image, giving 
an error:
   
   ```
   Pulling controller (openwhisk/controller:latest)...
   ERROR: manifest for openwhisk/controller:latest not found
   ```
   
   This is because during the "setup-providers" phase of the Makefile, the 
image prefix and image tag are missing from the "providers.env" file. 
   
   Adding the following lines to the Makefile "setup-providers" phase fixes the 
problem.
   
   ```
   printf "DOCKER_IMAGE_PREFIX"="openwhisk\n" >> 
$(TMP_HOME)/tmp/openwhisk/providers.env
   
   printf "DOCKER_IMAGE_TAG"="nightly\n" >> 
$(TMP_HOME)/tmp/openwhisk/providers.env
   ```


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-openwhisk-deploy-kube] dgrove-oss merged pull request #490: feat: add k8s tolerations support

[GitBox]

dgrove-oss merged pull request #490: feat: add k8s tolerations support
URL: https://github.com/apache/incubator-openwhisk-deploy-kube/pull/490
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-openwhisk-deploy-kube] dgrove-oss commented on issue #490: feat: add k8s tolerations support

[GitBox]

dgrove-oss commented on issue #490: feat: add k8s tolerations support
URL: 
https://github.com/apache/incubator-openwhisk-deploy-kube/pull/490#issuecomment-510513021
 
 
   CLA processed; will merge.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-openwhisk] style95 commented on issue #4541: Disable MesosContainerFactory from subscribing after close

[GitBox]

style95 commented on issue #4541: Disable MesosContainerFactory from 
subscribing after close
URL: 
https://github.com/apache/incubator-openwhisk/pull/4541#issuecomment-510420965
 
 
   I am not quite sure but I think the issue is happening in this way.
   
   `MesosContainerFactory` ask to the `mesosClientActor` which is `testActor` 
in test cases. 
   ```scala
   private def subscribe(): Future[Unit] = {
   logging.info(this, s"subscribing to Mesos master at 
${mesosConfig.masterUrl}")
   mesosClientActor  // here
 .ask(Subscribe)(mesosConfig.timeouts.subscribe)
 .mapTo[SubscribeComplete]
 .map(complete => logging.info(this, s"subscribe completed 
successfully... $complete"))
 .recoverWith {
   case e =>
 logging.error(this, s"subscribe failed... $e}")
 if (closed) Future.successful(()) else subscribe()
 }
 }
   ```
   
   ```scala
   factory = new MesosContainerFactory(
 wskConfig,
 system,
 logging,
 Map("--arg1" -> Set("v1", "v2"), "--arg2" -> Set("v3", "v4"), "other" 
-> Set("v5", "v6")),
 containerArgsConfig,
 mesosConfig = mesosConfig,
 clientFactory = (_, _) => testActor, // here
 taskIdGenerator = testTaskId _)
   ```
   
   Since `testActor` does not respond to the request `Subscribe`, `ask` request 
will be timed out and be caught by `recoverWith`.
   `recoverWith` logic will be asynchronously executed by another thread and 
the thread will call `subscribe()` again and be timed out recursively.
   
   
   So I think one easy way could be to define a simple testing actor which 
respond with static `SubscribeComplete` response against `Subscribe` request 
and pass the testing actor to the `MesosContainerFactory` instead of using just 
`testActor`.
   (We may want to define `AutoPilot` instead of defining a simple actor, but 
anyway)
   
   Since I did not look into the `MesosContainerFactory` logic in-depth, it 
would be great if @tysonnorris confirm this behavior once.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-openwhisk] mhenke1 merged pull request #4540: Removed unused controller instances config

[GitBox]

mhenke1 merged pull request #4540: Removed unused controller instances config
URL: https://github.com/apache/incubator-openwhisk/pull/4540
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-openwhisk] Guoyoyo commented on issue #4554: openwhisk Hello World error!! wsk api list error !!

[GitBox]

Guoyoyo commented on issue #4554: openwhisk Hello World error!! wsk api list 
error !!
URL: 
https://github.com/apache/incubator-openwhisk/issues/4554#issuecomment-510397931
 
 
   supplement:
   
   > creating the hello.js function ...
   > invoking the hello-world function ...
   > adding the function to whisk ...
   > ok: created action hello
   > invoking the function ...
   > invocation result: { "payload": "Hello, World!" }
   > { "payload": "Hello, World!" }
   > creating an API from the hello function ...
   > ok: updated action hello
   > **error: Unable to create API: API creation failure: Unable to obtain 
API(s) from the API Gateway (status code 404): {"status":404,"message":"Not 
Found"}**
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-openwhisk] Guoyoyo opened a new issue #4554: openwhisk Hello World error!! wsk api list error !!

[GitBox]

Guoyoyo opened a new issue #4554: openwhisk Hello World error!! wsk api list 
error !!
URL: https://github.com/apache/incubator-openwhisk/issues/4554
 
 
   
   
   ## Environment details:
   
   * Ubuntu 16.04.6   
   * openjdk version "1.8.0_212"
   * docker-compose version 1.21.2
   
   ## Question description about Openwhisk:
   Hello everyone, please give me a big handI'm beat...
   I am going to install the apache openwhisk. I choose the Quick Start 
(Docker-Compose) 
[https://github.com/apache/incubator-openwhisk#quick-start](https://github.com/apache/incubator-openwhisk#quick-start)
   
   It needs many port to install others service e.g. CouchDB, Kafka... in my 
computer, 80 and 9000 port is already used. so i revise the docker-compose.yml 
to assign the other port to replace them. (`80 => 9004 , 9000=> 9005`)
   
   After that, I run `make quick-start `, most service are work which show ok , 
i guess they were successfully installed. In the end, it should output the 
hello-world, but it didn't and show the error. 
   
   > error: Unable to create API: API creation failure: Unable to obtain API(s) 
from the API Gateway (status code 404): {"status":404,"message":"Not Found"}
   
   ## Question description about OpenwhiskCLI:
   I also tried to install openwhiskCLI reference by 
[https://github.com/apache/incubator-openwhisk-cli](https://github.com/apache/incubator-openwhisk-cli)
   the following instructions are what I inputted:
   
   > git clone https://github.com/apache/incubator-openwhisk-cli.git
   > ./gradlew compile –PnativeCompile
   > ./gradlew compile -PbuildPlatforms=linux-amd64
   > #add to the environment variable 
   > sudo mv wsk /usr/local/bin
   
   It seems no problem so far. i can input `wsk`. So, i stated to try an 
example like Hello-world.
   reference: 
[here](https://github.com/apache/incubator-openwhisk/blob/master/docs/samples.md)
   
   The first step:
   Create a JavaScript code example.
   ```
   /**
* Hello world as an OpenWhisk action.
*/
   function main(params) {
   var name = params.name || 'World';
   return {payload:  'Hello, ' + name + '!'};
   }
   ```
   
   When i inputted: `wsk action create hello hello.js`, errors are just 
happened...
   
   > error: Unable to create action 'hello': The connection failed, or timed 
out. (HTTP status code 400)
   
   I surveyed google many times and tried to set a lot @*$(%), but it still not 
work ... omg
   
   like:
   
   `wsk property set --apihost http://172.17.0.1 namespace guest –auth 
23bc46b1-71f6-4ed5-8c54-816aa4f8c502:123zO3xZCLrMN6v2BKK1dXYFpXlPkccOFqm12CdAsMgRU4VrNZ9lyGVCGuMDGIwP
 `
   > ok: whisk API host set to http://172.17.0.1
   
   `wsk action create hello hello.js`
   > error: Unable to create action 'hello': The connection failed, or timed 
out. (HTTP status code 405)
   
   `wsk api list`
   > error: Unable to obtain the API list: The connection failed, or timed out. 
(HTTP status code 404)
   
   `wsk property get`
   > whisk API host  http://172.17.0.1
   whisk auth  
23bc46b1-71f6-4ed5-8c54-816aa4f8c502:123zO3xZCLrMN6v2BKK1dXYFpXlPkccOFqm12CdAsMgRU4VrNZ9lyGVCGuMDGIwP
   whisk namespace _
   client cert
   Client key
   whisk API version   v1
   whisk CLI version   2019-07-11T14:05:29.661+0800
   whisk API build Unknown
   whisk API build number  Unknown
   error: Unable to obtain API build information: The connection failed, or 
timed out. (HTTP status code 404)
   
   I am not sure whether the error is happened due to wsk property set or not ? 
if it is, what should i set for apihost(port needed?) namespace? 
   
   Please guys, if you have experience for openwhisk, help me omg


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-openwhisk] rabbah commented on issue #4301: add firecracker container factory implementation

[GitBox]

rabbah commented on issue #4301: add firecracker container factory 
implementation 
URL: 
https://github.com/apache/incubator-openwhisk/issues/4301#issuecomment-510297166
 
 
   Related https://www.weave.works/blog/fire-up-your-vms-with-weave-ignite


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-openwhisk] dgrove-oss merged pull request #4552: gradlew licensing

[GitBox]

dgrove-oss merged pull request #4552: gradlew licensing
URL: https://github.com/apache/incubator-openwhisk/pull/4552
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-openwhisk-deploy-kube] dgrove-oss closed issue #492: Enhancement : Adding Pod Disruption Budget for Openwhisk Deployment

[GitBox]

dgrove-oss closed issue #492: Enhancement : Adding Pod Disruption Budget for 
Openwhisk Deployment
URL: https://github.com/apache/incubator-openwhisk-deploy-kube/issues/492
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services