[jira] [Commented] (RATIS-352) Persist commit index in Raft log.
[
https://issues.apache.org/jira/browse/RATIS-352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16660090#comment-16660090
]
Hadoop QA commented on RATIS-352:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
0s{color} | {color:blue} Docker mode activated. {color} |
| {color:red}-1{color} | {color:red} patch {color} | {color:red} 0m 4s{color}
| {color:red} RATIS-352 does not apply to master. Rebase required? Wrong
Branch? See https://yetus.apache.org/documentation/0.5.0/precommit-patchnames
for help. {color} |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Issue | RATIS-352 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12945035/r352_20181022d.patch |
| Console output |
https://builds.apache.org/job/PreCommit-RATIS-Build/442/console |
| Powered by | Apache Yetus 0.5.0 http://yetus.apache.org |
This message was automatically generated.
> Persist commit index in Raft log.
> -
>
> Key: RATIS-352
> URL: https://issues.apache.org/jira/browse/RATIS-352
> Project: Ratis
> Issue Type: Improvement
> Components: server
>Reporter: Tsz Wo Nicholas Sze
>Assignee: Tsz Wo Nicholas Sze
>Priority: Major
> Attachments: r352_20181022d.patch
>
>
> Current the commit index is not persisted in the Raft log. When a server
> restarts, it cannot apply its log until it has joined a Raft group. There is
> no problem if there is a Raft group.
> However, a server cannot recover its data when formatting a Raft group is
> impossible (e.g. a majority of servers are dead). Ideally, a server can
> safely apply the log up to the commit index. The JIRA is to persist the
> commit index so that such recovery is possible.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (RATIS-364) Raft should persist configuration entries to meta file
[ https://issues.apache.org/jira/browse/RATIS-364?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16660089#comment-16660089 ] Tsz Wo Nicholas Sze commented on RATIS-364: --- +1 the 002 patch looks good. > Raft should persist configuration entries to meta file > -- > > Key: RATIS-364 > URL: https://issues.apache.org/jira/browse/RATIS-364 > Project: Ratis > Issue Type: Improvement > Components: server >Reporter: Mukul Kumar Singh >Assignee: Mukul Kumar Singh >Priority: Major > Attachments: RATIS-364.002.patch > > > The responsibility of storing the raft configuration currently is state > Machine's responsibility. > This jira proposes to add a mechanism for Raft Server to persist the > configuration to its own metafile -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (RATIS-334) Implement server membership for LogService Metadata Service
[ https://issues.apache.org/jira/browse/RATIS-334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16660012#comment-16660012 ] Sergey Soldatov commented on RATIS-334: --- bq. Let's spin this out into its own Jira issue if you think it's important to fix well, I can't see how to use it. So the question is not about the importance, but about usability. But if I'm the only one who sees problems there, ignore me. > Implement server membership for LogService Metadata Service > --- > > Key: RATIS-334 > URL: https://issues.apache.org/jira/browse/RATIS-334 > Project: Ratis > Issue Type: Sub-task >Reporter: Josh Elser >Assignee: Sergey Soldatov >Priority: Major > Attachments: RATIS-334-v1.patch, RATIS-334-v3.patch, > RATIS-334-wip.patch > > > Half of the Metadata Service for managing LogStreams. > RATIS-279 is handling the "DDL" operations, and Rajesh suggested that we spin > out management of the servers which are available to back these LogStreams in > a second task. This is it. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (RATIS-334) Implement server membership for LogService Metadata Service
[
https://issues.apache.org/jira/browse/RATIS-334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16659968#comment-16659968
]
Josh Elser commented on RATIS-334:
--
{quote}this class is ambiguous
{quote}
Let's spin this out into its own Jira issue if you think it's important to fix
:)
> Implement server membership for LogService Metadata Service
> ---
>
> Key: RATIS-334
> URL: https://issues.apache.org/jira/browse/RATIS-334
> Project: Ratis
> Issue Type: Sub-task
>Reporter: Josh Elser
>Assignee: Sergey Soldatov
>Priority: Major
> Attachments: RATIS-334-v1.patch, RATIS-334-v3.patch,
> RATIS-334-wip.patch
>
>
> Half of the Metadata Service for managing LogStreams.
> RATIS-279 is handling the "DDL" operations, and Rajesh suggested that we spin
> out management of the servers which are available to back these LogStreams in
> a second task. This is it.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (RATIS-366) In StateMachineUpdater, the stopIndex should use Long.
[ https://issues.apache.org/jira/browse/RATIS-366?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jitendra Nath Pandey updated RATIS-366: --- Fix Version/s: 0.3.0 > In StateMachineUpdater, the stopIndex should use Long. > -- > > Key: RATIS-366 > URL: https://issues.apache.org/jira/browse/RATIS-366 > Project: Ratis > Issue Type: Bug > Components: server >Reporter: Tsz Wo Nicholas Sze >Assignee: Tsz Wo Nicholas Sze >Priority: Major > Fix For: 0.3.0 > > Attachments: r366_20181023.patch > > > stopIndex is better to use Long since raftLog.getLastCommittedIndex() may > return -1. In such case, updater.join() may not return since the updater > thread is stuck in wait(). > Some tests are failing; e.g. > [https://builds.apache.org/job/PreCommit-RATIS-Build/434/testReport/org.apache.ratis/TestRaftServerLeaderElectionTimeout/testLeaderElectionDetection/] -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (RATIS-334) Implement server membership for LogService Metadata Service
[ https://issues.apache.org/jira/browse/RATIS-334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16659879#comment-16659879 ] Sergey Soldatov commented on RATIS-334: --- [~vrodionov] well, my point is that this class is ambiguous because: 1. It uses raft client. And the stream class that provides reader/writer uses that raft client, so we can say that this client is the one based on Log quorum. 2. Log quorum is created by the meta service during .createLog() call, so this method should not be the part of LogService class. 3. createLog() in LogService is a remote call that returns LogStream. But the only thing that we create remotely is the raft group which will be used by raft client. But as I already mentioned, LogStream actually takes raft client from the LogService. > Implement server membership for LogService Metadata Service > --- > > Key: RATIS-334 > URL: https://issues.apache.org/jira/browse/RATIS-334 > Project: Ratis > Issue Type: Sub-task >Reporter: Josh Elser >Assignee: Sergey Soldatov >Priority: Major > Attachments: RATIS-334-v1.patch, RATIS-334-v3.patch, > RATIS-334-wip.patch > > > Half of the Metadata Service for managing LogStreams. > RATIS-279 is handling the "DDL" operations, and Rajesh suggested that we spin > out management of the servers which are available to back these LogStreams in > a second task. This is it. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (RATIS-334) Implement server membership for LogService Metadata Service
[
https://issues.apache.org/jira/browse/RATIS-334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16659600#comment-16659600
]
Josh Elser commented on RATIS-334:
--
{quote}I don't quite understand what LogService class is supposed to do. By the
name, it should be some kind of service, but it's definitely not. It behaves
like a client, but it has a factory
{quote}
Yes, that was the intent to have it behave like a client. The class LogService
is the "entrypoint" to using the "Ratis LogService" (this stuff). Don't have
strong reasons for naming it one way or the other.
> Implement server membership for LogService Metadata Service
> ---
>
> Key: RATIS-334
> URL: https://issues.apache.org/jira/browse/RATIS-334
> Project: Ratis
> Issue Type: Sub-task
>Reporter: Josh Elser
>Assignee: Sergey Soldatov
>Priority: Major
> Attachments: RATIS-334-v1.patch, RATIS-334-v3.patch,
> RATIS-334-wip.patch
>
>
> Half of the Metadata Service for managing LogStreams.
> RATIS-279 is handling the "DDL" operations, and Rajesh suggested that we spin
> out management of the servers which are available to back these LogStreams in
> a second task. This is it.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (RATIS-334) Implement server membership for LogService Metadata Service
[ https://issues.apache.org/jira/browse/RATIS-334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16659342#comment-16659342 ] Vladimir Rodionov commented on RATIS-334: - LogService looks like a client, agree. I would leave it, look at this as FileSystem -> File relationship, [~sergey.soldatov] > Implement server membership for LogService Metadata Service > --- > > Key: RATIS-334 > URL: https://issues.apache.org/jira/browse/RATIS-334 > Project: Ratis > Issue Type: Sub-task >Reporter: Josh Elser >Assignee: Sergey Soldatov >Priority: Major > Attachments: RATIS-334-v1.patch, RATIS-334-v3.patch, > RATIS-334-wip.patch > > > Half of the Metadata Service for managing LogStreams. > RATIS-279 is handling the "DDL" operations, and Rajesh suggested that we spin > out management of the servers which are available to back these LogStreams in > a second task. This is it. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (RATIS-334) Implement server membership for LogService Metadata Service
[ https://issues.apache.org/jira/browse/RATIS-334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16659297#comment-16659297 ] Sergey Soldatov commented on RATIS-334: --- [~rajeshbabu] I don't quite understand what LogService class is supposed to do. By the name, it should be some kind of service, but it's definitely not. It behaves like a client, but it has a factory. It has createLog method, but at the same time, it uses a single raft quorum ( so it handles a single Log). From my point of view, we don't need this class as well as the factory. All we need is to move raft client instance to LogStream. (fyi [~vrodionov]) as for the map of logs and pings - that information is persisted by Ratis itself. So during the restart, it would read the raft log from the beginning, replaying all transactions. I don't use the snapshots yet (haven't had a chance to understand how it works). some problems that I'm facing now: 1. retry logic in Ratis. If the request takes longer than 3 seconds (i.e. delete log - that would run 3 deleteGroup operations for all peers and it takes longer than 3 seconds) than ratis client would automatically resend the query. and it's not clear what to do in that case. Right now it tries to delete the group again, throwing exceptions. 2. Ping logic should be improved with tracking timeouts, etc. 3. Need to add messages as well as the logic for node replacement (i.e. in the quorum one of the followers went away). 4. possible some rework in the messages should be done to unify the responses ( with exceptions handling). > Implement server membership for LogService Metadata Service > --- > > Key: RATIS-334 > URL: https://issues.apache.org/jira/browse/RATIS-334 > Project: Ratis > Issue Type: Sub-task >Reporter: Josh Elser >Assignee: Sergey Soldatov >Priority: Major > Attachments: RATIS-334-v1.patch, RATIS-334-v3.patch, > RATIS-334-wip.patch > > > Half of the Metadata Service for managing LogStreams. > RATIS-279 is handling the "DDL" operations, and Rajesh suggested that we spin > out management of the servers which are available to back these LogStreams in > a second task. This is it. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (RATIS-366) In StateMachineUpdater, the stopIndex should use Long.
[
https://issues.apache.org/jira/browse/RATIS-366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16659284#comment-16659284
]
Hadoop QA commented on RATIS-366:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
10s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
1s{color} | {color:blue} Findbugs executables are not available. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m
0s{color} | {color:red} The patch doesn't appear to include any new or modified
tests. Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
49s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
54s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
14s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
29s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
49s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
43s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
43s{color} | {color:green} the patch passed {color} |
| {color:orange}-0{color} | {color:orange} checkstyle {color} | {color:orange}
0m 14s{color} | {color:orange} root: The patch generated 2 new + 46 unchanged -
2 fixed = 48 total (was 48) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
29s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 24m
37s{color} | {color:green} root in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
9s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 29m 47s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/ratis:date2018-10-22
|
| JIRA Issue | RATIS-366 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12945051/r366_20181023.patch |
| Optional Tests | asflicense javac javadoc unit findbugs checkstyle
compile |
| uname | Linux 5e9146a73fdd 3.13.0-153-generic #203-Ubuntu SMP Thu Jun 14
08:52:28 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-RATIS-Build/yetus-personality.sh
|
| git revision | master / 39916f2 |
| Default Java | 1.8.0_181 |
| checkstyle |
https://builds.apache.org/job/PreCommit-RATIS-Build/441/artifact/out/diff-checkstyle-root.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-RATIS-Build/441/testReport/ |
| modules | C: ratis-server U: ratis-server |
| Console output |
https://builds.apache.org/job/PreCommit-RATIS-Build/441/console |
| Powered by | Apache Yetus 0.5.0 http://yetus.apache.org |
This message was automatically generated.
> In StateMachineUpdater, the stopIndex should use Long.
> --
>
> Key: RATIS-366
> URL: https://issues.apache.org/jira/browse/RATIS-366
> Project: Ratis
> Issue Type: Bug
> Components: server
>Reporter: Tsz Wo Nicholas Sze
>Assignee: Tsz Wo Nicholas Sze
>Priority: Major
> Attachments: r366_20181023.patch
>
>
> stopIndex is better to use Long since raftLog.getLastCommittedIndex() may
> return -1. In such case, updater.join() may not return since the updater
> thread is stuck in wait().
> Some tests are failing; e.g.
>
[jira] [Comment Edited] (RATIS-334) Implement server membership for LogService Metadata Service
[ https://issues.apache.org/jira/browse/RATIS-334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16659241#comment-16659241 ] Rajeshbabu Chintaguntla edited comment on RATIS-334 at 10/22/18 6:01 PM: - [~sergey.soldatov] I have gone through the patch. Overall it looks good. What do you think of making APIs in LogService like createLog to createLogStream etc. as they are same as LogServiceClient APIs? As of now you are writing the log registration, ping requests in the meta state machine. I have one doubt that you still need to write the logic to rebuild the map of logname to peers by reading the snapshot right on recovery? or it will be handled by Ratis automatically? was (Author: rajeshbabu): [~sergey.soldatov] I have gone through the patch. Overall it looks good. What do you think of making APIs in LogService like createLog to createLogStream etc. as they are same as LogServiceClient APIs? As of now you are writing the log registration, ping requests in the meta state machine. I have one dount that you still need to write the logic to rebuild the map of logname to peers by reading the snapshot right on recovery? or it will be handled by Ratis automatically? > Implement server membership for LogService Metadata Service > --- > > Key: RATIS-334 > URL: https://issues.apache.org/jira/browse/RATIS-334 > Project: Ratis > Issue Type: Sub-task >Reporter: Josh Elser >Assignee: Sergey Soldatov >Priority: Major > Attachments: RATIS-334-v1.patch, RATIS-334-v3.patch, > RATIS-334-wip.patch > > > Half of the Metadata Service for managing LogStreams. > RATIS-279 is handling the "DDL" operations, and Rajesh suggested that we spin > out management of the servers which are available to back these LogStreams in > a second task. This is it. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (RATIS-334) Implement server membership for LogService Metadata Service
[ https://issues.apache.org/jira/browse/RATIS-334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16659241#comment-16659241 ] Rajeshbabu Chintaguntla commented on RATIS-334: --- [~sergey.soldatov] I have gone through the patch. Overall it looks good. What do you think of making APIs in LogService like createLog to createLogStream etc. as they are same as LogServiceClient APIs? As of now you are writing the log registration, ping requests in the meta state machine. I have one dount that you still need to write the logic to rebuild the map of logname to peers by reading the snapshot right on recovery? or it will be handled by Ratis automatically? > Implement server membership for LogService Metadata Service > --- > > Key: RATIS-334 > URL: https://issues.apache.org/jira/browse/RATIS-334 > Project: Ratis > Issue Type: Sub-task >Reporter: Josh Elser >Assignee: Sergey Soldatov >Priority: Major > Attachments: RATIS-334-v1.patch, RATIS-334-v3.patch, > RATIS-334-wip.patch > > > Half of the Metadata Service for managing LogStreams. > RATIS-279 is handling the "DDL" operations, and Rajesh suggested that we spin > out management of the servers which are available to back these LogStreams in > a second task. This is it. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (RATIS-365) Implement RaftServer.getGroupIds() using the key set of ImplMap
[
https://issues.apache.org/jira/browse/RATIS-365?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16659187#comment-16659187
]
Hadoop QA commented on RATIS-365:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
11s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
1s{color} | {color:blue} Findbugs executables are not available. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m
0s{color} | {color:red} The patch doesn't appear to include any new or modified
tests. Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
10s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m
0s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
43s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
21s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
30s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
5s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
48s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
43s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
43s{color} | {color:green} the patch passed {color} |
| {color:orange}-0{color} | {color:orange} checkstyle {color} | {color:orange}
0m 24s{color} | {color:orange} root: The patch generated 9 new + 544 unchanged
- 13 fixed = 553 total (was 557) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
35s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 19m 30s{color}
| {color:red} root in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
6s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 25m 14s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests |
ratis.server.simulation.TestRaftReconfigurationWithSimulatedRpc |
| | ratis.server.simulation.TestRaftWithSimulatedRpc |
| | ratis.TestRaftServerSlownessDetection |
| | ratis.TestRaftServerLeaderElectionTimeout |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/ratis:date2018-10-22
|
| JIRA Issue | RATIS-365 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12945048/r365_20181023.patch |
| Optional Tests | asflicense javac javadoc unit findbugs checkstyle
compile |
| uname | Linux c11d5fb4d519 3.13.0-153-generic #203-Ubuntu SMP Thu Jun 14
08:52:28 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-RATIS-Build/yetus-personality.sh
|
| git revision | master / 39916f2 |
| Default Java | 1.8.0_181 |
| checkstyle |
https://builds.apache.org/job/PreCommit-RATIS-Build/439/artifact/out/diff-checkstyle-root.txt
|
| unit |
https://builds.apache.org/job/PreCommit-RATIS-Build/439/artifact/out/patch-unit-root.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-RATIS-Build/439/testReport/ |
| modules | C: ratis-common ratis-server U: . |
| Console output |
https://builds.apache.org/job/PreCommit-RATIS-Build/439/console |
| Powered by | Apache Yetus 0.5.0 http://yetus.apache.org |
This message was automatically generated.
> Implement RaftServer.getGroupIds() using the key set of ImplMap
> ---
>
>
[jira] [Commented] (RATIS-366) In StateMachineUpdater, the stopIndex should use Long.
[
https://issues.apache.org/jira/browse/RATIS-366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16659185#comment-16659185
]
Hadoop QA commented on RATIS-366:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
17s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
0s{color} | {color:blue} Findbugs executables are not available. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m
0s{color} | {color:red} The patch doesn't appear to include any new or modified
tests. Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
50s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
44s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
14s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
29s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
47s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
43s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
43s{color} | {color:green} the patch passed {color} |
| {color:orange}-0{color} | {color:orange} checkstyle {color} | {color:orange}
0m 13s{color} | {color:orange} root: The patch generated 2 new + 46 unchanged -
2 fixed = 48 total (was 48) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
30s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 17m 4s{color}
| {color:red} root in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
7s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 22m 8s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | ratis.TestRaftServerLeaderElectionTimeout |
| | ratis.server.simulation.TestRaftStateMachineExceptionWithSimulatedRpc |
| | ratis.TestRaftServerSlownessDetection |
| | ratis.server.simulation.TestRaftWithSimulatedRpc |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/ratis:date2018-10-22
|
| JIRA Issue | RATIS-366 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12945051/r366_20181023.patch |
| Optional Tests | asflicense javac javadoc unit findbugs checkstyle
compile |
| uname | Linux 182f62628bdb 4.4.0-133-generic #159-Ubuntu SMP Fri Aug 10
07:31:43 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-RATIS-Build/yetus-personality.sh
|
| git revision | master / 39916f2 |
| Default Java | 1.8.0_181 |
| checkstyle |
https://builds.apache.org/job/PreCommit-RATIS-Build/440/artifact/out/diff-checkstyle-root.txt
|
| unit |
https://builds.apache.org/job/PreCommit-RATIS-Build/440/artifact/out/patch-unit-root.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-RATIS-Build/440/testReport/ |
| modules | C: ratis-server U: ratis-server |
| Console output |
https://builds.apache.org/job/PreCommit-RATIS-Build/440/console |
| Powered by | Apache Yetus 0.5.0 http://yetus.apache.org |
This message was automatically generated.
> In StateMachineUpdater, the stopIndex should use Long.
> --
>
> Key: RATIS-366
> URL: https://issues.apache.org/jira/browse/RATIS-366
> Project: Ratis
> Issue Type: Bug
> Components: server
>Reporter: Tsz Wo Nicholas Sze
>Assignee: Tsz Wo Nicholas Sze
>Priority: Major
>
[jira] [Commented] (RATIS-366) In StateMachineUpdater, the stopIndex should use Long.
[ https://issues.apache.org/jira/browse/RATIS-366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16659167#comment-16659167 ] Jitendra Nath Pandey commented on RATIS-366: +1 for the patch. > In StateMachineUpdater, the stopIndex should use Long. > -- > > Key: RATIS-366 > URL: https://issues.apache.org/jira/browse/RATIS-366 > Project: Ratis > Issue Type: Bug > Components: server >Reporter: Tsz Wo Nicholas Sze >Assignee: Tsz Wo Nicholas Sze >Priority: Major > Attachments: r366_20181023.patch > > > stopIndex is better to use Long since raftLog.getLastCommittedIndex() may > return -1. In such case, updater.join() may not return since the updater > thread is stuck in wait(). > Some tests are failing; e.g. > [https://builds.apache.org/job/PreCommit-RATIS-Build/434/testReport/org.apache.ratis/TestRaftServerLeaderElectionTimeout/testLeaderElectionDetection/] -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (RATIS-363) StateMachineUpdater should wait for committed transactions to be applied before shutdown.
[ https://issues.apache.org/jira/browse/RATIS-363?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16659147#comment-16659147 ] Tsz Wo Nicholas Sze commented on RATIS-363: --- Filed RATIS-366. > StateMachineUpdater should wait for committed transactions to be applied > before shutdown. > - > > Key: RATIS-363 > URL: https://issues.apache.org/jira/browse/RATIS-363 > Project: Ratis > Issue Type: Improvement > Components: server >Reporter: Jitendra Nath Pandey >Assignee: Jitendra Nath Pandey >Priority: Blocker > Fix For: 0.3.0 > > Attachments: RATIS-363.5.patch > > > StateMachineUpdater should apply all the committed transactions before > shutdown, otherwise committed data can be lost. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (RATIS-364) Raft should persist configuration entries to meta file
[
https://issues.apache.org/jira/browse/RATIS-364?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16659146#comment-16659146
]
Hadoop QA commented on RATIS-364:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
14s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
0s{color} | {color:blue} Findbugs executables are not available. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m
0s{color} | {color:red} The patch doesn't appear to include any new or modified
tests. Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m
5s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
57s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
28s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
40s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m
5s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
58s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
58s{color} | {color:green} the patch passed {color} |
| {color:orange}-0{color} | {color:orange} checkstyle {color} | {color:orange}
0m 27s{color} | {color:orange} root: The patch generated 15 new + 742 unchanged
- 8 fixed = 757 total (was 750) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
38s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 19m 35s{color}
| {color:red} root in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
6s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 26m 22s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests |
ratis.server.simulation.TestRaftReconfigurationWithSimulatedRpc |
| | ratis.server.simulation.TestRaftWithSimulatedRpc |
| | ratis.TestRaftServerSlownessDetection |
| | ratis.TestRaftServerLeaderElectionTimeout |
| | ratis.server.simulation.TestRaftSnapshotWithSimulatedRpc |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/ratis:date2018-10-22
|
| JIRA Issue | RATIS-364 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12945043/RATIS-364.002.patch |
| Optional Tests | asflicense javac javadoc unit findbugs checkstyle
compile |
| uname | Linux ea975c07cb53 3.13.0-153-generic #203-Ubuntu SMP Thu Jun 14
08:52:28 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-RATIS-Build/yetus-personality.sh
|
| git revision | master / 39916f2 |
| Default Java | 1.8.0_181 |
| checkstyle |
https://builds.apache.org/job/PreCommit-RATIS-Build/438/artifact/out/diff-checkstyle-root.txt
|
| unit |
https://builds.apache.org/job/PreCommit-RATIS-Build/438/artifact/out/patch-unit-root.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-RATIS-Build/438/testReport/ |
| modules | C: ratis-server U: ratis-server |
| Console output |
https://builds.apache.org/job/PreCommit-RATIS-Build/438/console |
| Powered by | Apache Yetus 0.5.0 http://yetus.apache.org |
This message was automatically generated.
> Raft should persist configuration entries to meta file
> --
>
> Key: RATIS-364
> URL: https://issues.apache.org/jira/browse/RATIS-364
> Project: Ratis
> Issue Type: Improvement
> Components: server
>Reporter: Mukul Kumar Singh
>
[jira] [Created] (RATIS-366) In StateMachineUpdater, the stopIndex should use Long.
Tsz Wo Nicholas Sze created RATIS-366: - Summary: In StateMachineUpdater, the stopIndex should use Long. Key: RATIS-366 URL: https://issues.apache.org/jira/browse/RATIS-366 Project: Ratis Issue Type: Bug Components: server Reporter: Tsz Wo Nicholas Sze Assignee: Tsz Wo Nicholas Sze Attachments: r366_20181023.patch stopIndex is better to use Long since raftLog.getLastCommittedIndex() may return -1. In such case, updater.join() may not return since the updater thread is stuck in wait(). Some tests are failing; e.g. [https://builds.apache.org/job/PreCommit-RATIS-Build/434/testReport/org.apache.ratis/TestRaftServerLeaderElectionTimeout/testLeaderElectionDetection/] -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (RATIS-366) In StateMachineUpdater, the stopIndex should use Long.
[ https://issues.apache.org/jira/browse/RATIS-366?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tsz Wo Nicholas Sze updated RATIS-366: -- Attachment: r366_20181023.patch > In StateMachineUpdater, the stopIndex should use Long. > -- > > Key: RATIS-366 > URL: https://issues.apache.org/jira/browse/RATIS-366 > Project: Ratis > Issue Type: Bug > Components: server >Reporter: Tsz Wo Nicholas Sze >Assignee: Tsz Wo Nicholas Sze >Priority: Major > Attachments: r366_20181023.patch > > > stopIndex is better to use Long since raftLog.getLastCommittedIndex() may > return -1. In such case, updater.join() may not return since the updater > thread is stuck in wait(). > Some tests are failing; e.g. > [https://builds.apache.org/job/PreCommit-RATIS-Build/434/testReport/org.apache.ratis/TestRaftServerLeaderElectionTimeout/testLeaderElectionDetection/] -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (RATIS-365) Implement RaftServer.getGroupIds() using the key set of ImplMap
[
https://issues.apache.org/jira/browse/RATIS-365?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16659142#comment-16659142
]
Tsz Wo Nicholas Sze commented on RATIS-365:
---
r365_20181023.patch: uses map.keySet() and removes quite a few "throws
IOException" declarations.
> Implement RaftServer.getGroupIds() using the key set of ImplMap
> ---
>
> Key: RATIS-365
> URL: https://issues.apache.org/jira/browse/RATIS-365
> Project: Ratis
> Issue Type: Improvement
> Components: server
>Reporter: Tsz Wo Nicholas Sze
>Assignee: Tsz Wo Nicholas Sze
>Priority: Major
> Attachments: r365_20181023.patch
>
>
> {code:java}
> //RaftServerProxy
> public Iterable getGroupIds() throws IOException {
> return
> getImpls().stream().map(RaftServerImpl::getGroupId).collect(Collectors.toList());
> }
> {code}
> getGroupIds() above unnecessarily calls getImpls() and then map
> RaftServerImpl to RaftGroupId. We may get RaftGroupId(s) directly from
> ImplMap.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Created] (RATIS-365) Implement RaftServer.getGroupIds() using the key set of ImplMap
Tsz Wo Nicholas Sze created RATIS-365:
-
Summary: Implement RaftServer.getGroupIds() using the key set of
ImplMap
Key: RATIS-365
URL: https://issues.apache.org/jira/browse/RATIS-365
Project: Ratis
Issue Type: Improvement
Components: server
Reporter: Tsz Wo Nicholas Sze
Assignee: Tsz Wo Nicholas Sze
{code:java}
//RaftServerProxy
public Iterable getGroupIds() throws IOException {
return
getImpls().stream().map(RaftServerImpl::getGroupId).collect(Collectors.toList());
}
{code}
getGroupIds() above unnecessarily calls getImpls() and then map RaftServerImpl
to RaftGroupId. We may get RaftGroupId(s) directly from ImplMap.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (RATIS-364) Raft should persist configuration entries to meta file
[ https://issues.apache.org/jira/browse/RATIS-364?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16659115#comment-16659115 ] Mukul Kumar Singh commented on RATIS-364: - Thanks for the review [~szetszwo]. patch v2 fixes the review comments. > Raft should persist configuration entries to meta file > -- > > Key: RATIS-364 > URL: https://issues.apache.org/jira/browse/RATIS-364 > Project: Ratis > Issue Type: Improvement > Components: server >Reporter: Mukul Kumar Singh >Assignee: Mukul Kumar Singh >Priority: Major > Attachments: RATIS-364.002.patch > > > The responsibility of storing the raft configuration currently is state > Machine's responsibility. > This jira proposes to add a mechanism for Raft Server to persist the > configuration to its own metafile -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (RATIS-364) Raft should persist configuration entries to meta file
[ https://issues.apache.org/jira/browse/RATIS-364?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mukul Kumar Singh updated RATIS-364: Attachment: RATIS-364.002.patch > Raft should persist configuration entries to meta file > -- > > Key: RATIS-364 > URL: https://issues.apache.org/jira/browse/RATIS-364 > Project: Ratis > Issue Type: Improvement > Components: server >Reporter: Mukul Kumar Singh >Assignee: Mukul Kumar Singh >Priority: Major > Attachments: RATIS-364.002.patch > > > The responsibility of storing the raft configuration currently is state > Machine's responsibility. > This jira proposes to add a mechanism for Raft Server to persist the > configuration to its own metafile -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (RATIS-364) Raft should persist configuration entries to meta file
[ https://issues.apache.org/jira/browse/RATIS-364?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mukul Kumar Singh updated RATIS-364: Attachment: (was: RATIS-364.001.patch) > Raft should persist configuration entries to meta file > -- > > Key: RATIS-364 > URL: https://issues.apache.org/jira/browse/RATIS-364 > Project: Ratis > Issue Type: Improvement > Components: server >Reporter: Mukul Kumar Singh >Assignee: Mukul Kumar Singh >Priority: Major > Attachments: RATIS-364.002.patch > > > The responsibility of storing the raft configuration currently is state > Machine's responsibility. > This jira proposes to add a mechanism for Raft Server to persist the > configuration to its own metafile -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (RATIS-364) Raft should persist configuration entries to meta file
[ https://issues.apache.org/jira/browse/RATIS-364?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16659100#comment-16659100 ] Tsz Wo Nicholas Sze commented on RATIS-364: --- [~msingh], thanks for working on this. The approach looks good. Some minor comments: - Rename getConfiguration to readRaftConfiguration, and setRaftConfiguration to writeRaftConfiguration. - We should log a warning when there is an exception in these two methods. - Import RaftProtos.LogEntryProto and then use LogEntryProto in the code. It looks shorter. - Remove raftConf from BaseStateMachine. > Raft should persist configuration entries to meta file > -- > > Key: RATIS-364 > URL: https://issues.apache.org/jira/browse/RATIS-364 > Project: Ratis > Issue Type: Bug > Components: server >Reporter: Mukul Kumar Singh >Assignee: Mukul Kumar Singh >Priority: Major > Attachments: RATIS-364.001.patch > > > The responsibility of storing the raft configuration currently is state > Machine's responsibility. > This jira proposes to add a mechanism for Raft Server to persist the > configuration to its own metafile -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (RATIS-364) Raft should persist configuration entries to meta file
[ https://issues.apache.org/jira/browse/RATIS-364?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tsz Wo Nicholas Sze updated RATIS-364: -- Issue Type: Improvement (was: Bug) > Raft should persist configuration entries to meta file > -- > > Key: RATIS-364 > URL: https://issues.apache.org/jira/browse/RATIS-364 > Project: Ratis > Issue Type: Improvement > Components: server >Reporter: Mukul Kumar Singh >Assignee: Mukul Kumar Singh >Priority: Major > Attachments: RATIS-364.001.patch > > > The responsibility of storing the raft configuration currently is state > Machine's responsibility. > This jira proposes to add a mechanism for Raft Server to persist the > configuration to its own metafile -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (RATIS-364) Raft should persist configuration entries to meta file
[
https://issues.apache.org/jira/browse/RATIS-364?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16659090#comment-16659090
]
Hadoop QA commented on RATIS-364:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 4m
10s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
1s{color} | {color:blue} Findbugs executables are not available. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m
0s{color} | {color:red} The patch doesn't appear to include any new or modified
tests. Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 2m
49s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
43s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
31s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
38s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
49s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
43s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
43s{color} | {color:green} the patch passed {color} |
| {color:orange}-0{color} | {color:orange} checkstyle {color} | {color:orange}
0m 25s{color} | {color:orange} root: The patch generated 15 new + 737 unchanged
- 7 fixed = 752 total (was 744) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
29s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 28m 40s{color}
| {color:red} root in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
17s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 40m 23s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | ratis.TestRaftServerLeaderElectionTimeout |
| | ratis.server.simulation.TestRaftStateMachineExceptionWithSimulatedRpc |
| | ratis.server.simulation.TestRaftExceptionWithSimulation |
| | ratis.server.simulation.TestRaftReconfigurationWithSimulatedRpc |
| | ratis.TestRaftServerSlownessDetection |
| | ratis.server.simulation.TestRaftSnapshotWithSimulatedRpc |
| | ratis.server.simulation.TestLeaderElectionWithSimulatedRpc |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/ratis:date2018-10-22
|
| JIRA Issue | RATIS-364 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12945032/RATIS-364.001.patch |
| Optional Tests | asflicense javac javadoc unit findbugs checkstyle
compile |
| uname | Linux ff6ef717d1a1 4.4.0-133-generic #159-Ubuntu SMP Fri Aug 10
07:31:43 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-RATIS-Build/yetus-personality.sh
|
| git revision | master / 8ef7b48 |
| Default Java | 1.8.0_181 |
| checkstyle |
https://builds.apache.org/job/PreCommit-RATIS-Build/436/artifact/out/diff-checkstyle-root.txt
|
| unit |
https://builds.apache.org/job/PreCommit-RATIS-Build/436/artifact/out/patch-unit-root.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-RATIS-Build/436/testReport/ |
| modules | C: ratis-server U: ratis-server |
| Console output |
https://builds.apache.org/job/PreCommit-RATIS-Build/436/console |
| Powered by | Apache Yetus 0.5.0 http://yetus.apache.org |
This message was automatically generated.
> Raft should persist configuration entries to meta file
> --
>
> Key: RATIS-364
> URL: https://issues.apache.org/jira/browse/RATIS-364
>
[jira] [Commented] (RATIS-363) StateMachineUpdater should wait for committed transactions to be applied before shutdown.
[
https://issues.apache.org/jira/browse/RATIS-363?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16659089#comment-16659089
]
Tsz Wo Nicholas Sze commented on RATIS-363:
---
Just found a bug -- stopIndex is better to use Long since
raftLog.getLastCommittedIndex() may return -1. In such case, updater.join()
may not return since the updater thread is stuck in wait(). Some tests may
fail; e.g.
https://builds.apache.org/job/PreCommit-RATIS-Build/434/testReport/org.apache.ratis/TestRaftServerLeaderElectionTimeout/testLeaderElectionDetection/
{code}
+++
b/ratis-server/src/main/java/org/apache/ratis/server/impl/StateMachineUpdater.java
@@ -44,7 +44,7 @@ import java.util.concurrent.CompletableFuture;
*/
class StateMachineUpdater implements Runnable {
static final Logger LOG = LoggerFactory.getLogger(StateMachineUpdater.class);
- private volatile long stopIndex = -1;
+ private volatile Long stopIndex = null;
enum State {
RUNNING, STOP, RELOAD
@@ -100,13 +100,13 @@ class StateMachineUpdater implements Runnable {
*
* @throws InterruptedException
*/
- public void stopAndJoin()
- throws InterruptedException {
-if (stopIndex == -1) {
+ void stopAndJoin() throws InterruptedException {
+if (stopIndex == null) {
synchronized (this) {
this.stopIndex = raftLog.getLastCommittedIndex();
notifyUpdater();
}
+ LOG.info("{}: set stopIndex = {}", this, stopIndex);
}
updater.join();
}
@@ -210,7 +210,7 @@ class StateMachineUpdater implements Runnable {
}
private boolean shouldStop() {
-return stopIndex > -1 && getLastAppliedIndex() >= stopIndex;
+return stopIndex != null && getLastAppliedIndex() >= stopIndex;
}
private boolean shouldTakeSnapshot() {
{code}
The patch in RATIS-352 will fix it.
> StateMachineUpdater should wait for committed transactions to be applied
> before shutdown.
> -
>
> Key: RATIS-363
> URL: https://issues.apache.org/jira/browse/RATIS-363
> Project: Ratis
> Issue Type: Improvement
> Components: server
>Reporter: Jitendra Nath Pandey
>Assignee: Jitendra Nath Pandey
>Priority: Blocker
> Fix For: 0.3.0
>
> Attachments: RATIS-363.5.patch
>
>
> StateMachineUpdater should apply all the committed transactions before
> shutdown, otherwise committed data can be lost.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (RATIS-352) Persist commit index in Raft log.
[
https://issues.apache.org/jira/browse/RATIS-352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16659087#comment-16659087
]
Hadoop QA commented on RATIS-352:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
14s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
2s{color} | {color:blue} Findbugs executables are not available. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 7 new or modified test
files. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
23s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m
8s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
57s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
32s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
38s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
6s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m
0s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
54s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} cc {color} | {color:green} 0m
54s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} javac {color} | {color:red} 0m 54s{color}
| {color:red} root generated 1 new + 99 unchanged - 0 fixed = 100 total (was
99) {color} |
| {color:orange}-0{color} | {color:orange} checkstyle {color} | {color:orange}
0m 30s{color} | {color:orange} root: The patch generated 55 new + 978 unchanged
- 32 fixed = 1033 total (was 1010) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
37s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 7m 31s{color}
| {color:red} root in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
10s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 14m 54s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests |
ratis.server.simulation.TestRaftReconfigurationWithSimulatedRpc |
| | ratis.server.simulation.TestRaftWithSimulatedRpc |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/ratis:date2018-10-22
|
| JIRA Issue | RATIS-352 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12945035/r352_20181022d.patch |
| Optional Tests | asflicense javac javadoc unit findbugs checkstyle
compile cc |
| uname | Linux 79e63e39fef2 3.13.0-153-generic #203-Ubuntu SMP Thu Jun 14
08:52:28 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-RATIS-Build/yetus-personality.sh
|
| git revision | master / 8ef7b48 |
| Default Java | 1.8.0_181 |
| javac |
https://builds.apache.org/job/PreCommit-RATIS-Build/437/artifact/out/diff-compile-javac-root.txt
|
| checkstyle |
https://builds.apache.org/job/PreCommit-RATIS-Build/437/artifact/out/diff-checkstyle-root.txt
|
| unit |
https://builds.apache.org/job/PreCommit-RATIS-Build/437/artifact/out/patch-unit-root.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-RATIS-Build/437/testReport/ |
| modules | C: ratis-proto ratis-server ratis-examples U: . |
| Console output |
https://builds.apache.org/job/PreCommit-RATIS-Build/437/console |
| Powered by | Apache Yetus 0.5.0 http://yetus.apache.org |
This message was automatically generated.
> Persist commit index in Raft log.
>
[jira] [Commented] (RATIS-338) ServerInformationReply should include multiple groups
[ https://issues.apache.org/jira/browse/RATIS-338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16659076#comment-16659076 ] Tsz Wo Nicholas Sze commented on RATIS-338: --- The failed tests do not seem related. > ServerInformationReply should include multiple groups > - > > Key: RATIS-338 > URL: https://issues.apache.org/jira/browse/RATIS-338 > Project: Ratis > Issue Type: Sub-task > Components: server >Reporter: Tsz Wo Nicholas Sze >Assignee: Sergey Soldatov >Priority: Major > Fix For: 0.3.0 > > Attachments: RATIS-338-v5.patch > > > ServerInformationReply currently only returns information of a particular > group. It should return informations of all the groups. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (RATIS-338) ServerInformationReply should include multiple groups
[
https://issues.apache.org/jira/browse/RATIS-338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16659064#comment-16659064
]
Hadoop QA commented on RATIS-338:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
11s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
1s{color} | {color:blue} Findbugs executables are not available. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 2 new or modified test
files. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 1m
19s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m
49s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
43s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
34s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
35s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
5s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
48s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
43s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} cc {color} | {color:green} 0m
43s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
43s{color} | {color:green} the patch passed {color} |
| {color:orange}-0{color} | {color:orange} checkstyle {color} | {color:orange}
0m 31s{color} | {color:orange} root: The patch generated 153 new + 1167
unchanged - 72 fixed = 1320 total (was 1239) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
29s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 17m 48s{color}
| {color:red} root in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
14s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 26m 0s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | ratis.server.simulation.TestRaftWithSimulatedRpc |
| | ratis.server.simulation.TestRaftReconfigurationWithSimulatedRpc |
| | ratis.TestRaftServerLeaderElectionTimeout |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/ratis:date2018-10-22
|
| JIRA Issue | RATIS-338 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12945012/RATIS-338-v5.patch |
| Optional Tests | asflicense javac javadoc unit findbugs checkstyle
compile cc |
| uname | Linux 32ec28ef4876 3.13.0-143-generic #192-Ubuntu SMP Tue Feb 27
10:45:36 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-RATIS-Build/yetus-personality.sh
|
| git revision | master / ce78399 |
| Default Java | 1.8.0_181 |
| checkstyle |
https://builds.apache.org/job/PreCommit-RATIS-Build/434/artifact/out/diff-checkstyle-root.txt
|
| unit |
https://builds.apache.org/job/PreCommit-RATIS-Build/434/artifact/out/patch-unit-root.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-RATIS-Build/434/testReport/ |
| modules | C: ratis-proto ratis-common ratis-client ratis-server ratis-grpc
ratis-netty ratis-hadoop U: . |
| Console output |
https://builds.apache.org/job/PreCommit-RATIS-Build/434/console |
| Powered by | Apache Yetus 0.5.0 http://yetus.apache.org |
This message was automatically generated.
> ServerInformationReply should include multiple groups
> -
>
>
[jira] [Commented] (RATIS-338) ServerInformationReply should include multiple groups
[ https://issues.apache.org/jira/browse/RATIS-338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16659059#comment-16659059 ] Tsz Wo Nicholas Sze commented on RATIS-338: --- +1 the v5 patch looks good. Thanks [~sergey.soldatov]. > ServerInformationReply should include multiple groups > - > > Key: RATIS-338 > URL: https://issues.apache.org/jira/browse/RATIS-338 > Project: Ratis > Issue Type: Sub-task > Components: server >Reporter: Tsz Wo Nicholas Sze >Assignee: Sergey Soldatov >Priority: Major > Attachments: RATIS-338-v5.patch > > > ServerInformationReply currently only returns information of a particular > group. It should return informations of all the groups. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (RATIS-352) Persist commit index in Raft log.
[ https://issues.apache.org/jira/browse/RATIS-352?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tsz Wo Nicholas Sze updated RATIS-352: -- Attachment: (was: r352_20181022d.patch) > Persist commit index in Raft log. > - > > Key: RATIS-352 > URL: https://issues.apache.org/jira/browse/RATIS-352 > Project: Ratis > Issue Type: Improvement > Components: server >Reporter: Tsz Wo Nicholas Sze >Assignee: Tsz Wo Nicholas Sze >Priority: Major > Attachments: r352_20181022d.patch > > > Current the commit index is not persisted in the Raft log. When a server > restarts, it cannot apply its log until it has joined a Raft group. There is > no problem if there is a Raft group. > However, a server cannot recover its data when formatting a Raft group is > impossible (e.g. a majority of servers are dead). Ideally, a server can > safely apply the log up to the commit index. The JIRA is to persist the > commit index so that such recovery is possible. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (RATIS-361) Fix the NPE bug in MemoryRaftLog
[
https://issues.apache.org/jira/browse/RATIS-361?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tsz Wo Nicholas Sze updated RATIS-361:
--
Attachment: (was: r361_20181022.patch)
> Fix the NPE bug in MemoryRaftLog
>
>
> Key: RATIS-361
> URL: https://issues.apache.org/jira/browse/RATIS-361
> Project: Ratis
> Issue Type: Bug
> Components: server
>Reporter: Tsz Wo Nicholas Sze
>Assignee: Tsz Wo Nicholas Sze
>Priority: Major
> Fix For: 0.3.0
>
> Attachments: r361_20181022.patch
>
>
> As stated in the TODO in
> TestStateMachine.testTransactionContextIsPassedBack(), MemoryRaftLog may
> throw NPE.
> {code}
> // TODO: fix and run with in-memory log. It fails with NPE
> // TODO: if change setUseMemory to true
> RaftServerConfigKeys.Log.setUseMemory(properties, false);
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (RATIS-361) Fix the NPE bug in MemoryRaftLog
[
https://issues.apache.org/jira/browse/RATIS-361?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tsz Wo Nicholas Sze updated RATIS-361:
--
Attachment: r361_20181022.patch
> Fix the NPE bug in MemoryRaftLog
>
>
> Key: RATIS-361
> URL: https://issues.apache.org/jira/browse/RATIS-361
> Project: Ratis
> Issue Type: Bug
> Components: server
>Reporter: Tsz Wo Nicholas Sze
>Assignee: Tsz Wo Nicholas Sze
>Priority: Major
> Fix For: 0.3.0
>
> Attachments: r361_20181022.patch
>
>
> As stated in the TODO in
> TestStateMachine.testTransactionContextIsPassedBack(), MemoryRaftLog may
> throw NPE.
> {code}
> // TODO: fix and run with in-memory log. It fails with NPE
> // TODO: if change setUseMemory to true
> RaftServerConfigKeys.Log.setUseMemory(properties, false);
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (RATIS-352) Persist commit index in Raft log.
[ https://issues.apache.org/jira/browse/RATIS-352?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tsz Wo Nicholas Sze updated RATIS-352: -- Attachment: r352_20181022d.patch > Persist commit index in Raft log. > - > > Key: RATIS-352 > URL: https://issues.apache.org/jira/browse/RATIS-352 > Project: Ratis > Issue Type: Improvement > Components: server >Reporter: Tsz Wo Nicholas Sze >Assignee: Tsz Wo Nicholas Sze >Priority: Major > Attachments: r352_20181022d.patch > > > Current the commit index is not persisted in the Raft log. When a server > restarts, it cannot apply its log until it has joined a Raft group. There is > no problem if there is a Raft group. > However, a server cannot recover its data when formatting a Raft group is > impossible (e.g. a majority of servers are dead). Ideally, a server can > safely apply the log up to the commit index. The JIRA is to persist the > commit index so that such recovery is possible. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (RATIS-352) Persist commit index in Raft log.
[
https://issues.apache.org/jira/browse/RATIS-352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16659053#comment-16659053
]
Hadoop QA commented on RATIS-352:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 6m
6s{color} | {color:blue} Docker mode activated. {color} |
| {color:red}-1{color} | {color:red} patch {color} | {color:red} 0m 4s{color}
| {color:red} RATIS-352 does not apply to master. Rebase required? Wrong
Branch? See https://yetus.apache.org/documentation/0.5.0/precommit-patchnames
for help. {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/ratis:date2018-10-22
|
| JIRA Issue | RATIS-352 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12945033/r352_20181022d.patch |
| Console output |
https://builds.apache.org/job/PreCommit-RATIS-Build/435/console |
| Powered by | Apache Yetus 0.5.0 http://yetus.apache.org |
This message was automatically generated.
> Persist commit index in Raft log.
> -
>
> Key: RATIS-352
> URL: https://issues.apache.org/jira/browse/RATIS-352
> Project: Ratis
> Issue Type: Improvement
> Components: server
>Reporter: Tsz Wo Nicholas Sze
>Assignee: Tsz Wo Nicholas Sze
>Priority: Major
> Attachments: r352_20181022d.patch
>
>
> Current the commit index is not persisted in the Raft log. When a server
> restarts, it cannot apply its log until it has joined a Raft group. There is
> no problem if there is a Raft group.
> However, a server cannot recover its data when formatting a Raft group is
> impossible (e.g. a majority of servers are dead). Ideally, a server can
> safely apply the log up to the commit index. The JIRA is to persist the
> commit index so that such recovery is possible.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (RATIS-352) Persist commit index in Raft log.
[ https://issues.apache.org/jira/browse/RATIS-352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16659050#comment-16659050 ] Tsz Wo Nicholas Sze commented on RATIS-352: --- r352_20181022d.patch: checks null for logConsumer. > Persist commit index in Raft log. > - > > Key: RATIS-352 > URL: https://issues.apache.org/jira/browse/RATIS-352 > Project: Ratis > Issue Type: Improvement > Components: server >Reporter: Tsz Wo Nicholas Sze >Assignee: Tsz Wo Nicholas Sze >Priority: Major > Attachments: r352_20181022d.patch > > > Current the commit index is not persisted in the Raft log. When a server > restarts, it cannot apply its log until it has joined a Raft group. There is > no problem if there is a Raft group. > However, a server cannot recover its data when formatting a Raft group is > impossible (e.g. a majority of servers are dead). Ideally, a server can > safely apply the log up to the commit index. The JIRA is to persist the > commit index so that such recovery is possible. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (RATIS-352) Persist commit index in Raft log.
[ https://issues.apache.org/jira/browse/RATIS-352?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tsz Wo Nicholas Sze updated RATIS-352: -- Attachment: (was: r352_20181022c.patch) > Persist commit index in Raft log. > - > > Key: RATIS-352 > URL: https://issues.apache.org/jira/browse/RATIS-352 > Project: Ratis > Issue Type: Improvement > Components: server >Reporter: Tsz Wo Nicholas Sze >Assignee: Tsz Wo Nicholas Sze >Priority: Major > Attachments: r352_20181022d.patch > > > Current the commit index is not persisted in the Raft log. When a server > restarts, it cannot apply its log until it has joined a Raft group. There is > no problem if there is a Raft group. > However, a server cannot recover its data when formatting a Raft group is > impossible (e.g. a majority of servers are dead). Ideally, a server can > safely apply the log up to the commit index. The JIRA is to persist the > commit index so that such recovery is possible. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (RATIS-352) Persist commit index in Raft log.
[ https://issues.apache.org/jira/browse/RATIS-352?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tsz Wo Nicholas Sze updated RATIS-352: -- Attachment: r352_20181022d.patch > Persist commit index in Raft log. > - > > Key: RATIS-352 > URL: https://issues.apache.org/jira/browse/RATIS-352 > Project: Ratis > Issue Type: Improvement > Components: server >Reporter: Tsz Wo Nicholas Sze >Assignee: Tsz Wo Nicholas Sze >Priority: Major > Attachments: r352_20181022d.patch > > > Current the commit index is not persisted in the Raft log. When a server > restarts, it cannot apply its log until it has joined a Raft group. There is > no problem if there is a Raft group. > However, a server cannot recover its data when formatting a Raft group is > impossible (e.g. a majority of servers are dead). Ideally, a server can > safely apply the log up to the commit index. The JIRA is to persist the > commit index so that such recovery is possible. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (RATIS-338) ServerInformationReply should include multiple groups
[ https://issues.apache.org/jira/browse/RATIS-338?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tsz Wo Nicholas Sze updated RATIS-338: -- Attachment: (was: RATIS-338-v4.patch) > ServerInformationReply should include multiple groups > - > > Key: RATIS-338 > URL: https://issues.apache.org/jira/browse/RATIS-338 > Project: Ratis > Issue Type: Sub-task > Components: server >Reporter: Tsz Wo Nicholas Sze >Assignee: Sergey Soldatov >Priority: Major > Attachments: RATIS-338-v5.patch > > > ServerInformationReply currently only returns information of a particular > group. It should return informations of all the groups. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (RATIS-364) Raft should persist configuration entries to meta file
[ https://issues.apache.org/jira/browse/RATIS-364?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mukul Kumar Singh updated RATIS-364: Attachment: RATIS-364.001.patch > Raft should persist configuration entries to meta file > -- > > Key: RATIS-364 > URL: https://issues.apache.org/jira/browse/RATIS-364 > Project: Ratis > Issue Type: Bug > Components: server >Reporter: Mukul Kumar Singh >Assignee: Mukul Kumar Singh >Priority: Major > Attachments: RATIS-364.001.patch > > > The responsibility of storing the raft configuration currently is state > Machine's responsibility. > This jira proposes to add a mechanism for Raft Server to persist the > configuration to its own metafile -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (RATIS-364) Raft should persist configuration entries to meta file
Mukul Kumar Singh created RATIS-364: --- Summary: Raft should persist configuration entries to meta file Key: RATIS-364 URL: https://issues.apache.org/jira/browse/RATIS-364 Project: Ratis Issue Type: Bug Components: server Reporter: Mukul Kumar Singh Assignee: Mukul Kumar Singh The responsibility of storing the raft configuration currently is state Machine's responsibility. This jira proposes to add a mechanism for Raft Server to persist the configuration to its own metafile -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (RATIS-361) Fix the NPE bug in MemoryRaftLog
[
https://issues.apache.org/jira/browse/RATIS-361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16659042#comment-16659042
]
Lokesh Jain commented on RATIS-361:
---
[~szetszwo] Thanks for working on this! The patch looks good to me. +1.
> Fix the NPE bug in MemoryRaftLog
>
>
> Key: RATIS-361
> URL: https://issues.apache.org/jira/browse/RATIS-361
> Project: Ratis
> Issue Type: Bug
> Components: server
>Reporter: Tsz Wo Nicholas Sze
>Assignee: Tsz Wo Nicholas Sze
>Priority: Major
> Attachments: r361_20181022.patch
>
>
> As stated in the TODO in
> TestStateMachine.testTransactionContextIsPassedBack(), MemoryRaftLog may
> throw NPE.
> {code}
> // TODO: fix and run with in-memory log. It fails with NPE
> // TODO: if change setUseMemory to true
> RaftServerConfigKeys.Log.setUseMemory(properties, false);
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (RATIS-352) Persist commit index in Raft log.
[
https://issues.apache.org/jira/browse/RATIS-352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16659019#comment-16659019
]
Hadoop QA commented on RATIS-352:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 1m
20s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
1s{color} | {color:blue} Findbugs executables are not available. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 7 new or modified test
files. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 1m
18s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m
47s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
42s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
30s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
35s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
5s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
46s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
43s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} cc {color} | {color:green} 0m
43s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} javac {color} | {color:red} 0m 43s{color}
| {color:red} root generated 1 new + 99 unchanged - 0 fixed = 100 total (was
99) {color} |
| {color:orange}-0{color} | {color:orange} checkstyle {color} | {color:orange}
0m 27s{color} | {color:orange} root: The patch generated 55 new + 965 unchanged
- 32 fixed = 1020 total (was 997) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
29s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 8m 37s{color}
| {color:red} root in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
13s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 17m 42s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | ratis.TestRaftServerSlownessDetection |
| | ratis.server.storage.TestSegmentedRaftLog |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/ratis:date2018-10-22
|
| JIRA Issue | RATIS-352 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12945018/r352_20181022c.patch |
| Optional Tests | asflicense javac javadoc unit findbugs checkstyle
compile cc |
| uname | Linux e60168b22fcd 3.13.0-139-generic #188-Ubuntu SMP Tue Jan 9
14:43:09 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-RATIS-Build/yetus-personality.sh
|
| git revision | master / ce78399 |
| Default Java | 1.8.0_181 |
| javac |
https://builds.apache.org/job/PreCommit-RATIS-Build/433/artifact/out/diff-compile-javac-root.txt
|
| checkstyle |
https://builds.apache.org/job/PreCommit-RATIS-Build/433/artifact/out/diff-checkstyle-root.txt
|
| unit |
https://builds.apache.org/job/PreCommit-RATIS-Build/433/artifact/out/patch-unit-root.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-RATIS-Build/433/testReport/ |
| modules | C: ratis-proto ratis-server ratis-examples U: . |
| Console output |
https://builds.apache.org/job/PreCommit-RATIS-Build/433/console |
| Powered by | Apache Yetus 0.5.0 http://yetus.apache.org |
This message was automatically generated.
> Persist commit index in Raft log.
> -
>
> Key:
[jira] [Commented] (RATIS-352) Persist commit index in Raft log.
[
https://issues.apache.org/jira/browse/RATIS-352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16659004#comment-16659004
]
Hadoop QA commented on RATIS-352:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 4m
12s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
0s{color} | {color:blue} Findbugs executables are not available. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 7 new or modified test
files. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
19s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
49s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
39s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
20s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
27s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
4s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
46s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
40s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} cc {color} | {color:green} 0m
40s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} javac {color} | {color:red} 0m 40s{color}
| {color:red} root generated 1 new + 99 unchanged - 0 fixed = 100 total (was
99) {color} |
| {color:orange}-0{color} | {color:orange} checkstyle {color} | {color:orange}
0m 24s{color} | {color:orange} root: The patch generated 55 new + 965 unchanged
- 32 fixed = 1020 total (was 997) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
28s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 17m 4s{color}
| {color:red} root in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
6s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 26m 27s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | ratis.server.TestRaftLogMetrics |
| | ratis.server.storage.TestSegmentedRaftLog |
| | ratis.server.simulation.TestRaftReconfigurationWithSimulatedRpc |
| | ratis.server.simulation.TestRaftStateMachineExceptionWithSimulatedRpc |
| | ratis.TestRaftServerSlownessDetection |
| | ratis.server.simulation.TestRaftSnapshotWithSimulatedRpc |
| | ratis.server.simulation.TestRaftWithSimulatedRpc |
| | ratis.TestRaftServerLeaderElectionTimeout |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/ratis:date2018-10-22
|
| JIRA Issue | RATIS-352 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12945018/r352_20181022c.patch |
| Optional Tests | asflicense javac javadoc unit findbugs checkstyle
compile cc |
| uname | Linux a224713482f2 4.4.0-133-generic #159-Ubuntu SMP Fri Aug 10
07:31:43 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-RATIS-Build/yetus-personality.sh
|
| git revision | master / ce78399 |
| Default Java | 1.8.0_181 |
| javac |
https://builds.apache.org/job/PreCommit-RATIS-Build/432/artifact/out/diff-compile-javac-root.txt
|
| checkstyle |
https://builds.apache.org/job/PreCommit-RATIS-Build/432/artifact/out/diff-checkstyle-root.txt
|
| unit |
https://builds.apache.org/job/PreCommit-RATIS-Build/432/artifact/out/patch-unit-root.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-RATIS-Build/432/testReport/
[jira] [Commented] (RATIS-352) Persist commit index in Raft log.
[ https://issues.apache.org/jira/browse/RATIS-352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16658968#comment-16658968 ] Tsz Wo Nicholas Sze commented on RATIS-352: --- r352_20181022c.patch: fixes unit tests. > Persist commit index in Raft log. > - > > Key: RATIS-352 > URL: https://issues.apache.org/jira/browse/RATIS-352 > Project: Ratis > Issue Type: Improvement > Components: server >Reporter: Tsz Wo Nicholas Sze >Assignee: Tsz Wo Nicholas Sze >Priority: Major > Attachments: r352_20181022c.patch > > > Current the commit index is not persisted in the Raft log. When a server > restarts, it cannot apply its log until it has joined a Raft group. There is > no problem if there is a Raft group. > However, a server cannot recover its data when formatting a Raft group is > impossible (e.g. a majority of servers are dead). Ideally, a server can > safely apply the log up to the commit index. The JIRA is to persist the > commit index so that such recovery is possible. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (RATIS-352) Persist commit index in Raft log.
[ https://issues.apache.org/jira/browse/RATIS-352?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tsz Wo Nicholas Sze updated RATIS-352: -- Attachment: (was: r352_20181022b.patch) > Persist commit index in Raft log. > - > > Key: RATIS-352 > URL: https://issues.apache.org/jira/browse/RATIS-352 > Project: Ratis > Issue Type: Improvement > Components: server >Reporter: Tsz Wo Nicholas Sze >Assignee: Tsz Wo Nicholas Sze >Priority: Major > Attachments: r352_20181022c.patch > > > Current the commit index is not persisted in the Raft log. When a server > restarts, it cannot apply its log until it has joined a Raft group. There is > no problem if there is a Raft group. > However, a server cannot recover its data when formatting a Raft group is > impossible (e.g. a majority of servers are dead). Ideally, a server can > safely apply the log up to the commit index. The JIRA is to persist the > commit index so that such recovery is possible. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (RATIS-352) Persist commit index in Raft log.
[ https://issues.apache.org/jira/browse/RATIS-352?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tsz Wo Nicholas Sze updated RATIS-352: -- Attachment: r352_20181022c.patch > Persist commit index in Raft log. > - > > Key: RATIS-352 > URL: https://issues.apache.org/jira/browse/RATIS-352 > Project: Ratis > Issue Type: Improvement > Components: server >Reporter: Tsz Wo Nicholas Sze >Assignee: Tsz Wo Nicholas Sze >Priority: Major > Attachments: r352_20181022c.patch > > > Current the commit index is not persisted in the Raft log. When a server > restarts, it cannot apply its log until it has joined a Raft group. There is > no problem if there is a Raft group. > However, a server cannot recover its data when formatting a Raft group is > impossible (e.g. a majority of servers are dead). Ideally, a server can > safely apply the log up to the commit index. The JIRA is to persist the > commit index so that such recovery is possible. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (RATIS-338) ServerInformationReply should include multiple groups
[
https://issues.apache.org/jira/browse/RATIS-338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16658954#comment-16658954
]
Hadoop QA commented on RATIS-338:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 8m
5s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
0s{color} | {color:blue} Findbugs executables are not available. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 2 new or modified test
files. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 1m
26s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 2m
3s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
50s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
42s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
44s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
7s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m
5s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
57s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} cc {color} | {color:green} 0m
57s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
57s{color} | {color:green} the patch passed {color} |
| {color:orange}-0{color} | {color:orange} checkstyle {color} | {color:orange}
0m 37s{color} | {color:orange} root: The patch generated 158 new + 1169
unchanged - 73 fixed = 1327 total (was 1242) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
30s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 25m 7s{color}
| {color:red} root in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
14s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 42m 40s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | ratis.TestRaftServerLeaderElectionTimeout |
| | ratis.server.simulation.TestRaftExceptionWithSimulation |
| | ratis.server.simulation.TestRaftStateMachineExceptionWithSimulatedRpc |
| | ratis.server.simulation.TestRaftReconfigurationWithSimulatedRpc |
| | ratis.server.simulation.TestLeaderElectionWithSimulatedRpc |
| | ratis.TestRaftServerSlownessDetection |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/ratis:date2018-10-22
|
| JIRA Issue | RATIS-338 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12944668/RATIS-338-v4.patch |
| Optional Tests | asflicense javac javadoc unit findbugs checkstyle
compile cc |
| uname | Linux 3c295f28c0a5 3.13.0-153-generic #203-Ubuntu SMP Thu Jun 14
08:52:28 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-RATIS-Build/yetus-personality.sh
|
| git revision | master / ce78399 |
| Default Java | 1.8.0_181 |
| checkstyle |
https://builds.apache.org/job/PreCommit-RATIS-Build/431/artifact/out/diff-checkstyle-root.txt
|
| unit |
https://builds.apache.org/job/PreCommit-RATIS-Build/431/artifact/out/patch-unit-root.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-RATIS-Build/431/testReport/ |
| modules | C: ratis-proto ratis-common ratis-client ratis-server ratis-grpc
ratis-netty ratis-hadoop U: . |
| Console output |
https://builds.apache.org/job/PreCommit-RATIS-Build/431/console |
| Powered by | Apache Yetus 0.5.0
[jira] [Commented] (RATIS-338) ServerInformationReply should include multiple groups
[ https://issues.apache.org/jira/browse/RATIS-338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16658909#comment-16658909 ] Sergey Soldatov commented on RATIS-338: --- [~szetszwo] addressed all 3 bullets in v5. > ServerInformationReply should include multiple groups > - > > Key: RATIS-338 > URL: https://issues.apache.org/jira/browse/RATIS-338 > Project: Ratis > Issue Type: Sub-task > Components: server >Reporter: Tsz Wo Nicholas Sze >Assignee: Sergey Soldatov >Priority: Major > Attachments: RATIS-338-v4.patch, RATIS-338-v5.patch > > > ServerInformationReply currently only returns information of a particular > group. It should return informations of all the groups. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (RATIS-338) ServerInformationReply should include multiple groups
[ https://issues.apache.org/jira/browse/RATIS-338?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sergey Soldatov updated RATIS-338: -- Attachment: RATIS-338-v5.patch > ServerInformationReply should include multiple groups > - > > Key: RATIS-338 > URL: https://issues.apache.org/jira/browse/RATIS-338 > Project: Ratis > Issue Type: Sub-task > Components: server >Reporter: Tsz Wo Nicholas Sze >Assignee: Sergey Soldatov >Priority: Major > Attachments: RATIS-338-v4.patch, RATIS-338-v5.patch > > > ServerInformationReply currently only returns information of a particular > group. It should return informations of all the groups. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Resolved] (RATIS-331) Ratis client should provide a method to wait for commit from all the replica
[ https://issues.apache.org/jira/browse/RATIS-331?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shashikant Banerjee resolved RATIS-331. --- Resolution: Fixed > Ratis client should provide a method to wait for commit from all the replica > > > Key: RATIS-331 > URL: https://issues.apache.org/jira/browse/RATIS-331 > Project: Ratis > Issue Type: Bug > Components: client >Affects Versions: 0.3.0 >Reporter: Mukul Kumar Singh >Assignee: Shashikant Banerjee >Priority: Major > Fix For: 0.3.0 > > > Ratis client should provide a method to wait for commit from all the peers. > Also it will be great is supplier method can be provided to take an action on > this event. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (RATIS-363) StateMachineUpdater should wait for committed transactions to be applied before shutdown.
[ https://issues.apache.org/jira/browse/RATIS-363?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16658799#comment-16658799 ] Tsz Wo Nicholas Sze commented on RATIS-363: --- +1 the .5 patch looks good. > StateMachineUpdater should wait for committed transactions to be applied > before shutdown. > - > > Key: RATIS-363 > URL: https://issues.apache.org/jira/browse/RATIS-363 > Project: Ratis > Issue Type: Improvement > Components: server >Reporter: Jitendra Nath Pandey >Assignee: Jitendra Nath Pandey >Priority: Blocker > Attachments: RATIS-363.5.patch > > > StateMachineUpdater should apply all the committed transactions before > shutdown, otherwise committed data can be lost. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (RATIS-363) StateMachineUpdater should wait for committed transactions to be applied before shutdown.
[
https://issues.apache.org/jira/browse/RATIS-363?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16658759#comment-16658759
]
Hadoop QA commented on RATIS-363:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
21s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
0s{color} | {color:blue} Findbugs executables are not available. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 2 new or modified test
files. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
18s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m
6s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
50s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
22s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
37s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
6s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
59s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
51s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
51s{color} | {color:green} the patch passed {color} |
| {color:orange}-0{color} | {color:orange} checkstyle {color} | {color:orange}
0m 18s{color} | {color:orange} root: The patch generated 8 new + 179 unchanged
- 5 fixed = 187 total (was 184) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
34s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 23m 56s{color}
| {color:red} root in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
8s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 30m 35s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests |
ratis.server.simulation.TestRaftReconfigurationWithSimulatedRpc |
| | ratis.server.simulation.TestGroupManagementWithSimulatedRpc |
| | ratis.TestRaftServerLeaderElectionTimeout |
| | ratis.server.simulation.TestRaftStateMachineExceptionWithSimulatedRpc |
| | ratis.TestRaftServerSlownessDetection |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/ratis:date2018-10-22
|
| JIRA Issue | RATIS-363 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12944961/RATIS-363.5.patch |
| Optional Tests | asflicense javac javadoc unit findbugs checkstyle
compile |
| uname | Linux c6cd044a690f 3.13.0-153-generic #203-Ubuntu SMP Thu Jun 14
08:52:28 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-RATIS-Build/yetus-personality.sh
|
| git revision | master / 60d0bc1 |
| Default Java | 1.8.0_181 |
| checkstyle |
https://builds.apache.org/job/PreCommit-RATIS-Build/428/artifact/out/diff-checkstyle-root.txt
|
| unit |
https://builds.apache.org/job/PreCommit-RATIS-Build/428/artifact/out/patch-unit-root.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-RATIS-Build/428/testReport/ |
| modules | C: ratis-server ratis-grpc U: . |
| Console output |
https://builds.apache.org/job/PreCommit-RATIS-Build/428/console |
| Powered by | Apache Yetus 0.5.0 http://yetus.apache.org |
This message was automatically generated.
> StateMachineUpdater should wait for committed transactions to be applied
> before shutdown.
> -
>
>
[jira] [Commented] (RATIS-363) StateMachineUpdater should wait for committed transactions to be applied before shutdown.
[ https://issues.apache.org/jira/browse/RATIS-363?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16658721#comment-16658721 ] Jitendra Nath Pandey commented on RATIS-363: RATIS-363.5.patch fixes the checkstyle issues. The failed unit tests, fail without this patch as well > StateMachineUpdater should wait for committed transactions to be applied > before shutdown. > - > > Key: RATIS-363 > URL: https://issues.apache.org/jira/browse/RATIS-363 > Project: Ratis > Issue Type: Improvement > Components: server >Reporter: Jitendra Nath Pandey >Assignee: Jitendra Nath Pandey >Priority: Blocker > Attachments: RATIS-363.5.patch > > > StateMachineUpdater should apply all the committed transactions before > shutdown, otherwise committed data can be lost. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (RATIS-363) StateMachineUpdater should wait for committed transactions to be applied before shutdown.
[ https://issues.apache.org/jira/browse/RATIS-363?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jitendra Nath Pandey updated RATIS-363: --- Attachment: RATIS-363.5.patch > StateMachineUpdater should wait for committed transactions to be applied > before shutdown. > - > > Key: RATIS-363 > URL: https://issues.apache.org/jira/browse/RATIS-363 > Project: Ratis > Issue Type: Improvement > Components: server >Reporter: Jitendra Nath Pandey >Assignee: Jitendra Nath Pandey >Priority: Blocker > Attachments: RATIS-363.5.patch > > > StateMachineUpdater should apply all the committed transactions before > shutdown, otherwise committed data can be lost. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (RATIS-363) StateMachineUpdater should wait for committed transactions to be applied before shutdown.
[
https://issues.apache.org/jira/browse/RATIS-363?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16658657#comment-16658657
]
Hadoop QA commented on RATIS-363:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 1m
23s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
1s{color} | {color:blue} Findbugs executables are not available. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 2 new or modified test
files. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
12s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
53s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
43s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
16s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
30s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
5s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
56s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
52s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
52s{color} | {color:green} the patch passed {color} |
| {color:orange}-0{color} | {color:orange} checkstyle {color} | {color:orange}
0m 18s{color} | {color:orange} root: The patch generated 12 new + 179 unchanged
- 5 fixed = 191 total (was 184) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
32s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 17m 53s{color}
| {color:red} root in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
6s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 24m 51s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | ratis.TestRaftServerLeaderElectionTimeout |
| | ratis.server.simulation.TestRaftWithSimulatedRpc |
| | ratis.server.simulation.TestRaftReconfigurationWithSimulatedRpc |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/ratis:date2018-10-22
|
| JIRA Issue | RATIS-363 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12944940/RATIS-363.4.patch |
| Optional Tests | asflicense javac javadoc unit findbugs checkstyle
compile |
| uname | Linux 5775403437dc 3.13.0-143-generic #192-Ubuntu SMP Tue Feb 27
10:45:36 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-RATIS-Build/yetus-personality.sh
|
| git revision | master / 60d0bc1 |
| Default Java | 1.8.0_181 |
| checkstyle |
https://builds.apache.org/job/PreCommit-RATIS-Build/427/artifact/out/diff-checkstyle-root.txt
|
| unit |
https://builds.apache.org/job/PreCommit-RATIS-Build/427/artifact/out/patch-unit-root.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-RATIS-Build/427/testReport/ |
| modules | C: ratis-server ratis-grpc U: . |
| Console output |
https://builds.apache.org/job/PreCommit-RATIS-Build/427/console |
| Powered by | Apache Yetus 0.5.0 http://yetus.apache.org |
This message was automatically generated.
> StateMachineUpdater should wait for committed transactions to be applied
> before shutdown.
> -
>
> Key: RATIS-363
> URL: https://issues.apache.org/jira/browse/RATIS-363
> Project: Ratis
>
[jira] [Commented] (RATIS-363) StateMachineUpdater should wait for committed transactions to be applied before shutdown.
[ https://issues.apache.org/jira/browse/RATIS-363?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16658622#comment-16658622 ] Jitendra Nath Pandey commented on RATIS-363: Thanks for review comments [~szetszwo] and [~msingh]. I have updated the patch accordingly. > StateMachineUpdater should wait for committed transactions to be applied > before shutdown. > - > > Key: RATIS-363 > URL: https://issues.apache.org/jira/browse/RATIS-363 > Project: Ratis > Issue Type: Improvement > Components: server >Reporter: Jitendra Nath Pandey >Assignee: Jitendra Nath Pandey >Priority: Blocker > Attachments: RATIS-363.4.patch > > > StateMachineUpdater should apply all the committed transactions before > shutdown, otherwise committed data can be lost. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (RATIS-363) StateMachineUpdater should wait for committed transactions to be applied before shutdown.
[ https://issues.apache.org/jira/browse/RATIS-363?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jitendra Nath Pandey updated RATIS-363: --- Attachment: RATIS-363.4.patch > StateMachineUpdater should wait for committed transactions to be applied > before shutdown. > - > > Key: RATIS-363 > URL: https://issues.apache.org/jira/browse/RATIS-363 > Project: Ratis > Issue Type: Improvement > Components: server >Reporter: Jitendra Nath Pandey >Assignee: Jitendra Nath Pandey >Priority: Blocker > Attachments: RATIS-363.4.patch > > > StateMachineUpdater should apply all the committed transactions before > shutdown, otherwise committed data can be lost. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (RATIS-363) StateMachineUpdater should wait for committed transactions to be applied before shutdown.
[ https://issues.apache.org/jira/browse/RATIS-363?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jitendra Nath Pandey updated RATIS-363: --- Attachment: (was: RATIS-363.3.patch) > StateMachineUpdater should wait for committed transactions to be applied > before shutdown. > - > > Key: RATIS-363 > URL: https://issues.apache.org/jira/browse/RATIS-363 > Project: Ratis > Issue Type: Improvement > Components: server >Reporter: Jitendra Nath Pandey >Assignee: Jitendra Nath Pandey >Priority: Blocker > Attachments: RATIS-363.4.patch > > > StateMachineUpdater should apply all the committed transactions before > shutdown, otherwise committed data can be lost. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
