[jira] [Commented] (RATIS-364) Raft should persist configuration entries to meta file

2018-10-23 Thread Tsz Wo Nicholas Sze (JIRA) 


[ 
https://issues.apache.org/jira/browse/RATIS-364?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16660936#comment-16660936
 ] 

Tsz Wo Nicholas Sze commented on RATIS-364:
---

Filed RATIS-368.

> Raft should persist configuration entries to meta file
> --
>
> Key: RATIS-364
> URL: https://issues.apache.org/jira/browse/RATIS-364
> Project: Ratis
>  Issue Type: Improvement
>  Components: server
>Reporter: Mukul Kumar Singh
>Assignee: Mukul Kumar Singh
>Priority: Major
> Attachments: RATIS-364.002.patch
>
>
> The responsibility of storing the raft configuration currently is state 
> Machine's responsibility.
> This jira proposes to add a mechanism for Raft Server to persist the 
> configuration to its own metafile



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (RATIS-364) Raft should persist configuration entries to meta file

2018-10-23 Thread Tsz Wo Nicholas Sze (JIRA) 


[ 
https://issues.apache.org/jira/browse/RATIS-364?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16660929#comment-16660929
 ] 

Tsz Wo Nicholas Sze commented on RATIS-364:
---

[~msingh], just found that some tests failed after this, e.g. 
TestRaftSnapshotWithSimulatedRpc.testRestartPeer.  It fails with
{code}
Caused by: java.lang.IllegalStateException
at org.apache.ratis.util.Preconditions.assertTrue(Preconditions.java:33)
at 
org.apache.ratis.server.impl.ConfigurationManager.addConfiguration(ConfigurationManager.java:47)
at 
org.apache.ratis.server.impl.ServerState.setRaftConf(ServerState.java:351)
{code}


> Raft should persist configuration entries to meta file
> --
>
> Key: RATIS-364
> URL: https://issues.apache.org/jira/browse/RATIS-364
> Project: Ratis
>  Issue Type: Improvement
>  Components: server
>Reporter: Mukul Kumar Singh
>Assignee: Mukul Kumar Singh
>Priority: Major
> Attachments: RATIS-364.002.patch
>
>
> The responsibility of storing the raft configuration currently is state 
> Machine's responsibility.
> This jira proposes to add a mechanism for Raft Server to persist the 
> configuration to its own metafile



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (RATIS-364) Raft should persist configuration entries to meta file

2018-10-22 Thread Tsz Wo Nicholas Sze (JIRA) 


[ 
https://issues.apache.org/jira/browse/RATIS-364?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16660089#comment-16660089
 ] 

Tsz Wo Nicholas Sze commented on RATIS-364:
---

+1 the 002 patch looks good.

> Raft should persist configuration entries to meta file
> --
>
> Key: RATIS-364
> URL: https://issues.apache.org/jira/browse/RATIS-364
> Project: Ratis
>  Issue Type: Improvement
>  Components: server
>Reporter: Mukul Kumar Singh
>Assignee: Mukul Kumar Singh
>Priority: Major
> Attachments: RATIS-364.002.patch
>
>
> The responsibility of storing the raft configuration currently is state 
> Machine's responsibility.
> This jira proposes to add a mechanism for Raft Server to persist the 
> configuration to its own metafile



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (RATIS-364) Raft should persist configuration entries to meta file

2018-10-22 Thread Hadoop QA (JIRA) 


[ 
https://issues.apache.org/jira/browse/RATIS-364?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16659146#comment-16659146
 ] 

Hadoop QA commented on RATIS-364:
-

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  0m 
14s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  0m  
0s{color} | {color:blue} Findbugs executables are not available. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red}  0m  
0s{color} | {color:red} The patch doesn't appear to include any new or modified 
tests. Please justify why no new tests are needed for this patch. Also please 
list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  1m 
 5s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
57s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
28s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
40s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  1m 
 5s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
58s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  0m 
58s{color} | {color:green} the patch passed {color} |
| {color:orange}-0{color} | {color:orange} checkstyle {color} | {color:orange}  
0m 27s{color} | {color:orange} root: The patch generated 15 new + 742 unchanged 
- 8 fixed = 757 total (was 750) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
38s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 19m 35s{color} 
| {color:red} root in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 
 6s{color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 26m 22s{color} | 
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | 
ratis.server.simulation.TestRaftReconfigurationWithSimulatedRpc |
|   | ratis.server.simulation.TestRaftWithSimulatedRpc |
|   | ratis.TestRaftServerSlownessDetection |
|   | ratis.TestRaftServerLeaderElectionTimeout |
|   | ratis.server.simulation.TestRaftSnapshotWithSimulatedRpc |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/ratis:date2018-10-22 
|
| JIRA Issue | RATIS-364 |
| JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/12945043/RATIS-364.002.patch |
| Optional Tests |  asflicense  javac  javadoc  unit  findbugs  checkstyle  
compile  |
| uname | Linux ea975c07cb53 3.13.0-153-generic #203-Ubuntu SMP Thu Jun 14 
08:52:28 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | 
/home/jenkins/jenkins-slave/workspace/PreCommit-RATIS-Build/yetus-personality.sh
 |
| git revision | master / 39916f2 |
| Default Java | 1.8.0_181 |
| checkstyle | 
https://builds.apache.org/job/PreCommit-RATIS-Build/438/artifact/out/diff-checkstyle-root.txt
 |
| unit | 
https://builds.apache.org/job/PreCommit-RATIS-Build/438/artifact/out/patch-unit-root.txt
 |
|  Test Results | 
https://builds.apache.org/job/PreCommit-RATIS-Build/438/testReport/ |
| modules | C: ratis-server U: ratis-server |
| Console output | 
https://builds.apache.org/job/PreCommit-RATIS-Build/438/console |
| Powered by | Apache Yetus 0.5.0   http://yetus.apache.org |


This message was automatically generated.



> Raft should persist configuration entries to meta file
> --
>
> Key: RATIS-364
> URL: https://issues.apache.org/jira/browse/RATIS-364
> Project: Ratis
>  Issue Type: Improvement
>  Components: server
>Reporter: Mukul Kumar Singh
>

[jira] [Commented] (RATIS-364) Raft should persist configuration entries to meta file

2018-10-22 Thread Mukul Kumar Singh (JIRA) 


[ 
https://issues.apache.org/jira/browse/RATIS-364?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16659115#comment-16659115
 ] 

Mukul Kumar Singh commented on RATIS-364:
-

Thanks for the review [~szetszwo]. patch v2 fixes the review comments.

> Raft should persist configuration entries to meta file
> --
>
> Key: RATIS-364
> URL: https://issues.apache.org/jira/browse/RATIS-364
> Project: Ratis
>  Issue Type: Improvement
>  Components: server
>Reporter: Mukul Kumar Singh
>Assignee: Mukul Kumar Singh
>Priority: Major
> Attachments: RATIS-364.002.patch
>
>
> The responsibility of storing the raft configuration currently is state 
> Machine's responsibility.
> This jira proposes to add a mechanism for Raft Server to persist the 
> configuration to its own metafile



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (RATIS-364) Raft should persist configuration entries to meta file

2018-10-22 Thread Tsz Wo Nicholas Sze (JIRA) 


[ 
https://issues.apache.org/jira/browse/RATIS-364?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16659100#comment-16659100
 ] 

Tsz Wo Nicholas Sze commented on RATIS-364:
---

[~msingh], thanks for working on this.  The approach looks good.  Some minor 
comments:

- Rename getConfiguration to readRaftConfiguration, and setRaftConfiguration to 
writeRaftConfiguration.
- We should log a warning when there is an exception in these two methods.
- Import RaftProtos.LogEntryProto and then use LogEntryProto in the code.  It 
looks shorter.
- Remove raftConf from BaseStateMachine.

> Raft should persist configuration entries to meta file
> --
>
> Key: RATIS-364
> URL: https://issues.apache.org/jira/browse/RATIS-364
> Project: Ratis
>  Issue Type: Bug
>  Components: server
>Reporter: Mukul Kumar Singh
>Assignee: Mukul Kumar Singh
>Priority: Major
> Attachments: RATIS-364.001.patch
>
>
> The responsibility of storing the raft configuration currently is state 
> Machine's responsibility.
> This jira proposes to add a mechanism for Raft Server to persist the 
> configuration to its own metafile



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (RATIS-364) Raft should persist configuration entries to meta file

2018-10-22 Thread Hadoop QA (JIRA) 


[ 
https://issues.apache.org/jira/browse/RATIS-364?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16659090#comment-16659090
 ] 

Hadoop QA commented on RATIS-364:
-

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  4m 
10s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  0m  
1s{color} | {color:blue} Findbugs executables are not available. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red}  0m  
0s{color} | {color:red} The patch doesn't appear to include any new or modified 
tests. Please justify why no new tests are needed for this patch. Also please 
list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  2m 
49s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
43s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
31s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
38s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  0m 
49s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
43s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  0m 
43s{color} | {color:green} the patch passed {color} |
| {color:orange}-0{color} | {color:orange} checkstyle {color} | {color:orange}  
0m 25s{color} | {color:orange} root: The patch generated 15 new + 737 unchanged 
- 7 fixed = 752 total (was 744) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
29s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 28m 40s{color} 
| {color:red} root in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 
17s{color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 40m 23s{color} | 
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | ratis.TestRaftServerLeaderElectionTimeout |
|   | ratis.server.simulation.TestRaftStateMachineExceptionWithSimulatedRpc |
|   | ratis.server.simulation.TestRaftExceptionWithSimulation |
|   | ratis.server.simulation.TestRaftReconfigurationWithSimulatedRpc |
|   | ratis.TestRaftServerSlownessDetection |
|   | ratis.server.simulation.TestRaftSnapshotWithSimulatedRpc |
|   | ratis.server.simulation.TestLeaderElectionWithSimulatedRpc |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/ratis:date2018-10-22 
|
| JIRA Issue | RATIS-364 |
| JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/12945032/RATIS-364.001.patch |
| Optional Tests |  asflicense  javac  javadoc  unit  findbugs  checkstyle  
compile  |
| uname | Linux ff6ef717d1a1 4.4.0-133-generic #159-Ubuntu SMP Fri Aug 10 
07:31:43 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | 
/home/jenkins/jenkins-slave/workspace/PreCommit-RATIS-Build/yetus-personality.sh
 |
| git revision | master / 8ef7b48 |
| Default Java | 1.8.0_181 |
| checkstyle | 
https://builds.apache.org/job/PreCommit-RATIS-Build/436/artifact/out/diff-checkstyle-root.txt
 |
| unit | 
https://builds.apache.org/job/PreCommit-RATIS-Build/436/artifact/out/patch-unit-root.txt
 |
|  Test Results | 
https://builds.apache.org/job/PreCommit-RATIS-Build/436/testReport/ |
| modules | C: ratis-server U: ratis-server |
| Console output | 
https://builds.apache.org/job/PreCommit-RATIS-Build/436/console |
| Powered by | Apache Yetus 0.5.0   http://yetus.apache.org |


This message was automatically generated.



> Raft should persist configuration entries to meta file
> --
>
> Key: RATIS-364
> URL: https://issues.apache.org/jira/brows