[jira] [Commented] (SENTRY-2458) Separate Web UI and service from service-server to prevent circular dependencies
[ https://issues.apache.org/jira/browse/SENTRY-2458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16703882#comment-16703882 ] Hadoop QA commented on SENTRY-2458: --- Here are the results of testing the latest attachment https://issues.apache.org/jira/secure/attachment/12950064/SENTRY-2458.007.patch against master. {color:green}Overall:{color} +1 all checks pass {color:green}SUCCESS:{color} all tests passed Console output: https://builds.apache.org/job/PreCommit-SENTRY-Build/4261/console This message is automatically generated. > Separate Web UI and service from service-server to prevent circular > dependencies > > > Key: SENTRY-2458 > URL: https://issues.apache.org/jira/browse/SENTRY-2458 > Project: Sentry > Issue Type: Improvement > Components: Service >Affects Versions: 2.0.1 >Reporter: Brian Towles >Assignee: Brian Towles >Priority: Major > Fix For: 2.2.0 > > Attachments: SENTRY-2458.001.patch, SENTRY-2458.002.patch, > SENTRY-2458.003.patch, SENTRY-2458.004.patch, SENTRY-2458.005.patch, > SENTRY-2458.006.patch, SENTRY-2458.007.patch > > > In order to additional modules to be added to Sentry there needs to be a > separation of some of the features used by service-server into other modules. > This will allow the web server to be pulled out from the base server and > allow for additional modules to be able to add web services and functionality > to the web interface without depending up the whole server module. > It will use the SPI to dynamically include servlets and content from other > modules. > It creates a sentry-service-providers to allow for Server and sub modules SPI > providers to be defined externally and not depended on directly. > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SENTRY-2458) Separate Web UI and service from service-server to prevent circular dependencies
[ https://issues.apache.org/jira/browse/SENTRY-2458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16703725#comment-16703725 ] Brian Towles commented on SENTRY-2458: -- [~spena] Thanks. Fix is in. Was not failing locally at all on that. Cause its really a binary. Not sure why its being picked up as text with the Apache Jenkins. > Separate Web UI and service from service-server to prevent circular > dependencies > > > Key: SENTRY-2458 > URL: https://issues.apache.org/jira/browse/SENTRY-2458 > Project: Sentry > Issue Type: Improvement > Components: Service >Affects Versions: 2.0.1 >Reporter: Brian Towles >Assignee: Brian Towles >Priority: Major > Fix For: 2.2.0 > > Attachments: SENTRY-2458.001.patch, SENTRY-2458.002.patch, > SENTRY-2458.003.patch, SENTRY-2458.004.patch, SENTRY-2458.005.patch, > SENTRY-2458.006.patch, SENTRY-2458.007.patch > > > In order to additional modules to be added to Sentry there needs to be a > separation of some of the features used by service-server into other modules. > This will allow the web server to be pulled out from the base server and > allow for additional modules to be able to add web services and functionality > to the web interface without depending up the whole server module. > It will use the SPI to dynamically include servlets and content from other > modules. > It creates a sentry-service-providers to allow for Server and sub modules SPI > providers to be defined externally and not depended on directly. > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SENTRY-2458) Separate Web UI and service from service-server to prevent circular dependencies
[ https://issues.apache.org/jira/browse/SENTRY-2458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16703545#comment-16703545 ] Hadoop QA commented on SENTRY-2458: --- Here are the results of testing the latest attachment https://issues.apache.org/jira/secure/attachment/12949890/SENTRY-2458.006.patch against master. {color:red}Overall:{color} -1 due to an error {color:red}ERROR:{color} failed to build with patch (exit code 1) Console output: https://builds.apache.org/job/PreCommit-SENTRY-Build/4259/console This message is automatically generated. > Separate Web UI and service from service-server to prevent circular > dependencies > > > Key: SENTRY-2458 > URL: https://issues.apache.org/jira/browse/SENTRY-2458 > Project: Sentry > Issue Type: Improvement > Components: Service >Affects Versions: 2.0.1 >Reporter: Brian Towles >Assignee: Brian Towles >Priority: Major > Fix For: 2.2.0 > > Attachments: SENTRY-2458.001.patch, SENTRY-2458.002.patch, > SENTRY-2458.003.patch, SENTRY-2458.004.patch, SENTRY-2458.005.patch, > SENTRY-2458.006.patch > > > In order to additional modules to be added to Sentry there needs to be a > separation of some of the features used by service-server into other modules. > This will allow the web server to be pulled out from the base server and > allow for additional modules to be able to add web services and functionality > to the web interface without depending up the whole server module. > It will use the SPI to dynamically include servlets and content from other > modules. > It creates a sentry-service-providers to allow for Server and sub modules SPI > providers to be defined externally and not depended on directly. > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SENTRY-2458) Separate Web UI and service from service-server to prevent circular dependencies
[ https://issues.apache.org/jira/browse/SENTRY-2458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16703551#comment-16703551 ] Sergio Peña commented on SENTRY-2458: - [~btowles] https://builds.apache.org/job/PreCommit-SENTRY-Build/4259/artifact/sentry-service/sentry-service-web/target/rat.txt > Separate Web UI and service from service-server to prevent circular > dependencies > > > Key: SENTRY-2458 > URL: https://issues.apache.org/jira/browse/SENTRY-2458 > Project: Sentry > Issue Type: Improvement > Components: Service >Affects Versions: 2.0.1 >Reporter: Brian Towles >Assignee: Brian Towles >Priority: Major > Fix For: 2.2.0 > > Attachments: SENTRY-2458.001.patch, SENTRY-2458.002.patch, > SENTRY-2458.003.patch, SENTRY-2458.004.patch, SENTRY-2458.005.patch, > SENTRY-2458.006.patch > > > In order to additional modules to be added to Sentry there needs to be a > separation of some of the features used by service-server into other modules. > This will allow the web server to be pulled out from the base server and > allow for additional modules to be able to add web services and functionality > to the web interface without depending up the whole server module. > It will use the SPI to dynamically include servlets and content from other > modules. > It creates a sentry-service-providers to allow for Server and sub modules SPI > providers to be defined externally and not depended on directly. > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SENTRY-2458) Separate Web UI and service from service-server to prevent circular dependencies
[ https://issues.apache.org/jira/browse/SENTRY-2458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16703543#comment-16703543 ] Sergio Peña commented on SENTRY-2458: - The rat.txt is not available to see. But I just configured Jenkins to archive it and access it to see what's wrong. I re-triggred the job, so wait the job to finish to see the file. > Separate Web UI and service from service-server to prevent circular > dependencies > > > Key: SENTRY-2458 > URL: https://issues.apache.org/jira/browse/SENTRY-2458 > Project: Sentry > Issue Type: Improvement > Components: Service >Affects Versions: 2.0.1 >Reporter: Brian Towles >Assignee: Brian Towles >Priority: Major > Fix For: 2.2.0 > > Attachments: SENTRY-2458.001.patch, SENTRY-2458.002.patch, > SENTRY-2458.003.patch, SENTRY-2458.004.patch, SENTRY-2458.005.patch, > SENTRY-2458.006.patch > > > In order to additional modules to be added to Sentry there needs to be a > separation of some of the features used by service-server into other modules. > This will allow the web server to be pulled out from the base server and > allow for additional modules to be able to add web services and functionality > to the web interface without depending up the whole server module. > It will use the SPI to dynamically include servlets and content from other > modules. > It creates a sentry-service-providers to allow for Server and sub modules SPI > providers to be defined externally and not depended on directly. > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SENTRY-2458) Separate Web UI and service from service-server to prevent circular dependencies
[ https://issues.apache.org/jira/browse/SENTRY-2458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16703411#comment-16703411 ] Brian Towles commented on SENTRY-2458: -- Yes I can . I can run a full verify (which runs the RAT checks) I think this is an issue with the build on jenkins. I cant look into the build workspace to be able to check the RAT report. If [~spena] or someone can look at the above path on the jenkins build we can see whats going on. I added RAT changes in to take into account the SVGs and other web fonts. > Separate Web UI and service from service-server to prevent circular > dependencies > > > Key: SENTRY-2458 > URL: https://issues.apache.org/jira/browse/SENTRY-2458 > Project: Sentry > Issue Type: Improvement > Components: Service >Affects Versions: 2.0.1 >Reporter: Brian Towles >Assignee: Brian Towles >Priority: Major > Fix For: 2.2.0 > > Attachments: SENTRY-2458.001.patch, SENTRY-2458.002.patch, > SENTRY-2458.003.patch, SENTRY-2458.004.patch, SENTRY-2458.005.patch, > SENTRY-2458.006.patch > > > In order to additional modules to be added to Sentry there needs to be a > separation of some of the features used by service-server into other modules. > This will allow the web server to be pulled out from the base server and > allow for additional modules to be able to add web services and functionality > to the web interface without depending up the whole server module. > It will use the SPI to dynamically include servlets and content from other > modules. > It creates a sentry-service-providers to allow for Server and sub modules SPI > providers to be defined externally and not depended on directly. > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SENTRY-2458) Separate Web UI and service from service-server to prevent circular dependencies
[ https://issues.apache.org/jira/browse/SENTRY-2458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16702385#comment-16702385 ] Na Li commented on SENTRY-2458: --- [~btowles] can you apply the patch locally and build successfully? {code} https://builds.apache.org/job/PreCommit-SENTRY-Build/4258/consoleFull 20:22:49 [ERROR] Failed to execute goal org.apache.rat:apache-rat-plugin:0.10:check (header-check) on project sentry-service-web: Too many files with unapproved license: 2 See RAT report in: /home/jenkins/jenkins-slave/workspace/PreCommit-SENTRY-Build/sentry-service/sentry-service-web/target/rat.txt -> [Help 1] 20:22:49 [ERROR] {code} > Separate Web UI and service from service-server to prevent circular > dependencies > > > Key: SENTRY-2458 > URL: https://issues.apache.org/jira/browse/SENTRY-2458 > Project: Sentry > Issue Type: Improvement > Components: Service >Affects Versions: 2.0.1 >Reporter: Brian Towles >Assignee: Brian Towles >Priority: Major > Fix For: 2.2.0 > > Attachments: SENTRY-2458.001.patch, SENTRY-2458.002.patch, > SENTRY-2458.003.patch, SENTRY-2458.004.patch, SENTRY-2458.005.patch, > SENTRY-2458.006.patch > > > In order to additional modules to be added to Sentry there needs to be a > separation of some of the features used by service-server into other modules. > This will allow the web server to be pulled out from the base server and > allow for additional modules to be able to add web services and functionality > to the web interface without depending up the whole server module. > It will use the SPI to dynamically include servlets and content from other > modules. > It creates a sentry-service-providers to allow for Server and sub modules SPI > providers to be defined externally and not depended on directly. > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SENTRY-2458) Separate Web UI and service from service-server to prevent circular dependencies
[ https://issues.apache.org/jira/browse/SENTRY-2458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16702354#comment-16702354 ] Hadoop QA commented on SENTRY-2458: --- Here are the results of testing the latest attachment https://issues.apache.org/jira/secure/attachment/12949890/SENTRY-2458.006.patch against master. {color:red}Overall:{color} -1 due to an error {color:red}ERROR:{color} failed to build with patch (exit code 1) Console output: https://builds.apache.org/job/PreCommit-SENTRY-Build/4258/console This message is automatically generated. > Separate Web UI and service from service-server to prevent circular > dependencies > > > Key: SENTRY-2458 > URL: https://issues.apache.org/jira/browse/SENTRY-2458 > Project: Sentry > Issue Type: Improvement > Components: Service >Affects Versions: 2.0.1 >Reporter: Brian Towles >Assignee: Brian Towles >Priority: Major > Fix For: 2.2.0 > > Attachments: SENTRY-2458.001.patch, SENTRY-2458.002.patch, > SENTRY-2458.003.patch, SENTRY-2458.004.patch, SENTRY-2458.005.patch, > SENTRY-2458.006.patch > > > In order to additional modules to be added to Sentry there needs to be a > separation of some of the features used by service-server into other modules. > This will allow the web server to be pulled out from the base server and > allow for additional modules to be able to add web services and functionality > to the web interface without depending up the whole server module. > It will use the SPI to dynamically include servlets and content from other > modules. > It creates a sentry-service-providers to allow for Server and sub modules SPI > providers to be defined externally and not depended on directly. > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SENTRY-2458) Separate Web UI and service from service-server to prevent circular dependencies
[ https://issues.apache.org/jira/browse/SENTRY-2458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16702117#comment-16702117 ] Na Li commented on SENTRY-2458: --- [~btowles] The patch cannot be applied for unit test. Can you rebase your code change and attach the patch again? > Separate Web UI and service from service-server to prevent circular > dependencies > > > Key: SENTRY-2458 > URL: https://issues.apache.org/jira/browse/SENTRY-2458 > Project: Sentry > Issue Type: Improvement > Components: Service >Affects Versions: 2.0.1 >Reporter: Brian Towles >Assignee: Brian Towles >Priority: Major > Fix For: 2.2.0 > > Attachments: SENTRY-2458.001.patch, SENTRY-2458.002.patch, > SENTRY-2458.003.patch, SENTRY-2458.004.patch, SENTRY-2458.005.patch > > > In order to additional modules to be added to Sentry there needs to be a > separation of some of the features used by service-server into other modules. > This will allow the web server to be pulled out from the base server and > allow for additional modules to be able to add web services and functionality > to the web interface without depending up the whole server module. > It will use the SPI to dynamically include servlets and content from other > modules. > It creates a sentry-service-providers to allow for Server and sub modules SPI > providers to be defined externally and not depended on directly. > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SENTRY-2458) Separate Web UI and service from service-server to prevent circular dependencies
[ https://issues.apache.org/jira/browse/SENTRY-2458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16699891#comment-16699891 ] Hadoop QA commented on SENTRY-2458: --- Here are the results of testing the latest attachment https://issues.apache.org/jira/secure/attachment/12949601/SENTRY-2458.005.patch against master. {color:red}Overall:{color} -1 due to an error {color:red}ERROR:{color} failed to build with patch (exit code 1) Console output: https://builds.apache.org/job/PreCommit-SENTRY-Build/4254/console This message is automatically generated. > Separate Web UI and service from service-server to prevent circular > dependencies > > > Key: SENTRY-2458 > URL: https://issues.apache.org/jira/browse/SENTRY-2458 > Project: Sentry > Issue Type: Improvement > Components: Service >Affects Versions: 2.0.1 >Reporter: Brian Towles >Assignee: Brian Towles >Priority: Major > Fix For: 2.2.0 > > Attachments: SENTRY-2458.001.patch, SENTRY-2458.002.patch, > SENTRY-2458.003.patch, SENTRY-2458.004.patch, SENTRY-2458.005.patch > > > In order to additional modules to be added to Sentry there needs to be a > separation of some of the features used by service-server into other modules. > This will allow the web server to be pulled out from the base server and > allow for additional modules to be able to add web services and functionality > to the web interface without depending up the whole server module. > It will use the SPI to dynamically include servlets and content from other > modules. > It creates a sentry-service-providers to allow for Server and sub modules SPI > providers to be defined externally and not depended on directly. > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SENTRY-2458) Separate Web UI and service from service-server to prevent circular dependencies
[ https://issues.apache.org/jira/browse/SENTRY-2458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16694880#comment-16694880 ] Hadoop QA commented on SENTRY-2458: --- Here are the results of testing the latest attachment https://issues.apache.org/jira/secure/attachment/12949068/SENTRY-2458.004.patch against master. {color:red}Overall:{color} -1 due to an error {color:red}ERROR:{color} failed to build with patch (exit code 1) Console output: https://builds.apache.org/job/PreCommit-SENTRY-Build/4251/console This message is automatically generated. > Separate Web UI and service from service-server to prevent circular > dependencies > > > Key: SENTRY-2458 > URL: https://issues.apache.org/jira/browse/SENTRY-2458 > Project: Sentry > Issue Type: Improvement > Components: Service >Affects Versions: 2.0.1 >Reporter: Brian Towles >Assignee: Brian Towles >Priority: Major > Fix For: 2.2.0 > > Attachments: SENTRY-2458.001.patch, SENTRY-2458.002.patch, > SENTRY-2458.003.patch, SENTRY-2458.004.patch > > > In order to additional modules to be added to Sentry there needs to be a > separation of some of the features used by service-server into other modules. > This will allow the web server to be pulled out from the base server and > allow for additional modules to be able to add web services and functionality > to the web interface without depending up the whole server module. > It will use the SPI to dynamically include servlets and content from other > modules. > It creates a sentry-service-providers to allow for Server and sub modules SPI > providers to be defined externally and not depended on directly. > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SENTRY-2458) Separate Web UI and service from service-server to prevent circular dependencies
[ https://issues.apache.org/jira/browse/SENTRY-2458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16693714#comment-16693714 ] Hadoop QA commented on SENTRY-2458: --- Here are the results of testing the latest attachment https://issues.apache.org/jira/secure/attachment/12948906/SENTRY-2458.004.patch against master. {color:red}Overall:{color} -1 due to an error {color:red}ERROR:{color} failed to build with patch (exit code 1) Console output: https://builds.apache.org/job/PreCommit-SENTRY-Build/4249/console This message is automatically generated. > Separate Web UI and service from service-server to prevent circular > dependencies > > > Key: SENTRY-2458 > URL: https://issues.apache.org/jira/browse/SENTRY-2458 > Project: Sentry > Issue Type: Improvement > Components: Service >Affects Versions: 2.0.1 >Reporter: Brian Towles >Assignee: Brian Towles >Priority: Major > Fix For: 2.2.0 > > Attachments: SENTRY-2458.001.patch, SENTRY-2458.002.patch, > SENTRY-2458.003.patch, SENTRY-2458.004.patch > > > In order to additional modules to be added to Sentry there needs to be a > separation of some of the features used by service-server into other modules. > This will allow the web server to be pulled out from the base server and > allow for additional modules to be able to add web services and functionality > to the web interface without depending up the whole server module. > It will use the SPI to dynamically include servlets and content from other > modules. > It creates a sentry-service-providers to allow for Server and sub modules SPI > providers to be defined externally and not depended on directly. > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SENTRY-2458) Separate Web UI and service from service-server to prevent circular dependencies
[ https://issues.apache.org/jira/browse/SENTRY-2458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16688584#comment-16688584 ] Hadoop QA commented on SENTRY-2458: --- Here are the results of testing the latest attachment https://issues.apache.org/jira/secure/attachment/12948373/SENTRY-2458.003.patch against master. {color:red}Overall:{color} -1 due to an error {color:red}ERROR:{color} failed to build with patch (exit code 1) Console output: https://builds.apache.org/job/PreCommit-SENTRY-Build/4241/console This message is automatically generated. > Separate Web UI and service from service-server to prevent circular > dependencies > > > Key: SENTRY-2458 > URL: https://issues.apache.org/jira/browse/SENTRY-2458 > Project: Sentry > Issue Type: Improvement > Components: Service >Affects Versions: 2.0.1 >Reporter: Brian Towles >Assignee: Brian Towles >Priority: Major > Fix For: 2.2.0 > > Attachments: SENTRY-2458.001.patch, SENTRY-2458.002.patch, > SENTRY-2458.003.patch > > > In order to additional modules to be added to Sentry there needs to be a > separation of some of the features used by service-server into other modules. > This will allow the web server to be pulled out from the base server and > allow for additional modules to be able to add web services and functionality > to the web interface without depending up the whole server module. > It will use the SPI to dynamically include servlets and content from other > modules. > It creates a sentry-service-providers to allow for Server and sub modules SPI > providers to be defined externally and not depended on directly. > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SENTRY-2458) Separate Web UI and service from service-server to prevent circular dependencies
[ https://issues.apache.org/jira/browse/SENTRY-2458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16688568#comment-16688568 ] Hadoop QA commented on SENTRY-2458: --- Here are the results of testing the latest attachment https://issues.apache.org/jira/secure/attachment/12948371/SENTRY-2458.002.patch against master. {color:red}Overall:{color} -1 due to an error {color:red}ERROR:{color} failed to build with patch (exit code 1) Console output: https://builds.apache.org/job/PreCommit-SENTRY-Build/4240/console This message is automatically generated. > Separate Web UI and service from service-server to prevent circular > dependencies > > > Key: SENTRY-2458 > URL: https://issues.apache.org/jira/browse/SENTRY-2458 > Project: Sentry > Issue Type: Improvement > Components: Service >Affects Versions: 2.0.1 >Reporter: Brian Towles >Assignee: Brian Towles >Priority: Major > Fix For: 2.2.0 > > Attachments: SENTRY-2458.001.patch, SENTRY-2458.002.patch > > > In order to additional modules to be added to Sentry there needs to be a > separation of some of the features used by service-server into other modules. > This will allow the web server to be pulled out from the base server and > allow for additional modules to be able to add web services and functionality > to the web interface without depending up the whole server module. > It will use the SPI to dynamically include servlets and content from other > modules. > It creates a sentry-service-providers to allow for Server and sub modules SPI > providers to be defined externally and not depended on directly. > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SENTRY-2458) Separate Web UI and service from service-server to prevent circular dependencies
[ https://issues.apache.org/jira/browse/SENTRY-2458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16688531#comment-16688531 ] Hadoop QA commented on SENTRY-2458: --- Here are the results of testing the latest attachment https://issues.apache.org/jira/secure/attachment/12948367/SENTRY-2458.001.patch against master. {color:red}Overall:{color} -1 due to an error {color:red}ERROR:{color} failed to build with patch (exit code 1) Console output: https://builds.apache.org/job/PreCommit-SENTRY-Build/4239/console This message is automatically generated. > Separate Web UI and service from service-server to prevent circular > dependencies > > > Key: SENTRY-2458 > URL: https://issues.apache.org/jira/browse/SENTRY-2458 > Project: Sentry > Issue Type: Improvement > Components: Service >Affects Versions: 2.0.1 >Reporter: Brian Towles >Assignee: Brian Towles >Priority: Major > Fix For: 2.2.0 > > Attachments: SENTRY-2458.001.patch > > > In order to additional modules to be added to Sentry there needs to be a > separation of some of the features used by service-server into other modules. > This will allow the web server to be pulled out from the base server and > allow for additional modules to be able to add web services and functionality > to the web interface without depending up the whole server module. > It will use the SPI to dynamically include servlets and content from other > modules. > It creates a sentry-service-providers to allow for Server and sub modules SPI > providers to be defined externally and not depended on directly. > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SENTRY-2458) Separate Web UI and service from service-server to prevent circular dependencies
[ https://issues.apache.org/jira/browse/SENTRY-2458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16688376#comment-16688376 ] Hadoop QA commented on SENTRY-2458: --- Here are the results of testing the latest attachment https://issues.apache.org/jira/secure/attachment/12948348/SENTRY-2458.001.patch against master. {color:red}Overall:{color} -1 due to an error {color:red}ERROR:{color} failed to apply patch (exit code 1): fatal: git apply: bad git-diff - inconsistent old filename on line 1409 error: cannot apply binary patch to 'sentry-service/sentry-service-web/src/main/webapp/static/bootstrap/fonts/glyphicons-halflings-regular.eot' without full index line Falling back to three-way merge... error: cannot apply binary patch to 'sentry-service/sentry-service-web/src/main/webapp/static/bootstrap/fonts/glyphicons-halflings-regular.eot' without full index line error: sentry-service/sentry-service-web/src/main/webapp/static/bootstrap/fonts/glyphicons-halflings-regular.eot: patch does not apply error: cannot apply binary patch to 'sentry-service/sentry-service-web/src/main/webapp/static/bootstrap/fonts/glyphicons-halflings-regular.ttf' without full index line Falling back to three-way merge... error: cannot apply binary patch to 'sentry-service/sentry-service-web/src/main/webapp/static/bootstrap/fonts/glyphicons-halflings-regular.ttf' without full index line error: sentry-service/sentry-service-web/src/main/webapp/static/bootstrap/fonts/glyphicons-halflings-regular.ttf: patch does not apply error: cannot apply binary patch to 'sentry-service/sentry-service-web/src/main/webapp/static/bootstrap/fonts/glyphicons-halflings-regular.woff' without full index line Falling back to three-way merge... error: cannot apply binary patch to 'sentry-service/sentry-service-web/src/main/webapp/static/bootstrap/fonts/glyphicons-halflings-regular.woff' without full index line error: sentry-service/sentry-service-web/src/main/webapp/static/bootstrap/fonts/glyphicons-halflings-regular.woff: patch does not apply error: cannot apply binary patch to 'sentry-service/sentry-service-web/src/main/webapp/static/bootstrap/fonts/glyphicons-halflings-regular.woff2' without full index line Falling back to three-way merge... error: cannot apply binary patch to 'sentry-service/sentry-service-web/src/main/webapp/static/bootstrap/fonts/glyphicons-halflings-regular.woff2' without full index line error: sentry-service/sentry-service-web/src/main/webapp/static/bootstrap/fonts/glyphicons-halflings-regular.woff2: patch does not apply error: cannot apply binary patch to 'sentry-service/sentry-service-web/src/main/webapp/static/materialdesign/fonts/materialdesignicons-webfont.eot' without full index line Falling back to three-way merge... error: cannot apply binary patch to 'sentry-service/sentry-service-web/src/main/webapp/static/materialdesign/fonts/materialdesignicons-webfont.eot' without full index line error: sentry-service/sentry-service-web/src/main/webapp/static/materialdesign/fonts/materialdesignicons-webfont.eot: patch does not apply error: cannot apply binary patch to 'sentry-service/sentry-service-web/src/main/webapp/static/materialdesign/fonts/materialdesignicons-webfont.ttf' without full index line Falling back to three-way merge... error: cannot apply binary patch to 'sentry-service/sentry-service-web/src/main/webapp/static/materialdesign/fonts/materialdesignicons-webfont.ttf' without full index line error: sentry-service/sentry-service-web/src/main/webapp/static/materialdesign/fonts/materialdesignicons-webfont.ttf: patch does not apply error: cannot apply binary patch to 'sentry-service/sentry-service-web/src/main/webapp/static/materialdesign/fonts/materialdesignicons-webfont.woff' without full index line Falling back to three-way merge... error: cannot apply binary patch to 'sentry-service/sentry-service-web/src/main/webapp/static/materialdesign/fonts/materialdesignicons-webfont.woff' without full index line error: sentry-service/sentry-service-web/src/main/webapp/static/materialdesign/fonts/materialdesignicons-webfont.woff: patch does not apply error: cannot apply binary patch to 'sentry-service/sentry-service-web/src/main/webapp/static/materialdesign/fonts/materialdesignicons-webfont.woff2' without full index line Falling back to three-way merge... error: cannot apply binary patch to 'sentry-service/sentry-service-web/src/main/webapp/static/materialdesign/fonts/materialdesignicons-webfont.woff2' without full index line error: sentry-service/sentry-service-web/src/main/webapp/static/materialdesign/fonts/materialdesignicons-webfont.woff2: patch does not apply error: patch failed: pom.xml:41 Falling back to three-way merge... Applied patch to 'pom.xml' with conflicts. error: src/license/THIRD-PARTY.properties: does not exist in index error: src/main/assembly/bin.xml: does not exist in index error: sentry-provider-db/pom.xml:
[jira] [Commented] (SENTRY-2458) Separate Web UI and service from service-server to prevent circular dependencies
[ https://issues.apache.org/jira/browse/SENTRY-2458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16688324#comment-16688324 ] Hadoop QA commented on SENTRY-2458: --- Here are the results of testing the latest attachment https://issues.apache.org/jira/secure/attachment/12948342/SENTRY-2458.001.patch against master. {color:red}Overall:{color} -1 due to an error {color:red}ERROR:{color} failed to apply patch (exit code 1): fatal: git diff header lacks filename information when removing 0 leading pathname components (line 17867) fatal: git diff header lacks filename information when removing 1 leading pathname component (line 17867) fatal: unable to find filename in patch at line 6 The patch does not appear to apply with p0, p1, or p2 Console output: https://builds.apache.org/job/PreCommit-SENTRY-Build/4237/console This message is automatically generated. > Separate Web UI and service from service-server to prevent circular > dependencies > > > Key: SENTRY-2458 > URL: https://issues.apache.org/jira/browse/SENTRY-2458 > Project: Sentry > Issue Type: Improvement > Components: Service >Affects Versions: 2.0.1 >Reporter: Brian Towles >Assignee: Brian Towles >Priority: Major > Fix For: 2.2.0 > > Attachments: SENTRY-2458.001.patch > > > In order to additional modules to be added to Sentry there needs to be a > separation of some of the features used by service-server into other modules. > This will allow the web server to be pulled out from the base server and > allow for additional modules to be able to add web services and functionality > to the web interface without depending up the whole server module. > It will use the SPI to dynamically include servlets and content from other > modules. > It creates a sentry-service-providers to allow for Server and sub modules SPI > providers to be defined externally and not depended on directly. > -- This message was sent by Atlassian JIRA (v7.6.3#76005)