[jira] [Resolved] (SCB-517) service center starter for spring boot/cloud improvement
[ https://issues.apache.org/jira/browse/SCB-517?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] liubao resolved SCB-517. Resolution: Fixed Fix Version/s: java-chassis-1.0.0-m2 > service center starter for spring boot/cloud improvement > > > Key: SCB-517 > URL: https://issues.apache.org/jira/browse/SCB-517 > Project: Apache ServiceComb > Issue Type: Improvement >Reporter: liubao >Assignee: liubao >Priority: Major > Fix For: java-chassis-1.0.0-m2 > > > Now, when enabled spring-boot-starter-discovery, we should add > @EnableAutoConfiguration > @ImportResource(locations = "classpath*:META-INF/spring/*.bean.xml") > to user class. But we can simplify it to write no code. On the other hand, if > user use this two code, it will work fine. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Resolved] (SCB-503) When using WeighedResponseTimeRule, there are some initialize and stateless access problems
[ https://issues.apache.org/jira/browse/SCB-503?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] liubao resolved SCB-503. Resolution: Fixed Fix Version/s: java-chassis-1.0.0-m2 > When using WeighedResponseTimeRule, there are some initialize and stateless > access problems > --- > > Key: SCB-503 > URL: https://issues.apache.org/jira/browse/SCB-503 > Project: Apache ServiceComb > Issue Type: Bug >Reporter: liubao >Assignee: liubao >Priority: Major > Fix For: java-chassis-1.0.0-m2 > > > 1. When creating WeighedResponseTimeRule, it will call loadbalance get all > service lists. And when running, it also starts a deamon to maintain states > and also call loadbalance get all service lists. So any state access to > 'invocation' will cause problem. > Any filter rules will avoid to use invocation for stateful filters. > > 2. when change WeighedResponseTimeRule to RoundRobin, it's deamon task is not > destroyed and may cause resource leak if change laodbalance rule from to this > frequently. > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Resolved] (SCB-516) AccessLog of EdgeService does not print traceId
[ https://issues.apache.org/jira/browse/SCB-516?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] YaoHaishi resolved SCB-516. --- Resolution: Fixed Fix Version/s: java-chassis-1.0.0-m2 > AccessLog of EdgeService does not print traceId > --- > > Key: SCB-516 > URL: https://issues.apache.org/jira/browse/SCB-516 > Project: Apache ServiceComb > Issue Type: Bug > Components: Java-Chassis >Reporter: YaoHaishi >Assignee: YaoHaishi >Priority: Major > Fix For: java-chassis-1.0.0-m2 > > Attachments: ComplieWarning.PNG > > > The access log of EdgeService always prints "-" as traceId. > It's found out that in TraceIdItem, traceId cannot be gotten, because the > dispatcher of EdgeService does not always set invocation into RoutingContext > like the VertxRestDispatcher.onRequest() does. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (SCB-523) maven-remote-resource-plugin execute very slow
[ https://issues.apache.org/jira/browse/SCB-523?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] liubao updated SCB-523: --- Fix Version/s: java-chassis-1.0.0-m2 > maven-remote-resource-plugin execute very slow > -- > > Key: SCB-523 > URL: https://issues.apache.org/jira/browse/SCB-523 > Project: Apache ServiceComb > Issue Type: Improvement >Reporter: liubao >Assignee: liubao >Priority: Major > Fix For: java-chassis-1.0.0-m2 > > > maven-remote-resource-plugin execute very slow and we only need this in > release stage. In order to make development easy, need to move it to release > stage. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-482) Http2 support for java chassis
[ https://issues.apache.org/jira/browse/SCB-482?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16456012#comment-16456012 ] ASF GitHub Bot commented on SCB-482: wujimin commented on issue #648: [SCB-482] Http2 support for java-chassis URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/648#issuecomment-384881908 there are conflicting files, please resolve it. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Http2 support for java chassis > -- > > Key: SCB-482 > URL: https://issues.apache.org/jira/browse/SCB-482 > Project: Apache ServiceComb > Issue Type: New Feature > Components: Java-Chassis >Reporter: Rajadeepan >Priority: Minor > > Http2 support for java chassis. > Only Application for Rest Vertex and not applicable for servlet and highway. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Resolved] (SCB-523) maven-remote-resource-plugin execute very slow
[ https://issues.apache.org/jira/browse/SCB-523?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] liubao resolved SCB-523. Resolution: Fixed > maven-remote-resource-plugin execute very slow > -- > > Key: SCB-523 > URL: https://issues.apache.org/jira/browse/SCB-523 > Project: Apache ServiceComb > Issue Type: Improvement >Reporter: liubao >Assignee: liubao >Priority: Major > > maven-remote-resource-plugin execute very slow and we only need this in > release stage. In order to make development easy, need to move it to release > stage. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-516) AccessLog of EdgeService does not print traceId
[ https://issues.apache.org/jira/browse/SCB-516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16456011#comment-16456011 ] YaoHaishi commented on SCB-516: --- Commits have been merged. https://github.com/apache/incubator-servicecomb-java-chassis/pull/671 > AccessLog of EdgeService does not print traceId > --- > > Key: SCB-516 > URL: https://issues.apache.org/jira/browse/SCB-516 > Project: Apache ServiceComb > Issue Type: Bug > Components: Java-Chassis >Reporter: YaoHaishi >Assignee: YaoHaishi >Priority: Major > Attachments: ComplieWarning.PNG > > > The access log of EdgeService always prints "-" as traceId. > It's found out that in TraceIdItem, traceId cannot be gotten, because the > dispatcher of EdgeService does not always set invocation into RoutingContext > like the VertxRestDispatcher.onRequest() does. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-515) change all configuration from 'cse.xxx' to 'servicecomb.xxx'
[ https://issues.apache.org/jira/browse/SCB-515?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16456008#comment-16456008 ] ASF GitHub Bot commented on SCB-515: wujimin closed pull request #669: [SCB-515] change all config of 'cse.xxx' to 'servicecomb.xxx' URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/669 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/archetypes/business-service-jaxrs/src/main/resources/microservice.yaml b/archetypes/business-service-jaxrs/src/main/resources/microservice.yaml index ddf5f398d..90de8072f 100644 --- a/archetypes/business-service-jaxrs/src/main/resources/microservice.yaml +++ b/archetypes/business-service-jaxrs/src/main/resources/microservice.yaml @@ -30,7 +30,7 @@ service_description: name: business-service #Indicates a service version version: 1.0.0 -cse: +servicecomb: service: #Specifies the service center IP address. registry: diff --git a/common/common-rest/src/test/resources/microservice.yaml b/common/common-rest/src/test/resources/microservice.yaml index 4de481325..b47bdef73 100644 --- a/common/common-rest/src/test/resources/microservice.yaml +++ b/common/common-rest/src/test/resources/microservice.yaml @@ -19,7 +19,7 @@ APPLICATION_ID: test service_description: name: test version: 0.0.1 -cse: +servicecomb: service: registry: address: http://127.0.0.1:30100 diff --git a/core/src/test/resources/microservice.yaml b/core/src/test/resources/microservice.yaml index 698b20f36..a49e8e399 100644 --- a/core/src/test/resources/microservice.yaml +++ b/core/src/test/resources/microservice.yaml @@ -19,7 +19,7 @@ APPLICATION_ID: app service_description: name: perfClient version: 0.0.1 -cse: +servicecomb: service: registry: address: http://127.0.0.1:30100 diff --git a/core/src/test/resources/test/test/microservice.yaml b/core/src/test/resources/test/test/microservice.yaml index 9b6c0fe84..a82dcd3f0 100644 --- a/core/src/test/resources/test/test/microservice.yaml +++ b/core/src/test/resources/test/test/microservice.yaml @@ -19,7 +19,7 @@ service_description: name: default version: 0.0.1 propertyExtentedClass: org.apache.servicecomb.serviceregistry.MicroServicePropertyExtendedStub -cse: +servicecomb: service: registry: address: http://127.0.0.1:30100 diff --git a/demo/demo-crossapp/crossapp-client/src/main/resources/microservice.yaml b/demo/demo-crossapp/crossapp-client/src/main/resources/microservice.yaml index 764149d0c..4590f8f87 100644 --- a/demo/demo-crossapp/crossapp-client/src/main/resources/microservice.yaml +++ b/demo/demo-crossapp/crossapp-client/src/main/resources/microservice.yaml @@ -19,7 +19,7 @@ APPLICATION_ID: appClient service_description: name: appClientService version: 0.0.1 -cse: +servicecomb: service: registry: address: http://127.0.0.1:30100 diff --git a/demo/demo-crossapp/crossapp-server/src/main/resources/microservice.yaml b/demo/demo-crossapp/crossapp-server/src/main/resources/microservice.yaml index d1170ebae..f58cba5e0 100644 --- a/demo/demo-crossapp/crossapp-server/src/main/resources/microservice.yaml +++ b/demo/demo-crossapp/crossapp-server/src/main/resources/microservice.yaml @@ -25,7 +25,7 @@ instance_description: properties: tag0: value0 -cse: +servicecomb: service: registry: address: http://127.0.0.1:30100 diff --git a/demo/demo-edge/authentication/src/main/resources/microservice.yaml b/demo/demo-edge/authentication/src/main/resources/microservice.yaml index 8e98001b9..d532582be 100644 --- a/demo/demo-edge/authentication/src/main/resources/microservice.yaml +++ b/demo/demo-edge/authentication/src/main/resources/microservice.yaml @@ -19,7 +19,7 @@ APPLICATION_ID: edge service_description: name: auth version: 0.0.1 -cse: +servicecomb: service: registry: address: http://127.0.0.1:30100 diff --git a/demo/demo-edge/business-1-1-0/src/main/resources/microservice.yaml b/demo/demo-edge/business-1-1-0/src/main/resources/microservice.yaml index 109e27ac7..11206233c 100644 --- a/demo/demo-edge/business-1-1-0/src/main/resources/microservice.yaml +++ b/demo/demo-edge/business-1-1-0/src/main/resources/microservice.yaml @@ -19,7 +19,7 @@ APPLICATION_ID: edge service_description: name: business version: 1.1.0 -cse: +servicecomb: service: registry: address: http://127.0.0.1:30100 diff --git a/demo/demo-edge/business-1.0.0/src/main/resources/microservice.yaml b/demo/demo-edge/business-1.0.0/src/main/resources/microservice.yaml index 2046f7489..296bf393a 100644 --- a/demo/demo-edge/business-1.0.0/src/main/resources/microservice.yaml +++ b
[jira] [Commented] (SCB-440) Provide Maven Archetype of business-service-pojo
[
https://issues.apache.org/jira/browse/SCB-440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16456001#comment-16456001
]
ASF GitHub Bot commented on SCB-440:
wujimin commented on a change in pull request #674: [SCB-440] Provide Maven
Archetype of business-service-pojo
URL:
https://github.com/apache/incubator-servicecomb-java-chassis/pull/674#discussion_r184604465
##
File path:
archetypes/business-service-pojo/src/main/java/org/apache/servicecomb/archetypes/HelloEndpoint.java
##
@@ -0,0 +1,28 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.servicecomb.archetypes;
+
+import org.apache.servicecomb.provider.pojo.RpcSchema;
+
+@RpcSchema(schemaId = "helloEndpoint")
+public class HelloEndpoint implements Hello {
Review comment:
names "Endpoint" is not so good.
conflict with transport endpoint.
Schema is important in ServiceComb, do not bypass it.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Provide Maven Archetype of business-service-pojo
>
>
> Key: SCB-440
> URL: https://issues.apache.org/jira/browse/SCB-440
> Project: Apache ServiceComb
> Issue Type: Sub-task
> Components: Java-Chassis
>Affects Versions: java-chassis-1.0.0-m2
>Reporter: yangyongzheng
>Assignee: yangyongzheng
>Priority: Major
> Fix For: java-chassis-1.0.0-m2
>
>
> This Archetype for create a common microservice using pojo provider.
> It's contains :
> 1.All necessary dependencies in pom.
> 2.An HelloEndpoint provider using pojo mode.
> 3.Default microservice.yaml.
> 4.Provider bean xml Included spring component-scan.
> 5.Consumer in test and can direct run with local registry.
> 6.Readme file teach user what can be done further.
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (SCB-524) The images in the blog 'open-design' is not the original version
[ https://issues.apache.org/jira/browse/SCB-524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16455994#comment-16455994 ] ASF GitHub Bot commented on SCB-524: zenlinTechnofreak opened a new pull request #75: [SCB-524] Replace images in the blog 'open design' to originals URL: https://github.com/apache/incubator-servicecomb-website/pull/75 [SCB-524] Replace images in the blog 'open design' to originals. Signed-off-by: linzhinan This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > The images in the blog 'open-design' is not the original version > > > Key: SCB-524 > URL: https://issues.apache.org/jira/browse/SCB-524 > Project: Apache ServiceComb > Issue Type: Bug > Components: website >Reporter: Zhinan Lin >Assignee: Zhinan Lin >Priority: Minor > > The images in the blog 'open-design' is not the original version, need to be > replaced. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-518) ServiceCenter ip address need to config default port
[
https://issues.apache.org/jira/browse/SCB-518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16455987#comment-16455987
]
ASF GitHub Bot commented on SCB-518:
wujimin commented on a change in pull request #676: [SCB-518] ServiceCenter ip
address need to config default port
URL:
https://github.com/apache/incubator-servicecomb-java-chassis/pull/676#discussion_r184602463
##
File path:
service-registry/src/test/java/org/apache/servicecomb/serviceregistry/config/TestServiceRegistryConfig.java
##
@@ -30,6 +34,7 @@
@BeforeClass
public static void initClass() {
ArchaiusUtils.resetConfig();
+ConfigUtil.installDynamicConfig();
Review comment:
so heavy, why not just invoke ArchaiusUtils.setProperty inside test case.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> ServiceCenter ip address need to config default port
>
>
> Key: SCB-518
> URL: https://issues.apache.org/jira/browse/SCB-518
> Project: Apache ServiceComb
> Issue Type: Improvement
> Components: Java-Chassis
>Reporter: WeiChao
>Assignee: WeiChao
>Priority: Major
>
> for http/https, the default ports are 80 and 443. if port is not configured,
> the default port needs to be used. this simplifies the configuration.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (SCB-514) update pom and code, so that we can treat warnings as errors
[
https://issues.apache.org/jira/browse/SCB-514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16455983#comment-16455983
]
ASF GitHub Bot commented on SCB-514:
liubao68 closed pull request #675: [SCB-514] Warning as error
URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/675
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/common/common-rest/src/main/java/org/apache/servicecomb/common/rest/codec/RestObjectMapper.java
b/common/common-rest/src/main/java/org/apache/servicecomb/common/rest/codec/RestObjectMapper.java
index fb76c901d..6dc1bbb01 100644
---
a/common/common-rest/src/main/java/org/apache/servicecomb/common/rest/codec/RestObjectMapper.java
+++
b/common/common-rest/src/main/java/org/apache/servicecomb/common/rest/codec/RestObjectMapper.java
@@ -26,10 +26,7 @@
import com.fasterxml.jackson.databind.ObjectMapper;
import com.fasterxml.jackson.databind.SerializationFeature;
import com.fasterxml.jackson.databind.type.TypeFactory;
-import com.fasterxml.jackson.databind.util.ISO8601DateFormat;
-import com.fasterxml.jackson.databind.util.ISO8601Utils;
-@SuppressWarnings("deprecation")
public final class RestObjectMapper extends ObjectMapper {
public static final RestObjectMapper INSTANCE = new RestObjectMapper();
@@ -37,15 +34,16 @@
private static final JavaType STRING_JAVA_TYPE =
TypeFactory.defaultInstance().constructType(String.class);
+ @SuppressWarnings("deprecation")
private RestObjectMapper() {
// swagger中要求date使用ISO8601格式传递，这里与之做了功能绑定，这在cse中是没有问题的
-setDateFormat(new ISO8601DateFormat() {
+setDateFormat(new com.fasterxml.jackson.databind.util.ISO8601DateFormat() {
private static final long serialVersionUID = 7798938088541203312L;
// to support millis
@Override
public StringBuffer format(Date date, StringBuffer toAppendTo,
FieldPosition fieldPosition) {
-String value = ISO8601Utils.format(date, true);
+String value =
com.fasterxml.jackson.databind.util.ISO8601Utils.format(date, true);
toAppendTo.append(value);
return toAppendTo;
}
diff --git
a/common/common-rest/src/test/java/org/apache/servicecomb/common/rest/codec/param/TestCookieProcessor.java
b/common/common-rest/src/test/java/org/apache/servicecomb/common/rest/codec/param/TestCookieProcessor.java
index 16a263675..98fa39c09 100644
---
a/common/common-rest/src/test/java/org/apache/servicecomb/common/rest/codec/param/TestCookieProcessor.java
+++
b/common/common-rest/src/test/java/org/apache/servicecomb/common/rest/codec/param/TestCookieProcessor.java
@@ -30,14 +30,12 @@
import org.junit.Test;
import com.fasterxml.jackson.databind.type.TypeFactory;
-import com.fasterxml.jackson.databind.util.ISO8601Utils;
import mockit.Expectations;
import mockit.Mock;
import mockit.MockUp;
import mockit.Mocked;
-@SuppressWarnings("deprecation")
public class TestCookieProcessor {
@Mocked
HttpServletRequest request;
@@ -103,10 +101,11 @@ public void testGetValueCookiesFound() throws Exception {
Assert.assertEquals("c1v", value);
}
+ @SuppressWarnings("deprecation")
@Test
public void testGetValueCookiesDate() throws Exception {
Date date = new Date();
-String strDate = ISO8601Utils.format(date);
+String strDate =
com.fasterxml.jackson.databind.util.ISO8601Utils.format(date);
Cookie[] cookies = new Cookie[] {new Cookie("c1", strDate)};
new Expectations() {
{
@@ -117,7 +116,7 @@ public void testGetValueCookiesDate() throws Exception {
CookieProcessor processor = createProcessor("c1", Date.class);
Object value = processor.getValue(request);
-Assert.assertEquals(strDate, ISO8601Utils.format((Date) value));
+Assert.assertEquals(strDate,
com.fasterxml.jackson.databind.util.ISO8601Utils.format((Date) value));
}
@Test
@@ -132,7 +131,8 @@ public void testSetValue() throws Exception {
@Test
public void testSetValueDate() throws Exception {
Date date = new Date();
-String strDate = ISO8601Utils.format(date, true);
+@SuppressWarnings("deprecation")
+String strDate =
com.fasterxml.jackson.databind.util.ISO8601Utils.format(date, true);
createClientRequest();
diff --git
a/common/common-rest/src/test/java/org/apache/servicecomb/common/rest/codec/param/TestFormProcessor.java
b/common/common-rest/src/test/java/org/apache/servicecomb/common/rest/codec/param/TestFormProcessor.java
index e204d91ed..efded340e 100644
---
a/common/common-rest/src/test/java/org/apache/servicecomb/common/rest/codec/param/TestFormProcessor.java
+++
b/common/common-rest/src/test/java/org/apache/servicecomb/common/rest/codec/
[jira] [Commented] (SCB-521) change the priority of ServiceComb config and SpringBoot config
[
https://issues.apache.org/jira/browse/SCB-521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16455809#comment-16455809
]
ASF GitHub Bot commented on SCB-521:
liubao68 closed pull request #679: [SCB-521] Config of Spring Boot should takes
higher priority than microservice.yaml
URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/679
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/foundations/foundation-config/src/main/java/org/apache/servicecomb/config/ConfigUtil.java
b/foundations/foundation-config/src/main/java/org/apache/servicecomb/config/ConfigUtil.java
index a5ff2e61c..bb3b41322 100644
---
a/foundations/foundation-config/src/main/java/org/apache/servicecomb/config/ConfigUtil.java
+++
b/foundations/foundation-config/src/main/java/org/apache/servicecomb/config/ConfigUtil.java
@@ -130,17 +130,17 @@ public static ConcurrentCompositeConfiguration
createLocalConfig(List !mapEntry.getValue().isEmpty())
.forEachOrdered(configMapEntry ->
duplicateServiceCombConfigToCse(config,
new ConcurrentMapConfiguration(configMapEntry.getValue()),
configMapEntry.getKey()));
+duplicateServiceCombConfigToCse(config,
+new DynamicConfiguration(
+new MicroserviceConfigurationSource(configModelList), new
NeverStartPollingScheduler()),
+"configFromYamlFile");
return config;
}
diff --git
a/foundations/foundation-config/src/test/java/org/apache/servicecomb/config/TestConfigUtil.java
b/foundations/foundation-config/src/test/java/org/apache/servicecomb/config/TestConfigUtil.java
index b10142de7..cd04d4e70 100644
---
a/foundations/foundation-config/src/test/java/org/apache/servicecomb/config/TestConfigUtil.java
+++
b/foundations/foundation-config/src/test/java/org/apache/servicecomb/config/TestConfigUtil.java
@@ -326,14 +326,15 @@ public void testCreateLocalConfigWithExtraConfig() {
String extraConfigValue = "value";
String overriddenConfigKey = "servicecomb.cse.servicecomb.file";
extraConfig.put(extraConfigKey, extraConfigValue);
-extraConfig.put(overriddenConfigKey, "should_be_overridden");
+final String propertyHigherPriority = "higher_priority";
+extraConfig.put(overriddenConfigKey, propertyHigherPriority);
ConfigUtil.addExtraConfig("testExtraConfig", extraConfig);
ConcurrentCompositeConfiguration localConfiguration =
ConfigUtil.createLocalConfig();
Assert.assertEquals(extraConfigValue,
localConfiguration.getProperty(extraConfigKey));
-Assert.assertEquals("value",
localConfiguration.getString(overriddenConfigKey));
+Assert.assertEquals(propertyHigherPriority,
localConfiguration.getString(overriddenConfigKey));
}
@SuppressWarnings("unchecked")
diff --git a/foundations/foundation-config/src/test/resources/microservice.yaml
b/foundations/foundation-config/src/test/resources/microservice.yaml
index f43982923..a7b123716 100644
--- a/foundations/foundation-config/src/test/resources/microservice.yaml
+++ b/foundations/foundation-config/src/test/resources/microservice.yaml
@@ -64,4 +64,4 @@ service_description:
servicecomb:
cse:
servicecomb:
- file: value
+ file: value # this is a config for
TestConfigUtil.testCreateLocalConfigWithExtraConfig()
diff --git
a/integration-tests/spring-jaxrs-tests/src/test/resources/application.properties
b/integration-tests/spring-jaxrs-tests/src/test/resources/application.properties
index 39d02011b..79e10ad70 100644
---
a/integration-tests/spring-jaxrs-tests/src/test/resources/application.properties
+++
b/integration-tests/spring-jaxrs-tests/src/test/resources/application.properties
@@ -16,5 +16,4 @@
#
property.test0=from_properties
-property.test4=from_properties
property.test5=from_properties
diff --git
a/integration-tests/spring-jaxrs-tests/src/test/resources/microservice.yaml
b/integration-tests/spring-jaxrs-tests/src/test/resources/microservice.yaml
index 49937a23e..16660f63c 100644
--- a/integration-tests/spring-jaxrs-tests/src/test/resources/microservice.yaml
+++ b/integration-tests/spring-jaxrs-tests/src/test/resources/microservice.yaml
@@ -16,5 +16,6 @@
# ---
property:
+ test2: from_microservice_yaml
test4: from_microservice_yaml
test5: from_microservice_yaml
diff --git
a/integration-tests/spring-zuul-tracing-tests/src/test/resources/application.properties
b/integration-tests/spring-zuul-tracing-tests/src/test/resources/application.properties
index 9c2440b2e..171496548 100644
---
a/integration-tests/spring-zuul-tracing-tests/src/test/resources/application.propert
[jira] [Commented] (SCB-523) maven-remote-resource-plugin execute very slow
[ https://issues.apache.org/jira/browse/SCB-523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16455807#comment-16455807 ] ASF GitHub Bot commented on SCB-523: WillemJiang commented on issue #680: [SCB-523]maven-remote-resource-plugin executes very slow URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/680#issuecomment-384873676 The resource plugin is used to generated dependency and license information for the release. It's OK to move it the release profile. @liubao68 Can you elaborate the slow performance reason of it? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > maven-remote-resource-plugin execute very slow > -- > > Key: SCB-523 > URL: https://issues.apache.org/jira/browse/SCB-523 > Project: Apache ServiceComb > Issue Type: Improvement >Reporter: liubao >Assignee: liubao >Priority: Major > > maven-remote-resource-plugin execute very slow and we only need this in > release stage. In order to make development easy, need to move it to release > stage. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (SCB-525) It is better to delete logos of Qcon in the Blog 'distributed-transactions-saga-implementation'
Zhinan Lin created SCB-525: -- Summary: It is better to delete logos of Qcon in the Blog 'distributed-transactions-saga-implementation' Key: SCB-525 URL: https://issues.apache.org/jira/browse/SCB-525 Project: Apache ServiceComb Issue Type: Wish Components: website Reporter: Zhinan Lin Assignee: Zhinan Lin It is better to delete logos of Qcon in the Blog 'distributed-transactions-saga-implementation' -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (SCB-524) The images in the blog 'open-design' is not the original version
Zhinan Lin created SCB-524: -- Summary: The images in the blog 'open-design' is not the original version Key: SCB-524 URL: https://issues.apache.org/jira/browse/SCB-524 Project: Apache ServiceComb Issue Type: Bug Components: website Reporter: Zhinan Lin Assignee: Zhinan Lin The images in the blog 'open-design' is not the original version, need to be replaced. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Resolved] (SCB-519) The Website can not be running up according to the chapter "How to run the site locally" of README.md
[ https://issues.apache.org/jira/browse/SCB-519?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zhinan Lin resolved SCB-519. Resolution: Fixed > The Website can not be running up according to the chapter "How to run the > site locally" of README.md > -- > > Key: SCB-519 > URL: https://issues.apache.org/jira/browse/SCB-519 > Project: Apache ServiceComb > Issue Type: Bug > Components: website >Reporter: Zhinan Lin >Assignee: Zhinan Lin >Priority: Major > > The Website can not running up if using default version of tools according to > the guide of README.md > # Lack of verison of tools > # Should be non-root -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-523) maven-remote-resource-plugin execute very slow
[ https://issues.apache.org/jira/browse/SCB-523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16455743#comment-16455743 ] ASF GitHub Bot commented on SCB-523: coveralls commented on issue #680: [SCB-523]maven-remote-resource-plugin executes very slow URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/680#issuecomment-384860631 [](https://coveralls.io/builds/16723097) Coverage increased (+0.02%) to 87.414% when pulling **4a09de4feb35f14463a96a7c177c5faadaeeb203 on liubao68:config-cc-fetch** into **5348393b977f5e6a8eac87016dd1f969a7a1e6df on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > maven-remote-resource-plugin execute very slow > -- > > Key: SCB-523 > URL: https://issues.apache.org/jira/browse/SCB-523 > Project: Apache ServiceComb > Issue Type: Improvement >Reporter: liubao >Assignee: liubao >Priority: Major > > maven-remote-resource-plugin execute very slow and we only need this in > release stage. In order to make development easy, need to move it to release > stage. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-523) maven-remote-resource-plugin execute very slow
[ https://issues.apache.org/jira/browse/SCB-523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16455726#comment-16455726 ] ASF GitHub Bot commented on SCB-523: liubao68 opened a new pull request #680: [SCB-523]maven-remote-resource-plugin executes very slow URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/680 Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/SCB) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [ ] Each commit in the pull request should have a meaningful subject line and body. - [ ] Format the pull request title like `[SCB-XXX] Fixes bug in ApproximateQuantiles`, where you replace `SCB-XXX` with the appropriate JIRA issue. - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [ ] Run `mvn clean install` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). --- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > maven-remote-resource-plugin execute very slow > -- > > Key: SCB-523 > URL: https://issues.apache.org/jira/browse/SCB-523 > Project: Apache ServiceComb > Issue Type: Improvement >Reporter: liubao >Assignee: liubao >Priority: Major > > maven-remote-resource-plugin execute very slow and we only need this in > release stage. In order to make development easy, need to move it to release > stage. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (SCB-523) maven-remote-resource-plugin execute very slow
liubao created SCB-523: -- Summary: maven-remote-resource-plugin execute very slow Key: SCB-523 URL: https://issues.apache.org/jira/browse/SCB-523 Project: Apache ServiceComb Issue Type: Improvement Reporter: liubao Assignee: liubao maven-remote-resource-plugin execute very slow and we only need this in release stage. In order to make development easy, need to move it to release stage. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-519) The Website can not be running up according to the chapter "How to run the site locally" of README.md
[ https://issues.apache.org/jira/browse/SCB-519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16455694#comment-16455694 ] ASF GitHub Bot commented on SCB-519: WillemJiang closed pull request #72: [SCB-519] Correct chapter 'How to run the site locally' of REAME.md URL: https://github.com/apache/incubator-servicecomb-website/pull/72 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/README.md b/README.md index 0bea954..0cf7617 100644 --- a/README.md +++ b/README.md @@ -1,29 +1,37 @@ # ServiceComb Website The Web Site of ServiceComb is based on [Minimal Mistakes Jekyll Theme](https://mmistakes.github.io/minimal-mistakes/). -# How to run the site locally -* Install [Ruby](https://www.ruby-lang.org/en/downloads/) and [Gem](https://rubygems.org/) - -* Install Jekyll and Bundler - - `gem install jekyll bundler` +# How to run the site locally +* Change to non-root user + +* Install [Ruby](https://www.ruby-lang.org/en/downloads/) and [Gem](https://rubygems.org/) + +* Install Jekyll and Bundler + + `sudo gem install jekyll bundler` * Clone the site files - `git clone g...@github.com:ServiceComb/ServiceComb.github.io.git` + `git clone https://github.com/apache/incubator-servicecomb-website.git` * cd ServiceComb.github.io.git * Install the gems with bundle - `bundle install` + `sudo bundle install` * Start the jekyll server - `bundle exec jekyll server` + `sudo bundle exec jekyll server` * Start web browser to access `http://localhost:4000` - + +**Note that tested versions of the tools covered in this section are as following,** + +* Ruby 2.3 +* Gem 2.7.6 +* Bundler 2.3 + # Multiple language support The website supports English now and English is used as the default language. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > The Website can not be running up according to the chapter "How to run the > site locally" of README.md > -- > > Key: SCB-519 > URL: https://issues.apache.org/jira/browse/SCB-519 > Project: Apache ServiceComb > Issue Type: Bug > Components: website >Reporter: Zhinan Lin >Assignee: Zhinan Lin >Priority: Major > > The Website can not running up if using default version of tools according to > the guide of README.md > # Lack of verison of tools > # Should be non-root -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-519) The Website can not be running up according to the chapter "How to run the site locally" of README.md
[ https://issues.apache.org/jira/browse/SCB-519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16455483#comment-16455483 ] ASF GitHub Bot commented on SCB-519: WillemJiang commented on a change in pull request #72: [SCB-519] Correct chapter 'How to run the site locally' of REAME.md URL: https://github.com/apache/incubator-servicecomb-website/pull/72#discussion_r184548409 ## File path: README.md ## @@ -1,29 +1,37 @@ # ServiceComb Website The Web Site of ServiceComb is based on [Minimal Mistakes Jekyll Theme](https://mmistakes.github.io/minimal-mistakes/). -# How to run the site locally -* Install [Ruby](https://www.ruby-lang.org/en/downloads/) and [Gem](https://rubygems.org/) - -* Install Jekyll and Bundler - - `gem install jekyll bundler` +# How to run the site locally +* Change to non-root user + +* Install [Ruby](https://www.ruby-lang.org/en/downloads/) and [Gem](https://rubygems.org/) + +* Install Jekyll and Bundler + + `sudo gem install jekyll bundler` * Clone the site files - `git clone g...@github.com:ServiceComb/ServiceComb.github.io.git` + `git clone https://github.com/apache/incubator-servicecomb-website.git` * cd ServiceComb.github.io.git Review comment: This line need to be changed too This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > The Website can not be running up according to the chapter "How to run the > site locally" of README.md > -- > > Key: SCB-519 > URL: https://issues.apache.org/jira/browse/SCB-519 > Project: Apache ServiceComb > Issue Type: Bug > Components: website >Reporter: Zhinan Lin >Assignee: Zhinan Lin >Priority: Major > > The Website can not running up if using default version of tools according to > the guide of README.md > # Lack of verison of tools > # Should be non-root -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (SCB-522) Compensation call could fail because of CompensationContext is instance related
haifeng niu created SCB-522: --- Summary: Compensation call could fail because of CompensationContext is instance related Key: SCB-522 URL: https://issues.apache.org/jira/browse/SCB-522 Project: Apache ServiceComb Issue Type: Bug Components: Saga Affects Versions: saga-0.1.0 Reporter: haifeng niu It's a critical situation, I could not provide a test case. But I can explain it with an example: We deploy two service instance A and B with same codebase. We usually do this for high available. If A did some operation, CompensationContext of A will cache instance of service bean, than later it would be used in compensation call if error happens. But if A crash, the coordinator (aka alpha) will call an backup service instance, which is B, to compensate. Although there is no cached instance of service bean in CompensationContext of B, so compensation fail. We expect any instance of same service should process compensation successfully, if it doesn't, it is a bug. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-518) ServiceCenter ip address need to config default port
[ https://issues.apache.org/jira/browse/SCB-518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16454224#comment-16454224 ] ASF GitHub Bot commented on SCB-518: coveralls commented on issue #676: [SCB-518] ServiceCenter ip address need to config default port URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/676#issuecomment-384499897 [](https://coveralls.io/builds/16709672) Coverage decreased (-0.001%) to 87.391% when pulling **69ff6accd33003f03bee344b0b0f00e934aa336d on weichao666:scusedefaultport** into **5348393b977f5e6a8eac87016dd1f969a7a1e6df on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > ServiceCenter ip address need to config default port > > > Key: SCB-518 > URL: https://issues.apache.org/jira/browse/SCB-518 > Project: Apache ServiceComb > Issue Type: Improvement > Components: Java-Chassis >Reporter: WeiChao >Assignee: WeiChao >Priority: Major > > for http/https, the default ports are 80 and 443. if port is not configured, > the default port needs to be used. this simplifies the configuration. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-518) ServiceCenter ip address need to config default port
[
https://issues.apache.org/jira/browse/SCB-518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16454007#comment-16454007
]
ASF GitHub Bot commented on SCB-518:
weichao666 commented on a change in pull request #676: [SCB-518] ServiceCenter
ip address need to config default port
URL:
https://github.com/apache/incubator-servicecomb-java-chassis/pull/676#discussion_r184383321
##
File path:
service-registry/src/main/java/org/apache/servicecomb/serviceregistry/config/ServiceRegistryConfig.java
##
@@ -133,10 +131,8 @@ public boolean isSsl() {
uriList.forEach(anUriList -> {
try {
URI uri = new URI(anUriList);
-StringBuilder sb = new StringBuilder(uri.getHost());
-sb.append(':').append(uri.getPort() < 0 ? PROTOCOL_HTTP_PORT :
uri.getPort());
this.ssl = uri.getScheme().startsWith("https");
Review comment:
done
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> ServiceCenter ip address need to config default port
>
>
> Key: SCB-518
> URL: https://issues.apache.org/jira/browse/SCB-518
> Project: Apache ServiceComb
> Issue Type: Improvement
> Components: Java-Chassis
>Reporter: WeiChao
>Assignee: WeiChao
>Priority: Major
>
> for http/https, the default ports are 80 and 443. if port is not configured,
> the default port needs to be used. this simplifies the configuration.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (SCB-518) ServiceCenter ip address need to config default port
[
https://issues.apache.org/jira/browse/SCB-518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16454006#comment-16454006
]
ASF GitHub Bot commented on SCB-518:
weichao666 commented on a change in pull request #676: [SCB-518] ServiceCenter
ip address need to config default port
URL:
https://github.com/apache/incubator-servicecomb-java-chassis/pull/676#discussion_r184383269
##
File path:
service-registry/src/main/java/org/apache/servicecomb/serviceregistry/config/ServiceRegistryConfig.java
##
@@ -133,10 +131,8 @@ public boolean isSsl() {
uriList.forEach(anUriList -> {
try {
URI uri = new URI(anUriList);
-StringBuilder sb = new StringBuilder(uri.getHost());
-sb.append(':').append(uri.getPort() < 0 ? PROTOCOL_HTTP_PORT :
uri.getPort());
this.ssl = uri.getScheme().startsWith("https");
-ipPortList.add(NetUtils.parseIpPort(sb.toString()));
+ipPortList.add(NetUtils.parseIpPort(uri.getScheme(),
uri.getAuthority()));
Review comment:
done
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> ServiceCenter ip address need to config default port
>
>
> Key: SCB-518
> URL: https://issues.apache.org/jira/browse/SCB-518
> Project: Apache ServiceComb
> Issue Type: Improvement
> Components: Java-Chassis
>Reporter: WeiChao
>Assignee: WeiChao
>Priority: Major
>
> for http/https, the default ports are 80 and 443. if port is not configured,
> the default port needs to be used. this simplifies the configuration.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (SCB-521) change the priority of ServiceComb config and SpringBoot config
[ https://issues.apache.org/jira/browse/SCB-521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16453951#comment-16453951 ] ASF GitHub Bot commented on SCB-521: coveralls commented on issue #679: [SCB-521] Config of Spring Boot should takes higher priority than microservice.yaml URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/679#issuecomment-384623803 [](https://coveralls.io/builds/16708510) Coverage increased (+0.006%) to 87.397% when pulling **6228339aedfe424cf29ab749c526eae94236e04f on yhs0092:change_config_priority_of_SpringBoot_and_ServiceComb** into **5348393b977f5e6a8eac87016dd1f969a7a1e6df on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > change the priority of ServiceComb config and SpringBoot config > --- > > Key: SCB-521 > URL: https://issues.apache.org/jira/browse/SCB-521 > Project: Apache ServiceComb > Issue Type: Bug >Reporter: YaoHaishi >Assignee: YaoHaishi >Priority: Major > Attachments: ComplieWarning.PNG > > > The configurations of SpringBoot should take higher priority than ServiceComb -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-506) 服务治理相关的需要事件上报
[ https://issues.apache.org/jira/browse/SCB-506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16453914#comment-16453914 ] ASF GitHub Bot commented on SCB-506: coveralls commented on issue #678: [SCB-506]服务治理相关的需要事件上报 URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/678#issuecomment-384615018 [](https://coveralls.io/builds/16708066) Coverage increased (+0.02%) to 87.411% when pulling **a9fa862360f9f8d33edffe072814feffd2c301af on xuyiyun0929:alarm** into **5348393b977f5e6a8eac87016dd1f969a7a1e6df on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > 服务治理相关的需要事件上报 > - > > Key: SCB-506 > URL: https://issues.apache.org/jira/browse/SCB-506 > Project: Apache ServiceComb > Issue Type: Task > Components: Java-Chassis >Reporter: xuyiyun >Assignee: xuyiyun >Priority: Major > > 如果发生服务降级 实例隔离 熔断等操作，业务监控系统需要能获取到对应的通知，方便集成 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-521) change the priority of ServiceComb config and SpringBoot config
[ https://issues.apache.org/jira/browse/SCB-521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16453912#comment-16453912 ] ASF GitHub Bot commented on SCB-521: yhs0092 opened a new pull request #679: [SCB-521] Config of Spring Boot should takes higher priority than microservice.yaml URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/679 Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/SCB) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [ ] Each commit in the pull request should have a meaningful subject line and body. - [ ] Format the pull request title like `[SCB-XXX] Fixes bug in ApproximateQuantiles`, where you replace `SCB-XXX` with the appropriate JIRA issue. - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [ ] Run `mvn clean install` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). --- See [SCB-521](https://issues.apache.org/jira/browse/SCB-521) Config of SpringBoot should takes higher priority than microservice.yaml, so that the users converting SpringBoot project to ServiceComb don't have to add microservice.yaml to override the default config. They can just write config in application.properties/yaml  This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > change the priority of ServiceComb config and SpringBoot config > --- > > Key: SCB-521 > URL: https://issues.apache.org/jira/browse/SCB-521 > Project: Apache ServiceComb > Issue Type: Bug >Reporter: YaoHaishi >Assignee: YaoHaishi >Priority: Major > Attachments: ComplieWarning.PNG > > > The configurations of SpringBoot should take higher priority than ServiceComb -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (SCB-521) change the priority of ServiceComb config and SpringBoot config
[ https://issues.apache.org/jira/browse/SCB-521?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] YaoHaishi updated SCB-521: -- Attachment: ComplieWarning.PNG > change the priority of ServiceComb config and SpringBoot config > --- > > Key: SCB-521 > URL: https://issues.apache.org/jira/browse/SCB-521 > Project: Apache ServiceComb > Issue Type: Bug >Reporter: YaoHaishi >Assignee: YaoHaishi >Priority: Major > Attachments: ComplieWarning.PNG > > > The configurations of SpringBoot should take higher priority than ServiceComb -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-519) The Website can not be running up according to the chapter "How to run the site locally" of README.md
[ https://issues.apache.org/jira/browse/SCB-519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16453886#comment-16453886 ] ASF GitHub Bot commented on SCB-519: zenlinTechnofreak opened a new pull request #72: [SCB-519] Correct chapter 'How to run the site locally' of REAME.md URL: https://github.com/apache/incubator-servicecomb-website/pull/72 [SCB-519] Correct chapter 'How to run the site locally' of REAME.md Signed-off-by: linzhinan This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > The Website can not be running up according to the chapter "How to run the > site locally" of README.md > -- > > Key: SCB-519 > URL: https://issues.apache.org/jira/browse/SCB-519 > Project: Apache ServiceComb > Issue Type: Bug > Components: website >Reporter: Zhinan Lin >Assignee: Zhinan Lin >Priority: Major > > The Website can not running up if using default version of tools according to > the guide of README.md > # Lack of verison of tools > # Should be non-root -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-506) 服务治理相关的需要事件上报
[ https://issues.apache.org/jira/browse/SCB-506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16453879#comment-16453879 ] ASF GitHub Bot commented on SCB-506: xuyiyun0929 opened a new pull request #678: [SCB-506]服务治理相关的需要事件上报 URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/678 Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/SCB) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [ ] Each commit in the pull request should have a meaningful subject line and body. - [ ] Format the pull request title like `[SCB-XXX] Fixes bug in ApproximateQuantiles`, where you replace `SCB-XXX` with the appropriate JIRA issue. - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [ ] Run `mvn clean install` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). --- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > 服务治理相关的需要事件上报 > - > > Key: SCB-506 > URL: https://issues.apache.org/jira/browse/SCB-506 > Project: Apache ServiceComb > Issue Type: Task > Components: Java-Chassis >Reporter: xuyiyun >Assignee: xuyiyun >Priority: Major > > 如果发生服务降级 实例隔离 熔断等操作，业务监控系统需要能获取到对应的通知，方便集成 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-520) resolve service with env re-registered will fail
[ https://issues.apache.org/jira/browse/SCB-520?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16453714#comment-16453714 ] ASF GitHub Bot commented on SCB-520: coveralls commented on issue #677: [SCB-520] resolve service with env re-registered will fail URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/677#issuecomment-384564240 [](https://coveralls.io/builds/16705660) Coverage increased (+0.001%) to 87.393% when pulling **d393e6d4668f6a024cf169215fedec4fae9ba0fb on weichao666:envreregistryfail** into **5348393b977f5e6a8eac87016dd1f969a7a1e6df on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > resolve service with env re-registered will fail > > > Key: SCB-520 > URL: https://issues.apache.org/jira/browse/SCB-520 > Project: Apache ServiceComb > Issue Type: Bug > Components: Java-Chassis >Reporter: WeiChao >Assignee: WeiChao >Priority: Major > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (SCB-521) change the priority of ServiceComb config and SpringBoot config
YaoHaishi created SCB-521: - Summary: change the priority of ServiceComb config and SpringBoot config Key: SCB-521 URL: https://issues.apache.org/jira/browse/SCB-521 Project: Apache ServiceComb Issue Type: Bug Reporter: YaoHaishi Assignee: YaoHaishi The configurations of SpringBoot should take higher priority than ServiceComb -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-520) resolve service with env re-registered will fail
[ https://issues.apache.org/jira/browse/SCB-520?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16453667#comment-16453667 ] ASF GitHub Bot commented on SCB-520: weichao666 commented on issue #677: [SCB-520] resolve service with env re-registered will fail URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/677#issuecomment-384553200  This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > resolve service with env re-registered will fail > > > Key: SCB-520 > URL: https://issues.apache.org/jira/browse/SCB-520 > Project: Apache ServiceComb > Issue Type: Bug > Components: Java-Chassis >Reporter: WeiChao >Assignee: WeiChao >Priority: Major > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-520) resolve service with env re-registered will fail
[ https://issues.apache.org/jira/browse/SCB-520?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16453665#comment-16453665 ] ASF GitHub Bot commented on SCB-520: weichao666 opened a new pull request #677: [SCB-520] resolve service with env re-registered will fail URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/677 Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/SCB) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [ ] Each commit in the pull request should have a meaningful subject line and body. - [ ] Format the pull request title like `[SCB-XXX] Fixes bug in ApproximateQuantiles`, where you replace `SCB-XXX` with the appropriate JIRA issue. - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [ ] Run `mvn clean install` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). --- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > resolve service with env re-registered will fail > > > Key: SCB-520 > URL: https://issues.apache.org/jira/browse/SCB-520 > Project: Apache ServiceComb > Issue Type: Bug > Components: Java-Chassis >Reporter: WeiChao >Assignee: WeiChao >Priority: Major > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (SCB-520) resolve service with env re-registered will fail
WeiChao created SCB-520: --- Summary: resolve service with env re-registered will fail Key: SCB-520 URL: https://issues.apache.org/jira/browse/SCB-520 Project: Apache ServiceComb Issue Type: Bug Components: Java-Chassis Reporter: WeiChao Assignee: WeiChao -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-224) [pack] retry sub-transaction on failure
[
https://issues.apache.org/jira/browse/SCB-224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16453655#comment-16453655
]
ASF GitHub Bot commented on SCB-224:
WillemJiang commented on a change in pull request #138: SCB-224 retry
sub-transaction on failure
URL:
https://github.com/apache/incubator-servicecomb-saga/pull/138#discussion_r183574797
##
File path:
alpha/alpha-server/src/main/java/org/apache/servicecomb/saga/alpha/server/TxEventEnvelopeRepository.java
##
@@ -56,9 +66,13 @@
@Query("SELECT DISTINCT new org.apache.servicecomb.saga.alpha.core.TxEvent("
+ "t.serviceName, t.instanceId, t.globalTxId, t.localTxId, t.parentTxId,
"
- + "t.type, t.compensationMethod, t.payloads"
+ + "t.type, t.compensationMethod, t.payloads "
+ ") FROM TxEvent t "
- + "WHERE t.globalTxId = ?1 AND t.type = ?2")
+ + "WHERE t.globalTxId = ?1 AND t.type = ?2 "
Review comment:
It's a litter bit complicated, as we have retry option, the retry failed
event is not same with the abort event. It should be easy if we introduce retry
failed event.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> [pack] retry sub-transaction on failure
> ---
>
> Key: SCB-224
> URL: https://issues.apache.org/jira/browse/SCB-224
> Project: Apache ServiceComb
> Issue Type: New Feature
> Components: Saga
>Reporter: Yin Xiang
>Assignee: Eric Lee
>Priority: Major
> Fix For: saga-0.2.0
>
>
> as a user, i want to retry transaction in my service, so that it can always
> be done eventually.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
