[jira] [Commented] (SCB-527) Reorganization All Archetype For Enable Auto Publish

2018-04-28 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/SCB-527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16457412#comment-16457412
 ] 

ASF GitHub Bot commented on SCB-527:


zhengyangyong opened a new pull request #682: [SCB-527] Reorganization All 
Archetype For Enable Auto Publish
URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/682
 
 
   Follow this checklist to help us incorporate your contribution quickly and 
easily:
   
- [ ] Make sure there is a [JIRA 
issue](https://issues.apache.org/jira/browse/SCB) filed for the change (usually 
before you start working on it).  Trivial changes like typos do not require a 
JIRA issue.  Your pull request should address just this issue, without pulling 
in other changes.
- [ ] Each commit in the pull request should have a meaningful subject line 
and body.
- [ ] Format the pull request title like `[SCB-XXX] Fixes bug in 
ApproximateQuantiles`, where you replace `SCB-XXX` with the appropriate JIRA 
issue.
- [ ] Write a pull request description that is detailed enough to 
understand what the pull request does, how, and why.
- [ ] Run `mvn clean install` to make sure basic checks pass. A more 
thorough check will be performed on your pull request automatically.
- [ ] If this contribution is large, please file an Apache [Individual 
Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
   
   ---
   Current archetype is organize for using [`mvn 
archetype:create-from-project`](http://maven.apache.org/archetype/maven-archetype-plugin/create-from-project-mojo.html)
 to publish,it is not so good for auto build and publish to maven center repo.
   
   We need reorganization all of them using normal [`maven 
install`](https://maven.apache.org/guides/mini/guide-creating-archetypes.html) 
to generate -archetype.jar and auto publish.some examples can be found 
[here](https://github.com/apache/camel/tree/master/archetypes) .
   
   Also update README.md
   
   Use snapshot archetypes (`business-service-jaxrs-archetype` as example) : 
   ```bash
   mvn archetype:generate -DarchetypeGroupId=org.apache.servicecomb.archetypes 
-DarchetypeArtifactId=business-service-jaxrs-archetype 
-DarchetypeVersion=${archetype-version} 
-DarchetypeRepository=https://repository.apache.org/content/groups/snapshots-group
   ```


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Reorganization All Archetype For Enable Auto Publish
> 
>
> Key: SCB-527
> URL: https://issues.apache.org/jira/browse/SCB-527
> Project: Apache ServiceComb
>  Issue Type: Sub-task
>  Components: Java-Chassis
>Affects Versions: java-chassis-1.0.0-m2
>Reporter: yangyongzheng
>Assignee: yangyongzheng
>Priority: Major
> Fix For: java-chassis-1.0.0-m2
>
>
> Current archetype is organize for using [`mvn 
> archetype:create-from-project`](http://maven.apache.org/archetype/maven-archetype-plugin/create-from-project-mojo.html)
>  to publish,it is not so good for auto build and publish to maven center repo.
> We need reorganization all of them using normal [`maven 
> install`](https://maven.apache.org/guides/mini/guide-creating-archetypes.html)
>  to generate -archetype.jar and auto publish.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (SCB-527) Reorganization All Archetype For Enable Auto Publish

2018-04-28 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/SCB-527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16457428#comment-16457428
 ] 

ASF GitHub Bot commented on SCB-527:


coveralls commented on issue #682: [SCB-527] Reorganization All Archetype For 
Enable Auto Publish
URL: 
https://github.com/apache/incubator-servicecomb-java-chassis/pull/682#issuecomment-385149322
 
 
   
   [![Coverage 
Status](https://coveralls.io/builds/16741079/badge)](https://coveralls.io/builds/16741079)
   
   Coverage remained the same at 87.411% when pulling 
**303a84a36c8ccabe47c71dbaadf004a34f1c8b16 on zhengyangyong:SCB-527** into 
**d5d1788fa8af733dc308c51548e03d1c81abd896 on apache:master**.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Reorganization All Archetype For Enable Auto Publish
> 
>
> Key: SCB-527
> URL: https://issues.apache.org/jira/browse/SCB-527
> Project: Apache ServiceComb
>  Issue Type: Sub-task
>  Components: Java-Chassis
>Affects Versions: java-chassis-1.0.0-m2
>Reporter: yangyongzheng
>Assignee: yangyongzheng
>Priority: Major
> Fix For: java-chassis-1.0.0-m2
>
>
> Current archetype is organize for using [`mvn 
> archetype:create-from-project`](http://maven.apache.org/archetype/maven-archetype-plugin/create-from-project-mojo.html)
>  to publish,it is not so good for auto build and publish to maven center repo.
> We need reorganization all of them using normal [`maven 
> install`](https://maven.apache.org/guides/mini/guide-creating-archetypes.html)
>  to generate -archetype.jar and auto publish.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (SCB-525) It is better to delete logos of Qcon in the Blog 'distributed-transactions-saga-implementation'

2018-04-28 Thread Zhinan Lin (JIRA)

[ 
https://issues.apache.org/jira/browse/SCB-525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16457447#comment-16457447
 ] 

Zhinan Lin commented on SCB-525:


It a speech on the Qcon, so  it is suitable for the Qcon logos.

> It is better to delete logos of Qcon in the Blog 
> 'distributed-transactions-saga-implementation' 
> 
>
> Key: SCB-525
> URL: https://issues.apache.org/jira/browse/SCB-525
> Project: Apache ServiceComb
>  Issue Type: Wish
>  Components: website
>Reporter: Zhinan Lin
>Assignee: Zhinan Lin
>Priority: Minor
>
> It is better to delete logos of Qcon in the Blog 
> 'distributed-transactions-saga-implementation' 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Comment Edited] (SCB-525) It is better to delete logos of Qcon in the Blog 'distributed-transactions-saga-implementation'

2018-04-28 Thread Zhinan Lin (JIRA)

[ 
https://issues.apache.org/jira/browse/SCB-525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16457447#comment-16457447
 ] 

Zhinan Lin edited comment on SCB-525 at 4/28/18 8:26 AM:
-

It a speech on the Qcon, so  it is suitable for the Qcon logos.

I am going to cancel the issue.


was (Author: zen lin):
It a speech on the Qcon, so  it is suitable for the Qcon logos.

> It is better to delete logos of Qcon in the Blog 
> 'distributed-transactions-saga-implementation' 
> 
>
> Key: SCB-525
> URL: https://issues.apache.org/jira/browse/SCB-525
> Project: Apache ServiceComb
>  Issue Type: Wish
>  Components: website
>Reporter: Zhinan Lin
>Assignee: Zhinan Lin
>Priority: Minor
>
> It is better to delete logos of Qcon in the Blog 
> 'distributed-transactions-saga-implementation' 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Closed] (SCB-525) It is better to delete logos of Qcon in the Blog 'distributed-transactions-saga-implementation'

2018-04-28 Thread Zhinan Lin (JIRA)

 [ 
https://issues.apache.org/jira/browse/SCB-525?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Zhinan Lin closed SCB-525.
--
Resolution: Not A Bug

It is suitable for Qcon logos because it is a describe of a speech on Qcon.

Canceled.

> It is better to delete logos of Qcon in the Blog 
> 'distributed-transactions-saga-implementation' 
> 
>
> Key: SCB-525
> URL: https://issues.apache.org/jira/browse/SCB-525
> Project: Apache ServiceComb
>  Issue Type: Wish
>  Components: website
>Reporter: Zhinan Lin
>Assignee: Zhinan Lin
>Priority: Minor
>
> It is better to delete logos of Qcon in the Blog 
> 'distributed-transactions-saga-implementation' 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (SCB-224) [pack] retry sub-transaction on failure

2018-04-28 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/SCB-224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16457482#comment-16457482
 ] 

ASF GitHub Bot commented on SCB-224:


WillemJiang commented on issue #138: SCB-224 retry sub-transaction on failure
URL: 
https://github.com/apache/incubator-servicecomb-saga/pull/138#issuecomment-385156256
 
 
   Merged the patch into master branch.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> [pack] retry sub-transaction on failure
> ---
>
> Key: SCB-224
> URL: https://issues.apache.org/jira/browse/SCB-224
> Project: Apache ServiceComb
>  Issue Type: New Feature
>  Components: Saga
>Reporter: Yin Xiang
>Assignee: Eric Lee
>Priority: Major
> Fix For: saga-0.2.0
>
>
> as a user, i want to retry transaction in my service, so that it can always 
> be done eventually.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (SCB-224) [pack] retry sub-transaction on failure

2018-04-28 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/SCB-224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16457481#comment-16457481
 ] 

ASF GitHub Bot commented on SCB-224:


WillemJiang closed pull request #138: SCB-224 retry sub-transaction on failure
URL: https://github.com/apache/incubator-servicecomb-saga/pull/138
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git 
a/acceptance-tests/acceptance-pack/src/test/java/org/apache/servicecomb/saga/PackStepdefs.java
 
b/acceptance-tests/acceptance-pack/src/test/java/org/apache/servicecomb/saga/PackStepdefs.java
index 4f2f729a..f9af438a 100644
--- 
a/acceptance-tests/acceptance-pack/src/test/java/org/apache/servicecomb/saga/PackStepdefs.java
+++ 
b/acceptance-tests/acceptance-pack/src/test/java/org/apache/servicecomb/saga/PackStepdefs.java
@@ -41,7 +41,7 @@
 import cucumber.api.java8.En;
 
 public class PackStepdefs implements En {
-  private static final Logger log = 
LoggerFactory.getLogger(MethodHandles.lookup().lookupClass());
+  private static final Logger LOG = 
LoggerFactory.getLogger(MethodHandles.lookup().lookupClass());
 
   private static final String ALPHA_REST_ADDRESS = "alpha.rest.address";
   private static final String CAR_SERVICE_ADDRESS = "car.service.address";
@@ -73,7 +73,7 @@ public PackStepdefs() {
 });
 
 Given("^Install the byteman script ([A-Za-z0-9_\\.]+) to ([A-Za-z]+) 
Service$", (String script, String service) -> {
-  log.info("Install the byteman script {} to {} service", script, service);
+  LOG.info("Install the byteman script {} to {} service", script, service);
   List rules = new ArrayList<>();
   rules.add("target/test-classes/" + script);
   Submit bm = getBytemanSubmit(service);
@@ -81,7 +81,7 @@ public PackStepdefs() {
 });
 
 When("^User ([A-Za-z]+) requests to book ([0-9]+) cars and ([0-9]+) rooms 
(success|fail)$", (username, cars, rooms, result) -> {
-  log.info("Received request from user {} to book {} cars and {} rooms", 
username, cars, rooms);
+  LOG.info("Received request from user {} to book {} cars and {} rooms", 
username, cars, rooms);
 
   Response resp = given()
   .pathParam("name", username)
@@ -116,7 +116,7 @@ public PackStepdefs() {
 
   @After
   public void cleanUp() {
-log.info("Cleaning up services");
+LOG.info("Cleaning up services");
 for (String address : addresses) {
   given()
   .when()
@@ -135,7 +135,7 @@ public void cleanUp() {
   try {
 bm.deleteAllRules();
   } catch (Exception e) {
-log.warn("Fail to delete the byteman rules " + e);
+LOG.warn("Fail to delete the byteman rules " + e);
   }
 }
   }
@@ -156,7 +156,7 @@ private void dataMatches(String address, DataTable 
dataTable, Consumer {
-  log.info("Found timeout event {}", event);
+  LOG.info("Found timeout event {}", event);
   timeoutRepository.save(txTimeoutOf(event));
 });
   }
@@ -93,9 +93,9 @@ private void updateTimeoutStatus() {
   }
 
   private void saveUncompensatedEventsToCommands() {
-
eventRepository.findFirstUncompensatedEventByIdGreaterThan(nextEndedEventId)
-.ifPresent(event -> {
-  log.info("Found uncompensated event {}", event);
+
eventRepository.findFirstUncompensatedEventByIdGreaterThan(nextEndedEventId, 
TxEndedEvent.name())
+.forEach(event -> {
+  LOG.info("Found uncompensated event {}", event);
   nextEndedEventId = event.id();
   commandRepository.saveCompensationCommands(event.globalTxId());
 });
@@ -104,7 +104,7 @@ private void saveUncompensatedEventsToCommands() {
   private void updateCompensatedCommands() {
 
eventRepository.findFirstCompensatedEventByIdGreaterThan(nextCompensatedEventId)
 .ifPresent(event -> {
-  log.info("Found compensated event {}", event);
+  LOG.info("Found compensated event {}", event);
   nextCompensatedEventId = event.id();
   updateCompensationStatus(event);
 });
@@ -114,13 +114,13 @@ private void deleteDuplicateSagaEndedEvents() {
 try {
   eventRepository.deleteDuplicateEvents(SagaEndedEvent.name());
 } catch (Exception e) {
-  log.warn("Failed to delete duplicate event", e);
+  LOG.warn("Failed to delete duplicate event", e);
 }
   }
 
   private void updateCompensationStatus(TxEvent event) {
 commandRepository.markCommandAsDone(event.globalTxId(), event.localTxId());
-log.info("Transaction with globalTxId {} and localTxId {} was compensated",
+LOG.info("Transaction with globalTxId {} and localTxId {} was compensated",
 event.globalTxId(),
 event.localTxId());
 

[jira] [Resolved] (SCB-153) Upgrade to Spring Boot 2.0

2018-04-28 Thread Willem Jiang (JIRA)

 [ 
https://issues.apache.org/jira/browse/SCB-153?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Willem Jiang resolved SCB-153.
--
   Resolution: Fixed
Fix Version/s: saga-0.2.0

> Upgrade to Spring Boot 2.0 
> ---
>
> Key: SCB-153
> URL: https://issues.apache.org/jira/browse/SCB-153
> Project: Apache ServiceComb
>  Issue Type: Wish
>  Components: Saga
>Reporter: Willem Jiang
>Priority: Major
> Fix For: saga-0.2.0
>
>
> We need to consider to upgrade to Spring Boot 2.0 to support Java 9.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (SCB-526) When creating dynamic configuration, we need to fetch once for the configuration when startup

2018-04-28 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/SCB-526?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16457495#comment-16457495
 ] 

ASF GitHub Bot commented on SCB-526:


WillemJiang commented on a change in pull request #681: [SCB-526]fetch once 
from dynamic config source when boot up
URL: 
https://github.com/apache/incubator-servicecomb-java-chassis/pull/681#discussion_r184847776
 
 

 ##
 File path: 
dynamic-config/config-cc/src/main/java/org/apache/servicecomb/config/client/ConfigCenterClient.java
 ##
 @@ -155,8 +161,19 @@ private void refreshMembers(MemberDiscovery 
memberDiscovery) {
   request.headers().add("X-Auth-Token", 
ConfigCenterConfig.INSTANCE.getToken());
 }
 authHeaderProviders.forEach(provider -> 
request.headers().addAll(provider.getSignAuthHeaders(signReq)));
+request.exceptionHandler(e -> {
+  LOGGER.error("Fetch member from {} failed. Error message is [{}].", 
configCenter, e.getMessage());
+  latch.countDown();
+});
 request.end();
   });
+  if (wait) {
+try {
 
 Review comment:
   Write a log for the waiting could be a good way to go.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> When creating dynamic configuration, we need to fetch once for the 
> configuration when startup
> -
>
> Key: SCB-526
> URL: https://issues.apache.org/jira/browse/SCB-526
> Project: Apache ServiceComb
>  Issue Type: Improvement
>Reporter: liubao
>Assignee: liubao
>Priority: Major
>
> Currently, dynamic config is fetched asynchronously, and when users use 
> dynamic configuration for following scenario will fail:
>  # make some environment, e.g. credentials
>  # spring @Value mechanism
> and so on. 
>  
> When users put these configurations to some dynamic configuration server, 
> they can assume server is running OK, and if try to fetch will give the 
> correct response. 
>  
> So it's very useful to fetch configurations once when boot up. 
>  
>  
>  
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (SCB-529) producer download file from byte[]

2018-04-28 Thread wujimin (JIRA)
wujimin created SCB-529:
---

 Summary: producer download file from byte[]
 Key: SCB-529
 URL: https://issues.apache.org/jira/browse/SCB-529
 Project: Apache ServiceComb
  Issue Type: Sub-task
  Components: Java-Chassis
Reporter: wujimin
Assignee: wujimin
 Fix For: java-chassis-1.0.0-m2






--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (SCB-530) optimize swagger to interface

2018-04-28 Thread wujimin (JIRA)
wujimin created SCB-530:
---

 Summary: optimize swagger to interface
 Key: SCB-530
 URL: https://issues.apache.org/jira/browse/SCB-530
 Project: Apache ServiceComb
  Issue Type: Task
  Components: Java-Chassis
Reporter: wujimin
Assignee: wujimin






--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (SCB-531) x-java-interface change from require to Optional

2018-04-28 Thread wujimin (JIRA)
wujimin created SCB-531:
---

 Summary: x-java-interface change from require to Optional
 Key: SCB-531
 URL: https://issues.apache.org/jira/browse/SCB-531
 Project: Apache ServiceComb
  Issue Type: Sub-task
  Components: Java-Chassis
Reporter: wujimin
Assignee: wujimin






--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (SCB-532) support Recursive dependence

2018-04-28 Thread wujimin (JIRA)
wujimin created SCB-532:
---

 Summary: support Recursive dependence
 Key: SCB-532
 URL: https://issues.apache.org/jira/browse/SCB-532
 Project: Apache ServiceComb
  Issue Type: Sub-task
  Components: Java-Chassis
Reporter: wujimin
Assignee: wujimin


{code:java}
class A{
  A a;
}
{code}
 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (SCB-533) support cyclic dependence

2018-04-28 Thread wujimin (JIRA)
wujimin created SCB-533:
---

 Summary: support cyclic dependence
 Key: SCB-533
 URL: https://issues.apache.org/jira/browse/SCB-533
 Project: Apache ServiceComb
  Issue Type: Sub-task
  Components: Java-Chassis
Reporter: wujimin
Assignee: wujimin


{code:java}
class A{
  B b;
}

class B{
  A a;
}{code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (SCB-532) support recursive dependence

2018-04-28 Thread wujimin (JIRA)

 [ 
https://issues.apache.org/jira/browse/SCB-532?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

wujimin updated SCB-532:

Summary: support recursive dependence  (was: support Recursive dependence)

> support recursive dependence
> 
>
> Key: SCB-532
> URL: https://issues.apache.org/jira/browse/SCB-532
> Project: Apache ServiceComb
>  Issue Type: Sub-task
>  Components: Java-Chassis
>Reporter: wujimin
>Assignee: wujimin
>Priority: Major
>
> {code:java}
> class A{
>   A a;
> }
> {code}
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (SCB-531) x-java-interface change from require to optional

2018-04-28 Thread wujimin (JIRA)

 [ 
https://issues.apache.org/jira/browse/SCB-531?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

wujimin updated SCB-531:

Summary: x-java-interface change from require to optional  (was: 
x-java-interface change from require to Optional)

> x-java-interface change from require to optional
> 
>
> Key: SCB-531
> URL: https://issues.apache.org/jira/browse/SCB-531
> Project: Apache ServiceComb
>  Issue Type: Sub-task
>  Components: Java-Chassis
>Reporter: wujimin
>Assignee: wujimin
>Priority: Major
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (SCB-534) generic class generate optimize

2018-04-28 Thread wujimin (JIRA)
wujimin created SCB-534:
---

 Summary: generic class generate optimize
 Key: SCB-534
 URL: https://issues.apache.org/jira/browse/SCB-534
 Project: Apache ServiceComb
  Issue Type: Sub-task
  Components: Java-Chassis
Reporter: wujimin
Assignee: wujimin


{code:java}
Generic
{code}
will not generate to be one class: Generic_User any more,

but to be two class: Generic and User



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (SCB-526) When creating dynamic configuration, we need to fetch once for the configuration when startup

2018-04-28 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/SCB-526?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16457870#comment-16457870
 ] 

ASF GitHub Bot commented on SCB-526:


eric-lee-ltk commented on a change in pull request #681: [SCB-526]fetch once 
from dynamic config source when boot up
URL: 
https://github.com/apache/incubator-servicecomb-java-chassis/pull/681#discussion_r184868922
 
 

 ##
 File path: 
dynamic-config/config-cc/src/main/java/org/apache/servicecomb/config/client/ConfigCenterClient.java
 ##
 @@ -128,24 +130,28 @@ public void connectServer() {
 } catch (InterruptedException e) {
   throw new IllegalStateException(e);
 }
-refreshMembers(memberDiscovery);
-EXECUTOR.scheduleWithFixedDelay(new ConfigRefresh(parseConfigUtils, 
memberDiscovery),
+refreshMembers(memberDiscovery, true);
+ConfigRefresh refrestTask = new ConfigRefresh(parseConfigUtils, 
memberDiscovery);
 
 Review comment:
   typo, refrestTask


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> When creating dynamic configuration, we need to fetch once for the 
> configuration when startup
> -
>
> Key: SCB-526
> URL: https://issues.apache.org/jira/browse/SCB-526
> Project: Apache ServiceComb
>  Issue Type: Improvement
>Reporter: liubao
>Assignee: liubao
>Priority: Major
>
> Currently, dynamic config is fetched asynchronously, and when users use 
> dynamic configuration for following scenario will fail:
>  # make some environment, e.g. credentials
>  # spring @Value mechanism
> and so on. 
>  
> When users put these configurations to some dynamic configuration server, 
> they can assume server is running OK, and if try to fetch will give the 
> correct response. 
>  
> So it's very useful to fetch configurations once when boot up. 
>  
>  
>  
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (SCB-527) Reorganization All Archetype For Enable Auto Publish

2018-04-28 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/SCB-527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16457872#comment-16457872
 ] 

ASF GitHub Bot commented on SCB-527:


eric-lee-ltk commented on a change in pull request #682: [SCB-527] 
Reorganization All Archetype For Enable Auto Publish
URL: 
https://github.com/apache/incubator-servicecomb-java-chassis/pull/682#discussion_r184869026
 
 

 ##
 File path: 
archetypes/business-service-pojo/src/main/resources/archetype-resources/README.md
 ##
 @@ -0,0 +1,20 @@
+## Welcome to use ServiceComb Java Chassis
+This project(module) is generate by 
*org.apache.servicecomb.archetypes:business-service-pojo-archetype*, it use 
**pojo provider** to develop service producer.  
+
+### More works can be done further:
+1. Modify "HelloImpl", add your business service logic, or create some new 
producers to provide your services. More details can be found : 
http://servicecomb.incubator.apache.org/users/develop-with-transparent-rpc/
+2. Modify "microservice.yaml", change APPLICATION_ID, 
service_description.name, version, and service center address, endpoints 
publish address etc. More details can be found : 
http://servicecomb.incubator.apache.org/users/service-definition/
+3. Modify setting value of "mainClass" in pom.xml for package.
+
+### Package your service
+Under project(module) root folder, run 
+```bash
+mvn package
+```
+Then you can get outputs in target folder:   
+- lib : contains all dependencies jars   
+- xx-{version}.jar   
+```bash
+java -jar xx-{version}.jar
+```
+*Notice: If you need to modify config setting in "microservice.yaml" like 
service center address but don't want repackage the executable jar, **you can 
direct place a new "microservice.yaml" file in same folder, then settings will 
be overridden.***
 
 Review comment:
   config setting -> configurations
   direct ->directly
   in same folder ->under the same folder
   settings -> configurations


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Reorganization All Archetype For Enable Auto Publish
> 
>
> Key: SCB-527
> URL: https://issues.apache.org/jira/browse/SCB-527
> Project: Apache ServiceComb
>  Issue Type: Sub-task
>  Components: Java-Chassis
>Affects Versions: java-chassis-1.0.0-m2
>Reporter: yangyongzheng
>Assignee: yangyongzheng
>Priority: Major
> Fix For: java-chassis-1.0.0-m2
>
>
> Current archetype is organize for using [`mvn 
> archetype:create-from-project`](http://maven.apache.org/archetype/maven-archetype-plugin/create-from-project-mojo.html)
>  to publish,it is not so good for auto build and publish to maven center repo.
> We need reorganization all of them using normal [`maven 
> install`](https://maven.apache.org/guides/mini/guide-creating-archetypes.html)
>  to generate -archetype.jar and auto publish.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)