[jira] [Commented] (SCB-735) Add admin dump api
[ https://issues.apache.org/jira/browse/SCB-735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16551555#comment-16551555 ] ASF GitHub Bot commented on SCB-735: coveralls edited a comment on issue #396: SCB-735 Add admin dump api URL: https://github.com/apache/incubator-servicecomb-service-center/pull/396#issuecomment-406771280 [](https://coveralls.io/builds/18096639) Coverage decreased (-2.4%) to 72.067% when pulling **0e1b969f3a269363304b076cede460ec6246e3f6 on little-cui:admin** into **7590fec4e4447fdd3b2977970d544e88ae3762cf on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Add admin dump api > -- > > Key: SCB-735 > URL: https://issues.apache.org/jira/browse/SCB-735 > Project: Apache ServiceComb > Issue Type: New Feature > Components: Service-Center >Reporter: little-cui >Assignee: little-cui >Priority: Major > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-735) Add admin dump api
[ https://issues.apache.org/jira/browse/SCB-735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16551554#comment-16551554 ] ASF GitHub Bot commented on SCB-735: codecov-io edited a comment on issue #396: SCB-735 Add admin dump api URL: https://github.com/apache/incubator-servicecomb-service-center/pull/396#issuecomment-406771272 # [Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/396?src=pr&el=h1) Report > Merging [#396](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/396?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-servicecomb-service-center/commit/7590fec4e4447fdd3b2977970d544e88ae3762cf?src=pr&el=desc) will **decrease** coverage by `2.04%`. > The diff coverage is `79.64%`. [](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/396?src=pr&el=tree) ```diff @@Coverage Diff @@ ## master #396 +/- ## == - Coverage 71.69% 69.65% -2.05% == Files 39 73 +34 Lines4130 5879+1749 == + Hits 2961 4095+1134 - Misses 1002 1564 +562 - Partials 167 220 +53 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/396?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [server/service/notification/common.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/396/diff?src=pr&el=tree#diff-c2VydmVyL3NlcnZpY2Uvbm90aWZpY2F0aW9uL2NvbW1vbi5nbw==) | `100% <ø> (ø)` | :arrow_up: | | [pkg/tlsutil/tlsutil.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/396/diff?src=pr&el=tree#diff-cGtnL3Rsc3V0aWwvdGxzdXRpbC5nbw==) | `73.07% <ø> (ø)` | | | [pkg/chain/invocation.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/396/diff?src=pr&el=tree#diff-cGtnL2NoYWluL2ludm9jYXRpb24uZ28=) | `89.47% <ø> (ø)` | | | [pkg/validate/url.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/396/diff?src=pr&el=tree#diff-cGtnL3ZhbGlkYXRlL3VybC5nbw==) | `0% <0%> (ø)` | | | [...erver/service/notification/notification\_service.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/396/diff?src=pr&el=tree#diff-c2VydmVyL3NlcnZpY2Uvbm90aWZpY2F0aW9uL25vdGlmaWNhdGlvbl9zZXJ2aWNlLmdv) | `91.54% <100%> (ø)` | :arrow_up: | | [pkg/util/goroutines.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/396/diff?src=pr&el=tree#diff-cGtnL3V0aWwvZ29yb3V0aW5lcy5nbw==) | `100% <100%> (ø)` | | | [pkg/util/util.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/396/diff?src=pr&el=tree#diff-cGtnL3V0aWwvdXRpbC5nbw==) | `67.34% <100%> (ø)` | | | [server/service/watch.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/396/diff?src=pr&el=tree#diff-c2VydmVyL3NlcnZpY2Uvd2F0Y2guZ28=) | `70.96% <100%> (ø)` | :arrow_up: | | [pkg/async/service.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/396/diff?src=pr&el=tree#diff-cGtnL2FzeW5jL3NlcnZpY2UuZ28=) | `72.8% <100%> (ø)` | | | [server/service/notification/stream.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/396/diff?src=pr&el=tree#diff-c2VydmVyL3NlcnZpY2Uvbm90aWZpY2F0aW9uL3N0cmVhbS5nbw==) | `65.21% <33.33%> (ø)` | :arrow_up: | | ... and [39 more](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/396/diff?src=pr&el=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/396?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/396?src=pr&el=footer). Last update [7590fec...0e1b969](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/396?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Add admin dump a
[jira] [Commented] (SCB-735) Add admin dump api
[ https://issues.apache.org/jira/browse/SCB-735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16551536#comment-16551536 ] ASF GitHub Bot commented on SCB-735: codecov-io commented on issue #396: SCB-735 Add admin dump api URL: https://github.com/apache/incubator-servicecomb-service-center/pull/396#issuecomment-406771272 # [Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/396?src=pr&el=h1) Report > Merging [#396](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/396?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-servicecomb-service-center/commit/7590fec4e4447fdd3b2977970d544e88ae3762cf?src=pr&el=desc) will **decrease** coverage by `5.32%`. > The diff coverage is `83.89%`. [](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/396?src=pr&el=tree) ```diff @@Coverage Diff @@ ## master #396 +/- ## == - Coverage 71.69% 66.37% -5.33% == Files 39 73 +34 Lines4130 5909+1779 == + Hits 2961 3922 +961 - Misses 1002 1773 +771 - Partials 167 214 +47 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/396?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [server/service/notification/common.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/396/diff?src=pr&el=tree#diff-c2VydmVyL3NlcnZpY2Uvbm90aWZpY2F0aW9uL2NvbW1vbi5nbw==) | `100% <ø> (ø)` | :arrow_up: | | [pkg/async/service.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/396/diff?src=pr&el=tree#diff-cGtnL2FzeW5jL3NlcnZpY2UuZ28=) | `72.8% <100%> (ø)` | | | [pkg/util/goroutines.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/396/diff?src=pr&el=tree#diff-cGtnL3V0aWwvZ29yb3V0aW5lcy5nbw==) | `100% <100%> (ø)` | | | [...erver/service/notification/notification\_service.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/396/diff?src=pr&el=tree#diff-c2VydmVyL3NlcnZpY2Uvbm90aWZpY2F0aW9uL25vdGlmaWNhdGlvbl9zZXJ2aWNlLmdv) | `91.54% <100%> (ø)` | :arrow_up: | | [server/service/watch.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/396/diff?src=pr&el=tree#diff-c2VydmVyL3NlcnZpY2Uvd2F0Y2guZ28=) | `70.96% <100%> (ø)` | :arrow_up: | | [server/service/notification/stream.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/396/diff?src=pr&el=tree#diff-c2VydmVyL3NlcnZpY2Uvbm90aWZpY2F0aW9uL3N0cmVhbS5nbw==) | `65.21% <33.33%> (ø)` | :arrow_up: | | [server/service/util/domain\_util.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/396/diff?src=pr&el=tree#diff-c2VydmVyL3NlcnZpY2UvdXRpbC9kb21haW5fdXRpbC5nbw==) | `61.19% <50%> (ø)` | :arrow_up: | | [pkg/etcdsync/mutex.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/396/diff?src=pr&el=tree#diff-cGtnL2V0Y2RzeW5jL211dGV4Lmdv) | `66.66% <79.54%> (ø)` | | | [server/service/notification/websocket.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/396/diff?src=pr&el=tree#diff-c2VydmVyL3NlcnZpY2Uvbm90aWZpY2F0aW9uL3dlYnNvY2tldC5nbw==) | `83.87% <82.05%> (+3.58%)` | :arrow_up: | | [pkg/util/log.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/396/diff?src=pr&el=tree#diff-cGtnL3V0aWwvbG9nLmdv) | `48.76% <0%> (ø)` | | | ... and [34 more](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/396/diff?src=pr&el=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/396?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/396?src=pr&el=footer). Last update [7590fec...19ed886](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/396?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queri
[jira] [Commented] (SCB-735) Add admin dump api
[ https://issues.apache.org/jira/browse/SCB-735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16551537#comment-16551537 ] ASF GitHub Bot commented on SCB-735: coveralls commented on issue #396: SCB-735 Add admin dump api URL: https://github.com/apache/incubator-servicecomb-service-center/pull/396#issuecomment-406771280 [](https://coveralls.io/builds/18096392) Coverage decreased (-5.8%) to 68.681% when pulling **19ed886ec0e8167a0b4dc564a8cb6fb56ca2d2ca on little-cui:admin** into **7590fec4e4447fdd3b2977970d544e88ae3762cf on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Add admin dump api > -- > > Key: SCB-735 > URL: https://issues.apache.org/jira/browse/SCB-735 > Project: Apache ServiceComb > Issue Type: New Feature > Components: Service-Center >Reporter: little-cui >Assignee: little-cui >Priority: Major > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-766) Upgrade Spring Boot version to 2.0.3.Release and 1.5.14.Release
[ https://issues.apache.org/jira/browse/SCB-766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16551502#comment-16551502 ] ASF GitHub Bot commented on SCB-766: WillemJiang closed pull request #229: SCB-766 Upgraded spring boot version 1.5.13 and 2.0.3. URL: https://github.com/apache/incubator-servicecomb-saga/pull/229 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Upgrade Spring Boot version to 2.0.3.Release and 1.5.14.Release > --- > > Key: SCB-766 > URL: https://issues.apache.org/jira/browse/SCB-766 > Project: Apache ServiceComb > Issue Type: Task > Components: Saga >Reporter: Willem Jiang >Priority: Minor > > We should consider to upgrade the Spring Boot version to 2.0.3.Release and > 1.5.14.Release. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-719) support complex integration test
[
https://issues.apache.org/jira/browse/SCB-719?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16551480#comment-16551480
]
wujimin commented on SCB-719:
-
should support manage test case like the below:
{code:java}
// deploy edge/zuul
// ITUtils.ensureReady(edge); // if not ready, will start a new instance and
wait for ready
// ITUtils.ensureReady(zuul);
// 1.base test case
// include all extension point abnormal scenes test case
// deploy standalone base-producer
// only run one case for "any" transport
// run highway
// run vertx-rest
// run native restTemplate to edge/zuul
// stop standalone base-producer
// deploy tomcat base-producer
// run vertx-servlet
// run native restTemplate to edge/zuul
// stop tomcat base-producer
// deploy sprint boot base-producer
// run vertx-servlet
// run native restTemplate to edge/zuul
// stop spring boot base-producer
// 2.complex test case
// 1)start new producer version
// consumer/edge/zuul should ..
// 2)delete new producer version
// consumer/edge/zuul should ..
// ..
// 3.deploy development mode producer
// ..
{code}
> support complex integration test
>
>
> Key: SCB-719
> URL: https://issues.apache.org/jira/browse/SCB-719
> Project: Apache ServiceComb
> Issue Type: Task
> Components: Java-Chassis
>Reporter: wujimin
>Assignee: wujimin
>Priority: Major
>
> currently we only support simple integration test
> if a test case need to start/stop microservice instance, then must run it
> manually, it's not so good.
>
> so we need to create a mechanism to support complex integration test.
> 1.support multiple node
> because Travis CI docker container resources are limited, so must start
> multiple containers
> 2.not depend on docker, can run in windows too.
> -3.support run in IDE equals run unit test-
> abandon
> because it's too difficult to manage microservice instance lifecycle and
> junit test class lifecycle
> some microservice instances should share cross many test class, and some
> microservice instances only used by one test class
> junit child test suite always run duplicate when whole project or package.
> 4.support run by java -jar ..
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (SCB-719) support complex integration test
[ https://issues.apache.org/jira/browse/SCB-719?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] wujimin updated SCB-719: Attachment: (was: image-2018-07-07-08-31-37-950.png) > support complex integration test > > > Key: SCB-719 > URL: https://issues.apache.org/jira/browse/SCB-719 > Project: Apache ServiceComb > Issue Type: Task > Components: Java-Chassis >Reporter: wujimin >Assignee: wujimin >Priority: Major > > currently we only support simple integration test > if a test case need to start/stop microservice instance, then must run it > manually, it's not so good. > > so we need to create a mechanism to support complex integration test. > 1.support multiple node > because Travis CI docker container resources are limited, so must start > multiple containers > 2.not depend on docker, can run in windows too. > -3.support run in IDE equals run unit test- > abandon > because it's too difficult to manage microservice instance lifecycle and > junit test class lifecycle > some microservice instances should share cross many test class, and some > microservice instances only used by one test class > junit child test suite always run duplicate when whole project or package. > 4.support run by java -jar .. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Issue Comment Deleted] (SCB-719) support complex integration test
[
https://issues.apache.org/jira/browse/SCB-719?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
wujimin updated SCB-719:
Comment: was deleted
(was: {code:java}
@RunWith(SCBSuite.class)
@Transports(Const.RESTFUL)
public class TestRestful {
@Test
public void test1() {
...
}
@Test
public void test2() {
...
}
}{code}
if run in IDE, will get a result:
!image-2018-07-07-08-31-37-950.png!
change Transports annotation:
{code:java}
@Transports()
{code}
or just delete the annotation
will get a result:
!image-2018-07-07-08-35-01-791.png!
annotation Transport support both class and method level)
> support complex integration test
>
>
> Key: SCB-719
> URL: https://issues.apache.org/jira/browse/SCB-719
> Project: Apache ServiceComb
> Issue Type: Task
> Components: Java-Chassis
>Reporter: wujimin
>Assignee: wujimin
>Priority: Major
>
> currently we only support simple integration test
> if a test case need to start/stop microservice instance, then must run it
> manually, it's not so good.
>
> so we need to create a mechanism to support complex integration test.
> 1.support multiple node
> because Travis CI docker container resources are limited, so must start
> multiple containers
> 2.not depend on docker, can run in windows too.
> -3.support run in IDE equals run unit test-
> abandon
> because it's too difficult to manage microservice instance lifecycle and
> junit test class lifecycle
> some microservice instances should share cross many test class, and some
> microservice instances only used by one test class
> junit child test suite always run duplicate when whole project or package.
> 4.support run by java -jar ..
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (SCB-719) support complex integration test
[ https://issues.apache.org/jira/browse/SCB-719?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] wujimin updated SCB-719: Attachment: (was: image-2018-07-07-08-35-01-791.png) > support complex integration test > > > Key: SCB-719 > URL: https://issues.apache.org/jira/browse/SCB-719 > Project: Apache ServiceComb > Issue Type: Task > Components: Java-Chassis >Reporter: wujimin >Assignee: wujimin >Priority: Major > > currently we only support simple integration test > if a test case need to start/stop microservice instance, then must run it > manually, it's not so good. > > so we need to create a mechanism to support complex integration test. > 1.support multiple node > because Travis CI docker container resources are limited, so must start > multiple containers > 2.not depend on docker, can run in windows too. > -3.support run in IDE equals run unit test- > abandon > because it's too difficult to manage microservice instance lifecycle and > junit test class lifecycle > some microservice instances should share cross many test class, and some > microservice instances only used by one test class > junit child test suite always run duplicate when whole project or package. > 4.support run by java -jar .. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Resolved] (SCB-762) resolve eclipse compile warnings
[ https://issues.apache.org/jira/browse/SCB-762?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] wujimin resolved SCB-762. - Resolution: Done > resolve eclipse compile warnings > > > Key: SCB-762 > URL: https://issues.apache.org/jira/browse/SCB-762 > Project: Apache ServiceComb > Issue Type: Task > Components: Java-Chassis >Reporter: wujimin >Assignee: wujimin >Priority: Major > Fix For: java-chassis-1.0.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-735) Add admin dump api
[ https://issues.apache.org/jira/browse/SCB-735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16551472#comment-16551472 ] ASF GitHub Bot commented on SCB-735: little-cui opened a new pull request #396: SCB-735 Add admin dump api URL: https://github.com/apache/incubator-servicecomb-service-center/pull/396 Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/SCB) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [ ] Each commit in the pull request should have a meaningful subject line and body. - [ ] Format the pull request title like `[SCB-XXX] Fixes bug in ApproximateQuantiles`, where you replace `SCB-XXX` with the appropriate JIRA issue. - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [ ] Run `go build` `go test` `go fmt` `go vet` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). --- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Add admin dump api > -- > > Key: SCB-735 > URL: https://issues.apache.org/jira/browse/SCB-735 > Project: Apache ServiceComb > Issue Type: New Feature > Components: Service-Center >Reporter: little-cui >Assignee: little-cui >Priority: Major > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-762) resolve eclipse compile warnings
[
https://issues.apache.org/jira/browse/SCB-762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16551435#comment-16551435
]
ASF GitHub Bot commented on SCB-762:
WillemJiang closed pull request #823: [SCB-762] resolve eclipse compile warnings
URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/823
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/foundations/foundation-common/src/main/java/org/apache/servicecomb/foundation/common/utils/JvmUtils.java
b/foundations/foundation-common/src/main/java/org/apache/servicecomb/foundation/common/utils/JvmUtils.java
index bb02d725e..e6315e9f3 100644
---
a/foundations/foundation-common/src/main/java/org/apache/servicecomb/foundation/common/utils/JvmUtils.java
+++
b/foundations/foundation-common/src/main/java/org/apache/servicecomb/foundation/common/utils/JvmUtils.java
@@ -72,7 +72,7 @@ private static String readFromJar(String mainClassOrJar) {
return mainClassOrJar;
}
-String manifestUri = "jar:file:/" + new
File(mainClassOrJar).getAbsolutePath() + "!/" + JarFile.MANIFEST_NAME;
+String manifestUri = "jar:file:" + new
File(mainClassOrJar).getAbsolutePath() + "!/" + JarFile.MANIFEST_NAME;
try {
URL url = new URL(manifestUri);
diff --git
a/foundations/foundation-common/src/test/java/org/apache/servicecomb/foundation/common/net/TestNetUtils.java
b/foundations/foundation-common/src/test/java/org/apache/servicecomb/foundation/common/net/TestNetUtils.java
index 8766b847e..a9f8fba66 100644
---
a/foundations/foundation-common/src/test/java/org/apache/servicecomb/foundation/common/net/TestNetUtils.java
+++
b/foundations/foundation-common/src/test/java/org/apache/servicecomb/foundation/common/net/TestNetUtils.java
@@ -18,7 +18,6 @@
package org.apache.servicecomb.foundation.common.net;
import java.io.IOException;
-import java.lang.reflect.Field;
import java.net.InetAddress;
import java.net.ServerSocket;
import java.util.HashMap;
@@ -108,7 +107,7 @@ public void testCanTcpListenYes() throws IOException {
Assert.assertTrue(NetUtils.canTcpListen(address, port));
}
-
+
@Test
public void testGetHostName() {
Assert.assertNotEquals(null, NetUtils.getHostName());
diff --git
a/foundations/foundation-common/src/test/java/org/apache/servicecomb/foundation/common/utils/TestJvmUtils.java
b/foundations/foundation-common/src/test/java/org/apache/servicecomb/foundation/common/utils/TestJvmUtils.java
index 257c8f407..97a616dd7 100644
---
a/foundations/foundation-common/src/test/java/org/apache/servicecomb/foundation/common/utils/TestJvmUtils.java
+++
b/foundations/foundation-common/src/test/java/org/apache/servicecomb/foundation/common/utils/TestJvmUtils.java
@@ -89,7 +89,7 @@ public void findMainClass_jar_normal() throws Exception {
URL url = PowerMockito.mock(URL.class);
String command = "a.jar";
-String manifestUri = "jar:file:/" + new File(command).getAbsolutePath() +
"!/" + JarFile.MANIFEST_NAME;
+String manifestUri = "jar:file:" + new File(command).getAbsolutePath() +
"!/" + JarFile.MANIFEST_NAME;
PowerMockito.whenNew(URL.class).withParameterTypes(String.class)
.withArguments(manifestUri).thenReturn(url);
diff --git
a/handlers/handler-bizkeeper/src/main/java/org/apache/servicecomb/bizkeeper/CustomizeCommandGroupKey.java
b/handlers/handler-bizkeeper/src/main/java/org/apache/servicecomb/bizkeeper/CustomizeCommandGroupKey.java
index c80e926f1..79183b718 100644
---
a/handlers/handler-bizkeeper/src/main/java/org/apache/servicecomb/bizkeeper/CustomizeCommandGroupKey.java
+++
b/handlers/handler-bizkeeper/src/main/java/org/apache/servicecomb/bizkeeper/CustomizeCommandGroupKey.java
@@ -24,7 +24,7 @@
import com.netflix.hystrix.util.InternMap;
/**
- *
ͨ��CommandGroupKey��ĿЯ��Invocation���־�̬��Ϣ��CircutBreakerEvent��ȡ��
+ * 通过定制CommandGroupKey，目的是携带Invocation部分静态信息，便于CircutBreakerEvent获取
*/
public class CustomizeCommandGroupKey extends HystrixKey.HystrixKeyDefault
implements HystrixCommandGroupKey {
@@ -34,13 +34,14 @@ public CustomizeCommandGroupKey(String key) {
super(key);
}
- private static final InternMap intern =
new InternMap(
- new InternMap.ValueConstructor() {
-@Override
-public CustomizeCommandGroupKey create(String key) {
- return new CustomizeCommandGroupKey(key);
-}
- });
+ private static final InternMap intern =
+ new InternMap(
+ new InternMap.ValueConstructor() {
+@Override
+public CustomizeCommandGroupKey create(String key) {
+ return new CustomizeCommandGroupKey(key);
+}
+ })
[jira] [Commented] (SCB-767) When using Response to return multi-code message, handlers / filters given ClassCaseException
[ https://issues.apache.org/jira/browse/SCB-767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16550697#comment-16550697 ] ASF GitHub Bot commented on SCB-767: coveralls commented on issue #827: [SCB-767]When using Response to return multi-code message, handlers /filters given ClassCaseException URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/827#issuecomment-406578556 [](https://coveralls.io/builds/18083079) Coverage decreased (-0.2%) to 86.763% when pulling **27ded86c1dbb5177bdb0d12980df767a0c64e24c on liubao68:response-fail** into **a1d0804132cc949061440d7de6fd971a1cfeb246 on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > When using Response to return multi-code message, handlers / filters given > ClassCaseException > - > > Key: SCB-767 > URL: https://issues.apache.org/jira/browse/SCB-767 > Project: Apache ServiceComb > Issue Type: Bug >Reporter: liubao >Assignee: liubao >Priority: Major > > Error code 400， 500 etc. takes as error. But the object result is not > throwable. So got class cast exception. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-767) When using Response to return multi-code message, handlers / filters given ClassCaseException
[ https://issues.apache.org/jira/browse/SCB-767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16550670#comment-16550670 ] ASF GitHub Bot commented on SCB-767: liubao68 opened a new pull request #827: [SCB-767]When using Response to return multi-code message, handlers /filters given ClassCaseException URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/827 Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/SCB) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [ ] Each commit in the pull request should have a meaningful subject line and body. - [ ] Format the pull request title like `[SCB-XXX] Fixes bug in ApproximateQuantiles`, where you replace `SCB-XXX` with the appropriate JIRA issue. - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [ ] Run `mvn clean install` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). --- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > When using Response to return multi-code message, handlers / filters given > ClassCaseException > - > > Key: SCB-767 > URL: https://issues.apache.org/jira/browse/SCB-767 > Project: Apache ServiceComb > Issue Type: Bug >Reporter: liubao >Assignee: liubao >Priority: Major > > Error code 400， 500 etc. takes as error. But the object result is not > throwable. So got class cast exception. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (SCB-767) When using Response to return multi-code message, handlers / filters given ClassCaseException
liubao created SCB-767: -- Summary: When using Response to return multi-code message, handlers / filters given ClassCaseException Key: SCB-767 URL: https://issues.apache.org/jira/browse/SCB-767 Project: Apache ServiceComb Issue Type: Bug Reporter: liubao Assignee: liubao Error code 400， 500 etc. takes as error. But the object result is not throwable. So got class cast exception. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-687) highway server not accept too many connection
[ https://issues.apache.org/jira/browse/SCB-687?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16550572#comment-16550572 ] ASF GitHub Bot commented on SCB-687: coveralls edited a comment on issue #824: [SCB-687] add highway server connection protection URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/824#issuecomment-406465050 [](https://coveralls.io/builds/18081071) Coverage decreased (-0.03%) to 87.055% when pulling **2c17acd2127fb77a3eba4e86d9c6cd12324c8ad0 on zhengyangyong:SCB-687** into **8227f0ccbe7d69db51df1fc22b11a364662c1d9d on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > highway server not accept too many connection > - > > Key: SCB-687 > URL: https://issues.apache.org/jira/browse/SCB-687 > Project: Apache ServiceComb > Issue Type: Sub-task > Components: Java-Chassis >Reporter: wujimin >Assignee: yangyongzheng >Priority: Major > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Resolved] (SCB-708) Support assembling query param into Object parameter(in Spring MVC developing style)
[
https://issues.apache.org/jira/browse/SCB-708?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
liubao resolved SCB-708.
Resolution: Fixed
> Support assembling query param into Object parameter(in Spring MVC developing
> style)
>
>
> Key: SCB-708
> URL: https://issues.apache.org/jira/browse/SCB-708
> Project: Apache ServiceComb
> Issue Type: New Feature
>Reporter: YaoHaishi
>Assignee: YaoHaishi
>Priority: Major
> Fix For: java-chassis-1.0.0
>
>
> In Spring Boot, user can define a REST operation with Object parameters, and
> there is no Annotation on the param like below:
> {code:java}
> @RequestMapping("/address")
> public String address(Address address)
> {code}
> {code:java}
> public class Address {
> String country;
> String city;
> }
> {code}
> Spring can assemble the query variable city and country into address, like
> /address?city=cc&country=co
> We need to support similar function.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (SCB-708) Support assembling query param into Object parameter(in Spring MVC developing style)
[
https://issues.apache.org/jira/browse/SCB-708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16550555#comment-16550555
]
ASF GitHub Bot commented on SCB-708:
liubao68 closed pull request #815: [SCB-708] Aggregate simple query params
into object param in spring mvc style
URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/815
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/core/src/main/java/org/apache/servicecomb/core/definition/schema/ProducerSchemaFactory.java
b/core/src/main/java/org/apache/servicecomb/core/definition/schema/ProducerSchemaFactory.java
index 1334332f7..a3b0a38cf 100644
---
a/core/src/main/java/org/apache/servicecomb/core/definition/schema/ProducerSchemaFactory.java
+++
b/core/src/main/java/org/apache/servicecomb/core/definition/schema/ProducerSchemaFactory.java
@@ -17,6 +17,8 @@
package org.apache.servicecomb.core.definition.schema;
+import java.util.LinkedHashMap;
+import java.util.Map;
import java.util.Set;
import java.util.concurrent.CompletableFuture;
import java.util.concurrent.Executor;
@@ -41,6 +43,7 @@
import com.fasterxml.jackson.core.JsonProcessingException;
import com.fasterxml.jackson.databind.ObjectWriter;
+import io.swagger.models.Operation;
import io.swagger.models.Swagger;
import io.swagger.util.Yaml;
@@ -79,7 +82,8 @@ public SchemaMeta getOrCreateProducerSchema(String
microserviceName, String sche
SchemaMeta schemaMeta = getOrCreateSchema(context);
-SwaggerProducer producer = swaggerEnv.createProducer(producerInstance,
schemaMeta.getSwaggerIntf());
+SwaggerProducer producer = swaggerEnv.createProducer(producerInstance,
schemaMeta.getSwaggerIntf(),
+convertSwaggerOperationMap(schemaMeta));
Executor reactiveExecutor =
BeanUtils.getBean(ExecutorManager.EXECUTOR_REACTIVE);
for (OperationMeta operationMeta : schemaMeta.getOperations()) {
SwaggerProducerOperation producerOperation =
producer.findOperation(operationMeta.getOperationId());
@@ -93,6 +97,13 @@ public SchemaMeta getOrCreateProducerSchema(String
microserviceName, String sche
return schemaMeta;
}
+ private Map convertSwaggerOperationMap(SchemaMeta
schemaMeta) {
+Map operationMap = new
LinkedHashMap<>(schemaMeta.getOperations().size());
+schemaMeta.getOperations().forEach(
+operationMeta -> operationMap.put(operationMeta.getOperationId(),
operationMeta.getSwaggerOperation()));
+return operationMap;
+ }
+
protected SchemaMeta createSchema(ProducerSchemaContext context) {
// 尝试从规划的目录加载契约
Swagger swagger = loadSwagger(context);
diff --git
a/demo/demo-schema/src/main/java/org/apache/servicecomb/demo/compute/GenericParam.java
b/demo/demo-schema/src/main/java/org/apache/servicecomb/demo/compute/GenericParam.java
new file mode 100644
index 0..3ec6f17c5
--- /dev/null
+++
b/demo/demo-schema/src/main/java/org/apache/servicecomb/demo/compute/GenericParam.java
@@ -0,0 +1,63 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.servicecomb.demo.compute;
+
+public class GenericParam {
+ private String str;
+
+ private long num;
+
+ private T data;
+
+ public String getStr() {
+return str;
+ }
+
+ public GenericParam setStr(String str) {
+this.str = str;
+return this;
+ }
+
+ public long getNum() {
+return num;
+ }
+
+ public GenericParam setNum(long num) {
+this.num = num;
+return this;
+ }
+
+ public T getData() {
+return data;
+ }
+
+ public GenericParam setData(T data) {
+this.data = data;
+return this;
+ }
+
+ @Override
+ public String toString() {
+final StringBuilder sb = new StringBuilder("GenericParam{");
+sb.append("str='").append(str).append('\'');
+sb.append(", num=").append(num);
+sb.append(", data=").append(data);
+sb.append('}');
+return sb.toString();
+ }
+}
diff --git
a/demo/demo-schema/src/m
[jira] [Updated] (SCB-708) Support assembling query param into Object parameter(in Spring MVC developing style)
[
https://issues.apache.org/jira/browse/SCB-708?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
liubao updated SCB-708:
---
Fix Version/s: (was: java-chassis-1.1.0)
java-chassis-1.0.0
> Support assembling query param into Object parameter(in Spring MVC developing
> style)
>
>
> Key: SCB-708
> URL: https://issues.apache.org/jira/browse/SCB-708
> Project: Apache ServiceComb
> Issue Type: New Feature
>Reporter: YaoHaishi
>Assignee: YaoHaishi
>Priority: Major
> Fix For: java-chassis-1.0.0
>
>
> In Spring Boot, user can define a REST operation with Object parameters, and
> there is no Annotation on the param like below:
> {code:java}
> @RequestMapping("/address")
> public String address(Address address)
> {code}
> {code:java}
> public class Address {
> String country;
> String city;
> }
> {code}
> Spring can assemble the query variable city and country into address, like
> /address?city=cc&country=co
> We need to support similar function.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (SCB-766) Upgrade Spring Boot version to 2.0.3.Release and 1.5.14.Release
[ https://issues.apache.org/jira/browse/SCB-766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16550534#comment-16550534 ] ASF GitHub Bot commented on SCB-766: coveralls commented on issue #229: SCB-766 Upgraded spring boot version 1.5.13 and 2.0.3. URL: https://github.com/apache/incubator-servicecomb-saga/pull/229#issuecomment-406535661 [](https://coveralls.io/builds/18080417) Coverage decreased (-0.6%) to 92.665% when pulling **8cff7ab8bc4e66283c4afa5aa662330134d86eb6 on SCB-766** into **be00cf4b0f91d1dda19835d3b3c0f1284df2e875 on master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Upgrade Spring Boot version to 2.0.3.Release and 1.5.14.Release > --- > > Key: SCB-766 > URL: https://issues.apache.org/jira/browse/SCB-766 > Project: Apache ServiceComb > Issue Type: Task > Components: Saga >Reporter: Willem Jiang >Priority: Minor > > We should consider to upgrade the Spring Boot version to 2.0.3.Release and > 1.5.14.Release. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-766) Upgrade Spring Boot version to 2.0.3.Release and 1.5.14.Release
[ https://issues.apache.org/jira/browse/SCB-766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16550506#comment-16550506 ] ASF GitHub Bot commented on SCB-766: WillemJiang opened a new pull request #229: SCB-766 Upgraded spring boot version 1.5.13 and 2.0.3. URL: https://github.com/apache/incubator-servicecomb-saga/pull/229 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Upgrade Spring Boot version to 2.0.3.Release and 1.5.14.Release > --- > > Key: SCB-766 > URL: https://issues.apache.org/jira/browse/SCB-766 > Project: Apache ServiceComb > Issue Type: Task > Components: Saga >Reporter: Willem Jiang >Priority: Minor > > We should consider to upgrade the Spring Boot version to 2.0.3.Release and > 1.5.14.Release. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Assigned] (SCB-608) Add a check list section for verifying the kit to the release guide
[ https://issues.apache.org/jira/browse/SCB-608?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zhinan Lin reassigned SCB-608: -- Assignee: Yang Bo > Add a check list section for verifying the kit to the release guide > --- > > Key: SCB-608 > URL: https://issues.apache.org/jira/browse/SCB-608 > Project: Apache ServiceComb > Issue Type: Wish > Components: website >Reporter: Zhinan Lin >Assignee: Yang Bo >Priority: Minor > > As mentioned in the dev@ mail list [1], we wish someone that is formiliar > with verifying the release kit to add a check list section to release guide. > [1] > [https://www.mail-archive.com/dev@servicecomb.apache.org/msg04607.html|http://example.com] > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-608) Add a check list section for verifying the kit to the release guide
[ https://issues.apache.org/jira/browse/SCB-608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16550488#comment-16550488 ] Zhinan Lin commented on SCB-608: [~yangbor] Could you help to report the status?Thanks. > Add a check list section for verifying the kit to the release guide > --- > > Key: SCB-608 > URL: https://issues.apache.org/jira/browse/SCB-608 > Project: Apache ServiceComb > Issue Type: Wish > Components: website >Reporter: Zhinan Lin >Assignee: Yang Bo >Priority: Minor > > As mentioned in the dev@ mail list [1], we wish someone that is formiliar > with verifying the release kit to add a check list section to release guide. > [1] > [https://www.mail-archive.com/dev@servicecomb.apache.org/msg04607.html|http://example.com] > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Closed] (SCB-519) The Website can not be running up according to the chapter "How to run the site locally" of README.md
[ https://issues.apache.org/jira/browse/SCB-519?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zhinan Lin closed SCB-519. -- > The Website can not be running up according to the chapter "How to run the > site locally" of README.md > -- > > Key: SCB-519 > URL: https://issues.apache.org/jira/browse/SCB-519 > Project: Apache ServiceComb > Issue Type: Bug > Components: website >Reporter: Zhinan Lin >Assignee: Zhinan Lin >Priority: Major > > The Website can not running up if using default version of tools according to > the guide of README.md > # Lack of verison of tools > # Should be non-root -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Closed] (SCB-524) The images in the blog 'open-design' is not the original version
[ https://issues.apache.org/jira/browse/SCB-524?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zhinan Lin closed SCB-524. -- > The images in the blog 'open-design' is not the original version > > > Key: SCB-524 > URL: https://issues.apache.org/jira/browse/SCB-524 > Project: Apache ServiceComb > Issue Type: Bug > Components: website >Reporter: Zhinan Lin >Assignee: Zhinan Lin >Priority: Minor > > The images in the blog 'open-design' is not the original version, need to be > replaced. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-687) highway server not accept too many connection
[ https://issues.apache.org/jira/browse/SCB-687?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16550480#comment-16550480 ] ASF GitHub Bot commented on SCB-687: zhengyangyong commented on a change in pull request #824: [SCB-687] add highway server connection protection URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/824#discussion_r203969867 ## File path: integration-tests/spring-pojo-connection-limit-test/src/test/resources/microservice.yaml ## @@ -0,0 +1,29 @@ +## --- +## Licensed to the Apache Software Foundation (ASF) under one or more +## contributor license agreements. See the NOTICE file distributed with +## this work for additional information regarding copyright ownership. +## The ASF licenses this file to You under the Apache License, Version 2.0 +## (the "License"); you may not use this file except in compliance with +## the License. You may obtain a copy of the License at +## +## http://www.apache.org/licenses/LICENSE-2.0 +## +## Unless required by applicable law or agreed to in writing, software +## distributed under the License is distributed on an "AS IS" BASIS, +## WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +## See the License for the specific language governing permissions and +## limitations under the License. +## --- + +APPLICATION_ID: pojotest-it +service_description: + name: pojo + version: 0.0.4 +servicecomb: + service: +registry: + address: http://127.0.0.1:30100 + highway: +address: 0.0.0.0:7070 +server: + connection-limit: 0 Review comment: I think it is not necessary yet This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > highway server not accept too many connection > - > > Key: SCB-687 > URL: https://issues.apache.org/jira/browse/SCB-687 > Project: Apache ServiceComb > Issue Type: Sub-task > Components: Java-Chassis >Reporter: wujimin >Assignee: yangyongzheng >Priority: Major > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-687) highway server not accept too many connection
[ https://issues.apache.org/jira/browse/SCB-687?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16550479#comment-16550479 ] ASF GitHub Bot commented on SCB-687: zhengyangyong commented on a change in pull request #824: [SCB-687] add highway server connection protection URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/824#discussion_r203969719 ## File path: integration-tests/spring-pojo-connection-limit-test/src/test/resources/log4j.properties ## @@ -0,0 +1,20 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +# +log4j.rootLogger=INFO, stdout Review comment: may do it in https://issues.apache.org/jira/browse/SCB-683 later This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > highway server not accept too many connection > - > > Key: SCB-687 > URL: https://issues.apache.org/jira/browse/SCB-687 > Project: Apache ServiceComb > Issue Type: Sub-task > Components: Java-Chassis >Reporter: wujimin >Assignee: yangyongzheng >Priority: Major > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-687) highway server not accept too many connection
[
https://issues.apache.org/jira/browse/SCB-687?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16550380#comment-16550380
]
ASF GitHub Bot commented on SCB-687:
zhengyangyong commented on a change in pull request #824: [SCB-687] add highway
server connection protection
URL:
https://github.com/apache/incubator-servicecomb-java-chassis/pull/824#discussion_r203969513
##
File path:
foundations/foundation-vertx/src/main/java/org/apache/servicecomb/foundation/vertx/server/TcpServer.java
##
@@ -18,23 +18,35 @@
package org.apache.servicecomb.foundation.vertx.server;
import java.net.InetSocketAddress;
+import java.util.concurrent.atomic.AtomicInteger;
+import org.apache.servicecomb.foundation.common.event.EventManager;
import org.apache.servicecomb.foundation.common.net.URIEndpointObject;
import org.apache.servicecomb.foundation.ssl.SSLCustom;
import org.apache.servicecomb.foundation.ssl.SSLOption;
import org.apache.servicecomb.foundation.ssl.SSLOptionFactory;
import org.apache.servicecomb.foundation.vertx.AsyncResultCallback;
+import org.apache.servicecomb.foundation.vertx.ClientConnectedEvent;
import org.apache.servicecomb.foundation.vertx.VertxTLSBuilder;
+import com.netflix.config.DynamicPropertyFactory;
+
import io.vertx.core.Vertx;
import io.vertx.core.net.NetServer;
import io.vertx.core.net.NetServerOptions;
public class TcpServer {
private URIEndpointObject endpointObject;
+ private final AtomicInteger connectedCounter;
Review comment:
Done
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> highway server not accept too many connection
> -
>
> Key: SCB-687
> URL: https://issues.apache.org/jira/browse/SCB-687
> Project: Apache ServiceComb
> Issue Type: Sub-task
> Components: Java-Chassis
>Reporter: wujimin
>Assignee: yangyongzheng
>Priority: Major
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (SCB-687) highway server not accept too many connection
[
https://issues.apache.org/jira/browse/SCB-687?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16550379#comment-16550379
]
ASF GitHub Bot commented on SCB-687:
zhengyangyong commented on a change in pull request #824: [SCB-687] add highway
server connection protection
URL:
https://github.com/apache/incubator-servicecomb-java-chassis/pull/824#discussion_r203969498
##
File path:
foundations/foundation-vertx/src/main/java/org/apache/servicecomb/foundation/vertx/server/TcpServer.java
##
@@ -57,8 +69,18 @@ public void init(Vertx vertx, String sslKey,
AsyncResultCallback {
- TcpServerConnection connection = createTcpServerConnection();
- connection.init(netSocket);
+ if (connectedCounter.get() < connectionLimit) {
Review comment:
Done
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> highway server not accept too many connection
> -
>
> Key: SCB-687
> URL: https://issues.apache.org/jira/browse/SCB-687
> Project: Apache ServiceComb
> Issue Type: Sub-task
> Components: Java-Chassis
>Reporter: wujimin
>Assignee: yangyongzheng
>Priority: Major
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (SCB-687) highway server not accept too many connection
[ https://issues.apache.org/jira/browse/SCB-687?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16550459#comment-16550459 ] ASF GitHub Bot commented on SCB-687: zhengyangyong commented on a change in pull request #824: [SCB-687] add highway server connection protection URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/824#discussion_r203969719 ## File path: integration-tests/spring-pojo-connection-limit-test/src/test/resources/log4j.properties ## @@ -0,0 +1,20 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +# +log4j.rootLogger=INFO, stdout Review comment: may do it in https://issues.apache.org/jira/browse/SCB-683 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > highway server not accept too many connection > - > > Key: SCB-687 > URL: https://issues.apache.org/jira/browse/SCB-687 > Project: Apache ServiceComb > Issue Type: Sub-task > Components: Java-Chassis >Reporter: wujimin >Assignee: yangyongzheng >Priority: Major > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-763) Simplify Dynamic Config (Apollo) Integration Test in Java Chassis
[
https://issues.apache.org/jira/browse/SCB-763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16550363#comment-16550363
]
ASF GitHub Bot commented on SCB-763:
wujimin closed pull request #826: [SCB-763] simplify dynamic config (apollo)
integration test
URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/826
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/integration-tests/dynamic-config-tests/pom.xml
b/integration-tests/dynamic-config-tests/pom.xml
index f265cff2e..7ce0ca252 100644
--- a/integration-tests/dynamic-config-tests/pom.xml
+++ b/integration-tests/dynamic-config-tests/pom.xml
@@ -46,87 +46,4 @@
-
-
-
- docker
-
-
-
-io.fabric8
-docker-maven-plugin
-
-
-
- lijasonvip/apollodb:1.2
- apollo-db
-
-
- testtoken
-
-
- mysqld: ready for connections
-
-
- 3306
-
-
- 6
-
-
- apollodb.port:3306
-
-
-
-
- nobodyiam/apollo-quick-start
- apollo.servicecomb.apache.org
-
-
- apollo-db
-
-
- Portal started
-
-
- 8080
- 8070
-
-
- 12
-
-
- apollo.config:8080
- apollo.portal:8070
-
-
- mysql
-
-
-
-
-
-
-
-
-start
-pre-integration-test
-
- start
-
-
-
-stop
-post-integration-test
-
- stop
-
-
-
-
-
-
-
-
-
\ No newline at end of file
diff --git
a/integration-tests/dynamic-config-tests/src/test/java/org/apache/dynamicconfig/test/DynamicConfigurationIT.java
b/integration-tests/dynamic-config-tests/src/test/java/org/apache/dynamicconfig/test/DynamicConfigurationIT.java
index bf6161296..fbe557b12 100644
---
a/integration-tests/dynamic-config-tests/src/test/java/org/apache/dynamicconfig/test/DynamicConfigurationIT.java
+++
b/integration-tests/dynamic-config-tests/src/test/java/org/apache/dynamicconfig/test/DynamicConfigurationIT.java
@@ -17,112 +17,37 @@
package org.apache.dynamicconfig.test;
-import static java.util.concurrent.TimeUnit.SECONDS;
-import static org.awaitility.Awaitility.await;
-
-import java.util.HashMap;
-import java.util.Map;
-
import org.apache.servicecomb.foundation.common.utils.BeanUtils;
import org.apache.servicecomb.foundation.common.utils.Log4jUtils;
-import org.junit.After;
+import org.junit.AfterClass;
import org.junit.Assert;
import org.junit.BeforeClass;
import org.junit.Test;
-import org.slf4j.Logger;
-import org.slf4j.LoggerFactory;
-import org.springframework.http.HttpEntity;
-import org.springframework.http.HttpHeaders;
-import org.springframework.http.HttpMethod;
-import org.springframework.http.HttpStatus;
-import org.springframework.http.ResponseEntity;
-import org.springframework.web.client.RestTemplate;
import com.netflix.config.DynamicPropertyFactory;
-public class DynamicConfigurationIT {
- private static final Logger LOGGER =
LoggerFactory.getLogger(DynamicConfigurationIT.class);
-
- private static String url;
+import io.vertx.core.Vertx;
- private static String token;
-
- private static final HttpHeaders headers = new HttpHeaders();
-
- private static final RestTemplate rest = new RestTemplate();
+public class DynamicConfigurationIT {
+ private static Vertx vertx = null;
@BeforeClass
public static void setUp() throws Exception {
-LOGGER.info("testDynamicConfiguration set up");
+vertx = Vertx.vertx();
+vertx.deployVerticle(new SimApolloServer());
+
Log4jUtils.init();
BeanUtils.init();
-url =
DynamicPropertyFactory.getInstance().getStringPro
[jira] [Updated] (SCB-766) Upgrade Spring Boot version to 2.0.3.Release and 1.5.14.Release
[ https://issues.apache.org/jira/browse/SCB-766?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Willem Jiang updated SCB-766: - Description: We should consider to upgrade the Spring Boot version to 2.0.3.Release and 1.5.14.Release. (was: We should consider to upgrade the Spring Boot version to 2.0.3.Release and 1.5.13.Release.) > Upgrade Spring Boot version to 2.0.3.Release and 1.5.14.Release > --- > > Key: SCB-766 > URL: https://issues.apache.org/jira/browse/SCB-766 > Project: Apache ServiceComb > Issue Type: Task > Components: Saga >Reporter: Willem Jiang >Priority: Minor > > We should consider to upgrade the Spring Boot version to 2.0.3.Release and > 1.5.14.Release. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (SCB-766) Upgrade Spring Boot version to 2.0.3.Release and 1.5.14.Release
[ https://issues.apache.org/jira/browse/SCB-766?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Willem Jiang updated SCB-766: - Summary: Upgrade Spring Boot version to 2.0.3.Release and 1.5.14.Release (was: Upgrade Spring Boot version to 2.0.3.Release and 1.5.13.Release) > Upgrade Spring Boot version to 2.0.3.Release and 1.5.14.Release > --- > > Key: SCB-766 > URL: https://issues.apache.org/jira/browse/SCB-766 > Project: Apache ServiceComb > Issue Type: Task > Components: Saga >Reporter: Willem Jiang >Priority: Minor > > We should consider to upgrade the Spring Boot version to 2.0.3.Release and > 1.5.13.Release. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-763) Simplify Dynamic Config (Apollo) Integration Test in Java Chassis
[ https://issues.apache.org/jira/browse/SCB-763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16550348#comment-16550348 ] ASF GitHub Bot commented on SCB-763: coveralls commented on issue #826: [SCB-763] simplify dynamic config (apollo) integration test URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/826#issuecomment-406517268 [](https://coveralls.io/builds/18079694) Coverage decreased (-0.03%) to 87.095% when pulling **6bbb135dce5809bdc2ec0047f9a0c172046321b9 on zhengyangyong:SCB-763** into **82f098f67745af2659f5a1822f5edc988d9a3402 on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Simplify Dynamic Config (Apollo) Integration Test in Java Chassis > - > > Key: SCB-763 > URL: https://issues.apache.org/jira/browse/SCB-763 > Project: Apache ServiceComb > Issue Type: Improvement > Components: Java-Chassis >Affects Versions: java-chassis-1.0.0-m2 >Reporter: yangyongzheng >Assignee: yangyongzheng >Priority: Major > Fix For: java-chassis-1.0.0 > > > Simplify Dynamic Config (Apollo) Integration Test in Java Chassis > Discussion Is here： > https://lists.apache.org/thread.html/d6adfe1c23a68b00271cac70840b8ed531939d565f80fa49171f68c1@%3Cdev.servicecomb.apache.org%3E -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (SCB-766) Upgrade Spring Boot version to 2.0.3.Release and 1.5.13.Release
Willem Jiang created SCB-766: Summary: Upgrade Spring Boot version to 2.0.3.Release and 1.5.13.Release Key: SCB-766 URL: https://issues.apache.org/jira/browse/SCB-766 Project: Apache ServiceComb Issue Type: Task Components: Saga Reporter: Willem Jiang We should consider to upgrade the Spring Boot version to 2.0.3.Release and 1.5.13.Release. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-762) resolve eclipse compile warnings
[ https://issues.apache.org/jira/browse/SCB-762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16550336#comment-16550336 ] ASF GitHub Bot commented on SCB-762: wujimin commented on issue #823: [SCB-762] resolve eclipse compile warnings URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/823#issuecomment-406514970 that's because i triggered it again.. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > resolve eclipse compile warnings > > > Key: SCB-762 > URL: https://issues.apache.org/jira/browse/SCB-762 > Project: Apache ServiceComb > Issue Type: Task > Components: Java-Chassis >Reporter: wujimin >Assignee: wujimin >Priority: Major > Fix For: java-chassis-1.0.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-762) resolve eclipse compile warnings
[ https://issues.apache.org/jira/browse/SCB-762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16550335#comment-16550335 ] ASF GitHub Bot commented on SCB-762: WillemJiang commented on issue #823: [SCB-762] resolve eclipse compile warnings URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/823#issuecomment-406514764 The CI build just started, code coverage is updated. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > resolve eclipse compile warnings > > > Key: SCB-762 > URL: https://issues.apache.org/jira/browse/SCB-762 > Project: Apache ServiceComb > Issue Type: Task > Components: Java-Chassis >Reporter: wujimin >Assignee: wujimin >Priority: Major > Fix For: java-chassis-1.0.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-762) resolve eclipse compile warnings
[ https://issues.apache.org/jira/browse/SCB-762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16550329#comment-16550329 ] ASF GitHub Bot commented on SCB-762: wujimin commented on issue #823: [SCB-762] resolve eclipse compile warnings URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/823#issuecomment-406513528 CI passed, but show error here, what happened? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > resolve eclipse compile warnings > > > Key: SCB-762 > URL: https://issues.apache.org/jira/browse/SCB-762 > Project: Apache ServiceComb > Issue Type: Task > Components: Java-Chassis >Reporter: wujimin >Assignee: wujimin >Priority: Major > Fix For: java-chassis-1.0.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-762) resolve eclipse compile warnings
[ https://issues.apache.org/jira/browse/SCB-762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16550328#comment-16550328 ] ASF GitHub Bot commented on SCB-762: coveralls edited a comment on issue #823: [SCB-762] resolve eclipse compile warnings URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/823#issuecomment-406460006 [](https://coveralls.io/builds/18079541) Coverage increased (+0.03%) to 87.11% when pulling **363bff8908fad0b3618366279307369726f5953a on wujimin:resolve-eclipse-compile-warnings** into **8227f0ccbe7d69db51df1fc22b11a364662c1d9d on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > resolve eclipse compile warnings > > > Key: SCB-762 > URL: https://issues.apache.org/jira/browse/SCB-762 > Project: Apache ServiceComb > Issue Type: Task > Components: Java-Chassis >Reporter: wujimin >Assignee: wujimin >Priority: Major > Fix For: java-chassis-1.0.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (SCB-765) add connection count meter to metrics
wujimin created SCB-765: --- Summary: add connection count meter to metrics Key: SCB-765 URL: https://issues.apache.org/jira/browse/SCB-765 Project: Apache ServiceComb Issue Type: Sub-task Components: Java-Chassis Reporter: wujimin include consumer and producer, highway and rest -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Assigned] (SCB-721) Replace the Users of website to user docs
[ https://issues.apache.org/jira/browse/SCB-721?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] lidian reassigned SCB-721: -- Assignee: lidian > Replace the Users of website to user docs > -- > > Key: SCB-721 > URL: https://issues.apache.org/jira/browse/SCB-721 > Project: Apache ServiceComb > Issue Type: Improvement > Components: website >Reporter: Zhinan Lin >Assignee: lidian >Priority: Critical > > As we have renew a user docs in > [https://huaweicse.github.io/servicecomb-java-chassis-doc/]. > I suggest to replace the user part of website to this docs, my idea is: > # Create several items in [http://servicecomb.incubator.apache.org/users/] , > each item corresponds to a project, such as java-chassis, saga, servicecenter > # Change [https://huaweicse.github.io/servicecomb-java-chassis-doc/] to > [https://servicecomb.incubator.apache,org/servicecomb-java-chassis-doc/|https://huaweicse.github.io/servicecomb-java-chassis-doc/] > # link > [https://servicecomb.incubator.apache,org/servicecomb-java-chassis-doc/|https://huaweicse.github.io/servicecomb-java-chassis-doc/] > to the Java-chassis item under > [http://servicecomb.incubator.apache.org/users/] > If we do it like this way , we also should change user docs of the saga and > servicecenter to gitbook to keep the user experience consistent. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-687) highway server not accept too many connection
[
https://issues.apache.org/jira/browse/SCB-687?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16550320#comment-16550320
]
ASF GitHub Bot commented on SCB-687:
zhengyangyong commented on a change in pull request #824: [SCB-687] add highway
server connection protection
URL:
https://github.com/apache/incubator-servicecomb-java-chassis/pull/824#discussion_r203955424
##
File path:
foundations/foundation-vertx/src/main/java/org/apache/servicecomb/foundation/vertx/server/TcpServer.java
##
@@ -18,23 +18,35 @@
package org.apache.servicecomb.foundation.vertx.server;
import java.net.InetSocketAddress;
+import java.util.concurrent.atomic.AtomicInteger;
+import org.apache.servicecomb.foundation.common.event.EventManager;
import org.apache.servicecomb.foundation.common.net.URIEndpointObject;
import org.apache.servicecomb.foundation.ssl.SSLCustom;
import org.apache.servicecomb.foundation.ssl.SSLOption;
import org.apache.servicecomb.foundation.ssl.SSLOptionFactory;
import org.apache.servicecomb.foundation.vertx.AsyncResultCallback;
+import org.apache.servicecomb.foundation.vertx.ClientConnectedEvent;
import org.apache.servicecomb.foundation.vertx.VertxTLSBuilder;
+import com.netflix.config.DynamicPropertyFactory;
+
import io.vertx.core.Vertx;
import io.vertx.core.net.NetServer;
import io.vertx.core.net.NetServerOptions;
public class TcpServer {
private URIEndpointObject endpointObject;
+ private final AtomicInteger connectedCounter;
Review comment:
sorry, forgotten
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> highway server not accept too many connection
> -
>
> Key: SCB-687
> URL: https://issues.apache.org/jira/browse/SCB-687
> Project: Apache ServiceComb
> Issue Type: Sub-task
> Components: Java-Chassis
>Reporter: wujimin
>Assignee: yangyongzheng
>Priority: Major
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (SCB-763) Simplify Dynamic Config (Apollo) Integration Test in Java Chassis
[ https://issues.apache.org/jira/browse/SCB-763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16550322#comment-16550322 ] ASF GitHub Bot commented on SCB-763: zhengyangyong commented on a change in pull request #826: [SCB-763] simplify dynamic config (apollo) integration test URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/826#discussion_r203956373 ## File path: integration-tests/dynamic-config-tests/src/test/resources/microservice.yaml ## @@ -23,15 +23,11 @@ service_description: apollo: config: -serverUri: http://apollo.servicecomb.apache.org:8070 +serverUri: http://localhost:8080 Review comment: Done This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Simplify Dynamic Config (Apollo) Integration Test in Java Chassis > - > > Key: SCB-763 > URL: https://issues.apache.org/jira/browse/SCB-763 > Project: Apache ServiceComb > Issue Type: Improvement > Components: Java-Chassis >Affects Versions: java-chassis-1.0.0-m2 >Reporter: yangyongzheng >Assignee: yangyongzheng >Priority: Major > Fix For: java-chassis-1.0.0 > > > Simplify Dynamic Config (Apollo) Integration Test in Java Chassis > Discussion Is here： > https://lists.apache.org/thread.html/d6adfe1c23a68b00271cac70840b8ed531939d565f80fa49171f68c1@%3Cdev.servicecomb.apache.org%3E -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-687) highway server not accept too many connection
[
https://issues.apache.org/jira/browse/SCB-687?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16550317#comment-16550317
]
ASF GitHub Bot commented on SCB-687:
zhengyangyong commented on a change in pull request #824: [SCB-687] add highway
server connection protection
URL:
https://github.com/apache/incubator-servicecomb-java-chassis/pull/824#discussion_r203955004
##
File path:
integration-tests/spring-pojo-tests/src/test/java/org/apache/servicecomb/demo/pojo/test/ConnectionEventWatcher.java
##
@@ -0,0 +1,44 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.servicecomb.demo.pojo.test;
+
+import java.util.ArrayList;
+import java.util.List;
+
+import org.apache.servicecomb.foundation.vertx.ClientClosedEvent;
+import org.apache.servicecomb.foundation.vertx.ClientConnectedEvent;
+
+import com.google.common.eventbus.Subscribe;
+
+public class ConnectionEventWatcher {
+ private final List counters = new ArrayList<>();
+
+ public List getCounters() {
+return counters;
+ }
+
+ @Subscribe
Review comment:
only for test
```java
Assert.assertArrayEquals("check connection count change", new Integer[] {1,
0}, watcher.getCounters().toArray());
```
watcher will receive a connection connected event when consumer calling
event.getTotalConnectedCount() = 1
and when
```java
SCBEngine.getInstance().destroy();
```
watcher will receive a connection close event
event.getTotalConnectedCount() = 0
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> highway server not accept too many connection
> -
>
> Key: SCB-687
> URL: https://issues.apache.org/jira/browse/SCB-687
> Project: Apache ServiceComb
> Issue Type: Sub-task
> Components: Java-Chassis
>Reporter: wujimin
>Assignee: yangyongzheng
>Priority: Major
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (SCB-763) Simplify Dynamic Config (Apollo) Integration Test in Java Chassis
[ https://issues.apache.org/jira/browse/SCB-763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16550314#comment-16550314 ] ASF GitHub Bot commented on SCB-763: wujimin commented on a change in pull request #826: [SCB-763] simplify dynamic config (apollo) integration test URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/826#discussion_r203954789 ## File path: integration-tests/dynamic-config-tests/src/test/resources/microservice.yaml ## @@ -23,15 +23,11 @@ service_description: apollo: config: -serverUri: http://apollo.servicecomb.apache.org:8070 +serverUri: http://localhost:8080 Review comment: it's better to use another not normal port, that's make developers run the case in IDE easier. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Simplify Dynamic Config (Apollo) Integration Test in Java Chassis > - > > Key: SCB-763 > URL: https://issues.apache.org/jira/browse/SCB-763 > Project: Apache ServiceComb > Issue Type: Improvement > Components: Java-Chassis >Affects Versions: java-chassis-1.0.0-m2 >Reporter: yangyongzheng >Assignee: yangyongzheng >Priority: Major > Fix For: java-chassis-1.0.0 > > > Simplify Dynamic Config (Apollo) Integration Test in Java Chassis > Discussion Is here： > https://lists.apache.org/thread.html/d6adfe1c23a68b00271cac70840b8ed531939d565f80fa49171f68c1@%3Cdev.servicecomb.apache.org%3E -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-687) highway server not accept too many connection
[
https://issues.apache.org/jira/browse/SCB-687?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16550310#comment-16550310
]
ASF GitHub Bot commented on SCB-687:
wujimin commented on a change in pull request #824: [SCB-687] add highway
server connection protection
URL:
https://github.com/apache/incubator-servicecomb-java-chassis/pull/824#discussion_r203954150
##
File path:
foundations/foundation-vertx/src/main/java/org/apache/servicecomb/foundation/vertx/server/TcpServer.java
##
@@ -18,23 +18,35 @@
package org.apache.servicecomb.foundation.vertx.server;
import java.net.InetSocketAddress;
+import java.util.concurrent.atomic.AtomicInteger;
+import org.apache.servicecomb.foundation.common.event.EventManager;
import org.apache.servicecomb.foundation.common.net.URIEndpointObject;
import org.apache.servicecomb.foundation.ssl.SSLCustom;
import org.apache.servicecomb.foundation.ssl.SSLOption;
import org.apache.servicecomb.foundation.ssl.SSLOptionFactory;
import org.apache.servicecomb.foundation.vertx.AsyncResultCallback;
+import org.apache.servicecomb.foundation.vertx.ClientConnectedEvent;
import org.apache.servicecomb.foundation.vertx.VertxTLSBuilder;
+import com.netflix.config.DynamicPropertyFactory;
+
import io.vertx.core.Vertx;
import io.vertx.core.net.NetServer;
import io.vertx.core.net.NetServerOptions;
public class TcpServer {
private URIEndpointObject endpointObject;
+ private final AtomicInteger connectedCounter;
Review comment:
if serivcecomb.highway.thread-count is n, then HighwayServerVerticle
instance count is n
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> highway server not accept too many connection
> -
>
> Key: SCB-687
> URL: https://issues.apache.org/jira/browse/SCB-687
> Project: Apache ServiceComb
> Issue Type: Sub-task
> Components: Java-Chassis
>Reporter: wujimin
>Assignee: yangyongzheng
>Priority: Major
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (SCB-687) highway server not accept too many connection
[
https://issues.apache.org/jira/browse/SCB-687?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16550308#comment-16550308
]
ASF GitHub Bot commented on SCB-687:
wujimin commented on a change in pull request #824: [SCB-687] add highway
server connection protection
URL:
https://github.com/apache/incubator-servicecomb-java-chassis/pull/824#discussion_r203953876
##
File path:
integration-tests/spring-pojo-tests/src/test/java/org/apache/servicecomb/demo/pojo/test/ConnectionEventWatcher.java
##
@@ -0,0 +1,44 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.servicecomb.demo.pojo.test;
+
+import java.util.ArrayList;
+import java.util.List;
+
+import org.apache.servicecomb.foundation.vertx.ClientClosedEvent;
+import org.apache.servicecomb.foundation.vertx.ClientConnectedEvent;
+
+import com.google.common.eventbus.Subscribe;
+
+public class ConnectionEventWatcher {
+ private final List counters = new ArrayList<>();
+
+ public List getCounters() {
+return counters;
+ }
+
+ @Subscribe
Review comment:
what's this watcher purpose?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> highway server not accept too many connection
> -
>
> Key: SCB-687
> URL: https://issues.apache.org/jira/browse/SCB-687
> Project: Apache ServiceComb
> Issue Type: Sub-task
> Components: Java-Chassis
>Reporter: wujimin
>Assignee: yangyongzheng
>Priority: Major
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (SCB-687) highway server not accept too many connection
[
https://issues.apache.org/jira/browse/SCB-687?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16550307#comment-16550307
]
ASF GitHub Bot commented on SCB-687:
wujimin commented on a change in pull request #824: [SCB-687] add highway
server connection protection
URL:
https://github.com/apache/incubator-servicecomb-java-chassis/pull/824#discussion_r203953811
##
File path:
integration-tests/spring-pojo-tests/src/test/java/org/apache/servicecomb/demo/pojo/test/ConnectionEventWatcher.java
##
@@ -0,0 +1,44 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.servicecomb.demo.pojo.test;
+
+import java.util.ArrayList;
+import java.util.List;
+
+import org.apache.servicecomb.foundation.vertx.ClientClosedEvent;
+import org.apache.servicecomb.foundation.vertx.ClientConnectedEvent;
+
+import com.google.common.eventbus.Subscribe;
+
+public class ConnectionEventWatcher {
+ private final List counters = new ArrayList<>();
+
+ public List getCounters() {
+return counters;
+ }
+
+ @Subscribe
Review comment:
all eventloop thread will sync invoke this
it's not a good sample.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> highway server not accept too many connection
> -
>
> Key: SCB-687
> URL: https://issues.apache.org/jira/browse/SCB-687
> Project: Apache ServiceComb
> Issue Type: Sub-task
> Components: Java-Chassis
>Reporter: wujimin
>Assignee: yangyongzheng
>Priority: Major
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (SCB-687) highway server not accept too many connection
[ https://issues.apache.org/jira/browse/SCB-687?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16550305#comment-16550305 ] ASF GitHub Bot commented on SCB-687: wujimin commented on a change in pull request #824: [SCB-687] add highway server connection protection URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/824#discussion_r203953673 ## File path: integration-tests/spring-pojo-connection-limit-test/src/test/resources/microservice.yaml ## @@ -0,0 +1,29 @@ +## --- +## Licensed to the Apache Software Foundation (ASF) under one or more +## contributor license agreements. See the NOTICE file distributed with +## this work for additional information regarding copyright ownership. +## The ASF licenses this file to You under the Apache License, Version 2.0 +## (the "License"); you may not use this file except in compliance with +## the License. You may obtain a copy of the License at +## +## http://www.apache.org/licenses/LICENSE-2.0 +## +## Unless required by applicable law or agreed to in writing, software +## distributed under the License is distributed on an "AS IS" BASIS, +## WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +## See the License for the specific language governing permissions and +## limitations under the License. +## --- + +APPLICATION_ID: pojotest-it +service_description: + name: pojo + version: 0.0.4 +servicecomb: + service: +registry: + address: http://127.0.0.1:30100 + highway: +address: 0.0.0.0:7070 +server: + connection-limit: 0 Review comment: consider dynamic update? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > highway server not accept too many connection > - > > Key: SCB-687 > URL: https://issues.apache.org/jira/browse/SCB-687 > Project: Apache ServiceComb > Issue Type: Sub-task > Components: Java-Chassis >Reporter: wujimin >Assignee: yangyongzheng >Priority: Major > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-687) highway server not accept too many connection
[ https://issues.apache.org/jira/browse/SCB-687?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16550303#comment-16550303 ] ASF GitHub Bot commented on SCB-687: wujimin commented on a change in pull request #824: [SCB-687] add highway server connection protection URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/824#discussion_r203953556 ## File path: integration-tests/spring-pojo-connection-limit-test/src/test/resources/log4j.properties ## @@ -0,0 +1,20 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +# +log4j.rootLogger=INFO, stdout Review comment: new projects switch to logback? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > highway server not accept too many connection > - > > Key: SCB-687 > URL: https://issues.apache.org/jira/browse/SCB-687 > Project: Apache ServiceComb > Issue Type: Sub-task > Components: Java-Chassis >Reporter: wujimin >Assignee: yangyongzheng >Priority: Major > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-687) highway server not accept too many connection
[
https://issues.apache.org/jira/browse/SCB-687?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16550304#comment-16550304
]
ASF GitHub Bot commented on SCB-687:
zhengyangyong commented on a change in pull request #824: [SCB-687] add highway
server connection protection
URL:
https://github.com/apache/incubator-servicecomb-java-chassis/pull/824#discussion_r203953650
##
File path:
foundations/foundation-vertx/src/main/java/org/apache/servicecomb/foundation/vertx/server/TcpServer.java
##
@@ -18,23 +18,35 @@
package org.apache.servicecomb.foundation.vertx.server;
import java.net.InetSocketAddress;
+import java.util.concurrent.atomic.AtomicInteger;
+import org.apache.servicecomb.foundation.common.event.EventManager;
import org.apache.servicecomb.foundation.common.net.URIEndpointObject;
import org.apache.servicecomb.foundation.ssl.SSLCustom;
import org.apache.servicecomb.foundation.ssl.SSLOption;
import org.apache.servicecomb.foundation.ssl.SSLOptionFactory;
import org.apache.servicecomb.foundation.vertx.AsyncResultCallback;
+import org.apache.servicecomb.foundation.vertx.ClientConnectedEvent;
import org.apache.servicecomb.foundation.vertx.VertxTLSBuilder;
+import com.netflix.config.DynamicPropertyFactory;
+
import io.vertx.core.Vertx;
import io.vertx.core.net.NetServer;
import io.vertx.core.net.NetServerOptions;
public class TcpServer {
private URIEndpointObject endpointObject;
+ private final AtomicInteger connectedCounter;
Review comment:
I think we only deploy one HighwayServerVerticle instance (as a spring
bean), so may not problem ?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> highway server not accept too many connection
> -
>
> Key: SCB-687
> URL: https://issues.apache.org/jira/browse/SCB-687
> Project: Apache ServiceComb
> Issue Type: Sub-task
> Components: Java-Chassis
>Reporter: wujimin
>Assignee: yangyongzheng
>Priority: Major
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
