[jira] [Commented] (SCB-1047) microservice.yaml service_description.version support format xxx.xx.xxx.xxx
[
https://issues.apache.org/jira/browse/SCB-1047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16701436#comment-16701436
]
ASF GitHub Bot commented on SCB-1047:
-
heyile commented on a change in pull request #1013: [SCB-1047]microservice.yaml
service_description.version support form…
URL:
https://github.com/apache/servicecomb-java-chassis/pull/1013#discussion_r236951927
##
File path: core/src/test/java/org/apache/servicecomb/core/TestConfig.java
##
@@ -53,7 +53,7 @@ public void testConstants() {
Assert.assertEquals("rest", Const.RESTFUL);
Assert.assertEquals("", Const.ANY_TRANSPORT);
Assert.assertEquals("latest", Const.VERSION_RULE_LATEST);
-Assert.assertEquals("0.0.0+", Const.DEFAULT_VERSION_RULE);
+Assert.assertEquals("0.0.0.0+", Const.DEFAULT_VERSION_RULE);
Review comment:
As the const DefinitionConst#VERSION_RULE_ALL is changed from "0.0.0+" to
"0.0.0.0+",
I change the value of Const.DEFAULT_VERSION_RULE. you means that I shouldn't
change the const
DefinitionConst#VERSION_RULE_ALL ?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> microservice.yaml service_description.version support format xxx.xx.xxx.xxx
>
>
> Key: SCB-1047
> URL: https://issues.apache.org/jira/browse/SCB-1047
> Project: Apache ServiceComb
> Issue Type: Improvement
> Components: Java-Chassis
>Reporter: 何一乐
>Assignee: 何一乐
>Priority: Major
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Created] (SCB-1053) Batch microservices instances discovery API
little-cui created SCB-1053: --- Summary: Batch microservices instances discovery API Key: SCB-1053 URL: https://issues.apache.org/jira/browse/SCB-1053 Project: Apache ServiceComb Issue Type: Improvement Components: Service-Center Reporter: little-cui Assignee: little-cui Fix For: service-center-1.2.0 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-1047) microservice.yaml service_description.version support format xxx.xx.xxx.xxx
[
https://issues.apache.org/jira/browse/SCB-1047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16701370#comment-16701370
]
ASF GitHub Bot commented on SCB-1047:
-
liubao68 commented on a change in pull request #1013:
[SCB-1047]microservice.yaml service_description.version support form…
URL:
https://github.com/apache/servicecomb-java-chassis/pull/1013#discussion_r236931523
##
File path: core/src/test/java/org/apache/servicecomb/core/TestConfig.java
##
@@ -53,7 +53,7 @@ public void testConstants() {
Assert.assertEquals("rest", Const.RESTFUL);
Assert.assertEquals("", Const.ANY_TRANSPORT);
Assert.assertEquals("latest", Const.VERSION_RULE_LATEST);
-Assert.assertEquals("0.0.0+", Const.DEFAULT_VERSION_RULE);
+Assert.assertEquals("0.0.0.0+", Const.DEFAULT_VERSION_RULE);
Review comment:
Implement this feature, we must make sure the old version rule works. Can
you add new test cases for 4 bit version without change any old test case?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> microservice.yaml service_description.version support format xxx.xx.xxx.xxx
>
>
> Key: SCB-1047
> URL: https://issues.apache.org/jira/browse/SCB-1047
> Project: Apache ServiceComb
> Issue Type: Improvement
> Components: Java-Chassis
>Reporter: 何一乐
>Assignee: 何一乐
>Priority: Major
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (SCB-1047) microservice.yaml service_description.version support format xxx.xx.xxx.xxx
[
https://issues.apache.org/jira/browse/SCB-1047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16701369#comment-16701369
]
ASF GitHub Bot commented on SCB-1047:
-
liubao68 commented on a change in pull request #1013:
[SCB-1047]microservice.yaml service_description.version support form…
URL:
https://github.com/apache/servicecomb-java-chassis/pull/1013#discussion_r236931523
##
File path: core/src/test/java/org/apache/servicecomb/core/TestConfig.java
##
@@ -53,7 +53,7 @@ public void testConstants() {
Assert.assertEquals("rest", Const.RESTFUL);
Assert.assertEquals("", Const.ANY_TRANSPORT);
Assert.assertEquals("latest", Const.VERSION_RULE_LATEST);
-Assert.assertEquals("0.0.0+", Const.DEFAULT_VERSION_RULE);
+Assert.assertEquals("0.0.0.0+", Const.DEFAULT_VERSION_RULE);
Review comment:
Implement this feature, we must make sure the old version rule works. Can
you add new test cases for 4 bit version with change any old test case?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> microservice.yaml service_description.version support format xxx.xx.xxx.xxx
>
>
> Key: SCB-1047
> URL: https://issues.apache.org/jira/browse/SCB-1047
> Project: Apache ServiceComb
> Issue Type: Improvement
> Components: Java-Chassis
>Reporter: 何一乐
>Assignee: 何一乐
>Priority: Major
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (SCB-1051) when interface set produces=text/plain;charset=utf-8. and consumers set accept = text/plain,will cause error
[
https://issues.apache.org/jira/browse/SCB-1051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16701368#comment-16701368
]
ASF GitHub Bot commented on SCB-1051:
-
liubao68 commented on a change in pull request #1015: [SCB-1051]when interface
set produces=text/plain;charset=utf-8. and c…
URL:
https://github.com/apache/servicecomb-java-chassis/pull/1015#discussion_r236931110
##
File path:
common/common-rest/src/test/java/org/apache/servicecomb/common/rest/definition/TestRestOperationMeta.java
##
@@ -147,6 +147,18 @@ public void testCreateProduceProcessorsTextAndWildcard() {
MediaType.APPLICATION_JSON + "," + MediaType.APPLICATION_XML + ","
+ MediaType.WILDCARD));
}
+ @Test
+ public void testCreateProduceProcessorsWithSemicolon() {
Review comment:
Can you add an integration tests for this? This is an user case, add an
integration tests is better.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> when interface set produces=text/plain;charset=utf-8. and consumers set
> accept = text/plain,will cause error
>
>
> Key: SCB-1051
> URL: https://issues.apache.org/jira/browse/SCB-1051
> Project: Apache ServiceComb
> Issue Type: Improvement
> Components: Java-Chassis
>Reporter: 何一乐
>Assignee: 何一乐
>Priority: Major
> Attachments: screenshot-1.png
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (SCB-1052) import zap logger without binding go version
[ https://issues.apache.org/jira/browse/SCB-1052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16701309#comment-16701309 ] ASF GitHub Bot commented on SCB-1052: - coveralls commented on issue #501: SCB-1052 Import zap logger without binding go version URL: https://github.com/apache/servicecomb-service-center/pull/501#issuecomment-442292688 [](https://coveralls.io/builds/20327330) Coverage decreased (-0.1%) to 61.655% when pulling **a0ed616abee55d3ebfc50763180bd78e8567145a on little-cui:zap** into **7aceab7f2ccb804089627bfdb82e7d7a62ab259a on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > import zap logger without binding go version > > > Key: SCB-1052 > URL: https://issues.apache.org/jira/browse/SCB-1052 > Project: Apache ServiceComb > Issue Type: Improvement > Components: Service-Center >Reporter: little-cui >Assignee: little-cui >Priority: Major > Fix For: service-center-1.2.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-1052) import zap logger without binding go version
[ https://issues.apache.org/jira/browse/SCB-1052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16701306#comment-16701306 ] ASF GitHub Bot commented on SCB-1052: - codecov-io commented on issue #501: SCB-1052 Import zap logger without binding go version URL: https://github.com/apache/servicecomb-service-center/pull/501#issuecomment-442292501 # [Codecov](https://codecov.io/gh/apache/servicecomb-service-center/pull/501?src=pr&el=h1) Report > Merging [#501](https://codecov.io/gh/apache/servicecomb-service-center/pull/501?src=pr&el=desc) into [master](https://codecov.io/gh/apache/servicecomb-service-center/commit/7aceab7f2ccb804089627bfdb82e7d7a62ab259a?src=pr&el=desc) will **decrease** coverage by `0.03%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/servicecomb-service-center/pull/501?src=pr&el=tree) ```diff @@Coverage Diff @@ ## master #501 +/- ## == - Coverage 59.25% 59.21% -0.04% == Files 166 166 Lines 1388013880 == - Hits 8224 8219 -5 - Misses 5074 5075 +1 - Partials 582 586 +4 ``` | [Impacted Files](https://codecov.io/gh/apache/servicecomb-service-center/pull/501?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [pkg/log/log\_zap.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/501/diff?src=pr&el=tree#diff-cGtnL2xvZy9sb2dfemFwLmdv) | `100% <ø> (ø)` | | | [pkg/etcdsync/mutex.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/501/diff?src=pr&el=tree#diff-cGtnL2V0Y2RzeW5jL211dGV4Lmdv) | `61.29% <0%> (-5.38%)` | :arrow_down: | | [pkg/tlsutil/tlsutil.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/501/diff?src=pr&el=tree#diff-cGtnL3Rsc3V0aWwvdGxzdXRpbC5nbw==) | `73.58% <0%> (-0.95%)` | :arrow_down: | | [pkg/log/logrotate.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/501/diff?src=pr&el=tree#diff-cGtnL2xvZy9sb2dyb3RhdGUuZ28=) | `33.71% <0%> (-0.58%)` | :arrow_down: | | [server/govern/service.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/501/diff?src=pr&el=tree#diff-c2VydmVyL2dvdmVybi9zZXJ2aWNlLmdv) | `72.6% <0%> (-0.34%)` | :arrow_down: | | [server/broker/util.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/501/diff?src=pr&el=tree#diff-c2VydmVyL2Jyb2tlci91dGlsLmdv) | `53.2% <0%> (-0.27%)` | :arrow_down: | | [server/broker/service.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/501/diff?src=pr&el=tree#diff-c2VydmVyL2Jyb2tlci9zZXJ2aWNlLmdv) | `57.94% <0%> (+0.15%)` | :arrow_up: | | [server/service/notification/websocket.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/501/diff?src=pr&el=tree#diff-c2VydmVyL3NlcnZpY2Uvbm90aWZpY2F0aW9uL3dlYnNvY2tldC5nbw==) | `84.51% <0%> (+0.64%)` | :arrow_up: | | [pkg/gopool/goroutines.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/501/diff?src=pr&el=tree#diff-cGtnL2dvcG9vbC9nb3JvdXRpbmVzLmdv) | `100% <0%> (+2.63%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/servicecomb-service-center/pull/501?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/servicecomb-service-center/pull/501?src=pr&el=footer). Last update [7aceab7...a0ed616](https://codecov.io/gh/apache/servicecomb-service-center/pull/501?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > import zap logger without binding go version > > > Key: SCB-1052 > URL: https://issues.apache.org/jira/browse/SCB-1052 > Project: Apache ServiceComb > Issue Type: Improvement > Components: Service-Center >Reporter: little-cui >Assignee: little-cui >Priority: Major > Fix For: service-center-1.2.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#7
[jira] [Commented] (SCB-1052) import zap logger without binding go version
[ https://issues.apache.org/jira/browse/SCB-1052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16701273#comment-16701273 ] ASF GitHub Bot commented on SCB-1052: - little-cui opened a new pull request #501: SCB-1052 Import zap logger without binding go version URL: https://github.com/apache/servicecomb-service-center/pull/501 Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/SCB) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [ ] Each commit in the pull request should have a meaningful subject line and body. - [ ] Format the pull request title like `[SCB-XXX] Fixes bug in ApproximateQuantiles`, where you replace `SCB-XXX` with the appropriate JIRA issue. - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [ ] Run `go build` `go test` `go fmt` `go vet` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). --- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > import zap logger without binding go version > > > Key: SCB-1052 > URL: https://issues.apache.org/jira/browse/SCB-1052 > Project: Apache ServiceComb > Issue Type: Improvement > Components: Service-Center >Reporter: little-cui >Assignee: little-cui >Priority: Major > Fix For: service-center-1.2.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (SCB-1052) import zap logger without binding go version
little-cui created SCB-1052: --- Summary: import zap logger without binding go version Key: SCB-1052 URL: https://issues.apache.org/jira/browse/SCB-1052 Project: Apache ServiceComb Issue Type: Improvement Components: Service-Center Reporter: little-cui Assignee: little-cui Fix For: service-center-1.2.0 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-1050) Metrics cache does not clean
[ https://issues.apache.org/jira/browse/SCB-1050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16700557#comment-16700557 ] ASF GitHub Bot commented on SCB-1050: - coveralls commented on issue #500: SCB-1050 Metrics cache does not clean URL: https://github.com/apache/servicecomb-service-center/pull/500#issuecomment-442092784 [](https://coveralls.io/builds/20314714) Coverage decreased (-0.04%) to 61.735% when pulling **083dbd14e9e40b60a493eb5e55a10b46aaac41e7 on little-cui:bug** into **7aceab7f2ccb804089627bfdb82e7d7a62ab259a on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Metrics cache does not clean > > > Key: SCB-1050 > URL: https://issues.apache.org/jira/browse/SCB-1050 > Project: Apache ServiceComb > Issue Type: Bug > Components: Service-Center >Reporter: little-cui >Assignee: little-cui >Priority: Major > Fix For: service-center-1.2.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (SCB-1051) when interface set produces=text/plain;charset=utf-8. and consumers set accept = text/plain,will cause error
[ https://issues.apache.org/jira/browse/SCB-1051?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] 何一乐 updated SCB-1051: - Attachment: screenshot-1.png > when interface set produces=text/plain;charset=utf-8. and consumers set > accept = text/plain,will cause error > > > Key: SCB-1051 > URL: https://issues.apache.org/jira/browse/SCB-1051 > Project: Apache ServiceComb > Issue Type: Improvement > Components: Java-Chassis >Reporter: 何一乐 >Assignee: 何一乐 >Priority: Major > Attachments: screenshot-1.png > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-1050) Metrics cache does not clean
[ https://issues.apache.org/jira/browse/SCB-1050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16700520#comment-16700520 ] ASF GitHub Bot commented on SCB-1050: - little-cui opened a new pull request #500: SCB-1050 Metrics cache does not clean URL: https://github.com/apache/servicecomb-service-center/pull/500 Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/SCB) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [ ] Each commit in the pull request should have a meaningful subject line and body. - [ ] Format the pull request title like `[SCB-XXX] Fixes bug in ApproximateQuantiles`, where you replace `SCB-XXX` with the appropriate JIRA issue. - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [ ] Run `go build` `go test` `go fmt` `go vet` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). --- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Metrics cache does not clean > > > Key: SCB-1050 > URL: https://issues.apache.org/jira/browse/SCB-1050 > Project: Apache ServiceComb > Issue Type: Bug > Components: Service-Center >Reporter: little-cui >Assignee: little-cui >Priority: Major > Fix For: service-center-1.2.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-1051) when interface set produces=text/plain;charset=utf-8. and consumers set accept = text/plain,will cause error
[ https://issues.apache.org/jira/browse/SCB-1051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16700516#comment-16700516 ] ASF GitHub Bot commented on SCB-1051: - heyile opened a new pull request #1015: [SCB-1051]when interface set produces=text/plain;charset=utf-8. and c… URL: https://github.com/apache/servicecomb-java-chassis/pull/1015 …onsumers set accept = text/plain,will cause error Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/SCB) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [ ] Each commit in the pull request should have a meaningful subject line and body. - [ ] Format the pull request title like `[SCB-XXX] Fixes bug in ApproximateQuantiles`, where you replace `SCB-XXX` with the appropriate JIRA issue. - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [ ] Run `mvn clean install` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). --- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > when interface set produces=text/plain;charset=utf-8. and consumers set > accept = text/plain,will cause error > > > Key: SCB-1051 > URL: https://issues.apache.org/jira/browse/SCB-1051 > Project: Apache ServiceComb > Issue Type: Improvement > Components: Java-Chassis >Reporter: 何一乐 >Assignee: 何一乐 >Priority: Major > Attachments: screenshot-1.png > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (SCB-1051) when interface set produces=text/plain;charset=utf-8. and consumers set accept = text/plain,will cause error
何一乐 created SCB-1051: Summary: when interface set produces=text/plain;charset=utf-8. and consumers set accept = text/plain,will cause error Key: SCB-1051 URL: https://issues.apache.org/jira/browse/SCB-1051 Project: Apache ServiceComb Issue Type: Improvement Components: Java-Chassis Reporter: 何一乐 Assignee: 何一乐 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (SCB-1050) Metrics cache does not clean
little-cui created SCB-1050: --- Summary: Metrics cache does not clean Key: SCB-1050 URL: https://issues.apache.org/jira/browse/SCB-1050 Project: Apache ServiceComb Issue Type: Bug Components: Service-Center Reporter: little-cui Assignee: little-cui Fix For: service-center-1.2.0 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (SCB-1049) Alarm center
[ https://issues.apache.org/jira/browse/SCB-1049?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] little-cui updated SCB-1049: Fix Version/s: service-center-1.2.0 > Alarm center > > > Key: SCB-1049 > URL: https://issues.apache.org/jira/browse/SCB-1049 > Project: Apache ServiceComb > Issue Type: New Feature > Components: Service-Center >Reporter: little-cui >Assignee: little-cui >Priority: Major > Fix For: service-center-1.2.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-1047) microservice.yaml service_description.version support format xxx.xx.xxx.xxx
[ https://issues.apache.org/jira/browse/SCB-1047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16700386#comment-16700386 ] ASF GitHub Bot commented on SCB-1047: - coveralls edited a comment on issue #1013: [SCB-1047]microservice.yaml service_description.version support form… URL: https://github.com/apache/servicecomb-java-chassis/pull/1013#issuecomment-441953809 [](https://coveralls.io/builds/20312103) Coverage decreased (-0.002%) to 86.772% when pulling **63641bf08974c66324477600bf6742dea2e78ba2 on heyile:versionFour** into **47d4773f3db7444e07fa2bb5bf87ac0a0387855f on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > microservice.yaml service_description.version support format xxx.xx.xxx.xxx > > > Key: SCB-1047 > URL: https://issues.apache.org/jira/browse/SCB-1047 > Project: Apache ServiceComb > Issue Type: Improvement > Components: Java-Chassis >Reporter: 何一乐 >Assignee: 何一乐 >Priority: Major > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Resolved] (SCB-1032) Support compress the response
[ https://issues.apache.org/jira/browse/SCB-1032?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] little-cui resolved SCB-1032. - Resolution: Fixed > Support compress the response > - > > Key: SCB-1032 > URL: https://issues.apache.org/jira/browse/SCB-1032 > Project: Apache ServiceComb > Issue Type: New Feature > Components: Service-Center >Reporter: little-cui >Assignee: little-cui >Priority: Major > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-1047) microservice.yaml service_description.version support format xxx.xx.xxx.xxx
[ https://issues.apache.org/jira/browse/SCB-1047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16700365#comment-16700365 ] ASF GitHub Bot commented on SCB-1047: - coveralls edited a comment on issue #1013: [SCB-1047]microservice.yaml service_description.version support form… URL: https://github.com/apache/servicecomb-java-chassis/pull/1013#issuecomment-441953809 [](https://coveralls.io/builds/20311753) Coverage decreased (-0.001%) to 86.773% when pulling **63641bf08974c66324477600bf6742dea2e78ba2 on heyile:versionFour** into **47d4773f3db7444e07fa2bb5bf87ac0a0387855f on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > microservice.yaml service_description.version support format xxx.xx.xxx.xxx > > > Key: SCB-1047 > URL: https://issues.apache.org/jira/browse/SCB-1047 > Project: Apache ServiceComb > Issue Type: Improvement > Components: Java-Chassis >Reporter: 何一乐 >Assignee: 何一乐 >Priority: Major > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (SCB-1049) Alarm center
little-cui created SCB-1049: --- Summary: Alarm center Key: SCB-1049 URL: https://issues.apache.org/jira/browse/SCB-1049 Project: Apache ServiceComb Issue Type: New Feature Components: Service-Center Reporter: little-cui Assignee: little-cui -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-925) Springmvc, when have defaultValue, required should be false
[
https://issues.apache.org/jira/browse/SCB-925?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16700307#comment-16700307
]
ASF GitHub Bot commented on SCB-925:
liubao68 commented on a change in pull request #1004: [SCB-925] Springmvc, when
have defaultValue, required should be false, when param not exist, should check
isRequired
URL:
https://github.com/apache/servicecomb-java-chassis/pull/1004#discussion_r236632935
##
File path:
common/common-rest/src/test/java/org/apache/servicecomb/common/rest/codec/param/TestCookieProcessor.java
##
@@ -67,8 +71,12 @@ public void testGetValueNoCookies() throws Exception {
};
CookieProcessor processor = createProcessor("c1", String.class);
-Object value = processor.getValue(request);
-Assert.assertNull(value);
+try {
+ processor.getValue(request);
Review comment:
This is a behavior change. And it's better to add a new test case which have
the same meaning as the old test case.
CookieProcessor processor = createProcessor("c1", String.class, null, false);
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Springmvc, when have defaultValue, required should be false
> ---
>
> Key: SCB-925
> URL: https://issues.apache.org/jira/browse/SCB-925
> Project: Apache ServiceComb
> Issue Type: Bug
> Components: Java-Chassis
>Reporter: WeiChao
>Assignee: WeiChao
>Priority: Major
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (SCB-925) Springmvc, when have defaultValue, required should be false
[
https://issues.apache.org/jira/browse/SCB-925?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16700304#comment-16700304
]
ASF GitHub Bot commented on SCB-925:
liubao68 commented on a change in pull request #1004: [SCB-925] Springmvc, when
have defaultValue, required should be false, when param not exist, should check
isRequired
URL:
https://github.com/apache/servicecomb-java-chassis/pull/1004#discussion_r236631717
##
File path:
common/common-rest/src/main/java/org/apache/servicecomb/common/rest/codec/param/QueryProcessorCreator.java
##
@@ -68,10 +75,7 @@ public Object getValue(HttpServletRequest request) throws
Exception {
}
}
if (value == null) {
- Object defaultValue = getDefaultValue();
- if (!ignoreDefaultValue && defaultValue != null) {
Review comment:
ignoreDefaultValue feature should not be deleted, keep it.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Springmvc, when have defaultValue, required should be false
> ---
>
> Key: SCB-925
> URL: https://issues.apache.org/jira/browse/SCB-925
> Project: Apache ServiceComb
> Issue Type: Bug
> Components: Java-Chassis
>Reporter: WeiChao
>Assignee: WeiChao
>Priority: Major
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (SCB-1048) Provide a way to configure bootstrap information in Cloud Native enviroment
[ https://issues.apache.org/jira/browse/SCB-1048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16700197#comment-16700197 ] ASF GitHub Bot commented on SCB-1048: - coveralls commented on issue #1014: [SCB-1048]Provide a way to configure bootstrap information in Cloud N… URL: https://github.com/apache/servicecomb-java-chassis/pull/1014#issuecomment-442010966 [](https://coveralls.io/builds/20309813) Coverage decreased (-0.01%) to 86.761% when pulling **b16bb8fa23dab9d862780316d8a3b10d871245db on liubao68:management** into **47d4773f3db7444e07fa2bb5bf87ac0a0387855f on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Provide a way to configure bootstrap information in Cloud Native enviroment > --- > > Key: SCB-1048 > URL: https://issues.apache.org/jira/browse/SCB-1048 > Project: Apache ServiceComb > Issue Type: New Feature > Components: Java-Chassis >Reporter: liubao >Assignee: liubao >Priority: Major > > # About Bootstrap Module > Bootstrap is a mechanism to manage how microservics interact with external > services. When running a microservic in a Cloud Native enviroment, it will > interact with many external services, like service center, config center, an > APM service to report tracing data, a dashboard service to report health > data, etc. Bootstrap manages the meta data of these services. Bootstrap > queries the addresses , the parameters, the authentication information of > these services and so on. > Bootstrap is some kind of service like service center, they are differ from > two aspects: > 1. All microservics will report their information to service center. But > Bootstrap acts as a management system and knows the meta information in > deploy time. > 2. Service center provide some other functions like instance management and > heartbeat, But Bootstrap only provide metadata query services and it is > simple. > Bootstrap does not provide a management service, it providers the interface > to interacts with management service. Service Providers can implement the > interface. > They are some design constraints need to be considered when implment > Bootstrap interface: > 1. Bootstrap can only read configurations of environment, microservics.yaml. > It can not read dynamic configurations. > 2. Bootstrap is initialized before bean initialization. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-1048) Provide a way to configure bootstrap information in Cloud Native enviroment
[ https://issues.apache.org/jira/browse/SCB-1048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16700167#comment-16700167 ] ASF GitHub Bot commented on SCB-1048: - liubao68 opened a new pull request #1014: [SCB-1048]Provide a way to configure bootstrap information in Cloud N… URL: https://github.com/apache/servicecomb-java-chassis/pull/1014 …ative enviroment Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/SCB) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [ ] Each commit in the pull request should have a meaningful subject line and body. - [ ] Format the pull request title like `[SCB-XXX] Fixes bug in ApproximateQuantiles`, where you replace `SCB-XXX` with the appropriate JIRA issue. - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [ ] Run `mvn clean install` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). --- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Provide a way to configure bootstrap information in Cloud Native enviroment > --- > > Key: SCB-1048 > URL: https://issues.apache.org/jira/browse/SCB-1048 > Project: Apache ServiceComb > Issue Type: New Feature > Components: Java-Chassis >Reporter: liubao >Assignee: liubao >Priority: Major > > # About Bootstrap Module > Bootstrap is a mechanism to manage how microservics interact with external > services. When running a microservic in a Cloud Native enviroment, it will > interact with many external services, like service center, config center, an > APM service to report tracing data, a dashboard service to report health > data, etc. Bootstrap manages the meta data of these services. Bootstrap > queries the addresses , the parameters, the authentication information of > these services and so on. > Bootstrap is some kind of service like service center, they are differ from > two aspects: > 1. All microservics will report their information to service center. But > Bootstrap acts as a management system and knows the meta information in > deploy time. > 2. Service center provide some other functions like instance management and > heartbeat, But Bootstrap only provide metadata query services and it is > simple. > Bootstrap does not provide a management service, it providers the interface > to interacts with management service. Service Providers can implement the > interface. > They are some design constraints need to be considered when implment > Bootstrap interface: > 1. Bootstrap can only read configurations of environment, microservics.yaml. > It can not read dynamic configurations. > 2. Bootstrap is initialized before bean initialization. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Resolved] (SCB-1038) Fix some bugs and logs improvement reported by users when testing
[ https://issues.apache.org/jira/browse/SCB-1038?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] liubao resolved SCB-1038. - Resolution: Fixed > Fix some bugs and logs improvement reported by users when testing > - > > Key: SCB-1038 > URL: https://issues.apache.org/jira/browse/SCB-1038 > Project: Apache ServiceComb > Issue Type: Improvement > Components: Java-Chassis >Reporter: liubao >Assignee: liubao >Priority: Major > > # loadbalancer do not print the cause when some unexpected error happens > # SessionStickRule microserviceName is not assigned a value -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (SCB-1048) Provide a way to configure bootstrap information in Cloud Native enviroment
[ https://issues.apache.org/jira/browse/SCB-1048?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] liubao updated SCB-1048: Component/s: Java-Chassis > Provide a way to configure bootstrap information in Cloud Native enviroment > --- > > Key: SCB-1048 > URL: https://issues.apache.org/jira/browse/SCB-1048 > Project: Apache ServiceComb > Issue Type: New Feature > Components: Java-Chassis >Reporter: liubao >Assignee: liubao >Priority: Major > > # About Bootstrap Module > Bootstrap is a mechanism to manage how microservics interact with external > services. When running a microservic in a Cloud Native enviroment, it will > interact with many external services, like service center, config center, an > APM service to report tracing data, a dashboard service to report health > data, etc. Bootstrap manages the meta data of these services. Bootstrap > queries the addresses , the parameters, the authentication information of > these services and so on. > Bootstrap is some kind of service like service center, they are differ from > two aspects: > 1. All microservics will report their information to service center. But > Bootstrap acts as a management system and knows the meta information in > deploy time. > 2. Service center provide some other functions like instance management and > heartbeat, But Bootstrap only provide metadata query services and it is > simple. > Bootstrap does not provide a management service, it providers the interface > to interacts with management service. Service Providers can implement the > interface. > They are some design constraints need to be considered when implment > Bootstrap interface: > 1. Bootstrap can only read configurations of environment, microservics.yaml. > It can not read dynamic configurations. > 2. Bootstrap is initialized before bean initialization. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (SCB-1048) Provide a way to configure bootstrap information in Cloud Native enviroment
liubao created SCB-1048: --- Summary: Provide a way to configure bootstrap information in Cloud Native enviroment Key: SCB-1048 URL: https://issues.apache.org/jira/browse/SCB-1048 Project: Apache ServiceComb Issue Type: New Feature Reporter: liubao Assignee: liubao # About Bootstrap Module Bootstrap is a mechanism to manage how microservics interact with external services. When running a microservic in a Cloud Native enviroment, it will interact with many external services, like service center, config center, an APM service to report tracing data, a dashboard service to report health data, etc. Bootstrap manages the meta data of these services. Bootstrap queries the addresses , the parameters, the authentication information of these services and so on. Bootstrap is some kind of service like service center, they are differ from two aspects: 1. All microservics will report their information to service center. But Bootstrap acts as a management system and knows the meta information in deploy time. 2. Service center provide some other functions like instance management and heartbeat, But Bootstrap only provide metadata query services and it is simple. Bootstrap does not provide a management service, it providers the interface to interacts with management service. Service Providers can implement the interface. They are some design constraints need to be considered when implment Bootstrap interface: 1. Bootstrap can only read configurations of environment, microservics.yaml. It can not read dynamic configurations. 2. Bootstrap is initialized before bean initialization. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (SCB-1038) Fix some bugs and logs improvement reported by users when testing
[ https://issues.apache.org/jira/browse/SCB-1038?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] liubao updated SCB-1038: Fix Version/s: java-chassis-1.1.0 > Fix some bugs and logs improvement reported by users when testing > - > > Key: SCB-1038 > URL: https://issues.apache.org/jira/browse/SCB-1038 > Project: Apache ServiceComb > Issue Type: Improvement > Components: Java-Chassis >Reporter: liubao >Assignee: liubao >Priority: Major > Fix For: java-chassis-1.1.0 > > > # loadbalancer do not print the cause when some unexpected error happens > # SessionStickRule microserviceName is not assigned a value -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-925) Springmvc, when have defaultValue, required should be false
[ https://issues.apache.org/jira/browse/SCB-925?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16700042#comment-16700042 ] ASF GitHub Bot commented on SCB-925: coveralls edited a comment on issue #1004: [SCB-925] Springmvc, when have defaultValue, required should be false, when param not exist, should check isRequired URL: https://github.com/apache/servicecomb-java-chassis/pull/1004#issuecomment-441166462 [](https://coveralls.io/builds/20307438) Coverage decreased (-0.1%) to 86.661% when pulling **91a8bbc14f3a71aa9e5314269064d7f592aa0d38 on weichao666:defaultvaluenew** into **47d4773f3db7444e07fa2bb5bf87ac0a0387855f on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Springmvc, when have defaultValue, required should be false > --- > > Key: SCB-925 > URL: https://issues.apache.org/jira/browse/SCB-925 > Project: Apache ServiceComb > Issue Type: Bug > Components: Java-Chassis >Reporter: WeiChao >Assignee: WeiChao >Priority: Major > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
