[jira] [Commented] (SCB-925) Springmvc, when have defaultValue, required should be false
[
https://issues.apache.org/jira/browse/SCB-925?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16698455#comment-16698455
]
ASF GitHub Bot commented on SCB-925:
weichao666 commented on a change in pull request #1004: [SCB-925] Springmvc,
when have defaultValue, required should be false, when param not exist, should
check isRequired
URL:
https://github.com/apache/servicecomb-java-chassis/pull/1004#discussion_r236115540
##
File path:
integration-tests/it-consumer/src/main/java/org/apache/servicecomb/it/testcase/TestDefaultValue.java
##
@@ -472,12 +524,21 @@ public void floatHeader_require_springmvc_rt() {
@Test
public void floatForm_require_springmvc_intf() {
-assertEquals(defaultFloat,
consumersSpringmvc.getIntf().floatFormRequire(null), 0.0f);
+try {
+ consumersSpringmvc.getIntf().floatFormRequire(null);
+ assertEquals("required is true, throw exception", "but not throw
exception");
+} catch (Exception e) {
+ assertEquals(true, e.getMessage().contains("Parameter is not valid"));
+}
}
@Test
public void floatForm_require_springmvc_rt() {
-assertEquals(defaultFloat,
-
consumersSpringmvc.getSCBRestTemplate().postForObject("/floatFormRequire",
null, float.class), 0.0f);
+try {
+
consumersSpringmvc.getSCBRestTemplate().postForObject("/floatFormRequire",
null, float.class);
Review comment:
yes
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Springmvc, when have defaultValue, required should be false
> ---
>
> Key: SCB-925
> URL: https://issues.apache.org/jira/browse/SCB-925
> Project: Apache ServiceComb
> Issue Type: Bug
> Components: Java-Chassis
>Reporter: WeiChao
>Assignee: WeiChao
>Priority: Major
> Fix For: java-chassis-1.1.0
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (SCB-925) Springmvc, when have defaultValue, required should be false
[
https://issues.apache.org/jira/browse/SCB-925?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16698452#comment-16698452
]
ASF GitHub Bot commented on SCB-925:
weichao666 commented on a change in pull request #1004: [SCB-925] Springmvc,
when have defaultValue, required should be false, when param not exist, should
check isRequired
URL:
https://github.com/apache/servicecomb-java-chassis/pull/1004#discussion_r236115468
##
File path:
common/common-rest/src/main/java/org/apache/servicecomb/common/rest/codec/param/FormProcessorCreator.java
##
@@ -50,20 +52,33 @@ public Object getValue(HttpServletRequest request) {
}
if (targetType.isContainerType()) {
-return convertValue(request.getParameterValues(paramPath), targetType);
+Object values = request.getParameterValues(paramPath);
+//Even if the paramPath does not exist, it won't be null at now, may
be optimized in the future
+if (values == null) {
+ values = checkRequiredAndDefaultValue(values);
+}
+return convertValue(values, targetType);
}
Object value = request.getParameter(paramPath);
if (value == null) {
-Object defaultValue = getDefaultValue();
-if (defaultValue != null) {
- value = defaultValue;
-}
+value = checkRequiredAndDefaultValue(value);
}
return convertValue(value, targetType);
}
+private Object checkRequiredAndDefaultValue(Object values) {
Review comment:
done
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Springmvc, when have defaultValue, required should be false
> ---
>
> Key: SCB-925
> URL: https://issues.apache.org/jira/browse/SCB-925
> Project: Apache ServiceComb
> Issue Type: Bug
> Components: Java-Chassis
>Reporter: WeiChao
>Assignee: WeiChao
>Priority: Major
> Fix For: java-chassis-1.1.0
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (SCB-1032) Support compress the response
[ https://issues.apache.org/jira/browse/SCB-1032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16698428#comment-16698428 ] ASF GitHub Bot commented on SCB-1032: - coveralls edited a comment on issue #496: SCB-1032 Support compress the response URL: https://github.com/apache/servicecomb-service-center/pull/496#issuecomment-440688511 [](https://coveralls.io/builds/20283016) Coverage decreased (-0.2%) to 61.616% when pulling **ab475ada118df92d28b6abb0ca6e9880a8de1886 on little-cui:gzip** into **7aceab7f2ccb804089627bfdb82e7d7a62ab259a on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Support compress the response > - > > Key: SCB-1032 > URL: https://issues.apache.org/jira/browse/SCB-1032 > Project: Apache ServiceComb > Issue Type: New Feature > Components: Service-Center >Reporter: little-cui >Assignee: little-cui >Priority: Major > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-1032) Support compress the response
[ https://issues.apache.org/jira/browse/SCB-1032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16698425#comment-16698425 ] ASF GitHub Bot commented on SCB-1032: - codecov-io edited a comment on issue #496: SCB-1032 Support compress the response URL: https://github.com/apache/servicecomb-service-center/pull/496#issuecomment-440691271 # [Codecov](https://codecov.io/gh/apache/servicecomb-service-center/pull/496?src=pr=h1) Report > Merging [#496](https://codecov.io/gh/apache/servicecomb-service-center/pull/496?src=pr=desc) into [master](https://codecov.io/gh/apache/servicecomb-service-center/commit/7aceab7f2ccb804089627bfdb82e7d7a62ab259a?src=pr=desc) will **increase** coverage by `0.01%`. > The diff coverage is `0%`. [](https://codecov.io/gh/apache/servicecomb-service-center/pull/496?src=pr=tree) ```diff @@Coverage Diff @@ ## master #496 +/- ## == + Coverage 59.25% 59.26% +0.01% == Files 166 166 Lines 1388013880 == + Hits 8224 8226 +2 + Misses 5074 5072 -2 Partials 582 582 ``` | [Impacted Files](https://codecov.io/gh/apache/servicecomb-service-center/pull/496?src=pr=tree) | Coverage Δ | | |---|---|---| | [...er/plugin/pkg/discovery/servicecenter/aggregate.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/496/diff?src=pr=tree#diff-c2VydmVyL3BsdWdpbi9wa2cvZGlzY292ZXJ5L3NlcnZpY2VjZW50ZXIvYWdncmVnYXRlLmdv) | `8% <0%> (ø)` | :arrow_up: | | [pkg/log/logrotate.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/496/diff?src=pr=tree#diff-cGtnL2xvZy9sb2dyb3RhdGUuZ28=) | `33.71% <0%> (-0.58%)` | :arrow_down: | | [server/govern/service.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/496/diff?src=pr=tree#diff-c2VydmVyL2dvdmVybi9zZXJ2aWNlLmdv) | `72.6% <0%> (-0.34%)` | :arrow_down: | | [server/service/tag.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/496/diff?src=pr=tree#diff-c2VydmVyL3NlcnZpY2UvdGFnLmdv) | `67.95% <0%> (+0.55%)` | :arrow_up: | | [server/service/notification/websocket.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/496/diff?src=pr=tree#diff-c2VydmVyL3NlcnZpY2Uvbm90aWZpY2F0aW9uL3dlYnNvY2tldC5nbw==) | `84.51% <0%> (+0.64%)` | :arrow_up: | | [pkg/gopool/goroutines.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/496/diff?src=pr=tree#diff-cGtnL2dvcG9vbC9nb3JvdXRpbmVzLmdv) | `100% <0%> (+2.63%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/servicecomb-service-center/pull/496?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/servicecomb-service-center/pull/496?src=pr=footer). Last update [7aceab7...ab475ad](https://codecov.io/gh/apache/servicecomb-service-center/pull/496?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Support compress the response > - > > Key: SCB-1032 > URL: https://issues.apache.org/jira/browse/SCB-1032 > Project: Apache ServiceComb > Issue Type: New Feature > Components: Service-Center >Reporter: little-cui >Assignee: little-cui >Priority: Major > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-1039) Add interface to compatible with ServiceCenter Aggregator
[
https://issues.apache.org/jira/browse/SCB-1039?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16698389#comment-16698389
]
ASF GitHub Bot commented on SCB-1039:
-
liubao68 closed pull request #1007: [SCB-1039]Add interface to compatible with
ServiceCenter Aggregator
URL: https://github.com/apache/servicecomb-java-chassis/pull/1007
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/core/src/main/java/org/apache/servicecomb/core/definition/schema/ConsumerSchemaFactory.java
b/core/src/main/java/org/apache/servicecomb/core/definition/schema/ConsumerSchemaFactory.java
index a3dbbdb3a..c9b8ed242 100644
---
a/core/src/main/java/org/apache/servicecomb/core/definition/schema/ConsumerSchemaFactory.java
+++
b/core/src/main/java/org/apache/servicecomb/core/definition/schema/ConsumerSchemaFactory.java
@@ -65,7 +65,7 @@ protected Swagger loadSwagger(ConsumerSchemaContext context) {
}
ServiceRegistryClient client = RegistryUtils.getServiceRegistryClient();
-String schemaContent =
client.getSchema(context.getMicroservice().getServiceId(),
context.getSchemaId());
+String schemaContent =
client.getAggregatedSchema(context.getMicroservice().getServiceId(),
context.getSchemaId());
LOGGER.info("load schema from service center, microservice={}:{}:{},
schemaId={}, result={}",
context.getMicroservice().getAppId(),
context.getMicroservice().getServiceName(),
diff --git
a/core/src/test/java/org/apache/servicecomb/core/definition/TestMicroserviceVersionMeta.java
b/core/src/test/java/org/apache/servicecomb/core/definition/TestMicroserviceVersionMeta.java
index fd24f6dec..9f5d68041 100644
---
a/core/src/test/java/org/apache/servicecomb/core/definition/TestMicroserviceVersionMeta.java
+++
b/core/src/test/java/org/apache/servicecomb/core/definition/TestMicroserviceVersionMeta.java
@@ -26,6 +26,7 @@
import org.apache.servicecomb.core.definition.loader.SchemaListenerManager;
import org.apache.servicecomb.core.definition.schema.ConsumerSchemaFactory;
import org.apache.servicecomb.serviceregistry.RegistryUtils;
+import org.apache.servicecomb.serviceregistry.ServiceRegistry;
import org.apache.servicecomb.serviceregistry.api.registry.Microservice;
import org.hamcrest.Matchers;
import org.junit.AfterClass;
@@ -35,6 +36,7 @@
import mockit.Expectations;
import mockit.Mock;
import mockit.MockUp;
+import mockit.Mocked;
public class TestMicroserviceVersionMeta {
@AfterClass
@@ -44,7 +46,7 @@ public static void teardown() {
}
@Test
- public void construct() {
+ public void construct(@Mocked ServiceRegistry serviceRegistry) {
String microserviceName = "app:ms";
String microserviceId = "id";
Microservice microservice = new Microservice();
@@ -52,7 +54,9 @@ public void construct() {
new Expectations(RegistryUtils.class) {
{
-RegistryUtils.getMicroservice(microserviceId);
+RegistryUtils.getServiceRegistry();
+result = serviceRegistry;
+serviceRegistry.getAggregatedRemoteMicroservice(microserviceId);
result = microservice;
}
};
diff --git
a/core/src/test/java/org/apache/servicecomb/core/definition/TestMicroserviceVersionMetaFactory.java
b/core/src/test/java/org/apache/servicecomb/core/definition/TestMicroserviceVersionMetaFactory.java
index bf6c527ac..8e5382abf 100644
---
a/core/src/test/java/org/apache/servicecomb/core/definition/TestMicroserviceVersionMetaFactory.java
+++
b/core/src/test/java/org/apache/servicecomb/core/definition/TestMicroserviceVersionMetaFactory.java
@@ -23,6 +23,7 @@
import org.apache.servicecomb.core.definition.loader.SchemaListenerManager;
import org.apache.servicecomb.core.definition.schema.ConsumerSchemaFactory;
import org.apache.servicecomb.serviceregistry.RegistryUtils;
+import org.apache.servicecomb.serviceregistry.ServiceRegistry;
import org.apache.servicecomb.serviceregistry.api.registry.Microservice;
import org.apache.servicecomb.serviceregistry.consumer.MicroserviceVersion;
import org.hamcrest.Matchers;
@@ -58,7 +59,7 @@ public void constructWithFactory() {
@Test
public void create(@Mocked ConsumerSchemaFactory consumerSchemaFactory,
- @Mocked SchemaListenerManager schemaListenerManager) {
+ @Mocked SchemaListenerManager schemaListenerManager, @Mocked
ServiceRegistry serviceRegistry) {
String microserviceName = "app:ms";
String microserviceId = "id";
Microservice microservice = new Microservice();
@@ -66,7 +67,9 @@ public void create(@Mocked ConsumerSchemaFactory
consumerSchemaFactory,
new Expectations(RegistryUtils.class) {
{
-RegistryUtils.getMicroservice(microserviceId);
+
[jira] [Commented] (SCB-968) [SCB-968]968 http2 do not support pump download
[ https://issues.apache.org/jira/browse/SCB-968?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16698372#comment-16698372 ] ASF GitHub Bot commented on SCB-968: coveralls edited a comment on issue #1001: [SCB-968]968 http2 do not support pump download URL: https://github.com/apache/servicecomb-java-chassis/pull/1001#issuecomment-441018970 [](https://coveralls.io/builds/20282486) Coverage decreased (-0.03%) to 86.739% when pulling **c11df57143f82be473b2272f00e7919376bb21f9 on heyile:h2PumpDownload** into **90f6d6fdc82ea0d677f7d04d2306835dd5c0e441 on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > [SCB-968]968 http2 do not support pump download > --- > > Key: SCB-968 > URL: https://issues.apache.org/jira/browse/SCB-968 > Project: Apache ServiceComb > Issue Type: Bug > Components: Java-Chassis >Reporter: 何一乐 >Priority: Major > > when use http2 settings, TestDownload in demo will throw a can not save zero > bytes exception. as the last item in pending stack is empty string "" -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-1039) Add interface to compatible with ServiceCenter Aggregator
[ https://issues.apache.org/jira/browse/SCB-1039?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16698368#comment-16698368 ] ASF GitHub Bot commented on SCB-1039: - heyile commented on issue #1007: [SCB-1039]Add interface to compatible with ServiceCenter Aggregator URL: https://github.com/apache/servicecomb-java-chassis/pull/1007#issuecomment-441488807 > Why we need to distinguish from register & find flow? I think service center knows the request is register or find. @wujimin I do not know the details very clearly This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Add interface to compatible with ServiceCenter Aggregator > - > > Key: SCB-1039 > URL: https://issues.apache.org/jira/browse/SCB-1039 > Project: Apache ServiceComb > Issue Type: Improvement > Components: Java-Chassis >Reporter: 何一乐 >Assignee: 何一乐 >Priority: Major > > 1.增加几个接口 > > org.apache.servicecomb.serviceregistry.client.ServiceRegistryClient#getMicroservice旁边加getAggregatedMicroervice > > org.apache.servicecomb.serviceregistry.ServiceRegistry#getRemoteMicroservice旁边加上getAggregatedRemoteMicroervice > > org.apache.servicecomb.serviceregistry.client.ServiceRegistryClient#getSchema旁边加getAggregatedSchema > 都加上java doc注释，描述以下信息： > 1）连接普通ServiceCenter时，效果等同于不带Aggregagit chected的信息 > 2）连接ServiceCenter > Aggregator时，表示获取范围不仅仅局限在本ServiceCenter中，还包括其他ServiceCenter集群 > 向ServiceCenter发RESTful请求时，Aggregated的版本是在query参数部分加上global=true > 2.搜索旧接口的所有引用 >所有在服务发现流程中对它们的调用，都需要切换为Aggregated版本 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-1039) Add interface to compatible with ServiceCenter Aggregator
[ https://issues.apache.org/jira/browse/SCB-1039?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16698369#comment-16698369 ] ASF GitHub Bot commented on SCB-1039: - wujimin commented on issue #1007: [SCB-1039]Add interface to compatible with ServiceCenter Aggregator URL: https://github.com/apache/servicecomb-java-chassis/pull/1007#issuecomment-441489296 both register and find instance flow, need to invoke getMicroservice/getSchema but: only local serviceCenter cluster available for register flow all serviceCenter clusters in aggregator available for find instance flow ServiceCenter can not know the scenes, so need client invoke with the flag This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Add interface to compatible with ServiceCenter Aggregator > - > > Key: SCB-1039 > URL: https://issues.apache.org/jira/browse/SCB-1039 > Project: Apache ServiceComb > Issue Type: Improvement > Components: Java-Chassis >Reporter: 何一乐 >Assignee: 何一乐 >Priority: Major > > 1.增加几个接口 > > org.apache.servicecomb.serviceregistry.client.ServiceRegistryClient#getMicroservice旁边加getAggregatedMicroervice > > org.apache.servicecomb.serviceregistry.ServiceRegistry#getRemoteMicroservice旁边加上getAggregatedRemoteMicroervice > > org.apache.servicecomb.serviceregistry.client.ServiceRegistryClient#getSchema旁边加getAggregatedSchema > 都加上java doc注释，描述以下信息： > 1）连接普通ServiceCenter时，效果等同于不带Aggregagit chected的信息 > 2）连接ServiceCenter > Aggregator时，表示获取范围不仅仅局限在本ServiceCenter中，还包括其他ServiceCenter集群 > 向ServiceCenter发RESTful请求时，Aggregated的版本是在query参数部分加上global=true > 2.搜索旧接口的所有引用 >所有在服务发现流程中对它们的调用，都需要切换为Aggregated版本 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-1039) Add interface to compatible with ServiceCenter Aggregator
[ https://issues.apache.org/jira/browse/SCB-1039?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16698367#comment-16698367 ] ASF GitHub Bot commented on SCB-1039: - heyile removed a comment on issue #1007: [SCB-1039]Add interface to compatible with ServiceCenter Aggregator URL: https://github.com/apache/servicecomb-java-chassis/pull/1007#issuecomment-441488705 > Why we need to distinguish from register & find flow? I think service center knows the request is register or find. @wujimin I know why, but I do not know the details very clearly This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Add interface to compatible with ServiceCenter Aggregator > - > > Key: SCB-1039 > URL: https://issues.apache.org/jira/browse/SCB-1039 > Project: Apache ServiceComb > Issue Type: Improvement > Components: Java-Chassis >Reporter: 何一乐 >Assignee: 何一乐 >Priority: Major > > 1.增加几个接口 > > org.apache.servicecomb.serviceregistry.client.ServiceRegistryClient#getMicroservice旁边加getAggregatedMicroervice > > org.apache.servicecomb.serviceregistry.ServiceRegistry#getRemoteMicroservice旁边加上getAggregatedRemoteMicroervice > > org.apache.servicecomb.serviceregistry.client.ServiceRegistryClient#getSchema旁边加getAggregatedSchema > 都加上java doc注释，描述以下信息： > 1）连接普通ServiceCenter时，效果等同于不带Aggregagit chected的信息 > 2）连接ServiceCenter > Aggregator时，表示获取范围不仅仅局限在本ServiceCenter中，还包括其他ServiceCenter集群 > 向ServiceCenter发RESTful请求时，Aggregated的版本是在query参数部分加上global=true > 2.搜索旧接口的所有引用 >所有在服务发现流程中对它们的调用，都需要切换为Aggregated版本 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-1039) Add interface to compatible with ServiceCenter Aggregator
[ https://issues.apache.org/jira/browse/SCB-1039?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16698366#comment-16698366 ] ASF GitHub Bot commented on SCB-1039: - heyile commented on issue #1007: [SCB-1039]Add interface to compatible with ServiceCenter Aggregator URL: https://github.com/apache/servicecomb-java-chassis/pull/1007#issuecomment-441488705 > Why we need to distinguish from register & find flow? I think service center knows the request is register or find. @wujimin I know why, but I do not know the details very clearly This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Add interface to compatible with ServiceCenter Aggregator > - > > Key: SCB-1039 > URL: https://issues.apache.org/jira/browse/SCB-1039 > Project: Apache ServiceComb > Issue Type: Improvement > Components: Java-Chassis >Reporter: 何一乐 >Assignee: 何一乐 >Priority: Major > > 1.增加几个接口 > > org.apache.servicecomb.serviceregistry.client.ServiceRegistryClient#getMicroservice旁边加getAggregatedMicroervice > > org.apache.servicecomb.serviceregistry.ServiceRegistry#getRemoteMicroservice旁边加上getAggregatedRemoteMicroervice > > org.apache.servicecomb.serviceregistry.client.ServiceRegistryClient#getSchema旁边加getAggregatedSchema > 都加上java doc注释，描述以下信息： > 1）连接普通ServiceCenter时，效果等同于不带Aggregagit chected的信息 > 2）连接ServiceCenter > Aggregator时，表示获取范围不仅仅局限在本ServiceCenter中，还包括其他ServiceCenter集群 > 向ServiceCenter发RESTful请求时，Aggregated的版本是在query参数部分加上global=true > 2.搜索旧接口的所有引用 >所有在服务发现流程中对它们的调用，都需要切换为Aggregated版本 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-1039) Add interface to compatible with ServiceCenter Aggregator
[ https://issues.apache.org/jira/browse/SCB-1039?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16698151#comment-16698151 ] ASF GitHub Bot commented on SCB-1039: - liubao68 commented on issue #1007: [SCB-1039]Add interface to compatible with ServiceCenter Aggregator URL: https://github.com/apache/servicecomb-java-chassis/pull/1007#issuecomment-441435350 Why we need to distinguish from register & find flow? I think service center knows the request is register or find. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Add interface to compatible with ServiceCenter Aggregator > - > > Key: SCB-1039 > URL: https://issues.apache.org/jira/browse/SCB-1039 > Project: Apache ServiceComb > Issue Type: Improvement > Components: Java-Chassis >Reporter: 何一乐 >Assignee: 何一乐 >Priority: Major > > 1.增加几个接口 > > org.apache.servicecomb.serviceregistry.client.ServiceRegistryClient#getMicroservice旁边加getAggregatedMicroervice > > org.apache.servicecomb.serviceregistry.ServiceRegistry#getRemoteMicroservice旁边加上getAggregatedRemoteMicroervice > > org.apache.servicecomb.serviceregistry.client.ServiceRegistryClient#getSchema旁边加getAggregatedSchema > 都加上java doc注释，描述以下信息： > 1）连接普通ServiceCenter时，效果等同于不带Aggregagit chected的信息 > 2）连接ServiceCenter > Aggregator时，表示获取范围不仅仅局限在本ServiceCenter中，还包括其他ServiceCenter集群 > 向ServiceCenter发RESTful请求时，Aggregated的版本是在query参数部分加上global=true > 2.搜索旧接口的所有引用 >所有在服务发现流程中对它们的调用，都需要切换为Aggregated版本 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-1031) The Response's properties was overrided wrong between @APIOperation and @Resoponse on the controller method
[
https://issues.apache.org/jira/browse/SCB-1031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16698145#comment-16698145
]
ASF GitHub Bot commented on SCB-1031:
-
liubao68 closed pull request #999: [SCB-1031] resolve @ApiOperator @Response
override wrong, if the prev…
URL: https://github.com/apache/servicecomb-java-chassis/pull/999
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/samples/springmvc-sample/springmvc-provider/src/main/resources/META-INF/spring/springmvc.provider.bean.xml
b/samples/springmvc-sample/springmvc-provider/src/main/resources/META-INF/spring/springmvc.provider.bean.xml
index 568a45f33..998207518 100644
---
a/samples/springmvc-sample/springmvc-provider/src/main/resources/META-INF/spring/springmvc.provider.bean.xml
+++
b/samples/springmvc-sample/springmvc-provider/src/main/resources/META-INF/spring/springmvc.provider.bean.xml
@@ -19,7 +19,10 @@
http://www.springframework.org/schema/beans;
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance;
xmlns:context="http://www.springframework.org/schema/context;
- xsi:schemaLocation="http://www.springframework.org/schema/context
http://www.springframework.org/schema/context/spring-context.xsd;>
+ xsi:schemaLocation="http://www.springframework.org/schema/beans
+
http://www.springframework.org/schema/beans/spring-beans.xsd
+http://www.springframework.org/schema/context
+
http://www.springframework.org/schema/context/spring-context.xsd;>
diff --git
a/swagger/swagger-generator/generator-core/src/main/java/org/apache/servicecomb/swagger/generator/core/processor/annotation/AnnotationUtils.java
b/swagger/swagger-generator/generator-core/src/main/java/org/apache/servicecomb/swagger/generator/core/processor/annotation/AnnotationUtils.java
index aebca2b29..2193f8e29 100644
---
a/swagger/swagger-generator/generator-core/src/main/java/org/apache/servicecomb/swagger/generator/core/processor/annotation/AnnotationUtils.java
+++
b/swagger/swagger-generator/generator-core/src/main/java/org/apache/servicecomb/swagger/generator/core/processor/annotation/AnnotationUtils.java
@@ -115,7 +115,7 @@ public static ResponseHeaderConfig convert(ResponseHeader
responseHeader) {
public static void addResponse(Swagger swagger, Operation operation,
ApiOperation apiOperation) {
ResponseConfig responseConfig = convert(apiOperation);
generateResponse(swagger, responseConfig);
-operation.response(responseConfig.getCode(), responseConfig.getResponse());
+mergeResponse(operation, responseConfig);
}
public static void addResponse(Swagger swagger, ApiResponse apiResponse) {
@@ -127,7 +127,35 @@ public static void addResponse(Swagger swagger,
ApiResponse apiResponse) {
public static void addResponse(Swagger swagger, Operation operation,
ApiResponse apiResponse) {
ResponseConfig responseConfig = convert(apiResponse);
generateResponse(swagger, responseConfig);
-operation.response(responseConfig.getCode(), responseConfig.getResponse());
+mergeResponse(operation, responseConfig);
+ }
+
+ private static void mergeResponse(Operation operation, ResponseConfig
responseConfig) {
+if (operation.getResponses() == null) {
+ operation.response(responseConfig.getCode(),
responseConfig.getResponse());
+ return;
+}
+Response response =
operation.getResponses().get(String.valueOf(responseConfig.getCode()));
+if (response == null) {
+ operation.response(responseConfig.getCode(),
responseConfig.getResponse());
+ return;
+}
+Response sourceResp = responseConfig.getResponse();
+if (StringUtils.isNotEmpty(sourceResp.getDescription()) &&
StringUtils.isEmpty(response.getDescription())) {
+ response.setDescription(sourceResp.getDescription());
+}
+if (sourceResp.getSchema() != null && response.getSchema() == null) {
+ response.setSchema(sourceResp.getSchema());
+}
+if (sourceResp.getExamples() != null && response.getExamples() == null) {
+ response.setExamples(sourceResp.getExamples());
+}
+if (sourceResp.getHeaders() != null && response.getHeaders() == null) {
+ response.setHeaders(sourceResp.getHeaders());
+}
+if (sourceResp.getVendorExtensions() != null &&
response.getVendorExtensions() == null) {
+ response.setVendorExtensions(sourceResp.getVendorExtensions());
+}
}
private static void generateResponse(Swagger swagger, ResponseConfig
responseConfig) {
diff --git
a/swagger/swagger-generator/generator-core/src/test/java/org/apache/servicecomb/swagger/generator/core/TestOperationGenerator.java
[jira] [Commented] (SCB-1035) Update third party licenses for java-chassis
[ https://issues.apache.org/jira/browse/SCB-1035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16697705#comment-16697705 ] ASF GitHub Bot commented on SCB-1035: - wujimin closed pull request #1000: [SCB-1035] Update license and notice for third parties URL: https://github.com/apache/servicecomb-java-chassis/pull/1000 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/core/src/main/java/org/apache/servicecomb/core/invocation/InvocationStageTrace.java b/core/src/main/java/org/apache/servicecomb/core/invocation/InvocationStageTrace.java index bf7879541..27296b29b 100644 --- a/core/src/main/java/org/apache/servicecomb/core/invocation/InvocationStageTrace.java +++ b/core/src/main/java/org/apache/servicecomb/core/invocation/InvocationStageTrace.java @@ -28,31 +28,31 @@ * * for consumer: * (prepare) (handlerReq) (clientFilterReq) - * start > startHandlersRequest ---> startClientFiltersRequest -- - * <(sendRequest)->| + * start startHandlersRequest --- startClientFiltersRequest -- + * (sendRequest)-| *(receiveResponse) (writeToBuffer) (getConnection)| - *---finishReceiveResponse <- finishWriteToBuffer <--- finishGetConnection <-- startSend <- + *---finishReceiveResponse - finishWriteToBuffer --- finishGetConnection -- startSend - * | (wakeConsumer)(clientFiltersResponse) (handlersResponse) - * |-> startClientFiltersResponse ---> finishClientFiltersResponse ---> finishHandlersResponse --> finish + * |- startClientFiltersResponse --- finishClientFiltersResponse --- finishHandlersResponse -- finish * * for producer: * (prepare) (threadPoolQueue) (serverFiltersRequest) - * start > startSchedule -> startExecution -> startServerFiltersRequest ---> startHandlersRequest --- - * (handlersResponse) <-(business)-> (handlersRequest) | - * -finishHandlersResponse <-- finishBusiness <--- finishBusinessMethod <-- startBusinessMethod-- + * start startSchedule - startExecution - startServerFiltersRequest --- startHandlersRequest --- + * (handlersResponse) -(business)- (handlersRequest) | + * -finishHandlersResponse -- finishBusiness --- finishBusinessMethod -- startBusinessMethod-- * | (serverFiltersResponse) (sendResponse) - * |---> finishServerFiltersResponse --> finish + * |--- finishServerFiltersResponse -- finish * * for edge: * (prepare) (threadPoolQueue) (serverFiltersRequest) - * start > startSchedule -> startExecution -> startServerFiltersRequest > startHandlersRequest -- - * <--(sendRequest)--> | + * start startSchedule - startExecution - startServerFiltersRequest startHandlersRequest -- + * --(sendRequest)-- | * (writeToBuffer) (getConnection) (clientFilterReq)(handlersRequest) | - * --- finishWriteToBuffer <-- finishGetConnection <-- startSend <-- startClientFiltersRequest <- + * --- finishWriteToBuffer -- finishGetConnection -- startSend -- startClientFiltersRequest - * | (receiveResponse) (wakeConsumer) (clientFiltersResponse) - * ---> finishReceiveResponse --> startClientFiltersResponse --> finishClientFiltersResponse + * --- finishReceiveResponse -- startClientFiltersResponse -- finishClientFiltersResponse * (sendResponse) (serverFiltersResponse) (handlersResponse) | - * finish <-- finishServerFiltersResponse <-- finishHandlersResponse < + * finish --
[jira] [Commented] (SCB-1039) Add interface to compatible with ServiceCenter Aggregator
[ https://issues.apache.org/jira/browse/SCB-1039?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16697704#comment-16697704 ] ASF GitHub Bot commented on SCB-1039: - coveralls edited a comment on issue #1007: [SCB-1039]Add interface to compatible with ServiceCenter Aggregator URL: https://github.com/apache/servicecomb-java-chassis/pull/1007#issuecomment-441339625 [](https://coveralls.io/builds/20268278) Coverage increased (+0.01%) to 86.782% when pulling **31ffdf758bed6a482e21f0341f3c6a7832462a5e on heyile:aggregated** into **ca4dea29d6a4c72cdebf28185c435ea69b7259dd on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Add interface to compatible with ServiceCenter Aggregator > - > > Key: SCB-1039 > URL: https://issues.apache.org/jira/browse/SCB-1039 > Project: Apache ServiceComb > Issue Type: Improvement > Components: Java-Chassis >Reporter: 何一乐 >Assignee: 何一乐 >Priority: Major > > 1.增加几个接口 > > org.apache.servicecomb.serviceregistry.client.ServiceRegistryClient#getMicroservice旁边加getAggregatedMicroervice > > org.apache.servicecomb.serviceregistry.ServiceRegistry#getRemoteMicroservice旁边加上getAggregatedRemoteMicroervice > > org.apache.servicecomb.serviceregistry.client.ServiceRegistryClient#getSchema旁边加getAggregatedSchema > 都加上java doc注释，描述以下信息： > 1）连接普通ServiceCenter时，效果等同于不带Aggregagit chected的信息 > 2）连接ServiceCenter > Aggregator时，表示获取范围不仅仅局限在本ServiceCenter中，还包括其他ServiceCenter集群 > 向ServiceCenter发RESTful请求时，Aggregated的版本是在query参数部分加上global=true > 2.搜索旧接口的所有引用 >所有在服务发现流程中对它们的调用，都需要切换为Aggregated版本 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-1035) Update third party licenses for java-chassis
[ https://issues.apache.org/jira/browse/SCB-1035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16697686#comment-16697686 ] ASF GitHub Bot commented on SCB-1035: - coveralls edited a comment on issue #1000: [SCB-1035] Update license and notice for third parties URL: https://github.com/apache/servicecomb-java-chassis/pull/1000#issuecomment-440904072 [](https://coveralls.io/builds/20268174) Coverage remained the same at 86.771% when pulling **0f712030815590c45ee40d3feabf8f0d24c7990c on yangbor:master** into **ca4dea29d6a4c72cdebf28185c435ea69b7259dd on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Update third party licenses for java-chassis > > > Key: SCB-1035 > URL: https://issues.apache.org/jira/browse/SCB-1035 > Project: Apache ServiceComb > Issue Type: Task > Components: Java-Chassis >Affects Versions: java-chassis-1.1.0 >Reporter: Yang Bo >Assignee: Yang Bo >Priority: Major > Fix For: java-chassis-1.1.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-1039) Add interface to compatible with ServiceCenter Aggregator
[
https://issues.apache.org/jira/browse/SCB-1039?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16697684#comment-16697684
]
ASF GitHub Bot commented on SCB-1039:
-
heyile commented on a change in pull request #1007: [SCB-1039]Add interface to
compatible with ServiceCenter Aggregator
URL:
https://github.com/apache/servicecomb-java-chassis/pull/1007#discussion_r236035554
##
File path:
service-registry/src/main/java/org/apache/servicecomb/serviceregistry/client/http/ServiceRegistryClientImpl.java
##
@@ -346,19 +346,26 @@ public boolean registerSchema(String microserviceId,
String schemaId, String sch
@Override
public String getSchema(String microserviceId, String schemaId) {
+return doGetSchema(microserviceId, schemaId, false);
+ }
+
+ private String doGetSchema(String microserviceId, String schemaId, boolean
isAggregatedServiceCenter) {
Review comment:
ok, i will change it
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Add interface to compatible with ServiceCenter Aggregator
> -
>
> Key: SCB-1039
> URL: https://issues.apache.org/jira/browse/SCB-1039
> Project: Apache ServiceComb
> Issue Type: Improvement
> Components: Java-Chassis
>Reporter: 何一乐
>Assignee: 何一乐
>Priority: Major
>
> 1.增加几个接口
>
> org.apache.servicecomb.serviceregistry.client.ServiceRegistryClient#getMicroservice旁边加getAggregatedMicroervice
>
> org.apache.servicecomb.serviceregistry.ServiceRegistry#getRemoteMicroservice旁边加上getAggregatedRemoteMicroervice
>
> org.apache.servicecomb.serviceregistry.client.ServiceRegistryClient#getSchema旁边加getAggregatedSchema
> 都加上java doc注释，描述以下信息：
> 1）连接普通ServiceCenter时，效果等同于不带Aggregagit chected的信息
> 2）连接ServiceCenter
> Aggregator时，表示获取范围不仅仅局限在本ServiceCenter中，还包括其他ServiceCenter集群
> 向ServiceCenter发RESTful请求时，Aggregated的版本是在query参数部分加上global=true
> 2.搜索旧接口的所有引用
>所有在服务发现流程中对它们的调用，都需要切换为Aggregated版本
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (SCB-1039) Add interface to compatible with ServiceCenter Aggregator
[ https://issues.apache.org/jira/browse/SCB-1039?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16697680#comment-16697680 ] ASF GitHub Bot commented on SCB-1039: - coveralls edited a comment on issue #1007: [SCB-1039]Add interface to compatible with ServiceCenter Aggregator URL: https://github.com/apache/servicecomb-java-chassis/pull/1007#issuecomment-441339625 [](https://coveralls.io/builds/20268045) Coverage increased (+0.007%) to 86.778% when pulling **0dc0080e68af549ee1b2c0b1a1401d7aea5ec2bc on heyile:aggregated** into **ca4dea29d6a4c72cdebf28185c435ea69b7259dd on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Add interface to compatible with ServiceCenter Aggregator > - > > Key: SCB-1039 > URL: https://issues.apache.org/jira/browse/SCB-1039 > Project: Apache ServiceComb > Issue Type: Improvement > Components: Java-Chassis >Reporter: 何一乐 >Assignee: 何一乐 >Priority: Major > > 1.增加几个接口 > > org.apache.servicecomb.serviceregistry.client.ServiceRegistryClient#getMicroservice旁边加getAggregatedMicroervice > > org.apache.servicecomb.serviceregistry.ServiceRegistry#getRemoteMicroservice旁边加上getAggregatedRemoteMicroervice > > org.apache.servicecomb.serviceregistry.client.ServiceRegistryClient#getSchema旁边加getAggregatedSchema > 都加上java doc注释，描述以下信息： > 1）连接普通ServiceCenter时，效果等同于不带Aggregagit chected的信息 > 2）连接ServiceCenter > Aggregator时，表示获取范围不仅仅局限在本ServiceCenter中，还包括其他ServiceCenter集群 > 向ServiceCenter发RESTful请求时，Aggregated的版本是在query参数部分加上global=true > 2.搜索旧接口的所有引用 >所有在服务发现流程中对它们的调用，都需要切换为Aggregated版本 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-1035) Update third party licenses for java-chassis
[ https://issues.apache.org/jira/browse/SCB-1035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16697679#comment-16697679 ] ASF GitHub Bot commented on SCB-1035: - coveralls edited a comment on issue #1000: [SCB-1035] Update license and notice for third parties URL: https://github.com/apache/servicecomb-java-chassis/pull/1000#issuecomment-440904072 [](https://coveralls.io/builds/20267999) Coverage decreased (-86.8%) to 0.0% when pulling **8b94bb44f24e70e4d8ae62be257b612a34c8c7ff on yangbor:master** into **ca4dea29d6a4c72cdebf28185c435ea69b7259dd on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Update third party licenses for java-chassis > > > Key: SCB-1035 > URL: https://issues.apache.org/jira/browse/SCB-1035 > Project: Apache ServiceComb > Issue Type: Task > Components: Java-Chassis >Affects Versions: java-chassis-1.1.0 >Reporter: Yang Bo >Assignee: Yang Bo >Priority: Major > Fix For: java-chassis-1.1.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-1031) The Response's properties was overrided wrong between @APIOperation and @Resoponse on the controller method
[
https://issues.apache.org/jira/browse/SCB-1031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16697673#comment-16697673
]
ASF GitHub Bot commented on SCB-1031:
-
coveralls edited a comment on issue #999: [SCB-1031] resolve @ApiOperator
@Response override wrong, if the prev…
URL:
https://github.com/apache/servicecomb-java-chassis/pull/999#issuecomment-440630826
[](https://coveralls.io/builds/20267841)
Coverage decreased (-0.006%) to 86.766% when pulling
**21dbd38bab549c159de3ce265602b29b8a32d973 on jeho0815:Branch_master_SCB-1031**
into **ca4dea29d6a4c72cdebf28185c435ea69b7259dd on apache:master**.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> The Response's properties was overrided wrong between @APIOperation and
> @Resoponse on the controller method
> ---
>
> Key: SCB-1031
> URL: https://issues.apache.org/jira/browse/SCB-1031
> Project: Apache ServiceComb
> Issue Type: Improvement
> Components: Java-Chassis
>Reporter: jeho0815
>Assignee: jeho0815
>Priority: Major
>
> @ApiResponse(code = 200, message = "200 is ok", response =
> String.class, responseHeaders = @ResponseHeader(name = "x-user-domain",
> response = String.class))
> @ApiOperation(nickname="getHelloworld", value="test", notes="this is a
> test", response = Integer.class, code = 200,
> responseHeaders =
> {@ResponseHeader(name = "x-user-name", response = String.class),
> @ResponseHeader(name = "x-user-id", response = String.class)}
> )
>
> swagger 's response's descritpion will be default "resoponse of 200", the
> best descritpion should be "200 is ok"
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (SCB-1041) scctl version command does not print sc verison
[
https://issues.apache.org/jira/browse/SCB-1041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16697637#comment-16697637
]
ASF GitHub Bot commented on SCB-1041:
-
asifdxtreme closed pull request #499: SCB-1041 scctl version command does not
print sc verison
URL: https://github.com/apache/servicecomb-service-center/pull/499
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/scctl/pkg/plugin/version/cmd.go b/scctl/pkg/plugin/version/cmd.go
index 877d23b2..8492071e 100644
--- a/scctl/pkg/plugin/version/cmd.go
+++ b/scctl/pkg/plugin/version/cmd.go
@@ -52,8 +52,8 @@ func VersionCommandFunc(_ *cobra.Command, _ []string) {
if err != nil {
return
}
- v, err := scClient.GetScVersion(context.Background())
- if err != nil {
+ v, scErr := scClient.GetScVersion(context.Background())
+ if scErr != nil {
return
}
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> scctl version command does not print sc verison
> ---
>
> Key: SCB-1041
> URL: https://issues.apache.org/jira/browse/SCB-1041
> Project: Apache ServiceComb
> Issue Type: Bug
> Components: Service-Center
>Reporter: little-cui
>Assignee: little-cui
>Priority: Major
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (SCB-993) Bug fixes
[ https://issues.apache.org/jira/browse/SCB-993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16697636#comment-16697636 ] ASF GitHub Bot commented on SCB-993: asifdxtreme closed pull request #498: SCB-993 Add the requirement of scctl URL: https://github.com/apache/servicecomb-service-center/pull/498 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/frontend/Readme.md b/frontend/Readme.md index 79c86ac7..9bb56b56 100644 --- a/frontend/Readme.md +++ b/frontend/Readme.md @@ -5,7 +5,8 @@ Service-Center UI also offers a unique feature of testing the Schemas of their M ### QuickStart Guide -Easiest way to get started with Service-Center UI is to download the release from [here](https://dist.apache.org/repos/dist/dev/incubator/servicecomb/incubator-servicecomb-service-center/) and then untar/unzip it based on your OS and run start-frontend.sh/start-frontend.bat. +Easiest way to get started with Service-Center UI is to download the release from +[`here`](http://servicecomb.apache.org/release/) and then untar/unzip it based on your OS and run start-frontend.sh/start-frontend.bat. This will bring up the Service-Center UI on [http://127.0.0.1:30103](http://127.0.0.1:30103). Windows(apache-servicecomb-service-center-XXX-windows-amd64.zip): diff --git a/scctl/README.md b/scctl/README.md index 5b5cfca9..b9431f08 100644 --- a/scctl/README.md +++ b/scctl/README.md @@ -1,13 +1,13 @@ ## scctl -`scctl` enables user to view the list of MicroServices registered in SC. +`scctl` enables user to view the list of MicroServices registered in service center(version 1.1.0+). You can view all the commands from [here](/scctl/pkg/plugin/README.md) ### QuickStart Guide # Install Easiest way to get started with `scctl` is to download the release -from [here](https://dist.apache.org/repos/dist/dev/incubator/servicecomb/incubator-servicecomb-service-center/) +from [`here`](http://servicecomb.apache.org/release/) and then untar/unzip it based on your OS. # Check the version diff --git a/scctl/pkg/plugin/README.md b/scctl/pkg/plugin/README.md index e244676e..d72dc5ba 100644 --- a/scctl/pkg/plugin/README.md +++ b/scctl/pkg/plugin/README.md @@ -1,7 +1,7 @@ scctl -`scctl` is a command line client for service center. +`scctl` is a command line client for service center(version 1.1.0+). ## Global options This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Bug fixes > - > > Key: SCB-993 > URL: https://issues.apache.org/jira/browse/SCB-993 > Project: Apache ServiceComb > Issue Type: Bug > Components: Service-Center >Reporter: little-cui >Assignee: little-cui >Priority: Major > Fix For: service-center-1.1.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-1039) Add interface to compatible with ServiceCenter Aggregator
[
https://issues.apache.org/jira/browse/SCB-1039?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16697628#comment-16697628
]
ASF GitHub Bot commented on SCB-1039:
-
wujimin commented on a change in pull request #1007: [SCB-1039]Add interface to
compatible with ServiceCenter Aggregator
URL:
https://github.com/apache/servicecomb-java-chassis/pull/1007#discussion_r236031524
##
File path:
service-registry/src/main/java/org/apache/servicecomb/serviceregistry/client/http/ServiceRegistryClientImpl.java
##
@@ -795,7 +841,7 @@ public ServiceCenterInfo getServiceCenterInfo() {
CountDownLatch countDownLatch = new CountDownLatch(1);
RestUtils.get(ipPort,
Const.REGISTRY_API.SERVICECENTER_VERSION,
-new RequestParam(),
+new RequestParam().addQueryParam("global", "true"),
Review comment:
no need to add global
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Add interface to compatible with ServiceCenter Aggregator
> -
>
> Key: SCB-1039
> URL: https://issues.apache.org/jira/browse/SCB-1039
> Project: Apache ServiceComb
> Issue Type: Improvement
> Components: Java-Chassis
>Reporter: 何一乐
>Assignee: 何一乐
>Priority: Major
>
> 1.增加几个接口
>
> org.apache.servicecomb.serviceregistry.client.ServiceRegistryClient#getMicroservice旁边加getAggregatedMicroervice
>
> org.apache.servicecomb.serviceregistry.ServiceRegistry#getRemoteMicroservice旁边加上getAggregatedRemoteMicroervice
>
> org.apache.servicecomb.serviceregistry.client.ServiceRegistryClient#getSchema旁边加getAggregatedSchema
> 都加上java doc注释，描述以下信息：
> 1）连接普通ServiceCenter时，效果等同于不带Aggregagit chected的信息
> 2）连接ServiceCenter
> Aggregator时，表示获取范围不仅仅局限在本ServiceCenter中，还包括其他ServiceCenter集群
> 向ServiceCenter发RESTful请求时，Aggregated的版本是在query参数部分加上global=true
> 2.搜索旧接口的所有引用
>所有在服务发现流程中对它们的调用，都需要切换为Aggregated版本
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (SCB-1039) Add interface to compatible with ServiceCenter Aggregator
[
https://issues.apache.org/jira/browse/SCB-1039?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16697627#comment-16697627
]
ASF GitHub Bot commented on SCB-1039:
-
heyile commented on a change in pull request #1007: [SCB-1039]Add interface to
compatible with ServiceCenter Aggregator
URL:
https://github.com/apache/servicecomb-java-chassis/pull/1007#discussion_r236031009
##
File path:
service-registry/src/main/java/org/apache/servicecomb/serviceregistry/RegistryUtils.java
##
@@ -216,7 +216,7 @@ public static boolean updateInstanceProperties(Map instancePrope
}
public static Microservice getMicroservice(String microserviceId) {
-return serviceRegistry.getRemoteMicroservice(microserviceId);
+return serviceRegistry.getAggregatedRemoteMicroervice(microserviceId);
Review comment:
if change this... the method
org.apache.servicecomb.serviceregistry#Microservice
getAggregatedRemoteMicrservice(String microserviceId) will never be invoked?
should I delete this method...
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Add interface to compatible with ServiceCenter Aggregator
> -
>
> Key: SCB-1039
> URL: https://issues.apache.org/jira/browse/SCB-1039
> Project: Apache ServiceComb
> Issue Type: Improvement
> Components: Java-Chassis
>Reporter: 何一乐
>Assignee: 何一乐
>Priority: Major
>
> 1.增加几个接口
>
> org.apache.servicecomb.serviceregistry.client.ServiceRegistryClient#getMicroservice旁边加getAggregatedMicroervice
>
> org.apache.servicecomb.serviceregistry.ServiceRegistry#getRemoteMicroservice旁边加上getAggregatedRemoteMicroervice
>
> org.apache.servicecomb.serviceregistry.client.ServiceRegistryClient#getSchema旁边加getAggregatedSchema
> 都加上java doc注释，描述以下信息：
> 1）连接普通ServiceCenter时，效果等同于不带Aggregagit chected的信息
> 2）连接ServiceCenter
> Aggregator时，表示获取范围不仅仅局限在本ServiceCenter中，还包括其他ServiceCenter集群
> 向ServiceCenter发RESTful请求时，Aggregated的版本是在query参数部分加上global=true
> 2.搜索旧接口的所有引用
>所有在服务发现流程中对它们的调用，都需要切换为Aggregated版本
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (SCB-1039) Add interface to compatible with ServiceCenter Aggregator
[
https://issues.apache.org/jira/browse/SCB-1039?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16697624#comment-16697624
]
ASF GitHub Bot commented on SCB-1039:
-
heyile commented on a change in pull request #1007: [SCB-1039]Add interface to
compatible with ServiceCenter Aggregator
URL:
https://github.com/apache/servicecomb-java-chassis/pull/1007#discussion_r236031194
##
File path:
service-registry/src/main/java/org/apache/servicecomb/serviceregistry/client/http/ServiceRegistryClientImpl.java
##
@@ -356,6 +356,30 @@ public String getSchema(String microserviceId, String
schemaId) {
syncHandler(countDownLatch, GetSchemaResponse.class, holder));
try {
countDownLatch.await();
+} catch (Exception e) {
+ LOGGER.error("query schema exist {}/{} failed",
+ schemaId,
+ e);
+}
+if (holder.value != null) {
+ return holder.value.getSchema();
+}
+
+return null;
+ }
+
+ @Override
+ public String getAggregatedSchema(String microserviceId, String schemaId) {
+Holder holder = new Holder<>();
Review comment:
ok
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Add interface to compatible with ServiceCenter Aggregator
> -
>
> Key: SCB-1039
> URL: https://issues.apache.org/jira/browse/SCB-1039
> Project: Apache ServiceComb
> Issue Type: Improvement
> Components: Java-Chassis
>Reporter: 何一乐
>Assignee: 何一乐
>Priority: Major
>
> 1.增加几个接口
>
> org.apache.servicecomb.serviceregistry.client.ServiceRegistryClient#getMicroservice旁边加getAggregatedMicroervice
>
> org.apache.servicecomb.serviceregistry.ServiceRegistry#getRemoteMicroservice旁边加上getAggregatedRemoteMicroervice
>
> org.apache.servicecomb.serviceregistry.client.ServiceRegistryClient#getSchema旁边加getAggregatedSchema
> 都加上java doc注释，描述以下信息：
> 1）连接普通ServiceCenter时，效果等同于不带Aggregagit chected的信息
> 2）连接ServiceCenter
> Aggregator时，表示获取范围不仅仅局限在本ServiceCenter中，还包括其他ServiceCenter集群
> 向ServiceCenter发RESTful请求时，Aggregated的版本是在query参数部分加上global=true
> 2.搜索旧接口的所有引用
>所有在服务发现流程中对它们的调用，都需要切换为Aggregated版本
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (SCB-968) [SCB-968]968 http2 do not support pump download
[ https://issues.apache.org/jira/browse/SCB-968?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16697625#comment-16697625 ] ASF GitHub Bot commented on SCB-968: coveralls edited a comment on issue #1001: [SCB-968]968 http2 do not support pump download URL: https://github.com/apache/servicecomb-java-chassis/pull/1001#issuecomment-441018970 [](https://coveralls.io/builds/20267205) Coverage decreased (-0.03%) to 86.74% when pulling **f7bb7606bb5d31d9f4d6602969af2c17afec8f35 on heyile:h2PumpDownload** into **ca4dea29d6a4c72cdebf28185c435ea69b7259dd on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > [SCB-968]968 http2 do not support pump download > --- > > Key: SCB-968 > URL: https://issues.apache.org/jira/browse/SCB-968 > Project: Apache ServiceComb > Issue Type: Bug > Components: Java-Chassis >Reporter: 何一乐 >Priority: Major > > when use http2 settings, TestDownload in demo will throw a can not save zero > bytes exception. as the last item in pending stack is empty string "" -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-968) [SCB-968]968 http2 do not support pump download
[ https://issues.apache.org/jira/browse/SCB-968?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16697626#comment-16697626 ] ASF GitHub Bot commented on SCB-968: coveralls edited a comment on issue #1001: [SCB-968]968 http2 do not support pump download URL: https://github.com/apache/servicecomb-java-chassis/pull/1001#issuecomment-441018970 [](https://coveralls.io/builds/20267204) Coverage decreased (-0.04%) to 86.736% when pulling **f7bb7606bb5d31d9f4d6602969af2c17afec8f35 on heyile:h2PumpDownload** into **ca4dea29d6a4c72cdebf28185c435ea69b7259dd on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > [SCB-968]968 http2 do not support pump download > --- > > Key: SCB-968 > URL: https://issues.apache.org/jira/browse/SCB-968 > Project: Apache ServiceComb > Issue Type: Bug > Components: Java-Chassis >Reporter: 何一乐 >Priority: Major > > when use http2 settings, TestDownload in demo will throw a can not save zero > bytes exception. as the last item in pending stack is empty string "" -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-1039) Add interface to compatible with ServiceCenter Aggregator
[
https://issues.apache.org/jira/browse/SCB-1039?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16697621#comment-16697621
]
ASF GitHub Bot commented on SCB-1039:
-
heyile commented on a change in pull request #1007: [SCB-1039]Add interface to
compatible with ServiceCenter Aggregator
URL:
https://github.com/apache/servicecomb-java-chassis/pull/1007#discussion_r236031009
##
File path:
service-registry/src/main/java/org/apache/servicecomb/serviceregistry/RegistryUtils.java
##
@@ -216,7 +216,7 @@ public static boolean updateInstanceProperties(Map instancePrope
}
public static Microservice getMicroservice(String microserviceId) {
-return serviceRegistry.getRemoteMicroservice(microserviceId);
+return serviceRegistry.getAggregatedRemoteMicroervice(microserviceId);
Review comment:
if change this... the method
org.apache.servicecomb.serviceregistry#Microservice
getAggregatedRemoteMicrservice(String microserviceId) will never be invoked?
can I delete the method...
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Add interface to compatible with ServiceCenter Aggregator
> -
>
> Key: SCB-1039
> URL: https://issues.apache.org/jira/browse/SCB-1039
> Project: Apache ServiceComb
> Issue Type: Improvement
> Components: Java-Chassis
>Reporter: 何一乐
>Assignee: 何一乐
>Priority: Major
>
> 1.增加几个接口
>
> org.apache.servicecomb.serviceregistry.client.ServiceRegistryClient#getMicroservice旁边加getAggregatedMicroervice
>
> org.apache.servicecomb.serviceregistry.ServiceRegistry#getRemoteMicroservice旁边加上getAggregatedRemoteMicroervice
>
> org.apache.servicecomb.serviceregistry.client.ServiceRegistryClient#getSchema旁边加getAggregatedSchema
> 都加上java doc注释，描述以下信息：
> 1）连接普通ServiceCenter时，效果等同于不带Aggregagit chected的信息
> 2）连接ServiceCenter
> Aggregator时，表示获取范围不仅仅局限在本ServiceCenter中，还包括其他ServiceCenter集群
> 向ServiceCenter发RESTful请求时，Aggregated的版本是在query参数部分加上global=true
> 2.搜索旧接口的所有引用
>所有在服务发现流程中对它们的调用，都需要切换为Aggregated版本
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (SCB-1039) Add interface to compatible with ServiceCenter Aggregator
[
https://issues.apache.org/jira/browse/SCB-1039?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16697622#comment-16697622
]
ASF GitHub Bot commented on SCB-1039:
-
heyile commented on a change in pull request #1007: [SCB-1039]Add interface to
compatible with ServiceCenter Aggregator
URL:
https://github.com/apache/servicecomb-java-chassis/pull/1007#discussion_r236031009
##
File path:
service-registry/src/main/java/org/apache/servicecomb/serviceregistry/RegistryUtils.java
##
@@ -216,7 +216,7 @@ public static boolean updateInstanceProperties(Map instancePrope
}
public static Microservice getMicroservice(String microserviceId) {
-return serviceRegistry.getRemoteMicroservice(microserviceId);
+return serviceRegistry.getAggregatedRemoteMicroervice(microserviceId);
Review comment:
if change this... the method
org.apache.servicecomb.serviceregistry#Microservice
getAggregatedRemoteMicrservice(String microserviceId) will never be invoked?
should I delete this method...
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Add interface to compatible with ServiceCenter Aggregator
> -
>
> Key: SCB-1039
> URL: https://issues.apache.org/jira/browse/SCB-1039
> Project: Apache ServiceComb
> Issue Type: Improvement
> Components: Java-Chassis
>Reporter: 何一乐
>Assignee: 何一乐
>Priority: Major
>
> 1.增加几个接口
>
> org.apache.servicecomb.serviceregistry.client.ServiceRegistryClient#getMicroservice旁边加getAggregatedMicroervice
>
> org.apache.servicecomb.serviceregistry.ServiceRegistry#getRemoteMicroservice旁边加上getAggregatedRemoteMicroervice
>
> org.apache.servicecomb.serviceregistry.client.ServiceRegistryClient#getSchema旁边加getAggregatedSchema
> 都加上java doc注释，描述以下信息：
> 1）连接普通ServiceCenter时，效果等同于不带Aggregagit chected的信息
> 2）连接ServiceCenter
> Aggregator时，表示获取范围不仅仅局限在本ServiceCenter中，还包括其他ServiceCenter集群
> 向ServiceCenter发RESTful请求时，Aggregated的版本是在query参数部分加上global=true
> 2.搜索旧接口的所有引用
>所有在服务发现流程中对它们的调用，都需要切换为Aggregated版本
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (SCB-968) [SCB-968]968 http2 do not support pump download
[
https://issues.apache.org/jira/browse/SCB-968?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16697617#comment-16697617
]
ASF GitHub Bot commented on SCB-968:
heyile closed pull request #1001: [SCB-968]968 http2 do not support pump
download
URL: https://github.com/apache/servicecomb-java-chassis/pull/1001
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/foundations/foundation-vertx/src/main/java/org/apache/servicecomb/foundation/vertx/stream/PumpFactoryImpl.java
b/foundations/foundation-vertx/src/main/java/org/apache/servicecomb/foundation/vertx/stream/PumpFactoryImpl.java
new file mode 100644
index 0..c3284e301
--- /dev/null
+++
b/foundations/foundation-vertx/src/main/java/org/apache/servicecomb/foundation/vertx/stream/PumpFactoryImpl.java
@@ -0,0 +1,40 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.servicecomb.foundation.vertx.stream;
+
+import java.util.Objects;
+
+import io.vertx.core.spi.PumpFactory;
+import io.vertx.core.streams.Pump;
+import io.vertx.core.streams.ReadStream;
+import io.vertx.core.streams.WriteStream;
+
+public class PumpFactoryImpl implements PumpFactory {
+ @Override
+ public Pump pump(ReadStream rs, WriteStream ws) {
+Objects.requireNonNull(rs);
+Objects.requireNonNull(ws);
+return new PumpImpl<>(rs, ws);
+ }
+
+ @Override
+ public Pump pump(ReadStream rs, WriteStream ws, int
writeQueueMaxSize) {
+Objects.requireNonNull(rs);
+Objects.requireNonNull(ws);
+return new PumpImpl<>(rs, ws, writeQueueMaxSize);
+ }
+}
\ No newline at end of file
diff --git
a/foundations/foundation-vertx/src/main/java/org/apache/servicecomb/foundation/vertx/stream/PumpImpl.java
b/foundations/foundation-vertx/src/main/java/org/apache/servicecomb/foundation/vertx/stream/PumpImpl.java
new file mode 100644
index 0..3657e7378
--- /dev/null
+++
b/foundations/foundation-vertx/src/main/java/org/apache/servicecomb/foundation/vertx/stream/PumpImpl.java
@@ -0,0 +1,108 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.servicecomb.foundation.vertx.stream;
+
+import io.vertx.core.Handler;
+import io.vertx.core.buffer.Buffer;
+import io.vertx.core.streams.Pump;
+import io.vertx.core.streams.ReadStream;
+import io.vertx.core.streams.WriteStream;
+
+public class PumpImpl implements Pump {
+
+ private final ReadStream readStream;
+
+ private final WriteStream writeStream;
+
+ private final Handler dataHandler;
+
+ private final Handler drainHandler;
+
+ private int pumped;
+
+ public PumpImpl(ReadStream readStream, WriteStream writeStream, int
maxWriteQueueSize) {
+this(readStream, writeStream);
+this.writeStream.setWriteQueueMaxSize(maxWriteQueueSize);
+ }
+
+ public PumpImpl(ReadStream readStream, WriteStream writeStream) {
+this.readStream = readStream;
+this.writeStream = writeStream;
+drainHandler = v -> readStream.resume();
+dataHandler = data -> {
+ if (data instanceof Buffer) {
+if (((Buffer) data).length() == 0) {
+ return;
+}
+ }
+ writeStream.write(data);
+ incPumped();
+ if (writeStream.writeQueueFull()) {
+
[jira] [Commented] (SCB-1039) Add interface to compatible with ServiceCenter Aggregator
[
https://issues.apache.org/jira/browse/SCB-1039?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16697619#comment-16697619
]
ASF GitHub Bot commented on SCB-1039:
-
heyile commented on a change in pull request #1007: [SCB-1039]Add interface to
compatible with ServiceCenter Aggregator
URL:
https://github.com/apache/servicecomb-java-chassis/pull/1007#discussion_r236030963
##
File path:
service-registry/src/main/java/org/apache/servicecomb/serviceregistry/client/http/ServiceRegistryClientImpl.java
##
@@ -489,7 +534,7 @@ public String
registerMicroserviceInstance(MicroserviceInstance instance) {
CountDownLatch countDownLatch = new CountDownLatch(1);
RestUtils.get(ipPort,
String.format(Const.REGISTRY_API.MICROSERVICE_INSTANCE_OPERATION_ALL,
providerId),
-new RequestParam().addHeader("X-ConsumerId", consumerId),
+new RequestParam().addHeader("X-ConsumerId",
consumerId).addQueryParam("global", "true"),
Review comment:
ok
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Add interface to compatible with ServiceCenter Aggregator
> -
>
> Key: SCB-1039
> URL: https://issues.apache.org/jira/browse/SCB-1039
> Project: Apache ServiceComb
> Issue Type: Improvement
> Components: Java-Chassis
>Reporter: 何一乐
>Assignee: 何一乐
>Priority: Major
>
> 1.增加几个接口
>
> org.apache.servicecomb.serviceregistry.client.ServiceRegistryClient#getMicroservice旁边加getAggregatedMicroervice
>
> org.apache.servicecomb.serviceregistry.ServiceRegistry#getRemoteMicroservice旁边加上getAggregatedRemoteMicroervice
>
> org.apache.servicecomb.serviceregistry.client.ServiceRegistryClient#getSchema旁边加getAggregatedSchema
> 都加上java doc注释，描述以下信息：
> 1）连接普通ServiceCenter时，效果等同于不带Aggregagit chected的信息
> 2）连接ServiceCenter
> Aggregator时，表示获取范围不仅仅局限在本ServiceCenter中，还包括其他ServiceCenter集群
> 向ServiceCenter发RESTful请求时，Aggregated的版本是在query参数部分加上global=true
> 2.搜索旧接口的所有引用
>所有在服务发现流程中对它们的调用，都需要切换为Aggregated版本
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (SCB-968) [SCB-968]968 http2 do not support pump download
[ https://issues.apache.org/jira/browse/SCB-968?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16697618#comment-16697618 ] ASF GitHub Bot commented on SCB-968: heyile opened a new pull request #1001: [SCB-968]968 http2 do not support pump download URL: https://github.com/apache/servicecomb-java-chassis/pull/1001 Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/SCB) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [ ] Each commit in the pull request should have a meaningful subject line and body. - [ ] Format the pull request title like `[SCB-XXX] Fixes bug in ApproximateQuantiles`, where you replace `SCB-XXX` with the appropriate JIRA issue. - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [ ] Run `mvn clean install` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). --- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > [SCB-968]968 http2 do not support pump download > --- > > Key: SCB-968 > URL: https://issues.apache.org/jira/browse/SCB-968 > Project: Apache ServiceComb > Issue Type: Bug > Components: Java-Chassis >Reporter: 何一乐 >Priority: Major > > when use http2 settings, TestDownload in demo will throw a can not save zero > bytes exception. as the last item in pending stack is empty string "" -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-1039) Add interface to compatible with ServiceCenter Aggregator
[ https://issues.apache.org/jira/browse/SCB-1039?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16697616#comment-16697616 ] ASF GitHub Bot commented on SCB-1039: - coveralls commented on issue #1007: [SCB-1039]Add interface to compatible with ServiceCenter Aggregator URL: https://github.com/apache/servicecomb-java-chassis/pull/1007#issuecomment-441339625 [](https://coveralls.io/builds/20267115) Coverage decreased (-0.03%) to 86.744% when pulling **b21e7d6cc1cd18acdf8f6813f0103730d5101cca on heyile:aggregated** into **ca4dea29d6a4c72cdebf28185c435ea69b7259dd on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Add interface to compatible with ServiceCenter Aggregator > - > > Key: SCB-1039 > URL: https://issues.apache.org/jira/browse/SCB-1039 > Project: Apache ServiceComb > Issue Type: Improvement > Components: Java-Chassis >Reporter: 何一乐 >Assignee: 何一乐 >Priority: Major > > 1.增加几个接口 > > org.apache.servicecomb.serviceregistry.client.ServiceRegistryClient#getMicroservice旁边加getAggregatedMicroervice > > org.apache.servicecomb.serviceregistry.ServiceRegistry#getRemoteMicroservice旁边加上getAggregatedRemoteMicroervice > > org.apache.servicecomb.serviceregistry.client.ServiceRegistryClient#getSchema旁边加getAggregatedSchema > 都加上java doc注释，描述以下信息： > 1）连接普通ServiceCenter时，效果等同于不带Aggregagit chected的信息 > 2）连接ServiceCenter > Aggregator时，表示获取范围不仅仅局限在本ServiceCenter中，还包括其他ServiceCenter集群 > 向ServiceCenter发RESTful请求时，Aggregated的版本是在query参数部分加上global=true > 2.搜索旧接口的所有引用 >所有在服务发现流程中对它们的调用，都需要切换为Aggregated版本 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-1039) Add interface to compatible with ServiceCenter Aggregator
[
https://issues.apache.org/jira/browse/SCB-1039?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16697615#comment-16697615
]
ASF GitHub Bot commented on SCB-1039:
-
wujimin commented on a change in pull request #1007: [SCB-1039]Add interface to
compatible with ServiceCenter Aggregator
URL:
https://github.com/apache/servicecomb-java-chassis/pull/1007#discussion_r236030836
##
File path:
service-registry/src/main/java/org/apache/servicecomb/serviceregistry/client/http/ServiceRegistryClientImpl.java
##
@@ -489,7 +534,7 @@ public String
registerMicroserviceInstance(MicroserviceInstance instance) {
CountDownLatch countDownLatch = new CountDownLatch(1);
RestUtils.get(ipPort,
String.format(Const.REGISTRY_API.MICROSERVICE_INSTANCE_OPERATION_ALL,
providerId),
-new RequestParam().addHeader("X-ConsumerId", consumerId),
+new RequestParam().addHeader("X-ConsumerId",
consumerId).addQueryParam("global", "true"),
Review comment:
no need to add global
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Add interface to compatible with ServiceCenter Aggregator
> -
>
> Key: SCB-1039
> URL: https://issues.apache.org/jira/browse/SCB-1039
> Project: Apache ServiceComb
> Issue Type: Improvement
> Components: Java-Chassis
>Reporter: 何一乐
>Assignee: 何一乐
>Priority: Major
>
> 1.增加几个接口
>
> org.apache.servicecomb.serviceregistry.client.ServiceRegistryClient#getMicroservice旁边加getAggregatedMicroervice
>
> org.apache.servicecomb.serviceregistry.ServiceRegistry#getRemoteMicroservice旁边加上getAggregatedRemoteMicroervice
>
> org.apache.servicecomb.serviceregistry.client.ServiceRegistryClient#getSchema旁边加getAggregatedSchema
> 都加上java doc注释，描述以下信息：
> 1）连接普通ServiceCenter时，效果等同于不带Aggregagit chected的信息
> 2）连接ServiceCenter
> Aggregator时，表示获取范围不仅仅局限在本ServiceCenter中，还包括其他ServiceCenter集群
> 向ServiceCenter发RESTful请求时，Aggregated的版本是在query参数部分加上global=true
> 2.搜索旧接口的所有引用
>所有在服务发现流程中对它们的调用，都需要切换为Aggregated版本
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (SCB-1039) Add interface to compatible with ServiceCenter Aggregator
[
https://issues.apache.org/jira/browse/SCB-1039?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16697614#comment-16697614
]
ASF GitHub Bot commented on SCB-1039:
-
wujimin commented on a change in pull request #1007: [SCB-1039]Add interface to
compatible with ServiceCenter Aggregator
URL:
https://github.com/apache/servicecomb-java-chassis/pull/1007#discussion_r236030818
##
File path:
service-registry/src/main/java/org/apache/servicecomb/serviceregistry/client/http/ServiceRegistryClientImpl.java
##
@@ -356,6 +356,30 @@ public String getSchema(String microserviceId, String
schemaId) {
syncHandler(countDownLatch, GetSchemaResponse.class, holder));
try {
countDownLatch.await();
+} catch (Exception e) {
+ LOGGER.error("query schema exist {}/{} failed",
+ schemaId,
+ e);
+}
+if (holder.value != null) {
+ return holder.value.getSchema();
+}
+
+return null;
+ }
+
+ @Override
+ public String getAggregatedSchema(String microserviceId, String schemaId) {
+Holder holder = new Holder<>();
Review comment:
do not copy code
just make global to be a parameter
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Add interface to compatible with ServiceCenter Aggregator
> -
>
> Key: SCB-1039
> URL: https://issues.apache.org/jira/browse/SCB-1039
> Project: Apache ServiceComb
> Issue Type: Improvement
> Components: Java-Chassis
>Reporter: 何一乐
>Assignee: 何一乐
>Priority: Major
>
> 1.增加几个接口
>
> org.apache.servicecomb.serviceregistry.client.ServiceRegistryClient#getMicroservice旁边加getAggregatedMicroervice
>
> org.apache.servicecomb.serviceregistry.ServiceRegistry#getRemoteMicroservice旁边加上getAggregatedRemoteMicroervice
>
> org.apache.servicecomb.serviceregistry.client.ServiceRegistryClient#getSchema旁边加getAggregatedSchema
> 都加上java doc注释，描述以下信息：
> 1）连接普通ServiceCenter时，效果等同于不带Aggregagit chected的信息
> 2）连接ServiceCenter
> Aggregator时，表示获取范围不仅仅局限在本ServiceCenter中，还包括其他ServiceCenter集群
> 向ServiceCenter发RESTful请求时，Aggregated的版本是在query参数部分加上global=true
> 2.搜索旧接口的所有引用
>所有在服务发现流程中对它们的调用，都需要切换为Aggregated版本
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (SCB-1039) Add interface to compatible with ServiceCenter Aggregator
[
https://issues.apache.org/jira/browse/SCB-1039?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16697613#comment-16697613
]
ASF GitHub Bot commented on SCB-1039:
-
wujimin commented on a change in pull request #1007: [SCB-1039]Add interface to
compatible with ServiceCenter Aggregator
URL:
https://github.com/apache/servicecomb-java-chassis/pull/1007#discussion_r236030804
##
File path:
service-registry/src/main/java/org/apache/servicecomb/serviceregistry/client/LocalServiceRegistryClientImpl.java
##
@@ -188,6 +188,11 @@ public Microservice getMicroservice(String
microserviceId) {
return microserviceIdMap.get(microserviceId);
}
+ @Override
+ public Microservice getAggregatedMicroservice(String microserviceId) {
+return microserviceIdMap.get(microserviceId);
Review comment:
do not copy code
just invoke getMicroservice
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Add interface to compatible with ServiceCenter Aggregator
> -
>
> Key: SCB-1039
> URL: https://issues.apache.org/jira/browse/SCB-1039
> Project: Apache ServiceComb
> Issue Type: Improvement
> Components: Java-Chassis
>Reporter: 何一乐
>Assignee: 何一乐
>Priority: Major
>
> 1.增加几个接口
>
> org.apache.servicecomb.serviceregistry.client.ServiceRegistryClient#getMicroservice旁边加getAggregatedMicroervice
>
> org.apache.servicecomb.serviceregistry.ServiceRegistry#getRemoteMicroservice旁边加上getAggregatedRemoteMicroervice
>
> org.apache.servicecomb.serviceregistry.client.ServiceRegistryClient#getSchema旁边加getAggregatedSchema
> 都加上java doc注释，描述以下信息：
> 1）连接普通ServiceCenter时，效果等同于不带Aggregagit chected的信息
> 2）连接ServiceCenter
> Aggregator时，表示获取范围不仅仅局限在本ServiceCenter中，还包括其他ServiceCenter集群
> 向ServiceCenter发RESTful请求时，Aggregated的版本是在query参数部分加上global=true
> 2.搜索旧接口的所有引用
>所有在服务发现流程中对它们的调用，都需要切换为Aggregated版本
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (SCB-1039) Add interface to compatible with ServiceCenter Aggregator
[
https://issues.apache.org/jira/browse/SCB-1039?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16697612#comment-16697612
]
ASF GitHub Bot commented on SCB-1039:
-
wujimin commented on a change in pull request #1007: [SCB-1039]Add interface to
compatible with ServiceCenter Aggregator
URL:
https://github.com/apache/servicecomb-java-chassis/pull/1007#discussion_r236030797
##
File path:
service-registry/src/main/java/org/apache/servicecomb/serviceregistry/client/LocalServiceRegistryClientImpl.java
##
@@ -353,6 +358,16 @@ public String getSchema(String microserviceId, String
schemaId) {
return microservice.getSchemaMap().get(schemaId);
}
+ @Override
+ public String getAggregatedSchema(String microserviceId, String schemaId) {
Review comment:
do not copy code
just invoke getSchema
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Add interface to compatible with ServiceCenter Aggregator
> -
>
> Key: SCB-1039
> URL: https://issues.apache.org/jira/browse/SCB-1039
> Project: Apache ServiceComb
> Issue Type: Improvement
> Components: Java-Chassis
>Reporter: 何一乐
>Assignee: 何一乐
>Priority: Major
>
> 1.增加几个接口
>
> org.apache.servicecomb.serviceregistry.client.ServiceRegistryClient#getMicroservice旁边加getAggregatedMicroervice
>
> org.apache.servicecomb.serviceregistry.ServiceRegistry#getRemoteMicroservice旁边加上getAggregatedRemoteMicroervice
>
> org.apache.servicecomb.serviceregistry.client.ServiceRegistryClient#getSchema旁边加getAggregatedSchema
> 都加上java doc注释，描述以下信息：
> 1）连接普通ServiceCenter时，效果等同于不带Aggregagit chected的信息
> 2）连接ServiceCenter
> Aggregator时，表示获取范围不仅仅局限在本ServiceCenter中，还包括其他ServiceCenter集群
> 向ServiceCenter发RESTful请求时，Aggregated的版本是在query参数部分加上global=true
> 2.搜索旧接口的所有引用
>所有在服务发现流程中对它们的调用，都需要切换为Aggregated版本
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (SCB-1039) Add interface to compatible with ServiceCenter Aggregator
[ https://issues.apache.org/jira/browse/SCB-1039?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16697611#comment-16697611 ] ASF GitHub Bot commented on SCB-1039: - wujimin commented on a change in pull request #1007: [SCB-1039]Add interface to compatible with ServiceCenter Aggregator URL: https://github.com/apache/servicecomb-java-chassis/pull/1007#discussion_r236030705 ## File path: service-registry/src/main/java/org/apache/servicecomb/serviceregistry/ServiceRegistry.java ## @@ -58,6 +58,15 @@ MicroserviceInstances findServiceInstances(String appId, String microserviceName Microservice getRemoteMicroservice(String microserviceId); + /** + * + *if connect to simple ServiceCenter, same with the method Review comment: normal, not "sample"? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Add interface to compatible with ServiceCenter Aggregator > - > > Key: SCB-1039 > URL: https://issues.apache.org/jira/browse/SCB-1039 > Project: Apache ServiceComb > Issue Type: Improvement > Components: Java-Chassis >Reporter: 何一乐 >Assignee: 何一乐 >Priority: Major > > 1.增加几个接口 > > org.apache.servicecomb.serviceregistry.client.ServiceRegistryClient#getMicroservice旁边加getAggregatedMicroervice > > org.apache.servicecomb.serviceregistry.ServiceRegistry#getRemoteMicroservice旁边加上getAggregatedRemoteMicroervice > > org.apache.servicecomb.serviceregistry.client.ServiceRegistryClient#getSchema旁边加getAggregatedSchema > 都加上java doc注释，描述以下信息： > 1）连接普通ServiceCenter时，效果等同于不带Aggregagit chected的信息 > 2）连接ServiceCenter > Aggregator时，表示获取范围不仅仅局限在本ServiceCenter中，还包括其他ServiceCenter集群 > 向ServiceCenter发RESTful请求时，Aggregated的版本是在query参数部分加上global=true > 2.搜索旧接口的所有引用 >所有在服务发现流程中对它们的调用，都需要切换为Aggregated版本 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-1039) Add interface to compatible with ServiceCenter Aggregator
[
https://issues.apache.org/jira/browse/SCB-1039?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16697610#comment-16697610
]
ASF GitHub Bot commented on SCB-1039:
-
wujimin commented on a change in pull request #1007: [SCB-1039]Add interface to
compatible with ServiceCenter Aggregator
URL:
https://github.com/apache/servicecomb-java-chassis/pull/1007#discussion_r236030674
##
File path:
service-registry/src/main/java/org/apache/servicecomb/serviceregistry/RegistryUtils.java
##
@@ -216,7 +216,7 @@ public static boolean updateInstanceProperties(Map instancePrope
}
public static Microservice getMicroservice(String microserviceId) {
-return serviceRegistry.getRemoteMicroservice(microserviceId);
+return serviceRegistry.getAggregatedRemoteMicroervice(microserviceId);
Review comment:
not change this
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Add interface to compatible with ServiceCenter Aggregator
> -
>
> Key: SCB-1039
> URL: https://issues.apache.org/jira/browse/SCB-1039
> Project: Apache ServiceComb
> Issue Type: Improvement
> Components: Java-Chassis
>Reporter: 何一乐
>Assignee: 何一乐
>Priority: Major
>
> 1.增加几个接口
>
> org.apache.servicecomb.serviceregistry.client.ServiceRegistryClient#getMicroservice旁边加getAggregatedMicroervice
>
> org.apache.servicecomb.serviceregistry.ServiceRegistry#getRemoteMicroservice旁边加上getAggregatedRemoteMicroervice
>
> org.apache.servicecomb.serviceregistry.client.ServiceRegistryClient#getSchema旁边加getAggregatedSchema
> 都加上java doc注释，描述以下信息：
> 1）连接普通ServiceCenter时，效果等同于不带Aggregagit chected的信息
> 2）连接ServiceCenter
> Aggregator时，表示获取范围不仅仅局限在本ServiceCenter中，还包括其他ServiceCenter集群
> 向ServiceCenter发RESTful请求时，Aggregated的版本是在query参数部分加上global=true
> 2.搜索旧接口的所有引用
>所有在服务发现流程中对它们的调用，都需要切换为Aggregated版本
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (SCB-1039) Add interface to compatible with ServiceCenter Aggregator
[ https://issues.apache.org/jira/browse/SCB-1039?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16697609#comment-16697609 ] ASF GitHub Bot commented on SCB-1039: - heyile opened a new pull request #1007: [SCB-1039]Add interface to compatible with ServiceCenter Aggregator URL: https://github.com/apache/servicecomb-java-chassis/pull/1007 Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/SCB) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [ ] Each commit in the pull request should have a meaningful subject line and body. - [ ] Format the pull request title like `[SCB-XXX] Fixes bug in ApproximateQuantiles`, where you replace `SCB-XXX` with the appropriate JIRA issue. - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [ ] Run `mvn clean install` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). --- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Add interface to compatible with ServiceCenter Aggregator > - > > Key: SCB-1039 > URL: https://issues.apache.org/jira/browse/SCB-1039 > Project: Apache ServiceComb > Issue Type: Improvement > Components: Java-Chassis >Reporter: 何一乐 >Assignee: 何一乐 >Priority: Major > > 1.增加几个接口 > > org.apache.servicecomb.serviceregistry.client.ServiceRegistryClient#getMicroservice旁边加getAggregatedMicroervice > > org.apache.servicecomb.serviceregistry.ServiceRegistry#getRemoteMicroservice旁边加上getAggregatedRemoteMicroervice > > org.apache.servicecomb.serviceregistry.client.ServiceRegistryClient#getSchema旁边加getAggregatedSchema > 都加上java doc注释，描述以下信息： > 1）连接普通ServiceCenter时，效果等同于不带Aggregagit chected的信息 > 2）连接ServiceCenter > Aggregator时，表示获取范围不仅仅局限在本ServiceCenter中，还包括其他ServiceCenter集群 > 向ServiceCenter发RESTful请求时，Aggregated的版本是在query参数部分加上global=true > 2.搜索旧接口的所有引用 >所有在服务发现流程中对它们的调用，都需要切换为Aggregated版本 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-925) Springmvc, when have defaultValue, required should be false
[
https://issues.apache.org/jira/browse/SCB-925?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16697605#comment-16697605
]
ASF GitHub Bot commented on SCB-925:
liubao68 commented on a change in pull request #1004: [SCB-925] Springmvc, when
have defaultValue, required should be false, when param not exist, should check
isRequired
URL:
https://github.com/apache/servicecomb-java-chassis/pull/1004#discussion_r236030477
##
File path:
common/common-rest/src/main/java/org/apache/servicecomb/common/rest/codec/param/FormProcessorCreator.java
##
@@ -50,20 +52,33 @@ public Object getValue(HttpServletRequest request) {
}
if (targetType.isContainerType()) {
-return convertValue(request.getParameterValues(paramPath), targetType);
+Object values = request.getParameterValues(paramPath);
+//Even if the paramPath does not exist, it won't be null at now, may
be optimized in the future
+if (values == null) {
+ values = checkRequiredAndDefaultValue(values);
+}
+return convertValue(values, targetType);
}
Object value = request.getParameter(paramPath);
if (value == null) {
-Object defaultValue = getDefaultValue();
-if (defaultValue != null) {
- value = defaultValue;
-}
+value = checkRequiredAndDefaultValue(value);
}
return convertValue(value, targetType);
}
+private Object checkRequiredAndDefaultValue(Object values) {
+ if (isRequired()) {
+throw new InvocationException(Status.BAD_REQUEST, "Parameter is not
valid, required is true");
+ }
+ Object defaultValue = getDefaultValue();
+ if (defaultValue != null) {
+return defaultValue;
+ }
+ return values;
Review comment:
return getDefaultValue() is enouph
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Springmvc, when have defaultValue, required should be false
> ---
>
> Key: SCB-925
> URL: https://issues.apache.org/jira/browse/SCB-925
> Project: Apache ServiceComb
> Issue Type: Bug
> Components: Java-Chassis
>Reporter: WeiChao
>Assignee: WeiChao
>Priority: Major
> Fix For: java-chassis-1.1.0
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (SCB-925) Springmvc, when have defaultValue, required should be false
[
https://issues.apache.org/jira/browse/SCB-925?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16697608#comment-16697608
]
ASF GitHub Bot commented on SCB-925:
liubao68 commented on a change in pull request #1004: [SCB-925] Springmvc, when
have defaultValue, required should be false, when param not exist, should check
isRequired
URL:
https://github.com/apache/servicecomb-java-chassis/pull/1004#discussion_r236030571
##
File path:
integration-tests/it-consumer/src/main/java/org/apache/servicecomb/it/testcase/TestDefaultValue.java
##
@@ -472,12 +524,21 @@ public void floatHeader_require_springmvc_rt() {
@Test
public void floatForm_require_springmvc_intf() {
-assertEquals(defaultFloat,
consumersSpringmvc.getIntf().floatFormRequire(null), 0.0f);
+try {
+ consumersSpringmvc.getIntf().floatFormRequire(null);
+ assertEquals("required is true, throw exception", "but not throw
exception");
+} catch (Exception e) {
+ assertEquals(true, e.getMessage().contains("Parameter is not valid"));
+}
}
@Test
public void floatForm_require_springmvc_rt() {
-assertEquals(defaultFloat,
-
consumersSpringmvc.getSCBRestTemplate().postForObject("/floatFormRequire",
null, float.class), 0.0f);
+try {
+
consumersSpringmvc.getSCBRestTemplate().postForObject("/floatFormRequire",
null, float.class);
Review comment:
Is this behavior change? We need to notice in RN.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Springmvc, when have defaultValue, required should be false
> ---
>
> Key: SCB-925
> URL: https://issues.apache.org/jira/browse/SCB-925
> Project: Apache ServiceComb
> Issue Type: Bug
> Components: Java-Chassis
>Reporter: WeiChao
>Assignee: WeiChao
>Priority: Major
> Fix For: java-chassis-1.1.0
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (SCB-1043) MicroserviceVersions.safeSetInstances lost exception message
[
https://issues.apache.org/jira/browse/SCB-1043?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16697606#comment-16697606
]
ASF GitHub Bot commented on SCB-1043:
-
jeho0815 commented on a change in pull request #1006: [SCB-1043] fix bug: if
safeSetInstances throw an exception, the excep…
URL:
https://github.com/apache/servicecomb-java-chassis/pull/1006#discussion_r236030517
##
File path:
service-registry/src/main/java/org/apache/servicecomb/serviceregistry/consumer/MicroserviceVersions.java
##
@@ -160,10 +160,10 @@ protected void
safeSetInstances(List pulledInstances, Stri
setInstances(pulledInstances, rev);
validated = true;
} catch (Throwable e) {
- LOGGER.error("Failed to setInstances, appId={}, microserviceName={}.",
- getAppId(),
- getMicroserviceName(),
- e);
+ LOGGER.error(String.format("Failed to setInstances, AppId=%s,
MicroserviceName=%s.",
Review comment:
yes, i will close it.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> MicroserviceVersions.safeSetInstances lost exception message
>
>
> Key: SCB-1043
> URL: https://issues.apache.org/jira/browse/SCB-1043
> Project: Apache ServiceComb
> Issue Type: Bug
> Components: Java-Chassis
>Reporter: jeho0815
>Assignee: jeho0815
>Priority: Major
> Fix For: java-chassis-1.1.0
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (SCB-1043) MicroserviceVersions.safeSetInstances lost exception message
[
https://issues.apache.org/jira/browse/SCB-1043?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16697607#comment-16697607
]
ASF GitHub Bot commented on SCB-1043:
-
jeho0815 closed pull request #1006: [SCB-1043] fix bug: if safeSetInstances
throw an exception, the excep…
URL: https://github.com/apache/servicecomb-java-chassis/pull/1006
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/service-registry/src/main/java/org/apache/servicecomb/serviceregistry/consumer/MicroserviceVersions.java
b/service-registry/src/main/java/org/apache/servicecomb/serviceregistry/consumer/MicroserviceVersions.java
index e85c51311..5e84b3c47 100644
---
a/service-registry/src/main/java/org/apache/servicecomb/serviceregistry/consumer/MicroserviceVersions.java
+++
b/service-registry/src/main/java/org/apache/servicecomb/serviceregistry/consumer/MicroserviceVersions.java
@@ -160,10 +160,10 @@ protected void
safeSetInstances(List pulledInstances, Stri
setInstances(pulledInstances, rev);
validated = true;
} catch (Throwable e) {
- LOGGER.error("Failed to setInstances, appId={}, microserviceName={}.",
- getAppId(),
- getMicroserviceName(),
- e);
+ LOGGER.error(String.format("Failed to setInstances, AppId=%s,
MicroserviceName=%s.",
+ getAppId(),
+ getMicroserviceName()),
+ e);
}
}
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> MicroserviceVersions.safeSetInstances lost exception message
>
>
> Key: SCB-1043
> URL: https://issues.apache.org/jira/browse/SCB-1043
> Project: Apache ServiceComb
> Issue Type: Bug
> Components: Java-Chassis
>Reporter: jeho0815
>Assignee: jeho0815
>Priority: Major
> Fix For: java-chassis-1.1.0
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (SCB-925) Springmvc, when have defaultValue, required should be false
[
https://issues.apache.org/jira/browse/SCB-925?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16697604#comment-16697604
]
ASF GitHub Bot commented on SCB-925:
liubao68 commented on a change in pull request #1004: [SCB-925] Springmvc, when
have defaultValue, required should be false, when param not exist, should check
isRequired
URL:
https://github.com/apache/servicecomb-java-chassis/pull/1004#discussion_r236030465
##
File path:
common/common-rest/src/main/java/org/apache/servicecomb/common/rest/codec/param/FormProcessorCreator.java
##
@@ -50,20 +52,33 @@ public Object getValue(HttpServletRequest request) {
}
if (targetType.isContainerType()) {
-return convertValue(request.getParameterValues(paramPath), targetType);
+Object values = request.getParameterValues(paramPath);
+//Even if the paramPath does not exist, it won't be null at now, may
be optimized in the future
+if (values == null) {
+ values = checkRequiredAndDefaultValue(values);
+}
+return convertValue(values, targetType);
}
Object value = request.getParameter(paramPath);
if (value == null) {
-Object defaultValue = getDefaultValue();
-if (defaultValue != null) {
- value = defaultValue;
-}
+value = checkRequiredAndDefaultValue(value);
}
return convertValue(value, targetType);
}
+private Object checkRequiredAndDefaultValue(Object values) {
Review comment:
values is always null, no need to pass this parameter
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Springmvc, when have defaultValue, required should be false
> ---
>
> Key: SCB-925
> URL: https://issues.apache.org/jira/browse/SCB-925
> Project: Apache ServiceComb
> Issue Type: Bug
> Components: Java-Chassis
>Reporter: WeiChao
>Assignee: WeiChao
>Priority: Major
> Fix For: java-chassis-1.1.0
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (SCB-925) Springmvc, when have defaultValue, required should be false
[
https://issues.apache.org/jira/browse/SCB-925?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16697603#comment-16697603
]
ASF GitHub Bot commented on SCB-925:
liubao68 commented on a change in pull request #1004: [SCB-925] Springmvc, when
have defaultValue, required should be false, when param not exist, should check
isRequired
URL:
https://github.com/apache/servicecomb-java-chassis/pull/1004#discussion_r236030429
##
File path:
common/common-rest/src/main/java/org/apache/servicecomb/common/rest/codec/param/CookieProcessorCreator.java
##
@@ -35,33 +38,41 @@
public static final String PARAMTYPE = "cookie";
public static class CookieProcessor extends AbstractParamProcessor {
-public CookieProcessor(String paramPath, JavaType targetType, Object
defaultValue) {
- super(paramPath, targetType, defaultValue);
+public CookieProcessor(String paramPath, JavaType targetType, Object
defaultValue, boolean required) {
+ super(paramPath, targetType, defaultValue, required);
}
@Override
public Object getValue(HttpServletRequest request) throws Exception {
Cookie[] cookies = request.getCookies();
- if (cookies == null) {
-return null;
+ Object value = null;
+ if (cookies == null || cookies.length == 0) {
+value = checkRequiredAndDefaultValue(value);
+return convertValue(value, targetType);
}
- String value = null;
for (Cookie cookie : cookies) {
if (paramPath.equals(cookie.getName())) {
value = cookie.getValue();
- if (value == null) {
-Object defaultValue = getDefaultValue();
-if (defaultValue != null) {
- value = defaultValue.toString();
-}
- }
}
}
-
+ if (value == null) {
+value = checkRequiredAndDefaultValue(value);
+ }
return convertValue(value, targetType);
}
+private Object checkRequiredAndDefaultValue(Object value) {
+ if (isRequired()) {
+throw new InvocationException(Status.BAD_REQUEST, "Parameter is not
valid, required is true");
Review comment:
"Parameter is reqired. " this message is better
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Springmvc, when have defaultValue, required should be false
> ---
>
> Key: SCB-925
> URL: https://issues.apache.org/jira/browse/SCB-925
> Project: Apache ServiceComb
> Issue Type: Bug
> Components: Java-Chassis
>Reporter: WeiChao
>Assignee: WeiChao
>Priority: Major
> Fix For: java-chassis-1.1.0
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (SCB-925) Springmvc, when have defaultValue, required should be false
[
https://issues.apache.org/jira/browse/SCB-925?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16697602#comment-16697602
]
ASF GitHub Bot commented on SCB-925:
liubao68 commented on a change in pull request #1004: [SCB-925] Springmvc, when
have defaultValue, required should be false, when param not exist, should check
isRequired
URL:
https://github.com/apache/servicecomb-java-chassis/pull/1004#discussion_r236030429
##
File path:
common/common-rest/src/main/java/org/apache/servicecomb/common/rest/codec/param/CookieProcessorCreator.java
##
@@ -35,33 +38,41 @@
public static final String PARAMTYPE = "cookie";
public static class CookieProcessor extends AbstractParamProcessor {
-public CookieProcessor(String paramPath, JavaType targetType, Object
defaultValue) {
- super(paramPath, targetType, defaultValue);
+public CookieProcessor(String paramPath, JavaType targetType, Object
defaultValue, boolean required) {
+ super(paramPath, targetType, defaultValue, required);
}
@Override
public Object getValue(HttpServletRequest request) throws Exception {
Cookie[] cookies = request.getCookies();
- if (cookies == null) {
-return null;
+ Object value = null;
+ if (cookies == null || cookies.length == 0) {
+value = checkRequiredAndDefaultValue(value);
+return convertValue(value, targetType);
}
- String value = null;
for (Cookie cookie : cookies) {
if (paramPath.equals(cookie.getName())) {
value = cookie.getValue();
- if (value == null) {
-Object defaultValue = getDefaultValue();
-if (defaultValue != null) {
- value = defaultValue.toString();
-}
- }
}
}
-
+ if (value == null) {
+value = checkRequiredAndDefaultValue(value);
+ }
return convertValue(value, targetType);
}
+private Object checkRequiredAndDefaultValue(Object value) {
+ if (isRequired()) {
+throw new InvocationException(Status.BAD_REQUEST, "Parameter is not
valid, required is true");
Review comment:
Parameter is reqired.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Springmvc, when have defaultValue, required should be false
> ---
>
> Key: SCB-925
> URL: https://issues.apache.org/jira/browse/SCB-925
> Project: Apache ServiceComb
> Issue Type: Bug
> Components: Java-Chassis
>Reporter: WeiChao
>Assignee: WeiChao
>Priority: Major
> Fix For: java-chassis-1.1.0
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (SCB-1038) Fix some bugs and logs improvement reported by users when testing
[
https://issues.apache.org/jira/browse/SCB-1038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16697601#comment-16697601
]
ASF GitHub Bot commented on SCB-1038:
-
liubao68 closed pull request #1005: [SCB-1038]Fix some bugs and logs
improvement reported by users when testing
URL: https://github.com/apache/servicecomb-java-chassis/pull/1005
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/handlers/handler-loadbalance/src/main/java/org/apache/servicecomb/loadbalance/LoadbalanceHandler.java
b/handlers/handler-loadbalance/src/main/java/org/apache/servicecomb/loadbalance/LoadbalanceHandler.java
index d36c55242..8547af52c 100644
---
a/handlers/handler-loadbalance/src/main/java/org/apache/servicecomb/loadbalance/LoadbalanceHandler.java
+++
b/handlers/handler-loadbalance/src/main/java/org/apache/servicecomb/loadbalance/LoadbalanceHandler.java
@@ -35,10 +35,10 @@
import org.apache.servicecomb.core.Invocation;
import org.apache.servicecomb.core.SCBEngine;
import org.apache.servicecomb.core.Transport;
-import org.apache.servicecomb.core.exception.ExceptionUtils;
import org.apache.servicecomb.core.provider.consumer.SyncResponseExecutor;
import org.apache.servicecomb.foundation.common.cache.VersionedCache;
import org.apache.servicecomb.foundation.common.concurrent.ConcurrentHashMapEx;
+import org.apache.servicecomb.foundation.common.utils.ExceptionUtils;
import org.apache.servicecomb.loadbalance.filter.ServerDiscoveryFilter;
import org.apache.servicecomb.serviceregistry.discovery.DiscoveryContext;
import org.apache.servicecomb.serviceregistry.discovery.DiscoveryFilter;
@@ -232,9 +232,7 @@ private void send(Invocation invocation, AsyncResponse
asyncResp, final LoadBala
long time = System.currentTimeMillis();
ServiceCombServer server = chosenLB.chooseServer(invocation);
if (null == server) {
-
asyncResp.consumerFail(ExceptionUtils.lbAddressNotFound(invocation.getMicroserviceName(),
- invocation.getMicroserviceVersionRule(),
- invocation.getConfigTransportName()));
+ asyncResp.consumerFail(new
InvocationException(Status.INTERNAL_SERVER_ERROR, "No available address
found."));
return;
}
chosenLB.getLoadBalancerStats().incrementNumRequests(server);
@@ -295,7 +293,7 @@ public void
onExceptionWithServer(ExecutionContext context, Throwabl
context.getRequest().getEndpoint(),
info.getNumberOfPastServersAttempted(),
info.getNumberOfPastAttemptsOnServer(),
-exception.getMessage());
+ExceptionUtils.getExceptionMessageWithoutTrace(exception));
}
@Override
@@ -319,7 +317,7 @@ public void onExecutionSuccess(ExecutionContext
context, Response re
public void onExecutionFailed(ExecutionContext context,
Throwable finalException,
ExecutionInfo info) {
LOGGER.error("Invoke all server failed. Operation {}, e={}",
-context.getRequest().getInvocationQualifiedName(),
finalException.toString());
+context.getRequest().getInvocationQualifiedName(),
ExceptionUtils.getExceptionMessageWithoutTrace(finalException));
if (orginExecutor != null) {
orginExecutor.execute(() -> {
fail(finalException);
@@ -366,7 +364,7 @@ private void fail(Throwable finalException) {
if (isFailedResponse(resp)) {
LOGGER.error("service {}, call error, msg is {}, server is {}
",
invocation.getInvocationQualifiedName(),
-((Throwable) resp.getResult()).getMessage(),
+ExceptionUtils.getExceptionMessageWithoutTrace((Throwable)
resp.getResult()),
s);
chosenLB.getLoadBalancerStats().incrementSuccessiveConnectionFailureCount(s);
ServiceCombLoadBalancerStats.INSTANCE.markFailure(server);
diff --git
a/handlers/handler-loadbalance/src/main/java/org/apache/servicecomb/loadbalance/SessionStickinessRule.java
b/handlers/handler-loadbalance/src/main/java/org/apache/servicecomb/loadbalance/SessionStickinessRule.java
index a489860ed..a854a831a 100644
---
a/handlers/handler-loadbalance/src/main/java/org/apache/servicecomb/loadbalance/SessionStickinessRule.java
+++
b/handlers/handler-loadbalance/src/main/java/org/apache/servicecomb/loadbalance/SessionStickinessRule.java
@@ -56,6 +56,7 @@ public SessionStickinessRule() {
}
public void setLoadBalancer(LoadBalancer loadBalancer) {
+this.microserviceName = loadBalancer.getMicroServiceName();
this.loadBalancer = loadBalancer;
}
diff --git
[jira] [Commented] (SCB-1034) metrics performance optimize
[ https://issues.apache.org/jira/browse/SCB-1034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16697597#comment-16697597 ] ASF GitHub Bot commented on SCB-1034: - wujimin commented on issue #1002: [SCB-1034] Metrics performance optimize URL: https://github.com/apache/servicecomb-java-chassis/pull/1002#issuecomment-441337695 already merged in https://github.com/apache/servicecomb-java-chassis/pull/997 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > metrics performance optimize > > > Key: SCB-1034 > URL: https://issues.apache.org/jira/browse/SCB-1034 > Project: Apache ServiceComb > Issue Type: Sub-task > Components: Java-Chassis >Reporter: wujimin >Assignee: wujimin >Priority: Major > Fix For: java-chassis-1.1.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-1043) MicroserviceVersions.safeSetInstances lost exception message
[ https://issues.apache.org/jira/browse/SCB-1043?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16697594#comment-16697594 ] ASF GitHub Bot commented on SCB-1043: - coveralls commented on issue #1006: [SCB-1043] fix bug: if safeSetInstances throw an exception, the excep… URL: https://github.com/apache/servicecomb-java-chassis/pull/1006#issuecomment-441337380 [](https://coveralls.io/builds/20266889) Coverage decreased (-0.02%) to 86.7% when pulling **8d45b1a575f8830822b3ec1d4bcda5ea15409e3e on jeho0815:Branch_master_SCB1043** into **defbfa4e67504356f309a0c447840dae06f22726 on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > MicroserviceVersions.safeSetInstances lost exception message > > > Key: SCB-1043 > URL: https://issues.apache.org/jira/browse/SCB-1043 > Project: Apache ServiceComb > Issue Type: Bug > Components: Java-Chassis >Reporter: jeho0815 >Assignee: jeho0815 >Priority: Major > Fix For: java-chassis-1.1.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-1043) MicroserviceVersions.safeSetInstances lost exception message
[
https://issues.apache.org/jira/browse/SCB-1043?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16697592#comment-16697592
]
ASF GitHub Bot commented on SCB-1043:
-
wujimin commented on a change in pull request #1006: [SCB-1043] fix bug: if
safeSetInstances throw an exception, the excep…
URL:
https://github.com/apache/servicecomb-java-chassis/pull/1006#discussion_r236029857
##
File path:
service-registry/src/main/java/org/apache/servicecomb/serviceregistry/consumer/MicroserviceVersions.java
##
@@ -160,10 +160,10 @@ protected void
safeSetInstances(List pulledInstances, Stri
setInstances(pulledInstances, rev);
validated = true;
} catch (Throwable e) {
- LOGGER.error("Failed to setInstances, appId={}, microserviceName={}.",
- getAppId(),
- getMicroserviceName(),
- e);
+ LOGGER.error(String.format("Failed to setInstances, AppId=%s,
MicroserviceName=%s.",
Review comment:
when will lost exception?
by my test, never happened.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> MicroserviceVersions.safeSetInstances lost exception message
>
>
> Key: SCB-1043
> URL: https://issues.apache.org/jira/browse/SCB-1043
> Project: Apache ServiceComb
> Issue Type: Bug
> Components: Java-Chassis
>Reporter: jeho0815
>Assignee: jeho0815
>Priority: Major
> Fix For: java-chassis-1.1.0
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (SCB-1043) MicroserviceVersions.safeSetInstances lost exception message
[ https://issues.apache.org/jira/browse/SCB-1043?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16697588#comment-16697588 ] ASF GitHub Bot commented on SCB-1043: - jeho0815 opened a new pull request #1006: [SCB-1043] fix bug: if safeSetInstances throw an exception, the excep… URL: https://github.com/apache/servicecomb-java-chassis/pull/1006 …tion message will lost Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/SCB) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [ ] Each commit in the pull request should have a meaningful subject line and body. - [ ] Format the pull request title like `[SCB-XXX] Fixes bug in ApproximateQuantiles`, where you replace `SCB-XXX` with the appropriate JIRA issue. - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [ ] Run `mvn clean install` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). --- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > MicroserviceVersions.safeSetInstances lost exception message > > > Key: SCB-1043 > URL: https://issues.apache.org/jira/browse/SCB-1043 > Project: Apache ServiceComb > Issue Type: Bug > Components: Java-Chassis >Reporter: jeho0815 >Assignee: jeho0815 >Priority: Major > Fix For: java-chassis-1.1.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-1021) add vertx client/server meters to metrics
[ https://issues.apache.org/jira/browse/SCB-1021?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16697585#comment-16697585 ] ASF GitHub Bot commented on SCB-1021: - coveralls edited a comment on issue #997: [SCB-1021] Add vertx client server meters URL: https://github.com/apache/servicecomb-java-chassis/pull/997#issuecomment-439906101 [](https://coveralls.io/builds/20266785) Coverage increased (+0.06%) to 86.772% when pulling **ab21b7e67432d22d647165f3de5a5845617cb4a1 on wujimin:add-vertx-client-server-meters** into **defbfa4e67504356f309a0c447840dae06f22726 on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > add vertx client/server meters to metrics > - > > Key: SCB-1021 > URL: https://issues.apache.org/jira/browse/SCB-1021 > Project: Apache ServiceComb > Issue Type: Sub-task > Components: Java-Chassis >Reporter: wujimin >Assignee: wujimin >Priority: Major > Fix For: java-chassis-1.1.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-993) Bug fixes
[ https://issues.apache.org/jira/browse/SCB-993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16697569#comment-16697569 ] ASF GitHub Bot commented on SCB-993: coveralls edited a comment on issue #498: SCB-993 Add the requirement of scctl URL: https://github.com/apache/servicecomb-service-center/pull/498#issuecomment-441254509 [](https://coveralls.io/builds/20266621) Coverage decreased (-0.02%) to 61.646% when pulling **91e6b597baa948b5f1ea09a0a35f35fd7d2c5125 on little-cui:docs** into **49428294a99f2a475203a7ceb04ce8d5754feb77 on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Bug fixes > - > > Key: SCB-993 > URL: https://issues.apache.org/jira/browse/SCB-993 > Project: Apache ServiceComb > Issue Type: Bug > Components: Service-Center >Reporter: little-cui >Assignee: little-cui >Priority: Major > Fix For: service-center-1.1.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-993) Bug fixes
[ https://issues.apache.org/jira/browse/SCB-993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16697568#comment-16697568 ] ASF GitHub Bot commented on SCB-993: codecov-io edited a comment on issue #498: SCB-993 Add the requirement of scctl URL: https://github.com/apache/servicecomb-service-center/pull/498#issuecomment-441254296 # [Codecov](https://codecov.io/gh/apache/servicecomb-service-center/pull/498?src=pr=h1) Report > Merging [#498](https://codecov.io/gh/apache/servicecomb-service-center/pull/498?src=pr=desc) into [master](https://codecov.io/gh/apache/servicecomb-service-center/commit/49428294a99f2a475203a7ceb04ce8d5754feb77?src=pr=desc) will **decrease** coverage by `0.02%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/servicecomb-service-center/pull/498?src=pr=tree) ```diff @@Coverage Diff @@ ## master #498 +/- ## == - Coverage 59.25% 59.23% -0.03% == Files 166 166 Lines 1388013880 == - Hits 8225 8222 -3 Misses 5072 5072 - Partials 583 586 +3 ``` | [Impacted Files](https://codecov.io/gh/apache/servicecomb-service-center/pull/498?src=pr=tree) | Coverage Δ | | |---|---|---| | [server/plugin/pkg/registry/etcd/tracing.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/498/diff?src=pr=tree#diff-c2VydmVyL3BsdWdpbi9wa2cvcmVnaXN0cnkvZXRjZC90cmFjaW5nLmdv) | `72.72% <0%> (-9.1%)` | :arrow_down: | | [server/service/tag.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/498/diff?src=pr=tree#diff-c2VydmVyL3NlcnZpY2UvdGFnLmdv) | `67.4% <0%> (-0.56%)` | :arrow_down: | | [server/broker/util.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/498/diff?src=pr=tree#diff-c2VydmVyL2Jyb2tlci91dGlsLmdv) | `53.2% <0%> (-0.27%)` | :arrow_down: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/servicecomb-service-center/pull/498?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/servicecomb-service-center/pull/498?src=pr=footer). Last update [4942829...91e6b59](https://codecov.io/gh/apache/servicecomb-service-center/pull/498?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Bug fixes > - > > Key: SCB-993 > URL: https://issues.apache.org/jira/browse/SCB-993 > Project: Apache ServiceComb > Issue Type: Bug > Components: Service-Center >Reporter: little-cui >Assignee: little-cui >Priority: Major > Fix For: service-center-1.1.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-1041) scctl version command does not print sc verison
[ https://issues.apache.org/jira/browse/SCB-1041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16697235#comment-16697235 ] ASF GitHub Bot commented on SCB-1041: - codecov-io commented on issue #499: SCB-1041 scctl version command does not print sc verison URL: https://github.com/apache/servicecomb-service-center/pull/499#issuecomment-441259819 # [Codecov](https://codecov.io/gh/apache/servicecomb-service-center/pull/499?src=pr=h1) Report > Merging [#499](https://codecov.io/gh/apache/servicecomb-service-center/pull/499?src=pr=desc) into [master](https://codecov.io/gh/apache/servicecomb-service-center/commit/49428294a99f2a475203a7ceb04ce8d5754feb77?src=pr=desc) will **decrease** coverage by `0.02%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/servicecomb-service-center/pull/499?src=pr=tree) ```diff @@Coverage Diff @@ ## master #499 +/- ## == - Coverage 59.25% 59.23% -0.03% == Files 166 166 Lines 1388013880 == - Hits 8225 8222 -3 Misses 5072 5072 - Partials 583 586 +3 ``` | [Impacted Files](https://codecov.io/gh/apache/servicecomb-service-center/pull/499?src=pr=tree) | Coverage Δ | | |---|---|---| | [server/plugin/pkg/registry/etcd/tracing.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/499/diff?src=pr=tree#diff-c2VydmVyL3BsdWdpbi9wa2cvcmVnaXN0cnkvZXRjZC90cmFjaW5nLmdv) | `72.72% <0%> (-9.1%)` | :arrow_down: | | [pkg/tlsutil/tlsutil.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/499/diff?src=pr=tree#diff-cGtnL3Rsc3V0aWwvdGxzdXRpbC5nbw==) | `73.58% <0%> (-0.95%)` | :arrow_down: | | [server/service/tag.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/499/diff?src=pr=tree#diff-c2VydmVyL3NlcnZpY2UvdGFnLmdv) | `67.4% <0%> (-0.56%)` | :arrow_down: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/servicecomb-service-center/pull/499?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/servicecomb-service-center/pull/499?src=pr=footer). Last update [4942829...a86b662](https://codecov.io/gh/apache/servicecomb-service-center/pull/499?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > scctl version command does not print sc verison > --- > > Key: SCB-1041 > URL: https://issues.apache.org/jira/browse/SCB-1041 > Project: Apache ServiceComb > Issue Type: Bug > Components: Service-Center >Reporter: little-cui >Assignee: little-cui >Priority: Major > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-1041) scctl version command does not print sc verison
[ https://issues.apache.org/jira/browse/SCB-1041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16697233#comment-16697233 ] ASF GitHub Bot commented on SCB-1041: - coveralls commented on issue #499: SCB-1041 scctl version command does not print sc verison URL: https://github.com/apache/servicecomb-service-center/pull/499#issuecomment-441259764 [](https://coveralls.io/builds/20261047) Coverage decreased (-0.03%) to 61.627% when pulling **a86b6620a6df8ea4109e5c9ccc453850deb5f4d1 on little-cui:bug** into **49428294a99f2a475203a7ceb04ce8d5754feb77 on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > scctl version command does not print sc verison > --- > > Key: SCB-1041 > URL: https://issues.apache.org/jira/browse/SCB-1041 > Project: Apache ServiceComb > Issue Type: Bug > Components: Service-Center >Reporter: little-cui >Assignee: little-cui >Priority: Major > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-1041) scctl version command does not print sc verison
[ https://issues.apache.org/jira/browse/SCB-1041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16697205#comment-16697205 ] ASF GitHub Bot commented on SCB-1041: - little-cui commented on issue #499: SCB-1041 scctl version command does not print sc verison URL: https://github.com/apache/servicecomb-service-center/pull/499#issuecomment-441254578 #497 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > scctl version command does not print sc verison > --- > > Key: SCB-1041 > URL: https://issues.apache.org/jira/browse/SCB-1041 > Project: Apache ServiceComb > Issue Type: Bug > Components: Service-Center >Reporter: little-cui >Assignee: little-cui >Priority: Major > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-993) Bug fixes
[ https://issues.apache.org/jira/browse/SCB-993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16697203#comment-16697203 ] ASF GitHub Bot commented on SCB-993: coveralls commented on issue #498: SCB-993 Add the requirement of scctl URL: https://github.com/apache/servicecomb-service-center/pull/498#issuecomment-441254509 [](https://coveralls.io/builds/20260744) Coverage decreased (-0.04%) to 61.625% when pulling **e7675bc2feb4fc54d4b9e1f19f3459047c3d1b13 on little-cui:docs** into **49428294a99f2a475203a7ceb04ce8d5754feb77 on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Bug fixes > - > > Key: SCB-993 > URL: https://issues.apache.org/jira/browse/SCB-993 > Project: Apache ServiceComb > Issue Type: Bug > Components: Service-Center >Reporter: little-cui >Assignee: little-cui >Priority: Major > Fix For: service-center-1.1.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-1041) scctl version command does not print sc verison
[ https://issues.apache.org/jira/browse/SCB-1041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16697204#comment-16697204 ] ASF GitHub Bot commented on SCB-1041: - little-cui opened a new pull request #499: SCB-1041 scctl version command does not print sc verison URL: https://github.com/apache/servicecomb-service-center/pull/499 Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/SCB) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [ ] Each commit in the pull request should have a meaningful subject line and body. - [ ] Format the pull request title like `[SCB-XXX] Fixes bug in ApproximateQuantiles`, where you replace `SCB-XXX` with the appropriate JIRA issue. - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [ ] Run `go build` `go test` `go fmt` `go vet` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). --- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > scctl version command does not print sc verison > --- > > Key: SCB-1041 > URL: https://issues.apache.org/jira/browse/SCB-1041 > Project: Apache ServiceComb > Issue Type: Bug > Components: Service-Center >Reporter: little-cui >Assignee: little-cui >Priority: Major > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-993) Bug fixes
[ https://issues.apache.org/jira/browse/SCB-993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16697202#comment-16697202 ] ASF GitHub Bot commented on SCB-993: codecov-io commented on issue #498: SCB-993 Add the requirement of scctl URL: https://github.com/apache/servicecomb-service-center/pull/498#issuecomment-441254296 # [Codecov](https://codecov.io/gh/apache/servicecomb-service-center/pull/498?src=pr=h1) Report > Merging [#498](https://codecov.io/gh/apache/servicecomb-service-center/pull/498?src=pr=desc) into [master](https://codecov.io/gh/apache/servicecomb-service-center/commit/49428294a99f2a475203a7ceb04ce8d5754feb77?src=pr=desc) will **increase** coverage by `0.01%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/servicecomb-service-center/pull/498?src=pr=tree) ```diff @@Coverage Diff @@ ## master #498 +/- ## == + Coverage 59.25% 59.27% +0.01% == Files 166 166 Lines 1388013880 == + Hits 8225 8227 +2 Misses 5072 5072 + Partials 583 581 -2 ``` | [Impacted Files](https://codecov.io/gh/apache/servicecomb-service-center/pull/498?src=pr=tree) | Coverage Δ | | |---|---|---| | [server/service/tag.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/498/diff?src=pr=tree#diff-c2VydmVyL3NlcnZpY2UvdGFnLmdv) | `67.4% <0%> (-0.56%)` | :arrow_down: | | [pkg/log/logrotate.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/498/diff?src=pr=tree#diff-cGtnL2xvZy9sb2dyb3RhdGUuZ28=) | `34.28% <0%> (+0.57%)` | :arrow_up: | | [server/service/notification/websocket.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/498/diff?src=pr=tree#diff-c2VydmVyL3NlcnZpY2Uvbm90aWZpY2F0aW9uL3dlYnNvY2tldC5nbw==) | `84.51% <0%> (+0.64%)` | :arrow_up: | | [...erver/plugin/pkg/tracing/buildin/file\_collector.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/498/diff?src=pr=tree#diff-c2VydmVyL3BsdWdpbi9wa2cvdHJhY2luZy9idWlsZGluL2ZpbGVfY29sbGVjdG9yLmdv) | `64.07% <0%> (+0.97%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/servicecomb-service-center/pull/498?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/servicecomb-service-center/pull/498?src=pr=footer). Last update [4942829...e7675bc](https://codecov.io/gh/apache/servicecomb-service-center/pull/498?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Bug fixes > - > > Key: SCB-993 > URL: https://issues.apache.org/jira/browse/SCB-993 > Project: Apache ServiceComb > Issue Type: Bug > Components: Service-Center >Reporter: little-cui >Assignee: little-cui >Priority: Major > Fix For: service-center-1.1.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-993) Bug fixes
[ https://issues.apache.org/jira/browse/SCB-993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16697172#comment-16697172 ] ASF GitHub Bot commented on SCB-993: little-cui opened a new pull request #498: SCB-993 Add the requirement of scctl URL: https://github.com/apache/servicecomb-service-center/pull/498 Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/SCB) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [ ] Each commit in the pull request should have a meaningful subject line and body. - [ ] Format the pull request title like `[SCB-XXX] Fixes bug in ApproximateQuantiles`, where you replace `SCB-XXX` with the appropriate JIRA issue. - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [ ] Run `go build` `go test` `go fmt` `go vet` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). --- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Bug fixes > - > > Key: SCB-993 > URL: https://issues.apache.org/jira/browse/SCB-993 > Project: Apache ServiceComb > Issue Type: Bug > Components: Service-Center >Reporter: little-cui >Assignee: little-cui >Priority: Major > Fix For: service-center-1.1.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-993) Bug fixes
[ https://issues.apache.org/jira/browse/SCB-993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16697174#comment-16697174 ] ASF GitHub Bot commented on SCB-993: little-cui commented on issue #498: SCB-993 Add the requirement of scctl URL: https://github.com/apache/servicecomb-service-center/pull/498#issuecomment-441249300 #497 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Bug fixes > - > > Key: SCB-993 > URL: https://issues.apache.org/jira/browse/SCB-993 > Project: Apache ServiceComb > Issue Type: Bug > Components: Service-Center >Reporter: little-cui >Assignee: little-cui >Priority: Major > Fix For: service-center-1.1.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-1032) Support compress the response
[ https://issues.apache.org/jira/browse/SCB-1032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16696672#comment-16696672 ] ASF GitHub Bot commented on SCB-1032: - codecov-io edited a comment on issue #496: SCB-1032 Support compress the response URL: https://github.com/apache/servicecomb-service-center/pull/496#issuecomment-440691271 # [Codecov](https://codecov.io/gh/apache/servicecomb-service-center/pull/496?src=pr=h1) Report > Merging [#496](https://codecov.io/gh/apache/servicecomb-service-center/pull/496?src=pr=desc) into [master](https://codecov.io/gh/apache/servicecomb-service-center/commit/49428294a99f2a475203a7ceb04ce8d5754feb77?src=pr=desc) will **not change** coverage. > The diff coverage is `0%`. [](https://codecov.io/gh/apache/servicecomb-service-center/pull/496?src=pr=tree) ```diff @@ Coverage Diff @@ ## master #496 +/- ## === Coverage 59.25% 59.25% === Files 166 166 Lines 1388013880 === Hits 8225 8225 Misses 5072 5072 Partials 583 583 ``` | [Impacted Files](https://codecov.io/gh/apache/servicecomb-service-center/pull/496?src=pr=tree) | Coverage Δ | | |---|---|---| | [...er/plugin/pkg/discovery/servicecenter/aggregate.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/496/diff?src=pr=tree#diff-c2VydmVyL3BsdWdpbi9wa2cvZGlzY292ZXJ5L3NlcnZpY2VjZW50ZXIvYWdncmVnYXRlLmdv) | `8% <0%> (ø)` | :arrow_up: | | [server/service/tag.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/496/diff?src=pr=tree#diff-c2VydmVyL3NlcnZpY2UvdGFnLmdv) | `67.4% <0%> (-0.56%)` | :arrow_down: | | [server/broker/util.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/496/diff?src=pr=tree#diff-c2VydmVyL2Jyb2tlci91dGlsLmdv) | `53.2% <0%> (-0.27%)` | :arrow_down: | | [server/govern/service.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/496/diff?src=pr=tree#diff-c2VydmVyL2dvdmVybi9zZXJ2aWNlLmdv) | `72.93% <0%> (+0.33%)` | :arrow_up: | | [pkg/log/logrotate.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/496/diff?src=pr=tree#diff-cGtnL2xvZy9sb2dyb3RhdGUuZ28=) | `34.28% <0%> (+0.57%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/servicecomb-service-center/pull/496?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/servicecomb-service-center/pull/496?src=pr=footer). Last update [4942829...32d0e20](https://codecov.io/gh/apache/servicecomb-service-center/pull/496?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Support compress the response > - > > Key: SCB-1032 > URL: https://issues.apache.org/jira/browse/SCB-1032 > Project: Apache ServiceComb > Issue Type: New Feature > Components: Service-Center >Reporter: little-cui >Assignee: little-cui >Priority: Major > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-1038) Fix some bugs and logs improvement reported by users when testing
[ https://issues.apache.org/jira/browse/SCB-1038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16696636#comment-16696636 ] ASF GitHub Bot commented on SCB-1038: - coveralls edited a comment on issue #1005: [SCB-1038]Fix some bugs and logs improvement reported by users when testing URL: https://github.com/apache/servicecomb-java-chassis/pull/1005#issuecomment-441192550 [](https://coveralls.io/builds/20257491) Coverage decreased (-0.02%) to 86.695% when pulling **3a3322f66e3c0f827f5459ae7c36fe394cc23419 on liubao68:fix_inpr** into **defbfa4e67504356f309a0c447840dae06f22726 on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Fix some bugs and logs improvement reported by users when testing > - > > Key: SCB-1038 > URL: https://issues.apache.org/jira/browse/SCB-1038 > Project: Apache ServiceComb > Issue Type: Improvement > Components: Java-Chassis >Reporter: liubao >Assignee: liubao >Priority: Major > Fix For: java-chassis-1.1.0 > > > # loadbalancer do not print the cause when some unexpected error happens > # SessionStickRule microserviceName is not assigned a value -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-925) Springmvc, when have defaultValue, required should be false
[ https://issues.apache.org/jira/browse/SCB-925?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16696596#comment-16696596 ] ASF GitHub Bot commented on SCB-925: coveralls edited a comment on issue #1004: [SCB-925] Springmvc, when have defaultValue, required should be false, when param not exist, should check isRequired URL: https://github.com/apache/servicecomb-java-chassis/pull/1004#issuecomment-441166462 [](https://coveralls.io/builds/20257049) Coverage decreased (-0.1%) to 86.582% when pulling **ced95605966d2984ef592c2c59213d9261a72e3f on weichao666:defaultvaluenew** into **defbfa4e67504356f309a0c447840dae06f22726 on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Springmvc, when have defaultValue, required should be false > --- > > Key: SCB-925 > URL: https://issues.apache.org/jira/browse/SCB-925 > Project: Apache ServiceComb > Issue Type: Bug > Components: Java-Chassis >Reporter: WeiChao >Assignee: WeiChao >Priority: Major > Fix For: java-chassis-1.1.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-1038) Fix some bugs and logs improvement reported by users when testing
[ https://issues.apache.org/jira/browse/SCB-1038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16696575#comment-16696575 ] ASF GitHub Bot commented on SCB-1038: - coveralls commented on issue #1005: [SCB-1038]Fix some bugs and logs improvement reported by users when testing URL: https://github.com/apache/servicecomb-java-chassis/pull/1005#issuecomment-441192550 [](https://coveralls.io/builds/20256876) Coverage decreased (-0.02%) to 86.699% when pulling **11233f6ce3bc212d6a19e956dfcb7233ae7f56ab on liubao68:fix_inpr** into **defbfa4e67504356f309a0c447840dae06f22726 on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Fix some bugs and logs improvement reported by users when testing > - > > Key: SCB-1038 > URL: https://issues.apache.org/jira/browse/SCB-1038 > Project: Apache ServiceComb > Issue Type: Improvement > Components: Java-Chassis >Reporter: liubao >Assignee: liubao >Priority: Major > Fix For: java-chassis-1.1.0 > > > # loadbalancer do not print the cause when some unexpected error happens > # SessionStickRule microserviceName is not assigned a value -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-925) Springmvc, when have defaultValue, required should be false
[ https://issues.apache.org/jira/browse/SCB-925?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16696562#comment-16696562 ] ASF GitHub Bot commented on SCB-925: weichao666 commented on issue #1004: [SCB-925] Springmvc, when have defaultValue, required should be false, when param not exist, should check isRequired URL: https://github.com/apache/servicecomb-java-chassis/pull/1004#issuecomment-441191265 Springmvc, Generating schema： if do not write defaultValue， required's value is what user write if have written defaultValue，No matter how the user writes，required is false running： When param is not transmitted，if required is true, report error When param is not transmitted , if required is false, handle it with defaultValue This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Springmvc, when have defaultValue, required should be false > --- > > Key: SCB-925 > URL: https://issues.apache.org/jira/browse/SCB-925 > Project: Apache ServiceComb > Issue Type: Bug > Components: Java-Chassis >Reporter: WeiChao >Assignee: WeiChao >Priority: Major > Fix For: java-chassis-1.1.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-1034) metrics performance optimize
[ https://issues.apache.org/jira/browse/SCB-1034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16696558#comment-16696558 ] ASF GitHub Bot commented on SCB-1034: - coveralls commented on issue #1002: [SCB-1034] Metrics performance optimize URL: https://github.com/apache/servicecomb-java-chassis/pull/1002#issuecomment-441189770 [](https://coveralls.io/builds/20256723) Coverage decreased (-0.02%) to 86.699% when pulling **ec351baf92f798445e021d19051258e8f377c69b on wujimin:metrics-performance-optimize** into **defbfa4e67504356f309a0c447840dae06f22726 on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > metrics performance optimize > > > Key: SCB-1034 > URL: https://issues.apache.org/jira/browse/SCB-1034 > Project: Apache ServiceComb > Issue Type: Sub-task > Components: Java-Chassis >Reporter: wujimin >Assignee: wujimin >Priority: Major > Fix For: java-chassis-1.1.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-613) delete useless EndpointsCache related classs
[
https://issues.apache.org/jira/browse/SCB-613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16696546#comment-16696546
]
ASF GitHub Bot commented on SCB-613:
liubao68 closed pull request #892: [SCB-613]delete useless EndpointsCache
related classs
URL: https://github.com/apache/servicecomb-java-chassis/pull/892
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/core/src/main/java/org/apache/servicecomb/core/SCBEngine.java
b/core/src/main/java/org/apache/servicecomb/core/SCBEngine.java
index dcd877f40..e1e89056f 100644
--- a/core/src/main/java/org/apache/servicecomb/core/SCBEngine.java
+++ b/core/src/main/java/org/apache/servicecomb/core/SCBEngine.java
@@ -30,7 +30,6 @@
import org.apache.servicecomb.core.BootListener.EventType;
import org.apache.servicecomb.core.definition.MicroserviceMeta;
import org.apache.servicecomb.core.definition.loader.SchemaListenerManager;
-import org.apache.servicecomb.core.endpoint.AbstractEndpointsCache;
import org.apache.servicecomb.core.event.InvocationFinishEvent;
import org.apache.servicecomb.core.event.InvocationStartEvent;
import org.apache.servicecomb.core.handler.HandlerConfigUtils;
@@ -208,7 +207,6 @@ private void doInit() throws Exception {
eventBus.register(this);
consumerProviderManager.setAppManager(RegistryUtils.getServiceRegistry().getAppManager());
-AbstractEndpointsCache.init(RegistryUtils.getInstanceCacheManager(),
transportManager);
triggerEvent(EventType.BEFORE_HANDLER);
HandlerConfigUtils.init();
diff --git
a/core/src/main/java/org/apache/servicecomb/core/endpoint/AbstractEndpointsCache.java
b/core/src/main/java/org/apache/servicecomb/core/endpoint/AbstractEndpointsCache.java
deleted file mode 100644
index 8501013cc..0
---
a/core/src/main/java/org/apache/servicecomb/core/endpoint/AbstractEndpointsCache.java
+++ /dev/null
@@ -1,119 +0,0 @@
-/*
- * Licensed to the Apache Software Foundation (ASF) under one or more
- * contributor license agreements. See the NOTICE file distributed with
- * this work for additional information regarding copyright ownership.
- * The ASF licenses this file to You under the Apache License, Version 2.0
- * (the "License"); you may not use this file except in compliance with
- * the License. You may obtain a copy of the License at
- *
- * http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- */
-
-package org.apache.servicecomb.core.endpoint;
-
-import java.util.ArrayList;
-import java.util.HashMap;
-import java.util.List;
-import java.util.Map;
-import java.util.Map.Entry;
-
-import org.apache.servicecomb.core.Transport;
-import org.apache.servicecomb.core.transport.TransportManager;
-import org.apache.servicecomb.serviceregistry.cache.CacheEndpoint;
-import org.apache.servicecomb.serviceregistry.cache.InstanceCache;
-import org.apache.servicecomb.serviceregistry.cache.InstanceCacheManager;
-import org.springframework.util.StringUtils;
-
-/**
- * registry模块不理解core中的概念
- * 所以要将字符串的各种信息转义一下，方便运行时使用
- */
-public abstract class AbstractEndpointsCache {
- protected static InstanceCacheManager instanceCacheManager;
-
- protected static TransportManager transportManager;
-
- protected List endpoints = new ArrayList<>();
-
- protected String transportName;
-
- protected InstanceCache instanceCache = null;
-
- public static void init(InstanceCacheManager instanceCacheManager,
TransportManager transportManager) {
-AbstractEndpointsCache.instanceCacheManager = instanceCacheManager;
-AbstractEndpointsCache.transportManager = transportManager;
- }
-
- /*
- * transportName 可能为""，表示走任意健康的地址即可
- */
- public AbstractEndpointsCache(String appId, String microserviceName, String
microserviceVersionRule,
- String transportName) {
-this.transportName = transportName;
-this.instanceCache = new InstanceCache(appId, microserviceName,
microserviceVersionRule, null);
- }
-
- public List getLatestEndpoints() {
-InstanceCache newCache =
instanceCacheManager.getOrCreate(instanceCache.getAppId(),
-instanceCache.getMicroserviceName(),
-instanceCache.getMicroserviceVersionRule());
-if (!instanceCache.cacheChanged(newCache)) {
- return endpoints;
-}
-
-// 走到这里，肯定已经是存在"有效"地址了(可能是个空列表，表示没有存活的实例)
-// 先创建，成功了，再走下面的更新逻辑
-List tmpEndpoints = createEndpoints(newCache);
-
-this.instanceCache = newCache;
-
[jira] [Commented] (SCB-613) delete useless EndpointsCache related classs
[ https://issues.apache.org/jira/browse/SCB-613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16696545#comment-16696545 ] ASF GitHub Bot commented on SCB-613: liubao68 commented on issue #892: [SCB-613]delete useless EndpointsCache related classs URL: https://github.com/apache/servicecomb-java-chassis/pull/892#issuecomment-441187116 This class is still in use, so we close this PR for later investiment. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > delete useless EndpointsCache related classs > > > Key: SCB-613 > URL: https://issues.apache.org/jira/browse/SCB-613 > Project: Apache ServiceComb > Issue Type: Task > Components: Java-Chassis >Reporter: wujimin >Assignee: lidian >Priority: Major > Labels: newbie > > all internal logic changed to DiscoveryTree and VersionedCache > so just delete everything about below classes: > org.apache.servicecomb.core.endpoint.EndpointsCache > org.apache.servicecomb.core.endpoint.AbstractEndpointsCache > org.apache.servicecomb.serviceregistry.cache.InstanceCacheManager#getOrCreate > org.apache.servicecomb.serviceregistry.cache.InstanceCache -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-1038) Fix some bugs and logs improvement reported by users when testing
[ https://issues.apache.org/jira/browse/SCB-1038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16696544#comment-16696544 ] ASF GitHub Bot commented on SCB-1038: - liubao68 opened a new pull request #1005: [SCB-1038]Fix some bugs and logs improvement reported by users when testing URL: https://github.com/apache/servicecomb-java-chassis/pull/1005 Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/SCB) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [ ] Each commit in the pull request should have a meaningful subject line and body. - [ ] Format the pull request title like `[SCB-XXX] Fixes bug in ApproximateQuantiles`, where you replace `SCB-XXX` with the appropriate JIRA issue. - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [ ] Run `mvn clean install` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). --- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Fix some bugs and logs improvement reported by users when testing > - > > Key: SCB-1038 > URL: https://issues.apache.org/jira/browse/SCB-1038 > Project: Apache ServiceComb > Issue Type: Improvement > Components: Java-Chassis >Reporter: liubao >Assignee: liubao >Priority: Major > Fix For: java-chassis-1.1.0 > > > # loadbalancer do not print the cause when some unexpected error happens > # SessionStickRule microserviceName is not assigned a value -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-925) Springmvc, when have defaultValue, required should be false
[ https://issues.apache.org/jira/browse/SCB-925?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16696532#comment-16696532 ] ASF GitHub Bot commented on SCB-925: coveralls edited a comment on issue #1004: [SCB-925] Springmvc, when have defaultValue, required should be false, when param not exist, should check isRequired URL: https://github.com/apache/servicecomb-java-chassis/pull/1004#issuecomment-441166462 [](https://coveralls.io/builds/20256353) Coverage decreased (-0.1%) to 86.597% when pulling **1d905046fd20fa8164dfd1fde456646850539f36 on weichao666:defaultvaluenew** into **defbfa4e67504356f309a0c447840dae06f22726 on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Springmvc, when have defaultValue, required should be false > --- > > Key: SCB-925 > URL: https://issues.apache.org/jira/browse/SCB-925 > Project: Apache ServiceComb > Issue Type: Bug > Components: Java-Chassis >Reporter: WeiChao >Assignee: WeiChao >Priority: Major > Fix For: java-chassis-1.1.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-925) Springmvc, when have defaultValue, required should be false
[ https://issues.apache.org/jira/browse/SCB-925?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16696438#comment-16696438 ] ASF GitHub Bot commented on SCB-925: coveralls commented on issue #1004: [SCB-925] Springmvc, when have defaultValue, required should be false, when param not exist, should check isRequired URL: https://github.com/apache/servicecomb-java-chassis/pull/1004#issuecomment-441166462 [](https://coveralls.io/builds/20255253) Coverage decreased (-0.1%) to 86.592% when pulling **bda9dc87e5d907e995cb9fe76189d089d3d20e2a on weichao666:defaultvaluenew** into **defbfa4e67504356f309a0c447840dae06f22726 on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Springmvc, when have defaultValue, required should be false > --- > > Key: SCB-925 > URL: https://issues.apache.org/jira/browse/SCB-925 > Project: Apache ServiceComb > Issue Type: Bug > Components: Java-Chassis >Reporter: WeiChao >Assignee: WeiChao >Priority: Major > Fix For: java-chassis-1.1.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-925) Springmvc, when have defaultValue, required should be false
[ https://issues.apache.org/jira/browse/SCB-925?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16696416#comment-16696416 ] ASF GitHub Bot commented on SCB-925: weichao666 opened a new pull request #1004: [SCB-925] Springmvc, when have defaultValue, required should be false, when param not exist, should check isRequired URL: https://github.com/apache/servicecomb-java-chassis/pull/1004 … Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/SCB) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [ ] Each commit in the pull request should have a meaningful subject line and body. - [ ] Format the pull request title like `[SCB-XXX] Fixes bug in ApproximateQuantiles`, where you replace `SCB-XXX` with the appropriate JIRA issue. - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [ ] Run `mvn clean install` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). --- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Springmvc, when have defaultValue, required should be false > --- > > Key: SCB-925 > URL: https://issues.apache.org/jira/browse/SCB-925 > Project: Apache ServiceComb > Issue Type: Bug > Components: Java-Chassis >Reporter: WeiChao >Assignee: WeiChao >Priority: Major > Fix For: java-chassis-1.1.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-1033) Update license for Service-Center
[ https://issues.apache.org/jira/browse/SCB-1033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16696410#comment-16696410 ] ASF GitHub Bot commented on SCB-1033: - yangbor closed pull request #495: [SCB-1033] Update third party licenses URL: https://github.com/apache/servicecomb-service-center/pull/495 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/scripts/release/LICENSE b/scripts/release/LICENSE index e723ef00..55109428 100644 --- a/scripts/release/LICENSE +++ b/scripts/release/LICENSE @@ -214,39 +214,40 @@ The following components are provided under the Apache License Version 2.0. See the respective project link for details. github.com/apache/thrift/lib/go/thrift (3d556248a8b97310da49939195330691dfe9d9ad) -github.com/astaxie/beego (323a1c4214101331a4b71922c23d19b7409ac71f) +github.com/astaxie/beego (v1.8.0) github.com/cockroachdb/cmux (30d10be492927e2dcae0089c374c455d42414fcb) -github.com/coreos/etcd (0f4a535c2fb7a2920e13e2e19b9eaf6b2e9285e5) -github.com/coreos/go-semver/semver (1817cd4bea52af76542157eeabd74b057d1a199e) -github.com/coreos/go-systemd/journal (24036eb3df68550d24a2736c5d013f4e83366866) -github.com/coreos/pkg/capnslog (8dbaa491b063ed47e2474b5363de0c0db91cf9f2) -github.com/google/btree (316fb6d3f031ae8f4d457c6c5186b9e3ded70435) -github.com/grpc-ecosystem/go-grpc-prometheus (6b7015e65d366bf3f19b2b2a000a831940f0f7e0) -github.com/jonboulle/clockwork (bcac9884e7502bb2b474c0339d889cb981a2f27f) -github.com/matttproud/golang_protobuf_extensions/pbutil (c12348ce28de40eed0136aa2b644d0ee0650e56c) +github.com/coreos/etcd (v3.1.9) +github.com/coreos/go-semver/semver (v0.2.0) +github.com/coreos/go-systemd/journal (v0.0.0-20180828140353-eee3db372b31) +github.com/coreos/pkg/capnslog (v0.0.0-20180108230652-97fdf19511ea) +github.com/google/btree (v0.0.0-20180813153112-4030bb1f1f0c) +github.com/grpc-ecosystem/go-grpc-prometheus (v1.2.0) +github.com/jonboulle/clockwork (v0.1.0) +github.com/matttproud/golang_protobuf_extensions/pbutil (v1.0.1) github.com/opentracing-contrib/go-observer (a52f2342449246d5bcc273e65cbdcfa5f7d6c63c) -github.com/opentracing/opentracing-go (1949ddbfd147afd4d964a9f00b24eb291e0e7c38) -github.com/prometheus/client_golang/prometheus (ab4214782d022e867e3195b4c9ddb1ca45413382) +github.com/opentracing/opentracing-go (v1.0.2) +github.com/prometheus/client_golang/prometheus (v0.8.1) github.com/prometheus/client_model/go (6f3806018612930941127f2a7c6c453ba2c527d2) -github.com/prometheus/common (0866df4b85a18d652b6965be022d007cdf076822) -github.com/prometheus/procfs/xfs (822d4a1f8edcbcbc71e8d1fd6527b12331a6d0ad) +github.com/prometheus/common (v0.0.0-20180801064454-c7de2306084e) +github.com/prometheus/procfs/xfs (v0.0.0-20180725123919-05ee40e3a273) github.com/go-chassis/paas-lager (50655443dc96e3d633667ca6310251ba2a3fe5c9) -github.com/bradfitz/gomemcache (1952afaa557dc08e8e0d89eafab110fb501c1a2b) -github.com/casbin/casbin (91e4fb9209910a1de86b67adc0fce5c35f17369f) -github.com/garyburd/redigo (57f1cd7de6175c96b423e7ac2534ff2b39e2ef79) github.com/google/btree (316fb6d3f031ae8f4d457c6c5186b9e3ded70435) github.com/spf13/cobra (4d647c8944eb42504a714e57e97f244ed6344722) google.golang.org/genproto/googleapis/rpc/status (aa2eb687b4d3e17154372564ad8d6bf11c3cf21f) -google.golang.org/grpc (3c33c26290b747350f8650c7d38bcc51b42dc785) -gopkg.in/yaml.v2 (d670f9405373e636a5a2765eea47fac0c9bc91a4) -k8s.io/client-go (release-7.0) -k8s.io/api (kubernetes-1.10.4) -k8s.io/apimachinery (kubernetes-1.10.4) -github.com/googleapis/gnostic (v0.1.0) +google.golang.org/grpc (v1.2.1) +gopkg.in/yaml.v2 (v2.2.1) +k8s.io/client-go (v2.0.0-alpha.0.0.20180817174322-745ca8300397) +k8s.io/api (v0.0.0-20180601181742-8b7507fac302) +k8s.io/apimachinery (v0.0.0-20180601181227-17529ec7eadb) +github.com/googleapis/gnostic (v0.2.0) github.com/google/gofuzz (24818f796faf91cd76ec7bddd72458fbced7a6c1) gopkg.in/inf.v0 (v0.9.1) -github.com/modern-go/concurrent (1.0.3) -github.com/modern-go/reflect2 (1.0.0) +github.com/modern-go/concurrent (v0.0.0-20180306012644-bacd9c7ef1dd) +github.com/modern-go/reflect2 (v1.0.1) +github.com/golang/glog (v0.0.0-20160126235308-23def4e6c14b) +github.com/go-chassis/glog (v0.0.0-20180920075250-95a09b2413e9) +github.com/go-mesh/openlogging (v0.0.0-20180905092207-9cc15d7752d3) +github.com/inconshreveable/mousetrap (v1.0.0) For beorn7/perks (4c0e84591b9aa9e6dcfdf3e020114cd81f89d5f9) @@ -256,14 +257,14 @@ For details, see https://github.com/beorn7/perks You can find a copy of the License at licenses/LICENSE-beorn7-perks
[jira] [Commented] (SCB-1033) Update license for Service-Center
[ https://issues.apache.org/jira/browse/SCB-1033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16696409#comment-16696409 ] ASF GitHub Bot commented on SCB-1033: - yangbor commented on issue #495: [SCB-1033] Update third party licenses URL: https://github.com/apache/servicecomb-service-center/pull/495#issuecomment-441162696 Closing this PR for now. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Update license for Service-Center > - > > Key: SCB-1033 > URL: https://issues.apache.org/jira/browse/SCB-1033 > Project: Apache ServiceComb > Issue Type: Task > Components: Service-Center >Affects Versions: service-center-1.1.0 >Reporter: Yang Bo >Assignee: Yang Bo >Priority: Major > Fix For: service-center-1.1.0 > > > Update license for Service-Center -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-1033) Update license for Service-Center
[ https://issues.apache.org/jira/browse/SCB-1033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16696407#comment-16696407 ] ASF GitHub Bot commented on SCB-1033: - asifdxtreme commented on a change in pull request #495: [SCB-1033] Update third party licenses URL: https://github.com/apache/servicecomb-service-center/pull/495#discussion_r235852180 ## File path: scripts/release/LICENSE ## @@ -214,39 +214,40 @@ The following components are provided under the Apache License Version 2.0. See the respective project link for details. github.com/apache/thrift/lib/go/thrift (3d556248a8b97310da49939195330691dfe9d9ad) Review comment: go mod is not updated and it uses lot of redudant repo which is actually not used by Service-Center and that's the whole reason why the are not included in the license, so for this release we prefer giving with glide.yaml and there is definitely some amount of work needed to update the go mod file This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Update license for Service-Center > - > > Key: SCB-1033 > URL: https://issues.apache.org/jira/browse/SCB-1033 > Project: Apache ServiceComb > Issue Type: Task > Components: Service-Center >Affects Versions: service-center-1.1.0 >Reporter: Yang Bo >Assignee: Yang Bo >Priority: Major > Fix For: service-center-1.1.0 > > > Update license for Service-Center -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-1033) Update license for Service-Center
[ https://issues.apache.org/jira/browse/SCB-1033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16696314#comment-16696314 ] ASF GitHub Bot commented on SCB-1033: - yangbor commented on a change in pull request #495: [SCB-1033] Update third party licenses URL: https://github.com/apache/servicecomb-service-center/pull/495#discussion_r235835381 ## File path: scripts/release/LICENSE ## @@ -214,39 +214,40 @@ The following components are provided under the Apache License Version 2.0. See the respective project link for details. github.com/apache/thrift/lib/go/thrift (3d556248a8b97310da49939195330691dfe9d9ad) Review comment: How about update the building scripts and use go mode (go 1.11) for this release. If we are going to migrate to go mod anyway, why not do it in this release. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Update license for Service-Center > - > > Key: SCB-1033 > URL: https://issues.apache.org/jira/browse/SCB-1033 > Project: Apache ServiceComb > Issue Type: Task > Components: Service-Center >Affects Versions: service-center-1.1.0 >Reporter: Yang Bo >Assignee: Yang Bo >Priority: Major > Fix For: service-center-1.1.0 > > > Update license for Service-Center -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-1033) Update license for Service-Center
[ https://issues.apache.org/jira/browse/SCB-1033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16696313#comment-16696313 ] ASF GitHub Bot commented on SCB-1033: - yangbor commented on a change in pull request #495: [SCB-1033] Update third party licenses URL: https://github.com/apache/servicecomb-service-center/pull/495#discussion_r235835381 ## File path: scripts/release/LICENSE ## @@ -214,39 +214,40 @@ The following components are provided under the Apache License Version 2.0. See the respective project link for details. github.com/apache/thrift/lib/go/thrift (3d556248a8b97310da49939195330691dfe9d9ad) Review comment: How about update the building scripts and use go 1.11 for this release. If we are going to migrate to go mod anyway, why not do it in this release. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Update license for Service-Center > - > > Key: SCB-1033 > URL: https://issues.apache.org/jira/browse/SCB-1033 > Project: Apache ServiceComb > Issue Type: Task > Components: Service-Center >Affects Versions: service-center-1.1.0 >Reporter: Yang Bo >Assignee: Yang Bo >Priority: Major > Fix For: service-center-1.1.0 > > > Update license for Service-Center -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-1031) The Response's properties was overrided wrong between @APIOperation and @Resoponse on the controller method
[
https://issues.apache.org/jira/browse/SCB-1031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16696127#comment-16696127
]
ASF GitHub Bot commented on SCB-1031:
-
wujimin commented on a change in pull request #999: [SCB-1031] resolve
@ApiOperator @Response override wrong, if the prev…
URL:
https://github.com/apache/servicecomb-java-chassis/pull/999#discussion_r235788636
##
File path:
swagger/swagger-generator/generator-core/src/main/java/org/apache/servicecomb/swagger/generator/core/processor/annotation/AnnotationUtils.java
##
@@ -127,7 +127,35 @@ public static void addResponse(Swagger swagger,
ApiResponse apiResponse) {
public static void addResponse(Swagger swagger, Operation operation,
ApiResponse apiResponse) {
ResponseConfig responseConfig = convert(apiResponse);
generateResponse(swagger, responseConfig);
-operation.response(responseConfig.getCode(), responseConfig.getResponse());
+mergeResponse(operation, responseConfig);
+ }
+
+ private static void mergeResponse(Operation operation, ResponseConfig
responseConfig) {
+if (operation.getResponses() == null) {
+ operation.response(responseConfig.getCode(),
responseConfig.getResponse());
+ return;
+}
+Response response =
operation.getResponses().get(String.valueOf(responseConfig.getCode()));
+if (response != null) {
+ Response targetResp = responseConfig.getResponse();
Review comment:
1.targetResp is source, right?
2.logic for (response == null) is simpler, better to process first and then
return, and no need write "else"
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> The Response's properties was overrided wrong between @APIOperation and
> @Resoponse on the controller method
> ---
>
> Key: SCB-1031
> URL: https://issues.apache.org/jira/browse/SCB-1031
> Project: Apache ServiceComb
> Issue Type: Improvement
> Components: Java-Chassis
>Reporter: jeho0815
>Assignee: jeho0815
>Priority: Major
>
> @ApiResponse(code = 200, message = "200 is ok", response =
> String.class, responseHeaders = @ResponseHeader(name = "x-user-domain",
> response = String.class))
> @ApiOperation(nickname="getHelloworld", value="test", notes="this is a
> test", response = Integer.class, code = 200,
> responseHeaders =
> {@ResponseHeader(name = "x-user-name", response = String.class),
> @ResponseHeader(name = "x-user-id", response = String.class)}
> )
>
> swagger 's response's descritpion will be default "resoponse of 200", the
> best descritpion should be "200 is ok"
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (SCB-968) [SCB-968]968 http2 do not support pump download
[ https://issues.apache.org/jira/browse/SCB-968?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16695860#comment-16695860 ] ASF GitHub Bot commented on SCB-968: coveralls commented on issue #1001: [SCB-968]968 http2 do not support pump download URL: https://github.com/apache/servicecomb-java-chassis/pull/1001#issuecomment-441018970 [](https://coveralls.io/builds/20243795) Coverage decreased (-0.05%) to 86.668% when pulling **1ce3de7ccabdaaca17bec97cb61df400475372b4 on heyile:h2PumpDownload** into **defbfa4e67504356f309a0c447840dae06f22726 on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > [SCB-968]968 http2 do not support pump download > --- > > Key: SCB-968 > URL: https://issues.apache.org/jira/browse/SCB-968 > Project: Apache ServiceComb > Issue Type: Bug > Components: Java-Chassis >Reporter: 何一乐 >Priority: Major > > when use http2 settings, TestDownload in demo will throw a can not save zero > bytes exception. as the last item in pending stack is empty string "" -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-968) [SCB-968]968 http2 do not support pump download
[ https://issues.apache.org/jira/browse/SCB-968?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16695838#comment-16695838 ] ASF GitHub Bot commented on SCB-968: heyile opened a new pull request #1001: [SCB-968]968 http2 do not support pump download URL: https://github.com/apache/servicecomb-java-chassis/pull/1001 Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/SCB) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [ ] Each commit in the pull request should have a meaningful subject line and body. - [ ] Format the pull request title like `[SCB-XXX] Fixes bug in ApproximateQuantiles`, where you replace `SCB-XXX` with the appropriate JIRA issue. - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [ ] Run `mvn clean install` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). --- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > [SCB-968]968 http2 do not support pump download > --- > > Key: SCB-968 > URL: https://issues.apache.org/jira/browse/SCB-968 > Project: Apache ServiceComb > Issue Type: Bug > Components: Java-Chassis >Reporter: 何一乐 >Priority: Major > > when use http2 settings, TestDownload in demo will throw a can not save zero > bytes exception. as the last item in pending stack is empty string "" -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-1032) Support compress the response
[ https://issues.apache.org/jira/browse/SCB-1032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16695615#comment-16695615 ] ASF GitHub Bot commented on SCB-1032: - codecov-io edited a comment on issue #496: SCB-1032 Support compress the response URL: https://github.com/apache/servicecomb-service-center/pull/496#issuecomment-440691271 # [Codecov](https://codecov.io/gh/apache/servicecomb-service-center/pull/496?src=pr=h1) Report > Merging [#496](https://codecov.io/gh/apache/servicecomb-service-center/pull/496?src=pr=desc) into [master](https://codecov.io/gh/apache/servicecomb-service-center/commit/49428294a99f2a475203a7ceb04ce8d5754feb77?src=pr=desc) will **increase** coverage by `0.02%`. > The diff coverage is `0%`. [](https://codecov.io/gh/apache/servicecomb-service-center/pull/496?src=pr=tree) ```diff @@Coverage Diff @@ ## master #496 +/- ## == + Coverage 59.23% 59.25% +0.02% == Files 166 166 Lines 1388013880 == + Hits 8222 8225 +3 Misses 5072 5072 + Partials 586 583 -3 ``` | [Impacted Files](https://codecov.io/gh/apache/servicecomb-service-center/pull/496?src=pr=tree) | Coverage Δ | | |---|---|---| | [...er/plugin/pkg/discovery/servicecenter/aggregate.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/496/diff?src=pr=tree#diff-c2VydmVyL3BsdWdpbi9wa2cvZGlzY292ZXJ5L3NlcnZpY2VjZW50ZXIvYWdncmVnYXRlLmdv) | `8% <0%> (ø)` | :arrow_up: | | [server/broker/util.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/496/diff?src=pr=tree#diff-c2VydmVyL2Jyb2tlci91dGlsLmdv) | `53.2% <0%> (-0.27%)` | :arrow_down: | | [server/govern/service.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/496/diff?src=pr=tree#diff-c2VydmVyL2dvdmVybi9zZXJ2aWNlLmdv) | `72.93% <0%> (+0.33%)` | :arrow_up: | | [pkg/log/logrotate.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/496/diff?src=pr=tree#diff-cGtnL2xvZy9sb2dyb3RhdGUuZ28=) | `34.28% <0%> (+0.57%)` | :arrow_up: | | [pkg/tlsutil/tlsutil.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/496/diff?src=pr=tree#diff-cGtnL3Rsc3V0aWwvdGxzdXRpbC5nbw==) | `74.52% <0%> (+0.94%)` | :arrow_up: | | [server/plugin/pkg/registry/etcd/tracing.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/496/diff?src=pr=tree#diff-c2VydmVyL3BsdWdpbi9wa2cvcmVnaXN0cnkvZXRjZC90cmFjaW5nLmdv) | `81.81% <0%> (+9.09%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/servicecomb-service-center/pull/496?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/servicecomb-service-center/pull/496?src=pr=footer). Last update [4942829...32d0e20](https://codecov.io/gh/apache/servicecomb-service-center/pull/496?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Support compress the response > - > > Key: SCB-1032 > URL: https://issues.apache.org/jira/browse/SCB-1032 > Project: Apache ServiceComb > Issue Type: New Feature > Components: Service-Center >Reporter: little-cui >Assignee: little-cui >Priority: Major > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-1032) Support compress the response
[ https://issues.apache.org/jira/browse/SCB-1032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16695616#comment-16695616 ] ASF GitHub Bot commented on SCB-1032: - coveralls edited a comment on issue #496: SCB-1032 Support compress the response URL: https://github.com/apache/servicecomb-service-center/pull/496#issuecomment-440688511 [](https://coveralls.io/builds/20239127) Coverage increased (+0.03%) to 61.692% when pulling **32d0e20cb0ed4f645378052f12e1cfbbca412d62 on little-cui:gzip** into **49428294a99f2a475203a7ceb04ce8d5754feb77 on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Support compress the response > - > > Key: SCB-1032 > URL: https://issues.apache.org/jira/browse/SCB-1032 > Project: Apache ServiceComb > Issue Type: New Feature > Components: Service-Center >Reporter: little-cui >Assignee: little-cui >Priority: Major > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-1033) Update license for Service-Center
[ https://issues.apache.org/jira/browse/SCB-1033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16695582#comment-16695582 ] ASF GitHub Bot commented on SCB-1033: - asifdxtreme commented on a change in pull request #495: [SCB-1033] Update third party licenses URL: https://github.com/apache/servicecomb-service-center/pull/495#discussion_r235612050 ## File path: scripts/release/LICENSE ## @@ -214,39 +214,40 @@ The following components are provided under the Apache License Version 2.0. See the respective project link for details. github.com/apache/thrift/lib/go/thrift (3d556248a8b97310da49939195330691dfe9d9ad) Review comment: Currently we are still using the glide.yaml for dependency managment so keeping specified version of glide.yaml is suggested. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Update license for Service-Center > - > > Key: SCB-1033 > URL: https://issues.apache.org/jira/browse/SCB-1033 > Project: Apache ServiceComb > Issue Type: Task > Components: Service-Center >Affects Versions: service-center-1.1.0 >Reporter: Yang Bo >Assignee: Yang Bo >Priority: Major > Fix For: service-center-1.1.0 > > > Update license for Service-Center -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-1035) Update third party licenses for java-chassis
[ https://issues.apache.org/jira/browse/SCB-1035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16695528#comment-16695528 ] ASF GitHub Bot commented on SCB-1035: - coveralls commented on issue #1000: [SCB-1035] Update license and notice for third parties URL: https://github.com/apache/servicecomb-java-chassis/pull/1000#issuecomment-440904072 [](https://coveralls.io/builds/20237478) Coverage decreased (-0.01%) to 86.703% when pulling **3d77eb3204e45c97bb1451d95bfe7bdebc1bc758 on yangbor:master** into **defbfa4e67504356f309a0c447840dae06f22726 on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Update third party licenses for java-chassis > > > Key: SCB-1035 > URL: https://issues.apache.org/jira/browse/SCB-1035 > Project: Apache ServiceComb > Issue Type: Task > Components: Java-Chassis >Affects Versions: java-chassis-1.1.0 >Reporter: Yang Bo >Assignee: Yang Bo >Priority: Major > Fix For: java-chassis-1.1.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-1035) Update third party licenses for java-chassis
[ https://issues.apache.org/jira/browse/SCB-1035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16695518#comment-16695518 ] ASF GitHub Bot commented on SCB-1035: - yangbor opened a new pull request #1000: [SCB-1035] Update license and notice for third parties URL: https://github.com/apache/servicecomb-java-chassis/pull/1000 Fix build errors for release and update license/notice for binary release. Follow this checklist to help us incorporate your contribution quickly and easily: - [X] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/SCB) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [X] Each commit in the pull request should have a meaningful subject line and body. - [X] Format the pull request title like `[SCB-XXX] Fixes bug in ApproximateQuantiles`, where you replace `SCB-XXX` with the appropriate JIRA issue. - [X] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [X] Run `mvn clean install` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [X] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). --- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Update third party licenses for java-chassis > > > Key: SCB-1035 > URL: https://issues.apache.org/jira/browse/SCB-1035 > Project: Apache ServiceComb > Issue Type: Task > Components: Java-Chassis >Affects Versions: java-chassis-1.1.0 >Reporter: Yang Bo >Assignee: Yang Bo >Priority: Major > Fix For: java-chassis-1.1.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-1030) NPE when use DynamicSchemaLoader.registerSchemas(String, String)
[
https://issues.apache.org/jira/browse/SCB-1030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16695502#comment-16695502
]
ASF GitHub Bot commented on SCB-1030:
-
laijianbin closed pull request #996: 【SCB-1030】NPE when use
DynamicSchemaLoader.registerSchemas(String, St…
URL: https://github.com/apache/servicecomb-java-chassis/pull/996
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/common/common-rest/src/main/java/org/apache/servicecomb/common/rest/locator/ServicePathManager.java
b/common/common-rest/src/main/java/org/apache/servicecomb/common/rest/locator/ServicePathManager.java
index 932a81be8..11b6c3f7c 100644
---
a/common/common-rest/src/main/java/org/apache/servicecomb/common/rest/locator/ServicePathManager.java
+++
b/common/common-rest/src/main/java/org/apache/servicecomb/common/rest/locator/ServicePathManager.java
@@ -96,6 +96,7 @@ public void addSchema(SchemaMeta schemaMeta) {
public ServicePathManager cloneServicePathManager() {
ServicePathManager mgr = new ServicePathManager(microserviceMeta);
+mgr.buildProducerPaths();
swaggerPaths.cloneTo(mgr.swaggerPaths);
mgr.schemaIdSet.addAll(schemaIdSet);
return mgr;
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> NPE when use DynamicSchemaLoader.registerSchemas(String, String)
>
>
> Key: SCB-1030
> URL: https://issues.apache.org/jira/browse/SCB-1030
> Project: Apache ServiceComb
> Issue Type: Task
>Reporter: laijianbin
>Assignee: laijianbin
>Priority: Major
> Attachments: image-2018-11-19-15-23-58-612.png
>
>
> 2018-11-19 11:46:14,758 [ERROR] http server failed.
> org.apache.servicecomb.transport.rest.vertx.VertxRestDispatcher.failureHandler(VertxRestDispatcher.java:72)
> java.lang.NullPointerException
> at
> org.apache.servicecomb.common.rest.locator.OperationLocator.locate(OperationLocator.java:56)
> at
> org.apache.servicecomb.common.rest.locator.ServicePathManager.producerLocateOperation(ServicePathManager.java:116)
> at
> org.apache.servicecomb.common.rest.RestProducerInvocation.locateOperation(RestProducerInvocation.java:61)
> at
> org.apache.servicecomb.common.rest.AbstractRestInvocation.findRestOperation(AbstractRestInvocation.java:80)
> at
> org.apache.servicecomb.common.rest.RestProducerInvocation.findRestOperation(RestProducerInvocation.java:56)
> at
> org.apache.servicecomb.common.rest.RestProducerInvocation.invoke(RestProducerInvocation.java:45)
> at
> org.apache.servicecomb.transport.rest.vertx.VertxRestDispatcher.onRequest(VertxRestDispatcher.java:194)
> at io.vertx.ext.web.impl.RouteImpl.handleContext(RouteImpl.java:223)
> at
> io.vertx.ext.web.impl.RoutingContextImplBase.iterateNext(RoutingContextImplBase.java:101)
> at io.vertx.ext.web.impl.RoutingContextImpl.next(RoutingContextImpl.java:120)
> at
> org.apache.servicecomb.transport.rest.vertx.RestBodyHandler$BHandler.doEnd(RestBodyHandler.java:248)
> at
> org.apache.servicecomb.transport.rest.vertx.RestBodyHandler$BHandler.end(RestBodyHandler.java:226)
> at
> org.apache.servicecomb.transport.rest.vertx.RestBodyHandler.lambda$0(RestBodyHandler.java:86)
> at
> io.vertx.core.http.impl.HttpServerRequestImpl.handleEnd(HttpServerRequestImpl.java:418)
> at
> io.vertx.core.http.impl.ServerConnection.handleLastHttpContent(ServerConnection.java:475)
> at
> io.vertx.core.http.impl.ServerConnection.processMessage(ServerConnection.java:446)
> at
> io.vertx.core.http.impl.ServerConnection.handleMessage(ServerConnection.java:156)
> at
> io.vertx.core.http.impl.HttpServerImpl$ServerHandlerWithWebSockets.handleMessage(HttpServerImpl.java:705)
> at
> io.vertx.core.http.impl.HttpServerImpl$ServerHandlerWithWebSockets.handleMessage(HttpServerImpl.java:614)
> at
> io.vertx.core.net.impl.VertxHandler.lambda$channelRead$1(VertxHandler.java:150)
> at io.vertx.core.impl.ContextImpl.lambda$wrapTask$2(ContextImpl.java:342)
> at io.vertx.core.impl.ContextImpl.executeFromIO(ContextImpl.java:200)
> at io.vertx.core.net.impl.VertxHandler.channelRead(VertxHandler.java:148)
> at
> io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:362)
> at
> io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:348)
> at
>
[jira] [Commented] (SCB-1032) Support compress the response
[ https://issues.apache.org/jira/browse/SCB-1032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16694804#comment-16694804 ] ASF GitHub Bot commented on SCB-1032: - coveralls edited a comment on issue #496: SCB-1032 Support compress the response URL: https://github.com/apache/servicecomb-service-center/pull/496#issuecomment-440688511 [](https://coveralls.io/builds/20225097) Coverage increased (+0.08%) to 61.738% when pulling **9a3ef86fc909235b23122b461b03d9a636c51669 on little-cui:gzip** into **49428294a99f2a475203a7ceb04ce8d5754feb77 on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Support compress the response > - > > Key: SCB-1032 > URL: https://issues.apache.org/jira/browse/SCB-1032 > Project: Apache ServiceComb > Issue Type: New Feature > Components: Service-Center >Reporter: little-cui >Assignee: little-cui >Priority: Major > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-1032) Support compress the response
[ https://issues.apache.org/jira/browse/SCB-1032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16694805#comment-16694805 ] ASF GitHub Bot commented on SCB-1032: - codecov-io commented on issue #496: SCB-1032 Support compress the response URL: https://github.com/apache/servicecomb-service-center/pull/496#issuecomment-440691271 # [Codecov](https://codecov.io/gh/apache/servicecomb-service-center/pull/496?src=pr=h1) Report > Merging [#496](https://codecov.io/gh/apache/servicecomb-service-center/pull/496?src=pr=desc) into [master](https://codecov.io/gh/apache/servicecomb-service-center/commit/49428294a99f2a475203a7ceb04ce8d5754feb77?src=pr=desc) will **decrease** coverage by `0.01%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/servicecomb-service-center/pull/496?src=pr=tree) ```diff @@Coverage Diff @@ ## master #496 +/- ## == - Coverage 59.23% 59.22% -0.02% == Files 166 166 Lines 1388013880 == - Hits 8222 8220 -2 - Misses 5072 5079 +7 + Partials 586 581 -5 ``` | [Impacted Files](https://codecov.io/gh/apache/servicecomb-service-center/pull/496?src=pr=tree) | Coverage Δ | | |---|---|---| | [server/service/notification/listwatcher.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/496/diff?src=pr=tree#diff-c2VydmVyL3NlcnZpY2Uvbm90aWZpY2F0aW9uL2xpc3R3YXRjaGVyLmdv) | `69.01% <0%> (-9.86%)` | :arrow_down: | | [server/service/notification/websocket.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/496/diff?src=pr=tree#diff-c2VydmVyL3NlcnZpY2Uvbm90aWZpY2F0aW9uL3dlYnNvY2tldC5nbw==) | `84.51% <0%> (+0.64%)` | :arrow_up: | | [pkg/tlsutil/tlsutil.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/496/diff?src=pr=tree#diff-cGtnL3Rsc3V0aWwvdGxzdXRpbC5nbw==) | `74.52% <0%> (+0.94%)` | :arrow_up: | | [pkg/util/tree.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/496/diff?src=pr=tree#diff-cGtnL3V0aWwvdHJlZS5nbw==) | `84.37% <0%> (+3.12%)` | :arrow_up: | | [server/service/util/heartbeat\_util.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/496/diff?src=pr=tree#diff-c2VydmVyL3NlcnZpY2UvdXRpbC9oZWFydGJlYXRfdXRpbC5nbw==) | `80% <0%> (+6.66%)` | :arrow_up: | | [server/plugin/pkg/registry/etcd/tracing.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/496/diff?src=pr=tree#diff-c2VydmVyL3BsdWdpbi9wa2cvcmVnaXN0cnkvZXRjZC90cmFjaW5nLmdv) | `81.81% <0%> (+9.09%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/servicecomb-service-center/pull/496?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/servicecomb-service-center/pull/496?src=pr=footer). Last update [4942829...9a3ef86](https://codecov.io/gh/apache/servicecomb-service-center/pull/496?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Support compress the response > - > > Key: SCB-1032 > URL: https://issues.apache.org/jira/browse/SCB-1032 > Project: Apache ServiceComb > Issue Type: New Feature > Components: Service-Center >Reporter: little-cui >Assignee: little-cui >Priority: Major > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-1032) Support compress the response
[ https://issues.apache.org/jira/browse/SCB-1032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16694786#comment-16694786 ] ASF GitHub Bot commented on SCB-1032: - coveralls commented on issue #496: SCB-1032 Support compress the response URL: https://github.com/apache/servicecomb-service-center/pull/496#issuecomment-440688511 [](https://coveralls.io/builds/20224916) Coverage decreased (-0.05%) to 61.607% when pulling **9a3ef86fc909235b23122b461b03d9a636c51669 on little-cui:gzip** into **49428294a99f2a475203a7ceb04ce8d5754feb77 on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Support compress the response > - > > Key: SCB-1032 > URL: https://issues.apache.org/jira/browse/SCB-1032 > Project: Apache ServiceComb > Issue Type: New Feature > Components: Service-Center >Reporter: little-cui >Assignee: little-cui >Priority: Major > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-1032) Support compress the response
[ https://issues.apache.org/jira/browse/SCB-1032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16694765#comment-16694765 ] ASF GitHub Bot commented on SCB-1032: - little-cui opened a new pull request #496: SCB-1032 Support compress the response URL: https://github.com/apache/servicecomb-service-center/pull/496 Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/SCB) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [ ] Each commit in the pull request should have a meaningful subject line and body. - [ ] Format the pull request title like `[SCB-XXX] Fixes bug in ApproximateQuantiles`, where you replace `SCB-XXX` with the appropriate JIRA issue. - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [ ] Run `go build` `go test` `go fmt` `go vet` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). --- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Support compress the response > - > > Key: SCB-1032 > URL: https://issues.apache.org/jira/browse/SCB-1032 > Project: Apache ServiceComb > Issue Type: New Feature > Components: Service-Center >Reporter: little-cui >Assignee: little-cui >Priority: Major > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-993) Bug fixes
[
https://issues.apache.org/jira/browse/SCB-993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16694761#comment-16694761
]
ASF GitHub Bot commented on SCB-993:
little-cui closed pull request #493: SCB-993 search sc cluster when key
mismatch with aggregator cache
URL: https://github.com/apache/servicecomb-service-center/pull/493
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/pkg/cache/cache_test.go b/pkg/cache/cache_test.go
index 331666ea..bfd337ef 100644
--- a/pkg/cache/cache_test.go
+++ b/pkg/cache/cache_test.go
@@ -26,12 +26,12 @@ import (
type level1 struct {
}
-func (l *level1) Name(ctx context.Context) string {
+func (l *level1) Name(ctx context.Context, _ *Node) string {
return ctx.Value("key1").(string)
}
func (l *level1) Init(ctx context.Context, parent *Node) (node *Node, err
error) {
- p := l.Name(ctx)
+ p := l.Name(ctx, parent)
if p == "err" {
return nil, fmt.Errorf("wrong logic")
}
@@ -51,7 +51,7 @@ type level2 struct {
changed string
}
-func (l *level2) Name(ctx context.Context) string {
+func (l *level2) Name(ctx context.Context, _ *Node) string {
return ctx.Value("key2").(string)
}
@@ -60,7 +60,7 @@ func (l *level2) Init(ctx context.Context, parent *Node)
(node *Node, err error)
return
}
- p := l.Name(ctx)
+ p := l.Name(ctx, parent)
if p == "err" {
return nil, fmt.Errorf("wrong logic")
}
diff --git a/pkg/cache/filter.go b/pkg/cache/filter.go
index 51c64481..9652fcf9 100644
--- a/pkg/cache/filter.go
+++ b/pkg/cache/filter.go
@@ -19,6 +19,6 @@ package cache
import "golang.org/x/net/context"
type Filter interface {
- Name(ctx context.Context) string
+ Name(ctx context.Context, parent *Node) string
Init(ctx context.Context, parent *Node) (*Node, error)
}
diff --git a/pkg/cache/tree.go b/pkg/cache/tree.go
index 9c89df08..d9adcf57 100644
--- a/pkg/cache/tree.go
+++ b/pkg/cache/tree.go
@@ -77,7 +77,7 @@ func (t *Tree) Remove(ctx context.Context) {
return
}
- t.roots.Delete(t.filters[0].Name(ctx))
+ t.roots.Delete(t.filters[0].Name(ctx, nil))
}
func (t *Tree) getOrCreateRoot(ctx context.Context) (node *Node, err error) {
@@ -86,7 +86,7 @@ func (t *Tree) getOrCreateRoot(ctx context.Context) (node
*Node, err error) {
}
filter := t.filters[0]
- name := filter.Name(ctx)
+ name := filter.Name(ctx, nil)
item, err := t.roots.Fetch(name, t.Config.TTL(), func() (interface{},
error) {
node, err := t.getOrCreateNode(ctx, 0, nil)
if err != nil {
@@ -108,7 +108,7 @@ func (t *Tree) getOrCreateRoot(ctx context.Context) (node
*Node, err error) {
func (t *Tree) getOrCreateNode(ctx context.Context, idx int, parent *Node)
(node *Node, err error) {
filter := t.filters[idx]
- name := t.nodeFullName(filter.Name(ctx), parent)
+ name := t.nodeFullName(filter.Name(ctx, parent), parent)
if parent == nil {
// new a temp node
diff --git a/pkg/client/sc/apis.go b/pkg/client/sc/apis.go
index e0103af1..3fb8f1a5 100644
--- a/pkg/client/sc/apis.go
+++ b/pkg/client/sc/apis.go
@@ -25,17 +25,22 @@ import (
scerr "github.com/apache/servicecomb-service-center/server/error"
"github.com/apache/servicecomb-service-center/server/plugin/pkg/registry"
"github.com/apache/servicecomb-service-center/version"
+ "golang.org/x/net/context"
"io/ioutil"
"net/http"
)
const (
- apiVersionURL = "/version"
- apiDumpURL = "/v4/default/admin/dump"
- apiClustersURL = "/v4/default/admin/clusters"
- apiHealthURL = "/v4/default/registry/health"
- apiSchemasURL = "/v4/%s/registry/microservices/%s/schemas"
- apiSchemaURL = "/v4/%s/registry/microservices/%s/schemas/%s"
+ apiVersionURL = "/version"
+ apiDumpURL = "/v4/default/admin/dump"
+ apiClustersURL = "/v4/default/admin/clusters"
+ apiHealthURL= "/v4/default/registry/health"
+ apiSchemasURL = "/v4/%s/registry/microservices/%s/schemas"
+ apiSchemaURL= "/v4/%s/registry/microservices/%s/schemas/%s"
+ apiInstancesURL = "/v4/%s/registry/microservices/%s/instances"
+ apiInstanceURL = "/v4/%s/registry/microservices/%s/instances/%s"
+
+ QueryGlobal = "global"
)
func (c *SCClient) toError(body []byte) *scerr.Error {
@@ -47,8 +52,18 @@ func (c *SCClient) toError(body []byte) *scerr.Error {
return message
}
-func (c *SCClient) GetScVersion() (*version.VersionSet, *scerr.Error) {
-
[jira] [Commented] (SCB-1033) Update license for Service-Center
[ https://issues.apache.org/jira/browse/SCB-1033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16694600#comment-16694600 ] ASF GitHub Bot commented on SCB-1033: - coveralls commented on issue #495: [SCB-1033] Update third party licenses URL: https://github.com/apache/servicecomb-service-center/pull/495#issuecomment-440637742 [](https://coveralls.io/builds/20221861) Coverage increased (+0.01%) to 62.171% when pulling **0c57a1be9865a209a3be46e02be1fb22128da3ed on yangbor:master** into **0a0b1fd8a8f7b1f7c6fd4badcfde6032ed17f8de on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Update license for Service-Center > - > > Key: SCB-1033 > URL: https://issues.apache.org/jira/browse/SCB-1033 > Project: Apache ServiceComb > Issue Type: Task > Components: Service-Center >Affects Versions: service-center-1.1.0 >Reporter: Yang Bo >Assignee: Yang Bo >Priority: Major > Fix For: service-center-1.1.0 > > > Update license for Service-Center -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-1033) Update license for Service-Center
[ https://issues.apache.org/jira/browse/SCB-1033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16694598#comment-16694598 ] ASF GitHub Bot commented on SCB-1033: - codecov-io commented on issue #495: [SCB-1033] Update third party licenses URL: https://github.com/apache/servicecomb-service-center/pull/495#issuecomment-440637647 # [Codecov](https://codecov.io/gh/apache/servicecomb-service-center/pull/495?src=pr=h1) Report > Merging [#495](https://codecov.io/gh/apache/servicecomb-service-center/pull/495?src=pr=desc) into [master](https://codecov.io/gh/apache/servicecomb-service-center/commit/0a0b1fd8a8f7b1f7c6fd4badcfde6032ed17f8de?src=pr=desc) will **decrease** coverage by `0.01%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/servicecomb-service-center/pull/495?src=pr=tree) ```diff @@Coverage Diff @@ ## master #495 +/- ## == - Coverage 59.74% 59.73% -0.02% == Files 165 165 Lines 1379613796 == - Hits 8243 8241 -2 Misses 4973 4973 - Partials 580 582 +2 ``` | [Impacted Files](https://codecov.io/gh/apache/servicecomb-service-center/pull/495?src=pr=tree) | Coverage Δ | | |---|---|---| | [server/service/util/util.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/495/diff?src=pr=tree#diff-c2VydmVyL3NlcnZpY2UvdXRpbC91dGlsLmdv) | `80% <0%> (-10%)` | :arrow_down: | | [server/service/notification/websocket.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/495/diff?src=pr=tree#diff-c2VydmVyL3NlcnZpY2Uvbm90aWZpY2F0aW9uL3dlYnNvY2tldC5nbw==) | `83.87% <0%> (-0.65%)` | :arrow_down: | | [pkg/log/logrotate.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/495/diff?src=pr=tree#diff-cGtnL2xvZy9sb2dyb3RhdGUuZ28=) | `33.71% <0%> (-0.58%)` | :arrow_down: | | [server/govern/service.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/495/diff?src=pr=tree#diff-c2VydmVyL2dvdmVybi9zZXJ2aWNlLmdv) | `72.6% <0%> (-0.34%)` | :arrow_down: | | [...erver/plugin/pkg/tracing/buildin/file\_collector.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/495/diff?src=pr=tree#diff-c2VydmVyL3BsdWdpbi9wa2cvdHJhY2luZy9idWlsZGluL2ZpbGVfY29sbGVjdG9yLmdv) | `64.07% <0%> (+0.97%)` | :arrow_up: | | [server/service/util/heartbeat\_util.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/495/diff?src=pr=tree#diff-c2VydmVyL3NlcnZpY2UvdXRpbC9oZWFydGJlYXRfdXRpbC5nbw==) | `80% <0%> (+6.66%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/servicecomb-service-center/pull/495?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/servicecomb-service-center/pull/495?src=pr=footer). Last update [0a0b1fd...0c57a1b](https://codecov.io/gh/apache/servicecomb-service-center/pull/495?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Update license for Service-Center > - > > Key: SCB-1033 > URL: https://issues.apache.org/jira/browse/SCB-1033 > Project: Apache ServiceComb > Issue Type: Task > Components: Service-Center >Affects Versions: service-center-1.1.0 >Reporter: Yang Bo >Assignee: Yang Bo >Priority: Major > Fix For: service-center-1.1.0 > > > Update license for Service-Center -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-993) Bug fixes
[ https://issues.apache.org/jira/browse/SCB-993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16694581#comment-16694581 ] ASF GitHub Bot commented on SCB-993: codecov-io edited a comment on issue #493: WIP: SCB-993 search sc cluster when key mismatch with aggregator cache URL: https://github.com/apache/servicecomb-service-center/pull/493#issuecomment-439767176 # [Codecov](https://codecov.io/gh/apache/servicecomb-service-center/pull/493?src=pr=h1) Report > Merging [#493](https://codecov.io/gh/apache/servicecomb-service-center/pull/493?src=pr=desc) into [master](https://codecov.io/gh/apache/servicecomb-service-center/commit/0a0b1fd8a8f7b1f7c6fd4badcfde6032ed17f8de?src=pr=desc) will **decrease** coverage by `0.49%`. > The diff coverage is `25.44%`. [](https://codecov.io/gh/apache/servicecomb-service-center/pull/493?src=pr=tree) ```diff @@Coverage Diff@@ ## master #493 +/- ## = - Coverage 59.74% 59.25% -0.5% = Files 165 166 +1 Lines 1379613880 +84 = - Hits 8243 8224 -19 - Misses 4973 5072 +99 - Partials 580 584 +4 ``` | [Impacted Files](https://codecov.io/gh/apache/servicecomb-service-center/pull/493?src=pr=tree) | Coverage Δ | | |---|---|---| | [server/service/event/instance\_event\_handler.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/493/diff?src=pr=tree#diff-c2VydmVyL3NlcnZpY2UvZXZlbnQvaW5zdGFuY2VfZXZlbnRfaGFuZGxlci5nbw==) | `7.54% <0%> (-0.3%)` | :arrow_down: | | [pkg/util/util.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/493/diff?src=pr=tree#diff-cGtnL3V0aWwvdXRpbC5nbw==) | `62.02% <0%> (-4.2%)` | :arrow_down: | | [...rver/plugin/pkg/discovery/servicecenter/indexer.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/493/diff?src=pr=tree#diff-c2VydmVyL3BsdWdpbi9wa2cvZGlzY292ZXJ5L3NlcnZpY2VjZW50ZXIvaW5kZXhlci5nbw==) | `0% <0%> (-35%)` | :arrow_down: | | [...erver/plugin/pkg/discovery/servicecenter/cacher.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/493/diff?src=pr=tree#diff-c2VydmVyL3BsdWdpbi9wa2cvZGlzY292ZXJ5L3NlcnZpY2VjZW50ZXIvY2FjaGVyLmdv) | `33.33% <0%> (ø)` | :arrow_up: | | [server/service/util/util.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/493/diff?src=pr=tree#diff-c2VydmVyL3NlcnZpY2UvdXRpbC91dGlsLmdv) | `80% <0%> (-10%)` | :arrow_down: | | [server/service/event/dependency\_event\_handler.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/493/diff?src=pr=tree#diff-c2VydmVyL3NlcnZpY2UvZXZlbnQvZGVwZW5kZW5jeV9ldmVudF9oYW5kbGVyLmdv) | `15.17% <0%> (-0.14%)` | :arrow_down: | | [scctl/pkg/plugin/diagnose/diagnose.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/493/diff?src=pr=tree#diff-c2NjdGwvcGtnL3BsdWdpbi9kaWFnbm9zZS9kaWFnbm9zZS5nbw==) | `64.77% <0%> (ø)` | :arrow_up: | | [...rver/plugin/pkg/discovery/servicecenter/adaptor.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/493/diff?src=pr=tree#diff-c2VydmVyL3BsdWdpbi9wa2cvZGlzY292ZXJ5L3NlcnZpY2VjZW50ZXIvYWRhcHRvci5nbw==) | `0% <0%> (ø)` | :arrow_up: | | [server/service/event/rule\_event\_handler.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/493/diff?src=pr=tree#diff-c2VydmVyL3NlcnZpY2UvZXZlbnQvcnVsZV9ldmVudF9oYW5kbGVyLmdv) | `8.33% <0%> (-0.37%)` | :arrow_down: | | [server/service/event/tag\_event\_handler.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/493/diff?src=pr=tree#diff-c2VydmVyL3NlcnZpY2UvZXZlbnQvdGFnX2V2ZW50X2hhbmRsZXIuZ28=) | `7.14% <0%> (-0.27%)` | :arrow_down: | | ... and [16 more](https://codecov.io/gh/apache/servicecomb-service-center/pull/493/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/servicecomb-service-center/pull/493?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/servicecomb-service-center/pull/493?src=pr=footer). Last update [0a0b1fd...bcee692](https://codecov.io/gh/apache/servicecomb-service-center/pull/493?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub
[jira] [Commented] (SCB-993) Bug fixes
[ https://issues.apache.org/jira/browse/SCB-993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16694582#comment-16694582 ] ASF GitHub Bot commented on SCB-993: coveralls edited a comment on issue #493: WIP: SCB-993 search sc cluster when key mismatch with aggregator cache URL: https://github.com/apache/servicecomb-service-center/pull/493#issuecomment-439767178 [](https://coveralls.io/builds/20221615) Coverage decreased (-0.4%) to 61.748% when pulling **bcee69265855e72151bb3c27ea91e0974f689b12 on little-cui:bug** into **0a0b1fd8a8f7b1f7c6fd4badcfde6032ed17f8de on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Bug fixes > - > > Key: SCB-993 > URL: https://issues.apache.org/jira/browse/SCB-993 > Project: Apache ServiceComb > Issue Type: Bug > Components: Service-Center >Reporter: little-cui >Assignee: little-cui >Priority: Major > Fix For: service-center-1.1.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-1033) Update license for Service-Center
[ https://issues.apache.org/jira/browse/SCB-1033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16694576#comment-16694576 ] ASF GitHub Bot commented on SCB-1033: - yangbor opened a new pull request #495: [SCB-1033] Update third party licenses URL: https://github.com/apache/servicecomb-service-center/pull/495 Follow this checklist to help us incorporate your contribution quickly and easily: - [X] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/SCB) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [X] Each commit in the pull request should have a meaningful subject line and body. - [X Format the pull request title like `[SCB-XXX] Fixes bug in ApproximateQuantiles`, where you replace `SCB-XXX` with the appropriate JIRA issue. - [X] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [X] Run `go build` `go test` `go fmt` `go vet` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [X] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). --- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Update license for Service-Center > - > > Key: SCB-1033 > URL: https://issues.apache.org/jira/browse/SCB-1033 > Project: Apache ServiceComb > Issue Type: Task > Components: Service-Center >Affects Versions: service-center-1.1.0 >Reporter: Yang Bo >Assignee: Yang Bo >Priority: Major > Fix For: service-center-1.1.0 > > > Update license for Service-Center -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-1031) The Response's properties was overrided wrong between @APIOperation and @Resoponse on the controller method
[
https://issues.apache.org/jira/browse/SCB-1031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16694571#comment-16694571
]
ASF GitHub Bot commented on SCB-1031:
-
coveralls commented on issue #999: [SCB-1031] resolve @ApiOperator @Response
override wrong, if the prev…
URL:
https://github.com/apache/servicecomb-java-chassis/pull/999#issuecomment-440630826
[](https://coveralls.io/builds/20221537)
Coverage decreased (-0.006%) to 86.709% when pulling
**3ac6d8a59e78d376f65afb92c3de65cace9adee8 on jeho0815:Branch_master_SCB-1031**
into **defbfa4e67504356f309a0c447840dae06f22726 on apache:master**.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> The Response's properties was overrided wrong between @APIOperation and
> @Resoponse on the controller method
> ---
>
> Key: SCB-1031
> URL: https://issues.apache.org/jira/browse/SCB-1031
> Project: Apache ServiceComb
> Issue Type: Improvement
> Components: Java-Chassis
>Reporter: jeho0815
>Assignee: jeho0815
>Priority: Major
>
> @ApiResponse(code = 200, message = "200 is ok", response =
> String.class, responseHeaders = @ResponseHeader(name = "x-user-domain",
> response = String.class))
> @ApiOperation(nickname="getHelloworld", value="test", notes="this is a
> test", response = Integer.class, code = 200,
> responseHeaders =
> {@ResponseHeader(name = "x-user-name", response = String.class),
> @ResponseHeader(name = "x-user-id", response = String.class)}
> )
>
> swagger 's response's descritpion will be default "resoponse of 200", the
> best descritpion should be "200 is ok"
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (SCB-993) Bug fixes
[ https://issues.apache.org/jira/browse/SCB-993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16694361#comment-16694361 ] ASF GitHub Bot commented on SCB-993: coveralls edited a comment on issue #493: WIP: SCB-993 search sc cluster when key mismatch with aggregator cache URL: https://github.com/apache/servicecomb-service-center/pull/493#issuecomment-439767178 [](https://coveralls.io/builds/20218501) Coverage decreased (-0.4%) to 61.759% when pulling **84e1d2b3c98141d89c8ac4cec058eeff69ccb6b6 on little-cui:bug** into **0a0b1fd8a8f7b1f7c6fd4badcfde6032ed17f8de on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Bug fixes > - > > Key: SCB-993 > URL: https://issues.apache.org/jira/browse/SCB-993 > Project: Apache ServiceComb > Issue Type: Bug > Components: Service-Center >Reporter: little-cui >Assignee: little-cui >Priority: Major > Fix For: service-center-1.1.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
