[jira] [Commented] (SOLR-16350) http response is delayed when solr is running in slow/restricted network environment
[
https://issues.apache.org/jira/browse/SOLR-16350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17628120#comment-17628120
]
Shubanker commented on SOLR-16350:
--
[~krisden] Yes I did try accessing it over 127.0.0.1, the delay is not while
making a connection to SOLR server but rather SOLR processing internally.
I saved the log of a simple GET Request of _/solr/admin/cores?wt=json_ and here
is the part of log where you can see the time difference at
{_}QueuedThreadPool ran CEP:SocketChannelEndPoint@1177a867{_}:
{quote}2022-08-23 10:46:54.516 DEBUG (qtp156710276-24) []
o.e.j.i.ChannelEndPoint changeInterests p=false 0->1 for
SocketChannelEndPoint@1177a867\{l=/172.17.0.2:8983,r=/172.17.0.1:63578,OPEN,fill=FI,flush=-,to=0/12}{io=0/1,kio=0,kro=1}->HttpConnection@3c82c535[p=HttpParser\{s=START,0
of
-1},g=HttpGenerator@28258fd1\{s=START}]=>HttpChannelOverHttp@a882b5b\{s=HttpChannelState@1d440803{s=IDLE
rs=BLOCKING os=OPEN is=IDLE awp=false se=false i=true
al=0},r=1,c=false/false,a=IDLE,uri=null,age=0}
2022-08-23 10:46:54.517 DEBUG (qtp156710276-24) [] o.e.j.i.ManagedSelector
Queued change lazy=false
org.eclipse.jetty.io.ChannelEndPoint$$Lambda$684/0x000800fc3ba0@67447191 on
ManagedSelector@a5bbaec\{STARTED} id=1 keys=1 selected=0 updates=0
2022-08-23 10:46:54.517 DEBUG (qtp156710276-24) [] o.e.j.i.ManagedSelector
Wakeup on submit ManagedSelector@a5bbaec\{STARTED} id=1 keys=1 selected=0
updates=1
2022-08-23 10:46:54.517 DEBUG (qtp156710276-19) [] o.e.j.i.ManagedSelector
Selector sun.nio.ch.EPollSelectorImpl@373889ae woken with none selected
2022-08-23 10:46:54.517 DEBUG (qtp156710276-19) [] o.e.j.i.ManagedSelector
Selector sun.nio.ch.EPollSelectorImpl@373889ae woken up from select, 0/0/1
selected
2022-08-23 10:46:54.517 DEBUG (qtp156710276-19) [] o.e.j.i.ManagedSelector
Selector sun.nio.ch.EPollSelectorImpl@373889ae processing 0 keys, 1 updates
2022-08-23 10:46:54.517 DEBUG (qtp156710276-19) [] o.e.j.i.ManagedSelector
updateable 1
2022-08-23 10:46:54.517 DEBUG (qtp156710276-19) [] o.e.j.i.ManagedSelector
update
org.eclipse.jetty.io.ChannelEndPoint$$Lambda$684/0x000800fc3ba0@67447191
2022-08-23 10:46:54.517 DEBUG (qtp156710276-19) [] o.e.j.i.ChannelEndPoint Key
interests updated 0 -> 1 on
SocketChannelEndPoint@1177a867\{l=/172.17.0.2:8983,r=/172.17.0.1:63578,OPEN,fill=FI,flush=-,to=1/12}{io=1/1,kio=1,kro=1}->HttpConnection@3c82c535[p=HttpParser\{s=START,0
of
-1},g=HttpGenerator@28258fd1\{s=START}]=>HttpChannelOverHttp@a882b5b\{s=HttpChannelState@1d440803{s=IDLE
rs=BLOCKING os=OPEN is=IDLE awp=false se=false i=true
al=0},r=1,c=false/false,a=IDLE,uri=null,age=0}
2022-08-23 10:46:54.517 DEBUG (qtp156710276-19) [] o.e.j.i.ManagedSelector
updates 0
2022-08-23 10:46:54.517 DEBUG (qtp156710276-19) [] o.e.j.i.ManagedSelector
Selector sun.nio.ch.EPollSelectorImpl@373889ae waiting with 1 keys
2022-08-23 10:46:54.518 DEBUG (qtp156710276-24) [] o.e.j.s.HttpConnection
HttpConnection@3c82c535::SocketChannelEndPoint@1177a867\{l=/172.17.0.2:8983,r=/172.17.0.1:63578,OPEN,fill=FI,flush=-,to=1/12}{io=1/1,kio=1,kro=1}->HttpConnection@3c82c535[p=HttpParser\{s=START,0
of
-1},g=HttpGenerator@28258fd1\{s=START}]=>HttpChannelOverHttp@a882b5b\{s=HttpChannelState@1d440803{s=IDLE
rs=BLOCKING os=OPEN is=IDLE awp=false se=false i=true
al=0},r=1,c=false/false,a=IDLE,uri=null,age=0} onFillable exit
HttpChannelState@1d440803\{s=IDLE rs=BLOCKING os=OPEN is=IDLE awp=false
se=false i=true al=0} null
2022-08-23 10:46:54.518 DEBUG (qtp156710276-24) [] o.e.j.u.t.QueuedThreadPool
ran
CEP:SocketChannelEndPoint@1177a867\{l=/172.17.0.2:8983,r=/172.17.0.1:63578,OPEN,fill=FI,flush=-,to=2/12}{io=1/1,kio=1,kro=1}->HttpConnection@3c82c535[p=HttpParser\{s=START,0
of
-1},g=HttpGenerator@28258fd1\{s=START}]=>HttpChannelOverHttp@a882b5b\{s=HttpChannelState@1d440803{s=IDLE
rs=BLOCKING os=OPEN is=IDLE awp=false se=false i=true
al=0},r=1,c=false/false,a=IDLE,uri=null,age=0}:runFillable:BLOCKING in
InstrumentedQueuedThreadPool[qtp156710276]@9573584\{STARTED,10<=10<=1,i=4,r=-1,q=0}[ReservedThreadExecutor@2aa7399c\{reserved=1/6,pending=0}]
2022-08-23 10:47:01.442 DEBUG (qtp156710276-19) [] o.e.j.i.ManagedSelector
Selector sun.nio.ch.EPollSelectorImpl@373889ae woken up from select, 1/1/1
selected
2022-08-23 10:47:01.442 DEBUG (qtp156710276-19) [] o.e.j.i.ManagedSelector
Selector sun.nio.ch.EPollSelectorImpl@373889ae processing 1 keys, 0 updates
2022-08-23 10:47:01.442 DEBUG (qtp156710276-19) [] o.e.j.i.ManagedSelector
selected 1 channel=java.nio.channels.SocketChannel[connected
local=localhost/127.0.0.1:8983 remote=/172.17.0.1:63578],
selector=sun.nio.ch.EPollSelectorImpl@373889ae, interestOps=1, readyOps=1
SocketChannelEndPoint@1177a867\{l=/172.17.0.2:8983,r=/172.17.0.1:63578,OPEN,fill=FI,flush=-,to=6948/12}{io=1/1,kio=1,kro=1}->HttpConnection@3c82c535[p=HttpParser\{s=START,0
of
[jira] [Commented] (SOLR-16414) Race condition in PRS state updates
[ https://issues.apache.org/jira/browse/SOLR-16414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17628111#comment-17628111 ] ASF subversion and git services commented on SOLR-16414: Commit b33161d0cdd976fc0c3dc78c4afafceb4db671cf in solr's branch refs/heads/branch_9x from Noble Paul [ https://gitbox.apache.org/repos/asf?p=solr.git;h=b33161d0cdd ] SOLR-16414: remove parallelStream > Race condition in PRS state updates > --- > > Key: SOLR-16414 > URL: https://issues.apache.org/jira/browse/SOLR-16414 > Project: Solr > Issue Type: Bug > Security Level: Public(Default Security Level. Issues are Public) >Reporter: Noble Paul >Assignee: Noble Paul >Priority: Major > Fix For: 9.1 > > Time Spent: 40m > Remaining Estimate: 0h > > For PRS collections the individual states are potentially updated from > individual nodes and sometimes from overseer too. it's possible that > > # OP1 is sent to overseer at T1 > # OP2 is executed in the node itself at T2 > > Because we cannot guarantee that the OP1 sent to overseer may execute before > OP2 tyhe final state will be the result of OP1 which is incorrect and can > lead to errors . > The solution is to never do any PRS writes from overseer. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
[jira] [Commented] (SOLR-16414) Race condition in PRS state updates
[ https://issues.apache.org/jira/browse/SOLR-16414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17628107#comment-17628107 ] ASF subversion and git services commented on SOLR-16414: Commit 1ad3f97790f0d510f8c9ef434ee019486acdcdad in solr's branch refs/heads/branch_9_1 from Noble Paul [ https://gitbox.apache.org/repos/asf?p=solr.git;h=1ad3f97790f ] SOLR-16414: remove parallelStream > Race condition in PRS state updates > --- > > Key: SOLR-16414 > URL: https://issues.apache.org/jira/browse/SOLR-16414 > Project: Solr > Issue Type: Bug > Security Level: Public(Default Security Level. Issues are Public) >Reporter: Noble Paul >Assignee: Noble Paul >Priority: Major > Fix For: 9.1 > > Time Spent: 40m > Remaining Estimate: 0h > > For PRS collections the individual states are potentially updated from > individual nodes and sometimes from overseer too. it's possible that > > # OP1 is sent to overseer at T1 > # OP2 is executed in the node itself at T2 > > Because we cannot guarantee that the OP1 sent to overseer may execute before > OP2 tyhe final state will be the result of OP1 which is incorrect and can > lead to errors . > The solution is to never do any PRS writes from overseer. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
[jira] [Commented] (SOLR-16414) Race condition in PRS state updates
[ https://issues.apache.org/jira/browse/SOLR-16414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17628105#comment-17628105 ] ASF subversion and git services commented on SOLR-16414: Commit 5125dab476625fadab9c30561621f5b2c67f9bfe in solr's branch refs/heads/main from Noble Paul [ https://gitbox.apache.org/repos/asf?p=solr.git;h=5125dab4766 ] SOLR-16414: remove parallelStream > Race condition in PRS state updates > --- > > Key: SOLR-16414 > URL: https://issues.apache.org/jira/browse/SOLR-16414 > Project: Solr > Issue Type: Bug > Security Level: Public(Default Security Level. Issues are Public) >Reporter: Noble Paul >Assignee: Noble Paul >Priority: Major > Fix For: 9.1 > > Time Spent: 40m > Remaining Estimate: 0h > > For PRS collections the individual states are potentially updated from > individual nodes and sometimes from overseer too. it's possible that > > # OP1 is sent to overseer at T1 > # OP2 is executed in the node itself at T2 > > Because we cannot guarantee that the OP1 sent to overseer may execute before > OP2 tyhe final state will be the result of OP1 which is incorrect and can > lead to errors . > The solution is to never do any PRS writes from overseer. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
[jira] [Reopened] (SOLR-16414) Race condition in PRS state updates
[ https://issues.apache.org/jira/browse/SOLR-16414?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ishan Chattopadhyaya reopened SOLR-16414: - The last commit caused a massive slowdown in node stop event. With 1000 cores/node, the nodes never gracefully stopped, had to be kill -9'd. Repoening for a fix to remove parallelStream usage. > Race condition in PRS state updates > --- > > Key: SOLR-16414 > URL: https://issues.apache.org/jira/browse/SOLR-16414 > Project: Solr > Issue Type: Bug > Security Level: Public(Default Security Level. Issues are Public) >Reporter: Noble Paul >Assignee: Noble Paul >Priority: Major > Fix For: 9.1 > > Time Spent: 40m > Remaining Estimate: 0h > > For PRS collections the individual states are potentially updated from > individual nodes and sometimes from overseer too. it's possible that > > # OP1 is sent to overseer at T1 > # OP2 is executed in the node itself at T2 > > Because we cannot guarantee that the OP1 sent to overseer may execute before > OP2 tyhe final state will be the result of OP1 which is incorrect and can > lead to errors . > The solution is to never do any PRS writes from overseer. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
[GitHub] [solr] noblepaul commented on a diff in pull request #1159: SOLR-16512 : Eliminate noggit JSONWriter.Writable from Solr classes
noblepaul commented on code in PR #1159:
URL: https://github.com/apache/solr/pull/1159#discussion_r1012271453
##
solr/solrj/src/java/org/apache/solr/common/cloud/ClusterState.java:
##
@@ -295,15 +296,12 @@ private static DocCollection collectionFromObjects(
}
@Override
- public void write(JSONWriter jsonWriter) {
-LinkedHashMap map = new LinkedHashMap<>();
-for (Entry e : collectionStates.entrySet()) {
- if (e.getValue().getClass() == CollectionRef.class) {
Review Comment:
yes. it was redundant. The value in the map is always a `CollectionRef`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
[jira] [Commented] (SOLR-16490) Create a v2 equivalent for /admin/cores BACKUPCORE+RESTORECORE
[
https://issues.apache.org/jira/browse/SOLR-16490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17628021#comment-17628021
]
Sanjay Dutt commented on SOLR-16490:
I am working on the v2 BACKUPCORE API. Will submit the PR in next few days.
> Create a v2 equivalent for /admin/cores BACKUPCORE+RESTORECORE
> --
>
> Key: SOLR-16490
> URL: https://issues.apache.org/jira/browse/SOLR-16490
> Project: Solr
> Issue Type: Sub-task
> Components: v2 API
>Affects Versions: 9.1, main (10.0)
>Reporter: Jason Gerlowski
>Priority: Major
> Labels: newdev
>
> The /admin/cores?action=BACKUPCORE and RESTORECORE APIs have no equivalent in
> the v2 paradigm. We should close these gaps, with v2 APIs like the ones below:
> * Create a core-level backup
> ** Current v1 API: GET /solr/admin/cores?action=BACKUPCORE=coreName
> ** Proposed v2 API: POST /api/cores/backups/backupName \{...\}
> ** Spreadsheet Ref: Tab 1, Line 88
> * Restore from a backup to a core
> ** Current v1 API: GET /solr/admin/cores?action=RESTORECORE=coreName
> ** POST /api/cores/coreName/commands/restore
> ** Spreadsheet Ref: Tab 6, Line 39
> "Spreadsheet References" are to the Google Sheet available
> [here|https://docs.google.com/spreadsheets/d/1HAoBBFPpSiT8mJmgNZKkZAPwfCfPvlc08m5jz3fQBpA/edit?usp=sharing],
> which includes additional information about each API, such as the hosting
> RequestHandler.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
[GitHub] [solr-operator] janhoy opened a new issue, #488: Support for updating security.json through Operator / Helm
janhoy opened a new issue, #488: URL: https://github.com/apache/solr-operator/issues/488 A user can now bootstrap `security.json` through operator, even by providing the raw `security.json` file in a Secret that will be uploaded to ZK on first Solr Pod start through an init-container. Users may want to also manage changes to `security.json` in the same manner, i.e. if they use GitOps. This won't work today, as the `bootstrapSecurityJson` feature only works if `security.json` is missing in ZK. So a workaround now is to delete the file manually from Zk and then trigger a restart of a Solr Pod, which will then bootstrap security once again. I'm not suggesting to change default behavior, as the pure 1st-time boostrap feature is useful for those who just want to bootstrap and then continue editing security through Solr's Auth APIs admin AdminUI's nice Securty editor. My proposal is therefor to add a `overwrite: true` property to existing `bootstrapSecurityJson`, which would cause the file to be uploaded on every node restart. We'd still need to figure out a way to trigger the upload anytime the Secret changes. ```yaml bootstrapSecurityJson: name: security-json-secret key: security_json overwrite: true ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
[GitHub] [solr-operator] janhoy commented on issue #85: Support uploading configsets through the operator
janhoy commented on issue #85: URL: https://github.com/apache/solr-operator/issues/85#issuecomment-1301476051 First question is - should it be a configSet bootstrapping feature that will only be run on first startup if a configset with that name does not already exist... OR - should it be a mechanism to manage configset updates through the operator? As a bootstrapping feature we just need an initContainer which looks for a CM and uploads it with a CLI command. But as a management feature it would more look like a `SolrConfigSet` CRD, where you could create, update, delete. For this to make sense, Solr should supported making a configSet Read-Only, so it is "owned" by the operator, since changes from ConfigSet API would be overwritten on next CM change... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
[jira] [Commented] (SOLR-16468) Create v2 equivalent of v1 'CREATESNAPSHOT', 'LISTSNAPSHOT' and 'DELETESNAPSHOT' (collection level)
[ https://issues.apache.org/jira/browse/SOLR-16468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17628004#comment-17628004 ] Jason Gerlowski commented on SOLR-16468: I'm going to grab LISTSNAPSHOT and push up a PR shortly. The other two are still available if anyone wants to pick them up though! > Create v2 equivalent of v1 'CREATESNAPSHOT', 'LISTSNAPSHOT' and > 'DELETESNAPSHOT' (collection level) > --- > > Key: SOLR-16468 > URL: https://issues.apache.org/jira/browse/SOLR-16468 > Project: Solr > Issue Type: Sub-task > Components: v2 API >Affects Versions: 9.2 >Reporter: Sanjay Dutt >Assignee: Jason Gerlowski >Priority: Major > Labels: V2, newdev > > Snapshot API has no v2 equivalent at collection level. This ticket is to > track changes made to the Solr to add v2 equivalent of 'CREATESNAPSHOT', > 'LISTSNAPSHOT' and 'DELETESNAPSHOT' api. > Proposed API design > * collection CREATESNAPSHOT - POST > /api/collections/collName/snapshots/snapshotName > * collection LISTSNAPSHOT - GET /api/collections/collName/snapshots > * collection DELETESNAPSHOT - DELETE > /api/collections/collName/snapshots/snapshotName > A few other pointers that might be helpful, especially for newcomers: > * The v1 logic for this API lives in CollectionsHandler (for the > collection-level APIs) and CoreAdminHandler (for the core-level APIs). > * Some discussion of how APIs work in Solr (Particularly the "APIs in Solr" > section.) > * A step-by-step guide to creating APIs using the preferred v2 API framework > * [A recent PR that adds a v2 API, as an > example|https://github.com/apache/solr/pull/1061/files] -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
[jira] [Assigned] (SOLR-16468) Create v2 equivalent of v1 'CREATESNAPSHOT', 'LISTSNAPSHOT' and 'DELETESNAPSHOT' (collection level)
[ https://issues.apache.org/jira/browse/SOLR-16468?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gerlowski reassigned SOLR-16468: -- Assignee: Jason Gerlowski > Create v2 equivalent of v1 'CREATESNAPSHOT', 'LISTSNAPSHOT' and > 'DELETESNAPSHOT' (collection level) > --- > > Key: SOLR-16468 > URL: https://issues.apache.org/jira/browse/SOLR-16468 > Project: Solr > Issue Type: Sub-task > Components: v2 API >Affects Versions: 9.2 >Reporter: Sanjay Dutt >Assignee: Jason Gerlowski >Priority: Major > Labels: V2, newdev > > Snapshot API has no v2 equivalent at collection level. This ticket is to > track changes made to the Solr to add v2 equivalent of 'CREATESNAPSHOT', > 'LISTSNAPSHOT' and 'DELETESNAPSHOT' api. > Proposed API design > * collection CREATESNAPSHOT - POST > /api/collections/collName/snapshots/snapshotName > * collection LISTSNAPSHOT - GET /api/collections/collName/snapshots > * collection DELETESNAPSHOT - DELETE > /api/collections/collName/snapshots/snapshotName > A few other pointers that might be helpful, especially for newcomers: > * The v1 logic for this API lives in CollectionsHandler (for the > collection-level APIs) and CoreAdminHandler (for the core-level APIs). > * Some discussion of how APIs work in Solr (Particularly the "APIs in Solr" > section.) > * A step-by-step guide to creating APIs using the preferred v2 API framework > * [A recent PR that adds a v2 API, as an > example|https://github.com/apache/solr/pull/1061/files] -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
[GitHub] [solr] dsmiley commented on a diff in pull request #862: SOLR-16195: Correct task-mgmt API paths in ref-guide
dsmiley commented on code in PR #862:
URL: https://github.com/apache/solr/pull/862#discussion_r1012271513
##
build.gradle:
##
@@ -207,3 +207,5 @@ apply from: file('gradle/ant-compat/solr.post-jar.gradle')
apply from: file('gradle/node.gradle')
+sourceCompatibility = JavaVersion.VERSION_17
+targetCompatibility = JavaVersion.VERSION_17
Review Comment:
Woah... an innocent mistake I presume.
This should be reverted @gerlowskija
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
[GitHub] [solr] noblepaul commented on a diff in pull request #1159: SOLR-16512 : Eliminate noggit JSONWriter.Writable from Solr classes
noblepaul commented on code in PR #1159:
URL: https://github.com/apache/solr/pull/1159#discussion_r1012271453
##
solr/solrj/src/java/org/apache/solr/common/cloud/ClusterState.java:
##
@@ -295,15 +296,12 @@ private static DocCollection collectionFromObjects(
}
@Override
- public void write(JSONWriter jsonWriter) {
-LinkedHashMap map = new LinkedHashMap<>();
-for (Entry e : collectionStates.entrySet()) {
- if (e.getValue().getClass() == CollectionRef.class) {
Review Comment:
yes. it was redundant. I could remove it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
[GitHub] [solr-operator] jkgonzio opened a new issue, #487: CVE Security Vulnerabilities
jkgonzio opened a new issue, #487: URL: https://github.com/apache/solr-operator/issues/487 I ran a flexline scan and ran into some security vulnerabilities that should be remediated: Vulnerability ID: CVE-2021-33194 Finding Level: High Package: golang.org/x/net/html Version: v0.0.0-20210520170846-37e1c6afe023 Fixed Version: 0.0.0-20210520170846-37e1c6afe023 Desc: golang.org/x/net before v0.0.0-20210520170846-37e1c6afe023 allows attackers to cause a denial of service (infinite loop) via crafted ParseFragment input. Link: https://avd.aquasec.com/nvd/2021/cve-2021-33194/ Vulnerability ID: CVE-2022-27664 Finding Level: High Package: golang.org/net/http Version: v0.0.0-20210428140749-89ef3d95e781 Fixed version: 0.0.0-20220906165146-f3363e06e74c Desc: In net/http in Go before 1.18.6 and 1.19.x before 1.19.1, attackers can cause a denial of service because an HTTP/2 connection can hang during closing if shutdown were preempted by a fatal error. Link: https://avd.aquasec.com/nvd/2022/cve-2022-27664/ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
[jira] [Resolved] (SOLR-16517) Solr export 8.11.2-slim Vulnerabilities
[ https://issues.apache.org/jira/browse/SOLR-16517?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Houston Putman resolved SOLR-16517. --- Resolution: Invalid Please read our security page: https://solr.apache.org/security.html This is an issue tracker, and we do not accept vulnerability scans as issues. DockerHub will provide timely updates of the base image, and Solr maintains a list of exploitative CVEs for its dependencies. > Solr export 8.11.2-slim Vulnerabilities > > > Key: SOLR-16517 > URL: https://issues.apache.org/jira/browse/SOLR-16517 > Project: Solr > Issue Type: Bug > Security Level: Public(Default Security Level. Issues are Public) > Components: security >Affects Versions: 8.11.2 >Reporter: Ritchie Gu >Priority: Critical > Attachments: twistlock_images-Solr-Exporter.csv > > > I have a question regarding the solr exporter > [https://hub.docker.com/layers/library/solr/8.11.2-slim/images/sha256-e2e7e8fddb75ec8055c2745bbaf784cd7608ea5898f17144312f316ef0a1f488?context=explore] > Our twistlock scan result showing that it has 95 vulnerabilities. We are > going through an auditing process and would like to get some answers from > Apache Solr team since it's officially supported. > Also is there any plan that Solr team will address these vulnerabilities? > I will attach the scan result here in the ticket. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
[jira] [Updated] (SOLR-16517) Solr export 8.11.2-slim Vulnerabilities
[ https://issues.apache.org/jira/browse/SOLR-16517?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ritchie Gu updated SOLR-16517: -- Description: I have a question regarding the solr exporter [https://hub.docker.com/layers/library/solr/8.11.2-slim/images/sha256-e2e7e8fddb75ec8055c2745bbaf784cd7608ea5898f17144312f316ef0a1f488?context=explore] Our twistlock scan result showing that it has 95 vulnerabilities. We are going through an auditing process and would like to get some answers from Apache Solr team since it's officially supported. Also is there any plan that Solr team will address these vulnerabilities? I will attach the scan result here in the ticket. was: I have a question regarding the solr exporter [https://hub.docker.com/layers/library/solr/8.11.2-slim/images/sha256-e2e7e8fddb75ec8055c2745bbaf784cd7608ea5898f17144312f316ef0a1f488?context=explore] Our twistlock scan result showing that it has 95 vulnerabilities. We are going through an auditing process and would like to get some answers from Apache Solr team since it's officinally supported. Also is there any plan that Solr team will address these vulnerabilities? I will attach the scan result here in the ticket. > Solr export 8.11.2-slim Vulnerabilities > > > Key: SOLR-16517 > URL: https://issues.apache.org/jira/browse/SOLR-16517 > Project: Solr > Issue Type: Bug > Security Level: Public(Default Security Level. Issues are Public) > Components: security >Affects Versions: 8.11.2 >Reporter: Ritchie Gu >Priority: Critical > Attachments: twistlock_images-Solr-Exporter.csv > > > I have a question regarding the solr exporter > [https://hub.docker.com/layers/library/solr/8.11.2-slim/images/sha256-e2e7e8fddb75ec8055c2745bbaf784cd7608ea5898f17144312f316ef0a1f488?context=explore] > Our twistlock scan result showing that it has 95 vulnerabilities. We are > going through an auditing process and would like to get some answers from > Apache Solr team since it's officially supported. > Also is there any plan that Solr team will address these vulnerabilities? > I will attach the scan result here in the ticket. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
[jira] [Created] (SOLR-16517) Solr export 8.11.2-slim Vulnerabilities
Ritchie Gu created SOLR-16517: - Summary: Solr export 8.11.2-slim Vulnerabilities Key: SOLR-16517 URL: https://issues.apache.org/jira/browse/SOLR-16517 Project: Solr Issue Type: Bug Security Level: Public (Default Security Level. Issues are Public) Components: security Affects Versions: 8.11.2 Reporter: Ritchie Gu Attachments: twistlock_images-Solr-Exporter.csv I have a question regarding the solr exporter [https://hub.docker.com/layers/library/solr/8.11.2-slim/images/sha256-e2e7e8fddb75ec8055c2745bbaf784cd7608ea5898f17144312f316ef0a1f488?context=explore] Our twistlock scan result showing that it has 95 vulnerabilities. We are going through an auditing process and would like to get some answers from Apache Solr team since it's officinally supported. Also is there any plan that Solr team will address these vulnerabilities? I will attach the scan result here in the ticket. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
[GitHub] [solr] dsmiley commented on pull request #1156: [SOLR-16515] Remove synchronized access to cachedOrdMaps in SlowCompositeReaderWrapper
dsmiley commented on PR #1156: URL: https://github.com/apache/solr/pull/1156#issuecomment-1300871894 I don't mean change Lucene code, I mean change SlowCompositeReaderWrapper internals only. Yeah Multi-stuff is kind of discouraged... more of a -- hey, use this if your algorithm can't easily loop over segments, which is probably what you should do if you cant. These Multi-classes are not going away. It's also okay to accept some duplication if you are only duplicating the Lucene code since at least then it's easier to verify we are keeping in sync with possible changes in Lucene. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
[GitHub] [solr] uschindler commented on pull request #1118: [SOLR-16489] CaffeineCache puts thread into infinite loop
uschindler commented on PR #1118: URL: https://github.com/apache/solr/pull/1118#issuecomment-1300831545 DisjunctionMaxQuery unfortunately has a getDisjuncts that returns a mutable Multiset (a Lucene collection subclass): https://github.com/apache/lucene/blob/main/lucene/core/src/java/org/apache/lucene/search/DisjunctionMaxQuery.java -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
[GitHub] [solr] uschindler commented on pull request #1118: [SOLR-16489] CaffeineCache puts thread into infinite loop
uschindler commented on PR #1118: URL: https://github.com/apache/solr/pull/1118#issuecomment-1300811132 This is a non-Lucene or non-Solr query from the external Querqy plugin. https://github.com/querqy/querqy/blob/1dbafde2eddc0938b309bbe955f127148671fd41/querqy-for-lucene/querqy-lucene/src/main/java/querqy/lucene/rewrite/FieldBoostTermQueryBuilder.java It looks fine, too. It also implements equals and hashCode. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
[GitHub] [solr] ben-manes commented on pull request #1118: [SOLR-16489] CaffeineCache puts thread into infinite loop
ben-manes commented on PR #1118: URL: https://github.com/apache/solr/pull/1118#issuecomment-1300803918 oh yes, I did not notice that `Collection getClauses(Occur occur)` is package-private. This is returning a mutable collection, but since it is not public then that is safe (maybe package-private for testing). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
[GitHub] [solr] uschindler commented on pull request #1118: [SOLR-16489] CaffeineCache puts thread into infinite loop
uschindler commented on PR #1118: URL: https://github.com/apache/solr/pull/1118#issuecomment-1300772734 Yes this helps. Interestingly: The "clauses" of a BooleanQuery are non-mutable, it is already wrapped with Collections.unmodifiableList(). So nobody can change the clauses after calling BooleanQuery.getCauses(). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
[GitHub] [solr-site] HoustonPutman merged pull request #81: Warn about scans in security section. (#80)
HoustonPutman merged PR #81: URL: https://github.com/apache/solr-site/pull/81 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
[GitHub] [solr-site] HoustonPutman opened a new pull request, #81: Warn about scans in security section. (#80)
HoustonPutman opened a new pull request, #81: URL: https://github.com/apache/solr-site/pull/81 Co-authored-by: David Smiley -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
[jira] [Commented] (SOLR-16496) provide option for Query Elevation Component to bypass filters
[
https://issues.apache.org/jira/browse/SOLR-16496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17627788#comment-17627788
]
Rudi Seitz commented on SOLR-16496:
---
Thanks, [~dsmiley], I've updated the PR based on your feedback. Added support
for tagging individual filters using LocalParams syntax and then specifying the
tags to exclude via {{elevate.excludeTags}}
Does the updated PR match what you had in mind?
A specific question came up: To create the set of filters to exclude based on
their tags, I [adapted some
code|https://github.com/apache/solr/pull/1154/commits/2a97643ce758029e5d68978eb0633fced927b515#diff-26b681890de6a262a6c94485956aa1ada9d2bff306dabe79962ec459843f76faR599]
from
[FacetProcessor#handleFilterExclusions()|https://github.com/apache/solr/blob/26195c82493422cb9d6d4bdf9d4452046e7b3f67/solr/core/src/java/org/apache/solr/search/facet/FacetProcessor.java#L192]
I thought about abstracting it into a common utility method but wanted to
avoid touching FacetProcessor for now. What would you recommend re: next steps?
> provide option for Query Elevation Component to bypass filters
> --
>
> Key: SOLR-16496
> URL: https://issues.apache.org/jira/browse/SOLR-16496
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
> Components: SearchComponents - other
>Reporter: Rudi Seitz
>Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
> The Query Elevation Component respects the fq parameter.
> A document listed in elevate.xml or specified via the {{elevateIds}}
> parameter must match the provided filter queries in order to be included in
> the result set for a given query. Documents that don't match the filter
> queries will be excluded regardless of whether they are supposed to be
> "elevated."
> In some cases, this behavior is desirable; in other cases, it is not. For
> example, an ecommerce landing page might filter products according to whether
> they are in stock ({{{}fq=inStock:true{}}}) but might wish to show certain
> promoted products regardless of inventory.
> This ticket asks for an {{elevateFilteredDocs}} parameter that could be set
> to true to include elevated documents in the result set regardless of whether
> they match the provided filter queries. The default would be false, in
> accordance with the current behavior.
> This parameter would allow elevated documents to "bypass" the provided
> filters, while keeping the filters in place for non-elevated documents.
> From an implementation standpoint, this parameter could be supported with
> code in {{QueryElevationComponent#setQuery}} that updates the filter queries
> in similar way to how the main query is updated. When
> {{{}elevateFilteredDocs=true{}}}, each filter query would become a boolean
> "OR" of the original filter query with a second query matching the elevated
> documents by id.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
[GitHub] [solr] epugh commented on a diff in pull request #1158: SOLR-16368: experiment with builder to simplify client creation
epugh commented on code in PR #1158:
URL: https://github.com/apache/solr/pull/1158#discussion_r1011906493
##
solr/solrj/src/test/org/apache/solr/client/solrj/SolrExampleTests.java:
##
@@ -602,58 +602,60 @@ public void testUnicode() throws Exception {
SolrClient client = getSolrClient();
// save the old parser, so we can set it back.
-ResponseParser oldParser = null;
-if (client instanceof HttpSolrClient) {
- HttpSolrClient httpSolrClient = (HttpSolrClient) client;
- oldParser = httpSolrClient.getParser();
-}
-
-try {
- for (int iteration = 0; iteration < numIterations; iteration++) {
-// choose format
-if (client instanceof HttpSolrClient) {
- if (random.nextBoolean()) {
-((HttpSolrClient) client).setParser(new BinaryResponseParser());
- } else {
-((HttpSolrClient) client).setParser(new XMLResponseParser());
- }
-}
-
-int numDocs = TestUtil.nextInt(random(), 1, 10 * RANDOM_MULTIPLIER);
-
-// Empty the database...
-client.deleteByQuery("*:*"); // delete everything!
-
-List docs = new ArrayList<>();
-for (int i = 0; i < numDocs; i++) {
- // Now add something...
- SolrInputDocument doc = new SolrInputDocument();
- doc.addField("id", "" + i);
- doc.addField("unicode_s", randomTestString(30));
- docs.add(doc);
-}
+// ResponseParser oldParser = null;
+// if (client instanceof HttpSolrClient) {
+// HttpSolrClient httpSolrClient = (HttpSolrClient) client;
+// oldParser = httpSolrClient.getParser();
+// }
Review Comment:
Actually hoping someone else can confirm that the changes I made still keep
the test working "as designed", and that this commented out code can just be
deleted
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
[GitHub] [solr] epugh commented on a diff in pull request #1158: SOLR-16368: experiment with builder to simplify client creation
epugh commented on code in PR #1158:
URL: https://github.com/apache/solr/pull/1158#discussion_r1011904785
##
solr/solrj/src/test/org/apache/solr/client/solrj/impl/BasicHttpSolrClientTest.java:
##
@@ -478,6 +484,8 @@ public void testUpdate() throws Exception {
assertEquals("\u1234", DebugServlet.parameters.get("a")[0]);
// XML response and writer
+ // Have not been able to move this to the Builder pattern, the below
check for application/xml
+ // always returns as application/javabin when I try this!
Review Comment:
yeah, I'd love a fresh set of eyes, I don't get why it doesn't work..
maybe somethign about the `DebugServlet` or some sort of something being
reused...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
[GitHub] [solr] epugh commented on a diff in pull request #1158: SOLR-16368: experiment with builder to simplify client creation
epugh commented on code in PR #1158:
URL: https://github.com/apache/solr/pull/1158#discussion_r1011902917
##
solr/solrj/src/test/org/apache/solr/client/solrj/impl/BasicHttpSolrClientTest.java:
##
@@ -341,7 +346,6 @@ public void testQuery() throws Exception {
assertEquals("keep-alive", DebugServlet.headers.get("Connection"));
// XML/POST
- client.setParser(new XMLResponseParser());
Review Comment:
i don't think so, as we generate a new client on line 236 with a fresh
`XMLResponseParser`, and the test pasts. However, the method `testUpdate` is
giving me problems
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
[GitHub] [solr] epugh commented on a diff in pull request #1158: SOLR-16368: experiment with builder to simplify client creation
epugh commented on code in PR #1158:
URL: https://github.com/apache/solr/pull/1158#discussion_r1011897088
##
solr/solrj/src/test/org/apache/solr/client/solrj/TestBatchUpdate.java:
##
@@ -46,24 +46,28 @@ public static void beforeTest() throws Exception {
@Test
public void testWithXml() throws Exception {
-HttpSolrClient client = (HttpSolrClient) getSolrClient();
-client.setRequestWriter(new RequestWriter());
+client =
Review Comment:
there is a
```
@After
public synchronized void afterClass() throws Exception {
if (client != null) client.close();
client = null;
}
```
There doesn't appear to be any one pattern...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
[GitHub] [solr] rseitz commented on pull request #1154: SOLR-16496: provide option for Query Elevation Component to bypass filters
rseitz commented on PR #1154: URL: https://github.com/apache/solr/pull/1154#issuecomment-1300609618 Thanks for reviewing, @risdenk and thanks to @dsmiley for feedback on the JIRA ticket. I have reworked this PR in accordance with that feedback. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
[GitHub] [solr] epugh commented on a diff in pull request #1158: SOLR-16368: experiment with builder to simplify client creation
epugh commented on code in PR #1158:
URL: https://github.com/apache/solr/pull/1158#discussion_r1011894050
##
solr/solrj/src/java/org/apache/solr/client/solrj/impl/HttpSolrClient.java:
##
@@ -813,6 +813,7 @@ public String getBaseURL() {
* In this case the client is more flexible and can be used to send requests
to any cores. The
* cost of this is that the core must be specified on each request.
*/
+ @Deprecated
Review Comment:
Just scavenged some text from a patch file that @gerlowskija had written!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
[GitHub] [solr] epugh commented on a diff in pull request #1158: SOLR-16368: experiment with builder to simplify client creation
epugh commented on code in PR #1158:
URL: https://github.com/apache/solr/pull/1158#discussion_r1011891480
##
solr/core/src/test/org/apache/solr/search/TestSmileRequest.java:
##
@@ -71,7 +71,7 @@ public void testDistribJsonRequest() throws Exception {
@Override
public void assertJQ(SolrClient client, SolrParams args, String...
tests)
throws Exception {
-((HttpSolrClient) client).setParser(SmileResponseParser.inst);
+((HttpSolrClient) client).setParser(new SmileResponseParser());
Review Comment:
I can't figure out how to move away from the `.setParser`, I want to somehow
override how `SolrTestCaseHS` sets up it's `SolrClient` and kind of got burned
out trying to slueth thorugh all the layers of indirection...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
[GitHub] [solr] DennisBerger1984 commented on pull request #1118: [SOLR-16489] CaffeineCache puts thread into infinite loop
DennisBerger1984 commented on PR #1118: URL: https://github.com/apache/solr/pull/1118#issuecomment-1300604173 @uschindler does this help?    -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
[GitHub] [solr] epugh commented on a diff in pull request #1158: SOLR-16368: experiment with builder to simplify client creation
epugh commented on code in PR #1158:
URL: https://github.com/apache/solr/pull/1158#discussion_r1011888554
##
solr/solrj/src/test/org/apache/solr/client/solrj/embedded/SolrExampleJettyTest.java:
##
@@ -118,72 +111,22 @@ public void testUtf8PerfDegradation() throws Exception {
doc.addField("id", "1");
doc.addField("b_is", IntStream.range(0,
3).boxed().collect(Collectors.toList()));
-HttpSolrClient client = (HttpSolrClient) getSolrClient();
-client.add(doc);
-client.commit();
-long start = System.nanoTime();
-QueryResponse rsp = client.query(new SolrQuery("*:*"));
-System.out.println("time taken : " + ((System.nanoTime() - start)) / (1000
* 1000));
-assertEquals(1, rsp.getResults().getNumFound());
- }
-
- @Ignore
Review Comment:
The test was added with the `@Ignore` tag four years ago, so I suspect it
wasn't really a test but was to figure some code out
https://github.com/apache/solr/blame/26195c82493422cb9d6d4bdf9d4452046e7b3f67/solr/solrj/src/test/org/apache/solr/client/solrj/embedded/SolrExampleJettyTest.java#L130.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
[GitHub] [solr] epugh commented on a diff in pull request #1158: SOLR-16368: experiment with builder to simplify client creation
epugh commented on code in PR #1158:
URL: https://github.com/apache/solr/pull/1158#discussion_r1011881388
##
solr/solrj/src/java/org/apache/solr/client/solrj/impl/ConcurrentUpdateSolrClient.java:
##
@@ -107,8 +107,8 @@ protected ConcurrentUpdateSolrClient(Builder builder) {
.withHttpClient(builder.httpClient)
.withConnectionTimeout(builder.connectionTimeoutMillis)
.withSocketTimeout(builder.socketTimeoutMillis)
+.setFollowRedirects(false)
Review Comment:
thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
[GitHub] [solr] risdenk commented on pull request #1118: [SOLR-16489] CaffeineCache puts thread into infinite loop
risdenk commented on PR #1118: URL: https://github.com/apache/solr/pull/1118#issuecomment-1300573313 https://github.com/apache/solr/search?q=setWrappedQuery is definitely not used in Solr main. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
[GitHub] [solr] risdenk commented on a diff in pull request #1159: SOLR-16512 : Eliminate noggit JSONWriter.Writable from Solr classes
risdenk commented on code in PR #1159:
URL: https://github.com/apache/solr/pull/1159#discussion_r1011865290
##
solr/solrj/src/java/org/apache/solr/common/cloud/ClusterState.java:
##
@@ -295,15 +296,12 @@ private static DocCollection collectionFromObjects(
}
@Override
- public void write(JSONWriter jsonWriter) {
-LinkedHashMap map = new LinkedHashMap<>();
-for (Entry e : collectionStates.entrySet()) {
- if (e.getValue().getClass() == CollectionRef.class) {
Review Comment:
This if statement check was redundant before right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
[GitHub] [solr] risdenk commented on a diff in pull request #1158: SOLR-16368: experiment with builder to simplify client creation
risdenk commented on code in PR #1158:
URL: https://github.com/apache/solr/pull/1158#discussion_r1011860272
##
solr/solrj/src/java/org/apache/solr/client/solrj/impl/HttpSolrClient.java:
##
@@ -813,6 +813,7 @@ public String getBaseURL() {
* In this case the client is more flexible and can be used to send requests
to any cores. The
* cost of this is that the core must be specified on each request.
*/
+ @Deprecated
Review Comment:
Eventually probably want to have a `use this instead` part of the javadoc
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
[GitHub] [solr] risdenk commented on a diff in pull request #1158: SOLR-16368: experiment with builder to simplify client creation
risdenk commented on code in PR #1158:
URL: https://github.com/apache/solr/pull/1158#discussion_r1011858823
##
solr/core/src/test/org/apache/solr/search/TestSmileRequest.java:
##
@@ -71,7 +71,7 @@ public void testDistribJsonRequest() throws Exception {
@Override
public void assertJQ(SolrClient client, SolrParams args, String...
tests)
throws Exception {
-((HttpSolrClient) client).setParser(SmileResponseParser.inst);
+((HttpSolrClient) client).setParser(new SmileResponseParser());
Review Comment:
What issues are you running into with this test?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
[GitHub] [solr] risdenk commented on a diff in pull request #1158: SOLR-16368: experiment with builder to simplify client creation
risdenk commented on code in PR #1158:
URL: https://github.com/apache/solr/pull/1158#discussion_r1011844656
##
solr/solrj/src/java/org/apache/solr/client/solrj/impl/SolrClientBuilder.java:
##
@@ -46,6 +50,21 @@ public B withResponseParser(ResponseParser responseParser) {
return getThis();
}
+ public B withRequestWriter(RequestWriter requestWriter) {
+this.requestWriter = requestWriter;
+return getThis();
+ }
+
+ public B withUseMultiPartPost(Boolean useMultiPartPost) {
+this.useMultiPartPost = useMultiPartPost;
+return getThis();
+ }
+
+ public B setFollowRedirects(boolean withFollowRedirects) {
Review Comment:
`withFollowRedirects`?
##
solr/solrj/src/test/org/apache/solr/client/solrj/TestBatchUpdate.java:
##
@@ -46,24 +46,28 @@ public static void beforeTest() throws Exception {
@Test
public void testWithXml() throws Exception {
-HttpSolrClient client = (HttpSolrClient) getSolrClient();
-client.setRequestWriter(new RequestWriter());
+client =
Review Comment:
`client` must be closed in `SolrJettyTestBase`? would be clearer to do
`try-with-resources` for each of these?
##
solr/solrj/src/test/org/apache/solr/client/solrj/SolrExampleTests.java:
##
@@ -602,58 +602,60 @@ public void testUnicode() throws Exception {
SolrClient client = getSolrClient();
// save the old parser, so we can set it back.
-ResponseParser oldParser = null;
-if (client instanceof HttpSolrClient) {
- HttpSolrClient httpSolrClient = (HttpSolrClient) client;
- oldParser = httpSolrClient.getParser();
-}
-
-try {
- for (int iteration = 0; iteration < numIterations; iteration++) {
-// choose format
-if (client instanceof HttpSolrClient) {
- if (random.nextBoolean()) {
-((HttpSolrClient) client).setParser(new BinaryResponseParser());
- } else {
-((HttpSolrClient) client).setParser(new XMLResponseParser());
- }
-}
-
-int numDocs = TestUtil.nextInt(random(), 1, 10 * RANDOM_MULTIPLIER);
-
-// Empty the database...
-client.deleteByQuery("*:*"); // delete everything!
-
-List docs = new ArrayList<>();
-for (int i = 0; i < numDocs; i++) {
- // Now add something...
- SolrInputDocument doc = new SolrInputDocument();
- doc.addField("id", "" + i);
- doc.addField("unicode_s", randomTestString(30));
- docs.add(doc);
-}
+// ResponseParser oldParser = null;
+// if (client instanceof HttpSolrClient) {
+// HttpSolrClient httpSolrClient = (HttpSolrClient) client;
+// oldParser = httpSolrClient.getParser();
+// }
Review Comment:
Guess still figuring out how this tests works/needs to be converted?
##
solr/solrj/src/test/org/apache/solr/client/solrj/impl/BasicHttpSolrClientTest.java:
##
@@ -478,6 +484,8 @@ public void testUpdate() throws Exception {
assertEquals("\u1234", DebugServlet.parameters.get("a")[0]);
// XML response and writer
+ // Have not been able to move this to the Builder pattern, the below
check for application/xml
+ // always returns as application/javabin when I try this!
Review Comment:
Would be good to dig to why this happens
##
solr/solrj/src/test/org/apache/solr/client/solrj/impl/BasicHttpSolrClientTest.java:
##
@@ -341,7 +346,6 @@ public void testQuery() throws Exception {
assertEquals("keep-alive", DebugServlet.headers.get("Connection"));
// XML/POST
- client.setParser(new XMLResponseParser());
Review Comment:
Is there a side effect here about having a new `XMLResponseParser` to be
concerned with?
##
solr/solrj/src/java/org/apache/solr/client/solrj/impl/ConcurrentUpdateSolrClient.java:
##
@@ -107,8 +107,8 @@ protected ConcurrentUpdateSolrClient(Builder builder) {
.withHttpClient(builder.httpClient)
.withConnectionTimeout(builder.connectionTimeoutMillis)
.withSocketTimeout(builder.socketTimeoutMillis)
+.setFollowRedirects(false)
Review Comment:
`withFollowRedirects`?
##
solr/solrj/src/test/org/apache/solr/client/solrj/embedded/SolrExampleJettyTest.java:
##
@@ -118,72 +111,22 @@ public void testUtf8PerfDegradation() throws Exception {
doc.addField("id", "1");
doc.addField("b_is", IntStream.range(0,
3).boxed().collect(Collectors.toList()));
-HttpSolrClient client = (HttpSolrClient) getSolrClient();
-client.add(doc);
-client.commit();
-long start = System.nanoTime();
-QueryResponse rsp = client.query(new SolrQuery("*:*"));
-System.out.println("time taken : " + ((System.nanoTime() - start)) / (1000
* 1000));
-assertEquals(1, rsp.getResults().getNumFound());
- }
-
- @Ignore
Review Comment:
when was this marked `@Ignore` would be good to find out why?
--
This
[GitHub] [solr] mpetris commented on pull request #1156: [SOLR-16515] Remove synchronized access to cachedOrdMaps in SlowCompositeReaderWrapper
mpetris commented on PR #1156: URL: https://github.com/apache/solr/pull/1156#issuecomment-1300514827 > Hey, this looks excellent! The code looks a bit deja-vu... do you think we could & should factorize out anything common? @dsmiley We could factorize out most of `SlowCompositeReaderWrapper::getSortedDocValues` and `SlowCompositeReaderWrapper::getSortedSetDocValues` to `MultiDocValues` just like it was. But to me it looks like as the two `MultiDocValues` methods were used in `SlowCompositeReaderWrapper` only. So I'm not sure that it would be worth the effort. Moreover since the usage of `MultiDocValues` seems to be discouraged anyway. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
[jira] [Commented] (SOLR-16367) Switch from CloudLegacySolrClient to CloudSolrClient
[ https://issues.apache.org/jira/browse/SOLR-16367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17627725#comment-17627725 ] Bence Szabó commented on SOLR-16367: I see, having that in mind the code makes more sense now. Thank you > Switch from CloudLegacySolrClient to CloudSolrClient > > > Key: SOLR-16367 > URL: https://issues.apache.org/jira/browse/SOLR-16367 > Project: Solr > Issue Type: Improvement > Security Level: Public(Default Security Level. Issues are Public) >Reporter: David Smiley >Priority: Major > > CloudLegacySolrClient is deprecated; it uses the Apache HTTP client. > CloudSolrClient uses the Jetty HTTP client, which supports HTTP 2. In this > issue, switch all of Solr to not use CloudLegacySolrClient anymore. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
[jira] [Commented] (SOLR-16367) Switch from CloudLegacySolrClient to CloudSolrClient
[ https://issues.apache.org/jira/browse/SOLR-16367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17627696#comment-17627696 ] David Smiley commented on SOLR-16367: - Construction of the ClusterStateProvider is internal based on wether the Builder was initialized referring to ZK hosts or Solr hosts. It is not directly settable on purpose. > Switch from CloudLegacySolrClient to CloudSolrClient > > > Key: SOLR-16367 > URL: https://issues.apache.org/jira/browse/SOLR-16367 > Project: Solr > Issue Type: Improvement > Security Level: Public(Default Security Level. Issues are Public) >Reporter: David Smiley >Priority: Major > > CloudLegacySolrClient is deprecated; it uses the Apache HTTP client. > CloudSolrClient uses the Jetty HTTP client, which supports HTTP 2. In this > issue, switch all of Solr to not use CloudLegacySolrClient anymore. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
[jira] [Commented] (SOLR-16367) Switch from CloudLegacySolrClient to CloudSolrClient
[
https://issues.apache.org/jira/browse/SOLR-16367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17627674#comment-17627674
]
Bence Szabó commented on SOLR-16367:
Maybe I am missing something but it seems to me there is no way to set the
{{ClusterStateProvider}} in the builder class of {{{}CloudHttp2SolrClient{}}}.
Shall I create a Jira for this and add something of a
{{withClusterStateProvider}} to the builder class or is this intentional?
> Switch from CloudLegacySolrClient to CloudSolrClient
>
>
> Key: SOLR-16367
> URL: https://issues.apache.org/jira/browse/SOLR-16367
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
>Reporter: David Smiley
>Priority: Major
>
> CloudLegacySolrClient is deprecated; it uses the Apache HTTP client.
> CloudSolrClient uses the Jetty HTTP client, which supports HTTP 2. In this
> issue, switch all of Solr to not use CloudLegacySolrClient anymore.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
[jira] [Comment Edited] (SOLR-16512) Eliminate noggit JSONWriter.Writable from Solr classes
[ https://issues.apache.org/jira/browse/SOLR-16512?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17627665#comment-17627665 ] Noble Paul edited comment on SOLR-16512 at 11/2/22 12:12 PM: - MapWriter is an interface we use to serialize all objects in Solr. Solr classes should be agnostic a specific codec(noggit, in this case) . Al our codecs json/javabin/xml know how to serialize this interface was (Author: noble.paul): MapWriter is an interface we use to serialize all objects in Solr. Solr classes should be agnostic a specific codec(noggit, in this case) > Eliminate noggit JSONWriter.Writable from Solr classes > -- > > Key: SOLR-16512 > URL: https://issues.apache.org/jira/browse/SOLR-16512 > Project: Solr > Issue Type: Bug > Security Level: Public(Default Security Level. Issues are Public) >Reporter: Noble Paul >Assignee: Noble Paul >Priority: Major > Time Spent: 20m > Remaining Estimate: 0h > > Use MapWriter instead -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
[jira] [Commented] (SOLR-16512) Eliminate noggit JSONWriter.Writable from Solr classes
[ https://issues.apache.org/jira/browse/SOLR-16512?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17627665#comment-17627665 ] Noble Paul commented on SOLR-16512: --- MapWriter is an interface we use to serialize all objects in Solr. Solr classes should be agnostic a specific codec(noggit, in this case) > Eliminate noggit JSONWriter.Writable from Solr classes > -- > > Key: SOLR-16512 > URL: https://issues.apache.org/jira/browse/SOLR-16512 > Project: Solr > Issue Type: Bug > Security Level: Public(Default Security Level. Issues are Public) >Reporter: Noble Paul >Assignee: Noble Paul >Priority: Major > Time Spent: 20m > Remaining Estimate: 0h > > Use MapWriter instead -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
[GitHub] [solr] epugh commented on a diff in pull request #1158: SOLR-16368: experiment with builder to simplify client creation
epugh commented on code in PR #1158:
URL: https://github.com/apache/solr/pull/1158#discussion_r1011650146
##
solr/solrj/src/test/org/apache/solr/client/solrj/embedded/SolrExampleStreamingBinaryTest.java:
##
@@ -35,9 +34,15 @@ public class SolrExampleStreamingBinaryTest extends
SolrExampleStreamingTest {
@Override
public SolrClient createNewSolrClient() {
-ConcurrentUpdateSolrClient client = (ConcurrentUpdateSolrClient)
super.createNewSolrClient();
-client.setParser(new BinaryResponseParser());
-client.setRequestWriter(new BinaryRequestWriter());
+
+SolrClient client =
+new ErrorTrackingConcurrentUpdateSolrClient.Builder(getServerUrl())
+.withQueueSize(2)
+.withThreadCount(5)
Review Comment:
okay, now I remember.. I eliminate the `super.createNewSolrClient` partly
because it was a pattern I had never seen used elsewhere, and in
`SolrExampleStreamingTest` it looks like:
```
return new ErrorTrackingConcurrentUpdateSolrClient.Builder(getServerUrl())
.withQueueSize(2)
.withThreadCount(5)
.withResponseParser(new XMLResponseParser())
.withRequestWriter(new RequestWriter())
.build();
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
[GitHub] [solr] epugh commented on a diff in pull request #1158: SOLR-16368: experiment with builder to simplify client creation
epugh commented on code in PR #1158:
URL: https://github.com/apache/solr/pull/1158#discussion_r1011647489
##
solr/solrj/src/test/org/apache/solr/client/solrj/embedded/SolrExampleStreamingBinaryTest.java:
##
@@ -35,9 +34,15 @@ public class SolrExampleStreamingBinaryTest extends
SolrExampleStreamingTest {
@Override
public SolrClient createNewSolrClient() {
-ConcurrentUpdateSolrClient client = (ConcurrentUpdateSolrClient)
super.createNewSolrClient();
-client.setParser(new BinaryResponseParser());
-client.setRequestWriter(new BinaryRequestWriter());
+
+SolrClient client =
+new ErrorTrackingConcurrentUpdateSolrClient.Builder(getServerUrl())
+.withQueueSize(2)
+.withThreadCount(5)
Review Comment:
looking into it now... i might have goofed! I remember thinking "this is
different"...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
[jira] [Commented] (SOLR-16512) Eliminate noggit JSONWriter.Writable from Solr classes
[ https://issues.apache.org/jira/browse/SOLR-16512?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17627655#comment-17627655 ] Eric Pugh commented on SOLR-16512: -- Out of curiosity, what does moving to MapWriter give us? I read through the PR, and I see the change, but don't quite understand the why... Performance? Less maintence code? > Eliminate noggit JSONWriter.Writable from Solr classes > -- > > Key: SOLR-16512 > URL: https://issues.apache.org/jira/browse/SOLR-16512 > Project: Solr > Issue Type: Bug > Security Level: Public(Default Security Level. Issues are Public) >Reporter: Noble Paul >Assignee: Noble Paul >Priority: Major > Time Spent: 20m > Remaining Estimate: 0h > > Use MapWriter instead -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
[GitHub] [solr] noblepaul commented on pull request #1159: SOLR-16512 : Eliminate noggit JSONWriter.Writable from Solr classes
noblepaul commented on PR #1159: URL: https://github.com/apache/solr/pull/1159#issuecomment-1300178646 > Seems fine. Couldn't find review button, btw. I think if you go to the "files" tab , it's on the top right -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
[jira] [Assigned] (SOLR-16512) Eliminate noggit JSONWriter.Writable from Solr classes
[ https://issues.apache.org/jira/browse/SOLR-16512?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Noble Paul reassigned SOLR-16512: - Assignee: Noble Paul > Eliminate noggit JSONWriter.Writable from Solr classes > -- > > Key: SOLR-16512 > URL: https://issues.apache.org/jira/browse/SOLR-16512 > Project: Solr > Issue Type: Bug > Security Level: Public(Default Security Level. Issues are Public) >Reporter: Noble Paul >Assignee: Noble Paul >Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > > Use MapWriter instead -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
[GitHub] [solr] mkhludnev commented on pull request #1159: SOLR-16512 : Eliminate noggit JSONWriter.Writable from Solr classes
mkhludnev commented on PR #1159: URL: https://github.com/apache/solr/pull/1159#issuecomment-1299968926 Seems fine. Couldn't find review button, btw. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
[jira] [Updated] (SOLR-16512) Eliminate noggit JSONWriter.Writable from Solr classes
[ https://issues.apache.org/jira/browse/SOLR-16512?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Noble Paul updated SOLR-16512: -- Summary: Eliminate noggit JSONWriter.Writable from Solr classes (was: Get rid of JSONWriter.Writable dependencies) > Eliminate noggit JSONWriter.Writable from Solr classes > -- > > Key: SOLR-16512 > URL: https://issues.apache.org/jira/browse/SOLR-16512 > Project: Solr > Issue Type: Bug > Security Level: Public(Default Security Level. Issues are Public) >Reporter: Noble Paul >Priority: Major > > Use MapWriter instead -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
[GitHub] [solr] uschindler commented on pull request #1118: [SOLR-16489] CaffeineCache puts thread into infinite loop
uschindler commented on PR #1118: URL: https://github.com/apache/solr/pull/1118#issuecomment-1299808362 For booleanQuery we have many tests in Lucene core and its own cache implementation. So it is three cases where it may break: - somebody calls getClauses() and modifies them (adding entries). We should prevent that by making the clauses unmodifiable in Lucene. I'll open an issue. - somebody modified one query inside the clauses. I would need to get all clauses of the above example - the WrappedQuery itsself is the issue. I would start there, see above. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
[GitHub] [solr] uschindler commented on pull request #1118: [SOLR-16489] CaffeineCache puts thread into infinite loop
uschindler commented on PR #1118: URL: https://github.com/apache/solr/pull/1118#issuecomment-1299803390 Anyways, we should figure out if not the WrappedQuery is changing its hashCode, because this one was explicitely mutable. But the setter is never called from Solr (dead code according to @risdenk, right?) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
[GitHub] [solr] uschindler commented on pull request #1118: [SOLR-16489] CaffeineCache puts thread into infinite loop
uschindler commented on PR #1118: URL: https://github.com/apache/solr/pull/1118#issuecomment-1299799324 The clauses should not be modifyable from outside and I don't know any code doing this. BooleanQuery is designed to be immutable, the problem is more that there seems to be a getter that returns the non-wrapped list. But I don't think this is the problem here. I have the feeling one of the inner queries is the bad guy. Can you post the fill clauses contents as tree? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
[GitHub] [solr] ben-manes commented on pull request #1118: [SOLR-16489] CaffeineCache puts thread into infinite loop
ben-manes commented on PR #1118: URL: https://github.com/apache/solr/pull/1118#issuecomment-1299774688 Lucerne’s BooleanQuery clauseSets is externally mutable. The getClauses method returns a mutable collection (hashset) so the caller might add to it. I don’t see an occurrence, but some unexpected inner mutability is an easy mistake. The idea in the related issue above of using `@Immutable` to assert deeply would be a nice goal. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
[GitHub] [solr] DennisBerger1984 commented on pull request #1118: [SOLR-16489] CaffeineCache puts thread into infinite loop
DennisBerger1984 commented on PR #1118: URL: https://github.com/apache/solr/pull/1118#issuecomment-1299722332  It's a WrappedQuery Object. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
[GitHub] [solr] DennisBerger1984 commented on pull request #1156: [SOLR-16515] Remove synchronized access to cachedOrdMaps in SlowCompositeReaderWrapper
DennisBerger1984 commented on PR #1156: URL: https://github.com/apache/solr/pull/1156#issuecomment-1299716722  It's a WrappedQuery object. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
[GitHub] [solr] sonatype-lift[bot] commented on pull request #1159: SOLR: 16512 : Eliminate noggit JSONWriter.Writable from Solr classes
sonatype-lift[bot] commented on PR #1159: URL: https://github.com/apache/solr/pull/1159#issuecomment-1299671194 :warning: **314 God Classes** were detected by Lift in this project. [Visit the Lift web console](https://lift.sonatype.com/results/github.com/apache/solr/01GGVFBCD8A8Z030NN5SM6B5Z9?tab=technical-debt_source=github.com_campaign=lift-comment_content=apache\%20solr) for more details. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
