[jira] [Commented] (SOLR-8238) Make Solr respect preferredLeader at startup
[ https://issues.apache.org/jira/browse/SOLR-8238?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17696011#comment-17696011 ] David Smiley commented on SOLR-8238: I think what you describe is a case *for* what this Jira issue is about, since it leads to more rebalancing. Without doing something, then in a rolling restart, the last node to start up will have *no* leaders, with or without preferredLeaders! > Make Solr respect preferredLeader at startup > > > Key: SOLR-8238 > URL: https://issues.apache.org/jira/browse/SOLR-8238 > Project: Solr > Issue Type: Improvement > Components: SolrCloud >Affects Versions: 5.2.1 >Reporter: Peter Morgan >Priority: Minor > > After setting preferredLeader property, noticed that upon restarting leaders > revert to wherever they were previously running before REBALANCE was called. > I would expect the preferredLeader to influence the startup election, but it > appears it is not observed. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
[GitHub] [solr] stillalex commented on pull request #1410: SOLR-16676 Http2SolrClient loss of MDC context
stillalex commented on PR #1410: URL: https://github.com/apache/solr/pull/1410#issuecomment-1452711234 trying the `ShardHandlerFactory#sizeOfQueue` setting on a Solr 9 definitely shows some weirdness, I'm unable to create a collection: ``` 2023-03-02 15:15:40.028 INFO (qtp2048013503-26) [] o.a.s.s.HttpSolrCall [admin] webapp=null path=/admin/collections params={replicationFactor=1=_default=test=compositeId=CREATE=5=json&_=1677798725094} status=500 QTime=180057 2023-03-02 15:15:40.029 ERROR (qtp2048013503-26) [] o.a.s.s.HttpSolrCall org.apache.solr.common.SolrException: create the collection time out:180s => org.apache.solr.common.SolrException: create the collection time out:180s at org.apache.solr.handler.admin.CollectionsHandler.submitCollectionApiCommand(CollectionsHandler.java:433) org.apache.solr.common.SolrException: create the collection time out:180s at org.apache.solr.handler.admin.CollectionsHandler.submitCollectionApiCommand(CollectionsHandler.java:433) ~[?:?] at org.apache.solr.handler.admin.CollectionsHandler.invokeAction(CollectionsHandler.java:345) ~[?:?] at org.apache.solr.handler.admin.CollectionsHandler.handleRequestBody(CollectionsHandler.java:297) ~[?:?] at org.apache.solr.handler.RequestHandlerBase.handleRequest(RequestHandlerBase.java:224) ~[?:?] at org.apache.solr.servlet.HttpSolrCall.handleAdmin(HttpSolrCall.java:941) ~[?:?] at org.apache.solr.servlet.HttpSolrCall.handleAdminRequest(HttpSolrCall.java:893) ~[?:?] at org.apache.solr.servlet.HttpSolrCall.call(HttpSolrCall.java:584) ~[?:?] at org.apache.solr.servlet.SolrDispatchFilter.dispatch(SolrDispatchFilter.java:250) ~[?:?] ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
[jira] [Commented] (SOLR-8238) Make Solr respect preferredLeader at startup
[ https://issues.apache.org/jira/browse/SOLR-8238?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17695924#comment-17695924 ] Erick Erickson commented on SOLR-8238: -- OK, you're asking me to get in the way-back machine here, but I still get e-mails from JIRAs I haven't stopped watching, generally ones from a long time ago Before the preferredleader and rebalanceleaders code was put in, it was possible to put hundreds of leaders on a single SOLR instance. This was a situation where there were a gazillion shards and the cluster was restarted and a particular SOLR instance had a replica from many shards and came up first. There was no way to move the leaders off that SOLR instance. And (IIRC), the added load on that instance was noticeable cluster wide. The preferredleader option and rebalanceleader command were put in to fix this (rare) situation. So the situation this was designed to address was before PREFERREDLEADER was an option. By and large, being concerned about how many shards had a leader on the same node is unnecessary. Now, that said, this was years ago. Whether this is necessary in modern code is left "as an exercise for the reader" ;) Also (and my memory may not be accurate here) this was before TLOG replicas were a thing. Imagine that there are hundreds of shards and a replica of each shard is on some SOLR instance and that instance is the first one started. How many leaders would be on that SOLR instance. And remember that this case had _hundreds_ of shards, so was an outlier back then (although I'm far enough out of the loop that I don't know how common such a situation is now)... Back to retirement ;) > Make Solr respect preferredLeader at startup > > > Key: SOLR-8238 > URL: https://issues.apache.org/jira/browse/SOLR-8238 > Project: Solr > Issue Type: Improvement > Components: SolrCloud >Affects Versions: 5.2.1 >Reporter: Peter Morgan >Priority: Minor > > After setting preferredLeader property, noticed that upon restarting leaders > revert to wherever they were previously running before REBALANCE was called. > I would expect the preferredLeader to influence the startup election, but it > appears it is not observed. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
[GitHub] [solr] stillalex commented on pull request #1410: SOLR-16676 Http2SolrClient loss of MDC context
stillalex commented on PR #1410: URL: https://github.com/apache/solr/pull/1410#issuecomment-1452676506 @dsmiley good news and bad news :) I finally managed to add tests (and cover failure scenarios too) thanks for the pointers, I was tempted to not go the extra mile. now the not so great news. I believe there might be a deadlock on the Http2SolrClient when configured with an ArrayBlockingQueue. I was not able to find tests for this config, but it's definitely possible to have this enabled via the HttpShardHandlerFactory configs. please take a look at https://github.com/apache/solr/pull/1410/commits/a9f9af819ed094a504c60b17da8607e66afc6a67 and possibly tell me what I did wrong. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
[jira] [Comment Edited] (SOLR-16681) Replacing uniqueKey field via fl doesn't work in distributed since 9.0
[ https://issues.apache.org/jira/browse/SOLR-16681?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17695871#comment-17695871 ] Mikhail Khludnev edited comment on SOLR-16681 at 3/2/23 8:05 PM: - I think [https://github.com/apache/solr/pull/1384] is ready. Remaining doubts are: * is it fine to piggyback on those tests or it's worth to bring up a new one? * I'm sure there's a better wording in exception message. Which one? * I feel like it's really hard to explain in documentation especially giving that it's something which doesn't work. I think exception is explicit enough. I wish put it into 9.2 as is. was (Author: mkhludnev): I think like [https://github.com/apache/solr/pull/1384] Remaining doubts are: * is it fine to piggyback on those tests or it's worth to bring up a new one? * I'm sure there's a better wording in exception message. Which one? * I feel like it's really hard to explain in documentation especially giving that it's something which doesn't work. I think exception is explicit enough. I wish put it into 9.2 as is. > Replacing uniqueKey field via fl doesn't work in distributed since 9.0 > -- > > Key: SOLR-16681 > URL: https://issues.apache.org/jira/browse/SOLR-16681 > Project: Solr > Issue Type: Bug > Security Level: Public(Default Security Level. Issues are Public) >Reporter: Mikhail Khludnev >Priority: Minor > Fix For: 9.2 > > Attachments: image-2023-02-26-09-48-31-974.png, > image-2023-02-26-09-48-59-323.png > > Time Spent: 10m > Remaining Estimate: 0h > > User reported a use case which were working before 9 but not anymore. > The point is to logically replace a field (hereby it's {{id}} {-}but it might > behave same for any other{-}) > {{fl=old_id:id,id:new_id}} > I'd say it's a kind of {{{}$mv new_id id{}}}. I've made a simple > [reproducer|https://github.com/apache/solr/pull/1384]. > it fails with > {code:java} > - org.apache.solr.cloud.TestCloudPseudoReturnFields.test_mv_fl (:solr:core) > [7597|https://github.com/apache/solr/actions/runs/4276380498/jobs/731149#step:4:7598] > Test output: > /tmp/src/solr/solr/core/build/test-results/test/outputs/OUTPUT-org.apache.solr.cloud.TestCloudPseudoReturnFields.txt > > [7598|https://github.com/apache/solr/actions/runs/4276380498/jobs/731149#step:4:7599] > Reproduce with: gradlew :solr:core:test --tests > "org.apache.solr.cloud.TestCloudPseudoReturnFields.test_mv_fl" > -Ptests.jvms=96 "-Ptests.jvmargs=-XX:TieredStopAtLevel=1 -XX:+UseParallelGC > -XX:ActiveProcessorCount=1 -XX:ReservedCodeCacheSize=120m" > -Ptests.seed=4CCEBE424880B511 -Ptests.file.encoding=US-ASCII > {code} > . [Then I applied > it|https://github.com/mkhludnev/solr/tree/SOLR-16681-proves-work-before] to > revision preceding > [SOLR-9376|https://github.com/mkhludnev/solr/commit/6ff81312607dd5d33f87dc52aed9d52938dc6883#diff-e72c1360a9b0097bcc01e269a94045ce5af1fdc93ae3021ca7e8d1b26d46bdcb] > and test passed. For me it seems like: > - Solr behaved like described before, but it does not after SOLR-9376. > - Should we reproduce this behavior or we can suggest a workaround? > -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
[GitHub] [solr] risdenk merged pull request #1397: Update dependency biz.aQute.bnd:biz.aQute.bnd.annotation to v6.4.0
risdenk merged PR #1397: URL: https://github.com/apache/solr/pull/1397 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
[GitHub] [solr] risdenk merged pull request #1399: Update com.google.cloud:google-cloud-bom to v0.190.0 and io.grpc:grpc-* to 1.53.0
risdenk merged PR #1399: URL: https://github.com/apache/solr/pull/1399 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
[jira] [Commented] (SOLR-16684) Keep solr's opennlp-tools version in sync with Lucene
[ https://issues.apache.org/jira/browse/SOLR-16684?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17695872#comment-17695872 ] ASF subversion and git services commented on SOLR-16684: Commit 7e72fdcec037997c23b10333bf6cb92256439b45 in solr's branch refs/heads/branch_9x from Jan Høydahl [ https://gitbox.apache.org/repos/asf?p=solr.git;h=7e72fdcec03 ] SOLR-16684: Stop overriding org.apache.opennlp:opennlp-tools in solr (#1424) Signed-off-by: Jan Høydahl (cherry picked from commit 1d0c8a18302c2d4732f2e25ae8a524b34294fa59) > Keep solr's opennlp-tools version in sync with Lucene > - > > Key: SOLR-16684 > URL: https://issues.apache.org/jira/browse/SOLR-16684 > Project: Solr > Issue Type: Improvement > Security Level: Public(Default Security Level. Issues are Public) >Reporter: Jan Høydahl >Assignee: Jan Høydahl >Priority: Major > Fix For: 9.2 > > Time Spent: 0.5h > Remaining Estimate: 0h > > Solr's analysis-extras module must be kept on the same version as lucene's > lucene-analysis-opennlp module. Currently we override the version in Solr's > {{versions.props}} file, but this is error prone. > We'll thus remove the override and let Lucene decide what version we pull in. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
[jira] [Commented] (SOLR-16681) Replacing uniqueKey field via fl doesn't work in distributed since 9.0
[ https://issues.apache.org/jira/browse/SOLR-16681?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17695871#comment-17695871 ] Mikhail Khludnev commented on SOLR-16681: - I think like [https://github.com/apache/solr/pull/1384] Remaining doubts are: * is it fine to piggyback on those tests or it's worth to bring up a new one? * I'm sure there's a better wording in exception message. Which one? * I feel like it's really hard to explain in documentation especially giving that it's something which doesn't work. I think exception is explicit enough. I wish put it into 9.2 as is. > Replacing uniqueKey field via fl doesn't work in distributed since 9.0 > -- > > Key: SOLR-16681 > URL: https://issues.apache.org/jira/browse/SOLR-16681 > Project: Solr > Issue Type: Bug > Security Level: Public(Default Security Level. Issues are Public) >Reporter: Mikhail Khludnev >Priority: Minor > Fix For: 9.2 > > Attachments: image-2023-02-26-09-48-31-974.png, > image-2023-02-26-09-48-59-323.png > > Time Spent: 10m > Remaining Estimate: 0h > > User reported a use case which were working before 9 but not anymore. > The point is to logically replace a field (hereby it's {{id}} {-}but it might > behave same for any other{-}) > {{fl=old_id:id,id:new_id}} > I'd say it's a kind of {{{}$mv new_id id{}}}. I've made a simple > [reproducer|https://github.com/apache/solr/pull/1384]. > it fails with > {code:java} > - org.apache.solr.cloud.TestCloudPseudoReturnFields.test_mv_fl (:solr:core) > [7597|https://github.com/apache/solr/actions/runs/4276380498/jobs/731149#step:4:7598] > Test output: > /tmp/src/solr/solr/core/build/test-results/test/outputs/OUTPUT-org.apache.solr.cloud.TestCloudPseudoReturnFields.txt > > [7598|https://github.com/apache/solr/actions/runs/4276380498/jobs/731149#step:4:7599] > Reproduce with: gradlew :solr:core:test --tests > "org.apache.solr.cloud.TestCloudPseudoReturnFields.test_mv_fl" > -Ptests.jvms=96 "-Ptests.jvmargs=-XX:TieredStopAtLevel=1 -XX:+UseParallelGC > -XX:ActiveProcessorCount=1 -XX:ReservedCodeCacheSize=120m" > -Ptests.seed=4CCEBE424880B511 -Ptests.file.encoding=US-ASCII > {code} > . [Then I applied > it|https://github.com/mkhludnev/solr/tree/SOLR-16681-proves-work-before] to > revision preceding > [SOLR-9376|https://github.com/mkhludnev/solr/commit/6ff81312607dd5d33f87dc52aed9d52938dc6883#diff-e72c1360a9b0097bcc01e269a94045ce5af1fdc93ae3021ca7e8d1b26d46bdcb] > and test passed. For me it seems like: > - Solr behaved like described before, but it does not after SOLR-9376. > - Should we reproduce this behavior or we can suggest a workaround? > -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
[jira] [Commented] (SOLR-16684) Keep solr's opennlp-tools version in sync with Lucene
[ https://issues.apache.org/jira/browse/SOLR-16684?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17695870#comment-17695870 ] ASF subversion and git services commented on SOLR-16684: Commit 1d0c8a18302c2d4732f2e25ae8a524b34294fa59 in solr's branch refs/heads/main from Jan Høydahl [ https://gitbox.apache.org/repos/asf?p=solr.git;h=1d0c8a18302 ] SOLR-16684: Stop overriding org.apache.opennlp:opennlp-tools in solr (#1424) Signed-off-by: Jan Høydahl > Keep solr's opennlp-tools version in sync with Lucene > - > > Key: SOLR-16684 > URL: https://issues.apache.org/jira/browse/SOLR-16684 > Project: Solr > Issue Type: Improvement > Security Level: Public(Default Security Level. Issues are Public) >Reporter: Jan Høydahl >Assignee: Jan Høydahl >Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > > Solr's analysis-extras module must be kept on the same version as lucene's > lucene-analysis-opennlp module. Currently we override the version in Solr's > {{versions.props}} file, but this is error prone. > We'll thus remove the override and let Lucene decide what version we pull in. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
[jira] [Resolved] (SOLR-16684) Keep solr's opennlp-tools version in sync with Lucene
[ https://issues.apache.org/jira/browse/SOLR-16684?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Høydahl resolved SOLR-16684. Fix Version/s: 9.2 Resolution: Fixed > Keep solr's opennlp-tools version in sync with Lucene > - > > Key: SOLR-16684 > URL: https://issues.apache.org/jira/browse/SOLR-16684 > Project: Solr > Issue Type: Improvement > Security Level: Public(Default Security Level. Issues are Public) >Reporter: Jan Høydahl >Assignee: Jan Høydahl >Priority: Major > Fix For: 9.2 > > Time Spent: 0.5h > Remaining Estimate: 0h > > Solr's analysis-extras module must be kept on the same version as lucene's > lucene-analysis-opennlp module. Currently we override the version in Solr's > {{versions.props}} file, but this is error prone. > We'll thus remove the override and let Lucene decide what version we pull in. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
[GitHub] [solr] janhoy closed pull request #1424: SOLR-16684 Stop overriding org.apache.opennlp:opennlp-tools in solr
janhoy closed pull request #1424: SOLR-16684 Stop overriding org.apache.opennlp:opennlp-tools in solr URL: https://github.com/apache/solr/pull/1424 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
[GitHub] [solr] janhoy commented on pull request #1424: SOLR-16684 Stop overriding org.apache.opennlp:opennlp-tools in solr
janhoy commented on PR #1424: URL: https://github.com/apache/solr/pull/1424#issuecomment-1452420513 Merged by hand -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
[GitHub] [solr] janhoy commented on pull request #1424: SOLR-16684 Stop overriding org.apache.opennlp:opennlp-tools in solr
janhoy commented on PR #1424: URL: https://github.com/apache/solr/pull/1424#issuecomment-1452411168 https://issues.apache.org/jira/browse/SOLR-16684 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
[jira] [Created] (SOLR-16684) Keep solr's opennlp-tools version in sync with Lucene
Jan Høydahl created SOLR-16684: -- Summary: Keep solr's opennlp-tools version in sync with Lucene Key: SOLR-16684 URL: https://issues.apache.org/jira/browse/SOLR-16684 Project: Solr Issue Type: Improvement Security Level: Public (Default Security Level. Issues are Public) Reporter: Jan Høydahl Assignee: Jan Høydahl Solr's analysis-extras module must be kept on the same version as lucene's lucene-analysis-opennlp module. Currently we override the version in Solr's {{versions.props}} file, but this is error prone. We'll thus remove the override and let Lucene decide what version we pull in. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
[jira] [Updated] (SOLR-16681) Replacing uniqueKey field via fl doesn't work in distributed since 9.0
[ https://issues.apache.org/jira/browse/SOLR-16681?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mikhail Khludnev updated SOLR-16681: Fix Version/s: 9.2 > Replacing uniqueKey field via fl doesn't work in distributed since 9.0 > -- > > Key: SOLR-16681 > URL: https://issues.apache.org/jira/browse/SOLR-16681 > Project: Solr > Issue Type: Bug > Security Level: Public(Default Security Level. Issues are Public) >Reporter: Mikhail Khludnev >Priority: Minor > Fix For: 9.2 > > Attachments: image-2023-02-26-09-48-31-974.png, > image-2023-02-26-09-48-59-323.png > > Time Spent: 10m > Remaining Estimate: 0h > > User reported a use case which were working before 9 but not anymore. > The point is to logically replace a field (hereby it's {{id}} {-}but it might > behave same for any other{-}) > {{fl=old_id:id,id:new_id}} > I'd say it's a kind of {{{}$mv new_id id{}}}. I've made a simple > [reproducer|https://github.com/apache/solr/pull/1384]. > it fails with > {code:java} > - org.apache.solr.cloud.TestCloudPseudoReturnFields.test_mv_fl (:solr:core) > [7597|https://github.com/apache/solr/actions/runs/4276380498/jobs/731149#step:4:7598] > Test output: > /tmp/src/solr/solr/core/build/test-results/test/outputs/OUTPUT-org.apache.solr.cloud.TestCloudPseudoReturnFields.txt > > [7598|https://github.com/apache/solr/actions/runs/4276380498/jobs/731149#step:4:7599] > Reproduce with: gradlew :solr:core:test --tests > "org.apache.solr.cloud.TestCloudPseudoReturnFields.test_mv_fl" > -Ptests.jvms=96 "-Ptests.jvmargs=-XX:TieredStopAtLevel=1 -XX:+UseParallelGC > -XX:ActiveProcessorCount=1 -XX:ReservedCodeCacheSize=120m" > -Ptests.seed=4CCEBE424880B511 -Ptests.file.encoding=US-ASCII > {code} > . [Then I applied > it|https://github.com/mkhludnev/solr/tree/SOLR-16681-proves-work-before] to > revision preceding > [SOLR-9376|https://github.com/mkhludnev/solr/commit/6ff81312607dd5d33f87dc52aed9d52938dc6883#diff-e72c1360a9b0097bcc01e269a94045ce5af1fdc93ae3021ca7e8d1b26d46bdcb] > and test passed. For me it seems like: > - Solr behaved like described before, but it does not after SOLR-9376. > - Should we reproduce this behavior or we can suggest a workaround? > -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
[jira] [Updated] (SOLR-16681) Replacing uniqueKey field via fl doesn't work in distributed since 9.0
[ https://issues.apache.org/jira/browse/SOLR-16681?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mikhail Khludnev updated SOLR-16681: Summary: Replacing uniqueKey field via fl doesn't work in distributed since 9.0 (was: Replacing uniqueKey field via fl doesn't work since 9.0) > Replacing uniqueKey field via fl doesn't work in distributed since 9.0 > -- > > Key: SOLR-16681 > URL: https://issues.apache.org/jira/browse/SOLR-16681 > Project: Solr > Issue Type: Bug > Security Level: Public(Default Security Level. Issues are Public) >Reporter: Mikhail Khludnev >Priority: Minor > Attachments: image-2023-02-26-09-48-31-974.png, > image-2023-02-26-09-48-59-323.png > > Time Spent: 10m > Remaining Estimate: 0h > > User reported a use case which were working before 9 but not anymore. > The point is to logically replace a field (hereby it's {{id}} {-}but it might > behave same for any other{-}) > {{fl=old_id:id,id:new_id}} > I'd say it's a kind of {{{}$mv new_id id{}}}. I've made a simple > [reproducer|https://github.com/apache/solr/pull/1384]. > it fails with > {code:java} > - org.apache.solr.cloud.TestCloudPseudoReturnFields.test_mv_fl (:solr:core) > [7597|https://github.com/apache/solr/actions/runs/4276380498/jobs/731149#step:4:7598] > Test output: > /tmp/src/solr/solr/core/build/test-results/test/outputs/OUTPUT-org.apache.solr.cloud.TestCloudPseudoReturnFields.txt > > [7598|https://github.com/apache/solr/actions/runs/4276380498/jobs/731149#step:4:7599] > Reproduce with: gradlew :solr:core:test --tests > "org.apache.solr.cloud.TestCloudPseudoReturnFields.test_mv_fl" > -Ptests.jvms=96 "-Ptests.jvmargs=-XX:TieredStopAtLevel=1 -XX:+UseParallelGC > -XX:ActiveProcessorCount=1 -XX:ReservedCodeCacheSize=120m" > -Ptests.seed=4CCEBE424880B511 -Ptests.file.encoding=US-ASCII > {code} > . [Then I applied > it|https://github.com/mkhludnev/solr/tree/SOLR-16681-proves-work-before] to > revision preceding > [SOLR-9376|https://github.com/mkhludnev/solr/commit/6ff81312607dd5d33f87dc52aed9d52938dc6883#diff-e72c1360a9b0097bcc01e269a94045ce5af1fdc93ae3021ca7e8d1b26d46bdcb] > and test passed. For me it seems like: > - Solr behaved like described before, but it does not after SOLR-9376. > - Should we reproduce this behavior or we can suggest a workaround? > -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
[GitHub] [solr] janhoy commented on pull request #1424: Stop overriding org.apache.opennlp:opennlp-tools in solr
janhoy commented on PR #1424: URL: https://github.com/apache/solr/pull/1424#issuecomment-1452404846 Crave.io is not happy when applying its patches ``` error: versions.props: patch does not apply ``` I manually ran both the analysis-extras and langid tests, which pass, and `versions.lock` is identical as before, so think this is safe. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
[GitHub] [solr] solrbot commented on pull request #1424: Stop overriding org.apache.opennlp:opennlp-tools in solr
solrbot commented on PR #1424: URL: https://github.com/apache/solr/pull/1424#issuecomment-1452385955 ### Edited/Blocked Notification Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR. You can manually request rebase by checking the rebase/retry box above. ⚠ **Warning**: custom changes will be lost. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
[GitHub] [solr] risdenk commented on a diff in pull request #1399: Update com.google.cloud:google-cloud-bom to v0.190.0 and io.grpc:grpc-* to 1.53.0
risdenk commented on code in PR #1399: URL: https://github.com/apache/solr/pull/1399#discussion_r1123569346 ## versions.props: ## @@ -8,7 +8,7 @@ com.fasterxml.woodstox:woodstox-core=6.5.0 com.github.ben-manes.caffeine:caffeine=3.1.4 com.github.spotbugs:*=4.7.3 com.github.stephenc.jcip:jcip-annotations=1.0-1 -com.google.cloud:google-cloud-bom=0.184.0 Review Comment: fixed in 153fcbafce43823d57ad1ef0ccbad4dfe3861735 ## solr/licenses/auto-value-1.10.1.jar.sha1: ## @@ -0,0 +1 @@ +e0184c26c3a20257c6fb46eaea16fdd3d7b6d357 Review Comment: fixed in b72e14aff6df643aa043bf6a2e779bc5c8bc9504 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
[jira] [Updated] (SOLR-16683) Frequent failures of OtelTracerConfiguratorTest
[ https://issues.apache.org/jira/browse/SOLR-16683?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Høydahl updated SOLR-16683: --- Fix Version/s: 9.2 Resolution: Fixed Status: Resolved (was: Patch Available) > Frequent failures of OtelTracerConfiguratorTest > --- > > Key: SOLR-16683 > URL: https://issues.apache.org/jira/browse/SOLR-16683 > Project: Solr > Issue Type: Bug > Security Level: Public(Default Security Level. Issues are Public) >Affects Versions: 9.1.1 >Reporter: Jan Høydahl >Assignee: Jan Høydahl >Priority: Major > Fix For: 9.2 > > Time Spent: 40m > Remaining Estimate: 0h > > 4.7% failure of the test OtelTracerConfiguratorTest. > {code:java} > org.apache.solr.opentelemetry.OtelTracerConfiguratorTest > classMethod FAILED > com.carrotsearch.randomizedtesting.ThreadLeakError: 1 thread leaked from > SUITE scope at org.apache.solr.opentelemetry.OtelTracerConfiguratorTest: > 1) Thread[id=64, name=BatchSpanProcessor_WorkerThread-1, > state=TIMED_WAITING, group=TGRP-OtelTracerConfiguratorTest] > at java.base@11.0.16/jdk.internal.misc.Unsafe.park(Native Method) > at > java.base@11.0.16/java.util.concurrent.locks.LockSupport.parkNanos(LockSupport.java:234) > at > java.base@11.0.16/java.util.concurrent.locks.AbstractQueuedSynchronizer$ConditionObject.awaitNanos(AbstractQueuedSynchronizer.java:2123) > at > java.base@11.0.16/java.util.concurrent.ArrayBlockingQueue.poll(ArrayBlockingQueue.java:432) > at > app//io.opentelemetry.sdk.trace.export.BatchSpanProcessor$Worker.run(BatchSpanProcessor.java:252) > at java.base@11.0.16/java.lang.Thread.run(Thread.java:829) > at __randomizedtesting.SeedInfo.seed([CCCE79C05B3FB703]:0) {code} > The tracer uses a BatchSpanProcessor by default, which has its own thread. It > will eventually exit, but the test fails -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
[GitHub] [solr] risdenk commented on a diff in pull request #1399: Update dependency com.google.cloud:google-cloud-bom to v0.190.0
risdenk commented on code in PR #1399: URL: https://github.com/apache/solr/pull/1399#discussion_r1123559207 ## solr/licenses/auto-value-1.10.1.jar.sha1: ## @@ -0,0 +1 @@ +e0184c26c3a20257c6fb46eaea16fdd3d7b6d357 Review Comment: need NOTICE and LICENSE file for auto-value -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
[GitHub] [solr] janhoy commented on a diff in pull request #1399: Update dependency com.google.cloud:google-cloud-bom to v0.190.0
janhoy commented on code in PR #1399: URL: https://github.com/apache/solr/pull/1399#discussion_r1123555073 ## versions.props: ## @@ -8,7 +8,7 @@ com.fasterxml.woodstox:woodstox-core=6.5.0 com.github.ben-manes.caffeine:caffeine=3.1.4 com.github.spotbugs:*=4.7.3 com.github.stephenc.jcip:jcip-annotations=1.0-1 -com.google.cloud:google-cloud-bom=0.184.0 Review Comment: Feel free to complete this... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
[GitHub] [solr] janhoy commented on pull request #1424: Stop overriding org.apache.opennlp:opennlp-tools in solr
janhoy commented on PR #1424: URL: https://github.com/apache/solr/pull/1424#issuecomment-1452351278 Re-purposing this PR to remove version override of opennlp-tools in solr. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
[GitHub] [solr] janhoy commented on pull request #1424: Update dependency org.apache.opennlp:opennlp-tools to v2
janhoy commented on PR #1424: URL: https://github.com/apache/solr/pull/1424#issuecomment-1452324786 Our `analysis-extras` module depends on `lucene-analysis-opennlp` which depends on `opennlp-tools 1.9.1`. So Solr has to use the exact same version. I'll try to remove this line from `versions.props` and let it flow in from lucene instead. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
[GitHub] [solr] risdenk merged pull request #1429: Renovate tweaks
risdenk merged PR #1429: URL: https://github.com/apache/solr/pull/1429 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
[jira] [Commented] (SOLR-16683) Frequent failures of OtelTracerConfiguratorTest
[ https://issues.apache.org/jira/browse/SOLR-16683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17695845#comment-17695845 ] ASF subversion and git services commented on SOLR-16683: Commit 644e705a42451ad0a2a9619729df0122a1ba5059 in solr's branch refs/heads/branch_9x from Jan Høydahl [ https://gitbox.apache.org/repos/asf?p=solr.git;h=644e705a424 ] SOLR-16683 Fix frequent failures of OtelTracerConfiguratorTest (#1413) Signed-off-by: Jan Høydahl (cherry picked from commit f9b800f1cfc3876107c10bd606ad11382d8f6129) > Frequent failures of OtelTracerConfiguratorTest > --- > > Key: SOLR-16683 > URL: https://issues.apache.org/jira/browse/SOLR-16683 > Project: Solr > Issue Type: Bug > Security Level: Public(Default Security Level. Issues are Public) >Affects Versions: 9.1.1 >Reporter: Jan Høydahl >Assignee: Jan Høydahl >Priority: Major > Time Spent: 40m > Remaining Estimate: 0h > > 4.7% failure of the test OtelTracerConfiguratorTest. > {code:java} > org.apache.solr.opentelemetry.OtelTracerConfiguratorTest > classMethod FAILED > com.carrotsearch.randomizedtesting.ThreadLeakError: 1 thread leaked from > SUITE scope at org.apache.solr.opentelemetry.OtelTracerConfiguratorTest: > 1) Thread[id=64, name=BatchSpanProcessor_WorkerThread-1, > state=TIMED_WAITING, group=TGRP-OtelTracerConfiguratorTest] > at java.base@11.0.16/jdk.internal.misc.Unsafe.park(Native Method) > at > java.base@11.0.16/java.util.concurrent.locks.LockSupport.parkNanos(LockSupport.java:234) > at > java.base@11.0.16/java.util.concurrent.locks.AbstractQueuedSynchronizer$ConditionObject.awaitNanos(AbstractQueuedSynchronizer.java:2123) > at > java.base@11.0.16/java.util.concurrent.ArrayBlockingQueue.poll(ArrayBlockingQueue.java:432) > at > app//io.opentelemetry.sdk.trace.export.BatchSpanProcessor$Worker.run(BatchSpanProcessor.java:252) > at java.base@11.0.16/java.lang.Thread.run(Thread.java:829) > at __randomizedtesting.SeedInfo.seed([CCCE79C05B3FB703]:0) {code} > The tracer uses a BatchSpanProcessor by default, which has its own thread. It > will eventually exit, but the test fails -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
[jira] [Commented] (SOLR-16683) Frequent failures of OtelTracerConfiguratorTest
[ https://issues.apache.org/jira/browse/SOLR-16683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17695844#comment-17695844 ] ASF subversion and git services commented on SOLR-16683: Commit f9b800f1cfc3876107c10bd606ad11382d8f6129 in solr's branch refs/heads/main from Jan Høydahl [ https://gitbox.apache.org/repos/asf?p=solr.git;h=f9b800f1cfc ] SOLR-16683 Fix frequent failures of OtelTracerConfiguratorTest (#1413) Signed-off-by: Jan Høydahl > Frequent failures of OtelTracerConfiguratorTest > --- > > Key: SOLR-16683 > URL: https://issues.apache.org/jira/browse/SOLR-16683 > Project: Solr > Issue Type: Bug > Security Level: Public(Default Security Level. Issues are Public) >Affects Versions: 9.1.1 >Reporter: Jan Høydahl >Assignee: Jan Høydahl >Priority: Major > Time Spent: 40m > Remaining Estimate: 0h > > 4.7% failure of the test OtelTracerConfiguratorTest. > {code:java} > org.apache.solr.opentelemetry.OtelTracerConfiguratorTest > classMethod FAILED > com.carrotsearch.randomizedtesting.ThreadLeakError: 1 thread leaked from > SUITE scope at org.apache.solr.opentelemetry.OtelTracerConfiguratorTest: > 1) Thread[id=64, name=BatchSpanProcessor_WorkerThread-1, > state=TIMED_WAITING, group=TGRP-OtelTracerConfiguratorTest] > at java.base@11.0.16/jdk.internal.misc.Unsafe.park(Native Method) > at > java.base@11.0.16/java.util.concurrent.locks.LockSupport.parkNanos(LockSupport.java:234) > at > java.base@11.0.16/java.util.concurrent.locks.AbstractQueuedSynchronizer$ConditionObject.awaitNanos(AbstractQueuedSynchronizer.java:2123) > at > java.base@11.0.16/java.util.concurrent.ArrayBlockingQueue.poll(ArrayBlockingQueue.java:432) > at > app//io.opentelemetry.sdk.trace.export.BatchSpanProcessor$Worker.run(BatchSpanProcessor.java:252) > at java.base@11.0.16/java.lang.Thread.run(Thread.java:829) > at __randomizedtesting.SeedInfo.seed([CCCE79C05B3FB703]:0) {code} > The tracer uses a BatchSpanProcessor by default, which has its own thread. It > will eventually exit, but the test fails -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
[GitHub] [solr] janhoy merged pull request #1413: SOLR-16683 Fix frequent failures of OtelTracerConfiguratorTest
janhoy merged PR #1413: URL: https://github.com/apache/solr/pull/1413 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
[GitHub] [solr] janhoy commented on pull request #1413: SOLR-16683 Fix frequent failures of OtelTracerConfiguratorTest
janhoy commented on PR #1413: URL: https://github.com/apache/solr/pull/1413#issuecomment-1452270624 > I haven't tried these changes, but its sad that the worker thread is just unmanaged and can't be shutdown. Yes, they should allow passing in an executor or otherwise control it. But Hopefully the timeouts set in the test will now cause the worker to shutdown within 10s. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
[GitHub] [solr] janhoy merged pull request #1419: Update io.prometheus:* to v0.16.0
janhoy merged PR #1419: URL: https://github.com/apache/solr/pull/1419 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
[GitHub] [solr] janhoy commented on a diff in pull request #1419: Update io.prometheus:* to v0.16.0
janhoy commented on code in PR #1419: URL: https://github.com/apache/solr/pull/1419#discussion_r1123315054 ## solr/prometheus-exporter/src/test/org/apache/solr/prometheus/exporter/SolrExporterIntegrationTest.java: ## @@ -58,7 +58,7 @@ public void solrExporterDurationMetric() throws Exception { assertTrue(durationHistogram.get("solr_exporter_duration_seconds_sum") > 0); // 17 = (15 buckets in the histogram) + (count metric) + (sum metric) -assertEquals(17, durationHistogram.size()); +assertEquals(18, durationHistogram.size()); Review Comment: Thanks for the digging, makes sense! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
[GitHub] [solr] janhoy merged pull request #1416: Update dependency org.bitbucket.b_c:jose4j to v0.9.3
janhoy merged PR #1416: URL: https://github.com/apache/solr/pull/1416 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
[jira] [Commented] (SOLR-14303) Deprecate /admin/zookeeper
[ https://issues.apache.org/jira/browse/SOLR-14303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17695767#comment-17695767 ] Jason Gerlowski commented on SOLR-14303: I think it'd probably be worth a separate JIRA - even if it's a "sub-task" or child of this one. A few questions/concerns/comments about the plan you mentioned above [~epugh]: # I think I agree in principle that pagination is secondary to filtering. It's hard for me to imagine a user with hundreds of collections paging through the collections just browsing. I imagine almost 100% of the time, users on this page are going to be looking for a particular collection based on either name or status (i.e. recovering, down, etc.). Though maybe pagination is still useful even after a filter has been applied (e.g. a user who has too many 'down' shards to display on a single screen). # How are you imagining the Graph UI would work without pagination? Would we display all the collections? Would we impose some limit, say 20, until (and maybe even after) the user provides some filter? Even assuming CLUSTERSTATUS scales well enough to not need server-side paging (which is a separate assumption that we need to double-check), the screen real-estate is still going to limit what we can show in practice, right? I'm fine with whatever approach makes the most sense to you, since you took the initiative here. Just wanted to toss out some questions in case they help clarify your thinking at all. > Deprecate /admin/zookeeper > -- > > Key: SOLR-14303 > URL: https://issues.apache.org/jira/browse/SOLR-14303 > Project: Solr > Issue Type: Bug >Reporter: Ishan Chattopadhyaya >Priority: Major > Attachments: Screenshot at Mar 01 17-26-37.png, Skjermbilde > 2023-02-17 kl. 15.49.59.png, Skjermbilde 2023-02-17 kl. 15.51.07.png, > Skjermbilde 2023-02-17 kl. 16.18.43.png > > Time Spent: 10m > Remaining Estimate: 0h > > This is a spinoff from SOLR-13942 to deprecate /admin/zookeeper and cutover > the admin UI to the new API proposed there (/cluster/zk). -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
[GitHub] [solr] risdenk commented on pull request #1402: Update dependency com.tdunning:t-digest to v3.3
risdenk commented on PR #1402: URL: https://github.com/apache/solr/pull/1402#issuecomment-1452020390 This caused these test failures so I reverted it: ``` ERROR: The following test(s) have failed: - org.apache.solr.client.solrj.io.stream.StreamExpressionTest.testSubFacetStream (:solr:solrj-streaming) Test output: /Users/risdenk/repos/apache/solr/solr/solrj-streaming/build/test-results/test/outputs/OUTPUT-org.apache.solr.client.solrj.io.stream.StreamExpressionTest.txt Reproduce with: gradlew :solr:solrj-streaming:test --tests "org.apache.solr.client.solrj.io.stream.StreamExpressionTest.testSubFacetStream" -Ptests.jvms=5 "-Ptests.jvmargs=-XX:TieredStopAtLevel=1 -XX:+UseParallelGC -XX:ActiveProcessorCount=1 -XX:ReservedCodeCacheSize=120m" -Ptests.seed=F0D3AF99EEE61E75 -Ptests.file.encoding=ISO-8859-1 - org.apache.solr.client.solrj.io.stream.StreamExpressionTest.testFacetStream (:solr:solrj-streaming) Test output: /Users/risdenk/repos/apache/solr/solr/solrj-streaming/build/test-results/test/outputs/OUTPUT-org.apache.solr.client.solrj.io.stream.StreamExpressionTest.txt Reproduce with: gradlew :solr:solrj-streaming:test --tests "org.apache.solr.client.solrj.io.stream.StreamExpressionTest.testFacetStream" -Ptests.jvms=5 "-Ptests.jvmargs=-XX:TieredStopAtLevel=1 -XX:+UseParallelGC -XX:ActiveProcessorCount=1 -XX:ReservedCodeCacheSize=120m" -Ptests.seed=F0D3AF99EEE61E75 -Ptests.file.encoding=ISO-8859-1 - org.apache.solr.client.solrj.io.stream.StreamExpressionTest.testStatsStream (:solr:solrj-streaming) Test output: /Users/risdenk/repos/apache/solr/solr/solrj-streaming/build/test-results/test/outputs/OUTPUT-org.apache.solr.client.solrj.io.stream.StreamExpressionTest.txt Reproduce with: gradlew :solr:solrj-streaming:test --tests "org.apache.solr.client.solrj.io.stream.StreamExpressionTest.testStatsStream" -Ptests.jvms=5 "-Ptests.jvmargs=-XX:TieredStopAtLevel=1 -XX:+UseParallelGC -XX:ActiveProcessorCount=1 -XX:ReservedCodeCacheSize=120m" -Ptests.seed=F0D3AF99EEE61E75 -Ptests.file.encoding=ISO-8859-1 - org.apache.solr.search.facet.DistributedFacetSimpleRefinementLongTailTest.test (:solr:core) Test output: /Users/risdenk/repos/apache/solr/solr/core/build/test-results/test/outputs/OUTPUT-org.apache.solr.search.facet.DistributedFacetSimpleRefinementLongTailTest.txt Reproduce with: gradlew :solr:core:test --tests "org.apache.solr.search.facet.DistributedFacetSimpleRefinementLongTailTest.test" -Ptests.jvms=5 "-Ptests.jvmargs=-XX:TieredStopAtLevel=1 -XX:+UseParallelGC -XX:ActiveProcessorCount=1 -XX:ReservedCodeCacheSize=120m" -Ptests.seed=F0D3AF99EEE61E75 -Ptests.file.encoding=ISO-8859-1 - org.apache.solr.search.facet.TestJsonFacets.testStatsDistrib {p0=SMART} (:solr:core) Test output: /Users/risdenk/repos/apache/solr/solr/core/build/test-results/test/outputs/OUTPUT-org.apache.solr.search.facet.TestJsonFacets.txt Reproduce with: gradlew :solr:core:test --tests "org.apache.solr.search.facet.TestJsonFacets.testStatsDistrib {p0=SMART}" -Ptests.jvms=5 "-Ptests.jvmargs=-XX:TieredStopAtLevel=1 -XX:+UseParallelGC -XX:ActiveProcessorCount=1 -XX:ReservedCodeCacheSize=120m" -Ptests.seed=F0D3AF99EEE61E75 -Ptests.file.encoding=ISO-8859-1 - org.apache.solr.search.facet.TestJsonFacets.testStats {p0=SMART} (:solr:core) Test output: /Users/risdenk/repos/apache/solr/solr/core/build/test-results/test/outputs/OUTPUT-org.apache.solr.search.facet.TestJsonFacets.txt Reproduce with: gradlew :solr:core:test --tests "org.apache.solr.search.facet.TestJsonFacets.testStats {p0=SMART}" -Ptests.jvms=5 "-Ptests.jvmargs=-XX:TieredStopAtLevel=1 -XX:+UseParallelGC -XX:ActiveProcessorCount=1 -XX:ReservedCodeCacheSize=120m" -Ptests.seed=F0D3AF99EEE61E75 -Ptests.file.encoding=ISO-8859-1 ``` I don't know if I missed this in the check of the bot results above. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
[GitHub] [solr] solrbot commented on pull request #1427: Update org.apache.curator:* to v5 (major)
solrbot commented on PR #1427: URL: https://github.com/apache/solr/pull/1427#issuecomment-1451975454 ### Renovate Ignore Notification As this PR has been closed unmerged, Renovate will ignore this upgrade and you will not receive PRs for *any* future 5.x releases. However, if you upgrade to 5.x manually then Renovate will reenable minor and patch updates automatically. If this PR was closed by mistake or you changed your mind, you can simply rename this PR and you will soon get a fresh replacement PR opened. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
[GitHub] [solr] solrbot commented on pull request #1423: Update dependency jakarta.ws.rs:jakarta.ws.rs-api to v3
solrbot commented on PR #1423: URL: https://github.com/apache/solr/pull/1423#issuecomment-1451975158 ### Renovate Ignore Notification As this PR has been closed unmerged, Renovate will ignore this upgrade and you will not receive PRs for *any* future 3.x releases. However, if you upgrade to 3.x manually then Renovate will reenable minor and patch updates automatically. If this PR was closed by mistake or you changed your mind, you can simply rename this PR and you will soon get a fresh replacement PR opened. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
[GitHub] [solr] risdenk merged pull request #1402: Update dependency com.tdunning:t-digest to v3.3
risdenk merged PR #1402: URL: https://github.com/apache/solr/pull/1402 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
[GitHub] [solr] risdenk merged pull request #1425: Update dependency org.jctools:jctools-core to v4
risdenk merged PR #1425: URL: https://github.com/apache/solr/pull/1425 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
[GitHub] [solr] risdenk commented on pull request #1428: Update org.apache.tika:* to v2 (major)
risdenk commented on PR #1428: URL: https://github.com/apache/solr/pull/1428#issuecomment-1451965938 This is a relatively big change but one we should probably do. The dependency names changed so need to take that into account. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
[GitHub] [solr] risdenk merged pull request #1420: Update org.apache.calcite:* to v1.33.0 and org.apache.calcite.avatica:* to v1.23.0
risdenk merged PR #1420: URL: https://github.com/apache/solr/pull/1420 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
[GitHub] [solr] risdenk merged pull request #1415: Update dependency org.apache.commons:commons-compress to v1.22
risdenk merged PR #1415: URL: https://github.com/apache/solr/pull/1415 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
[GitHub] [solr] risdenk merged pull request #1426: Update dependency org.semver4j:semver4j to v4
risdenk merged PR #1426: URL: https://github.com/apache/solr/pull/1426 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
[jira] [Commented] (SOLR-16441) Upgrade Jetty to 11.x
[ https://issues.apache.org/jira/browse/SOLR-16441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17695737#comment-17695737 ] Kevin Risden commented on SOLR-16441: - https://github.com/apache/solr/pull/1423 is related since it looks at upgrading to Jakarta package names. > Upgrade Jetty to 11.x > - > > Key: SOLR-16441 > URL: https://issues.apache.org/jira/browse/SOLR-16441 > Project: Solr > Issue Type: Improvement > Components: Server >Reporter: Tomas Eduardo Fernandez Lobbe >Priority: Major > > Solr is currently using Jetty 9.4.x and upgrading to Jetty 10.x in > SOLR-15955, we should look at upgrade to Jetty 11 which moves from javax to > jakarta namespace for servlet. > -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
[GitHub] [solr] risdenk closed pull request #1423: Update dependency jakarta.ws.rs:jakarta.ws.rs-api to v3
risdenk closed pull request #1423: Update dependency jakarta.ws.rs:jakarta.ws.rs-api to v3 URL: https://github.com/apache/solr/pull/1423 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
[GitHub] [solr] risdenk commented on pull request #1423: Update dependency jakarta.ws.rs:jakarta.ws.rs-api to v3
risdenk commented on PR #1423: URL: https://github.com/apache/solr/pull/1423#issuecomment-1451956369 We should look at doing this with Jetty 11 I think - https://issues.apache.org/jira/browse/SOLR-16441 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
[GitHub] [solr] risdenk commented on pull request #1423: Update dependency jakarta.ws.rs:jakarta.ws.rs-api to v3
risdenk commented on PR #1423: URL: https://github.com/apache/solr/pull/1423#issuecomment-1451955702 Yea this is going to be a big change - https://github.com/jakartaee/rest/releases -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
[GitHub] [solr] risdenk commented on pull request #1414: Update dependency org.apache.calcite.avatica:avatica-core to v1.23.0
risdenk commented on PR #1414: URL: https://github.com/apache/solr/pull/1414#issuecomment-1451943314 Opened https://github.com/apache/solr/pull/1429 to combine them into a group -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
[GitHub] [solr] risdenk opened a new pull request, #1429: Renovate tweaks
risdenk opened a new pull request, #1429: URL: https://github.com/apache/solr/pull/1429 * Group together Apache Calcite and Apache Calcite Avatica * Use `matchPackagePrefixes` instead of regex * Add google cloud to monthly checks like AWS SDK -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
[GitHub] [solr] risdenk commented on a diff in pull request #1419: Update io.prometheus:* to v0.16.0
risdenk commented on code in PR #1419: URL: https://github.com/apache/solr/pull/1419#discussion_r1123160738 ## solr/prometheus-exporter/src/test/org/apache/solr/prometheus/exporter/SolrExporterIntegrationTest.java: ## @@ -58,7 +58,7 @@ public void solrExporterDurationMetric() throws Exception { assertTrue(durationHistogram.get("solr_exporter_duration_seconds_sum") > 0); // 17 = (15 buckets in the histogram) + (count metric) + (sum metric) Review Comment: Comment should be updated with `_created` metric. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
[GitHub] [solr] risdenk commented on a diff in pull request #1419: Update io.prometheus:* to v0.16.0
risdenk commented on code in PR #1419: URL: https://github.com/apache/solr/pull/1419#discussion_r1123160314 ## solr/prometheus-exporter/src/test/org/apache/solr/prometheus/exporter/SolrExporterIntegrationTest.java: ## @@ -58,7 +58,7 @@ public void solrExporterDurationMetric() throws Exception { assertTrue(durationHistogram.get("solr_exporter_duration_seconds_sum") > 0); // 17 = (15 buckets in the histogram) + (count metric) + (sum metric) -assertEquals(17, durationHistogram.size()); +assertEquals(18, durationHistogram.size()); Review Comment: Ah bingo: * https://github.com/prometheus/client_java/pull/615 which came in as part of https://github.com/prometheus/client_java/releases/tag/parent-0.10.0 There is https://github.com/prometheus/client_java/releases/tag/parent-0.16.0 which has https://github.com/prometheus/client_java/pull/791 * https://github.com/prometheus/client_java/tree/main#disabling-_created-metrics I don't think this is an issue and just updating the count makes sense. The comment should be updated though. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
[GitHub] [solr] risdenk commented on a diff in pull request #1419: Update io.prometheus:* to v0.16.0
risdenk commented on code in PR #1419: URL: https://github.com/apache/solr/pull/1419#discussion_r1123156164 ## solr/prometheus-exporter/src/test/org/apache/solr/prometheus/exporter/SolrExporterIntegrationTest.java: ## @@ -58,7 +58,7 @@ public void solrExporterDurationMetric() throws Exception { assertTrue(durationHistogram.get("solr_exporter_duration_seconds_sum") > 0); // 17 = (15 buckets in the histogram) + (count metric) + (sum metric) -assertEquals(17, durationHistogram.size()); +assertEquals(18, durationHistogram.size()); Review Comment: I think this is `solr_exporter_duration_seconds_created` but I don't know where it came from right now. These are all the durationHistogram keys ``` [solr_exporter_duration_seconds_bucket{le="+Inf",}, solr_exporter_duration_seconds_bucket{le="0.005",}, solr_exporter_duration_seconds_bucket{le="0.01",}, solr_exporter_duration_seconds_bucket{le="0.025",}, solr_exporter_duration_seconds_bucket{le="0.05",}, solr_exporter_duration_seconds_bucket{le="0.075",}, solr_exporter_duration_seconds_bucket{le="0.1",}, solr_exporter_duration_seconds_bucket{le="0.25",}, solr_exporter_duration_seconds_bucket{le="0.5",}, solr_exporter_duration_seconds_bucket{le="0.75",}, solr_exporter_duration_seconds_bucket{le="1.0",}, solr_exporter_duration_seconds_bucket{le="10.0",}, solr_exporter_duration_seconds_bucket{le="2.5",}, solr_exporter_duration_seconds_bucket{le="5.0",}, solr_exporter_duration_seconds_bucket{le="7.5",}, solr_exporter_duration_seconds_count, solr_exporter_duration_seconds_created, solr_exporter_duration_seconds_sum] ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
[GitHub] [solr] risdenk commented on pull request #1415: Update dependency org.apache.commons:commons-compress to v1.22
risdenk commented on PR #1415: URL: https://github.com/apache/solr/pull/1415#issuecomment-1451916349 It is used in `solr/modules/hdfs/src/test/org/apache/hadoop/fs/FileUtil.java` which is part of Hadoop code for testing. We copied it in to avoid security manager issues. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
[GitHub] [solr] risdenk commented on pull request #1427: Update org.apache.curator:* to v5 (major)
risdenk commented on PR #1427: URL: https://github.com/apache/solr/pull/1427#issuecomment-1451904870 I wouldn't upgrade this until Hadoop upgrades. We pull this in in hadoop-auth currently: ``` # git grep -F curator **/build.gradle solr/modules/hadoop-auth/build.gradle: implementation 'org.apache.curator:curator-client' solr/modules/hadoop-auth/build.gradle: implementation 'org.apache.curator:curator-framework' solr/modules/hadoop-auth/build.gradle: runtimeOnly 'org.apache.curator:curator-recipes' ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
[GitHub] [solr] risdenk closed pull request #1427: Update org.apache.curator:* to v5 (major)
risdenk closed pull request #1427: Update org.apache.curator:* to v5 (major) URL: https://github.com/apache/solr/pull/1427 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
[GitHub] [solr] risdenk merged pull request #1390: Update dependency org.xerial.snappy:snappy-java to v1.1.9.1
risdenk merged PR #1390: URL: https://github.com/apache/solr/pull/1390 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
[GitHub] [solr-operator] samuelverstraete commented on issue #483: Servicemonitor for prometheus exporter is referring to cluster port instead of metrics pod port
samuelverstraete commented on issue #483: URL: https://github.com/apache/solr-operator/issues/483#issuecomment-1451884676 We have exactly the same issue. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
[GitHub] [solr] risdenk commented on pull request #1414: Update dependency org.apache.calcite.avatica:avatica-core to v1.23.0
risdenk commented on PR #1414: URL: https://github.com/apache/solr/pull/1414#issuecomment-1451883310 > We could define a custom "group" in renovate.json to define these two to be grouped in same PR in the future, like with httpcomponents. @janhoy that would be awesome -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
[GitHub] [solr] risdenk commented on pull request #1416: Update dependency org.bitbucket.b_c:jose4j to v0.9.3
risdenk commented on PR #1416: URL: https://github.com/apache/solr/pull/1416#issuecomment-1451881735 @janhoy you probably want to look closer at this one. jose4j has been a rough upgrade from what I remember in the past from other projects. At least make sure this doesn't subtly break jwt-auth. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
[GitHub] [solr] risdenk merged pull request #1421: Update org.apache.logging.log4j:* to v2.20.0
risdenk merged PR #1421: URL: https://github.com/apache/solr/pull/1421 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
[GitHub] [solr] risdenk merged pull request #1417: Update dependency org.openjdk.jmh:jmh-core to v1.36
risdenk merged PR #1417: URL: https://github.com/apache/solr/pull/1417 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
[GitHub] [solr] vinayakphegde commented on a diff in pull request #1360: SOLR 16642 : upgrade Solr to use Lucene 9.5.0
vinayakphegde commented on code in PR #1360: URL: https://github.com/apache/solr/pull/1360#discussion_r1122863133 ## solr/core/src/java/org/apache/solr/core/MMapDirectoryFactory.java: ## @@ -63,7 +63,7 @@ protected Directory create(String path, LockFactory lockFactory, DirContext dirC throws IOException { MMapDirectory mapDirectory = new MMapDirectory(Path.of(path), lockFactory, maxChunk); try { - mapDirectory.setUseUnmap(unmapHack); + System.setProperty(MMapDirectory.ENABLE_UNMAP_HACK_SYSPROP, String.valueOf(unmapHack)); Review Comment: Okay, will remove the `unmapHack` references. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org