Re: [PR] SOLR-17321: Remove Deprecated URL API in Preparation for Java 21 [solr]
iamsanjay commented on PR #2501: URL: https://github.com/apache/solr/pull/2501#issuecomment-2157166055 All the usages of `new URL` (except one) has been replaced with `URI.create(url).toURL()`. The exception was one specific case which is testing the presence of caret in the URL as It was an old issues (https://issues.apache.org/jira/browse/SOLR-5971) that failed due to the caret. Now replacing it with new Syntax fails because caret is in the disallowed list for URI and thus failed. I do not want to encode the character, because the whole point of test is to test caret without encoding it, instead I used `@SuppressForbidden`. Because #2497 is still in progress, So, meanwhile, I added "new URL" to the forbidden api to make sure no one would use it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
Re: [PR] force the use jdk21 through Crave [solr]
iamsanjay commented on PR #2498: URL: https://github.com/apache/solr/pull/2498#issuecomment-2157150820 If crave.yml change the Java version to 21, `gradlew check` should fail, more specifically the `ecj-lint` version that we are currently using make sure the Java version should be less than or equal to 19. > Task :solr:api:ecjLintMain FAILED > source level should be in '1.1'...'1.8','9'...'19' (or '5.0'..'19.0'): 21 And, `dependancy-analyze` task should also fail which we have disabled in #2497 just to make it run. > Task :solr:modules:scripting:analyzeTestClassesDependencies > Dependency analysis found issues. > unusedDeclaredArtifacts > - org.apache.solr:test-framework:10.0.0-SNAPSHOT@ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
Re: [PR] SOLR-17321: Bump minimum required Java version to 21 [solr]
iamsanjay commented on PR #2497:
URL: https://github.com/apache/solr/pull/2497#issuecomment-2157143107
Setting different Java version for main and SolrJ resulting in error.
Currently, `:solr:api:ecjLintTest ` task is failing and below is the error.
```
> Task :solr:api:ecjLintTest
--
1. ERROR in
/Users/sanjaydutt/Documents/Solr/solr-main/solr/solr/api/src/test/org/apache/solr/util/TestSolrVersion.java
(at line 19)
import org.apache.solr.SolrTestCase;
The import org.apache.solr.SolrTestCase cannot be resolved
--
2. ERROR in
/Users/sanjaydutt/Documents/Solr/solr-main/solr/solr/api/src/test/org/apache/solr/util/TestSolrVersion.java
(at line 23)
public class TestSolrVersion extends SolrTestCase {
SolrTestCase cannot be resolved to a type
```
The api test cases not able to access the class, `SolrTestClass`, from the
main branch. Further, I logged the java version that has been used to
configure SolrJ via adding println statements.
`ecj-lint.gradle`
```
allprojects {
plugins.withType(JavaPlugin) {
// Create a [sourceSetName]EcjLint task for each source set
// with a non-empty java.srcDirs. These tasks are then
// attached to project's "ecjLint" task.
println "The project name is " + project + " and the sourceCompatibility
is " + project.sourceCompatibility
def lintTasks = sourceSets.collect { sourceSet ->
def srcDirs = sourceSet.java.srcDirs.findAll { dir -> dir.exists() }
tasks.create(sourceSet.getTaskName("ecjLint", null), JavaExec, {task ->
...
```
**Output**
```
> Configure project :solr:server
The project name is project ':solr:server' and the sourceCompatibility is 21
> Configure project :solr:core
The project name is project ':solr:core' and the sourceCompatibility is 21
> Configure project :solr:api
The project name is project ':solr:api' and the sourceCompatibility is 17
> Configure project :solr:solrj
The project name is project ':solr:solrj' and the sourceCompatibility is 17
```
The version has changed for SolrJ and for api as well. However, as @dsmiley
pointed out before that test classes for both of these project should point to
21. Still looking for a way How we can achieve that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
[jira] [Resolved] (SOLR-17315) Bug in messaging when creating a collection, and then you can't actually call the config method to set-user-property
[
https://issues.apache.org/jira/browse/SOLR-17315?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Eric Pugh resolved SOLR-17315.
--
Fix Version/s: 9.7
Resolution: Fixed
> Bug in messaging when creating a collection, and then you can't actually call
> the config method to set-user-property
>
>
> Key: SOLR-17315
> URL: https://issues.apache.org/jira/browse/SOLR-17315
> Project: Solr
> Issue Type: Sub-task
> Components: cli
>Affects Versions: 9.6
>Reporter: Eric Pugh
>Assignee: Eric Pugh
>Priority: Minor
> Fix For: 9.7
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> I made a collection, and noticed the default message doesn't format properly:
>
> {{{
> bin/solr create -c stuff
> Neither -zkHost or -solrUrl parameters provided so assuming solrUrl is
> http://localhost:8983.
> Neither -zkHost or -solrUrl parameters provided so assuming solrUrl is
> http://localhost:8983.
> WARN - 2024-05-29 13:48:32.981; org.apache.solr.common.cloud.SolrZkClient;
> Using default ZkCredentialsInjector. ZkCredentialsInjector is not secure, it
> creates an empty list of credentials which leads to 'OPEN_ACL_UNSAFE' ACLs to
> Zookeeper nodes
> WARN - 2024-05-29 13:48:33.049; org.apache.solr.common.cloud.SolrZkClient;
> Using default ZkACLProvider. DefaultZkACLProvider is not secure, it creates
> 'OPEN_ACL_UNSAFE' ACLs to Zookeeper nodes
> WARNING: Using _default configset. Data driven schema functionality is
> enabled by default, which is
> NOT RECOMMENDED for production use.
> To turn it off:
> curl http://localhost:8983/null/config -d '\{"set-user-property":
> {"update.autoCreateFields":"false"}}'
> Or:
> bin/solr config -c null -p 8983 -action set-user-property
> -property update.autoCreateFields -value false
> }}}
>
> -c null is wrong. Also, on main, the -p didn't work!
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
[jira] [Commented] (SOLR-17109) solr.sharedLib should be explicitly added to the security policy with read access
[ https://issues.apache.org/jira/browse/SOLR-17109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17853528#comment-17853528 ] ASF subversion and git services commented on SOLR-17109: Commit b7f6be0f62dc7b0e8d1a910d74c903f5bcfe0298 in solr's branch refs/heads/branch_9x from Tomas Eduardo Fernandez Lobbe [ https://gitbox.apache.org/repos/asf?p=solr.git;h=b7f6be0f62d ] SOLR-17109: Give security manager explicit read access to sharedLib (#2172) Co-authored-by: Eric Pugh > solr.sharedLib should be explicitly added to the security policy with read > access > - > > Key: SOLR-17109 > URL: https://issues.apache.org/jira/browse/SOLR-17109 > Project: Solr > Issue Type: Improvement > Components: security >Reporter: Tomas Eduardo Fernandez Lobbe >Assignee: Eric Pugh >Priority: Minor > Time Spent: 2h 20m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
[jira] [Resolved] (SOLR-17109) solr.sharedLib should be explicitly added to the security policy with read access
[ https://issues.apache.org/jira/browse/SOLR-17109?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eric Pugh resolved SOLR-17109. -- Fix Version/s: 9.7 Resolution: Fixed thanks! > solr.sharedLib should be explicitly added to the security policy with read > access > - > > Key: SOLR-17109 > URL: https://issues.apache.org/jira/browse/SOLR-17109 > Project: Solr > Issue Type: Improvement > Components: security >Reporter: Tomas Eduardo Fernandez Lobbe >Assignee: Eric Pugh >Priority: Minor > Fix For: 9.7 > > Time Spent: 2h 20m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
[jira] [Commented] (SOLR-17109) solr.sharedLib should be explicitly added to the security policy with read access
[ https://issues.apache.org/jira/browse/SOLR-17109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17853527#comment-17853527 ] ASF subversion and git services commented on SOLR-17109: Commit baabca56f9cca9d967bda230fb454ae9f55f5289 in solr's branch refs/heads/main from Tomas Eduardo Fernandez Lobbe [ https://gitbox.apache.org/repos/asf?p=solr.git;h=baabca56f9c ] SOLR-17109: Give security manager explicit read access to sharedLib (#2172) Co-authored-by: Eric Pugh > solr.sharedLib should be explicitly added to the security policy with read > access > - > > Key: SOLR-17109 > URL: https://issues.apache.org/jira/browse/SOLR-17109 > Project: Solr > Issue Type: Improvement > Components: security >Reporter: Tomas Eduardo Fernandez Lobbe >Assignee: Eric Pugh >Priority: Minor > Time Spent: 2h 20m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
Re: [PR] SOLR-17109: Give security manager explicit read access to sharedLib [solr]
epugh merged PR #2172: URL: https://github.com/apache/solr/pull/2172 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
[jira] [Commented] (SOLR-17315) Bug in messaging when creating a collection, and then you can't actually call the config method to set-user-property
[
https://issues.apache.org/jira/browse/SOLR-17315?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17853526#comment-17853526
]
ASF subversion and git services commented on SOLR-17315:
Commit 241617dac5d2777423d63706e64b8b002efab659 in solr's branch
refs/heads/branch_9x from Eric Pugh
[ https://gitbox.apache.org/repos/asf?p=solr.git;h=241617dac5d ]
SOLR-17315: Fix message formatting (#2511)
> Bug in messaging when creating a collection, and then you can't actually call
> the config method to set-user-property
>
>
> Key: SOLR-17315
> URL: https://issues.apache.org/jira/browse/SOLR-17315
> Project: Solr
> Issue Type: Sub-task
> Components: cli
>Affects Versions: 9.6
>Reporter: Eric Pugh
>Assignee: Eric Pugh
>Priority: Minor
> Time Spent: 20m
> Remaining Estimate: 0h
>
> I made a collection, and noticed the default message doesn't format properly:
>
> {{{
> bin/solr create -c stuff
> Neither -zkHost or -solrUrl parameters provided so assuming solrUrl is
> http://localhost:8983.
> Neither -zkHost or -solrUrl parameters provided so assuming solrUrl is
> http://localhost:8983.
> WARN - 2024-05-29 13:48:32.981; org.apache.solr.common.cloud.SolrZkClient;
> Using default ZkCredentialsInjector. ZkCredentialsInjector is not secure, it
> creates an empty list of credentials which leads to 'OPEN_ACL_UNSAFE' ACLs to
> Zookeeper nodes
> WARN - 2024-05-29 13:48:33.049; org.apache.solr.common.cloud.SolrZkClient;
> Using default ZkACLProvider. DefaultZkACLProvider is not secure, it creates
> 'OPEN_ACL_UNSAFE' ACLs to Zookeeper nodes
> WARNING: Using _default configset. Data driven schema functionality is
> enabled by default, which is
> NOT RECOMMENDED for production use.
> To turn it off:
> curl http://localhost:8983/null/config -d '\{"set-user-property":
> {"update.autoCreateFields":"false"}}'
> Or:
> bin/solr config -c null -p 8983 -action set-user-property
> -property update.autoCreateFields -value false
> }}}
>
> -c null is wrong. Also, on main, the -p didn't work!
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
[jira] [Commented] (SOLR-17315) Bug in messaging when creating a collection, and then you can't actually call the config method to set-user-property
[
https://issues.apache.org/jira/browse/SOLR-17315?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17853525#comment-17853525
]
ASF subversion and git services commented on SOLR-17315:
Commit 99a9b10feb0a704dcda802a8e53a7e45be39cbd8 in solr's branch
refs/heads/main from Eric Pugh
[ https://gitbox.apache.org/repos/asf?p=solr.git;h=99a9b10feb0 ]
SOLR-17315: Fix message formatting (#2511)
> Bug in messaging when creating a collection, and then you can't actually call
> the config method to set-user-property
>
>
> Key: SOLR-17315
> URL: https://issues.apache.org/jira/browse/SOLR-17315
> Project: Solr
> Issue Type: Sub-task
> Components: cli
>Affects Versions: 9.6
>Reporter: Eric Pugh
>Assignee: Eric Pugh
>Priority: Minor
> Time Spent: 20m
> Remaining Estimate: 0h
>
> I made a collection, and noticed the default message doesn't format properly:
>
> {{{
> bin/solr create -c stuff
> Neither -zkHost or -solrUrl parameters provided so assuming solrUrl is
> http://localhost:8983.
> Neither -zkHost or -solrUrl parameters provided so assuming solrUrl is
> http://localhost:8983.
> WARN - 2024-05-29 13:48:32.981; org.apache.solr.common.cloud.SolrZkClient;
> Using default ZkCredentialsInjector. ZkCredentialsInjector is not secure, it
> creates an empty list of credentials which leads to 'OPEN_ACL_UNSAFE' ACLs to
> Zookeeper nodes
> WARN - 2024-05-29 13:48:33.049; org.apache.solr.common.cloud.SolrZkClient;
> Using default ZkACLProvider. DefaultZkACLProvider is not secure, it creates
> 'OPEN_ACL_UNSAFE' ACLs to Zookeeper nodes
> WARNING: Using _default configset. Data driven schema functionality is
> enabled by default, which is
> NOT RECOMMENDED for production use.
> To turn it off:
> curl http://localhost:8983/null/config -d '\{"set-user-property":
> {"update.autoCreateFields":"false"}}'
> Or:
> bin/solr config -c null -p 8983 -action set-user-property
> -property update.autoCreateFields -value false
> }}}
>
> -c null is wrong. Also, on main, the -p didn't work!
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
Re: [PR] SOLR-17315: Fix message formatting [solr]
epugh merged PR #2511: URL: https://github.com/apache/solr/pull/2511 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
[jira] [Created] (SOLR-17327) Update bats test to remove /solr from solr Urls.
Eric Pugh created SOLR-17327: Summary: Update bats test to remove /solr from solr Urls. Key: SOLR-17327 URL: https://issues.apache.org/jira/browse/SOLR-17327 Project: Solr Issue Type: Sub-task Components: cli Reporter: Eric Pugh For all the bats tests Except where it matters, remove the /solr context path from the various --solr-url's. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
[PR] Update dependency com.carrotsearch:hppc to v0.10.0 [solr]
solrbot opened a new pull request, #2512:
URL: https://github.com/apache/solr/pull/2512
This PR contains the following updates:
| Package | Type | Update | Change |
|---|---|---|---|
| [com.carrotsearch:hppc](https://togithub.com/carrotsearch/hppc) |
dependencies | minor | `0.9.1` -> `0.10.0` |
---
### Release Notes
carrotsearch/hppc (com.carrotsearch:hppc)
### [`v0.10.0`](https://togithub.com/carrotsearch/hppc/releases/tag/0.10.0)
[Compare
Source](https://togithub.com/carrotsearch/hppc/compare/0.9.1...0.10.0)
This release adds a few utility methods and fixes a few problems with
clashing method names (remove). This release is not backward compatible: it's
likely you will have to update your code (remove method renamed to
removeElement or removeAt, depending on the semantics, dropped WormMap and
WormSet classes).
This release requires Java 11 or higher to run.
Resolved issues:
https://github.com/carrotsearch/hppc/milestone/4?closed=1
JavaDoc:
http://carrotsearch.github.io/hppc/releases/0.10.0/api/
New features and API changes
- [GH-250](https://togithub.com/carrotsearch/hppc/issues/250): Add
KTypeIndexedContainer stream, sort and reverse methods. (Bruno Roustant)
- [GH-247](https://togithub.com/carrotsearch/hppc/issues/247): Add
KTypeArrayList removeAt and rename remove to removeElement. (Bruno Roustant)
- [GH-244](https://togithub.com/carrotsearch/hppc/issues/244): Hide
RamUsageEstimator from the public API. (Dawid Weiss)
- [GH-239](https://togithub.com/carrotsearch/hppc/issues/239): Minimum
Java bumped to 11 (from 8). (Dawid Weiss)
- [GH-235](https://togithub.com/carrotsearch/hppc/issues/235): Drop
WormMap and WormSet. (Bruno Roustant).
Improvements
- [GH-248](https://togithub.com/carrotsearch/hppc/issues/248): List
constructor creates a buffer with capacity exactly the expected number of
elements. (Bruno Roustant)
\*\* Bugs
- [GH-237](https://togithub.com/carrotsearch/hppc/issues/237): Fix HashMap
put/remove returned value for empty key after clear. (Bruno Roustant)
---
### Configuration
📅 **Schedule**: Branch creation - "* * * * 0" (UTC), Automerge - At any time
(no schedule defined).
🚦 **Automerge**: Disabled by config. Please merge this manually once you are
satisfied.
♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry
checkbox.
🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.
---
- [ ] If you want to rebase/retry this PR, check this
box
---
This PR has been generated by [Renovate
Bot](https://togithub.com/solrbot/renovate-github-action)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
[jira] [Assigned] (SOLR-16875) Resolve Fate of bin/post and the SimplePostTool code base.
[ https://issues.apache.org/jira/browse/SOLR-16875?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eric Pugh reassigned SOLR-16875: Assignee: Eric Pugh > Resolve Fate of bin/post and the SimplePostTool code base. > -- > > Key: SOLR-16875 > URL: https://issues.apache.org/jira/browse/SOLR-16875 > Project: Solr > Issue Type: Sub-task > Components: cli >Affects Versions: main (10.0) >Reporter: Eric Pugh >Assignee: Eric Pugh >Priority: Major > > Following up from SOLR-6994, we still generate a post.jar as a separate > artifact, and we now have competing PostTool.java and SimplePostTool.java. > Get consensus on the future of the post.jar in 10x? -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
[PR] SOLR-17315: Fix message formatting, and introduce v2 api for curl command [solr]
epugh opened a new pull request, #2511: URL: https://github.com/apache/solr/pull/2511 https://issues.apache.org/jira/browse/SOLR-17315 # Description Fix the issue that when you create a collection, the post create message gives some example commands that are not formatted properly. # Solution Use the correct parameter for getting the name of the collection, remove the -p parameter that is no longer used, and suggest users use v2 config api. # Tests manual # Checklist Please review the following and check all that apply: - [ ] I have reviewed the guidelines for [How to Contribute](https://github.com/apache/solr/blob/main/CONTRIBUTING.md) and my code conforms to the standards described there to the best of my ability. - [ ] I have created a Jira issue and added the issue ID to my pull request title. - [ ] I have given Solr maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended) - [ ] I have developed this patch against the `main` branch. - [ ] I have run `./gradlew check`. - [ ] I have added tests for my changes. - [ ] I have added documentation for the [Reference Guide](https://github.com/apache/solr/tree/main/solr/solr-ref-guide) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
[jira] [Assigned] (SOLR-17109) solr.sharedLib should be explicitly added to the security policy with read access
[ https://issues.apache.org/jira/browse/SOLR-17109?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eric Pugh reassigned SOLR-17109: Assignee: Eric Pugh > solr.sharedLib should be explicitly added to the security policy with read > access > - > > Key: SOLR-17109 > URL: https://issues.apache.org/jira/browse/SOLR-17109 > Project: Solr > Issue Type: Improvement > Components: security >Reporter: Tomas Eduardo Fernandez Lobbe >Assignee: Eric Pugh >Priority: Minor > Time Spent: 2h 10m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
Re: [PR] SOLR-17109: Give security manager explicit read access to sharedLib [solr]
epugh commented on PR #2172: URL: https://github.com/apache/solr/pull/2172#issuecomment-2156625490 https://issues.apache.org/jira/browse/SOLR-17109 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
Re: [PR] SOLR-17109: Give security manager explicit read access to sharedLib [solr]
epugh commented on PR #2172: URL: https://github.com/apache/solr/pull/2172#issuecomment-2156625293 I wish we had some bats style tests for these things ;-). I'm going to merge this when the tests finish. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
Re: [PR] fix documentation for cbor response writer. The parameter used in cod… [solr]
epugh merged PR #2509: URL: https://github.com/apache/solr/pull/2509 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
Re: [PR] fix documentation for cbor response writer. The parameter used in cod… [solr]
epugh commented on PR #2509: URL: https://github.com/apache/solr/pull/2509#issuecomment-2156614773 thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
Re: [PR] Introduce support for Reciprocal Rank Fusion (combining queries) [solr]
alessandrobenedetti commented on code in PR #2489:
URL: https://github.com/apache/solr/pull/2489#discussion_r1632230094
##
solr/solrj/src/java/org/apache/solr/common/params/CombinerParams.java:
##
@@ -0,0 +1,36 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.solr.common.params;
+
+/** Defines the request parameters used by all combiners. */
+public interface CombinerParams {
+ String COMBINER = "combiner";
+
+ String COMBINER_ALGORITHM = COMBINER + ".algorithm";
+
+ String COMBINER_KEYS = COMBINER + ".keys";
Review Comment:
m, I do believe it can be useful to have a "query key", especially
because the debug component explains both the query parsing and combination:
0.032522473 =
1/(60+1) + 1/(60+2) because its ranks were: 1 for query(lexical), 2 for
query(lexical2)
So the keys help in my opinion.
If you were referring to this specific parameter, this is not intended for
the user, it gets used automatically by Solr.
Happy to elaborate!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
Re: [PR] Introduce support for Reciprocal Rank Fusion (combining queries) [solr]
alessandrobenedetti commented on code in PR #2489:
URL: https://github.com/apache/solr/pull/2489#discussion_r1632229605
##
solr/core/src/java/org/apache/solr/handler/component/QueryComponent.java:
##
@@ -173,22 +175,51 @@ public void prepare(ResponseBuilder rb) throws
IOException {
// get it from the response builder to give a different component a chance
// to set it.
-String queryString = rb.getQueryString();
-if (queryString == null) {
- // this is the normal way it's set.
- queryString = params.get(CommonParams.Q);
- rb.setQueryString(queryString);
+List unparsedQueries;
+rb.isCombined = params.getBool(CombinerParams.COMBINER, false);
+if (rb.isCombinedSearch()) {
+ String[] queriesToCombineKeys =
params.getParams(CombinerParams.COMBINER_KEYS);
+ unparsedQueries = new ArrayList<>(queriesToCombineKeys.length);
+ rb.queriesCombiningStrategy = QueriesCombiner.getImplementation(params);
+ for (String queryKey : queriesToCombineKeys) {
+unparsedQueries.add(params.get(queryKey));
+ }
+} else {
+ unparsedQueries = new ArrayList<>(1);
Review Comment:
Done, coming in next commit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
Re: [PR] Introduce support for Reciprocal Rank Fusion (combining queries) [solr]
alessandrobenedetti commented on code in PR #2489:
URL: https://github.com/apache/solr/pull/2489#discussion_r1632229302
##
solr/core/src/java/org/apache/solr/search/combining/QueriesCombiner.java:
##
@@ -0,0 +1,92 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.solr.search.combining;
+
+import static
org.apache.solr.common.params.CombinerParams.RECIPROCAl_RANK_FUSION;
+
+import java.io.IOException;
+import java.util.List;
+import org.apache.lucene.search.Explanation;
+import org.apache.lucene.search.Query;
+import org.apache.solr.common.SolrException;
+import org.apache.solr.common.params.CombinerParams;
+import org.apache.solr.common.params.SolrParams;
+import org.apache.solr.common.util.NamedList;
+import org.apache.solr.schema.IndexSchema;
+import org.apache.solr.search.DocList;
+import org.apache.solr.search.QueryResult;
+import org.apache.solr.search.SolrIndexSearcher;
+
+/**
+ * Combining considers two or more query rankedLists: resultA, resultB ...
+ * For a given query, each query result is a ranked list of documents La =
(a1,a2,...), Lb = (b1,
+ * b2, ...)...
+ * A combining algorithm creates a unique ranked list I = (i1, i2, ...).
+ * This list is created by combining elements from the lists la and lb as
described by the
+ * implementation algorithm.
+ */
+public abstract class QueriesCombiner {
+
+ protected int upTo;
+
+ public QueriesCombiner(SolrParams requestParams) {
+this.upTo =
+requestParams.getInt(CombinerParams.COMBINER_UP_TO,
CombinerParams.COMBINER_UP_TO_DEFAULT);
+ }
+
+ public abstract QueryResult combine(QueryResult[] rankedLists);
+
+ QueryResult initCombinedResult(QueryResult[] rankedLists) {
Review Comment:
done, coming in next commit!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
Re: [PR] Introduce support for Reciprocal Rank Fusion (combining queries) [solr]
alessandrobenedetti commented on code in PR #2489:
URL: https://github.com/apache/solr/pull/2489#discussion_r1632229327
##
solr/core/src/java/org/apache/solr/search/combining/QueriesCombiner.java:
##
@@ -0,0 +1,92 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.solr.search.combining;
+
+import static
org.apache.solr.common.params.CombinerParams.RECIPROCAl_RANK_FUSION;
+
+import java.io.IOException;
+import java.util.List;
+import org.apache.lucene.search.Explanation;
+import org.apache.lucene.search.Query;
+import org.apache.solr.common.SolrException;
+import org.apache.solr.common.params.CombinerParams;
+import org.apache.solr.common.params.SolrParams;
+import org.apache.solr.common.util.NamedList;
+import org.apache.solr.schema.IndexSchema;
+import org.apache.solr.search.DocList;
+import org.apache.solr.search.QueryResult;
+import org.apache.solr.search.SolrIndexSearcher;
+
+/**
+ * Combining considers two or more query rankedLists: resultA, resultB ...
+ * For a given query, each query result is a ranked list of documents La =
(a1,a2,...), Lb = (b1,
+ * b2, ...)...
+ * A combining algorithm creates a unique ranked list I = (i1, i2, ...).
+ * This list is created by combining elements from the lists la and lb as
described by the
+ * implementation algorithm.
+ */
+public abstract class QueriesCombiner {
Review Comment:
done, coming in next commit!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
