[jira] [Commented] (TEZ-4103) Progress in DAG, Vertex, and tasks is incorrect
[ https://issues.apache.org/jira/browse/TEZ-4103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16988265#comment-16988265 ] TezQA commented on TEZ-4103: | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 19s{color} | {color:blue} Docker mode activated. {color} | || || || || {color:brown} Prechecks {color} || | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | | {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m 0s{color} | {color:green} The patch appears to include 1 new or modified test files. {color} | || || || || {color:brown} master Compile Tests {color} || | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 19s{color} | {color:blue} Maven dependency ordering for branch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m 32s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 42s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m 41s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m 47s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 49s{color} | {color:green} master passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 20s{color} | {color:blue} Maven dependency ordering for patch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m 43s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 42s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m 42s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 22s{color} | {color:green} tez-api: The patch generated 0 new + 8 unchanged - 6 fixed = 8 total (was 14) {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 20s{color} | {color:green} The patch passed checkstyle in tez-runtime-internals {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 22s{color} | {color:green} The patch passed checkstyle in tez-mapreduce {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 35s{color} | {color:green} tez-dag: The patch generated 0 new + 397 unchanged - 1 fixed = 397 total (was 398) {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 3m 19s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 48s{color} | {color:green} the patch passed {color} | || || || || {color:brown} Other Tests {color} || | {color:green}+1{color} | {color:green} unit {color} | {color:green} 1m 51s{color} | {color:green} tez-api in the patch passed. {color} | | {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m 48s{color} | {color:green} tez-runtime-internals in the patch passed. {color} | | {color:green}+1{color} | {color:green} unit {color} | {color:green} 1m 12s{color} | {color:green} tez-mapreduce in the patch passed. {color} | | {color:green}+1{color} | {color:green} unit {color} | {color:green} 3m 50s{color} | {color:green} tez-dag in the patch passed. {color} | | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 1m 17s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 33m 53s{color} | {color:black} {color} | \\ \\ || Subsystem || Report/Notes || | Docker | Client=19.03.5 Server=19.03.5 Image:yetus/tez:d4a62deee | | JIRA Issue | TEZ-4103 | | JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12987502/TEZ-4103.006.patch | | Optional Tests | dupname asflicense javac javadoc unit findbugs checkstyle compile | | uname | Linux 8597b7820706 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | /testptch/patchprocess/precommit/personality/provided.sh | | git revision | master / 1af0897 | | maven | version: Apache Maven 3.3.9 | | Default Java | 1.8.0_222 |
[jira] [Commented] (TEZ-4103) Progress in DAG, Vertex, and tasks is incorrect
[ https://issues.apache.org/jira/browse/TEZ-4103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16988208#comment-16988208 ] TezQA commented on TEZ-4103: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 21s{color} | {color:blue} Docker mode activated. {color} | || || || || {color:brown} Prechecks {color} || | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | | {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m 0s{color} | {color:green} The patch appears to include 1 new or modified test files. {color} | || || || || {color:brown} master Compile Tests {color} || | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 23s{color} | {color:blue} Maven dependency ordering for branch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m 37s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 42s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m 42s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m 49s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 51s{color} | {color:green} master passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 20s{color} | {color:blue} Maven dependency ordering for patch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m 45s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 43s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m 43s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 23s{color} | {color:green} tez-api: The patch generated 0 new + 8 unchanged - 6 fixed = 8 total (was 14) {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 21s{color} | {color:green} The patch passed checkstyle in tez-runtime-internals {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 21s{color} | {color:green} The patch passed checkstyle in tez-mapreduce {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 37s{color} | {color:green} tez-dag: The patch generated 0 new + 397 unchanged - 1 fixed = 397 total (was 398) {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 3m 21s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 53s{color} | {color:green} the patch passed {color} | || || || || {color:brown} Other Tests {color} || | {color:green}+1{color} | {color:green} unit {color} | {color:green} 1m 50s{color} | {color:green} tez-api in the patch passed. {color} | | {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m 48s{color} | {color:green} tez-runtime-internals in the patch passed. {color} | | {color:green}+1{color} | {color:green} unit {color} | {color:green} 1m 13s{color} | {color:green} tez-mapreduce in the patch passed. {color} | | {color:red}-1{color} | {color:red} unit {color} | {color:red} 5m 29s{color} | {color:red} tez-dag in the patch failed. {color} | | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 1m 17s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 36m 3s{color} | {color:black} {color} | \\ \\ || Reason || Tests || | Failed junit tests | tez.dag.app.TestSpeculation | \\ \\ || Subsystem || Report/Notes || | Docker | Client=19.03.5 Server=19.03.5 Image:yetus/tez:d4a62deee | | JIRA Issue | TEZ-4103 | | JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12987502/TEZ-4103.006.patch | | Optional Tests | dupname asflicense javac javadoc unit findbugs checkstyle compile | | uname | Linux d3b3fe74d031 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | /testptch/patchprocess/precommit/personality/provided.sh | | git revision | master / 1af0897
[jira] [Updated] (TEZ-4103) Progress in DAG, Vertex, and tasks is incorrect
[ https://issues.apache.org/jira/browse/TEZ-4103?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ahmed Hussein updated TEZ-4103: --- Attachment: TEZ-4103.006.patch > Progress in DAG, Vertex, and tasks is incorrect > --- > > Key: TEZ-4103 > URL: https://issues.apache.org/jira/browse/TEZ-4103 > Project: Apache Tez > Issue Type: Bug >Reporter: Ahmed Hussein >Assignee: Ahmed Hussein >Priority: Major > Attachments: TEZ-4103.001.patch, TEZ-4103.002.patch, > TEZ-4103.003.patch, TEZ-4103.004.patch, TEZ-4103.005.patch, TEZ-4103.006.patch > > > Looking at the progress code, there some few issues that could lead to some > problems calculating the progress. > There are some cases when the progress never reach 1.0. > This is a list of issues that need to be fixed in the progress code: > * After TEZ-3982, since values are skipped in the In some cases, the > progress of DAG or a vertex may never reach 1.0f. this is in both > "{{DAGImpl.java}}" and "{{ProgressHelper.java}}" > * {{ProgressHelper}} schedules a service to update the progress, dubbed > `{{ProgressHelper.monitorProgress}}`. According to Java Documentation: > {quote}If any execution of the task encounters an exception, > subsequent executions are suppressed. > Otherwise, the task will only terminate via cancellation > or termination of the executor. > {quote} > In other words, if the service dies, there is no way to catch that in the > code and the progress will never be updated. > * The `{{SimpleProcessor.inputMap}}` is not thread-safe. They are > initialized as `{{LinkedHashMap}}` and there is no synchronization on the > field objects in the map. This could be problematic in concurrent context. > * `{{VertexImpl.getProgress()}}` does not check the range of the progress > calculated in `{{VertexImpl.computeProgress()}}` > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (TEZ-4103) Progress in DAG, Vertex, and tasks is incorrect
[ https://issues.apache.org/jira/browse/TEZ-4103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16988159#comment-16988159 ] TezQA commented on TEZ-4103: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 19s{color} | {color:blue} Docker mode activated. {color} | || || || || {color:brown} Prechecks {color} || | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | | {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m 0s{color} | {color:green} The patch appears to include 1 new or modified test files. {color} | || || || || {color:brown} master Compile Tests {color} || | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 21s{color} | {color:blue} Maven dependency ordering for branch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m 35s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 41s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m 39s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m 49s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 49s{color} | {color:green} master passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 20s{color} | {color:blue} Maven dependency ordering for patch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m 43s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 42s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m 42s{color} | {color:green} the patch passed {color} | | {color:orange}-0{color} | {color:orange} checkstyle {color} | {color:orange} 0m 23s{color} | {color:orange} tez-api: The patch generated 1 new + 8 unchanged - 6 fixed = 9 total (was 14) {color} | | {color:orange}-0{color} | {color:orange} checkstyle {color} | {color:orange} 0m 20s{color} | {color:orange} tez-runtime-internals: The patch generated 1 new + 14 unchanged - 0 fixed = 15 total (was 14) {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 22s{color} | {color:green} The patch passed checkstyle in tez-mapreduce {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 35s{color} | {color:green} tez-dag: The patch generated 0 new + 397 unchanged - 1 fixed = 397 total (was 398) {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 3m 19s{color} | {color:green} the patch passed {color} | | {color:red}-1{color} | {color:red} javadoc {color} | {color:red} 0m 32s{color} | {color:red} tez-api generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0) {color} | || || || || {color:brown} Other Tests {color} || | {color:green}+1{color} | {color:green} unit {color} | {color:green} 1m 51s{color} | {color:green} tez-api in the patch passed. {color} | | {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m 49s{color} | {color:green} tez-runtime-internals in the patch passed. {color} | | {color:green}+1{color} | {color:green} unit {color} | {color:green} 1m 11s{color} | {color:green} tez-mapreduce in the patch passed. {color} | | {color:green}+1{color} | {color:green} unit {color} | {color:green} 3m 51s{color} | {color:green} tez-dag in the patch passed. {color} | | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 1m 14s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 33m 58s{color} | {color:black} {color} | \\ \\ || Subsystem || Report/Notes || | Docker | Client=19.03.5 Server=19.03.5 Image:yetus/tez:d4a62deee | | JIRA Issue | TEZ-4103 | | JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12987499/TEZ-4103.005.patch | | Optional Tests | dupname asflicense javac javadoc unit findbugs checkstyle compile | | uname | Linux 5b4d460a73c7 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | /testptch/patchprocess/precommit/personality/provided.sh | | git revision |
[jira] [Commented] (TEZ-4102) Merge AM credentials into session credentials while creating appContext
[ https://issues.apache.org/jira/browse/TEZ-4102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16988127#comment-16988127 ] Jonathan Turner Eagles commented on TEZ-4102: - This seems to violate the principle that AM and DAG can be separate users, which is a use case hive (perhaps LLAP needs) > Merge AM credentials into session credentials while creating appContext > --- > > Key: TEZ-4102 > URL: https://issues.apache.org/jira/browse/TEZ-4102 > Project: Apache Tez > Issue Type: Bug >Reporter: László Bodor >Assignee: László Bodor >Priority: Major > Attachments: TEZ-4102.01.patch, TEZ-4102.02.patch > > > Given the following scenario: kerberos + long running session + dags keep > submitted to the session > After 24h the queries can fail, because tasks don't have the correct > HDFS_DELEGATION_TOKEN, because there is chance that am credentials has been > previously filled with tokens and it cannot be overridden by session > credentials > [here|https://github.com/apache/tez/blob/master/tez-api/src/main/java/org/apache/tez/client/TezClientUtils.java#L485] > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Issue Comment Deleted] (TEZ-4102) Merge AM credentials into session credentials while creating appContext
[ https://issues.apache.org/jira/browse/TEZ-4102?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ashutosh Chauhan updated TEZ-4102: -- Comment: was deleted (was: +1) > Merge AM credentials into session credentials while creating appContext > --- > > Key: TEZ-4102 > URL: https://issues.apache.org/jira/browse/TEZ-4102 > Project: Apache Tez > Issue Type: Bug >Reporter: László Bodor >Assignee: László Bodor >Priority: Major > Attachments: TEZ-4102.01.patch, TEZ-4102.02.patch > > > Given the following scenario: kerberos + long running session + dags keep > submitted to the session > After 24h the queries can fail, because tasks don't have the correct > HDFS_DELEGATION_TOKEN, because there is chance that am credentials has been > previously filled with tokens and it cannot be overridden by session > credentials > [here|https://github.com/apache/tez/blob/master/tez-api/src/main/java/org/apache/tez/client/TezClientUtils.java#L485] > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (TEZ-4103) Progress in DAG, Vertex, and tasks is incorrect
[ https://issues.apache.org/jira/browse/TEZ-4103?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ahmed Hussein updated TEZ-4103: --- Attachment: TEZ-4103.005.patch > Progress in DAG, Vertex, and tasks is incorrect > --- > > Key: TEZ-4103 > URL: https://issues.apache.org/jira/browse/TEZ-4103 > Project: Apache Tez > Issue Type: Bug >Reporter: Ahmed Hussein >Assignee: Ahmed Hussein >Priority: Major > Attachments: TEZ-4103.001.patch, TEZ-4103.002.patch, > TEZ-4103.003.patch, TEZ-4103.004.patch, TEZ-4103.005.patch > > > Looking at the progress code, there some few issues that could lead to some > problems calculating the progress. > There are some cases when the progress never reach 1.0. > This is a list of issues that need to be fixed in the progress code: > * After TEZ-3982, since values are skipped in the In some cases, the > progress of DAG or a vertex may never reach 1.0f. this is in both > "{{DAGImpl.java}}" and "{{ProgressHelper.java}}" > * {{ProgressHelper}} schedules a service to update the progress, dubbed > `{{ProgressHelper.monitorProgress}}`. According to Java Documentation: > {quote}If any execution of the task encounters an exception, > subsequent executions are suppressed. > Otherwise, the task will only terminate via cancellation > or termination of the executor. > {quote} > In other words, if the service dies, there is no way to catch that in the > code and the progress will never be updated. > * The `{{SimpleProcessor.inputMap}}` is not thread-safe. They are > initialized as `{{LinkedHashMap}}` and there is no synchronization on the > field objects in the map. This could be problematic in concurrent context. > * `{{VertexImpl.getProgress()}}` does not check the range of the progress > calculated in `{{VertexImpl.computeProgress()}}` > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (TEZ-4102) Merge AM credentials into session credentials while creating appContext
[ https://issues.apache.org/jira/browse/TEZ-4102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16988107#comment-16988107 ] Ashutosh Chauhan commented on TEZ-4102: --- +1 > Merge AM credentials into session credentials while creating appContext > --- > > Key: TEZ-4102 > URL: https://issues.apache.org/jira/browse/TEZ-4102 > Project: Apache Tez > Issue Type: Bug >Reporter: László Bodor >Assignee: László Bodor >Priority: Major > Attachments: TEZ-4102.01.patch, TEZ-4102.02.patch > > > Given the following scenario: kerberos + long running session + dags keep > submitted to the session > After 24h the queries can fail, because tasks don't have the correct > HDFS_DELEGATION_TOKEN, because there is chance that am credentials has been > previously filled with tokens and it cannot be overridden by session > credentials > [here|https://github.com/apache/tez/blob/master/tez-api/src/main/java/org/apache/tez/client/TezClientUtils.java#L485] > -- This message was sent by Atlassian Jira (v8.3.4#803005)