[jira] [Commented] (TEZ-2988) DAGAppMaster::shutdownTezAM should return with a no-op if it has been invoked earlier
[ https://issues.apache.org/jira/browse/TEZ-2988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15172365#comment-15172365 ] Hitesh Shah commented on TEZ-2988: -- +1 committing shortly. > DAGAppMaster::shutdownTezAM should return with a no-op if it has been invoked > earlier > - > > Key: TEZ-2988 > URL: https://issues.apache.org/jira/browse/TEZ-2988 > Project: Apache Tez > Issue Type: Bug >Reporter: Hitesh Shah >Assignee: Tsuyoshi Ozawa > Attachments: TEZ-2988.001.patch, TEZ-2988.002.patch > > > If the session is already shutting down, DAGAppMaster::shutdownTezAM() should > not block. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TEZ-2988) DAGAppMaster::shutdownTezAM should return with a no-op if it has been invoked earlier
[
https://issues.apache.org/jira/browse/TEZ-2988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15171333#comment-15171333
]
TezQA commented on TEZ-2988:
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12790388/TEZ-2988.002.patch
against master revision 18398c8.
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 3.0.1) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 core tests{color}. The patch failed these unit tests in :
org.apache.tez.test.TestFaultTolerance
Test results:
https://builds.apache.org/job/PreCommit-TEZ-Build/1527//testReport/
Console output: https://builds.apache.org/job/PreCommit-TEZ-Build/1527//console
This message is automatically generated.
> DAGAppMaster::shutdownTezAM should return with a no-op if it has been invoked
> earlier
> -
>
> Key: TEZ-2988
> URL: https://issues.apache.org/jira/browse/TEZ-2988
> Project: Apache Tez
> Issue Type: Bug
>Reporter: Hitesh Shah
>Assignee: Tsuyoshi Ozawa
> Attachments: TEZ-2988.001.patch, TEZ-2988.002.patch
>
>
> If the session is already shutting down, DAGAppMaster::shutdownTezAM() should
> not block.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (TEZ-2988) DAGAppMaster::shutdownTezAM should return with a no-op if it has been invoked earlier
[
https://issues.apache.org/jira/browse/TEZ-2988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15171227#comment-15171227
]
TezQA commented on TEZ-2988:
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12790379/TEZ-2988.001.patch
against master revision 18398c8.
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 3.0.1) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-TEZ-Build/1526//testReport/
Console output: https://builds.apache.org/job/PreCommit-TEZ-Build/1526//console
This message is automatically generated.
> DAGAppMaster::shutdownTezAM should return with a no-op if it has been invoked
> earlier
> -
>
> Key: TEZ-2988
> URL: https://issues.apache.org/jira/browse/TEZ-2988
> Project: Apache Tez
> Issue Type: Bug
>Reporter: Hitesh Shah
>Assignee: Tsuyoshi Ozawa
> Attachments: TEZ-2988.001.patch
>
>
> If the session is already shutting down, DAGAppMaster::shutdownTezAM() should
> not block.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (TEZ-2988) DAGAppMaster::shutdownTezAM should return with a no-op if it has been invoked earlier
[ https://issues.apache.org/jira/browse/TEZ-2988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15171203#comment-15171203 ] Hitesh Shah commented on TEZ-2988: -- Generally looks fine. Minor nit: Instead of putting the full block of code into the if section, maybe do a return if sessionStopped.compareAndSet(false, true) returns false with a comment on why the return is being done? > DAGAppMaster::shutdownTezAM should return with a no-op if it has been invoked > earlier > - > > Key: TEZ-2988 > URL: https://issues.apache.org/jira/browse/TEZ-2988 > Project: Apache Tez > Issue Type: Bug >Reporter: Hitesh Shah >Assignee: Tsuyoshi Ozawa > Attachments: TEZ-2988.001.patch > > > If the session is already shutting down, DAGAppMaster::shutdownTezAM() should > not block. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
