[GitHub] incubator-trafficcontrol pull request #521: [TC-251] Fixed an issue where Tr...
GitHub user dneuman64 opened a pull request: https://github.com/apache/incubator-trafficcontrol/pull/521 [TC-251] Fixed an issue where Traffic Ops was not correctly refreshing DNSSEC keys This fixes [TC-251](https://issues.apache.org/jira/browse/TC-251) Thanks to @oren-shemesh for the help! You can merge this pull request into a Git repository by running: $ git pull https://github.com/dneuman64/incubator-trafficcontrol TC-251-again Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-trafficcontrol/pull/521.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #521 commit 00ad90659422cd5e6773b31738bb913b3bcc141a Author: David Neuman Date: 2017-04-25T21:00:09Z Fixed and issue where a search for DSs was using a profile ID instead of cdn_id (cherry picked from commit 3f6f1cc17befc970bc0bf5cff8ff5023bd48c27c) commit c1ef4a07d09624832ab4dfe463034492381b5c87 Author: David Neuman Date: 2017-04-26T14:26:17Z Change Daemonize so that parent process returns a 1 instead of a 0, also remove re-direct of output to /dev/null. Thanks @oren-shemesh for the help --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-trafficcontrol pull request #521: [TC-251] Fixed an issue where Tr...
Github user dneuman64 commented on a diff in the pull request:
https://github.com/apache/incubator-trafficcontrol/pull/521#discussion_r113472074
--- Diff: traffic_ops/app/lib/MojoPlugins/Daemonize.pm ---
@@ -41,12 +41,6 @@ sub register {
# This is the first child
$self->inactivity_timeout(0);
POSIX::setsid();
- open( STDIN, "< /dev/null" )
- || confess("Can't read /dev/null: $!");
--- End diff --
I removed them because they were preventing me from seeing log output from
the child process (even using $self->app->log). It's probably just an issue
with my local env, so I can add them back in.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafficcontrol pull request #521: [TC-251] Fixed an issue where Tr...
Github user oren-shemesh commented on a diff in the pull request:
https://github.com/apache/incubator-trafficcontrol/pull/521#discussion_r113468159
--- Diff: traffic_ops/app/lib/MojoPlugins/Daemonize.pm ---
@@ -41,12 +41,6 @@ sub register {
# This is the first child
$self->inactivity_timeout(0);
POSIX::setsid();
- open( STDIN, "< /dev/null" )
- || confess("Can't read /dev/null: $!");
--- End diff --
Why are you removing these lines ?
They make sure that any accidental input/output activity in the child
process will not interfere with the parent process.
It is a standard thing to do when spawning child processes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafficcontrol pull request #521: [TC-251] Fixed an issue where Tr...
Github user oren-shemesh commented on a diff in the pull request:
https://github.com/apache/incubator-trafficcontrol/pull/521#discussion_r113473675
--- Diff: traffic_ops/app/lib/MojoPlugins/Daemonize.pm ---
@@ -41,12 +41,6 @@ sub register {
# This is the first child
$self->inactivity_timeout(0);
POSIX::setsid();
- open( STDIN, "< /dev/null" )
- || confess("Can't read /dev/null: $!");
--- End diff --
Cool.
If child STD streams are not detached from the parent streams, this could
be the source of "mysterious" problems in "random" worker processes due to
child daemons doing IO, down the line.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafficcontrol pull request #521: [TC-251] Fixed an issue where Tr...
Github user asfgit closed the pull request at: https://github.com/apache/incubator-trafficcontrol/pull/521 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
