[jira] [Work logged] (TS-5019) Add total header length checks in HPACK

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-5019?focusedWorklogId=31283=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-31283
 ]

ASF GitHub Bot logged work on TS-5019:
--

Author: ASF GitHub Bot
Created on: 28/Oct/16 00:53
Start Date: 28/Oct/16 00:53
Worklog Time Spent: 10m 
  Work Description: Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1162
  
Linux build *successful*! See 
https://ci.trafficserver.apache.org/job/Github-Linux/1013/ for details.
 



Issue Time Tracking
---

Worklog Id: (was: 31283)
Time Spent: 1.5h  (was: 1h 20m)

> Add total header length checks in HPACK
> ---
>
> Key: TS-5019
> URL: https://issues.apache.org/jira/browse/TS-5019
> Project: Traffic Server
>  Issue Type: Bug
>  Components: HTTP/2
>Reporter: Masaori Koshiba
> Fix For: 7.1.0
>
>  Time Spent: 1.5h
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Work logged] (TS-5019) Add total header length checks in HPACK

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-5019?focusedWorklogId=31282=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-31282
 ]

ASF GitHub Bot logged work on TS-5019:
--

Author: ASF GitHub Bot
Created on: 28/Oct/16 00:53
Start Date: 28/Oct/16 00:53
Worklog Time Spent: 10m 
  Work Description: Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1162
  
FreeBSD build *successful*! See 
https://ci.trafficserver.apache.org/job/Github-FreeBSD/1119/ for details.
 



Issue Time Tracking
---

Worklog Id: (was: 31282)
Time Spent: 1h 20m  (was: 1h 10m)

> Add total header length checks in HPACK
> ---
>
> Key: TS-5019
> URL: https://issues.apache.org/jira/browse/TS-5019
> Project: Traffic Server
>  Issue Type: Bug
>  Components: HTTP/2
>Reporter: Masaori Koshiba
> Fix For: 7.1.0
>
>  Time Spent: 1h 20m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] trafficserver issue #1162: TS-5019: Add total header length checks in HPACK ...

[atsci]

Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1162
  
Linux build *successful*! See 
https://ci.trafficserver.apache.org/job/Github-Linux/1013/ for details.
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1162: TS-5019: Add total header length checks in HPACK ...

[atsci]

Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1162
  
FreeBSD build *successful*! See 
https://ci.trafficserver.apache.org/job/Github-FreeBSD/1119/ for details.
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Work logged] (TS-5019) Add total header length checks in HPACK

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-5019?focusedWorklogId=31281=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-31281
 ]

ASF GitHub Bot logged work on TS-5019:
--

Author: ASF GitHub Bot
Created on: 28/Oct/16 00:38
Start Date: 28/Oct/16 00:38
Worklog Time Spent: 10m 
  Work Description: GitHub user masaori335 opened a pull request:

https://github.com/apache/trafficserver/pull/1162

TS-5019: Add total header length checks in HPACK (back-port)



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/masaori335/trafficserver 6.2.x_ts-5019

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/trafficserver/pull/1162.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1162


commit 7557ca0eb1a1d6090d59d9aaf584994e89d9028a
Author: Masaori Koshiba 
Date:   2016-10-27T23:18:58Z

TS-5019: Add total header length checks in HPACK




Issue Time Tracking
---

Worklog Id: (was: 31281)
Time Spent: 1h 10m  (was: 1h)

> Add total header length checks in HPACK
> ---
>
> Key: TS-5019
> URL: https://issues.apache.org/jira/browse/TS-5019
> Project: Traffic Server
>  Issue Type: Bug
>  Components: HTTP/2
>Reporter: Masaori Koshiba
> Fix For: 7.1.0
>
>  Time Spent: 1h 10m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] trafficserver pull request #1162: TS-5019: Add total header length checks in...

[masaori335]

GitHub user masaori335 opened a pull request:

https://github.com/apache/trafficserver/pull/1162

TS-5019: Add total header length checks in HPACK (back-port)



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/masaori335/trafficserver 6.2.x_ts-5019

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/trafficserver/pull/1162.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1162


commit 7557ca0eb1a1d6090d59d9aaf584994e89d9028a
Author: Masaori Koshiba 
Date:   2016-10-27T23:18:58Z

TS-5019: Add total header length checks in HPACK




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Work logged] (TS-4986) Memory leak in test_Map

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-4986?focusedWorklogId=31280=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-31280
 ]

ASF GitHub Bot logged work on TS-4986:
--

Author: ASF GitHub Bot
Created on: 28/Oct/16 00:02
Start Date: 28/Oct/16 00:02
Worklog Time Spent: 10m 
  Work Description: Github user bryancall closed the pull request at:

https://github.com/apache/trafficserver/pull/1159


Issue Time Tracking
---

Worklog Id: (was: 31280)
Time Spent: 40m  (was: 0.5h)

> Memory leak in test_Map
> ---
>
> Key: TS-4986
> URL: https://issues.apache.org/jira/browse/TS-4986
> Project: Traffic Server
>  Issue Type: Bug
>  Components: Core, Tests
>Reporter: Bryan Call
>  Time Spent: 40m
>  Remaining Estimate: 0h
>
> {noformat}
> =
> ==22202==ERROR: LeakSanitizer: detected memory leaks
> Direct leak of 3216 byte(s) in 134 object(s) allocated from:
> #0 0x7f4d3de22ea0 in operator new(unsigned long) 
> (/lib64/libasan.so.3+0xc7ea0)
> #1 0x402df9 in test_TSHashTable() 
> /home/bcall/dev/apache/trafficserver/lib/ts/test_Map.cc:76
> #2 0x402380 in main 
> /home/bcall/dev/apache/trafficserver/lib/ts/test_Map.cc:214
> #3 0x7f4d3b09b730 in __libc_start_main (/lib64/libc.so.6+0x20730)
> Direct leak of 112 byte(s) in 1 object(s) allocated from:
> #0 0x7f4d3de21e60 in malloc (/lib64/libasan.so.3+0xc6e60)
> #1 0x7f4d3db28f85 in ats_malloc 
> /home/bcall/dev/apache/trafficserver/lib/ts/ink_memory.cc:59
> #2 0x406576 in DefaultAlloc::alloc(int) ../../lib/ts/defalloc.h:34
> #3 0x406576 in Vec 2>::set_expand() ../../lib/ts/Vec.h:781
> #4 0x406576 in HashMap DefaultAlloc>::put(char const*, int) ../../lib/ts/Map.h:552
> #5 0x401d90 in main 
> /home/bcall/dev/apache/trafficserver/lib/ts/test_Map.cc:174
> #6 0x7f4d3b09b730 in __libc_start_main (/lib64/libc.so.6+0x20730)
> Direct leak of 24 byte(s) in 1 object(s) allocated from:
> #0 0x7f4d3de21e60 in malloc (/lib64/libasan.so.3+0xc6e60)
> #1 0x7f4d3db28f85 in ats_malloc 
> /home/bcall/dev/apache/trafficserver/lib/ts/ink_memory.cc:59
> #2 0x4126bf in DefaultAlloc::alloc(int) ../../lib/ts/defalloc.h:34
> #3 0x4126bf in ConsCell DefaultAlloc>::operator new(unsigned long) ../../lib/ts/List.h:603
> #4 0x4126bf in List DefaultAlloc>::List(MapElem) ../../lib/ts/List.h:663
> #5 0x4126bf in ChainHashMap DefaultAlloc>::put(char const*, int) ../../lib/ts/Map.h:691
> #6 0x401f26 in main 
> /home/bcall/dev/apache/trafficserver/lib/ts/test_Map.cc:196
> #7 0x7f4d3b09b730 in __libc_start_main (/lib64/libc.so.6+0x20730)
> Direct leak of 24 byte(s) in 1 object(s) allocated from:
> #0 0x7f4d3de22ea0 in operator new(unsigned long) 
> (/lib64/libasan.so.3+0xc7ea0)
> #1 0x402d4a in test_TSHashTable() 
> /home/bcall/dev/apache/trafficserver/lib/ts/test_Map.cc:73
> #2 0x402380 in main 
> /home/bcall/dev/apache/trafficserver/lib/ts/test_Map.cc:214
> #3 0x7f4d3b09b730 in __libc_start_main (/lib64/libc.so.6+0x20730)
> Direct leak of 24 byte(s) in 1 object(s) allocated from:
> #0 0x7f4d3de21e60 in malloc (/lib64/libasan.so.3+0xc6e60)
> #1 0x7f4d3db28f85 in ats_malloc 
> /home/bcall/dev/apache/trafficserver/lib/ts/ink_memory.cc:59
> #2 0x4126bf in DefaultAlloc::alloc(int) ../../lib/ts/defalloc.h:34
> #3 0x4126bf in ConsCell DefaultAlloc>::operator new(unsigned long) ../../lib/ts/List.h:603
> #4 0x4126bf in List DefaultAlloc>::List(MapElem) ../../lib/ts/List.h:663
> #5 0x4126bf in ChainHashMap DefaultAlloc>::put(char const*, int) ../../lib/ts/Map.h:691
> #6 0x401efe in main 
> /home/bcall/dev/apache/trafficserver/lib/ts/test_Map.cc:194
> #7 0x7f4d3b09b730 in __libc_start_main (/lib64/libc.so.6+0x20730)
> Direct leak of 24 byte(s) in 1 object(s) allocated from:
> #0 0x7f4d3de21e60 in malloc (/lib64/libasan.so.3+0xc6e60)
> #1 0x7f4d3db28f85 in ats_malloc 
> /home/bcall/dev/apache/trafficserver/lib/ts/ink_memory.cc:59
> #2 0x4126bf in DefaultAlloc::alloc(int) ../../lib/ts/defalloc.h:34
> #3 0x4126bf in ConsCell DefaultAlloc>::operator new(unsigned long) ../../lib/ts/List.h:603
> #4 0x4126bf in List DefaultAlloc>::List(MapElem) ../../lib/ts/List.h:663
> #5 0x4126bf in ChainHashMap DefaultAlloc>::put(char const*, int) ../../lib/ts/Map.h:691
> #6 0x401f12 in main 
> /home/bcall/dev/apache/trafficserver/lib/ts/test_Map.cc:195
> #7 0x7f4d3b09b730 in __libc_start_main (/lib64/libc.so.6+0x20730)
> Direct leak of 24 byte(s) in 1 object(s) allocated from:
> #0 0x7f4d3de21e60 in malloc (/lib64/libasan.so.3+0xc6e60)
> #1 0x7f4d3db28f85 in ats_malloc 
> 

[GitHub] trafficserver pull request #1159: TS-4986: Memory leak in test_Map

[bryancall]

Github user bryancall closed the pull request at:

https://github.com/apache/trafficserver/pull/1159


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Work logged] (TS-5018) CID 1365301: Control flow issues (DEADCODE)

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-5018?focusedWorklogId=31279=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-31279
 ]

ASF GitHub Bot logged work on TS-5018:
--

Author: ASF GitHub Bot
Created on: 27/Oct/16 23:45
Start Date: 27/Oct/16 23:45
Worklog Time Spent: 10m 
  Work Description: Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1161
  
Linux build *successful*! See 
https://ci.trafficserver.apache.org/job/Github-Linux/1012/ for details.
 



Issue Time Tracking
---

Worklog Id: (was: 31279)
Time Spent: 0.5h  (was: 20m)

> CID 1365301:  Control flow issues  (DEADCODE)
> -
>
> Key: TS-5018
> URL: https://issues.apache.org/jira/browse/TS-5018
> Project: Traffic Server
>  Issue Type: Bug
>  Components: Plugins
>Reporter: Masaori Koshiba
>Assignee: Masaori Koshiba
> Fix For: 7.1.0
>
>  Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> {noformat}
> ** CID 1365301:  Control flow issues  (DEADCODE)
> /plugins/header_rewrite/parser.cc: 67 in Parser::Parser(const 
> std::basic_string&)()
> 
> *** CID 1365301:  Control flow issues  (DEADCODE)
> /plugins/header_rewrite/parser.cc: 67 in Parser::Parser(const 
> std::basic_string&)()
> 61 cur_token_length = i - cur_token_start + 1;
> 62 _tokens.push_back(line.substr(cur_token_start, 
> cur_token_length));
> 63 state= PARSER_DEFAULT;
> 64 extracting_token = false;
> 65   } else if (!extracting_token) {
> 66 // /'s elsewhere are just consumed, but we should not end up 
> here if we're not extracting a token
> >>> CID 1365301:  Control flow issues  (DEADCODE)
> >>> Execution cannot reach this statement: "TSError("[%s] malformed 
> >>> reg...".
> 67 TSError("[%s] malformed regex \"%s\" ignoring...", 
> PLUGIN_NAME, line.c_str());
> 68   }
> 69 } else if ((state != PARSER_IN_REGEX) && (line[i] == '\\')) {
> 70   // Escaping
> 71   if (!extracting_token) {
> 72 extracting_token = true;
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] trafficserver issue #1161: TS-5018: Fix CID 1365301: Control flow issues (DE...

[atsci]

Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1161
  
Linux build *successful*! See 
https://ci.trafficserver.apache.org/job/Github-Linux/1012/ for details.
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Work logged] (TS-5018) CID 1365301: Control flow issues (DEADCODE)

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-5018?focusedWorklogId=31278=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-31278
 ]

ASF GitHub Bot logged work on TS-5018:
--

Author: ASF GitHub Bot
Created on: 27/Oct/16 23:43
Start Date: 27/Oct/16 23:43
Worklog Time Spent: 10m 
  Work Description: Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1161
  
FreeBSD build *successful*! See 
https://ci.trafficserver.apache.org/job/Github-FreeBSD/1118/ for details.
 



Issue Time Tracking
---

Worklog Id: (was: 31278)
Time Spent: 20m  (was: 10m)

> CID 1365301:  Control flow issues  (DEADCODE)
> -
>
> Key: TS-5018
> URL: https://issues.apache.org/jira/browse/TS-5018
> Project: Traffic Server
>  Issue Type: Bug
>  Components: Plugins
>Reporter: Masaori Koshiba
>Assignee: Masaori Koshiba
> Fix For: 7.1.0
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> {noformat}
> ** CID 1365301:  Control flow issues  (DEADCODE)
> /plugins/header_rewrite/parser.cc: 67 in Parser::Parser(const 
> std::basic_string&)()
> 
> *** CID 1365301:  Control flow issues  (DEADCODE)
> /plugins/header_rewrite/parser.cc: 67 in Parser::Parser(const 
> std::basic_string&)()
> 61 cur_token_length = i - cur_token_start + 1;
> 62 _tokens.push_back(line.substr(cur_token_start, 
> cur_token_length));
> 63 state= PARSER_DEFAULT;
> 64 extracting_token = false;
> 65   } else if (!extracting_token) {
> 66 // /'s elsewhere are just consumed, but we should not end up 
> here if we're not extracting a token
> >>> CID 1365301:  Control flow issues  (DEADCODE)
> >>> Execution cannot reach this statement: "TSError("[%s] malformed 
> >>> reg...".
> 67 TSError("[%s] malformed regex \"%s\" ignoring...", 
> PLUGIN_NAME, line.c_str());
> 68   }
> 69 } else if ((state != PARSER_IN_REGEX) && (line[i] == '\\')) {
> 70   // Escaping
> 71   if (!extracting_token) {
> 72 extracting_token = true;
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] trafficserver issue #1161: TS-5018: Fix CID 1365301: Control flow issues (DE...

[atsci]

Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1161
  
FreeBSD build *successful*! See 
https://ci.trafficserver.apache.org/job/Github-FreeBSD/1118/ for details.
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Work logged] (TS-5019) Add total header length checks in HPACK

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-5019?focusedWorklogId=31277=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-31277
 ]

ASF GitHub Bot logged work on TS-5019:
--

Author: ASF GitHub Bot
Created on: 27/Oct/16 23:38
Start Date: 27/Oct/16 23:38
Worklog Time Spent: 10m 
  Work Description: Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1160
  
Linux build *successful*! See 
https://ci.trafficserver.apache.org/job/Github-Linux/1011/ for details.
 



Issue Time Tracking
---

Worklog Id: (was: 31277)
Time Spent: 1h  (was: 50m)

> Add total header length checks in HPACK
> ---
>
> Key: TS-5019
> URL: https://issues.apache.org/jira/browse/TS-5019
> Project: Traffic Server
>  Issue Type: Bug
>  Components: HTTP/2
>Reporter: Masaori Koshiba
> Fix For: 7.1.0
>
>  Time Spent: 1h
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] trafficserver issue #1160: TS-5019: Add header length checks in HPACK

[atsci]

Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1160
  
Linux build *successful*! See 
https://ci.trafficserver.apache.org/job/Github-Linux/1011/ for details.
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Work logged] (TS-5019) Add total header length checks in HPACK

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-5019?focusedWorklogId=31276=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-31276
 ]

ASF GitHub Bot logged work on TS-5019:
--

Author: ASF GitHub Bot
Created on: 27/Oct/16 23:35
Start Date: 27/Oct/16 23:35
Worklog Time Spent: 10m 
  Work Description: Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1160
  
FreeBSD build *successful*! See 
https://ci.trafficserver.apache.org/job/Github-FreeBSD/1117/ for details.
 



Issue Time Tracking
---

Worklog Id: (was: 31276)
Time Spent: 50m  (was: 40m)

> Add total header length checks in HPACK
> ---
>
> Key: TS-5019
> URL: https://issues.apache.org/jira/browse/TS-5019
> Project: Traffic Server
>  Issue Type: Bug
>  Components: HTTP/2
>Reporter: Masaori Koshiba
> Fix For: 7.1.0
>
>  Time Spent: 50m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] trafficserver issue #1160: TS-5019: Add header length checks in HPACK

[atsci]

Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1160
  
FreeBSD build *successful*! See 
https://ci.trafficserver.apache.org/job/Github-FreeBSD/1117/ for details.
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Work logged] (TS-5019) Add total header length checks in HPACK

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-5019?focusedWorklogId=31275=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-31275
 ]

ASF GitHub Bot logged work on TS-5019:
--

Author: ASF GitHub Bot
Created on: 27/Oct/16 23:34
Start Date: 27/Oct/16 23:34
Worklog Time Spent: 10m 
  Work Description: Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1160
  
FreeBSD build *successful*! See 
https://ci.trafficserver.apache.org/job/Github-FreeBSD/1116/ for details.
 



Issue Time Tracking
---

Worklog Id: (was: 31275)
Time Spent: 40m  (was: 0.5h)

> Add total header length checks in HPACK
> ---
>
> Key: TS-5019
> URL: https://issues.apache.org/jira/browse/TS-5019
> Project: Traffic Server
>  Issue Type: Bug
>  Components: HTTP/2
>Reporter: Masaori Koshiba
> Fix For: 7.1.0
>
>  Time Spent: 40m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Work logged] (TS-5019) Add total header length checks in HPACK

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-5019?focusedWorklogId=31273=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-31273
 ]

ASF GitHub Bot logged work on TS-5019:
--

Author: ASF GitHub Bot
Created on: 27/Oct/16 23:32
Start Date: 27/Oct/16 23:32
Worklog Time Spent: 10m 
  Work Description: Github user maskit commented on the issue:

https://github.com/apache/trafficserver/pull/1160
  
Looks good.


Issue Time Tracking
---

Worklog Id: (was: 31273)
Time Spent: 20m  (was: 10m)

> Add total header length checks in HPACK
> ---
>
> Key: TS-5019
> URL: https://issues.apache.org/jira/browse/TS-5019
> Project: Traffic Server
>  Issue Type: Bug
>  Components: HTTP/2
>Reporter: Masaori Koshiba
> Fix For: 7.1.0
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Work logged] (TS-5019) Add total header length checks in HPACK

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-5019?focusedWorklogId=31274=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-31274
 ]

ASF GitHub Bot logged work on TS-5019:
--

Author: ASF GitHub Bot
Created on: 27/Oct/16 23:33
Start Date: 27/Oct/16 23:33
Worklog Time Spent: 10m 
  Work Description: Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1160
  
Linux build *successful*! See 
https://ci.trafficserver.apache.org/job/Github-Linux/1010/ for details.
 



Issue Time Tracking
---

Worklog Id: (was: 31274)
Time Spent: 0.5h  (was: 20m)

> Add total header length checks in HPACK
> ---
>
> Key: TS-5019
> URL: https://issues.apache.org/jira/browse/TS-5019
> Project: Traffic Server
>  Issue Type: Bug
>  Components: HTTP/2
>Reporter: Masaori Koshiba
> Fix For: 7.1.0
>
>  Time Spent: 0.5h
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] trafficserver issue #1160: TS-5019: Add header length checks in HPACK

[atsci]

Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1160
  
FreeBSD build *successful*! See 
https://ci.trafficserver.apache.org/job/Github-FreeBSD/1116/ for details.
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1160: TS-5019: Add header length checks in HPACK

[atsci]

Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1160
  
Linux build *successful*! See 
https://ci.trafficserver.apache.org/job/Github-Linux/1010/ for details.
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1160: TS-5019: Add header length checks in HPACK

[maskit]

Github user maskit commented on the issue:

https://github.com/apache/trafficserver/pull/1160
  
Looks good.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Work logged] (TS-5018) CID 1365301: Control flow issues (DEADCODE)

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-5018?focusedWorklogId=31272=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-31272
 ]

ASF GitHub Bot logged work on TS-5018:
--

Author: ASF GitHub Bot
Created on: 27/Oct/16 23:28
Start Date: 27/Oct/16 23:28
Worklog Time Spent: 10m 
  Work Description: GitHub user masaori335 opened a pull request:

https://github.com/apache/trafficserver/pull/1161

TS-5018: Fix CID 1365301: Control flow issues (DEADCODE)

I think Coverity says that when `state` is not `PARSER_IN_REGEX`, 
`extracting_token` is always false.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/masaori335/trafficserver ts-5018

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/trafficserver/pull/1161.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1161


commit c45acda3199f0842ffaee8f3a52d8cde57d73fcb
Author: Masaori Koshiba 
Date:   2016-10-27T22:25:52Z

TS-5018: Fix CID 1365301: Control flow issues (DEADCODE)




Issue Time Tracking
---

Worklog Id: (was: 31272)
Time Spent: 10m
Remaining Estimate: 0h

> CID 1365301:  Control flow issues  (DEADCODE)
> -
>
> Key: TS-5018
> URL: https://issues.apache.org/jira/browse/TS-5018
> Project: Traffic Server
>  Issue Type: Bug
>  Components: Plugins
>Reporter: Masaori Koshiba
>Assignee: Masaori Koshiba
> Fix For: 7.1.0
>
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> {noformat}
> ** CID 1365301:  Control flow issues  (DEADCODE)
> /plugins/header_rewrite/parser.cc: 67 in Parser::Parser(const 
> std::basic_string&)()
> 
> *** CID 1365301:  Control flow issues  (DEADCODE)
> /plugins/header_rewrite/parser.cc: 67 in Parser::Parser(const 
> std::basic_string&)()
> 61 cur_token_length = i - cur_token_start + 1;
> 62 _tokens.push_back(line.substr(cur_token_start, 
> cur_token_length));
> 63 state= PARSER_DEFAULT;
> 64 extracting_token = false;
> 65   } else if (!extracting_token) {
> 66 // /'s elsewhere are just consumed, but we should not end up 
> here if we're not extracting a token
> >>> CID 1365301:  Control flow issues  (DEADCODE)
> >>> Execution cannot reach this statement: "TSError("[%s] malformed 
> >>> reg...".
> 67 TSError("[%s] malformed regex \"%s\" ignoring...", 
> PLUGIN_NAME, line.c_str());
> 68   }
> 69 } else if ((state != PARSER_IN_REGEX) && (line[i] == '\\')) {
> 70   // Escaping
> 71   if (!extracting_token) {
> 72 extracting_token = true;
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] trafficserver pull request #1161: TS-5018: Fix CID 1365301: Control flow iss...

[masaori335]

GitHub user masaori335 opened a pull request:

https://github.com/apache/trafficserver/pull/1161

TS-5018: Fix CID 1365301: Control flow issues (DEADCODE)

I think Coverity says that when `state` is not `PARSER_IN_REGEX`, 
`extracting_token` is always false.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/masaori335/trafficserver ts-5018

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/trafficserver/pull/1161.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1161


commit c45acda3199f0842ffaee8f3a52d8cde57d73fcb
Author: Masaori Koshiba 
Date:   2016-10-27T22:25:52Z

TS-5018: Fix CID 1365301: Control flow issues (DEADCODE)




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Updated] (TS-5019) Add total header length checks in HPACK

[Masaori Koshiba (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-5019?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Masaori Koshiba updated TS-5019:

Summary: Add total header length checks in HPACK  (was: Add header length 
checks in HPACK)

> Add total header length checks in HPACK
> ---
>
> Key: TS-5019
> URL: https://issues.apache.org/jira/browse/TS-5019
> Project: Traffic Server
>  Issue Type: Bug
>  Components: HTTP/2
>Reporter: Masaori Koshiba
> Fix For: 7.1.0
>
>  Time Spent: 10m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (TS-5019) Add header length checks in HPACK

[Masaori Koshiba (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-5019?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Masaori Koshiba updated TS-5019:

Backport to Version: 6.2.1, 7.0.0

> Add header length checks in HPACK
> -
>
> Key: TS-5019
> URL: https://issues.apache.org/jira/browse/TS-5019
> Project: Traffic Server
>  Issue Type: Bug
>  Components: HTTP/2
>Reporter: Masaori Koshiba
> Fix For: 7.1.0
>
>  Time Spent: 10m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Work logged] (TS-5019) Add header length checks in HPACK

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-5019?focusedWorklogId=31271=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-31271
 ]

ASF GitHub Bot logged work on TS-5019:
--

Author: ASF GitHub Bot
Created on: 27/Oct/16 23:19
Start Date: 27/Oct/16 23:19
Worklog Time Spent: 10m 
  Work Description: GitHub user masaori335 opened a pull request:

https://github.com/apache/trafficserver/pull/1160

TS-5019: Add header length checks in HPACK



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/masaori335/trafficserver ts-5019

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/trafficserver/pull/1160.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1160


commit 959975f0e37de0f557c8f6aa6ea7890fa96b6899
Author: Masaori Koshiba 
Date:   2016-10-27T23:18:58Z

TS-5019: Add header length checks in HPACK




Issue Time Tracking
---

Worklog Id: (was: 31271)
Time Spent: 10m
Remaining Estimate: 0h

> Add header length checks in HPACK
> -
>
> Key: TS-5019
> URL: https://issues.apache.org/jira/browse/TS-5019
> Project: Traffic Server
>  Issue Type: Bug
>  Components: HTTP/2
>Reporter: Masaori Koshiba
> Fix For: 7.1.0
>
>  Time Spent: 10m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] trafficserver pull request #1160: TS-5019: Add header length checks in HPACK

[masaori335]

GitHub user masaori335 opened a pull request:

https://github.com/apache/trafficserver/pull/1160

TS-5019: Add header length checks in HPACK



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/masaori335/trafficserver ts-5019

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/trafficserver/pull/1160.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1160


commit 959975f0e37de0f557c8f6aa6ea7890fa96b6899
Author: Masaori Koshiba 
Date:   2016-10-27T23:18:58Z

TS-5019: Add header length checks in HPACK




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Updated] (TS-5019) Add header length checks in HPACK

[Masaori Koshiba (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-5019?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Masaori Koshiba updated TS-5019:

Fix Version/s: 7.1.0

> Add header length checks in HPACK
> -
>
> Key: TS-5019
> URL: https://issues.apache.org/jira/browse/TS-5019
> Project: Traffic Server
>  Issue Type: Bug
>  Components: HTTP/2
>Reporter: Masaori Koshiba
> Fix For: 7.1.0
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (TS-5019) Add header length checks in HPACK

[Masaori Koshiba (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-5019?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Masaori Koshiba updated TS-5019:

Summary: Add header length checks in HPACK  (was: Add header length checks)

> Add header length checks in HPACK
> -
>
> Key: TS-5019
> URL: https://issues.apache.org/jira/browse/TS-5019
> Project: Traffic Server
>  Issue Type: Bug
>  Components: HTTP/2
>Reporter: Masaori Koshiba
> Fix For: 7.1.0
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (TS-5019) Add header length checks

[Masaori Koshiba (JIRA)]

Masaori Koshiba created TS-5019:
---

 Summary: Add header length checks
 Key: TS-5019
 URL: https://issues.apache.org/jira/browse/TS-5019
 Project: Traffic Server
  Issue Type: Bug
  Components: HTTP/2
Reporter: Masaori Koshiba






--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (TS-5018) CID 1365301: Control flow issues (DEADCODE)

[Leif Hedstrom (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-5018?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Leif Hedstrom updated TS-5018:
--
Fix Version/s: 7.1.0

> CID 1365301:  Control flow issues  (DEADCODE)
> -
>
> Key: TS-5018
> URL: https://issues.apache.org/jira/browse/TS-5018
> Project: Traffic Server
>  Issue Type: Bug
>  Components: Plugins
>Reporter: Masaori Koshiba
>Assignee: Masaori Koshiba
> Fix For: 7.1.0
>
>
> {noformat}
> ** CID 1365301:  Control flow issues  (DEADCODE)
> /plugins/header_rewrite/parser.cc: 67 in Parser::Parser(const 
> std::basic_string&)()
> 
> *** CID 1365301:  Control flow issues  (DEADCODE)
> /plugins/header_rewrite/parser.cc: 67 in Parser::Parser(const 
> std::basic_string&)()
> 61 cur_token_length = i - cur_token_start + 1;
> 62 _tokens.push_back(line.substr(cur_token_start, 
> cur_token_length));
> 63 state= PARSER_DEFAULT;
> 64 extracting_token = false;
> 65   } else if (!extracting_token) {
> 66 // /'s elsewhere are just consumed, but we should not end up 
> here if we're not extracting a token
> >>> CID 1365301:  Control flow issues  (DEADCODE)
> >>> Execution cannot reach this statement: "TSError("[%s] malformed 
> >>> reg...".
> 67 TSError("[%s] malformed regex \"%s\" ignoring...", 
> PLUGIN_NAME, line.c_str());
> 68   }
> 69 } else if ((state != PARSER_IN_REGEX) && (line[i] == '\\')) {
> 70   // Escaping
> 71   if (!extracting_token) {
> 72 extracting_token = true;
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Work logged] (TS-5009) CID 1022011 Logically dead code

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-5009?focusedWorklogId=31270=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-31270
 ]

ASF GitHub Bot logged work on TS-5009:
--

Author: ASF GitHub Bot
Created on: 27/Oct/16 22:45
Start Date: 27/Oct/16 22:45
Worklog Time Spent: 10m 
  Work Description: Github user ngara commented on the issue:

https://github.com/apache/trafficserver/pull/1152
  
Maybe this should be an ink_abort instead of ink_release_assert?


Issue Time Tracking
---

Worklog Id: (was: 31270)
Time Spent: 2h  (was: 1h 50m)

> CID 1022011 Logically dead code
> ---
>
> Key: TS-5009
> URL: https://issues.apache.org/jira/browse/TS-5009
> Project: Traffic Server
>  Issue Type: Bug
>  Components: Core
>Reporter: Nathan Garabedian
>Assignee: Nathan Garabedian
>  Labels: coverity
> Fix For: 7.1.0
>
>  Time Spent: 2h
>  Remaining Estimate: 0h
>
> TS_INLINE char ::operator[](int64_t i)
> 686{
> 687  static char _error = '\0';
> 688  IOBufferBlock *b   = block.get();
> 689
> 690  i += start_offset;
>   cond_null: Condition b, taking false branch. Now the value of b is NULL.
> 691  while (b) {
> 692int64_t bytes = b->read_avail();
> 693if (bytes > i)
> 694  return b->start()[i];
> 695i -= bytes;
> 696b = b->next.get();
> 697  }
> 698
> 699  ink_assert(!"out of range");
>   const: At condition !!b, the value of b must be equal to 0.
>   null: At condition !!b, the value of b must be NULL.
>   dead_error_condition: The condition !!b cannot be true.
> 700  if (unlikely(b)) {
>   
> CID 1022011 (#1 of 1): Logically dead code (DEADCODE)
> dead_error_line: Execution cannot reach this statement: return b->start();.
> 701return *b->start();
> 702  }



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] trafficserver issue #1152: TS-5009 CID 1022011 Logically dead code removal

[ngara]

Github user ngara commented on the issue:

https://github.com/apache/trafficserver/pull/1152
  
Maybe this should be an ink_abort instead of ink_release_assert?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Assigned] (TS-5018) CID 1365301: Control flow issues (DEADCODE)

[Masaori Koshiba (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-5018?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Masaori Koshiba reassigned TS-5018:
---

Assignee: Masaori Koshiba

> CID 1365301:  Control flow issues  (DEADCODE)
> -
>
> Key: TS-5018
> URL: https://issues.apache.org/jira/browse/TS-5018
> Project: Traffic Server
>  Issue Type: Bug
>  Components: Plugins
>Reporter: Masaori Koshiba
>Assignee: Masaori Koshiba
>
> {noformat}
> ** CID 1365301:  Control flow issues  (DEADCODE)
> /plugins/header_rewrite/parser.cc: 67 in Parser::Parser(const 
> std::basic_string&)()
> 
> *** CID 1365301:  Control flow issues  (DEADCODE)
> /plugins/header_rewrite/parser.cc: 67 in Parser::Parser(const 
> std::basic_string&)()
> 61 cur_token_length = i - cur_token_start + 1;
> 62 _tokens.push_back(line.substr(cur_token_start, 
> cur_token_length));
> 63 state= PARSER_DEFAULT;
> 64 extracting_token = false;
> 65   } else if (!extracting_token) {
> 66 // /'s elsewhere are just consumed, but we should not end up 
> here if we're not extracting a token
> >>> CID 1365301:  Control flow issues  (DEADCODE)
> >>> Execution cannot reach this statement: "TSError("[%s] malformed 
> >>> reg...".
> 67 TSError("[%s] malformed regex \"%s\" ignoring...", 
> PLUGIN_NAME, line.c_str());
> 68   }
> 69 } else if ((state != PARSER_IN_REGEX) && (line[i] == '\\')) {
> 70   // Escaping
> 71   if (!extracting_token) {
> 72 extracting_token = true;
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (TS-5018) CID 1365301: Control flow issues (DEADCODE)

[Masaori Koshiba (JIRA)]

Masaori Koshiba created TS-5018:
---

 Summary: CID 1365301:  Control flow issues  (DEADCODE)
 Key: TS-5018
 URL: https://issues.apache.org/jira/browse/TS-5018
 Project: Traffic Server
  Issue Type: Bug
  Components: Plugins
Reporter: Masaori Koshiba


{noformat}
** CID 1365301:  Control flow issues  (DEADCODE)
/plugins/header_rewrite/parser.cc: 67 in Parser::Parser(const 
std::basic_string&)()



*** CID 1365301:  Control flow issues  (DEADCODE)
/plugins/header_rewrite/parser.cc: 67 in Parser::Parser(const 
std::basic_string&)()
61 cur_token_length = i - cur_token_start + 1;
62 _tokens.push_back(line.substr(cur_token_start, 
cur_token_length));
63 state= PARSER_DEFAULT;
64 extracting_token = false;
65   } else if (!extracting_token) {
66 // /'s elsewhere are just consumed, but we should not end up 
here if we're not extracting a token
>>> CID 1365301:  Control flow issues  (DEADCODE)
>>> Execution cannot reach this statement: "TSError("[%s] malformed reg...".
67 TSError("[%s] malformed regex \"%s\" ignoring...", PLUGIN_NAME, 
line.c_str());
68   }
69 } else if ((state != PARSER_IN_REGEX) && (line[i] == '\\')) {
70   // Escaping
71   if (!extracting_token) {
72 extracting_token = true;
{noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (TS-4993) Backslash/escape removed from header_rewrite rule when unquoted

[Bryan Call (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-4993?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Bryan Call updated TS-4993:
---
Summary: Backslash/escape removed from header_rewrite rule when unquoted  
(was: backslash/escape removed from header_rewrite rule when unquoted)

> Backslash/escape removed from header_rewrite rule when unquoted
> ---
>
> Key: TS-4993
> URL: https://issues.apache.org/jira/browse/TS-4993
> Project: Traffic Server
>  Issue Type: Bug
>  Components: Plugins
>Affects Versions: 7.0.0
>Reporter: Randall Meyer
>Assignee: Leif Hedstrom
> Fix For: 7.0.0
>
>  Time Spent: 2h 20m
>  Remaining Estimate: 0h
>
> Loading up a configuration with a header_rewrite rule of:
> {noformat}
> cond %{READ_RESPONSE_HDR_HOOK} [AND]
> cond %{PATH} /(\.html|\.js|\.png)(?:\?(.*))*$/ [AND]
> cond %{STATUS} >199 [AND]
> cond %{STATUS} <300
>   set-header Cache-Control "max-age=31536000, public
> {noformat}
> results in an call to abort() in matcher.h under ATS 7.0.0. This worked fine 
> under ATS 6.x (and probably 5.3.x)
> {noformat}
> (gdb) where
> #0  0x74f64625 in *__GI_raise (sig=) at 
> ../nptl/sysdeps/unix/sysv/linux/raise.c:64
> #1  0x74f65e05 in *__GI_abort () at abort.c:92
> #2  0x7fffe71dd3ff in Matchers::setRegex 
> (this=this@entry=0x7fffe5ac0f80) at matcher.h:98
> #3  0x7fffe71d7baa in Matchers::set (d=..., 
> this=0x7fffe5ac0f80) at matcher.h:119
> #4  ConditionPath::initialize (this=0x7fffe59a6d00, p=...) at 
> conditions.cc:260
> {noformat}
> The string comes to matcher with the escapes removed:
> {noformat}
> Adding condition: %{PATH} with arg: /(.html|.js|.png)(?:?(.*))*$/
> {noformat}
> If I add quotes around the regex, this regex is passed through correctly 
> escaped.
> Not sure if this is expected behavior or not. 
> This also seems related to TS-4797 and TS-4940. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (TS-4993) backslash/escape removed from header_rewrite rule when unquoted

[Bryan Call (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-4993?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Bryan Call updated TS-4993:
---
Fix Version/s: (was: 7.1.0)
   7.0.0

> backslash/escape removed from header_rewrite rule when unquoted
> ---
>
> Key: TS-4993
> URL: https://issues.apache.org/jira/browse/TS-4993
> Project: Traffic Server
>  Issue Type: Bug
>  Components: Plugins
>Affects Versions: 7.0.0
>Reporter: Randall Meyer
>Assignee: Leif Hedstrom
> Fix For: 7.0.0
>
>  Time Spent: 2h 20m
>  Remaining Estimate: 0h
>
> Loading up a configuration with a header_rewrite rule of:
> {noformat}
> cond %{READ_RESPONSE_HDR_HOOK} [AND]
> cond %{PATH} /(\.html|\.js|\.png)(?:\?(.*))*$/ [AND]
> cond %{STATUS} >199 [AND]
> cond %{STATUS} <300
>   set-header Cache-Control "max-age=31536000, public
> {noformat}
> results in an call to abort() in matcher.h under ATS 7.0.0. This worked fine 
> under ATS 6.x (and probably 5.3.x)
> {noformat}
> (gdb) where
> #0  0x74f64625 in *__GI_raise (sig=) at 
> ../nptl/sysdeps/unix/sysv/linux/raise.c:64
> #1  0x74f65e05 in *__GI_abort () at abort.c:92
> #2  0x7fffe71dd3ff in Matchers::setRegex 
> (this=this@entry=0x7fffe5ac0f80) at matcher.h:98
> #3  0x7fffe71d7baa in Matchers::set (d=..., 
> this=0x7fffe5ac0f80) at matcher.h:119
> #4  ConditionPath::initialize (this=0x7fffe59a6d00, p=...) at 
> conditions.cc:260
> {noformat}
> The string comes to matcher with the escapes removed:
> {noformat}
> Adding condition: %{PATH} with arg: /(.html|.js|.png)(?:?(.*))*$/
> {noformat}
> If I add quotes around the regex, this regex is passed through correctly 
> escaped.
> Not sure if this is expected behavior or not. 
> This also seems related to TS-4797 and TS-4940. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (TS-4993) Backslash/escape removed from header_rewrite rule when unquoted

[Bryan Call (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-4993?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Bryan Call updated TS-4993:
---
Backport to Version:   (was: 7.0.0)

> Backslash/escape removed from header_rewrite rule when unquoted
> ---
>
> Key: TS-4993
> URL: https://issues.apache.org/jira/browse/TS-4993
> Project: Traffic Server
>  Issue Type: Bug
>  Components: Plugins
>Affects Versions: 7.0.0
>Reporter: Randall Meyer
>Assignee: Leif Hedstrom
> Fix For: 7.0.0
>
>  Time Spent: 2h 20m
>  Remaining Estimate: 0h
>
> Loading up a configuration with a header_rewrite rule of:
> {noformat}
> cond %{READ_RESPONSE_HDR_HOOK} [AND]
> cond %{PATH} /(\.html|\.js|\.png)(?:\?(.*))*$/ [AND]
> cond %{STATUS} >199 [AND]
> cond %{STATUS} <300
>   set-header Cache-Control "max-age=31536000, public
> {noformat}
> results in an call to abort() in matcher.h under ATS 7.0.0. This worked fine 
> under ATS 6.x (and probably 5.3.x)
> {noformat}
> (gdb) where
> #0  0x74f64625 in *__GI_raise (sig=) at 
> ../nptl/sysdeps/unix/sysv/linux/raise.c:64
> #1  0x74f65e05 in *__GI_abort () at abort.c:92
> #2  0x7fffe71dd3ff in Matchers::setRegex 
> (this=this@entry=0x7fffe5ac0f80) at matcher.h:98
> #3  0x7fffe71d7baa in Matchers::set (d=..., 
> this=0x7fffe5ac0f80) at matcher.h:119
> #4  ConditionPath::initialize (this=0x7fffe59a6d00, p=...) at 
> conditions.cc:260
> {noformat}
> The string comes to matcher with the escapes removed:
> {noformat}
> Adding condition: %{PATH} with arg: /(.html|.js|.png)(?:?(.*))*$/
> {noformat}
> If I add quotes around the regex, this regex is passed through correctly 
> escaped.
> Not sure if this is expected behavior or not. 
> This also seems related to TS-4797 and TS-4940. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Work logged] (TS-4986) Memory leak in test_Map

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-4986?focusedWorklogId=31266=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-31266
 ]

ASF GitHub Bot logged work on TS-4986:
--

Author: ASF GitHub Bot
Created on: 27/Oct/16 17:53
Start Date: 27/Oct/16 17:53
Worklog Time Spent: 10m 
  Work Description: Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1159
  
FreeBSD build *successful*! See 
https://ci.trafficserver.apache.org/job/Github-FreeBSD/1115/ for details.
 



Issue Time Tracking
---

Worklog Id: (was: 31266)
Time Spent: 20m  (was: 10m)

> Memory leak in test_Map
> ---
>
> Key: TS-4986
> URL: https://issues.apache.org/jira/browse/TS-4986
> Project: Traffic Server
>  Issue Type: Bug
>  Components: Core, Tests
>Reporter: Bryan Call
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> {noformat}
> =
> ==22202==ERROR: LeakSanitizer: detected memory leaks
> Direct leak of 3216 byte(s) in 134 object(s) allocated from:
> #0 0x7f4d3de22ea0 in operator new(unsigned long) 
> (/lib64/libasan.so.3+0xc7ea0)
> #1 0x402df9 in test_TSHashTable() 
> /home/bcall/dev/apache/trafficserver/lib/ts/test_Map.cc:76
> #2 0x402380 in main 
> /home/bcall/dev/apache/trafficserver/lib/ts/test_Map.cc:214
> #3 0x7f4d3b09b730 in __libc_start_main (/lib64/libc.so.6+0x20730)
> Direct leak of 112 byte(s) in 1 object(s) allocated from:
> #0 0x7f4d3de21e60 in malloc (/lib64/libasan.so.3+0xc6e60)
> #1 0x7f4d3db28f85 in ats_malloc 
> /home/bcall/dev/apache/trafficserver/lib/ts/ink_memory.cc:59
> #2 0x406576 in DefaultAlloc::alloc(int) ../../lib/ts/defalloc.h:34
> #3 0x406576 in Vec 2>::set_expand() ../../lib/ts/Vec.h:781
> #4 0x406576 in HashMap DefaultAlloc>::put(char const*, int) ../../lib/ts/Map.h:552
> #5 0x401d90 in main 
> /home/bcall/dev/apache/trafficserver/lib/ts/test_Map.cc:174
> #6 0x7f4d3b09b730 in __libc_start_main (/lib64/libc.so.6+0x20730)
> Direct leak of 24 byte(s) in 1 object(s) allocated from:
> #0 0x7f4d3de21e60 in malloc (/lib64/libasan.so.3+0xc6e60)
> #1 0x7f4d3db28f85 in ats_malloc 
> /home/bcall/dev/apache/trafficserver/lib/ts/ink_memory.cc:59
> #2 0x4126bf in DefaultAlloc::alloc(int) ../../lib/ts/defalloc.h:34
> #3 0x4126bf in ConsCell DefaultAlloc>::operator new(unsigned long) ../../lib/ts/List.h:603
> #4 0x4126bf in List DefaultAlloc>::List(MapElem) ../../lib/ts/List.h:663
> #5 0x4126bf in ChainHashMap DefaultAlloc>::put(char const*, int) ../../lib/ts/Map.h:691
> #6 0x401f26 in main 
> /home/bcall/dev/apache/trafficserver/lib/ts/test_Map.cc:196
> #7 0x7f4d3b09b730 in __libc_start_main (/lib64/libc.so.6+0x20730)
> Direct leak of 24 byte(s) in 1 object(s) allocated from:
> #0 0x7f4d3de22ea0 in operator new(unsigned long) 
> (/lib64/libasan.so.3+0xc7ea0)
> #1 0x402d4a in test_TSHashTable() 
> /home/bcall/dev/apache/trafficserver/lib/ts/test_Map.cc:73
> #2 0x402380 in main 
> /home/bcall/dev/apache/trafficserver/lib/ts/test_Map.cc:214
> #3 0x7f4d3b09b730 in __libc_start_main (/lib64/libc.so.6+0x20730)
> Direct leak of 24 byte(s) in 1 object(s) allocated from:
> #0 0x7f4d3de21e60 in malloc (/lib64/libasan.so.3+0xc6e60)
> #1 0x7f4d3db28f85 in ats_malloc 
> /home/bcall/dev/apache/trafficserver/lib/ts/ink_memory.cc:59
> #2 0x4126bf in DefaultAlloc::alloc(int) ../../lib/ts/defalloc.h:34
> #3 0x4126bf in ConsCell DefaultAlloc>::operator new(unsigned long) ../../lib/ts/List.h:603
> #4 0x4126bf in List DefaultAlloc>::List(MapElem) ../../lib/ts/List.h:663
> #5 0x4126bf in ChainHashMap DefaultAlloc>::put(char const*, int) ../../lib/ts/Map.h:691
> #6 0x401efe in main 
> /home/bcall/dev/apache/trafficserver/lib/ts/test_Map.cc:194
> #7 0x7f4d3b09b730 in __libc_start_main (/lib64/libc.so.6+0x20730)
> Direct leak of 24 byte(s) in 1 object(s) allocated from:
> #0 0x7f4d3de21e60 in malloc (/lib64/libasan.so.3+0xc6e60)
> #1 0x7f4d3db28f85 in ats_malloc 
> /home/bcall/dev/apache/trafficserver/lib/ts/ink_memory.cc:59
> #2 0x4126bf in DefaultAlloc::alloc(int) ../../lib/ts/defalloc.h:34
> #3 0x4126bf in ConsCell DefaultAlloc>::operator new(unsigned long) ../../lib/ts/List.h:603
> #4 0x4126bf in List DefaultAlloc>::List(MapElem) ../../lib/ts/List.h:663
> #5 0x4126bf in ChainHashMap DefaultAlloc>::put(char const*, int) ../../lib/ts/Map.h:691
> #6 0x401f12 in main 
> /home/bcall/dev/apache/trafficserver/lib/ts/test_Map.cc:195
> #7 0x7f4d3b09b730 in __libc_start_main (/lib64/libc.so.6+0x20730)
> Direct leak of 24 byte(s) in 1 object(s) allocated 

[jira] [Work logged] (TS-4986) Memory leak in test_Map

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-4986?focusedWorklogId=31267=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-31267
 ]

ASF GitHub Bot logged work on TS-4986:
--

Author: ASF GitHub Bot
Created on: 27/Oct/16 17:53
Start Date: 27/Oct/16 17:53
Worklog Time Spent: 10m 
  Work Description: Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1159
  
Linux build *successful*! See 
https://ci.trafficserver.apache.org/job/Github-Linux/1009/ for details.
 



Issue Time Tracking
---

Worklog Id: (was: 31267)
Time Spent: 0.5h  (was: 20m)

> Memory leak in test_Map
> ---
>
> Key: TS-4986
> URL: https://issues.apache.org/jira/browse/TS-4986
> Project: Traffic Server
>  Issue Type: Bug
>  Components: Core, Tests
>Reporter: Bryan Call
>  Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> {noformat}
> =
> ==22202==ERROR: LeakSanitizer: detected memory leaks
> Direct leak of 3216 byte(s) in 134 object(s) allocated from:
> #0 0x7f4d3de22ea0 in operator new(unsigned long) 
> (/lib64/libasan.so.3+0xc7ea0)
> #1 0x402df9 in test_TSHashTable() 
> /home/bcall/dev/apache/trafficserver/lib/ts/test_Map.cc:76
> #2 0x402380 in main 
> /home/bcall/dev/apache/trafficserver/lib/ts/test_Map.cc:214
> #3 0x7f4d3b09b730 in __libc_start_main (/lib64/libc.so.6+0x20730)
> Direct leak of 112 byte(s) in 1 object(s) allocated from:
> #0 0x7f4d3de21e60 in malloc (/lib64/libasan.so.3+0xc6e60)
> #1 0x7f4d3db28f85 in ats_malloc 
> /home/bcall/dev/apache/trafficserver/lib/ts/ink_memory.cc:59
> #2 0x406576 in DefaultAlloc::alloc(int) ../../lib/ts/defalloc.h:34
> #3 0x406576 in Vec 2>::set_expand() ../../lib/ts/Vec.h:781
> #4 0x406576 in HashMap DefaultAlloc>::put(char const*, int) ../../lib/ts/Map.h:552
> #5 0x401d90 in main 
> /home/bcall/dev/apache/trafficserver/lib/ts/test_Map.cc:174
> #6 0x7f4d3b09b730 in __libc_start_main (/lib64/libc.so.6+0x20730)
> Direct leak of 24 byte(s) in 1 object(s) allocated from:
> #0 0x7f4d3de21e60 in malloc (/lib64/libasan.so.3+0xc6e60)
> #1 0x7f4d3db28f85 in ats_malloc 
> /home/bcall/dev/apache/trafficserver/lib/ts/ink_memory.cc:59
> #2 0x4126bf in DefaultAlloc::alloc(int) ../../lib/ts/defalloc.h:34
> #3 0x4126bf in ConsCell DefaultAlloc>::operator new(unsigned long) ../../lib/ts/List.h:603
> #4 0x4126bf in List DefaultAlloc>::List(MapElem) ../../lib/ts/List.h:663
> #5 0x4126bf in ChainHashMap DefaultAlloc>::put(char const*, int) ../../lib/ts/Map.h:691
> #6 0x401f26 in main 
> /home/bcall/dev/apache/trafficserver/lib/ts/test_Map.cc:196
> #7 0x7f4d3b09b730 in __libc_start_main (/lib64/libc.so.6+0x20730)
> Direct leak of 24 byte(s) in 1 object(s) allocated from:
> #0 0x7f4d3de22ea0 in operator new(unsigned long) 
> (/lib64/libasan.so.3+0xc7ea0)
> #1 0x402d4a in test_TSHashTable() 
> /home/bcall/dev/apache/trafficserver/lib/ts/test_Map.cc:73
> #2 0x402380 in main 
> /home/bcall/dev/apache/trafficserver/lib/ts/test_Map.cc:214
> #3 0x7f4d3b09b730 in __libc_start_main (/lib64/libc.so.6+0x20730)
> Direct leak of 24 byte(s) in 1 object(s) allocated from:
> #0 0x7f4d3de21e60 in malloc (/lib64/libasan.so.3+0xc6e60)
> #1 0x7f4d3db28f85 in ats_malloc 
> /home/bcall/dev/apache/trafficserver/lib/ts/ink_memory.cc:59
> #2 0x4126bf in DefaultAlloc::alloc(int) ../../lib/ts/defalloc.h:34
> #3 0x4126bf in ConsCell DefaultAlloc>::operator new(unsigned long) ../../lib/ts/List.h:603
> #4 0x4126bf in List DefaultAlloc>::List(MapElem) ../../lib/ts/List.h:663
> #5 0x4126bf in ChainHashMap DefaultAlloc>::put(char const*, int) ../../lib/ts/Map.h:691
> #6 0x401efe in main 
> /home/bcall/dev/apache/trafficserver/lib/ts/test_Map.cc:194
> #7 0x7f4d3b09b730 in __libc_start_main (/lib64/libc.so.6+0x20730)
> Direct leak of 24 byte(s) in 1 object(s) allocated from:
> #0 0x7f4d3de21e60 in malloc (/lib64/libasan.so.3+0xc6e60)
> #1 0x7f4d3db28f85 in ats_malloc 
> /home/bcall/dev/apache/trafficserver/lib/ts/ink_memory.cc:59
> #2 0x4126bf in DefaultAlloc::alloc(int) ../../lib/ts/defalloc.h:34
> #3 0x4126bf in ConsCell DefaultAlloc>::operator new(unsigned long) ../../lib/ts/List.h:603
> #4 0x4126bf in List DefaultAlloc>::List(MapElem) ../../lib/ts/List.h:663
> #5 0x4126bf in ChainHashMap DefaultAlloc>::put(char const*, int) ../../lib/ts/Map.h:691
> #6 0x401f12 in main 
> /home/bcall/dev/apache/trafficserver/lib/ts/test_Map.cc:195
> #7 0x7f4d3b09b730 in __libc_start_main (/lib64/libc.so.6+0x20730)
> Direct leak of 24 byte(s) in 1 object(s) allocated from:

[GitHub] trafficserver issue #1159: TS-4986: Memory leak in test_Map

[atsci]

Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1159
  
Linux build *successful*! See 
https://ci.trafficserver.apache.org/job/Github-Linux/1009/ for details.
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1159: TS-4986: Memory leak in test_Map

[atsci]

Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1159
  
FreeBSD build *successful*! See 
https://ci.trafficserver.apache.org/job/Github-FreeBSD/1115/ for details.
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver pull request #1159: TS-4986: Memory leak in test_Map

[bryancall]

GitHub user bryancall opened a pull request:

https://github.com/apache/trafficserver/pull/1159

TS-4986: Memory leak in test_Map



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/bryancall/trafficserver TS-4986

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/trafficserver/pull/1159.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1159


commit 4bcbff442e930ff381e337f007dcf15aed9cf465
Author: Bryan Call 
Date:   2016-10-27T17:35:37Z

TS-4986: Memory leak in test_Map




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Work logged] (TS-4986) Memory leak in test_Map

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-4986?focusedWorklogId=31265=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-31265
 ]

ASF GitHub Bot logged work on TS-4986:
--

Author: ASF GitHub Bot
Created on: 27/Oct/16 17:37
Start Date: 27/Oct/16 17:37
Worklog Time Spent: 10m 
  Work Description: GitHub user bryancall opened a pull request:

https://github.com/apache/trafficserver/pull/1159

TS-4986: Memory leak in test_Map



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/bryancall/trafficserver TS-4986

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/trafficserver/pull/1159.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1159


commit 4bcbff442e930ff381e337f007dcf15aed9cf465
Author: Bryan Call 
Date:   2016-10-27T17:35:37Z

TS-4986: Memory leak in test_Map




Issue Time Tracking
---

Worklog Id: (was: 31265)
Time Spent: 10m
Remaining Estimate: 0h

> Memory leak in test_Map
> ---
>
> Key: TS-4986
> URL: https://issues.apache.org/jira/browse/TS-4986
> Project: Traffic Server
>  Issue Type: Bug
>  Components: Core, Tests
>Reporter: Bryan Call
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> {noformat}
> =
> ==22202==ERROR: LeakSanitizer: detected memory leaks
> Direct leak of 3216 byte(s) in 134 object(s) allocated from:
> #0 0x7f4d3de22ea0 in operator new(unsigned long) 
> (/lib64/libasan.so.3+0xc7ea0)
> #1 0x402df9 in test_TSHashTable() 
> /home/bcall/dev/apache/trafficserver/lib/ts/test_Map.cc:76
> #2 0x402380 in main 
> /home/bcall/dev/apache/trafficserver/lib/ts/test_Map.cc:214
> #3 0x7f4d3b09b730 in __libc_start_main (/lib64/libc.so.6+0x20730)
> Direct leak of 112 byte(s) in 1 object(s) allocated from:
> #0 0x7f4d3de21e60 in malloc (/lib64/libasan.so.3+0xc6e60)
> #1 0x7f4d3db28f85 in ats_malloc 
> /home/bcall/dev/apache/trafficserver/lib/ts/ink_memory.cc:59
> #2 0x406576 in DefaultAlloc::alloc(int) ../../lib/ts/defalloc.h:34
> #3 0x406576 in Vec 2>::set_expand() ../../lib/ts/Vec.h:781
> #4 0x406576 in HashMap DefaultAlloc>::put(char const*, int) ../../lib/ts/Map.h:552
> #5 0x401d90 in main 
> /home/bcall/dev/apache/trafficserver/lib/ts/test_Map.cc:174
> #6 0x7f4d3b09b730 in __libc_start_main (/lib64/libc.so.6+0x20730)
> Direct leak of 24 byte(s) in 1 object(s) allocated from:
> #0 0x7f4d3de21e60 in malloc (/lib64/libasan.so.3+0xc6e60)
> #1 0x7f4d3db28f85 in ats_malloc 
> /home/bcall/dev/apache/trafficserver/lib/ts/ink_memory.cc:59
> #2 0x4126bf in DefaultAlloc::alloc(int) ../../lib/ts/defalloc.h:34
> #3 0x4126bf in ConsCell DefaultAlloc>::operator new(unsigned long) ../../lib/ts/List.h:603
> #4 0x4126bf in List DefaultAlloc>::List(MapElem) ../../lib/ts/List.h:663
> #5 0x4126bf in ChainHashMap DefaultAlloc>::put(char const*, int) ../../lib/ts/Map.h:691
> #6 0x401f26 in main 
> /home/bcall/dev/apache/trafficserver/lib/ts/test_Map.cc:196
> #7 0x7f4d3b09b730 in __libc_start_main (/lib64/libc.so.6+0x20730)
> Direct leak of 24 byte(s) in 1 object(s) allocated from:
> #0 0x7f4d3de22ea0 in operator new(unsigned long) 
> (/lib64/libasan.so.3+0xc7ea0)
> #1 0x402d4a in test_TSHashTable() 
> /home/bcall/dev/apache/trafficserver/lib/ts/test_Map.cc:73
> #2 0x402380 in main 
> /home/bcall/dev/apache/trafficserver/lib/ts/test_Map.cc:214
> #3 0x7f4d3b09b730 in __libc_start_main (/lib64/libc.so.6+0x20730)
> Direct leak of 24 byte(s) in 1 object(s) allocated from:
> #0 0x7f4d3de21e60 in malloc (/lib64/libasan.so.3+0xc6e60)
> #1 0x7f4d3db28f85 in ats_malloc 
> /home/bcall/dev/apache/trafficserver/lib/ts/ink_memory.cc:59
> #2 0x4126bf in DefaultAlloc::alloc(int) ../../lib/ts/defalloc.h:34
> #3 0x4126bf in ConsCell DefaultAlloc>::operator new(unsigned long) ../../lib/ts/List.h:603
> #4 0x4126bf in List DefaultAlloc>::List(MapElem) ../../lib/ts/List.h:663
> #5 0x4126bf in ChainHashMap DefaultAlloc>::put(char const*, int) ../../lib/ts/Map.h:691
> #6 0x401efe in main 
> /home/bcall/dev/apache/trafficserver/lib/ts/test_Map.cc:194
> #7 0x7f4d3b09b730 in __libc_start_main (/lib64/libc.so.6+0x20730)
> Direct leak of 24 byte(s) in 1 object(s) allocated from:
> #0 0x7f4d3de21e60 in malloc (/lib64/libasan.so.3+0xc6e60)
> #1 0x7f4d3db28f85 in ats_malloc 
> /home/bcall/dev/apache/trafficserver/lib/ts/ink_memory.cc:59
> #2 0x4126bf in DefaultAlloc::alloc(int) 

[jira] [Work logged] (TS-5009) CID 1022011 Logically dead code

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-5009?focusedWorklogId=31264=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-31264
 ]

ASF GitHub Bot logged work on TS-5009:
--

Author: ASF GitHub Bot
Created on: 27/Oct/16 17:03
Start Date: 27/Oct/16 17:03
Worklog Time Spent: 10m 
  Work Description: Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1152
  
FreeBSD build *successful*! See 
https://ci.trafficserver.apache.org/job/Github-FreeBSD/1114/ for details.
 



Issue Time Tracking
---

Worklog Id: (was: 31264)
Time Spent: 1h 50m  (was: 1h 40m)

> CID 1022011 Logically dead code
> ---
>
> Key: TS-5009
> URL: https://issues.apache.org/jira/browse/TS-5009
> Project: Traffic Server
>  Issue Type: Bug
>  Components: Core
>Reporter: Nathan Garabedian
>Assignee: Nathan Garabedian
>  Labels: coverity
> Fix For: 7.1.0
>
>  Time Spent: 1h 50m
>  Remaining Estimate: 0h
>
> TS_INLINE char ::operator[](int64_t i)
> 686{
> 687  static char _error = '\0';
> 688  IOBufferBlock *b   = block.get();
> 689
> 690  i += start_offset;
>   cond_null: Condition b, taking false branch. Now the value of b is NULL.
> 691  while (b) {
> 692int64_t bytes = b->read_avail();
> 693if (bytes > i)
> 694  return b->start()[i];
> 695i -= bytes;
> 696b = b->next.get();
> 697  }
> 698
> 699  ink_assert(!"out of range");
>   const: At condition !!b, the value of b must be equal to 0.
>   null: At condition !!b, the value of b must be NULL.
>   dead_error_condition: The condition !!b cannot be true.
> 700  if (unlikely(b)) {
>   
> CID 1022011 (#1 of 1): Logically dead code (DEADCODE)
> dead_error_line: Execution cannot reach this statement: return b->start();.
> 701return *b->start();
> 702  }



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] trafficserver issue #1152: TS-5009 CID 1022011 Logically dead code removal

[atsci]

Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1152
  
FreeBSD build *successful*! See 
https://ci.trafficserver.apache.org/job/Github-FreeBSD/1114/ for details.
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1152: TS-5009 CID 1022011 Logically dead code removal

[ngara]

Github user ngara commented on the issue:

https://github.com/apache/trafficserver/pull/1152
  
I took a close look at this and I didn't make the change that caused 
clang-format to fail here


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Work logged] (TS-5009) CID 1022011 Logically dead code

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-5009?focusedWorklogId=31261=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-31261
 ]

ASF GitHub Bot logged work on TS-5009:
--

Author: ASF GitHub Bot
Created on: 27/Oct/16 16:53
Start Date: 27/Oct/16 16:53
Worklog Time Spent: 10m 
  Work Description: Github user ngara commented on the issue:

https://github.com/apache/trafficserver/pull/1152
  
I took a close look at this and I didn't make the change that caused 
clang-format to fail here


Issue Time Tracking
---

Worklog Id: (was: 31261)
Time Spent: 1h 20m  (was: 1h 10m)

> CID 1022011 Logically dead code
> ---
>
> Key: TS-5009
> URL: https://issues.apache.org/jira/browse/TS-5009
> Project: Traffic Server
>  Issue Type: Bug
>  Components: Core
>Reporter: Nathan Garabedian
>Assignee: Nathan Garabedian
>  Labels: coverity
> Fix For: 7.1.0
>
>  Time Spent: 1h 20m
>  Remaining Estimate: 0h
>
> TS_INLINE char ::operator[](int64_t i)
> 686{
> 687  static char _error = '\0';
> 688  IOBufferBlock *b   = block.get();
> 689
> 690  i += start_offset;
>   cond_null: Condition b, taking false branch. Now the value of b is NULL.
> 691  while (b) {
> 692int64_t bytes = b->read_avail();
> 693if (bytes > i)
> 694  return b->start()[i];
> 695i -= bytes;
> 696b = b->next.get();
> 697  }
> 698
> 699  ink_assert(!"out of range");
>   const: At condition !!b, the value of b must be equal to 0.
>   null: At condition !!b, the value of b must be NULL.
>   dead_error_condition: The condition !!b cannot be true.
> 700  if (unlikely(b)) {
>   
> CID 1022011 (#1 of 1): Logically dead code (DEADCODE)
> dead_error_line: Execution cannot reach this statement: return b->start();.
> 701return *b->start();
> 702  }



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Work logged] (TS-5009) CID 1022011 Logically dead code

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-5009?focusedWorklogId=31263=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-31263
 ]

ASF GitHub Bot logged work on TS-5009:
--

Author: ASF GitHub Bot
Created on: 27/Oct/16 16:58
Start Date: 27/Oct/16 16:58
Worklog Time Spent: 10m 
  Work Description: Github user ngara commented on the issue:

https://github.com/apache/trafficserver/pull/1152
  
OK, figured it out.  removing a variable made the equals signs want to line 
up differently on a line i didnt modify.  Fixed!


Issue Time Tracking
---

Worklog Id: (was: 31263)
Time Spent: 1h 40m  (was: 1.5h)

> CID 1022011 Logically dead code
> ---
>
> Key: TS-5009
> URL: https://issues.apache.org/jira/browse/TS-5009
> Project: Traffic Server
>  Issue Type: Bug
>  Components: Core
>Reporter: Nathan Garabedian
>Assignee: Nathan Garabedian
>  Labels: coverity
> Fix For: 7.1.0
>
>  Time Spent: 1h 40m
>  Remaining Estimate: 0h
>
> TS_INLINE char ::operator[](int64_t i)
> 686{
> 687  static char _error = '\0';
> 688  IOBufferBlock *b   = block.get();
> 689
> 690  i += start_offset;
>   cond_null: Condition b, taking false branch. Now the value of b is NULL.
> 691  while (b) {
> 692int64_t bytes = b->read_avail();
> 693if (bytes > i)
> 694  return b->start()[i];
> 695i -= bytes;
> 696b = b->next.get();
> 697  }
> 698
> 699  ink_assert(!"out of range");
>   const: At condition !!b, the value of b must be equal to 0.
>   null: At condition !!b, the value of b must be NULL.
>   dead_error_condition: The condition !!b cannot be true.
> 700  if (unlikely(b)) {
>   
> CID 1022011 (#1 of 1): Logically dead code (DEADCODE)
> dead_error_line: Execution cannot reach this statement: return b->start();.
> 701return *b->start();
> 702  }



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] trafficserver issue #1152: TS-5009 CID 1022011 Logically dead code removal

[ngara]

Github user ngara commented on the issue:

https://github.com/apache/trafficserver/pull/1152
  
OK, figured it out.  removing a variable made the equals signs want to line 
up differently on a line i didnt modify.  Fixed!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Work logged] (TS-5009) CID 1022011 Logically dead code

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-5009?focusedWorklogId=31262=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-31262
 ]

ASF GitHub Bot logged work on TS-5009:
--

Author: ASF GitHub Bot
Created on: 27/Oct/16 16:53
Start Date: 27/Oct/16 16:53
Worklog Time Spent: 10m 
  Work Description: Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1152
  
Linux build *failed*! See 
https://ci.trafficserver.apache.org/job/Github-Linux/1008/ for details.
 



Issue Time Tracking
---

Worklog Id: (was: 31262)
Time Spent: 1.5h  (was: 1h 20m)

> CID 1022011 Logically dead code
> ---
>
> Key: TS-5009
> URL: https://issues.apache.org/jira/browse/TS-5009
> Project: Traffic Server
>  Issue Type: Bug
>  Components: Core
>Reporter: Nathan Garabedian
>Assignee: Nathan Garabedian
>  Labels: coverity
> Fix For: 7.1.0
>
>  Time Spent: 1.5h
>  Remaining Estimate: 0h
>
> TS_INLINE char ::operator[](int64_t i)
> 686{
> 687  static char _error = '\0';
> 688  IOBufferBlock *b   = block.get();
> 689
> 690  i += start_offset;
>   cond_null: Condition b, taking false branch. Now the value of b is NULL.
> 691  while (b) {
> 692int64_t bytes = b->read_avail();
> 693if (bytes > i)
> 694  return b->start()[i];
> 695i -= bytes;
> 696b = b->next.get();
> 697  }
> 698
> 699  ink_assert(!"out of range");
>   const: At condition !!b, the value of b must be equal to 0.
>   null: At condition !!b, the value of b must be NULL.
>   dead_error_condition: The condition !!b cannot be true.
> 700  if (unlikely(b)) {
>   
> CID 1022011 (#1 of 1): Logically dead code (DEADCODE)
> dead_error_line: Execution cannot reach this statement: return b->start();.
> 701return *b->start();
> 702  }



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] trafficserver issue #1152: TS-5009 CID 1022011 Logically dead code removal

[atsci]

Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1152
  
Linux build *failed*! See 
https://ci.trafficserver.apache.org/job/Github-Linux/1008/ for details.
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Work logged] (TS-5009) CID 1022011 Logically dead code

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-5009?focusedWorklogId=31260=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-31260
 ]

ASF GitHub Bot logged work on TS-5009:
--

Author: ASF GitHub Bot
Created on: 27/Oct/16 16:47
Start Date: 27/Oct/16 16:47
Worklog Time Spent: 10m 
  Work Description: Github user zwoop commented on the issue:

https://github.com/apache/trafficserver/pull/1152
  
[approve ci]


Issue Time Tracking
---

Worklog Id: (was: 31260)
Time Spent: 1h 10m  (was: 1h)

> CID 1022011 Logically dead code
> ---
>
> Key: TS-5009
> URL: https://issues.apache.org/jira/browse/TS-5009
> Project: Traffic Server
>  Issue Type: Bug
>  Components: Core
>Reporter: Nathan Garabedian
>Assignee: Nathan Garabedian
>  Labels: coverity
> Fix For: 7.1.0
>
>  Time Spent: 1h 10m
>  Remaining Estimate: 0h
>
> TS_INLINE char ::operator[](int64_t i)
> 686{
> 687  static char _error = '\0';
> 688  IOBufferBlock *b   = block.get();
> 689
> 690  i += start_offset;
>   cond_null: Condition b, taking false branch. Now the value of b is NULL.
> 691  while (b) {
> 692int64_t bytes = b->read_avail();
> 693if (bytes > i)
> 694  return b->start()[i];
> 695i -= bytes;
> 696b = b->next.get();
> 697  }
> 698
> 699  ink_assert(!"out of range");
>   const: At condition !!b, the value of b must be equal to 0.
>   null: At condition !!b, the value of b must be NULL.
>   dead_error_condition: The condition !!b cannot be true.
> 700  if (unlikely(b)) {
>   
> CID 1022011 (#1 of 1): Logically dead code (DEADCODE)
> dead_error_line: Execution cannot reach this statement: return b->start();.
> 701return *b->start();
> 702  }



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] trafficserver issue #1152: TS-5009 CID 1022011 Logically dead code removal

[zwoop]

Github user zwoop commented on the issue:

https://github.com/apache/trafficserver/pull/1152
  
[approve ci]


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Work logged] (TS-5009) CID 1022011 Logically dead code

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-5009?focusedWorklogId=31259=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-31259
 ]

ASF GitHub Bot logged work on TS-5009:
--

Author: ASF GitHub Bot
Created on: 27/Oct/16 16:44
Start Date: 27/Oct/16 16:44
Worklog Time Spent: 10m 
  Work Description: Github user ngara commented on the issue:

https://github.com/apache/trafficserver/pull/1152
  
I put the plugin hook in and got it working.  Thanks for the suggestion.

Nathan

> On Oct 26, 2016, at 9:01 PM, Leif Hedstrom  
wrote:
> 
> @ngara  I think this is failing because of 
clang-format. I recommend you copy the pre-commit githook into your .git/hooks 
tree.
> 
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub 
, or 
mute the thread 
.
> 




Issue Time Tracking
---

Worklog Id: (was: 31259)
Time Spent: 1h  (was: 50m)

> CID 1022011 Logically dead code
> ---
>
> Key: TS-5009
> URL: https://issues.apache.org/jira/browse/TS-5009
> Project: Traffic Server
>  Issue Type: Bug
>  Components: Core
>Reporter: Nathan Garabedian
>Assignee: Nathan Garabedian
>  Labels: coverity
> Fix For: 7.1.0
>
>  Time Spent: 1h
>  Remaining Estimate: 0h
>
> TS_INLINE char ::operator[](int64_t i)
> 686{
> 687  static char _error = '\0';
> 688  IOBufferBlock *b   = block.get();
> 689
> 690  i += start_offset;
>   cond_null: Condition b, taking false branch. Now the value of b is NULL.
> 691  while (b) {
> 692int64_t bytes = b->read_avail();
> 693if (bytes > i)
> 694  return b->start()[i];
> 695i -= bytes;
> 696b = b->next.get();
> 697  }
> 698
> 699  ink_assert(!"out of range");
>   const: At condition !!b, the value of b must be equal to 0.
>   null: At condition !!b, the value of b must be NULL.
>   dead_error_condition: The condition !!b cannot be true.
> 700  if (unlikely(b)) {
>   
> CID 1022011 (#1 of 1): Logically dead code (DEADCODE)
> dead_error_line: Execution cannot reach this statement: return b->start();.
> 701return *b->start();
> 702  }



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] trafficserver issue #1152: TS-5009 CID 1022011 Logically dead code removal

[ngara]

Github user ngara commented on the issue:

https://github.com/apache/trafficserver/pull/1152
  
I put the plugin hook in and got it working.  Thanks for the suggestion.

Nathan

> On Oct 26, 2016, at 9:01 PM, Leif Hedstrom  
wrote:
> 
> @ngara  I think this is failing because of 
clang-format. I recommend you copy the pre-commit githook into your .git/hooks 
tree.
> 
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub 
, or 
mute the thread 
.
> 




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Work logged] (TS-5011) Memory leak in CFLUS compression

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-5011?focusedWorklogId=31258=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-31258
 ]

ASF GitHub Bot logged work on TS-5011:
--

Author: ASF GitHub Bot
Created on: 27/Oct/16 16:23
Start Date: 27/Oct/16 16:23
Worklog Time Spent: 10m 
  Work Description: Github user zwoop commented on the issue:

https://github.com/apache/trafficserver/pull/1154
  
@SolidWallOfCode I agree, file a lira :).


Issue Time Tracking
---

Worklog Id: (was: 31258)
Time Spent: 1h  (was: 50m)

> Memory leak in CFLUS compression
> 
>
> Key: TS-5011
> URL: https://issues.apache.org/jira/browse/TS-5011
> Project: Traffic Server
>  Issue Type: Bug
>  Components: Cache
>Reporter: Leif Hedstrom
>Assignee: Leif Hedstrom
> Fix For: 7.1.0
>
>  Time Spent: 1h
>  Remaining Estimate: 0h
>
> John sent me the fix for this, all the credit to him.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] trafficserver issue #1154: TS-5011: Fixes memory leak in CLFUS compression

[zwoop]

Github user zwoop commented on the issue:

https://github.com/apache/trafficserver/pull/1154
  
@SolidWallOfCode I agree, file a lira :).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Work logged] (TS-5011) Memory leak in CFLUS compression

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-5011?focusedWorklogId=31257=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-31257
 ]

ASF GitHub Bot logged work on TS-5011:
--

Author: ASF GitHub Bot
Created on: 27/Oct/16 16:08
Start Date: 27/Oct/16 16:08
Worklog Time Spent: 10m 
  Work Description: Github user SolidWallOfCode commented on the issue:

https://github.com/apache/trafficserver/pull/1154
  
It looks OK. I really do think we should do a more thorough fix, such as 
with `std::unique_ptr` or `ats_scoped_str` or even using `_alloca`. 


Issue Time Tracking
---

Worklog Id: (was: 31257)
Time Spent: 50m  (was: 40m)

> Memory leak in CFLUS compression
> 
>
> Key: TS-5011
> URL: https://issues.apache.org/jira/browse/TS-5011
> Project: Traffic Server
>  Issue Type: Bug
>  Components: Cache
>Reporter: Leif Hedstrom
>Assignee: Leif Hedstrom
> Fix For: 7.1.0
>
>  Time Spent: 50m
>  Remaining Estimate: 0h
>
> John sent me the fix for this, all the credit to him.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] trafficserver issue #1154: TS-5011: Fixes memory leak in CLFUS compression

[SolidWallOfCode]

Github user SolidWallOfCode commented on the issue:

https://github.com/apache/trafficserver/pull/1154
  
It looks OK. I really do think we should do a more thorough fix, such as 
with `std::unique_ptr` or `ats_scoped_str` or even using `_alloca`. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Updated] (TS-4405) Remove proxy.config.http.parse.allow_non_http ?

[Leif Hedstrom (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-4405?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Leif Hedstrom updated TS-4405:
--
Fix Version/s: (was: 7.1.0)
   8.0.0

> Remove proxy.config.http.parse.allow_non_http ?
> ---
>
> Key: TS-4405
> URL: https://issues.apache.org/jira/browse/TS-4405
> Project: Traffic Server
>  Issue Type: Improvement
>  Components: Configuration, HTTP
>Reporter: Leif Hedstrom
>Assignee: Leif Hedstrom
> Fix For: 8.0.0
>
>
> This option, undocumented, seems pretty useless. As far as I can tell, it 
> allows the HTTP response to exclude e.g. HTTP/1.1. Does anyone actually use / 
> need this ? Seems that enabling would cause more harm than good?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (TS-4993) backslash/escape removed from header_rewrite rule when unquoted

[Leif Hedstrom (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-4993?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Leif Hedstrom updated TS-4993:
--
Backport to Version: 7.0.0

> backslash/escape removed from header_rewrite rule when unquoted
> ---
>
> Key: TS-4993
> URL: https://issues.apache.org/jira/browse/TS-4993
> Project: Traffic Server
>  Issue Type: Bug
>  Components: Plugins
>Affects Versions: 7.0.0
>Reporter: Randall Meyer
>Assignee: Leif Hedstrom
> Fix For: 7.1.0
>
>  Time Spent: 2h 20m
>  Remaining Estimate: 0h
>
> Loading up a configuration with a header_rewrite rule of:
> {noformat}
> cond %{READ_RESPONSE_HDR_HOOK} [AND]
> cond %{PATH} /(\.html|\.js|\.png)(?:\?(.*))*$/ [AND]
> cond %{STATUS} >199 [AND]
> cond %{STATUS} <300
>   set-header Cache-Control "max-age=31536000, public
> {noformat}
> results in an call to abort() in matcher.h under ATS 7.0.0. This worked fine 
> under ATS 6.x (and probably 5.3.x)
> {noformat}
> (gdb) where
> #0  0x74f64625 in *__GI_raise (sig=) at 
> ../nptl/sysdeps/unix/sysv/linux/raise.c:64
> #1  0x74f65e05 in *__GI_abort () at abort.c:92
> #2  0x7fffe71dd3ff in Matchers::setRegex 
> (this=this@entry=0x7fffe5ac0f80) at matcher.h:98
> #3  0x7fffe71d7baa in Matchers::set (d=..., 
> this=0x7fffe5ac0f80) at matcher.h:119
> #4  ConditionPath::initialize (this=0x7fffe59a6d00, p=...) at 
> conditions.cc:260
> {noformat}
> The string comes to matcher with the escapes removed:
> {noformat}
> Adding condition: %{PATH} with arg: /(.html|.js|.png)(?:?(.*))*$/
> {noformat}
> If I add quotes around the regex, this regex is passed through correctly 
> escaped.
> Not sure if this is expected behavior or not. 
> This also seems related to TS-4797 and TS-4940. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Resolved] (TS-4993) backslash/escape removed from header_rewrite rule when unquoted

[Leif Hedstrom (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-4993?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Leif Hedstrom resolved TS-4993.
---
Resolution: Fixed

> backslash/escape removed from header_rewrite rule when unquoted
> ---
>
> Key: TS-4993
> URL: https://issues.apache.org/jira/browse/TS-4993
> Project: Traffic Server
>  Issue Type: Bug
>  Components: Plugins
>Affects Versions: 7.0.0
>Reporter: Randall Meyer
>Assignee: Leif Hedstrom
> Fix For: 7.1.0
>
>  Time Spent: 2h 20m
>  Remaining Estimate: 0h
>
> Loading up a configuration with a header_rewrite rule of:
> {noformat}
> cond %{READ_RESPONSE_HDR_HOOK} [AND]
> cond %{PATH} /(\.html|\.js|\.png)(?:\?(.*))*$/ [AND]
> cond %{STATUS} >199 [AND]
> cond %{STATUS} <300
>   set-header Cache-Control "max-age=31536000, public
> {noformat}
> results in an call to abort() in matcher.h under ATS 7.0.0. This worked fine 
> under ATS 6.x (and probably 5.3.x)
> {noformat}
> (gdb) where
> #0  0x74f64625 in *__GI_raise (sig=) at 
> ../nptl/sysdeps/unix/sysv/linux/raise.c:64
> #1  0x74f65e05 in *__GI_abort () at abort.c:92
> #2  0x7fffe71dd3ff in Matchers::setRegex 
> (this=this@entry=0x7fffe5ac0f80) at matcher.h:98
> #3  0x7fffe71d7baa in Matchers::set (d=..., 
> this=0x7fffe5ac0f80) at matcher.h:119
> #4  ConditionPath::initialize (this=0x7fffe59a6d00, p=...) at 
> conditions.cc:260
> {noformat}
> The string comes to matcher with the escapes removed:
> {noformat}
> Adding condition: %{PATH} with arg: /(.html|.js|.png)(?:?(.*))*$/
> {noformat}
> If I add quotes around the regex, this regex is passed through correctly 
> escaped.
> Not sure if this is expected behavior or not. 
> This also seems related to TS-4797 and TS-4940. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Resolved] (TS-4815) CID 1267839 dead code in /mgmt/api/CfgContextManager.cc: return TS_ERR_PARAMS;

[Leif Hedstrom (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-4815?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Leif Hedstrom resolved TS-4815.
---
Resolution: Fixed

> CID 1267839 dead code in /mgmt/api/CfgContextManager.cc: return TS_ERR_PARAMS;
> --
>
> Key: TS-4815
> URL: https://issues.apache.org/jira/browse/TS-4815
> Project: Traffic Server
>  Issue Type: Bug
>  Components: Management API
>Reporter: Nathan Garabedian
>Assignee: Nathan Garabedian
> Fix For: 7.1.0
>
>  Time Spent: 2.5h
>  Remaining Estimate: 0h
>
>   cond_notnull: Condition ctx, taking true branch. Now the value of ctx 
> is not NULL.
> 165  ink_assert(ctx);
>   notnull: At condition ctx, the value of ctx cannot be NULL.
>   dead_error_condition: The condition !ctx cannot be true.
> 166  if (!ctx) {
>   
> CID 1267839 (#1 of 1): Logically dead code (DEADCODE)
> dead_error_line: Execution cannot reach this statement: return TS_ERR_PARAMS;.
> 167return TS_ERR_PARAMS;
> 168  }



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Work logged] (TS-4815) CID 1267839 dead code in /mgmt/api/CfgContextManager.cc: return TS_ERR_PARAMS;

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-4815?focusedWorklogId=31247=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-31247
 ]

ASF GitHub Bot logged work on TS-4815:
--

Author: ASF GitHub Bot
Created on: 27/Oct/16 08:45
Start Date: 27/Oct/16 08:45
Worklog Time Spent: 10m 
  Work Description: Github user zwoop closed the pull request at:

https://github.com/apache/trafficserver/pull/963


Issue Time Tracking
---

Worklog Id: (was: 31247)
Time Spent: 2.5h  (was: 2h 20m)

> CID 1267839 dead code in /mgmt/api/CfgContextManager.cc: return TS_ERR_PARAMS;
> --
>
> Key: TS-4815
> URL: https://issues.apache.org/jira/browse/TS-4815
> Project: Traffic Server
>  Issue Type: Bug
>  Components: Management API
>Reporter: Nathan Garabedian
>Assignee: Nathan Garabedian
> Fix For: 7.1.0
>
>  Time Spent: 2.5h
>  Remaining Estimate: 0h
>
>   cond_notnull: Condition ctx, taking true branch. Now the value of ctx 
> is not NULL.
> 165  ink_assert(ctx);
>   notnull: At condition ctx, the value of ctx cannot be NULL.
>   dead_error_condition: The condition !ctx cannot be true.
> 166  if (!ctx) {
>   
> CID 1267839 (#1 of 1): Logically dead code (DEADCODE)
> dead_error_line: Execution cannot reach this statement: return TS_ERR_PARAMS;.
> 167return TS_ERR_PARAMS;
> 168  }



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] trafficserver pull request #963: TS-4815 - CID 1267839 dead code in /mgmt/ap...

[zwoop]

Github user zwoop closed the pull request at:

https://github.com/apache/trafficserver/pull/963


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Work logged] (TS-4834) Expose bad disk and disk access failures

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-4834?focusedWorklogId=31246=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-31246
 ]

ASF GitHub Bot logged work on TS-4834:
--

Author: ASF GitHub Bot
Created on: 27/Oct/16 08:41
Start Date: 27/Oct/16 08:41
Worklog Time Spent: 10m 
  Work Description: Github user zwoop commented on the issue:

https://github.com/apache/trafficserver/pull/996
  
@gtenev This is ready to land now, right ?


Issue Time Tracking
---

Worklog Id: (was: 31246)
Time Spent: 1h 40m  (was: 1.5h)

> Expose bad disk and disk access failures
> 
>
> Key: TS-4834
> URL: https://issues.apache.org/jira/browse/TS-4834
> Project: Traffic Server
>  Issue Type: Improvement
>  Components: Cache, Metrics
>Reporter: Gancho Tenev
>Assignee: Gancho Tenev
> Fix For: 7.1.0
>
>  Time Spent: 1h 40m
>  Remaining Estimate: 0h
>
> We would like to monitor low-level disk access failures and disks marked by 
> ATS as bad.
> I have a patch that exposes that information through
> {code}
> proxy.process.cache.disk_error_count 10
> proxy.process.cache.disk_bad_count 5
> {code}
> and the following tests/shows how it would work...
> Start ATS with 2 disks and tail {{diags.log}}
> {code}
> $ cat etc/trafficserver/storage.config
> /dev/sdb
> /dev/sdc
> $ tail -f var/log/trafficserver/diags.log
> [Sep  8 12:18:48.149] Server {0x2b5f43db54c0} NOTE: traffic server running
> [Sep  8 12:18:48.198] Server {0x2b5f44654700} NOTE: cache enabled
> {code}
> Check related metrics and observe all 0s
> {code}
> $ ./bin/traffic_ctl metric match "proxy.process.cache*.disk.*" 
> "proxy.process.cache.*(read|write).failure" 
> "proxy.process.http.cache_(read|write)_errors"
> proxy.process.cache.disk_error_count 0
> proxy.process.cache.disk_bad_count 0
> proxy.process.cache.read.failure 0
> proxy.process.cache.write.failure 0
> proxy.process.cache.volume_0.read.failure 0
> proxy.process.cache.volume_0.write.failure 0
> proxy.process.http.cache_write_errors 0
> proxy.process.http.cache_read_errors 0
> {code}
> Now using your favorite hard disk failure injection tool inject 10 failures, 
> by setting both disks used by this setup {{/dev/sdb}} and {{/dev/sdc}} to 
> fail all reads. And shoot 5 requests causing 10 failed reads.
> {code}
> $ for i in 1 2 3 4 5; do curl -x 127.0.0.1:80 http://example.com/1 -o 
> /dev/null -s; done
> $ tail -f var/log/trafficserver/diags.log
> [Sep  8 12:19:09.758] Server {0x2aaab4302700} WARNING: cache disk operation 
> failed READ -1 0
> [Sep  8 12:19:09.759] Server {0x2aaac0100700} WARNING: cache disk operation 
> failed READ -1 0
> [Sep  8 12:19:09.764] Server {0x2b5f43db54c0} WARNING: Error accessing Disk 
> /dev/sdb [1/10]
> [Sep  8 12:19:09.769] Server {0x2b5f44654700} WARNING: Error accessing Disk 
> /dev/sdb [2/10]
> [Sep  8 12:19:09.785] Server {0x2aaac0100700} WARNING: cache disk operation 
> failed READ -1 0
> [Sep  8 12:19:09.786] Server {0x2aaab4302700} WARNING: cache disk operation 
> failed READ -1 0
> [Sep  8 12:19:09.791] Server {0x2b5f44654700} WARNING: Error accessing Disk 
> /dev/sdb [3/10]
> [Sep  8 12:19:09.796] Server {0x2b5f43db54c0} WARNING: Error accessing Disk 
> /dev/sdb [4/10]
> [Sep  8 12:19:09.812] Server {0x2aaab4100700} WARNING: cache disk operation 
> failed READ -1 0
> [Sep  8 12:19:09.813] Server {0x2aaacc100700} WARNING: cache disk operation 
> failed READ -1 0
> [Sep  8 12:19:09.817] Server {0x2b5f43db54c0} WARNING: Error accessing Disk 
> /dev/sdb [5/10]
> [Sep  8 12:19:09.823] Server {0x2b5f44654700} WARNING: Error accessing Disk 
> /dev/sdb [6/10]
> [Sep  8 12:19:09.843] Server {0x2aaacc302700} WARNING: cache disk operation 
> failed READ -1 0
> [Sep  8 12:19:09.844] Server {0x2aaad8100700} WARNING: cache disk operation 
> failed READ -1 0
> [Sep  8 12:19:09.847] Server {0x2b5f44654700} WARNING: Error accessing Disk 
> /dev/sdb [7/10]
> [Sep  8 12:19:09.854] Server {0x2b5f43db54c0} WARNING: Error accessing Disk 
> /dev/sdb [8/10]
> [Sep  8 12:19:09.874] Server {0x2aaacc302700} WARNING: cache disk operation 
> failed READ -1 0
> [Sep  8 12:19:09.875] Server {0x2aaad8100700} WARNING: cache disk operation 
> failed READ -1 0
> [Sep  8 12:19:09.880] Server {0x2b5f43db54c0} WARNING: Error accessing Disk 
> /dev/sdb [9/10]
> [Sep  8 12:19:09.887] Server {0x2b5f44654700} WARNING: too many errors 
> accessing disk /dev/sdb [10/10]: declaring disk bad
> {code}
> We see 5 read failures which triggered 10 actually disk reads and marked the 
> failing disk as a bad disk.
> {code}
> $ ./bin/traffic_ctl metric match "proxy.process.cache*.disk.*" 
> "proxy.process.cache.*(read|write).failure" 
> "proxy.process.http.cache_(read|write)_errors"
> proxy.process.cache.disk_error_count 10
> 

[GitHub] trafficserver issue #996: TS-4834 Expose bad disk and disk access failures

[zwoop]

Github user zwoop commented on the issue:

https://github.com/apache/trafficserver/pull/996
  
@gtenev This is ready to land now, right ?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1120: TS-4978: illegal memory access with ticket_key.fi...

[zwoop]

Github user zwoop commented on the issue:

https://github.com/apache/trafficserver/pull/1120
  
Looks like we have merge conflicts now.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Work logged] (TS-4978) CID 1364311: Memory - illegal accesses (USE_AFTER_FREE) in iocore/net/SSLConfig.cc

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-4978?focusedWorklogId=31245=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-31245
 ]

ASF GitHub Bot logged work on TS-4978:
--

Author: ASF GitHub Bot
Created on: 27/Oct/16 08:39
Start Date: 27/Oct/16 08:39
Worklog Time Spent: 10m 
  Work Description: Github user zwoop commented on the issue:

https://github.com/apache/trafficserver/pull/1120
  
Looks like we have merge conflicts now.


Issue Time Tracking
---

Worklog Id: (was: 31245)
Time Spent: 1h  (was: 50m)

> CID 1364311:  Memory - illegal accesses  (USE_AFTER_FREE) in 
> iocore/net/SSLConfig.cc
> 
>
> Key: TS-4978
> URL: https://issues.apache.org/jira/browse/TS-4978
> Project: Traffic Server
>  Issue Type: Bug
>  Components: TLS
>Reporter: Leif Hedstrom
>Assignee: Syeda Persia Aziz
> Fix For: 7.1.0
>
>  Time Spent: 1h
>  Remaining Estimate: 0h
>
> I think this is perhaps from TS-4858:
> {code}
> *** CID 1364311:  Memory - illegal accesses  (USE_AFTER_FREE)
> /iocore/net/SSLConfig.cc: 258 in SSLConfigParams::initialize()()
> 252   ats_free(ssl_server_ca_cert_filename);
> 253   ats_free(CACertRelativePath);
> 254 
> 255 #if HAVE_OPENSSL_SESSION_TICKETS
> 256   REC_ReadConfigStringAlloc(ticket_key_filename, 
> "proxy.config.ssl.server.ticket_key.filename");
> 257   if (this->ticket_key_filename != NULL) {
>CID 1364311:  Memory - illegal accesses  (USE_AFTER_FREE)
>Passing freed pointer "this->ticket_key_filename" as an argument to 
> "relative_to".
> 258 ats_scoped_str 
> ticket_key_path(Layout::relative_to(this->serverCertPathOnly, 
> this->ticket_key_filename));
> 259 default_global_keyblock = 
> ssl_create_ticket_keyblock(ticket_key_path);
> 260   } else {
> 261 default_global_keyblock = ssl_create_ticket_keyblock(NULL);
> 262   }
> 263 #endif
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Resolved] (TS-5006) Fix Coverity Issues

[Leif Hedstrom (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-5006?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Leif Hedstrom resolved TS-5006.
---
Resolution: Fixed

> Fix Coverity Issues
> ---
>
> Key: TS-5006
> URL: https://issues.apache.org/jira/browse/TS-5006
> Project: Traffic Server
>  Issue Type: Bug
>Reporter: Phil Sorber
>Assignee: Phil Sorber
> Fix For: 7.1.0
>
>  Time Spent: 2h 50m
>  Remaining Estimate: 0h
>
> Issue to track coverity fixes



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] trafficserver pull request #1140: TS-5006: Fix CID 1356975

[zwoop]

Github user zwoop closed the pull request at:

https://github.com/apache/trafficserver/pull/1140


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Updated] (TS-5006) Fix Coverity Issues

[Leif Hedstrom (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-5006?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Leif Hedstrom updated TS-5006:
--
Fix Version/s: 7.1.0

> Fix Coverity Issues
> ---
>
> Key: TS-5006
> URL: https://issues.apache.org/jira/browse/TS-5006
> Project: Traffic Server
>  Issue Type: Bug
>Reporter: Phil Sorber
> Fix For: 7.1.0
>
>  Time Spent: 2h 50m
>  Remaining Estimate: 0h
>
> Issue to track coverity fixes



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Failed: trafficserver (latest)

[Read the Docs]

Build Failed for trafficserver (latest)



Error:
Version locked, retrying in 5 minutes.

You can find out more about this failure here:
https://readthedocs.org/projects/trafficserver/builds/4572341/

If you have questions, a good place to start is the FAQ:
https://docs.readthedocs.org/en/latest/faq.html



Keep documenting,
Read the Docs
--
http://readthedocs.org

[jira] [Updated] (TS-5006) Fix Coverity Issues

[Leif Hedstrom (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-5006?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Leif Hedstrom updated TS-5006:
--
Assignee: Phil Sorber

> Fix Coverity Issues
> ---
>
> Key: TS-5006
> URL: https://issues.apache.org/jira/browse/TS-5006
> Project: Traffic Server
>  Issue Type: Bug
>Reporter: Phil Sorber
>Assignee: Phil Sorber
> Fix For: 7.1.0
>
>  Time Spent: 2h 50m
>  Remaining Estimate: 0h
>
> Issue to track coverity fixes



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Work logged] (TS-5006) Fix Coverity Issues

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-5006?focusedWorklogId=31244=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-31244
 ]

ASF GitHub Bot logged work on TS-5006:
--

Author: ASF GitHub Bot
Created on: 27/Oct/16 08:37
Start Date: 27/Oct/16 08:37
Worklog Time Spent: 10m 
  Work Description: Github user zwoop closed the pull request at:

https://github.com/apache/trafficserver/pull/1140


Issue Time Tracking
---

Worklog Id: (was: 31244)
Time Spent: 2h 50m  (was: 2h 40m)

> Fix Coverity Issues
> ---
>
> Key: TS-5006
> URL: https://issues.apache.org/jira/browse/TS-5006
> Project: Traffic Server
>  Issue Type: Bug
>Reporter: Phil Sorber
> Fix For: 7.1.0
>
>  Time Spent: 2h 50m
>  Remaining Estimate: 0h
>
> Issue to track coverity fixes



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Resolved] (TS-5008) CID 1022007 Logically dead code

[Leif Hedstrom (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-5008?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Leif Hedstrom resolved TS-5008.
---
Resolution: Fixed

> CID 1022007 Logically dead code
> ---
>
> Key: TS-5008
> URL: https://issues.apache.org/jira/browse/TS-5008
> Project: Traffic Server
>  Issue Type: Bug
>  Components: Core
>Reporter: Nathan Garabedian
>Assignee: Nathan Garabedian
> Fix For: 7.1.0
>
>  Time Spent: 50m
>  Remaining Estimate: 0h
>
> if (ink_hash_table_lookup(our_map, virt_ip, _value) != 0) {
>   const: At condition in_ext_map, the value of in_ext_map must be equal 
> to 0.
>   dead_error_condition: The condition in_ext_map cannot be true.
> 620if (in_ext_map) {
>   
> CID 1022007 (#1 of 1): Logically dead code (DEADCODE)
> dead_error_line: Execution cannot reach this statement: ret = true;.
> 621  ret = true;
> 622} else {
> 623  ret = false;
> 624}
> 625  }



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (TS-5008) CID 1022007 Logically dead code

[Leif Hedstrom (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-5008?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Leif Hedstrom updated TS-5008:
--
Fix Version/s: 7.1.0

> CID 1022007 Logically dead code
> ---
>
> Key: TS-5008
> URL: https://issues.apache.org/jira/browse/TS-5008
> Project: Traffic Server
>  Issue Type: Bug
>  Components: Core
>Reporter: Nathan Garabedian
>Assignee: Nathan Garabedian
> Fix For: 7.1.0
>
>  Time Spent: 50m
>  Remaining Estimate: 0h
>
> if (ink_hash_table_lookup(our_map, virt_ip, _value) != 0) {
>   const: At condition in_ext_map, the value of in_ext_map must be equal 
> to 0.
>   dead_error_condition: The condition in_ext_map cannot be true.
> 620if (in_ext_map) {
>   
> CID 1022007 (#1 of 1): Logically dead code (DEADCODE)
> dead_error_line: Execution cannot reach this statement: ret = true;.
> 621  ret = true;
> 622} else {
> 623  ret = false;
> 624}
> 625  }



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (TS-5003) 64 bit CAS fails to compile

[Leif Hedstrom (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-5003?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Leif Hedstrom updated TS-5003:
--
Fix Version/s: 7.1.0

> 64 bit CAS fails to compile
> ---
>
> Key: TS-5003
> URL: https://issues.apache.org/jira/browse/TS-5003
> Project: Traffic Server
>  Issue Type: Bug
>  Components: Core
>Reporter: Alan M. Carroll
>Assignee: Alan M. Carroll
> Fix For: 7.1.0
>
>  Time Spent: 50m
>  Remaining Estimate: 0h
>
> On machines with 64 bit void pointers but not 128 bit CAS support 
> {{lib/ts/ink_queue.h}} doesn't compile due to a missing define of 
> {{version_type}}.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] trafficserver pull request #1141: TS-5003: Compile fail for 64 bit systems w...

[zwoop]

Github user zwoop closed the pull request at:

https://github.com/apache/trafficserver/pull/1141


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Work logged] (TS-5003) 64 bit CAS fails to compile

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-5003?focusedWorklogId=31243=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-31243
 ]

ASF GitHub Bot logged work on TS-5003:
--

Author: ASF GitHub Bot
Created on: 27/Oct/16 08:35
Start Date: 27/Oct/16 08:35
Worklog Time Spent: 10m 
  Work Description: Github user zwoop closed the pull request at:

https://github.com/apache/trafficserver/pull/1141


Issue Time Tracking
---

Worklog Id: (was: 31243)
Time Spent: 50m  (was: 40m)

> 64 bit CAS fails to compile
> ---
>
> Key: TS-5003
> URL: https://issues.apache.org/jira/browse/TS-5003
> Project: Traffic Server
>  Issue Type: Bug
>  Components: Core
>Reporter: Alan M. Carroll
>Assignee: Alan M. Carroll
>  Time Spent: 50m
>  Remaining Estimate: 0h
>
> On machines with 64 bit void pointers but not 128 bit CAS support 
> {{lib/ts/ink_queue.h}} doesn't compile due to a missing define of 
> {{version_type}}.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Resolved] (TS-5003) 64 bit CAS fails to compile

[Leif Hedstrom (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-5003?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Leif Hedstrom resolved TS-5003.
---
Resolution: Fixed

> 64 bit CAS fails to compile
> ---
>
> Key: TS-5003
> URL: https://issues.apache.org/jira/browse/TS-5003
> Project: Traffic Server
>  Issue Type: Bug
>  Components: Core
>Reporter: Alan M. Carroll
>Assignee: Alan M. Carroll
>  Time Spent: 50m
>  Remaining Estimate: 0h
>
> On machines with 64 bit void pointers but not 128 bit CAS support 
> {{lib/ts/ink_queue.h}} doesn't compile due to a missing define of 
> {{version_type}}.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Work logged] (TS-5008) CID 1022007 Logically dead code

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-5008?focusedWorklogId=31242=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-31242
 ]

ASF GitHub Bot logged work on TS-5008:
--

Author: ASF GitHub Bot
Created on: 27/Oct/16 08:34
Start Date: 27/Oct/16 08:34
Worklog Time Spent: 10m 
  Work Description: Github user zwoop closed the pull request at:

https://github.com/apache/trafficserver/pull/1149


Issue Time Tracking
---

Worklog Id: (was: 31242)
Time Spent: 50m  (was: 40m)

> CID 1022007 Logically dead code
> ---
>
> Key: TS-5008
> URL: https://issues.apache.org/jira/browse/TS-5008
> Project: Traffic Server
>  Issue Type: Bug
>  Components: Core
>Reporter: Nathan Garabedian
>Assignee: Nathan Garabedian
>  Time Spent: 50m
>  Remaining Estimate: 0h
>
> if (ink_hash_table_lookup(our_map, virt_ip, _value) != 0) {
>   const: At condition in_ext_map, the value of in_ext_map must be equal 
> to 0.
>   dead_error_condition: The condition in_ext_map cannot be true.
> 620if (in_ext_map) {
>   
> CID 1022007 (#1 of 1): Logically dead code (DEADCODE)
> dead_error_line: Execution cannot reach this statement: ret = true;.
> 621  ret = true;
> 622} else {
> 623  ret = false;
> 624}
> 625  }



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] trafficserver pull request #1149: TS-5008 CID 1022007 Logically dead code

[zwoop]

Github user zwoop closed the pull request at:

https://github.com/apache/trafficserver/pull/1149


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Resolved] (TS-5012) CID 1267812 Logically Dead Code

[Leif Hedstrom (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-5012?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Leif Hedstrom resolved TS-5012.
---
Resolution: Fixed

> CID 1267812 Logically Dead Code
> ---
>
> Key: TS-5012
> URL: https://issues.apache.org/jira/browse/TS-5012
> Project: Traffic Server
>  Issue Type: Bug
>  Components: Manager
>Reporter: Nathan Garabedian
>Assignee: Nathan Garabedian
>  Labels: coverity
> Fix For: 7.1.0
>
>  Time Spent: 50m
>  Remaining Estimate: 0h
>
> 8void
> 189ConfigProcessor::release(unsigned int id, ConfigInfo *info)
> 190{
> 191  int idx;
> 192
>   cond_at_least: Condition id != 0U, taking true branch. Now the value of 
> id is at least 1.
>   cond_cannot_single: Condition id != 0U, taking true branch. Now the 
> value of id cannot be equal to 0.
> 193  ink_assert(id != 0);
>   cond_between: Condition id <= 100U, taking true branch. Now the value 
> of id is between 1 and 100.
> 194  ink_assert(id <= MAX_CONFIGS);
> 195
>   between: At condition id == 0U, the value of id must be between 1 and 
> 100.
>   cannot_single: At condition id == 0U, the value of id cannot be equal 
> to 0.
>   dead_error_condition: The condition id == 0U cannot be true.
>   cond_between: Condition id == 0U, taking false branch. Now the value of 
> id is between 1 and 100.
>   between: At condition id > 100U, the value of id must be between 1 and 
> 100.
>   cannot_single: At condition id > 100U, the value of id cannot be equal 
> to 0.
>   dead_error_condition: The condition id > 100U cannot be true.
> 196  if (id == 0 || id > MAX_CONFIGS) {
> 197// nothing to delete since we have an invalid index
>   
> CID 1267812 (#1 of 1): Logically dead code (DEADCODE)
> dead_error_line: Execution cannot reach this statement: return;.
> 198return;
> 199  }
> 200



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Work logged] (TS-5012) CID 1267812 Logically Dead Code

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-5012?focusedWorklogId=31241=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-31241
 ]

ASF GitHub Bot logged work on TS-5012:
--

Author: ASF GitHub Bot
Created on: 27/Oct/16 08:32
Start Date: 27/Oct/16 08:32
Worklog Time Spent: 10m 
  Work Description: Github user zwoop closed the pull request at:

https://github.com/apache/trafficserver/pull/1155


Issue Time Tracking
---

Worklog Id: (was: 31241)
Time Spent: 50m  (was: 40m)

> CID 1267812 Logically Dead Code
> ---
>
> Key: TS-5012
> URL: https://issues.apache.org/jira/browse/TS-5012
> Project: Traffic Server
>  Issue Type: Bug
>  Components: Manager
>Reporter: Nathan Garabedian
>Assignee: Nathan Garabedian
>  Labels: coverity
> Fix For: 7.1.0
>
>  Time Spent: 50m
>  Remaining Estimate: 0h
>
> 8void
> 189ConfigProcessor::release(unsigned int id, ConfigInfo *info)
> 190{
> 191  int idx;
> 192
>   cond_at_least: Condition id != 0U, taking true branch. Now the value of 
> id is at least 1.
>   cond_cannot_single: Condition id != 0U, taking true branch. Now the 
> value of id cannot be equal to 0.
> 193  ink_assert(id != 0);
>   cond_between: Condition id <= 100U, taking true branch. Now the value 
> of id is between 1 and 100.
> 194  ink_assert(id <= MAX_CONFIGS);
> 195
>   between: At condition id == 0U, the value of id must be between 1 and 
> 100.
>   cannot_single: At condition id == 0U, the value of id cannot be equal 
> to 0.
>   dead_error_condition: The condition id == 0U cannot be true.
>   cond_between: Condition id == 0U, taking false branch. Now the value of 
> id is between 1 and 100.
>   between: At condition id > 100U, the value of id must be between 1 and 
> 100.
>   cannot_single: At condition id > 100U, the value of id cannot be equal 
> to 0.
>   dead_error_condition: The condition id > 100U cannot be true.
> 196  if (id == 0 || id > MAX_CONFIGS) {
> 197// nothing to delete since we have an invalid index
>   
> CID 1267812 (#1 of 1): Logically dead code (DEADCODE)
> dead_error_line: Execution cannot reach this statement: return;.
> 198return;
> 199  }
> 200



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] trafficserver pull request #1155: TS-5012 CID 1267812 Logically Dead Code fi...

[zwoop]

Github user zwoop closed the pull request at:

https://github.com/apache/trafficserver/pull/1155


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Work logged] (TS-5015) Convert storage config file to Lua

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-5015?focusedWorklogId=31239=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-31239
 ]

ASF GitHub Bot logged work on TS-5015:
--

Author: ASF GitHub Bot
Created on: 27/Oct/16 08:20
Start Date: 27/Oct/16 08:20
Worklog Time Spent: 10m 
  Work Description: Github user zwoop commented on the issue:

https://github.com/apache/trafficserver/pull/1158
  
Before committing this, I think we should at least squash the build fixes 
such that there are not intermediate commit steps that are failing.


Issue Time Tracking
---

Worklog Id: (was: 31239)
Time Spent: 1.5h  (was: 1h 20m)

> Convert storage config file to Lua
> --
>
> Key: TS-5015
> URL: https://issues.apache.org/jira/browse/TS-5015
> Project: Traffic Server
>  Issue Type: Improvement
>  Components: Cache, Lua
>Reporter: Kit Chan
>Assignee: Kit Chan
> Fix For: 7.1.0
>
>  Time Spent: 1.5h
>  Remaining Estimate: 0h
>
> Similar to TS-4548
> storage.config is the next good candidate to convert to Lua bindings. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] trafficserver issue #1158: TS-5015: Convert storage configuration file to Lu...

[zwoop]

Github user zwoop commented on the issue:

https://github.com/apache/trafficserver/pull/1158
  
Before committing this, I think we should at least squash the build fixes 
such that there are not intermediate commit steps that are failing.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1158: TS-5015: Convert storage configuration file to Lu...

[zwoop]

Github user zwoop commented on the issue:

https://github.com/apache/trafficserver/pull/1158
  
Neat! I wonder, maybe we should start naming these new config files with a 
.lua extension? That makes editors much happier, and it makes logical sense 
too. So, this could be named storage.lua instead of "store.config".

In retrospect, we then should have named them metrics.lua and logging.lua, 
but we can retrofit that later (or, support both naming for the 7.x lifetime).

Thoughts?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Work logged] (TS-5015) Convert storage config file to Lua

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-5015?focusedWorklogId=31238=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-31238
 ]

ASF GitHub Bot logged work on TS-5015:
--

Author: ASF GitHub Bot
Created on: 27/Oct/16 08:18
Start Date: 27/Oct/16 08:18
Worklog Time Spent: 10m 
  Work Description: Github user zwoop commented on the issue:

https://github.com/apache/trafficserver/pull/1158
  
Neat! I wonder, maybe we should start naming these new config files with a 
.lua extension? That makes editors much happier, and it makes logical sense 
too. So, this could be named storage.lua instead of "store.config".

In retrospect, we then should have named them metrics.lua and logging.lua, 
but we can retrofit that later (or, support both naming for the 7.x lifetime).

Thoughts?


Issue Time Tracking
---

Worklog Id: (was: 31238)
Time Spent: 1h 20m  (was: 1h 10m)

> Convert storage config file to Lua
> --
>
> Key: TS-5015
> URL: https://issues.apache.org/jira/browse/TS-5015
> Project: Traffic Server
>  Issue Type: Improvement
>  Components: Cache, Lua
>Reporter: Kit Chan
>Assignee: Kit Chan
> Fix For: 7.1.0
>
>  Time Spent: 1h 20m
>  Remaining Estimate: 0h
>
> Similar to TS-4548
> storage.config is the next good candidate to convert to Lua bindings. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (TS-5017) ip_allow.config seems use the first matched rule

[James Fang (JIRA)]

James Fang created TS-5017:
--

 Summary: ip_allow.config seems use the first matched rule
 Key: TS-5017
 URL: https://issues.apache.org/jira/browse/TS-5017
 Project: Traffic Server
  Issue Type: Improvement
  Components: Documentation
Reporter: James Fang


as title, rules are not merged, and the first matched rule take effect.

shall we update the doc for this ?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (TS-5016) TS should allow force reload, and may also check inclued files

[James Fang (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-5016?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

James Fang updated TS-5016:
---
Description: 
1) on config change, if TS hasn't detect the changes yet - traffic_ctl config 
status show "current", 
 reload seems skipped.  so user may need to wait for the detection.
 this happens if config file are generated by programs since the reload is 
immediately.

2) for included config files, such as .include from remap.config,
if included files changes, TS still seems configuration as current

  was:
1) on config change, if TS hasn't detect the changes yet - traffic_ctl config 
status show "current", 
 reload seems skipped.  so user may need to wait for the detection.

2) for included config files, such as .include from remap.config,
if included files changes, TS still seems configuration as current


> TS should allow force reload, and may also check inclued files 
> ---
>
> Key: TS-5016
> URL: https://issues.apache.org/jira/browse/TS-5016
> Project: Traffic Server
>  Issue Type: Improvement
>Reporter: James Fang
>
> 1) on config change, if TS hasn't detect the changes yet - traffic_ctl config 
> status show "current", 
>  reload seems skipped.  so user may need to wait for the detection.
>  this happens if config file are generated by programs since the reload 
> is immediately.
> 2) for included config files, such as .include from remap.config,
> if included files changes, TS still seems configuration as current



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (TS-5016) TS should allow force reload, and may also check inclued files

[James Fang (JIRA)]

James Fang created TS-5016:
--

 Summary: TS should allow force reload, and may also check inclued 
files 
 Key: TS-5016
 URL: https://issues.apache.org/jira/browse/TS-5016
 Project: Traffic Server
  Issue Type: Improvement
Reporter: James Fang


1) on config change,
 if TS hasn't detect the changes yet - traffic_ctl config status show 
"current" 
 reload seems skipped.
 so user may need to wait for the detection.

2) for included config files, such as .include from remap.config,
if included files changes, TS still seems configuration as current



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (TS-5016) TS should allow force reload, and may also check inclued files

[James Fang (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-5016?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

James Fang updated TS-5016:
---
Description: 
1) on config change, if TS hasn't detect the changes yet - traffic_ctl config 
status show "current", 
 reload seems skipped.  so user may need to wait for the detection.

2) for included config files, such as .include from remap.config,
if included files changes, TS still seems configuration as current

  was:
1) on config change,
 if TS hasn't detect the changes yet - traffic_ctl config status show 
"current" 
 reload seems skipped.
 so user may need to wait for the detection.

2) for included config files, such as .include from remap.config,
if included files changes, TS still seems configuration as current


> TS should allow force reload, and may also check inclued files 
> ---
>
> Key: TS-5016
> URL: https://issues.apache.org/jira/browse/TS-5016
> Project: Traffic Server
>  Issue Type: Improvement
>Reporter: James Fang
>
> 1) on config change, if TS hasn't detect the changes yet - traffic_ctl config 
> status show "current", 
>  reload seems skipped.  so user may need to wait for the detection.
> 2) for included config files, such as .include from remap.config,
> if included files changes, TS still seems configuration as current



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] trafficserver issue #1158: TS-5015: Convert storage configuration file to Lu...

[atsci]

Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1158
  
Linux build *successful*! See 
https://ci.trafficserver.apache.org/job/Github-Linux/1007/ for details.
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Work logged] (TS-5015) Convert storage config file to Lua

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-5015?focusedWorklogId=31236=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-31236
 ]

ASF GitHub Bot logged work on TS-5015:
--

Author: ASF GitHub Bot
Created on: 27/Oct/16 07:19
Start Date: 27/Oct/16 07:19
Worklog Time Spent: 10m 
  Work Description: Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1158
  
Linux build *successful*! See 
https://ci.trafficserver.apache.org/job/Github-Linux/1007/ for details.
 



Issue Time Tracking
---

Worklog Id: (was: 31236)
Time Spent: 1h 10m  (was: 1h)

> Convert storage config file to Lua
> --
>
> Key: TS-5015
> URL: https://issues.apache.org/jira/browse/TS-5015
> Project: Traffic Server
>  Issue Type: Improvement
>  Components: Cache, Lua
>Reporter: Kit Chan
>Assignee: Kit Chan
> Fix For: 7.1.0
>
>  Time Spent: 1h 10m
>  Remaining Estimate: 0h
>
> Similar to TS-4548
> storage.config is the next good candidate to convert to Lua bindings. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Work logged] (TS-5015) Convert storage config file to Lua

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-5015?focusedWorklogId=31235=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-31235
 ]

ASF GitHub Bot logged work on TS-5015:
--

Author: ASF GitHub Bot
Created on: 27/Oct/16 07:17
Start Date: 27/Oct/16 07:17
Worklog Time Spent: 10m 
  Work Description: Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1158
  
FreeBSD build *successful*! See 
https://ci.trafficserver.apache.org/job/Github-FreeBSD/1113/ for details.
 



Issue Time Tracking
---

Worklog Id: (was: 31235)
Time Spent: 1h  (was: 50m)

> Convert storage config file to Lua
> --
>
> Key: TS-5015
> URL: https://issues.apache.org/jira/browse/TS-5015
> Project: Traffic Server
>  Issue Type: Improvement
>  Components: Cache, Lua
>Reporter: Kit Chan
>Assignee: Kit Chan
> Fix For: 7.1.0
>
>  Time Spent: 1h
>  Remaining Estimate: 0h
>
> Similar to TS-4548
> storage.config is the next good candidate to convert to Lua bindings. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] trafficserver issue #1158: TS-5015: Convert storage configuration file to Lu...

[atsci]

Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1158
  
FreeBSD build *successful*! See 
https://ci.trafficserver.apache.org/job/Github-FreeBSD/1113/ for details.
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---