[GitHub] trafficserver issue #1516: Implement Cache-Control: immutable handling

[atsci]

Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1516
  
Linux build *failed*! See 
https://ci.trafficserver.apache.org/job/linux-github/1589/ for details.
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1546: NetVC maybe lost from read_ready_list if Plugin c...

[atsci]

Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1546
  
FreeBSD build *successful*! See 
https://ci.trafficserver.apache.org/job/freebsd-github/1692/ for details.
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1516: Implement Cache-Control: immutable handling

[atsci]

Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1516
  
RAT check *successful*! See 
https://ci.trafficserver.apache.org/job/RAT-github/11/ for details.
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1546: NetVC maybe lost from read_ready_list if Plugin c...

[atsci]

Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1546
  
RAT check *successful*! See 
https://ci.trafficserver.apache.org/job/RAT-github/10/ for details.
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1546: NetVC maybe lost from read_ready_list if Plugin c...

[zwoop]

Github user zwoop commented on the issue:

https://github.com/apache/trafficserver/pull/1546
  
Should this go into 7.1.0?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1471: is_transparent_passthrough_allowed always returns...

[atsci]

Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1471
  
Linux build *successful*! See 
https://ci.trafficserver.apache.org/job/RAT-github/9/ for details.
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1473: Avoid forcing "proxied URL" in case of transparen...

[atsci]

Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1473
  
Linux build *successful*! See 
https://ci.trafficserver.apache.org/job/RAT-github/8/ for details.
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1479: Add static type checking to configuration overrid...

[atsci]

Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1479
  
Linux build *successful*! See 
https://ci.trafficserver.apache.org/job/RAT-github/7/ for details.
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1516: Implement Cache-Control: immutable handling

[atsci]

Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1516
  
Linux build *successful*! See 
https://ci.trafficserver.apache.org/job/RAT-github/6/ for details.
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1517: Remove BisonHeaderToC++.sed

[atsci]

Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1517
  
Linux build *successful*! See 
https://ci.trafficserver.apache.org/job/RAT-github/5/ for details.
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1521: Changes default RAM cache to the LRU + seen-filte...

[atsci]

Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1521
  
Linux build *successful*! See 
https://ci.trafficserver.apache.org/job/RAT-github/3/ for details.
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1520: Report protocol in request via header

[atsci]

Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1520
  
Linux build *failed*! See 
https://ci.trafficserver.apache.org/job/RAT-github/4/ for details.
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1522: Ignore read and write errors if vio has been clea...

[atsci]

Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1522
  
Linux build *successful*! See 
https://ci.trafficserver.apache.org/job/RAT-github/2/ for details.
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1534: Use StringView for protocol stack to avoid callin...

[atsci]

Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1534
  
Linux build *successful*! See 
https://ci.trafficserver.apache.org/job/RAT-github/1/ for details.
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver pull request #1516: Implement Cache-Control: immutable handlin...

[danobi]

Github user danobi commented on a diff in the pull request:

https://github.com/apache/trafficserver/pull/1516#discussion_r104771989
  
--- Diff: plugins/esi/combo_handler.cc ---
@@ -187,6 +207,94 @@ InterceptData::~InterceptData()
   }
 }
 
+void
+CacheControlHeader::update(TSMBuffer bufp, TSMLoc hdr_loc)
+{
+  vector values;
--- End diff --

Why a loop? If we use a loop then it's harder to set the `found_private` 
and `found_immutable` flags. I feel like unrolling the loop in this case is 
better since the # of parameters in Cache-Control is known.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1485: back port "fix TS-4195: double free when stop tra...

[zwoop]

Github user zwoop commented on the issue:

https://github.com/apache/trafficserver/pull/1485
  
So, my bad, but we reverted this on master, because of issues raised on the 
use of _exit(). Also, not sure I agree that the ICC changes should be rolled 
into this (if we were to back port this).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1548: Insure that parent health stats are updated prope...

[atsci]

Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1548
  
clang-analyzer build *successful*! See 
https://ci.trafficserver.apache.org/job/clang-analyzer-github/255/ for details.
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1548: Insure that parent health stats are updated prope...

[atsci]

Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1548
  
Linux build *successful*! See 
https://ci.trafficserver.apache.org/job/linux-github/1587/ for details.
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1548: Insure that parent health stats are updated prope...

[atsci]

Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1548
  
Intel CC build *successful*! See 
https://ci.trafficserver.apache.org/job/icc-github/123/ for details.
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1548: Insure that parent health stats are updated prope...

[atsci]

Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1548
  
FreeBSD build *successful*! See 
https://ci.trafficserver.apache.org/job/freebsd-github/1691/ for details.
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1547: Fix ssl hook state logic.

[atsci]

Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1547
  
clang-analyzer build *successful*! See 
https://ci.trafficserver.apache.org/job/clang-analyzer-github/254/ for details.
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver pull request #1548: Insure that parent health stats are update...

[jrushford]

GitHub user jrushford opened a pull request:

https://github.com/apache/trafficserver/pull/1548

Insure that parent health stats are updated properly on a markdown

Parents may be marked down prematurely because the health stats are not 
reset when the retry window has elapsed.  This adds a check when a parent is 
marked down to make sure that the health stats are updated appropriately.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/jrushford/trafficserver reset_parent_stats

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/trafficserver/pull/1548.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1548


commit 0ab69ddd9d51d19aa3f983d39f02b1175c80cf63
Author: jrushf1239k 
Date:   2017-03-07T18:01:25Z

Insure that parent health stats are updated properly on a markdown
when the retry window has elapsed.  This avoids premature markdowns.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1547: Fix ssl hook state logic.

[atsci]

Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1547
  
FreeBSD build *successful*! See 
https://ci.trafficserver.apache.org/job/freebsd-github/1690/ for details.
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1547: Fix ssl hook state logic.

[atsci]

Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1547
  
Intel CC build *successful*! See 
https://ci.trafficserver.apache.org/job/icc-github/122/ for details.
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1547: Fix ssl hook state logic.

[atsci]

Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1547
  
Linux build *successful*! See 
https://ci.trafficserver.apache.org/job/linux-github/1586/ for details.
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver pull request #1547: Fix ssl hook state logic.

[shinrich]

GitHub user shinrich opened a pull request:

https://github.com/apache/trafficserver/pull/1547

Fix ssl hook state logic.

Was not correctly resetting the ssl hook state after the servername hooks.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/shinrich/trafficserver 
fix_ssl_hook_state_transition

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/trafficserver/pull/1547.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1547


commit 0d3801cb39b0101b44365fb3d2e990ffc1287858
Author: Susan Hinrichs 
Date:   2017-03-07T19:04:12Z

Fix ssl hook state logic.

Was not correctly resetting the ssl hook state after the servername hooks.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver pull request #1446: Need dedicated TS_SSL_SERVERNAME_HOOK

[shinrich]

Github user shinrich commented on a diff in the pull request:

https://github.com/apache/trafficserver/pull/1446#discussion_r104750433
  
--- Diff: iocore/net/SSLNetVConnection.cc ---
@@ -1438,17 +1438,22 @@ bool
 SSLNetVConnection::callHooks(TSEvent eventId)
 {
   // Only dealing with the SNI/CERT hook so far.
-  ink_assert(eventId == TS_EVENT_SSL_CERT);
+  ink_assert(eventId == TS_EVENT_SSL_CERT || eventId == 
TS_EVENT_SSL_SERVERNAME);
   Debug("ssl", "callHooks sslHandshakeHookState=%d", 
this->sslHandshakeHookState);
 
   // First time through, set the type of the hook that is currently being 
invoked
-  if (HANDSHAKE_HOOKS_PRE == sslHandshakeHookState) {
+  if ((this->sslHandshakeHookState == HANDSHAKE_HOOKS_PRE || 
this->sslHandshakeHookState == HANDSHAKE_HOOKS_DONE) &&
--- End diff --

For SSL_CTX_set_early_cb, perhaps as we move to openssl1.1 we should make 
that change.  

For the sslHandshakeHookState == DONE, probably not needed since we reset 
the hook state to PRE at the end of the servername chain.  There is a flaw with 
this PR, and I am in the process of putting up another one.  I'll probably 
leave the DONE check for now.  I'm in the process of writing a test suite for 
this logic since it has bitten me multiple times.  I'll do the tidy up once the 
test suite is there to check me.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1457: fix TS-4195: crash when stop trafficserver

[jaaju]

Github user jaaju commented on the issue:

https://github.com/apache/trafficserver/pull/1457
  
@zizhong you need to call `exit` for normal process termination in case of 
SIGTERM so ASAN leak detection report is available. But since you can not call 
`exit` from the signal handler, what @jpeach suggests is to merely take note of 
the delivered signal and call `exit` later when normal process execution 
resumes. The pipe is a mechanism to wake up the code that calls `exit`, and you 
can write to the pipe calling only async-signal-safe routines.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1522: Ignore read and write errors if vio has been clea...

[shinrich]

Github user shinrich commented on the issue:

https://github.com/apache/trafficserver/pull/1522
  
I ran my production box overnight with the latest work around.  I think 
this change is a step in the right direction and we should merge it and bring 
it back to 7.1.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1522: Ignore read and write errors if vio has been clea...

[shinrich]

Github user shinrich commented on the issue:

https://github.com/apache/trafficserver/pull/1522
  
I think the issue raised by @scw00 is different.  It looks like what @zwoop 
identified in issue #1531.  In that case the write vio errored, so the write 
vio is being sent up as data to a handler expecting only a read vio.  In the 
error case it shouldn't matter whether it is a read or a write vio and the 
error clean up should occur regardless.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1534: Use StringView for protocol stack to avoid callin...

[mlibbey]

Github user mlibbey commented on the issue:

https://github.com/apache/trafficserver/pull/1534
  
I'm terrible at reading RFC docs, so, fwiw, the Via header structure is 
described here:
https://tools.ietf.org/html/rfc7230#section-5.7.1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver pull request #1534: Use StringView for protocol stack to avoid...

[maskit]

Github user maskit commented on a diff in the pull request:

https://github.com/apache/trafficserver/pull/1534#discussion_r104723567
  
--- Diff: proxy/http/HttpTransactHeaders.cc ---
@@ -685,6 +687,23 @@ 
HttpTransactHeaders::insert_server_header_in_response(const char *server_tag, in
   }
 }
 
+/// Look up the protocol stack and write it to the @a via_string.
+size_t
+Write_Client_Protocol_Stack(HttpTransact::State *s, char *via_string, 
size_t len)
--- End diff --

write_client_protocol_stack? Is this intentional?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1537: TS-4976: Regularize example plugin basic_auth.

[SolidWallOfCode]

Github user SolidWallOfCode commented on the issue:

https://github.com/apache/trafficserver/pull/1537
  
Allright.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver pull request #1534: Use StringView for protocol stack to avoid...

[maskit]

Github user maskit commented on a diff in the pull request:

https://github.com/apache/trafficserver/pull/1534#discussion_r104721541
  
--- Diff: proxy/http/HttpSM.cc ---
@@ -8057,14 +8059,13 @@ HttpSM::is_redirect_required()
 
 // Fill in the client protocols used.  Return the number of entries 
returned
 int
-HttpSM::populate_client_protocol(const char **result, int n) const
+HttpSM::populate_client_protocol(ts::StringView *result, int n) const
--- End diff --

StringView (w/o namespace) ?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1534: Use StringView for protocol stack to avoid callin...

[zwoop]

Github user zwoop commented on the issue:

https://github.com/apache/trafficserver/pull/1534
  
It even works:

```
odin (08:54) 283/0 $ curl -D - -o /dev/null -s  https://www.ogre.com/ | 
grep Via:
Via: http/1.1 tls/1.2 tcp ipv4 Cosmo (ApacheTrafficServer/7.2.0 [cRs f ])
```

Question: Do we really want to modify the Via: header format in the 
mid-release cycle? I guess i'm ok with it, but, a concern would be if anyone 
parses the Via: header for whatever reason, it might break things?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1537: TS-4976: Regularize example plugin basic_auth.

[maskit]

Github user maskit commented on the issue:

https://github.com/apache/trafficserver/pull/1537
  
Could you also update the documentation?
```
$ git grep basic-auth.c doc

doc/developer-guide/plugins/example-plugins/basic-authorization/index.en.rst:The
 sample basic authorization plugin, ``basic-auth.c``, checks for
doc/developer-guide/plugins/example-plugins/index.en.rst:and 
``basic-auth.c``.
doc/developer-guide/plugins/getting-started/index.en.rst:-  
``basic-auth.c`` performs basic HTTP proxy authorization.
doc/developer-guide/plugins/introduction.en.rst:``blacklist-1.c``, 
``basic-auth.c``, and ``redirect-1.c``.
```
You can ignore `*.po` files.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1544: AddressSanitizer failed to deallocate

[bryancall]

Github user bryancall commented on the issue:

https://github.com/apache/trafficserver/issues/1544
  
What version are you running?  I am seeing the same errors with 7.1.0.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1521: Changes default RAM cache to the LRU + seen-filte...

[zwoop]

Github user zwoop commented on the issue:

https://github.com/apache/trafficserver/pull/1521
  
ping @bryancall @SolidWallOfCode ?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1546: NetVC maybe lost from read_ready_list if Plugin c...

[atsci]

Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1546
  
clang-analyzer build *successful*! See 
https://ci.trafficserver.apache.org/job/clang-analyzer-github/253/ for details.
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1546: NetVC maybe lost from read_ready_list if Plugin c...

[atsci]

Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1546
  
clang-analyzer build *successful*! See 
https://ci.trafficserver.apache.org/job/clang-analyzer-github/252/ for details.
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1546: NetVC maybe lost from read_ready_list if Plugin c...

[atsci]

Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1546
  
Intel CC build *successful*! See 
https://ci.trafficserver.apache.org/job/icc-github/121/ for details.
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1546: NetVC maybe lost from read_ready_list if Plugin c...

[atsci]

Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1546
  
Linux build *successful*! See 
https://ci.trafficserver.apache.org/job/linux-github/1585/ for details.
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1546: NetVC maybe lost from read_ready_list if Plugin c...

[atsci]

Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1546
  
FreeBSD build *successful*! See 
https://ci.trafficserver.apache.org/job/freebsd-github/1689/ for details.
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1546: NetVC maybe lost from read_ready_list if Plugin c...

[oknet]

Github user oknet commented on the issue:

https://github.com/apache/trafficserver/pull/1546
  
/cc @lstipakov 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1546: NetVC maybe lost from read_ready_list if Plugin c...

[oknet]

Github user oknet commented on the issue:

https://github.com/apache/trafficserver/pull/1546
  
This is update for TS-3456: SSL blind tunnel sometime not created 
(57a53649acfbc7b1cb3d828f47457aad335936bd)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1546: NetVC maybe lost from read_ready_list if Plugin c...

[atsci]

Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1546
  
Intel CC build *successful*! See 
https://ci.trafficserver.apache.org/job/icc-github/120/ for details.
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1546: NetVC maybe lost from read_ready_list if Plugin c...

[atsci]

Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1546
  
FreeBSD build *successful*! See 
https://ci.trafficserver.apache.org/job/freebsd-github/1688/ for details.
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1546: NetVC maybe lost from read_ready_list if Plugin c...

[atsci]

Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1546
  
Linux build *failed*! See 
https://ci.trafficserver.apache.org/job/linux-github/1584/ for details.
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1546: NetVC maybe lost from read_ready_list if Plugin c...

[atsci]

Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1546
  
clang-analyzer build *successful*! See 
https://ci.trafficserver.apache.org/job/clang-analyzer-github/251/ for details.
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1546: NetVC maybe lost from read_ready_list if Plugin c...

[atsci]

Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1546
  
Linux build *successful*! See 
https://ci.trafficserver.apache.org/job/linux-github/1583/ for details.
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1546: NetVC maybe lost from read_ready_list if Plugin c...

[atsci]

Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1546
  
Intel CC build *successful*! See 
https://ci.trafficserver.apache.org/job/icc-github/119/ for details.
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1546: NetVC maybe lost from read_ready_list if Plugin c...

[atsci]

Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1546
  
FreeBSD build *successful*! See 
https://ci.trafficserver.apache.org/job/freebsd-github/1687/ for details.
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver pull request #1546: NetVC maybe lost from read_ready_list if P...

[oknet]

GitHub user oknet opened a pull request:

https://github.com/apache/trafficserver/pull/1546

NetVC maybe lost from read_ready_list if Plugin call TSVConnReenable()



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/oknet/trafficserver i1546

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/trafficserver/pull/1546.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1546


commit e8357d98ae3dd140f1f083a100b68aa3b3f72fe9
Author: Oknet Xu 
Date:   2017-03-07T13:35:07Z

NetVC maybe lost from read_ready_list if Plugin call TSVConnReenable()




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver pull request #1446: Need dedicated TS_SSL_SERVERNAME_HOOK

[oknet]

Github user oknet commented on a diff in the pull request:

https://github.com/apache/trafficserver/pull/1446#discussion_r104651844
  
--- Diff: iocore/net/SSLNetVConnection.cc ---
@@ -1438,17 +1438,22 @@ bool
 SSLNetVConnection::callHooks(TSEvent eventId)
 {
   // Only dealing with the SNI/CERT hook so far.
-  ink_assert(eventId == TS_EVENT_SSL_CERT);
+  ink_assert(eventId == TS_EVENT_SSL_CERT || eventId == 
TS_EVENT_SSL_SERVERNAME);
   Debug("ssl", "callHooks sslHandshakeHookState=%d", 
this->sslHandshakeHookState);
 
   // First time through, set the type of the hook that is currently being 
invoked
-  if (HANDSHAKE_HOOKS_PRE == sslHandshakeHookState) {
+  if ((this->sslHandshakeHookState == HANDSHAKE_HOOKS_PRE || 
this->sslHandshakeHookState == HANDSHAKE_HOOKS_DONE) &&
--- End diff --

@shinrich Why you add "this->sslHandshakeHookState == HANDSHAKE_HOOKS_DONE" 
here ?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1446: Need dedicated TS_SSL_SERVERNAME_HOOK

[oknet]

Github user oknet commented on the issue:

https://github.com/apache/trafficserver/pull/1446
  
@shinrich Maybe the SSL_CTX_set_early_cb() is better than 
SSL_CTX_set_tlsext_servername_callback() ?

Only one plugin could hook on the TS_SSL_SERVERNAME_HOOK since the 
SSL_CTX_set_tlsext_servername_callback() can not stop.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---