[jira] [Work logged] (TS-5022) Multiple Client Certificate to Origin

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-5022?focusedWorklogId=35136=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-35136
 ]

ASF GitHub Bot logged work on TS-5022:
--

Author: ASF GitHub Bot
Created on: 10/Jan/17 15:12
Start Date: 10/Jan/17 15:12
Worklog Time Spent: 10m 
  Work Description: Github user zwoop closed the pull request at:

https://github.com/apache/trafficserver/pull/1316


Issue Time Tracking
---

Worklog Id: (was: 35136)
Time Spent: 8.5h  (was: 8h 20m)

> Multiple Client Certificate to Origin
> -
>
> Key: TS-5022
> URL: https://issues.apache.org/jira/browse/TS-5022
> Project: Traffic Server
>  Issue Type: Improvement
>  Components: Security, SSL, TLS
>Reporter: Scott Beardsley
>Assignee: Syeda Persia Aziz
>  Labels: yahoo
> Fix For: 7.1.0
>
>  Time Spent: 8.5h
>  Remaining Estimate: 0h
>
> Yahoo has a use case where the origin is doing mutual TLS authentication 
> which requires ATS to send a client certificate. This works fine (for now) 
> because ATS supports configuring *one* client cert but this feature should 
> really allow multiple client certificates to be configured which would depend 
> upon the origin being contacted.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Work logged] (TS-5022) Multiple Client Certificate to Origin

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-5022?focusedWorklogId=35094=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-35094
 ]

ASF GitHub Bot logged work on TS-5022:
--

Author: ASF GitHub Bot
Created on: 09/Jan/17 23:44
Start Date: 09/Jan/17 23:44
Worklog Time Spent: 10m 
  Work Description: Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1316
  
Linux build *successful*! See 
https://ci.trafficserver.apache.org/job/Github-Linux/1214/ for details.
 



Issue Time Tracking
---

Worklog Id: (was: 35094)
Time Spent: 8h 20m  (was: 8h 10m)

> Multiple Client Certificate to Origin
> -
>
> Key: TS-5022
> URL: https://issues.apache.org/jira/browse/TS-5022
> Project: Traffic Server
>  Issue Type: Improvement
>  Components: Security, SSL, TLS
>Reporter: Scott Beardsley
>Assignee: Syeda Persia Aziz
>  Labels: yahoo
> Fix For: 7.1.0
>
>  Time Spent: 8h 20m
>  Remaining Estimate: 0h
>
> Yahoo has a use case where the origin is doing mutual TLS authentication 
> which requires ATS to send a client certificate. This works fine (for now) 
> because ATS supports configuring *one* client cert but this feature should 
> really allow multiple client certificates to be configured which would depend 
> upon the origin being contacted.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Work logged] (TS-5022) Multiple Client Certificate to Origin

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-5022?focusedWorklogId=35093=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-35093
 ]

ASF GitHub Bot logged work on TS-5022:
--

Author: ASF GitHub Bot
Created on: 09/Jan/17 23:40
Start Date: 09/Jan/17 23:40
Worklog Time Spent: 10m 
  Work Description: Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1316
  
FreeBSD build *successful*! See 
https://ci.trafficserver.apache.org/job/Github-FreeBSD/1320/ for details.
 



Issue Time Tracking
---

Worklog Id: (was: 35093)
Time Spent: 8h 10m  (was: 8h)

> Multiple Client Certificate to Origin
> -
>
> Key: TS-5022
> URL: https://issues.apache.org/jira/browse/TS-5022
> Project: Traffic Server
>  Issue Type: Improvement
>  Components: Security, SSL, TLS
>Reporter: Scott Beardsley
>Assignee: Syeda Persia Aziz
>  Labels: yahoo
> Fix For: 7.1.0
>
>  Time Spent: 8h 10m
>  Remaining Estimate: 0h
>
> Yahoo has a use case where the origin is doing mutual TLS authentication 
> which requires ATS to send a client certificate. This works fine (for now) 
> because ATS supports configuring *one* client cert but this feature should 
> really allow multiple client certificates to be configured which would depend 
> upon the origin being contacted.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Work logged] (TS-5022) Multiple Client Certificate to Origin

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-5022?focusedWorklogId=35088=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-35088
 ]

ASF GitHub Bot logged work on TS-5022:
--

Author: ASF GitHub Bot
Created on: 09/Jan/17 23:28
Start Date: 09/Jan/17 23:28
Worklog Time Spent: 10m 
  Work Description: GitHub user persiaAziz opened a pull request:

https://github.com/apache/trafficserver/pull/1316

TS-5022: remove goto in SSLConfig : getnewCTX



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/persiaAziz/trafficserver TS-5022

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/trafficserver/pull/1316.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1316






Issue Time Tracking
---

Worklog Id: (was: 35088)
Time Spent: 8h  (was: 7h 50m)

> Multiple Client Certificate to Origin
> -
>
> Key: TS-5022
> URL: https://issues.apache.org/jira/browse/TS-5022
> Project: Traffic Server
>  Issue Type: Improvement
>  Components: Security, SSL, TLS
>Reporter: Scott Beardsley
>Assignee: Syeda Persia Aziz
>  Labels: yahoo
> Fix For: 7.1.0
>
>  Time Spent: 8h
>  Remaining Estimate: 0h
>
> Yahoo has a use case where the origin is doing mutual TLS authentication 
> which requires ATS to send a client certificate. This works fine (for now) 
> because ATS supports configuring *one* client cert but this feature should 
> really allow multiple client certificates to be configured which would depend 
> upon the origin being contacted.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Work logged] (TS-5022) Multiple Client Certificate to Origin

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-5022?focusedWorklogId=35082=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-35082
 ]

ASF GitHub Bot logged work on TS-5022:
--

Author: ASF GitHub Bot
Created on: 09/Jan/17 22:44
Start Date: 09/Jan/17 22:44
Worklog Time Spent: 10m 
  Work Description: Github user shinrich commented on the issue:

https://github.com/apache/trafficserver/pull/1315
  
Looks good.


Issue Time Tracking
---

Worklog Id: (was: 35082)
Time Spent: 7h 40m  (was: 7.5h)

> Multiple Client Certificate to Origin
> -
>
> Key: TS-5022
> URL: https://issues.apache.org/jira/browse/TS-5022
> Project: Traffic Server
>  Issue Type: Improvement
>  Components: Security, SSL, TLS
>Reporter: Scott Beardsley
>Assignee: Syeda Persia Aziz
>  Labels: yahoo
> Fix For: 7.1.0
>
>  Time Spent: 7h 40m
>  Remaining Estimate: 0h
>
> Yahoo has a use case where the origin is doing mutual TLS authentication 
> which requires ATS to send a client certificate. This works fine (for now) 
> because ATS supports configuring *one* client cert but this feature should 
> really allow multiple client certificates to be configured which would depend 
> upon the origin being contacted.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Work logged] (TS-5022) Multiple Client Certificate to Origin

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-5022?focusedWorklogId=35083=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-35083
 ]

ASF GitHub Bot logged work on TS-5022:
--

Author: ASF GitHub Bot
Created on: 09/Jan/17 22:44
Start Date: 09/Jan/17 22:44
Worklog Time Spent: 10m 
  Work Description: Github user shinrich closed the pull request at:

https://github.com/apache/trafficserver/pull/1315


Issue Time Tracking
---

Worklog Id: (was: 35083)
Time Spent: 7h 50m  (was: 7h 40m)

> Multiple Client Certificate to Origin
> -
>
> Key: TS-5022
> URL: https://issues.apache.org/jira/browse/TS-5022
> Project: Traffic Server
>  Issue Type: Improvement
>  Components: Security, SSL, TLS
>Reporter: Scott Beardsley
>Assignee: Syeda Persia Aziz
>  Labels: yahoo
> Fix For: 7.1.0
>
>  Time Spent: 7h 50m
>  Remaining Estimate: 0h
>
> Yahoo has a use case where the origin is doing mutual TLS authentication 
> which requires ATS to send a client certificate. This works fine (for now) 
> because ATS supports configuring *one* client cert but this feature should 
> really allow multiple client certificates to be configured which would depend 
> upon the origin being contacted.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Work logged] (TS-5022) Multiple Client Certificate to Origin

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-5022?focusedWorklogId=35077=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-35077
 ]

ASF GitHub Bot logged work on TS-5022:
--

Author: ASF GitHub Bot
Created on: 09/Jan/17 21:43
Start Date: 09/Jan/17 21:43
Worklog Time Spent: 10m 
  Work Description: Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1315
  
Linux build *successful*! See 
https://ci.trafficserver.apache.org/job/Github-Linux/1213/ for details.
 



Issue Time Tracking
---

Worklog Id: (was: 35077)
Time Spent: 7.5h  (was: 7h 20m)

> Multiple Client Certificate to Origin
> -
>
> Key: TS-5022
> URL: https://issues.apache.org/jira/browse/TS-5022
> Project: Traffic Server
>  Issue Type: Improvement
>  Components: Security, SSL, TLS
>Reporter: Scott Beardsley
>Assignee: Syeda Persia Aziz
>  Labels: yahoo
> Fix For: 7.1.0
>
>  Time Spent: 7.5h
>  Remaining Estimate: 0h
>
> Yahoo has a use case where the origin is doing mutual TLS authentication 
> which requires ATS to send a client certificate. This works fine (for now) 
> because ATS supports configuring *one* client cert but this feature should 
> really allow multiple client certificates to be configured which would depend 
> upon the origin being contacted.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Work logged] (TS-5022) Multiple Client Certificate to Origin

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-5022?focusedWorklogId=35076=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-35076
 ]

ASF GitHub Bot logged work on TS-5022:
--

Author: ASF GitHub Bot
Created on: 09/Jan/17 21:40
Start Date: 09/Jan/17 21:40
Worklog Time Spent: 10m 
  Work Description: Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1315
  
FreeBSD build *successful*! See 
https://ci.trafficserver.apache.org/job/Github-FreeBSD/1319/ for details.
 



Issue Time Tracking
---

Worklog Id: (was: 35076)
Time Spent: 7h 20m  (was: 7h 10m)

> Multiple Client Certificate to Origin
> -
>
> Key: TS-5022
> URL: https://issues.apache.org/jira/browse/TS-5022
> Project: Traffic Server
>  Issue Type: Improvement
>  Components: Security, SSL, TLS
>Reporter: Scott Beardsley
>Assignee: Syeda Persia Aziz
>  Labels: yahoo
> Fix For: 7.1.0
>
>  Time Spent: 7h 20m
>  Remaining Estimate: 0h
>
> Yahoo has a use case where the origin is doing mutual TLS authentication 
> which requires ATS to send a client certificate. This works fine (for now) 
> because ATS supports configuring *one* client cert but this feature should 
> really allow multiple client certificates to be configured which would depend 
> upon the origin being contacted.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Work logged] (TS-5022) Multiple Client Certificate to Origin

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-5022?focusedWorklogId=35075=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-35075
 ]

ASF GitHub Bot logged work on TS-5022:
--

Author: ASF GitHub Bot
Created on: 09/Jan/17 21:27
Start Date: 09/Jan/17 21:27
Worklog Time Spent: 10m 
  Work Description: Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1315
  
FreeBSD build *failed*! See 
https://ci.trafficserver.apache.org/job/Github-FreeBSD/1318/ for details.
 



Issue Time Tracking
---

Worklog Id: (was: 35075)
Time Spent: 7h 10m  (was: 7h)

> Multiple Client Certificate to Origin
> -
>
> Key: TS-5022
> URL: https://issues.apache.org/jira/browse/TS-5022
> Project: Traffic Server
>  Issue Type: Improvement
>  Components: Security, SSL, TLS
>Reporter: Scott Beardsley
>Assignee: Syeda Persia Aziz
>  Labels: yahoo
> Fix For: 7.1.0
>
>  Time Spent: 7h 10m
>  Remaining Estimate: 0h
>
> Yahoo has a use case where the origin is doing mutual TLS authentication 
> which requires ATS to send a client certificate. This works fine (for now) 
> because ATS supports configuring *one* client cert but this feature should 
> really allow multiple client certificates to be configured which would depend 
> upon the origin being contacted.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Work logged] (TS-5022) Multiple Client Certificate to Origin

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-5022?focusedWorklogId=35074=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-35074
 ]

ASF GitHub Bot logged work on TS-5022:
--

Author: ASF GitHub Bot
Created on: 09/Jan/17 21:23
Start Date: 09/Jan/17 21:23
Worklog Time Spent: 10m 
  Work Description: Github user SolidWallOfCode commented on a diff in the 
pull request:

https://github.com/apache/trafficserver/pull/1315#discussion_r95249133
  
--- Diff: iocore/net/SSLConfig.cc ---
@@ -421,7 +421,6 @@ SSLConfigParams::getNewCTX(char *client_cert) const
   return nclient_ctx;
 fail:
   SSLReleaseContext(nclient_ctx);
--- End diff --

How does this compile, without a return value in this case?


Issue Time Tracking
---

Worklog Id: (was: 35074)
Time Spent: 7h  (was: 6h 50m)

> Multiple Client Certificate to Origin
> -
>
> Key: TS-5022
> URL: https://issues.apache.org/jira/browse/TS-5022
> Project: Traffic Server
>  Issue Type: Improvement
>  Components: Security, SSL, TLS
>Reporter: Scott Beardsley
>Assignee: Syeda Persia Aziz
>  Labels: yahoo
> Fix For: 7.1.0
>
>  Time Spent: 7h
>  Remaining Estimate: 0h
>
> Yahoo has a use case where the origin is doing mutual TLS authentication 
> which requires ATS to send a client certificate. This works fine (for now) 
> because ATS supports configuring *one* client cert but this feature should 
> really allow multiple client certificates to be configured which would depend 
> upon the origin being contacted.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Work logged] (TS-5022) Multiple Client Certificate to Origin

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-5022?focusedWorklogId=35073=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-35073
 ]

ASF GitHub Bot logged work on TS-5022:
--

Author: ASF GitHub Bot
Created on: 09/Jan/17 21:23
Start Date: 09/Jan/17 21:23
Worklog Time Spent: 10m 
  Work Description: Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1315
  
Linux build *failed*! See 
https://ci.trafficserver.apache.org/job/Github-Linux/1212/ for details.
 



Issue Time Tracking
---

Worklog Id: (was: 35073)
Time Spent: 6h 50m  (was: 6h 40m)

> Multiple Client Certificate to Origin
> -
>
> Key: TS-5022
> URL: https://issues.apache.org/jira/browse/TS-5022
> Project: Traffic Server
>  Issue Type: Improvement
>  Components: Security, SSL, TLS
>Reporter: Scott Beardsley
>Assignee: Syeda Persia Aziz
>  Labels: yahoo
> Fix For: 7.1.0
>
>  Time Spent: 6h 50m
>  Remaining Estimate: 0h
>
> Yahoo has a use case where the origin is doing mutual TLS authentication 
> which requires ATS to send a client certificate. This works fine (for now) 
> because ATS supports configuring *one* client cert but this feature should 
> really allow multiple client certificates to be configured which would depend 
> upon the origin being contacted.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Work logged] (TS-5022) Multiple Client Certificate to Origin

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-5022?focusedWorklogId=35072=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-35072
 ]

ASF GitHub Bot logged work on TS-5022:
--

Author: ASF GitHub Bot
Created on: 09/Jan/17 21:21
Start Date: 09/Jan/17 21:21
Worklog Time Spent: 10m 
  Work Description: GitHub user persiaAziz opened a pull request:

https://github.com/apache/trafficserver/pull/1315

TS-5022: fix silent exit problem



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/persiaAziz/trafficserver TS-5022

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/trafficserver/pull/1315.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1315


commit 5ffbcb63ec80ef9461dd2512683cfc4991cfb404
Author: Persia Aziz 
Date:   2017-01-09T21:14:20Z

TS-5022: fix silent exit problem




Issue Time Tracking
---

Worklog Id: (was: 35072)
Time Spent: 6h 40m  (was: 6.5h)

> Multiple Client Certificate to Origin
> -
>
> Key: TS-5022
> URL: https://issues.apache.org/jira/browse/TS-5022
> Project: Traffic Server
>  Issue Type: Improvement
>  Components: Security, SSL, TLS
>Reporter: Scott Beardsley
>Assignee: Syeda Persia Aziz
>  Labels: yahoo
> Fix For: 7.1.0
>
>  Time Spent: 6h 40m
>  Remaining Estimate: 0h
>
> Yahoo has a use case where the origin is doing mutual TLS authentication 
> which requires ATS to send a client certificate. This works fine (for now) 
> because ATS supports configuring *one* client cert but this feature should 
> really allow multiple client certificates to be configured which would depend 
> upon the origin being contacted.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Work logged] (TS-5092) ATS handling of too many concurrent streams too agressive and maybe out of spec

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-5092?focusedWorklogId=35071=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-35071
 ]

ASF GitHub Bot logged work on TS-5092:
--

Author: ASF GitHub Bot
Created on: 09/Jan/17 21:04
Start Date: 09/Jan/17 21:04
Worklog Time Spent: 10m 
  Work Description: Github user shinrich closed the issue at:

https://github.com/apache/trafficserver/issues/1308


Issue Time Tracking
---

Worklog Id: (was: 35071)
Time Spent: 1h 40m  (was: 1.5h)

> ATS handling of too many concurrent streams too agressive and maybe out of 
> spec
> ---
>
> Key: TS-5092
> URL: https://issues.apache.org/jira/browse/TS-5092
> Project: Traffic Server
>  Issue Type: Bug
>  Components: HTTP/2
>Reporter: Susan Hinrichs
>Assignee: Susan Hinrichs
> Fix For: 7.1.0
>
>  Time Spent: 1h 40m
>  Remaining Estimate: 0h
>
> This issue was identified while debugging new errors seen by an internal team 
> after they enabled HTTP/2 in their client. On the backend, they saw an 
> increase in the cases were ATS sends the origin the POST header but no POST 
> body and then closes the connection.
> With the addition of Error() messages we were able to see a case where the 
> client is trying to open the 101'st stream on a session. This is beyond the 
> 100 max concurrent stream limit, so ATS shuts down the session which kills 
> the previous 100 streams.
> A closer reading of section 5.1.2 of the spec 
> (https://tools.ietf.org/html/rfc7540#section-5.1.2) indicates that this 
> should be a stream error and not a connection error. Bryan Call, Masaori, and 
> Maskit confirmed this interpretation. Maskit also noted that the other error 
> case in the current createStream method must be treated as a connection error.
> Presumably the client library is expecting the refused stream case so it can 
> try again later.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Work logged] (TS-5022) Multiple Client Certificate to Origin

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-5022?focusedWorklogId=35066=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-35066
 ]

ASF GitHub Bot logged work on TS-5022:
--

Author: ASF GitHub Bot
Created on: 09/Jan/17 18:33
Start Date: 09/Jan/17 18:33
Worklog Time Spent: 10m 
  Work Description: Github user shinrich closed the pull request at:

https://github.com/apache/trafficserver/pull/1310


Issue Time Tracking
---

Worklog Id: (was: 35066)
Time Spent: 6.5h  (was: 6h 20m)

> Multiple Client Certificate to Origin
> -
>
> Key: TS-5022
> URL: https://issues.apache.org/jira/browse/TS-5022
> Project: Traffic Server
>  Issue Type: Improvement
>  Components: Security, SSL, TLS
>Reporter: Scott Beardsley
>Assignee: Syeda Persia Aziz
>  Labels: yahoo
> Fix For: 7.1.0
>
>  Time Spent: 6.5h
>  Remaining Estimate: 0h
>
> Yahoo has a use case where the origin is doing mutual TLS authentication 
> which requires ATS to send a client certificate. This works fine (for now) 
> because ATS supports configuring *one* client cert but this feature should 
> really allow multiple client certificates to be configured which would depend 
> upon the origin being contacted.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Work logged] (TS-5022) Multiple Client Certificate to Origin

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-5022?focusedWorklogId=35065=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-35065
 ]

ASF GitHub Bot logged work on TS-5022:
--

Author: ASF GitHub Bot
Created on: 09/Jan/17 18:32
Start Date: 09/Jan/17 18:32
Worklog Time Spent: 10m 
  Work Description: Github user shinrich commented on the issue:

https://github.com/apache/trafficserver/pull/1310
  
Looks good.  Also addresses Issue 1308.


Issue Time Tracking
---

Worklog Id: (was: 35065)
Time Spent: 6h 20m  (was: 6h 10m)

> Multiple Client Certificate to Origin
> -
>
> Key: TS-5022
> URL: https://issues.apache.org/jira/browse/TS-5022
> Project: Traffic Server
>  Issue Type: Improvement
>  Components: Security, SSL, TLS
>Reporter: Scott Beardsley
>Assignee: Syeda Persia Aziz
>  Labels: yahoo
> Fix For: 7.1.0
>
>  Time Spent: 6h 20m
>  Remaining Estimate: 0h
>
> Yahoo has a use case where the origin is doing mutual TLS authentication 
> which requires ATS to send a client certificate. This works fine (for now) 
> because ATS supports configuring *one* client cert but this feature should 
> really allow multiple client certificates to be configured which would depend 
> upon the origin being contacted.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Work logged] (TS-5022) Multiple Client Certificate to Origin

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-5022?focusedWorklogId=35012=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-35012
 ]

ASF GitHub Bot logged work on TS-5022:
--

Author: ASF GitHub Bot
Created on: 09/Jan/17 02:03
Start Date: 09/Jan/17 02:03
Worklog Time Spent: 10m 
  Work Description: Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1310
  
Linux build *successful*! See 
https://ci.trafficserver.apache.org/job/Github-Linux/1206/ for details.
 



Issue Time Tracking
---

Worklog Id: (was: 35012)
Time Spent: 6h 10m  (was: 6h)

> Multiple Client Certificate to Origin
> -
>
> Key: TS-5022
> URL: https://issues.apache.org/jira/browse/TS-5022
> Project: Traffic Server
>  Issue Type: Improvement
>  Components: Security, SSL, TLS
>Reporter: Scott Beardsley
>Assignee: Syeda Persia Aziz
>  Labels: yahoo
> Fix For: 7.1.0
>
>  Time Spent: 6h 10m
>  Remaining Estimate: 0h
>
> Yahoo has a use case where the origin is doing mutual TLS authentication 
> which requires ATS to send a client certificate. This works fine (for now) 
> because ATS supports configuring *one* client cert but this feature should 
> really allow multiple client certificates to be configured which would depend 
> upon the origin being contacted.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Work logged] (TS-5022) Multiple Client Certificate to Origin

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-5022?focusedWorklogId=35011=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-35011
 ]

ASF GitHub Bot logged work on TS-5022:
--

Author: ASF GitHub Bot
Created on: 09/Jan/17 02:00
Start Date: 09/Jan/17 02:00
Worklog Time Spent: 10m 
  Work Description: Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1310
  
FreeBSD build *successful*! See 
https://ci.trafficserver.apache.org/job/Github-FreeBSD/1312/ for details.
 



Issue Time Tracking
---

Worklog Id: (was: 35011)
Time Spent: 6h  (was: 5h 50m)

> Multiple Client Certificate to Origin
> -
>
> Key: TS-5022
> URL: https://issues.apache.org/jira/browse/TS-5022
> Project: Traffic Server
>  Issue Type: Improvement
>  Components: Security, SSL, TLS
>Reporter: Scott Beardsley
>Assignee: Syeda Persia Aziz
>  Labels: yahoo
> Fix For: 7.1.0
>
>  Time Spent: 6h
>  Remaining Estimate: 0h
>
> Yahoo has a use case where the origin is doing mutual TLS authentication 
> which requires ATS to send a client certificate. This works fine (for now) 
> because ATS supports configuring *one* client cert but this feature should 
> really allow multiple client certificates to be configured which would depend 
> upon the origin being contacted.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Work logged] (TS-5022) Multiple Client Certificate to Origin

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-5022?focusedWorklogId=35008=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-35008
 ]

ASF GitHub Bot logged work on TS-5022:
--

Author: ASF GitHub Bot
Created on: 09/Jan/17 01:47
Start Date: 09/Jan/17 01:47
Worklog Time Spent: 10m 
  Work Description: GitHub user persiaAziz opened a pull request:

https://github.com/apache/trafficserver/pull/1310

TS-5022: resource leak fix CID 1368316



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/persiaAziz/trafficserver TS-5022

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/trafficserver/pull/1310.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1310


commit fe31808d90342273186bc5f69a331999d4a96124
Author: Syeda Persia Aziz 
Date:   2017-01-09T01:35:20Z

TS-5022: resource leak fix




Issue Time Tracking
---

Worklog Id: (was: 35008)
Time Spent: 5h 50m  (was: 5h 40m)

> Multiple Client Certificate to Origin
> -
>
> Key: TS-5022
> URL: https://issues.apache.org/jira/browse/TS-5022
> Project: Traffic Server
>  Issue Type: Improvement
>  Components: Security, SSL, TLS
>Reporter: Scott Beardsley
>Assignee: Syeda Persia Aziz
>  Labels: yahoo
> Fix For: 7.1.0
>
>  Time Spent: 5h 50m
>  Remaining Estimate: 0h
>
> Yahoo has a use case where the origin is doing mutual TLS authentication 
> which requires ATS to send a client certificate. This works fine (for now) 
> because ATS supports configuring *one* client cert but this feature should 
> really allow multiple client certificates to be configured which would depend 
> upon the origin being contacted.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Work logged] (TS-5107) ATS 7.0.0 doesn't build against python docutils 0.13.1

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-5107?focusedWorklogId=34992=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-34992
 ]

ASF GitHub Bot logged work on TS-5107:
--

Author: ASF GitHub Bot
Created on: 08/Jan/17 18:29
Start Date: 08/Jan/17 18:29
Worklog Time Spent: 10m 
  Work Description: Github user jbfavre commented on the issue:

https://github.com/apache/trafficserver/pull/1303
  
AFAIK, there're no case yet where an issue exists only on Github.
But, this has been "announced" by Bryan Call on trafficserver-dev: 
https://mail-archives.apache.org/mod_mbox/trafficserver-dev/201612.mbox/%3ce5d8e071-8de0-4930-bc2d-15cae1d57...@apache.org%3e
 so I asume this will come to reality one day.

Like I said, I won't go against the Autolink feature :)


Issue Time Tracking
---

Worklog Id: (was: 34992)
Time Spent: 2h 50m  (was: 2h 40m)

> ATS 7.0.0 doesn't build against python docutils 0.13.1
> --
>
> Key: TS-5107
> URL: https://issues.apache.org/jira/browse/TS-5107
> Project: Traffic Server
>  Issue Type: Bug
>  Components: Documentation
>Reporter: Jean Baptiste Favre
>Assignee: Jean Baptiste Favre
> Fix For: 7.0.1
>
>  Time Spent: 2h 50m
>  Remaining Estimate: 0h
>
> Trying to build ATS 7.0.0 with python docutils 0.13.1 on Debian fails
> with following error:
> {code}Making all in doc
> make[2]: Entering directory '/home/debocker/source/build/doc'
> PAPEROPT_a4="-D latex_paper_size=a4" PAPEROPT_letter="-D
> latex_paper_size=letter" PAPER="letter" ./sbuild sphinx-build -c .  -d
> docbuild/doctrees -b man . docbuild/man
> Running Sphinx v1.4.9
> making output directory...
> WARNING: sphinx.ext.pngmath has been deprecated. Please use
> sphinx.ext.imgmath instead.
> loading pickled environment... not yet created
> building [mo]: targets for 0 po files that are out of date
> building [man]: all manpages
> updating environment: 456 added, 0 changed, 0 removed
> reading sources... [  0%] admin-guide/configuration/cache-basics.en
> Exception occurred:
>   File "conf.py", line 185, in __init__
> start_string_prefix=self.start_string_prefix,
> AttributeError: Inliner instance has no attribute 'start_string_prefix'
> The full traceback has been saved in /tmp/sphinx-err-5iq_t9.log, if you
> want to report the issue to the developers.
> Please also report this if it was a user error, so that a better error
> message can be provided next time.
> A bug report can be filed in the tracker at
> . Thanks!
> Makefile:998: recipe for target 'man' failed
> make[2]: Leaving directory '/home/debocker/source/build/doc'
> make[2]: *** [man] Error 1
> make[1]: *** [all-recursive] Error 1{code}
> I tracked it down to 
> [docutils/parsers/rst/states.py|https://fossies.org/diffs/docutils/0.12_vs_0.13.1/docutils/parsers/rst/states.py-diff.html]
>  which changed
> between 0.12 & 0.13.1
> {{start_string_prefix}} is not defined anymore at {{Inliner}} init. We have to
> call {{init_cutomizations}} method, but I can't figure out the {{settings}}
> structure.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Work logged] (TS-5107) ATS 7.0.0 doesn't build against python docutils 0.13.1

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-5107?focusedWorklogId=34989=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-34989
 ]

ASF GitHub Bot logged work on TS-5107:
--

Author: ASF GitHub Bot
Created on: 08/Jan/17 16:33
Start Date: 08/Jan/17 16:33
Worklog Time Spent: 10m 
  Work Description: Github user jablko commented on the issue:

https://github.com/apache/trafficserver/pull/1303
  
> The ``inliner`` parameter takes an instance of `states.Inliner` or a 
subclass.
> It handles inline markup recognition. A common extension is the addition 
of
> further implicit hyperlinks, like "RFC 2822". This can be done by 
subclassing
> `states.Inliner`, adding a new method for the implicit markup, and adding 
a
> ``(pattern, method)`` pair to the "implicit_dispatch" attribute of the
> subclass. See `states.Inliner.implicit_inline()` for details.


https://sourceforge.net/p/docutils/code/HEAD/tree/trunk/docutils/docutils/parsers/rst/__init__.py#l59

This is exactly what we're doing. I think it's okay that Docutils added the 
init_customizations() method between versions -- it sounds like it was their 
only option.

I don't have a strong sense yet how we want to reference GitHub issues (are 
there any cases yet?) so it's hard to judge whether consistency between Jira 
and GitHub is desirable. One thing I personally like about TS-1234 (for Jira) 
is that we use the same in commit messages, source code comments, etc. so it's 
consistent in that sense.


Issue Time Tracking
---

Worklog Id: (was: 34989)
Time Spent: 2h 40m  (was: 2.5h)

> ATS 7.0.0 doesn't build against python docutils 0.13.1
> --
>
> Key: TS-5107
> URL: https://issues.apache.org/jira/browse/TS-5107
> Project: Traffic Server
>  Issue Type: Bug
>  Components: Documentation
>Reporter: Jean Baptiste Favre
>Assignee: Jean Baptiste Favre
> Fix For: 7.0.1
>
>  Time Spent: 2h 40m
>  Remaining Estimate: 0h
>
> Trying to build ATS 7.0.0 with python docutils 0.13.1 on Debian fails
> with following error:
> {code}Making all in doc
> make[2]: Entering directory '/home/debocker/source/build/doc'
> PAPEROPT_a4="-D latex_paper_size=a4" PAPEROPT_letter="-D
> latex_paper_size=letter" PAPER="letter" ./sbuild sphinx-build -c .  -d
> docbuild/doctrees -b man . docbuild/man
> Running Sphinx v1.4.9
> making output directory...
> WARNING: sphinx.ext.pngmath has been deprecated. Please use
> sphinx.ext.imgmath instead.
> loading pickled environment... not yet created
> building [mo]: targets for 0 po files that are out of date
> building [man]: all manpages
> updating environment: 456 added, 0 changed, 0 removed
> reading sources... [  0%] admin-guide/configuration/cache-basics.en
> Exception occurred:
>   File "conf.py", line 185, in __init__
> start_string_prefix=self.start_string_prefix,
> AttributeError: Inliner instance has no attribute 'start_string_prefix'
> The full traceback has been saved in /tmp/sphinx-err-5iq_t9.log, if you
> want to report the issue to the developers.
> Please also report this if it was a user error, so that a better error
> message can be provided next time.
> A bug report can be filed in the tracker at
> . Thanks!
> Makefile:998: recipe for target 'man' failed
> make[2]: Leaving directory '/home/debocker/source/build/doc'
> make[2]: *** [man] Error 1
> make[1]: *** [all-recursive] Error 1{code}
> I tracked it down to 
> [docutils/parsers/rst/states.py|https://fossies.org/diffs/docutils/0.12_vs_0.13.1/docutils/parsers/rst/states.py-diff.html]
>  which changed
> between 0.12 & 0.13.1
> {{start_string_prefix}} is not defined anymore at {{Inliner}} init. We have to
> call {{init_cutomizations}} method, but I can't figure out the {{settings}}
> structure.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Work logged] (TS-5107) ATS 7.0.0 doesn't build against python docutils 0.13.1

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-5107?focusedWorklogId=34988=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-34988
 ]

ASF GitHub Bot logged work on TS-5107:
--

Author: ASF GitHub Bot
Created on: 08/Jan/17 15:35
Start Date: 08/Jan/17 15:35
Worklog Time Spent: 10m 
  Work Description: Github user jbfavre commented on the issue:

https://github.com/apache/trafficserver/pull/1303
  
Well, at least I won't go against it :)

When fixing it in first place, docutils devs feedback was that we wrongly 
used Inliner, in the sense it's supposed to be internal.
What if another docutils internal change breaks it again ? Don't think it 
won't happen because the discussion I had showed that not every docutils dev is 
happy with last change. So, chances are that there'll be another refacto, maybe 
for 0.15 or 0.16.
Better solution, in both docutils devs & myself, should be to make Sphinx 
allow customization.

Second concern is that, IMHO, we shouldn't allow 2 different syntax to 
reference trafficserver issues in documentation.
This usually leads to confusion (why should I use one more than another ?)

Finally, the fix I made has another positive effect: we now have a 
consistent way of referencing issues, for both Jira & Github. For now, I don't 
see any way to differentiate Jira & github ones with the Autolink feature.

My 2 cents,


Issue Time Tracking
---

Worklog Id: (was: 34988)
Time Spent: 2.5h  (was: 2h 20m)

> ATS 7.0.0 doesn't build against python docutils 0.13.1
> --
>
> Key: TS-5107
> URL: https://issues.apache.org/jira/browse/TS-5107
> Project: Traffic Server
>  Issue Type: Bug
>  Components: Documentation
>Reporter: Jean Baptiste Favre
>Assignee: Jean Baptiste Favre
> Fix For: 7.0.1
>
>  Time Spent: 2.5h
>  Remaining Estimate: 0h
>
> Trying to build ATS 7.0.0 with python docutils 0.13.1 on Debian fails
> with following error:
> {code}Making all in doc
> make[2]: Entering directory '/home/debocker/source/build/doc'
> PAPEROPT_a4="-D latex_paper_size=a4" PAPEROPT_letter="-D
> latex_paper_size=letter" PAPER="letter" ./sbuild sphinx-build -c .  -d
> docbuild/doctrees -b man . docbuild/man
> Running Sphinx v1.4.9
> making output directory...
> WARNING: sphinx.ext.pngmath has been deprecated. Please use
> sphinx.ext.imgmath instead.
> loading pickled environment... not yet created
> building [mo]: targets for 0 po files that are out of date
> building [man]: all manpages
> updating environment: 456 added, 0 changed, 0 removed
> reading sources... [  0%] admin-guide/configuration/cache-basics.en
> Exception occurred:
>   File "conf.py", line 185, in __init__
> start_string_prefix=self.start_string_prefix,
> AttributeError: Inliner instance has no attribute 'start_string_prefix'
> The full traceback has been saved in /tmp/sphinx-err-5iq_t9.log, if you
> want to report the issue to the developers.
> Please also report this if it was a user error, so that a better error
> message can be provided next time.
> A bug report can be filed in the tracker at
> . Thanks!
> Makefile:998: recipe for target 'man' failed
> make[2]: Leaving directory '/home/debocker/source/build/doc'
> make[2]: *** [man] Error 1
> make[1]: *** [all-recursive] Error 1{code}
> I tracked it down to 
> [docutils/parsers/rst/states.py|https://fossies.org/diffs/docutils/0.12_vs_0.13.1/docutils/parsers/rst/states.py-diff.html]
>  which changed
> between 0.12 & 0.13.1
> {{start_string_prefix}} is not defined anymore at {{Inliner}} init. We have to
> call {{init_cutomizations}} method, but I can't figure out the {{settings}}
> structure.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Work logged] (TS-5107) ATS 7.0.0 doesn't build against python docutils 0.13.1

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-5107?focusedWorklogId=34987=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-34987
 ]

ASF GitHub Bot logged work on TS-5107:
--

Author: ASF GitHub Bot
Created on: 08/Jan/17 15:26
Start Date: 08/Jan/17 15:26
Worklog Time Spent: 10m 
  Work Description: Github user jablko commented on the issue:

https://github.com/apache/trafficserver/pull/1303
  
@zwoop Yes, I'd like to backport this to 7.1.x if @SolidWallOfCode, @jsime, 
and @jbfavre approve it. #1296 is in 7.1.x already.


Issue Time Tracking
---

Worklog Id: (was: 34987)
Time Spent: 2h 20m  (was: 2h 10m)

> ATS 7.0.0 doesn't build against python docutils 0.13.1
> --
>
> Key: TS-5107
> URL: https://issues.apache.org/jira/browse/TS-5107
> Project: Traffic Server
>  Issue Type: Bug
>  Components: Documentation
>Reporter: Jean Baptiste Favre
>Assignee: Jean Baptiste Favre
> Fix For: 7.0.1
>
>  Time Spent: 2h 20m
>  Remaining Estimate: 0h
>
> Trying to build ATS 7.0.0 with python docutils 0.13.1 on Debian fails
> with following error:
> {code}Making all in doc
> make[2]: Entering directory '/home/debocker/source/build/doc'
> PAPEROPT_a4="-D latex_paper_size=a4" PAPEROPT_letter="-D
> latex_paper_size=letter" PAPER="letter" ./sbuild sphinx-build -c .  -d
> docbuild/doctrees -b man . docbuild/man
> Running Sphinx v1.4.9
> making output directory...
> WARNING: sphinx.ext.pngmath has been deprecated. Please use
> sphinx.ext.imgmath instead.
> loading pickled environment... not yet created
> building [mo]: targets for 0 po files that are out of date
> building [man]: all manpages
> updating environment: 456 added, 0 changed, 0 removed
> reading sources... [  0%] admin-guide/configuration/cache-basics.en
> Exception occurred:
>   File "conf.py", line 185, in __init__
> start_string_prefix=self.start_string_prefix,
> AttributeError: Inliner instance has no attribute 'start_string_prefix'
> The full traceback has been saved in /tmp/sphinx-err-5iq_t9.log, if you
> want to report the issue to the developers.
> Please also report this if it was a user error, so that a better error
> message can be provided next time.
> A bug report can be filed in the tracker at
> . Thanks!
> Makefile:998: recipe for target 'man' failed
> make[2]: Leaving directory '/home/debocker/source/build/doc'
> make[2]: *** [man] Error 1
> make[1]: *** [all-recursive] Error 1{code}
> I tracked it down to 
> [docutils/parsers/rst/states.py|https://fossies.org/diffs/docutils/0.12_vs_0.13.1/docutils/parsers/rst/states.py-diff.html]
>  which changed
> between 0.12 & 0.13.1
> {{start_string_prefix}} is not defined anymore at {{Inliner}} init. We have to
> call {{init_cutomizations}} method, but I can't figure out the {{settings}}
> structure.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Work logged] (TS-5105) Assert on Socks.cc line 67, due to remote_addr not set in connect_re_internal

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-5105?focusedWorklogId=34967=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-34967
 ]

ASF GitHub Bot logged work on TS-5105:
--

Author: ASF GitHub Bot
Created on: 08/Jan/17 06:32
Start Date: 08/Jan/17 06:32
Worklog Time Spent: 10m 
  Work Description: Github user oknet commented on the issue:

https://github.com/apache/trafficserver/pull/1276
  
Sorry, it is my fault, the commit 724f7cb5cc2c689d618ad306b5ca5795aec88b11 
did not merge into 6.2.x. I should rewrite the patch working with 
vc->server_addr.


Issue Time Tracking
---

Worklog Id: (was: 34967)
Time Spent: 2h 10m  (was: 2h)

> Assert on Socks.cc line 67, due to remote_addr not set in connect_re_internal
> -
>
> Key: TS-5105
> URL: https://issues.apache.org/jira/browse/TS-5105
> Project: Traffic Server
>  Issue Type: Bug
>  Components: SOCKS
>Reporter: Oknet Xu
>Assignee: Oknet Xu
> Fix For: 7.0.0
>
>  Time Spent: 2h 10m
>  Remaining Estimate: 0h
>
> {code}
> traffic_server: using root directory '/usr/local'
> traffic_server: Abort trap
> traffic_server - STACK TRACE:
> 0x4b07a9 <_Z19crash_logger_invokeiP9__siginfoPv+0x69> at 
> /usr/local/bin/traffic_server
> 0x80275ab37  at /lib/libthr.so.3
> 0x80275a22c  at /lib/libthr.so.3
> [Dec 21 17:27:34.840] Server {0x804006400} DEBUG:  (loadSocksConfiguration)> (Socks) Socks Version 4
> [Dec 21 17:27:34.840] Server {0x804006400} DEBUG:  (loadSocksConfiguration)> (Socks) server connect timeout: 10 socks respnonse 
> timeout 100
> [Dec 21 17:27:34.840] Server {0x804006400} DEBUG:  (loadSocksConfiguration)> (SocksProxy) Read SocksProxy info: accept_enabled = 
> 0 accept_port = 1080 http_port = 80
> [Dec 21 17:27:34.841] Server {0x804006400} DEBUG:  (loadSocksConfiguration)> (Socks) Socks Config File: 
> /usr/local/etc/trafficserver/socks.config
> [Dec 21 17:27:34.842] Server {0x804006400} DEBUG:  (loadSocksConfiguration)> (Socks) Socks Turned on
> [Dec 21 17:27:35.052] Server {0x804008000} DEBUG:  (connect_re_internal)> (Socks) Using Socks ip: 216.58.192.142:80
> Assertion failed: (ats_is_ip4(_addr)), function init, file Socks.cc, 
> line 67.
> traffic_server: using root directory '/usr/local'
> traffic_server: Abort trap
> traffic_server - STACK TRACE:
> 0x4b07a9 <_Z19crash_logger_invokeiP9__siginfoPv+0x69> at 
> /usr/local/bin/traffic_server
> 0x80275ab37  at /lib/libthr.so.3
> 0x80275a22c  at /lib/libthr.so.3
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Work logged] (TS-5105) Assert on Socks.cc line 67, due to remote_addr not set in connect_re_internal

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-5105?focusedWorklogId=34966=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-34966
 ]

ASF GitHub Bot logged work on TS-5105:
--

Author: ASF GitHub Bot
Created on: 08/Jan/17 05:32
Start Date: 08/Jan/17 05:32
Worklog Time Spent: 10m 
  Work Description: Github user oknet commented on the issue:

https://github.com/apache/trafficserver/pull/1276
  
It is crash in ats_base64_encode during regression test.

```
traffic_server: Aborted (Signal sent by tkill() 2585 989)
traffic_server - STACK TRACE: 

/var/jenkins/workspace/Github-Linux/1204/install/bin/traffic_server(crash_logger_invoke(int,
 siginfo_t*, void*)+0xc3)[0x5096f4]
/lib64/libpthread.so.0(+0xf370)[0x7f601e88f370]
/lib64/libc.so.6(gsignal+0x37)[0x7f601d7651d7]
/lib64/libc.so.6(abort+0x148)[0x7f601d7668c8]

/var/jenkins/workspace/Github-Linux/1204/install/lib/libtsutil.so.6(ink_fatal_va(char
 const*, __va_list_tag*)+0x0)[0x7f60203891fd]

/var/jenkins/workspace/Github-Linux/1204/install/lib/libtsutil.so.6(ink_fatal(char
 const*, ...)+0x0)[0x7f60203892b6]

/var/jenkins/workspace/Github-Linux/1204/install/lib/libtsutil.so.6(ink_pfatal(char
 const*, ...)+0x0)[0x7f6020389355]

/var/jenkins/workspace/Github-Linux/1204/install/lib/libtsutil.so.6(ats_base64_encode(unsigned
 char const*, unsigned long, char*, unsigned long, unsigned 
long*)+0x0)[0x7f6020386d96]

/var/jenkins/workspace/Github-Linux/1204/install/bin/traffic_server[0x56ce19]

/var/jenkins/workspace/Github-Linux/1204/install/bin/traffic_server(INKContInternal::handle_event(int,
 void*)+0xe5)[0x520b83]

/var/jenkins/workspace/Github-Linux/1204/install/bin/traffic_server(Continuation::handleEvent(int,
 void*)+0x72)[0x50c662]

/var/jenkins/workspace/Github-Linux/1204/install/bin/traffic_server(EThread::process_event(Event*,
 int)+0x136)[0x79e4dc]

/var/jenkins/workspace/Github-Linux/1204/install/bin/traffic_server(EThread::execute()+0x288)[0x79e8e8]

/var/jenkins/workspace/Github-Linux/1204/install/bin/traffic_server[0x79dabd]
/lib64/libpthread.so.0(+0x7dc5)[0x7f601e887dc5]
/lib64/libc.so.6(clone+0x6d)[0x7f601d82773d]
```


Issue Time Tracking
---

Worklog Id: (was: 34966)
Time Spent: 2h  (was: 1h 50m)

> Assert on Socks.cc line 67, due to remote_addr not set in connect_re_internal
> -
>
> Key: TS-5105
> URL: https://issues.apache.org/jira/browse/TS-5105
> Project: Traffic Server
>  Issue Type: Bug
>  Components: SOCKS
>Reporter: Oknet Xu
>Assignee: Oknet Xu
> Fix For: 7.0.0
>
>  Time Spent: 2h
>  Remaining Estimate: 0h
>
> {code}
> traffic_server: using root directory '/usr/local'
> traffic_server: Abort trap
> traffic_server - STACK TRACE:
> 0x4b07a9 <_Z19crash_logger_invokeiP9__siginfoPv+0x69> at 
> /usr/local/bin/traffic_server
> 0x80275ab37  at /lib/libthr.so.3
> 0x80275a22c  at /lib/libthr.so.3
> [Dec 21 17:27:34.840] Server {0x804006400} DEBUG:  (loadSocksConfiguration)> (Socks) Socks Version 4
> [Dec 21 17:27:34.840] Server {0x804006400} DEBUG:  (loadSocksConfiguration)> (Socks) server connect timeout: 10 socks respnonse 
> timeout 100
> [Dec 21 17:27:34.840] Server {0x804006400} DEBUG:  (loadSocksConfiguration)> (SocksProxy) Read SocksProxy info: accept_enabled = 
> 0 accept_port = 1080 http_port = 80
> [Dec 21 17:27:34.841] Server {0x804006400} DEBUG:  (loadSocksConfiguration)> (Socks) Socks Config File: 
> /usr/local/etc/trafficserver/socks.config
> [Dec 21 17:27:34.842] Server {0x804006400} DEBUG:  (loadSocksConfiguration)> (Socks) Socks Turned on
> [Dec 21 17:27:35.052] Server {0x804008000} DEBUG:  (connect_re_internal)> (Socks) Using Socks ip: 216.58.192.142:80
> Assertion failed: (ats_is_ip4(_addr)), function init, file Socks.cc, 
> line 67.
> traffic_server: using root directory '/usr/local'
> traffic_server: Abort trap
> traffic_server - STACK TRACE:
> 0x4b07a9 <_Z19crash_logger_invokeiP9__siginfoPv+0x69> at 
> /usr/local/bin/traffic_server
> 0x80275ab37  at /lib/libthr.so.3
> 0x80275a22c  at /lib/libthr.so.3
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Work logged] (TS-5105) Assert on Socks.cc line 67, due to remote_addr not set in connect_re_internal

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-5105?focusedWorklogId=34965=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-34965
 ]

ASF GitHub Bot logged work on TS-5105:
--

Author: ASF GitHub Bot
Created on: 08/Jan/17 03:22
Start Date: 08/Jan/17 03:22
Worklog Time Spent: 10m 
  Work Description: Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1276
  
Linux build *failed*! See 
https://ci.trafficserver.apache.org/job/Github-Linux/1204/ for details.
 



Issue Time Tracking
---

Worklog Id: (was: 34965)
Time Spent: 1h 50m  (was: 1h 40m)

> Assert on Socks.cc line 67, due to remote_addr not set in connect_re_internal
> -
>
> Key: TS-5105
> URL: https://issues.apache.org/jira/browse/TS-5105
> Project: Traffic Server
>  Issue Type: Bug
>  Components: SOCKS
>Reporter: Oknet Xu
>Assignee: Oknet Xu
> Fix For: 7.0.0
>
>  Time Spent: 1h 50m
>  Remaining Estimate: 0h
>
> {code}
> traffic_server: using root directory '/usr/local'
> traffic_server: Abort trap
> traffic_server - STACK TRACE:
> 0x4b07a9 <_Z19crash_logger_invokeiP9__siginfoPv+0x69> at 
> /usr/local/bin/traffic_server
> 0x80275ab37  at /lib/libthr.so.3
> 0x80275a22c  at /lib/libthr.so.3
> [Dec 21 17:27:34.840] Server {0x804006400} DEBUG:  (loadSocksConfiguration)> (Socks) Socks Version 4
> [Dec 21 17:27:34.840] Server {0x804006400} DEBUG:  (loadSocksConfiguration)> (Socks) server connect timeout: 10 socks respnonse 
> timeout 100
> [Dec 21 17:27:34.840] Server {0x804006400} DEBUG:  (loadSocksConfiguration)> (SocksProxy) Read SocksProxy info: accept_enabled = 
> 0 accept_port = 1080 http_port = 80
> [Dec 21 17:27:34.841] Server {0x804006400} DEBUG:  (loadSocksConfiguration)> (Socks) Socks Config File: 
> /usr/local/etc/trafficserver/socks.config
> [Dec 21 17:27:34.842] Server {0x804006400} DEBUG:  (loadSocksConfiguration)> (Socks) Socks Turned on
> [Dec 21 17:27:35.052] Server {0x804008000} DEBUG:  (connect_re_internal)> (Socks) Using Socks ip: 216.58.192.142:80
> Assertion failed: (ats_is_ip4(_addr)), function init, file Socks.cc, 
> line 67.
> traffic_server: using root directory '/usr/local'
> traffic_server: Abort trap
> traffic_server - STACK TRACE:
> 0x4b07a9 <_Z19crash_logger_invokeiP9__siginfoPv+0x69> at 
> /usr/local/bin/traffic_server
> 0x80275ab37  at /lib/libthr.so.3
> 0x80275a22c  at /lib/libthr.so.3
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Work logged] (TS-5105) Assert on Socks.cc line 67, due to remote_addr not set in connect_re_internal

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-5105?focusedWorklogId=34964=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-34964
 ]

ASF GitHub Bot logged work on TS-5105:
--

Author: ASF GitHub Bot
Created on: 08/Jan/17 03:07
Start Date: 08/Jan/17 03:07
Worklog Time Spent: 10m 
  Work Description: Github user zwoop commented on the issue:

https://github.com/apache/trafficserver/pull/1276
  
Trying a new  build [approve ci] 


Issue Time Tracking
---

Worklog Id: (was: 34964)
Time Spent: 1h 40m  (was: 1.5h)

> Assert on Socks.cc line 67, due to remote_addr not set in connect_re_internal
> -
>
> Key: TS-5105
> URL: https://issues.apache.org/jira/browse/TS-5105
> Project: Traffic Server
>  Issue Type: Bug
>  Components: SOCKS
>Reporter: Oknet Xu
>Assignee: Oknet Xu
> Fix For: 7.0.0
>
>  Time Spent: 1h 40m
>  Remaining Estimate: 0h
>
> {code}
> traffic_server: using root directory '/usr/local'
> traffic_server: Abort trap
> traffic_server - STACK TRACE:
> 0x4b07a9 <_Z19crash_logger_invokeiP9__siginfoPv+0x69> at 
> /usr/local/bin/traffic_server
> 0x80275ab37  at /lib/libthr.so.3
> 0x80275a22c  at /lib/libthr.so.3
> [Dec 21 17:27:34.840] Server {0x804006400} DEBUG:  (loadSocksConfiguration)> (Socks) Socks Version 4
> [Dec 21 17:27:34.840] Server {0x804006400} DEBUG:  (loadSocksConfiguration)> (Socks) server connect timeout: 10 socks respnonse 
> timeout 100
> [Dec 21 17:27:34.840] Server {0x804006400} DEBUG:  (loadSocksConfiguration)> (SocksProxy) Read SocksProxy info: accept_enabled = 
> 0 accept_port = 1080 http_port = 80
> [Dec 21 17:27:34.841] Server {0x804006400} DEBUG:  (loadSocksConfiguration)> (Socks) Socks Config File: 
> /usr/local/etc/trafficserver/socks.config
> [Dec 21 17:27:34.842] Server {0x804006400} DEBUG:  (loadSocksConfiguration)> (Socks) Socks Turned on
> [Dec 21 17:27:35.052] Server {0x804008000} DEBUG:  (connect_re_internal)> (Socks) Using Socks ip: 216.58.192.142:80
> Assertion failed: (ats_is_ip4(_addr)), function init, file Socks.cc, 
> line 67.
> traffic_server: using root directory '/usr/local'
> traffic_server: Abort trap
> traffic_server - STACK TRACE:
> 0x4b07a9 <_Z19crash_logger_invokeiP9__siginfoPv+0x69> at 
> /usr/local/bin/traffic_server
> 0x80275ab37  at /lib/libthr.so.3
> 0x80275a22c  at /lib/libthr.so.3
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Work logged] (TS-5022) Multiple Client Certificate to Origin

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-5022?focusedWorklogId=34963=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-34963
 ]

ASF GitHub Bot logged work on TS-5022:
--

Author: ASF GitHub Bot
Created on: 08/Jan/17 03:06
Start Date: 08/Jan/17 03:06
Worklog Time Spent: 10m 
  Work Description: Github user zwoop closed the issue at:

https://github.com/apache/trafficserver/issues/1305


Issue Time Tracking
---

Worklog Id: (was: 34963)
Time Spent: 5h 40m  (was: 5.5h)

> Multiple Client Certificate to Origin
> -
>
> Key: TS-5022
> URL: https://issues.apache.org/jira/browse/TS-5022
> Project: Traffic Server
>  Issue Type: Improvement
>  Components: Security, SSL, TLS
>Reporter: Scott Beardsley
>Assignee: Syeda Persia Aziz
>  Labels: yahoo
> Fix For: 7.1.0
>
>  Time Spent: 5h 40m
>  Remaining Estimate: 0h
>
> Yahoo has a use case where the origin is doing mutual TLS authentication 
> which requires ATS to send a client certificate. This works fine (for now) 
> because ATS supports configuring *one* client cert but this feature should 
> really allow multiple client certificates to be configured which would depend 
> upon the origin being contacted.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Work logged] (TS-5092) ATS handling of too many concurrent streams too agressive and maybe out of spec

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-5092?focusedWorklogId=34962=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-34962
 ]

ASF GitHub Bot logged work on TS-5092:
--

Author: ASF GitHub Bot
Created on: 08/Jan/17 02:56
Start Date: 08/Jan/17 02:56
Worklog Time Spent: 10m 
  Work Description: GitHub user zwoop opened an issue:

https://github.com/apache/trafficserver/issues/1308

CID 1368316 & 1368315: Leaks and NULL references

I think this landed recently (TS-5092?), and we have to fix this for 7.1.x. 
clang-analyzer also detects the NULL pointer reference.

```C
** CID 1368316:  Resource leaks  (RESOURCE_LEAK)
/proxy/http/HttpSM.cc: 5049 in HttpSM::do_http_server_open(bool)()




*** CID 1368316:  Resource leaks  (RESOURCE_LEAK)
/proxy/http/HttpSM.cc: 5049 in HttpSM::do_http_server_open(bool)()
5043 int len  = 0;
5044 const char *host = 
t_state.hdr_info.server_request.host_get();
5045 if (host && len > 0) {
5046   opt.set_sni_servername(host, len);
5047 }
5048 
   CID 1368316:  Resource leaks  (RESOURCE_LEAK)
   Failing to save or free storage allocated by 
"Layout::relative_to(this->t_state.txn_conf->client_cert_filepath, 
this->t_state.txn_conf->client_cert_filename)" leaks it.
5049 ats_scoped_str clientCert(
5050   
ats_strdup((Layout::relative_to(t_state.txn_conf->client_cert_filepath, 
t_state.txn_conf->client_cert_filename;
5051 opt.set_client_certname(clientCert);
5052 connect_action_handle = sslNetProcessor.connect_re(this,   
  // state machine
5053
_state.current.server->dst_addr.sa, // addr + port
5054);

** CID 1368315:  Null pointer dereferences  (FORWARD_NULL)
/proxy/http2/Http2ConnectionState.cc: 217 in 
rcv_headers_frame(Http2ConnectionState &, const Http2Frame &)()




*** CID 1368315:  Null pointer dereferences  (FORWARD_NULL)
/proxy/http2/Http2ConnectionState.cc: 217 in 
rcv_headers_frame(Http2ConnectionState &, const Http2Frame &)()
211 if (!stream) {
212   return error;
213 }
214   }
215 
216   // keep track of how many bytes we get in the frame
   CID 1368315:  Null pointer dereferences  (FORWARD_NULL)
   Dereferencing null pointer "stream".
217   stream->request_header_length += payload_length;
218   if (stream->request_header_length > 
Http2::max_request_header_size) {
219 return Http2Error(HTTP2_ERROR_CLASS_STREAM, 
HTTP2_ERROR_PROTOCOL_ERROR,
220   "recv headers payload for headers greater 
than header length");
221   }
222 
```






Issue Time Tracking
---

Worklog Id: (was: 34962)
Time Spent: 1.5h  (was: 1h 20m)

> ATS handling of too many concurrent streams too agressive and maybe out of 
> spec
> ---
>
> Key: TS-5092
> URL: https://issues.apache.org/jira/browse/TS-5092
> Project: Traffic Server
>  Issue Type: Bug
>  Components: HTTP/2
>Reporter: Susan Hinrichs
>Assignee: Susan Hinrichs
> Fix For: 7.1.0
>
>  Time Spent: 1.5h
>  Remaining Estimate: 0h
>
> This issue was identified while debugging new errors seen by an internal team 
> after they enabled HTTP/2 in their client. On the backend, they saw an 
> increase in the cases were ATS sends the origin the POST header but no POST 
> body and then closes the connection.
> With the addition of Error() messages we were able to see a case where the 
> client is trying to open the 101'st stream on a session. This is beyond the 
> 100 max concurrent stream limit, so ATS shuts down the session which kills 
> the previous 100 streams.
> A closer reading of section 5.1.2 of the spec 
> (https://tools.ietf.org/html/rfc7540#section-5.1.2) indicates that this 
> should be a stream error and not a connection error. Bryan Call, Masaori, and 
> Maskit confirmed this interpretation. Maskit also noted that the other error 
> case in the current createStream method must be treated as a connection error.
> Presumably the client library is expecting the refused stream case so it can 
> try again later.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Work logged] (TS-5107) ATS 7.0.0 doesn't build against python docutils 0.13.1

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-5107?focusedWorklogId=34961=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-34961
 ]

ASF GitHub Bot logged work on TS-5107:
--

Author: ASF GitHub Bot
Created on: 08/Jan/17 02:52
Start Date: 08/Jan/17 02:52
Worklog Time Spent: 10m 
  Work Description: Github user zwoop commented on the issue:

https://github.com/apache/trafficserver/pull/1303
  
We need into 7.1.x as well, right?


Issue Time Tracking
---

Worklog Id: (was: 34961)
Time Spent: 2h 10m  (was: 2h)

> ATS 7.0.0 doesn't build against python docutils 0.13.1
> --
>
> Key: TS-5107
> URL: https://issues.apache.org/jira/browse/TS-5107
> Project: Traffic Server
>  Issue Type: Bug
>  Components: Documentation
>Reporter: Jean Baptiste Favre
>Assignee: Jean Baptiste Favre
> Fix For: 7.0.1
>
>  Time Spent: 2h 10m
>  Remaining Estimate: 0h
>
> Trying to build ATS 7.0.0 with python docutils 0.13.1 on Debian fails
> with following error:
> {code}Making all in doc
> make[2]: Entering directory '/home/debocker/source/build/doc'
> PAPEROPT_a4="-D latex_paper_size=a4" PAPEROPT_letter="-D
> latex_paper_size=letter" PAPER="letter" ./sbuild sphinx-build -c .  -d
> docbuild/doctrees -b man . docbuild/man
> Running Sphinx v1.4.9
> making output directory...
> WARNING: sphinx.ext.pngmath has been deprecated. Please use
> sphinx.ext.imgmath instead.
> loading pickled environment... not yet created
> building [mo]: targets for 0 po files that are out of date
> building [man]: all manpages
> updating environment: 456 added, 0 changed, 0 removed
> reading sources... [  0%] admin-guide/configuration/cache-basics.en
> Exception occurred:
>   File "conf.py", line 185, in __init__
> start_string_prefix=self.start_string_prefix,
> AttributeError: Inliner instance has no attribute 'start_string_prefix'
> The full traceback has been saved in /tmp/sphinx-err-5iq_t9.log, if you
> want to report the issue to the developers.
> Please also report this if it was a user error, so that a better error
> message can be provided next time.
> A bug report can be filed in the tracker at
> . Thanks!
> Makefile:998: recipe for target 'man' failed
> make[2]: Leaving directory '/home/debocker/source/build/doc'
> make[2]: *** [man] Error 1
> make[1]: *** [all-recursive] Error 1{code}
> I tracked it down to 
> [docutils/parsers/rst/states.py|https://fossies.org/diffs/docutils/0.12_vs_0.13.1/docutils/parsers/rst/states.py-diff.html]
>  which changed
> between 0.12 & 0.13.1
> {{start_string_prefix}} is not defined anymore at {{Inliner}} init. We have to
> call {{init_cutomizations}} method, but I can't figure out the {{settings}}
> structure.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Work logged] (TS-5105) Assert on Socks.cc line 67, due to remote_addr not set in connect_re_internal

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-5105?focusedWorklogId=34936=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-34936
 ]

ASF GitHub Bot logged work on TS-5105:
--

Author: ASF GitHub Bot
Created on: 07/Jan/17 07:36
Start Date: 07/Jan/17 07:36
Worklog Time Spent: 10m 
  Work Description: Github user oknet commented on the issue:

https://github.com/apache/trafficserver/pull/1276
  
@zwoop the build failed on regression test and I think it is not caused by 
this patch. could you please check the build log for details ?


Issue Time Tracking
---

Worklog Id: (was: 34936)
Time Spent: 1.5h  (was: 1h 20m)

> Assert on Socks.cc line 67, due to remote_addr not set in connect_re_internal
> -
>
> Key: TS-5105
> URL: https://issues.apache.org/jira/browse/TS-5105
> Project: Traffic Server
>  Issue Type: Bug
>  Components: SOCKS
>Reporter: Oknet Xu
>Assignee: Oknet Xu
> Fix For: 7.0.0
>
>  Time Spent: 1.5h
>  Remaining Estimate: 0h
>
> {code}
> traffic_server: using root directory '/usr/local'
> traffic_server: Abort trap
> traffic_server - STACK TRACE:
> 0x4b07a9 <_Z19crash_logger_invokeiP9__siginfoPv+0x69> at 
> /usr/local/bin/traffic_server
> 0x80275ab37  at /lib/libthr.so.3
> 0x80275a22c  at /lib/libthr.so.3
> [Dec 21 17:27:34.840] Server {0x804006400} DEBUG:  (loadSocksConfiguration)> (Socks) Socks Version 4
> [Dec 21 17:27:34.840] Server {0x804006400} DEBUG:  (loadSocksConfiguration)> (Socks) server connect timeout: 10 socks respnonse 
> timeout 100
> [Dec 21 17:27:34.840] Server {0x804006400} DEBUG:  (loadSocksConfiguration)> (SocksProxy) Read SocksProxy info: accept_enabled = 
> 0 accept_port = 1080 http_port = 80
> [Dec 21 17:27:34.841] Server {0x804006400} DEBUG:  (loadSocksConfiguration)> (Socks) Socks Config File: 
> /usr/local/etc/trafficserver/socks.config
> [Dec 21 17:27:34.842] Server {0x804006400} DEBUG:  (loadSocksConfiguration)> (Socks) Socks Turned on
> [Dec 21 17:27:35.052] Server {0x804008000} DEBUG:  (connect_re_internal)> (Socks) Using Socks ip: 216.58.192.142:80
> Assertion failed: (ats_is_ip4(_addr)), function init, file Socks.cc, 
> line 67.
> traffic_server: using root directory '/usr/local'
> traffic_server: Abort trap
> traffic_server - STACK TRACE:
> 0x4b07a9 <_Z19crash_logger_invokeiP9__siginfoPv+0x69> at 
> /usr/local/bin/traffic_server
> 0x80275ab37  at /lib/libthr.so.3
> 0x80275a22c  at /lib/libthr.so.3
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Work logged] (TS-5107) ATS 7.0.0 doesn't build against python docutils 0.13.1

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-5107?focusedWorklogId=34931=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-34931
 ]

ASF GitHub Bot logged work on TS-5107:
--

Author: ASF GitHub Bot
Created on: 06/Jan/17 21:19
Start Date: 06/Jan/17 21:19
Worklog Time Spent: 10m 
  Work Description: Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1303
  
Linux build *successful*! See 
https://ci.trafficserver.apache.org/job/Github-Linux/1203/ for details.
 



Issue Time Tracking
---

Worklog Id: (was: 34931)
Time Spent: 2h  (was: 1h 50m)

> ATS 7.0.0 doesn't build against python docutils 0.13.1
> --
>
> Key: TS-5107
> URL: https://issues.apache.org/jira/browse/TS-5107
> Project: Traffic Server
>  Issue Type: Bug
>  Components: Documentation
>Reporter: Jean Baptiste Favre
>Assignee: Jean Baptiste Favre
> Fix For: 7.0.1
>
>  Time Spent: 2h
>  Remaining Estimate: 0h
>
> Trying to build ATS 7.0.0 with python docutils 0.13.1 on Debian fails
> with following error:
> {code}Making all in doc
> make[2]: Entering directory '/home/debocker/source/build/doc'
> PAPEROPT_a4="-D latex_paper_size=a4" PAPEROPT_letter="-D
> latex_paper_size=letter" PAPER="letter" ./sbuild sphinx-build -c .  -d
> docbuild/doctrees -b man . docbuild/man
> Running Sphinx v1.4.9
> making output directory...
> WARNING: sphinx.ext.pngmath has been deprecated. Please use
> sphinx.ext.imgmath instead.
> loading pickled environment... not yet created
> building [mo]: targets for 0 po files that are out of date
> building [man]: all manpages
> updating environment: 456 added, 0 changed, 0 removed
> reading sources... [  0%] admin-guide/configuration/cache-basics.en
> Exception occurred:
>   File "conf.py", line 185, in __init__
> start_string_prefix=self.start_string_prefix,
> AttributeError: Inliner instance has no attribute 'start_string_prefix'
> The full traceback has been saved in /tmp/sphinx-err-5iq_t9.log, if you
> want to report the issue to the developers.
> Please also report this if it was a user error, so that a better error
> message can be provided next time.
> A bug report can be filed in the tracker at
> . Thanks!
> Makefile:998: recipe for target 'man' failed
> make[2]: Leaving directory '/home/debocker/source/build/doc'
> make[2]: *** [man] Error 1
> make[1]: *** [all-recursive] Error 1{code}
> I tracked it down to 
> [docutils/parsers/rst/states.py|https://fossies.org/diffs/docutils/0.12_vs_0.13.1/docutils/parsers/rst/states.py-diff.html]
>  which changed
> between 0.12 & 0.13.1
> {{start_string_prefix}} is not defined anymore at {{Inliner}} init. We have to
> call {{init_cutomizations}} method, but I can't figure out the {{settings}}
> structure.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Work logged] (TS-5107) ATS 7.0.0 doesn't build against python docutils 0.13.1

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-5107?focusedWorklogId=34930=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-34930
 ]

ASF GitHub Bot logged work on TS-5107:
--

Author: ASF GitHub Bot
Created on: 06/Jan/17 21:15
Start Date: 06/Jan/17 21:15
Worklog Time Spent: 10m 
  Work Description: Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1303
  
FreeBSD build *successful*! See 
https://ci.trafficserver.apache.org/job/Github-FreeBSD/1309/ for details.
 



Issue Time Tracking
---

Worklog Id: (was: 34930)
Time Spent: 1h 50m  (was: 1h 40m)

> ATS 7.0.0 doesn't build against python docutils 0.13.1
> --
>
> Key: TS-5107
> URL: https://issues.apache.org/jira/browse/TS-5107
> Project: Traffic Server
>  Issue Type: Bug
>  Components: Documentation
>Reporter: Jean Baptiste Favre
>Assignee: Jean Baptiste Favre
> Fix For: 7.0.1
>
>  Time Spent: 1h 50m
>  Remaining Estimate: 0h
>
> Trying to build ATS 7.0.0 with python docutils 0.13.1 on Debian fails
> with following error:
> {code}Making all in doc
> make[2]: Entering directory '/home/debocker/source/build/doc'
> PAPEROPT_a4="-D latex_paper_size=a4" PAPEROPT_letter="-D
> latex_paper_size=letter" PAPER="letter" ./sbuild sphinx-build -c .  -d
> docbuild/doctrees -b man . docbuild/man
> Running Sphinx v1.4.9
> making output directory...
> WARNING: sphinx.ext.pngmath has been deprecated. Please use
> sphinx.ext.imgmath instead.
> loading pickled environment... not yet created
> building [mo]: targets for 0 po files that are out of date
> building [man]: all manpages
> updating environment: 456 added, 0 changed, 0 removed
> reading sources... [  0%] admin-guide/configuration/cache-basics.en
> Exception occurred:
>   File "conf.py", line 185, in __init__
> start_string_prefix=self.start_string_prefix,
> AttributeError: Inliner instance has no attribute 'start_string_prefix'
> The full traceback has been saved in /tmp/sphinx-err-5iq_t9.log, if you
> want to report the issue to the developers.
> Please also report this if it was a user error, so that a better error
> message can be provided next time.
> A bug report can be filed in the tracker at
> . Thanks!
> Makefile:998: recipe for target 'man' failed
> make[2]: Leaving directory '/home/debocker/source/build/doc'
> make[2]: *** [man] Error 1
> make[1]: *** [all-recursive] Error 1{code}
> I tracked it down to 
> [docutils/parsers/rst/states.py|https://fossies.org/diffs/docutils/0.12_vs_0.13.1/docutils/parsers/rst/states.py-diff.html]
>  which changed
> between 0.12 & 0.13.1
> {{start_string_prefix}} is not defined anymore at {{Inliner}} init. We have to
> call {{init_cutomizations}} method, but I can't figure out the {{settings}}
> structure.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Work logged] (TS-5107) ATS 7.0.0 doesn't build against python docutils 0.13.1

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-5107?focusedWorklogId=34929=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-34929
 ]

ASF GitHub Bot logged work on TS-5107:
--

Author: ASF GitHub Bot
Created on: 06/Jan/17 21:02
Start Date: 06/Jan/17 21:02
Worklog Time Spent: 10m 
  Work Description: GitHub user jablko opened a pull request:

https://github.com/apache/trafficserver/pull/1303

TS-5107: Changes to autolinking in Docutils 1.3

Restore the autolinking code and update it for Docutils 1.3, which added 
the init_customizations() method. It works with Docutils 1.2 and 1.3 now.

@jbfavre already fixed this in #1296, thanks! I realize it would've been 
much better if I'd had this ready at the beginning of the week ...

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/jablko/trafficserver docutils

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/trafficserver/pull/1303.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1303


commit 8ee31f9bdfa8969c685b0ca11fb6306ba5068811
Author: Jack Bates 
Date:   2017-01-06T19:49:30Z

Revert "Fix nested role (not supported)"

This reverts commit 9e374946a6700bf9766d011dadbc05891d92f058.

commit d3c244f43f68c02d2b652f91b418d3dccaa3a511
Author: Jack Bates 
Date:   2017-01-06T19:49:42Z

Revert "Fix documentation build for docutils 0.13.1 (2/2)"

This reverts commit f3e37f8e104a74700b35816e50f32f95ee436741.

commit 6f1b0cbc235dd8d7e92d1e0d868ed55a76237a27
Author: Jack Bates 
Date:   2017-01-06T19:49:46Z

Revert "Fix documentation build for docutils 0.13.1 (1/2)"

This reverts commit ac0db847e841d50fd38920234166a45762b00398.

commit 8a6fa8392d42caf5588df523f370debffcd7537b
Author: Jack Bates 
Date:   2017-01-06T19:55:44Z

TS-5107: Changes to autolinking in Docutils 1.3

init_customizations() was added in Docutils 1.3.




Issue Time Tracking
---

Worklog Id: (was: 34929)
Time Spent: 1h 40m  (was: 1.5h)

> ATS 7.0.0 doesn't build against python docutils 0.13.1
> --
>
> Key: TS-5107
> URL: https://issues.apache.org/jira/browse/TS-5107
> Project: Traffic Server
>  Issue Type: Bug
>  Components: Documentation
>Reporter: Jean Baptiste Favre
>Assignee: Jean Baptiste Favre
> Fix For: 7.0.1
>
>  Time Spent: 1h 40m
>  Remaining Estimate: 0h
>
> Trying to build ATS 7.0.0 with python docutils 0.13.1 on Debian fails
> with following error:
> {code}Making all in doc
> make[2]: Entering directory '/home/debocker/source/build/doc'
> PAPEROPT_a4="-D latex_paper_size=a4" PAPEROPT_letter="-D
> latex_paper_size=letter" PAPER="letter" ./sbuild sphinx-build -c .  -d
> docbuild/doctrees -b man . docbuild/man
> Running Sphinx v1.4.9
> making output directory...
> WARNING: sphinx.ext.pngmath has been deprecated. Please use
> sphinx.ext.imgmath instead.
> loading pickled environment... not yet created
> building [mo]: targets for 0 po files that are out of date
> building [man]: all manpages
> updating environment: 456 added, 0 changed, 0 removed
> reading sources... [  0%] admin-guide/configuration/cache-basics.en
> Exception occurred:
>   File "conf.py", line 185, in __init__
> start_string_prefix=self.start_string_prefix,
> AttributeError: Inliner instance has no attribute 'start_string_prefix'
> The full traceback has been saved in /tmp/sphinx-err-5iq_t9.log, if you
> want to report the issue to the developers.
> Please also report this if it was a user error, so that a better error
> message can be provided next time.
> A bug report can be filed in the tracker at
> . Thanks!
> Makefile:998: recipe for target 'man' failed
> make[2]: Leaving directory '/home/debocker/source/build/doc'
> make[2]: *** [man] Error 1
> make[1]: *** [all-recursive] Error 1{code}
> I tracked it down to 
> [docutils/parsers/rst/states.py|https://fossies.org/diffs/docutils/0.12_vs_0.13.1/docutils/parsers/rst/states.py-diff.html]
>  which changed
> between 0.12 & 0.13.1
> {{start_string_prefix}} is not defined anymore at {{Inliner}} init. We have to
> call {{init_cutomizations}} method, but I can't figure out the {{settings}}
> structure.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Work logged] (TS-5056) Implement nonrecoverable error mechanism

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-5056?focusedWorklogId=34923=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-34923
 ]

ASF GitHub Bot logged work on TS-5056:
--

Author: ASF GitHub Bot
Created on: 06/Jan/17 17:59
Start Date: 06/Jan/17 17:59
Worklog Time Spent: 10m 
  Work Description: Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1224
  
Linux build *successful*! See 
https://ci.trafficserver.apache.org/job/Github-Linux/1202/ for details.
 



Issue Time Tracking
---

Worklog Id: (was: 34923)
Time Spent: 1h 10m  (was: 1h)

> Implement nonrecoverable error mechanism
> 
>
> Key: TS-5056
> URL: https://issues.apache.org/jira/browse/TS-5056
> Project: Traffic Server
>  Issue Type: Improvement
>  Components: Manager
>Reporter: Daniel Xu
>Assignee: Daniel Xu
> Fix For: 7.1.0
>
>  Time Spent: 1h 10m
>  Remaining Estimate: 0h
>
> There should be a mechanism for {{traffic_server}} to signal to 
> {{traffic_manager}} that {{traffic_server}} cannot be recovered with any 
> amount of restarting. 
> For example, if TS sees a bad log file, then no amount of restarting will fix 
> TS. Thus, it would be better for TM to just sit tight and wait for human 
> intervention. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Work logged] (TS-5056) Implement nonrecoverable error mechanism

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-5056?focusedWorklogId=34922=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-34922
 ]

ASF GitHub Bot logged work on TS-5056:
--

Author: ASF GitHub Bot
Created on: 06/Jan/17 17:58
Start Date: 06/Jan/17 17:58
Worklog Time Spent: 10m 
  Work Description: Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1224
  
FreeBSD build *successful*! See 
https://ci.trafficserver.apache.org/job/Github-FreeBSD/1308/ for details.
 



Issue Time Tracking
---

Worklog Id: (was: 34922)
Time Spent: 1h  (was: 50m)

> Implement nonrecoverable error mechanism
> 
>
> Key: TS-5056
> URL: https://issues.apache.org/jira/browse/TS-5056
> Project: Traffic Server
>  Issue Type: Improvement
>  Components: Manager
>Reporter: Daniel Xu
>Assignee: Daniel Xu
> Fix For: 7.1.0
>
>  Time Spent: 1h
>  Remaining Estimate: 0h
>
> There should be a mechanism for {{traffic_server}} to signal to 
> {{traffic_manager}} that {{traffic_server}} cannot be recovered with any 
> amount of restarting. 
> For example, if TS sees a bad log file, then no amount of restarting will fix 
> TS. Thus, it would be better for TM to just sit tight and wait for human 
> intervention. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Work logged] (TS-5056) Implement nonrecoverable error mechanism

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-5056?focusedWorklogId=34921=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-34921
 ]

ASF GitHub Bot logged work on TS-5056:
--

Author: ASF GitHub Bot
Created on: 06/Jan/17 17:56
Start Date: 06/Jan/17 17:56
Worklog Time Spent: 10m 
  Work Description: Github user SolidWallOfCode closed the pull request at:

https://github.com/apache/trafficserver/pull/1224


Issue Time Tracking
---

Worklog Id: (was: 34921)
Time Spent: 50m  (was: 40m)

> Implement nonrecoverable error mechanism
> 
>
> Key: TS-5056
> URL: https://issues.apache.org/jira/browse/TS-5056
> Project: Traffic Server
>  Issue Type: Improvement
>  Components: Manager
>Reporter: Daniel Xu
>Assignee: Daniel Xu
> Fix For: 7.1.0
>
>  Time Spent: 50m
>  Remaining Estimate: 0h
>
> There should be a mechanism for {{traffic_server}} to signal to 
> {{traffic_manager}} that {{traffic_server}} cannot be recovered with any 
> amount of restarting. 
> For example, if TS sees a bad log file, then no amount of restarting will fix 
> TS. Thus, it would be better for TM to just sit tight and wait for human 
> intervention. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Work logged] (TS-5056) Implement nonrecoverable error mechanism

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-5056?focusedWorklogId=34919=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-34919
 ]

ASF GitHub Bot logged work on TS-5056:
--

Author: ASF GitHub Bot
Created on: 06/Jan/17 17:44
Start Date: 06/Jan/17 17:44
Worklog Time Spent: 10m 
  Work Description: Github user shinrich commented on the issue:

https://github.com/apache/trafficserver/pull/1224
  
[approve ci]


Issue Time Tracking
---

Worklog Id: (was: 34919)
Time Spent: 40m  (was: 0.5h)

> Implement nonrecoverable error mechanism
> 
>
> Key: TS-5056
> URL: https://issues.apache.org/jira/browse/TS-5056
> Project: Traffic Server
>  Issue Type: Improvement
>  Components: Manager
>Reporter: Daniel Xu
>Assignee: Daniel Xu
> Fix For: 7.1.0
>
>  Time Spent: 40m
>  Remaining Estimate: 0h
>
> There should be a mechanism for {{traffic_server}} to signal to 
> {{traffic_manager}} that {{traffic_server}} cannot be recovered with any 
> amount of restarting. 
> For example, if TS sees a bad log file, then no amount of restarting will fix 
> TS. Thus, it would be better for TM to just sit tight and wait for human 
> intervention. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Work logged] (TS-5022) Multiple Client Certificate to Origin

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-5022?focusedWorklogId=34909=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-34909
 ]

ASF GitHub Bot logged work on TS-5022:
--

Author: ASF GitHub Bot
Created on: 06/Jan/17 16:52
Start Date: 06/Jan/17 16:52
Worklog Time Spent: 10m 
  Work Description: Github user shinrich closed the pull request at:

https://github.com/apache/trafficserver/pull/1226


Issue Time Tracking
---

Worklog Id: (was: 34909)
Time Spent: 5.5h  (was: 5h 20m)

> Multiple Client Certificate to Origin
> -
>
> Key: TS-5022
> URL: https://issues.apache.org/jira/browse/TS-5022
> Project: Traffic Server
>  Issue Type: Improvement
>  Components: Security, SSL, TLS
>Reporter: Scott Beardsley
>Assignee: Syeda Persia Aziz
>  Labels: yahoo
> Fix For: 7.1.0
>
>  Time Spent: 5.5h
>  Remaining Estimate: 0h
>
> Yahoo has a use case where the origin is doing mutual TLS authentication 
> which requires ATS to send a client certificate. This works fine (for now) 
> because ATS supports configuring *one* client cert but this feature should 
> really allow multiple client certificates to be configured which would depend 
> upon the origin being contacted.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Work logged] (TS-5022) Multiple Client Certificate to Origin

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-5022?focusedWorklogId=34908=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-34908
 ]

ASF GitHub Bot logged work on TS-5022:
--

Author: ASF GitHub Bot
Created on: 06/Jan/17 16:52
Start Date: 06/Jan/17 16:52
Worklog Time Spent: 10m 
  Work Description: Github user shinrich commented on the issue:

https://github.com/apache/trafficserver/pull/1226
  
Looks Good!


Issue Time Tracking
---

Worklog Id: (was: 34908)
Time Spent: 5h 20m  (was: 5h 10m)

> Multiple Client Certificate to Origin
> -
>
> Key: TS-5022
> URL: https://issues.apache.org/jira/browse/TS-5022
> Project: Traffic Server
>  Issue Type: Improvement
>  Components: Security, SSL, TLS
>Reporter: Scott Beardsley
>Assignee: Syeda Persia Aziz
>  Labels: yahoo
> Fix For: 7.1.0
>
>  Time Spent: 5h 20m
>  Remaining Estimate: 0h
>
> Yahoo has a use case where the origin is doing mutual TLS authentication 
> which requires ATS to send a client certificate. This works fine (for now) 
> because ATS supports configuring *one* client cert but this feature should 
> really allow multiple client certificates to be configured which would depend 
> upon the origin being contacted.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Work logged] (TS-5092) ATS handling of too many concurrent streams too agressive and maybe out of spec

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-5092?focusedWorklogId=34907=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-34907
 ]

ASF GitHub Bot logged work on TS-5092:
--

Author: ASF GitHub Bot
Created on: 06/Jan/17 16:49
Start Date: 06/Jan/17 16:49
Worklog Time Spent: 10m 
  Work Description: Github user shinrich closed the pull request at:

https://github.com/apache/trafficserver/pull/1262


Issue Time Tracking
---

Worklog Id: (was: 34907)
Time Spent: 1h 20m  (was: 1h 10m)

> ATS handling of too many concurrent streams too agressive and maybe out of 
> spec
> ---
>
> Key: TS-5092
> URL: https://issues.apache.org/jira/browse/TS-5092
> Project: Traffic Server
>  Issue Type: Bug
>  Components: HTTP/2
>Reporter: Susan Hinrichs
>Assignee: Susan Hinrichs
> Fix For: 7.1.0
>
>  Time Spent: 1h 20m
>  Remaining Estimate: 0h
>
> This issue was identified while debugging new errors seen by an internal team 
> after they enabled HTTP/2 in their client. On the backend, they saw an 
> increase in the cases were ATS sends the origin the POST header but no POST 
> body and then closes the connection.
> With the addition of Error() messages we were able to see a case where the 
> client is trying to open the 101'st stream on a session. This is beyond the 
> 100 max concurrent stream limit, so ATS shuts down the session which kills 
> the previous 100 streams.
> A closer reading of section 5.1.2 of the spec 
> (https://tools.ietf.org/html/rfc7540#section-5.1.2) indicates that this 
> should be a stream error and not a connection error. Bryan Call, Masaori, and 
> Maskit confirmed this interpretation. Maskit also noted that the other error 
> case in the current createStream method must be treated as a connection error.
> Presumably the client library is expecting the refused stream case so it can 
> try again later.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Work logged] (TS-5103) Always tunnel non-keepalive HTTP request if tr-pass enabled

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-5103?focusedWorklogId=34905=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-34905
 ]

ASF GitHub Bot logged work on TS-5103:
--

Author: ASF GitHub Bot
Created on: 06/Jan/17 16:34
Start Date: 06/Jan/17 16:34
Worklog Time Spent: 10m 
  Work Description: Github user shinrich closed the pull request at:

https://github.com/apache/trafficserver/pull/1271


Issue Time Tracking
---

Worklog Id: (was: 34905)
Time Spent: 50m  (was: 40m)

> Always tunnel non-keepalive HTTP request if tr-pass enabled
> ---
>
> Key: TS-5103
> URL: https://issues.apache.org/jira/browse/TS-5103
> Project: Traffic Server
>  Issue Type: Bug
>  Components: HTTP
>Reporter: Oknet Xu
>  Time Spent: 50m
>  Remaining Estimate: 0h
>
> Should use ua_buffer_reader instead of ua_raw_buffer_reader.
> {code}
>   // If we had a GET request that has data after the
>   // get request, do blind tunnel
> } else if (state == PARSE_DONE && 
> t_state.hdr_info.client_request.method_get_wksidx() == HTTP_WKSIDX_GET &&
>ua_raw_buffer_reader->read_avail() > 0 && 
> !t_state.hdr_info.client_request.is_keep_alive_set()) {
>   do_blind_tunnel = true;
> }
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Work logged] (TS-5022) Multiple Client Certificate to Origin

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-5022?focusedWorklogId=34837=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-34837
 ]

ASF GitHub Bot logged work on TS-5022:
--

Author: ASF GitHub Bot
Created on: 05/Jan/17 21:49
Start Date: 05/Jan/17 21:49
Worklog Time Spent: 10m 
  Work Description: Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1226
  
Linux build *successful*! See 
https://ci.trafficserver.apache.org/job/Github-Linux/1201/ for details.
 



Issue Time Tracking
---

Worklog Id: (was: 34837)
Time Spent: 5h 10m  (was: 5h)

> Multiple Client Certificate to Origin
> -
>
> Key: TS-5022
> URL: https://issues.apache.org/jira/browse/TS-5022
> Project: Traffic Server
>  Issue Type: Improvement
>  Components: Security, SSL, TLS
>Reporter: Scott Beardsley
>Assignee: Syeda Persia Aziz
>  Labels: yahoo
> Fix For: 7.1.0
>
>  Time Spent: 5h 10m
>  Remaining Estimate: 0h
>
> Yahoo has a use case where the origin is doing mutual TLS authentication 
> which requires ATS to send a client certificate. This works fine (for now) 
> because ATS supports configuring *one* client cert but this feature should 
> really allow multiple client certificates to be configured which would depend 
> upon the origin being contacted.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Work logged] (TS-5022) Multiple Client Certificate to Origin

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-5022?focusedWorklogId=34836=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-34836
 ]

ASF GitHub Bot logged work on TS-5022:
--

Author: ASF GitHub Bot
Created on: 05/Jan/17 21:45
Start Date: 05/Jan/17 21:45
Worklog Time Spent: 10m 
  Work Description: Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1226
  
FreeBSD build *successful*! See 
https://ci.trafficserver.apache.org/job/Github-FreeBSD/1307/ for details.
 



Issue Time Tracking
---

Worklog Id: (was: 34836)
Time Spent: 5h  (was: 4h 50m)

> Multiple Client Certificate to Origin
> -
>
> Key: TS-5022
> URL: https://issues.apache.org/jira/browse/TS-5022
> Project: Traffic Server
>  Issue Type: Improvement
>  Components: Security, SSL, TLS
>Reporter: Scott Beardsley
>Assignee: Syeda Persia Aziz
>  Labels: yahoo
> Fix For: 7.1.0
>
>  Time Spent: 5h
>  Remaining Estimate: 0h
>
> Yahoo has a use case where the origin is doing mutual TLS authentication 
> which requires ATS to send a client certificate. This works fine (for now) 
> because ATS supports configuring *one* client cert but this feature should 
> really allow multiple client certificates to be configured which would depend 
> upon the origin being contacted.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Work logged] (TS-4664) Crash due to separate event handlers for IO events and plugin events for ClientSession

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-4664?focusedWorklogId=34835=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-34835
 ]

ASF GitHub Bot logged work on TS-4664:
--

Author: ASF GitHub Bot
Created on: 05/Jan/17 21:37
Start Date: 05/Jan/17 21:37
Worklog Time Spent: 10m 
  Work Description: Github user shinrich commented on the issue:

https://github.com/apache/trafficserver/pull/801
  
I'm actually holding off on this one.  We are running our version of 5.3.x 
with this change, but there were a number of other changes as well.  Not clear 
this one is needed.  I plan to do stress testing of 7.x this month.  I'll pull 
this logic forward if it is needed (or at least understand the issue better).


Issue Time Tracking
---

Worklog Id: (was: 34835)
Time Spent: 2.5h  (was: 2h 20m)

> Crash due to separate event handlers for IO events and plugin events for 
> ClientSession
> --
>
> Key: TS-4664
> URL: https://issues.apache.org/jira/browse/TS-4664
> Project: Traffic Server
>  Issue Type: Bug
>Reporter: Susan Hinrichs
>Assignee: Susan Hinrichs
> Fix For: 7.1.0
>
>  Time Spent: 2.5h
>  Remaining Estimate: 0h
>
> Found while tracking TS-4507 and original fix on that branch.
> Cleaned up handling regular events at the same time as plugin events. The 
> original code relied on the subclasses overriding handle_api_event to handle 
> the regular events, but the handler only handled the TIMEOUT event. Changed 
> that to augment the subclasses' main event handler to call out to 
> state_api_callout in the event of the plugin events.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Work logged] (TS-5084) Make logcat follow file rotation

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-5084?focusedWorklogId=34832=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-34832
 ]

ASF GitHub Bot logged work on TS-5084:
--

Author: ASF GitHub Bot
Created on: 05/Jan/17 21:28
Start Date: 05/Jan/17 21:28
Worklog Time Spent: 10m 
  Work Description: Github user shinrich closed the pull request at:

https://github.com/apache/trafficserver/pull/1253


Issue Time Tracking
---

Worklog Id: (was: 34832)
Time Spent: 1h 40m  (was: 1.5h)

> Make logcat follow file rotation
> 
>
> Key: TS-5084
> URL: https://issues.apache.org/jira/browse/TS-5084
> Project: Traffic Server
>  Issue Type: Improvement
>  Components: Logging
>Reporter: Daniel Xu
>Assignee: Daniel Xu
> Fix For: 7.1.0
>
>  Time Spent: 1h 40m
>  Remaining Estimate: 0h
>
> The {{traffic_logcat}} tool does not follow {{squid.blog}} if it is rotated. 
> This is still occurring even when {{traffic_logcat}} is run with {{-f}} It 
> would be nice if the tool would follow the log.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Work logged] (TS-5053) const char **argv passed to TSPluginInit is not null terminated

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-5053?focusedWorklogId=34834=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-34834
 ]

ASF GitHub Bot logged work on TS-5053:
--

Author: ASF GitHub Bot
Created on: 05/Jan/17 21:33
Start Date: 05/Jan/17 21:33
Worklog Time Spent: 10m 
  Work Description: Github user shinrich closed the pull request at:

https://github.com/apache/trafficserver/pull/1257


Issue Time Tracking
---

Worklog Id: (was: 34834)
Time Spent: 1h 20m  (was: 1h 10m)

> const char **argv passed to TSPluginInit is not null terminated
> ---
>
> Key: TS-5053
> URL: https://issues.apache.org/jira/browse/TS-5053
> Project: Traffic Server
>  Issue Type: Bug
>  Components: Plugins
>Reporter: Daniel Xu
>Assignee: Daniel Xu
> Fix For: 7.1.0
>
>  Time Spent: 1h 20m
>  Remaining Estimate: 0h
>
> See title. Typically **argv is null terminated in other systems. And who are 
> we to question 1000 years of tradition?
> One example of an issue is that {{lib/ts/ink_args.cc}} actually relies on 
> **argv being null terminated. Interesting segfaults occur in plugins usings 
> the ATS argument parser.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Work logged] (TS-5093) Augment and fix crash in slow log

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-5093?focusedWorklogId=34833=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-34833
 ]

ASF GitHub Bot logged work on TS-5093:
--

Author: ASF GitHub Bot
Created on: 05/Jan/17 21:28
Start Date: 05/Jan/17 21:28
Worklog Time Spent: 10m 
  Work Description: Github user shinrich closed the pull request at:

https://github.com/apache/trafficserver/pull/1260


Issue Time Tracking
---

Worklog Id: (was: 34833)
Time Spent: 40m  (was: 0.5h)

> Augment and fix crash in slow log
> -
>
> Key: TS-5093
> URL: https://issues.apache.org/jira/browse/TS-5093
> Project: Traffic Server
>  Issue Type: Bug
>  Components: Core
>Reporter: Susan Hinrichs
>Assignee: Susan Hinrichs
> Fix For: 7.1.0
>
>  Time Spent: 40m
>  Remaining Estimate: 0h
>
> While tracking down a performance problem in HTTP/2, added some values to the 
> slow log entry. Also rearranged the call to avoid a use-after-free crash 
> calling update_stats HttpSM::kill_this().



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Work logged] (TS-5091) Crash if server session from global pool is not alive

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-5091?focusedWorklogId=34831=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-34831
 ]

ASF GitHub Bot logged work on TS-5091:
--

Author: ASF GitHub Bot
Created on: 05/Jan/17 21:26
Start Date: 05/Jan/17 21:26
Worklog Time Spent: 10m 
  Work Description: Github user shinrich closed the pull request at:

https://github.com/apache/trafficserver/pull/1263


Issue Time Tracking
---

Worklog Id: (was: 34831)
Time Spent: 40m  (was: 0.5h)

> Crash if server session from global pool is not alive
> -
>
> Key: TS-5091
> URL: https://issues.apache.org/jira/browse/TS-5091
> Project: Traffic Server
>  Issue Type: Bug
>  Components: Core
>Reporter: Susan Hinrichs
>Assignee: Susan Hinrichs
> Fix For: 7.1.0
>
>  Time Spent: 40m
>  Remaining Estimate: 0h
>
> We have seen the following stack in production.  The problem is the migration 
> fails, but we set the netvc to null before calling do_io_close.  This causes 
> the get_server_ip() call in HttpServerSession::do_io_close to dereference a 
> NULL.
> {code}
> (gdb) bt
> #0  0x2aae5acc2625 in raise () from /lib64/libc.so.6
> #1  0x2aae5acc3d8d in abort () from /lib64/libc.so.6
> #2  0x2aae58062149 in ink_die_die_die () at 
> ../../../../trafficserver/lib/ts/ink_error.cc:43
> #3  0x2aae58062202 in ink_fatal_va(const char *, typedef __va_list_tag 
> __va_list_tag *) (fmt=0x2aae58077b18 "%s:%d: failed assert `%s`", 
> ap=0x2aae62dccd68) at ../../../../trafficserver/lib/ts/ink_error.cc:65
> #4  0x2aae580622a1 in ink_fatal (message_format=0x2aae58077b18 "%s:%d: 
> failed assert `%s`") at ../../../../trafficserver/lib/ts/ink_error.cc:73
> #5  0x2aae5805fa06 in _ink_assert (expression=0x7c2a51 "server_vc != 
> NULL", file=0x7c2a10 
> "../../../../trafficserver/proxy/http/../http/HttpServerSession.h", line=123) 
> at ../../../../trafficserver/lib/ts/ink_assert.cc:37
> #6  0x006038b9 in HttpServerSession::get_server_ip 
> (this=0x2aac08b0efd0) at 
> ../../../../trafficserver/proxy/http/../http/HttpServerSession.h:123
> #7  0x0060801e in HttpServerSession::do_io_close 
> (this=0x2aac08b0efd0, alerrno=-1) at 
> ../../../../trafficserver/proxy/http/HttpServerSession.cc:130
> #8  0x00609b12 in HttpSessionManager::acquire_session (this=0xae1ba0, 
> ip=0x2aac2f2817c8, hostname=0x2aac305e8a19 "sc1.ycpi.vip.bf1.yahoo.com", 
> ua_session=0x2aac104fca70, sm=0x2aac2f2810b0) at 
> ../../../../trafficserver/proxy/http/HttpSessionManager.cc:311
> #9  0x005f7554 in HttpSM::do_http_server_open (this=0x2aac2f2810b0, 
> raw=false) at ../../../../trafficserver/proxy/http/HttpSM.cc:4872
> #10 0x00600357 in HttpSM::set_next_state (this=0x2aac2f2810b0) at 
> ../../../../trafficserver/proxy/http/HttpSM.cc:7385
> #11 0x005ff4ee in HttpSM::call_transact_and_set_next_state 
> (this=0x2aac2f2810b0, f=0) at 
> ../../../../trafficserver/proxy/http/HttpSM.cc:7198
> #12 0x005ef0d5 in HttpSM::state_cache_open_write 
> (this=0x2aac2f2810b0, event=1108, data=0x2aaad0203540) at 
> ../../../../trafficserver/proxy/http/HttpSM.cc:2581
> #13 0x005ef79c in HttpSM::main_handler (this=0x2aac2f2810b0, 
> event=1108, data=0x2aaad0203540) at 
> ../../../../trafficserver/proxy/http/HttpSM.cc:2693
> #14 0x0051381a in Continuation::handleEvent (this=0x2aac2f2810b0, 
> event=1108, data=0x2aaad0203540) at 
> ../../../trafficserver/iocore/eventsystem/I_Continuation.h:150
> #15 0x005d9e38 in HttpCacheSM::state_cache_open_write 
> (this=0x2aac2f282ba0, event=1108, data=0x2aaad0203540) at 
> ../../../../trafficserver/proxy/http/HttpCacheSM.cc:167
> #16 0x0051381a in Continuation::handleEvent (this=0x2aac2f282ba0, 
> event=1108, data=0x2aaad0203540) at 
> ../../../trafficserver/iocore/eventsystem/I_Continuation.h:150
> #17 0x0073c9be in CacheVC::callcont (this=0x2aaad0203540, event=1108) 
> at ../../../../trafficserver/iocore/cache/P_CacheInternal.h:673
> #18 0x00746aca in Cache::open_write (this=0x2aaadc008c90, 
> cont=0x2aac2f282ba0, key=0x2aae62dcd650, info=0x0, apin_in_cache=0, 
> type=CACHE_FRAG_TYPE_HTTP, hostname=0x2aac0cad3405 
> "68.media.tumblr.com9548920493ae47f3954b2a04b9d8763a/tumblr_inline_n1gft6Y4Vj1qjk6k8.jpg",
>  host_len=19) at ../../../../trafficserver/iocore/cache/CacheWrite.cc:1789
> #19 0x00723667 in Cache::open_write (this=0x2aaadc008c90, 
> cont=0x2aac2f282ba0, url=0x2aac2f281158, request=0x2aac2f281828, 
> old_info=0x0, pin_in_cache=0, type=CACHE_FRAG_TYPE_HTTP) at 
> ../../../../trafficserver/iocore/cache/P_CacheInternal.h:1104
> #20 0x007211be in CacheProcessor::open_write (this=0x1059780, 
> cont=0x2aac2f282ba0, 

[jira] [Work logged] (TS-5022) Multiple Client Certificate to Origin

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-5022?focusedWorklogId=34830=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-34830
 ]

ASF GitHub Bot logged work on TS-5022:
--

Author: ASF GitHub Bot
Created on: 05/Jan/17 21:24
Start Date: 05/Jan/17 21:24
Worklog Time Spent: 10m 
  Work Description: Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1226
  
Linux build *successful*! See 
https://ci.trafficserver.apache.org/job/Github-Linux/1200/ for details.
 



Issue Time Tracking
---

Worklog Id: (was: 34830)
Time Spent: 4h 50m  (was: 4h 40m)

> Multiple Client Certificate to Origin
> -
>
> Key: TS-5022
> URL: https://issues.apache.org/jira/browse/TS-5022
> Project: Traffic Server
>  Issue Type: Improvement
>  Components: Security, SSL, TLS
>Reporter: Scott Beardsley
>Assignee: Syeda Persia Aziz
>  Labels: yahoo
> Fix For: 7.1.0
>
>  Time Spent: 4h 50m
>  Remaining Estimate: 0h
>
> Yahoo has a use case where the origin is doing mutual TLS authentication 
> which requires ATS to send a client certificate. This works fine (for now) 
> because ATS supports configuring *one* client cert but this feature should 
> really allow multiple client certificates to be configured which would depend 
> upon the origin being contacted.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Work logged] (TS-5022) Multiple Client Certificate to Origin

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-5022?focusedWorklogId=34829=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-34829
 ]

ASF GitHub Bot logged work on TS-5022:
--

Author: ASF GitHub Bot
Created on: 05/Jan/17 21:22
Start Date: 05/Jan/17 21:22
Worklog Time Spent: 10m 
  Work Description: Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1226
  
FreeBSD build *successful*! See 
https://ci.trafficserver.apache.org/job/Github-FreeBSD/1306/ for details.
 



Issue Time Tracking
---

Worklog Id: (was: 34829)
Time Spent: 4h 40m  (was: 4.5h)

> Multiple Client Certificate to Origin
> -
>
> Key: TS-5022
> URL: https://issues.apache.org/jira/browse/TS-5022
> Project: Traffic Server
>  Issue Type: Improvement
>  Components: Security, SSL, TLS
>Reporter: Scott Beardsley
>Assignee: Syeda Persia Aziz
>  Labels: yahoo
> Fix For: 7.1.0
>
>  Time Spent: 4h 40m
>  Remaining Estimate: 0h
>
> Yahoo has a use case where the origin is doing mutual TLS authentication 
> which requires ATS to send a client certificate. This works fine (for now) 
> because ATS supports configuring *one* client cert but this feature should 
> really allow multiple client certificates to be configured which would depend 
> upon the origin being contacted.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Work logged] (TS-4522) Should signal SM with EVENT_ERROR on error in write_to_net_io(), EVENT_EOS only signaled from read_from_net()

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-4522?focusedWorklogId=34828=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-34828
 ]

ASF GitHub Bot logged work on TS-4522:
--

Author: ASF GitHub Bot
Created on: 05/Jan/17 21:18
Start Date: 05/Jan/17 21:18
Worklog Time Spent: 10m 
  Work Description: Github user asfgit closed the pull request at:

https://github.com/apache/trafficserver/pull/701


Issue Time Tracking
---

Worklog Id: (was: 34828)
Time Spent: 2h 20m  (was: 2h 10m)

> Should signal SM with EVENT_ERROR on error in write_to_net_io(), EVENT_EOS 
> only signaled from read_from_net()
> -
>
> Key: TS-4522
> URL: https://issues.apache.org/jira/browse/TS-4522
> Project: Traffic Server
>  Issue Type: Bug
>  Components: Core, Network
>Reporter: Oknet Xu
>Assignee: Oknet Xu
> Fix For: 7.1.0
>
>  Time Spent: 2h 20m
>  Remaining Estimate: 0h
>
> The 1st Problem:
> The "r" saved return value from write(). The "r == 0" or "!r" is not means 
> EOS. 
> Because of on a closed socket fd: 
> - read(socketfd) return 0
> - write(socketfd) return EPIPE
> In the write_to_net_io, we check the return value of write() with the same 
> way to read().
> {code}
> if (!r || r == -ECONNRESET) {
> {code}
> It is a copy & paste bug.
> The bug makes no VC_EVENT_EOS callbacked while write_to_net_io, but 
> VC_EVENT_ERROR instead. 
> full code here:
> {code}
>   int64_t r = vc->load_buffer_and_write(towrite, buf, total_written, needs);
>   if (total_written > 0) {
> NET_SUM_DYN_STAT(net_write_bytes_stat, total_written);
> s->vio.ndone += total_written;
>   }
>   // check for errors
>   if (r <= 0) { // if the socket was not ready,add to WaitList
> if (r == -EAGAIN || r == -ENOTCONN) {
>   NET_INCREMENT_DYN_STAT(net_calls_to_write_nodata_stat);
>   if ((needs & EVENTIO_WRITE) == EVENTIO_WRITE) {
> vc->write.triggered = 0;
> nh->write_ready_list.remove(vc);
> write_reschedule(nh, vc);
>   }
>   if ((needs & EVENTIO_READ) == EVENTIO_READ) {
> vc->read.triggered = 0;
> nh->read_ready_list.remove(vc);
> read_reschedule(nh, vc);
>   }
>   return;
> }
> if (!r || r == -ECONNRESET) {
>   vc->write.triggered = 0;
>   write_signal_done(VC_EVENT_EOS, nh, vc);
>   return;
> }
> vc->write.triggered = 0;
> write_signal_error(nh, vc, (int)-total_written);
> return;
> {code}
> The 2nd Problem:
> In the iocore/net/I_NetVConnection.h, the comments for do_io_write:
> {code}
> 257   /**
> 258 Initiates write. Thread-safe, may be called when not handling
> 259 an event from the NetVConnection, or the NetVConnection creation
> 260 callback.
> 261 
> 262 Callbacks: non-reentrant, c's lock taken during callbacks.
> 263 
> 264 
> 265   
> 266 c->handleEvent(VC_EVENT_WRITE_READY, vio)
> 267 signifies data has written from the reader or there are no 
> bytes available for the reader to write.
> 268   
> 269   
> 270 c->handleEvent(VC_EVENT_WRITE_COMPLETE, vio)
> 271 signifies the amount of data indicated by nbytes has been 
> read from the buffer
> 272   
> 273   
> 274 c->handleEvent(VC_EVENT_ERROR, vio)
> 275 signified that error occured during write.
> 276   
> 277 
> 278 
> 279 The vio returned during callbacks is the same as the one returned
> 280 by do_io_write(). The vio can be changed only during call backs
> 281 from the vconnection. The vconnection deallocates the reader
> 282 when it is destroyed.
> 283 
> 284 @param c continuation to be called back after (partial) write
> 285 @param nbytes no of bytes to write, if unknown msut be set to 
> INT64_MAX
> 286 @param buf source of data
> 287 @param owner
> 288 @return vio pointer
> 289 
> 290   */
> 291   virtual VIO *do_io_write(Continuation *c, int64_t nbytes, 
> IOBufferReader *buf, bool owner = false) = 0;
> {code}
> Only 3 Events was introduced
> - VC_EVENT_WRITE_READY
> - VC_EVENT_WRITE_COMPLETE
> - VC_EVENT_ERROR
> The code {code}write_signal_done(VC_EVENT_EOS, nh, vc);{code} should not be 
> here (write_to_net_io).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Work logged] (TS-5022) Multiple Client Certificate to Origin

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-5022?focusedWorklogId=34827=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-34827
 ]

ASF GitHub Bot logged work on TS-5022:
--

Author: ASF GitHub Bot
Created on: 05/Jan/17 21:08
Start Date: 05/Jan/17 21:08
Worklog Time Spent: 10m 
  Work Description: Github user persiaAziz commented on the issue:

https://github.com/apache/trafficserver/pull/1226
  
Please review @shinrich. The client context initialization and creation 
parts have been moved to SSLConfig


Issue Time Tracking
---

Worklog Id: (was: 34827)
Time Spent: 4.5h  (was: 4h 20m)

> Multiple Client Certificate to Origin
> -
>
> Key: TS-5022
> URL: https://issues.apache.org/jira/browse/TS-5022
> Project: Traffic Server
>  Issue Type: Improvement
>  Components: Security, SSL, TLS
>Reporter: Scott Beardsley
>Assignee: Syeda Persia Aziz
>  Labels: yahoo
> Fix For: 7.1.0
>
>  Time Spent: 4.5h
>  Remaining Estimate: 0h
>
> Yahoo has a use case where the origin is doing mutual TLS authentication 
> which requires ATS to send a client certificate. This works fine (for now) 
> because ATS supports configuring *one* client cert but this feature should 
> really allow multiple client certificates to be configured which would depend 
> upon the origin being contacted.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Work logged] (TS-4948) CID 1364117 (Forward NULL) in proxy/http/HttpSM.cc

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-4948?focusedWorklogId=34826=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-34826
 ]

ASF GitHub Bot logged work on TS-4948:
--

Author: ASF GitHub Bot
Created on: 05/Jan/17 20:33
Start Date: 05/Jan/17 20:33
Worklog Time Spent: 10m 
  Work Description: Github user shinrich commented on the issue:

https://github.com/apache/trafficserver/pull/1092
  
Looks like someone else fixed this along the way.  Closing.


Issue Time Tracking
---

Worklog Id: (was: 34826)
Time Spent: 1h 20m  (was: 1h 10m)

> CID 1364117 (Forward NULL) in proxy/http/HttpSM.cc
> --
>
> Key: TS-4948
> URL: https://issues.apache.org/jira/browse/TS-4948
> Project: Traffic Server
>  Issue Type: Bug
>  Components: HTTP
>Reporter: Leif Hedstrom
> Fix For: 7.1.0
>
>  Time Spent: 1h 20m
>  Remaining Estimate: 0h
>
> {code}
> *** CID 1364117:(FORWARD_NULL)
> /proxy/http/HttpSM.cc: 2111 in HttpSM::process_hostdb_info(HostDBInfo *)()
> 2105 void
> 2106 HttpSM::process_hostdb_info(HostDBInfo *r)
> 2107 {
> 2108   // Increment the refcount to our item, since we are pointing at it
> 2109   t_state.hostdb_entry = Ptr(r);
> 2110 
>CID 1364117:(FORWARD_NULL)
>Assigning: "client_addr" = "NULL".
> 2111   sockaddr const *client_addr = NULL;
> 2112   bool use_client_addr= 
> t_state.http_config_param->use_client_target_addr == 1 && 
> t_state.client_info.is_transparent &&
> 2113  t_state.dns_info.os_addr_style == 
> HttpTransact::DNSLookupInfo::OS_ADDR_TRY_DEFAULT;
> 2114   if (use_client_addr) {
> 2115 NetVConnection *vc = t_state.state_machine->ua_session ? 
> t_state.state_machine->ua_session->get_netvc() : NULL;
> 2116 if (vc) {
> /proxy/http/HttpSM.cc: 2111 in HttpSM::process_hostdb_info(HostDBInfo *)()
> 2105 void
> 2106 HttpSM::process_hostdb_info(HostDBInfo *r)
> 2107 {
> 2108   // Increment the refcount to our item, since we are pointing at it
> 2109   t_state.hostdb_entry = Ptr(r);
> 2110 
>CID 1364117:(FORWARD_NULL)
>Assigning: "client_addr" = "NULL".
> 2111   sockaddr const *client_addr = NULL;
> 2112   bool use_client_addr= 
> t_state.http_config_param->use_client_target_addr == 1 && 
> t_state.client_info.is_transparent &&
> 2113  t_state.dns_info.os_addr_style == 
> HttpTransact::DNSLookupInfo::OS_ADDR_TRY_DEFAULT;
> 2114   if (use_client_addr) {
> 2115 NetVConnection *vc = t_state.state_machine->ua_session ? 
> t_state.state_machine->ua_session->get_netvc() : NULL;
> 2116 if (vc) {
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Work logged] (TS-4948) CID 1364117 (Forward NULL) in proxy/http/HttpSM.cc

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-4948?focusedWorklogId=34825=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-34825
 ]

ASF GitHub Bot logged work on TS-4948:
--

Author: ASF GitHub Bot
Created on: 05/Jan/17 20:33
Start Date: 05/Jan/17 20:33
Worklog Time Spent: 10m 
  Work Description: Github user shinrich closed the pull request at:

https://github.com/apache/trafficserver/pull/1092


Issue Time Tracking
---

Worklog Id: (was: 34825)
Time Spent: 1h 20m  (was: 1h 10m)

> CID 1364117 (Forward NULL) in proxy/http/HttpSM.cc
> --
>
> Key: TS-4948
> URL: https://issues.apache.org/jira/browse/TS-4948
> Project: Traffic Server
>  Issue Type: Bug
>  Components: HTTP
>Reporter: Leif Hedstrom
> Fix For: 7.1.0
>
>  Time Spent: 1h 20m
>  Remaining Estimate: 0h
>
> {code}
> *** CID 1364117:(FORWARD_NULL)
> /proxy/http/HttpSM.cc: 2111 in HttpSM::process_hostdb_info(HostDBInfo *)()
> 2105 void
> 2106 HttpSM::process_hostdb_info(HostDBInfo *r)
> 2107 {
> 2108   // Increment the refcount to our item, since we are pointing at it
> 2109   t_state.hostdb_entry = Ptr(r);
> 2110 
>CID 1364117:(FORWARD_NULL)
>Assigning: "client_addr" = "NULL".
> 2111   sockaddr const *client_addr = NULL;
> 2112   bool use_client_addr= 
> t_state.http_config_param->use_client_target_addr == 1 && 
> t_state.client_info.is_transparent &&
> 2113  t_state.dns_info.os_addr_style == 
> HttpTransact::DNSLookupInfo::OS_ADDR_TRY_DEFAULT;
> 2114   if (use_client_addr) {
> 2115 NetVConnection *vc = t_state.state_machine->ua_session ? 
> t_state.state_machine->ua_session->get_netvc() : NULL;
> 2116 if (vc) {
> /proxy/http/HttpSM.cc: 2111 in HttpSM::process_hostdb_info(HostDBInfo *)()
> 2105 void
> 2106 HttpSM::process_hostdb_info(HostDBInfo *r)
> 2107 {
> 2108   // Increment the refcount to our item, since we are pointing at it
> 2109   t_state.hostdb_entry = Ptr(r);
> 2110 
>CID 1364117:(FORWARD_NULL)
>Assigning: "client_addr" = "NULL".
> 2111   sockaddr const *client_addr = NULL;
> 2112   bool use_client_addr= 
> t_state.http_config_param->use_client_target_addr == 1 && 
> t_state.client_info.is_transparent &&
> 2113  t_state.dns_info.os_addr_style == 
> HttpTransact::DNSLookupInfo::OS_ADDR_TRY_DEFAULT;
> 2114   if (use_client_addr) {
> 2115 NetVConnection *vc = t_state.state_machine->ua_session ? 
> t_state.state_machine->ua_session->get_netvc() : NULL;
> 2116 if (vc) {
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Work logged] (TS-5059) ATS 7.0.0 build fails with OpenSSL 1.1.0c

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-5059?focusedWorklogId=34823=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-34823
 ]

ASF GitHub Bot logged work on TS-5059:
--

Author: ASF GitHub Bot
Created on: 05/Jan/17 19:53
Start Date: 05/Jan/17 19:53
Worklog Time Spent: 10m 
  Work Description: Github user jablko commented on a diff in the pull 
request:

https://github.com/apache/trafficserver/pull/1294#discussion_r94839085
  
--- Diff: iocore/net/BIO_fastopen.cc ---
@@ -116,39 +115,21 @@ static long
 fastopen_ctrl(BIO *bio, int cmd, long larg, void *ptr)
 {
   switch (cmd) {
-  case BIO_C_SET_FD:
-ink_assert(larg == BIO_CLOSE || larg == BIO_NOCLOSE);
-ink_assert(bio->num == NO_FD);
-
-bio->init = 1;
-bio->shutdown = larg;
-bio->num  = *reinterpret_cast(ptr);
-return 0;
-
   case BIO_C_SET_CONNECT:
 // We only support BIO_set_conn_address(), which sets a sockaddr.
 ink_assert(larg == 2);
-bio->ptr = ptr;
+BIO_set_data(bio, ptr);
 return 0;
 
-  // We are unbuffered so unconditionally succeed on BIO_flush().
-  case BIO_CTRL_FLUSH:
-return 1;
-
-  case BIO_CTRL_PUSH:
-  case BIO_CTRL_POP:
-return 0;
-
-  default:
-#if DEBUG
-ink_abort("unsupported BIO control cmd=%d larg=%ld ptr=%p", cmd, larg, 
ptr);
-#endif
-
-return 0;
+  case BIO_C_SET_FD:
+ink_assert(larg == BIO_CLOSE || larg == BIO_NOCLOSE);
+ink_assert(BIO_get_fd(bio, nullptr) == NO_FD);
--- End diff --

Done.


Issue Time Tracking
---

Worklog Id: (was: 34823)
Time Spent: 8h 20m  (was: 8h 10m)

> ATS 7.0.0 build fails with OpenSSL 1.1.0c
> -
>
> Key: TS-5059
> URL: https://issues.apache.org/jira/browse/TS-5059
> Project: Traffic Server
>  Issue Type: Bug
>  Components: SSL, TLS
>Reporter: Jean Baptiste Favre
> Fix For: 7.1.0
>
>  Time Spent: 8h 20m
>  Remaining Estimate: 0h
>
> ATS 7.0.0 build currently fails with following error:
> {code}SSLInternal.cc: In function ‘void SSL_set_rbio(SSL*, BIO*)’:
> SSLInternal.cc:40:10: error: invalid use of incomplete type ‘SSL {aka
> struct ssl_st}’
>if (ssl->rbio != NULL) {
>   ^~
> In file included from /usr/include/openssl/crypto.h:31:0,
>  from /usr/include/openssl/comp.h:16,
>  from /usr/include/openssl/ssl.h:47,
>  from SSLInternal.cc:33:
> /usr/include/openssl/ossl_typ.h:144:16: note: forward declaration of
> ‘SSL {aka struct ssl_st}’
>  typedef struct ssl_st SSL;
> ^~
> SSLInternal.cc:41:17: error: invalid use of incomplete type ‘SSL {aka
> struct ssl_st}’
>  BIO_free(ssl->rbio);
>  ^~
> In file included from /usr/include/openssl/crypto.h:31:0,
>  from /usr/include/openssl/comp.h:16,
>  from /usr/include/openssl/ssl.h:47,
>  from SSLInternal.cc:33:
> /usr/include/openssl/ossl_typ.h:144:16: note: forward declaration of
> ‘SSL {aka struct ssl_st}’
>  typedef struct ssl_st SSL;
> ^~
> SSLInternal.cc:43:6: error: invalid use of incomplete type ‘SSL {aka
> struct ssl_st}’
>ssl->rbio = rbio;
>   ^~
> In file included from /usr/include/openssl/crypto.h:31:0,
>  from /usr/include/openssl/comp.h:16,
>  from /usr/include/openssl/ssl.h:47,
>  from SSLInternal.cc:33:
> /usr/include/openssl/ossl_typ.h:144:16: note: forward declaration of
> ‘SSL {aka struct ssl_st}’
>  typedef struct ssl_st SSL;
> ^~
> {code}
> The full configure log can be found here:
> https://gist.github.com/jbfavre/00f63362b435d8ffc682d42d29b671f2
> According to https://wiki.openssl.org/index.php/1.1_API_Changes :
> > setting SSL->rbio without setting SSL->wbio. New function introduction
> in 1.1.0 to handle this: SSL_set_rbio()".
> Problem is, rbio doesn't seems to be nicely detected at configure stage:
> {code}checking for SSL_set_rbio... no
> checking whether to enable set rbio... no{code}
> Binding ATS to OpenSSL 1.0 still works.
> Regards,
> Jean Baptiste Favre



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Work logged] (TS-5059) ATS 7.0.0 build fails with OpenSSL 1.1.0c

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-5059?focusedWorklogId=34822=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-34822
 ]

ASF GitHub Bot logged work on TS-5059:
--

Author: ASF GitHub Bot
Created on: 05/Jan/17 19:53
Start Date: 05/Jan/17 19:53
Worklog Time Spent: 10m 
  Work Description: Github user jablko commented on a diff in the pull 
request:

https://github.com/apache/trafficserver/pull/1294#discussion_r94839028
  
--- Diff: iocore/net/BIO_fastopen.cc ---
@@ -58,26 +57,26 @@ fastopen_bwrite(BIO *bio, const char *in, int insz)
 
   errno = 0;
   BIO_clear_retry_flags(bio);
-  ink_assert(bio->num != NO_FD);
+  ink_assert(BIO_get_fd(bio, nullptr) != NO_FD);
--- End diff --

Done.


Issue Time Tracking
---

Worklog Id: (was: 34822)
Time Spent: 8h 10m  (was: 8h)

> ATS 7.0.0 build fails with OpenSSL 1.1.0c
> -
>
> Key: TS-5059
> URL: https://issues.apache.org/jira/browse/TS-5059
> Project: Traffic Server
>  Issue Type: Bug
>  Components: SSL, TLS
>Reporter: Jean Baptiste Favre
> Fix For: 7.1.0
>
>  Time Spent: 8h 10m
>  Remaining Estimate: 0h
>
> ATS 7.0.0 build currently fails with following error:
> {code}SSLInternal.cc: In function ‘void SSL_set_rbio(SSL*, BIO*)’:
> SSLInternal.cc:40:10: error: invalid use of incomplete type ‘SSL {aka
> struct ssl_st}’
>if (ssl->rbio != NULL) {
>   ^~
> In file included from /usr/include/openssl/crypto.h:31:0,
>  from /usr/include/openssl/comp.h:16,
>  from /usr/include/openssl/ssl.h:47,
>  from SSLInternal.cc:33:
> /usr/include/openssl/ossl_typ.h:144:16: note: forward declaration of
> ‘SSL {aka struct ssl_st}’
>  typedef struct ssl_st SSL;
> ^~
> SSLInternal.cc:41:17: error: invalid use of incomplete type ‘SSL {aka
> struct ssl_st}’
>  BIO_free(ssl->rbio);
>  ^~
> In file included from /usr/include/openssl/crypto.h:31:0,
>  from /usr/include/openssl/comp.h:16,
>  from /usr/include/openssl/ssl.h:47,
>  from SSLInternal.cc:33:
> /usr/include/openssl/ossl_typ.h:144:16: note: forward declaration of
> ‘SSL {aka struct ssl_st}’
>  typedef struct ssl_st SSL;
> ^~
> SSLInternal.cc:43:6: error: invalid use of incomplete type ‘SSL {aka
> struct ssl_st}’
>ssl->rbio = rbio;
>   ^~
> In file included from /usr/include/openssl/crypto.h:31:0,
>  from /usr/include/openssl/comp.h:16,
>  from /usr/include/openssl/ssl.h:47,
>  from SSLInternal.cc:33:
> /usr/include/openssl/ossl_typ.h:144:16: note: forward declaration of
> ‘SSL {aka struct ssl_st}’
>  typedef struct ssl_st SSL;
> ^~
> {code}
> The full configure log can be found here:
> https://gist.github.com/jbfavre/00f63362b435d8ffc682d42d29b671f2
> According to https://wiki.openssl.org/index.php/1.1_API_Changes :
> > setting SSL->rbio without setting SSL->wbio. New function introduction
> in 1.1.0 to handle this: SSL_set_rbio()".
> Problem is, rbio doesn't seems to be nicely detected at configure stage:
> {code}checking for SSL_set_rbio... no
> checking whether to enable set rbio... no{code}
> Binding ATS to OpenSSL 1.0 still works.
> Regards,
> Jean Baptiste Favre



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Work logged] (TS-5059) ATS 7.0.0 build fails with OpenSSL 1.1.0c

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-5059?focusedWorklogId=34821=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-34821
 ]

ASF GitHub Bot logged work on TS-5059:
--

Author: ASF GitHub Bot
Created on: 05/Jan/17 19:52
Start Date: 05/Jan/17 19:52
Worklog Time Spent: 10m 
  Work Description: Github user jablko commented on a diff in the pull 
request:

https://github.com/apache/trafficserver/pull/1294#discussion_r94838912
  
--- Diff: iocore/net/BIO_fastopen.cc ---
@@ -160,9 +174,24 @@ static const BIO_METHOD fastopen_methods = {
   .destroy   = fastopen_destroy,
   .callback_ctrl = nullptr,
 };
+#else
+static BIO_METHOD *fastopen_methods = nullptr;
+#endif
 
 const BIO_METHOD *
 BIO_s_fastopen()
 {
+#if OPENSSL_VERSION_NUMBER < 0x1010L
   return _methods;
+#else
+  if (!fastopen_methods) {
+fastopen_methods = BIO_meth_new(BIO_TYPE_SOCKET, "fastopen");
+BIO_meth_set_write(fastopen_methods, fastopen_bwrite);
+BIO_meth_set_read(fastopen_methods, fastopen_bread);
+BIO_meth_set_ctrl(fastopen_methods, fastopen_ctrl);
+BIO_meth_set_create(fastopen_methods, fastopen_create);
+BIO_meth_set_destroy(fastopen_methods, fastopen_destroy);
--- End diff --

Is the following equivalent?

```C
#if OPENSSL_VERSION_NUMBER < 0x1010L
static const BIO_METHOD fastopen_methods[] = {{
...
}};
#else
static const BIO_METHOD *fastopen_methods = [] {
  BIO_METHOD *fastopen_methods = BIO_meth_new(BIO_TYPE_SOCKET, "fastopen");
  ...
  return fastopen_methods;
}();
#endif

const BIO_METHOD *
BIO_s_fastopen()
{
  return fastopen_methods;
}


Issue Time Tracking
---

Worklog Id: (was: 34821)
Time Spent: 8h  (was: 7h 50m)

> ATS 7.0.0 build fails with OpenSSL 1.1.0c
> -
>
> Key: TS-5059
> URL: https://issues.apache.org/jira/browse/TS-5059
> Project: Traffic Server
>  Issue Type: Bug
>  Components: SSL, TLS
>Reporter: Jean Baptiste Favre
> Fix For: 7.1.0
>
>  Time Spent: 8h
>  Remaining Estimate: 0h
>
> ATS 7.0.0 build currently fails with following error:
> {code}SSLInternal.cc: In function ‘void SSL_set_rbio(SSL*, BIO*)’:
> SSLInternal.cc:40:10: error: invalid use of incomplete type ‘SSL {aka
> struct ssl_st}’
>if (ssl->rbio != NULL) {
>   ^~
> In file included from /usr/include/openssl/crypto.h:31:0,
>  from /usr/include/openssl/comp.h:16,
>  from /usr/include/openssl/ssl.h:47,
>  from SSLInternal.cc:33:
> /usr/include/openssl/ossl_typ.h:144:16: note: forward declaration of
> ‘SSL {aka struct ssl_st}’
>  typedef struct ssl_st SSL;
> ^~
> SSLInternal.cc:41:17: error: invalid use of incomplete type ‘SSL {aka
> struct ssl_st}’
>  BIO_free(ssl->rbio);
>  ^~
> In file included from /usr/include/openssl/crypto.h:31:0,
>  from /usr/include/openssl/comp.h:16,
>  from /usr/include/openssl/ssl.h:47,
>  from SSLInternal.cc:33:
> /usr/include/openssl/ossl_typ.h:144:16: note: forward declaration of
> ‘SSL {aka struct ssl_st}’
>  typedef struct ssl_st SSL;
> ^~
> SSLInternal.cc:43:6: error: invalid use of incomplete type ‘SSL {aka
> struct ssl_st}’
>ssl->rbio = rbio;
>   ^~
> In file included from /usr/include/openssl/crypto.h:31:0,
>  from /usr/include/openssl/comp.h:16,
>  from /usr/include/openssl/ssl.h:47,
>  from SSLInternal.cc:33:
> /usr/include/openssl/ossl_typ.h:144:16: note: forward declaration of
> ‘SSL {aka struct ssl_st}’
>  typedef struct ssl_st SSL;
> ^~
> {code}
> The full configure log can be found here:
> https://gist.github.com/jbfavre/00f63362b435d8ffc682d42d29b671f2
> According to https://wiki.openssl.org/index.php/1.1_API_Changes :
> > setting SSL->rbio without setting SSL->wbio. New function introduction
> in 1.1.0 to handle this: SSL_set_rbio()".
> Problem is, rbio doesn't seems to be nicely detected at configure stage:
> {code}checking for SSL_set_rbio... no
> checking whether to enable set rbio... no{code}
> Binding ATS to OpenSSL 1.0 still works.
> Regards,
> Jean Baptiste Favre



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Work logged] (TS-5059) ATS 7.0.0 build fails with OpenSSL 1.1.0c

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-5059?focusedWorklogId=34820=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-34820
 ]

ASF GitHub Bot logged work on TS-5059:
--

Author: ASF GitHub Bot
Created on: 05/Jan/17 19:39
Start Date: 05/Jan/17 19:39
Worklog Time Spent: 10m 
  Work Description: Github user jablko commented on a diff in the pull 
request:

https://github.com/apache/trafficserver/pull/1294#discussion_r94836394
  
--- Diff: iocore/net/BIO_fastopen.cc ---
@@ -44,8 +57,7 @@ fastopen_destroy(BIO *bio)
   if (bio) {
 // We expect this BIO to not own the socket, so we must always
 // be in NOCLOSE mode.
-ink_assert(bio->shutdown == BIO_NOCLOSE);
-fastopen_create(bio);
+ink_assert(BIO_get_shutdown(bio) == BIO_NOCLOSE);
--- End diff --

The struct is gone now.


Issue Time Tracking
---

Worklog Id: (was: 34820)
Time Spent: 7h 50m  (was: 7h 40m)

> ATS 7.0.0 build fails with OpenSSL 1.1.0c
> -
>
> Key: TS-5059
> URL: https://issues.apache.org/jira/browse/TS-5059
> Project: Traffic Server
>  Issue Type: Bug
>  Components: SSL, TLS
>Reporter: Jean Baptiste Favre
> Fix For: 7.1.0
>
>  Time Spent: 7h 50m
>  Remaining Estimate: 0h
>
> ATS 7.0.0 build currently fails with following error:
> {code}SSLInternal.cc: In function ‘void SSL_set_rbio(SSL*, BIO*)’:
> SSLInternal.cc:40:10: error: invalid use of incomplete type ‘SSL {aka
> struct ssl_st}’
>if (ssl->rbio != NULL) {
>   ^~
> In file included from /usr/include/openssl/crypto.h:31:0,
>  from /usr/include/openssl/comp.h:16,
>  from /usr/include/openssl/ssl.h:47,
>  from SSLInternal.cc:33:
> /usr/include/openssl/ossl_typ.h:144:16: note: forward declaration of
> ‘SSL {aka struct ssl_st}’
>  typedef struct ssl_st SSL;
> ^~
> SSLInternal.cc:41:17: error: invalid use of incomplete type ‘SSL {aka
> struct ssl_st}’
>  BIO_free(ssl->rbio);
>  ^~
> In file included from /usr/include/openssl/crypto.h:31:0,
>  from /usr/include/openssl/comp.h:16,
>  from /usr/include/openssl/ssl.h:47,
>  from SSLInternal.cc:33:
> /usr/include/openssl/ossl_typ.h:144:16: note: forward declaration of
> ‘SSL {aka struct ssl_st}’
>  typedef struct ssl_st SSL;
> ^~
> SSLInternal.cc:43:6: error: invalid use of incomplete type ‘SSL {aka
> struct ssl_st}’
>ssl->rbio = rbio;
>   ^~
> In file included from /usr/include/openssl/crypto.h:31:0,
>  from /usr/include/openssl/comp.h:16,
>  from /usr/include/openssl/ssl.h:47,
>  from SSLInternal.cc:33:
> /usr/include/openssl/ossl_typ.h:144:16: note: forward declaration of
> ‘SSL {aka struct ssl_st}’
>  typedef struct ssl_st SSL;
> ^~
> {code}
> The full configure log can be found here:
> https://gist.github.com/jbfavre/00f63362b435d8ffc682d42d29b671f2
> According to https://wiki.openssl.org/index.php/1.1_API_Changes :
> > setting SSL->rbio without setting SSL->wbio. New function introduction
> in 1.1.0 to handle this: SSL_set_rbio()".
> Problem is, rbio doesn't seems to be nicely detected at configure stage:
> {code}checking for SSL_set_rbio... no
> checking whether to enable set rbio... no{code}
> Binding ATS to OpenSSL 1.0 still works.
> Regards,
> Jean Baptiste Favre



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Work logged] (TS-5059) ATS 7.0.0 build fails with OpenSSL 1.1.0c

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-5059?focusedWorklogId=34819=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-34819
 ]

ASF GitHub Bot logged work on TS-5059:
--

Author: ASF GitHub Bot
Created on: 05/Jan/17 19:34
Start Date: 05/Jan/17 19:34
Worklog Time Spent: 10m 
  Work Description: Github user jablko commented on a diff in the pull 
request:

https://github.com/apache/trafficserver/pull/1294#discussion_r94835352
  
--- Diff: iocore/net/BIO_fastopen.cc ---
@@ -27,13 +27,26 @@
 
 #include "BIO_fastopen.h"
 
+#if OPENSSL_VERSION_NUMBER < 0x1010L
+#define BIO_set_data(a, ptr) ((a)->ptr = (ptr))
+#define BIO_get_data(a) ((a)->ptr)
+#define BIO_set_init(a, init) ((a)->init = (init))
+#define BIO_set_shutdown(a, shut) ((a)->shutdown = (shut))
+#define BIO_get_shutdown(a) ((a)->shutdown)
+#endif
+
+struct Data {
+  Data() : fd(NO_FD), dst(nullptr) {}
+  int fd;
+  const sockaddr *dst;
+};
--- End diff --

Nice! Done.


Issue Time Tracking
---

Worklog Id: (was: 34819)
Time Spent: 7h 40m  (was: 7.5h)

> ATS 7.0.0 build fails with OpenSSL 1.1.0c
> -
>
> Key: TS-5059
> URL: https://issues.apache.org/jira/browse/TS-5059
> Project: Traffic Server
>  Issue Type: Bug
>  Components: SSL, TLS
>Reporter: Jean Baptiste Favre
> Fix For: 7.1.0
>
>  Time Spent: 7h 40m
>  Remaining Estimate: 0h
>
> ATS 7.0.0 build currently fails with following error:
> {code}SSLInternal.cc: In function ‘void SSL_set_rbio(SSL*, BIO*)’:
> SSLInternal.cc:40:10: error: invalid use of incomplete type ‘SSL {aka
> struct ssl_st}’
>if (ssl->rbio != NULL) {
>   ^~
> In file included from /usr/include/openssl/crypto.h:31:0,
>  from /usr/include/openssl/comp.h:16,
>  from /usr/include/openssl/ssl.h:47,
>  from SSLInternal.cc:33:
> /usr/include/openssl/ossl_typ.h:144:16: note: forward declaration of
> ‘SSL {aka struct ssl_st}’
>  typedef struct ssl_st SSL;
> ^~
> SSLInternal.cc:41:17: error: invalid use of incomplete type ‘SSL {aka
> struct ssl_st}’
>  BIO_free(ssl->rbio);
>  ^~
> In file included from /usr/include/openssl/crypto.h:31:0,
>  from /usr/include/openssl/comp.h:16,
>  from /usr/include/openssl/ssl.h:47,
>  from SSLInternal.cc:33:
> /usr/include/openssl/ossl_typ.h:144:16: note: forward declaration of
> ‘SSL {aka struct ssl_st}’
>  typedef struct ssl_st SSL;
> ^~
> SSLInternal.cc:43:6: error: invalid use of incomplete type ‘SSL {aka
> struct ssl_st}’
>ssl->rbio = rbio;
>   ^~
> In file included from /usr/include/openssl/crypto.h:31:0,
>  from /usr/include/openssl/comp.h:16,
>  from /usr/include/openssl/ssl.h:47,
>  from SSLInternal.cc:33:
> /usr/include/openssl/ossl_typ.h:144:16: note: forward declaration of
> ‘SSL {aka struct ssl_st}’
>  typedef struct ssl_st SSL;
> ^~
> {code}
> The full configure log can be found here:
> https://gist.github.com/jbfavre/00f63362b435d8ffc682d42d29b671f2
> According to https://wiki.openssl.org/index.php/1.1_API_Changes :
> > setting SSL->rbio without setting SSL->wbio. New function introduction
> in 1.1.0 to handle this: SSL_set_rbio()".
> Problem is, rbio doesn't seems to be nicely detected at configure stage:
> {code}checking for SSL_set_rbio... no
> checking whether to enable set rbio... no{code}
> Binding ATS to OpenSSL 1.0 still works.
> Regards,
> Jean Baptiste Favre



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Work logged] (TS-5059) ATS 7.0.0 build fails with OpenSSL 1.1.0c

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-5059?focusedWorklogId=34818=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-34818
 ]

ASF GitHub Bot logged work on TS-5059:
--

Author: ASF GitHub Bot
Created on: 05/Jan/17 19:32
Start Date: 05/Jan/17 19:32
Worklog Time Spent: 10m 
  Work Description: Github user jablko commented on a diff in the pull 
request:

https://github.com/apache/trafficserver/pull/1294#discussion_r94835039
  
--- Diff: iocore/net/BIO_fastopen.cc ---
@@ -27,13 +27,26 @@
 
 #include "BIO_fastopen.h"
 
+#if OPENSSL_VERSION_NUMBER < 0x1010L
+#define BIO_set_data(a, ptr) ((a)->ptr = (ptr))
--- End diff --

Done.


Issue Time Tracking
---

Worklog Id: (was: 34818)
Time Spent: 7.5h  (was: 7h 20m)

> ATS 7.0.0 build fails with OpenSSL 1.1.0c
> -
>
> Key: TS-5059
> URL: https://issues.apache.org/jira/browse/TS-5059
> Project: Traffic Server
>  Issue Type: Bug
>  Components: SSL, TLS
>Reporter: Jean Baptiste Favre
> Fix For: 7.1.0
>
>  Time Spent: 7.5h
>  Remaining Estimate: 0h
>
> ATS 7.0.0 build currently fails with following error:
> {code}SSLInternal.cc: In function ‘void SSL_set_rbio(SSL*, BIO*)’:
> SSLInternal.cc:40:10: error: invalid use of incomplete type ‘SSL {aka
> struct ssl_st}’
>if (ssl->rbio != NULL) {
>   ^~
> In file included from /usr/include/openssl/crypto.h:31:0,
>  from /usr/include/openssl/comp.h:16,
>  from /usr/include/openssl/ssl.h:47,
>  from SSLInternal.cc:33:
> /usr/include/openssl/ossl_typ.h:144:16: note: forward declaration of
> ‘SSL {aka struct ssl_st}’
>  typedef struct ssl_st SSL;
> ^~
> SSLInternal.cc:41:17: error: invalid use of incomplete type ‘SSL {aka
> struct ssl_st}’
>  BIO_free(ssl->rbio);
>  ^~
> In file included from /usr/include/openssl/crypto.h:31:0,
>  from /usr/include/openssl/comp.h:16,
>  from /usr/include/openssl/ssl.h:47,
>  from SSLInternal.cc:33:
> /usr/include/openssl/ossl_typ.h:144:16: note: forward declaration of
> ‘SSL {aka struct ssl_st}’
>  typedef struct ssl_st SSL;
> ^~
> SSLInternal.cc:43:6: error: invalid use of incomplete type ‘SSL {aka
> struct ssl_st}’
>ssl->rbio = rbio;
>   ^~
> In file included from /usr/include/openssl/crypto.h:31:0,
>  from /usr/include/openssl/comp.h:16,
>  from /usr/include/openssl/ssl.h:47,
>  from SSLInternal.cc:33:
> /usr/include/openssl/ossl_typ.h:144:16: note: forward declaration of
> ‘SSL {aka struct ssl_st}’
>  typedef struct ssl_st SSL;
> ^~
> {code}
> The full configure log can be found here:
> https://gist.github.com/jbfavre/00f63362b435d8ffc682d42d29b671f2
> According to https://wiki.openssl.org/index.php/1.1_API_Changes :
> > setting SSL->rbio without setting SSL->wbio. New function introduction
> in 1.1.0 to handle this: SSL_set_rbio()".
> Problem is, rbio doesn't seems to be nicely detected at configure stage:
> {code}checking for SSL_set_rbio... no
> checking whether to enable set rbio... no{code}
> Binding ATS to OpenSSL 1.0 still works.
> Regards,
> Jean Baptiste Favre



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Work logged] (TS-5022) Multiple Client Certificate to Origin

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-5022?focusedWorklogId=34817=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-34817
 ]

ASF GitHub Bot logged work on TS-5022:
--

Author: ASF GitHub Bot
Created on: 05/Jan/17 18:58
Start Date: 05/Jan/17 18:58
Worklog Time Spent: 10m 
  Work Description: Github user persiaAziz commented on a diff in the pull 
request:

https://github.com/apache/trafficserver/pull/1226#discussion_r94828732
  
--- Diff: proxy/http/HttpSM.cc ---
@@ -4059,6 +4061,16 @@ HttpSM::do_remap_request(bool run_inline)
 pending_action = remap_action_handle;
   }
 
+  // check if the overridden client cert filename is already attached to 
an existing ssl context
+  ats_scoped_str 
clientCert(Layout::relative_to(t_state.txn_conf->client_cert_filepath, 
t_state.txn_conf->client_cert_filename));
+  auto tCTX = params->getCTX(clientCert);
+
+  if (tCTX == nullptr) {
+// make new client ctx and add it to the ctx list
+auto tctx = ssl_NetProcessor.getNewCTX(clientCert);
+params->InsertCTX(clientCert, tctx);
--- End diff --

Yes it would be cleaner. I reused the SSLInitClientContext logic to create 
the new CTX. That is why I kept it here. I will see if I can move the whole 
client context thing to SSLconfig


Issue Time Tracking
---

Worklog Id: (was: 34817)
Time Spent: 4h 20m  (was: 4h 10m)

> Multiple Client Certificate to Origin
> -
>
> Key: TS-5022
> URL: https://issues.apache.org/jira/browse/TS-5022
> Project: Traffic Server
>  Issue Type: Improvement
>  Components: Security, SSL, TLS
>Reporter: Scott Beardsley
>Assignee: Syeda Persia Aziz
>  Labels: yahoo
> Fix For: 7.1.0
>
>  Time Spent: 4h 20m
>  Remaining Estimate: 0h
>
> Yahoo has a use case where the origin is doing mutual TLS authentication 
> which requires ATS to send a client certificate. This works fine (for now) 
> because ATS supports configuring *one* client cert but this feature should 
> really allow multiple client certificates to be configured which would depend 
> upon the origin being contacted.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Work logged] (TS-5022) Multiple Client Certificate to Origin

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-5022?focusedWorklogId=34816=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-34816
 ]

ASF GitHub Bot logged work on TS-5022:
--

Author: ASF GitHub Bot
Created on: 05/Jan/17 18:52
Start Date: 05/Jan/17 18:52
Worklog Time Spent: 10m 
  Work Description: Github user persiaAziz commented on a diff in the pull 
request:

https://github.com/apache/trafficserver/pull/1226#discussion_r94827614
  
--- Diff: iocore/net/SSLNetProcessor.cc ---
@@ -76,6 +77,7 @@ SSLNetProcessor::start(int, size_t stacksize)
 SSLError("Can't initialize the SSL client, HTTPS in remap rules will 
not function");
   }
 
+  params->InsertCTX(params->clientCertPath, client_ctx);
--- End diff --

I put it here because client_ctx is being initialized here which belongs to 
SSLNetprocessor


Issue Time Tracking
---

Worklog Id: (was: 34816)
Time Spent: 4h 10m  (was: 4h)

> Multiple Client Certificate to Origin
> -
>
> Key: TS-5022
> URL: https://issues.apache.org/jira/browse/TS-5022
> Project: Traffic Server
>  Issue Type: Improvement
>  Components: Security, SSL, TLS
>Reporter: Scott Beardsley
>Assignee: Syeda Persia Aziz
>  Labels: yahoo
> Fix For: 7.1.0
>
>  Time Spent: 4h 10m
>  Remaining Estimate: 0h
>
> Yahoo has a use case where the origin is doing mutual TLS authentication 
> which requires ATS to send a client certificate. This works fine (for now) 
> because ATS supports configuring *one* client cert but this feature should 
> really allow multiple client certificates to be configured which would depend 
> upon the origin being contacted.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Work logged] (TS-5022) Multiple Client Certificate to Origin

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-5022?focusedWorklogId=34815=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-34815
 ]

ASF GitHub Bot logged work on TS-5022:
--

Author: ASF GitHub Bot
Created on: 05/Jan/17 18:50
Start Date: 05/Jan/17 18:50
Worklog Time Spent: 10m 
  Work Description: Github user persiaAziz commented on a diff in the pull 
request:

https://github.com/apache/trafficserver/pull/1226#discussion_r94827291
  
--- Diff: iocore/net/SSLNetProcessor.cc ---
@@ -67,7 +67,8 @@ SSLNetProcessor::start(int, size_t stacksize)
 
   // Acquire a SSLConfigParams instance *after* we start SSL up.
   SSLConfig::scoped_config params;
-
+  // freeing the CTX Map
+  params->freeCTXmap();
--- End diff --

You are right, I forgot to remove this call


Issue Time Tracking
---

Worklog Id: (was: 34815)
Time Spent: 4h  (was: 3h 50m)

> Multiple Client Certificate to Origin
> -
>
> Key: TS-5022
> URL: https://issues.apache.org/jira/browse/TS-5022
> Project: Traffic Server
>  Issue Type: Improvement
>  Components: Security, SSL, TLS
>Reporter: Scott Beardsley
>Assignee: Syeda Persia Aziz
>  Labels: yahoo
> Fix For: 7.1.0
>
>  Time Spent: 4h
>  Remaining Estimate: 0h
>
> Yahoo has a use case where the origin is doing mutual TLS authentication 
> which requires ATS to send a client certificate. This works fine (for now) 
> because ATS supports configuring *one* client cert but this feature should 
> really allow multiple client certificates to be configured which would depend 
> upon the origin being contacted.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Work logged] (TS-5022) Multiple Client Certificate to Origin

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-5022?focusedWorklogId=34814=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-34814
 ]

ASF GitHub Bot logged work on TS-5022:
--

Author: ASF GitHub Bot
Created on: 05/Jan/17 18:46
Start Date: 05/Jan/17 18:46
Worklog Time Spent: 10m 
  Work Description: Github user shinrich commented on a diff in the pull 
request:

https://github.com/apache/trafficserver/pull/1226#discussion_r94826573
  
--- Diff: proxy/http/HttpSM.cc ---
@@ -4059,6 +4061,16 @@ HttpSM::do_remap_request(bool run_inline)
 pending_action = remap_action_handle;
   }
 
+  // check if the overridden client cert filename is already attached to 
an existing ssl context
+  ats_scoped_str 
clientCert(Layout::relative_to(t_state.txn_conf->client_cert_filepath, 
t_state.txn_conf->client_cert_filename));
+  auto tCTX = params->getCTX(clientCert);
+
+  if (tCTX == nullptr) {
+// make new client ctx and add it to the ctx list
+auto tctx = ssl_NetProcessor.getNewCTX(clientCert);
+params->InsertCTX(clientCert, tctx);
--- End diff --

Maybe it would be cleaner to have a version of InsertCTX() that only took 
the certificate name and did the certificate creation and insert?


Issue Time Tracking
---

Worklog Id: (was: 34814)
Time Spent: 3h 50m  (was: 3h 40m)

> Multiple Client Certificate to Origin
> -
>
> Key: TS-5022
> URL: https://issues.apache.org/jira/browse/TS-5022
> Project: Traffic Server
>  Issue Type: Improvement
>  Components: Security, SSL, TLS
>Reporter: Scott Beardsley
>Assignee: Syeda Persia Aziz
>  Labels: yahoo
> Fix For: 7.1.0
>
>  Time Spent: 3h 50m
>  Remaining Estimate: 0h
>
> Yahoo has a use case where the origin is doing mutual TLS authentication 
> which requires ATS to send a client certificate. This works fine (for now) 
> because ATS supports configuring *one* client cert but this feature should 
> really allow multiple client certificates to be configured which would depend 
> upon the origin being contacted.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Work logged] (TS-5022) Multiple Client Certificate to Origin

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-5022?focusedWorklogId=34813=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-34813
 ]

ASF GitHub Bot logged work on TS-5022:
--

Author: ASF GitHub Bot
Created on: 05/Jan/17 18:43
Start Date: 05/Jan/17 18:43
Worklog Time Spent: 10m 
  Work Description: Github user shinrich commented on a diff in the pull 
request:

https://github.com/apache/trafficserver/pull/1226#discussion_r94825933
  
--- Diff: iocore/net/SSLNetVConnection.cc ---
@@ -980,7 +980,20 @@ SSLNetVConnection::sslStartHandShake(int event, int 
)
 
   case SSL_EVENT_CLIENT:
 if (this->ssl == nullptr) {
-  this->ssl = make_ssl_connection(ssl_NetProcessor.client_ctx, this);
+  SSL_CTX *clientCTX = nullptr;
+  if (this->options.clientCertificate) {
+const char *certfile = (const char 
*)this->options.clientCertificate;
+if (certfile != nullptr) {
+  clientCTX = params->getCTX(certfile);
+  if (clientCTX != nullptr)
+Debug("ssl", "context for %s is found at %p", 
this->options.clientCertificate.get(), (void *)clientCTX);
+  else
+Debug("ssl", "failed to find context for %s", 
this->options.clientCertificate.get());
+}
+  } else {
+clientCTX = ssl_NetProcessor.client_ctx;
+  }
--- End diff --

Should we use the same logic to fetch the default client cert as well?


Issue Time Tracking
---

Worklog Id: (was: 34813)
Time Spent: 3h 40m  (was: 3.5h)

> Multiple Client Certificate to Origin
> -
>
> Key: TS-5022
> URL: https://issues.apache.org/jira/browse/TS-5022
> Project: Traffic Server
>  Issue Type: Improvement
>  Components: Security, SSL, TLS
>Reporter: Scott Beardsley
>Assignee: Syeda Persia Aziz
>  Labels: yahoo
> Fix For: 7.1.0
>
>  Time Spent: 3h 40m
>  Remaining Estimate: 0h
>
> Yahoo has a use case where the origin is doing mutual TLS authentication 
> which requires ATS to send a client certificate. This works fine (for now) 
> because ATS supports configuring *one* client cert but this feature should 
> really allow multiple client certificates to be configured which would depend 
> upon the origin being contacted.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Work logged] (TS-5022) Multiple Client Certificate to Origin

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-5022?focusedWorklogId=34812=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-34812
 ]

ASF GitHub Bot logged work on TS-5022:
--

Author: ASF GitHub Bot
Created on: 05/Jan/17 18:38
Start Date: 05/Jan/17 18:38
Worklog Time Spent: 10m 
  Work Description: Github user shinrich commented on a diff in the pull 
request:

https://github.com/apache/trafficserver/pull/1226#discussion_r94824973
  
--- Diff: iocore/net/SSLNetProcessor.cc ---
@@ -76,6 +77,7 @@ SSLNetProcessor::start(int, size_t stacksize)
 SSLError("Can't initialize the SSL client, HTTPS in remap rules will 
not function");
   }
 
+  params->InsertCTX(params->clientCertPath, client_ctx);
--- End diff --

And maybe the InsertCTX should be moved to the logic that initializes/sets 
up the SSLConfig?  


Issue Time Tracking
---

Worklog Id: (was: 34812)
Time Spent: 3.5h  (was: 3h 20m)

> Multiple Client Certificate to Origin
> -
>
> Key: TS-5022
> URL: https://issues.apache.org/jira/browse/TS-5022
> Project: Traffic Server
>  Issue Type: Improvement
>  Components: Security, SSL, TLS
>Reporter: Scott Beardsley
>Assignee: Syeda Persia Aziz
>  Labels: yahoo
> Fix For: 7.1.0
>
>  Time Spent: 3.5h
>  Remaining Estimate: 0h
>
> Yahoo has a use case where the origin is doing mutual TLS authentication 
> which requires ATS to send a client certificate. This works fine (for now) 
> because ATS supports configuring *one* client cert but this feature should 
> really allow multiple client certificates to be configured which would depend 
> upon the origin being contacted.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Work logged] (TS-5022) Multiple Client Certificate to Origin

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-5022?focusedWorklogId=34811=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-34811
 ]

ASF GitHub Bot logged work on TS-5022:
--

Author: ASF GitHub Bot
Created on: 05/Jan/17 18:36
Start Date: 05/Jan/17 18:36
Worklog Time Spent: 10m 
  Work Description: Github user shinrich commented on a diff in the pull 
request:

https://github.com/apache/trafficserver/pull/1226#discussion_r94824666
  
--- Diff: iocore/net/SSLNetProcessor.cc ---
@@ -67,7 +67,8 @@ SSLNetProcessor::start(int, size_t stacksize)
 
   // Acquire a SSLConfigParams instance *after* we start SSL up.
   SSLConfig::scoped_config params;
-
+  // freeing the CTX Map
+  params->freeCTXmap();
--- End diff --

Shouldn't you just rely on the SSLConfig::cleanup to call freeCTXmap?


Issue Time Tracking
---

Worklog Id: (was: 34811)
Time Spent: 3h 20m  (was: 3h 10m)

> Multiple Client Certificate to Origin
> -
>
> Key: TS-5022
> URL: https://issues.apache.org/jira/browse/TS-5022
> Project: Traffic Server
>  Issue Type: Improvement
>  Components: Security, SSL, TLS
>Reporter: Scott Beardsley
>Assignee: Syeda Persia Aziz
>  Labels: yahoo
> Fix For: 7.1.0
>
>  Time Spent: 3h 20m
>  Remaining Estimate: 0h
>
> Yahoo has a use case where the origin is doing mutual TLS authentication 
> which requires ATS to send a client certificate. This works fine (for now) 
> because ATS supports configuring *one* client cert but this feature should 
> really allow multiple client certificates to be configured which would depend 
> upon the origin being contacted.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Work logged] (TS-5059) ATS 7.0.0 build fails with OpenSSL 1.1.0c

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-5059?focusedWorklogId=34810=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-34810
 ]

ASF GitHub Bot logged work on TS-5059:
--

Author: ASF GitHub Bot
Created on: 05/Jan/17 18:04
Start Date: 05/Jan/17 18:04
Worklog Time Spent: 10m 
  Work Description: Github user jablko commented on a diff in the pull 
request:

https://github.com/apache/trafficserver/pull/1294#discussion_r94818857
  
--- Diff: iocore/net/BIO_fastopen.cc ---
@@ -27,28 +27,27 @@
 
 #include "BIO_fastopen.h"
 
-static int
-fastopen_create(BIO *bio)
-{
-  bio->init  = 0;
-  bio->num   = NO_FD;
-  bio->flags = 0;
-  bio->ptr   = nullptr;
+#if OPENSSL_VERSION_NUMBER < 0x1010L
+#define BIO_set_data(a, _ptr) ((a)->ptr = (_ptr))
+#define BIO_get_data(a) ((a)->ptr)
+#define BIO_get_shutdown(a) ((a)->shutdown)
+#define BIO_meth_get_ctrl(biom) ((biom)->ctrl)
+#define BIO_meth_get_create(biom) ((biom)->create)
+#define BIO_meth_get_destroy(biom) ((biom)->destroy)
+#endif
 
-  return 1;
-}
+static int (*fastopen_create)(BIO *) = 
BIO_meth_get_create(const_cast(BIO_s_socket()));
 
 static int
 fastopen_destroy(BIO *bio)
 {
   if (bio) {
 // We expect this BIO to not own the socket, so we must always
 // be in NOCLOSE mode.
-ink_assert(bio->shutdown == BIO_NOCLOSE);
-fastopen_create(bio);
+ink_assert(BIO_get_shutdown(bio) == BIO_NOCLOSE);
   }
 
-  return 1;
+  return BIO_meth_get_destroy(const_cast(BIO_s_socket()))(bio);
--- End diff --

Agreed. https://github.com/openssl/openssl/pull/2181


Issue Time Tracking
---

Worklog Id: (was: 34810)
Time Spent: 7h 20m  (was: 7h 10m)

> ATS 7.0.0 build fails with OpenSSL 1.1.0c
> -
>
> Key: TS-5059
> URL: https://issues.apache.org/jira/browse/TS-5059
> Project: Traffic Server
>  Issue Type: Bug
>  Components: SSL, TLS
>Reporter: Jean Baptiste Favre
> Fix For: 7.1.0
>
>  Time Spent: 7h 20m
>  Remaining Estimate: 0h
>
> ATS 7.0.0 build currently fails with following error:
> {code}SSLInternal.cc: In function ‘void SSL_set_rbio(SSL*, BIO*)’:
> SSLInternal.cc:40:10: error: invalid use of incomplete type ‘SSL {aka
> struct ssl_st}’
>if (ssl->rbio != NULL) {
>   ^~
> In file included from /usr/include/openssl/crypto.h:31:0,
>  from /usr/include/openssl/comp.h:16,
>  from /usr/include/openssl/ssl.h:47,
>  from SSLInternal.cc:33:
> /usr/include/openssl/ossl_typ.h:144:16: note: forward declaration of
> ‘SSL {aka struct ssl_st}’
>  typedef struct ssl_st SSL;
> ^~
> SSLInternal.cc:41:17: error: invalid use of incomplete type ‘SSL {aka
> struct ssl_st}’
>  BIO_free(ssl->rbio);
>  ^~
> In file included from /usr/include/openssl/crypto.h:31:0,
>  from /usr/include/openssl/comp.h:16,
>  from /usr/include/openssl/ssl.h:47,
>  from SSLInternal.cc:33:
> /usr/include/openssl/ossl_typ.h:144:16: note: forward declaration of
> ‘SSL {aka struct ssl_st}’
>  typedef struct ssl_st SSL;
> ^~
> SSLInternal.cc:43:6: error: invalid use of incomplete type ‘SSL {aka
> struct ssl_st}’
>ssl->rbio = rbio;
>   ^~
> In file included from /usr/include/openssl/crypto.h:31:0,
>  from /usr/include/openssl/comp.h:16,
>  from /usr/include/openssl/ssl.h:47,
>  from SSLInternal.cc:33:
> /usr/include/openssl/ossl_typ.h:144:16: note: forward declaration of
> ‘SSL {aka struct ssl_st}’
>  typedef struct ssl_st SSL;
> ^~
> {code}
> The full configure log can be found here:
> https://gist.github.com/jbfavre/00f63362b435d8ffc682d42d29b671f2
> According to https://wiki.openssl.org/index.php/1.1_API_Changes :
> > setting SSL->rbio without setting SSL->wbio. New function introduction
> in 1.1.0 to handle this: SSL_set_rbio()".
> Problem is, rbio doesn't seems to be nicely detected at configure stage:
> {code}checking for SSL_set_rbio... no
> checking whether to enable set rbio... no{code}
> Binding ATS to OpenSSL 1.0 still works.
> Regards,
> Jean Baptiste Favre



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Work logged] (TS-5059) ATS 7.0.0 build fails with OpenSSL 1.1.0c

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-5059?focusedWorklogId=34809=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-34809
 ]

ASF GitHub Bot logged work on TS-5059:
--

Author: ASF GitHub Bot
Created on: 05/Jan/17 18:00
Start Date: 05/Jan/17 18:00
Worklog Time Spent: 10m 
  Work Description: Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1294
  
FreeBSD build *successful*! See 
https://ci.trafficserver.apache.org/job/Github-FreeBSD/1305/ for details.
 



Issue Time Tracking
---

Worklog Id: (was: 34809)
Time Spent: 7h 10m  (was: 7h)

> ATS 7.0.0 build fails with OpenSSL 1.1.0c
> -
>
> Key: TS-5059
> URL: https://issues.apache.org/jira/browse/TS-5059
> Project: Traffic Server
>  Issue Type: Bug
>  Components: SSL, TLS
>Reporter: Jean Baptiste Favre
> Fix For: 7.1.0
>
>  Time Spent: 7h 10m
>  Remaining Estimate: 0h
>
> ATS 7.0.0 build currently fails with following error:
> {code}SSLInternal.cc: In function ‘void SSL_set_rbio(SSL*, BIO*)’:
> SSLInternal.cc:40:10: error: invalid use of incomplete type ‘SSL {aka
> struct ssl_st}’
>if (ssl->rbio != NULL) {
>   ^~
> In file included from /usr/include/openssl/crypto.h:31:0,
>  from /usr/include/openssl/comp.h:16,
>  from /usr/include/openssl/ssl.h:47,
>  from SSLInternal.cc:33:
> /usr/include/openssl/ossl_typ.h:144:16: note: forward declaration of
> ‘SSL {aka struct ssl_st}’
>  typedef struct ssl_st SSL;
> ^~
> SSLInternal.cc:41:17: error: invalid use of incomplete type ‘SSL {aka
> struct ssl_st}’
>  BIO_free(ssl->rbio);
>  ^~
> In file included from /usr/include/openssl/crypto.h:31:0,
>  from /usr/include/openssl/comp.h:16,
>  from /usr/include/openssl/ssl.h:47,
>  from SSLInternal.cc:33:
> /usr/include/openssl/ossl_typ.h:144:16: note: forward declaration of
> ‘SSL {aka struct ssl_st}’
>  typedef struct ssl_st SSL;
> ^~
> SSLInternal.cc:43:6: error: invalid use of incomplete type ‘SSL {aka
> struct ssl_st}’
>ssl->rbio = rbio;
>   ^~
> In file included from /usr/include/openssl/crypto.h:31:0,
>  from /usr/include/openssl/comp.h:16,
>  from /usr/include/openssl/ssl.h:47,
>  from SSLInternal.cc:33:
> /usr/include/openssl/ossl_typ.h:144:16: note: forward declaration of
> ‘SSL {aka struct ssl_st}’
>  typedef struct ssl_st SSL;
> ^~
> {code}
> The full configure log can be found here:
> https://gist.github.com/jbfavre/00f63362b435d8ffc682d42d29b671f2
> According to https://wiki.openssl.org/index.php/1.1_API_Changes :
> > setting SSL->rbio without setting SSL->wbio. New function introduction
> in 1.1.0 to handle this: SSL_set_rbio()".
> Problem is, rbio doesn't seems to be nicely detected at configure stage:
> {code}checking for SSL_set_rbio... no
> checking whether to enable set rbio... no{code}
> Binding ATS to OpenSSL 1.0 still works.
> Regards,
> Jean Baptiste Favre



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Work logged] (TS-5059) ATS 7.0.0 build fails with OpenSSL 1.1.0c

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-5059?focusedWorklogId=34808=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-34808
 ]

ASF GitHub Bot logged work on TS-5059:
--

Author: ASF GitHub Bot
Created on: 05/Jan/17 17:58
Start Date: 05/Jan/17 17:58
Worklog Time Spent: 10m 
  Work Description: Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1294
  
Linux build *successful*! See 
https://ci.trafficserver.apache.org/job/Github-Linux/1199/ for details.
 



Issue Time Tracking
---

Worklog Id: (was: 34808)
Time Spent: 7h  (was: 6h 50m)

> ATS 7.0.0 build fails with OpenSSL 1.1.0c
> -
>
> Key: TS-5059
> URL: https://issues.apache.org/jira/browse/TS-5059
> Project: Traffic Server
>  Issue Type: Bug
>  Components: SSL, TLS
>Reporter: Jean Baptiste Favre
> Fix For: 7.1.0
>
>  Time Spent: 7h
>  Remaining Estimate: 0h
>
> ATS 7.0.0 build currently fails with following error:
> {code}SSLInternal.cc: In function ‘void SSL_set_rbio(SSL*, BIO*)’:
> SSLInternal.cc:40:10: error: invalid use of incomplete type ‘SSL {aka
> struct ssl_st}’
>if (ssl->rbio != NULL) {
>   ^~
> In file included from /usr/include/openssl/crypto.h:31:0,
>  from /usr/include/openssl/comp.h:16,
>  from /usr/include/openssl/ssl.h:47,
>  from SSLInternal.cc:33:
> /usr/include/openssl/ossl_typ.h:144:16: note: forward declaration of
> ‘SSL {aka struct ssl_st}’
>  typedef struct ssl_st SSL;
> ^~
> SSLInternal.cc:41:17: error: invalid use of incomplete type ‘SSL {aka
> struct ssl_st}’
>  BIO_free(ssl->rbio);
>  ^~
> In file included from /usr/include/openssl/crypto.h:31:0,
>  from /usr/include/openssl/comp.h:16,
>  from /usr/include/openssl/ssl.h:47,
>  from SSLInternal.cc:33:
> /usr/include/openssl/ossl_typ.h:144:16: note: forward declaration of
> ‘SSL {aka struct ssl_st}’
>  typedef struct ssl_st SSL;
> ^~
> SSLInternal.cc:43:6: error: invalid use of incomplete type ‘SSL {aka
> struct ssl_st}’
>ssl->rbio = rbio;
>   ^~
> In file included from /usr/include/openssl/crypto.h:31:0,
>  from /usr/include/openssl/comp.h:16,
>  from /usr/include/openssl/ssl.h:47,
>  from SSLInternal.cc:33:
> /usr/include/openssl/ossl_typ.h:144:16: note: forward declaration of
> ‘SSL {aka struct ssl_st}’
>  typedef struct ssl_st SSL;
> ^~
> {code}
> The full configure log can be found here:
> https://gist.github.com/jbfavre/00f63362b435d8ffc682d42d29b671f2
> According to https://wiki.openssl.org/index.php/1.1_API_Changes :
> > setting SSL->rbio without setting SSL->wbio. New function introduction
> in 1.1.0 to handle this: SSL_set_rbio()".
> Problem is, rbio doesn't seems to be nicely detected at configure stage:
> {code}checking for SSL_set_rbio... no
> checking whether to enable set rbio... no{code}
> Binding ATS to OpenSSL 1.0 still works.
> Regards,
> Jean Baptiste Favre



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Work logged] (TS-5022) Multiple Client Certificate to Origin

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-5022?focusedWorklogId=34807=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-34807
 ]

ASF GitHub Bot logged work on TS-5022:
--

Author: ASF GitHub Bot
Created on: 05/Jan/17 17:43
Start Date: 05/Jan/17 17:43
Worklog Time Spent: 10m 
  Work Description: Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1226
  
Linux build *successful*! See 
https://ci.trafficserver.apache.org/job/Github-Linux/1198/ for details.
 



Issue Time Tracking
---

Worklog Id: (was: 34807)
Time Spent: 3h 10m  (was: 3h)

> Multiple Client Certificate to Origin
> -
>
> Key: TS-5022
> URL: https://issues.apache.org/jira/browse/TS-5022
> Project: Traffic Server
>  Issue Type: Improvement
>  Components: Security, SSL, TLS
>Reporter: Scott Beardsley
>Assignee: Syeda Persia Aziz
>  Labels: yahoo
> Fix For: 7.1.0
>
>  Time Spent: 3h 10m
>  Remaining Estimate: 0h
>
> Yahoo has a use case where the origin is doing mutual TLS authentication 
> which requires ATS to send a client certificate. This works fine (for now) 
> because ATS supports configuring *one* client cert but this feature should 
> really allow multiple client certificates to be configured which would depend 
> upon the origin being contacted.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Work logged] (TS-5022) Multiple Client Certificate to Origin

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-5022?focusedWorklogId=34806=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-34806
 ]

ASF GitHub Bot logged work on TS-5022:
--

Author: ASF GitHub Bot
Created on: 05/Jan/17 17:40
Start Date: 05/Jan/17 17:40
Worklog Time Spent: 10m 
  Work Description: Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1226
  
FreeBSD build *successful*! See 
https://ci.trafficserver.apache.org/job/Github-FreeBSD/1304/ for details.
 



Issue Time Tracking
---

Worklog Id: (was: 34806)
Time Spent: 3h  (was: 2h 50m)

> Multiple Client Certificate to Origin
> -
>
> Key: TS-5022
> URL: https://issues.apache.org/jira/browse/TS-5022
> Project: Traffic Server
>  Issue Type: Improvement
>  Components: Security, SSL, TLS
>Reporter: Scott Beardsley
>Assignee: Syeda Persia Aziz
>  Labels: yahoo
> Fix For: 7.1.0
>
>  Time Spent: 3h
>  Remaining Estimate: 0h
>
> Yahoo has a use case where the origin is doing mutual TLS authentication 
> which requires ATS to send a client certificate. This works fine (for now) 
> because ATS supports configuring *one* client cert but this feature should 
> really allow multiple client certificates to be configured which would depend 
> upon the origin being contacted.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Work logged] (TS-5022) Multiple Client Certificate to Origin

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-5022?focusedWorklogId=34805=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-34805
 ]

ASF GitHub Bot logged work on TS-5022:
--

Author: ASF GitHub Bot
Created on: 05/Jan/17 17:24
Start Date: 05/Jan/17 17:24
Worklog Time Spent: 10m 
  Work Description: Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1226
  
Linux build *successful*! See 
https://ci.trafficserver.apache.org/job/Github-Linux/1197/ for details.
 



Issue Time Tracking
---

Worklog Id: (was: 34805)
Time Spent: 2h 50m  (was: 2h 40m)

> Multiple Client Certificate to Origin
> -
>
> Key: TS-5022
> URL: https://issues.apache.org/jira/browse/TS-5022
> Project: Traffic Server
>  Issue Type: Improvement
>  Components: Security, SSL, TLS
>Reporter: Scott Beardsley
>Assignee: Syeda Persia Aziz
>  Labels: yahoo
> Fix For: 7.1.0
>
>  Time Spent: 2h 50m
>  Remaining Estimate: 0h
>
> Yahoo has a use case where the origin is doing mutual TLS authentication 
> which requires ATS to send a client certificate. This works fine (for now) 
> because ATS supports configuring *one* client cert but this feature should 
> really allow multiple client certificates to be configured which would depend 
> upon the origin being contacted.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Work logged] (TS-5022) Multiple Client Certificate to Origin

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-5022?focusedWorklogId=34804=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-34804
 ]

ASF GitHub Bot logged work on TS-5022:
--

Author: ASF GitHub Bot
Created on: 05/Jan/17 17:23
Start Date: 05/Jan/17 17:23
Worklog Time Spent: 10m 
  Work Description: Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1226
  
FreeBSD build *successful*! See 
https://ci.trafficserver.apache.org/job/Github-FreeBSD/1303/ for details.
 



Issue Time Tracking
---

Worklog Id: (was: 34804)
Time Spent: 2h 40m  (was: 2.5h)

> Multiple Client Certificate to Origin
> -
>
> Key: TS-5022
> URL: https://issues.apache.org/jira/browse/TS-5022
> Project: Traffic Server
>  Issue Type: Improvement
>  Components: Security, SSL, TLS
>Reporter: Scott Beardsley
>Assignee: Syeda Persia Aziz
>  Labels: yahoo
> Fix For: 7.1.0
>
>  Time Spent: 2h 40m
>  Remaining Estimate: 0h
>
> Yahoo has a use case where the origin is doing mutual TLS authentication 
> which requires ATS to send a client certificate. This works fine (for now) 
> because ATS supports configuring *one* client cert but this feature should 
> really allow multiple client certificates to be configured which would depend 
> upon the origin being contacted.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Work logged] (TS-5022) Multiple Client Certificate to Origin

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-5022?focusedWorklogId=34803=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-34803
 ]

ASF GitHub Bot logged work on TS-5022:
--

Author: ASF GitHub Bot
Created on: 05/Jan/17 17:10
Start Date: 05/Jan/17 17:10
Worklog Time Spent: 10m 
  Work Description: Github user persiaAziz commented on the issue:

https://github.com/apache/trafficserver/pull/1226
  
Please review @shinrich . The map containing client ctxs have been moved to 
sslconfig


Issue Time Tracking
---

Worklog Id: (was: 34803)
Time Spent: 2.5h  (was: 2h 20m)

> Multiple Client Certificate to Origin
> -
>
> Key: TS-5022
> URL: https://issues.apache.org/jira/browse/TS-5022
> Project: Traffic Server
>  Issue Type: Improvement
>  Components: Security, SSL, TLS
>Reporter: Scott Beardsley
>Assignee: Syeda Persia Aziz
>  Labels: yahoo
> Fix For: 7.1.0
>
>  Time Spent: 2.5h
>  Remaining Estimate: 0h
>
> Yahoo has a use case where the origin is doing mutual TLS authentication 
> which requires ATS to send a client certificate. This works fine (for now) 
> because ATS supports configuring *one* client cert but this feature should 
> really allow multiple client certificates to be configured which would depend 
> upon the origin being contacted.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Work logged] (TS-5108) SSL requests might stall because enabled write is ignored

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-5108?focusedWorklogId=34788=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-34788
 ]

ASF GitHub Bot logged work on TS-5108:
--

Author: ASF GitHub Bot
Created on: 05/Jan/17 14:28
Start Date: 05/Jan/17 14:28
Worklog Time Spent: 10m 
  Work Description: Github user oschaaf closed the pull request at:

https://github.com/apache/trafficserver/pull/1300


Issue Time Tracking
---

Worklog Id: (was: 34788)
Time Spent: 1h 10m  (was: 1h)

> SSL requests might stall because enabled write is ignored
> -
>
> Key: TS-5108
> URL: https://issues.apache.org/jira/browse/TS-5108
> Project: Traffic Server
>  Issue Type: Bug
>  Components: SSL
>Reporter: Kees Spoelstra
>  Time Spent: 1h 10m
>  Remaining Estimate: 0h
>
> In non-debug mode an enabled write is ignored resulting in a stalled request. 
> In debug mode the writeReschedule is fired.
> A fix is to move the conditional writeReschedule  out of the conditional 
> debug code.
> Addendum to:
> https://issues.apache.org/jira/browse/TS-2815
> https://github.com/apache/trafficserver/commit/f3a3edb048fc5f96163d1c4a26c1523383786f5d
> For more context:
> https://github.com/apache/trafficserver/blob/6.2.0/iocore/net/SSLNetVConnection.cc#L1279



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Work logged] (TS-5059) ATS 7.0.0 build fails with OpenSSL 1.1.0c

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-5059?focusedWorklogId=34767=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-34767
 ]

ASF GitHub Bot logged work on TS-5059:
--

Author: ASF GitHub Bot
Created on: 05/Jan/17 05:54
Start Date: 05/Jan/17 05:54
Worklog Time Spent: 10m 
  Work Description: Github user jpeach commented on a diff in the pull 
request:

https://github.com/apache/trafficserver/pull/1294#discussion_r94717030
  
--- Diff: iocore/net/BIO_fastopen.cc ---
@@ -58,26 +57,26 @@ fastopen_bwrite(BIO *bio, const char *in, int insz)
 
   errno = 0;
   BIO_clear_retry_flags(bio);
-  ink_assert(bio->num != NO_FD);
+  ink_assert(BIO_get_fd(bio, nullptr) != NO_FD);
--- End diff --

Rather than calling `BIO_get_fd` multiple times, call it once and stash the 
fd in a local variable. Same for the write path.


Issue Time Tracking
---

Worklog Id: (was: 34767)
Time Spent: 6h 50m  (was: 6h 40m)

> ATS 7.0.0 build fails with OpenSSL 1.1.0c
> -
>
> Key: TS-5059
> URL: https://issues.apache.org/jira/browse/TS-5059
> Project: Traffic Server
>  Issue Type: Bug
>  Components: SSL, TLS
>Reporter: Jean Baptiste Favre
> Fix For: 7.1.0
>
>  Time Spent: 6h 50m
>  Remaining Estimate: 0h
>
> ATS 7.0.0 build currently fails with following error:
> {code}SSLInternal.cc: In function ‘void SSL_set_rbio(SSL*, BIO*)’:
> SSLInternal.cc:40:10: error: invalid use of incomplete type ‘SSL {aka
> struct ssl_st}’
>if (ssl->rbio != NULL) {
>   ^~
> In file included from /usr/include/openssl/crypto.h:31:0,
>  from /usr/include/openssl/comp.h:16,
>  from /usr/include/openssl/ssl.h:47,
>  from SSLInternal.cc:33:
> /usr/include/openssl/ossl_typ.h:144:16: note: forward declaration of
> ‘SSL {aka struct ssl_st}’
>  typedef struct ssl_st SSL;
> ^~
> SSLInternal.cc:41:17: error: invalid use of incomplete type ‘SSL {aka
> struct ssl_st}’
>  BIO_free(ssl->rbio);
>  ^~
> In file included from /usr/include/openssl/crypto.h:31:0,
>  from /usr/include/openssl/comp.h:16,
>  from /usr/include/openssl/ssl.h:47,
>  from SSLInternal.cc:33:
> /usr/include/openssl/ossl_typ.h:144:16: note: forward declaration of
> ‘SSL {aka struct ssl_st}’
>  typedef struct ssl_st SSL;
> ^~
> SSLInternal.cc:43:6: error: invalid use of incomplete type ‘SSL {aka
> struct ssl_st}’
>ssl->rbio = rbio;
>   ^~
> In file included from /usr/include/openssl/crypto.h:31:0,
>  from /usr/include/openssl/comp.h:16,
>  from /usr/include/openssl/ssl.h:47,
>  from SSLInternal.cc:33:
> /usr/include/openssl/ossl_typ.h:144:16: note: forward declaration of
> ‘SSL {aka struct ssl_st}’
>  typedef struct ssl_st SSL;
> ^~
> {code}
> The full configure log can be found here:
> https://gist.github.com/jbfavre/00f63362b435d8ffc682d42d29b671f2
> According to https://wiki.openssl.org/index.php/1.1_API_Changes :
> > setting SSL->rbio without setting SSL->wbio. New function introduction
> in 1.1.0 to handle this: SSL_set_rbio()".
> Problem is, rbio doesn't seems to be nicely detected at configure stage:
> {code}checking for SSL_set_rbio... no
> checking whether to enable set rbio... no{code}
> Binding ATS to OpenSSL 1.0 still works.
> Regards,
> Jean Baptiste Favre



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Work logged] (TS-5059) ATS 7.0.0 build fails with OpenSSL 1.1.0c

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-5059?focusedWorklogId=34765=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-34765
 ]

ASF GitHub Bot logged work on TS-5059:
--

Author: ASF GitHub Bot
Created on: 05/Jan/17 05:54
Start Date: 05/Jan/17 05:54
Worklog Time Spent: 10m 
  Work Description: Github user jpeach commented on a diff in the pull 
request:

https://github.com/apache/trafficserver/pull/1294#discussion_r94717201
  
--- Diff: iocore/net/BIO_fastopen.cc ---
@@ -27,28 +27,27 @@
 
 #include "BIO_fastopen.h"
 
-static int
-fastopen_create(BIO *bio)
-{
-  bio->init  = 0;
-  bio->num   = NO_FD;
-  bio->flags = 0;
-  bio->ptr   = nullptr;
+#if OPENSSL_VERSION_NUMBER < 0x1010L
+#define BIO_set_data(a, _ptr) ((a)->ptr = (_ptr))
+#define BIO_get_data(a) ((a)->ptr)
+#define BIO_get_shutdown(a) ((a)->shutdown)
+#define BIO_meth_get_ctrl(biom) ((biom)->ctrl)
+#define BIO_meth_get_create(biom) ((biom)->create)
+#define BIO_meth_get_destroy(biom) ((biom)->destroy)
+#endif
 
-  return 1;
-}
+static int (*fastopen_create)(BIO *) = 
BIO_meth_get_create(const_cast(BIO_s_socket()));
 
 static int
 fastopen_destroy(BIO *bio)
 {
   if (bio) {
 // We expect this BIO to not own the socket, so we must always
 // be in NOCLOSE mode.
-ink_assert(bio->shutdown == BIO_NOCLOSE);
-fastopen_create(bio);
+ink_assert(BIO_get_shutdown(bio) == BIO_NOCLOSE);
   }
 
-  return 1;
+  return BIO_meth_get_destroy(const_cast(BIO_s_socket()))(bio);
--- End diff --

Seems pretty unfortunate that they make you cast away the const here :(


Issue Time Tracking
---

Worklog Id: (was: 34765)
Time Spent: 6h 50m  (was: 6h 40m)

> ATS 7.0.0 build fails with OpenSSL 1.1.0c
> -
>
> Key: TS-5059
> URL: https://issues.apache.org/jira/browse/TS-5059
> Project: Traffic Server
>  Issue Type: Bug
>  Components: SSL, TLS
>Reporter: Jean Baptiste Favre
> Fix For: 7.1.0
>
>  Time Spent: 6h 50m
>  Remaining Estimate: 0h
>
> ATS 7.0.0 build currently fails with following error:
> {code}SSLInternal.cc: In function ‘void SSL_set_rbio(SSL*, BIO*)’:
> SSLInternal.cc:40:10: error: invalid use of incomplete type ‘SSL {aka
> struct ssl_st}’
>if (ssl->rbio != NULL) {
>   ^~
> In file included from /usr/include/openssl/crypto.h:31:0,
>  from /usr/include/openssl/comp.h:16,
>  from /usr/include/openssl/ssl.h:47,
>  from SSLInternal.cc:33:
> /usr/include/openssl/ossl_typ.h:144:16: note: forward declaration of
> ‘SSL {aka struct ssl_st}’
>  typedef struct ssl_st SSL;
> ^~
> SSLInternal.cc:41:17: error: invalid use of incomplete type ‘SSL {aka
> struct ssl_st}’
>  BIO_free(ssl->rbio);
>  ^~
> In file included from /usr/include/openssl/crypto.h:31:0,
>  from /usr/include/openssl/comp.h:16,
>  from /usr/include/openssl/ssl.h:47,
>  from SSLInternal.cc:33:
> /usr/include/openssl/ossl_typ.h:144:16: note: forward declaration of
> ‘SSL {aka struct ssl_st}’
>  typedef struct ssl_st SSL;
> ^~
> SSLInternal.cc:43:6: error: invalid use of incomplete type ‘SSL {aka
> struct ssl_st}’
>ssl->rbio = rbio;
>   ^~
> In file included from /usr/include/openssl/crypto.h:31:0,
>  from /usr/include/openssl/comp.h:16,
>  from /usr/include/openssl/ssl.h:47,
>  from SSLInternal.cc:33:
> /usr/include/openssl/ossl_typ.h:144:16: note: forward declaration of
> ‘SSL {aka struct ssl_st}’
>  typedef struct ssl_st SSL;
> ^~
> {code}
> The full configure log can be found here:
> https://gist.github.com/jbfavre/00f63362b435d8ffc682d42d29b671f2
> According to https://wiki.openssl.org/index.php/1.1_API_Changes :
> > setting SSL->rbio without setting SSL->wbio. New function introduction
> in 1.1.0 to handle this: SSL_set_rbio()".
> Problem is, rbio doesn't seems to be nicely detected at configure stage:
> {code}checking for SSL_set_rbio... no
> checking whether to enable set rbio... no{code}
> Binding ATS to OpenSSL 1.0 still works.
> Regards,
> Jean Baptiste Favre



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Work logged] (TS-5059) ATS 7.0.0 build fails with OpenSSL 1.1.0c

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-5059?focusedWorklogId=34766=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-34766
 ]

ASF GitHub Bot logged work on TS-5059:
--

Author: ASF GitHub Bot
Created on: 05/Jan/17 05:54
Start Date: 05/Jan/17 05:54
Worklog Time Spent: 10m 
  Work Description: Github user jpeach commented on a diff in the pull 
request:

https://github.com/apache/trafficserver/pull/1294#discussion_r94717094
  
--- Diff: iocore/net/BIO_fastopen.cc ---
@@ -116,39 +115,21 @@ static long
 fastopen_ctrl(BIO *bio, int cmd, long larg, void *ptr)
 {
   switch (cmd) {
-  case BIO_C_SET_FD:
-ink_assert(larg == BIO_CLOSE || larg == BIO_NOCLOSE);
-ink_assert(bio->num == NO_FD);
-
-bio->init = 1;
-bio->shutdown = larg;
-bio->num  = *reinterpret_cast(ptr);
-return 0;
-
   case BIO_C_SET_CONNECT:
 // We only support BIO_set_conn_address(), which sets a sockaddr.
 ink_assert(larg == 2);
-bio->ptr = ptr;
+BIO_set_data(bio, ptr);
 return 0;
 
-  // We are unbuffered so unconditionally succeed on BIO_flush().
-  case BIO_CTRL_FLUSH:
-return 1;
-
-  case BIO_CTRL_PUSH:
-  case BIO_CTRL_POP:
-return 0;
-
-  default:
-#if DEBUG
-ink_abort("unsupported BIO control cmd=%d larg=%ld ptr=%p", cmd, larg, 
ptr);
-#endif
-
-return 0;
+  case BIO_C_SET_FD:
+ink_assert(larg == BIO_CLOSE || larg == BIO_NOCLOSE);
+ink_assert(BIO_get_fd(bio, nullptr) == NO_FD);
--- End diff --

I don't think you need to worry about keeping this any more.


Issue Time Tracking
---

Worklog Id: (was: 34766)
Time Spent: 6h 50m  (was: 6h 40m)

> ATS 7.0.0 build fails with OpenSSL 1.1.0c
> -
>
> Key: TS-5059
> URL: https://issues.apache.org/jira/browse/TS-5059
> Project: Traffic Server
>  Issue Type: Bug
>  Components: SSL, TLS
>Reporter: Jean Baptiste Favre
> Fix For: 7.1.0
>
>  Time Spent: 6h 50m
>  Remaining Estimate: 0h
>
> ATS 7.0.0 build currently fails with following error:
> {code}SSLInternal.cc: In function ‘void SSL_set_rbio(SSL*, BIO*)’:
> SSLInternal.cc:40:10: error: invalid use of incomplete type ‘SSL {aka
> struct ssl_st}’
>if (ssl->rbio != NULL) {
>   ^~
> In file included from /usr/include/openssl/crypto.h:31:0,
>  from /usr/include/openssl/comp.h:16,
>  from /usr/include/openssl/ssl.h:47,
>  from SSLInternal.cc:33:
> /usr/include/openssl/ossl_typ.h:144:16: note: forward declaration of
> ‘SSL {aka struct ssl_st}’
>  typedef struct ssl_st SSL;
> ^~
> SSLInternal.cc:41:17: error: invalid use of incomplete type ‘SSL {aka
> struct ssl_st}’
>  BIO_free(ssl->rbio);
>  ^~
> In file included from /usr/include/openssl/crypto.h:31:0,
>  from /usr/include/openssl/comp.h:16,
>  from /usr/include/openssl/ssl.h:47,
>  from SSLInternal.cc:33:
> /usr/include/openssl/ossl_typ.h:144:16: note: forward declaration of
> ‘SSL {aka struct ssl_st}’
>  typedef struct ssl_st SSL;
> ^~
> SSLInternal.cc:43:6: error: invalid use of incomplete type ‘SSL {aka
> struct ssl_st}’
>ssl->rbio = rbio;
>   ^~
> In file included from /usr/include/openssl/crypto.h:31:0,
>  from /usr/include/openssl/comp.h:16,
>  from /usr/include/openssl/ssl.h:47,
>  from SSLInternal.cc:33:
> /usr/include/openssl/ossl_typ.h:144:16: note: forward declaration of
> ‘SSL {aka struct ssl_st}’
>  typedef struct ssl_st SSL;
> ^~
> {code}
> The full configure log can be found here:
> https://gist.github.com/jbfavre/00f63362b435d8ffc682d42d29b671f2
> According to https://wiki.openssl.org/index.php/1.1_API_Changes :
> > setting SSL->rbio without setting SSL->wbio. New function introduction
> in 1.1.0 to handle this: SSL_set_rbio()".
> Problem is, rbio doesn't seems to be nicely detected at configure stage:
> {code}checking for SSL_set_rbio... no
> checking whether to enable set rbio... no{code}
> Binding ATS to OpenSSL 1.0 still works.
> Regards,
> Jean Baptiste Favre



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Work logged] (TS-5059) ATS 7.0.0 build fails with OpenSSL 1.1.0c

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-5059?focusedWorklogId=34744=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-34744
 ]

ASF GitHub Bot logged work on TS-5059:
--

Author: ASF GitHub Bot
Created on: 04/Jan/17 23:58
Start Date: 04/Jan/17 23:58
Worklog Time Spent: 10m 
  Work Description: Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1294
  
Linux build *successful*! See 
https://ci.trafficserver.apache.org/job/Github-Linux/1196/ for details.
 



Issue Time Tracking
---

Worklog Id: (was: 34744)
Time Spent: 6h 40m  (was: 6.5h)

> ATS 7.0.0 build fails with OpenSSL 1.1.0c
> -
>
> Key: TS-5059
> URL: https://issues.apache.org/jira/browse/TS-5059
> Project: Traffic Server
>  Issue Type: Bug
>  Components: SSL, TLS
>Reporter: Jean Baptiste Favre
> Fix For: 7.1.0
>
>  Time Spent: 6h 40m
>  Remaining Estimate: 0h
>
> ATS 7.0.0 build currently fails with following error:
> {code}SSLInternal.cc: In function ‘void SSL_set_rbio(SSL*, BIO*)’:
> SSLInternal.cc:40:10: error: invalid use of incomplete type ‘SSL {aka
> struct ssl_st}’
>if (ssl->rbio != NULL) {
>   ^~
> In file included from /usr/include/openssl/crypto.h:31:0,
>  from /usr/include/openssl/comp.h:16,
>  from /usr/include/openssl/ssl.h:47,
>  from SSLInternal.cc:33:
> /usr/include/openssl/ossl_typ.h:144:16: note: forward declaration of
> ‘SSL {aka struct ssl_st}’
>  typedef struct ssl_st SSL;
> ^~
> SSLInternal.cc:41:17: error: invalid use of incomplete type ‘SSL {aka
> struct ssl_st}’
>  BIO_free(ssl->rbio);
>  ^~
> In file included from /usr/include/openssl/crypto.h:31:0,
>  from /usr/include/openssl/comp.h:16,
>  from /usr/include/openssl/ssl.h:47,
>  from SSLInternal.cc:33:
> /usr/include/openssl/ossl_typ.h:144:16: note: forward declaration of
> ‘SSL {aka struct ssl_st}’
>  typedef struct ssl_st SSL;
> ^~
> SSLInternal.cc:43:6: error: invalid use of incomplete type ‘SSL {aka
> struct ssl_st}’
>ssl->rbio = rbio;
>   ^~
> In file included from /usr/include/openssl/crypto.h:31:0,
>  from /usr/include/openssl/comp.h:16,
>  from /usr/include/openssl/ssl.h:47,
>  from SSLInternal.cc:33:
> /usr/include/openssl/ossl_typ.h:144:16: note: forward declaration of
> ‘SSL {aka struct ssl_st}’
>  typedef struct ssl_st SSL;
> ^~
> {code}
> The full configure log can be found here:
> https://gist.github.com/jbfavre/00f63362b435d8ffc682d42d29b671f2
> According to https://wiki.openssl.org/index.php/1.1_API_Changes :
> > setting SSL->rbio without setting SSL->wbio. New function introduction
> in 1.1.0 to handle this: SSL_set_rbio()".
> Problem is, rbio doesn't seems to be nicely detected at configure stage:
> {code}checking for SSL_set_rbio... no
> checking whether to enable set rbio... no{code}
> Binding ATS to OpenSSL 1.0 still works.
> Regards,
> Jean Baptiste Favre



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Work logged] (TS-5059) ATS 7.0.0 build fails with OpenSSL 1.1.0c

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-5059?focusedWorklogId=34743=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-34743
 ]

ASF GitHub Bot logged work on TS-5059:
--

Author: ASF GitHub Bot
Created on: 04/Jan/17 23:55
Start Date: 04/Jan/17 23:55
Worklog Time Spent: 10m 
  Work Description: Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1294
  
FreeBSD build *successful*! See 
https://ci.trafficserver.apache.org/job/Github-FreeBSD/1302/ for details.
 



Issue Time Tracking
---

Worklog Id: (was: 34743)
Time Spent: 6.5h  (was: 6h 20m)

> ATS 7.0.0 build fails with OpenSSL 1.1.0c
> -
>
> Key: TS-5059
> URL: https://issues.apache.org/jira/browse/TS-5059
> Project: Traffic Server
>  Issue Type: Bug
>  Components: SSL, TLS
>Reporter: Jean Baptiste Favre
> Fix For: 7.1.0
>
>  Time Spent: 6.5h
>  Remaining Estimate: 0h
>
> ATS 7.0.0 build currently fails with following error:
> {code}SSLInternal.cc: In function ‘void SSL_set_rbio(SSL*, BIO*)’:
> SSLInternal.cc:40:10: error: invalid use of incomplete type ‘SSL {aka
> struct ssl_st}’
>if (ssl->rbio != NULL) {
>   ^~
> In file included from /usr/include/openssl/crypto.h:31:0,
>  from /usr/include/openssl/comp.h:16,
>  from /usr/include/openssl/ssl.h:47,
>  from SSLInternal.cc:33:
> /usr/include/openssl/ossl_typ.h:144:16: note: forward declaration of
> ‘SSL {aka struct ssl_st}’
>  typedef struct ssl_st SSL;
> ^~
> SSLInternal.cc:41:17: error: invalid use of incomplete type ‘SSL {aka
> struct ssl_st}’
>  BIO_free(ssl->rbio);
>  ^~
> In file included from /usr/include/openssl/crypto.h:31:0,
>  from /usr/include/openssl/comp.h:16,
>  from /usr/include/openssl/ssl.h:47,
>  from SSLInternal.cc:33:
> /usr/include/openssl/ossl_typ.h:144:16: note: forward declaration of
> ‘SSL {aka struct ssl_st}’
>  typedef struct ssl_st SSL;
> ^~
> SSLInternal.cc:43:6: error: invalid use of incomplete type ‘SSL {aka
> struct ssl_st}’
>ssl->rbio = rbio;
>   ^~
> In file included from /usr/include/openssl/crypto.h:31:0,
>  from /usr/include/openssl/comp.h:16,
>  from /usr/include/openssl/ssl.h:47,
>  from SSLInternal.cc:33:
> /usr/include/openssl/ossl_typ.h:144:16: note: forward declaration of
> ‘SSL {aka struct ssl_st}’
>  typedef struct ssl_st SSL;
> ^~
> {code}
> The full configure log can be found here:
> https://gist.github.com/jbfavre/00f63362b435d8ffc682d42d29b671f2
> According to https://wiki.openssl.org/index.php/1.1_API_Changes :
> > setting SSL->rbio without setting SSL->wbio. New function introduction
> in 1.1.0 to handle this: SSL_set_rbio()".
> Problem is, rbio doesn't seems to be nicely detected at configure stage:
> {code}checking for SSL_set_rbio... no
> checking whether to enable set rbio... no{code}
> Binding ATS to OpenSSL 1.0 still works.
> Regards,
> Jean Baptiste Favre



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Work logged] (TS-5059) ATS 7.0.0 build fails with OpenSSL 1.1.0c

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-5059?focusedWorklogId=34742=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-34742
 ]

ASF GitHub Bot logged work on TS-5059:
--

Author: ASF GitHub Bot
Created on: 04/Jan/17 23:43
Start Date: 04/Jan/17 23:43
Worklog Time Spent: 10m 
  Work Description: Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1294
  
Linux build *failed*! See 
https://ci.trafficserver.apache.org/job/Github-Linux/1195/ for details.
 



Issue Time Tracking
---

Worklog Id: (was: 34742)
Time Spent: 6h 20m  (was: 6h 10m)

> ATS 7.0.0 build fails with OpenSSL 1.1.0c
> -
>
> Key: TS-5059
> URL: https://issues.apache.org/jira/browse/TS-5059
> Project: Traffic Server
>  Issue Type: Bug
>  Components: SSL, TLS
>Reporter: Jean Baptiste Favre
> Fix For: 7.1.0
>
>  Time Spent: 6h 20m
>  Remaining Estimate: 0h
>
> ATS 7.0.0 build currently fails with following error:
> {code}SSLInternal.cc: In function ‘void SSL_set_rbio(SSL*, BIO*)’:
> SSLInternal.cc:40:10: error: invalid use of incomplete type ‘SSL {aka
> struct ssl_st}’
>if (ssl->rbio != NULL) {
>   ^~
> In file included from /usr/include/openssl/crypto.h:31:0,
>  from /usr/include/openssl/comp.h:16,
>  from /usr/include/openssl/ssl.h:47,
>  from SSLInternal.cc:33:
> /usr/include/openssl/ossl_typ.h:144:16: note: forward declaration of
> ‘SSL {aka struct ssl_st}’
>  typedef struct ssl_st SSL;
> ^~
> SSLInternal.cc:41:17: error: invalid use of incomplete type ‘SSL {aka
> struct ssl_st}’
>  BIO_free(ssl->rbio);
>  ^~
> In file included from /usr/include/openssl/crypto.h:31:0,
>  from /usr/include/openssl/comp.h:16,
>  from /usr/include/openssl/ssl.h:47,
>  from SSLInternal.cc:33:
> /usr/include/openssl/ossl_typ.h:144:16: note: forward declaration of
> ‘SSL {aka struct ssl_st}’
>  typedef struct ssl_st SSL;
> ^~
> SSLInternal.cc:43:6: error: invalid use of incomplete type ‘SSL {aka
> struct ssl_st}’
>ssl->rbio = rbio;
>   ^~
> In file included from /usr/include/openssl/crypto.h:31:0,
>  from /usr/include/openssl/comp.h:16,
>  from /usr/include/openssl/ssl.h:47,
>  from SSLInternal.cc:33:
> /usr/include/openssl/ossl_typ.h:144:16: note: forward declaration of
> ‘SSL {aka struct ssl_st}’
>  typedef struct ssl_st SSL;
> ^~
> {code}
> The full configure log can be found here:
> https://gist.github.com/jbfavre/00f63362b435d8ffc682d42d29b671f2
> According to https://wiki.openssl.org/index.php/1.1_API_Changes :
> > setting SSL->rbio without setting SSL->wbio. New function introduction
> in 1.1.0 to handle this: SSL_set_rbio()".
> Problem is, rbio doesn't seems to be nicely detected at configure stage:
> {code}checking for SSL_set_rbio... no
> checking whether to enable set rbio... no{code}
> Binding ATS to OpenSSL 1.0 still works.
> Regards,
> Jean Baptiste Favre



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Work logged] (TS-5059) ATS 7.0.0 build fails with OpenSSL 1.1.0c

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-5059?focusedWorklogId=34741=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-34741
 ]

ASF GitHub Bot logged work on TS-5059:
--

Author: ASF GitHub Bot
Created on: 04/Jan/17 23:42
Start Date: 04/Jan/17 23:42
Worklog Time Spent: 10m 
  Work Description: Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1294
  
FreeBSD build *failed*! See 
https://ci.trafficserver.apache.org/job/Github-FreeBSD/1301/ for details.
 



Issue Time Tracking
---

Worklog Id: (was: 34741)
Time Spent: 6h 10m  (was: 6h)

> ATS 7.0.0 build fails with OpenSSL 1.1.0c
> -
>
> Key: TS-5059
> URL: https://issues.apache.org/jira/browse/TS-5059
> Project: Traffic Server
>  Issue Type: Bug
>  Components: SSL, TLS
>Reporter: Jean Baptiste Favre
> Fix For: 7.1.0
>
>  Time Spent: 6h 10m
>  Remaining Estimate: 0h
>
> ATS 7.0.0 build currently fails with following error:
> {code}SSLInternal.cc: In function ‘void SSL_set_rbio(SSL*, BIO*)’:
> SSLInternal.cc:40:10: error: invalid use of incomplete type ‘SSL {aka
> struct ssl_st}’
>if (ssl->rbio != NULL) {
>   ^~
> In file included from /usr/include/openssl/crypto.h:31:0,
>  from /usr/include/openssl/comp.h:16,
>  from /usr/include/openssl/ssl.h:47,
>  from SSLInternal.cc:33:
> /usr/include/openssl/ossl_typ.h:144:16: note: forward declaration of
> ‘SSL {aka struct ssl_st}’
>  typedef struct ssl_st SSL;
> ^~
> SSLInternal.cc:41:17: error: invalid use of incomplete type ‘SSL {aka
> struct ssl_st}’
>  BIO_free(ssl->rbio);
>  ^~
> In file included from /usr/include/openssl/crypto.h:31:0,
>  from /usr/include/openssl/comp.h:16,
>  from /usr/include/openssl/ssl.h:47,
>  from SSLInternal.cc:33:
> /usr/include/openssl/ossl_typ.h:144:16: note: forward declaration of
> ‘SSL {aka struct ssl_st}’
>  typedef struct ssl_st SSL;
> ^~
> SSLInternal.cc:43:6: error: invalid use of incomplete type ‘SSL {aka
> struct ssl_st}’
>ssl->rbio = rbio;
>   ^~
> In file included from /usr/include/openssl/crypto.h:31:0,
>  from /usr/include/openssl/comp.h:16,
>  from /usr/include/openssl/ssl.h:47,
>  from SSLInternal.cc:33:
> /usr/include/openssl/ossl_typ.h:144:16: note: forward declaration of
> ‘SSL {aka struct ssl_st}’
>  typedef struct ssl_st SSL;
> ^~
> {code}
> The full configure log can be found here:
> https://gist.github.com/jbfavre/00f63362b435d8ffc682d42d29b671f2
> According to https://wiki.openssl.org/index.php/1.1_API_Changes :
> > setting SSL->rbio without setting SSL->wbio. New function introduction
> in 1.1.0 to handle this: SSL_set_rbio()".
> Problem is, rbio doesn't seems to be nicely detected at configure stage:
> {code}checking for SSL_set_rbio... no
> checking whether to enable set rbio... no{code}
> Binding ATS to OpenSSL 1.0 still works.
> Regards,
> Jean Baptiste Favre



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Work logged] (TS-5059) ATS 7.0.0 build fails with OpenSSL 1.1.0c

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-5059?focusedWorklogId=34739=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-34739
 ]

ASF GitHub Bot logged work on TS-5059:
--

Author: ASF GitHub Bot
Created on: 04/Jan/17 23:37
Start Date: 04/Jan/17 23:37
Worklog Time Spent: 10m 
  Work Description: Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1294
  
FreeBSD build *failed*! See 
https://ci.trafficserver.apache.org/job/Github-FreeBSD/1300/ for details.
 



Issue Time Tracking
---

Worklog Id: (was: 34739)
Time Spent: 6h  (was: 5h 50m)

> ATS 7.0.0 build fails with OpenSSL 1.1.0c
> -
>
> Key: TS-5059
> URL: https://issues.apache.org/jira/browse/TS-5059
> Project: Traffic Server
>  Issue Type: Bug
>  Components: SSL, TLS
>Reporter: Jean Baptiste Favre
> Fix For: 7.1.0
>
>  Time Spent: 6h
>  Remaining Estimate: 0h
>
> ATS 7.0.0 build currently fails with following error:
> {code}SSLInternal.cc: In function ‘void SSL_set_rbio(SSL*, BIO*)’:
> SSLInternal.cc:40:10: error: invalid use of incomplete type ‘SSL {aka
> struct ssl_st}’
>if (ssl->rbio != NULL) {
>   ^~
> In file included from /usr/include/openssl/crypto.h:31:0,
>  from /usr/include/openssl/comp.h:16,
>  from /usr/include/openssl/ssl.h:47,
>  from SSLInternal.cc:33:
> /usr/include/openssl/ossl_typ.h:144:16: note: forward declaration of
> ‘SSL {aka struct ssl_st}’
>  typedef struct ssl_st SSL;
> ^~
> SSLInternal.cc:41:17: error: invalid use of incomplete type ‘SSL {aka
> struct ssl_st}’
>  BIO_free(ssl->rbio);
>  ^~
> In file included from /usr/include/openssl/crypto.h:31:0,
>  from /usr/include/openssl/comp.h:16,
>  from /usr/include/openssl/ssl.h:47,
>  from SSLInternal.cc:33:
> /usr/include/openssl/ossl_typ.h:144:16: note: forward declaration of
> ‘SSL {aka struct ssl_st}’
>  typedef struct ssl_st SSL;
> ^~
> SSLInternal.cc:43:6: error: invalid use of incomplete type ‘SSL {aka
> struct ssl_st}’
>ssl->rbio = rbio;
>   ^~
> In file included from /usr/include/openssl/crypto.h:31:0,
>  from /usr/include/openssl/comp.h:16,
>  from /usr/include/openssl/ssl.h:47,
>  from SSLInternal.cc:33:
> /usr/include/openssl/ossl_typ.h:144:16: note: forward declaration of
> ‘SSL {aka struct ssl_st}’
>  typedef struct ssl_st SSL;
> ^~
> {code}
> The full configure log can be found here:
> https://gist.github.com/jbfavre/00f63362b435d8ffc682d42d29b671f2
> According to https://wiki.openssl.org/index.php/1.1_API_Changes :
> > setting SSL->rbio without setting SSL->wbio. New function introduction
> in 1.1.0 to handle this: SSL_set_rbio()".
> Problem is, rbio doesn't seems to be nicely detected at configure stage:
> {code}checking for SSL_set_rbio... no
> checking whether to enable set rbio... no{code}
> Binding ATS to OpenSSL 1.0 still works.
> Regards,
> Jean Baptiste Favre



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Work logged] (TS-5059) ATS 7.0.0 build fails with OpenSSL 1.1.0c

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-5059?focusedWorklogId=34738=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-34738
 ]

ASF GitHub Bot logged work on TS-5059:
--

Author: ASF GitHub Bot
Created on: 04/Jan/17 23:33
Start Date: 04/Jan/17 23:33
Worklog Time Spent: 10m 
  Work Description: Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1294
  
Linux build *failed*! See 
https://ci.trafficserver.apache.org/job/Github-Linux/1194/ for details.
 



Issue Time Tracking
---

Worklog Id: (was: 34738)
Time Spent: 5h 50m  (was: 5h 40m)

> ATS 7.0.0 build fails with OpenSSL 1.1.0c
> -
>
> Key: TS-5059
> URL: https://issues.apache.org/jira/browse/TS-5059
> Project: Traffic Server
>  Issue Type: Bug
>  Components: SSL, TLS
>Reporter: Jean Baptiste Favre
> Fix For: 7.1.0
>
>  Time Spent: 5h 50m
>  Remaining Estimate: 0h
>
> ATS 7.0.0 build currently fails with following error:
> {code}SSLInternal.cc: In function ‘void SSL_set_rbio(SSL*, BIO*)’:
> SSLInternal.cc:40:10: error: invalid use of incomplete type ‘SSL {aka
> struct ssl_st}’
>if (ssl->rbio != NULL) {
>   ^~
> In file included from /usr/include/openssl/crypto.h:31:0,
>  from /usr/include/openssl/comp.h:16,
>  from /usr/include/openssl/ssl.h:47,
>  from SSLInternal.cc:33:
> /usr/include/openssl/ossl_typ.h:144:16: note: forward declaration of
> ‘SSL {aka struct ssl_st}’
>  typedef struct ssl_st SSL;
> ^~
> SSLInternal.cc:41:17: error: invalid use of incomplete type ‘SSL {aka
> struct ssl_st}’
>  BIO_free(ssl->rbio);
>  ^~
> In file included from /usr/include/openssl/crypto.h:31:0,
>  from /usr/include/openssl/comp.h:16,
>  from /usr/include/openssl/ssl.h:47,
>  from SSLInternal.cc:33:
> /usr/include/openssl/ossl_typ.h:144:16: note: forward declaration of
> ‘SSL {aka struct ssl_st}’
>  typedef struct ssl_st SSL;
> ^~
> SSLInternal.cc:43:6: error: invalid use of incomplete type ‘SSL {aka
> struct ssl_st}’
>ssl->rbio = rbio;
>   ^~
> In file included from /usr/include/openssl/crypto.h:31:0,
>  from /usr/include/openssl/comp.h:16,
>  from /usr/include/openssl/ssl.h:47,
>  from SSLInternal.cc:33:
> /usr/include/openssl/ossl_typ.h:144:16: note: forward declaration of
> ‘SSL {aka struct ssl_st}’
>  typedef struct ssl_st SSL;
> ^~
> {code}
> The full configure log can be found here:
> https://gist.github.com/jbfavre/00f63362b435d8ffc682d42d29b671f2
> According to https://wiki.openssl.org/index.php/1.1_API_Changes :
> > setting SSL->rbio without setting SSL->wbio. New function introduction
> in 1.1.0 to handle this: SSL_set_rbio()".
> Problem is, rbio doesn't seems to be nicely detected at configure stage:
> {code}checking for SSL_set_rbio... no
> checking whether to enable set rbio... no{code}
> Binding ATS to OpenSSL 1.0 still works.
> Regards,
> Jean Baptiste Favre



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Work logged] (TS-5059) ATS 7.0.0 build fails with OpenSSL 1.1.0c

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-5059?focusedWorklogId=34736=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-34736
 ]

ASF GitHub Bot logged work on TS-5059:
--

Author: ASF GitHub Bot
Created on: 04/Jan/17 23:13
Start Date: 04/Jan/17 23:13
Worklog Time Spent: 10m 
  Work Description: Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1294
  
Linux build *failed*! See 
https://ci.trafficserver.apache.org/job/Github-Linux/1193/ for details.
 



Issue Time Tracking
---

Worklog Id: (was: 34736)
Time Spent: 5h 40m  (was: 5.5h)

> ATS 7.0.0 build fails with OpenSSL 1.1.0c
> -
>
> Key: TS-5059
> URL: https://issues.apache.org/jira/browse/TS-5059
> Project: Traffic Server
>  Issue Type: Bug
>  Components: SSL, TLS
>Reporter: Jean Baptiste Favre
> Fix For: 7.1.0
>
>  Time Spent: 5h 40m
>  Remaining Estimate: 0h
>
> ATS 7.0.0 build currently fails with following error:
> {code}SSLInternal.cc: In function ‘void SSL_set_rbio(SSL*, BIO*)’:
> SSLInternal.cc:40:10: error: invalid use of incomplete type ‘SSL {aka
> struct ssl_st}’
>if (ssl->rbio != NULL) {
>   ^~
> In file included from /usr/include/openssl/crypto.h:31:0,
>  from /usr/include/openssl/comp.h:16,
>  from /usr/include/openssl/ssl.h:47,
>  from SSLInternal.cc:33:
> /usr/include/openssl/ossl_typ.h:144:16: note: forward declaration of
> ‘SSL {aka struct ssl_st}’
>  typedef struct ssl_st SSL;
> ^~
> SSLInternal.cc:41:17: error: invalid use of incomplete type ‘SSL {aka
> struct ssl_st}’
>  BIO_free(ssl->rbio);
>  ^~
> In file included from /usr/include/openssl/crypto.h:31:0,
>  from /usr/include/openssl/comp.h:16,
>  from /usr/include/openssl/ssl.h:47,
>  from SSLInternal.cc:33:
> /usr/include/openssl/ossl_typ.h:144:16: note: forward declaration of
> ‘SSL {aka struct ssl_st}’
>  typedef struct ssl_st SSL;
> ^~
> SSLInternal.cc:43:6: error: invalid use of incomplete type ‘SSL {aka
> struct ssl_st}’
>ssl->rbio = rbio;
>   ^~
> In file included from /usr/include/openssl/crypto.h:31:0,
>  from /usr/include/openssl/comp.h:16,
>  from /usr/include/openssl/ssl.h:47,
>  from SSLInternal.cc:33:
> /usr/include/openssl/ossl_typ.h:144:16: note: forward declaration of
> ‘SSL {aka struct ssl_st}’
>  typedef struct ssl_st SSL;
> ^~
> {code}
> The full configure log can be found here:
> https://gist.github.com/jbfavre/00f63362b435d8ffc682d42d29b671f2
> According to https://wiki.openssl.org/index.php/1.1_API_Changes :
> > setting SSL->rbio without setting SSL->wbio. New function introduction
> in 1.1.0 to handle this: SSL_set_rbio()".
> Problem is, rbio doesn't seems to be nicely detected at configure stage:
> {code}checking for SSL_set_rbio... no
> checking whether to enable set rbio... no{code}
> Binding ATS to OpenSSL 1.0 still works.
> Regards,
> Jean Baptiste Favre



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Work logged] (TS-5059) ATS 7.0.0 build fails with OpenSSL 1.1.0c

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-5059?focusedWorklogId=34735=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-34735
 ]

ASF GitHub Bot logged work on TS-5059:
--

Author: ASF GitHub Bot
Created on: 04/Jan/17 23:12
Start Date: 04/Jan/17 23:12
Worklog Time Spent: 10m 
  Work Description: Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1294
  
FreeBSD build *failed*! See 
https://ci.trafficserver.apache.org/job/Github-FreeBSD/1299/ for details.
 



Issue Time Tracking
---

Worklog Id: (was: 34735)
Time Spent: 5.5h  (was: 5h 20m)

> ATS 7.0.0 build fails with OpenSSL 1.1.0c
> -
>
> Key: TS-5059
> URL: https://issues.apache.org/jira/browse/TS-5059
> Project: Traffic Server
>  Issue Type: Bug
>  Components: SSL, TLS
>Reporter: Jean Baptiste Favre
> Fix For: 7.1.0
>
>  Time Spent: 5.5h
>  Remaining Estimate: 0h
>
> ATS 7.0.0 build currently fails with following error:
> {code}SSLInternal.cc: In function ‘void SSL_set_rbio(SSL*, BIO*)’:
> SSLInternal.cc:40:10: error: invalid use of incomplete type ‘SSL {aka
> struct ssl_st}’
>if (ssl->rbio != NULL) {
>   ^~
> In file included from /usr/include/openssl/crypto.h:31:0,
>  from /usr/include/openssl/comp.h:16,
>  from /usr/include/openssl/ssl.h:47,
>  from SSLInternal.cc:33:
> /usr/include/openssl/ossl_typ.h:144:16: note: forward declaration of
> ‘SSL {aka struct ssl_st}’
>  typedef struct ssl_st SSL;
> ^~
> SSLInternal.cc:41:17: error: invalid use of incomplete type ‘SSL {aka
> struct ssl_st}’
>  BIO_free(ssl->rbio);
>  ^~
> In file included from /usr/include/openssl/crypto.h:31:0,
>  from /usr/include/openssl/comp.h:16,
>  from /usr/include/openssl/ssl.h:47,
>  from SSLInternal.cc:33:
> /usr/include/openssl/ossl_typ.h:144:16: note: forward declaration of
> ‘SSL {aka struct ssl_st}’
>  typedef struct ssl_st SSL;
> ^~
> SSLInternal.cc:43:6: error: invalid use of incomplete type ‘SSL {aka
> struct ssl_st}’
>ssl->rbio = rbio;
>   ^~
> In file included from /usr/include/openssl/crypto.h:31:0,
>  from /usr/include/openssl/comp.h:16,
>  from /usr/include/openssl/ssl.h:47,
>  from SSLInternal.cc:33:
> /usr/include/openssl/ossl_typ.h:144:16: note: forward declaration of
> ‘SSL {aka struct ssl_st}’
>  typedef struct ssl_st SSL;
> ^~
> {code}
> The full configure log can be found here:
> https://gist.github.com/jbfavre/00f63362b435d8ffc682d42d29b671f2
> According to https://wiki.openssl.org/index.php/1.1_API_Changes :
> > setting SSL->rbio without setting SSL->wbio. New function introduction
> in 1.1.0 to handle this: SSL_set_rbio()".
> Problem is, rbio doesn't seems to be nicely detected at configure stage:
> {code}checking for SSL_set_rbio... no
> checking whether to enable set rbio... no{code}
> Binding ATS to OpenSSL 1.0 still works.
> Regards,
> Jean Baptiste Favre



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Work logged] (TS-5084) Make logcat follow file rotation

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-5084?focusedWorklogId=34734=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-34734
 ]

ASF GitHub Bot logged work on TS-5084:
--

Author: ASF GitHub Bot
Created on: 04/Jan/17 22:58
Start Date: 04/Jan/17 22:58
Worklog Time Spent: 10m 
  Work Description: Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1253
  
Linux build *successful*! See 
https://ci.trafficserver.apache.org/job/Github-Linux/1192/ for details.
 



Issue Time Tracking
---

Worklog Id: (was: 34734)
Time Spent: 1.5h  (was: 1h 20m)

> Make logcat follow file rotation
> 
>
> Key: TS-5084
> URL: https://issues.apache.org/jira/browse/TS-5084
> Project: Traffic Server
>  Issue Type: Improvement
>  Components: Logging
>Reporter: Daniel Xu
>Assignee: Daniel Xu
> Fix For: 7.1.0
>
>  Time Spent: 1.5h
>  Remaining Estimate: 0h
>
> The {{traffic_logcat}} tool does not follow {{squid.blog}} if it is rotated. 
> This is still occurring even when {{traffic_logcat}} is run with {{-f}} It 
> would be nice if the tool would follow the log.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Work logged] (TS-5084) Make logcat follow file rotation

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-5084?focusedWorklogId=34733=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-34733
 ]

ASF GitHub Bot logged work on TS-5084:
--

Author: ASF GitHub Bot
Created on: 04/Jan/17 22:58
Start Date: 04/Jan/17 22:58
Worklog Time Spent: 10m 
  Work Description: Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1253
  
FreeBSD build *successful*! See 
https://ci.trafficserver.apache.org/job/Github-FreeBSD/1298/ for details.
 



Issue Time Tracking
---

Worklog Id: (was: 34733)
Time Spent: 1h 20m  (was: 1h 10m)

> Make logcat follow file rotation
> 
>
> Key: TS-5084
> URL: https://issues.apache.org/jira/browse/TS-5084
> Project: Traffic Server
>  Issue Type: Improvement
>  Components: Logging
>Reporter: Daniel Xu
>Assignee: Daniel Xu
> Fix For: 7.1.0
>
>  Time Spent: 1h 20m
>  Remaining Estimate: 0h
>
> The {{traffic_logcat}} tool does not follow {{squid.blog}} if it is rotated. 
> This is still occurring even when {{traffic_logcat}} is run with {{-f}} It 
> would be nice if the tool would follow the log.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Work logged] (TS-5084) Make logcat follow file rotation

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-5084?focusedWorklogId=34732=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-34732
 ]

ASF GitHub Bot logged work on TS-5084:
--

Author: ASF GitHub Bot
Created on: 04/Jan/17 22:47
Start Date: 04/Jan/17 22:47
Worklog Time Spent: 10m 
  Work Description: Github user danobi commented on the issue:

https://github.com/apache/trafficserver/pull/1253
  
@shinrich Done


Issue Time Tracking
---

Worklog Id: (was: 34732)
Time Spent: 1h 10m  (was: 1h)

> Make logcat follow file rotation
> 
>
> Key: TS-5084
> URL: https://issues.apache.org/jira/browse/TS-5084
> Project: Traffic Server
>  Issue Type: Improvement
>  Components: Logging
>Reporter: Daniel Xu
>Assignee: Daniel Xu
> Fix For: 7.1.0
>
>  Time Spent: 1h 10m
>  Remaining Estimate: 0h
>
> The {{traffic_logcat}} tool does not follow {{squid.blog}} if it is rotated. 
> This is still occurring even when {{traffic_logcat}} is run with {{-f}} It 
> would be nice if the tool would follow the log.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Work logged] (TS-5059) ATS 7.0.0 build fails with OpenSSL 1.1.0c

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-5059?focusedWorklogId=34712=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-34712
 ]

ASF GitHub Bot logged work on TS-5059:
--

Author: ASF GitHub Bot
Created on: 04/Jan/17 22:13
Start Date: 04/Jan/17 22:13
Worklog Time Spent: 10m 
  Work Description: Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1294
  
Linux build *failed*! See 
https://ci.trafficserver.apache.org/job/Github-Linux/1191/ for details.
 



Issue Time Tracking
---

Worklog Id: (was: 34712)
Time Spent: 5h 20m  (was: 5h 10m)

> ATS 7.0.0 build fails with OpenSSL 1.1.0c
> -
>
> Key: TS-5059
> URL: https://issues.apache.org/jira/browse/TS-5059
> Project: Traffic Server
>  Issue Type: Bug
>  Components: SSL, TLS
>Reporter: Jean Baptiste Favre
> Fix For: 7.1.0
>
>  Time Spent: 5h 20m
>  Remaining Estimate: 0h
>
> ATS 7.0.0 build currently fails with following error:
> {code}SSLInternal.cc: In function ‘void SSL_set_rbio(SSL*, BIO*)’:
> SSLInternal.cc:40:10: error: invalid use of incomplete type ‘SSL {aka
> struct ssl_st}’
>if (ssl->rbio != NULL) {
>   ^~
> In file included from /usr/include/openssl/crypto.h:31:0,
>  from /usr/include/openssl/comp.h:16,
>  from /usr/include/openssl/ssl.h:47,
>  from SSLInternal.cc:33:
> /usr/include/openssl/ossl_typ.h:144:16: note: forward declaration of
> ‘SSL {aka struct ssl_st}’
>  typedef struct ssl_st SSL;
> ^~
> SSLInternal.cc:41:17: error: invalid use of incomplete type ‘SSL {aka
> struct ssl_st}’
>  BIO_free(ssl->rbio);
>  ^~
> In file included from /usr/include/openssl/crypto.h:31:0,
>  from /usr/include/openssl/comp.h:16,
>  from /usr/include/openssl/ssl.h:47,
>  from SSLInternal.cc:33:
> /usr/include/openssl/ossl_typ.h:144:16: note: forward declaration of
> ‘SSL {aka struct ssl_st}’
>  typedef struct ssl_st SSL;
> ^~
> SSLInternal.cc:43:6: error: invalid use of incomplete type ‘SSL {aka
> struct ssl_st}’
>ssl->rbio = rbio;
>   ^~
> In file included from /usr/include/openssl/crypto.h:31:0,
>  from /usr/include/openssl/comp.h:16,
>  from /usr/include/openssl/ssl.h:47,
>  from SSLInternal.cc:33:
> /usr/include/openssl/ossl_typ.h:144:16: note: forward declaration of
> ‘SSL {aka struct ssl_st}’
>  typedef struct ssl_st SSL;
> ^~
> {code}
> The full configure log can be found here:
> https://gist.github.com/jbfavre/00f63362b435d8ffc682d42d29b671f2
> According to https://wiki.openssl.org/index.php/1.1_API_Changes :
> > setting SSL->rbio without setting SSL->wbio. New function introduction
> in 1.1.0 to handle this: SSL_set_rbio()".
> Problem is, rbio doesn't seems to be nicely detected at configure stage:
> {code}checking for SSL_set_rbio... no
> checking whether to enable set rbio... no{code}
> Binding ATS to OpenSSL 1.0 still works.
> Regards,
> Jean Baptiste Favre



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Work logged] (TS-5059) ATS 7.0.0 build fails with OpenSSL 1.1.0c

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-5059?focusedWorklogId=34711=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-34711
 ]

ASF GitHub Bot logged work on TS-5059:
--

Author: ASF GitHub Bot
Created on: 04/Jan/17 22:12
Start Date: 04/Jan/17 22:12
Worklog Time Spent: 10m 
  Work Description: Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1294
  
FreeBSD build *failed*! See 
https://ci.trafficserver.apache.org/job/Github-FreeBSD/1297/ for details.
 



Issue Time Tracking
---

Worklog Id: (was: 34711)
Time Spent: 5h 10m  (was: 5h)

> ATS 7.0.0 build fails with OpenSSL 1.1.0c
> -
>
> Key: TS-5059
> URL: https://issues.apache.org/jira/browse/TS-5059
> Project: Traffic Server
>  Issue Type: Bug
>  Components: SSL, TLS
>Reporter: Jean Baptiste Favre
> Fix For: 7.1.0
>
>  Time Spent: 5h 10m
>  Remaining Estimate: 0h
>
> ATS 7.0.0 build currently fails with following error:
> {code}SSLInternal.cc: In function ‘void SSL_set_rbio(SSL*, BIO*)’:
> SSLInternal.cc:40:10: error: invalid use of incomplete type ‘SSL {aka
> struct ssl_st}’
>if (ssl->rbio != NULL) {
>   ^~
> In file included from /usr/include/openssl/crypto.h:31:0,
>  from /usr/include/openssl/comp.h:16,
>  from /usr/include/openssl/ssl.h:47,
>  from SSLInternal.cc:33:
> /usr/include/openssl/ossl_typ.h:144:16: note: forward declaration of
> ‘SSL {aka struct ssl_st}’
>  typedef struct ssl_st SSL;
> ^~
> SSLInternal.cc:41:17: error: invalid use of incomplete type ‘SSL {aka
> struct ssl_st}’
>  BIO_free(ssl->rbio);
>  ^~
> In file included from /usr/include/openssl/crypto.h:31:0,
>  from /usr/include/openssl/comp.h:16,
>  from /usr/include/openssl/ssl.h:47,
>  from SSLInternal.cc:33:
> /usr/include/openssl/ossl_typ.h:144:16: note: forward declaration of
> ‘SSL {aka struct ssl_st}’
>  typedef struct ssl_st SSL;
> ^~
> SSLInternal.cc:43:6: error: invalid use of incomplete type ‘SSL {aka
> struct ssl_st}’
>ssl->rbio = rbio;
>   ^~
> In file included from /usr/include/openssl/crypto.h:31:0,
>  from /usr/include/openssl/comp.h:16,
>  from /usr/include/openssl/ssl.h:47,
>  from SSLInternal.cc:33:
> /usr/include/openssl/ossl_typ.h:144:16: note: forward declaration of
> ‘SSL {aka struct ssl_st}’
>  typedef struct ssl_st SSL;
> ^~
> {code}
> The full configure log can be found here:
> https://gist.github.com/jbfavre/00f63362b435d8ffc682d42d29b671f2
> According to https://wiki.openssl.org/index.php/1.1_API_Changes :
> > setting SSL->rbio without setting SSL->wbio. New function introduction
> in 1.1.0 to handle this: SSL_set_rbio()".
> Problem is, rbio doesn't seems to be nicely detected at configure stage:
> {code}checking for SSL_set_rbio... no
> checking whether to enable set rbio... no{code}
> Binding ATS to OpenSSL 1.0 still works.
> Regards,
> Jean Baptiste Favre



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Work logged] (TS-5059) ATS 7.0.0 build fails with OpenSSL 1.1.0c

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-5059?focusedWorklogId=34708=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-34708
 ]

ASF GitHub Bot logged work on TS-5059:
--

Author: ASF GitHub Bot
Created on: 04/Jan/17 21:47
Start Date: 04/Jan/17 21:47
Worklog Time Spent: 10m 
  Work Description: Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1294
  
FreeBSD build *failed*! See 
https://ci.trafficserver.apache.org/job/Github-FreeBSD/1296/ for details.
 



Issue Time Tracking
---

Worklog Id: (was: 34708)
Time Spent: 4h 50m  (was: 4h 40m)

> ATS 7.0.0 build fails with OpenSSL 1.1.0c
> -
>
> Key: TS-5059
> URL: https://issues.apache.org/jira/browse/TS-5059
> Project: Traffic Server
>  Issue Type: Bug
>  Components: SSL, TLS
>Reporter: Jean Baptiste Favre
> Fix For: 7.1.0
>
>  Time Spent: 4h 50m
>  Remaining Estimate: 0h
>
> ATS 7.0.0 build currently fails with following error:
> {code}SSLInternal.cc: In function ‘void SSL_set_rbio(SSL*, BIO*)’:
> SSLInternal.cc:40:10: error: invalid use of incomplete type ‘SSL {aka
> struct ssl_st}’
>if (ssl->rbio != NULL) {
>   ^~
> In file included from /usr/include/openssl/crypto.h:31:0,
>  from /usr/include/openssl/comp.h:16,
>  from /usr/include/openssl/ssl.h:47,
>  from SSLInternal.cc:33:
> /usr/include/openssl/ossl_typ.h:144:16: note: forward declaration of
> ‘SSL {aka struct ssl_st}’
>  typedef struct ssl_st SSL;
> ^~
> SSLInternal.cc:41:17: error: invalid use of incomplete type ‘SSL {aka
> struct ssl_st}’
>  BIO_free(ssl->rbio);
>  ^~
> In file included from /usr/include/openssl/crypto.h:31:0,
>  from /usr/include/openssl/comp.h:16,
>  from /usr/include/openssl/ssl.h:47,
>  from SSLInternal.cc:33:
> /usr/include/openssl/ossl_typ.h:144:16: note: forward declaration of
> ‘SSL {aka struct ssl_st}’
>  typedef struct ssl_st SSL;
> ^~
> SSLInternal.cc:43:6: error: invalid use of incomplete type ‘SSL {aka
> struct ssl_st}’
>ssl->rbio = rbio;
>   ^~
> In file included from /usr/include/openssl/crypto.h:31:0,
>  from /usr/include/openssl/comp.h:16,
>  from /usr/include/openssl/ssl.h:47,
>  from SSLInternal.cc:33:
> /usr/include/openssl/ossl_typ.h:144:16: note: forward declaration of
> ‘SSL {aka struct ssl_st}’
>  typedef struct ssl_st SSL;
> ^~
> {code}
> The full configure log can be found here:
> https://gist.github.com/jbfavre/00f63362b435d8ffc682d42d29b671f2
> According to https://wiki.openssl.org/index.php/1.1_API_Changes :
> > setting SSL->rbio without setting SSL->wbio. New function introduction
> in 1.1.0 to handle this: SSL_set_rbio()".
> Problem is, rbio doesn't seems to be nicely detected at configure stage:
> {code}checking for SSL_set_rbio... no
> checking whether to enable set rbio... no{code}
> Binding ATS to OpenSSL 1.0 still works.
> Regards,
> Jean Baptiste Favre



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Work logged] (TS-5059) ATS 7.0.0 build fails with OpenSSL 1.1.0c

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-5059?focusedWorklogId=34709=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-34709
 ]

ASF GitHub Bot logged work on TS-5059:
--

Author: ASF GitHub Bot
Created on: 04/Jan/17 21:48
Start Date: 04/Jan/17 21:48
Worklog Time Spent: 10m 
  Work Description: Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1294
  
Linux build *failed*! See 
https://ci.trafficserver.apache.org/job/Github-Linux/1190/ for details.
 



Issue Time Tracking
---

Worklog Id: (was: 34709)
Time Spent: 5h  (was: 4h 50m)

> ATS 7.0.0 build fails with OpenSSL 1.1.0c
> -
>
> Key: TS-5059
> URL: https://issues.apache.org/jira/browse/TS-5059
> Project: Traffic Server
>  Issue Type: Bug
>  Components: SSL, TLS
>Reporter: Jean Baptiste Favre
> Fix For: 7.1.0
>
>  Time Spent: 5h
>  Remaining Estimate: 0h
>
> ATS 7.0.0 build currently fails with following error:
> {code}SSLInternal.cc: In function ‘void SSL_set_rbio(SSL*, BIO*)’:
> SSLInternal.cc:40:10: error: invalid use of incomplete type ‘SSL {aka
> struct ssl_st}’
>if (ssl->rbio != NULL) {
>   ^~
> In file included from /usr/include/openssl/crypto.h:31:0,
>  from /usr/include/openssl/comp.h:16,
>  from /usr/include/openssl/ssl.h:47,
>  from SSLInternal.cc:33:
> /usr/include/openssl/ossl_typ.h:144:16: note: forward declaration of
> ‘SSL {aka struct ssl_st}’
>  typedef struct ssl_st SSL;
> ^~
> SSLInternal.cc:41:17: error: invalid use of incomplete type ‘SSL {aka
> struct ssl_st}’
>  BIO_free(ssl->rbio);
>  ^~
> In file included from /usr/include/openssl/crypto.h:31:0,
>  from /usr/include/openssl/comp.h:16,
>  from /usr/include/openssl/ssl.h:47,
>  from SSLInternal.cc:33:
> /usr/include/openssl/ossl_typ.h:144:16: note: forward declaration of
> ‘SSL {aka struct ssl_st}’
>  typedef struct ssl_st SSL;
> ^~
> SSLInternal.cc:43:6: error: invalid use of incomplete type ‘SSL {aka
> struct ssl_st}’
>ssl->rbio = rbio;
>   ^~
> In file included from /usr/include/openssl/crypto.h:31:0,
>  from /usr/include/openssl/comp.h:16,
>  from /usr/include/openssl/ssl.h:47,
>  from SSLInternal.cc:33:
> /usr/include/openssl/ossl_typ.h:144:16: note: forward declaration of
> ‘SSL {aka struct ssl_st}’
>  typedef struct ssl_st SSL;
> ^~
> {code}
> The full configure log can be found here:
> https://gist.github.com/jbfavre/00f63362b435d8ffc682d42d29b671f2
> According to https://wiki.openssl.org/index.php/1.1_API_Changes :
> > setting SSL->rbio without setting SSL->wbio. New function introduction
> in 1.1.0 to handle this: SSL_set_rbio()".
> Problem is, rbio doesn't seems to be nicely detected at configure stage:
> {code}checking for SSL_set_rbio... no
> checking whether to enable set rbio... no{code}
> Binding ATS to OpenSSL 1.0 still works.
> Regards,
> Jean Baptiste Favre



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Work logged] (TS-5107) ATS 7.0.0 doesn't build against python docutils 0.13.1

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-5107?focusedWorklogId=34694=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-34694
 ]

ASF GitHub Bot logged work on TS-5107:
--

Author: ASF GitHub Bot
Created on: 04/Jan/17 17:32
Start Date: 04/Jan/17 17:32
Worklog Time Spent: 10m 
  Work Description: Github user jsime closed the pull request at:

https://github.com/apache/trafficserver/pull/1296


Issue Time Tracking
---

Worklog Id: (was: 34694)
Time Spent: 1.5h  (was: 1h 20m)

> ATS 7.0.0 doesn't build against python docutils 0.13.1
> --
>
> Key: TS-5107
> URL: https://issues.apache.org/jira/browse/TS-5107
> Project: Traffic Server
>  Issue Type: Bug
>  Components: Documentation
>Reporter: Jean Baptiste Favre
>  Time Spent: 1.5h
>  Remaining Estimate: 0h
>
> Trying to build ATS 7.0.0 with python docutils 0.13.1 on Debian fails
> with following error:
> {code}Making all in doc
> make[2]: Entering directory '/home/debocker/source/build/doc'
> PAPEROPT_a4="-D latex_paper_size=a4" PAPEROPT_letter="-D
> latex_paper_size=letter" PAPER="letter" ./sbuild sphinx-build -c .  -d
> docbuild/doctrees -b man . docbuild/man
> Running Sphinx v1.4.9
> making output directory...
> WARNING: sphinx.ext.pngmath has been deprecated. Please use
> sphinx.ext.imgmath instead.
> loading pickled environment... not yet created
> building [mo]: targets for 0 po files that are out of date
> building [man]: all manpages
> updating environment: 456 added, 0 changed, 0 removed
> reading sources... [  0%] admin-guide/configuration/cache-basics.en
> Exception occurred:
>   File "conf.py", line 185, in __init__
> start_string_prefix=self.start_string_prefix,
> AttributeError: Inliner instance has no attribute 'start_string_prefix'
> The full traceback has been saved in /tmp/sphinx-err-5iq_t9.log, if you
> want to report the issue to the developers.
> Please also report this if it was a user error, so that a better error
> message can be provided next time.
> A bug report can be filed in the tracker at
> . Thanks!
> Makefile:998: recipe for target 'man' failed
> make[2]: Leaving directory '/home/debocker/source/build/doc'
> make[2]: *** [man] Error 1
> make[1]: *** [all-recursive] Error 1{code}
> I tracked it down to 
> [docutils/parsers/rst/states.py|https://fossies.org/diffs/docutils/0.12_vs_0.13.1/docutils/parsers/rst/states.py-diff.html]
>  which changed
> between 0.12 & 0.13.1
> {{start_string_prefix}} is not defined anymore at {{Inliner}} init. We have to
> call {{init_cutomizations}} method, but I can't figure out the {{settings}}
> structure.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Work logged] (TS-5053) const char **argv passed to TSPluginInit is not null terminated

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-5053?focusedWorklogId=34693=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-34693
 ]

ASF GitHub Bot logged work on TS-5053:
--

Author: ASF GitHub Bot
Created on: 04/Jan/17 17:16
Start Date: 04/Jan/17 17:16
Worklog Time Spent: 10m 
  Work Description: Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1257
  
Linux build *successful*! See 
https://ci.trafficserver.apache.org/job/Github-Linux/1189/ for details.
 



Issue Time Tracking
---

Worklog Id: (was: 34693)
Time Spent: 1h 10m  (was: 1h)

> const char **argv passed to TSPluginInit is not null terminated
> ---
>
> Key: TS-5053
> URL: https://issues.apache.org/jira/browse/TS-5053
> Project: Traffic Server
>  Issue Type: Bug
>  Components: Plugins
>Reporter: Daniel Xu
>Assignee: Daniel Xu
> Fix For: 7.1.0
>
>  Time Spent: 1h 10m
>  Remaining Estimate: 0h
>
> See title. Typically **argv is null terminated in other systems. And who are 
> we to question 1000 years of tradition?
> One example of an issue is that {{lib/ts/ink_args.cc}} actually relies on 
> **argv being null terminated. Interesting segfaults occur in plugins usings 
> the ATS argument parser.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Work logged] (TS-5070) Add configuration variables to set file permissions for diags.log & traffic.out

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-5070?focusedWorklogId=34686=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-34686
 ]

ASF GitHub Bot logged work on TS-5070:
--

Author: ASF GitHub Bot
Created on: 04/Jan/17 17:08
Start Date: 04/Jan/17 17:08
Worklog Time Spent: 10m 
  Work Description: Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1248
  
FreeBSD build *successful*! See 
https://ci.trafficserver.apache.org/job/Github-FreeBSD/1294/ for details.
 



Issue Time Tracking
---

Worklog Id: (was: 34686)
Time Spent: 50m  (was: 40m)

> Add configuration variables to set file permissions for diags.log & 
> traffic.out
> ---
>
> Key: TS-5070
> URL: https://issues.apache.org/jira/browse/TS-5070
> Project: Traffic Server
>  Issue Type: Improvement
>  Components: Logging
>Reporter: Daniel Xu
>Assignee: Daniel Xu
> Fix For: 7.1.0
>
>  Time Spent: 50m
>  Remaining Estimate: 0h
>
> It would be useful to be able to control file permissions for {{diags.log}} 
> and {{traffic.out}}.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Work logged] (TS-5053) const char **argv passed to TSPluginInit is not null terminated

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-5053?focusedWorklogId=34689=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-34689
 ]

ASF GitHub Bot logged work on TS-5053:
--

Author: ASF GitHub Bot
Created on: 04/Jan/17 17:09
Start Date: 04/Jan/17 17:09
Worklog Time Spent: 10m 
  Work Description: Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1257
  
FreeBSD build *successful*! See 
https://ci.trafficserver.apache.org/job/Github-FreeBSD/1295/ for details.
 



Issue Time Tracking
---

Worklog Id: (was: 34689)
Time Spent: 1h  (was: 50m)

> const char **argv passed to TSPluginInit is not null terminated
> ---
>
> Key: TS-5053
> URL: https://issues.apache.org/jira/browse/TS-5053
> Project: Traffic Server
>  Issue Type: Bug
>  Components: Plugins
>Reporter: Daniel Xu
>Assignee: Daniel Xu
> Fix For: 7.1.0
>
>  Time Spent: 1h
>  Remaining Estimate: 0h
>
> See title. Typically **argv is null terminated in other systems. And who are 
> we to question 1000 years of tradition?
> One example of an issue is that {{lib/ts/ink_args.cc}} actually relies on 
> **argv being null terminated. Interesting segfaults occur in plugins usings 
> the ATS argument parser.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Work logged] (TS-5070) Add configuration variables to set file permissions for diags.log & traffic.out

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-5070?focusedWorklogId=34687=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-34687
 ]

ASF GitHub Bot logged work on TS-5070:
--

Author: ASF GitHub Bot
Created on: 04/Jan/17 17:09
Start Date: 04/Jan/17 17:09
Worklog Time Spent: 10m 
  Work Description: Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1248
  
Linux build *successful*! See 
https://ci.trafficserver.apache.org/job/Github-Linux/1188/ for details.
 



Issue Time Tracking
---

Worklog Id: (was: 34687)
Time Spent: 1h  (was: 50m)

> Add configuration variables to set file permissions for diags.log & 
> traffic.out
> ---
>
> Key: TS-5070
> URL: https://issues.apache.org/jira/browse/TS-5070
> Project: Traffic Server
>  Issue Type: Improvement
>  Components: Logging
>Reporter: Daniel Xu
>Assignee: Daniel Xu
> Fix For: 7.1.0
>
>  Time Spent: 1h
>  Remaining Estimate: 0h
>
> It would be useful to be able to control file permissions for {{diags.log}} 
> and {{traffic.out}}.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Work logged] (TS-5053) const char **argv passed to TSPluginInit is not null terminated

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-5053?focusedWorklogId=34685=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-34685
 ]

ASF GitHub Bot logged work on TS-5053:
--

Author: ASF GitHub Bot
Created on: 04/Jan/17 16:59
Start Date: 04/Jan/17 16:59
Worklog Time Spent: 10m 
  Work Description: Github user shinrich commented on the issue:

https://github.com/apache/trafficserver/pull/1257
  
[approve ci]


Issue Time Tracking
---

Worklog Id: (was: 34685)
Time Spent: 50m  (was: 40m)

> const char **argv passed to TSPluginInit is not null terminated
> ---
>
> Key: TS-5053
> URL: https://issues.apache.org/jira/browse/TS-5053
> Project: Traffic Server
>  Issue Type: Bug
>  Components: Plugins
>Reporter: Daniel Xu
>Assignee: Daniel Xu
> Fix For: 7.1.0
>
>  Time Spent: 50m
>  Remaining Estimate: 0h
>
> See title. Typically **argv is null terminated in other systems. And who are 
> we to question 1000 years of tradition?
> One example of an issue is that {{lib/ts/ink_args.cc}} actually relies on 
> **argv being null terminated. Interesting segfaults occur in plugins usings 
> the ATS argument parser.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)