[GitHub] trafficserver pull request #1548: Insure that parent health stats are update...
Github user jrushford closed the pull request at: https://github.com/apache/trafficserver/pull/1548 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1548: Insure that parent health stats are updated prope...
Github user jrushford commented on the issue: https://github.com/apache/trafficserver/pull/1548 Should backport it to 7.1.0. Submitted an issue to refactor the duplicated code into a base class and will merge this pr. Thanks -- John J. Rushford IPCDN Engineering 1400 Wewatta Street, Denver Colorado 80202 john_rushf...@cable.comcast.com From: Leif Hedstrom <notificati...@github.com> Reply-To: apache/trafficserver <re...@reply.github.com> Date: Thursday, March 16, 2017 at 1:24 PM To: apache/trafficserver <trafficser...@noreply.github.com> Cc: John Rushford <john_rushf...@cable.comcast.com>, Mention <ment...@noreply.github.com> Subject: Re: [apache/trafficserver] Insure that parent health stats are updated properly on a markdown (#1548) @jrushford<https://github.com/jrushford> I assume we don't want this for 7.1.0 ? â You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub<https://github.com/apache/trafficserver/pull/1548#issuecomment-287164895>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AEVybk2JOOWOyaRJ0xW-u3Ttj_i1Dlf8ks5rmYxbgaJpZM4MV7Dh>. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1597: Refactor ParentRoundRobin and ParentConsistentHas...
GitHub user jrushford opened an issue: https://github.com/apache/trafficserver/issues/1597 Refactor ParentRoundRobin and ParentConsistentHash policy's The ParentRoundRobin and ParentConsistentHash selection policies have functions that should be refactored into a base class as these functions are duplicates of one anther. Specifically markParentDown(), markParentUp() and numParents(). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1548: Insure that parent health stats are updated prope...
Github user jrushford commented on the issue: https://github.com/apache/trafficserver/pull/1548 @zwoop you're right of course. I'm going to take a closer look at refactoring this into a base class. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1582: Make regex_revalidate.c use ref-counted config da...
Github user jrushford commented on the issue: https://github.com/apache/trafficserver/issues/1582 @zwoop I'll take a look. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1565: Fix Assertion failure in the regex_revalidate plu...
Github user jrushford commented on the issue: https://github.com/apache/trafficserver/pull/1565 @amc - thanks, I just saw @jpeach comment. @zwoop - Yes this change fixes the issue. We ran into the problem running 6.2.x in production. The PR that mad a mutex a requirement was from this Jira: https://issues.apache.org/jira/browse/TS-4387?jql=text%20~%20%22TSContSchedule%22 regex_revalidate may have been overlooked when they updated plugins using TSContSchedule() --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1548: Insure that parent health stats are updated prope...
Github user jrushford commented on the issue: https://github.com/apache/trafficserver/pull/1548 @PSUdaemon, @vmamidi, @zwoop - is this one okay to merge? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1565: Fix Assertion failure in the regex_revalidate plu...
Github user jrushford commented on the issue:
https://github.com/apache/trafficserver/pull/1565
@zwoop there was a change, https://issues.apache.org/jira/browse/TS-4387,
made that requires a mutex when using TSContSchedule(). With the PR, all
plugins using TSContSchedule were updated to supply a mutex on the continuation
scheduled by TSContSchedule(). Sdding the Mutex() did solve the assertion
failures in 6..2 that we saw whenever the regex_revalidate config file was
changed.
Thanks
--
John J. Rushford
From: Leif Hedstrom <notificati...@github.com>
Reply-To: apache/trafficserver <re...@reply.github.com>
Date: Tuesday, March 14, 2017 at 3:36 PM
To: apache/trafficserver <trafficser...@noreply.github.com>
Cc: John Rushford <john_rushf...@cable.comcast.com>, Review requested
<review_reques...@noreply.github.com>
Subject: Re: [apache/trafficserver] Fix Assertion failure in the
regex_revalidate plugin. (#1565)
@zwoop commented on this pull request.
In
plugins/regex_revalidate/regex_revalidate.c<https://github.com/apache/trafficserver/pull/1565#discussion_r106033633>:
> @@ -362,7 +362,7 @@ config_handler(TSCont cont, TSEvent event ATS_UNUSED,
void *edata ATS_UNUSED)
iptr = __sync_val_compare_and_swap(&(pstate->invalidate_list),
pstate->invalidate_list, i);
if (iptr) {
- free_cont = TSContCreate(free_handler, NULL);
+ free_cont = TSContCreate(free_handler, TSMutexCreate());
I'm ok with this (assuming this solves the problem, it's not immediately
clear as to why it needs the mutex). However, this approach of a schedule
"delete" seems bad, we should change this (later) to use ref-counted data
instead. That would eliminate the entire free_cont, and is a better / more
reliable pattern.
â
You are receiving this because your review was requested.
Reply to this email directly, view it on
GitHub<https://github.com/apache/trafficserver/pull/1565#pullrequestreview-26939009>,
or mute the
thread<https://github.com/notifications/unsubscribe-auth/AEVybl5q-yr1BXSWc-Z9QeVRgIsqo1PSks5rlwhkgaJpZM4MZjXB>.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request #1267: TS-5021: Separate parent_is_proxy from oth...
Github user jrushford closed the pull request at: https://github.com/apache/trafficserver/pull/1267 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1267: TS-5021: Separate parent_is_proxy from other pare...
Github user jrushford commented on the issue: https://github.com/apache/trafficserver/pull/1267 7.2.0 is fine Thanks -- John J. Rushford IPCDN Engineering 1400 Wewatta Street, Denver Colorado 80202 john_rushf...@cable.comcast.com From: Leif Hedstrom <notificati...@github.com> Reply-To: apache/trafficserver <re...@reply.github.com> Date: Wednesday, March 8, 2017 at 11:56 AM To: apache/trafficserver <trafficser...@noreply.github.com> Cc: John Rushford <john_rushf...@cable.comcast.com>, Mention <ment...@noreply.github.com> Subject: Re: [apache/trafficserver] TS-5021: Separate parent_is_proxy from other parent configuration options. (#1267) @jrushford<https://github.com/jrushford> Question: do we want this into 7.1.x ? â You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub<https://github.com/apache/trafficserver/pull/1267#issuecomment-285133197>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AEVybnd92JxcZRQzasVMnaGxRU3jR2-Aks5rjvnEgaJpZM4LOpz6>. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1267: TS-5021: Separate parent_is_proxy from other pare...
Github user jrushford commented on the issue: https://github.com/apache/trafficserver/pull/1267 @zwoop - forgot about this one but, i rebased this and it's ready to go if you're +1. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver pull request #1548: Insure that parent health stats are update...
GitHub user jrushford opened a pull request: https://github.com/apache/trafficserver/pull/1548 Insure that parent health stats are updated properly on a markdown Parents may be marked down prematurely because the health stats are not reset when the retry window has elapsed. This adds a check when a parent is marked down to make sure that the health stats are updated appropriately. You can merge this pull request into a Git repository by running: $ git pull https://github.com/jrushford/trafficserver reset_parent_stats Alternatively you can review and apply these changes as the patch at: https://github.com/apache/trafficserver/pull/1548.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1548 commit 0ab69ddd9d51d19aa3f983d39f02b1175c80cf63 Author: jrushf1239k <john_rushf...@cable.comcast.com> Date: 2017-03-07T18:01:25Z Insure that parent health stats are updated properly on a markdown when the retry window has elapsed. This avoids premature markdowns. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1541: retry safe requests
Github user jrushford commented on the issue: https://github.com/apache/trafficserver/pull/1541 I'd like Vijay to review but was unable to assign him for some reason. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver pull request #1541: retry safe requests
GitHub user jrushford opened a pull request: https://github.com/apache/trafficserver/pull/1541 retry safe requests (cherry picked from commit a57f6609644752b8a2e81bcd4872f64575331c1e) Conflicts: doc/developer-guide/api/functions/TSHttpOverridableConfig.en.rst proxy/InkAPI.cc proxy/http/HttpConfig.cc proxy/http/HttpConfig.h proxy/http/HttpSM.cc proxy/http/HttpTransact.cc You can merge this pull request into a Git repository by running: $ git pull https://github.com/jrushford/trafficserver retry_safe_methods Alternatively you can review and apply these changes as the patch at: https://github.com/apache/trafficserver/pull/1541.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1541 commit 0c63fd307afa4267394f107b49e444b280c878ea Author: vijayabhaskar <vijayabhaskar_mam...@yahoo.com> Date: 2017-02-01T17:12:36Z retry safe requests (cherry picked from commit a57f6609644752b8a2e81bcd4872f64575331c1e) Conflicts: doc/developer-guide/api/functions/TSHttpOverridableConfig.en.rst proxy/InkAPI.cc proxy/http/HttpConfig.cc proxy/http/HttpConfig.h proxy/http/HttpSM.cc proxy/http/HttpTransact.cc --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver pull request #1513: TS-4747: make marking parent proxies down ...
GitHub user jrushford reopened a pull request: https://github.com/apache/trafficserver/pull/1513 TS-4747: make marking parent proxies down in hostdb configurable. Back port of https://github.com/apache/trafficserver/pull/1464 to 6.2.2 (cherry picked from commit 2752c758fd480c1becd814f40ff53896d44b315b) Conflicts: doc/admin-guide/files/records.config.en.rst doc/developer-guide/api/functions/TSHttpOverridableConfig.en.rst lib/ts/apidefs.h.in mgmt/RecordsConfig.cc plugins/experimental/ts_lua/ts_lua_http_config.c proxy/InkAPI.cc proxy/InkAPITest.cc proxy/http/HttpConfig.cc proxy/http/HttpConfig.h You can merge this pull request into a Git repository by running: $ git pull https://github.com/jrushford/trafficserver ts-4747bp Alternatively you can review and apply these changes as the patch at: https://github.com/apache/trafficserver/pull/1513.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1513 commit 65e41a6a3b6ce1a7ceabd2da70b9a171647f82b0 Author: jrushf1239k <john_rushf...@cable.comcast.com> Date: 2017-02-17T16:34:33Z TS-4747: make marking parent proxies down in hostdb configurable. (cherry picked from commit 2752c758fd480c1becd814f40ff53896d44b315b) Conflicts: doc/admin-guide/files/records.config.en.rst doc/developer-guide/api/functions/TSHttpOverridableConfig.en.rst lib/ts/apidefs.h.in mgmt/RecordsConfig.cc plugins/experimental/ts_lua/ts_lua_http_config.c proxy/InkAPI.cc proxy/InkAPITest.cc proxy/http/HttpConfig.cc proxy/http/HttpConfig.h --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver pull request #1513: TS-4747: make marking parent proxies down ...
Github user jrushford closed the pull request at: https://github.com/apache/trafficserver/pull/1513 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1513: TS-4747: make marking parent proxies down in host...
Github user jrushford commented on the issue: https://github.com/apache/trafficserver/pull/1513 [approve ci] --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1427: Crash in ATSConsistentHash::lookup_by_hashval
Github user jrushford commented on the issue: https://github.com/apache/trafficserver/issues/1427 Are there any changes being made to parent.config with traffic_ctl when the crash happens? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver pull request #1299: TS-2888: remove vararg and format paramete...
Github user jrushford commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/1299#discussion_r103735621
--- Diff: proxy/http/HttpTransact.cc ---
@@ -3571,11 +3571,7 @@ HttpTransact::handle_response_from_parent(State *s)
ink_assert(s->hdr_info.server_request.valid());
s->current.server->connect_result = ENOTCONN;
- // only mark the parent down in hostdb if the configuration allows
it,
- // see proxy.config.http.parent_proxy.mark_down_hostdb in
records.config.
- if (s->txn_conf->parent_failures_update_hostdb) {
-s->state_machine->do_hostdb_update_if_necessary();
- }
+ s->state_machine->do_hostdb_update_if_necessary();
--- End diff --
yeah it is, see https://github.com/apache/trafficserver/pull/1464 merged
about a week ago.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request #1513: TS-4747: make marking parent proxies down ...
GitHub user jrushford opened a pull request: https://github.com/apache/trafficserver/pull/1513 TS-4747: make marking parent proxies down in hostdb configurable. (cherry picked from commit 2752c758fd480c1becd814f40ff53896d44b315b) Conflicts: doc/admin-guide/files/records.config.en.rst doc/developer-guide/api/functions/TSHttpOverridableConfig.en.rst lib/ts/apidefs.h.in mgmt/RecordsConfig.cc plugins/experimental/ts_lua/ts_lua_http_config.c proxy/InkAPI.cc proxy/InkAPITest.cc proxy/http/HttpConfig.cc proxy/http/HttpConfig.h You can merge this pull request into a Git repository by running: $ git pull https://github.com/jrushford/trafficserver ts-4747bp Alternatively you can review and apply these changes as the patch at: https://github.com/apache/trafficserver/pull/1513.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1513 commit 46b44cc3533a17a6392f87a53c37f66056a16f78 Author: jrushf1239k <john_rushf...@cable.comcast.com> Date: 2017-02-17T16:34:33Z TS-4747: make marking parent proxies down in hostdb configurable. (cherry picked from commit 2752c758fd480c1becd814f40ff53896d44b315b) Conflicts: doc/admin-guide/files/records.config.en.rst doc/developer-guide/api/functions/TSHttpOverridableConfig.en.rst lib/ts/apidefs.h.in mgmt/RecordsConfig.cc plugins/experimental/ts_lua/ts_lua_http_config.c proxy/InkAPI.cc proxy/InkAPITest.cc proxy/http/HttpConfig.cc proxy/http/HttpConfig.h --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver pull request #1464: TS-4747: make marking parent proxies down ...
Github user jrushford closed the pull request at: https://github.com/apache/trafficserver/pull/1464 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1464: TS-4747: make marking parent proxies down in host...
Github user jrushford commented on the issue: https://github.com/apache/trafficserver/pull/1464 @zwoop All changes are in, see the commits. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1427: Crash in ATSConsistentHash::lookup_by_hashval
Github user jrushford commented on the issue: https://github.com/apache/trafficserver/issues/1427 @randall - what os are you using, i'll try to duplicate. can i see a sample of your parent.config? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1464: TS-4747: make marking parent proxies down in host...
Github user jrushford commented on the issue: https://github.com/apache/trafficserver/pull/1464 changed type on parent_failures_update_hostdb from MgmtInt to MgmtByte. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1464: TS-4747: make marking parent proxies down in host...
Github user jrushford commented on the issue: https://github.com/apache/trafficserver/pull/1464 [approve ci] --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1464: TS-4747: make marking parent proxies down in host...
Github user jrushford commented on the issue: https://github.com/apache/trafficserver/pull/1464 @zwoop, @bryancall, @PSUdaemon - changes were made, see last two commits. changed the config variable name and made it overridable. Tested with header_rewrite plugin and traffic_ctl --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver pull request #1464: TS-4747: make marking parent proxies down ...
Github user jrushford commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/1464#discussion_r101805199
--- Diff: mgmt/RecordsConfig.cc ---
@@ -518,6 +518,8 @@ static const RecordElement RecordsConfig[] =
,
{RECT_CONFIG, "proxy.config.http.parent_proxy.connect_attempts_timeout",
RECD_INT, "30", RECU_DYNAMIC, RR_NULL, RECC_NULL, nullptr, RECA_NULL}
,
+ {RECT_CONFIG,
"proxy.config.http.update_hostdb_on_parent_proxy_connect_errors", RECD_INT,
"0", RECU_DYNAMIC, RR_NULL, RECC_INT, "[0-1]", RECA_NULL}
--- End diff --
yeah it is long, i prefer your second suggestion since it's used in the
http transaction to update or not hostdb. All the ones named spaced to
proxy.config.hostdb are internal to hostdb and its configuration. But if you
prefer #1, I'll use it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request #1464: TS-4747: make marking parent proxies down ...
GitHub user jrushford opened a pull request: https://github.com/apache/trafficserver/pull/1464 TS-4747: make marking parent proxies down in hostdb configurable. For the use case where a parent in parent.config has multiple ip's for failover, TS-4747 added marking the parent down in hostdb so that subsequent requests to the parent would go to another ip/host. For parent proxies listed in parent.config tat are not using multiple ips for failover, it is not desirable to mark the parent proxy down in hostdb as the parent selection system will manage the availability of the parent. This PR reverts to the original behavior where parent proxies are not marked down in hostdb but adds a configuration option so that need parent proxies marked down in hostdb may enable it. You can merge this pull request into a Git repository by running: $ git pull https://github.com/jrushford/trafficserver ts-4747 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/trafficserver/pull/1464.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1464 commit 46b21419eb7216eafee097f649d51ca40646187c Author: jrushf1239k <john_rushf...@cable.comcast.com> Date: 2017-02-17T16:34:33Z TS-4747: make marking parent proxies down in hostdb configurable. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1427: Crash in ATSConsistentHash::lookup_by_hashval
Github user jrushford commented on the issue: https://github.com/apache/trafficserver/issues/1427 Randall, I'm unable to duplicate in my environment, CentOS 7.2 and gcc 4.8.5-4. What OS are you using and can you attach your parent.config? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1406: Fix Assertion failure in the regex_revalidate plu...
Github user jrushford commented on the issue: https://github.com/apache/trafficserver/pull/1406 [approve ci] --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1406: Fix Assertion failure in the regex_revalidate plu...
Github user jrushford commented on the issue: https://github.com/apache/trafficserver/pull/1406 [approve ci] --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1406: Fix Assertion failure in the regex_revalidate plu...
Github user jrushford commented on the issue: https://github.com/apache/trafficserver/pull/1406 [approve ci] --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver pull request #1406: Fix Assertion failure in the regex_revalid...
GitHub user jrushford opened a pull request: https://github.com/apache/trafficserver/pull/1406 Fix Assertion failure in the regex_revalidate plugin. When using the regex_revalidate plugin, we see an assertion failure in TSContSchedule() at InkAPI.cc:4232 Since TS-4387, Calls to TSContSchedule/TSContScheduleEvery(), require that the continuation associated with the TSCont parameter must have a mutex. You can merge this pull request into a Git repository by running: $ git pull https://github.com/jrushford/trafficserver regex_revalidate_issue Alternatively you can review and apply these changes as the patch at: https://github.com/apache/trafficserver/pull/1406.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1406 commit 27c4a142a0371f8dff59b8fc03a61b37c5232eb4 Author: John J. Rushford <jrushf...@apache.org> Date: 2017-02-01T20:34:44Z Fix Assertion failure in the regex_revalidate plugin. Since TS-4387, Calls to TSContSchedule/TSContScheduleEvery(), require that the continuation associated with the TSCont parameter must have a mutex. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver pull request #1297: ISSUE 1283: Fix CID 1367526 and CID 136752...
Github user jrushford closed the pull request at: https://github.com/apache/trafficserver/pull/1297 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1283: CID 1367526: CID 1367525 : money_trace/money_trac...
Github user jrushford commented on the issue: https://github.com/apache/trafficserver/issues/1283 PR #1297 fixes this issue --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1297: ISSUE 1283: Fix CID 1367526 and CID 1367525 in mo...
Github user jrushford commented on the issue: https://github.com/apache/trafficserver/pull/1297 This PR fixes issue #1283 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1283: CID 1367526: CID 1367525 : money_trace/money_trac...
Github user jrushford commented on the issue: https://github.com/apache/trafficserver/issues/1283 This should be fixed, see PR https://github.com/apache/trafficserver/pull/1297 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver pull request #1297: ISSUE 1283: Fix CID 1367526 and CID 136752...
GitHub user jrushford opened a pull request: https://github.com/apache/trafficserver/pull/1297 ISSUE 1283: Fix CID 1367526 and CID 1367525 in money_trace plugin. Fixes the coverity scan issues CID 1367526 and CID 1367525 in money_trace plugin. You can merge this pull request into a Git repository by running: $ git pull https://github.com/jrushford/trafficserver issue-1283 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/trafficserver/pull/1297.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1297 commit 169383e88afc4406a99098012f33cd57c33f8599 Author: John J. Rushford <jrushf...@apache.org> Date: 2017-01-03T18:03:11Z ISSUE 1283: Fix CID 1367526 and CID 1367525 in money_trace plugin. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver pull request #1258: TS-5089: Add money_trace plugin.
Github user jrushford closed the pull request at: https://github.com/apache/trafficserver/pull/1258 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver pull request #1267: TS-5021: Separate parent_is_proxy from oth...
GitHub user jrushford opened a pull request: https://github.com/apache/trafficserver/pull/1267 TS-5021: Separate parent_is_proxy from other parent configuration options. simple retry and unavailable_server retry are no-longer tied to parent_is_proxy. @zwoop - please review. You can merge this pull request into a Git repository by running: $ git pull https://github.com/jrushford/trafficserver TS-5021 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/trafficserver/pull/1267.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1267 commit 7b89fac9402883d2430cb3d9ce3dd64471079b80 Author: John J. Rushford <jrushf...@apache.org> Date: 2016-12-14T20:01:59Z TS-5021: Separate parent_is_proxy from other parent configuration options. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver pull request #1264: TS-3692: Remove code associated with proxy...
GitHub user jrushford opened a pull request: https://github.com/apache/trafficserver/pull/1264 TS-3692: Remove code associated with proxy.config.url_remap.url_remap_mode. @zwoop and @jpeach could you please review this. I believe this removes the all the unused code associated with proxy.config.url_remap.url_remap_mode. testing + regression tests ok. You can merge this pull request into a Git repository by running: $ git pull https://github.com/jrushford/trafficserver TS-3692 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/trafficserver/pull/1264.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1264 commit 3cae5673715d611ead95cd103759e6ab33e1081d Author: John J. Rushford <jrushf...@apache.org> Date: 2016-12-14T02:20:20Z TS-3692: Remove code associated with proxy.config.url_remap.url_remap_mode. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1258: TS-5089: Add money_trace plugin.
Github user jrushford commented on the issue: https://github.com/apache/trafficserver/pull/1258 @PSUdaemon - I've updated the docs per your request. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1258: TS-5089: Add money_trace plugin.
Github user jrushford commented on the issue: https://github.com/apache/trafficserver/pull/1258 @jpeach Cisco is looking at using it in their deployments and possibly Cox. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver pull request #1258: TS-5089: Add money_trace plugin.
GitHub user jrushford opened a pull request: https://github.com/apache/trafficserver/pull/1258 TS-5089: Add money_trace plugin. This is an experimental remap plugin that is now open sourced that allows traffic server caches to participate in a distributed tracing system that utilizes the Comcast Money library. The Comcast Money library, https://github.com/Comcast/money/wiki, has its roots in Google Dapper and Twitter's zipkin. Hopefully this plugin may prove useful for others in the community. You can merge this pull request into a Git repository by running: $ git pull https://github.com/jrushford/trafficserver TS-5089 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/trafficserver/pull/1258.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1258 commit e96ed1f7ec166b49be5adda763fe08e0b6936ee2 Author: John J. Rushford <jrushf...@apache.org> Date: 2016-12-12T19:10:15Z TS-5089: Add money_trace plugin. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver pull request #1250: TS-5060: Fix DNAME support for OSX and Fre...
Github user jrushford closed the pull request at: https://github.com/apache/trafficserver/pull/1250 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1250: TS-5060: Fix DNAME support for OSX and FreeBSD.
Github user jrushford commented on the issue: https://github.com/apache/trafficserver/pull/1250 [approve ci] --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver pull request #1250: TS-5060: Fix DNAME support for OSX and Fre...
GitHub user jrushford opened a pull request: https://github.com/apache/trafficserver/pull/1250 TS-5060: Fix DNAME support for OSX and FreeBSD. This PR fixes the build errors found for OSX caused by removing nameser_compat.h in the PR thath adds DNAME support. nameser_compat.h is being added back in and T_DNAME is defined in lib/ts/ink_resolver.h for OSX and FreeBSD. You can merge this pull request into a Git repository by running: $ git pull https://github.com/jrushford/trafficserver TS-5060 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/trafficserver/pull/1250.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1250 commit d704de6b7b12ef410457c1f76a08a0a53ef56652 Author: John J. Rushford <jrushf...@apache.org> Date: 2016-12-06T17:22:50Z TS-5060: Fix DNAME support for OSX and FreeBSD. commit 0b1f84314350d379bf85ace6a4d8470d94284725 Author: John Rushford <jrushf...@apache.org> Date: 2016-12-06T17:36:33Z TS-5060: define T_DNAME for OSX and FreeBSD. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1241: TS-5060: Add support for DNAME record type.
Github user jrushford commented on the issue: https://github.com/apache/trafficserver/pull/1241 I squashed them, just wanted you to be able to see the commit history. From: Leif Hedstrom <notificati...@github.com> Reply-To: apache/trafficserver <re...@reply.github.com> Date: Thursday, December 1, 2016 at 1:26 PM To: apache/trafficserver <trafficser...@noreply.github.com> Cc: John Rushford <john_rushf...@cable.comcast.com>, Author <aut...@noreply.github.com> Subject: Re: [apache/trafficserver] TS-5060: Add support for DNAME record type. (#1241) @zwoop commented on this pull request. Yeh, squash 'em, since otherwise we have potential broken intermediate commits. â You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub<https://github.com/apache/trafficserver/pull/1241#pullrequestreview-11049908>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AEVybtbLuaMzhyAaiB9lHsvGcwxCXqLMks5rDy1_gaJpZM4LBjGp>. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1241: TS-5060: Add support for DNAME record type.
Github user jrushford commented on the issue: https://github.com/apache/trafficserver/pull/1241 In FreeBSD T_DNAME is missing from /usr/include/arpa/nameser_compat.h. However, in /usr/include/arpa/nameser_h, ns_t_dname is defined and In nameser_compat.h, all the T_* dns record types tokens point to the ns_t_* tokens defined in nameser.h I changed DNS.cc to use the ns_t_dname token and for consistency, I changed all the other record type tokens to use the ns_t names from nameser.h. After making these changes, there really is no need for nameser_compat.h in the ATS code so, I removed including it. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1241: TS-5060: Add support for DNAME record type.
Github user jrushford commented on the issue: https://github.com/apache/trafficserver/pull/1241 Taking a look. Thanks -- John J. Rushford IPCDN Engineering 1400 Wewatta Street, Denver Colorado 80202 john_rushf...@cable.comcast.com From: Leif Hedstrom <notificati...@github.com> Reply-To: apache/trafficserver <re...@reply.github.com> Date: Thursday, December 1, 2016 at 9:04 AM To: apache/trafficserver <trafficser...@noreply.github.com> Cc: John Rushford <john_rushf...@cable.comcast.com>, Author <aut...@noreply.github.com> Subject: Re: [apache/trafficserver] TS-5060: Add support for DNAME record type. (#1241) Seems two issues here: 1. clang-format 2. FreeBSD doesn't have a T_DNAME ? â You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub<https://github.com/apache/trafficserver/pull/1241#issuecomment-264213697>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AEVybpNvF4mZXXMjhOE6Xu_0J0zXmFVSks5rDvAFgaJpZM4LBjGp>. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver pull request #1241: TS-5060: Add support for DNAME record type...
GitHub user jrushford opened a pull request: https://github.com/apache/trafficserver/pull/1241 TS-5060: Add support for DNAME record type. This is a patch suggested by @zwoop that adds support for resolving DNAME record types. I've tested this patch with a delivery service we were trying to deploy that uses DNAME record types. This patch solves the problem where queries using DNAME failed due to ATS inability to resolve DNAME's. You can merge this pull request into a Git repository by running: $ git pull https://github.com/jrushford/trafficserver TS-5060 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/trafficserver/pull/1241.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1241 commit 0719d4fdcd9213ed26a831bcc014008a0fd39762 Author: John J. Rushford <jrushf...@apache.org> Date: 2016-12-01T15:16:16Z TS-5060: Add support for DNAME record type. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver pull request #1218: TS-5050: The background_fetch plugin fails...
Github user jrushford closed the pull request at: https://github.com/apache/trafficserver/pull/1218 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1218: TS-5050: The background_fetch plugin fails to che...
Github user jrushford commented on the issue: https://github.com/apache/trafficserver/pull/1218 whew wipes sweat from furrowed brow :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1218: TS-5050: The background_fetch plugin fails to che...
Github user jrushford commented on the issue: https://github.com/apache/trafficserver/pull/1218 see the changes @jpeach. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver pull request #1218: TS-5050: The background_fetch plugin fails...
Github user jrushford commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/1218#discussion_r88068883
--- Diff: plugins/background_fetch/configs.cc ---
@@ -44,8 +44,13 @@ BgFetchConfig::readConfig(const char *config_file)
snprintf(file_path, sizeof(file_path), "%s/%s", TSInstallDirGet(),
config_file);
file = TSfopen(file_path, "r");
if (nullptr == file) {
- TSError("[%s] invalid config file", PLUGIN_NAME);
- return false;
+ TSDebug(PLUGIN_NAME, "Failed to open config file %s, trying config
path", config_file);
+ snprintf(file_path, sizeof(file_path), "%s/%s", TSConfigDirGet(),
config_file);
+ file = TSfopen(file_path, "r");
+ if (NULL == file) {
+TSError("[%s] invalid config file", PLUGIN_NAME);
+return false;
+ }
--- End diff --
ok, see changes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1218: TS-5050: The background_fetch plugin fails to che...
Github user jrushford commented on the issue: https://github.com/apache/trafficserver/pull/1218 @jpeach - tested and the fix consumes absolute paths, relative paths to install directory, and it now consumes config files relative to the config directory --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1218: TS-5050: The background_fetch plugin fails to che...
Github user jrushford commented on the issue: https://github.com/apache/trafficserver/pull/1218 @zwoop I just put back the code used previous to TS-2682 in background_fetch.cc. Didn't spend too much time on it, just wanted our configs to be read wen we deploy 6.2. I can go back and clean it up. @jpeach I haven't looked at every remap plugin to see how they open and read they're config files. Just put back the code from before the regression. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver pull request #1218: TS-5050: The background_fetch plugin fails...
GitHub user jrushford opened a pull request: https://github.com/apache/trafficserver/pull/1218 TS-5050: The background_fetch plugin fails to check for config files ⦠This may be from a regression with TS-2682. Anyway, with the following remap config that we've been using with ATS 5.3.2, the background_fetch config file could not be found and read. The config file is located at /opt/trafficserver/etc/trafficserver/bg_fetch.config @plugin=background_fetch.so @pparam=bg_fetch.config This works: @plugin=background_fetch.so @pparam=etc/trafficserver/bg_fetch.config This PR restores the original behavior so that both configurations shown above work. You can merge this pull request into a Git repository by running: $ git pull https://github.com/jrushford/trafficserver TS-5050 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/trafficserver/pull/1218.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1218 commit 42ffc818416a5486d42bb51190f064db05e7e4e5 Author: John J. Rushford <jrushf...@apache.org> Date: 2016-11-11T20:31:33Z TS-5050: The background_fetch plugin fails to check for config files relative to the config dir etc/trafficserver. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver pull request #1208: TS-4514: Transaction hangs when no_dns_jus...
GitHub user jrushford reopened a pull request: https://github.com/apache/trafficserver/pull/1208 TS-4514: Transaction hangs when no_dns_just_forward is configured but⦠⦠parent proxy is unresolvable (#699) It doesn't really make sense for the parent selection layer to be aware of the no_dns flag. Calling code handles takes the flag into account. (cherry picked from commit 52843c023800370781e69fec45c3952edf8a307b) Conflicts: proxy/ParentRoundRobin.cc proxy/ParentSelection.cc You can merge this pull request into a Git repository by running: $ git pull https://github.com/jrushford/trafficserver TS-4514 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/trafficserver/pull/1208.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1208 commit 9b9b2a30f5fb6331a9ba3e9df2d1a46bb8aa015e Author: Uri Shachar <ushac...@apache.org> Date: 2016-06-09T07:11:18Z TS-4514: Transaction hangs when no_dns_just_forward is configured but parent proxy is unresolvable (#699) It doesn't really make sense for the parent selection layer to be aware of the no_dns flag. Calling code handles takes the flag into account. (cherry picked from commit 52843c023800370781e69fec45c3952edf8a307b) Conflicts: proxy/ParentRoundRobin.cc proxy/ParentSelection.cc --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver pull request #1208: TS-4514: Transaction hangs when no_dns_jus...
Github user jrushford closed the pull request at: https://github.com/apache/trafficserver/pull/1208 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver pull request #1208: TS-4514: Transaction hangs when no_dns_jus...
GitHub user jrushford opened a pull request: https://github.com/apache/trafficserver/pull/1208 TS-4514: Transaction hangs when no_dns_just_forward is configured but⦠⦠parent proxy is unresolvable (#699) It doesn't really make sense for the parent selection layer to be aware of the no_dns flag. Calling code handles takes the flag into account. (cherry picked from commit 52843c023800370781e69fec45c3952edf8a307b) Conflicts: proxy/ParentRoundRobin.cc proxy/ParentSelection.cc You can merge this pull request into a Git repository by running: $ git pull https://github.com/jrushford/trafficserver TS-4514 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/trafficserver/pull/1208.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1208 commit 9b9b2a30f5fb6331a9ba3e9df2d1a46bb8aa015e Author: Uri Shachar <ushac...@apache.org> Date: 2016-06-09T07:11:18Z TS-4514: Transaction hangs when no_dns_just_forward is configured but parent proxy is unresolvable (#699) It doesn't really make sense for the parent selection layer to be aware of the no_dns flag. Calling code handles takes the flag into account. (cherry picked from commit 52843c023800370781e69fec45c3952edf8a307b) Conflicts: proxy/ParentRoundRobin.cc proxy/ParentSelection.cc --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1198: Add failcount and threshold values in parent sele...
Github user jrushford commented on the issue: https://github.com/apache/trafficserver/pull/1198 @sekimura - this seems reasonable. Can you create a JIRA ticket to go along with this PR and amend the commit message with the JIRA ticket? The commit message would be "TS-: Add failcount and threshold values in parent selection logging." thanks --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver pull request #1178: TS-4942: simple retry is not working corre...
GitHub user jrushford opened a pull request: https://github.com/apache/trafficserver/pull/1178 TS-4942: simple retry is not working correctly. (cherry picked from commit 1fdc8ab1f229e8c6d00b34bcd64fff23c9c01ddf) conflicts resolved. Conflicts: proxy/http/HttpTransact.cc You can merge this pull request into a Git repository by running: $ git pull https://github.com/jrushford/trafficserver ts-4942 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/trafficserver/pull/1178.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1178 commit b4837254eeea0bf0ca5a37ed02b62ac637cf4661 Author: John J. Rushford <jrushf...@apache.org> Date: 2016-10-07T17:29:20Z TS-4942: simple retry is not working correctly. (cherry picked from commit 1fdc8ab1f229e8c6d00b34bcd64fff23c9c01ddf) conflicts resolved. Conflicts: proxy/http/HttpTransact.cc --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver pull request #1177: TS-4391: Duplicated parent origin retry ty...
GitHub user jrushford opened a pull request: https://github.com/apache/trafficserver/pull/1177 TS-4391: Duplicated parent origin retry types (cherry picked from commit 6d4637ce33ab5375cb03c06899f7ab15eb293e7e) conflicts were properly resolved. Conflicts: proxy/http/HttpTransact.cc You can merge this pull request into a Git repository by running: $ git pull https://github.com/jrushford/trafficserver ts-4391 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/trafficserver/pull/1177.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1177 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver pull request #1176: TS-4845: NULL dereference in url_sig
GitHub user jrushford opened a pull request: https://github.com/apache/trafficserver/pull/1176 TS-4845: NULL dereference in url_sig (cherry picked from commit 6b4100c1200e309e229c9fdd24004e1d4fb59c9a) backport PR to 6.2.1 You can merge this pull request into a Git repository by running: $ git pull https://github.com/jrushford/trafficserver ts-4845 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/trafficserver/pull/1176.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1176 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1171: TS-4957: Make the use of madvise() with MADV_DONT...
Github user jrushford commented on the issue: https://github.com/apache/trafficserver/pull/1171 removed unused variable in Eventsystem.cc and squashed commits. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1171: TS-4957: Make the use of madvise() with MADV_DONT...
Github user jrushford commented on the issue: https://github.com/apache/trafficserver/pull/1171 [approve ci] --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1171: TS-4957: Make the use of madvise() with MADV_DONT...
Github user jrushford commented on the issue: https://github.com/apache/trafficserver/pull/1171 oops From: Leif Hedstrom <notificati...@github.com> Reply-To: apache/trafficserver <re...@reply.github.com> Date: Wednesday, November 2, 2016 at 12:01 PM To: apache/trafficserver <trafficser...@noreply.github.com> Cc: John Rushford <john_rushf...@cable.comcast.com>, Author <aut...@noreply.github.com> Subject: Re: [apache/trafficserver] TS-4957: Make the use of madvise() with MADV_DONTDUMP configurable. (#1171) EventSystem.o ../../../iocore/eventsystem/EventSystem.cc:38:7: error: unused variable 'iobuffer_advice' [-Werror,-Wunused-variable] int iobuffer_advice = 0; ^ â You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1171: TS-4957: Make the use of madvise() with MADV_DONT...
Github user jrushford commented on the issue: https://github.com/apache/trafficserver/pull/1171 This PR is for backport to 6.2.1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver pull request #1171: TS-4957: Make the use of madvise() with MA...
GitHub user jrushford opened a pull request: https://github.com/apache/trafficserver/pull/1171 TS-4957: Make the use of madvise() with MADV_DONTDUMP configurable. (cherry picked from commit 514d3fd7de5841b8a74cd32bed001db9b479764f) Backport PR to 6.2.x You can merge this pull request into a Git repository by running: $ git pull https://github.com/jrushford/trafficserver ts-4957 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/trafficserver/pull/1171.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1171 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver pull request #1097: TS-4957: Make the use of madvise() with MA...
Github user jrushford closed the pull request at: https://github.com/apache/trafficserver/pull/1097 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1097: TS-4957: Make the use of madvise() with MADV_DONT...
Github user jrushford commented on the issue: https://github.com/apache/trafficserver/pull/1097 Thanks @jpeach. FWIW, this patch is originally from TS-3417 and @PSUdaemon and I dug it up after we discovered we had a problem with madvise() and to fix, required deploying a new rpm to 1300+ proxies. I'm okay with the name change and will make it if @zwoop and @PSUdaemon agree. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1097: Make the use of madvise() with MADV_DONTDUMP conf...
Github user jrushford commented on the issue: https://github.com/apache/trafficserver/pull/1097 @jpeach and @PSUdaemon - I've made iobuffer_advice a local variable. Tested and it is working okay. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver pull request #1097: Make the use of madvise() with MADV_DONTDU...
Github user jrushford commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/1097#discussion_r83866632 --- Diff: iocore/eventsystem/I_IOBuffer.h --- @@ -58,6 +58,7 @@ class VIO; inkcoreapi extern int64_t max_iobuffer_size; extern int64_t default_small_iobuffer_size; extern int64_t default_large_iobuffer_size; // matched to size of OS buffers +extern int iobuffer_advice; --- End diff -- @jpeach I'd like to land this as is and write a JIRA to come back to the global variable once we've had time to evaluate this. Are you okay with this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver pull request #1084: TS-4701: Add a new latched parent selectio...
Github user jrushford closed the pull request at: https://github.com/apache/trafficserver/pull/1084 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver pull request #1097: Make the use of madvise() with MADV_DONTDU...
Github user jrushford commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/1097#discussion_r83292609
--- Diff: iocore/eventsystem/EventSystem.cc ---
@@ -51,5 +51,15 @@ ink_event_system_init(ModuleVersion v)
if (default_large_iobuffer_size > max_iobuffer_size) {
default_large_iobuffer_size = max_iobuffer_size;
}
+
+#ifdef MADV_DONTDUMP // This should only exist on Linux 3.4 and higher.
+ bool dont_dump_enabled;
--- End diff --
done
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request #1085: TS-4942: simple retry is not working corre...
Github user jrushford closed the pull request at: https://github.com/apache/trafficserver/pull/1085 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1084: TS-4701: Add a new latched parent selection strat...
Github user jrushford commented on the issue: https://github.com/apache/trafficserver/pull/1084 [approve ci] --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1084: TS-4701: Add a new latched parent selection strat...
Github user jrushford commented on the issue: https://github.com/apache/trafficserver/pull/1084 @zwoop - are you okay on this PR? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver pull request #1097: Make the use of madvise() with MADV_DONTDU...
Github user jrushford commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/1097#discussion_r83227421
--- Diff: iocore/eventsystem/EventSystem.cc ---
@@ -51,5 +51,15 @@ ink_event_system_init(ModuleVersion v)
if (default_large_iobuffer_size > max_iobuffer_size) {
default_large_iobuffer_size = max_iobuffer_size;
}
+
+#ifdef MADV_DONTDUMP // This should only exist on Linux 3.4 and higher.
+ bool dont_dump_enabled;
--- End diff --
done
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1097: Make the use of madvise() with MADV_DONTDUMP conf...
Github user jrushford commented on the issue: https://github.com/apache/trafficserver/pull/1097 [approve ci] --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1097: Make the use of madvise() with MADV_DONTDUMP conf...
Github user jrushford commented on the issue: https://github.com/apache/trafficserver/pull/1097 @PSUdaemon - requested changes have been made and squashed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver pull request #1097: Make the use of madvise() with MADV_DONTDU...
Github user jrushford commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/1097#discussion_r82902604
--- Diff: iocore/eventsystem/EventSystem.cc ---
@@ -51,5 +51,15 @@ ink_event_system_init(ModuleVersion v)
if (default_large_iobuffer_size > max_iobuffer_size) {
default_large_iobuffer_size = max_iobuffer_size;
}
+
+#ifdef MADV_DONTDUMP // This should only exist on Linux 3.4 and higher.
+ bool dont_dump_enabled;
+ RecGetRecordBool("proxy.config.allocator.dontdump_iobuffers", (RecBool
*)_dump_enabled, false);
+
+ if (dont_dump_enabled) {
+iobuffer_advice = MADV_DONTDUMP;
--- End diff --
Changes were made and squashed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request #1097: Make the use of madvise() with MADV_DONTDU...
Github user jrushford commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/1097#discussion_r82898723
--- Diff: mgmt/RecordsConfig.cc ---
@@ -1449,6 +1449,8 @@ static const RecordElement RecordsConfig[] =
,
{RECT_CONFIG, "proxy.config.allocator.hugepages", RECD_INT, "0",
RECU_RESTART_TS, RR_NULL, RECC_NULL, "[0-1]", RECA_NULL}
,
+ {RECT_CONFIG, "proxy.config.allocator.dontdump_iobuffers", RECD_INT,
"0", RECU_RESTART_TS, RR_NULL, RECC_NULL, "[0-1]", RECA_NULL}
--- End diff --
Okay, I'll make the change and update the doc.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request #1097: Make the use of madvise() with MADV_DONTDU...
Github user jrushford commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/1097#discussion_r82898472
--- Diff: iocore/eventsystem/EventSystem.cc ---
@@ -51,5 +51,15 @@ ink_event_system_init(ModuleVersion v)
if (default_large_iobuffer_size > max_iobuffer_size) {
default_large_iobuffer_size = max_iobuffer_size;
}
+
+#ifdef MADV_DONTDUMP // This should only exist on Linux 3.4 and higher.
+ bool dont_dump_enabled;
+ RecGetRecordBool("proxy.config.allocator.dontdump_iobuffers", (RecBool
*)_dump_enabled, false);
+
+ if (dont_dump_enabled) {
+iobuffer_advice = MADV_DONTDUMP;
--- End diff --
Good idea, I'll make the change.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request #1097: Make the use of madvise() with MADV_DONTDU...
GitHub user jrushford opened a pull request: https://github.com/apache/trafficserver/pull/1097 Make the use of madvise() with MADV_DONTDUMP configurable. We have seen high cpu loads and high time to serve problems in our production platform when using madvise() with the MADV_DONTDUMP option. This appears to be a kernel issue with madvise(). in order to avoid having to rebuild ats, this PR uses a patch from TS-3417 to make the use of madvise() with the MADV_DONTDUMP flag configurable. You can merge this pull request into a Git repository by running: $ git pull https://github.com/jrushford/trafficserver TS-4957 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/trafficserver/pull/1097.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1097 commit f1c37818622fc0fc4e05614c7f1f83a10fe8c063 Author: John J. Rushford <jrushf...@apache.org> Date: 2016-10-11T21:37:01Z Make the use of madvise() with MADV_DONTDUMP configurable. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver pull request #1085: TS-44942: simple retry is not working corr...
GitHub user jrushford opened a pull request: https://github.com/apache/trafficserver/pull/1085 TS-44942: simple retry is not working correctly. Fix for simple retry. You can merge this pull request into a Git repository by running: $ git pull https://github.com/jrushford/trafficserver TS-4942 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/trafficserver/pull/1085.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1085 commit 2dadaf59c6d72e41f99b2b6b0d3d269d2cd754ec Author: John J. Rushford <jrushf...@apache.org> Date: 2016-10-07T17:29:20Z TS-44942: simple retry is not working correctly. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver pull request #1084: TS-4701: Add a new latched parent selectio...
Github user jrushford commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/1084#discussion_r82292764 --- Diff: doc/admin-guide/files/parent.config.en.rst --- @@ -207,6 +207,13 @@ The following list shows the possible actions and their allowed values. The other traffic is unaffected. Once the downed parent becomes available, the traffic distribution returns to the pre-down state. +- ``latched`` - The first parent in the list is marked as primary and is + always chosen until connection errors cause it to be marked down. When + this occurs the next parent in the list then becomes primary. The primary + will wrap back to the first parent in the list when it is the last parent + in the list and is marked down due to a connection error. Newly chosen + primary parents marked as unavilable will then be restored if the failure --- End diff -- thanks, i've fixed that. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver pull request #1084: TS-4701: Add a new latched parent selectio...
Github user jrushford commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/1084#discussion_r82285415
--- Diff: proxy/ParentSelection.h ---
@@ -59,12 +59,7 @@ enum ParentResultType {
PARENT_FAIL,
};
-enum ParentRR_t {
- P_NO_ROUND_ROBIN = 0,
- P_STRICT_ROUND_ROBIN,
- P_HASH_ROUND_ROBIN,
- P_CONSISTENT_HASH,
-};
+enum ParentRR_t { P_NO_ROUND_ROBIN = 0, P_STRICT_ROUND_ROBIN,
P_HASH_ROUND_ROBIN, P_CONSISTENT_HASH, P_LATCHED_ROUND_ROBIN };
--- End diff --
Oops, I'll fix that.
The interfaces are defined in ParentSelection.h and the enum is used in
both ParentSelection.cc, ParentConsistentHash.cc and ParentRoundRobin.cc all of
which include ParentSelection.h
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request #1084: TS-4701: Add a new latched parent selectio...
GitHub user jrushford opened a pull request: https://github.com/apache/trafficserver/pull/1084 TS-4701: Add a new latched parent selection strategy. Add a new "latched" round robin parent selection strategy. A primary parent is chosen from the first parent in the parent list and is always returned as the resulting call to findParent(). When connection failure occurs and the primary parent is marked down, the state changes the primary to the next parent in the list and remains latched until the state is changed when a error causes the primary parent to be marked down. This strategy is helpful for delivery of live video. A failure and switch to a new parent origin will cause a video client to retune as the manifest and video fragment names between origins are different. With the other strategies, once the retry time for a marked down parent has elapsed, another switch and retune may occur. To keep retunes to a minimum, this strategy "latches" state to always use the same healthy parent. You can merge this pull request into a Git repository by running: $ git pull https://github.com/jrushford/trafficserver TS-4701 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/trafficserver/pull/1084.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1084 commit ebcf828ae6300db7d770abc35fef16a8b9c82e89 Author: John J. Rushford <jrushf...@apache.org> Date: 2016-10-06T20:22:59Z TS-4701: Add a new latched parent selection strategy. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver pull request #834: TS-4707 : Parent Consistent Hash Selection ...
Github user jrushford closed the pull request at: https://github.com/apache/trafficserver/pull/834 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1041: TS-4887 : Clean up Parent Selection URL feature
Github user jrushford commented on the issue: https://github.com/apache/trafficserver/pull/1041 @pbchou - thanks for the variable name change. I havent started on TS-4025 yet but, I'll proably use that pointer so go ahead and leave the cache_lookup pointer but fix the debug. docs look okay. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver pull request #1009: TS-4853 : Parent Consistent Hash Selection...
Github user jrushford closed the pull request at: https://github.com/apache/trafficserver/pull/1009 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1009: TS-4853 : Parent Consistent Hash Selection - add ...
Github user jrushford commented on the issue: https://github.com/apache/trafficserver/pull/1009 @pbchou - could you squash the 2 commits to one. If you wouldn't mind, while you're at it, could you also rename the 'const char *tmp' pointer to something more meaningful in ParentConsistentHash::getPathHash(). It's alway been called 'tmp' but there was a comment suggesting a name change. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #834: TS-4707 : Parent Consistent Hash Selection - add f...
Github user jrushford commented on the issue: https://github.com/apache/trafficserver/pull/834 @pbchou - Yeah we missed 7.0, everyone including myself were working on patches and bug fixes for 7.0 from a recent bug scrub. As for these PR's they could go in for 7.1 and later. I requested an API review on the dev mailing list for the PR with the new API functions. I'm waiting for people to have the chance to review and discuss as part of the review. I'll keep you posted. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver pull request #1015: TS-4845: NULL dereference in url_sig
Github user jrushford closed the pull request at: https://github.com/apache/trafficserver/pull/1015 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver pull request #1015: TS-4845: NULL dereference in url_sig
Github user jrushford commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/1015#discussion_r78652614
--- Diff: plugins/experimental/url_sig/url_sig.c ---
@@ -561,7 +561,9 @@ TSRemapDoRemap(void *ih, TSHttpTxn txnp,
TSRemapRequestInfo *rri)
/* * Allow * */
allow:
- app_qry = getAppQueryString(query, strlen(query));
+ if (query != NULL) {
+app_qry = getAppQueryString(query, strlen(query));
+ }
--- End diff --
Yes, thanks for the catch!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1015: TS-4845: NULL dereference in url_sig
Github user jrushford commented on the issue: https://github.com/apache/trafficserver/pull/1015 [approve ci] --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver pull request #1015: TS-4845: NULL dereference in url_sig
GitHub user jrushford opened a pull request: https://github.com/apache/trafficserver/pull/1015 TS-4845: NULL dereference in url_sig Fix a NULL dereference in url_sig. You can merge this pull request into a Git repository by running: $ git pull https://github.com/jrushford/trafficserver TS-4845 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/trafficserver/pull/1015.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1015 commit 6b4100c1200e309e229c9fdd24004e1d4fb59c9a Author: John J. Rushford <jrushf...@apache.org> Date: 2016-09-13T21:08:52Z TS-4845: NULL dereference in url_sig --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #834: TS-4707 : Parent Consistent Hash Selection - add f...
Github user jrushford commented on the issue: https://github.com/apache/trafficserver/pull/834 @pbchou, thanks i look at this and get an API review started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
