[jira] [Commented] (TS-2082) Remove NON_MODULAR #ifdef and others
[
https://issues.apache.org/jira/browse/TS-2082?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13842113#comment-13842113
]
ASF subversion and git services commented on TS-2082:
-
Commit 0b3367a8e1f52cf2ac3ca8c458156f11e89bfa70 in branch refs/heads/master
from [~zym]
[ https://git-wip-us.apache.org/repos/asf?p=trafficserver.git;h=0b3367a ]
TS-2082: remove FIXME_NONMODULAR defines
> Remove NON_MODULAR #ifdef and others
>
>
> Key: TS-2082
> URL: https://issues.apache.org/jira/browse/TS-2082
> Project: Traffic Server
> Issue Type: Improvement
> Components: Core
>Reporter: Leif Hedstrom
>Assignee: Zhao Yongming
> Labels: cleanup
> Fix For: 5.0.0
>
> Attachments: 0001-TS-2082-remove-STANDALONE_IOCORE-defines.patch,
> 0001-fix-build-with-enable-standalone-iocore.patch,
> 0002-TS-2082-remove-NON_MODULAR-define.patch
>
>
> {code}
> #if TS_HAS_STANDALONE_IOCORE
> # define STANDALONE_IOCORE 1
> #else
> # define FIXME_NONMODULAR 1
> # define SPLIT_DNS 1
> # define NON_MODULAR1
> # define HTTP_CACHE 1
> #endif
> {code}
> all those ifdefine states relate to some work to make iocore portable to
> other project, that we don't have any interest right now.
> I think all those define should be cleanup to make codes alive, and we do not
> need to make a stand alone library right now. when we need to make the iocore
> into a library, we don't use #ifdefine.
> let us nuke them
--
This message was sent by Atlassian JIRA
(v6.1#6144)
[jira] [Commented] (TS-2082) Remove NON_MODULAR #ifdef and others
[
https://issues.apache.org/jira/browse/TS-2082?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13842103#comment-13842103
]
ASF subversion and git services commented on TS-2082:
-
Commit db8052d5760fb1882057561b8e4250b6939235df in branch refs/heads/master
from [~zym]
[ https://git-wip-us.apache.org/repos/asf?p=trafficserver.git;h=db8052d ]
add TS-2082
> Remove NON_MODULAR #ifdef and others
>
>
> Key: TS-2082
> URL: https://issues.apache.org/jira/browse/TS-2082
> Project: Traffic Server
> Issue Type: Improvement
> Components: Core
>Reporter: Leif Hedstrom
>Assignee: Zhao Yongming
> Labels: cleanup
> Fix For: 5.0.0
>
> Attachments: 0001-TS-2082-remove-STANDALONE_IOCORE-defines.patch,
> 0001-fix-build-with-enable-standalone-iocore.patch,
> 0002-TS-2082-remove-NON_MODULAR-define.patch
>
>
> {code}
> #if TS_HAS_STANDALONE_IOCORE
> # define STANDALONE_IOCORE 1
> #else
> # define FIXME_NONMODULAR 1
> # define SPLIT_DNS 1
> # define NON_MODULAR1
> # define HTTP_CACHE 1
> #endif
> {code}
> all those ifdefine states relate to some work to make iocore portable to
> other project, that we don't have any interest right now.
> I think all those define should be cleanup to make codes alive, and we do not
> need to make a stand alone library right now. when we need to make the iocore
> into a library, we don't use #ifdefine.
> let us nuke them
--
This message was sent by Atlassian JIRA
(v6.1#6144)
[jira] [Commented] (TS-2082) Remove NON_MODULAR #ifdef and others
[
https://issues.apache.org/jira/browse/TS-2082?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13842101#comment-13842101
]
ASF subversion and git services commented on TS-2082:
-
Commit 5140b18d0c15be1b532edab8c92b00b7c862324f in branch refs/heads/master
from [~zym]
[ https://git-wip-us.apache.org/repos/asf?p=trafficserver.git;h=5140b18 ]
TS-2082: remove NON_MODULAR define
> Remove NON_MODULAR #ifdef and others
>
>
> Key: TS-2082
> URL: https://issues.apache.org/jira/browse/TS-2082
> Project: Traffic Server
> Issue Type: Improvement
> Components: Core
>Reporter: Leif Hedstrom
>Assignee: Zhao Yongming
> Labels: cleanup
> Fix For: 5.0.0
>
> Attachments: 0001-TS-2082-remove-STANDALONE_IOCORE-defines.patch,
> 0001-fix-build-with-enable-standalone-iocore.patch,
> 0002-TS-2082-remove-NON_MODULAR-define.patch
>
>
> {code}
> #if TS_HAS_STANDALONE_IOCORE
> # define STANDALONE_IOCORE 1
> #else
> # define FIXME_NONMODULAR 1
> # define SPLIT_DNS 1
> # define NON_MODULAR1
> # define HTTP_CACHE 1
> #endif
> {code}
> all those ifdefine states relate to some work to make iocore portable to
> other project, that we don't have any interest right now.
> I think all those define should be cleanup to make codes alive, and we do not
> need to make a stand alone library right now. when we need to make the iocore
> into a library, we don't use #ifdefine.
> let us nuke them
--
This message was sent by Atlassian JIRA
(v6.1#6144)
[jira] [Commented] (TS-2082) Remove NON_MODULAR #ifdef and others
[
https://issues.apache.org/jira/browse/TS-2082?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13842100#comment-13842100
]
ASF subversion and git services commented on TS-2082:
-
Commit 51ce9aec5fe8edb129c4cf1df29accdac35c5222 in branch refs/heads/master
from [~zym]
[ https://git-wip-us.apache.org/repos/asf?p=trafficserver.git;h=51ce9ae ]
TS-2082: remove STANDALONE_IOCORE defines
> Remove NON_MODULAR #ifdef and others
>
>
> Key: TS-2082
> URL: https://issues.apache.org/jira/browse/TS-2082
> Project: Traffic Server
> Issue Type: Improvement
> Components: Core
>Reporter: Leif Hedstrom
>Assignee: Zhao Yongming
> Labels: cleanup
> Fix For: 5.0.0
>
> Attachments: 0001-TS-2082-remove-STANDALONE_IOCORE-defines.patch,
> 0001-fix-build-with-enable-standalone-iocore.patch,
> 0002-TS-2082-remove-NON_MODULAR-define.patch
>
>
> {code}
> #if TS_HAS_STANDALONE_IOCORE
> # define STANDALONE_IOCORE 1
> #else
> # define FIXME_NONMODULAR 1
> # define SPLIT_DNS 1
> # define NON_MODULAR1
> # define HTTP_CACHE 1
> #endif
> {code}
> all those ifdefine states relate to some work to make iocore portable to
> other project, that we don't have any interest right now.
> I think all those define should be cleanup to make codes alive, and we do not
> need to make a stand alone library right now. when we need to make the iocore
> into a library, we don't use #ifdefine.
> let us nuke them
--
This message was sent by Atlassian JIRA
(v6.1#6144)
[jira] [Commented] (TS-2082) Remove NON_MODULAR #ifdef and others
[
https://issues.apache.org/jira/browse/TS-2082?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13841480#comment-13841480
]
Leif Hedstrom commented on TS-2082:
---
[~zym] What's the status on this bug ?
> Remove NON_MODULAR #ifdef and others
>
>
> Key: TS-2082
> URL: https://issues.apache.org/jira/browse/TS-2082
> Project: Traffic Server
> Issue Type: Improvement
> Components: Core
>Reporter: Leif Hedstrom
>Assignee: Zhao Yongming
> Labels: cleanup
> Fix For: 5.0.0
>
> Attachments: 0001-TS-2082-remove-STANDALONE_IOCORE-defines.patch,
> 0001-fix-build-with-enable-standalone-iocore.patch,
> 0002-TS-2082-remove-NON_MODULAR-define.patch
>
>
> {code}
> #if TS_HAS_STANDALONE_IOCORE
> # define STANDALONE_IOCORE 1
> #else
> # define FIXME_NONMODULAR 1
> # define SPLIT_DNS 1
> # define NON_MODULAR1
> # define HTTP_CACHE 1
> #endif
> {code}
> all those ifdefine states relate to some work to make iocore portable to
> other project, that we don't have any interest right now.
> I think all those define should be cleanup to make codes alive, and we do not
> need to make a stand alone library right now. when we need to make the iocore
> into a library, we don't use #ifdefine.
> let us nuke them
--
This message was sent by Atlassian JIRA
(v6.1#6144)
[jira] [Commented] (TS-2082) Remove NON_MODULAR #ifdef and others
[
https://issues.apache.org/jira/browse/TS-2082?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13830689#comment-13830689
]
ASF subversion and git services commented on TS-2082:
-
Commit 123785de08b966f271be78d94844d4c5ebb30425 in branch refs/heads/master
from [~zym]
[ https://git-wip-us.apache.org/repos/asf?p=trafficserver.git;h=123785d ]
TS-2082: fix build with --enable-standalone-iocore
This is redo of the 94215bf293d76d27a88a0fc9e35356321310fbf5.
and with a fix of the cache regression testing.
This also reverts commit b9b1bdc81fa1b7e3b1edb54de938d1ea0aec2d7a.
> Remove NON_MODULAR #ifdef and others
>
>
> Key: TS-2082
> URL: https://issues.apache.org/jira/browse/TS-2082
> Project: Traffic Server
> Issue Type: Improvement
> Components: Core
>Reporter: Leif Hedstrom
>Assignee: Zhao Yongming
> Labels: cleanup
> Fix For: 5.0.0
>
> Attachments: 0001-TS-2082-remove-STANDALONE_IOCORE-defines.patch,
> 0001-fix-build-with-enable-standalone-iocore.patch,
> 0002-TS-2082-remove-NON_MODULAR-define.patch
>
>
> {code}
> #if TS_HAS_STANDALONE_IOCORE
> # define STANDALONE_IOCORE 1
> #else
> # define FIXME_NONMODULAR 1
> # define SPLIT_DNS 1
> # define NON_MODULAR1
> # define HTTP_CACHE 1
> #endif
> {code}
> all those ifdefine states relate to some work to make iocore portable to
> other project, that we don't have any interest right now.
> I think all those define should be cleanup to make codes alive, and we do not
> need to make a stand alone library right now. when we need to make the iocore
> into a library, we don't use #ifdefine.
> let us nuke them
--
This message was sent by Atlassian JIRA
(v6.1#6144)
[jira] [Commented] (TS-2082) Remove NON_MODULAR #ifdef and others
[
https://issues.apache.org/jira/browse/TS-2082?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13823813#comment-13823813
]
ASF subversion and git services commented on TS-2082:
-
Commit b9b1bdc81fa1b7e3b1edb54de938d1ea0aec2d7a in branch refs/heads/master
from [~psudaemon]
[ https://git-wip-us.apache.org/repos/asf?p=trafficserver.git;h=b9b1bdc ]
Revert "TS-2082: fix build with --enable-standalone-iocore"
This reverts commit 94215bf293d76d27a88a0fc9e35356321310fbf5.
This broke some cache regression tests and we are reverting it until
those can be addressed.
> Remove NON_MODULAR #ifdef and others
>
>
> Key: TS-2082
> URL: https://issues.apache.org/jira/browse/TS-2082
> Project: Traffic Server
> Issue Type: Improvement
> Components: Core
>Reporter: Leif Hedstrom
>Assignee: Zhao Yongming
> Labels: cleanup
> Fix For: 5.0.0
>
> Attachments: 0001-TS-2082-remove-STANDALONE_IOCORE-defines.patch,
> 0001-fix-build-with-enable-standalone-iocore.patch,
> 0002-TS-2082-remove-NON_MODULAR-define.patch
>
>
> {code}
> #if TS_HAS_STANDALONE_IOCORE
> # define STANDALONE_IOCORE 1
> #else
> # define FIXME_NONMODULAR 1
> # define SPLIT_DNS 1
> # define NON_MODULAR1
> # define HTTP_CACHE 1
> #endif
> {code}
> all those ifdefine states relate to some work to make iocore portable to
> other project, that we don't have any interest right now.
> I think all those define should be cleanup to make codes alive, and we do not
> need to make a stand alone library right now. when we need to make the iocore
> into a library, we don't use #ifdefine.
> let us nuke them
--
This message was sent by Atlassian JIRA
(v6.1#6144)
[jira] [Commented] (TS-2082) Remove NON_MODULAR #ifdef and others
[
https://issues.apache.org/jira/browse/TS-2082?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13815971#comment-13815971
]
Zhao Yongming commented on TS-2082:
---
the next step is to remove HTTP_CACHE SPLIT_DNS and FIXME_NONMODULAR defines.
but for HTTP_CACHE, there the code is something good when you can find out
which parts is not following the origin desgin or distinct from the other
parts, it will easy the task when we need to split the big components into
small ones
> Remove NON_MODULAR #ifdef and others
>
>
> Key: TS-2082
> URL: https://issues.apache.org/jira/browse/TS-2082
> Project: Traffic Server
> Issue Type: Improvement
> Components: Core
>Reporter: Leif Hedstrom
>Assignee: Zhao Yongming
> Labels: cleanup
> Fix For: 5.0.0
>
> Attachments: 0001-TS-2082-remove-STANDALONE_IOCORE-defines.patch,
> 0001-fix-build-with-enable-standalone-iocore.patch,
> 0002-TS-2082-remove-NON_MODULAR-define.patch
>
>
> {code}
> #if TS_HAS_STANDALONE_IOCORE
> # define STANDALONE_IOCORE 1
> #else
> # define FIXME_NONMODULAR 1
> # define SPLIT_DNS 1
> # define NON_MODULAR1
> # define HTTP_CACHE 1
> #endif
> {code}
> all those ifdefine states relate to some work to make iocore portable to
> other project, that we don't have any interest right now.
> I think all those define should be cleanup to make codes alive, and we do not
> need to make a stand alone library right now. when we need to make the iocore
> into a library, we don't use #ifdefine.
> let us nuke them
--
This message was sent by Atlassian JIRA
(v6.1#6144)
[jira] [Commented] (TS-2082) Remove NON_MODULAR #ifdef and others
[
https://issues.apache.org/jira/browse/TS-2082?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13815617#comment-13815617
]
ASF subversion and git services commented on TS-2082:
-
Commit 94215bf293d76d27a88a0fc9e35356321310fbf5 in branch refs/heads/master
from [~zym]
[ https://git-wip-us.apache.org/repos/asf?p=trafficserver.git;h=94215bf ]
TS-2082: fix build with --enable-standalone-iocore
before we remove that completely, get it work fist.
> Remove NON_MODULAR #ifdef and others
>
>
> Key: TS-2082
> URL: https://issues.apache.org/jira/browse/TS-2082
> Project: Traffic Server
> Issue Type: Improvement
> Components: Core
>Reporter: Leif Hedstrom
> Labels: cleanup
> Fix For: 5.0.0
>
> Attachments: 0001-fix-build-with-enable-standalone-iocore.patch
>
>
> {code}
> #if TS_HAS_STANDALONE_IOCORE
> # define STANDALONE_IOCORE 1
> #else
> # define FIXME_NONMODULAR 1
> # define SPLIT_DNS 1
> # define NON_MODULAR1
> # define HTTP_CACHE 1
> #endif
> {code}
> all those ifdefine states relate to some work to make iocore portable to
> other project, that we don't have any interest right now.
> I think all those define should be cleanup to make codes alive, and we do not
> need to make a stand alone library right now. when we need to make the iocore
> into a library, we don't use #ifdefine.
> let us nuke them
--
This message was sent by Atlassian JIRA
(v6.1#6144)
[jira] [Commented] (TS-2082) Remove NON_MODULAR #ifdef and others
[
https://issues.apache.org/jira/browse/TS-2082?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13813619#comment-13813619
]
Zhao Yongming commented on TS-2082:
---
I have a patch to cleanup the standalone iocore building that based on TS-2172.
> Remove NON_MODULAR #ifdef and others
>
>
> Key: TS-2082
> URL: https://issues.apache.org/jira/browse/TS-2082
> Project: Traffic Server
> Issue Type: Improvement
> Components: Core
>Reporter: Leif Hedstrom
> Labels: cleanup
> Fix For: 5.0.0
>
>
> {code}
> #if TS_HAS_STANDALONE_IOCORE
> # define STANDALONE_IOCORE 1
> #else
> # define FIXME_NONMODULAR 1
> # define SPLIT_DNS 1
> # define NON_MODULAR1
> # define HTTP_CACHE 1
> #endif
> {code}
> all those ifdefine states relate to some work to make iocore portable to
> other project, that we don't have any interest right now.
> I think all those define should be cleanup to make codes alive, and we do not
> need to make a stand alone library right now. when we need to make the iocore
> into a library, we don't use #ifdefine.
> let us nuke them
--
This message was sent by Atlassian JIRA
(v6.1#6144)
