[jira] [Commented] (TS-3917) Sending only SETTINGS_INITIAL_WINDOW_SIZE in SETTINGS Frame

2016-04-27 Thread ASF subversion and git services (JIRA) 

[ 
https://issues.apache.org/jira/browse/TS-3917?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15260881#comment-15260881
 ] 

ASF subversion and git services commented on TS-3917:
-

Commit bac5f0b0df91b048366f08b6f39185559908bff6 in trafficserver's branch 
refs/heads/6.1.x from [~bcall]
[ https://git-wip-us.apache.org/repos/asf?p=trafficserver.git;h=bac5f0b ]

TS-3917: Sending only SETTINGS_INITIAL_WINDOW_SIZE in

This closes #471

(cherry picked from commit baf2d759cd9e2c8de0e17154a7cf4c2c55ba9018)


> Sending only SETTINGS_INITIAL_WINDOW_SIZE in SETTINGS Frame
> ---
>
> Key: TS-3917
> URL: https://issues.apache.org/jira/browse/TS-3917
> Project: Traffic Server
>  Issue Type: Bug
>  Components: HTTP/2
>Reporter: Masaori Koshiba
>Assignee: Bryan Call
>Priority: Critical
> Fix For: 6.2.0
>
>
> After fix for TS-3492, ATS sends only {{SETTINGS_INITIAL_WINDOW_SIZE}} in 
> first SETTINGS Frame.
> ATS should send SETTINGS Parameters when values in records.config is 
> different from default value of RFC7540 (6.5.2 Defined SETTINGS Parameters).
> For example, {{SETTINGS_MAX_CONCURRENT_STREAMS}} is unlimited in RFC7540, but 
> default value in records.config is 100. ATS should send this value in first 
> SETTINGS Frame but not.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (TS-3917) Sending only SETTINGS_INITIAL_WINDOW_SIZE in SETTINGS Frame

2016-02-11 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/TS-3917?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15144069#comment-15144069
 ] 

ASF GitHub Bot commented on TS-3917:


GitHub user bryancall opened a pull request:

https://github.com/apache/trafficserver/pull/471

TS-3917: Sending only SETTINGS_INITIAL_WINDOW_SIZE in SETTINGS Frame



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/bryancall/trafficserver TS-3917

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/trafficserver/pull/471.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #471


commit 7cf04c6053cf1880af7b83dfb43be0eb2b70aeb1
Author: Bryan Call 
Date:   2016-02-12T05:13:16Z

TS-3917: Sending only SETTINGS_INITIAL_WINDOW_SIZE in SETTINGS Frame




> Sending only SETTINGS_INITIAL_WINDOW_SIZE in SETTINGS Frame
> ---
>
> Key: TS-3917
> URL: https://issues.apache.org/jira/browse/TS-3917
> Project: Traffic Server
>  Issue Type: Bug
>  Components: HTTP/2
>Reporter: Masaori Koshiba
>Assignee: Bryan Call
>Priority: Critical
> Fix For: 6.2.0
>
>
> After fix for TS-3492, ATS sends only {{SETTINGS_INITIAL_WINDOW_SIZE}} in 
> first SETTINGS Frame.
> ATS should send SETTINGS Parameters when values in records.config is 
> different from default value of RFC7540 (6.5.2 Defined SETTINGS Parameters).
> For example, {{SETTINGS_MAX_CONCURRENT_STREAMS}} is unlimited in RFC7540, but 
> default value in records.config is 100. ATS should send this value in first 
> SETTINGS Frame but not.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (TS-3917) Sending only SETTINGS_INITIAL_WINDOW_SIZE in SETTINGS Frame

2016-02-11 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/TS-3917?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15144070#comment-15144070
 ] 

ASF GitHub Bot commented on TS-3917:


Github user masaori335 commented on the pull request:

https://github.com/apache/trafficserver/pull/471#issuecomment-183182665
  
+1


> Sending only SETTINGS_INITIAL_WINDOW_SIZE in SETTINGS Frame
> ---
>
> Key: TS-3917
> URL: https://issues.apache.org/jira/browse/TS-3917
> Project: Traffic Server
>  Issue Type: Bug
>  Components: HTTP/2
>Reporter: Masaori Koshiba
>Assignee: Bryan Call
>Priority: Critical
> Fix For: 6.2.0
>
>
> After fix for TS-3492, ATS sends only {{SETTINGS_INITIAL_WINDOW_SIZE}} in 
> first SETTINGS Frame.
> ATS should send SETTINGS Parameters when values in records.config is 
> different from default value of RFC7540 (6.5.2 Defined SETTINGS Parameters).
> For example, {{SETTINGS_MAX_CONCURRENT_STREAMS}} is unlimited in RFC7540, but 
> default value in records.config is 100. ATS should send this value in first 
> SETTINGS Frame but not.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (TS-3917) Sending only SETTINGS_INITIAL_WINDOW_SIZE in SETTINGS Frame

2016-02-11 Thread ASF subversion and git services (JIRA) 

[ 
https://issues.apache.org/jira/browse/TS-3917?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15144075#comment-15144075
 ] 

ASF subversion and git services commented on TS-3917:
-

Commit baf2d759cd9e2c8de0e17154a7cf4c2c55ba9018 in trafficserver's branch 
refs/heads/master from [~bcall]
[ https://git-wip-us.apache.org/repos/asf?p=trafficserver.git;h=baf2d75 ]

TS-3917: Sending only SETTINGS_INITIAL_WINDOW_SIZE in

This closes #471


> Sending only SETTINGS_INITIAL_WINDOW_SIZE in SETTINGS Frame
> ---
>
> Key: TS-3917
> URL: https://issues.apache.org/jira/browse/TS-3917
> Project: Traffic Server
>  Issue Type: Bug
>  Components: HTTP/2
>Reporter: Masaori Koshiba
>Assignee: Bryan Call
>Priority: Critical
> Fix For: 6.2.0
>
>
> After fix for TS-3492, ATS sends only {{SETTINGS_INITIAL_WINDOW_SIZE}} in 
> first SETTINGS Frame.
> ATS should send SETTINGS Parameters when values in records.config is 
> different from default value of RFC7540 (6.5.2 Defined SETTINGS Parameters).
> For example, {{SETTINGS_MAX_CONCURRENT_STREAMS}} is unlimited in RFC7540, but 
> default value in records.config is 100. ATS should send this value in first 
> SETTINGS Frame but not.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (TS-3917) Sending only SETTINGS_INITIAL_WINDOW_SIZE in SETTINGS Frame

2016-02-11 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/TS-3917?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15144076#comment-15144076
 ] 

ASF GitHub Bot commented on TS-3917:


Github user asfgit closed the pull request at:

https://github.com/apache/trafficserver/pull/471


> Sending only SETTINGS_INITIAL_WINDOW_SIZE in SETTINGS Frame
> ---
>
> Key: TS-3917
> URL: https://issues.apache.org/jira/browse/TS-3917
> Project: Traffic Server
>  Issue Type: Bug
>  Components: HTTP/2
>Reporter: Masaori Koshiba
>Assignee: Bryan Call
>Priority: Critical
> Fix For: 6.2.0
>
>
> After fix for TS-3492, ATS sends only {{SETTINGS_INITIAL_WINDOW_SIZE}} in 
> first SETTINGS Frame.
> ATS should send SETTINGS Parameters when values in records.config is 
> different from default value of RFC7540 (6.5.2 Defined SETTINGS Parameters).
> For example, {{SETTINGS_MAX_CONCURRENT_STREAMS}} is unlimited in RFC7540, but 
> default value in records.config is 100. ATS should send this value in first 
> SETTINGS Frame but not.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (TS-3917) Sending only SETTINGS_INITIAL_WINDOW_SIZE in SETTINGS Frame

2016-02-11 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/TS-3917?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15143957#comment-15143957
 ] 

ASF GitHub Bot commented on TS-3917:


Github user zwoop commented on the pull request:

https://github.com/apache/trafficserver/pull/466#issuecomment-183162557
  
+1


> Sending only SETTINGS_INITIAL_WINDOW_SIZE in SETTINGS Frame
> ---
>
> Key: TS-3917
> URL: https://issues.apache.org/jira/browse/TS-3917
> Project: Traffic Server
>  Issue Type: Bug
>  Components: HTTP/2
>Reporter: Masaori Koshiba
>Assignee: Bryan Call
>Priority: Critical
> Fix For: 6.2.0
>
>
> After fix for TS-3492, ATS sends only {{SETTINGS_INITIAL_WINDOW_SIZE}} in 
> first SETTINGS Frame.
> ATS should send SETTINGS Parameters when values in records.config is 
> different from default value of RFC7540 (6.5.2 Defined SETTINGS Parameters).
> For example, {{SETTINGS_MAX_CONCURRENT_STREAMS}} is unlimited in RFC7540, but 
> default value in records.config is 100. ATS should send this value in first 
> SETTINGS Frame but not.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (TS-3917) Sending only SETTINGS_INITIAL_WINDOW_SIZE in SETTINGS Frame

2016-02-11 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/TS-3917?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15143937#comment-15143937
 ] 

ASF GitHub Bot commented on TS-3917:


GitHub user bryancall opened a pull request:

https://github.com/apache/trafficserver/pull/466

TS-3917: Sending only SETTINGS_INITIAL_WINDOW_SIZE in SETTINGS Frame



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/bryancall/trafficserver TS-3917

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/trafficserver/pull/466.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #466


commit 7f7e16884c80b8e8ddfb4f8d56f4ac1bb9635512
Author: Bryan Call 
Date:   2016-02-12T02:58:08Z

TS-3917: Sending only SETTINGS_INITIAL_WINDOW_SIZE in SETTINGS Frame




> Sending only SETTINGS_INITIAL_WINDOW_SIZE in SETTINGS Frame
> ---
>
> Key: TS-3917
> URL: https://issues.apache.org/jira/browse/TS-3917
> Project: Traffic Server
>  Issue Type: Bug
>  Components: HTTP/2
>Reporter: Masaori Koshiba
>Assignee: Bryan Call
>Priority: Critical
> Fix For: 6.2.0
>
>
> After fix for TS-3492, ATS sends only {{SETTINGS_INITIAL_WINDOW_SIZE}} in 
> first SETTINGS Frame.
> ATS should send SETTINGS Parameters when values in records.config is 
> different from default value of RFC7540 (6.5.2 Defined SETTINGS Parameters).
> For example, {{SETTINGS_MAX_CONCURRENT_STREAMS}} is unlimited in RFC7540, but 
> default value in records.config is 100. ATS should send this value in first 
> SETTINGS Frame but not.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (TS-3917) Sending only SETTINGS_INITIAL_WINDOW_SIZE in SETTINGS Frame

2016-02-11 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/TS-3917?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15143994#comment-15143994
 ] 

ASF GitHub Bot commented on TS-3917:


Github user asfgit closed the pull request at:

https://github.com/apache/trafficserver/pull/466


> Sending only SETTINGS_INITIAL_WINDOW_SIZE in SETTINGS Frame
> ---
>
> Key: TS-3917
> URL: https://issues.apache.org/jira/browse/TS-3917
> Project: Traffic Server
>  Issue Type: Bug
>  Components: HTTP/2
>Reporter: Masaori Koshiba
>Assignee: Bryan Call
>Priority: Critical
> Fix For: 6.2.0
>
>
> After fix for TS-3492, ATS sends only {{SETTINGS_INITIAL_WINDOW_SIZE}} in 
> first SETTINGS Frame.
> ATS should send SETTINGS Parameters when values in records.config is 
> different from default value of RFC7540 (6.5.2 Defined SETTINGS Parameters).
> For example, {{SETTINGS_MAX_CONCURRENT_STREAMS}} is unlimited in RFC7540, but 
> default value in records.config is 100. ATS should send this value in first 
> SETTINGS Frame but not.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (TS-3917) Sending only SETTINGS_INITIAL_WINDOW_SIZE in SETTINGS Frame

2016-02-11 Thread ASF subversion and git services (JIRA) 

[ 
https://issues.apache.org/jira/browse/TS-3917?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15143993#comment-15143993
 ] 

ASF subversion and git services commented on TS-3917:
-

Commit 17736704d4f677c93f6854834639b4be63dcd614 in trafficserver's branch 
refs/heads/master from [~bcall]
[ https://git-wip-us.apache.org/repos/asf?p=trafficserver.git;h=1773670 ]

TS-3917: Sending only SETTINGS_INITIAL_WINDOW_SIZE in

This closes #466


> Sending only SETTINGS_INITIAL_WINDOW_SIZE in SETTINGS Frame
> ---
>
> Key: TS-3917
> URL: https://issues.apache.org/jira/browse/TS-3917
> Project: Traffic Server
>  Issue Type: Bug
>  Components: HTTP/2
>Reporter: Masaori Koshiba
>Assignee: Bryan Call
>Priority: Critical
> Fix For: 6.2.0
>
>
> After fix for TS-3492, ATS sends only {{SETTINGS_INITIAL_WINDOW_SIZE}} in 
> first SETTINGS Frame.
> ATS should send SETTINGS Parameters when values in records.config is 
> different from default value of RFC7540 (6.5.2 Defined SETTINGS Parameters).
> For example, {{SETTINGS_MAX_CONCURRENT_STREAMS}} is unlimited in RFC7540, but 
> default value in records.config is 100. ATS should send this value in first 
> SETTINGS Frame but not.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (TS-3917) Sending only SETTINGS_INITIAL_WINDOW_SIZE in SETTINGS Frame

2016-02-11 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/TS-3917?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15144014#comment-15144014
 ] 

ASF GitHub Bot commented on TS-3917:


Github user bryancall commented on the pull request:

https://github.com/apache/trafficserver/pull/466#issuecomment-183174731
  
@masaori335 I am pretty sure the compare when setting the settings uses 
this value to compare with.


> Sending only SETTINGS_INITIAL_WINDOW_SIZE in SETTINGS Frame
> ---
>
> Key: TS-3917
> URL: https://issues.apache.org/jira/browse/TS-3917
> Project: Traffic Server
>  Issue Type: Bug
>  Components: HTTP/2
>Reporter: Masaori Koshiba
>Assignee: Bryan Call
>Priority: Critical
> Fix For: 6.2.0
>
>
> After fix for TS-3492, ATS sends only {{SETTINGS_INITIAL_WINDOW_SIZE}} in 
> first SETTINGS Frame.
> ATS should send SETTINGS Parameters when values in records.config is 
> different from default value of RFC7540 (6.5.2 Defined SETTINGS Parameters).
> For example, {{SETTINGS_MAX_CONCURRENT_STREAMS}} is unlimited in RFC7540, but 
> default value in records.config is 100. ATS should send this value in first 
> SETTINGS Frame but not.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (TS-3917) Sending only SETTINGS_INITIAL_WINDOW_SIZE in SETTINGS Frame

2016-02-11 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/TS-3917?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15144016#comment-15144016
 ] 

ASF GitHub Bot commented on TS-3917:


Github user masaori335 commented on the pull request:

https://github.com/apache/trafficserver/pull/466#issuecomment-183175215
  
@bryancall Oh really? I'll check.


> Sending only SETTINGS_INITIAL_WINDOW_SIZE in SETTINGS Frame
> ---
>
> Key: TS-3917
> URL: https://issues.apache.org/jira/browse/TS-3917
> Project: Traffic Server
>  Issue Type: Bug
>  Components: HTTP/2
>Reporter: Masaori Koshiba
>Assignee: Bryan Call
>Priority: Critical
> Fix For: 6.2.0
>
>
> After fix for TS-3492, ATS sends only {{SETTINGS_INITIAL_WINDOW_SIZE}} in 
> first SETTINGS Frame.
> ATS should send SETTINGS Parameters when values in records.config is 
> different from default value of RFC7540 (6.5.2 Defined SETTINGS Parameters).
> For example, {{SETTINGS_MAX_CONCURRENT_STREAMS}} is unlimited in RFC7540, but 
> default value in records.config is 100. ATS should send this value in first 
> SETTINGS Frame but not.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (TS-3917) Sending only SETTINGS_INITIAL_WINDOW_SIZE in SETTINGS Frame

2016-02-11 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/TS-3917?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15144010#comment-15144010
 ] 

ASF GitHub Bot commented on TS-3917:


Github user masaori335 commented on a diff in the pull request:

https://github.com/apache/trafficserver/pull/466#discussion_r52704287
  
--- Diff: proxy/http2/HTTP2.cc ---
@@ -727,7 +727,7 @@ http2_decode_header_blocks(HTTPHdr *hdr, const uint8_t 
*buf_start, const uint8_t
 }
 
 // Initialize this subsystem with librecords configs (for now)
-uint32_t Http2::max_concurrent_streams = 100;
+uint32_t Http2::max_concurrent_streams = 4294967295;
--- End diff --

This variable is override by `proxy.config.http2.max_concurrent_streams_in` 
in 
[Http2::init()](https://github.com/apache/trafficserver/blob/master/proxy/http2/HTTP2.cc#L743).
IMO, where we should change is `HTTP2_MAX_CONCURRENT_STREAMS` in 
[HTTP2.h#L57](https://github.com/apache/trafficserver/blob/master/proxy/http2/HTTP2.h#L57)


> Sending only SETTINGS_INITIAL_WINDOW_SIZE in SETTINGS Frame
> ---
>
> Key: TS-3917
> URL: https://issues.apache.org/jira/browse/TS-3917
> Project: Traffic Server
>  Issue Type: Bug
>  Components: HTTP/2
>Reporter: Masaori Koshiba
>Assignee: Bryan Call
>Priority: Critical
> Fix For: 6.2.0
>
>
> After fix for TS-3492, ATS sends only {{SETTINGS_INITIAL_WINDOW_SIZE}} in 
> first SETTINGS Frame.
> ATS should send SETTINGS Parameters when values in records.config is 
> different from default value of RFC7540 (6.5.2 Defined SETTINGS Parameters).
> For example, {{SETTINGS_MAX_CONCURRENT_STREAMS}} is unlimited in RFC7540, but 
> default value in records.config is 100. ATS should send this value in first 
> SETTINGS Frame but not.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (TS-3917) Sending only SETTINGS_INITIAL_WINDOW_SIZE in SETTINGS Frame

2016-02-11 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/TS-3917?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15144023#comment-15144023
 ] 

ASF GitHub Bot commented on TS-3917:


Github user bryancall commented on the pull request:

https://github.com/apache/trafficserver/pull/466#issuecomment-183178115
  
@masaori335 You are right :)


> Sending only SETTINGS_INITIAL_WINDOW_SIZE in SETTINGS Frame
> ---
>
> Key: TS-3917
> URL: https://issues.apache.org/jira/browse/TS-3917
> Project: Traffic Server
>  Issue Type: Bug
>  Components: HTTP/2
>Reporter: Masaori Koshiba
>Assignee: Bryan Call
>Priority: Critical
> Fix For: 6.2.0
>
>
> After fix for TS-3492, ATS sends only {{SETTINGS_INITIAL_WINDOW_SIZE}} in 
> first SETTINGS Frame.
> ATS should send SETTINGS Parameters when values in records.config is 
> different from default value of RFC7540 (6.5.2 Defined SETTINGS Parameters).
> For example, {{SETTINGS_MAX_CONCURRENT_STREAMS}} is unlimited in RFC7540, but 
> default value in records.config is 100. ATS should send this value in first 
> SETTINGS Frame but not.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (TS-3917) Sending only SETTINGS_INITIAL_WINDOW_SIZE in SETTINGS Frame

2016-02-11 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/TS-3917?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15144026#comment-15144026
 ] 

ASF GitHub Bot commented on TS-3917:


Github user masaori335 commented on the pull request:

https://github.com/apache/trafficserver/pull/466#issuecomment-183178397
  
@bryancall OK :)


> Sending only SETTINGS_INITIAL_WINDOW_SIZE in SETTINGS Frame
> ---
>
> Key: TS-3917
> URL: https://issues.apache.org/jira/browse/TS-3917
> Project: Traffic Server
>  Issue Type: Bug
>  Components: HTTP/2
>Reporter: Masaori Koshiba
>Assignee: Bryan Call
>Priority: Critical
> Fix For: 6.2.0
>
>
> After fix for TS-3492, ATS sends only {{SETTINGS_INITIAL_WINDOW_SIZE}} in 
> first SETTINGS Frame.
> ATS should send SETTINGS Parameters when values in records.config is 
> different from default value of RFC7540 (6.5.2 Defined SETTINGS Parameters).
> For example, {{SETTINGS_MAX_CONCURRENT_STREAMS}} is unlimited in RFC7540, but 
> default value in records.config is 100. ATS should send this value in first 
> SETTINGS Frame but not.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (TS-3917) Sending only SETTINGS_INITIAL_WINDOW_SIZE in SETTINGS Frame

2015-12-20 Thread Masaori Koshiba (JIRA) 

[ 
https://issues.apache.org/jira/browse/TS-3917?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15066068#comment-15066068
 ] 

Masaori Koshiba commented on TS-3917:
-

I agree with 
https://github.com/apache/trafficserver/blob/6.0.x/proxy/http2/HTTP2.h#L58 
should be {{UINT_MAX}}.
100 is default value of {{proxy.config.http2.max_concurrent_streams_in}}.

> Sending only SETTINGS_INITIAL_WINDOW_SIZE in SETTINGS Frame
> ---
>
> Key: TS-3917
> URL: https://issues.apache.org/jira/browse/TS-3917
> Project: Traffic Server
>  Issue Type: Bug
>  Components: HTTP/2
>Reporter: Masaori Koshiba
>Assignee: Bryan Call
>Priority: Critical
> Fix For: 6.1.0
>
>
> After fix for TS-3492, ATS sends only {{SETTINGS_INITIAL_WINDOW_SIZE}} in 
> first SETTINGS Frame.
> ATS should send SETTINGS Parameters when values in records.config is 
> different from default value of RFC7540 (6.5.2 Defined SETTINGS Parameters).
> For example, {{SETTINGS_MAX_CONCURRENT_STREAMS}} is unlimited in RFC7540, but 
> default value in records.config is 100. ATS should send this value in first 
> SETTINGS Frame but not.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (TS-3917) Sending only SETTINGS_INITIAL_WINDOW_SIZE in SETTINGS Frame

2015-12-19 Thread Masakazu Kitajo (JIRA) 

[ 
https://issues.apache.org/jira/browse/TS-3917?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15065453#comment-15065453
 ] 

Masakazu Kitajo commented on TS-3917:
-

It seems that the current implementation does send the differences but the 
value to compare embedded in HTTP2.h differs from the one defined on the 
specification.
https://github.com/apache/trafficserver/blob/6.0.x/proxy/http2/HTTP2.h#L58

So the actual issue is that the initial value for 
SETTINGS_MAX_CONCURRENT_STREAMS differs from the specification.

Though I don't know why the value differs, it can be fixed by just changing the 
value above to UINT_MAX.

> Sending only SETTINGS_INITIAL_WINDOW_SIZE in SETTINGS Frame
> ---
>
> Key: TS-3917
> URL: https://issues.apache.org/jira/browse/TS-3917
> Project: Traffic Server
>  Issue Type: Bug
>  Components: HTTP/2
>Reporter: Masaori Koshiba
>Assignee: Bryan Call
>Priority: Critical
> Fix For: 6.1.0
>
>
> After fix for TS-3492, ATS sends only {{SETTINGS_INITIAL_WINDOW_SIZE}} in 
> first SETTINGS Frame.
> ATS should send SETTINGS Parameters when values in records.config is 
> different from default value of RFC7540 (6.5.2 Defined SETTINGS Parameters).
> For example, {{SETTINGS_MAX_CONCURRENT_STREAMS}} is unlimited in RFC7540, but 
> default value in records.config is 100. ATS should send this value in first 
> SETTINGS Frame but not.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)