[jira] [Commented] (YUNIKORN-31) Turn on lint checks for k8shim
[
https://issues.apache.org/jira/browse/YUNIKORN-31?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17074202#comment-17074202
]
Wilfred Spiegelenburg commented on YUNIKORN-31:
---
The lint check is also no working correctly on the core as it does not pull in
the correct reference form git to check against.
the makefile in both projects must be updated to run the following lint check:
{code}
golangci-lint run --new-from-rev=`git rev-parse --short=12 refs/heads/master`
{code}
> Turn on lint checks for k8shim
> --
>
> Key: YUNIKORN-31
> URL: https://issues.apache.org/jira/browse/YUNIKORN-31
> Project: Apache YuniKorn
> Issue Type: Improvement
> Components: shim - kubernetes
>Reporter: Wilfred Spiegelenburg
>Assignee: Wilfred Spiegelenburg
>Priority: Major
>
> The lint checks have been turned off for the k8shim.
> This means that new PRs are not checked against the code styles.
> Lots of new issues have been created due to not running lint checks on the
> code.
> The core is running the lint checks and so should the shim.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: issues-unsubscr...@yunikorn.apache.org
For additional commands, e-mail: issues-h...@yunikorn.apache.org
[jira] [Resolved] (YUNIKORN-14) Add rest API to retrieve app/container history info
[
https://issues.apache.org/jira/browse/YUNIKORN-14?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Wilfred Spiegelenburg resolved YUNIKORN-14.
---
Fix Version/s: 0.8
Resolution: Fixed
Thank you [~adam.antal], merged the changes, closing
follow up for the webapp is to check if it properly handles the {{-1}} returned
if we cannot collect the data: YUNIKORN-74
> Add rest API to retrieve app/container history info
> ---
>
> Key: YUNIKORN-14
> URL: https://issues.apache.org/jira/browse/YUNIKORN-14
> Project: Apache YuniKorn
> Issue Type: New Feature
> Components: core - scheduler
>Reporter: Wilfred Spiegelenburg
>Assignee: Adam Antal
>Priority: Blocker
> Labels: pull-request-available
> Fix For: 0.8
>
> Attachments: Yunikorn_UI.png
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> As part of the web UI we can show application and container history.
> The current pages are mocked up and do not show the real history. Before the
> changes can be made on the web UI side we need to provide the history via a
> REST interface so it can be consumed by the UI.
> All web service code is located in package
> [https://github.com/apache/incubator-yunikorn-core/tree/master/pkg/webservice].
> When running the scheduler locally (from K8shim using "make run"), the REST
> APIs can be accessed via
> * [http://localhost:9080/ws/v1/apps]
> * [http://localhost:9080/ws/v1/queues]
> * [http://localhost:9080/ws/v1/nodes]
> We need to add another endpoint to provide data to yunikorn-web to render the
> app/container history page. Please check with [~akhilpb] for the desired data
> format, etc. That issue is tracked via YUNIKORN-8.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: issues-unsubscr...@yunikorn.apache.org
For additional commands, e-mail: issues-h...@yunikorn.apache.org
[jira] [Created] (YUNIKORN-74) handle negative history counters in web app history
Wilfred Spiegelenburg created YUNIKORN-74: - Summary: handle negative history counters in web app history Key: YUNIKORN-74 URL: https://issues.apache.org/jira/browse/YUNIKORN-74 Project: Apache YuniKorn Issue Type: Bug Components: webapp Affects Versions: 0.8 Reporter: Wilfred Spiegelenburg In the current setup the REST API returns a -1 for all values that could not be converted from the internal prometheus counter to an integer. The web app must be able to handle it or even show the fact that there is no data by colour coding etc. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: issues-unsubscr...@yunikorn.apache.org For additional commands, e-mail: issues-h...@yunikorn.apache.org
[jira] [Resolved] (YUNIKORN-73) Temporarily disable the badge on github
[ https://issues.apache.org/jira/browse/YUNIKORN-73?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Weiwei Yang resolved YUNIKORN-73. - Fix Version/s: 0.8 Resolution: Fixed > Temporarily disable the badge on github > --- > > Key: YUNIKORN-73 > URL: https://issues.apache.org/jira/browse/YUNIKORN-73 > Project: Apache YuniKorn > Issue Type: Improvement > Components: documentation >Reporter: Weiwei Yang >Assignee: Weiwei Yang >Priority: Major > Labels: pull-request-available > Fix For: 0.8 > > Time Spent: 20m > Remaining Estimate: 0h > > Seems like our UT is not very stable on github, let's disable the badge and > reenable it once we have a stable UT env. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: issues-unsubscr...@yunikorn.apache.org For additional commands, e-mail: issues-h...@yunikorn.apache.org
[jira] [Commented] (YUNIKORN-69) Design YUNIKORN logo
[ https://issues.apache.org/jira/browse/YUNIKORN-69?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17074136#comment-17074136 ] Wangda Tan commented on YUNIKORN-69: Thanks the contribution from Yu-En! We have a better-than-average logo among all Apache project. ;) > Design YUNIKORN logo > > > Key: YUNIKORN-69 > URL: https://issues.apache.org/jira/browse/YUNIKORN-69 > Project: Apache YuniKorn > Issue Type: Task >Reporter: Sunil G >Priority: Major > Fix For: 0.8 > > Attachments: yunikorn-log-gray.png, yunikorn-logo-black.png, > yunikorn-logo-blue (1).png, yunikorn-logo-main.png > > > New Yunikorn logo creation and using in all projects. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: issues-unsubscr...@yunikorn.apache.org For additional commands, e-mail: issues-h...@yunikorn.apache.org
[jira] [Updated] (YUNIKORN-66) Add labels to the history view on the web UI
[ https://issues.apache.org/jira/browse/YUNIKORN-66?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Akhil PB updated YUNIKORN-66: - Summary: Add labels to the history view on the web UI (was: add labels to the history view on the web UI) > Add labels to the history view on the web UI > > > Key: YUNIKORN-66 > URL: https://issues.apache.org/jira/browse/YUNIKORN-66 > Project: Apache YuniKorn > Issue Type: Improvement > Components: webapp >Reporter: Wilfred Spiegelenburg >Assignee: Akhil PB >Priority: Minor > > The backend will return the running applications and or containers. The page > does not really make that clear, a label or mouse hover should explain what > is displayed. > In the future, can we include total ones, and completed ones in this chart > too if possible? -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: issues-unsubscr...@yunikorn.apache.org For additional commands, e-mail: issues-h...@yunikorn.apache.org
[jira] [Assigned] (YUNIKORN-66) add labels to the history view on the web UI
[ https://issues.apache.org/jira/browse/YUNIKORN-66?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Akhil PB reassigned YUNIKORN-66: Assignee: Akhil PB > add labels to the history view on the web UI > > > Key: YUNIKORN-66 > URL: https://issues.apache.org/jira/browse/YUNIKORN-66 > Project: Apache YuniKorn > Issue Type: Improvement > Components: webapp >Reporter: Wilfred Spiegelenburg >Assignee: Akhil PB >Priority: Minor > > The backend will return the running applications and or containers. The page > does not really make that clear, a label or mouse hover should explain what > is displayed. > In the future, can we include total ones, and completed ones in this chart > too if possible? -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: issues-unsubscr...@yunikorn.apache.org For additional commands, e-mail: issues-h...@yunikorn.apache.org
[jira] [Assigned] (YUNIKORN-65) Remove job references from the web app
[ https://issues.apache.org/jira/browse/YUNIKORN-65?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Akhil PB reassigned YUNIKORN-65: Assignee: Akhil PB > Remove job references from the web app > -- > > Key: YUNIKORN-65 > URL: https://issues.apache.org/jira/browse/YUNIKORN-65 > Project: Apache YuniKorn > Issue Type: Improvement > Components: webapp >Reporter: Wilfred Spiegelenburg >Assignee: Akhil PB >Priority: Minor > > In the shim and core we have moved away from job and are using application as > a generic term to talk about sets of related allocations. > The web code still uses job everywhere for internal objects. We should change > to application in the webapp to get consistency. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: issues-unsubscr...@yunikorn.apache.org For additional commands, e-mail: issues-h...@yunikorn.apache.org
