[jira] [Commented] (YUNIKORN-872) [Umbrella] Build against kubernetes 1.20

2021-10-19 Thread Craig Condit (Jira)


[ 
https://issues.apache.org/jira/browse/YUNIKORN-872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17430669#comment-17430669
 ] 

Craig Condit commented on YUNIKORN-872:
---

End-to-end testing has been completed successfully on k8s 1.18.19, 1.19.11, 
1.20.7, and 1.21.1. 

> [Umbrella] Build against kubernetes 1.20
> 
>
> Key: YUNIKORN-872
> URL: https://issues.apache.org/jira/browse/YUNIKORN-872
> Project: Apache YuniKorn
>  Issue Type: Improvement
>  Components: shim - kubernetes
>Reporter: Craig Condit
>Assignee: Craig Condit
>Priority: Major
>
> Currently, the kubernetes shim is built against kubernetes 1.16. This version 
> has been end-of-life for quite some time now. We should update to build 
> against 1.20 prior to YuniKorn 1.0.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: issues-unsubscr...@yunikorn.apache.org
For additional commands, e-mail: issues-h...@yunikorn.apache.org



[jira] [Commented] (YUNIKORN-872) [Umbrella] Build against kubernetes 1.20

2021-10-18 Thread Craig Condit (Jira)


[ 
https://issues.apache.org/jira/browse/YUNIKORN-872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17430177#comment-17430177
 ] 

Craig Condit commented on YUNIKORN-872:
---

The "Predicates" configuration option will be non-functional in the new 
version, as it doesn't have a good mapping to plugins. I've checked the code 
and it is no longer referenced anywhere. I've opened YUNIKORN-872 to address 
removing it.

I'm planning to run the e2e tests (which cover most of the test scenarios you 
describe) locally on a small cluster. 



> [Umbrella] Build against kubernetes 1.20
> 
>
> Key: YUNIKORN-872
> URL: https://issues.apache.org/jira/browse/YUNIKORN-872
> Project: Apache YuniKorn
>  Issue Type: Improvement
>  Components: shim - kubernetes
>Reporter: Craig Condit
>Assignee: Craig Condit
>Priority: Major
>
> Currently, the kubernetes shim is built against kubernetes 1.16. This version 
> has been end-of-life for quite some time now. We should update to build 
> against 1.20 prior to YuniKorn 1.0.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: issues-unsubscr...@yunikorn.apache.org
For additional commands, e-mail: issues-h...@yunikorn.apache.org



[jira] [Commented] (YUNIKORN-872) [Umbrella] Build against kubernetes 1.20

2021-10-18 Thread Weiwei Yang (Jira)


[ 
https://issues.apache.org/jira/browse/YUNIKORN-872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17430160#comment-17430160
 ] 

Weiwei Yang commented on YUNIKORN-872:
--

Hi [~ccondit] thanks for all the efforts.
there are a few more things I would suggest checking before merging this back 
to the master
# Need to check if this parameter is still applicable: 
https://github.com/apache/incubator-yunikorn-k8shim/blob/3a94fcbc1a0ea861e52c5da963e6d7a2f42302a3/pkg/conf/schedulerconf.go#L68.
# is there a testing plan for this? to make sure the predicates are all 
functional after the merge? e.g node affinity/anti-affinity, taints/toleration, 
ports, volumes, etc.


> [Umbrella] Build against kubernetes 1.20
> 
>
> Key: YUNIKORN-872
> URL: https://issues.apache.org/jira/browse/YUNIKORN-872
> Project: Apache YuniKorn
>  Issue Type: Improvement
>  Components: shim - kubernetes
>Reporter: Craig Condit
>Assignee: Craig Condit
>Priority: Major
>
> Currently, the kubernetes shim is built against kubernetes 1.16. This version 
> has been end-of-life for quite some time now. We should update to build 
> against 1.20 prior to YuniKorn 1.0.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: issues-unsubscr...@yunikorn.apache.org
For additional commands, e-mail: issues-h...@yunikorn.apache.org



[jira] [Commented] (YUNIKORN-872) [Umbrella] Build against kubernetes 1.20

2021-10-18 Thread Craig Condit (Jira)


[ 
https://issues.apache.org/jira/browse/YUNIKORN-872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17430103#comment-17430103
 ] 

Craig Condit commented on YUNIKORN-872:
---

Build issues have been resolved, and predicates code refactored to use K8S 
filter / prefilter plugins instead. 

[~kmarton], [~cheersyang], [~yuchaoran2011], are there any other tasks we want 
to add before merging to master?

> [Umbrella] Build against kubernetes 1.20
> 
>
> Key: YUNIKORN-872
> URL: https://issues.apache.org/jira/browse/YUNIKORN-872
> Project: Apache YuniKorn
>  Issue Type: Improvement
>  Components: shim - kubernetes
>Reporter: Craig Condit
>Assignee: Craig Condit
>Priority: Major
>
> Currently, the kubernetes shim is built against kubernetes 1.16. This version 
> has been end-of-life for quite some time now. We should update to build 
> against 1.20 prior to YuniKorn 1.0.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: issues-unsubscr...@yunikorn.apache.org
For additional commands, e-mail: issues-h...@yunikorn.apache.org



[jira] [Commented] (YUNIKORN-872) [Umbrella] Build against kubernetes 1.20

2021-10-07 Thread Craig Condit (Jira)


[ 
https://issues.apache.org/jira/browse/YUNIKORN-872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17425592#comment-17425592
 ] 

Craig Condit commented on YUNIKORN-872:
---

[~kmarton]thank you for creating the branch. I've started adding subtasks as 
well. The initial patch I'll be contributing for YUNKORN-873 will get the basic 
build functioning, but with predicates disabled and tests being broken. I've 
created follow-up sub tasks for each of those. I suspect we will need more for 
stabilization as well.

> [Umbrella] Build against kubernetes 1.20
> 
>
> Key: YUNIKORN-872
> URL: https://issues.apache.org/jira/browse/YUNIKORN-872
> Project: Apache YuniKorn
>  Issue Type: Improvement
>  Components: shim - kubernetes
>Reporter: Craig Condit
>Assignee: Craig Condit
>Priority: Major
>
> Currently, the kubernetes shim is built against kubernetes 1.16. This version 
> has been end-of-life for quite some time now. We should update to build 
> against 1.20 prior to YuniKorn 1.0.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: issues-unsubscr...@yunikorn.apache.org
For additional commands, e-mail: issues-h...@yunikorn.apache.org



[jira] [Commented] (YUNIKORN-872) [Umbrella] Build against kubernetes 1.20

2021-10-07 Thread Kinga Marton (Jira)


[ 
https://issues.apache.org/jira/browse/YUNIKORN-872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17425588#comment-17425588
 ] 

Kinga Marton commented on YUNIKORN-872:
---

Since this is a bigger feature, as we discussed offline, I created YUNIKORN-872 
branch for working on the subtasks.

> [Umbrella] Build against kubernetes 1.20
> 
>
> Key: YUNIKORN-872
> URL: https://issues.apache.org/jira/browse/YUNIKORN-872
> Project: Apache YuniKorn
>  Issue Type: Improvement
>  Components: shim - kubernetes
>Reporter: Craig Condit
>Assignee: Craig Condit
>Priority: Major
>
> Currently, the kubernetes shim is built against kubernetes 1.16. This version 
> has been end-of-life for quite some time now. We should update to build 
> against 1.20 prior to YuniKorn 1.0.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: issues-unsubscr...@yunikorn.apache.org
For additional commands, e-mail: issues-h...@yunikorn.apache.org