[jira] [Commented] (ZOOKEEPER-3457) Code optimization in QuorumCnxManager
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16890597#comment-16890597
]
Asutosh Pandya commented on ZOOKEEPER-3457:
---
[https://github.com/apache/zookeeper/pull/1020]
> Code optimization in QuorumCnxManager
> -
>
> Key: ZOOKEEPER-3457
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3457
> Project: ZooKeeper
> Issue Type: Improvement
> Components: quorum
>Affects Versions: 3.5.5
>Reporter: tom.long
>Priority: Trivial
> Labels: easyfix, pull-request-available
> Fix For: 3.5.5
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> Dear developer:
> I think the following code in line 623 of the QuorumCnxManager class can be
> optimized:
> {code:java}
> ArrayBlockingQueue bq = new ArrayBlockingQueue(
> SEND_CAPACITY);
> ArrayBlockingQueue oldq = queueSendMap.putIfAbsent(sid, bq);
> if (oldq != null) {
> addToSendQueue(oldq, b);
> } else {
> addToSendQueue(bq, b);
> }
> {code}
> The optimization is as follows:
> {code:java}
> ArrayBlockingQueue bq = queueSendMap.computeIfAbsent(sid,
> serverId
> -> new ArrayBlockingQueue<>(SEND_CAPACITY));
> addToSendQueue(bq, b);
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Commented] (ZOOKEEPER-3356) Request throttling in Netty is not working as expected and could cause direct buffer OOM issue
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16890432#comment-16890432 ] Hadoop QA commented on ZOOKEEPER-3356: -- +1 overall. GitHub Pull Request Build +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 12 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 3.0.1) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/4066//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/4066//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/4066//console This message is automatically generated. > Request throttling in Netty is not working as expected and could cause direct > buffer OOM issue > --- > > Key: ZOOKEEPER-3356 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3356 > Project: ZooKeeper > Issue Type: Bug > Components: server >Affects Versions: 3.5.4, 3.6.0 >Reporter: Fangmin Lv >Assignee: Fangmin Lv >Priority: Major > Labels: pull-request-available > Fix For: 3.6.0 > > Time Spent: 2h 40m > Remaining Estimate: 0h > > The current implementation of Netty enable/disable recv logic may cause the > direct buffer OOM because we may enable read a large chunk of packets and > disabled again after consuming a single ZK request. We have seen this problem > on prod occasionally. > > Need a more advanced flow control in Netty instead of using AUTO_READ. Have > improved it internally by enable/disable recv based on the queuedBuffer size, > will upstream this soon. > > With this implementation, the max Netty queued buffer size (direct memory > usage) will be 2 * recv_buffer size. It's not the per message size because in > epoll ET mode it will try to read until the socket is empty, and because of > SslHandler will trigger another read when it's not a full encrypt packet and > haven't issued any decrypt message. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Updated] (ZOOKEEPER-3464) enfore checkstyle in the zookeeper-server module and clean the package:admin and client
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3464?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated ZOOKEEPER-3464: -- Labels: pull-request-available (was: ) > enfore checkstyle in the zookeeper-server module and clean the package:admin > and client > --- > > Key: ZOOKEEPER-3464 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3464 > Project: ZooKeeper > Issue Type: Sub-task > Components: build >Reporter: maoling >Assignee: maoling >Priority: Major > Labels: pull-request-available > Fix For: 3.6.0 > > -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Updated] (ZOOKEEPER-3464) enfore checkstyle in the zookeeper-server module and clean the package:admin and client
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3464?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] maoling updated ZOOKEEPER-3464: --- Summary: enfore checkstyle in the zookeeper-server module and clean the package:admin and client (was: Enforce the checkstyle violations in the package org.apache.zookeeper.common) > enfore checkstyle in the zookeeper-server module and clean the package:admin > and client > --- > > Key: ZOOKEEPER-3464 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3464 > Project: ZooKeeper > Issue Type: Sub-task > Components: build >Reporter: maoling >Assignee: maoling >Priority: Major > Fix For: 3.6.0 > > -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Commented] (ZOOKEEPER-2668) Remove reference to requireClientAuthScheme from https://cwiki.apache.org/confluence/display/ZOOKEEPER/Client-Server+mutual+authentication
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2668?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16889989#comment-16889989 ] Jerome Xue commented on ZOOKEEPER-2668: --- I have the same issue > Remove reference to requireClientAuthScheme from > https://cwiki.apache.org/confluence/display/ZOOKEEPER/Client-Server+mutual+authentication > -- > > Key: ZOOKEEPER-2668 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2668 > Project: ZooKeeper > Issue Type: Bug > Components: documentation >Reporter: Devaraj Das >Priority: Major > > I was trying to see if ZK can be configured to always do client > authentication (globally and not per znode). I came across this > https://cwiki.apache.org/confluence/display/ZOOKEEPER/Client-Server+mutual+authentication > and it describes a config key requireClientAuthScheme that when set to > 'sasl' should do the job. But upon looking at code (in master and in > branch-3.5), I don't see any reference to it. > Raising this jira to update the wiki (assuming I am on the right track). > There are probably ways to update the wiki otherwise but I wanted to get some > attention on this before we did that. (cc [~phunt], [~ekoontz]). -- This message was sent by Atlassian JIRA (v7.6.14#76016)
