[jira] Updated: (LUCENE-1987) Remove rest of analysis deprecations (Token, CharacterCache)
[
https://issues.apache.org/jira/browse/LUCENE-1987?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Uwe Schindler updated LUCENE-1987:
--
Attachment: LUCENE-1987-StopFilter.patch
A new patch which resolves the Benchmark problem by adding a static method in
NewAnalyzerTask that loads an analyzer by class name:
{code}
public static final Analyzer createAnalyzer(String className) throws Exception{
final Class? extends Analyzer clazz =
Class.forName(className).asSubclass(Analyzer.class);
try {
// first try to use a ctor with version parameter (needed for many new
Analyzers that have no default one anymore
Constructor? extends Analyzer cnstr =
clazz.getConstructor(Version.class);
return cnstr.newInstance(Version.LUCENE_CURRENT);
} catch (NoSuchMethodException nsme) {
// otherwise use default ctor
return clazz.newInstance();
}
}
{code}
This method is reused at other places where an Analyzer is created by a config
property.
This patch now passes all test. There are still the problems with Analyzer and
QueryParsr with wrong default properties, but I would like to commit this first
and then solve the problems, also in 2.9.1.
Mike, are you OK with that?
Remove rest of analysis deprecations (Token, CharacterCache)
Key: LUCENE-1987
URL: https://issues.apache.org/jira/browse/LUCENE-1987
Project: Lucene - Java
Issue Type: Task
Components: Analysis
Reporter: Uwe Schindler
Assignee: Uwe Schindler
Fix For: 2.9.1, 3.0
Attachments: LUCENE-1987-StopFilter-backport29.patch,
LUCENE-1987-StopFilter-BW.patch, LUCENE-1987-StopFilter.patch,
LUCENE-1987-StopFilter.patch, LUCENE-1987-StopFilter.patch,
LUCENE-1987-StopFilter.patch, LUCENE-1987-StopFilter.patch,
LUCENE-1987.patch, LUCENE-1987.patch, LUCENE-1987.patch
These removes the rest of the deprecations in the analysis package:
- -Token's termText field-- (DONE)
- -eventually un-deprecate ctors of Token taking Strings (they are still
useful) - if yes remove deprec in 2.9.1- (DONE)
- -remove CharacterCache and use Character.valueOf() from Java5- (DONE)
- Stopwords lists
- Remove the backwards settings from analyzers (acronym, posIncr,...). They
are deprecated, but we still have the VERSION constants. Do not know, how to
proceed. Keep the settings alive for index compatibility? Or remove it
together with the version constants (which were undeprecated).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
-
To unsubscribe, e-mail: java-dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: java-dev-h...@lucene.apache.org
[jira] Updated: (LUCENE-1987) Remove rest of analysis deprecations (Token, CharacterCache)
[
https://issues.apache.org/jira/browse/LUCENE-1987?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Uwe Schindler updated LUCENE-1987:
--
Attachment: LUCENE-1987-StopFilter.patch
Hallo Mike,
attached is a patch with all deprecated methods removed (only the
setOverridesTokenStream is still there, making Analyzers final is another thing
to do).
Also StopFilter and its stopWord ets were generified (to ?, which is ok for
every type of set, as CharArraySet uses toString() to convert everything to
string when testing, so any set is fine)
I only had the following problems and solution is here (StandardAnalyzer):
{code}
enableStopPositionIncrements = matchVersion.onOrAfter(Version.LUCENE_29);
replaceInvalidAcronym = matchVersion.onOrAfter(Version.LUCENE_23);
{code}
The setting defaultPosIncr was removed (static method, so there is no default
anymore). Because of that, the pre 2.9 default was false (which is now not
changeable). So I set the posIncr to false for all older versions (this was the
default before, but is now fixed as no static setter/sysprop anymore)
For the invalid acronyms I added LUCENE_23 version constant, so for all
versions =2.3 it is enabled. If you want old behaviour, use LUCENE_22 or below.
Mike: Can you review this?
If you're ok with it I have to change 175 new StandardAnalyzer() occurences
in tests :(
Remove rest of analysis deprecations (Token, CharacterCache)
Key: LUCENE-1987
URL: https://issues.apache.org/jira/browse/LUCENE-1987
Project: Lucene - Java
Issue Type: Task
Components: Analysis
Reporter: Uwe Schindler
Assignee: Uwe Schindler
Fix For: 3.0
Attachments: LUCENE-1987-StopFilter.patch, LUCENE-1987.patch,
LUCENE-1987.patch, LUCENE-1987.patch
These removes the rest of the deprecations in the analysis package:
- -Token's termText field-- (DONE)
- -eventually un-deprecate ctors of Token taking Strings (they are still
useful) - if yes remove deprec in 2.9.1- (DONE)
- -remove CharacterCache and use Character.valueOf() from Java5- (DONE)
- Stopwords lists
- Remove the backwards settings from analyzers (acronym, posIncr,...). They
are deprecated, but we still have the VERSION constants. Do not know, how to
proceed. Keep the settings alive for index compatibility? Or remove it
together with the version constants (which were undeprecated).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
-
To unsubscribe, e-mail: java-dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: java-dev-h...@lucene.apache.org
[jira] Updated: (LUCENE-1987) Remove rest of analysis deprecations (Token, CharacterCache)
[ https://issues.apache.org/jira/browse/LUCENE-1987?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Uwe Schindler updated LUCENE-1987: -- Attachment: LUCENE-1987-StopFilter.patch Correct patch. Remove rest of analysis deprecations (Token, CharacterCache) Key: LUCENE-1987 URL: https://issues.apache.org/jira/browse/LUCENE-1987 Project: Lucene - Java Issue Type: Task Components: Analysis Reporter: Uwe Schindler Assignee: Uwe Schindler Fix For: 3.0 Attachments: LUCENE-1987-StopFilter.patch, LUCENE-1987.patch, LUCENE-1987.patch, LUCENE-1987.patch These removes the rest of the deprecations in the analysis package: - -Token's termText field-- (DONE) - -eventually un-deprecate ctors of Token taking Strings (they are still useful) - if yes remove deprec in 2.9.1- (DONE) - -remove CharacterCache and use Character.valueOf() from Java5- (DONE) - Stopwords lists - Remove the backwards settings from analyzers (acronym, posIncr,...). They are deprecated, but we still have the VERSION constants. Do not know, how to proceed. Keep the settings alive for index compatibility? Or remove it together with the version constants (which were undeprecated). -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. - To unsubscribe, e-mail: java-dev-unsubscr...@lucene.apache.org For additional commands, e-mail: java-dev-h...@lucene.apache.org
[jira] Updated: (LUCENE-1987) Remove rest of analysis deprecations (Token, CharacterCache)
[ https://issues.apache.org/jira/browse/LUCENE-1987?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Uwe Schindler updated LUCENE-1987: -- Attachment: (was: LUCENE-1987-StopFilter.patch) Remove rest of analysis deprecations (Token, CharacterCache) Key: LUCENE-1987 URL: https://issues.apache.org/jira/browse/LUCENE-1987 Project: Lucene - Java Issue Type: Task Components: Analysis Reporter: Uwe Schindler Assignee: Uwe Schindler Fix For: 3.0 Attachments: LUCENE-1987-StopFilter.patch, LUCENE-1987.patch, LUCENE-1987.patch, LUCENE-1987.patch These removes the rest of the deprecations in the analysis package: - -Token's termText field-- (DONE) - -eventually un-deprecate ctors of Token taking Strings (they are still useful) - if yes remove deprec in 2.9.1- (DONE) - -remove CharacterCache and use Character.valueOf() from Java5- (DONE) - Stopwords lists - Remove the backwards settings from analyzers (acronym, posIncr,...). They are deprecated, but we still have the VERSION constants. Do not know, how to proceed. Keep the settings alive for index compatibility? Or remove it together with the version constants (which were undeprecated). -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. - To unsubscribe, e-mail: java-dev-unsubscr...@lucene.apache.org For additional commands, e-mail: java-dev-h...@lucene.apache.org
[jira] Updated: (LUCENE-1987) Remove rest of analysis deprecations (Token, CharacterCache)
[ https://issues.apache.org/jira/browse/LUCENE-1987?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Uwe Schindler updated LUCENE-1987: -- Attachment: LUCENE-1987-StopFilter.patch Javadocs fixes. Remove rest of analysis deprecations (Token, CharacterCache) Key: LUCENE-1987 URL: https://issues.apache.org/jira/browse/LUCENE-1987 Project: Lucene - Java Issue Type: Task Components: Analysis Reporter: Uwe Schindler Assignee: Uwe Schindler Fix For: 3.0 Attachments: LUCENE-1987-StopFilter.patch, LUCENE-1987-StopFilter.patch, LUCENE-1987.patch, LUCENE-1987.patch, LUCENE-1987.patch These removes the rest of the deprecations in the analysis package: - -Token's termText field-- (DONE) - -eventually un-deprecate ctors of Token taking Strings (they are still useful) - if yes remove deprec in 2.9.1- (DONE) - -remove CharacterCache and use Character.valueOf() from Java5- (DONE) - Stopwords lists - Remove the backwards settings from analyzers (acronym, posIncr,...). They are deprecated, but we still have the VERSION constants. Do not know, how to proceed. Keep the settings alive for index compatibility? Or remove it together with the version constants (which were undeprecated). -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. - To unsubscribe, e-mail: java-dev-unsubscr...@lucene.apache.org For additional commands, e-mail: java-dev-h...@lucene.apache.org
[jira] Updated: (LUCENE-1987) Remove rest of analysis deprecations (Token, CharacterCache)
[ https://issues.apache.org/jira/browse/LUCENE-1987?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Uwe Schindler updated LUCENE-1987: -- Attachment: LUCENE-1987-StopFilter.patch Updated patch with LUCENE_24. I did not remove the other version constants, because then we have them and can use them anywhere else. And a user coming from e.g. 2.2 to 3.0 can just use LUCENE_22 to match his old behaviour. The user should be free to give his version he used before for this backwards compatibility. Mike: Should I backport the setting for 2.4 to 2.9 to enable plugin-replacements from 2.9.1 to 3.0? Remove rest of analysis deprecations (Token, CharacterCache) Key: LUCENE-1987 URL: https://issues.apache.org/jira/browse/LUCENE-1987 Project: Lucene - Java Issue Type: Task Components: Analysis Reporter: Uwe Schindler Assignee: Uwe Schindler Fix For: 3.0 Attachments: LUCENE-1987-StopFilter.patch, LUCENE-1987-StopFilter.patch, LUCENE-1987-StopFilter.patch, LUCENE-1987.patch, LUCENE-1987.patch, LUCENE-1987.patch These removes the rest of the deprecations in the analysis package: - -Token's termText field-- (DONE) - -eventually un-deprecate ctors of Token taking Strings (they are still useful) - if yes remove deprec in 2.9.1- (DONE) - -remove CharacterCache and use Character.valueOf() from Java5- (DONE) - Stopwords lists - Remove the backwards settings from analyzers (acronym, posIncr,...). They are deprecated, but we still have the VERSION constants. Do not know, how to proceed. Keep the settings alive for index compatibility? Or remove it together with the version constants (which were undeprecated). -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. - To unsubscribe, e-mail: java-dev-unsubscr...@lucene.apache.org For additional commands, e-mail: java-dev-h...@lucene.apache.org
[jira] Updated: (LUCENE-1987) Remove rest of analysis deprecations (Token, CharacterCache)
[ https://issues.apache.org/jira/browse/LUCENE-1987?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Uwe Schindler updated LUCENE-1987: -- Attachment: LUCENE-1987-StopFilter-backport29.patch LUCENE-1987-StopFilter-BW.patch LUCENE-1987-StopFilter.patch Here 2 mega patches and one backport to 2.9 (want to get this in before 2.9.1): All core tests pass, all bw tests pass. Most contrib tests also pass, but we have the following problems and inconsistencies: - benchmark does not work any longer, because StandardAnalyzer has no default ctor anymore and cannot be instantiated by reflection, same with StopAnalyzer - Highlighter only works, if StandardAnalyzer is in 2.4 mde, in 2.9 mode (current) it fails because the position increments of stop words are not correctly respected. This fails in addition/combination with the following: - Very bad inconsistency: The default of QueryParser is to ignore position increments, but the current version of StandardAnalyzer uses posIncr for stop words - bäng. We should change the default for QueryParser(+ contrib QP), too. There is march rework needed and much documentation. The tests in core now pass, as most parts use StandardAnalyzer in 2.9 mode but have no stop words. And the special tests explicitely set the posIncr flag. This is totally disturbed, it needs fixing! (it also affects 2.9.0, if somebody uses the new StandardAnalyzer with LUCENE_CURRENT). - XMLQueryParser also fails with latest StandardAnalyzer version, because it cannot set the flag in QueryParser. In my opinion, the query parser should take the flag from the analyzer, but this is not easy to fix. - All contrib analyzers have stopWordPosIncr turned off (backwards compatibility). Maybe we need a Version Parameter in all analyzers there too! What to do? After this StopFilter/StandardAnalyzer-hell-day Aspirin and Paracetamol and beer is not enough to think clear again... And please: next time when we deprecate APIs: remove all deprecated calls from tests and contrib and mark all deprecated-test as such! Remove rest of analysis deprecations (Token, CharacterCache) Key: LUCENE-1987 URL: https://issues.apache.org/jira/browse/LUCENE-1987 Project: Lucene - Java Issue Type: Task Components: Analysis Reporter: Uwe Schindler Assignee: Uwe Schindler Fix For: 3.0 Attachments: LUCENE-1987-StopFilter-backport29.patch, LUCENE-1987-StopFilter-BW.patch, LUCENE-1987-StopFilter.patch, LUCENE-1987-StopFilter.patch, LUCENE-1987-StopFilter.patch, LUCENE-1987-StopFilter.patch, LUCENE-1987.patch, LUCENE-1987.patch, LUCENE-1987.patch These removes the rest of the deprecations in the analysis package: - -Token's termText field-- (DONE) - -eventually un-deprecate ctors of Token taking Strings (they are still useful) - if yes remove deprec in 2.9.1- (DONE) - -remove CharacterCache and use Character.valueOf() from Java5- (DONE) - Stopwords lists - Remove the backwards settings from analyzers (acronym, posIncr,...). They are deprecated, but we still have the VERSION constants. Do not know, how to proceed. Keep the settings alive for index compatibility? Or remove it together with the version constants (which were undeprecated). -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. - To unsubscribe, e-mail: java-dev-unsubscr...@lucene.apache.org For additional commands, e-mail: java-dev-h...@lucene.apache.org
[jira] Updated: (LUCENE-1987) Remove rest of analysis deprecations (Token, CharacterCache)
[ https://issues.apache.org/jira/browse/LUCENE-1987?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Uwe Schindler updated LUCENE-1987: -- Fix Version/s: 2.9.1 Remove rest of analysis deprecations (Token, CharacterCache) Key: LUCENE-1987 URL: https://issues.apache.org/jira/browse/LUCENE-1987 Project: Lucene - Java Issue Type: Task Components: Analysis Reporter: Uwe Schindler Assignee: Uwe Schindler Fix For: 2.9.1, 3.0 Attachments: LUCENE-1987-StopFilter-backport29.patch, LUCENE-1987-StopFilter-BW.patch, LUCENE-1987-StopFilter.patch, LUCENE-1987-StopFilter.patch, LUCENE-1987-StopFilter.patch, LUCENE-1987-StopFilter.patch, LUCENE-1987.patch, LUCENE-1987.patch, LUCENE-1987.patch These removes the rest of the deprecations in the analysis package: - -Token's termText field-- (DONE) - -eventually un-deprecate ctors of Token taking Strings (they are still useful) - if yes remove deprec in 2.9.1- (DONE) - -remove CharacterCache and use Character.valueOf() from Java5- (DONE) - Stopwords lists - Remove the backwards settings from analyzers (acronym, posIncr,...). They are deprecated, but we still have the VERSION constants. Do not know, how to proceed. Keep the settings alive for index compatibility? Or remove it together with the version constants (which were undeprecated). -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. - To unsubscribe, e-mail: java-dev-unsubscr...@lucene.apache.org For additional commands, e-mail: java-dev-h...@lucene.apache.org
Re: [jira] Updated: (LUCENE-1987) Remove rest of analysis deprecations (Token, CharacterCache)
Uwe Schindler (JIRA) wrote: And please: next time when we deprecate APIs: remove all deprecated calls from tests and contrib and mark all deprecated-test as such! Its the nature of open source. Each of us takes the work that other contributors are willing/able/havetime to provide - and fill in the rest ourselves or decide its too much work and don't. I agree that its a nice idea, but I don't think the issue is going away so easily myself ;) In which case it falls to the poor soul who decides to help later and remove the deprecated methods. Or perhaps it keeps someone from stepping up and doing that - nature of the beast. But as long as we are making such requests, please no one commit any more funky source formatting either :) It hurts my eyes. -- - Mark http://www.lucidimagination.com - To unsubscribe, e-mail: java-dev-unsubscr...@lucene.apache.org For additional commands, e-mail: java-dev-h...@lucene.apache.org
RE: [jira] Updated: (LUCENE-1987) Remove rest of analysis deprecations (Token, CharacterCache)
Uwe Schindler (JIRA) wrote: And please: next time when we deprecate APIs: remove all deprecated calls from tests and contrib and mark all deprecated-test as such! Its the nature of open source. Each of us takes the work that other contributors are willing/able/havetime to provide - and fill in the rest ourselves or decide its too much work and don't. I agree that its a nice idea, but I don't think the issue is going away so easily myself ;) In which case it falls to the poor soul who decides to help later and remove the deprecated methods. Or perhaps it keeps someone from stepping up and doing that - nature of the beast. Sorry, I was disappointed and somehow angry because nothing worked as expected when I removed the deprecated parts. I fixed one thing and 5 other problems appeared. But as long as we are making such requests, please no one commit any more funky source formatting either :) It hurts my eyes. What was funky? I think I should stop working today and do something other... Uwe - To unsubscribe, e-mail: java-dev-unsubscr...@lucene.apache.org For additional commands, e-mail: java-dev-h...@lucene.apache.org
Re: [jira] Updated: (LUCENE-1987) Remove rest of analysis deprecations (Token, CharacterCache)
Uwe Schindler wrote: Uwe Schindler (JIRA) wrote: And please: next time when we deprecate APIs: remove all deprecated calls from tests and contrib and mark all deprecated-test as such! Its the nature of open source. Each of us takes the work that other contributors are willing/able/havetime to provide - and fill in the rest ourselves or decide its too much work and don't. I agree that its a nice idea, but I don't think the issue is going away so easily myself ;) In which case it falls to the poor soul who decides to help later and remove the deprecated methods. Or perhaps it keeps someone from stepping up and doing that - nature of the beast. Sorry, I was disappointed and somehow angry because nothing worked as expected when I removed the deprecated parts. I fixed one thing and 5 other problems appeared. Ha - no reason to be sorry - I agree it would be nice - just saying good luck getting everyone to fall in line in the future :) But as long as we are making such requests, please no one commit any more funky source formatting either :) It hurts my eyes. What was funky? I think I should stop working today and do something other... Ha again :) I actually reworded that because the first time I wrote it I thought it sounded like I was saying you did it - guess I failed :) I was commenting in general, not about you - I don't think anything to bad has gotten in in some time - but there is some old source code here and there that really bugs me - totally unrelated to your comment - just adding a wish of my own - no more ugly source code :) ! Uwe - To unsubscribe, e-mail: java-dev-unsubscr...@lucene.apache.org For additional commands, e-mail: java-dev-h...@lucene.apache.org -- - Mark http://www.lucidimagination.com - To unsubscribe, e-mail: java-dev-unsubscr...@lucene.apache.org For additional commands, e-mail: java-dev-h...@lucene.apache.org
Re: [jira] Updated: (LUCENE-1987) Remove rest of analysis deprecations (Token, CharacterCache)
On Mon, Oct 19, 2009 at 3:11 PM, Mark Miller markrmil...@gmail.com wrote: Uwe Schindler (JIRA) wrote: And please: next time when we deprecate APIs: remove all deprecated calls from tests and contrib and mark all deprecated-test as such! Its the nature of open source. Each of us takes the work that other contributors are willing/able/havetime to provide - and fill in the rest ourselves or decide its too much work and don't. I agree that its a nice idea, but I don't think the issue is going away so easily myself ;) In which case it falls to the poor soul who decides to help later and remove the deprecated methods. Or perhaps it keeps someone from stepping up and doing that - nature of the beast. I do agree this is the nature of the beast. Also, thinking more about it... I think a good approach, for an issue with a large number of deprecations, might be to open a separate issue to fix the deprecations in contrib/test, and fix it after some delay. This way we confirm that deprecated usage of the APIs is working, for at least some time, before removing them all from the tests. EG in LUCENE-1458 I waited until quite late to cutover usage to the flex API. But as long as we are making such requests, please no one commit any more funky source formatting either :) It hurts my eyes. +1! Mike - To unsubscribe, e-mail: java-dev-unsubscr...@lucene.apache.org For additional commands, e-mail: java-dev-h...@lucene.apache.org
Re: [jira] Updated: (LUCENE-1987) Remove rest of analysis deprecations (Token, CharacterCache)
On Mon, Oct 19, 2009 at 3:45 PM, Mark Miller markrmil...@gmail.com wrote:
but there is some old source code here and
there that really bugs me
Is it Doug's
if (foo)
bar()
else {
baz();
}
or is it my single line
if (a==null) return 0;
;-)
One of my personal pet peeves is more indentation than necessary for
large blocks of code, rather than just immediately handling the
exception cases and escaping. Example:
void doSomething(MyObj obj) {
if (obj != null) {// at this point, I'm wondering... hmmm, is
there code that executes *after* this huge if in the event that obj
is null?
[...]
// same with this one... ya gotta go and try to match up braces
to see if there is code that executes in the opposite case...
// and if it also falls through to execute the obj==null case or
simply returns.
if (some other condition) {
[ tons of code ]
[ tons of code ]
}
}
A much more readable version (regardless of if one likes the
single-line syntax or not):
void doSomething(MyObj obj) {
if (obj==null) return; // immediately obvious handling of the exception case
[...]
if (!some other condition) return; // again, immediately obvious
how the exception case was handled
[ tons of code ]
[ tons of code ]
}
-Yonik
http://www.lucidimagination.com
-
To unsubscribe, e-mail: java-dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: java-dev-h...@lucene.apache.org
Re: [jira] Updated: (LUCENE-1987) Remove rest of analysis deprecations (Token, CharacterCache)
On Mon, Oct 19, 2009 at 4:00 PM, Yonik Seeley
yo...@lucidimagination.com wrote:
On Mon, Oct 19, 2009 at 3:45 PM, Mark Miller markrmil...@gmail.com wrote:
but there is some old source code here and
there that really bugs me
Is it Doug's
if (foo)
bar()
else {
baz();
}
or is it my single line
if (a==null) return 0;
;-)
Or my always doing this up until a while ago:
if (foo)
something;
but then suddenly [trying to] switch to the correct:
if (foo) {
something;
}
?
One of my personal pet peeves is more indentation than necessary for
large blocks of code, rather than just immediately handling the
exception cases and escaping. Example:
Hmm I think I tend to do this :)
But I agree, your way IS more readable so I'll try to switch!
Mike
-
To unsubscribe, e-mail: java-dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: java-dev-h...@lucene.apache.org
[jira] Updated: (LUCENE-1987) Remove rest of analysis deprecations (Token, CharacterCache)
[ https://issues.apache.org/jira/browse/LUCENE-1987?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Uwe Schindler updated LUCENE-1987: -- Attachment: LUCENE-1987.patch New patch. Will commit soon (+bw branch). I will also commit the un-depreactions to 2.9 branch. Still open are the StopFilter/StopAnalyzer patches (not sure, how to proceed here). Remove rest of analysis deprecations (Token, CharacterCache) Key: LUCENE-1987 URL: https://issues.apache.org/jira/browse/LUCENE-1987 Project: Lucene - Java Issue Type: Task Components: Analysis Reporter: Uwe Schindler Assignee: Uwe Schindler Fix For: 3.0 Attachments: LUCENE-1987.patch, LUCENE-1987.patch, LUCENE-1987.patch These removes the rest of the deprecations in the analysis package: - Token's termText field - eventually un-deprecate ctors of Token taking Strings (they are still useful) - if yes remove deprec in 2.9.1 - remove CharacterCache and use Character.valueOf() from Java5 - Some Analyzers have stopword lists in wrong format (HashMaps) -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. - To unsubscribe, e-mail: java-dev-unsubscr...@lucene.apache.org For additional commands, e-mail: java-dev-h...@lucene.apache.org
[jira] Updated: (LUCENE-1987) Remove rest of analysis deprecations (Token, CharacterCache)
[ https://issues.apache.org/jira/browse/LUCENE-1987?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Uwe Schindler updated LUCENE-1987: -- Description: These removes the rest of the deprecations in the analysis package: - -Token's termText field-- (DONE) - -eventually un-deprecate ctors of Token taking Strings (they are still useful) - if yes remove deprec in 2.9.1- (DONE) - -remove CharacterCache and use Character.valueOf() from Java5- (DONE) - Stopwords lists - Remove the backwards settings from analyzers (acronym, posIncr,...). They are deprecated, but we still have the VERSION constants. Do not know, how to proceed. Keep the settings alive for index compatibility? Or remove it together with the version constants (which were undeprecated). was: These removes the rest of the deprecations in the analysis package: - Token's termText field - eventually un-deprecate ctors of Token taking Strings (they are still useful) - if yes remove deprec in 2.9.1 - remove CharacterCache and use Character.valueOf() from Java5 - Some Analyzers have stopword lists in wrong format (HashMaps) Remove rest of analysis deprecations (Token, CharacterCache) Key: LUCENE-1987 URL: https://issues.apache.org/jira/browse/LUCENE-1987 Project: Lucene - Java Issue Type: Task Components: Analysis Reporter: Uwe Schindler Assignee: Uwe Schindler Fix For: 3.0 Attachments: LUCENE-1987.patch, LUCENE-1987.patch, LUCENE-1987.patch These removes the rest of the deprecations in the analysis package: - -Token's termText field-- (DONE) - -eventually un-deprecate ctors of Token taking Strings (they are still useful) - if yes remove deprec in 2.9.1- (DONE) - -remove CharacterCache and use Character.valueOf() from Java5- (DONE) - Stopwords lists - Remove the backwards settings from analyzers (acronym, posIncr,...). They are deprecated, but we still have the VERSION constants. Do not know, how to proceed. Keep the settings alive for index compatibility? Or remove it together with the version constants (which were undeprecated). -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. - To unsubscribe, e-mail: java-dev-unsubscr...@lucene.apache.org For additional commands, e-mail: java-dev-h...@lucene.apache.org
[jira] Updated: (LUCENE-1987) Remove rest of analysis deprecations (Token, CharacterCache)
[ https://issues.apache.org/jira/browse/LUCENE-1987?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Uwe Schindler updated LUCENE-1987: -- Attachment: LUCENE-1987.patch Updated patch to last generics additions Remove rest of analysis deprecations (Token, CharacterCache) Key: LUCENE-1987 URL: https://issues.apache.org/jira/browse/LUCENE-1987 Project: Lucene - Java Issue Type: Task Components: Analysis Reporter: Uwe Schindler Assignee: Uwe Schindler Fix For: 3.0 Attachments: LUCENE-1987.patch, LUCENE-1987.patch These removes the rest of the deprecations in the analysis package: - Token's termText field - eventually un-deprecate ctors of Token taking Strings (they are still useful) - if yes remove deprec in 2.9.1 - remove CharacterCache and use Character.valueOf() from Java5 - Some Analyzers have stopword lists in wrong format (HashMaps) -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. - To unsubscribe, e-mail: java-dev-unsubscr...@lucene.apache.org For additional commands, e-mail: java-dev-h...@lucene.apache.org
RE: [jira] Updated: (LUCENE-1987) Remove rest of analysis deprecations (Token, CharacterCache)
Any comments about this? +1 for undeprecate these ctors in Token from my side. - Uwe Schindler H.-H.-Meier-Allee 63, D-28213 Bremen http://www.thetaphi.de eMail: u...@thetaphi.de -Original Message- From: Uwe Schindler (JIRA) [mailto:j...@apache.org] Sent: Friday, October 16, 2009 11:39 PM To: java-dev@lucene.apache.org Subject: [jira] Updated: (LUCENE-1987) Remove rest of analysis deprecations (Token, CharacterCache) [ https://issues.apache.org/jira/browse/LUCENE- 1987?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Uwe Schindler updated LUCENE-1987: -- Attachment: LUCENE-1987.patch Pastch with the first three points. The three deprecated methods should stay alive in my opinion. Copying the string to the termbuffer in the ctor is the same linke copying the initial termbuffer. If we remove these ctors, we should also remove the setTermBuffer(String) method. This is no consistency. If the others agree to keep these three ctors alive I will apply an undeprecation in 2.9 branch. Remove rest of analysis deprecations (Token, CharacterCache) Key: LUCENE-1987 URL: https://issues.apache.org/jira/browse/LUCENE-1987 Project: Lucene - Java Issue Type: Task Components: Analysis Reporter: Uwe Schindler Assignee: Uwe Schindler Fix For: 3.0 Attachments: LUCENE-1987.patch These removes the rest of the deprecations in the analysis package: - Token's termText field - eventually un-deprecate ctors of Token taking Strings (they are still useful) - if yes remove deprec in 2.9.1 - remove CharacterCache and use Character.valueOf() from Java5 - Some Analyzers have stopword lists in wrong format (HashMaps) -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. - To unsubscribe, e-mail: java-dev-unsubscr...@lucene.apache.org For additional commands, e-mail: java-dev-h...@lucene.apache.org - To unsubscribe, e-mail: java-dev-unsubscr...@lucene.apache.org For additional commands, e-mail: java-dev-h...@lucene.apache.org
[jira] Updated: (LUCENE-1987) Remove rest of analysis deprecations (Token, CharacterCache)
[ https://issues.apache.org/jira/browse/LUCENE-1987?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Uwe Schindler updated LUCENE-1987: -- Attachment: LUCENE-1987.patch Pastch with the first three points. The three deprecated methods should stay alive in my opinion. Copying the string to the termbuffer in the ctor is the same linke copying the initial termbuffer. If we remove these ctors, we should also remove the setTermBuffer(String) method. This is no consistency. If the others agree to keep these three ctors alive I will apply an undeprecation in 2.9 branch. Remove rest of analysis deprecations (Token, CharacterCache) Key: LUCENE-1987 URL: https://issues.apache.org/jira/browse/LUCENE-1987 Project: Lucene - Java Issue Type: Task Components: Analysis Reporter: Uwe Schindler Assignee: Uwe Schindler Fix For: 3.0 Attachments: LUCENE-1987.patch These removes the rest of the deprecations in the analysis package: - Token's termText field - eventually un-deprecate ctors of Token taking Strings (they are still useful) - if yes remove deprec in 2.9.1 - remove CharacterCache and use Character.valueOf() from Java5 - Some Analyzers have stopword lists in wrong format (HashMaps) -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. - To unsubscribe, e-mail: java-dev-unsubscr...@lucene.apache.org For additional commands, e-mail: java-dev-h...@lucene.apache.org
