[jira] Commented: (JDO-414) CallingJdoPreclear tries to add the same instance to multiple 1-M relations
[ http://issues.apache.org/jira/browse/JDO-414?page=comments#action_12449799 ] Michelle Caisse commented on JDO-414: - I agree that we should simple delete the call to primaryObj.addChild(secondaryObj). It doesn't appear to be necessary. CallingJdoPreclear tries to add the same instance to multiple 1-M relations --- Key: JDO-414 URL: http://issues.apache.org/jira/browse/JDO-414 Project: JDO Issue Type: Bug Components: tck2 Affects Versions: JDO 2 final Reporter: Marc Prud'hommeaux Assigned To: Michelle Caisse Priority: Minor The CallingJdoPreclear test tries to add the same instance to multiple one-to-many relations in different instances, which may result in validation errors at commit time. The code that does this is: primaryObj.addChild(secondaryObj); // primaryObj contains one child; secondaryObj contains none. primaryObj is now dirty ... ternaryObj.addChild(secondaryObj); Errors can be worked around by removing secondaryObj from primaryObj.children before adding it to ternaryObj. E.g.: primaryObj.addChild(secondaryObj); // primaryObj contains one child; secondaryObj contains none. primaryObj is now dirty primaryObj.children.remove(secondaryObj); ... ternaryObj.addChild(secondaryObj); Alternately, the call to primaryObj.addChild(secondaryObj); can probably just be skipped ... it doesn't look like it would impact the test case. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (JDO-414) CallingJdoPreclear tries to add the same instance to multiple 1-M relations
[ http://issues.apache.org/jira/browse/JDO-414?page=comments#action_12449821 ] Craig Russell commented on JDO-414: --- If you skip the call to primaryObj.addChild(secondaryObj), you have to make primaryObj dirty in some other way, or you are not testing what the test case claims to be testing: new, clean, and dirty instance callbacks. CallingJdoPreclear tries to add the same instance to multiple 1-M relations --- Key: JDO-414 URL: http://issues.apache.org/jira/browse/JDO-414 Project: JDO Issue Type: Bug Components: tck2 Affects Versions: JDO 2 final Reporter: Marc Prud'hommeaux Assigned To: Michelle Caisse Priority: Minor The CallingJdoPreclear test tries to add the same instance to multiple one-to-many relations in different instances, which may result in validation errors at commit time. The code that does this is: primaryObj.addChild(secondaryObj); // primaryObj contains one child; secondaryObj contains none. primaryObj is now dirty ... ternaryObj.addChild(secondaryObj); Errors can be worked around by removing secondaryObj from primaryObj.children before adding it to ternaryObj. E.g.: primaryObj.addChild(secondaryObj); // primaryObj contains one child; secondaryObj contains none. primaryObj is now dirty primaryObj.children.remove(secondaryObj); ... ternaryObj.addChild(secondaryObj); Alternately, the call to primaryObj.addChild(secondaryObj); can probably just be skipped ... it doesn't look like it would impact the test case. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (JDO-414) CallingJdoPreclear tries to add the same instance to multiple 1-M relations
[ http://issues.apache.org/jira/browse/JDO-414?page=comments#action_12449826 ] Michelle Caisse commented on JDO-414: - Oops. What I meant was to skip the call to ternaryObj.addChild(secondaryObj) in the following code snippet: InstanceCallbackClass ternaryObj = new InstanceCallbackClass(ternaryObj, stillLaterDate, 3, 3.3, (short)-30, '3', null); pm.makePersistent(ternaryObj); ternaryObj.addChild(secondaryObj); // SKIP THIS LINE!! ternaryObj.addChild(primaryObj); t.commit(); CallingJdoPreclear tries to add the same instance to multiple 1-M relations --- Key: JDO-414 URL: http://issues.apache.org/jira/browse/JDO-414 Project: JDO Issue Type: Bug Components: tck2 Affects Versions: JDO 2 final Reporter: Marc Prud'hommeaux Assigned To: Michelle Caisse Priority: Minor The CallingJdoPreclear test tries to add the same instance to multiple one-to-many relations in different instances, which may result in validation errors at commit time. The code that does this is: primaryObj.addChild(secondaryObj); // primaryObj contains one child; secondaryObj contains none. primaryObj is now dirty ... ternaryObj.addChild(secondaryObj); Errors can be worked around by removing secondaryObj from primaryObj.children before adding it to ternaryObj. E.g.: primaryObj.addChild(secondaryObj); // primaryObj contains one child; secondaryObj contains none. primaryObj is now dirty primaryObj.children.remove(secondaryObj); ... ternaryObj.addChild(secondaryObj); Alternately, the call to primaryObj.addChild(secondaryObj); can probably just be skipped ... it doesn't look like it would impact the test case. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (JDO-414) CallingJdoPreclear tries to add the same instance to multiple 1-M relations
[ http://issues.apache.org/jira/browse/JDO-414?page=comments#action_12449851 ] Craig Russell commented on JDO-414: --- Ok, sounds good. CallingJdoPreclear tries to add the same instance to multiple 1-M relations --- Key: JDO-414 URL: http://issues.apache.org/jira/browse/JDO-414 Project: JDO Issue Type: Bug Components: tck2 Affects Versions: JDO 2 final Reporter: Marc Prud'hommeaux Assigned To: Michelle Caisse Priority: Minor The CallingJdoPreclear test tries to add the same instance to multiple one-to-many relations in different instances, which may result in validation errors at commit time. The code that does this is: primaryObj.addChild(secondaryObj); // primaryObj contains one child; secondaryObj contains none. primaryObj is now dirty ... ternaryObj.addChild(secondaryObj); Errors can be worked around by removing secondaryObj from primaryObj.children before adding it to ternaryObj. E.g.: primaryObj.addChild(secondaryObj); // primaryObj contains one child; secondaryObj contains none. primaryObj is now dirty primaryObj.children.remove(secondaryObj); ... ternaryObj.addChild(secondaryObj); Alternately, the call to primaryObj.addChild(secondaryObj); can probably just be skipped ... it doesn't look like it would impact the test case. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Resolved: (JDO-414) CallingJdoPreclear tries to add the same instance to multiple 1-M relations
[ http://issues.apache.org/jira/browse/JDO-414?page=all ] Michelle Caisse resolved JDO-414. - Fix Version/s: JDO 2 maintenance release 1 Resolution: Fixed Fixed with revision: 475051 CallingJdoPreclear tries to add the same instance to multiple 1-M relations --- Key: JDO-414 URL: http://issues.apache.org/jira/browse/JDO-414 Project: JDO Issue Type: Bug Components: tck2 Affects Versions: JDO 2 final Reporter: Marc Prud'hommeaux Assigned To: Michelle Caisse Priority: Minor Fix For: JDO 2 maintenance release 1 The CallingJdoPreclear test tries to add the same instance to multiple one-to-many relations in different instances, which may result in validation errors at commit time. The code that does this is: primaryObj.addChild(secondaryObj); // primaryObj contains one child; secondaryObj contains none. primaryObj is now dirty ... ternaryObj.addChild(secondaryObj); Errors can be worked around by removing secondaryObj from primaryObj.children before adding it to ternaryObj. E.g.: primaryObj.addChild(secondaryObj); // primaryObj contains one child; secondaryObj contains none. primaryObj is now dirty primaryObj.children.remove(secondaryObj); ... ternaryObj.addChild(secondaryObj); Alternately, the call to primaryObj.addChild(secondaryObj); can probably just be skipped ... it doesn't look like it would impact the test case. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Resolved: (JDO-443) Change column name in InstanceCallbacks table
[ http://issues.apache.org/jira/browse/JDO-443?page=all ] Michelle Caisse resolved JDO-443. - Resolution: Fixed Fixed with revision: 475055 Change column name in InstanceCallbacks table - Key: JDO-443 URL: http://issues.apache.org/jira/browse/JDO-443 Project: JDO Issue Type: Improvement Components: tck2, tck2-legacy Affects Versions: JDO 2 final Reporter: Michelle Caisse Assigned To: Michelle Caisse Priority: Trivial Fix For: JDO 2 maintenance release 1 The table InstanceCallbacks contains a column named CHILD, to which the field children of pc.InstanceCallbackClass is mapped. The field children is a HashSet of type InstanceCallbackClass. Therefore, the value of the database column CHILD is actually a foreign key to the parent of the instance. Therefore, for semantic consistency of the naming of database entities and to clarify how the Collection type is mapped to the database column, I propose changing the name of the column to PARENT. Two schema files and two orm files will need to be changed, one for each identity type. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
Re: [jira] Resolved: (JDO-443) Change column name in InstanceCallbacks table
Wow, fixed the 80 character lines, too. Craig On Nov 14, 2006, at 3:28 PM, Michelle Caisse (JIRA) wrote: [ http://issues.apache.org/jira/browse/JDO-443?page=all ] Michelle Caisse resolved JDO-443. - Resolution: Fixed Fixed with revision: 475055 Change column name in InstanceCallbacks table - Key: JDO-443 URL: http://issues.apache.org/jira/browse/JDO-443 Project: JDO Issue Type: Improvement Components: tck2, tck2-legacy Affects Versions: JDO 2 final Reporter: Michelle Caisse Assigned To: Michelle Caisse Priority: Trivial Fix For: JDO 2 maintenance release 1 The table InstanceCallbacks contains a column named CHILD, to which the field children of pc.InstanceCallbackClass is mapped. The field children is a HashSet of type InstanceCallbackClass. Therefore, the value of the database column CHILD is actually a foreign key to the parent of the instance. Therefore, for semantic consistency of the naming of database entities and to clarify how the Collection type is mapped to the database column, I propose changing the name of the column to PARENT. Two schema files and two orm files will need to be changed, one for each identity type. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/ Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/ software/jira Craig Russell Architect, Sun Java Enterprise System http://java.sun.com/products/jdo 408 276-5638 mailto:[EMAIL PROTECTED] P.S. A good JDO? O, Gasp! smime.p7s Description: S/MIME cryptographic signature
