Re: TCK : TreeSetCollections CHALLENGE

2022-03-31 Thread Andy Jefferson
> Upon inspection of the TCK orm.xml files I find the embedded fields such as
> TreeSetCollections.TreeSetOfObject1 are supposed to be embedded in a join
> table, yet have no  block, though they do for the other java.util
> type tests.

FWIW The same comment applies to the ORM files for ArrayList (app id and ds 
id). List, LinkedList, Vector all have the  block, whereas ArrayList 
doesn't. 

The requisite schema for ArrayList and TreeSet likewise don't have the 
embedded columns needed, so that would need updating too.
Currently, for those cases, it seems to be simply ignoring the embedded flag 
and storing the SimpleClass in its own table with FK across to it from the 
join table.



-- 
Andy
DataNucleus (Web: http://www.datanucleus.org   Twitter: @datanucleus)




TCK : TreeSetCollections CHALLENGE

2022-03-30 Thread Andy Jefferson
Hi,

after reworking some DN code and rerunning the TCK I came across a situation 
where TestTreeSetCollections was failing (for app id), yet 
TestHashSetCollections/TestSetCollections were passing (which was strange 
considering the innocuous change I've been making). That, on its own, doesn't 
say whether the problem is mine, or the TCKs. Upon inspection of the TCK 
orm.xml files I find the embedded fields such as 
TreeSetCollections.TreeSetOfObject1 are supposed to be embedded in a join 
table, yet have no  block, though they do for the other java.util 
type tests.

See TreeSet
https://github.com/apache/db-jdo/blob/main/tck/src/main/resources/orm/
applicationidentity/org/apache/jdo/tck/pc/fieldtypes/TreeSetCollections-
standard.orm#L30

compared to HashSet
https://github.com/apache/db-jdo/blob/main/tck/src/main/resources/orm/
applicationidentity/org/apache/jdo/tck/pc/fieldtypes/HashSetCollections-
standard.orm#L30

and Set
https://github.com/apache/db-jdo/blob/main/tck/src/main/resources/orm/
applicationidentity/org/apache/jdo/tck/pc/fieldtypes/SetCollections-
standard.orm#L30


Any comments?


Regards
-- 
Andy
DataNucleus (Web: http://www.datanucleus.org   Twitter: @datanucleus)