[jenkinsci/stash-pullrequest-builder-plugin] cd031f: StashApiClient: Add spaces after "GET" and "POST" ...
Branch: refs/heads/master Home: https://github.com/jenkinsci/stash-pullrequest-builder-plugin Commit: cd031fd2db81b5d2da0d5978c4bd6a6409ec6b98 https://github.com/jenkinsci/stash-pullrequest-builder-plugin/commit/cd031fd2db81b5d2da0d5978c4bd6a6409ec6b98 Author: Pavel Roskin Date: 2020-07-28 (Tue, 28 Jul 2020) Changed paths: M src/main/java/stashpullrequestbuilder/stashpullrequestbuilder/stash/StashApiClient.java Log Message: --- StashApiClient: Add spaces after "GET" and "POST" in log messages (#185) Without the spaces, "GET" and "POST" were glued together with the URI of the failed request. -- You received this message because you are subscribed to the Google Groups "Jenkins Commits" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-commits+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-commits/jenkinsci/stash-pullrequest-builder-plugin/push/refs/heads/master/8cfee6-cd031f%40github.com.
[jenkinsci/stash-pullrequest-builder-plugin] 8cfee6: StashBuildTrigger: Fix null pointer exception for ...
Branch: refs/heads/master Home: https://github.com/jenkinsci/stash-pullrequest-builder-plugin Commit: 8cfee61aab18321abf4a188ea8b3635ca8e82a21 https://github.com/jenkinsci/stash-pullrequest-builder-plugin/commit/8cfee61aab18321abf4a188ea8b3635ca8e82a21 Author: Pavel Roskin Date: 2020-01-10 (Fri, 10 Jan 2020) Changed paths: M src/main/java/stashpullrequestbuilder/stashpullrequestbuilder/StashBuildTrigger.java M src/test/java/stashpullrequestbuilder/stashpullrequestbuilder/StashBuildTriggerTest.java Log Message: --- StashBuildTrigger: Fix null pointer exception for missing credentials (#184) If the credential ID is empty or if the credentials cannot be looked up by the credential ID, log the error to the polling log and don't start the trigger. Ensure that non-empty credentials are selected in the GUI. Remove public getUsername() and getPassword() methods, they are not used by other classes. Add more unit tests for StashBuildTrigger constructor, start() and the new functionality. Remove leftover debug print. -- You received this message because you are subscribed to the Google Groups "Jenkins Commits" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-commits+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-commits/jenkinsci/stash-pullrequest-builder-plugin/push/refs/heads/master/43ad5b-8cfee6%40github.com.
[jenkinsci/stash-pullrequest-builder-plugin] 56f544: pom.xml: Update JUnit to version 4.13 (#183)
Branch: refs/heads/master Home: https://github.com/jenkinsci/stash-pullrequest-builder-plugin Commit: 56f544761968424715dfef5d70fd47f50b46745b https://github.com/jenkinsci/stash-pullrequest-builder-plugin/commit/56f544761968424715dfef5d70fd47f50b46745b Author: Pavel Roskin Date: 2020-01-02 (Thu, 02 Jan 2020) Changed paths: M pom.xml Log Message: --- pom.xml: Update JUnit to version 4.13 (#183) No need to use a release candidate when a newer release is available. -- You received this message because you are subscribed to the Google Groups "Jenkins Commits" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-commits+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-commits/jenkinsci/stash-pullrequest-builder-plugin/push/refs/heads/master/32320a-56f544%40github.com.
[jenkinsci/stash-pullrequest-builder-plugin] 73afb2: pom:xml: Update parent POM to version 3.53 (#182)
Branch: refs/heads/master Home: https://github.com/jenkinsci/stash-pullrequest-builder-plugin Commit: 73afb2d9f18816ef3915c3b87ffd4ea3e5b35842 https://github.com/jenkinsci/stash-pullrequest-builder-plugin/commit/73afb2d9f18816ef3915c3b87ffd4ea3e5b35842 Author: Pavel Roskin Date: 2019-12-20 (Fri, 20 Dec 2019) Changed paths: M pom.xml Log Message: --- pom:xml: Update parent POM to version 3.53 (#182) Remove direct dependencies on JUnit and Hamcrest. The parent POM depends on them through jenkins-test-harness already. Use dependencyManagement to require a newer version of JUnit without having a direct dependency. -- You received this message because you are subscribed to the Google Groups "Jenkins Commits" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-commits+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-commits/jenkinsci/stash-pullrequest-builder-plugin/push/refs/heads/master/7567bf-73afb2%40github.com.
[jenkinsci/stash-pullrequest-builder-plugin] aa0b42: StashBuildListener: Simplify code for calculating ...
Branch: refs/heads/master Home: https://github.com/jenkinsci/stash-pullrequest-builder-plugin Commit: aa0b429956e945eeb519c224e37a2c0512817ff5 https://github.com/jenkinsci/stash-pullrequest-builder-plugin/commit/aa0b429956e945eeb519c224e37a2c0512817ff5 Author: Pavel Roskin Date: 2019-12-16 (Mon, 16 Dec 2019) Changed paths: M src/main/java/stashpullrequestbuilder/stashpullrequestbuilder/StashBuildListener.java Log Message: --- StashBuildListener: Simplify code for calculating buildUrl (#179) Use Jenkins#getRootUrl(), which reflects the configuration currently in effect. It is used widely in the current Jenkins code. Use Objects.toString() to provide the default if the root URL is not configured. Surround the message with "===" for better readability. Update the comment to document the actual behavior. -- You received this message because you are subscribed to the Google Groups "Jenkins Commits" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-commits+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-commits/jenkinsci/stash-pullrequest-builder-plugin/push/refs/heads/master/6a067f-aa0b42%40github.com.
[jenkinsci/stash-pullrequest-builder-plugin] 8d6d7c: StashRepository: Format timestamps using DateTimeF...
Branch: refs/heads/master Home: https://github.com/jenkinsci/stash-pullrequest-builder-plugin Commit: 8d6d7c94c2b567aa76a60df48d9078b4175a24be https://github.com/jenkinsci/stash-pullrequest-builder-plugin/commit/8d6d7c94c2b567aa76a60df48d9078b4175a24be Author: Pavel Roskin Date: 2019-12-16 (Mon, 16 Dec 2019) Changed paths: M src/main/java/stashpullrequestbuilder/stashpullrequestbuilder/StashRepository.java Log Message: --- StashRepository: Format timestamps using DateTimeFormatter DateTimeFormatter appeared in Java 8. The formatter is thread-safe, so it can be initialized once. Commit: 7567bfb03936cb471346aa6276d2341d41fbf938 https://github.com/jenkinsci/stash-pullrequest-builder-plugin/commit/7567bfb03936cb471346aa6276d2341d41fbf938 Author: Pavel Roskin Date: 2019-12-16 (Mon, 16 Dec 2019) Changed paths: M src/main/java/stashpullrequestbuilder/stashpullrequestbuilder/StashRepository.java M src/spotbugs/excludesFilter.xml Log Message: --- StashRepository: Remove PRMC_POSSIBLY_REDUNDANT_METHOD_CALLS suppression SpotBugs assumes incorrectly that logTimestamp() would always return the same value. However, it doesn't consider multiple ZonedDateTime.now() calls as "redundant". While it might be possible to pass ZonedDateTime.now() as an argument to logTimestamp(), that method would become too simple to be useful. Replace calls to logTimestamp() with direct formatting calls. Compare: https://github.com/jenkinsci/stash-pullrequest-builder-plugin/compare/aa0b429956e9...7567bfb03936 -- You received this message because you are subscribed to the Google Groups "Jenkins Commits" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-commits+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-commits/jenkinsci/stash-pullrequest-builder-plugin/push/refs/heads/master/aa0b42-7567bf%40github.com.
[jenkinsci/stash-pullrequest-builder-plugin] 6a067f: StashApiClient: Process comments in getPullRequest...
Branch: refs/heads/master Home: https://github.com/jenkinsci/stash-pullrequest-builder-plugin Commit: 6a067f6a6b4d0a674b46785ddee75de69b47aa69 https://github.com/jenkinsci/stash-pullrequest-builder-plugin/commit/6a067f6a6b4d0a674b46785ddee75de69b47aa69 Author: Pavel Roskin Date: 2019-12-03 (Tue, 03 Dec 2019) Changed paths: M src/main/java/stashpullrequestbuilder/stashpullrequestbuilder/stash/StashApiClient.java M src/spotbugs/excludesFilter.xml M src/test/java/stashpullrequestbuilder/stashpullrequestbuilder/stash/StashApiClientTest.java Log Message: --- StashApiClient: Process comments in getPullRequestComments() as they arrive (#174) Improve variable names and formatting for readability. No need to create a temporary list of StashPullRequestActivityResponse objects and extract comments at the end. Fix unit test name. This resolves PSC_PRESIZE_COLLECTIONS warning, remove the suppression. -- You received this message because you are subscribed to the Google Groups "Jenkins Commits" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-commits+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-commits/jenkinsci/stash-pullrequest-builder-plugin/push/refs/heads/master/4f6536-6a067f%40github.com.
[jenkinsci/stash-pullrequest-builder-plugin] 4f6536: StashApiClientTest: Use more verifications, check ...
Branch: refs/heads/master Home: https://github.com/jenkinsci/stash-pullrequest-builder-plugin Commit: 4f6536283b8e26f8694566c80529f8ef075f0a44 https://github.com/jenkinsci/stash-pullrequest-builder-plugin/commit/4f6536283b8e26f8694566c80529f8ef075f0a44 Author: Pavel Roskin Date: 2019-12-03 (Tue, 03 Dec 2019) Changed paths: M src/test/java/stashpullrequestbuilder/stashpullrequestbuilder/stash/StashApiClientTest.java Log Message: --- StashApiClientTest: Use more verifications, check URL match (#180) Check URLs in all verifications. We have the URLs already from the stubs, so it's easy to add. Add verifications to all deletePullRequestComment() calls, as they don't return anything confirming that the DELETE request was sent. Add one verification for each StashApiClient method being tested. -- You received this message because you are subscribed to the Google Groups "Jenkins Commits" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-commits+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-commits/jenkinsci/stash-pullrequest-builder-plugin/push/refs/heads/master/5dabc6-4f6536%40github.com.
[jenkinsci/stash-pullrequest-builder-plugin] 6c5b87: StashApiClient: Use Optional.of() in mergePullRequ...
Branch: refs/heads/master Home: https://github.com/jenkinsci/stash-pullrequest-builder-plugin Commit: 6c5b876dbbe707f85009995ca32b0b6e8e2f716d https://github.com/jenkinsci/stash-pullrequest-builder-plugin/commit/6c5b876dbbe707f85009995ca32b0b6e8e2f716d Author: Pavel Roskin Date: 2019-12-02 (Mon, 02 Dec 2019) Changed paths: M src/main/java/stashpullrequestbuilder/stashpullrequestbuilder/stash/StashApiClient.java Log Message: --- StashApiClient: Use Optional.of() in mergePullRequest() (#175) Optional.ofNullable() can produce Optional.empty(), which would incorrectly indicate a successful merge. The argument of Optional.of() is guaranteed to be non-null now. -- You received this message because you are subscribed to the Google Groups "Jenkins Commits" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-commits+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-commits/jenkinsci/stash-pullrequest-builder-plugin/push/refs/heads/master/7b10a8-6c5b87%40github.com.
[jenkinsci/stash-pullrequest-builder-plugin] 7b10a8: StashRepository: Use sort() method of the List (#178)
Branch: refs/heads/master Home: https://github.com/jenkinsci/stash-pullrequest-builder-plugin Commit: 7b10a8c84ec79e2fe0ffadd0d80d9cffabf93265 https://github.com/jenkinsci/stash-pullrequest-builder-plugin/commit/7b10a8c84ec79e2fe0ffadd0d80d9cffabf93265 Author: Pavel Roskin Date: 2019-12-02 (Mon, 02 Dec 2019) Changed paths: M src/main/java/stashpullrequestbuilder/stashpullrequestbuilder/StashRepository.java Log Message: --- StashRepository: Use sort() method of the List (#178) That's a Java 8 feature. An object can use the best sorting algorithm for its actual class (ArrayList in this case). -- You received this message because you are subscribed to the Google Groups "Jenkins Commits" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-commits+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-commits/jenkinsci/stash-pullrequest-builder-plugin/push/refs/heads/master/d5701c-7b10a8%40github.com.
[jenkinsci/stash-pullrequest-builder-plugin] d5701c: StashApiClient: Avoid unnecessary initialization (...
Branch: refs/heads/master Home: https://github.com/jenkinsci/stash-pullrequest-builder-plugin Commit: d5701c922c01869c18ff7f515ba5c971966aa9c2 https://github.com/jenkinsci/stash-pullrequest-builder-plugin/commit/d5701c922c01869c18ff7f515ba5c971966aa9c2 Author: Pavel Roskin Date: 2019-12-02 (Mon, 02 Dec 2019) Changed paths: M src/main/java/stashpullrequestbuilder/stashpullrequestbuilder/stash/StashApiClient.java Log Message: --- StashApiClient: Avoid unnecessary initialization (#177) It is misleading to declare variables with values that are never used. Instead, declare variables in the scope in which they are used. Move the code using those variables inside that scope as well. -- You received this message because you are subscribed to the Google Groups "Jenkins Commits" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-commits+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-commits/jenkinsci/stash-pullrequest-builder-plugin/push/refs/heads/master/49ff23-d5701c%40github.com.
[jenkinsci/stash-pullrequest-builder-plugin] 49ff23: StashPostBuildComment: Make getDisplayName() @Nonn...
Branch: refs/heads/master Home: https://github.com/jenkinsci/stash-pullrequest-builder-plugin Commit: 49ff23e018ed6482ac1ec5fa9c3ddb8c862a868e https://github.com/jenkinsci/stash-pullrequest-builder-plugin/commit/49ff23e018ed6482ac1ec5fa9c3ddb8c862a868e Author: Pavel Roskin Date: 2019-12-02 (Mon, 02 Dec 2019) Changed paths: M src/main/java/stashpullrequestbuilder/stashpullrequestbuilder/StashPostBuildComment.java Log Message: --- StashPostBuildComment: Make getDisplayName() @Nonnull to match the superclass (#176) -- You received this message because you are subscribed to the Google Groups "Jenkins Commits" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-commits+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-commits/jenkinsci/stash-pullrequest-builder-plugin/push/refs/heads/master/4994ec-49ff23%40github.com.
[jenkinsci/stash-pullrequest-builder-plugin] 4994ec: Enable more SpotBugs checks, ignore known issues (...
Branch: refs/heads/master Home: https://github.com/jenkinsci/stash-pullrequest-builder-plugin Commit: 4994ecbb3e16c1edeb322c1c955b1b3fe8bf25c0 https://github.com/jenkinsci/stash-pullrequest-builder-plugin/commit/4994ecbb3e16c1edeb322c1c955b1b3fe8bf25c0 Author: Pavel Roskin Date: 2019-12-02 (Mon, 02 Dec 2019) Changed paths: M pom.xml A src/spotbugs/excludesFilter.xml Log Message: --- Enable more SpotBugs checks, ignore known issues (#164) Set SpotBugs threshold to Low. Use fb-contrib and find-sec-bugs plugins for SpotBugs. Add src/spotbugs/excludesFilter.xml file to ignore known issues. The parent POM makes SpotBugs use that file if it exists. It is better to check for more issues and ignore known issues than to risk adding new issues unknowingly. -- You received this message because you are subscribed to the Google Groups "Jenkins Commits" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-commits+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-commits/jenkinsci/stash-pullrequest-builder-plugin/push/refs/heads/master/d1cd90-4994ec%40github.com.
[jenkinsci/stash-pullrequest-builder-plugin] 697f3c: Restrict unnecessarily permissive methods (#173)
Branch: refs/heads/master Home: https://github.com/jenkinsci/stash-pullrequest-builder-plugin Commit: 697f3c546be5e1c645e18a4e73e27b6fc6f7ecc3 https://github.com/jenkinsci/stash-pullrequest-builder-plugin/commit/697f3c546be5e1c645e18a4e73e27b6fc6f7ecc3 Author: Pavel Roskin Date: 2019-11-30 (Sat, 30 Nov 2019) Changed paths: M src/main/java/stashpullrequestbuilder/stashpullrequestbuilder/StashRepository.java M src/main/java/stashpullrequestbuilder/stashpullrequestbuilder/stash/StashApiClient.java Log Message: --- Restrict unnecessarily permissive methods (#173) -- You received this message because you are subscribed to the Google Groups "Jenkins Commits" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-commits+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-commits/jenkinsci/stash-pullrequest-builder-plugin/push/refs/heads/master/bf508b-697f3c%40github.com.
[jenkinsci/stash-pullrequest-builder-plugin] d1cd90: Move static fields above instance fields (#172)
Branch: refs/heads/master Home: https://github.com/jenkinsci/stash-pullrequest-builder-plugin Commit: d1cd900b669672ef9257f48290485e3c99e5cb1f https://github.com/jenkinsci/stash-pullrequest-builder-plugin/commit/d1cd900b669672ef9257f48290485e3c99e5cb1f Author: Pavel Roskin Date: 2019-11-30 (Sat, 30 Nov 2019) Changed paths: M src/main/java/stashpullrequestbuilder/stashpullrequestbuilder/StashBuildTrigger.java M src/main/java/stashpullrequestbuilder/stashpullrequestbuilder/StashPostBuildComment.java Log Message: --- Move static fields above instance fields (#172) -- You received this message because you are subscribed to the Google Groups "Jenkins Commits" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-commits+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-commits/jenkinsci/stash-pullrequest-builder-plugin/push/refs/heads/master/697f3c-d1cd90%40github.com.
[jenkinsci/stash-pullrequest-builder-plugin] bf508b: StashApiClient: Run HTTP requests in the main thre...
Branch: refs/heads/master Home: https://github.com/jenkinsci/stash-pullrequest-builder-plugin Commit: bf508bf1e579c9fd293da102577f5cd26babfe90 https://github.com/jenkinsci/stash-pullrequest-builder-plugin/commit/bf508bf1e579c9fd293da102577f5cd26babfe90 Author: Pavel Roskin Date: 2019-11-29 (Fri, 29 Nov 2019) Changed paths: M src/main/java/stashpullrequestbuilder/stashpullrequestbuilder/stash/StashApiClient.java M src/test/java/stashpullrequestbuilder/stashpullrequestbuilder/stash/StashApiClientTest.java Log Message: --- StashApiClient: Run HTTP requests in the main thread (#137) * StashApiClient: Run HTTP requests in the main thread Using separate threads adds complexity for little benefit. Socket timeout should take care of slow HTTP connections. JENKINS-30558 doesn't provide any evidence that a separate timeout for requests was needed. The request timeout and the socket timeout were added in the same commit 80431f422dce9ea763e59c28e35fef75113203b1. This change eliminates ExecutionException as an exception thrown by StashApiClient, replacing it with more specific exceptions. Update unit tests for the new behavior. * StashApiClient: Declare httpTask and thread where they are initialized -- You received this message because you are subscribed to the Google Groups "Jenkins Commits" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-commits+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-commits/jenkinsci/stash-pullrequest-builder-plugin/push/refs/heads/master/dc86da-bf508b%40github.com.
[jenkinsci/stash-pullrequest-builder-plugin] dc86da: StashApiClient: Remove wrappers around mapper.read...
Branch: refs/heads/master Home: https://github.com/jenkinsci/stash-pullrequest-builder-plugin Commit: dc86da708063378002dd4666d5fc75ef609ef28d https://github.com/jenkinsci/stash-pullrequest-builder-plugin/commit/dc86da708063378002dd4666d5fc75ef609ef28d Author: Pavel Roskin Date: 2019-11-29 (Fri, 29 Nov 2019) Changed paths: M src/main/java/stashpullrequestbuilder/stashpullrequestbuilder/stash/StashApiClient.java M src/test/java/stashpullrequestbuilder/stashpullrequestbuilder/stash/StashApiClientTest.java A src/test/java/stashpullrequestbuilder/stashpullrequestbuilder/stash/StashPullRequestMergeableResponseTest.java Log Message: --- StashApiClient: Remove wrappers around mapper.readValue() (#171) Calling mapper.readValue() directly make the code more readable. Move a test for parsing StashPullRequestMergeableResponse to a new class, StashPullRequestMergeableResponseTest. Shorten the example JSON string. -- You received this message because you are subscribed to the Google Groups "Jenkins Commits" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-commits+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-commits/jenkinsci/stash-pullrequest-builder-plugin/push/refs/heads/master/7df445-dc86da%40github.com.
[jenkinsci/stash-pullrequest-builder-plugin] 7df445: AdditionalParameterRegExTest: Move one level up to...
Branch: refs/heads/master Home: https://github.com/jenkinsci/stash-pullrequest-builder-plugin Commit: 7df4453cbeeb47cca9a19df58da94501591342b8 https://github.com/jenkinsci/stash-pullrequest-builder-plugin/commit/7df4453cbeeb47cca9a19df58da94501591342b8 Author: Pavel Roskin Date: 2019-11-29 (Fri, 29 Nov 2019) Changed paths: A src/test/java/stashpullrequestbuilder/stashpullrequestbuilder/StashRepositoryRegexTest.java R src/test/java/stashpullrequestbuilder/stashpullrequestbuilder/stash/AdditionalParameterRegExTest.java Log Message: --- AdditionalParameterRegExTest: Move one level up to match StashRepository (#168) Rename it to StashRepositoryRegexTest to indicate the class under test. We can have more regex related tests in the future. Since it's a test for StashRepository, it should be in the same package, stashpullrequestbuilder.stashpullrequestbuilder. -- You received this message because you are subscribed to the Google Groups "Jenkins Commits" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-commits+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-commits/jenkinsci/stash-pullrequest-builder-plugin/push/refs/heads/master/8be630-7df445%40github.com.
[jenkinsci/stash-pullrequest-builder-plugin] b7e75d: Convert instance fields to local variables when po...
Branch: refs/heads/master Home: https://github.com/jenkinsci/stash-pullrequest-builder-plugin Commit: b7e75dd41b494b9a23874eb50091d63080112e4e https://github.com/jenkinsci/stash-pullrequest-builder-plugin/commit/b7e75dd41b494b9a23874eb50091d63080112e4e Author: Pavel Roskin Date: 2019-11-28 (Thu, 28 Nov 2019) Changed paths: M src/test/java/stashpullrequestbuilder/stashpullrequestbuilder/StashBuildListenerTest.java M src/test/java/stashpullrequestbuilder/stashpullrequestbuilder/StashRepositoryTest.java Log Message: --- Convert instance fields to local variables when possible Suggested by IntelliJ IDEA. -- You received this message because you are subscribed to the Google Groups "Jenkins Commits" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-commits+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-commits/jenkinsci/stash-pullrequest-builder-plugin/push/refs/heads/master/8ca4ef-b7e75d%40github.com.
[jenkinsci/stash-pullrequest-builder-plugin] 8ca4ef: extensions.xml: Update git-changelist-maven-extens...
Branch: refs/heads/master Home: https://github.com/jenkinsci/stash-pullrequest-builder-plugin Commit: 8ca4ef6655f32467618ba472e12642bbb4ffa9ba https://github.com/jenkinsci/stash-pullrequest-builder-plugin/commit/8ca4ef6655f32467618ba472e12642bbb4ffa9ba Author: Pavel Roskin Date: 2019-11-28 (Thu, 28 Nov 2019) Changed paths: M .mvn/extensions.xml Log Message: --- extensions.xml: Update git-changelist-maven-extension to version 1.1 -- You received this message because you are subscribed to the Google Groups "Jenkins Commits" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-commits+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-commits/jenkinsci/stash-pullrequest-builder-plugin/push/refs/heads/master/1b56ae-8ca4ef%40github.com.
[jenkinsci/stash-pullrequest-builder-plugin] 1b56ae: StashApiClient: Don't ever return null from entity...
Branch: refs/heads/master Home: https://github.com/jenkinsci/stash-pullrequest-builder-plugin Commit: 1b56ae3719b38ddd5a7545c0321c567107847965 https://github.com/jenkinsci/stash-pullrequest-builder-plugin/commit/1b56ae3719b38ddd5a7545c0321c567107847965 Author: Pavel Roskin Date: 2019-11-28 (Thu, 28 Nov 2019) Changed paths: M src/main/java/stashpullrequestbuilder/stashpullrequestbuilder/stash/StashApiClient.java Log Message: --- StashApiClient: Don't ever return null from entityAsString() EntityUtils.toString() can return null under some obscure circumstances. >From our point of view, it's the same as an empty response, as long as no exception is thrown. JSON parser would consider both as invalid JSON, but it's safer not to deal with null. Use Util.fix to convert null to an empty string. Mark getRequest() and postRequest() as @Nonnull, they return the result of entityAsString(). -- You received this message because you are subscribed to the Google Groups "Jenkins Commits" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-commits+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-commits/jenkinsci/stash-pullrequest-builder-plugin/push/refs/heads/master/a1a7f3-1b56ae%40github.com.
[jenkinsci/stash-pullrequest-builder-plugin] 61f316: Fix error handling when merging pull requests
Branch: refs/heads/master Home: https://github.com/jenkinsci/stash-pullrequest-builder-plugin Commit: 61f31689780998ec4cd8613fb9a2f602f2cee5ed https://github.com/jenkinsci/stash-pullrequest-builder-plugin/commit/61f31689780998ec4cd8613fb9a2f602f2cee5ed Author: Pavel Roskin Date: 2019-11-26 (Tue, 26 Nov 2019) Changed paths: M src/main/java/stashpullrequestbuilder/stashpullrequestbuilder/StashBuildListener.java M src/main/java/stashpullrequestbuilder/stashpullrequestbuilder/StashRepository.java M src/main/java/stashpullrequestbuilder/stashpullrequestbuilder/stash/StashApiClient.java M src/test/java/stashpullrequestbuilder/stashpullrequestbuilder/StashBuildListenerTest.java M src/test/java/stashpullrequestbuilder/stashpullrequestbuilder/stash/StashApiClientTest.java A src/test/resources/__files/PullRequestMergeFailed.json A src/test/resources/__files/PullRequestMerged.json Log Message: --- Fix error handling when merging pull requests Treat HTTP code 409 as valid. That makes it possible to process the responses sent with that code. Parse the response to the merge call as a pull request. If it succeeds and the pull request state is "MERGED", return empty Optional. Otherwise, return the server response as a string and write it to the build log. -- You received this message because you are subscribed to the Google Groups "Jenkins Commits" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-commits+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-commits/jenkinsci/stash-pullrequest-builder-plugin/push/refs/heads/master/bde3d5-61f316%40github.com.
[jenkinsci/stash-pullrequest-builder-plugin] bde3d5: StashApiClient: Refactor and simplify HTTP respons...
Branch: refs/heads/master Home: https://github.com/jenkinsci/stash-pullrequest-builder-plugin Commit: bde3d51191b66122379834b1e0a94029c399d9c7 https://github.com/jenkinsci/stash-pullrequest-builder-plugin/commit/bde3d51191b66122379834b1e0a94029c399d9c7 Author: Pavel Roskin Date: 2019-11-26 (Tue, 26 Nov 2019) Changed paths: M src/main/java/stashpullrequestbuilder/stashpullrequestbuilder/stash/StashApiClient.java Log Message: --- StashApiClient: Refactor and simplify HTTP response processing Use EntityUtils to convert HTTP response to a string. Rethrow IOException as StashApiException. The whole response was logged twice in postRequest() at the FINEST level. Log it only once. -- You received this message because you are subscribed to the Google Groups "Jenkins Commits" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-commits+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-commits/jenkinsci/stash-pullrequest-builder-plugin/push/refs/heads/master/fa1544-bde3d5%40github.com.
[jenkinsci/stash-pullrequest-builder-plugin] 040c4d: StashCause: Generate environment on demand, don't ...
Branch: refs/heads/master Home: https://github.com/jenkinsci/stash-pullrequest-builder-plugin Commit: 040c4d4f9569deda974205fc210f6a986a9beb3b https://github.com/jenkinsci/stash-pullrequest-builder-plugin/commit/040c4d4f9569deda974205fc210f6a986a9beb3b Author: Pavel Roskin Date: 2019-11-25 (Mon, 25 Nov 2019) Changed paths: M src/main/java/stashpullrequestbuilder/stashpullrequestbuilder/StashCause.java Log Message: --- StashCause: Generate environment on demand, don't keep it A transient map is lost on Jenkins restart for queue items. That was causing a null pointer exception in StashBuildEnvironmentContributor. If the environment was kept as a non-transient map, it would be saved to build.xml, duplicating already saved information from individual StashCause fields. -- You received this message because you are subscribed to the Google Groups "Jenkins Commits" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-commits+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-commits/jenkinsci/stash-pullrequest-builder-plugin/push/refs/heads/master/1c8e96-040c4d%40github.com.
[jenkinsci/stash-pullrequest-builder-plugin] e2d8bc: StashBuildListener: Make logging in onStarted() mo...
Branch: refs/heads/master Home: https://github.com/jenkinsci/stash-pullrequest-builder-plugin Commit: e2d8bc8b2d1f1be0676c502733a61bc0ed7bd097 https://github.com/jenkinsci/stash-pullrequest-builder-plugin/commit/e2d8bc8b2d1f1be0676c502733a61bc0ed7bd097 Author: Pavel Roskin Date: 2019-11-25 (Mon, 25 Nov 2019) Changed paths: M src/main/java/stashpullrequestbuilder/stashpullrequestbuilder/StashBuildListener.java Log Message: --- StashBuildListener: Make logging in onStarted() more informative That's one of the few log messages at the INFO level for the happy case, so it should provide more details. Log the run (that includes the job name and the build number), the pull request ID and the commit hash to be tested. Commit: fa15440c2684e600db9a528f43e5efe22fba9a68 https://github.com/jenkinsci/stash-pullrequest-builder-plugin/commit/fa15440c2684e600db9a528f43e5efe22fba9a68 Author: Pavel Roskin Date: 2019-11-25 (Mon, 25 Nov 2019) Changed paths: M src/main/java/stashpullrequestbuilder/stashpullrequestbuilder/StashRepository.java Log Message: --- StashRepository: Improve logging when a job is queued Log the full name of the job, as it cannot be easily found from the Jenkins log. Move logging next to the corresponding poll log calls. If the job cannot be queued, use the WARNING log level. Compare: https://github.com/jenkinsci/stash-pullrequest-builder-plugin/compare/040c4d4f9569...fa15440c2684 -- You received this message because you are subscribed to the Google Groups "Jenkins Commits" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-commits+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-commits/jenkinsci/stash-pullrequest-builder-plugin/push/refs/heads/master/040c4d-fa1544%40github.com.
[jenkinsci/stash-pullrequest-builder-plugin] 1c8e96: Use assertThrows from JUnit 4.13 instead of Expect...
Branch: refs/heads/master Home: https://github.com/jenkinsci/stash-pullrequest-builder-plugin Commit: 1c8e961a6b13ee014faa6377fec3f567fe92b53d https://github.com/jenkinsci/stash-pullrequest-builder-plugin/commit/1c8e961a6b13ee014faa6377fec3f567fe92b53d Author: Pavel Roskin Date: 2019-11-25 (Mon, 25 Nov 2019) Changed paths: M pom.xml M src/test/java/stashpullrequestbuilder/stashpullrequestbuilder/stash/StashApiClientTest.java M src/test/java/stashpullrequestbuilder/stashpullrequestbuilder/stash/StashPullRequestCommentTest.java Log Message: --- Use assertThrows from JUnit 4.13 instead of ExpectedException Use JUnit 4.13-rc-1 until JUnit 4.13 is released. -- You received this message because you are subscribed to the Google Groups "Jenkins Commits" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-commits+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-commits/jenkinsci/stash-pullrequest-builder-plugin/push/refs/heads/master/c577a4-1c8e96%40github.com.
[jenkinsci/stash-pullrequest-builder-plugin] c577a4: StashRepository: Reduce nesting in isForTargetBran...
Branch: refs/heads/master Home: https://github.com/jenkinsci/stash-pullrequest-builder-plugin Commit: c577a4df811f96bcd39bf94117e65c060caf95a4 https://github.com/jenkinsci/stash-pullrequest-builder-plugin/commit/c577a4df811f96bcd39bf94117e65c060caf95a4 Author: Pavel Roskin Date: 2019-11-25 (Mon, 25 Nov 2019) Changed paths: M src/main/java/stashpullrequestbuilder/stashpullrequestbuilder/StashRepository.java Log Message: --- StashRepository: Reduce nesting in isForTargetBranch() Check for a simple condition first, return early. Suggested by sb-contrib plugin for SpotBugs. -- You received this message because you are subscribed to the Google Groups "Jenkins Commits" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-commits+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-commits/jenkinsci/stash-pullrequest-builder-plugin/push/refs/heads/master/c8f0ef-c577a4%40github.com.
[jenkinsci/stash-pullrequest-builder-plugin] d2c6a4: StashRepository: Take pollLog as a constructor arg...
Branch: refs/heads/master Home: https://github.com/jenkinsci/stash-pullrequest-builder-plugin Commit: d2c6a4b8177c8ce4dc6a53222ae2248ca850d04d https://github.com/jenkinsci/stash-pullrequest-builder-plugin/commit/d2c6a4b8177c8ce4dc6a53222ae2248ca850d04d Author: Pavel Roskin Date: 2019-11-25 (Mon, 25 Nov 2019) Changed paths: M src/main/java/stashpullrequestbuilder/stashpullrequestbuilder/StashBuildTrigger.java M src/main/java/stashpullrequestbuilder/stashpullrequestbuilder/StashRepository.java M src/test/java/stashpullrequestbuilder/stashpullrequestbuilder/StashRepositoryTest.java Log Message: --- StashRepository: Take pollLog as a constructor argument Move the code that logs common information (start and stop time, duration, number of pull requests) to pollRepository(). Add a unit test to check that the common information is being logged. Commit: 9d21d4f7a99628c21002b6a4db55ab6586ddff24 https://github.com/jenkinsci/stash-pullrequest-builder-plugin/commit/9d21d4f7a99628c21002b6a4db55ab6586ddff24 Author: Pavel Roskin Date: 2019-11-25 (Mon, 25 Nov 2019) Changed paths: M src/main/java/stashpullrequestbuilder/stashpullrequestbuilder/StashRepository.java Log Message: --- StashRepository: Log exceptions to the poll log and to the system log Even users without administrative access should know if their PRs are not built due to an exception. Commit: c8f0efb629c17307ff440707b3a0f27d1a46fa3d https://github.com/jenkinsci/stash-pullrequest-builder-plugin/commit/c8f0efb629c17307ff440707b3a0f27d1a46fa3d Author: Pavel Roskin Date: 2019-11-25 (Mon, 25 Nov 2019) Changed paths: M src/main/java/stashpullrequestbuilder/stashpullrequestbuilder/StashRepository.java Log Message: --- StashRepository: Log triggering decisions to the poll log only If a message explains why a PR is not being built, log it to the poll log only, unless it's caused by an exception. Triggering decisions depend on the state of the PR and don't appear and disappear on their own. It is not of much interest why a PR wasn't built in the past. No need to fill logs with messages about pull requests that cannot be merged for every polling cycle. Compare: https://github.com/jenkinsci/stash-pullrequest-builder-plugin/compare/70be4cf1df7e...c8f0efb629c1 -- You received this message because you are subscribed to the Google Groups "Jenkins Commits" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-commits+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-commits/jenkinsci/stash-pullrequest-builder-plugin/push/refs/heads/master/70be4c-c8f0ef%40github.com.
[jenkinsci/stash-pullrequest-builder-plugin] 70be4c: StashPullRequestCommentTest: Don't check that comp...
Branch: refs/heads/master Home: https://github.com/jenkinsci/stash-pullrequest-builder-plugin Commit: 70be4cf1df7eb0f5db355c74f367f19d8ddb6e11 https://github.com/jenkinsci/stash-pullrequest-builder-plugin/commit/70be4cf1df7eb0f5db355c74f367f19d8ddb6e11 Author: Pavel Roskin Date: 2019-11-05 (Tue, 05 Nov 2019) Changed paths: M src/test/java/stashpullrequestbuilder/stashpullrequestbuilder/stash/StashPullRequestCommentTest.java Log Message: --- StashPullRequestCommentTest: Don't check that compareTo(null) throws We don't rely on that functionality, and the fb-contrib detects a "scary" bug in that code. -- You received this message because you are subscribed to the Google Groups "Jenkins Commits" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-commits+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-commits/jenkinsci/stash-pullrequest-builder-plugin/push/refs/heads/master/bbd7f7-70be4c%40github.com.
[jenkinsci/stash-pullrequest-builder-plugin] bbd7f7: StashPullRequestResponseValueRepositoryRepository:...
Branch: refs/heads/master Home: https://github.com/jenkinsci/stash-pullrequest-builder-plugin Commit: bbd7f7a77195f72ca7e2169e6b56baa10cb382e8 https://github.com/jenkinsci/stash-pullrequest-builder-plugin/commit/bbd7f7a77195f72ca7e2169e6b56baa10cb382e8 Author: Pavel Roskin Date: 2019-11-05 (Tue, 05 Nov 2019) Changed paths: M src/main/java/stashpullrequestbuilder/stashpullrequestbuilder/stash/StashPullRequestResponseValueRepositoryRepository.java Log Message: --- StashPullRequestResponseValueRepositoryRepository: Remove useless null check Whether project.getKey() is null or not, getProjectName() would return project.getKey(). Mark getProjectName() as Nullable. -- You received this message because you are subscribed to the Google Groups "Jenkins Commits" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-commits+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-commits/jenkinsci/stash-pullrequest-builder-plugin/push/refs/heads/master/46b155-bbd7f7%40github.com.
[jenkinsci/stash-pullrequest-builder-plugin] 46b155: StashApiClient: Use Iterable instead of List as ar...
Branch: refs/heads/master Home: https://github.com/jenkinsci/stash-pullrequest-builder-plugin Commit: 46b1550db2782db3fe74fe80e0e703221c75646f https://github.com/jenkinsci/stash-pullrequest-builder-plugin/commit/46b1550db2782db3fe74fe80e0e703221c75646f Author: Pavel Roskin Date: 2019-11-05 (Tue, 05 Nov 2019) Changed paths: M src/main/java/stashpullrequestbuilder/stashpullrequestbuilder/stash/StashApiClient.java Log Message: --- StashApiClient: Use Iterable instead of List as argument when possible -- You received this message because you are subscribed to the Google Groups "Jenkins Commits" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-commits+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-commits/jenkinsci/stash-pullrequest-builder-plugin/push/refs/heads/master/98bc0b-46b155%40github.com.
[jenkinsci/stash-pullrequest-builder-plugin] 98bc0b: StashRepository: Add Nullable annotations to funct...
Branch: refs/heads/master Home: https://github.com/jenkinsci/stash-pullrequest-builder-plugin Commit: 98bc0b5893bf2c945744dad4b9bebc19081d5621 https://github.com/jenkinsci/stash-pullrequest-builder-plugin/commit/98bc0b5893bf2c945744dad4b9bebc19081d5621 Author: Pavel Roskin Date: 2019-11-05 (Tue, 05 Nov 2019) Changed paths: M src/main/java/stashpullrequestbuilder/stashpullrequestbuilder/StashRepository.java Log Message: --- StashRepository: Add Nullable annotations to functions that can return null -- You received this message because you are subscribed to the Google Groups "Jenkins Commits" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-commits+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-commits/jenkinsci/stash-pullrequest-builder-plugin/push/refs/heads/master/b01fc7-98bc0b%40github.com.
[jenkinsci/stash-pullrequest-builder-plugin] b01fc7: StashApiClient: Remove unnecessary variables when ...
Branch: refs/heads/master Home: https://github.com/jenkinsci/stash-pullrequest-builder-plugin Commit: b01fc7d71264ae6e3f1c76adc1f676b25e1c9660 https://github.com/jenkinsci/stash-pullrequest-builder-plugin/commit/b01fc7d71264ae6e3f1c76adc1f676b25e1c9660 Author: Pavel Roskin Date: 2019-11-05 (Tue, 05 Nov 2019) Changed paths: M src/main/java/stashpullrequestbuilder/stashpullrequestbuilder/stash/StashApiClient.java Log Message: --- StashApiClient: Remove unnecessary variables when returning a value -- You received this message because you are subscribed to the Google Groups "Jenkins Commits" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-commits+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-commits/jenkinsci/stash-pullrequest-builder-plugin/push/refs/heads/master/e5bf62-b01fc7%40github.com.
[jenkinsci/stash-pullrequest-builder-plugin] e5bf62: StashApiClientTest: Fix tests on systems that list...
Branch: refs/heads/master Home: https://github.com/jenkinsci/stash-pullrequest-builder-plugin Commit: e5bf623cccffafb2f13c9f69102997337996d472 https://github.com/jenkinsci/stash-pullrequest-builder-plugin/commit/e5bf623cccffafb2f13c9f69102997337996d472 Author: Pavel Roskin Date: 2019-10-31 (Thu, 31 Oct 2019) Changed paths: M src/test/java/stashpullrequestbuilder/stashpullrequestbuilder/stash/StashApiClientTest.java Log Message: --- StashApiClientTest: Fix tests on systems that listen to HTTP port 8080 WireMock listens to HTTP port 8080 by default, even if HTTPS port is dynamic and no tests use HTTP. Use dynamic ports both for HTTP and HTTPS. -- You received this message because you are subscribed to the Google Groups "Jenkins Commits" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-commits+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-commits/jenkinsci/stash-pullrequest-builder-plugin/push/refs/heads/master/a0f85a-e5bf62%40github.com.
[jenkinsci/stash-pullrequest-builder-plugin] a0f85a: StashRepository: Only cancel queue items for the s...
Branch: refs/heads/master Home: https://github.com/jenkinsci/stash-pullrequest-builder-plugin Commit: a0f85af9541cd4339024b0c5f968b48c678647d2 https://github.com/jenkinsci/stash-pullrequest-builder-plugin/commit/a0f85af9541cd4339024b0c5f968b48c678647d2 Author: Pavel Roskin Date: 2019-10-31 (Thu, 31 Oct 2019) Changed paths: M src/main/java/stashpullrequestbuilder/stashpullrequestbuilder/StashRepository.java Log Message: --- StashRepository: Only cancel queue items for the same job One repository can use multiple pull request builders. Don't let them cancel each other's queue items when "cancel outdated jobs" is enabled. Log the job name when canceling a queue item. -- You received this message because you are subscribed to the Google Groups "Jenkins Commits" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-commits+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-commits/jenkinsci/stash-pullrequest-builder-plugin/push/refs/heads/master/f46c24-a0f85a%40github.com.
[jenkinsci/stash-pullrequest-builder-plugin] f46c24: Use StringUtils.isEmpty() and StringUtils.isNotEmp...
Branch: refs/heads/master Home: https://github.com/jenkinsci/stash-pullrequest-builder-plugin Commit: f46c24f001f728722a7d2c5cc922e0a930e252d3 https://github.com/jenkinsci/stash-pullrequest-builder-plugin/commit/f46c24f001f728722a7d2c5cc922e0a930e252d3 Author: Pavel Roskin Date: 2019-10-30 (Wed, 30 Oct 2019) Changed paths: M src/main/java/stashpullrequestbuilder/stashpullrequestbuilder/StashBuildListener.java M src/main/java/stashpullrequestbuilder/stashpullrequestbuilder/StashRepository.java Log Message: --- Use StringUtils.isEmpty() and StringUtils.isNotEmpty() where appropriate -- You received this message because you are subscribed to the Google Groups "Jenkins Commits" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-commits+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-commits/jenkinsci/stash-pullrequest-builder-plugin/push/refs/heads/master/a91e52-f46c24%40github.com.
[jenkinsci/stash-pullrequest-builder-plugin] 325c18: [JENKINS-59833] Prevent unwanted folding of multip...
Branch: refs/heads/master Home: https://github.com/jenkinsci/stash-pullrequest-builder-plugin Commit: 325c18a0373a72f81f4cde89c666ebb6c2b0a433 https://github.com/jenkinsci/stash-pullrequest-builder-plugin/commit/325c18a0373a72f81f4cde89c666ebb6c2b0a433 Author: Pavel Roskin Date: 2019-10-23 (Wed, 23 Oct 2019) Changed paths: A src/main/java/stashpullrequestbuilder/stashpullrequestbuilder/StashQueueAction.java M src/main/java/stashpullrequestbuilder/stashpullrequestbuilder/StashRepository.java Log Message: --- [JENKINS-59833] Prevent unwanted folding of multiple queue tasks into one Add StashQueueAction class that always requests a new task to be scheduled. -- You received this message because you are subscribed to the Google Groups "Jenkins Commits" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-commits+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-commits/jenkinsci/stash-pullrequest-builder-plugin/push/refs/heads/master/655006-325c18%40github.com.
[jenkinsci/stash-pullrequest-builder-plugin] 655006: pom.xml: Use GitHub for plugin's documentation on ...
Branch: refs/heads/master Home: https://github.com/jenkinsci/stash-pullrequest-builder-plugin Commit: 655006ce4c3c4d9fed17ddba9ee6a6b96b783970 https://github.com/jenkinsci/stash-pullrequest-builder-plugin/commit/655006ce4c3c4d9fed17ddba9ee6a6b96b783970 Author: Pavel Roskin Date: 2019-10-21 (Mon, 21 Oct 2019) Changed paths: M pom.xml Log Message: --- pom.xml: Use GitHub for plugin's documentation on plugins.jenkins.io This fixes duplication of the documentation between the plugin sources and the plugin website. See https://groups.google.com/forum/#!topic/jenkinsci-dev/VSdfVMDIW-A and https://issues.jenkins-ci.org/browse/WEBSITE-406 for details. -- You received this message because you are subscribed to the Google Groups "Jenkins Commits" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-commits+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-commits/jenkinsci/stash-pullrequest-builder-plugin/push/refs/heads/master/36251a-655006%40github.com.
[jenkinsci/stash-pullrequest-builder-plugin] 4ba7f6: Construct StashApiClient in StashBuildTrigger
Branch: refs/heads/master Home: https://github.com/jenkinsci/stash-pullrequest-builder-plugin Commit: 4ba7f645bbdc373ecd4cb1ab786a0f2588f6 https://github.com/jenkinsci/stash-pullrequest-builder-plugin/commit/4ba7f645bbdc373ecd4cb1ab786a0f2588f6 Author: Pavel Roskin Date: 2019-08-20 (Tue, 20 Aug 2019) Changed paths: M src/main/java/stashpullrequestbuilder/stashpullrequestbuilder/StashBuildTrigger.java M src/main/java/stashpullrequestbuilder/stashpullrequestbuilder/StashRepository.java M src/test/java/stashpullrequestbuilder/stashpullrequestbuilder/StashRepositoryTest.java Log Message: --- Construct StashApiClient in StashBuildTrigger Use a single StashRepository constructor. Don't test StashApiClient in StashRepositoryTest. Remove WireMock from StashRepositoryTest. Commit: 45da95f53725fdda09048d48c8383e77a1a0d7f1 https://github.com/jenkinsci/stash-pullrequest-builder-plugin/commit/45da95f53725fdda09048d48c8383e77a1a0d7f1 Author: Pavel Roskin Date: 2019-08-20 (Tue, 20 Aug 2019) Changed paths: M src/main/java/stashpullrequestbuilder/stashpullrequestbuilder/StashBuildTrigger.java Log Message: --- StashBuildTrigger: Don't throw NullPointerException unnecessarily If job is null, report it and return. Looking at the Jenkins code, it should not happen, but Javadoc makes no explicit promises, and the job argument is not annotated with @Nonnull. Report all possible exceptions in start(), not just NullPointerException. The calling code may not be well prepared to deal with exceptions. Compare: https://github.com/jenkinsci/stash-pullrequest-builder-plugin/compare/4cedf70ffacf...45da95f53725 -- You received this message because you are subscribed to the Google Groups "Jenkins Commits" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-commits+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-commits/jenkinsci/stash-pullrequest-builder-plugin/push/refs/heads/master/4cedf7-45da95%40github.com.
[jenkinsci/stash-pullrequest-builder-plugin] 1a6e19: StashBuildTrigger: Fix exception if run() is calle...
Branch: refs/heads/master Home: https://github.com/jenkinsci/stash-pullrequest-builder-plugin Commit: 1a6e19a85b8e3050ec86ae0975054101f3e2d0f8 https://github.com/jenkinsci/stash-pullrequest-builder-plugin/commit/1a6e19a85b8e3050ec86ae0975054101f3e2d0f8 Author: Pavel Roskin Date: 2019-08-09 (Fri, 09 Aug 2019) Changed paths: M src/main/java/stashpullrequestbuilder/stashpullrequestbuilder/StashBuildTrigger.java Log Message: --- StashBuildTrigger: Fix exception if run() is called after stop() Trigger#stop() doesn't set job to null, so having a non-null job doesn't guarantee that stashRepository is not null. -- You received this message because you are subscribed to the Google Groups "Jenkins Commits" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-commits+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-commits/jenkinsci/stash-pullrequest-builder-plugin/push/refs/heads/master/0a65ef-1a6e19%40github.com.
[jenkinsci/stash-pullrequest-builder-plugin] 0a65ef: pom.xml: Update revision to 1.13
Branch: refs/heads/master Home: https://github.com/jenkinsci/stash-pullrequest-builder-plugin Commit: 0a65efa12975a75e49c81bf0b241f78419aa42cf https://github.com/jenkinsci/stash-pullrequest-builder-plugin/commit/0a65efa12975a75e49c81bf0b241f78419aa42cf Author: Pavel Roskin Date: 2019-08-09 (Fri, 09 Aug 2019) Changed paths: M pom.xml Log Message: --- pom.xml: Update revision to 1.13 The revision is updated in the incrementals:reincrementalify commits, but the last such commit didn't update the revision. -- You received this message because you are subscribed to the Google Groups "Jenkins Commits" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-commits+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-commits/jenkinsci/stash-pullrequest-builder-plugin/push/refs/heads/master/dec78f-0a65ef%40github.com.
[jenkinsci/stash-pullrequest-builder-plugin] dec78f: StashPostBuildCommentAction: Remove, it has been o...
Branch: refs/heads/master Home: https://github.com/jenkinsci/stash-pullrequest-builder-plugin Commit: dec78fd9ff18f077567d4a24ca9b4133ebb09260 https://github.com/jenkinsci/stash-pullrequest-builder-plugin/commit/dec78fd9ff18f077567d4a24ca9b4133ebb09260 Author: Pavel Roskin Date: 2019-08-08 (Thu, 08 Aug 2019) Changed paths: R src/main/java/stashpullrequestbuilder/stashpullrequestbuilder/StashPostBuildCommentAction.java Log Message: --- StashPostBuildCommentAction: Remove, it has been obsolete since version 1.9 Starting with plugin version 1.9, this file has been used to suppress warnings about unreadable data when upgrading from plugin version 1.8 and older. The compatibility code have been around for a long time, it should be safe to remove now. Not having this file in the version 1.13 of the plugin means that users upgrading directly from version 1.8 and older directly to version 1.13 and newer would get warnings about unreadable fields. The warnings are actually harmless and can be trivially cleared. The unused fields were triggering warnings in SpotBugs and FindBugs when threshold was set to Low. -- You received this message because you are subscribed to the Google Groups "Jenkins Commits" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-commits+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-commits/jenkinsci/stash-pullrequest-builder-plugin/push/refs/heads/master/630fe1-dec78f%40github.com.
[jenkinsci/stash-pullrequest-builder-plugin] 630fe1: Remove template parameters that can be deduced
Branch: refs/heads/master Home: https://github.com/jenkinsci/stash-pullrequest-builder-plugin Commit: 630fe163a6cff74d0eb7496c54e1e9cec6f11774 https://github.com/jenkinsci/stash-pullrequest-builder-plugin/commit/630fe163a6cff74d0eb7496c54e1e9cec6f11774 Author: Pavel Roskin Date: 2019-08-07 (Wed, 07 Aug 2019) Changed paths: M src/main/java/stashpullrequestbuilder/stashpullrequestbuilder/StashRepository.java M src/main/java/stashpullrequestbuilder/stashpullrequestbuilder/stash/StashApiClient.java M src/test/java/stashpullrequestbuilder/stashpullrequestbuilder/StashBuildEnvironmentContributorTest.java M src/test/java/stashpullrequestbuilder/stashpullrequestbuilder/StashBuildListenerTest.java Log Message: --- Remove template parameters that can be deduced -- You received this message because you are subscribed to the Google Groups "Jenkins Commits" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-commits+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-commits/jenkinsci/stash-pullrequest-builder-plugin/push/refs/heads/master/0846a0-630fe1%40github.com.
[jenkinsci/stash-pullrequest-builder-plugin] 496a8c: Update Wiremock to version 2.24.0
Branch: refs/heads/master Home: https://github.com/jenkinsci/stash-pullrequest-builder-plugin Commit: 496a8cc737d3815f61300cf8633cc912820de383 https://github.com/jenkinsci/stash-pullrequest-builder-plugin/commit/496a8cc737d3815f61300cf8633cc912820de383 Author: Pavel Roskin Date: 2019-08-07 (Wed, 07 Aug 2019) Changed paths: M pom.xml M src/test/java/stashpullrequestbuilder/stashpullrequestbuilder/stash/StashApiClientTest.java Log Message: --- Update Wiremock to version 2.24.0 Version 2.23.2 has an issue with absent() for the request body in verifications. Remove the workaround. Commit: 0846a06e7c7a97db0c8c7fededec6aef8f0fc58b https://github.com/jenkinsci/stash-pullrequest-builder-plugin/commit/0846a06e7c7a97db0c8c7fededec6aef8f0fc58b Author: Pavel Roskin Date: 2019-08-07 (Wed, 07 Aug 2019) Changed paths: M pom.xml Log Message: --- pom.xml: Update fmt-maven-plugin to version 2.9 Compare: https://github.com/jenkinsci/stash-pullrequest-builder-plugin/compare/85ce1e7c628c...0846a06e7c7a -- You received this message because you are subscribed to the Google Groups "Jenkins Commits" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-commits+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-commits/jenkinsci/stash-pullrequest-builder-plugin/push/refs/heads/master/85ce1e-0846a0%40github.com.
[jenkinsci/stash-pullrequest-builder-plugin] 3fe807: Update to parent POM 3.48, add SpotBugs settings
Branch: refs/heads/master Home: https://github.com/jenkinsci/stash-pullrequest-builder-plugin Commit: 3fe8073797f660f2dccac500dff0ed1bd054301b https://github.com/jenkinsci/stash-pullrequest-builder-plugin/commit/3fe8073797f660f2dccac500dff0ed1bd054301b Author: Pavel Roskin Date: 2019-08-07 (Wed, 07 Aug 2019) Changed paths: M pom.xml Log Message: --- Update to parent POM 3.48, add SpotBugs settings The update makes "mvn verify" invoke SpotBugs instead of FindBugs. Don't set Mockito version, the parent is using a newer version. -- You received this message because you are subscribed to the Google Groups "Jenkins Commits" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-commits+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-commits/jenkinsci/stash-pullrequest-builder-plugin/push/refs/heads/master/c216c7-3fe807%40github.com.
[jenkinsci/stash-pullrequest-builder-plugin] 85ce1e: StashRepositoryTest: Use Collections.singletonList...
Branch: refs/heads/master Home: https://github.com/jenkinsci/stash-pullrequest-builder-plugin Commit: 85ce1e7c628c7993ef01e599202df6ff6baf99a1 https://github.com/jenkinsci/stash-pullrequest-builder-plugin/commit/85ce1e7c628c7993ef01e599202df6ff6baf99a1 Author: Pavel Roskin Date: 2019-08-07 (Wed, 07 Aug 2019) Changed paths: M src/test/java/stashpullrequestbuilder/stashpullrequestbuilder/StashRepositoryTest.java Log Message: --- StashRepositoryTest: Use Collections.singletonList for a single element list -- You received this message because you are subscribed to the Google Groups "Jenkins Commits" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-commits+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-commits/jenkinsci/stash-pullrequest-builder-plugin/push/refs/heads/master/3fe807-85ce1e%40github.com.
[jenkinsci/stash-pullrequest-builder-plugin] c216c7: Add a "Polling Log" page as a link on the project ...
Branch: refs/heads/master Home: https://github.com/jenkinsci/stash-pullrequest-builder-plugin Commit: c216c76f86a5ccc98026bbb83f5374f21fa290ee https://github.com/jenkinsci/stash-pullrequest-builder-plugin/commit/c216c76f86a5ccc98026bbb83f5374f21fa290ee Author: Pavel Roskin Date: 2019-08-06 (Tue, 06 Aug 2019) Changed paths: M pom.xml M src/main/java/stashpullrequestbuilder/stashpullrequestbuilder/StashBuildTrigger.java A src/main/java/stashpullrequestbuilder/stashpullrequestbuilder/StashPollingAction.java A src/main/java/stashpullrequestbuilder/stashpullrequestbuilder/StashPollingActionFactory.java M src/main/java/stashpullrequestbuilder/stashpullrequestbuilder/StashRepository.java A src/main/resources/stashpullrequestbuilder/stashpullrequestbuilder/StashPollingAction/index.jelly A src/test/java/stashpullrequestbuilder/stashpullrequestbuilder/StashPollingActionFactoryTest.java A src/test/java/stashpullrequestbuilder/stashpullrequestbuilder/StashPollingActionTest.java M src/test/java/stashpullrequestbuilder/stashpullrequestbuilder/StashRepositoryTest.java Log Message: --- Add a "Polling Log" page as a link on the project page Add StashPollingAction class, which is an Action and a logger. Use slf4j MessageFormatter for the log messages. Add slf4j dependency. StashPollingActionFactory is used to inject StashPollingAction into the project using the Extension mechanism. Change StashBuildTrigger and StashRepository to write information about polling to the polling log. Some messages are now logged both to the polling log and to the global Jenkins log. -- You received this message because you are subscribed to the Google Groups "Jenkins Commits" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-commits+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-commits/jenkinsci/stash-pullrequest-builder-plugin/push/refs/heads/master/7b8366-c216c7%40github.com.
[jenkinsci/stash-pullrequest-builder-plugin] 7b8366: StashPullRequestActivity: Don't implement Comparab...
Branch: refs/heads/master Home: https://github.com/jenkinsci/stash-pullrequest-builder-plugin Commit: 7b8366a43b7c0297c7948cd93cf7d5aed8991937 https://github.com/jenkinsci/stash-pullrequest-builder-plugin/commit/7b8366a43b7c0297c7948cd93cf7d5aed8991937 Author: Pavel Roskin Date: 2019-08-06 (Tue, 06 Aug 2019) Changed paths: M src/main/java/stashpullrequestbuilder/stashpullrequestbuilder/stash/StashPullRequestActivity.java Log Message: --- StashPullRequestActivity: Don't implement Comparable, it is not used Remove FindBugs suppressions. -- You received this message because you are subscribed to the Google Groups "Jenkins Commits" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-commits+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-commits/jenkinsci/stash-pullrequest-builder-plugin/push/refs/heads/master/2f1676-7b8366%40github.com.
[jenkinsci/stash-pullrequest-builder-plugin] 2f1676: StashRepository: Use StringUtils.containsIgnoreCas...
Branch: refs/heads/master Home: https://github.com/jenkinsci/stash-pullrequest-builder-plugin Commit: 2f1676d3ba828e28adcabdb9e1a340fa216bdb46 https://github.com/jenkinsci/stash-pullrequest-builder-plugin/commit/2f1676d3ba828e28adcabdb9e1a340fa216bdb46 Author: Pavel Roskin Date: 2019-08-06 (Tue, 06 Aug 2019) Changed paths: M src/main/java/stashpullrequestbuilder/stashpullrequestbuilder/StashRepository.java Log Message: --- StashRepository: Use StringUtils.containsIgnoreCase() and StringUtils.isEmpty() This improves readability of the code in isPhrasesContain(). It also fixes a low-priority FindBugs warning. -- You received this message because you are subscribed to the Google Groups "Jenkins Commits" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-commits+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-commits/jenkinsci/stash-pullrequest-builder-plugin/push/refs/heads/master/21c820-2f1676%40github.com.
[jenkinsci/stash-pullrequest-builder-plugin] 668a28: Update to Apache httpclient 4.5.x
Branch: refs/heads/master Home: https://github.com/jenkinsci/stash-pullrequest-builder-plugin Commit: 668a2863946545f5a8f9a1b1c67a9a99fb942c55 https://github.com/jenkinsci/stash-pullrequest-builder-plugin/commit/668a2863946545f5a8f9a1b1c67a9a99fb942c55 Author: Pavel Roskin Date: 2019-08-06 (Tue, 06 Aug 2019) Changed paths: M pom.xml M src/main/java/stashpullrequestbuilder/stashpullrequestbuilder/stash/StashApiClient.java M src/test/java/stashpullrequestbuilder/stashpullrequestbuilder/stash/StashApiClientTest.java Log Message: --- Update to Apache httpclient 4.5.x Many properties of the connection between Jenkins and Bitbucket server can now be set as Java parameters. The list of the supported parameters is available at https://hc.apache.org/httpcomponents-client-ga/httpclient/apidocs/org/apache/http/impl/client/HttpClientBuilder.html Additionally, many compiler warnings are fixed by removing obsolete code. Original patch by Albertin Loic Commit: 21c820668432f7d9ee0b9246c353c00030e676cf https://github.com/jenkinsci/stash-pullrequest-builder-plugin/commit/21c820668432f7d9ee0b9246c353c00030e676cf Author: Pavel Roskin Date: 2019-08-06 (Tue, 06 Aug 2019) Changed paths: M pom.xml R src/findbugs-exclude.xml R src/main/java/stashpullrequestbuilder/stashpullrequestbuilder/repackage/org/apache/commons/httpclient/contrib/ssl/EasySSLProtocolSocketFactory.java R src/main/java/stashpullrequestbuilder/stashpullrequestbuilder/repackage/org/apache/commons/httpclient/contrib/ssl/EasyX509TrustManager.java Log Message: --- Remove repackaged EasySSLProtocolSocketFactory, it's not used anymore Remove corresponding exclusions for Javadoc and FindBugs Compare: https://github.com/jenkinsci/stash-pullrequest-builder-plugin/compare/9df78f7df345...21c820668432 -- You received this message because you are subscribed to the Google Groups "Jenkins Commits" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-commits+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-commits/jenkinsci/stash-pullrequest-builder-plugin/push/refs/heads/master/9df78f-21c820%40github.com.
[jenkinsci/stash-pullrequest-builder-plugin] 776e52: StashApiClientTest: Add a test for parsing all pul...
Branch: refs/heads/master Home: https://github.com/jenkinsci/stash-pullrequest-builder-plugin Commit: 776e521af22ea82bd420ee38e2453865fce64322 https://github.com/jenkinsci/stash-pullrequest-builder-plugin/commit/776e521af22ea82bd420ee38e2453865fce64322 Author: Pavel Roskin Date: 2019-08-06 (Tue, 06 Aug 2019) Changed paths: M src/test/java/stashpullrequestbuilder/stashpullrequestbuilder/stash/StashApiClientTest.java A src/test/resources/__files/PullRequestListSingle.json Log Message: --- StashApiClientTest: Add a test for parsing all pull request fields Make sure that the branch name is taken from the "name" field, not from "Name". That works only in absence of the "id" field. Commit: 9df78f7df3458d43b3cfe48ad2fa44d527f9c5ee https://github.com/jenkinsci/stash-pullrequest-builder-plugin/commit/9df78f7df3458d43b3cfe48ad2fa44d527f9c5ee Author: Pavel Roskin Date: 2019-08-06 (Tue, 06 Aug 2019) Changed paths: M src/main/java/stashpullrequestbuilder/stashpullrequestbuilder/stash/StashPullRequestResponseValueRepositoryBranch.java Log Message: --- StashPullRequestResponseValueRepositoryBranch: Use lowercase "name" field Capitalized field names are flagged by FindBugs as non-standard. Naming of private fields should not affect JSON deserialization. The "name" field is deserialized using the standard setter, setName(). Compare: https://github.com/jenkinsci/stash-pullrequest-builder-plugin/compare/e188806b163e...9df78f7df345 -- You received this message because you are subscribed to the Google Groups "Jenkins Commits" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-commits+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-commits/jenkinsci/stash-pullrequest-builder-plugin/push/refs/heads/master/e18880-9df78f%40github.com.
[jenkinsci/stash-pullrequest-builder-plugin] e18880: StashPullRequestComment: Use a method reference in...
Branch: refs/heads/master Home: https://github.com/jenkinsci/stash-pullrequest-builder-plugin Commit: e188806b163e6719ca2317fd137baa1586847875 https://github.com/jenkinsci/stash-pullrequest-builder-plugin/commit/e188806b163e6719ca2317fd137baa1586847875 Author: Pavel Roskin Date: 2019-08-06 (Tue, 06 Aug 2019) Changed paths: M src/main/java/stashpullrequestbuilder/stashpullrequestbuilder/stash/StashPullRequestComment.java Log Message: --- StashPullRequestComment: Use a method reference instead of a lambda -- You received this message because you are subscribed to the Google Groups "Jenkins Commits" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-commits+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-commits/jenkinsci/stash-pullrequest-builder-plugin/push/refs/heads/master/c1b8c9-e18880%40github.com.
[jenkinsci/stash-pullrequest-builder-plugin] d3f0ca: pom.xml: Fix Jenkins not detecting bad pom.xml for...
Branch: refs/heads/master Home: https://github.com/jenkinsci/stash-pullrequest-builder-plugin Commit: d3f0ca31fbfea2108ef2ceed0b2984253dd24622 https://github.com/jenkinsci/stash-pullrequest-builder-plugin/commit/d3f0ca31fbfea2108ef2ceed0b2984253dd24622 Author: Pavel Roskin Date: 2019-08-05 (Mon, 05 Aug 2019) Changed paths: M pom.xml Log Message: --- pom.xml: Fix Jenkins not detecting bad pom.xml formatting The sortpom:verify goal is set to sort pom.xml if it finds any issues. That goal would not fail in case of bad pom.xml formatting, and Jenkins would not know that pom.xml needs sorting. But even when "verifyFail" is set to "Stop", sortpom:verify doesn't fail on minor formatting issues that sortpom:sort would fix. It would be better to make Jenkins detect all formatting issues in pom.xml. Instead of running sortpom:verify, run sortpom:sort unconditionally, i.e. on Jenkins and on other systems. There is no good reason to skip any goals on Jenkins if they are run elsewhere. The only additional behavior for Jenkins is checking for changes in the working directory. Jenkins would fail the build if the code is different from the checked out commit. Check for modifications at the "verify" phase, so that all other issues (e.g. findbugs and unit tests failures) would be detected first. To keep the build logic consistent, use the same approach for Java code formatting. Format Java code unconditionally. Jenkins would fail the test if any changes are detected. -- You received this message because you are subscribed to the Google Groups "Jenkins Commits" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-commits+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-commits/jenkinsci/stash-pullrequest-builder-plugin/push/refs/heads/master/b39081-d3f0ca%40github.com.
[jenkinsci/stash-pullrequest-builder-plugin] b39081: Merge StashPullRequestsBuilder into StashRepository
Branch: refs/heads/master Home: https://github.com/jenkinsci/stash-pullrequest-builder-plugin Commit: b3908145616185e9d7dd8504985794821e8e7ba8 https://github.com/jenkinsci/stash-pullrequest-builder-plugin/commit/b3908145616185e9d7dd8504985794821e8e7ba8 Author: Pavel Roskin Date: 2019-08-05 (Mon, 05 Aug 2019) Changed paths: M src/main/java/stashpullrequestbuilder/stashpullrequestbuilder/StashBuildListener.java M src/main/java/stashpullrequestbuilder/stashpullrequestbuilder/StashBuildTrigger.java R src/main/java/stashpullrequestbuilder/stashpullrequestbuilder/StashPullRequestsBuilder.java M src/main/java/stashpullrequestbuilder/stashpullrequestbuilder/StashRepository.java M src/test/java/stashpullrequestbuilder/stashpullrequestbuilder/StashBuildListenerTest.java M src/test/java/stashpullrequestbuilder/stashpullrequestbuilder/StashRepositoryTest.java Log Message: --- Merge StashPullRequestsBuilder into StashRepository StashPullRequestsBuilder was a thin layer between StashBuildTrigger and StashRepository without a well defined responsibility. Make StashBuildTrigger create StashRepository object directly. Move run() to StashRepository as pollRepository(). -- You received this message because you are subscribed to the Google Groups "Jenkins Commits" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-commits+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-commits/jenkinsci/stash-pullrequest-builder-plugin/push/refs/heads/master/fb217e-b39081%40github.com.
[jenkinsci/stash-pullrequest-builder-plugin] fb217e: Update to Jackson2 API, use Jenkins Jackson2 API p...
Branch: refs/heads/master Home: https://github.com/jenkinsci/stash-pullrequest-builder-plugin Commit: fb217edab9b51e2096351fab6eaf3f5899094ceb https://github.com/jenkinsci/stash-pullrequest-builder-plugin/commit/fb217edab9b51e2096351fab6eaf3f5899094ceb Author: Pavel Roskin Date: 2019-08-05 (Mon, 05 Aug 2019) Changed paths: M pom.xml M src/main/java/stashpullrequestbuilder/stashpullrequestbuilder/stash/StashApiClient.java M src/main/java/stashpullrequestbuilder/stashpullrequestbuilder/stash/StashPullRequestActivity.java M src/main/java/stashpullrequestbuilder/stashpullrequestbuilder/stash/StashPullRequestActivityResponse.java M src/main/java/stashpullrequestbuilder/stashpullrequestbuilder/stash/StashPullRequestComment.java M src/main/java/stashpullrequestbuilder/stashpullrequestbuilder/stash/StashPullRequestMergeableResponse.java M src/main/java/stashpullrequestbuilder/stashpullrequestbuilder/stash/StashPullRequestMergeableVetoMessage.java M src/main/java/stashpullrequestbuilder/stashpullrequestbuilder/stash/StashPullRequestResponse.java M src/main/java/stashpullrequestbuilder/stashpullrequestbuilder/stash/StashPullRequestResponseValue.java M src/main/java/stashpullrequestbuilder/stashpullrequestbuilder/stash/StashPullRequestResponseValueRepository.java M src/main/java/stashpullrequestbuilder/stashpullrequestbuilder/stash/StashPullRequestResponseValueRepositoryBranch.java M src/main/java/stashpullrequestbuilder/stashpullrequestbuilder/stash/StashPullRequestResponseValueRepositoryCommit.java M src/main/java/stashpullrequestbuilder/stashpullrequestbuilder/stash/StashPullRequestResponseValueRepositoryProject.java M src/main/java/stashpullrequestbuilder/stashpullrequestbuilder/stash/StashPullRequestResponseValueRepositoryRepository.java M src/test/java/stashpullrequestbuilder/stashpullrequestbuilder/stash/StashApiClientTest.java Log Message: --- Update to Jackson2 API, use Jenkins Jackson2 API plugin -- You received this message because you are subscribed to the Google Groups "Jenkins Commits" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-commits+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-commits/jenkinsci/stash-pullrequest-builder-plugin/push/refs/heads/master/727154-fb217e%40github.com.
[jenkinsci/stash-pullrequest-builder-plugin] 262076: pom.xml: Require Jenkins 2.60.3 instead of 2.60.1
Branch: refs/heads/master Home: https://github.com/jenkinsci/stash-pullrequest-builder-plugin Commit: 2620765f074f72f42864c20f3b9ad6fdec28becd https://github.com/jenkinsci/stash-pullrequest-builder-plugin/commit/2620765f074f72f42864c20f3b9ad6fdec28becd Author: Pavel Roskin Date: 2019-08-05 (Mon, 05 Aug 2019) Changed paths: M README.md M pom.xml Log Message: --- pom.xml: Require Jenkins 2.60.3 instead of 2.60.1 All recent versions of HttpClient API and Jackson2 API plugins require 2.60.3. It's not a significant requirement change. Commit: 7271542954c99b9900ac33874ea44cd869b9a051 https://github.com/jenkinsci/stash-pullrequest-builder-plugin/commit/7271542954c99b9900ac33874ea44cd869b9a051 Author: Pavel Roskin Date: 2019-08-05 (Mon, 05 Aug 2019) Changed paths: M pom.xml Log Message: --- pom.xml: Use Apache HttpComponents Client 4.x API Plugin This removes httpclient-4.5.2.jar and httpcore-4.4.4.jar from the plugin package, cutting its size by almost a megabyte. Users can update the Apache HttpComponents plugin on their own without waiting for other plugins to update their dependencies. Apache HttpComponents plugin is likely to be installed already because it's used by the git plugin. Compare: https://github.com/jenkinsci/stash-pullrequest-builder-plugin/compare/6ce9fc3aa373...7271542954c9 -- You received this message because you are subscribed to the Google Groups "Jenkins Commits" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-commits+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-commits/jenkinsci/stash-pullrequest-builder-plugin/push/refs/heads/master/6ce9fc-727154%40github.com.
[jenkinsci/stash-pullrequest-builder-plugin] 124992: StashPullRequestComment: Rewrite Comparable interf...
Branch: refs/heads/master Home: https://github.com/jenkinsci/stash-pullrequest-builder-plugin Commit: 124992f4aeecb9f72f4b8ab6a4f88804a4b557ca https://github.com/jenkinsci/stash-pullrequest-builder-plugin/commit/124992f4aeecb9f72f4b8ab6a4f88804a4b557ca Author: Pavel Roskin Date: 2019-07-22 (Mon, 22 Jul 2019) Changed paths: M src/main/java/stashpullrequestbuilder/stashpullrequestbuilder/stash/StashPullRequestComment.java A src/test/java/stashpullrequestbuilder/stashpullrequestbuilder/stash/StashPullRequestCommentTest.java Log Message: --- StashPullRequestComment: Rewrite Comparable interface implementation Define hashCode() and equals() to ensure consistent behavior and fix FindBugs warnings. Remove FindBugs suppressions. Treat null as Integer.MIN_VALUE in hashCode(), as that comment ID is not expected to be found in actual server responses. Make equals() and compareTo() compare ID only. Comparing text is not needed because comparison is only used for comments in the same pull request. Each comment in the pull request should have an ID unique within that pull request. Add extensive unit tests. -- You received this message because you are subscribed to the Google Groups "Jenkins Commits" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-commits+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-commits/jenkinsci/stash-pullrequest-builder-plugin/push/refs/heads/master/f5c1fd-124992%40github.com.
[jenkinsci/stash-pullrequest-builder-plugin] f5c1fd: Enable optional support for Jenkins pipelines
Branch: refs/heads/master Home: https://github.com/jenkinsci/stash-pullrequest-builder-plugin Commit: f5c1fda807e40f1fce0e99441de4391384589101 https://github.com/jenkinsci/stash-pullrequest-builder-plugin/commit/f5c1fda807e40f1fce0e99441de4391384589101 Author: Pavel Roskin Date: 2019-07-22 (Mon, 22 Jul 2019) Changed paths: M README.md M pom.xml M src/main/java/stashpullrequestbuilder/stashpullrequestbuilder/StashBuildTrigger.java A src/main/resources/stashpullrequestbuilder/stashpullrequestbuilder/StashBuildTrigger/global.jelly A src/main/resources/stashpullrequestbuilder/stashpullrequestbuilder/StashBuildTrigger/help-enablePipelineSupport.html M src/test/java/stashpullrequestbuilder/stashpullrequestbuilder/StashBuildTriggerTest.java Log Message: --- Enable optional support for Jenkins pipelines Add a global option to enable pipeline support. If it's enabled, don't require the job to inherit from AbstractProject. Allow any Job subclass that implements ParameterizedJob, which is true both for freestyle projects and for pipelines. Make it clear in the option help text and in README.md that pipeline support is currently experimental. Add workflow-job as a test dependency. Add unit tests to make sure that WorkflowJob is supported only when pipeline support is enabled. -- You received this message because you are subscribed to the Google Groups "Jenkins Commits" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-commits+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-commits/jenkinsci/stash-pullrequest-builder-plugin/push/refs/heads/master/6f02fb-f5c1fd%40github.com.
[jenkinsci/stash-pullrequest-builder-plugin] 6f02fb: pom.xml: Depend on hamcrest, not on hamcrest-library
Branch: refs/heads/master Home: https://github.com/jenkinsci/stash-pullrequest-builder-plugin Commit: 6f02fba27861cfaf9a932b3686186ab72064d844 https://github.com/jenkinsci/stash-pullrequest-builder-plugin/commit/6f02fba27861cfaf9a932b3686186ab72064d844 Author: Pavel Roskin Date: 2019-07-21 (Sun, 21 Jul 2019) Changed paths: M pom.xml Log Message: --- pom.xml: Depend on hamcrest, not on hamcrest-library hamcrest-library is a deprecated dependency, as indicated by hamcrest-library-2.1.pom. -- You received this message because you are subscribed to the Google Groups "Jenkins Commits" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-commits+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-commits/jenkinsci/stash-pullrequest-builder-plugin/push/refs/heads/master/5aae7f-6f02fb%40github.com.
[jenkinsci/stash-pullrequest-builder-plugin] c789dc: StashBuildTrigger: Use @DataBoundSetter for advanc...
Branch: refs/heads/master Home: https://github.com/jenkinsci/stash-pullrequest-builder-plugin Commit: c789dc7a31993431d3ec19ffb44d3aa8e7d3ff69 https://github.com/jenkinsci/stash-pullrequest-builder-plugin/commit/c789dc7a31993431d3ec19ffb44d3aa8e7d3ff69 Author: Pavel Roskin Date: 2019-07-21 (Sun, 21 Jul 2019) Changed paths: M src/main/java/stashpullrequestbuilder/stashpullrequestbuilder/StashBuildTrigger.java Log Message: --- StashBuildTrigger: Use @DataBoundSetter for advanced settings Change the constructor to accept essential settings only. Reorder private fields, setters and getters the way they are ordered in config.jelly. Commit: 5aae7f6ab8d05e170c981259011c3cefb0b9a6b1 https://github.com/jenkinsci/stash-pullrequest-builder-plugin/commit/5aae7f6ab8d05e170c981259011c3cefb0b9a6b1 Author: Pavel Roskin Date: 2019-07-21 (Sun, 21 Jul 2019) Changed paths: M src/main/java/stashpullrequestbuilder/stashpullrequestbuilder/StashBuildTrigger.java M src/main/resources/stashpullrequestbuilder/stashpullrequestbuilder/StashBuildTrigger/config.jelly Log Message: --- StashBuildTrigger: Make field defaults match config.jelly That makes the Pipeline Snippet Generator skip arguments from the trigger call if those arguments have default values. Keep default values for the skip phrase and the build phrase in the descriptor, so they can be used both in config.jelly and in the code. Compare: https://github.com/jenkinsci/stash-pullrequest-builder-plugin/compare/6bf204fc278f...5aae7f6ab8d0 -- You received this message because you are subscribed to the Google Groups "Jenkins Commits" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-commits+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-commits/jenkinsci/stash-pullrequest-builder-plugin/push/refs/heads/master/6bf204-5aae7f%40github.com.
[jenkinsci/stash-pullrequest-builder-plugin] 6bf204: StashBuildTrigger: Rename StashBuildTriggerDescrip...
Branch: refs/heads/master Home: https://github.com/jenkinsci/stash-pullrequest-builder-plugin Commit: 6bf204fc278f7760e89e937077516078b0aaca9d https://github.com/jenkinsci/stash-pullrequest-builder-plugin/commit/6bf204fc278f7760e89e937077516078b0aaca9d Author: Pavel Roskin Date: 2019-07-12 (Fri, 12 Jul 2019) Changed paths: M src/main/java/stashpullrequestbuilder/stashpullrequestbuilder/StashBuildTrigger.java M src/test/java/stashpullrequestbuilder/stashpullrequestbuilder/StashBuildTriggerTest.java Log Message: --- StashBuildTrigger: Rename StashBuildTriggerDescriptor to DescriptorImpl DescriptorImpl is the standard name for a descriptor defined as an inner class. StashBuildTriggerDescriptor is a long name that duplicates the name of its containing class, StashBuildTrigger. -- You received this message because you are subscribed to the Google Groups "Jenkins Commits" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-commits+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-commits/jenkinsci/stash-pullrequest-builder-plugin/push/refs/heads/master/c218ee-6bf204%40github.com. For more options, visit https://groups.google.com/d/optout.
[jenkinsci/stash-pullrequest-builder-plugin] bfc9bb: StashApiClientTest: Add WireMock based tests for S...
Branch: refs/heads/master Home: https://github.com/jenkinsci/stash-pullrequest-builder-plugin Commit: bfc9bb4d66b95dd198446264b8fddb557e259ace https://github.com/jenkinsci/stash-pullrequest-builder-plugin/commit/bfc9bb4d66b95dd198446264b8fddb557e259ace Author: Pavel Roskin Date: 2019-07-11 (Thu, 11 Jul 2019) Changed paths: M src/test/java/stashpullrequestbuilder/stashpullrequestbuilder/stash/StashApiClientTest.java A src/test/resources/__files/PostPullRequestComment.json A src/test/resources/__files/PullRequestCommentsEmpty.json A src/test/resources/__files/PullRequestCommentsPage1.json A src/test/resources/__files/PullRequestCommentsPage2.json A src/test/resources/__files/PullRequestCommentsPage3.json A src/test/resources/__files/PullRequestListEmpty.json A src/test/resources/__files/PullRequestListPage1.json A src/test/resources/__files/PullRequestListPage2.json A src/test/resources/__files/PullRequestListPage3.json A src/test/resources/__files/PullRequestMergeStatus.json Log Message: --- StashApiClientTest: Add WireMock based tests for StashApiClient Document discovered issues. Commit: c218eeff82c1339e6224c832087211ff5eaff89b https://github.com/jenkinsci/stash-pullrequest-builder-plugin/commit/c218eeff82c1339e6224c832087211ff5eaff89b Author: Pavel Roskin Date: 2019-07-11 (Thu, 11 Jul 2019) Changed paths: M src/main/java/stashpullrequestbuilder/stashpullrequestbuilder/StashBuildListener.java M src/main/java/stashpullrequestbuilder/stashpullrequestbuilder/StashRepository.java M src/main/java/stashpullrequestbuilder/stashpullrequestbuilder/stash/StashApiClient.java M src/test/java/stashpullrequestbuilder/stashpullrequestbuilder/StashBuildListenerTest.java M src/test/java/stashpullrequestbuilder/stashpullrequestbuilder/StashRepositoryTest.java M src/test/java/stashpullrequestbuilder/stashpullrequestbuilder/stash/StashApiClientTest.java Log Message: --- Clean up exception handling in StashApiClient Stop using RuntimeException, it's an unchecked exception. The callers may be unaware that they need to handle it. Stop using Exception. Always use most specific exception types. Always rethrow caught exceptions by wrapping them in StashApiClient. Let the callers handle them, as they are in a better position to chose what to do and emit meaningful logs. Don't print stack trace in StashApiClient. Print it when the exception is handled. Some callers log the stack trace to the build log, not to the global Jenkins log. Don't log error messages and throw StashApiException at the same time, unless the log message contains information that is not added to the exception. Adjust "throws" declarations. Catch errors where appropriate and log them. Document functions that throw StashApiException. Add comments explaining how StashApiException is handled. Adjust unit tests for the new behavior. Compare: https://github.com/jenkinsci/stash-pullrequest-builder-plugin/compare/d28f5adb62de...c218eeff82c1 -- You received this message because you are subscribed to the Google Groups "Jenkins Commits" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-commits+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-commits/jenkinsci/stash-pullrequest-builder-plugin/push/refs/heads/master/d28f5a-c218ee%40github.com. For more options, visit https://groups.google.com/d/optout.
[jenkinsci/stash-pullrequest-builder-plugin] d28f5a: StashRepositoryTest: No need to stub getCiSkipPhra...
Branch: refs/heads/master Home: https://github.com/jenkinsci/stash-pullrequest-builder-plugin Commit: d28f5adb62def244be11e6af10e68323a391f3e8 https://github.com/jenkinsci/stash-pullrequest-builder-plugin/commit/d28f5adb62def244be11e6af10e68323a391f3e8 Author: Pavel Roskin Date: 2019-07-11 (Thu, 11 Jul 2019) Changed paths: M src/test/java/stashpullrequestbuilder/stashpullrequestbuilder/StashRepositoryTest.java Log Message: --- StashRepositoryTest: No need to stub getCiSkipPhrases() everywhere Mockito returns null for unstubbed methods on mocked classes. It's OK for getCiSkipPhrases() to return null, as it's only used in isSkipBuild() that can deal with null. Stub getCiSkipPhrases() only when it's relevant to the test. -- You received this message because you are subscribed to the Google Groups "Jenkins Commits" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-commits+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-commits/jenkinsci/stash-pullrequest-builder-plugin/push/refs/heads/master/d56749-d28f5a%40github.com. For more options, visit https://groups.google.com/d/optout.
[jenkinsci/stash-pullrequest-builder-plugin] d56749: StashBuildTrigger: Remove all references to projec...
Branch: refs/heads/master Home: https://github.com/jenkinsci/stash-pullrequest-builder-plugin Commit: d56749e3d7813df3eb50e9c261a1fe21803ecae7 https://github.com/jenkinsci/stash-pullrequest-builder-plugin/commit/d56749e3d7813df3eb50e9c261a1fe21803ecae7 Author: Pavel Roskin Date: 2019-07-10 (Wed, 10 Jul 2019) Changed paths: M src/main/java/stashpullrequestbuilder/stashpullrequestbuilder/StashBuildTrigger.java Log Message: --- StashBuildTrigger: Remove all references to projectPath, it's not used -- You received this message because you are subscribed to the Google Groups "Jenkins Commits" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-commits+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-commits/jenkinsci/stash-pullrequest-builder-plugin/push/refs/heads/master/c82ffb-d56749%40github.com. For more options, visit https://groups.google.com/d/optout.
[jenkinsci/stash-pullrequest-builder-plugin] c82ffb: StashBuildListener: Log error updating build descr...
Branch: refs/heads/master Home: https://github.com/jenkinsci/stash-pullrequest-builder-plugin Commit: c82ffb60e00c5124d66c5d9460e4d0960e490603 https://github.com/jenkinsci/stash-pullrequest-builder-plugin/commit/c82ffb60e00c5124d66c5d9460e4d0960e490603 Author: Pavel Roskin Date: 2019-07-07 (Sun, 07 Jul 2019) Changed paths: M src/main/java/stashpullrequestbuilder/stashpullrequestbuilder/StashBuildListener.java M src/test/java/stashpullrequestbuilder/stashpullrequestbuilder/StashBuildListenerTest.java Log Message: --- StashBuildListener: Log error updating build description to the build output Updating build description is done for convenience. It doesn't affect other functionality if it fails. No need to log that condition to the main Jenkins log, especially at the SEVERE level. Change unit tests to allow intercepting and testing build logs. Minor fix for an existing test name. -- You received this message because you are subscribed to the Google Groups "Jenkins Commits" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-commits+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-commits/jenkinsci/stash-pullrequest-builder-plugin/push/refs/heads/master/a6dc8b-c82ffb%40github.com. For more options, visit https://groups.google.com/d/optout.
[jenkinsci/stash-pullrequest-builder-plugin] a6dc8b: StashBuildTrigger: Use correct getter names for co...
Branch: refs/heads/master Home: https://github.com/jenkinsci/stash-pullrequest-builder-plugin Commit: a6dc8bb48172ed3da4e8058a7c5d7c162b11c889 https://github.com/jenkinsci/stash-pullrequest-builder-plugin/commit/a6dc8bb48172ed3da4e8058a7c5d7c162b11c889 Author: Pavel Roskin Date: 2019-07-07 (Sun, 07 Jul 2019) Changed paths: M src/main/java/stashpullrequestbuilder/stashpullrequestbuilder/StashBuildTrigger.java M src/main/java/stashpullrequestbuilder/stashpullrequestbuilder/StashRepository.java A src/test/java/stashpullrequestbuilder/stashpullrequestbuilder/StashBuildTriggerTest.java M src/test/java/stashpullrequestbuilder/stashpullrequestbuilder/StashRepositoryTest.java Log Message: --- StashBuildTrigger: Use correct getter names for config.jelly fields Getter names for fields referenced in config.jelly should start with "get" followed by the capitalized property name. "is" is not supported. -- You received this message because you are subscribed to the Google Groups "Jenkins Commits" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-commits+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-commits/jenkinsci/stash-pullrequest-builder-plugin/push/refs/heads/master/b4a94a-a6dc8b%40github.com. For more options, visit https://groups.google.com/d/optout.
[jenkinsci/stash-pullrequest-builder-plugin] b4a94a: StashPullRequestsBuilder: Fix compile error, "proj...
Branch: refs/heads/master Home: https://github.com/jenkinsci/stash-pullrequest-builder-plugin Commit: b4a94aa0f23b86ceb6ff344946e172006268e7c7 https://github.com/jenkinsci/stash-pullrequest-builder-plugin/commit/b4a94aa0f23b86ceb6ff344946e172006268e7c7 Author: Pavel Roskin Date: 2019-07-06 (Sat, 06 Jul 2019) Changed paths: M src/main/java/stashpullrequestbuilder/stashpullrequestbuilder/StashPullRequestsBuilder.java Log Message: --- StashPullRequestsBuilder: Fix compile error, "project" should be "job" now -- You received this message because you are subscribed to the Google Groups "Jenkins Commits" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-commits+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-commits/jenkinsci/stash-pullrequest-builder-plugin/push/refs/heads/master/74fd53-b4a94a%40github.com. For more options, visit https://groups.google.com/d/optout.
[jenkinsci/stash-pullrequest-builder-plugin] 74fd53: StashBuildListenerTest: Add test for onCompleted()...
Branch: refs/heads/master Home: https://github.com/jenkinsci/stash-pullrequest-builder-plugin Commit: 74fd53a58754831d953cb10424e374248c89cec6 https://github.com/jenkinsci/stash-pullrequest-builder-plugin/commit/74fd53a58754831d953cb10424e374248c89cec6 Author: Pavel Roskin Date: 2019-07-06 (Sat, 06 Jul 2019) Changed paths: M src/test/java/stashpullrequestbuilder/stashpullrequestbuilder/StashBuildListenerTest.java Log Message: --- StashBuildListenerTest: Add test for onCompleted() with matching cause -- You received this message because you are subscribed to the Google Groups "Jenkins Commits" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-commits+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-commits/jenkinsci/stash-pullrequest-builder-plugin/push/refs/heads/master/f04a51-74fd53%40github.com. For more options, visit https://groups.google.com/d/optout.
[jenkinsci/stash-pullrequest-builder-plugin] f04a51: Replace AbstractProject and AbstractBuild with Job...
Branch: refs/heads/master Home: https://github.com/jenkinsci/stash-pullrequest-builder-plugin Commit: f04a51cd7bdf888a8d5493f8feaaee21d53442de https://github.com/jenkinsci/stash-pullrequest-builder-plugin/commit/f04a51cd7bdf888a8d5493f8feaaee21d53442de Author: Pavel Roskin Date: 2019-07-06 (Sat, 06 Jul 2019) Changed paths: M src/main/java/stashpullrequestbuilder/stashpullrequestbuilder/StashBuildListener.java M src/main/java/stashpullrequestbuilder/stashpullrequestbuilder/StashBuildTrigger.java M src/main/java/stashpullrequestbuilder/stashpullrequestbuilder/StashPullRequestsBuilder.java Log Message: --- Replace AbstractProject and AbstractBuild with Job and Run (#107) This makes it possible to support pipelines. Pipelines don't use AbstractProject and AbstractBuild. Instead, they use WorkflowJob and WorkflowRun. The common ancestors are Job and Run. In some cases, Job doesn't provide the needed API. However, both AbstractProject and WorkflowJob implement ParameterizedJob interface, which provides the required functionality. -- You received this message because you are subscribed to the Google Groups "Jenkins Commits" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-commits+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-commits/jenkinsci/stash-pullrequest-builder-plugin/push/refs/heads/master/d93b35-f04a51%40github.com. For more options, visit https://groups.google.com/d/optout.
[jenkinsci/stash-pullrequest-builder-plugin] d93b35: StashRepository: Merge init() into the constructor
Branch: refs/heads/master Home: https://github.com/jenkinsci/stash-pullrequest-builder-plugin Commit: d93b35adecd1442303e2d5e53eadc8d57cf28458 https://github.com/jenkinsci/stash-pullrequest-builder-plugin/commit/d93b35adecd1442303e2d5e53eadc8d57cf28458 Author: Pavel Roskin Date: 2019-07-06 (Sat, 06 Jul 2019) Changed paths: M pom.xml M src/main/java/stashpullrequestbuilder/stashpullrequestbuilder/StashPullRequestsBuilder.java M src/main/java/stashpullrequestbuilder/stashpullrequestbuilder/StashRepository.java M src/test/java/stashpullrequestbuilder/stashpullrequestbuilder/StashRepositoryTest.java Log Message: --- StashRepository: Merge init() into the constructor Jenkins documentation doesn't guarantee that start() would not be called after run() for a trigger. While it doesn't happen in freestyle projects, Jenkins would actually call start() after run() on the trigger in a pipeline project. That would create a new StashRepository object that would not have the StashApiClient object initialized. When the build completes, it would try to post the build result as a PR comment. That would throw an exception. To prevent it, remove the init() method. Move StashApiClient initialization inside the StashRepository constructor, so that the StashRepository object always has a valid StashApiClient object. Add WireMock as a test dependency. Check that the newly constructed StashRepository object would actually send an HTTP request. -- You received this message because you are subscribed to the Google Groups "Jenkins Commits" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-commits+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-commits/jenkinsci/stash-pullrequest-builder-plugin/push/refs/heads/master/4d6853-d93b35%40github.com. For more options, visit https://groups.google.com/d/optout.
[jenkinsci/stash-pullrequest-builder-plugin] 4d6853: StashRepository: Log stack trace when catching Sta...
Branch: refs/heads/master Home: https://github.com/jenkinsci/stash-pullrequest-builder-plugin Commit: 4d68531b5de6da3f7c9c77edf62b03e3357f6ac1 https://github.com/jenkinsci/stash-pullrequest-builder-plugin/commit/4d68531b5de6da3f7c9c77edf62b03e3357f6ac1 Author: Pavel Roskin Date: 2019-07-04 (Thu, 04 Jul 2019) Changed paths: M src/main/java/stashpullrequestbuilder/stashpullrequestbuilder/StashRepository.java Log Message: --- StashRepository: Log stack trace when catching StashApiException -- You received this message because you are subscribed to the Google Groups "Jenkins Commits" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-commits+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-commits/jenkinsci/stash-pullrequest-builder-plugin/push/refs/heads/master/5719ae-4d6853%40github.com. For more options, visit https://groups.google.com/d/optout.
[jenkinsci/stash-pullrequest-builder-plugin] 5719ae: Make project and repository name available everywh...
Branch: refs/heads/master
Home: https://github.com/jenkinsci/stash-pullrequest-builder-plugin
Commit: 5719ae1e4f3d69359f5d873fa1b15b1af04990d9
https://github.com/jenkinsci/stash-pullrequest-builder-plugin/commit/5719ae1e4f3d69359f5d873fa1b15b1af04990d9
Author: Pavel Roskin
Date: 2019-06-27 (Thu, 27 Jun 2019)
Changed paths:
M README.md
M
src/main/java/stashpullrequestbuilder/stashpullrequestbuilder/StashBuildEnvironmentContributor.java
M
src/test/java/stashpullrequestbuilder/stashpullrequestbuilder/StashBuildEnvironmentContributorTest.java
Log Message:
---
Make project and repository name available everywhere in project configuration
Make StashBuildEnvironmentContributor provide destinationRepositoryOwner
and destinationRepositoryName variables through the buildEnvironmentFor()
function with a Job argument.
${destinationRepositoryOwner} and ${destinationRepositoryName} can now be
used in configuration fields that are not tied to a specific build.
In particular, they can be used in the repository browser URL, e.g.
http://stash/projects/${destinationRepositoryOwner}/repos/${destinationRepositoryName}/
Builds triggered by Stash Pull Request Builder will have those variables
replaced with the actual values from the pull request.
--
You received this message because you are subscribed to the Google Groups
"Jenkins Commits" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to jenkinsci-commits+unsubscr...@googlegroups.com.
To view this discussion on the web visit
https://groups.google.com/d/msgid/jenkinsci-commits/jenkinsci/stash-pullrequest-builder-plugin/push/refs/heads/master/5bccde-5719ae%40github.com.
For more options, visit https://groups.google.com/d/optout.
[jenkinsci/stash-pullrequest-builder-plugin] 7b2713: Expand wildcard imports
Branch: refs/heads/master Home: https://github.com/jenkinsci/stash-pullrequest-builder-plugin Commit: 7b27130d900a6b047eebab802d92e14833a6ae21 https://github.com/jenkinsci/stash-pullrequest-builder-plugin/commit/7b27130d900a6b047eebab802d92e14833a6ae21 Author: Pavel Roskin Date: 2019-06-27 (Thu, 27 Jun 2019) Changed paths: M src/test/java/stashpullrequestbuilder/stashpullrequestbuilder/StashBuildEnvironmentContributorTest.java M src/test/java/stashpullrequestbuilder/stashpullrequestbuilder/stash/AdditionalParameterRegExTest.java M src/test/java/stashpullrequestbuilder/stashpullrequestbuilder/stash/StashApiClientTest.java M src/test/java/stashpullrequestbuilder/stashpullrequestbuilder/stash/StashPullRequestResponseValueRepositoryTest.java Log Message: --- Expand wildcard imports Commit: 87adeba77d089f5044ad8959b3fea0a9d9289c71 https://github.com/jenkinsci/stash-pullrequest-builder-plugin/commit/87adeba77d089f5044ad8959b3fea0a9d9289c71 Author: Pavel Roskin Date: 2019-06-27 (Thu, 27 Jun 2019) Changed paths: M src/test/java/stashpullrequestbuilder/stashpullrequestbuilder/StashRepositoryTest.java Log Message: --- Move public members above private members Commit: fad87163617658cd185b3a4273f32f6e6f82832e https://github.com/jenkinsci/stash-pullrequest-builder-plugin/commit/fad87163617658cd185b3a4273f32f6e6f82832e Author: Pavel Roskin Date: 2019-06-27 (Thu, 27 Jun 2019) Changed paths: M src/test/java/stashpullrequestbuilder/stashpullrequestbuilder/StashRepositoryTest.java Log Message: --- Use contains() matcher to check lists Commit: 2528fb09b33a0f262f46068ffe275286b111a91b https://github.com/jenkinsci/stash-pullrequest-builder-plugin/commit/2528fb09b33a0f262f46068ffe275286b111a91b Author: Pavel Roskin Date: 2019-06-27 (Thu, 27 Jun 2019) Changed paths: M src/test/java/stashpullrequestbuilder/stashpullrequestbuilder/stash/AdditionalParameterRegExTest.java Log Message: --- Use allOf() matcher to check maps Commit: 5bccdeede80393641df4ee4542e09f39bafbf6a5 https://github.com/jenkinsci/stash-pullrequest-builder-plugin/commit/5bccdeede80393641df4ee4542e09f39bafbf6a5 Author: Pavel Roskin Date: 2019-06-27 (Thu, 27 Jun 2019) Changed paths: M src/test/java/stashpullrequestbuilder/stashpullrequestbuilder/StashBuildEnvironmentContributorTest.java M src/test/java/stashpullrequestbuilder/stashpullrequestbuilder/StashRepositoryTest.java Log Message: --- Use snake_case for unit test names Compare: https://github.com/jenkinsci/stash-pullrequest-builder-plugin/compare/f4c4a3c31102...5bccdeede803 -- You received this message because you are subscribed to the Google Groups "Jenkins Commits" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-commits+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-commits/jenkinsci/stash-pullrequest-builder-plugin/push/refs/heads/master/f4c4a3-5bccde%40github.com. For more options, visit https://groups.google.com/d/optout.
[jenkinsci/stash-pullrequest-builder-plugin] f4c4a3: Fill parameter values from environment variables a...
Branch: refs/heads/master Home: https://github.com/jenkinsci/stash-pullrequest-builder-plugin Commit: f4c4a3c311028b27572f43932d88440d976e34a8 https://github.com/jenkinsci/stash-pullrequest-builder-plugin/commit/f4c4a3c311028b27572f43932d88440d976e34a8 Author: Pavel Roskin Date: 2019-06-26 (Wed, 26 Jun 2019) Changed paths: M README.md M src/main/java/stashpullrequestbuilder/stashpullrequestbuilder/StashBuildEnvironmentContributor.java M src/main/java/stashpullrequestbuilder/stashpullrequestbuilder/StashCause.java M src/main/java/stashpullrequestbuilder/stashpullrequestbuilder/StashRepository.java M src/test/java/stashpullrequestbuilder/stashpullrequestbuilder/StashRepositoryTest.java Log Message: --- Fill parameter values from environment variables added by the plugin Parameters generate environment variables that take precedence over the environment variables supplied by the EnvironmentContributor extension. Some users relied on the plugin filling values for the parameters defined for the project. That functionality was broken in version 1.9. Make StashRepository#getParameters() fill parameters with the values that the plugin supplies to the environment. To avoid code duplication, move the environment variables to StashCause as a transient map (the data is already saved to XML files from the fields). Use that map both from StashBuildEnvironmentContributor and StashRepository. Make the environment variables override the parameters from the pull request comments. Users with comment posting permissions should not be able to override parameters that the administrator intended to be filled from the environment. -- You received this message because you are subscribed to the Google Groups "Jenkins Commits" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-commits+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-commits/jenkinsci/stash-pullrequest-builder-plugin/push/refs/heads/master/302f76-f4c4a3%40github.com. For more options, visit https://groups.google.com/d/optout.
[jenkinsci/stash-pullrequest-builder-plugin] 826ce8: Fix handling of failures to fetch the PR list and ...
Branch: refs/heads/master Home: https://github.com/jenkinsci/stash-pullrequest-builder-plugin Commit: 826ce8c24eb8bba91ee7b5add9c82afd94ae70ef https://github.com/jenkinsci/stash-pullrequest-builder-plugin/commit/826ce8c24eb8bba91ee7b5add9c82afd94ae70ef Author: Pavel Roskin Date: 2019-06-25 (Tue, 25 Jun 2019) Changed paths: M src/main/java/stashpullrequestbuilder/stashpullrequestbuilder/StashRepository.java M src/main/java/stashpullrequestbuilder/stashpullrequestbuilder/stash/StashApiClient.java M src/test/java/stashpullrequestbuilder/stashpullrequestbuilder/StashRepositoryTest.java Log Message: --- Fix handling of failures to fetch the PR list and the PR comments Add a new exception StashApiException, throw it in both cases. Don't trigger a build on a failure to fetch PR comments. That issue has been observed creating a large number of builds if the connection between Jenkins and Stash is unstable. Commit: 4f9b7d0c223072fbd715a22d062de8d71aca49bd https://github.com/jenkinsci/stash-pullrequest-builder-plugin/commit/4f9b7d0c223072fbd715a22d062de8d71aca49bd Author: Pavel Roskin Date: 2019-06-25 (Tue, 25 Jun 2019) Changed paths: M src/main/java/stashpullrequestbuilder/stashpullrequestbuilder/StashRepository.java M src/main/java/stashpullrequestbuilder/stashpullrequestbuilder/stash/StashApiClient.java Log Message: --- Add @Nonnull annotations, remove unnecessary null checks In StashApiClient.java, getPullRequests() and getPullRequestComments() don't return null anymore, they throw StashApiException on error. extractComments() is used getPullRequestComments() and doesn't return null either, so annotate it as well. In StashRepository.java, remove null checks for the results of the @Nonnull methods. Compare: https://github.com/jenkinsci/stash-pullrequest-builder-plugin/compare/2ab923ad3d3f...4f9b7d0c2230 -- You received this message because you are subscribed to the Google Groups "Jenkins Commits" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-commits+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-commits/jenkinsci/stash-pullrequest-builder-plugin/push/refs/heads/master/2ab923-4f9b7d%40github.com. For more options, visit https://groups.google.com/d/optout.
[jenkinsci/stash-pullrequest-builder-plugin] 828f48: findbugs-exclude.xml: Remove suppressions for Stas...
Branch: refs/heads/master Home: https://github.com/jenkinsci/stash-pullrequest-builder-plugin Commit: 828f48cf3f71dcd958329f06446863ee4f8a52d3 https://github.com/jenkinsci/stash-pullrequest-builder-plugin/commit/828f48cf3f71dcd958329f06446863ee4f8a52d3 Author: Pavel Roskin Date: 2019-06-25 (Tue, 25 Jun 2019) Changed paths: M src/findbugs-exclude.xml Log Message: --- findbugs-exclude.xml: Remove suppressions for StashBuildTrigger The issues in StashBuildTrigger have been fixed already. -- You received this message because you are subscribed to the Google Groups "Jenkins Commits" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-commits+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-commits/jenkinsci/stash-pullrequest-builder-plugin/push/refs/heads/master/39d095-828f48%40github.com. For more options, visit https://groups.google.com/d/optout.
[jenkinsci/stash-pullrequest-builder-plugin] 39d095: StashPostBuildComment: Don't override newInstance(...
Branch: refs/heads/master Home: https://github.com/jenkinsci/stash-pullrequest-builder-plugin Commit: 39d0950c9b1a2183431b11e5f15b182cea3126f6 https://github.com/jenkinsci/stash-pullrequest-builder-plugin/commit/39d0950c9b1a2183431b11e5f15b182cea3126f6 Author: Pavel Roskin Date: 2019-06-21 (Fri, 21 Jun 2019) Changed paths: M src/main/java/stashpullrequestbuilder/stashpullrequestbuilder/StashPostBuildComment.java Log Message: --- StashPostBuildComment: Don't override newInstance(), it's not needed The override was doing the same thing as the superclass implementation. -- You received this message because you are subscribed to the Google Groups "Jenkins Commits" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-commits+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-commits/jenkinsci/stash-pullrequest-builder-plugin/push/refs/heads/master/14c630-39d095%40github.com. For more options, visit https://groups.google.com/d/optout.
[jenkinsci/stash-pullrequest-builder-plugin] 14c630: Fix FindBugs warnings about StashBuildTrigger#job ...
Branch: refs/heads/master Home: https://github.com/jenkinsci/stash-pullrequest-builder-plugin Commit: 14c630de35b51a56173ae98f26d71c09745302db https://github.com/jenkinsci/stash-pullrequest-builder-plugin/commit/14c630de35b51a56173ae98f26d71c09745302db Author: Pavel Roskin Date: 2019-06-06 (Thu, 06 Jun 2019) Changed paths: M src/main/java/stashpullrequestbuilder/stashpullrequestbuilder/StashBuildTrigger.java M src/main/java/stashpullrequestbuilder/stashpullrequestbuilder/StashRepository.java R src/test/java/stashpullrequestbuilder/stashpullrequestbuilder/StashBuildTriggerTest.java M src/test/java/stashpullrequestbuilder/stashpullrequestbuilder/StashRepositoryTest.java Log Message: --- Fix FindBugs warnings about StashBuildTrigger#job being null Move startJob() and its dependencies from StashBuildTrigger to StashRepository. StashBuildTrigger objects can have a null job field, but it's impossible for StashRepository, which is instantiated once a non-null job is passed to StashBuildTrigger#start(). Move corresponding unit tests from StashBuildTriggerTest to StashRepositoryTest. -- You received this message because you are subscribed to the Google Groups "Jenkins Commits" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-commits+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-commits/jenkinsci/stash-pullrequest-builder-plugin/push/refs/heads/master/82bcab-14c630%40github.com. For more options, visit https://groups.google.com/d/optout.
[jenkinsci/stash-pullrequest-builder-plugin] 82bcab: StashPostBuildComment: Remove redundant "implements"
Branch: refs/heads/master Home: https://github.com/jenkinsci/stash-pullrequest-builder-plugin Commit: 82bcab2ac0734cee170c0f8c128e91cd8b093c57 https://github.com/jenkinsci/stash-pullrequest-builder-plugin/commit/82bcab2ac0734cee170c0f8c128e91cd8b093c57 Author: Pavel Roskin Date: 2019-06-06 (Thu, 06 Jun 2019) Changed paths: M src/main/java/stashpullrequestbuilder/stashpullrequestbuilder/StashPostBuildComment.java Log Message: --- StashPostBuildComment: Remove redundant "implements" Notifier implements Describable, no need to specify the same thing in subclasses of Notifier. -- You received this message because you are subscribed to the Google Groups "Jenkins Commits" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-commits+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-commits/jenkinsci/stash-pullrequest-builder-plugin/push/refs/heads/master/792ab3-82bcab%40github.com. For more options, visit https://groups.google.com/d/optout.
[jenkinsci/stash-pullrequest-builder-plugin] 792ab3: StashRepository: Use Java style array declaration
Branch: refs/heads/master Home: https://github.com/jenkinsci/stash-pullrequest-builder-plugin Commit: 792ab3a438f4bd542b530aafc33f37b35e0797b6 https://github.com/jenkinsci/stash-pullrequest-builder-plugin/commit/792ab3a438f4bd542b530aafc33f37b35e0797b6 Author: Pavel Roskin Date: 2019-06-06 (Thu, 06 Jun 2019) Changed paths: M src/main/java/stashpullrequestbuilder/stashpullrequestbuilder/StashRepository.java Log Message: --- StashRepository: Use Java style array declaration Using [] after the variable name is deprecated. -- You received this message because you are subscribed to the Google Groups "Jenkins Commits" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-commits+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-commits/jenkinsci/stash-pullrequest-builder-plugin/push/refs/heads/master/1b73ed-792ab3%40github.com. For more options, visit https://groups.google.com/d/optout.
[jenkinsci/stash-pullrequest-builder-plugin] 1b73ed: StashBuildTriggerTest: Use varargs for parameter d...
Branch: refs/heads/master Home: https://github.com/jenkinsci/stash-pullrequest-builder-plugin Commit: 1b73ed3bff9b9d2a8f5065f8114ee1a80a6200bb https://github.com/jenkinsci/stash-pullrequest-builder-plugin/commit/1b73ed3bff9b9d2a8f5065f8114ee1a80a6200bb Author: Pavel Roskin Date: 2019-06-04 (Tue, 04 Jun 2019) Changed paths: M src/test/java/stashpullrequestbuilder/stashpullrequestbuilder/StashBuildTriggerTest.java Log Message: --- StashBuildTriggerTest: Use varargs for parameter definitions -- You received this message because you are subscribed to the Google Groups "Jenkins Commits" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-commits+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-commits/jenkinsci/stash-pullrequest-builder-plugin/push/refs/heads/master/943e4f-1b73ed%40github.com. For more options, visit https://groups.google.com/d/optout.
[jenkinsci/stash-pullrequest-builder-plugin] 8753b1: StashApiClient: Annotate functions as @Nullable if...
Branch: refs/heads/master Home: https://github.com/jenkinsci/stash-pullrequest-builder-plugin Commit: 8753b1621cee3ebf9523c4f8d4b1ba62d5341a32 https://github.com/jenkinsci/stash-pullrequest-builder-plugin/commit/8753b1621cee3ebf9523c4f8d4b1ba62d5341a32 Author: Pavel Roskin Date: 2019-06-03 (Mon, 03 Jun 2019) Changed paths: M src/main/java/stashpullrequestbuilder/stashpullrequestbuilder/stash/StashApiClient.java Log Message: --- StashApiClient: Annotate functions as @Nullable if they can return null Commit: 680a7b81c302b063ca251f08e4ff69977ded958d https://github.com/jenkinsci/stash-pullrequest-builder-plugin/commit/680a7b81c302b063ca251f08e4ff69977ded958d Author: Pavel Roskin Date: 2019-06-03 (Mon, 03 Jun 2019) Changed paths: M src/main/java/stashpullrequestbuilder/stashpullrequestbuilder/stash/StashApiClient.java Log Message: --- StashApiClient: Remove useless casts and class prefixes Commit: 6e0d3c4f9bb109d62f358ce67bf5a4f1c6003b96 https://github.com/jenkinsci/stash-pullrequest-builder-plugin/commit/6e0d3c4f9bb109d62f358ce67bf5a4f1c6003b96 Author: Pavel Roskin Date: 2019-06-03 (Mon, 03 Jun 2019) Changed paths: M src/main/java/stashpullrequestbuilder/stashpullrequestbuilder/stash/StashApiClient.java Log Message: --- StashApiClient: Provide better descriptions for all timeouts Commit: fbbbed31a6fc7a6637d6bd879c72d33a6a963fc6 https://github.com/jenkinsci/stash-pullrequest-builder-plugin/commit/fbbbed31a6fc7a6637d6bd879c72d33a6a963fc6 Author: Pavel Roskin Date: 2019-06-03 (Mon, 03 Jun 2019) Changed paths: M src/main/java/stashpullrequestbuilder/stashpullrequestbuilder/stash/StashApiClient.java Log Message: --- StashApiClient: Rename all variables for HTTP requests to "request" That is easier to understand, as every function deals with just one request. "httppost" was incorrectly used for DELETE requests. Expand "res" to "response" for DELETE method. Write HTTP in uppercase in comments. Commit: 943e4ff9c0b228a8100d20bcdc9c501b9a8f5355 https://github.com/jenkinsci/stash-pullrequest-builder-plugin/commit/943e4ff9c0b228a8100d20bcdc9c501b9a8f5355 Author: Pavel Roskin Date: 2019-06-03 (Mon, 03 Jun 2019) Changed paths: M src/main/java/stashpullrequestbuilder/stashpullrequestbuilder/stash/StashApiClient.java Log Message: --- StashApiClient: Remove all special treatment for UnsupportedEncodingException postRequest() doesn't throw UnsupportedEncodingException, adjust the callers. UnsupportedEncodingException is derived from IOException, treat it as the later. No need to print stack trace. Don't catch IOException in the code that cannot throw it. Compare: https://github.com/jenkinsci/stash-pullrequest-builder-plugin/compare/2961b06f6f58...943e4ff9c0b2 -- You received this message because you are subscribed to the Google Groups "Jenkins Commits" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-commits+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-commits/jenkinsci/stash-pullrequest-builder-plugin/push/refs/heads/master/2961b0-943e4f%40github.com. For more options, visit https://groups.google.com/d/optout.
[jenkinsci/stash-pullrequest-builder-plugin] 2961b0: StashRepository: Clean up comment sorting, add com...
Branch: refs/heads/master Home: https://github.com/jenkinsci/stash-pullrequest-builder-plugin Commit: 2961b06f6f5854593608705ce5bd2525a2745349 https://github.com/jenkinsci/stash-pullrequest-builder-plugin/commit/2961b06f6f5854593608705ce5bd2525a2745349 Author: Pavel Roskin Date: 2019-06-03 (Mon, 03 Jun 2019) Changed paths: M src/main/java/stashpullrequestbuilder/stashpullrequestbuilder/StashRepository.java M src/test/java/stashpullrequestbuilder/stashpullrequestbuilder/StashRepositoryTest.java Log Message: --- StashRepository: Clean up comment sorting, add comments When extracting parameters from comments, start with the oldest comments, as the code iterates over all comments. Parameters from the new comments are processed last, overwriting older values. When deleting old "BUILD FINISHED" comments, don't sort the comments, it doesn't matter in which order they are deleted. When looking for comments to decide whether to run a build, start with the most recent comments. The loop terminates early as soon as it's clear whether to start the build or not. Don't sort and reverse the sort order as two operations, use reverse sorting. -- You received this message because you are subscribed to the Google Groups "Jenkins Commits" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-commits+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-commits/jenkinsci/stash-pullrequest-builder-plugin/push/refs/heads/master/db3937-2961b0%40github.com. For more options, visit https://groups.google.com/d/optout.
[jenkinsci/stash-pullrequest-builder-plugin] db3937: StashBuildEnvironmentContributor: Pass environment...
Branch: refs/heads/master Home: https://github.com/jenkinsci/stash-pullrequest-builder-plugin Commit: db39375f9d26b6ce11bc1c3f6ffa48c52792cabf https://github.com/jenkinsci/stash-pullrequest-builder-plugin/commit/db39375f9d26b6ce11bc1c3f6ffa48c52792cabf Author: Pavel Roskin Date: 2019-06-03 (Mon, 03 Jun 2019) Changed paths: M src/main/java/stashpullrequestbuilder/stashpullrequestbuilder/StashBuildEnvironmentContributor.java A src/test/java/stashpullrequestbuilder/stashpullrequestbuilder/StashBuildEnvironmentContributorTest.java Log Message: --- StashBuildEnvironmentContributor: Pass environment variables to pipelines (#96) * StashBuildEnvironmentContributor: Pass environment variables to pipelines Add environment variables to every Run caused by StashCause even if it's not an instance of AbstractBuild. * Add unit tests for StashBuildEnvironmentContributor -- You received this message because you are subscribed to the Google Groups "Jenkins Commits" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-commits+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-commits/jenkinsci/stash-pullrequest-builder-plugin/push/refs/heads/master/2f1711-db3937%40github.com. For more options, visit https://groups.google.com/d/optout.
[jenkinsci/stash-pullrequest-builder-plugin] 2f1711: Don't accept any new parameter names from pull req...
Branch: refs/heads/master Home: https://github.com/jenkinsci/stash-pullrequest-builder-plugin Commit: 2f1711b8b43862750e96dec670e526bacea43335 https://github.com/jenkinsci/stash-pullrequest-builder-plugin/commit/2f1711b8b43862750e96dec670e526bacea43335 Author: Pavel Roskin Date: 2019-06-03 (Mon, 03 Jun 2019) Changed paths: M README.md M src/main/java/stashpullrequestbuilder/stashpullrequestbuilder/StashBuildTrigger.java A src/test/java/stashpullrequestbuilder/stashpullrequestbuilder/StashBuildTriggerTest.java Log Message: --- Don't accept any new parameter names from pull request comments Parameters extracted from Stash comments are only allowed to override the default values of the parameters defined for the job. Accepting arbitrary parameters from Stash comments can be exploited by a user who can post comments but not administer the Jenkins job. Pass only one copy of the parameter to the job. Remove null parameters only after the values from the Stash comments have been applied. Suppress a FindBugs warning about this.job being null. That cannot happen, but FindBugs cannot figure it out. -- You received this message because you are subscribed to the Google Groups "Jenkins Commits" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-commits+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-commits/jenkinsci/stash-pullrequest-builder-plugin/push/refs/heads/master/a38b1d-2f1711%40github.com. For more options, visit https://groups.google.com/d/optout.
[jenkinsci/stash-pullrequest-builder-plugin] 47c6fa: StashRepositoryTest: Remove verifications
Branch: refs/heads/master Home: https://github.com/jenkinsci/stash-pullrequest-builder-plugin Commit: 47c6fa4e7314d7d0d1d49e82b45a91072e804499 https://github.com/jenkinsci/stash-pullrequest-builder-plugin/commit/47c6fa4e7314d7d0d1d49e82b45a91072e804499 Author: Pavel Roskin Date: 2019-05-24 (Fri, 24 May 2019) Changed paths: M src/test/java/stashpullrequestbuilder/stashpullrequestbuilder/StashRepositoryTest.java Log Message: --- StashRepositoryTest: Remove verifications Verifications require mock objects, but we can easily use real objects to represent the data received from the Bitbucket Server. The existing verifications don't provide any significant value. Commit: 12077ff8b8246d3dbc7e24b7b1d0ccf664fdbfa2 https://github.com/jenkinsci/stash-pullrequest-builder-plugin/commit/12077ff8b8246d3dbc7e24b7b1d0ccf664fdbfa2 Author: Pavel Roskin Date: 2019-05-24 (Fri, 24 May 2019) Changed paths: M src/test/java/stashpullrequestbuilder/stashpullrequestbuilder/StashRepositoryTest.java Log Message: --- StashRepositoryTest: Replace "CLOSED" with "MERGED" "MERGED" is an actual PR status (the others are "OPEN" and "DECLINED"). It's easier to understand tests based on realistic data. Commit: 79d6c7d2e7b9325dbebaa24f8f57e8bb4df64e00 https://github.com/jenkinsci/stash-pullrequest-builder-plugin/commit/79d6c7d2e7b9325dbebaa24f8f57e8bb4df64e00 Author: Pavel Roskin Date: 2019-05-24 (Fri, 24 May 2019) Changed paths: M src/test/java/stashpullrequestbuilder/stashpullrequestbuilder/StashRepositoryTest.java Log Message: --- StashRepositoryTest: Refactor creation of a pull request list Commit: a38b1d1a8da7e85f7e81035808a792607bd0bbf2 https://github.com/jenkinsci/stash-pullrequest-builder-plugin/commit/a38b1d1a8da7e85f7e81035808a792607bd0bbf2 Author: Pavel Roskin Date: 2019-05-24 (Fri, 24 May 2019) Changed paths: M src/test/java/stashpullrequestbuilder/stashpullrequestbuilder/StashRepositoryTest.java Log Message: --- StashRepositoryTest: Don't mock pullRequest, repository and repoRepo They are just data classes that can be trivially constructed and modified. That allows refactoring some code shared between test cases. Compare: https://github.com/jenkinsci/stash-pullrequest-builder-plugin/compare/41f8d12de895...a38b1d1a8da7 -- You received this message because you are subscribed to the Google Groups "Jenkins Commits" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-commits+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-commits/jenkinsci/stash-pullrequest-builder-plugin/push/refs/heads/master/41f8d1-a38b1d%40github.com. For more options, visit https://groups.google.com/d/optout.
[jenkinsci/stash-pullrequest-builder-plugin] 64ed3a: StashBuildListener: Get the trigger using Paramete...
Branch: refs/heads/master Home: https://github.com/jenkinsci/stash-pullrequest-builder-plugin Commit: 64ed3a5717cd12114eec2a357164a069233fd4e0 https://github.com/jenkinsci/stash-pullrequest-builder-plugin/commit/64ed3a5717cd12114eec2a357164a069233fd4e0 Author: Pavel Roskin Date: 2019-05-23 (Thu, 23 May 2019) Changed paths: M src/main/java/stashpullrequestbuilder/stashpullrequestbuilder/StashBuildListener.java M src/main/java/stashpullrequestbuilder/stashpullrequestbuilder/StashBuildTrigger.java Log Message: --- StashBuildListener: Get the trigger using ParameterizedJobMixIn.getTrigger() Remove StashBuildTrigger.getTrigger(), it's not used anymore. -- You received this message because you are subscribed to the Google Groups "Jenkins Commits" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-commits+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-commits/jenkinsci/stash-pullrequest-builder-plugin/push/refs/heads/master/1b82f6-64ed3a%40github.com. For more options, visit https://groups.google.com/d/optout.
[jenkinsci/stash-pullrequest-builder-plugin] 8a0a2a: StashRepositoryTest: Set Mockito strictness to STR...
Branch: refs/heads/master Home: https://github.com/jenkinsci/stash-pullrequest-builder-plugin Commit: 8a0a2a5813933b97ff4ca562b23fe3b822e47d90 https://github.com/jenkinsci/stash-pullrequest-builder-plugin/commit/8a0a2a5813933b97ff4ca562b23fe3b822e47d90 Author: Pavel Roskin Date: 2019-05-23 (Thu, 23 May 2019) Changed paths: M src/test/java/stashpullrequestbuilder/stashpullrequestbuilder/StashRepositoryTest.java Log Message: --- StashRepositoryTest: Set Mockito strictness to STRICT_STUBS This makes unit tests warn about unnecessary mocking so the code is kept short and to the point. Commit: de2ff32e3938318557d9c80fe16d91ba8a51412e https://github.com/jenkinsci/stash-pullrequest-builder-plugin/commit/de2ff32e3938318557d9c80fe16d91ba8a51412e Author: Pavel Roskin Date: 2019-05-23 (Thu, 23 May 2019) Changed paths: M src/test/java/stashpullrequestbuilder/stashpullrequestbuilder/StashRepositoryTest.java Log Message: --- StashRepositoryTest: Add unit tests for isForTargetBranch() and isSkipBuild() Commit: 1b82f628bb7eef071ccfc8b9909ad3da1819ee28 https://github.com/jenkinsci/stash-pullrequest-builder-plugin/commit/1b82f628bb7eef071ccfc8b9909ad3da1819ee28 Author: Pavel Roskin Date: 2019-05-23 (Thu, 23 May 2019) Changed paths: M src/main/java/stashpullrequestbuilder/stashpullrequestbuilder/StashRepository.java Log Message: --- StashRepository: Use StringUtils.isNotEmpty(), it treats null as empty Compare: https://github.com/jenkinsci/stash-pullrequest-builder-plugin/compare/8d19372a9e26...1b82f628bb7e -- You received this message because you are subscribed to the Google Groups "Jenkins Commits" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-commits+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-commits/jenkinsci/stash-pullrequest-builder-plugin/push/refs/heads/master/8d1937-1b82f6%40github.com. For more options, visit https://groups.google.com/d/optout.
[jenkinsci/stash-pullrequest-builder-plugin] 8d1937: StashRepository: Make string constants private, ot...
Branch: refs/heads/master Home: https://github.com/jenkinsci/stash-pullrequest-builder-plugin Commit: 8d19372a9e2680f2e41f1d641010b323d7992c71 https://github.com/jenkinsci/stash-pullrequest-builder-plugin/commit/8d19372a9e2680f2e41f1d641010b323d7992c71 Author: Pavel Roskin Date: 2019-05-09 (Thu, 09 May 2019) Changed paths: M src/main/java/stashpullrequestbuilder/stashpullrequestbuilder/StashRepository.java Log Message: --- StashRepository: Make string constants private, other classes don't use them Remove unused constants BUILD_START_SENTENCE and BUILD_RUNNING_COMMENT. -- You received this message because you are subscribed to the Google Groups "Jenkins Commits" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-commits+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-commits/jenkinsci/stash-pullrequest-builder-plugin/push/refs/heads/master/c4121b-8d1937%40github.com. For more options, visit https://groups.google.com/d/optout.
[jenkinsci/stash-pullrequest-builder-plugin] c4121b: Annotate compareTo() methods with @Override
Branch: refs/heads/master Home: https://github.com/jenkinsci/stash-pullrequest-builder-plugin Commit: c4121bfd7e1c03eeab1b1ee0d46089edc08d08d4 https://github.com/jenkinsci/stash-pullrequest-builder-plugin/commit/c4121bfd7e1c03eeab1b1ee0d46089edc08d08d4 Author: Pavel Roskin Date: 2019-05-09 (Thu, 09 May 2019) Changed paths: M src/main/java/stashpullrequestbuilder/stashpullrequestbuilder/stash/StashPullRequestActivity.java M src/main/java/stashpullrequestbuilder/stashpullrequestbuilder/stash/StashPullRequestComment.java Log Message: --- Annotate compareTo() methods with @Override -- You received this message because you are subscribed to the Google Groups "Jenkins Commits" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-commits+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-commits/jenkinsci/stash-pullrequest-builder-plugin/push/refs/heads/master/807750-c4121b%40github.com. For more options, visit https://groups.google.com/d/optout.
[jenkinsci/stash-pullrequest-builder-plugin] eb6dbc: StashRepository: Change constructor to get needed ...
Branch: refs/heads/master Home: https://github.com/jenkinsci/stash-pullrequest-builder-plugin Commit: eb6dbcb43c7f46ccd4aa5a5bf2230e9ef48c0cae https://github.com/jenkinsci/stash-pullrequest-builder-plugin/commit/eb6dbcb43c7f46ccd4aa5a5bf2230e9ef48c0cae Author: Pavel Roskin Date: 2019-05-06 (Mon, 06 May 2019) Changed paths: M src/main/java/stashpullrequestbuilder/stashpullrequestbuilder/StashPullRequestsBuilder.java M src/main/java/stashpullrequestbuilder/stashpullrequestbuilder/StashRepository.java Log Message: --- StashRepository: Change constructor to get needed objects directly The StashPullRequestsBuilder object is not needed, but the project and the trigger are used a lot, so pass them to the constructor. Annotate the constructor arguments with @Nonnull. No need to defer setting trigger until the init() call, it is not going to change. Passing the needed objects directly simplifies mock object injection in unit tests. Commit: cc2f4d712837c80a26a09a5f289cbe98605f273d https://github.com/jenkinsci/stash-pullrequest-builder-plugin/commit/cc2f4d712837c80a26a09a5f289cbe98605f273d Author: Pavel Roskin Date: 2019-05-06 (Mon, 06 May 2019) Changed paths: M pom.xml M src/main/java/stashpullrequestbuilder/stashpullrequestbuilder/StashRepository.java A src/test/java/stashpullrequestbuilder/stashpullrequestbuilder/StashRepositoryTest.java Log Message: --- StashRepository: Only consider pull requests in the "OPEN" state Pull requests in other states were wrongly considered buildable. Fortunately, they are not returned but Stash. Still, the check was in the code, and it was not working as intended. Add Mockito based unit tests. Add a constructor that takes the StashApiClient object, since "new" cannot be mocked. Compare: https://github.com/jenkinsci/stash-pullrequest-builder-plugin/compare/b5fc46ad61c4...cc2f4d712837 -- You received this message because you are subscribed to the Google Groups "Jenkins Commits" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-commits+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[jenkinsci/stash-pullrequest-builder-plugin] 807750: Fix credential matching by Stash URL
Branch: refs/heads/master Home: https://github.com/jenkinsci/stash-pullrequest-builder-plugin Commit: 8077506d860bcc7dc9426f8ff294f4a3bedc8577 https://github.com/jenkinsci/stash-pullrequest-builder-plugin/commit/8077506d860bcc7dc9426f8ff294f4a3bedc8577 Author: Pavel Roskin Date: 2019-05-06 (Mon, 06 May 2019) Changed paths: M src/main/java/stashpullrequestbuilder/stashpullrequestbuilder/StashBuildTrigger.java Log Message: --- Fix credential matching by Stash URL The arguments to doFillCredentialsIdItems() should have specific names to receive values from the correct fields. The "source" parameter was null, so credentials from all domains were selectable. "stashHost" gets the value from the "Stash URL" field and uses it to limit credentials to those from matching domains. -- You received this message because you are subscribed to the Google Groups "Jenkins Commits" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-commits+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[jenkinsci/stash-pullrequest-builder-plugin] b5fc46: pom.xml: Replace unneeded dependency on git with d...
Branch: refs/heads/master Home: https://github.com/jenkinsci/stash-pullrequest-builder-plugin Commit: b5fc46ad61c4261b5dcee1004c18df0bbeddfa66 https://github.com/jenkinsci/stash-pullrequest-builder-plugin/commit/b5fc46ad61c4261b5dcee1004c18df0bbeddfa66 Author: Pavel Roskin Date: 2019-04-27 (Sat, 27 Apr 2019) Changed paths: M pom.xml Log Message: --- pom.xml: Replace unneeded dependency on git with direct dependencies org.apache.http.params.CoreConnectionPNames needs httpclient 4.5.2. Junit is used in unit tests. -- You received this message because you are subscribed to the Google Groups "Jenkins Commits" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-commits+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[jenkinsci/stash-pullrequest-builder-plugin] 549e51: StashBuildTrigger: Call super.start() first
Branch: refs/heads/master Home: https://github.com/jenkinsci/stash-pullrequest-builder-plugin Commit: 549e512b06c5cc3de98478cdaf53f87cc2174adb https://github.com/jenkinsci/stash-pullrequest-builder-plugin/commit/549e512b06c5cc3de98478cdaf53f87cc2174adb Author: Pavel Roskin Date: 2019-04-24 (Wed, 24 Apr 2019) Changed paths: M src/main/java/stashpullrequestbuilder/stashpullrequestbuilder/StashBuildTrigger.java Log Message: --- StashBuildTrigger: Call super.start() first It is safer to let the superclass do its part first. In particular, super.start() sets this.job, which should be done before "this" is passed to another constructor. -- You received this message because you are subscribed to the Google Groups "Jenkins Commits" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-commits+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[jenkinsci/stash-pullrequest-builder-plugin] 028866: Fix canceling outdated Maven projects
Branch: refs/heads/master Home: https://github.com/jenkinsci/stash-pullrequest-builder-plugin Commit: 028866271378fe47b75ce177db9a84c0801e9280 https://github.com/jenkinsci/stash-pullrequest-builder-plugin/commit/028866271378fe47b75ce177db9a84c0801e9280 Author: Pavel Roskin Date: 2019-04-24 (Wed, 24 Apr 2019) Changed paths: M src/main/java/stashpullrequestbuilder/stashpullrequestbuilder/StashBuildTrigger.java Log Message: --- Fix canceling outdated Maven projects The original code would only look for instances of Build to be canceled. MavenBuild inherits from AbstractBuild but not from Build, so Maven builds would not be canceled. Use Run for elements of the job.getBuilds(), it is type safe and provides the necessary API. Use run.getId() in the log for better readability. Check the result of getExecutor(), it has @CheckForNull attribute. -- You received this message because you are subscribed to the Google Groups "Jenkins Commits" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-commits+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[jenkinsci/stash-pullrequest-builder-plugin] 3d7d9c: Use Hamcrest in unit tests, it gives better diagno...
Branch: refs/heads/master Home: https://github.com/jenkinsci/stash-pullrequest-builder-plugin Commit: 3d7d9c0d24913df4a893d33e20e0a482f074124c https://github.com/jenkinsci/stash-pullrequest-builder-plugin/commit/3d7d9c0d24913df4a893d33e20e0a482f074124c Author: Pavel Roskin Date: 2019-04-24 (Wed, 24 Apr 2019) Changed paths: M pom.xml M src/test/java/stashpullrequestbuilder/stashpullrequestbuilder/stash/AdditionalParameterRegExTest.java M src/test/java/stashpullrequestbuilder/stashpullrequestbuilder/stash/StashApiClientTest.java M src/test/java/stashpullrequestbuilder/stashpullrequestbuilder/stash/StashPullRequestResponseValueRepositoryTest.java Log Message: --- Use Hamcrest in unit tests, it gives better diagnostics Add explicit JUnit dependency in pom.xml and make sure that Hamcrest stands above JUnit, as suggested in Hamcrest documentation. Rename "testN" variables to "entry", as they are instances of SimpleEntry. -- You received this message because you are subscribed to the Google Groups "Jenkins Commits" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-commits+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[jenkinsci/stash-pullrequest-builder-plugin] fc28fa: Iterate over map entries more efficiently
Branch: refs/heads/master Home: https://github.com/jenkinsci/stash-pullrequest-builder-plugin Commit: fc28fa2c93b842b54a135f9d13aa9322d04dd3bb https://github.com/jenkinsci/stash-pullrequest-builder-plugin/commit/fc28fa2c93b842b54a135f9d13aa9322d04dd3bb Author: Pavel Roskin Date: 2019-04-24 (Wed, 24 Apr 2019) Changed paths: M src/main/java/stashpullrequestbuilder/stashpullrequestbuilder/StashBuildTrigger.java M src/main/java/stashpullrequestbuilder/stashpullrequestbuilder/StashRepository.java Log Message: --- Iterate over map entries more efficiently Use iteration over key-value pairs, not over keys. The later is less efficient, as it needs to construct a temporary Set of keys. Remove attributes to suppress corresponding FindBugs issues. -- You received this message because you are subscribed to the Google Groups "Jenkins Commits" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-commits+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[jenkinsci/stash-pullrequest-builder-plugin] b55085: StashRepository: Don't take projectPath in constru...
Branch: refs/heads/master Home: https://github.com/jenkinsci/stash-pullrequest-builder-plugin Commit: b5508588b345638de6d9edd84c2d11a11d265962 https://github.com/jenkinsci/stash-pullrequest-builder-plugin/commit/b5508588b345638de6d9edd84c2d11a11d265962 Author: Pavel Roskin Date: 2019-04-12 (Fri, 12 Apr 2019) Changed paths: M src/main/java/stashpullrequestbuilder/stashpullrequestbuilder/StashPullRequestsBuilder.java M src/main/java/stashpullrequestbuilder/stashpullrequestbuilder/StashRepository.java Log Message: --- StashRepository: Don't take projectPath in constructor, it's unused -- You received this message because you are subscribed to the Google Groups "Jenkins Commits" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-commits+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[jenkinsci/stash-pullrequest-builder-plugin] 689f3c: Fix warnings about raw types
Branch: refs/heads/master Home: https://github.com/jenkinsci/stash-pullrequest-builder-plugin Commit: 689f3c645c3a11f38e809d67876283147924d9a3 https://github.com/jenkinsci/stash-pullrequest-builder-plugin/commit/689f3c645c3a11f38e809d67876283147924d9a3 Author: Pavel Roskin Date: 2019-04-11 (Thu, 11 Apr 2019) Changed paths: M src/main/java/stashpullrequestbuilder/stashpullrequestbuilder/StashBuildEnvironmentContributor.java M src/main/java/stashpullrequestbuilder/stashpullrequestbuilder/StashBuildListener.java M src/main/java/stashpullrequestbuilder/stashpullrequestbuilder/StashBuildTrigger.java M src/main/java/stashpullrequestbuilder/stashpullrequestbuilder/StashPullRequestsBuilder.java Log Message: --- Fix warnings about raw types Warnings caused by raw types in the Jenkins API are not fixed, as there is no way to do it. Remove casts that are redundant with parameterized types. -- You received this message because you are subscribed to the Google Groups "Jenkins Commits" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-commits+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[jenkinsci/stash-pullrequest-builder-plugin] 051d40: Fix spelling of "comment"
Branch: refs/heads/master Home: https://github.com/jenkinsci/stash-pullrequest-builder-plugin Commit: 051d40e608f104947b201a10646b9b49606ce1cf https://github.com/jenkinsci/stash-pullrequest-builder-plugin/commit/051d40e608f104947b201a10646b9b49606ce1cf Author: Pavel Roskin Date: 2019-04-10 (Wed, 10 Apr 2019) Changed paths: M src/main/java/stashpullrequestbuilder/stashpullrequestbuilder/stash/StashPullRequestActivity.java Log Message: --- Fix spelling of "comment" Commit: 542bc77f641ae7e22f153e70a39022604a857cb0 https://github.com/jenkinsci/stash-pullrequest-builder-plugin/commit/542bc77f641ae7e22f153e70a39022604a857cb0 Author: Pavel Roskin Date: 2019-04-10 (Wed, 10 Apr 2019) Changed paths: M src/main/java/stashpullrequestbuilder/stashpullrequestbuilder/StashRepository.java M src/main/java/stashpullrequestbuilder/stashpullrequestbuilder/stash/StashApiClient.java R src/main/java/stashpullrequestbuilder/stashpullrequestbuilder/stash/StashPullRequestMergableResponse.java R src/main/java/stashpullrequestbuilder/stashpullrequestbuilder/stash/StashPullRequestMergableVetoMessage.java A src/main/java/stashpullrequestbuilder/stashpullrequestbuilder/stash/StashPullRequestMergeableResponse.java A src/main/java/stashpullrequestbuilder/stashpullrequestbuilder/stash/StashPullRequestMergeableVetoMessage.java M src/test/java/stashpullrequestbuilder/stashpullrequestbuilder/stash/StashApiClientTest.java Log Message: --- Fix spelling of "mergeable" Compare: https://github.com/jenkinsci/stash-pullrequest-builder-plugin/compare/e38e5e03d06f...542bc77f641a -- You received this message because you are subscribed to the Google Groups "Jenkins Commits" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-commits+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
