Re: Adopt plugin openid-plugin

[Michael Nazzareno Trimarchi]

Hi

This is really nice community

On Sun, Feb 18, 2024 at 9:57 PM Michael Nazzareno Trimarchi
 wrote:
>
> Hi
>
> On Sun, Feb 18, 2024 at 9:55 PM Mark Waite  wrote:
> >
> >
> >
> > On Sunday, February 18, 2024 at 1:42:00 PM UTC-7 Michael wrote:
> >
> > Hi
> >
> > Solved this way
> >
> > + 
> > + org.jenkins-ci.plugins
> > + junit
> > + 1119.1121.vc43d0fc45561
> > + test
> > + 
> > + 
> > + org.jenkins-ci.plugins
> > + script-security
> > + 1175.v4b_d517d6db_f0
> > + test
> > + 
> >
> > Is this the correct way?
> >
> >
> > That is a valid way to solve it, though most plugin maintainers prefer to 
> > let the plugin bill of materials manage the versions of dependencies when 
> > they are available from the plugin bill of materials.
> >
> > The "Improve a  plugin" tutorial includes a section on using the plugin 
> > bill of materials.
> >
> > It also has a section on updating the minimum Jenkins version (you probably 
> > want 2.414.3 rather than 2.410).
> >
> > It also has a section on updating the parent pom that will allow you to run 
> > tests with Java 21 and Java 17 so that you're confident the plugin works on 
> > all the JDKs that Jenkins supports.
> >
>
> Let me study this and I will adjust security problems now and then
> bump again to 2.414.3
>
> Michael
>
> > Thanks very much for adopting the plugin!
> >
> > Mark Waite

Thank you Mark for helping me and let me understand how now it works
with the BOM.

Michael

> >
> >
> > --
> > You received this message because you are subscribed to the Google Groups 
> > "Jenkins Developers" group.
> > To unsubscribe from this group and stop receiving emails from it, send an 
> > email to jenkinsci-dev+unsubscr...@googlegroups.com.
> > To view this discussion on the web visit 
> > https://groups.google.com/d/msgid/jenkinsci-dev/ca8c242d-1f6d-4ba8-aad6-fe28a29ed6b0n%40googlegroups.com.
>
>
>
> --
> Michael Nazzareno Trimarchi
> Co-Founder & Chief Executive Officer
> M. +39 347 913 2170
> mich...@amarulasolutions.com
> __
>
> Amarula Solutions BV
> Joop Geesinkweg 125, 1114 AB, Amsterdam, NL
> T. +31 (0)85 111 9172
> i...@amarulasolutions.com
> www.amarulasolutions.com



-- 
Michael Nazzareno Trimarchi
Co-Founder & Chief Executive Officer
M. +39 347 913 2170
mich...@amarulasolutions.com
__

Amarula Solutions BV
Joop Geesinkweg 125, 1114 AB, Amsterdam, NL
T. +31 (0)85 111 9172
i...@amarulasolutions.com
www.amarulasolutions.com

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/CAOf5uw%3DqXJ2du%3DEVNj_oG%2BDD%3DVKS9zKCE0RVtTsdUHVQM9M6KA%40mail.gmail.com.

Re: Proposal: Stefan Spieker to join the core PR reviewers team

[Basil Crow]

+1

On Sun, Feb 18, 2024 at 10:07 PM Mark Waite 
wrote:

>
>
> On Sunday, February 18, 2024 at 9:30:35 AM UTC-7 Alexander Brandes wrote:
>
> Hey everyone,
>
> I would like to propose Stefan Spieker (@StefanSpieker
> ) to join the core PR reviewers team.
>
> Stefan has been a core contributor since October 2022, and filed 172
>  pull
> requests, where 171 PRs have been merged.
> Additionally, he has been active in reviewing core PRs and has voiced his
> opinion in almost 300
> 
>  pull
> requests.
>
> I would welcome him as an addition to the core pr team :)
>
>
> +1 from me.
>
> Mark Waite
>
> --
> You received this message because you are subscribed to the Google Groups
> "Jenkins Developers" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to jenkinsci-dev+unsubscr...@googlegroups.com.
> To view this discussion on the web visit
> https://groups.google.com/d/msgid/jenkinsci-dev/28e931e5-26e9-47c4-80c7-87871a4a929en%40googlegroups.com
> 
> .
>

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/CAFwNDjrpBy1cWe%3DXGyhub1jKnExrd-Zr6GD%3Dn2KT3ObvgTRTBg%40mail.gmail.com.

Re: Proposal: Stefan Spieker to join the core PR reviewers team

[Mark Waite]

On Sunday, February 18, 2024 at 9:30:35 AM UTC-7 Alexander Brandes wrote:

Hey everyone,

I would like to propose Stefan Spieker (@StefanSpieker 
) to join the core PR reviewers team.

Stefan has been a core contributor since October 2022, and filed 172 
 pull 
requests, where 171 PRs have been merged.
Additionally, he has been active in reviewing core PRs and has voiced his 
opinion in almost 300 
 
pull 
requests.

I would welcome him as an addition to the core pr team :)


+1 from me.

Mark Waite 

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/28e931e5-26e9-47c4-80c7-87871a4a929en%40googlegroups.com.

Re: Adopt plugin openid-plugin

[Michael Nazzareno Trimarchi]

Hi

On Sun, Feb 18, 2024 at 9:55 PM Mark Waite  wrote:
>
>
>
> On Sunday, February 18, 2024 at 1:42:00 PM UTC-7 Michael wrote:
>
> Hi
>
> Solved this way
>
> + 
> + org.jenkins-ci.plugins
> + junit
> + 1119.1121.vc43d0fc45561
> + test
> + 
> + 
> + org.jenkins-ci.plugins
> + script-security
> + 1175.v4b_d517d6db_f0
> + test
> + 
>
> Is this the correct way?
>
>
> That is a valid way to solve it, though most plugin maintainers prefer to let 
> the plugin bill of materials manage the versions of dependencies when they 
> are available from the plugin bill of materials.
>
> The "Improve a  plugin" tutorial includes a section on using the plugin bill 
> of materials.
>
> It also has a section on updating the minimum Jenkins version (you probably 
> want 2.414.3 rather than 2.410).
>
> It also has a section on updating the parent pom that will allow you to run 
> tests with Java 21 and Java 17 so that you're confident the plugin works on 
> all the JDKs that Jenkins supports.
>

Let me study this and I will adjust security problems now and then
bump again to 2.414.3

Michael

> Thanks very much for adopting the plugin!
>
> Mark Waite
>
>
> --
> You received this message because you are subscribed to the Google Groups 
> "Jenkins Developers" group.
> To unsubscribe from this group and stop receiving emails from it, send an 
> email to jenkinsci-dev+unsubscr...@googlegroups.com.
> To view this discussion on the web visit 
> https://groups.google.com/d/msgid/jenkinsci-dev/ca8c242d-1f6d-4ba8-aad6-fe28a29ed6b0n%40googlegroups.com.



-- 
Michael Nazzareno Trimarchi
Co-Founder & Chief Executive Officer
M. +39 347 913 2170
mich...@amarulasolutions.com
__

Amarula Solutions BV
Joop Geesinkweg 125, 1114 AB, Amsterdam, NL
T. +31 (0)85 111 9172
i...@amarulasolutions.com
www.amarulasolutions.com

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/CAOf5uwnmxyXVTbKr%3D1_Ma0%2BenurS3irf%2BLaHD8-uJ4yFHTZ6hA%40mail.gmail.com.

Re: Adopt plugin openid-plugin

[Mark Waite]

On Sunday, February 18, 2024 at 1:42:00 PM UTC-7 Michael wrote:

Hi 

Solved this way 

+  
+ org.jenkins-ci.plugins 
+ junit 
+ 1119.1121.vc43d0fc45561 
+ test 
+  
+  
+ org.jenkins-ci.plugins 
+ script-security 
+ 1175.v4b_d517d6db_f0 
+ test 
+  

Is this the correct way?


That is a valid way to solve it, though most plugin maintainers prefer to 
let the plugin bill of materials manage the versions of dependencies when 
they are available from the plugin bill of materials.

The "Improve a  plugin" tutorial 
 includes a section 
on using the plugin bill of materials 

.

It also has a section on updating the minimum Jenkins version 

 
(you probably want 2.414.3 rather than 2.410).

It also has a section on updating the parent pom 
 
that will allow you to run tests with Java 21 and Java 17 
 
so that you're confident the plugin works on all the JDKs that Jenkins 
supports.

Thanks very much for adopting the plugin!

Mark Waite
 

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/ca8c242d-1f6d-4ba8-aad6-fe28a29ed6b0n%40googlegroups.com.

Re: Adopt plugin openid-plugin

['Alexander Brandes' via Jenkins Developers]

Additionally to bumping the jenkins.version, don’t forget to modernise the 
plugin to our standards for maintained plugins: 
https://github.com/jenkinsci/archetypes/tree/master/common-files (ignoring 
archetype-post-generate.groovy)

> On 18. Feb 2024, at 21:41, Michael Nazzareno Trimarchi 
>  wrote:
> 
> Hi
> 
> Solved this way
> 
> +
> +  org.jenkins-ci.plugins
> +  junit
> +  1119.1121.vc43d0fc45561
> +  test
> +
> +
> +  org.jenkins-ci.plugins
> +  script-security
> +  1175.v4b_d517d6db_f0
> +  test
> +
> 
> Is this the correct way?
> 
> Michael
> 
> On Sun, Feb 18, 2024 at 9:05 PM Michael Nazzareno Trimarchi
>  wrote:
>> 
>> Hi all
>> 
>> I have some lack of experience but how can I resolve a problem like this?
>> 
>> 20:04:25  Caused by: java.io.IOException: Failed to load: Matrix
>> Project Plugin (matrix-project 785.v06b_7f47b_c631)
>> 20:04:25   - Update required: JUnit Plugin (junit 1.3) to be updated
>> to 1119.1121.vc43d0fc45561 or higher
>> 
>> Is something that is connected to the pom.xml?
>> 
>> Michael
>> 
>> 
>> 
>> On Sun, Feb 18, 2024 at 6:15 PM Adrien Lecharpentier
>>  wrote:
>>> 
>>> The jenkins.version you set in your pom requires java 11 minimum 
>>> (https://www.jenkins.io/doc/book/platform-information/support-policy-java/).
>>> However, the jenkinsfile still tries to build the plugin using java 8 on 
>>> windows.
>>> 
>>> As you are not the maintainer for now, changing the Jenkinsfile wouldn't 
>>> change anything as it wouldn't be used.
>>> 
>>> Once you're the maintainer, I'd suggested to open a pull request updating 
>>> the jenkinsfile configuration (there is a open rewrite recipe to help you). 
>>> Merge that PR and then you can work more deeply on the plugin.
>>> 
>>> Le dim. 18 févr. 2024, 18:07, Michael Nazzareno Trimarchi 
>>>  a écrit :
 
 Hi
 
 On Sun, Feb 18, 2024 at 5:56 PM Adrien Lecharpentier
  wrote:
> 
> Even if the plugin is not mark as up for adoption, it currently has no 
> maintainer listed in the RPU. So +1 for me.
> 
> Please note that the plugin has multiple public security issues. I'm sure 
> the security team will require you to resolve them before any release can 
> be deployed.
> 
 
 Ok I see, mostly my problem is even resolve CI build on jenkins CI too
 
 Michael
 
> Le dim. 18 févr. 2024, 16:35, Michael Nazzareno Trimarchi 
>  a écrit :
>> 
>> Hi all
>> 
>> https://github.com/jenkinsci/openid-plugin/pull/24
>> 
>> My github account
>> https://github.com/panicking
>> 
>> Pull request for the permission
>> 
>> https://github.com/jenkins-infra/repository-permissions-updater/pull/3776
>> 
>> Michael
>> 
>> --
>> You received this message because you are subscribed to the Google 
>> Groups "Jenkins Developers" group.
>> To unsubscribe from this group and stop receiving emails from it, send 
>> an email to jenkinsci-dev+unsubscr...@googlegroups.com.
>> To view this discussion on the web visit 
>> https://groups.google.com/d/msgid/jenkinsci-dev/CAOf5uwnO4r%2B-upaC-5wCMXbez-bsBd3LajxyU483ftm%2BMLYq2A%40mail.gmail.com.
> 
> --
> You received this message because you are subscribed to the Google Groups 
> "Jenkins Developers" group.
> To unsubscribe from this group and stop receiving emails from it, send an 
> email to jenkinsci-dev+unsubscr...@googlegroups.com.
> To view this discussion on the web visit 
> https://groups.google.com/d/msgid/jenkinsci-dev/CAKwJSvyP%3DkpWEcumyRLhzYBrn4rfB9NguybafT4MwxnTq4f12g%40mail.gmail.com.
 
 
 
 --
 Michael Nazzareno Trimarchi
 Co-Founder & Chief Executive Officer
 M. +39 347 913 2170
 mich...@amarulasolutions.com
 __
 
 Amarula Solutions BV
 Joop Geesinkweg 125, 1114 AB, Amsterdam, NL
 T. +31 (0)85 111 9172
 i...@amarulasolutions.com
 www.amarulasolutions.com
 
 --
 You received this message because you are subscribed to the Google Groups 
 "Jenkins Developers" group.
 To unsubscribe from this group and stop receiving emails from it, send an 
 email to jenkinsci-dev+unsubscr...@googlegroups.com.
 To view this discussion on the web visit 
 https://groups.google.com/d/msgid/jenkinsci-dev/CAOf5uwnQTw0z2bO3RRK6xvorCNmBUojQirg%2BpDJR%2BS3h81RxCg%40mail.gmail.com.
>>> 
>>> --
>>> You received this message because you are subscribed to the Google Groups 
>>> "Jenkins Developers" group.
>>> To unsubscribe from this group and stop receiving emails from it, send an 
>>> email to jenkinsci-dev+unsubscr...@googlegroups.com.
>>> To view this discussion on the web visit 
>>> https://groups.google.com/d/msgid/jenkinsci-dev/CAKwJSvy-ozNe95WkobFbDEidjFz%3DzCeN2rVw_uY_YKY-21kHaw%40mail.gmail.com.
>> 
>> 
>> 
>> --
>> Michael Nazzareno Trimarchi
>> Co-Founder & Chief Executive Offic

Re: Adopt plugin openid-plugin

[Michael Nazzareno Trimarchi]

Hi

Solved this way

+
+  org.jenkins-ci.plugins
+  junit
+  1119.1121.vc43d0fc45561
+  test
+
+
+  org.jenkins-ci.plugins
+  script-security
+  1175.v4b_d517d6db_f0
+  test
+

Is this the correct way?

Michael

On Sun, Feb 18, 2024 at 9:05 PM Michael Nazzareno Trimarchi
 wrote:
>
> Hi all
>
> I have some lack of experience but how can I resolve a problem like this?
>
> 20:04:25  Caused by: java.io.IOException: Failed to load: Matrix
> Project Plugin (matrix-project 785.v06b_7f47b_c631)
> 20:04:25   - Update required: JUnit Plugin (junit 1.3) to be updated
> to 1119.1121.vc43d0fc45561 or higher
>
> Is something that is connected to the pom.xml?
>
> Michael
>
>
>
> On Sun, Feb 18, 2024 at 6:15 PM Adrien Lecharpentier
>  wrote:
> >
> > The jenkins.version you set in your pom requires java 11 minimum 
> > (https://www.jenkins.io/doc/book/platform-information/support-policy-java/).
> > However, the jenkinsfile still tries to build the plugin using java 8 on 
> > windows.
> >
> > As you are not the maintainer for now, changing the Jenkinsfile wouldn't 
> > change anything as it wouldn't be used.
> >
> > Once you're the maintainer, I'd suggested to open a pull request updating 
> > the jenkinsfile configuration (there is a open rewrite recipe to help you). 
> > Merge that PR and then you can work more deeply on the plugin.
> >
> > Le dim. 18 févr. 2024, 18:07, Michael Nazzareno Trimarchi 
> >  a écrit :
> >>
> >> Hi
> >>
> >> On Sun, Feb 18, 2024 at 5:56 PM Adrien Lecharpentier
> >>  wrote:
> >> >
> >> > Even if the plugin is not mark as up for adoption, it currently has no 
> >> > maintainer listed in the RPU. So +1 for me.
> >> >
> >> > Please note that the plugin has multiple public security issues. I'm 
> >> > sure the security team will require you to resolve them before any 
> >> > release can be deployed.
> >> >
> >>
> >> Ok I see, mostly my problem is even resolve CI build on jenkins CI too
> >>
> >> Michael
> >>
> >> > Le dim. 18 févr. 2024, 16:35, Michael Nazzareno Trimarchi 
> >> >  a écrit :
> >> >>
> >> >> Hi all
> >> >>
> >> >> https://github.com/jenkinsci/openid-plugin/pull/24
> >> >>
> >> >> My github account
> >> >> https://github.com/panicking
> >> >>
> >> >> Pull request for the permission
> >> >>
> >> >> https://github.com/jenkins-infra/repository-permissions-updater/pull/3776
> >> >>
> >> >> Michael
> >> >>
> >> >> --
> >> >> You received this message because you are subscribed to the Google 
> >> >> Groups "Jenkins Developers" group.
> >> >> To unsubscribe from this group and stop receiving emails from it, send 
> >> >> an email to jenkinsci-dev+unsubscr...@googlegroups.com.
> >> >> To view this discussion on the web visit 
> >> >> https://groups.google.com/d/msgid/jenkinsci-dev/CAOf5uwnO4r%2B-upaC-5wCMXbez-bsBd3LajxyU483ftm%2BMLYq2A%40mail.gmail.com.
> >> >
> >> > --
> >> > You received this message because you are subscribed to the Google 
> >> > Groups "Jenkins Developers" group.
> >> > To unsubscribe from this group and stop receiving emails from it, send 
> >> > an email to jenkinsci-dev+unsubscr...@googlegroups.com.
> >> > To view this discussion on the web visit 
> >> > https://groups.google.com/d/msgid/jenkinsci-dev/CAKwJSvyP%3DkpWEcumyRLhzYBrn4rfB9NguybafT4MwxnTq4f12g%40mail.gmail.com.
> >>
> >>
> >>
> >> --
> >> Michael Nazzareno Trimarchi
> >> Co-Founder & Chief Executive Officer
> >> M. +39 347 913 2170
> >> mich...@amarulasolutions.com
> >> __
> >>
> >> Amarula Solutions BV
> >> Joop Geesinkweg 125, 1114 AB, Amsterdam, NL
> >> T. +31 (0)85 111 9172
> >> i...@amarulasolutions.com
> >> www.amarulasolutions.com
> >>
> >> --
> >> You received this message because you are subscribed to the Google Groups 
> >> "Jenkins Developers" group.
> >> To unsubscribe from this group and stop receiving emails from it, send an 
> >> email to jenkinsci-dev+unsubscr...@googlegroups.com.
> >> To view this discussion on the web visit 
> >> https://groups.google.com/d/msgid/jenkinsci-dev/CAOf5uwnQTw0z2bO3RRK6xvorCNmBUojQirg%2BpDJR%2BS3h81RxCg%40mail.gmail.com.
> >
> > --
> > You received this message because you are subscribed to the Google Groups 
> > "Jenkins Developers" group.
> > To unsubscribe from this group and stop receiving emails from it, send an 
> > email to jenkinsci-dev+unsubscr...@googlegroups.com.
> > To view this discussion on the web visit 
> > https://groups.google.com/d/msgid/jenkinsci-dev/CAKwJSvy-ozNe95WkobFbDEidjFz%3DzCeN2rVw_uY_YKY-21kHaw%40mail.gmail.com.
>
>
>
> --
> Michael Nazzareno Trimarchi
> Co-Founder & Chief Executive Officer
> M. +39 347 913 2170
> mich...@amarulasolutions.com
> __
>
> Amarula Solutions BV
> Joop Geesinkweg 125, 1114 AB, Amsterdam, NL
> T. +31 (0)85 111 9172
> i...@amarulasolutions.com
> www.amarulasolutions.com



-- 
Michael Nazzareno Trimarchi
Co-Founder & Chief Executive Officer
M. +39 347 913 2170
mich...@amarulasolutions.com
_

Re: Adopt plugin openid-plugin

[Michael Nazzareno Trimarchi]

Hi all

I have some lack of experience but how can I resolve a problem like this?

20:04:25  Caused by: java.io.IOException: Failed to load: Matrix
Project Plugin (matrix-project 785.v06b_7f47b_c631)
20:04:25   - Update required: JUnit Plugin (junit 1.3) to be updated
to 1119.1121.vc43d0fc45561 or higher

Is something that is connected to the pom.xml?

Michael



On Sun, Feb 18, 2024 at 6:15 PM Adrien Lecharpentier
 wrote:
>
> The jenkins.version you set in your pom requires java 11 minimum 
> (https://www.jenkins.io/doc/book/platform-information/support-policy-java/).
> However, the jenkinsfile still tries to build the plugin using java 8 on 
> windows.
>
> As you are not the maintainer for now, changing the Jenkinsfile wouldn't 
> change anything as it wouldn't be used.
>
> Once you're the maintainer, I'd suggested to open a pull request updating the 
> jenkinsfile configuration (there is a open rewrite recipe to help you). Merge 
> that PR and then you can work more deeply on the plugin.
>
> Le dim. 18 févr. 2024, 18:07, Michael Nazzareno Trimarchi 
>  a écrit :
>>
>> Hi
>>
>> On Sun, Feb 18, 2024 at 5:56 PM Adrien Lecharpentier
>>  wrote:
>> >
>> > Even if the plugin is not mark as up for adoption, it currently has no 
>> > maintainer listed in the RPU. So +1 for me.
>> >
>> > Please note that the plugin has multiple public security issues. I'm sure 
>> > the security team will require you to resolve them before any release can 
>> > be deployed.
>> >
>>
>> Ok I see, mostly my problem is even resolve CI build on jenkins CI too
>>
>> Michael
>>
>> > Le dim. 18 févr. 2024, 16:35, Michael Nazzareno Trimarchi 
>> >  a écrit :
>> >>
>> >> Hi all
>> >>
>> >> https://github.com/jenkinsci/openid-plugin/pull/24
>> >>
>> >> My github account
>> >> https://github.com/panicking
>> >>
>> >> Pull request for the permission
>> >>
>> >> https://github.com/jenkins-infra/repository-permissions-updater/pull/3776
>> >>
>> >> Michael
>> >>
>> >> --
>> >> You received this message because you are subscribed to the Google Groups 
>> >> "Jenkins Developers" group.
>> >> To unsubscribe from this group and stop receiving emails from it, send an 
>> >> email to jenkinsci-dev+unsubscr...@googlegroups.com.
>> >> To view this discussion on the web visit 
>> >> https://groups.google.com/d/msgid/jenkinsci-dev/CAOf5uwnO4r%2B-upaC-5wCMXbez-bsBd3LajxyU483ftm%2BMLYq2A%40mail.gmail.com.
>> >
>> > --
>> > You received this message because you are subscribed to the Google Groups 
>> > "Jenkins Developers" group.
>> > To unsubscribe from this group and stop receiving emails from it, send an 
>> > email to jenkinsci-dev+unsubscr...@googlegroups.com.
>> > To view this discussion on the web visit 
>> > https://groups.google.com/d/msgid/jenkinsci-dev/CAKwJSvyP%3DkpWEcumyRLhzYBrn4rfB9NguybafT4MwxnTq4f12g%40mail.gmail.com.
>>
>>
>>
>> --
>> Michael Nazzareno Trimarchi
>> Co-Founder & Chief Executive Officer
>> M. +39 347 913 2170
>> mich...@amarulasolutions.com
>> __
>>
>> Amarula Solutions BV
>> Joop Geesinkweg 125, 1114 AB, Amsterdam, NL
>> T. +31 (0)85 111 9172
>> i...@amarulasolutions.com
>> www.amarulasolutions.com
>>
>> --
>> You received this message because you are subscribed to the Google Groups 
>> "Jenkins Developers" group.
>> To unsubscribe from this group and stop receiving emails from it, send an 
>> email to jenkinsci-dev+unsubscr...@googlegroups.com.
>> To view this discussion on the web visit 
>> https://groups.google.com/d/msgid/jenkinsci-dev/CAOf5uwnQTw0z2bO3RRK6xvorCNmBUojQirg%2BpDJR%2BS3h81RxCg%40mail.gmail.com.
>
> --
> You received this message because you are subscribed to the Google Groups 
> "Jenkins Developers" group.
> To unsubscribe from this group and stop receiving emails from it, send an 
> email to jenkinsci-dev+unsubscr...@googlegroups.com.
> To view this discussion on the web visit 
> https://groups.google.com/d/msgid/jenkinsci-dev/CAKwJSvy-ozNe95WkobFbDEidjFz%3DzCeN2rVw_uY_YKY-21kHaw%40mail.gmail.com.



-- 
Michael Nazzareno Trimarchi
Co-Founder & Chief Executive Officer
M. +39 347 913 2170
mich...@amarulasolutions.com
__

Amarula Solutions BV
Joop Geesinkweg 125, 1114 AB, Amsterdam, NL
T. +31 (0)85 111 9172
i...@amarulasolutions.com
www.amarulasolutions.com

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/CAOf5uwnCWy-PfNvjg3AeAQX8s0f9ooV_WmUkJMZJxDURwA_kgQ%40mail.gmail.com.

Re: Adopt plugin openid-plugin

[Adrien Lecharpentier]

The jenkins.version you set in your pom requires java 11 minimum (
https://www.jenkins.io/doc/book/platform-information/support-policy-java/).
However, the jenkinsfile still tries to build the plugin using java 8 on
windows.

As you are not the maintainer for now, changing the Jenkinsfile wouldn't
change anything as it wouldn't be used.

Once you're the maintainer, I'd suggested to open a pull request updating
the jenkinsfile configuration (there is a open rewrite recipe to help you).
Merge that PR and then you can work more deeply on the plugin.

Le dim. 18 févr. 2024, 18:07, Michael Nazzareno Trimarchi <
mich...@amarulasolutions.com> a écrit :

> Hi
>
> On Sun, Feb 18, 2024 at 5:56 PM Adrien Lecharpentier
>  wrote:
> >
> > Even if the plugin is not mark as up for adoption, it currently has no
> maintainer listed in the RPU. So +1 for me.
> >
> > Please note that the plugin has multiple public security issues. I'm
> sure the security team will require you to resolve them before any release
> can be deployed.
> >
>
> Ok I see, mostly my problem is even resolve CI build on jenkins CI too
>
> Michael
>
> > Le dim. 18 févr. 2024, 16:35, Michael Nazzareno Trimarchi <
> mich...@amarulasolutions.com> a écrit :
> >>
> >> Hi all
> >>
> >> https://github.com/jenkinsci/openid-plugin/pull/24
> >>
> >> My github account
> >> https://github.com/panicking
> >>
> >> Pull request for the permission
> >>
> >>
> https://github.com/jenkins-infra/repository-permissions-updater/pull/3776
> >>
> >> Michael
> >>
> >> --
> >> You received this message because you are subscribed to the Google
> Groups "Jenkins Developers" group.
> >> To unsubscribe from this group and stop receiving emails from it, send
> an email to jenkinsci-dev+unsubscr...@googlegroups.com.
> >> To view this discussion on the web visit
> https://groups.google.com/d/msgid/jenkinsci-dev/CAOf5uwnO4r%2B-upaC-5wCMXbez-bsBd3LajxyU483ftm%2BMLYq2A%40mail.gmail.com
> .
> >
> > --
> > You received this message because you are subscribed to the Google
> Groups "Jenkins Developers" group.
> > To unsubscribe from this group and stop receiving emails from it, send
> an email to jenkinsci-dev+unsubscr...@googlegroups.com.
> > To view this discussion on the web visit
> https://groups.google.com/d/msgid/jenkinsci-dev/CAKwJSvyP%3DkpWEcumyRLhzYBrn4rfB9NguybafT4MwxnTq4f12g%40mail.gmail.com
> .
>
>
>
> --
> Michael Nazzareno Trimarchi
> Co-Founder & Chief Executive Officer
> M. +39 347 913 2170
> mich...@amarulasolutions.com
> __
>
> Amarula Solutions BV
> Joop Geesinkweg 125, 1114 AB, Amsterdam, NL
> T. +31 (0)85 111 9172
> i...@amarulasolutions.com
> www.amarulasolutions.com
>
> --
> You received this message because you are subscribed to the Google Groups
> "Jenkins Developers" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to jenkinsci-dev+unsubscr...@googlegroups.com.
> To view this discussion on the web visit
> https://groups.google.com/d/msgid/jenkinsci-dev/CAOf5uwnQTw0z2bO3RRK6xvorCNmBUojQirg%2BpDJR%2BS3h81RxCg%40mail.gmail.com
> .
>

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/CAKwJSvy-ozNe95WkobFbDEidjFz%3DzCeN2rVw_uY_YKY-21kHaw%40mail.gmail.com.

Re: Adopt plugin openid-plugin

[Michael Nazzareno Trimarchi]

Hi

On Sun, Feb 18, 2024 at 5:56 PM Adrien Lecharpentier
 wrote:
>
> Even if the plugin is not mark as up for adoption, it currently has no 
> maintainer listed in the RPU. So +1 for me.
>
> Please note that the plugin has multiple public security issues. I'm sure the 
> security team will require you to resolve them before any release can be 
> deployed.
>

Ok I see, mostly my problem is even resolve CI build on jenkins CI too

Michael

> Le dim. 18 févr. 2024, 16:35, Michael Nazzareno Trimarchi 
>  a écrit :
>>
>> Hi all
>>
>> https://github.com/jenkinsci/openid-plugin/pull/24
>>
>> My github account
>> https://github.com/panicking
>>
>> Pull request for the permission
>>
>> https://github.com/jenkins-infra/repository-permissions-updater/pull/3776
>>
>> Michael
>>
>> --
>> You received this message because you are subscribed to the Google Groups 
>> "Jenkins Developers" group.
>> To unsubscribe from this group and stop receiving emails from it, send an 
>> email to jenkinsci-dev+unsubscr...@googlegroups.com.
>> To view this discussion on the web visit 
>> https://groups.google.com/d/msgid/jenkinsci-dev/CAOf5uwnO4r%2B-upaC-5wCMXbez-bsBd3LajxyU483ftm%2BMLYq2A%40mail.gmail.com.
>
> --
> You received this message because you are subscribed to the Google Groups 
> "Jenkins Developers" group.
> To unsubscribe from this group and stop receiving emails from it, send an 
> email to jenkinsci-dev+unsubscr...@googlegroups.com.
> To view this discussion on the web visit 
> https://groups.google.com/d/msgid/jenkinsci-dev/CAKwJSvyP%3DkpWEcumyRLhzYBrn4rfB9NguybafT4MwxnTq4f12g%40mail.gmail.com.



-- 
Michael Nazzareno Trimarchi
Co-Founder & Chief Executive Officer
M. +39 347 913 2170
mich...@amarulasolutions.com
__

Amarula Solutions BV
Joop Geesinkweg 125, 1114 AB, Amsterdam, NL
T. +31 (0)85 111 9172
i...@amarulasolutions.com
www.amarulasolutions.com

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/CAOf5uwnQTw0z2bO3RRK6xvorCNmBUojQirg%2BpDJR%2BS3h81RxCg%40mail.gmail.com.

Re: Adopt plugin openid-plugin

[Adrien Lecharpentier]

Even if the plugin is not mark as up for adoption, it currently has no
maintainer listed in the RPU. So +1 for me.

Please note that the plugin has multiple public security issues. I'm sure
the security team will require you to resolve them before any release can
be deployed.

Le dim. 18 févr. 2024, 16:35, Michael Nazzareno Trimarchi <
mich...@amarulasolutions.com> a écrit :

> Hi all
>
> https://github.com/jenkinsci/openid-plugin/pull/24
>
> My github account
> https://github.com/panicking
>
> Pull request for the permission
>
> https://github.com/jenkins-infra/repository-permissions-updater/pull/3776
>
> Michael
>
> --
> You received this message because you are subscribed to the Google Groups
> "Jenkins Developers" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to jenkinsci-dev+unsubscr...@googlegroups.com.
> To view this discussion on the web visit
> https://groups.google.com/d/msgid/jenkinsci-dev/CAOf5uwnO4r%2B-upaC-5wCMXbez-bsBd3LajxyU483ftm%2BMLYq2A%40mail.gmail.com
> .
>

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/CAKwJSvyP%3DkpWEcumyRLhzYBrn4rfB9NguybafT4MwxnTq4f12g%40mail.gmail.com.

Proposal: Stefan Spieker to join the core PR reviewers team

['Alexander Brandes' via Jenkins Developers]

Hey everyone,

I would like to propose Stefan Spieker (@StefanSpieker 
) to join the core PR reviewers team.

Stefan has been a core contributor since October 2022, and filed 172 
 pull 
requests, where 171 PRs have been merged.
Additionally, he has been active in reviewing core PRs and has voiced his 
opinion in almost 300 
 
pull requests.

I would welcome him as an addition to the core pr team :)

Best,
Alex

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/C1B318DE-5D1F-44F9-B0D3-2CE7CF584352%40notmyfault.dev.

Adopt plugin openid-plugin

[Michael Nazzareno Trimarchi]

Hi all

https://github.com/jenkinsci/openid-plugin/pull/24

My github account
https://github.com/panicking

Pull request for the permission

https://github.com/jenkins-infra/repository-permissions-updater/pull/3776

Michael

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/CAOf5uwnO4r%2B-upaC-5wCMXbez-bsBd3LajxyU483ftm%2BMLYq2A%40mail.gmail.com.