Re: Grant timja immediate permissions to commons-lang3-api plugin

2022-07-18 Thread Raihaan Shouhell
+1

This is break is quite severe

Cheers,
Raihaan

On Tue, Jul 19, 2022, 1:20 PM Basil Crow  wrote:

> +UINT64_MAX
>
> On Mon, Jul 18, 2022 at 8:31 PM Mark Waite 
> wrote:
>
>> A release of the Apache mina API plugins (core and common) have exposed a
>> cyclic dependency between the mina plugins, configuration as code, and
>> other plugins.  Details are into from
>> https://issues.jenkins.io/browse/JENKINS-69034
>>  .
>> A workaround is available, but a fix would be much better for users than
>> the workaround.
>>
>> The preferred fix needs a new release of the commons-lang3-api plugin
>> .  The current
>> maintainer has not responded to previous requests nor to the current
>> request
>> 
>> that asks to grant Tim Jacomb permission to maintain the plugin.
>>
>> The usual process would require a 2 week wait for the adoption request to
>> "time out".  I propose an exception in this case based on the need to
>> deliver a new release of the commons-lang3-api-plugin.  Tim is the Jenkins
>> release officer, a long-standing contributor to the Jenkins project, and a
>> strong contributor.
>>
>> I propose that Tim be granted permission immediately to maintain the  
>> commons-lang3-api
>> plugin  as
>> requested in the RPU pull request
>> 
>> .
>>
>> Mark Waite
>>
>> --
>> You received this message because you are subscribed to the Google Groups
>> "Jenkins Developers" group.
>> To unsubscribe from this group and stop receiving emails from it, send an
>> email to jenkinsci-dev+unsubscr...@googlegroups.com.
>> To view this discussion on the web visit
>> https://groups.google.com/d/msgid/jenkinsci-dev/d7ca0365-4600-4097-8dd4-d3c9f93e5327n%40googlegroups.com
>> 
>> .
>>
> --
> You received this message because you are subscribed to the Google Groups
> "Jenkins Developers" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to jenkinsci-dev+unsubscr...@googlegroups.com.
> To view this discussion on the web visit
> https://groups.google.com/d/msgid/jenkinsci-dev/CAFwNDjrbhAkTTe48on0nY105HbZJCrOx8Yt5MS%3Ddf%3D0sL1Pm4A%40mail.gmail.com
> 
> .
>

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/CAFoxvgw2%2Bdk9UjUOits7hvF4M-qK_H5RLXJHqaEpjwmASa3VLA%40mail.gmail.com.


Re: 2.303.3 release lead

2021-10-17 Thread Raihaan Shouhell
https://issues.jenkins.io/browse/JENKINS-61212 does not seem to have
confirmation that the issue is resolved.
https://issues.jenkins.io/browse/JENKINS-66613 seems reasonable to me.
Marking it with lts-candidate, will be backporting this.

Cheers,
Raihaan

On Sun, Oct 17, 2021 at 9:57 PM Oleg Nenashev 
wrote:

>
> It would be nice to have https://issues.jenkins.io/browse/JENKINS-61212
> integrated since we package Java 11 by default in Docker
> https://issues.jenkins.io/browse/JENKINS-66613 is IMHO reasonable too.
>
> I have no access to Jira but I will try to scrub the recent reports
>
> FWIW, it seems we are missing a few weekly release steps with the current
> process - resolving Jira issues and marking defects for backporting if
> seems reasonable
>
> BR, Oleg
>
>
> On Sunday, October 17, 2021 at 3:41:38 PM UTC+2 timja...@gmail.com wrote:
>
>> Shall we cancel the release then if there's nothing to add?
>>
>> On Thu, 14 Oct 2021 at 11:37, Raihaan Shouhell 
>> wrote:
>>
>>> Our lts-candidate filter seems to be without issues.
>>>
>>> https://issues.jenkins-ci.org/issues/?filter=12146
>>>
>>> Our regression fix PRs is also dry of new issues
>>> https://github.com/jenkinsci/jenkins/pulls?q=is%3Apr+label%3Aregression-fix+is%3Aclosed
>>>
>>> Does anyone have any candidates for backport?
>>>
>>> Cheers,
>>> Raihaan
>>>
>>> On Thu, Oct 14, 2021 at 4:07 PM Oleg Nenashev 
>>> wrote:
>>>
>>>> Thank you!
>>>>
>>>> On Wednesday, October 13, 2021 at 2:41:44 PM UTC+2 timja...@gmail.com
>>>> wrote:
>>>>
>>>>> Thanks!
>>>>>
>>>>> (libera IRC, not freenode, copied from an old email -.-)
>>>>>
>>>>> On Wed, 13 Oct 2021 at 13:32, Raihaan Shouhell 
>>>>> wrote:
>>>>>
>>>>>> Sure I'll take it
>>>>>>
>>>>>> Cheers,
>>>>>> Raihaan
>>>>>>
>>>>>> On Wed, Oct 13, 2021, 8:22 PM Tim Jacomb  wrote:
>>>>>>
>>>>>>> Hello
>>>>>>>
>>>>>>> Is anyone interested in being the release lead for 2.303.3?
>>>>>>>
>>>>>>> Planned dates can be seen on the event calendar:
>>>>>>> https://www.jenkins.io/events/#event-calendar
>>>>>>> Release candidate by 20th October
>>>>>>> Release on 3rd November
>>>>>>>
>>>>>>> The documentation is at:
>>>>>>> https://github.com/jenkins-infra/release
>>>>>>> /blob/master/.github/ISSUE_TEMPLATE/1-lts-release-checklist.md
>>>>>>>
>>>>>>> I'll be available to answer any questions and provide guidance
>>>>>>> (along with hopefully other past release leads)
>>>>>>>
>>>>>>> We chat in #jenkins-release on freenode IRC,
>>>>>>> https://www.jenkins.io/chat/#jenkins-release
>>>>>>>
>>>>>>> Anyone interested?
>>>>>>>
>>>>>>> Thanks
>>>>>>> Tim
>>>>>>>
>>>>>>> --
>>>>>>> You received this message because you are subscribed to the Google
>>>>>>> Groups "Jenkins Developers" group.
>>>>>>> To unsubscribe from this group and stop receiving emails from it,
>>>>>>> send an email to jenkinsci-de...@googlegroups.com.
>>>>>>> To view this discussion on the web visit
>>>>>>> https://groups.google.com/d/msgid/jenkinsci-dev/CAH-3BidLkUsXcz%3DnE%2BK1useR3r63imzJ0gLtdTX%2BS%2BTRYa64mA%40mail.gmail.com
>>>>>>> <https://groups.google.com/d/msgid/jenkinsci-dev/CAH-3BidLkUsXcz%3DnE%2BK1useR3r63imzJ0gLtdTX%2BS%2BTRYa64mA%40mail.gmail.com?utm_medium=email_source=footer>
>>>>>>> .
>>>>>>>
>>>>>> --
>>>>>> You received this message because you are subscribed to the Google
>>>>>> Groups "Jenkins Developers" group.
>>>>>> To unsubscribe from this group and stop receiving emails from it,
>>>>>> send an email to jenkinsci-de...@googlegroups.com.
>>>>>>
>>>>> To view this discussion on the web visit
>>>>>> https://groups.google.com/d/msgid/jenkinsci-dev/CAFoxvgwJE8rR2VvWPqvFFrRiM_AUOhEpX-N

Re: 2.303.3 release lead

2021-10-14 Thread Raihaan Shouhell
Our lts-candidate filter seems to be without issues.

https://issues.jenkins-ci.org/issues/?filter=12146

Our regression fix PRs is also dry of new issues
https://github.com/jenkinsci/jenkins/pulls?q=is%3Apr+label%3Aregression-fix+is%3Aclosed

Does anyone have any candidates for backport?

Cheers,
Raihaan

On Thu, Oct 14, 2021 at 4:07 PM Oleg Nenashev 
wrote:

> Thank you!
>
> On Wednesday, October 13, 2021 at 2:41:44 PM UTC+2 timja...@gmail.com
> wrote:
>
>> Thanks!
>>
>> (libera IRC, not freenode, copied from an old email -.-)
>>
>> On Wed, 13 Oct 2021 at 13:32, Raihaan Shouhell 
>> wrote:
>>
>>> Sure I'll take it
>>>
>>> Cheers,
>>> Raihaan
>>>
>>> On Wed, Oct 13, 2021, 8:22 PM Tim Jacomb  wrote:
>>>
>>>> Hello
>>>>
>>>> Is anyone interested in being the release lead for 2.303.3?
>>>>
>>>> Planned dates can be seen on the event calendar:
>>>> https://www.jenkins.io/events/#event-calendar
>>>> Release candidate by 20th October
>>>> Release on 3rd November
>>>>
>>>> The documentation is at:
>>>> https://github.com/jenkins-infra/release
>>>> /blob/master/.github/ISSUE_TEMPLATE/1-lts-release-checklist.md
>>>>
>>>> I'll be available to answer any questions and provide guidance (along
>>>> with hopefully other past release leads)
>>>>
>>>> We chat in #jenkins-release on freenode IRC,
>>>> https://www.jenkins.io/chat/#jenkins-release
>>>>
>>>> Anyone interested?
>>>>
>>>> Thanks
>>>> Tim
>>>>
>>>> --
>>>> You received this message because you are subscribed to the Google
>>>> Groups "Jenkins Developers" group.
>>>> To unsubscribe from this group and stop receiving emails from it, send
>>>> an email to jenkinsci-de...@googlegroups.com.
>>>> To view this discussion on the web visit
>>>> https://groups.google.com/d/msgid/jenkinsci-dev/CAH-3BidLkUsXcz%3DnE%2BK1useR3r63imzJ0gLtdTX%2BS%2BTRYa64mA%40mail.gmail.com
>>>> <https://groups.google.com/d/msgid/jenkinsci-dev/CAH-3BidLkUsXcz%3DnE%2BK1useR3r63imzJ0gLtdTX%2BS%2BTRYa64mA%40mail.gmail.com?utm_medium=email_source=footer>
>>>> .
>>>>
>>> --
>>> You received this message because you are subscribed to the Google
>>> Groups "Jenkins Developers" group.
>>> To unsubscribe from this group and stop receiving emails from it, send
>>> an email to jenkinsci-de...@googlegroups.com.
>>>
>> To view this discussion on the web visit
>>> https://groups.google.com/d/msgid/jenkinsci-dev/CAFoxvgwJE8rR2VvWPqvFFrRiM_AUOhEpX-Nq3233LagzBSovuw%40mail.gmail.com
>>> <https://groups.google.com/d/msgid/jenkinsci-dev/CAFoxvgwJE8rR2VvWPqvFFrRiM_AUOhEpX-Nq3233LagzBSovuw%40mail.gmail.com?utm_medium=email_source=footer>
>>> .
>>>
>> --
> You received this message because you are subscribed to the Google Groups
> "Jenkins Developers" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to jenkinsci-dev+unsubscr...@googlegroups.com.
> To view this discussion on the web visit
> https://groups.google.com/d/msgid/jenkinsci-dev/aedaa5af-d3ac-4e4b-8fa4-18a74f2b0279n%40googlegroups.com
> <https://groups.google.com/d/msgid/jenkinsci-dev/aedaa5af-d3ac-4e4b-8fa4-18a74f2b0279n%40googlegroups.com?utm_medium=email_source=footer>
> .
>

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/CAFoxvgwyrDJ4aR1m%3Dh%2BXbMrFK1fwjVrRm0qj26GS1ZxDpN%3DOjw%40mail.gmail.com.


Re: 2.303.3 release lead

2021-10-13 Thread Raihaan Shouhell
Sure I'll take it

Cheers,
Raihaan

On Wed, Oct 13, 2021, 8:22 PM Tim Jacomb  wrote:

> Hello
>
> Is anyone interested in being the release lead for 2.303.3?
>
> Planned dates can be seen on the event calendar:
> https://www.jenkins.io/events/#event-calendar
> Release candidate by 20th October
> Release on 3rd November
>
> The documentation is at:
> https://github.com/jenkins-infra/release
> /blob/master/.github/ISSUE_TEMPLATE/1-lts-release-checklist.md
>
> I'll be available to answer any questions and provide guidance (along with
> hopefully other past release leads)
>
> We chat in #jenkins-release on freenode IRC,
> https://www.jenkins.io/chat/#jenkins-release
>
> Anyone interested?
>
> Thanks
> Tim
>
> --
> You received this message because you are subscribed to the Google Groups
> "Jenkins Developers" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to jenkinsci-dev+unsubscr...@googlegroups.com.
> To view this discussion on the web visit
> https://groups.google.com/d/msgid/jenkinsci-dev/CAH-3BidLkUsXcz%3DnE%2BK1useR3r63imzJ0gLtdTX%2BS%2BTRYa64mA%40mail.gmail.com
> 
> .
>

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/CAFoxvgwJE8rR2VvWPqvFFrRiM_AUOhEpX-Nq3233LagzBSovuw%40mail.gmail.com.


Re: Proposal: Adding Basil Crow to the Jenkins Core maintainers team

2021-09-23 Thread Raihaan Shouhell
+1 he has been leading the charge on a variety of improvements

On Thu, Sep 23, 2021, 4:25 PM Baptiste Mathus  wrote:

> +1. IMO Basil is wa past the minimum criteria to get this status.
>
> Le mer. 22 sept. 2021 à 11:14, Oleg Nenashev  a
> écrit :
>
>> Dear all,
>>
>> Basil has been a very active contributor to the Jenkins core since 2020,
>> and he has contributed a lot to Jenkins over the past several years. He is
>> an active community member, and he helps a lot with the technical debt
>> cleanup and code reviews in Jenkins.
>>
>> It would be great to have Basil joining the Jenkins core maintainers
>> team. I propose to officially add Basil to the Jenkins core team. IMHO the
>> code reviewer stage can be skipped, because he has been already
>> contributing a lot to the reviews. Opinions/votes?
>>
>> References:
>>
>>- https://github.com/basil
>>- Jenkins core maintainers team and ladder:
>>
>> https://github.com/jenkinsci/jenkins/blob/master/docs/MAINTAINERS.adoc#team
>>
>> Best regards,
>> Oleg Nenashev
>>
>> --
>> You received this message because you are subscribed to the Google Groups
>> "Jenkins Developers" group.
>> To unsubscribe from this group and stop receiving emails from it, send an
>> email to jenkinsci-dev+unsubscr...@googlegroups.com.
>> To view this discussion on the web visit
>> https://groups.google.com/d/msgid/jenkinsci-dev/0c920f79-f7b7-4299-92d7-15a814821632n%40googlegroups.com
>> 
>> .
>>
> --
> You received this message because you are subscribed to the Google Groups
> "Jenkins Developers" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to jenkinsci-dev+unsubscr...@googlegroups.com.
> To view this discussion on the web visit
> https://groups.google.com/d/msgid/jenkinsci-dev/CANWgJS55rBhwXNumbJL2rLRa1cc4h%2BpjLgiM00n%2BByBLsxf9fw%40mail.gmail.com
> 
> .
>

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/CAFoxvgy%3D%3Dx0C6nibxugptU_Mm3p2zaKHNdn%3Dv6%3D7yBpwPDsSOw%40mail.gmail.com.


Re: LTS 2.289.1 RC

2021-05-21 Thread Raihaan Shouhell
Hey all,

The change has been cherry picked back into lts.

Here is an updated RC
https://repo.jenkins-ci.org/snapshots/org/jenkins-ci/main/jenkins-war/2.289.1-SNAPSHOT/jenkins-war-2.289.1-20210521.105612-2.war

Happy Friday

Cheers,
Raihaan

On Thu, May 20, 2021 at 7:05 PM jn...@cloudbees.com 
wrote:

> There is a regression with CLI SSH auth (sorry for saying this late, I
> thought it was already reported).
>
> I have a PR that fixes this (at least the CLITest in the 3.0.3 sshd-plugin
> passes with https://github.com/jenkinsci/jenkins/pull/5506 cherry picked
> in to the LTS branch).
>
> Would be good to get eyes on that with a possibility to cherry pick into
> this LTS.
>
> /James
>
> On Wednesday, May 19, 2021 at 3:25:53 PM UTC+1 raihaan...@gmail.com wrote:
>
>> Hey everyone,
>>
>> The RC is available:
>>
>>
>> https://repo.jenkins-ci.org/snapshots/org/jenkins-ci/main/jenkins-war/2.289.1-SNAPSHOT/jenkins-war-2.289.1-20210519.141720-1.war
>>
>> Cheers,
>> Raihaan
>>
> --
> You received this message because you are subscribed to a topic in the
> Google Groups "Jenkins Developers" group.
> To unsubscribe from this topic, visit
> https://groups.google.com/d/topic/jenkinsci-dev/RZwGKBky7Yo/unsubscribe.
> To unsubscribe from this group and all its topics, send an email to
> jenkinsci-dev+unsubscr...@googlegroups.com.
> To view this discussion on the web visit
> https://groups.google.com/d/msgid/jenkinsci-dev/2c5815b5-4392-4e4c-a833-553668b9d22dn%40googlegroups.com
> 
> .
>

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/CAFoxvgzi7zVfGm49PxkfU%2BV7BfXQfHZ69un9gCPt%3DW2f-4-45w%40mail.gmail.com.


Re: Using JDK 11 instead of JDK 8 in default docker images

2021-04-27 Thread Raihaan Shouhell
Perhaps removal of java 8 support should come with a bump in major version
number so jenkins 3.x and an announcement ahead of time.

Cheers,
Raihaan

On Wed, Apr 28, 2021, 7:42 AM Oleg Nenashev  wrote:

> I am in favor of making JDK11 the default in all our distributions,
> including controller and agent Docker images.
> At the same time I am afraid that removal of Java 1.8 support is
> premature. The vast majority of Jenkins users still uses this version, and
> the migration to Java 11 won't be seamless in al l cases. For example,
> Maven Plugin will effectively switch project builds to Java 11 once the
> agent images are updated. It will cause unexpected issues in user builds
> here and there. Nothing should be critical, but we should not force users
> to migrate immediately.
>
> IMHO there should be a grace period between Java 8 support deprecation and
> the actual removal. Maybe 6 months or so.
>
> BR, Oleg
>
> On Tuesday, April 27, 2021 at 7:13:17 PM UTC+2 slide wrote:
>
>> I agree with dropping java 8. There are some nice features in 11 that
>> would be good to use.
>>
>> On Tue, Apr 27, 2021 at 9:11 AM Tim Jacomb  wrote:
>>
>>> We’ve been using it for over a year on java 11 and never hit an issue...
>>>
>>> I would rather drop java 8 as well
>>>
>>> On Tue, 27 Apr 2021 at 15:48, Jesse Glick  wrote:
>>>
 My opinion remains that if we believe Java 11 support is solid enough
 to be the default, then we may as well keep things simple and drop Java 8
 support: start building core and important plugins with `java.level=11`,
 and take advantage of its features. Building and testing primarily against
 8 while pushing users to run 11, and forcing developers to consider both
 platforms in every situation, seems like the worst decision.

 --
 You received this message because you are subscribed to the Google
 Groups "Jenkins Developers" group.
 To unsubscribe from this group and stop receiving emails from it, send
 an email to jenkinsci-de...@googlegroups.com.
 To view this discussion on the web visit
 https://groups.google.com/d/msgid/jenkinsci-dev/CANfRfr2hjuPWgK7XqzwezcT8eP1i1_ZZd_iMNreg%3D7K7FTzH8Q%40mail.gmail.com
 
 .

>>> --
>>> You received this message because you are subscribed to the Google
>>> Groups "Jenkins Developers" group.
>>> To unsubscribe from this group and stop receiving emails from it, send
>>> an email to jenkinsci-de...@googlegroups.com.
>>>
>> To view this discussion on the web visit
>>> https://groups.google.com/d/msgid/jenkinsci-dev/CAH-3BifVe04fx-7vx6Dp-jkLmTvepCDGHXqRDLEWdHyNN8TG%3Dw%40mail.gmail.com
>>> 
>>> .
>>>
>>
>>
>> --
>> Website: http://earl-of-code.com
>>
> --
> You received this message because you are subscribed to the Google Groups
> "Jenkins Developers" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to jenkinsci-dev+unsubscr...@googlegroups.com.
> To view this discussion on the web visit
> https://groups.google.com/d/msgid/jenkinsci-dev/74c9f96d-1acc-4315-9fd5-e59bb6fdeff8n%40googlegroups.com
> 
> .
>

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/CAFoxvgwycdrsK9dX-A7KVcA%2Bi%3Dta6dhc4iZbVAz%2BRKv3dn5Ymg%40mail.gmail.com.


Re: Jenkins LTS baseline selection

2021-04-20 Thread Raihaan Shouhell
Hey Tim,

I'm entirely for 2.289 as 2.289 does not make any major changes and as
Daniel has pointed out, we can backport any fixes.

Cheers,
Raihaan

On Tue, Apr 20, 2021 at 4:17 PM Baptiste Mathus  wrote:

> Thanks for raising this Tim.
> As I've written on IRC, as long as we choose 2.288+, I'm happy :).
>
> Can you please confirm the expected timeline, so we can better assess
> things?
> Re-reading https://www.jenkins.io/download/lts/ we're looking at a .1 6
> weeks from now, i.e. some time around 2021-06-02 right ?
>
> If so, I agree even choosing the upcoming 2.289 could be acceptable with
> such a testing period.
>
> -- Baptiste
>
>
>
>
> Given the expected usua
>
>
>
> Le mar. 20 avr. 2021 à 08:53, Tim Jacomb  a écrit :
>
>> Hello everyone,
>>
>> Please voice your opinion on which version should be our next core
>> baseline.
>>
>> For me it looks like either 2.288 or 2.289 are the options
>>
>> 2.289 (being released today) includes a change for an upcoming firefox
>> version so it would be good to get it in, but it hasn't had any weekly
>> soaking time so we could use 2.288 and then backport it in if we don't find
>> any issues?
>>
>> What do you think?
>>
>> Thanks
>> Tim
>>
>> --
>> You received this message because you are subscribed to the Google Groups
>> "Jenkins Developers" group.
>> To unsubscribe from this group and stop receiving emails from it, send an
>> email to jenkinsci-dev+unsubscr...@googlegroups.com.
>> To view this discussion on the web visit
>> https://groups.google.com/d/msgid/jenkinsci-dev/CAH-3BidOjTQoUe7Y4q7m-9hp_UN6JX9t1xNyQTdhwNk3M1LqVg%40mail.gmail.com
>> 
>> .
>>
> --
> You received this message because you are subscribed to the Google Groups
> "Jenkins Developers" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to jenkinsci-dev+unsubscr...@googlegroups.com.
> To view this discussion on the web visit
> https://groups.google.com/d/msgid/jenkinsci-dev/CANWgJS7o6mGZttw4uo2r2RNqHnf7haaSFVmPcUEsphV7ynwkeA%40mail.gmail.com
> 
> .
>

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/CAFoxvgxhKh_v1YRrniinWfJJBx1%3DOqtjEg14aUH3d_EU8VwM7g%40mail.gmail.com.


2.222.x LTS missing backport of JENKINS-61197

2020-06-01 Thread Raihaan Shouhell
Hey all,

I've recently upgraded masters to the 2.222.x line and ran into an issue 
where a build that was using a filesystem root workspace will throw a null 
pointer exception.

Some quick investigation revealed 
https://issues.jenkins-ci.org/browse/JENKINS-61197 which states 
2.222.1-fixed but the bug exists in my instance running 2.222.3,

Inspecting the 2.222.1 tag reveals that the bug still exists and was not 
backported 
https://github.com/jenkinsci/jenkins/blob/d66bd8595e531749e842274a806eabab5cc16a32/core/src/main/java/hudson/model/AbstractBuild.java#L866-L869

Cheers,
Raihaan

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/cf75cc3f-4d91-4822-a61c-f0706e8e85fa%40googlegroups.com.


Re: Jenkins Release Automation project: Jenkins Code Signing Certificate

2020-03-26 Thread Raihaan Shouhell
That really is great news, the release pipeline does LTS as well?

Great job, and thanks for all your efforts.

Cheers,
Raihaan

On Thu, Mar 26, 2020 at 4:47 AM Jeff Thompson 
wrote:

> This is great news!
> On 3/25/20 2:09 PM, Olblak wrote:
>
> Hello,
>
> I am happy to share that I received a code signing certificate for the
> Jenkins project, so the next step is to update the release environment with
> the right code signing certificate and the right gpg key, verify that they
> are in a safe location (both on Azure Key vault) and then finalize the
> publishing part.
>
> Quick reminder on the current state of this project.
>
> I deployed a specific Jenkins instance in the vpn, it's called
> release.ci.jenkins.io. This instance is configured with two jobs one to
> trigger release and a second one to trigger packaging for a specific
> release for debian,redhat,suse, msi
>
> release.ci.jenkins.io configuration is defined on jenkins-infra/charts
> 
> .
>
> I created a new repository  named "github.com/jenkins-infra/release"
> , where that repository
> contains scripts, Jenkinsfiles and pod template definition used by
> release.ci.jenkins.io
>
> Finally, I reused and adapted scripts from jenkinsci/packaging, with the
> last PR located here,  I
> wish I had the time to refactor more those scripts to reduce the dependency
> on pkg.jenkins.io but I'll probably have to take some shortcut.
>
> Today people that I consider who should be able to trigger a job from
> release.ci.jenkins.io are
> olblak, danielbeck, olivergondza, oleg_nenashev, anybody else will have
> read-only access from the vpn.
>
> Feel free to ask if you have any questions, or just suggestions.
>
> Cheers
> --
> You received this message because you are subscribed to the Google Groups
> "Jenkins Developers" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to jenkinsci-dev+unsubscr...@googlegroups.com.
> To view this discussion on the web visit
> https://groups.google.com/d/msgid/jenkinsci-dev/0e4fac96-0039-487d-a267-f6e7df04cdc9%40www.fastmail.com
> 
> .
>
> --
> You received this message because you are subscribed to the Google Groups
> "Jenkins Developers" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to jenkinsci-dev+unsubscr...@googlegroups.com.
> To view this discussion on the web visit
> https://groups.google.com/d/msgid/jenkinsci-dev/7f7b0251-f868-5789-cb2a-3a7993246fd4%40cloudbees.com
> 
> .
>

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/CAFoxvgxGtRW5pFaq2%3DhegXtnD%2BMyDBgDEpEMcPsgnedbM2UQgA%40mail.gmail.com.


Re: Approval Request: Admin access to the Jenkins LinkedIn profile

2020-03-23 Thread Raihaan Shouhell
+1

A link to this should also be added to https://jenkins.io/ i see twitter at 
the bottom but not linkedin / facebook

On Monday, 23 March 2020 16:57:54 UTC+8, Oleg Nenashev wrote:
>
> Hi all,
>
> I would like to request administrative access to the Jenkins LinkedIn 
> profile . 
>
> *Why?* I am exploring options to make the Jenkins-related content in 
> social media more visible. We currently use Twitter, but other resources 
> (LinkedIn, Facebook, Reddit, etc.) are dormant, and reviving these accounts 
> would be a great step. There are services like https://ifttt.com/ which 
> could be used to repost the content on LinkedI, and I think it would be 
> a good quick win.
>
> *Eligibility*: I am one of the Advocacy SIG leaders and a 
> Jenkins board member (term ends in Dec 2021). I have a signed CLA with the 
> project. I am also a manager of the Jenkins Twitter account, jenkins.io 
> copy editor and a press contact in the CIS region. So I already work with 
> public-facing content for Jenkins, quite a lot.
>
> I will add the approval voting to the next governance meeting 
>  agenda. After that I 
> will still need to figure out who owns the account, but it is a technical 
> detail.
>
> Best regards,
> Oleg Nenashev
>
>
>
>
>
>

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/a2beddf6-fca9-4918-b577-3aa8ee2701f3%40googlegroups.com.


Re: Plugin release issue

2020-03-19 Thread Raihaan Shouhell
git tags cannot take spaces IIRC pick a name without a space

Cheers,
Raihaan

On Thu, Mar 19, 2020 at 3:26 PM selva vignesh 
wrote:

> [INFO] Scanning for projects...
>
> [INFO]
>
> [INFO] ---< io.jenkins.plugins:zohosprints
> >---
>
> [INFO] Building Zoho Sprints 1.0
>
> [INFO] [ hpi
> ]-
>
> [INFO]
>
> [INFO] --- maven-release-plugin:2.5.3:prepare (default-cli) @ zohosprints
> ---
>
> [INFO] Resuming release from phase 'scm-tag'
>
> [INFO] Tagging release with the label beta release...
>
> [INFO] Executing: /bin/sh -c cd
> /Users/selva-5820/jenkinsgithubrepo/zohosprints-plugin && git tag -F
> /var/folders/z4/7mg5vgwd1jb4zj9p61kckypdwhyjwq/T/maven-scm-1664433616.commit
> 'beta release'
>
> [INFO] Working directory:
> /Users/selva-5820/jenkinsgithubrepo/zohosprints-plugin
>
> [INFO]
> 
>
> [INFO] BUILD FAILURE
>
> [INFO]
> 
>
> [INFO] Total time:  1.666 s
>
> [INFO] Finished at: 2020-03-19T12:52:30+05:30
>
> [INFO]
> 
>
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-release-plugin:2.5.3:prepare (default-cli)
> on project zohosprints: Unable to tag SCM
>
> [ERROR] Provider message:
>
> [ERROR] The git-tag command failed.
>
> [ERROR] Command output:
>
> [ERROR] fatal: 'beta release' is not a valid tag name.
>
> [ERROR]
>
> [ERROR] -> [Help 1]
>
> [ERROR]
>
> [ERROR] To see the full stack trace of the errors, re-run Maven with the
> -e switch.
>
> [ERROR] Re-run Maven using the -X switch to enable full debug logging.
>
> [ERROR]
>
> [ERROR] For more information about the errors and possible solutions,
> please read the following articles:
>
> [ERROR] [Help 1]
> http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException
>
> After the all change getting error like this. what might be the git-tag.
> I gave as *beta release*
> Kindly assist
> On Mon, Mar 16, 2020 at 7:26 PM Slide  wrote:
>
>> You need to have a -SNAPSHOT version in your pom.xml. The version for the
>> release will be asked for during the release process. See
>> https://github.com/jenkinsci/email-ext-plugin/blob/master/pom.xml#L20 for
>> an example.
>>
>> On Mon, Mar 16, 2020 at 5:45 AM selva vignesh 
>> wrote:
>>
>>> Hi team,
>>> When i am performing release getting below error can anyone please
>>> assist me.
>>>
>>> I've added *Artifactory Credentials for Maven. *
>>>
>>> *mvn release:prepare release:perform*
>>>
>>>
>>> [INFO] Scanning for projects...
>>>
>>> [INFO]
>>>
>>> [INFO] ---< io.jenkins.plugins:zohosprints
>>> >---
>>>
>>> [INFO] Building Zoho Sprints 1.1
>>>
>>> [INFO] [ hpi
>>> ]-
>>>
>>> [INFO]
>>>
>>> [INFO] --- maven-release-plugin:2.5.3:prepare (default-cli) @
>>> zohosprints ---
>>>
>>> [INFO]
>>> 
>>>
>>> [INFO] BUILD FAILURE
>>>
>>> [INFO]
>>> 
>>>
>>> [INFO] Total time:  1.994 s
>>>
>>> [INFO] Finished at: 2020-03-16T18:11:02+05:30
>>>
>>> [INFO]
>>> 
>>>
>>> [ERROR] Failed to execute goal
>>> org.apache.maven.plugins:maven-release-plugin:2.5.3:prepare
>>> (default-cli) on project zohosprints: You don't have a SNAPSHOT project
>>> in the reactor projects list. -> [Help 1]
>>>
>>> [ERROR]
>>>
>>> [ERROR] To see the full stack trace of the errors, re-run Maven with
>>> the -e switch.
>>>
>>> [ERROR] Re-run Maven using the -X switch to enable full debug logging.
>>>
>>> [ERROR]
>>>
>>> [ERROR] For more information about the errors and possible solutions,
>>> please read the following articles:
>>>
>>> [ERROR] [Help 1]
>>> http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException
>>>
>>> --
>>> You received this message because you are subscribed to the Google
>>> Groups "Jenkins Developers" group.
>>> To unsubscribe from this group and stop receiving emails from it, send
>>> an email to jenkinsci-dev+unsubscr...@googlegroups.com.
>>> To view this discussion on the web visit
>>> https://groups.google.com/d/msgid/jenkinsci-dev/f5184842-53d4-4d8c-be29-bcbc8a5f4321%40googlegroups.com
>>> 
>>> .
>>>
>>
>>
>> --
>> Website: http://earl-of-code.com
>>
>> --
>> You received this message because you are subscribed to the Google Groups
>> "Jenkins Developers" group.
>> To unsubscribe from this group and stop receiving emails from it, send an
>> email to jenkinsci-dev+unsubscr...@googlegroups.com.
>> To view this discussion on the web visit
>> 

Re: Depublishing the Jenkins Design Language 2 website and resources

2020-02-26 Thread Raihaan Shouhell
+1

On Wed, Feb 26, 2020 at 9:01 PM Mark Waite 
wrote:

> +1
>
> On Wed, Feb 26, 2020, 5:16 AM Oleg Nenashev 
> wrote:
>
>> Hi all,
>>
>> Currently Jenkins Design Language 2
>>  is not used
>> anywhere, and there is no active maintainers. Taking the current Blue Ocean
>> state, I would not expect JDL 2.0 to ever go out of Alpha. At the same time
>> the current site sometimes confuses Jenkins plugin developers who discover
>> the website and try to use JDL for new designs. It gets even worse, because
>> the actual codebase is now in
>> https://github.com/jenkinsci/blueocean-plugin/tree/jdl-site-link/jenkins-design-language
>> .
>>
>> I suggest to...
>>
>>- Modify the Blue Ocean JDL docs to point to the right documentation.
>>https://github.com/jenkinsci/blueocean-plugin/pull/2055 does it
>>- Archive https://github.com/jenkinsci/jenkins-design-language
>>- Depublish the JDL2 website:
>>http://jenkinsci.github.io/jenkins-design-language
>>
>> Is everyone fine with the suggested approach?
>>
>> Thanks in advance,
>> Oleg
>>
>> --
>> You received this message because you are subscribed to the Google Groups
>> "Jenkins Developers" group.
>> To unsubscribe from this group and stop receiving emails from it, send an
>> email to jenkinsci-dev+unsubscr...@googlegroups.com.
>> To view this discussion on the web visit
>> https://groups.google.com/d/msgid/jenkinsci-dev/CAPfivLBVeYyQcbY1veh6qeqfHpj%2BchGhVmpaKU6TzACPUwv%3DJA%40mail.gmail.com
>> 
>> .
>>
> --
> You received this message because you are subscribed to the Google Groups
> "Jenkins Developers" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to jenkinsci-dev+unsubscr...@googlegroups.com.
> To view this discussion on the web visit
> https://groups.google.com/d/msgid/jenkinsci-dev/CAO49JtEqR%2BtoB-CGULw_AMLuv31sYv9n0DBcRxp%3D9N8hMRL%3Dmg%40mail.gmail.com
> 
> .
>

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/CAFoxvgxRKZFmtfe3swMFjRGFJ-p%2Bic7q%2BKy1G-_r7yNnnf5HdA%40mail.gmail.com.


Re: JEP-13: timja youtube permissions for JCasc

2020-01-31 Thread Raihaan Shouhell
+1

On Fri, Jan 31, 2020 at 5:12 PM Tracy Miranda 
wrote:

> +1
>
> On Fri, Jan 31, 2020 at 3:27 AM Mark Waite 
> wrote:
>
>> +1 from me
>>
>> On Fri, Jan 31, 2020 at 9:22 AM Tim Jacomb  wrote:
>>
>>> Hi
>>>
>>> As a sub-project leader for JCasc I'm requesting permission to upload
>>> videos to the jenkinsci youtube channel for JCasC sub-project meetings
>>>
>>>
>>> https://github.com/jenkinsci/jep/blob/master/jep/13/README.adoc#eligibility
>>>
>>> I have a signed ICLA:
>>> https://github.com/jenkinsci/infra-cla/tree/master/collected/icla/timja
>>> and my google account has 2fa on it
>>>
>>> Thanks
>>> Tim
>>>
>>> --
>>> You received this message because you are subscribed to the Google
>>> Groups "Jenkins Developers" group.
>>> To unsubscribe from this group and stop receiving emails from it, send
>>> an email to jenkinsci-dev+unsubscr...@googlegroups.com.
>>> To view this discussion on the web visit
>>> https://groups.google.com/d/msgid/jenkinsci-dev/CAH-3BieuhqJAAcDMC%3Dz-OcvkG26z3exQERTpvw1uxZ_4MKfmAQ%40mail.gmail.com
>>> 
>>> .
>>>
>> --
>> You received this message because you are subscribed to the Google Groups
>> "Jenkins Developers" group.
>> To unsubscribe from this group and stop receiving emails from it, send an
>> email to jenkinsci-dev+unsubscr...@googlegroups.com.
>> To view this discussion on the web visit
>> https://groups.google.com/d/msgid/jenkinsci-dev/CAO49JtHaGr-tfPJUz4y2s9MWHNJHYUd5DS%2BgtmwrFYc%2BQm0Vfg%40mail.gmail.com
>> 
>> .
>>
> --
> You received this message because you are subscribed to the Google Groups
> "Jenkins Developers" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to jenkinsci-dev+unsubscr...@googlegroups.com.
> To view this discussion on the web visit
> https://groups.google.com/d/msgid/jenkinsci-dev/CACTaz6pkXqc8-a%3D0S5j6nzw7YuKgAnSgEz_w_Q2%2B4KTnfaZdyw%40mail.gmail.com
> 
> .
>

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/CAFoxvgzPMuaDwNtRm3DNjwLNuboKWFW-B-OZmoHq2czVP_ZExQ%40mail.gmail.com.


Re: Adopting pipeline stage view

2020-01-30 Thread Raihaan Shouhell
Hey Ulrich,

I did file one but ultimately decided not to adopt it as Olivier who I was 
under the impression was unavailable to work on it replied me in another 
email I sent some time back, today.
As Olivier is a much better suited for this than I am, I will let him be 
its maintainer. My goal was to ultimately deliver the PRs and make a 
release as there are bugs that have been plaguing us for months which has a 
fix not being released
Since he has started work on releasing. I will drop the request.

Thanks for your patience.

Cheers,
Raihaan

On Thursday, 30 January 2020 19:10:07 UTC+8, Ullrich Hafner wrote:
>
> Thanks very much for your willingness to adopt this plugin!  
>
> Can you please create a PR for 
>
> https://github.com/jenkins-infra/repository-permissions-updater/blob/master/permissions/plugin-pipeline-stage-view.yml
> As well, so you are able to upload releases?
>
>
> Am 30.01.2020 um 10:43 schrieb Raihaan Shouhell  >:
>
> Hi,
>
> I'd like to adopt https://github.com/jenkinsci/pipeline-stage-view-plugin
>
> it needs a release and has some PRs worth delivering
>
> https://github.com/jenkinsci/pipeline-stage-view-plugin/pull/81
> https://github.com/jenkinsci/pipeline-stage-view-plugin/pull/80
>
> github-id: res0nance
> infra-id: raihaan
>
> Cheers,
> Raihaan
>
> -- 
> You received this message because you are subscribed to the Google Groups 
> "Jenkins Developers" group.
> To unsubscribe from this group and stop receiving emails from it, send an 
> email to jenkin...@googlegroups.com .
> To view this discussion on the web visit 
> https://groups.google.com/d/msgid/jenkinsci-dev/d33d42e8-c021-4dd0-866e-6d824853f76c%40googlegroups.com
>  
> <https://groups.google.com/d/msgid/jenkinsci-dev/d33d42e8-c021-4dd0-866e-6d824853f76c%40googlegroups.com?utm_medium=email_source=footer>
> .
>
>
>

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/1c5a302e-204f-4e45-a15f-d2fc564b458e%40googlegroups.com.


Adopting pipeline stage view

2020-01-30 Thread Raihaan Shouhell
Hi,

I'd like to adopt https://github.com/jenkinsci/pipeline-stage-view-plugin

it needs a release and has some PRs worth delivering

https://github.com/jenkinsci/pipeline-stage-view-plugin/pull/81
https://github.com/jenkinsci/pipeline-stage-view-plugin/pull/80

github-id: res0nance
infra-id: raihaan

Cheers,
Raihaan

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/d33d42e8-c021-4dd0-866e-6d824853f76c%40googlegroups.com.


Re: Proposal: Expanding the Jenkins Core maintainers team

2020-01-27 Thread Raihaan Shouhell
I was under the impression that a CCLA has to be filed first, is my 
assumption wrong?
I'm currently in the process of getting that sorted out

On Monday, 27 January 2020 04:31:06 UTC+8, Oleg Nenashev wrote:
>
> One thing to mention is that I will be traveling on Jan 29 ... Feb 08: 
> FOSDEM and then a business trip. This time my time will be really limited, 
> and it is safe to assume that I will not be available to review and merge 
> pull requests. On the other hand, I also will unlikely be available for 
> timely Q After considering options, my preference was to add more 
> maintainers and to do the best efforts on the documentation fronts before I 
> go off.
>
> Regarding the permissions, I am waiting for the Weekly release with 
> regression patches and for ICLA submission from Raihaan 
>
> I wonder about the methodology used here though. The data is objective, 
>> but do these numbers actually tell us something useful, other than that 
>> Gavin's recent (awesome) contributions to the project are elsewhere? This 
>> seems akin to counting lines of code changed as a proxy for productivity.
>>
> Be sure I recognize and hugely appreciate Gavin's contributions. At the 
> moment they just do not go into the Jenkins core, and hence Gavin was not 
> in my list for Core maintainers. If others would like to add Gavin to the 
> core maintainers team, I would be happy to support it. Regarding my 
> methodology, I just used the existing queries, they do not represent 
> quality of the reviews and other factors. If anyone wants to introduce 
> better metrics and to reconsider the list, be my guest :)
>
> I'd also like to recommend that we emphasize the need to evaluate the 
>> usefulness of contributions in the maintainer guidelines. Not all 
>> contributions make sense to merge, and even useful contributions might 
>> result in weird inconsistencies or even problems across the whole of 
>> Jenkins if accepted as submitted. There's some subjectivity here, but even 
>> if you tend to be lenient on such matters, please still consider these 
>> issues and don't simply focus on whether the code works in isolation; 
>> that's not how it's going to affect users.
>>
> Duly noted, I will add it explicitly to the maintainer docs
>  
> BR, Oleg
>
>
>
>
> On Saturday, January 25, 2020 at 11:44:10 PM UTC+1, Daniel Beck wrote:
>>
>>
>>
>> > On 21. Jan 2020, at 13:01, Oleg Nenashev  wrote: 
>> > 
>> > TL;DR: I propose to expand the Jenkins Core maintainers team by 
>> inviting the most active code reviewers to the team. 
>> > 
>>
>> I'm all for adding more active maintainers, so +1. It's been nice 
>> actually getting reviews for submissions (and with this change they will 
>> even be green, not grey!). 
>>
>> I wonder about the methodology used here though. The data is objective, 
>> but do these numbers actually tell us something useful, other than that 
>> Gavin's recent (awesome) contributions to the project are elsewhere? This 
>> seems akin to counting lines of code changed as a proxy for productivity. 
>>
>>
>> > • We ensure that there is a knowledge transfer process established to 
>> help new maintainers 
>> >   • We start doing regular office hours with Q and joint PR 
>> grooming/review sessions, e.g. every 2 weeks. I am ready to run such 
>> sessions 
>> >   • Maintainer guidelines and best practices are documented in the 
>> Jenkins core repo. We will gradually create this documentation together 
>> during KT sessions   
>>
>>
>> I'd also like to recommend that we emphasize the need to evaluate the 
>> usefulness of contributions in the maintainer guidelines. Not all 
>> contributions make sense to merge, and even useful contributions might 
>> result in weird inconsistencies or even problems across the whole of 
>> Jenkins if accepted as submitted. There's some subjectivity here, but even 
>> if you tend to be lenient on such matters, please still consider these 
>> issues and don't simply focus on whether the code works in isolation; 
>> that's not how it's going to affect users. 
>>
>>
>>

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/bb477d30-4251-43e5-8f0a-a27bcbed7b35%40googlegroups.com.


Re: Any plans for the github checks API?

2020-01-27 Thread Raihaan Shouhell
I think having a checks api would be great.
Reports sending checks back to the change request would be a useful feature.


On Monday, 27 January 2020 20:57:31 UTC+8, Oleg Nenashev wrote:
>
> Just to bump this thread, we consider adding Checks API integration as a 
> GSoC 2020 project idea.
> We had a preliminary discussion with Ulli Hafner (Warnings NG) and other 
> parties.
>
> If someone is interested to join the project, please let me know
>
> On Thursday, May 10, 2018 at 5:56:28 PM UTC+2, Jesse Glick wrote:
>>
>> On Thu, May 10, 2018 at 5:37 AM, Steven F  wrote: 
>> > The examples in the article show elements such as linting, 
>> > build, static analysis as separate and individually runnable things. In 
>> > Jenkins 2.x Pipeline it feels like bundling these things together is 
>> more 
>> > encouraged. 
>>
>> Well, it is generally more straightforward to have those things be run 
>> as part of a single Jenkins build, triggered by SCM changes. What is 
>> missing is an API which would allow Jenkins report plugins (`Publisher 
>> & SimpleBuildStep`, for example) to indicate to the system that there 
>> is some information to be displayed in an abstract “change request”, 
>> perhaps associated with source code lines, which would then be 
>> implemented by `github-branch-source` with the Checks API. 
>>
>> jxpe...@godaddy.com wrote: 
>> > just rerunning the job from github would save a step 
>>
>> See JENKINS-45455 for rerunning generally; again we would need a new 
>> API to allow this is to be integrated with in-PR “chatops” triggers, 
>> so that `github-branch-source` could receive GH events and refire them 
>> as requests to rerun parts of a build, which 
>> `pipeline-model-definition` would then interpret as a Declarative 
>> build trigger. 
>>
>> All this would allow you to do more from GitHub and less from Blue 
>> Ocean or the Jenkins “classic” UI. @abayer has done the most work in 
>> this area and should probably be commenting. 
>>
>

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/fa0449e3-53ec-42d2-a788-cad59557d4d2%40googlegroups.com.


Re: Finding relevant jelly for branch-api

2020-01-22 Thread Raihaan Shouhell
Oh i was thinking because ViewImpl in branch-api calls getItems in 
getDisplayName since view has to call get items it can just check the size 
from there eliminating the need to call getItems twice or three times. 
Only problem is that view has to be reworked to incorporate this. Might not 
be worth the trouble.

On Wednesday, 22 January 2020 23:29:45 UTC+8, Jesse Glick wrote:
>
> On Wed, Jan 22, 2020 at 9:48 AM Raihaan Shouhell 
> > wrote: 
> > when core calls getItems() in jelly 
> >  you can get the size and therefore skip the need for permissions checks 
>
> `getItems` would still need to run permission checks, regardless of 
> where it is implemented. 
>

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/a69a2a45-8e98-43e7-b82f-ae12a9c5cb97%40googlegroups.com.


Re: Finding relevant jelly for branch-api

2020-01-22 Thread Raihaan Shouhell
Thanks for the reply Jesse, my idea was because branch-api wants to show 
the number of items in its view if core should provide that feature and 
that way when core calls getItems() in jelly
 you can get the size and therefore skip the need for permissions checks. 
But I'm not sure if its worth the effort.

On Wednesday, 22 January 2020 08:43:30 UTC+8, Jesse Glick wrote:
>
> On Mon, Jan 20, 2020 at 5:13 AM Raihaan Shouhell 
> > wrote: 
> > I'd like to see if the relevant jelly files that call this has access to 
> items and the use of getItems() (and hasPermission) can be reduced. 
>
> Doubtful since this is just overriding 
>
> https://javadoc.jenkins.io/hudson/model/View.html#getDisplayName-- 
>
> If permission checks are a bottleneck here it might be a problem in 
> the `AuthorizationStrategy`. Alternately, it would probably be fine to 
> wrap the `getItems` call inside `ACL.as(ACL.SYSTEM)` since someone 
> with permission to view the organization folder very likely also has 
> permission to view all the child repositories (it would be an obscure 
> authorization strategy that decided otherwise), and at worst the 
> leaked information would be a count of hidden subfolders. 
>

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/b6feb5ab-51a9-4be3-b8ca-7c20b9997d1f%40googlegroups.com.


Re: Getting jenkins build user

2020-01-22 Thread Raihaan Shouhell
Yes the useridcause will have the information you need

On Wednesday, 22 January 2020 17:27:23 UTC+8, selva vignesh wrote:
>
> Hi,
> I have developed Jenkins plugin for my use. In that i am getting 
> *triggerer* of build (i.e build user, who triggered a build). Now i am 
> using Jenkins own database for user. 
> If i migrate to AD, *am i able to get userid from build?.*
>
>> Cause.UpstreamCause upstreamCause = (Cause.UpstreamCause) 
>> run.getCause(Cause.UpstreamCause.class);
>> Run temp = null;
>> while (upstreamCause != null) {
>> Job job = 
>> Jenkins.getInstance().getItemByFullName(upstreamCause.getUpstreamProject(), 
>> Job.class);
>> if (job != null) {
>> temp = job.getBuildByNumber(upstreamCause.getUpstreamBuild());
>> if (temp != null) {
>>upstreamCause = (Cause.UpstreamCause) 
>> temp.getCause(Cause.UpstreamCause.class);
>> }
>> }
>> }
>> if (temp != null) {
>> run = temp;
>> }
>> SCMTrigger.SCMTriggerCause scmTriggerCause = (SCMTrigger.SCMTriggerCause) 
>> run.getCause(SCMTrigger.SCMTriggerCause.class);
>> if (scmTriggerCause != null) {
>> return "SCMTrigger";
>> }
>> UserIdCause cause = (UserIdCause) run.getCause(UserIdCause.class);
>> if (cause == null) {
>> return "System";
>> }
>> return cause.getUserId();
>>
>>
> I am using above code to get build *triggerer. *Kindly assist.
>

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/40b138dd-79de-41b0-a1c2-51617af617c1%40googlegroups.com.


Re: Proposal: Expanding the Jenkins Core maintainers team

2020-01-22 Thread Raihaan Shouhell
Sounds good to me

On Wed, 22 Jan 2020, 5:59 AM Victor Martinez, 
wrote:

> +1
> This is really great news!! Thanks for moving forward <3
>
> --
> You received this message because you are subscribed to the Google Groups
> "Jenkins Developers" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to jenkinsci-dev+unsubscr...@googlegroups.com.
> To view this discussion on the web visit
> https://groups.google.com/d/msgid/jenkinsci-dev/74dd129f-eca3-4eea-9385-e0a9cd6ecb16%40googlegroups.com
> 
> .
>

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/CAFoxvgy6MN2SPsrg_yDhWRwJrsgPAv0q5bD-ZjRnrV_Y-_MieQ%40mail.gmail.com.


Finding relevant jelly for branch-api

2020-01-20 Thread Raihaan Shouhell
Hi all,

Recently I've been looking into some page loading issues that plague some 
of my jenkins instances while doing some optimizations I came across this 
line

https://github.com/jenkinsci/branch-api-plugin/blob/ad83debf8f48d6ad2661ec2549116b3df8cb0f5b/src/main/java/jenkins/branch/OrganizationFolderViewHolder.java#L219

getItems() essentially checks every item for item.read permissions and 
returns a list of permitted items. I'd like to see if the relevant jelly 
files that call this has access to items and the use of getItems() (and 
hasPermission) can be reduced.

Is there any good way of tracing how pages get rendered?

Personally I'm not sure if this is even worth looking into (Some of my 
organizations have 900+ items) would anyone have any suggestions?

Cheers,
Raihaan

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/505f8bb3-ba63-43c5-a5a4-272089d60d16%40googlegroups.com.


Re: Archiving jenkinsci/groovy repo

2020-01-07 Thread Raihaan Shouhell
+1 should have been archived a long time ago.

Cheers,
Raihaan

On Tue, Jan 7, 2020 at 4:17 PM Oliver Gondža  wrote:

> Thanks to a github security alert, I find out we have a fork of an
> official groovy repo[1] in our org. It is terribly outdated and unused
> for over 8 years[2].
>
> Are there any objections to archiving such repositories? The repo will
> remain readable but it would clearly indicate it is obsolete and it will
> not be searched for vulnerabilities, noone is interested in.
>
> [1] https://github.com/jenkinsci/groovy
> [2]
>
> https://github.com/jenkinsci/jenkins/commit/b8673633da9aa4f0632a4a9e1fc26729cfca0f9e
>
> Thanks!
> --
> oliver
>
> --
> You received this message because you are subscribed to the Google Groups
> "Jenkins Developers" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to jenkinsci-dev+unsubscr...@googlegroups.com.
> To view this discussion on the web visit
> https://groups.google.com/d/msgid/jenkinsci-dev/3ce4514d-3464-6003-2f96-7125155c18eb%40gmail.com
> .
>

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/CAFoxvgwcj-gBCuxUyfm_w-VogutwXbtNmohigmm_9NSaw-oweg%40mail.gmail.com.


Re: findsecbugs in spotbugs

2019-12-10 Thread Raihaan Shouhell
Hey Jeff,

I think it is ok to introduce it. Sounds like it would add value. 
There should be a switch to at least disable failing the build because of 
findsecbugs.

Despite the potential problems with introducing it, I am +1 on it since it 
will definitely help the development of new plugins.

Like you said spotbugs has actually helped find a ton of bugs, I even find 
myself getting annoyed when the relevant annotation was missing that could 
potentially avoid a bug.
If this tool can help us avoid security issues the same way spotbugs helps 
with bugs that would be awesome.

Cheers,
Raihaan

On Wednesday, 11 December 2019 04:27:16 UTC+8, Jeff Thompson wrote:
>
> Jenkins developers, 
>
> I've been working on introducing findsecbugs into the Jenkins developer 
> ecosystem. findsecbugs is a plugin for spotbugs (formerly findbugs) that 
> adds analysis for a significant collection of bug rules that could 
> potentially impact security. More information is at 
> https://find-sec-bugs.github.io/ 
>
> I've got PRs about ready for merge to introduce findsecbugs into Jenkins 
> ( https://github.com/jenkinsci/jenkins/pull/4381 ) and Remoting ( 
> https://github.com/jenkinsci/remoting/pull/361 ). 
>
> The problem with introducing a tool like this in any legacy software is 
> that it finds things that could have been better implemented or are 
> outdated but are not real issues. Turning it on means going through the 
> all the findings, analyzing them, and then suppressing them (hopefully 
> individually) or fixing them. I've done that in my two PRs. 
>
> I've also gone through this with a sampling of 7 plugins. Only one of 
> them didn't detect any findings, but they didn't necessarily have any 
> real security issues. I intend to push PRs for these plugins I've tried 
> in the coming days. 
>
> I believe there is a lot of value in having this tool detect new, 
> potential issues as we move forward with changes and new code. I've been 
> glad in the past at how spotbugs and other tools help catch things 
> before PRs are merged. 
>
> I want to get findsecbugs turned on in the parent plugin pom. 
> @StefanSpieker also has a PR to turn it on in the parent Jenkins pom. 
>
> I'm not sure whether we need to be more cautious about turning 
> findsecbugs on in the parent poms. Do we need to make it opt-in? How do 
> we encourage people to opt-in? Or, does that just become something 
> everyone has to do to move forward to latest poms? At a minimum I think 
> we should use @StefanSpieker's PR to turn it on in the Jenkins parent pom. 
>
> Jeff Thompson 
>
>

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/551b065c-8a6c-47d8-8377-b3d186db363d%40googlegroups.com.


Re: Access to git parameter plugin

2019-12-04 Thread Raihaan Shouhell
Hey,

Sure I'll get to that

CCed: Boguslaw on this.

Cheers,
Raihaan


On Wed, Dec 4, 2019 at 4:48 PM Baptiste Mathus 
wrote:

> Hello,
>
> Please also CC the current maintainer(s), as documented on
> https://jenkins.io/doc/developer/plugin-governance/adopt-a-plugin/
>
> Thanks for stepping up!
>
> On Wed, Dec 4, 2019 at 7:44 AM Raihaan Shouhell 
> wrote:
>
>> Hi All,
>>
>> I'd like to request access to the git parameter plugin.
>> https://github.com/jenkinsci/git-parameter-plugin
>>
>> It seems to have been abandoned. I've tried reaching out to its current
>> listed maintainers,
>> https://github.com/jenkinsci/git-parameter-plugin/blob/f1daa529bef163c9b678b537b1d4ff98c2bbc39e/pom.xml#L39-L48
>>
>> One of whom, Niklaus has mentioned that he stepped down as maintainer in
>> 2015 and Boguslaw(kilmas7) is the current maintainer. I have yet to receive
>> any reply from him.
>>
>> I'd like to merge some of the PRs, move its docs to github, enable
>> dependabot and incrementals and cut a new release.
>>
>> Github username: res0nance
>> Jenkins infra account: raihaan
>>
>> Cheers,
>> Raihaan
>>
>> --
>> You received this message because you are subscribed to the Google Groups
>> "Jenkins Developers" group.
>> To unsubscribe from this group and stop receiving emails from it, send an
>> email to jenkinsci-dev+unsubscr...@googlegroups.com.
>> To view this discussion on the web visit
>> https://groups.google.com/d/msgid/jenkinsci-dev/1dea1ad2-b86f-4a05-b2ed-d6e5510caf5e%40googlegroups.com
>> <https://groups.google.com/d/msgid/jenkinsci-dev/1dea1ad2-b86f-4a05-b2ed-d6e5510caf5e%40googlegroups.com?utm_medium=email_source=footer>
>> .
>>
> --
> You received this message because you are subscribed to the Google Groups
> "Jenkins Developers" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to jenkinsci-dev+unsubscr...@googlegroups.com.
> To view this discussion on the web visit
> https://groups.google.com/d/msgid/jenkinsci-dev/CAPyTVp3ZuCc%2B5N6Tiwq%2BCgwF9FEvpKPCAQo%2BKAFccys6DJuN-A%40mail.gmail.com
> <https://groups.google.com/d/msgid/jenkinsci-dev/CAPyTVp3ZuCc%2B5N6Tiwq%2BCgwF9FEvpKPCAQo%2BKAFccys6DJuN-A%40mail.gmail.com?utm_medium=email_source=footer>
> .
>

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/CAFoxvgzBFJ9h3nhBNsTJ5aRVE0A-89FwgbLxTARR38Lpxcup3A%40mail.gmail.com.


Access to git parameter plugin

2019-12-03 Thread Raihaan Shouhell
Hi All,

I'd like to request access to the git parameter 
plugin. https://github.com/jenkinsci/git-parameter-plugin

It seems to have been abandoned. I've tried reaching out to its current 
listed 
maintainers, 
https://github.com/jenkinsci/git-parameter-plugin/blob/f1daa529bef163c9b678b537b1d4ff98c2bbc39e/pom.xml#L39-L48

One of whom, Niklaus has mentioned that he stepped down as maintainer in 
2015 and Boguslaw(kilmas7) is the current maintainer. I have yet to receive 
any reply from him.

I'd like to merge some of the PRs, move its docs to github, enable 
dependabot and incrementals and cut a new release.

Github username: res0nance
Jenkins infra account: raihaan

Cheers,
Raihaan

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/1dea1ad2-b86f-4a05-b2ed-d6e5510caf5e%40googlegroups.com.


Re: JENKINS-43556 - Possible run result changing after isBuilding() returns false

2019-10-31 Thread Raihaan Shouhell
I meant that there was a replay feature which allowed you to modify the 
Jenkinsfile without having to pushed back to github

On Friday, 1 November 2019 03:27:29 UTC+8, Jesse Glick wrote:
>
> On Thu, Oct 31, 2019 at 11:02 AM Raihaan Shouhell 
> > wrote: 
> > blue ocean doesn't support replays 
>
> Meaning? There is a stage rerun feature for Declarative Pipeline which 
> is supported by Blue Ocean as far as I know. 
>

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/7b823756-0ea6-40a5-94c9-136d9c3e84c6%40googlegroups.com.


Re: JENKINS-43556 - Possible run result changing after isBuilding() returns false

2019-10-31 Thread Raihaan Shouhell
Yeah it doesnt seem to be, but unfortunately blue ocean doesn't support
replays and other features.
As a result I'm trying to fix this one misleading bug that occasionally
plagues my instances.
Any help would be appreciated

Cheers,
Raihaan

On Thu, 31 Oct 2019, 8:27 PM Jesse Glick,  wrote:

> On Thu, Oct 31, 2019 at 3:06 AM Raihaan Shouhell
>  wrote:
> > stage-view shows a failed result even though the run passed.
>
> I do not think this plugin is maintained any longer. Whatever
> attention is paid to Pipeline visualization goes into Blue Ocean.
>
> --
> You received this message because you are subscribed to the Google Groups
> "Jenkins Developers" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to jenkinsci-dev+unsubscr...@googlegroups.com.
> To view this discussion on the web visit
> https://groups.google.com/d/msgid/jenkinsci-dev/CANfRfr0%3D99SASV%3DncP4Dc-Et66yuSrWAUnNkVDbPvQ%2Bh0JoU4Q%40mail.gmail.com
> .
>

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/CAFoxvgyKHXmC07qeaZtSP4itTASR4FVHq14CUWt2c_Nwcgig_A%40mail.gmail.com.


JENKINS-43556 - Possible run result changing after isBuilding() returns false

2019-10-31 Thread Raihaan Shouhell
Hey all,

I've recently been looking into an issue JENKINS-43556 where stage-view 
shows a failed result even though the run passed.

The cause seems to be due to its cache holding data that indicates failure 
(FlowNodeUtil.java).

If you refresh the cached data it will indcate success. Tested through this 
script

import com.cloudbees.workflow.flownode.FlowNodeUtil;
import com.cloudbees.workflow.rest.external.RunExt;

def jobs = Jenkins.get().getItemByFullName("PROJECT_NAME")
def job = jobs.getBuild("BUILD_NUMBER")

//Cache result
println FlowNodeUtil.getCachedRun(job).getStatus()
//Job result
println job.getResult()
//Recreate cache value
RunExt runExt = RunExt.createNew(job);
println runExt.getStatus()
FlowNodeUtil.cacheRun(job,runExt)

This will return
FAILURE 
SUCCESS 
SUCCESS

>From 
https://github.com/jenkinsci/pipeline-stage-view-plugin/blob/c1e87387be34530f0e625d8fb5d4bf7699f73b03/rest-api/src/main/java/com/cloudbees/workflow/flownode/FlowNodeUtil.java#L108-L112
Values will not be cached unless the Run is not building and from 
https://github.com/jenkinsci/pipeline-stage-view-plugin/blob/c1e87387be34530f0e625d8fb5d4bf7699f73b03/rest-api/src/main/java/com/cloudbees/workflow/rest/external/RunExt.java#L298-L315
It will not be cached unless FlowExecution has completed. Is there any 
scenario where the result gets modified after isComplete() is true and 
isBuilding() is false?

Cheers,
Raihaan

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/1540e590-a684-419c-9684-e2174502b883%40googlegroups.com.


Re: Enabling ImgBot in jenkinsci and in jenkins-infra/jenkins.io?

2019-10-07 Thread Raihaan Shouhell
I think its a good idea  +1

On Monday, 7 October 2019 16:09:29 UTC+8, Oleg Nenashev wrote:
>
> Hi all,
>
> I would like to enable ImgBot in 
> some of my plugins in order to optimize image sizes. ImgBot is a bot which 
> creates pull requests with image optimizations, e.g. here is a sample pull 
> requests for the Jenkins Core: 
> https://github.com/oleg-nenashev/jenkins/pull/38. There are a lot of 
> historical images in Jenkins, and it could be a good opportunity to 
> optimize them. 
>
> There is a free open-source plan for ImgBot, so I think enabling the bot 
> should not be a problem. As for other bots, I suggest we enable it in the 
> org but do not enable it widely by default. Each plugin maintainer will be 
> able to enable it on his/her own.
>
> What do you think?
>
> Thanks in advance,
> Oleg
>
>

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/98b1fe89-d010-40e2-8103-a70d085fcdd0%40googlegroups.com.


Re: Jenkins global configuration

2019-10-02 Thread Raihaan Shouhell
That helped a ton, figured out that it was me not marking the setters and 
getters public.
Thanks Jesse

On Tuesday, 1 October 2019 20:44:49 UTC+8, Jesse Glick wrote:
>
> On Tue, Oct 1, 2019 at 5:06 AM Raihaan Shouhell 
> > wrote: 
> > I've been trying to implement a global configuration 
>
> Try using the sample in https://github.com/jenkinsci/archetypes which 
> includes a functional test that should be helpful. 
>

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/969fa337-bca1-4883-b24c-17cd78bf9f94%40googlegroups.com.


Jenkins global configuration

2019-10-01 Thread Raihaan Shouhell
Hi all,

I've been trying to implement a global configuration but have an issue 
where only the username field is properly reflected and saved when I use 
the configuration UI.
Other plugins seem to do similar things.

Here is a repo with an MRE of what I get 
https://github.com/res0nance/global-test

Any help would be appreciated.

Cheers,
Raihaan

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/fd8ac17d-8317-4ddc-aa4c-7e8ce647ce41%40googlegroups.com.


Re: 2.190.2 LTS RC: Backporting JENKINS-59406?

2019-10-01 Thread Raihaan Shouhell
+1 to backporting

On Tuesday, 1 October 2019 14:16:58 UTC+8, Baptiste Mathus wrote:
>
> Hello everyone, hello Oliver,
>
> Our ongoing tests confirmed that 
> https://issues.jenkins-ci.org/browse/JENKINS-59406 is a problem.
>
> Can we consider backporting it? (Oleg already added the lts-candidate a 
> few days ago fwiw).
>
> Thanks!
>

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/7797200e-2bc0-42a6-b099-06dc49ac194b%40googlegroups.com.


Re: Proposal: Jenkins Core PR reviewers team

2019-09-20 Thread Raihaan Shouhell
I'd be keen on this +1

On Thursday, 19 September 2019 19:26:46 UTC+8, Oleg Nenashev wrote:
>
> Hi all,
>
> I would like to make a proposal w.r.t the Jenkins Core review process. 
>
> As you may see from the pull requests 
> , currently we have a pretty 
> heavy process which includes multiple reviews, labeling PRs for automatic 
> changelog drafts, and so on. This process helps us to maintain high quality 
> of weekly releases. Over the last year we have had many contributors who 
> helped to review core pull requests on a regular basis. These contributors 
> do not have WRITE permission in the repo, and they had no way no assign 
> labels, request reviews, re-trigger CI, and so on. Only jenkinsci/Core 
> members have permission to do that, and it is a serious overhead since we 
> do not have many active core maintainers in jenkinsci/Core looking at PRs.
>
> Few months ago GitHub introduced a new TRIAGE 
> 
>  permission 
> for the repository which basically gives permissions to manage issues/pull 
> requests without being actually able to merge them. IMO it gives us a great 
> opportunity to expand the core reviewers bandwidth and at the same time to 
> offer a path for onboarding new core maintainers (contributor => Triage => 
> Write permissions).
>
> What I suggest to do:
>
>- Introduce a new jenkinsci/core-pr-reviewers team
>- Grant the team TRIAGE permission in  
>https://github.com/jenkinsci/jenkins
>- Maybe?: Add CODEOWNERS to GitHub to automatically request reviews 
>from the new team for new pull requests
>- Invite contributors who regularly review Jenkins core pull requests: 
>alecharp , varyvol 
>, MarkEWaite 
>, res0nance 
>, jvz , 
>MRamonLeon, halkeye  (sorry if I missed 
>anyone!)
>
> If the approach works well, later we can expand it to components which are 
> a part of the Jenkins core (libraries, modules, etc.).
>
> What do you think?
>
> Best regards,
> Oleg
>
>
>
>
>
>
>
>

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/191d48e2-1898-4266-8c39-0b2465bef2d9%40googlegroups.com.


Request for admin permissions to ec2-plugin repo

2019-08-28 Thread Raihaan Shouhell
Hi all,

I'd like to enable release-drafter and dependabot for ec2-plugin's 
repository but do not have enough permissions on it.
Could I be granted the appropriate permissions?

My github id is res0nance

Cheers,
Raihaan

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/255fc5a2-7d93-43aa-8119-4ac7928631b3%40googlegroups.com.