[JIRA] [release-plugin] (JENKINS-27722) upgrade to the release plugin has left the plugin broken
dan tran commented on JENKINS-27722 upgrade to the release plugin has left the plugin broken @Glen Yes It is from your fork. I am using Jenkins 1.596.2, suse 11.3 x64, jdk8. I can see the release configuration in my job, and when enable, configured and save the job config, the release option at navigation is not visible Not sure what more I can provide This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [job-dsl-plugin] (JENKINS-27891) Support ignoreNotifyCommit for Git Plugin
Christian Galsterer closed JENKINS-27891 as Fixed Support ignoreNotifyCommit for Git Plugin Will be included in 1.33 Change By: Christian Galsterer (11/Apr/15 6:45 PM) Status: Resolved Closed This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [ec2-plugin] (JENKINS-24359) Allow more than one cloud definition per region, to support multiple accounts using the same region.
SCM/JIRA link daemon commented on JENKINS-24359 Allow more than one cloud definition per region, to support multiple accounts using the same region. Code changed in jenkins User: Francis Upton Path: src/main/java/hudson/plugins/ec2/AmazonEC2Cloud.java src/main/resources/hudson/plugins/ec2/AmazonEC2Cloud/config-entries.jelly src/main/resources/hudson/plugins/ec2/EC2Cloud/computerSet.jelly src/main/resources/hudson/plugins/ec2/Messages.properties src/test/java/hudson/plugins/ec2/AmazonEC2CloudTest.java src/test/java/hudson/plugins/ec2/SlaveTemplateTest.java src/test/java/hudson/plugins/ec2/TemplateLabelsTest.java http://jenkins-ci.org/commit/ec2-plugin/cbe044e737c169ab2fc322000916d91853a5789a Log: Merge pull request #132 from sirca/feature/multiple-clouds-per-region JENKINS-24359: Overcoming limit of one cloud per region. Compare: https://github.com/jenkinsci/ec2-plugin/compare/1ba2206f4345...cbe044e737c1 This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [workflow-plugin] (JENKINS-27893) Varargs mishandled in Groovy CPS
Thomas Dalton commented on JENKINS-27893 Varargs mishandled in Groovy CPS Thanks Jesse. For the benefit of others I've tried the following: node { fn1("This should only be one string") fn1("Two", "Strings") fn2(["is", "This", "Three?"]) fn3(["What", "about", "this?"] as String[]) fn4(["Or", "perhaps", "this?"]) } def fn1 (String... strs) { echo "${strs.size()}" def String s = "" for (int i = 0; i strs.size(); i++) { s += "${strs[i]} " } echo "$s" } def fn2 (strs) { echo "${strs.size()}" def String s = "" for (int i = 0; i strs.size(); i++) { s += "${strs[i]} " } echo "$s" } def fn3 (String[] strs) { echo "${strs.size()}" def String s = "" for (int i = 0; i strs.size(); i++) { s += "${strs[i]} " } echo "$s" } def fn4 (List strs) { echo "${strs.size()}" def String s = "" for (int i = 0; i strs.size(); i++) { s += "${strs[i]} " } echo "$s" } Here were the results: Running: Allocate node : Start Running on master in /nobackup/thdalton/jenkins/workspace/Sandbox Running: Allocate node : Body : Start Running: Print Message 30 Running: Print Message T h i s s h o u l d o n l y b e o n e s t r i n g Running: Print Message 3 Running: Print Message T w o Running: Print Message 3 Running: Print Message is This Three? Running: Print Message 4 Running: Print Message W h a t Running: Print Message 3 Running: Print Message Or perhaps this? Running: Allocate node : Body : End Running: Allocate node : End Running: End of Workflow Finished: SUCCESS I think I prefer the explicit List in fn4() so I shall go with that thanks. This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [core] (JENKINS-27871) Block on upstream projects does not work
stephenconnolly commented on JENKINS-27871 Block on upstream projects does not work Cool I'll set them both up for a run-off to see if either breaks the issue I was trying to fix and see which is better performing... (I also have a 3rd variant of the 2nd version that should be more performant and less likely to cause a regression elsewhere, but as it's more complex...) I would expect to get the fix committed towards 1.610... if 1.607-1.609 get selected for the next LTS then the fix for this should be a viable candidate for back-porting as it does not change any exposed APIs This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [git-plugin] (JENKINS-27902) Allow to pass additional request parameter for notifyCommit
Christian Galsterer commented on JENKINS-27902 Allow to pass additional request parameter for notifyCommit PR available at https://github.com/jenkinsci/git-plugin/pull/315 This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [analysis-collector-plugin] (JENKINS-27890) FindBugs report does not correctly indicate New/Fixed warnings
Ulli Hafner commented on JENKINS-27890 FindBugs report does not correctly indicate New/Fixed warnings I'm using FindBugs instance hash to identify new or old warnings. Maybe it is not computed correctly by FindBugs. Can you please attach the findbugs-warnings.xml files of my plugin that are located in the corresponding build folder in your Jenkins instance? This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [git-plugin] (JENKINS-27902) Allow to pass additional request parameter for notifyCommit
Christian Galsterer started work on JENKINS-27902 Allow to pass additional request parameter for notifyCommit Change By: Christian Galsterer (11/Apr/15 8:18 PM) Status: Open InProgress This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [core] (JENKINS-9913) Not obvious why some post-build tasks enforce serial behavior even when builds are concurrent
SCM/JIRA link daemon commented on JENKINS-9913 Not obvious why some post-build tasks enforce serial behavior even when builds are concurrent Code changed in jenkins User: Tim-Clifford Path: src/main/java/jenkins/plugins/slack/ActiveNotifier.java http://jenkins-ci.org/commit/slack-plugin/832e7b50028ca086dd49311ce454e7a19c9a3af9 Log: Change .getPreviousBuild() to allow for higher concurrency Jenkins changed getPreviousBuild() to halt jobs if a previous build hasn't finished, meaning jobs of variable runtime end up being serialized: https://issues.jenkins-ci.org/browse/JENKINS-9913?focusedCommentId=184188page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-184188 This change switches to the latest completed build, allowing this plugin to work with jobs of variable length. This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [email-ext-plugin] (JENKINS-27540) FILE macro is generically useful and could be part of the token-macro plugin
Alex Earl resolved JENKINS-27540 as Fixed FILE macro is generically useful and could be part of the token-macro plugin Added FILE macro to token-macro. Change By: Alex Earl (11/Apr/15 8:53 PM) Status: Open Resolved Resolution: Fixed This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [job-dsl-plugin] (JENKINS-16365) allPermissions should try to load Jenkins's list of permissions
Daniel Spilker commented on JENKINS-16365 allPermissions should try to load Jenkinss list of permissions Will be fixed in 1.33, see https://github.com/jenkinsci/job-dsl-plugin/pull/447. This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [core] (JENKINS-27871) Block on upstream projects does not work
Paul Draper commented on JENKINS-27871 Block on upstream projects does not work @stephenconnolly, that change also works. This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [active-directory-plugin] (JENKINS-24958) UsernameNotFoundException when ActiveDirectory used for API and token authentication
Keith Davis reopened JENKINS-24958 UsernameNotFoundException when ActiveDirectory used for API and token authentication Change By: Keith Davis (11/Apr/15 8:46 PM) Resolution: Incomplete Status: Resolved Reopened This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [active-directory-plugin] (JENKINS-24958) UsernameNotFoundException when ActiveDirectory used for API and token authentication
Keith Davis commented on JENKINS-24958 UsernameNotFoundException when ActiveDirectory used for API and token authentication I'm having this same problem. What info exactly do you need? This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [ec2-plugin] (JENKINS-27260) SPNEGO for Windows in the EC2 Plugin
SCM/JIRA link daemon commented on JENKINS-27260 SPNEGO for Windows in the EC2 Plugin Code changed in jenkins User: Jason Mittertreiner Path: src/main/java/hudson/plugins/ec2/win/EC2WindowsLauncher.java src/main/java/hudson/plugins/ec2/win/winrm/WinRMClient.java http://jenkins-ci.org/commit/ec2-plugin/0e840f7129b91af5101cb8f08f938743dc188ff9 Log: JENKINS-27260 SPNEGO for Windows in EC2 Plugin Fixed the Windows temp directory getting set to "" Enabled SPNEGO authentication JENKINS-25385 and JENKINS-4995 both have comments complaining about infinite loops when creating Windows slaves. Because SPNEGO is unregistered for, the httpclient throws and exception that is silently caught and causes the infinite loop. This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [ec2-plugin] (JENKINS-25385) Jenkins EC2 plugin is not able to launch Windows Slaves in AWS
SCM/JIRA link daemon commented on JENKINS-25385 Jenkins EC2 plugin is not able to launch Windows Slaves in AWS Code changed in jenkins User: Jason Mittertreiner Path: src/main/java/hudson/plugins/ec2/win/EC2WindowsLauncher.java src/main/java/hudson/plugins/ec2/win/winrm/WinRMClient.java http://jenkins-ci.org/commit/ec2-plugin/0e840f7129b91af5101cb8f08f938743dc188ff9 Log: JENKINS-27260 SPNEGO for Windows in EC2 Plugin Fixed the Windows temp directory getting set to "" Enabled SPNEGO authentication JENKINS-25385 and JENKINS-4995 both have comments complaining about infinite loops when creating Windows slaves. Because SPNEGO is unregistered for, the httpclient throws and exception that is silently caught and causes the infinite loop. This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [ec2-plugin] (JENKINS-4995) Support windows AMI's in EC2 plugin
SCM/JIRA link daemon commented on JENKINS-4995 Support windows AMIs in EC2 plugin Code changed in jenkins User: Jason Mittertreiner Path: src/main/java/hudson/plugins/ec2/win/EC2WindowsLauncher.java src/main/java/hudson/plugins/ec2/win/winrm/WinRMClient.java http://jenkins-ci.org/commit/ec2-plugin/0e840f7129b91af5101cb8f08f938743dc188ff9 Log: JENKINS-27260 SPNEGO for Windows in EC2 Plugin Fixed the Windows temp directory getting set to "" Enabled SPNEGO authentication JENKINS-25385 and JENKINS-4995 both have comments complaining about infinite loops when creating Windows slaves. Because SPNEGO is unregistered for, the httpclient throws and exception that is silently caught and causes the infinite loop. This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [ec2-plugin] (JENKINS-27260) SPNEGO for Windows in the EC2 Plugin
SCM/JIRA link daemon commented on JENKINS-27260 SPNEGO for Windows in the EC2 Plugin Code changed in jenkins User: Francis Upton Path: src/main/java/hudson/plugins/ec2/win/EC2WindowsLauncher.java src/main/java/hudson/plugins/ec2/win/winrm/WinRMClient.java http://jenkins-ci.org/commit/ec2-plugin/1ba2206f4345d08de2c8dc4261b52bef206f0010 Log: Merge pull request #138 from jmittert/JENKINS-27260 JENKINS-27260 SPNEGO for Windows in EC2 Plugin Compare: https://github.com/jenkinsci/ec2-plugin/compare/8a4454a1d30a...1ba2206f4345 This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [analysis-collector-plugin] (JENKINS-27890) FindBugs report does not correctly indicate New/Fixed warnings
Vlad Nikiforov commented on JENKINS-27890 FindBugs report does not correctly indicate New/Fixed warnings Hmm, actually FindBugs-Issue.zip contains two build folder snapshots taken from Jenkins instance. If the file you need is not there, then where can I look for it? This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [email-ext-plugin] (JENKINS-27540) FILE macro is generically useful and could be part of the token-macro plugin
SCM/JIRA link daemon commented on JENKINS-27540 FILE macro is generically useful and could be part of the token-macro plugin Code changed in jenkins User: Alex Earl Path: pom.xml src/main/java/org/jenkinsci/plugins/tokenmacro/impl/WorkspaceFileMacro.java src/test/java/org/jenkinsci/plugins/tokenmacro/impl/AdminEmailMacroTest.java src/test/java/org/jenkinsci/plugins/tokenmacro/impl/EnvironmentVariableMacroTest.java src/test/java/org/jenkinsci/plugins/tokenmacro/impl/LogRegExMacroTest.java src/test/java/org/jenkinsci/plugins/tokenmacro/impl/PropertyFromFileMacroTest.java src/test/java/org/jenkinsci/plugins/tokenmacro/impl/WorkspaceFileMacroTest.java http://jenkins-ci.org/commit/token-macro-plugin/e74bf1c4898ab0359bf5e4e3f5c54e6efbd520d3 Log: Fix JENKINS-27540 Add FILE macro. This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [throttle-concurrent-builds-plugin] (JENKINS-27708) Concurrent build limits not honored on Jenkins 1.607
stephenconnolly commented on JENKINS-27708 Concurrent build limits not honored on Jenkins 1.607 http://repo.jenkins-ci.org/snapshots/org/jenkins-ci/main/jenkins-war/1.609-SNAPSHOT/jenkins-war-1.609-20150411.073620-2.war is an alternative attempt. It would be good if you could confirm that it also resolves the issue. diff --git a/core/src/main/java/hudson/model/Queue.java b/core/src/main/java/hudson/model/Queue.java index d776a57..3c9367a 100644 --- a/core/src/main/java/hudson/model/Queue.java +++ b/core/src/main/java/hudson/model/Queue.java @@ -844,6 +844,17 @@ public class Queue extends ResourceController implements Saveable { * Gets all the {@link BuildableItem}s that are waiting for an executor in the given {@link Computer}. */ public ListBuildableItem getBuildableItems(Computer c) { +if (lock.tryLock()) { +// JENKINS-22708 and JENKINS-27871, if we can get the lock, return live +try { +ListBuildableItem result = new ArrayListBuildableItem(); +_getBuildableItems(c, buildables, result); +_getBuildableItems(c, pendings, result); +return result; +} finally { +lock.unlock(); +} +} Snapshot snapshot = this.snapshot; ListBuildableItem result = new ArrayListBuildableItem(); _getBuildableItems(c, snapshot.buildables, result); @@ -865,6 +876,16 @@ public class Queue extends ResourceController implements Saveable { * Gets the snapshot of all {@link BuildableItem}s. */ public ListBuildableItem getBuildableItems() { +if (lock.tryLock()) { +// JENKINS-22708 and JENKINS-27871, if we can get the lock, return live +try { +ArrayListBuildableItem r = new ArrayListBuildableItem(buildables); +r.addAll(pendings); +return r; +} finally { +lock.unlock(); +} +} Snapshot snapshot = this.snapshot; ArrayListBuildableItem r = new ArrayListBuildableItem(snapshot.buildables); r.addAll(snapshot.pendings); @@ -875,6 +896,14 @@ public class Queue extends ResourceController implements Saveable { * Gets the snapshot of all {@link BuildableItem}s. */ public ListBuildableItem getPendingItems() { +if (lock.tryLock()) { +// JENKINS-22708 and JENKINS-27871, if we can get the lock, return live +try { +return new ArrayListBuildableItem(pendings); +} finally { +lock.unlock(); +} +} return new ArrayListBuildableItem(snapshot.pendings); } @@ -902,6 +931,19 @@ public class Queue extends ResourceController implements Saveable { * @since 1.402 */ public ListItem getUnblockedItems() { +if (lock.tryLock()) { +// JENKINS-22708 and JENKINS-27871, if we can get the lock, return live +try { +ListItem queuedNotBlocked = new ArrayListItem(); +queuedNotBlocked.addAll(waitingList); +queuedNotBlocked.addAll(buildables); +queuedNotBlocked.addAll(pendings); +// but not 'blockedProjects' +return queuedNotBlocked; +} finally { +lock.unlock(); +} +} Snapshot snapshot = this.snapshot; ListItem queuedNotBlocked = new ArrayListItem(); queuedNotBlocked.addAll(snapshot.waitingList); @@ -928,6 +970,16 @@ public class Queue extends ResourceController implements Saveable { * Is the given task currently pending execution? */ public boolean isPending(Task t) { +if (lock.tryLock()) { +try { +for (BuildableItem i : pendings) +if (i.task.equals(t)) +return true; +return false; +} finally { +lock.unlock(); +} +} Snapshot snapshot = this.snapshot; for (BuildableItem i : snapshot.pendings) if (i.task.equals(t)) If both work then I will fire each up on my test bed environment and see which passes the concurrency and lock stress... then we commit the simpler fix.
[JIRA] [core] (JENKINS-27871) Block on upstream projects does not work
stephenconnolly commented on JENKINS-27871 Block on upstream projects does not work http://repo.jenkins-ci.org/snapshots/org/jenkins-ci/main/jenkins-war/1.609-SNAPSHOT/jenkins-war-1.609-20150411.073620-2.war is an alternative attempt. It would be good if you could confirm that it also resolves the issue. diff --git a/core/src/main/java/hudson/model/Queue.java b/core/src/main/java/hudson/model/Queue.java index d776a57..3c9367a 100644 --- a/core/src/main/java/hudson/model/Queue.java +++ b/core/src/main/java/hudson/model/Queue.java @@ -844,6 +844,17 @@ public class Queue extends ResourceController implements Saveable { * Gets all the {@link BuildableItem}s that are waiting for an executor in the given {@link Computer}. */ public ListBuildableItem getBuildableItems(Computer c) { +if (lock.tryLock()) { +// JENKINS-22708 and JENKINS-27871, if we can get the lock, return live +try { +ListBuildableItem result = new ArrayListBuildableItem(); +_getBuildableItems(c, buildables, result); +_getBuildableItems(c, pendings, result); +return result; +} finally { +lock.unlock(); +} +} Snapshot snapshot = this.snapshot; ListBuildableItem result = new ArrayListBuildableItem(); _getBuildableItems(c, snapshot.buildables, result); @@ -865,6 +876,16 @@ public class Queue extends ResourceController implements Saveable { * Gets the snapshot of all {@link BuildableItem}s. */ public ListBuildableItem getBuildableItems() { +if (lock.tryLock()) { +// JENKINS-22708 and JENKINS-27871, if we can get the lock, return live +try { +ArrayListBuildableItem r = new ArrayListBuildableItem(buildables); +r.addAll(pendings); +return r; +} finally { +lock.unlock(); +} +} Snapshot snapshot = this.snapshot; ArrayListBuildableItem r = new ArrayListBuildableItem(snapshot.buildables); r.addAll(snapshot.pendings); @@ -875,6 +896,14 @@ public class Queue extends ResourceController implements Saveable { * Gets the snapshot of all {@link BuildableItem}s. */ public ListBuildableItem getPendingItems() { +if (lock.tryLock()) { +// JENKINS-22708 and JENKINS-27871, if we can get the lock, return live +try { +return new ArrayListBuildableItem(pendings); +} finally { +lock.unlock(); +} +} return new ArrayListBuildableItem(snapshot.pendings); } @@ -902,6 +931,19 @@ public class Queue extends ResourceController implements Saveable { * @since 1.402 */ public ListItem getUnblockedItems() { +if (lock.tryLock()) { +// JENKINS-22708 and JENKINS-27871, if we can get the lock, return live +try { +ListItem queuedNotBlocked = new ArrayListItem(); +queuedNotBlocked.addAll(waitingList); +queuedNotBlocked.addAll(buildables); +queuedNotBlocked.addAll(pendings); +// but not 'blockedProjects' +return queuedNotBlocked; +} finally { +lock.unlock(); +} +} Snapshot snapshot = this.snapshot; ListItem queuedNotBlocked = new ArrayListItem(); queuedNotBlocked.addAll(snapshot.waitingList); @@ -928,6 +970,16 @@ public class Queue extends ResourceController implements Saveable { * Is the given task currently pending execution? */ public boolean isPending(Task t) { +if (lock.tryLock()) { +try { +for (BuildableItem i : pendings) +if (i.task.equals(t)) +return true; +return false; +} finally { +lock.unlock(); +} +} Snapshot snapshot = this.snapshot; for (BuildableItem i : snapshot.pendings) if (i.task.equals(t)) If both work then I will fire each up on my test bed environment and see which passes the concurrency and lock stress... then we commit the simpler fix.
[JIRA] [subversion-plugin] (JENKINS-17228) Fail build when subversion workspace is locked
Paavo Helde commented on JENKINS-17228 Fail build when subversion workspace is locked This issue is about when Jenkins has checked out and updating the working copy by itself. In this scenario every job should get its own workspace so concurrent access to it should not happen AFAIK. If there is concurrent access this probably means the svn checkout was not done by Jenkins; that would also explain why it does not attempt to wipe the workspace. Or have I misunderstood something here? Running concurrent builds in the same checkout folder seems not so good idea anyway. Jenkins provides an easy way to avoid that by setting the allowed number of executors to 1. This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [mercurial-plugin] (JENKINS-27749) Incoming Changeset Message Regex
Jesse Glick started work on JENKINS-27749 Incoming Changeset Message Regex Change By: Jesse Glick (11/Apr/15 1:47 PM) Status: Open InProgress This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [mercurial-plugin] (JENKINS-27749) Incoming Changeset Message Regex
Jesse Glick updated JENKINS-27749 Incoming Changeset Message Regex Change By: Jesse Glick (11/Apr/15 1:47 PM) Status: Reopened Open This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [workflow-plugin] (JENKINS-27893) Varargs mishandled in Groovy CPS
Jesse Glick updated JENKINS-27893 Varargs mishandled in Groovy CPS You may be the first to try to use varargs in a Groovy CPS-transformed script. Disambiguating varargs calls is complicated enough in Java, and argument handling is an order of magnitude more complicated in Groovy, so I am not that surprised it does not work. The following does work: fn(["This should only be one string"]) def fn(strs) { echo "${strs.size()}" } Change By: Jesse Glick (11/Apr/15 1:47 PM) Summary: Stringarrays,orvariableargspassedtofunctionsdontseemtowork VarargsmishandledinGroovyCPS Priority: Minor Major Assignee: JesseGlick KohsukeKawaguchi This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [mercurial-plugin] (JENKINS-27749) Incoming Changeset Message Regex
Jesse Glick reopened JENKINS-27749 Incoming Changeset Message Regex Change By: Jesse Glick (11/Apr/15 1:47 PM) Resolution: Fixed Status: Resolved Reopened This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [core] (JENKINS-27901) Standard form control for string collections
SCM/JIRA link daemon commented on JENKINS-27901 Standard form control for string collections Code changed in jenkins User: Jesse Glick Path: basic-steps/src/main/java/org/jenkinsci/plugins/workflow/steps/EnvStep.java http://jenkins-ci.org/commit/workflow-plugin/df1825c211c5c6be0875c9d4c334c9f7aed3d8ba Log: JENKINS-27901 Noting. This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [core] (JENKINS-26781) regression resolving Descriptor using $class vs kind
Jesse Glick updated JENKINS-26781 regression resolving Descriptor using $class vs kind Change By: Jesse Glick (11/Apr/15 3:23 PM) Labels: api regression stapler This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [core] (JENKINS-26781) regression resolving Descriptor using $class vs kind
Jesse Glick updated JENKINS-26781 regression resolving Descriptor using $class vs kind Change By: Jesse Glick (11/Apr/15 3:23 PM) Labels: apistapler This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [core] (JENKINS-26781) regression resolving Descriptor using $class vs kind
Jesse Glick reopened JENKINS-26781 regression resolving Descriptor using $class vs kind I think this remains legitimate. Change By: Jesse Glick (11/Apr/15 3:23 PM) Resolution: WontFix Status: Resolved Reopened This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [publish-over-ssh-plugin] (JENKINS-27903) Allow ssh server definition from job configuration
Matthew Holt created JENKINS-27903 Allow ssh server definition from job configuration Issue Type: Improvement Assignee: bap Components: publish-over-ssh-plugin Created: 11/Apr/15 4:10 PM Description: We have several teams using the Publish over ssh plugin on a single Jenkins master. It would be helpful to allow them to specify the server information they should connect to in the job itself, and not just the master configuration. However, if there are security reasons this shouldn't be done, please ignore. Project: Jenkins Priority: Minor Reporter: Matthew Holt This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [publish-over-ssh-plugin] (JENKINS-27903) Allow ssh server definition from job configuration
Matthew Holt updated JENKINS-27903 Allow ssh server definition from job configuration Great plugin, thank you for your work! Change By: Matthew Holt (11/Apr/15 4:10 PM) Description: WehaveseveralteamsusingthePublishoversshpluginonasingleJenkinsmaster.Itwouldbehelpfultoallowthemtospecifytheserverinformationtheyshouldconnecttointhejobitself,andnotjustthemasterconfiguration.However,iftherearesecurityreasonsthisshouldntbedone,pleaseignore thisrequest . This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [core] (JENKINS-26781) regression resolving Descriptor using $class vs kind
Jesse Glick updated JENKINS-26781 regression resolving Descriptor using $class vs kind Change By: Jesse Glick (11/Apr/15 5:26 PM) Priority: Major Critical Assignee: NicolasDeLoof JesseGlick This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [core] (JENKINS-26781) regression resolving Descriptor using $class vs kind
Jesse Glick started work on JENKINS-26781 regression resolving Descriptor using $class vs kind Change By: Jesse Glick (11/Apr/15 4:18 PM) Status: Open InProgress This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [core] (JENKINS-26781) regression resolving Descriptor using $class vs kind
Jesse Glick updated JENKINS-26781 regression resolving Descriptor using $class vs kind Change By: Jesse Glick (11/Apr/15 4:18 PM) Status: Reopened Open This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [unity3d-plugin] (JENKINS-27896) Running a Unity3dBuilder Plugin step on a Jenkins slave configured to run as a Windows service is broken
lacostej commented on JENKINS-27896 Running a Unity3dBuilder Plugin step on a Jenkins slave configured to run as a Windows service is broken Hello Victor, Is this the same as JENKINS-24265 ? Are you using version 0.7 of the plugin ? I've made a change in v0.7 to help troubleshoot that particular issue. In fact from v0.7, it should not hang, just not display the console. I need help troubleshooting it as I don't have a Windows server right now. Contact me @lacostej on skype if you can. This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [release-plugin] (JENKINS-27722) upgrade to the release plugin has left the plugin broken
dan tran commented on JENKINS-27722 upgrade to the release plugin has left the plugin broken I am able to verify that the steps from last comment is correct. I do see your changes in Eclipse Git history at JENKINS-27222 branch. Also, I also see your unit test failure on my windows using java 7 and 8 Tests in error: createJobAndCheckButton(hudson.plugins.release.TestJobCreation): elementName=input attributeName=name attributeVal ue=hudson-plugins-release-ReleaseWrapper This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [nunit-plugin] (JENKINS-27906) Fail to read NUnit3 output xml
apgray created JENKINS-27906 Fail to read NUnit3 output xml Issue Type: Bug Assignee: Bruno P. Kinoshita Components: nunit-plugin Created: 12/Apr/15 4:32 AM Description: When I run NUnit tests using the NUnit 3 Beta 1 the tests execute but the build fails when the NUnit plugin tries to publish the results. Exception I get in Jenkins console is: Test Run Summary Overall result: Passed Tests run: 9, Passed: 9, Errors: 0, Failures: 0, Inconclusive: 0 Not run: 0, Invalid: 0, Ignored: 0, Skipped: 0 Start time: 2015-04-12 04:15:47Z End time: 2015-04-12 04:24:43Z Duration: 535.974 seconds Results (nunit3) saved as nunit-selenium-testsuite.xml Recording NUnit tests results ERROR: Publisher hudson.plugins.nunit.NUnitPublisher aborted due to exception hudson.util.IOException2: Could not transform the NUnit report. Please report this issue to the plugin author at hudson.plugins.nunit.NUnitArchiver.invoke(NUnitArchiver.java:60) at hudson.plugins.nunit.NUnitArchiver.invoke(NUnitArchiver.java:26) at hudson.FilePath.act(FilePath.java:989) at hudson.FilePath.act(FilePath.java:967) at hudson.plugins.nunit.NUnitPublisher.perform(NUnitPublisher.java:116) at hudson.tasks.BuildStepMonitor$3.perform(BuildStepMonitor.java:45) at hudson.model.AbstractBuild$AbstractBuildExecution.perform(AbstractBuild.java:761) at hudson.model.AbstractBuild$AbstractBuildExecution.performAllBuildSteps(AbstractBuild.java:721) at hudson.model.Build$BuildExecution.post2(Build.java:183) at hudson.model.AbstractBuild$AbstractBuildExecution.post(AbstractBuild.java:670) at hudson.model.Run.execute(Run.java:1766) at hudson.model.FreeStyleBuild.run(FreeStyleBuild.java:43) at hudson.model.ResourceController.execute(ResourceController.java:98) at hudson.model.Executor.run(Executor.java:374) Caused by: org.xml.sax.SAXParseException; systemId: file:/C:/Jenkins/workspace/Saucery3NUnit/temporary-junit-reports/temp-junit.xml; lineNumber: 12; columnNumber: 9; Content is not allowed in prolog. at com.sun.org.apache.xerces.internal.parsers.DOMParser.parse(DOMParser.java:257) at com.sun.org.apache.xerces.internal.jaxp.DocumentBuilderImpl.parse(DocumentBuilderImpl.java:348) at javax.xml.parsers.DocumentBuilder.parse(DocumentBuilder.java:205) at hudson.plugins.nunit.NUnitReportTransformer.splitJUnitFile(NUnitReportTransformer.java:102) at hudson.plugins.nunit.NUnitReportTransformer.transform(NUnitReportTransformer.java:72) at hudson.plugins.nunit.NUnitArchiver.invoke(NUnitArchiver.java:55) Environment: Windows Project: Jenkins Labels: plugin nunit Priority: Minor Reporter: apgray This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [release-plugin] (JENKINS-27722) upgrade to the release plugin has left the plugin broken
dan tran edited a comment on JENKINS-27722 upgrade to the release plugin has left the plugin broken I am able to verify that the steps from last comment is correct. I do see your changes in Eclipse Git history at JENKINS-27222 branch. Also, I also see unit test failure on my windows using java 7 and 8, BUT passes at my suse linux. Tests in error: createJobAndCheckButton(hudson.plugins.release.TestJobCreation): elementName=input attributeName=name attributeVal ue=hudson-plugins-release-ReleaseWrapper I loaded the release.hpi built by both and windows and linux with the same result This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [mercurial-plugin] (JENKINS-10706) MERCURIAL_BRANCH environment variable
SCM/JIRA link daemon resolved JENKINS-10706 as Fixed MERCURIAL_BRANCH environment variable Change By: SCM/JIRA link daemon (11/Apr/15 1:59 PM) Status: Open Resolved Resolution: Fixed This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [mercurial-plugin] (JENKINS-10706) MERCURIAL_BRANCH environment variable
SCM/JIRA link daemon commented on JENKINS-10706 MERCURIAL_BRANCH environment variable Code changed in jenkins User: Jesse Glick Path: src/main/java/hudson/plugins/mercurial/HgExe.java src/main/java/hudson/plugins/mercurial/MercurialSCM.java src/main/java/hudson/plugins/mercurial/MercurialTagAction.java src/main/resources/hudson/plugins/mercurial/Messages.properties src/test/java/hudson/plugins/mercurial/ChangeComparatorTest.java src/test/java/hudson/plugins/mercurial/HgExeFunctionalTest.java src/test/java/hudson/plugins/mercurial/MercurialSCMTest.java src/test/java/hudson/plugins/mercurial/MercurialTagActionTest.java src/test/java/hudson/plugins/mercurial/SCMTestBase.java http://jenkins-ci.org/commit/mercurial-plugin/f3fd807f20d1ab1bd49698a389ad24fd061afa87 Log: Merge pull request #62 from misery/master FIXED JENKINS-10706 Add env variable MERCURIAL_REVISION_BRANCH A couple of minor comments outstanding, but those can be fixed up later or not at all. Compare: https://github.com/jenkinsci/mercurial-plugin/compare/5e5b7ca8b055...f3fd807f20d1 This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [mercurial-plugin] (JENKINS-10706) MERCURIAL_BRANCH environment variable
SCM/JIRA link daemon commented on JENKINS-10706 MERCURIAL_BRANCH environment variable Code changed in jenkins User: André Klitzing Path: src/main/java/hudson/plugins/mercurial/HgExe.java src/main/java/hudson/plugins/mercurial/MercurialSCM.java src/main/java/hudson/plugins/mercurial/MercurialTagAction.java src/main/resources/hudson/plugins/mercurial/Messages.properties src/test/java/hudson/plugins/mercurial/ChangeComparatorTest.java src/test/java/hudson/plugins/mercurial/MercurialSCMTest.java src/test/java/hudson/plugins/mercurial/MercurialTagActionTest.java http://jenkins-ci.org/commit/mercurial-plugin/1140b3b276bf0452ad009b2eef8200fd2c0f930e Log: JENKINS-10706 Add env variable MERCURIAL_REVISION_BRANCH This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [git-plugin] (JENKINS-27902) Allow to pass additional request parameter for notifyCommit
Christian Galsterer created JENKINS-27902 Allow to pass additional request parameter for notifyCommit Issue Type: New Feature Assignee: Christian Galsterer Components: git-plugin Created: 11/Apr/15 3:09 PM Description: When calling notifyCommit it should be possible to pass additional request parameter to the notifyCommit URL and when a job is triggered the parameters are passed on the triggered job, similar to "buildWithParameters", but that the parameters are part of the call to notifyCommit. This is e.g. valuable when an external system is triggering the Jenkins job with the Git notifyCommit Url and needs to pass additional parameter, e.g. the reason for the triggering or pull request identifier. Project: Jenkins Priority: Major Reporter: Christian Galsterer This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [job-dsl-plugin] (JENKINS-27891) Support ignoreNotifyCommit for Git Plugin
SCM/JIRA link daemon commented on JENKINS-27891 Support ignoreNotifyCommit for Git Plugin Code changed in jenkins User: Christian Galsterer Path: docs/Home.md docs/Job-reference.md job-dsl-core/src/main/groovy/javaposse/jobdsl/dsl/helpers/ScmContext.groovy job-dsl-core/src/main/groovy/javaposse/jobdsl/dsl/helpers/scm/GitContext.groovy job-dsl-core/src/test/groovy/javaposse/jobdsl/dsl/helpers/ScmContextSpec.groovy http://jenkins-ci.org/commit/job-dsl-plugin/30e66ca12d0d0d6b0c87d8d9057216fa9ee88f63 Log: JENKINS-27891 Support ignoreNotifyCommit for Git Plugin This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [release-plugin] (JENKINS-27722) upgrade to the release plugin has left the plugin broken
Glen Ritchie commented on JENKINS-27722 upgrade to the release plugin has left the plugin broken @dan tran, Was that from my fork or the official git repo? I haven't done a pull request yet to the official so it hasn't been merged. I'm having difficulty reproducing this issue, can you post more information about the environment you are using to test and maybe some steps to reproduce (including any and all versions that you are using) as well? In addition can you verify the "Configure release build" option is enabled in the job configuration? This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [workflow-plugin] (JENKINS-27893) String arrays, or variable args passed to functions don't seem to work
Jesse Glick updated JENKINS-27893 String arrays, or variable args passed to functions dont seem to work Change By: Jesse Glick (11/Apr/15 1:35 PM) Labels: jenkinsworkflow groovy This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [core] (JENKINS-27901) Standard form control for string collections
Jesse Glick created JENKINS-27901 Standard form control for string collections Issue Type: New Feature Assignee: Unassigned Components: core Created: 11/Apr/15 2:30 PM Description: There is not a great way in Jenkins databinding to handle String[]-valued properties. The general best practice is to make the property name as understood by Stapler (data binding) match the property name as understood by XStream (serial form), and for the type of both to be natural (a collection of some kind rather than a text blob). This makes for more consistent and predictable interaction with ways of defining job configuration other than the web UI. This tends to matter for the Workflow plugins (Describable objects instantiated as part of Step configuration from the Groovy DSL); Job DSL plugin; YAML Project plugin; etc. This commit gives an example of how you can make these align, even using the standard textarea.jelly control. The trick is to override Descriptor.newInstance. This is awkward though, and prevents you from using automatic databinding for other properties of the same class. It would be preferable to have a standard form control dedicated to representing a list of strings, probably rendered as a textarea (split on newlines and whitespace trimmed), though a series of textboxes with Add/Remove buttons is also an option. The representation created by buildFormTree should be a JSON array, which I believe Stapler already knows how to bind to Java arrays and/or lists; and FormChecker would ideally let you use a collection type in @QueryParameter for doCheck* methods as well. (Using a SetString as the property type is dubious, because duplicates will be silently deleted when the form is saved. Perhaps better to use a FormValidation warning to alert the user if duplicates are unwanted for the particular property.) Project: Jenkins Labels: api jelly stapler form-data workflow Priority: Major Reporter: Jesse Glick This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [job-dsl-plugin] (JENKINS-27894) Add Fingerprint artifacts to CopyArtifacts closure options
SCM/JIRA link daemon commented on JENKINS-27894 Add Fingerprint artifacts to CopyArtifacts closure options Code changed in jenkins User: Daniel Spilker Path: docs/Home.md docs/Job-reference.md job-dsl-core/src/main/groovy/javaposse/jobdsl/dsl/helpers/step/CopyArtifactContext.groovy job-dsl-core/src/main/groovy/javaposse/jobdsl/dsl/helpers/step/StepContext.groovy job-dsl-core/src/test/groovy/javaposse/jobdsl/dsl/helpers/step/StepContextSpec.groovy http://jenkins-ci.org/commit/job-dsl-plugin/ff3fe16db4ddd2f3cafb5e8d6828ecbba9e0cce6 Log: Merge branch 'JENKINS-27894' Compare: https://github.com/jenkinsci/job-dsl-plugin/compare/6191aea5a00f...ff3fe16db4dd This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [job-dsl-plugin] (JENKINS-27894) Add Fingerprint artifacts to CopyArtifacts closure options
Daniel Spilker resolved JENKINS-27894 as Fixed Add Fingerprint artifacts to CopyArtifacts closure options Will be released in 1.33. Change By: Daniel Spilker (11/Apr/15 12:37 PM) Status: Open Resolved Resolution: Fixed This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [workflow-plugin] (JENKINS-27904) Access to currentBuild.getStartTime in Jenkins Workflow
Metin OSMAN created JENKINS-27904 Access to currentBuild.getStartTime in Jenkins Workflow Issue Type: Improvement Assignee: Jesse Glick Components: workflow-plugin Created: 11/Apr/15 10:15 PM Description: Hi, my application version number relies on the build start time. I need to set up a BUILD_TIMESTAMP variable at the beginning of my workflow. It will be more convenient to give access to the currentBuild.getStartTime instead of/beside currentBuild.getStartTimeInMillis, so I can then format it directly. Thanks Environment: workflow-plugin 1.5 Project: Jenkins Priority: Minor Reporter: Metin OSMAN This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [workflow-plugin] (JENKINS-27905) Use of stage concurrency only allows 1 thread to be blocked at a time
Thomas Dalton updated JENKINS-27905 Use of stage concurrency only allows 1 thread to be blocked at a time Change By: Thomas Dalton (11/Apr/15 11:12 PM) Description: Takethefollowingscriptasanexample:{code}node{defsleeps=[:]for(inti=0;i4;i++){sleeps[num_${i}]={sleep60()}}parallel(sleeps)}defsleep60(){ws{stagename:Sleepfor60secs,concurrency:1shsleep60}}{code}Becausethestagesaremarkedwith{{concurrency:1}} ) ,Iwouldexpectthesleepstooccurinseries,butwithall parallel tasksperformed.With3,then2,then1taskblockeduntilallarecomplete.Insteadthefirstsleepruns,thesecondblocksonit,buttheothertwomysteriouslyfail,andthisactuallyresultsintheJobhangingindefinitelyandthe2nd job sleep doesntseemto getto runeither.{code}StartedbyuseranonymousRunning:Allocatenode:StartRunningonmasterin/mydir/jenkins/workspace/SandboxRunning:Allocatenode:Body:StartRunning:Executesub-workflowsinparallel:Start[num_0]Running:Parallelbranch:num_0[num_1]Running:Parallelbranch:num_1[num_2]Running:Parallelbranch:num_2[num_3]Running:Parallelbranch:num_3[num_0]Running:Allocateworkspace:Start[num_0]Runningin/mydir/jenkins/workspace/Sandbox-2[num_0]Running:Allocateworkspace:Body:Start[num_1]Running:Allocateworkspace:Start[num_1]Runningin/mydir/jenkins/workspace/Sandbox-3[num_1]Running:Allocateworkspace:Body:Start[num_2]Running:Allocateworkspace:Start[num_2]Runningin/mydir/jenkins/workspace/Sandbox-4[num_2]Running:Allocateworkspace:Body:Start[num_3]Running:Allocateworkspace:Start[num_3]Runningin/mydir/jenkins/workspace/Sandbox-5[num_3]Running:Allocateworkspace:Body:Start[num_0]Running:Sleepfor60secs[num_0]EnteringstageSleepfor60secs[num_0]Proceeding[num_0]Running:ShellScript[num_0][Sandbox-2]Runningshellscript[num_1]Running:Sleepfor60secs[num_1]EnteringstageSleepfor60secs[num_1]Waitingforbuilds[7][num_2]Running:Sleepfor60secs[num_2]EnteringstageSleepfor60secsRunning:Allocateworkspace:Body:End[num_3]Running:Sleepfor60secs[num_3]EnteringstageSleepfor60secsRunning:Allocateworkspace:Body:EndRunning:Allocateworkspace:EndRunning:Allocateworkspace:EndRunning:Executesub-workflowsinparallel:Body:EndRunning:Executesub-workflowsinparallel:Body:End[num_0]+sleep60Running:Allocateworkspace:Body:EndRunning:Allocateworkspace:EndRunning:Executesub-workflowsinparallel:Body:End{code}Iassumethisisjustabugratherthanmymisunderstandingoftheuseof{{concurrency}}butImhappytobecorrected! This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [label-linked-jobs-plugin] (JENKINS-27588) Labels used in Label Factory are shown as not used
SCM/JIRA link daemon commented on JENKINS-27588 Labels used in Label Factory are shown as not used Code changed in jenkins User: Dominique Path: src/main/java/jenkins/plugins/linkedjobs/helpers/TriggeredJobsHelper.java http://jenkins-ci.org/commit/label-linked-jobs-plugin/e7929ce180bd46853d0e78555b1e34eae6e092c6 Log: JENKINS-27588 add support for Label parameters in parameterized triggered jobs This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [release-plugin] (JENKINS-27722) upgrade to the release plugin has left the plugin broken
dan tran commented on JENKINS-27722 upgrade to the release plugin has left the plugin broken here is the steps I went thru 1. clone https://github.com/glenritchie/release-plugin.git 2. git checkout JENKINS-27722 3. Build and load target/release.hpi into my jenkins Look reasonable? Thanks This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [workflow-plugin] (JENKINS-27905) Use of stage concurrency only allows 1 thread to be blocked at a time
Thomas Dalton created JENKINS-27905 Use of stage concurrency only allows 1 thread to be blocked at a time Issue Type: Bug Assignee: Jesse Glick Components: workflow-plugin Created: 11/Apr/15 10:56 PM Description: Take the following script as an example: node { def sleeps = [ : ] for (int i = 0; i 4; i++) { sleeps["num_${i}"] = { sleep60() } } parallel(sleeps) } def sleep60 () { ws { stage name: "Sleep for 60 secs", concurrency: 1 sh "sleep 60" } } Because the stages are marked with concurrency: 1), I would expect the sleeps to occur in series, but with all parallel tasks performed. With 3, then 2, then 1 task blocked until all are complete. Instead the first sleep runs, the second blocks on it, but the other two mysteriously "fail", and this actually results in the Job hanging indefinitely and the 2nd job doesn't seem to run either. Started by user anonymous Running: Allocate node : Start Running on master in /mydir/jenkins/workspace/Sandbox Running: Allocate node : Body : Start Running: Execute sub-workflows in parallel : Start [num_0] Running: Parallel branch: num_0 [num_1] Running: Parallel branch: num_1 [num_2] Running: Parallel branch: num_2 [num_3] Running: Parallel branch: num_3 [num_0] Running: Allocate workspace : Start [num_0] Running in /mydir/jenkins/workspace/Sandbox-2 [num_0] Running: Allocate workspace : Body : Start [num_1] Running: Allocate workspace : Start [num_1] Running in /mydir/jenkins/workspace/Sandbox-3 [num_1] Running: Allocate workspace : Body : Start [num_2] Running: Allocate workspace : Start [num_2] Running in /mydir/jenkins/workspace/Sandbox-4 [num_2] Running: Allocate workspace : Body : Start [num_3] Running: Allocate workspace : Start [num_3] Running in /mydir/jenkins/workspace/Sandbox-5 [num_3] Running: Allocate workspace : Body : Start [num_0] Running: Sleep for 60 secs [num_0] Entering stage Sleep for 60 secs [num_0] Proceeding [num_0] Running: Shell Script [num_0] [Sandbox-2] Running shell script [num_1] Running: Sleep for 60 secs [num_1] Entering stage Sleep for 60 secs [num_1] Waiting for builds [7] [num_2] Running: Sleep for 60 secs [num_2] Entering stage Sleep for 60 secs Running: Allocate workspace : Body : End [num_3] Running: Sleep for 60 secs [num_3] Entering stage Sleep for 60 secs Running: Allocate workspace : Body : End Running: Allocate workspace : End Running: Allocate workspace : End Running: Execute sub-workflows in parallel : Body : End Running: Execute sub-workflows in parallel : Body : End [num_0] + sleep 60 Running: Allocate workspace : Body : End Running: Allocate workspace : End Running: Execute sub-workflows in parallel : Body : End I assume this is just a bug rather than my misunderstanding of the use of concurrency but I'm happy to be corrected! Environment: Jenkins 1.606 Workflow 1.5 Project: Jenkins Priority: Major Reporter: Thomas Dalton This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [label-linked-jobs-plugin] (JENKINS-27588) Labels used in Label Factory are shown as not used
SCM/JIRA link daemon commented on JENKINS-27588 Labels used in Label Factory are shown as not used Code changed in jenkins User: Dominique Path: src/main/java/jenkins/plugins/linkedjobs/actions/LabelDashboardAction.java src/main/java/jenkins/plugins/linkedjobs/helpers/TriggeredJobsHelper.java src/main/java/jenkins/plugins/linkedjobs/model/LabelAtomData.java src/main/java/jenkins/plugins/linkedjobs/model/NodeData.java src/main/resources/jenkins/plugins/linkedjobs/actions/LabelDashboardAction/index.jelly http://jenkins-ci.org/commit/label-linked-jobs-plugin/20d9598d2639cf06cf45258a8549dd7d3b3975b8 Log: JENKINS-27588 add support for Label default value in Labels Dashboard This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.