[JIRA] [cvs] (JENKINS-16314) cvs plugin removes sticky branch tag
Adriano Andrulis commented on JENKINS-16314 cvs plugin removes sticky branch tag Hi Michael, do you know when the next version will be release? Thanks in advance. This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[JIRA] (JENKINS-16314) cvs plugin removes sticky branch tag
Adriano Andrulis commented on JENKINS-16314 cvs plugin removes sticky branch tag Hi Michael, following is the xml for the job mentioned by James. Thanks for looking at. ?xml version='1.0' encoding='UTF-8'? maven2-moduleset plugin="maven-plugin@1.499" actions/ descriptionserver branch build/description keepDependenciesfalse/keepDependencies properties de.pellepelster.jenkins.walldisplay.WallDisplayJobProperty plugin="jenkinswalldisplay@0.6.15"/ /properties scm class="hudson.scm.CVSSCM" plugin="cvs@2.8" flattentrue/flatten repositoryBrowser class="hudson.scm.browsers.ViewCVS" urlhttps://viewvc/cgi-bin/viewvc.cgi/server/?root=root/url /repositoryBrowser repositories hudson.scm.CvsRepository cvsRoot:pserver:builder@pserver:/cvsroot-root/cvsRoot repositoryItems hudson.scm.CvsRepositoryItem modules hudson.scm.CvsModule localName/localName remoteNameComponent/services/server/remoteName /hudson.scm.CvsModule /modules location class="hudson.scm.CvsRepositoryLocation$BranchRepositoryLocation" locationTypeBRANCH/locationType locationNameRC_repServer2_6/locationName useHeadIfNotFoundfalse/useHeadIfNotFound /location /hudson.scm.CvsRepositoryItem /repositoryItems compressionLevel-1/compressionLevel excludedRegions hudson.scm.ExcludedRegion pattern/pattern /hudson.scm.ExcludedRegion /excludedRegions passwordB5SEyM3MM3X7KWpcw=/password passwordRequiredtrue/passwordRequired /hudson.scm.CvsRepository /repositories canUseUpdatefalse/canUseUpdate skipChangeLogfalse/skipChangeLog pruneEmptyDirectoriestrue/pruneEmptyDirectories disableCvsQuiettrue/disableCvsQuiet cleanOnFailedUpdatefalse/cleanOnFailedUpdate forceCleanCopytrue/forceCleanCopy /scm assignedNodedev02/assignedNode canRoamfalse/canRoam disabledfalse/disabled blockBuildWhenDownstreamBuildingfalse/blockBuildWhenDownstreamBuilding blockBuildWhenUpstreamBuildingfalse/blockBuildWhenUpstreamBuilding jdksun_jdk_7/jdk triggers class="vector" hudson.triggers.SCMTrigger spec# every 10 mins */10 * * * */spec ignorePostCommitHooksfalse/ignorePostCommitHooks /hudson.triggers.SCMTrigger /triggers concurrentBuildfalse/concurrentBuild rootModule groupIdcom.components.server/groupId artifactIdserver/artifactId /rootModule goals-U -DskipITs=false clean install -e/goals mavenOpts-Xmx512M -Dm3plugin.lib=/space/jenkins_slave/main/workspace/artifactory-plugin/2.1.3/mavenOpts aggregatorStyleBuildtrue/aggregatorStyleBuild incrementalBuildfalse/incrementalBuild perModuleEmailtrue/perModuleEmail ignoreUpstremChangesfalse/ignoreUpstremChanges archivingDisabledfalse/archivingDisabled resolveDependenciesfalse/resolveDependencies processPluginsfalse/processPlugins mavenValidationLevel-1/mavenValidationLevel runHeadlessfalse/runHeadless disableTriggerDownstreamProjectsfalse/disableTriggerDownstreamProjects settings class="jenkins.mvn.DefaultSettingsProvider"/ globalSettings class="jenkins.mvn.DefaultGlobalSettingsProvider"/ reporters hudson.maven.reporters.MavenMailer recipientsd...@mail.com/recipients dontNotifyEveryUnstableBuildfalse/dontNotifyEveryUnstableBuild sendToIndividualstrue/sendToIndividuals perModuleEmailtrue/perModuleEmail /hudson.maven.reporters.MavenMailer /reporters publishers/ buildWrappers org.jvnet.hudson.plugins.m2release.M2ReleaseBuildWrapper plugin="m2release@0.9.1" scmUserEnvVar/scmUserEnvVar scmPasswordEnvVar/scmPasswordEnvVar releaseEnvVarIS_M2RELEASEBUILD/releaseEnvVar releaseGoals-Dresume=false release:prepare release:perform -Dmaven.scm.provider.cvs.implementation=cvs_native -X/releaseGoals dryRunGoals-X -Dresume=false -DdryRun=true release:prepare -Dmaven.scm.provider.cvs.implementation=cvs_native -e/dryRunGoals selectCustomScmCommentPrefixfalse/selectCustomScmCommentPrefix selectAppendHudsonUsernamefalse/selectAppendHudsonUsername selectScmCredentialsfalse/selectScmCredentials /org.jvnet.hudson.plugins.m2release.M2ReleaseBuildWrapper org.jfrog.hudson.maven3.ArtifactoryMaven3NativeConfigurator plugin="artifactory@2.1.3" details
[JIRA] (JENKINS-16314) cvs plugin removes sticky branch tag
Adriano Andrulis
commented on JENKINS-16314
cvs plugin removes sticky branch tag
Hi Michael, while debugging the code I found the problem is in the cleanout method on the FileCallable inner class on the AbstractCVS.java line 695.
It call entry.setDate(null) that also removes the tag entry as it's stated on its javadoc "Set the sticky date information. Note that setting this will remove any tag information that is currently set."
private void cleanup(File directory, AdminHandler adminHandler) throws IOException {
for (File file : adminHandler.getAllFiles(directory)) {
Entry entry = adminHandler.getEntry(file);
String savedTag = entry.getTag();
entry.setDate(null);
adminHandler.setEntry(file, entry);
}
I hope that helps your analysis.
As a quick fix I've changed my AbstractCVS code as below but I'm not fully sure of the consequences.
entry.setDate(null);
to
String savedTag = entry.getTag();
entry.setDate(null);
if(savedTag != null) {
entry.setTag(savedTag);
}
Thanks and Regards.
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira
--
You received this message because you are subscribed to the Google Groups Jenkins Issues group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
