Re: Review Request: JDK-8162401 Support multiple --add-exports and --add-reads with the same module/package

[Sundararajan Athijegannathan]

+1

-Sundar


On 10/7/2016 3:47 AM, Mandy Chung wrote:
> http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8162401/webrev.00/
>
> Currently, `--add-exports` and `--add-reads` options do not accept duplicated 
> module/package and it is an error to attempt to export the same package more 
> than once on the command-line.  There are cases where allow augmenting the 
> command-line options to add `--add-exports` or `--add-reads`.  jtreg is one 
> example that currently parses the command-line options and has to merge 
> properly if there exists a `--add-exports` option of a given module/package.
>
> This patch relaxes this restriction and allow multiple `--add-exports` and 
> `--add-reads` options with the same module/package.  In addition, these 2 
> options allow unknown module/package and emit a warning rather than as a 
> fatal error, to be consistent with javac.
>
> Mandy
>
>

Re: [9] RFR: 8167240: Write new tests to cover functionality of existing 'jimage' options

[Denis Kononenko]

> >
> > Could someone please review these new tests for jimage utility.
> >
> > There're 5 new files containing tests to cover use cases for 'info',
> 
> > 'list', 'extract' and other options. No new tests for 'verify'.
> >
> > BUGURL: https://bugs.openjdk.java.net/browse/JDK-8167240
> > WEBREV: http://cr.openjdk.java.net/~dkononenko/8167240/webrev.00/
> Do these tests overlap with the existing tests? Just wondering if 
> JImageToolTest should be removed as part of this.


Yes, they do. Overlapping occurs in very common use cases. 
However I wouldn't remove JImageToolTest, we need such a test to ensure:
1) bin/jimage exists;
2) bin/jimage properly communicates to jdk.tools.jimage.JImageTask;

I think it could be simplified to an invocation of jimage --version. 

Denis.


> 
> -Alan

hg: jigsaw/jake/langtools: 2 new changesets

[mandy . chung]

Changeset: 8e9e1a2373a4
Author:lana
Date:  2016-10-06 20:56 +
URL:   http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/8e9e1a2373a4

Added tag jdk-9+139 for changeset 17a82cb0e4b4

! .hgtags

Changeset: e886b0aaa09f
Author:mchung
Date:  2016-10-06 15:48 -0700
URL:   http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/e886b0aaa09f

Merge

! .hgtags
- 
src/jdk.jdeps/share/classes/com/sun/tools/classfile/ConcealedPackages_attribute.java
- test/tools/javac/diags/examples/DuplicateExports/exported/Class.java
- test/tools/javac/diags/examples/DuplicateExports/module-info.java
- test/tools/javac/modules/RequiresPublicTest.java
- test/tools/jdeps/modules/src/m1/module-info.java
- test/tools/jdeps/modules/src/m1/p1/Goo.java
- test/tools/jdeps/modules/src/m1/p1/Lib.java
- test/tools/jdeps/modules/src/m1/p1/S.java
- test/tools/jdeps/modules/src/m1/p1/internal/Impl.java
- test/tools/jdeps/modules/src/m2/module-info.java
- test/tools/jdeps/modules/src/m2/p2/Bar.java
- test/tools/jdeps/modules/src/m2/p2/internal/T2.java
- test/tools/jdeps/modules/src/m3/module-info.java
- test/tools/jdeps/modules/src/m3/p3/Foo.java
- test/tools/jdeps/modules/src/m3/p3/Main.java
- test/tools/jdeps/modules/src/m6/module-info.java
- test/tools/jdeps/modules/src/m6/p6/indirect/UnsafeRef.java
- test/tools/jdeps/modules/src/m6/p6/safe/Lib.java
- test/tools/jdeps/modules/src/m7/module-info.java
- test/tools/jdeps/modules/src/m7/p7/Main.java

hg: jigsaw/jake/jdk: 2 new changesets

[mandy . chung]

Changeset: 2bf254421854
Author:lana
Date:  2016-10-06 20:56 +
URL:   http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/2bf254421854

Added tag jdk-9+139 for changeset 5518ac2f2ead

! .hgtags

Changeset: d31ab14d938f
Author:mchung
Date:  2016-10-06 15:48 -0700
URL:   http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/d31ab14d938f

Merge

! .hgtags
- src/java.base/share/classes/java/lang/module/Dependence.java
- src/java.base/share/classes/jdk/internal/module/ConfigurableModuleFinder.java
- test/java/lang/Class/getResource/src/m3/module-info.java
- test/java/lang/Class/getResource/src/m3/p3/Main.java
- test/java/lang/ClassLoader/getResource/modules/src/m3/module-info.java
- test/java/lang/ClassLoader/getResource/modules/src/m3/p3/Main.java
- test/java/lang/module/ModuleReader/MultiReleaseJarTest.java
- test/java/lang/reflect/Module/access/src/target/p/Exported.java
- test/java/lang/reflect/Module/access/src/target/p/Helper.java
- test/java/lang/reflect/Module/access/src/target/q/Internal.java
- 
test/java/util/ResourceBundle/modules/basic/src/asiabundles/jdk/test/resources/MyResources_ja_JP.properties
- test/java/util/ServiceLoader/modules/MiscTests.java
- test/java/util/ServiceLoader/modules/ServicesTest.java
- test/java/util/ServiceLoader/modules/src/bananascript/module-info.java
- 
test/java/util/ServiceLoader/modules/src/bananascript/org/banana/BananaScript.java
- 
test/java/util/ServiceLoader/modules/src/bananascript/org/banana/BananaScriptEngineFactory.java
- test/java/util/ServiceLoader/modules/src/test/module-info.java
- test/java/util/ServiceLoader/modules/src/test/test/Main.java

hg: jigsaw/jake/jaxws: 2 new changesets

[mandy . chung]

Changeset: 6b704401a214
Author:lana
Date:  2016-10-06 20:56 +
URL:   http://hg.openjdk.java.net/jigsaw/jake/jaxws/rev/6b704401a214

Added tag jdk-9+139 for changeset 7a7aadf3c450

! .hgtags

Changeset: 9af9124a6bfe
Author:mchung
Date:  2016-10-06 15:48 -0700
URL:   http://hg.openjdk.java.net/jigsaw/jake/jaxws/rev/9af9124a6bfe

Merge

hg: jigsaw/jake/nashorn: 2 new changesets

[mandy . chung]

Changeset: 430dee99064d
Author:lana
Date:  2016-10-06 20:56 +
URL:   http://hg.openjdk.java.net/jigsaw/jake/nashorn/rev/430dee99064d

Added tag jdk-9+139 for changeset e3b11296395b

! .hgtags

Changeset: 034810f8d9cb
Author:mchung
Date:  2016-10-06 15:48 -0700
URL:   http://hg.openjdk.java.net/jigsaw/jake/nashorn/rev/034810f8d9cb

Merge

! .hgtags

hg: jigsaw/jake: 2 new changesets

[mandy . chung]

Changeset: f73344fddabe
Author:lana
Date:  2016-10-06 20:56 +
URL:   http://hg.openjdk.java.net/jigsaw/jake/rev/f73344fddabe

Added tag jdk-9+139 for changeset 7dcf453eacae

! .hgtags

Changeset: 2f8eb7df5d8b
Author:mchung
Date:  2016-10-06 15:48 -0700
URL:   http://hg.openjdk.java.net/jigsaw/jake/rev/2f8eb7df5d8b

Merge

hg: jigsaw/jake/hotspot: 2 new changesets

[mandy . chung]

Changeset: 0384427f59fa
Author:lana
Date:  2016-10-06 20:56 +
URL:   http://hg.openjdk.java.net/jigsaw/jake/hotspot/rev/0384427f59fa

Added tag jdk-9+139 for changeset 08492e67bf32

! .hgtags

Changeset: ced1a5e167ae
Author:mchung
Date:  2016-10-06 15:48 -0700
URL:   http://hg.openjdk.java.net/jigsaw/jake/hotspot/rev/ced1a5e167ae

Merge

! .hgtags

hg: jigsaw/jake/corba: 2 new changesets

[mandy . chung]

Changeset: e7cc0efa4972
Author:lana
Date:  2016-10-06 20:56 +
URL:   http://hg.openjdk.java.net/jigsaw/jake/corba/rev/e7cc0efa4972

Added tag jdk-9+139 for changeset 8c9da7fc5b07

! .hgtags

Changeset: 3a29b8924e4d
Author:mchung
Date:  2016-10-06 15:48 -0700
URL:   http://hg.openjdk.java.net/jigsaw/jake/corba/rev/3a29b8924e4d

Merge

hg: jigsaw/jake/nashorn: 4 new changesets

[mandy . chung]

Changeset: ab0b7e471cb6
Author:hannesw
Date:  2016-09-30 19:40 +0200
URL:   http://hg.openjdk.java.net/jigsaw/jake/nashorn/rev/ab0b7e471cb6

8166902: Nested object literal property maps not reset in optimistic 
recompilation
Reviewed-by: lagergren, attila

! 
src/jdk.scripting.nashorn/share/classes/jdk/nashorn/internal/codegen/CodeGenerator.java
! 
src/jdk.scripting.nashorn/share/classes/jdk/nashorn/internal/codegen/SpillObjectCreator.java
+ test/script/basic/JDK-8166902.js

Changeset: fc972ab7d939
Author:attila
Date:  2016-10-04 13:23 +0200
URL:   http://hg.openjdk.java.net/jigsaw/jake/nashorn/rev/fc972ab7d939

8167037: Remove CALL_METHOD support from internal Nashorn linkers
Reviewed-by: hannesw, sundar

! 
src/jdk.scripting.nashorn/share/classes/jdk/nashorn/internal/objects/NativeJSAdapter.java
! 
src/jdk.scripting.nashorn/share/classes/jdk/nashorn/internal/runtime/ScriptObject.java
! 
src/jdk.scripting.nashorn/share/classes/jdk/nashorn/internal/runtime/Undefined.java
! 
src/jdk.scripting.nashorn/share/classes/jdk/nashorn/internal/runtime/linker/NashornBottomLinker.java

Changeset: e3b11296395b
Author:erikj
Date:  2016-10-04 13:41 +0200
URL:   http://hg.openjdk.java.net/jigsaw/jake/nashorn/rev/e3b11296395b

8166965: Some small java build tools are still running with big JVM 
configuration
Reviewed-by: ihse

! make/BuildNashorn.gmk

Changeset: b2ea70eefe24
Author:mchung
Date:  2016-10-06 15:21 -0700
URL:   http://hg.openjdk.java.net/jigsaw/jake/nashorn/rev/b2ea70eefe24

Merge

! make/BuildNashorn.gmk

hg: jigsaw/jake/jdk: 39 new changesets

[mandy . chung]

Changeset: 12e616e0a018
Author:asmotrak
Date:  2016-09-27 11:34 -0700
URL:   http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/12e616e0a018

8164591: sun/net/www/protocol/https/HttpsClient/ServerIdentityTest.java failed 
with SSLHandshakeException
Reviewed-by: xuelei

+ test/javax/net/ssl/templates/SSLTest.java
! test/sun/net/www/protocol/https/HttpsClient/ServerIdentityTest.java

Changeset: a68f9f843ffa
Author:vtewari
Date:  2016-09-15 12:20 +0530
URL:   http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/a68f9f843ffa

8161448: 4 JNI exception pending defect groups in DiagnosticCommandImpl.c
Reviewed-by: dholmes, dsamersoff

! src/jdk.management/share/native/libmanagement_ext/DiagnosticCommandImpl.c

Changeset: 4c843eb35b8a
Author:sgehwolf
Date:  2016-03-21 11:24 +0100
URL:   http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/4c843eb35b8a

8153711: [REDO] JDWP: Memory Leak: GlobalRefs never deleted when processing 
invokeMethod command
Summary: Delete global references in invoker_completeInvokeRequest()
Reviewed-by: sspitsyn, dsamersoff

! src/jdk.jdwp.agent/share/native/libjdwp/invoker.c
+ test/com/sun/jdi/OomDebugTest.java

Changeset: 65ec51b4e600
Author:ctornqvi
Date:  2016-09-15 16:56 -0400
URL:   http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/65ec51b4e600

6648858: InvokeHangTest.java fails due to "failure: Debuggee appears to be 
hung" when running with -Xcomp
Reviewed-by: zgu, gtriantafill, iignatyev

! test/com/sun/jdi/InvokeHangTest.java

Changeset: 511e3dcdf740
Author:amurillo
Date:  2016-09-16 13:15 -0700
URL:   http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/511e3dcdf740

Merge

- src/java.base/share/classes/sun/text/resources/BreakIteratorRulesProvider.java
- src/jdk.localedata/share/classes/sun/text/resources/thai_dict
- test/sun/security/pkcs11/nss/lib/windows-amd64/libnspr4.dll
- test/sun/security/pkcs11/nss/lib/windows-amd64/libnspr4.lib
- test/sun/security/pkcs11/nss/lib/windows-amd64/libplc4.dll
- test/sun/security/pkcs11/nss/lib/windows-amd64/libplc4.lib
- test/sun/security/pkcs11/nss/lib/windows-amd64/libplds4.dll
- test/sun/security/pkcs11/nss/lib/windows-amd64/libplds4.lib
- test/sun/security/pkcs11/nss/lib/windows-i586/libnspr4.dll
- test/sun/security/pkcs11/nss/lib/windows-i586/libnspr4.lib
- test/sun/security/pkcs11/nss/lib/windows-i586/libplc4.dll
- test/sun/security/pkcs11/nss/lib/windows-i586/libplc4.lib
- test/sun/security/pkcs11/nss/lib/windows-i586/libplds4.dll
- test/sun/security/pkcs11/nss/lib/windows-i586/libplds4.lib
- test/sun/security/pkcs11/nss/src/nss-3.16_nspr-4.10_src.tar.gz
- test/sun/security/pkcs11/nss/src/nss-3.16_nspr-4.10_src.tar.gz.sha256

Changeset: a041a4759597
Author:amurillo
Date:  2016-09-23 13:32 -0700
URL:   http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/a041a4759597

Merge


Changeset: f61c40b324c5
Author:amurillo
Date:  2016-09-27 09:04 -0700
URL:   http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/f61c40b324c5

Merge


Changeset: d16e09effe10
Author:amurillo
Date:  2016-09-27 13:22 -0700
URL:   http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/d16e09effe10

Merge


Changeset: e8bfba969b7c
Author:mli
Date:  2016-09-27 18:45 -0700
URL:   http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/e8bfba969b7c

8162519: Remove ParallelPrefix.java from ProblemList.txt
Reviewed-by: psandoz

! test/ProblemList.txt

Changeset: 111fbc6a5a09
Author:valeriep
Date:  2016-09-28 03:10 +
URL:   http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/111fbc6a5a09

8149802: Signature.verify() doesn't reset the signature object on exception
Summary: Ensure the signature object is always reset after verify() is called.
Reviewed-by: xuelei

! src/java.base/share/classes/sun/security/rsa/RSASignature.java
! src/jdk.crypto.pkcs11/share/classes/sun/security/pkcs11/P11Signature.java
! src/jdk.crypto.pkcs11/share/classes/sun/security/pkcs11/Secmod.java
! 
src/jdk.crypto.ucrypto/solaris/classes/com/oracle/security/ucrypto/NativeRSASignature.java
+ test/java/security/Signature/ResetAfterException.java

Changeset: 7cd8128e16be
Author:valeriep
Date:  2016-09-28 03:18 +
URL:   http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/7cd8128e16be

6946830: javax.crypto.Cipher.doFinal behavior differs depending on platform
Summary: Updated OracleUcrypto and SunPKCS11 providers with SunJCE provider 
behavior
Reviewed-by: xuelei

! src/jdk.crypto.pkcs11/share/classes/sun/security/pkcs11/P11Cipher.java
! 
src/jdk.crypto.ucrypto/solaris/classes/com/oracle/security/ucrypto/NativeCipherWithJavaPadding.java
+ test/javax/crypto/Cipher/EmptyFinalBuffer.java

Changeset: 030fd20df66d
Author:mhaupt
Date:  2016-09-28 14:02 +0200
URL:   http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/030fd20df66d

8151179: address issues raised by JCK team on JEP 274 API
Reviewed-by: jrose, redestad, psandoz

! src/java.base/share/classes/java/lang/invoke/MethodHandleImpl.java
! 

hg: jigsaw/jake/langtools: 10 new changesets

[mandy . chung]

Changeset: abfa6353574c
Author:sadayapalam
Date:  2016-09-28 09:05 +0530
URL:   http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/abfa6353574c

8166363: Method with reordered type parameter bounds compiles with @Override 
annotation but does not actually override superclass method.
Reviewed-by: vromero

! src/jdk.compiler/share/classes/com/sun/tools/javac/comp/TransTypes.java
+ test/tools/javac/generics/bridges/ReorderedBoundsTest.java

Changeset: 721c5727816d
Author:shinyafox
Date:  2016-09-28 16:36 +0900
URL:   http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/721c5727816d

8154714: jshell tool: add exports support
Reviewed-by: jlahoda, rfield

! src/jdk.jshell/share/classes/jdk/internal/jshell/tool/JShellTool.java
! 
src/jdk.jshell/share/classes/jdk/internal/jshell/tool/resources/l10n.properties
! test/jdk/jshell/ToolBasicTest.java

Changeset: b15188167309
Author:shinyafox
Date:  2016-09-29 17:36 +0900
URL:   http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/b15188167309

8166744: JShell: java.lang.IndexOutOfBoundsException for legal history access
Reviewed-by: rfield, jlahoda

! test/jdk/jshell/HistoryTest.java

Changeset: 21be9eb2fb2f
Author:lana
Date:  2016-09-29 17:24 +
URL:   http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/21be9eb2fb2f

Merge


Changeset: 36f470bd6765
Author:mchung
Date:  2016-09-29 21:31 -0700
URL:   http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/36f470bd6765

8166238: Update jdeps for GNU-style long form options
Reviewed-by: alanb

! src/jdk.jdeps/share/classes/com/sun/tools/jdeps/JdepsTask.java
! src/jdk.jdeps/share/classes/com/sun/tools/jdeps/resources/jdeps.properties
! test/tools/jdeps/APIDeps.java
! test/tools/jdeps/jdkinternals/ShowReplacement.java
! test/tools/jdeps/modules/GenModuleInfo.java
! test/tools/jdeps/modules/InverseDeps.java
! test/tools/jdeps/modules/src/m3/module-info.java

Changeset: 8bf23828bb2f
Author:jjg
Date:  2016-09-30 13:15 -0700
URL:   http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/8bf23828bb2f

8166144: New javadoc options don't conform to JEP 293 (GNU style options)
Reviewed-by: ksrini, bpatel

! src/jdk.compiler/share/classes/com/sun/tools/javac/main/Option.java
! src/jdk.javadoc/share/classes/jdk/javadoc/internal/api/JavadocTool.java
! 
src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/ConfigurationImpl.java
! 
src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/resources/standard.properties
! 
src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/Configuration.java
! src/jdk.javadoc/share/classes/jdk/javadoc/internal/tool/Messager.java
! src/jdk.javadoc/share/classes/jdk/javadoc/internal/tool/Start.java
! src/jdk.javadoc/share/classes/jdk/javadoc/internal/tool/ToolOption.java
! 
src/jdk.javadoc/share/classes/jdk/javadoc/internal/tool/resources/javadoc.properties
! test/jdk/javadoc/doclet/lib/JavadocTester.java
! test/jdk/javadoc/doclet/testHelpOption/TestHelpOption.java
! test/jdk/javadoc/doclet/testXOption/TestXOption.java
! test/jdk/javadoc/tool/CheckResourceKeys.java
+ test/jdk/javadoc/tool/OptionSyntaxTest.java
! test/jdk/javadoc/tool/api/basic/IsSupportedOptionTest.java
! test/jdk/javadoc/tool/modules/FilterOptions.java
! test/jdk/javadoc/tool/modules/Modules.java

Changeset: f6d8902a4c8b
Author:erikj
Date:  2016-10-04 13:41 +0200
URL:   http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/f6d8902a4c8b

8166965: Some small java build tools are still running with big JVM 
configuration
Reviewed-by: ihse

! make/gendata/Gendata-jdk.compiler.gmk
! make/gensrc/GensrcCommon.gmk

Changeset: 50a14048e428
Author:jlahoda
Date:  2016-10-04 16:25 +0200
URL:   http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/50a14048e428

8152911: javac assertion error when compiling overlay sources
Summary: Avoid creating ModuleSymbols with unspecified name, to avoid conflicts 
with predefined ModuleSymbol for the java.base module.
Reviewed-by: jjg

! src/jdk.compiler/share/classes/com/sun/tools/javac/code/ModuleFinder.java
! src/jdk.compiler/share/classes/com/sun/tools/javac/code/Symbol.java
! src/jdk.compiler/share/classes/com/sun/tools/javac/code/Symtab.java
! src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Modules.java
! src/jdk.compiler/share/classes/com/sun/tools/javac/file/Locations.java
- src/jdk.compiler/share/classes/com/sun/tools/javac/file/ModuleNameReader.java
! src/jdk.compiler/share/classes/com/sun/tools/javac/jvm/ClassReader.java
+ src/jdk.compiler/share/classes/com/sun/tools/javac/jvm/ModuleNameReader.java
! src/jdk.compiler/share/classes/com/sun/tools/javac/main/JavaCompiler.java
! 
src/jdk.compiler/share/classes/com/sun/tools/javac/resources/compiler.properties
! test/tools/javac/diags/examples.not-yet.txt
! test/tools/javac/modules/EdgeCases.java

Changeset: 17a82cb0e4b4
Author:jlahoda
Date:  2016-10-04 17:40 +0200
URL:   

Re: Review Request: JDK-8162401 Support multiple --add-exports and --add-reads with the same module/package

[Claes Redestad]

Hi Mandy,

On 2016-10-07 00:17, Mandy Chung wrote:

http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8162401/webrev.00/


looks ok to me.

/Claes



Currently, `--add-exports` and `--add-reads` options do not accept duplicated 
module/package and it is an error to attempt to export the same package more 
than once on the command-line.  There are cases where allow augmenting the 
command-line options to add `--add-exports` or `--add-reads`.  jtreg is one 
example that currently parses the command-line options and has to merge 
properly if there exists a `--add-exports` option of a given module/package.

This patch relaxes this restriction and allow multiple `--add-exports` and 
`--add-reads` options with the same module/package.  In addition, these 2 
options allow unknown module/package and emit a warning rather than as a fatal 
error, to be consistent with javac.

Mandy

hg: jigsaw/jake/hotspot: 21 new changesets

[mandy . chung]

Changeset: c8b3f8e5423b
Author:dsamersoff
Date:  2016-09-15 10:19 +0300
URL:   http://hg.openjdk.java.net/jigsaw/jake/hotspot/rev/c8b3f8e5423b

8027920: SA: Add default methods to InstanceKlass
Summary: Add default methods to InstanceKlass to enable SA to inspect default 
methods
Reviewed-by: dsamersoff, iklam
Contributed-by: jini.geo...@oracle.com

! src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/oops/InstanceKlass.java

Changeset: f5fd5477a807
Author:akulyakh
Date:  2016-09-14 16:20 +0300
URL:   http://hg.openjdk.java.net/jigsaw/jake/hotspot/rev/f5fd5477a807

8165017: Additional test coverage of the JDWP CLASSLOADER and MODULE commands
Summary: A new JDWP test
Reviewed-by: sspitsyn

! test/serviceability/jdwp/AllModulesCommandTest.java
! test/serviceability/jdwp/JdwpCmd.java
+ test/serviceability/jdwp/JdwpModuleCmd.java
+ test/serviceability/jdwp/JdwpModuleReply.java
+ test/serviceability/jdwp/JdwpVisibleClassesCmd.java
+ test/serviceability/jdwp/JdwpVisibleClassesReply.java

Changeset: 27d09549c47b
Author:tschatzl
Date:  2016-09-15 16:44 +0200
URL:   http://hg.openjdk.java.net/jigsaw/jake/hotspot/rev/27d09549c47b

8159422: Very high Concurrent Mark mark stack contention
Summary: Decrease contention on mark stack by splitting locks, and minimizing 
the amount of time these locks are held. Improve mark stack management.
Reviewed-by: kbarrett, mgerdin, eosterlund

! src/share/vm/gc/g1/g1CollectedHeap.cpp
! src/share/vm/gc/g1/g1ConcurrentMark.cpp
! src/share/vm/gc/g1/g1ConcurrentMark.hpp
! src/share/vm/gc/g1/g1ConcurrentMark.inline.hpp
! src/share/vm/gc/g1/g1OopClosures.hpp
! src/share/vm/memory/allocation.hpp
! src/share/vm/memory/allocation.inline.hpp
! src/share/vm/runtime/mutexLocker.cpp
! src/share/vm/runtime/mutexLocker.hpp

Changeset: fd16b627ebc5
Author:kbarrett
Date:  2016-09-15 12:10 -0400
URL:   http://hg.openjdk.java.net/jigsaw/jake/hotspot/rev/fd16b627ebc5

8165808: Add release barriers when allocating objects with concurrent collection
Summary: Add release_set_klass, use in slow-path allocators.
Reviewed-by: jmasa, dholmes

! src/share/vm/gc/shared/collectedHeap.hpp
! src/share/vm/gc/shared/collectedHeap.inline.hpp
! src/share/vm/oops/oop.hpp
! src/share/vm/oops/oop.inline.hpp

Changeset: bc2c975bc342
Author:tschatzl
Date:  2016-09-16 11:33 +0200
URL:   http://hg.openjdk.java.net/jigsaw/jake/hotspot/rev/bc2c975bc342

8157952: Parallelize Memory Pretouch
Summary: Use multiple threads to pretouch memory using -XX:+AlwaysPreTouch to 
use more memory bandwidth
Reviewed-by: jmasa, sangheki

! src/share/vm/gc/g1/g1CollectedHeap.cpp
! src/share/vm/gc/g1/g1CollectedHeap.hpp
! src/share/vm/gc/g1/g1PageBasedVirtualSpace.cpp
! src/share/vm/gc/g1/g1PageBasedVirtualSpace.hpp
! src/share/vm/gc/g1/g1RegionToSpaceMapper.cpp
! src/share/vm/gc/g1/g1RegionToSpaceMapper.hpp
! src/share/vm/gc/g1/heapRegionManager.cpp
! src/share/vm/gc/g1/heapRegionManager.hpp
! src/share/vm/gc/shared/workgroup.hpp
! src/share/vm/runtime/globals.hpp
! src/share/vm/runtime/os.cpp
! src/share/vm/runtime/os.hpp

Changeset: 5bddf69330f2
Author:gziemski
Date:  2016-09-16 12:09 -0500
URL:   http://hg.openjdk.java.net/jigsaw/jake/hotspot/rev/5bddf69330f2

8136766: Enable ThreadStackSize range test
Summary: Re-enabled max range check for StackSize runtime options
Reviewed-by: dcubed

! test/runtime/CommandLine/OptionsValidation/TestOptionsWithRanges.java

Changeset: 939e55404a8f
Author:amurillo
Date:  2016-09-16 13:15 -0700
URL:   http://hg.openjdk.java.net/jigsaw/jake/hotspot/rev/939e55404a8f

Merge


Changeset: a696583f5ddb
Author:mdoerr
Date:  2016-09-06 13:01 +0200
URL:   http://hg.openjdk.java.net/jigsaw/jake/hotspot/rev/a696583f5ddb

8165489: Missing G1 barrier in Unsafe_GetObjectVolatile
Summary: Add missing barrier, sharing code with Unsafe_GetObject.
Reviewed-by: kbarrett, mgerdin, pliden

! src/share/vm/prims/unsafe.cpp

Changeset: 24b753d90c4b
Author:jiangli
Date:  2016-09-18 21:10 -0400
URL:   http://hg.openjdk.java.net/jigsaw/jake/hotspot/rev/24b753d90c4b

8078644: CDS needs to support JVMTI CFLH
Summary: Support posting CLFH for shared classes. Tests are contributed by 
Misha Seledtsov.
Reviewed-by: iklam, coleenp, acorn, dcubed, sspitsyn

! src/share/vm/classfile/klassFactory.cpp
! src/share/vm/classfile/klassFactory.hpp
! src/share/vm/classfile/systemDictionary.cpp
! src/share/vm/memory/filemap.cpp
! src/share/vm/memory/filemap.hpp
! src/share/vm/memory/metaspace.cpp
! src/share/vm/memory/metaspaceShared.cpp
! src/share/vm/memory/metaspaceShared.hpp
! src/share/vm/oops/instanceKlass.cpp
! src/share/vm/oops/instanceKlass.hpp
! src/share/vm/utilities/debug.cpp
! src/share/vm/utilities/debug.hpp
+ test/runtime/SharedArchiveFile/CDSTestUtils.java
+ 
test/runtime/SharedArchiveFile/serviceability/transformRelatedClasses/Implementor.java
+ 

hg: jigsaw/jake: 4 new changesets

[mandy . chung]

Changeset: 13a8f3836051
Author:erikj
Date:  2016-09-30 09:05 +0200
URL:   http://hg.openjdk.java.net/jigsaw/jake/rev/13a8f3836051

8160630: libjimage.so and others should link statically to libgcc
Reviewed-by: ihse, tbell

! common/autoconf/buildjdk-spec.gmk.in
! common/autoconf/generated-configure.sh
! common/autoconf/lib-std.m4

Changeset: 60addd60b367
Author:erikj
Date:  2016-10-04 13:34 +0200
URL:   http://hg.openjdk.java.net/jigsaw/jake/rev/60addd60b367

8166948: Exploded image too slow to be usable
Reviewed-by: alanb, mchung, ihse

+ make/ExplodedImageOptimize.gmk
! make/Main.gmk

Changeset: 7dcf453eacae
Author:erikj
Date:  2016-10-04 13:41 +0200
URL:   http://hg.openjdk.java.net/jigsaw/jake/rev/7dcf453eacae

8166965: Some small java build tools are still running with big JVM 
configuration
Reviewed-by: ihse

! make/Javadoc.gmk
! make/MainSupport.gmk
! make/common/SetupJavaCompilers.gmk

Changeset: 02d4bcaca691
Author:mchung
Date:  2016-10-06 15:20 -0700
URL:   http://hg.openjdk.java.net/jigsaw/jake/rev/02d4bcaca691

Merge

! common/autoconf/buildjdk-spec.gmk.in
! common/autoconf/generated-configure.sh
! make/Javadoc.gmk
! make/Main.gmk
! make/MainSupport.gmk
! make/common/SetupJavaCompilers.gmk

hg: jigsaw/jake/corba: 2 new changesets

[mandy . chung]

Changeset: 8c9da7fc5b07
Author:erikj
Date:  2016-10-04 13:41 +0200
URL:   http://hg.openjdk.java.net/jigsaw/jake/corba/rev/8c9da7fc5b07

8166965: Some small java build tools are still running with big JVM 
configuration
Reviewed-by: ihse

! make/gensrc/Gensrc-java.corba.gmk

Changeset: 8b179a3fe35a
Author:mchung
Date:  2016-10-06 15:20 -0700
URL:   http://hg.openjdk.java.net/jigsaw/jake/corba/rev/8b179a3fe35a

Merge

! make/gensrc/Gensrc-java.corba.gmk

Review Request: JDK-8162401 Support multiple --add-exports and --add-reads with the same module/package

[Mandy Chung]

http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8162401/webrev.00/

Currently, `--add-exports` and `--add-reads` options do not accept duplicated 
module/package and it is an error to attempt to export the same package more 
than once on the command-line.  There are cases where allow augmenting the 
command-line options to add `--add-exports` or `--add-reads`.  jtreg is one 
example that currently parses the command-line options and has to merge 
properly if there exists a `--add-exports` option of a given module/package.

This patch relaxes this restriction and allow multiple `--add-exports` and 
`--add-reads` options with the same module/package.  In addition, these 2 
options allow unknown module/package and emit a warning rather than as a fatal 
error, to be consistent with javac.

Mandy

Re: [9] RFR: 8167240: Write new tests to cover functionality of existing 'jimage' options

[Alan Bateman]

On 06/10/2016 17:37, Denis Kononenko wrote:


Hi,

Could someone please review these new tests for jimage utility.

There're 5 new files containing tests to cover use cases for 'info', 
'list', 'extract' and other options. No new tests for 'verify'.


BUGURL: https://bugs.openjdk.java.net/browse/JDK-8167240
WEBREV: http://cr.openjdk.java.net/~dkononenko/8167240/webrev.00/
Do these tests overlap with the existing tests? Just wondering if 
JImageToolTest should be removed as part of this.


-Alan

hg: jigsaw/jake/jdk: Workaround jdk.jconsole to add exports private

[mandy . chung]

Changeset: f493db6e68cc
Author:mchung
Date:  2016-10-06 12:22 -0700
URL:   http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/f493db6e68cc

Workaround jdk.jconsole to add exports private

! make/launcher/Launcher-jdk.jconsole.gmk

Re: Adding boot and platform module flags to ResolvedModule

[Scott Stark]

In the prototype that allows the vm to boot with modules on the module path 
that have packages with the same name, I have modified the ModuleBootstrap to 
use an alternate Function mapping that creates a 
jdk.internal.loader.Loader for the modules that are not in the set of 
boot/platform modules so that duplicate packages in separate modules do not 
cause the vm to fail the boot phase. Attached is the very rough first version 
of the prototype. Most of the changes are just System.err.printf statements to 
debug what is happening during the bootstrap phase.

There are a couple of places that need to know whether a module is in the 
boot/platform set in order to assign the correct ClassLoader.

- Original Message -
From: "Alan Bateman" 
To: "Scott Stark" , jigsaw-dev@openjdk.java.net
Sent: Thursday, October 6, 2016 9:29:57 AM
Subject: Re: Adding boot and platform module flags to ResolvedModule

On 06/10/2016 17:15, Scott Stark wrote:

> Hello,
>
> I'm currently prototyping an alternate bootstrap implementation that will 
> allow packages with the same name to exist across modules, and one thing I 
> have run across is the need to know what the boot and platform modules are 
> since there are restrictions on what type of ClassLoader can be used with 
> them. Currently this information is located in the
> jdk.internal.module.ModuleLoaderMap class. In my prototype I just exposed 
> that info via static public methods on ModuleLoaderMap, but it seems like the 
> appropriate place for this is as read only attributes on the 
> java.lang.module.ResolvedModule class.
>
> Does that make sense?
ModuleLoaderMap is generated at build time with the mapping of modules 
to loader. Once the VM initialized then there shouldn't be any further 
need for it and not clear that it would be worth exposing it in the API. 
Maybe you could expand a bit more on what you doing as it's hard to 
understand how you might use this.

-Alandiff -r e0864f0eb268 src/java.base/share/classes/java/lang/reflect/Layer.java
--- a/src/java.base/share/classes/java/lang/reflect/Layer.java	Thu Sep 15 15:17:35 2016 -0700
+++ b/src/java.base/share/classes/java/lang/reflect/Layer.java	Wed Oct 05 22:52:40 2016 -0700
@@ -285,6 +285,7 @@
 checkGetClassLoaderPermission();
 
 LoaderPool pool = new LoaderPool(cf, this, parentLoader);
+System.err.printf("defineModulesWithManyLoaders, cf=%s, parentLoader=%s\n", cf, parentLoader);
 try {
 return new Layer(cf, this, pool::loaderFor);
 } catch (IllegalArgumentException e) {
@@ -374,6 +375,7 @@
 return new Layer(cf, this, clf);
 } catch (IllegalArgumentException iae) {
 // IAE is thrown by VM when defining the module fails
+iae.printStackTrace();
 throw new LayerInstantiationException(iae.getMessage());
 }
 }
@@ -415,8 +417,9 @@
 for (String p : descriptor.packages()) {
 String other = packageToModule.putIfAbsent(p, name);
 if (other != null) {
-throw fail("Package " + p + " in both module "
-   + name + " and module " + other);
+System.err.printf("Package: %s in both module: %s and %s\n", p, name, other);
+//throw fail("Package " + p + " in both module "
+//   + name + " and module " + other);
 }
 }
 }
diff -r e0864f0eb268 src/java.base/share/classes/java/lang/reflect/Module.java
--- a/src/java.base/share/classes/java/lang/reflect/Module.java	Thu Sep 15 15:17:35 2016 -0700
+++ b/src/java.base/share/classes/java/lang/reflect/Module.java	Wed Oct 05 22:52:40 2016 -0700
@@ -52,6 +52,9 @@
 
 import jdk.internal.loader.BuiltinClassLoader;
 import jdk.internal.loader.BootLoader;
+import jdk.internal.loader.ClassLoaders;
+import jdk.internal.loader.Loader;
+import jdk.internal.loader.LoaderPool;
 import jdk.internal.loader.ResourceHelper;
 import jdk.internal.misc.JavaLangAccess;
 import jdk.internal.misc.JavaLangReflectModuleAccess;
@@ -135,7 +138,15 @@
 String vs = Objects.toString(version, null);
 String loc = Objects.toString(uri, null);
 
-defineModule0(this, vs, loc, array);
+try {
+System.err.printf("DefiningModule(%s,%s)\n", name, loader);
+defineModule0(this, vs, loc, array);
+} catch (Throwable t) {
+System.err.printf("Failed to define module: %s, uri:%s, cl: %s, err: %s\n", name, uri, loader, t.getMessage());
+t.printStackTrace();
+System.err.flush();
+throw t;
+}
 }
 
 
@@ -1001,12 +1012,22 @@
 
 boolean isBootLayer = (Layer.boot() == null);
 Set loaders = new HashSet<>();
+ClassLoader appClassLoader = ClassLoaders.appClassLoader();
+LoaderPool appLoaderPool = null; //new LoaderPool(cf, layer, appClassLoader);
+

Re: [9] RFR: 8167240: Write new tests to cover functionality of existing 'jimage' options

[Alexandre (Shura) Iline]

Hi, Denis,

By an agreement, @modules should go before any action tag. You use it after 
@build.

Shura

> On Oct 6, 2016, at 9:37 AM, Denis Kononenko  
> wrote:
> 
> Hi,
> 
> Could someone please review these new tests for jimage utility.
> 
> There're 5 new files containing tests to cover use cases for 'info', 'list', 
> 'extract' and other options. No new tests for 'verify'.
> 
> BUGURL: https://bugs.openjdk.java.net/browse/JDK-8167240
> WEBREV: http://cr.openjdk.java.net/~dkononenko/8167240/webrev.00/
> 
> 
> Thank you,
> Denis.

Re: RFR 8167181: Exported elements referring to inaccessible types in jdk.security.jgss

[Mandy Chung]

> On Oct 6, 2016, at 9:55 AM, Wang Weijun  wrote:
> 
> Please review the code change for jdk9/dev/jdk repo at
> 
>   http://cr.openjdk.java.net/~weijun/8167181/webrev.00


This looks good to me.  

Thanks
Mandy

RFR 8167181: Exported elements referring to inaccessible types in jdk.security.jgss

[Wang Weijun]

Please review the code change for jdk9/dev/jdk repo at

   http://cr.openjdk.java.net/~weijun/8167181/webrev.00

and for jdk9/dev which is simply

diff --git a/make/CompileJavaModules.gmk b/make/CompileJavaModules.gmk
--- a/make/CompileJavaModules.gmk
+++ b/make/CompileJavaModules.gmk
@@ -452,10 +452,6 @@




-jdk.security.jgss_ADD_JAVAC_FLAGS := -Xlint:-exports
-
-
-
 jdk.vm.ci_ADD_JAVAC_FLAGS := -Xlint:-exports




After the change the *Impl classes disappeared from javadoc [1]. I wish 
I had noticed them before.


Thanks
Max

[1] 
http://download.java.net/java/jdk9/docs/jre/api/security/jgss/spec/com/sun/security/jgss/package-summary.html

[9] RFR: 8167240: Write new tests to cover functionality of existing 'jimage' options

[Denis Kononenko]

Hi,

Could someone please review these new tests for jimage utility.

There're 5 new files containing tests to cover use cases for 'info', 
'list', 'extract' and other options. No new tests for 'verify'.


BUGURL: https://bugs.openjdk.java.net/browse/JDK-8167240
WEBREV: http://cr.openjdk.java.net/~dkononenko/8167240/webrev.00/


Thank you,
Denis.

Re: Adding boot and platform module flags to ResolvedModule

[Alan Bateman]

On 06/10/2016 17:15, Scott Stark wrote:


Hello,

I'm currently prototyping an alternate bootstrap implementation that will allow 
packages with the same name to exist across modules, and one thing I have run 
across is the need to know what the boot and platform modules are since there 
are restrictions on what type of ClassLoader can be used with them. Currently 
this information is located in the
jdk.internal.module.ModuleLoaderMap class. In my prototype I just exposed that 
info via static public methods on ModuleLoaderMap, but it seems like the 
appropriate place for this is as read only attributes on the 
java.lang.module.ResolvedModule class.

Does that make sense?
ModuleLoaderMap is generated at build time with the mapping of modules 
to loader. Once the VM initialized then there shouldn't be any further 
need for it and not clear that it would be worth exposing it in the API. 
Maybe you could expand a bit more on what you doing as it's hard to 
understand how you might use this.


-Alan

Adding boot and platform module flags to ResolvedModule

[Scott Stark]

Hello,

I'm currently prototyping an alternate bootstrap implementation that will allow 
packages with the same name to exist across modules, and one thing I have run 
across is the need to know what the boot and platform modules are since there 
are restrictions on what type of ClassLoader can be used with them. Currently 
this information is located in the 
jdk.internal.module.ModuleLoaderMap class. In my prototype I just exposed that 
info via static public methods on ModuleLoaderMap, but it seems like the 
appropriate place for this is as read only attributes on the 
java.lang.module.ResolvedModule class.

Does that make sense?

Is there interest in a feature request and patch for that?

Thanks,
Scott