Re: jlink tool review (Re: Initial webrev with changes for JDK 9)

[Sundararajan Athijegannathan]

Hi,

Thanks for the review. I've filed a bug to track your suggestions:
https://bugs.openjdk.java.net/browse/JDK-8151896

Thanks,
-Sundar

On 3/14/2016 6:26 PM, Michael Haupt wrote:
> Hi again,
>
> some certain list server doesn't like attachments. ;-)
> Find it at http://cr.openjdk.java.net/~mhaupt/jigsaw/
>
> Best,
>
> Michael
>
>> Am 14.03.2016 um 13:49 schrieb Michael Haupt :
>>
>> Alan, all,
>>
>> please find a patch with suggested changes to jlink in the attachment. The 
>> patch also contains a file named review-comments.txt, which addresses 
>> several topics throughout jlink. I've covered most code; only the 
>> jlink.internal package is still missing. I've been able to compile jake with 
>> these refactorings applied; I have not yet run all the jlink tests.
>>
>> Unfortunately, I have to lay down the review work at this time; Sundar is 
>> taking over (thanks!!). I'm available for clarification matters.
>>
>> Best,
>>
>> Michael
>

Re: jlink tool review (Re: Initial webrev with changes for JDK 9)

[Michael Haupt]

Hi again,

some certain list server doesn't like attachments. ;-)
Find it at http://cr.openjdk.java.net/~mhaupt/jigsaw/

Best,

Michael

> Am 14.03.2016 um 13:49 schrieb Michael Haupt :
> 
> Alan, all,
> 
> please find a patch with suggested changes to jlink in the attachment. The 
> patch also contains a file named review-comments.txt, which addresses several 
> topics throughout jlink. I've covered most code; only the jlink.internal 
> package is still missing. I've been able to compile jake with these 
> refactorings applied; I have not yet run all the jlink tests.
> 
> Unfortunately, I have to lay down the review work at this time; Sundar is 
> taking over (thanks!!). I'm available for clarification matters.
> 
> Best,
> 
> Michael


-- 

 
Dr. Michael Haupt | Principal Member of Technical Staff
Phone: +49 331 200 7277 | Fax: +49 331 200 7561
Oracle Java Platform Group | LangTools Team | Nashorn
Oracle Deutschland B.V. & Co. KG | Schiffbauergasse 14 | 14467 Potsdam, Germany

ORACLE Deutschland B.V. & Co. KG | Hauptverwaltung: Riesstraße 25, D-80992 
München
Registergericht: Amtsgericht München, HRA 95603

Komplementärin: ORACLE Deutschland Verwaltung B.V. | Hertogswetering 163/167, 
3543 AS Utrecht, Niederlande
Handelsregister der Handelskammer Midden-Nederland, Nr. 30143697
Geschäftsführer: Alexander van der Ven, Jan Schultheiss, Val Maher
  Oracle is committed to developing 
practices and products that help protect the environment

jlink tool review (Re: Initial webrev with changes for JDK 9)

[Michael Haupt]

Alan, all,

please find a patch with suggested changes to jlink in the attachment. The 
patch also contains a file named review-comments.txt, which addresses several 
topics throughout jlink. I've covered most code; only the jlink.internal 
package is still missing. I've been able to compile jake with these 
refactorings applied; I have not yet run all the jlink tests.

Unfortunately, I have to lay down the review work at this time; Sundar is 
taking over (thanks!!). I'm available for clarification matters.

Best,

Michael



-- 

 
Dr. Michael Haupt | Principal Member of Technical Staff
Phone: +49 331 200 7277 | Fax: +49 331 200 7561
Oracle Java Platform Group | LangTools Team | Nashorn
Oracle Deutschland B.V. & Co. KG | Schiffbauergasse 14 | 14467 Potsdam, Germany

ORACLE Deutschland B.V. & Co. KG | Hauptverwaltung: Riesstraße 25, D-80992 
München
Registergericht: Amtsgericht München, HRA 95603

Komplementärin: ORACLE Deutschland Verwaltung B.V. | Hertogswetering 163/167, 
3543 AS Utrecht, Niederlande
Handelsregister der Handelskammer Midden-Nederland, Nr. 30143697
Geschäftsführer: Alexander van der Ven, Jan Schultheiss, Val Maher
  Oracle is committed to developing 
practices and products that help protect the environment