Hi, Thanks for the review. I've filed a bug to track your suggestions: https://bugs.openjdk.java.net/browse/JDK-8151896
Thanks, -Sundar On 3/14/2016 6:26 PM, Michael Haupt wrote: > Hi again, > > some certain list server doesn't like attachments. ;-) > Find it at http://cr.openjdk.java.net/~mhaupt/jigsaw/ > > Best, > > Michael > >> Am 14.03.2016 um 13:49 schrieb Michael Haupt <michael.ha...@oracle.com>: >> >> Alan, all, >> >> please find a patch with suggested changes to jlink in the attachment. The >> patch also contains a file named review-comments.txt, which addresses >> several topics throughout jlink. I've covered most code; only the >> jlink.internal package is still missing. I've been able to compile jake with >> these refactorings applied; I have not yet run all the jlink tests. >> >> Unfortunately, I have to lay down the review work at this time; Sundar is >> taking over (thanks!!). I'm available for clarification matters. >> >> Best, >> >> Michael >