[jira] [Commented] (KAFKA-10055) Add shared internal utility class for Streams module
[ https://issues.apache.org/jira/browse/KAFKA-10055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17142451#comment-17142451 ] Vito Jeng commented on KAFKA-10055: --- [~bchen225242] Got it. > Add shared internal utility class for Streams module > > > Key: KAFKA-10055 > URL: https://issues.apache.org/jira/browse/KAFKA-10055 > Project: Kafka > Issue Type: Improvement > Components: streams >Reporter: Matthias J. Sax >Assignee: Vito Jeng >Priority: Minor > Labels: beginner, newbie > > Throughout the code base we added small helper methods (usually static) when > needed. Those helpers are often added to classes they don't really belong to > (out of convenience) and may lead to coded duplication. > We should add a shared utility class that unifies all those helper methods > into a single place. > For example `StreamsThread#eosEnabled`. Please update this ticket description > to add more such methods (or just leave a comment). -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (KAFKA-10055) Add shared internal utility class for Streams module
[ https://issues.apache.org/jira/browse/KAFKA-10055?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vito Jeng reassigned KAFKA-10055: - Assignee: Vito Jeng > Add shared internal utility class for Streams module > > > Key: KAFKA-10055 > URL: https://issues.apache.org/jira/browse/KAFKA-10055 > Project: Kafka > Issue Type: Improvement > Components: streams >Reporter: Matthias J. Sax >Assignee: Vito Jeng >Priority: Minor > Labels: beginner, newbie > > Throughout the code base we added small helper methods (usually static) when > needed. Those helpers are often added to classes they don't really belong to > (out of convenience) and may lead to coded duplication. > We should add a shared utility class that unifies all those helper methods > into a single place. > For example `StreamsThread#eosEnabled`. Please update this ticket description > to add more such methods (or just leave a comment). -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (KAFKA-10055) Add shared internal utility class for Streams module
[ https://issues.apache.org/jira/browse/KAFKA-10055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17125407#comment-17125407 ] Vito Jeng commented on KAFKA-10055: --- [~mjsax] Can I take this? > Add shared internal utility class for Streams module > > > Key: KAFKA-10055 > URL: https://issues.apache.org/jira/browse/KAFKA-10055 > Project: Kafka > Issue Type: Improvement > Components: streams >Reporter: Matthias J. Sax >Priority: Minor > Labels: beginner, newbie > > Throughout the code base we added small helper methods (usually static) when > needed. Those helpers are often added to classes they don't really belong to > (out of convenience) and may lead to coded duplication. > We should add a shared utility class that unifies all those helper methods > into a single place. > For example `StreamsThread#eosEnabled`. Please update this ticket description > to add more such methods (or just leave a comment). -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (KAFKA-9471) Throw exception for DEAD StreamThread.State
[
https://issues.apache.org/jira/browse/KAFKA-9471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17022980#comment-17022980
]
Vito Jeng commented on KAFKA-9471:
--
[~yuzhih...@gmail.com]
Yes, I would be include this in KIP-216.
> Throw exception for DEAD StreamThread.State
> ---
>
> Key: KAFKA-9471
> URL: https://issues.apache.org/jira/browse/KAFKA-9471
> Project: Kafka
> Issue Type: Improvement
> Components: streams
>Reporter: Ted Yu
>Assignee: Ted Yu
>Priority: Minor
>
> In StreamThreadStateStoreProvider we have:
> {code}
> if (streamThread.state() == StreamThread.State.DEAD) {
> return Collections.emptyList();
> {code}
> If user cannot retry anymore, we should throw exception which is handled in
> the else block.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (KAFKA-9471) Throw exception for DEAD StreamThread.State
[
https://issues.apache.org/jira/browse/KAFKA-9471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17022968#comment-17022968
]
Vito Jeng commented on KAFKA-9471:
--
[~yuzhih...@gmail.com]
Yes. Currently, *shouldAllowToQueryAfterThreadDied()* would be fail when
InvalidStateStoreException thrown.
This test method also should be update, IMO.
I notice this during KIP-216 implementation, too, but my PR is not yet
completed.
> Throw exception for DEAD StreamThread.State
> ---
>
> Key: KAFKA-9471
> URL: https://issues.apache.org/jira/browse/KAFKA-9471
> Project: Kafka
> Issue Type: Improvement
> Components: streams
>Reporter: Ted Yu
>Assignee: Ted Yu
>Priority: Minor
>
> In StreamThreadStateStoreProvider we have:
> {code}
> if (streamThread.state() == StreamThread.State.DEAD) {
> return Collections.emptyList();
> {code}
> If user cannot retry anymore, we should throw exception which is handled in
> the else block.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (KAFKA-9471) Return empty collection for PENDING_SHUTDOWN
[
https://issues.apache.org/jira/browse/KAFKA-9471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17022586#comment-17022586
]
Vito Jeng commented on KAFKA-9471:
--
Thanks [~yuzhih...@gmail.com] point this.
In KIP-216, we handle state store related exception based on Streams state, not
StreamThread state. IMHO, I think we should throw exception rather than empty
list and user cannot retry anymore.
> Return empty collection for PENDING_SHUTDOWN
>
>
> Key: KAFKA-9471
> URL: https://issues.apache.org/jira/browse/KAFKA-9471
> Project: Kafka
> Issue Type: Improvement
> Components: streams
>Reporter: Ted Yu
>Assignee: Ted Yu
>Priority: Minor
>
> In StreamThreadStateStoreProvider we have:
> {code}
> if (streamThread.state() == StreamThread.State.DEAD) {
> return Collections.emptyList();
> {code}
> PENDING_SHUTDOWN is precursor to DEAD state.
> PENDING_SHUTDOWN should be treated the same way as DEAD.
> This makes more sense than current behavior of throwing exception for
> PENDING_SHUTDOWN.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (KAFKA-5876) IQ should throw different exceptions for different errors
[
https://issues.apache.org/jira/browse/KAFKA-5876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16347957#comment-16347957
]
Vito Jeng commented on KAFKA-5876:
--
[~Pegerto] Thanks!
> IQ should throw different exceptions for different errors
> -
>
> Key: KAFKA-5876
> URL: https://issues.apache.org/jira/browse/KAFKA-5876
> Project: Kafka
> Issue Type: Task
> Components: streams
>Reporter: Matthias J. Sax
>Assignee: Vito Jeng
>Priority: Major
> Labels: needs-kip, newbie++
> Fix For: 1.2.0
>
>
> Currently, IQ does only throws {{InvalidStateStoreException}} for all errors
> that occur. However, we have different types of errors and should throw
> different exceptions for those types.
> For example, if a store was migrated it must be rediscovered while if a store
> cannot be queried yet, because it is still re-created after a rebalance, the
> user just needs to wait until store recreation is finished.
> There might be other examples, too.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (KAFKA-5876) IQ should throw different exceptions for different errors
[
https://issues.apache.org/jira/browse/KAFKA-5876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16195313#comment-16195313
]
Vito Jeng commented on KAFKA-5876:
--
Thanks. I'll write my first KIP. ;)
> IQ should throw different exceptions for different errors
> -
>
> Key: KAFKA-5876
> URL: https://issues.apache.org/jira/browse/KAFKA-5876
> Project: Kafka
> Issue Type: Sub-task
> Components: streams
>Reporter: Matthias J. Sax
>Assignee: Vito Jeng
> Labels: needs-kip, newbie++
> Fix For: 1.1.0
>
>
> Currently, IQ does only throws {{InvalidStateStoreException}} for all errors
> that occur. However, we have different types of errors and should throw
> different exceptions for those types.
> For example, if a store was migrated it must be rediscovered while if a store
> cannot be queried yet, because it is still re-created after a rebalance, the
> user just needs to wait until store recreation is finished.
> There might be other examples, too.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Assigned] (KAFKA-5876) IQ should throw different exceptions for different errors
[
https://issues.apache.org/jira/browse/KAFKA-5876?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Vito Jeng reassigned KAFKA-5876:
Assignee: Vito Jeng
> IQ should throw different exceptions for different errors
> -
>
> Key: KAFKA-5876
> URL: https://issues.apache.org/jira/browse/KAFKA-5876
> Project: Kafka
> Issue Type: Sub-task
> Components: streams
>Reporter: Matthias J. Sax
>Assignee: Vito Jeng
> Labels: needs-kip, newbie++
> Fix For: 1.1.0
>
>
> Currently, IQ does only throws {{InvalidStateStoreException}} for all errors
> that occur. However, we have different types of errors and should throw
> different exceptions for those types.
> For example, if a store was migrated it must be rediscovered while if a store
> cannot be queried yet, because it is still re-created after a rebalance, the
> user just needs to wait until store recreation is finished.
> There might be other examples, too.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (KAFKA-5876) IQ should throw different exceptions for different errors
[
https://issues.apache.org/jira/browse/KAFKA-5876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16194325#comment-16194325
]
Vito Jeng commented on KAFKA-5876:
--
Could I work on this issue?
> IQ should throw different exceptions for different errors
> -
>
> Key: KAFKA-5876
> URL: https://issues.apache.org/jira/browse/KAFKA-5876
> Project: Kafka
> Issue Type: Sub-task
> Components: streams
>Reporter: Matthias J. Sax
> Labels: needs-kip, newbie++
> Fix For: 1.1.0
>
>
> Currently, IQ does only throws {{InvalidStateStoreException}} for all errors
> that occur. However, we have different types of errors and should throw
> different exceptions for those types.
> For example, if a store was migrated it must be rediscovered while if a store
> cannot be queried yet, because it is still re-created after a rebalance, the
> user just needs to wait until store recreation is finished.
> There might be other examples, too.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
