[GitHub] [kafka] ableegoldman commented on a change in pull request #10568: KAFKA-8897: Upgrade RocksDB to 6.19.3
ableegoldman commented on a change in pull request #10568:
URL: https://github.com/apache/kafka/pull/10568#discussion_r629637264
##
File path:
streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBGenericOptionsToDbOptionsColumnFamilyOptionsAdapter.java
##
@@ -1381,6 +1364,313 @@ public WriteBufferManager writeBufferManager() {
return dbOptions.writeBufferManager();
}
+@Override
+public Options setMaxWriteBatchGroupSizeBytes(final long
maxWriteBatchGroupSizeBytes) {
+dbOptions.setMaxWriteBatchGroupSizeBytes(maxWriteBatchGroupSizeBytes);
+return this;
+}
+
+@Override
+public long maxWriteBatchGroupSizeBytes() {
+return dbOptions.maxWriteBatchGroupSizeBytes();
+}
+
+@Override
+public Options oldDefaults(final int majorVersion, final int minorVersion)
{
+columnFamilyOptions.oldDefaults(majorVersion, minorVersion);
+return this;
+}
+
+@Override
+public Options optimizeForSmallDb(final Cache cache) {
+return super.optimizeForSmallDb(cache);
+}
+
+@Override
+public AbstractCompactionFilter>
compactionFilter() {
+return columnFamilyOptions.compactionFilter();
+}
+
+@Override
+public AbstractCompactionFilterFactory> compactionFilterFactory() {
+return columnFamilyOptions.compactionFilterFactory();
+}
+
+@Override
+public Options setStatsPersistPeriodSec(final int statsPersistPeriodSec) {
+dbOptions.setStatsPersistPeriodSec(statsPersistPeriodSec);
+return this;
+}
+
+@Override
+public int statsPersistPeriodSec() {
+return dbOptions.statsPersistPeriodSec();
+}
+
+@Override
+public Options setStatsHistoryBufferSize(final long
statsHistoryBufferSize) {
+dbOptions.setStatsHistoryBufferSize(statsHistoryBufferSize);
+return this;
+}
+
+@Override
+public long statsHistoryBufferSize() {
+return dbOptions.statsHistoryBufferSize();
+}
+
+@Override
+public Options setStrictBytesPerSync(final boolean strictBytesPerSync) {
+dbOptions.setStrictBytesPerSync(strictBytesPerSync);
+return this;
+}
+
+@Override
+public boolean strictBytesPerSync() {
+return dbOptions.strictBytesPerSync();
+}
+
+@Override
+public Options setListeners(final List listeners) {
+dbOptions.setListeners(listeners);
+return this;
+}
+
+@Override
+public List listeners() {
+return dbOptions.listeners();
+}
+
+@Override
+public Options setEnablePipelinedWrite(final boolean enablePipelinedWrite)
{
+dbOptions.setEnablePipelinedWrite(enablePipelinedWrite);
+return this;
+}
+
+@Override
+public boolean enablePipelinedWrite() {
+return dbOptions.enablePipelinedWrite();
+}
+
+@Override
+public Options setUnorderedWrite(final boolean unorderedWrite) {
+dbOptions.setUnorderedWrite(unorderedWrite);
+return this;
+}
+
+@Override
+public boolean unorderedWrite() {
+return dbOptions.unorderedWrite();
+}
+
+@Override
+public Options setSkipCheckingSstFileSizesOnDbOpen(final boolean
skipCheckingSstFileSizesOnDbOpen) {
+
dbOptions.setSkipCheckingSstFileSizesOnDbOpen(skipCheckingSstFileSizesOnDbOpen);
+return this;
+}
+
+@Override
+public boolean skipCheckingSstFileSizesOnDbOpen() {
+return dbOptions.skipCheckingSstFileSizesOnDbOpen();
+}
+
+@Override
+public Options setWalFilter(final AbstractWalFilter walFilter) {
+dbOptions.setWalFilter(walFilter);
+return this;
+}
+
+@Override
+public WalFilter walFilter() {
+return dbOptions.walFilter();
+}
+
+@Override
+public Options setAllowIngestBehind(final boolean allowIngestBehind) {
+dbOptions.setAllowIngestBehind(allowIngestBehind);
+return this;
+}
+
+@Override
+public boolean allowIngestBehind() {
+return dbOptions.allowIngestBehind();
+}
+
+@Override
+public Options setPreserveDeletes(final boolean preserveDeletes) {
+dbOptions.setPreserveDeletes(preserveDeletes);
+return this;
+}
+
+@Override
+public boolean preserveDeletes() {
+return dbOptions.preserveDeletes();
+}
+
+@Override
+public Options setTwoWriteQueues(final boolean twoWriteQueues) {
+dbOptions.setTwoWriteQueues(twoWriteQueues);
+return this;
+}
+
+@Override
+public boolean twoWriteQueues() {
+return dbOptions.twoWriteQueues();
+}
+
+@Override
+public Options setManualWalFlush(final boolean manualWalFlush) {
+dbOptions.setManualWalFlush(manualWalFlush);
+return this;
+}
+
+@Override
+public boolean manualWalFlush() {
+return dbOptions.manualWalFlush();
+}
+
+@Override
+public Options
[GitHub] [kafka] ableegoldman commented on a change in pull request #10568: KAFKA-8897: Upgrade RocksDB to 6.19.3
ableegoldman commented on a change in pull request #10568:
URL: https://github.com/apache/kafka/pull/10568#discussion_r628815764
##
File path:
streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBGenericOptionsToDbOptionsColumnFamilyOptionsAdapter.java
##
@@ -1381,6 +1364,313 @@ public WriteBufferManager writeBufferManager() {
return dbOptions.writeBufferManager();
}
+@Override
+public Options setMaxWriteBatchGroupSizeBytes(final long
maxWriteBatchGroupSizeBytes) {
+dbOptions.setMaxWriteBatchGroupSizeBytes(maxWriteBatchGroupSizeBytes);
+return this;
+}
+
+@Override
+public long maxWriteBatchGroupSizeBytes() {
+return dbOptions.maxWriteBatchGroupSizeBytes();
+}
+
+@Override
+public Options oldDefaults(final int majorVersion, final int minorVersion)
{
+columnFamilyOptions.oldDefaults(majorVersion, minorVersion);
+return this;
+}
+
+@Override
+public Options optimizeForSmallDb(final Cache cache) {
+return super.optimizeForSmallDb(cache);
+}
+
+@Override
+public AbstractCompactionFilter>
compactionFilter() {
+return columnFamilyOptions.compactionFilter();
+}
+
+@Override
+public AbstractCompactionFilterFactory> compactionFilterFactory() {
+return columnFamilyOptions.compactionFilterFactory();
+}
+
+@Override
+public Options setStatsPersistPeriodSec(final int statsPersistPeriodSec) {
+dbOptions.setStatsPersistPeriodSec(statsPersistPeriodSec);
+return this;
+}
+
+@Override
+public int statsPersistPeriodSec() {
+return dbOptions.statsPersistPeriodSec();
+}
+
+@Override
+public Options setStatsHistoryBufferSize(final long
statsHistoryBufferSize) {
+dbOptions.setStatsHistoryBufferSize(statsHistoryBufferSize);
+return this;
+}
+
+@Override
+public long statsHistoryBufferSize() {
+return dbOptions.statsHistoryBufferSize();
+}
+
+@Override
+public Options setStrictBytesPerSync(final boolean strictBytesPerSync) {
+dbOptions.setStrictBytesPerSync(strictBytesPerSync);
+return this;
+}
+
+@Override
+public boolean strictBytesPerSync() {
+return dbOptions.strictBytesPerSync();
+}
+
+@Override
+public Options setListeners(final List listeners) {
+dbOptions.setListeners(listeners);
+return this;
+}
+
+@Override
+public List listeners() {
+return dbOptions.listeners();
+}
+
+@Override
+public Options setEnablePipelinedWrite(final boolean enablePipelinedWrite)
{
+dbOptions.setEnablePipelinedWrite(enablePipelinedWrite);
+return this;
+}
+
+@Override
+public boolean enablePipelinedWrite() {
+return dbOptions.enablePipelinedWrite();
+}
+
+@Override
+public Options setUnorderedWrite(final boolean unorderedWrite) {
+dbOptions.setUnorderedWrite(unorderedWrite);
+return this;
+}
+
+@Override
+public boolean unorderedWrite() {
+return dbOptions.unorderedWrite();
+}
+
+@Override
+public Options setSkipCheckingSstFileSizesOnDbOpen(final boolean
skipCheckingSstFileSizesOnDbOpen) {
+
dbOptions.setSkipCheckingSstFileSizesOnDbOpen(skipCheckingSstFileSizesOnDbOpen);
+return this;
+}
+
+@Override
+public boolean skipCheckingSstFileSizesOnDbOpen() {
+return dbOptions.skipCheckingSstFileSizesOnDbOpen();
+}
+
+@Override
+public Options setWalFilter(final AbstractWalFilter walFilter) {
+dbOptions.setWalFilter(walFilter);
Review comment:
> Whatever, we decide I would like to have that in a separate PR.
Sounds good. If you don't have time to follow up right away, can you just
file a quick ticket so we don't forget?
Maybe you are not as forgetful as I am, but I always worry any things like
this, whether small or critically important, can be easily lost in the flood of
other things we are all working on at any given time
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [kafka] ableegoldman commented on a change in pull request #10568: KAFKA-8897: Upgrade RocksDB to 6.19.3
ableegoldman commented on a change in pull request #10568:
URL: https://github.com/apache/kafka/pull/10568#discussion_r628815666
##
File path:
streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBGenericOptionsToDbOptionsColumnFamilyOptionsAdapter.java
##
@@ -1381,6 +1364,313 @@ public WriteBufferManager writeBufferManager() {
return dbOptions.writeBufferManager();
}
+@Override
+public Options setMaxWriteBatchGroupSizeBytes(final long
maxWriteBatchGroupSizeBytes) {
+dbOptions.setMaxWriteBatchGroupSizeBytes(maxWriteBatchGroupSizeBytes);
+return this;
+}
+
+@Override
+public long maxWriteBatchGroupSizeBytes() {
+return dbOptions.maxWriteBatchGroupSizeBytes();
+}
+
+@Override
+public Options oldDefaults(final int majorVersion, final int minorVersion)
{
+columnFamilyOptions.oldDefaults(majorVersion, minorVersion);
+return this;
+}
+
+@Override
+public Options optimizeForSmallDb(final Cache cache) {
+return super.optimizeForSmallDb(cache);
+}
+
+@Override
+public AbstractCompactionFilter>
compactionFilter() {
+return columnFamilyOptions.compactionFilter();
+}
+
+@Override
+public AbstractCompactionFilterFactory> compactionFilterFactory() {
+return columnFamilyOptions.compactionFilterFactory();
+}
+
+@Override
+public Options setStatsPersistPeriodSec(final int statsPersistPeriodSec) {
+dbOptions.setStatsPersistPeriodSec(statsPersistPeriodSec);
+return this;
+}
+
+@Override
+public int statsPersistPeriodSec() {
+return dbOptions.statsPersistPeriodSec();
+}
+
+@Override
+public Options setStatsHistoryBufferSize(final long
statsHistoryBufferSize) {
+dbOptions.setStatsHistoryBufferSize(statsHistoryBufferSize);
+return this;
+}
+
+@Override
+public long statsHistoryBufferSize() {
+return dbOptions.statsHistoryBufferSize();
+}
+
+@Override
+public Options setStrictBytesPerSync(final boolean strictBytesPerSync) {
+dbOptions.setStrictBytesPerSync(strictBytesPerSync);
+return this;
+}
+
+@Override
+public boolean strictBytesPerSync() {
+return dbOptions.strictBytesPerSync();
+}
+
+@Override
+public Options setListeners(final List listeners) {
+dbOptions.setListeners(listeners);
+return this;
+}
+
+@Override
+public List listeners() {
+return dbOptions.listeners();
+}
+
+@Override
+public Options setEnablePipelinedWrite(final boolean enablePipelinedWrite)
{
+dbOptions.setEnablePipelinedWrite(enablePipelinedWrite);
+return this;
+}
+
+@Override
+public boolean enablePipelinedWrite() {
+return dbOptions.enablePipelinedWrite();
+}
+
+@Override
+public Options setUnorderedWrite(final boolean unorderedWrite) {
+dbOptions.setUnorderedWrite(unorderedWrite);
+return this;
+}
+
+@Override
+public boolean unorderedWrite() {
+return dbOptions.unorderedWrite();
+}
+
+@Override
+public Options setSkipCheckingSstFileSizesOnDbOpen(final boolean
skipCheckingSstFileSizesOnDbOpen) {
+
dbOptions.setSkipCheckingSstFileSizesOnDbOpen(skipCheckingSstFileSizesOnDbOpen);
+return this;
+}
+
+@Override
+public boolean skipCheckingSstFileSizesOnDbOpen() {
+return dbOptions.skipCheckingSstFileSizesOnDbOpen();
+}
+
+@Override
+public Options setWalFilter(final AbstractWalFilter walFilter) {
+dbOptions.setWalFilter(walFilter);
+return this;
+}
+
+@Override
+public WalFilter walFilter() {
+return dbOptions.walFilter();
+}
+
+@Override
+public Options setAllowIngestBehind(final boolean allowIngestBehind) {
+dbOptions.setAllowIngestBehind(allowIngestBehind);
+return this;
+}
+
+@Override
+public boolean allowIngestBehind() {
+return dbOptions.allowIngestBehind();
+}
+
+@Override
+public Options setPreserveDeletes(final boolean preserveDeletes) {
+dbOptions.setPreserveDeletes(preserveDeletes);
+return this;
+}
+
+@Override
+public boolean preserveDeletes() {
+return dbOptions.preserveDeletes();
+}
+
+@Override
+public Options setTwoWriteQueues(final boolean twoWriteQueues) {
+dbOptions.setTwoWriteQueues(twoWriteQueues);
+return this;
+}
+
+@Override
+public boolean twoWriteQueues() {
+return dbOptions.twoWriteQueues();
+}
+
+@Override
+public Options setManualWalFlush(final boolean manualWalFlush) {
+dbOptions.setManualWalFlush(manualWalFlush);
+return this;
+}
+
+@Override
+public boolean manualWalFlush() {
+return dbOptions.manualWalFlush();
+}
+
+@Override
+public Options
[GitHub] [kafka] ableegoldman commented on a change in pull request #10568: KAFKA-8897: Upgrade RocksDB to 6.19.3
ableegoldman commented on a change in pull request #10568:
URL: https://github.com/apache/kafka/pull/10568#discussion_r626990213
##
File path:
streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBGenericOptionsToDbOptionsColumnFamilyOptionsAdapter.java
##
@@ -1381,6 +1364,313 @@ public WriteBufferManager writeBufferManager() {
return dbOptions.writeBufferManager();
}
+@Override
+public Options setMaxWriteBatchGroupSizeBytes(final long
maxWriteBatchGroupSizeBytes) {
+dbOptions.setMaxWriteBatchGroupSizeBytes(maxWriteBatchGroupSizeBytes);
+return this;
+}
+
+@Override
+public long maxWriteBatchGroupSizeBytes() {
+return dbOptions.maxWriteBatchGroupSizeBytes();
+}
+
+@Override
+public Options oldDefaults(final int majorVersion, final int minorVersion)
{
+columnFamilyOptions.oldDefaults(majorVersion, minorVersion);
+return this;
+}
+
+@Override
+public Options optimizeForSmallDb(final Cache cache) {
+return super.optimizeForSmallDb(cache);
+}
+
+@Override
+public AbstractCompactionFilter>
compactionFilter() {
+return columnFamilyOptions.compactionFilter();
+}
+
+@Override
+public AbstractCompactionFilterFactory> compactionFilterFactory() {
+return columnFamilyOptions.compactionFilterFactory();
+}
+
+@Override
+public Options setStatsPersistPeriodSec(final int statsPersistPeriodSec) {
+dbOptions.setStatsPersistPeriodSec(statsPersistPeriodSec);
+return this;
+}
+
+@Override
+public int statsPersistPeriodSec() {
+return dbOptions.statsPersistPeriodSec();
+}
+
+@Override
+public Options setStatsHistoryBufferSize(final long
statsHistoryBufferSize) {
+dbOptions.setStatsHistoryBufferSize(statsHistoryBufferSize);
+return this;
+}
+
+@Override
+public long statsHistoryBufferSize() {
+return dbOptions.statsHistoryBufferSize();
+}
+
+@Override
+public Options setStrictBytesPerSync(final boolean strictBytesPerSync) {
+dbOptions.setStrictBytesPerSync(strictBytesPerSync);
+return this;
+}
+
+@Override
+public boolean strictBytesPerSync() {
+return dbOptions.strictBytesPerSync();
+}
+
+@Override
+public Options setListeners(final List listeners) {
+dbOptions.setListeners(listeners);
+return this;
+}
+
+@Override
+public List listeners() {
+return dbOptions.listeners();
+}
+
+@Override
+public Options setEnablePipelinedWrite(final boolean enablePipelinedWrite)
{
+dbOptions.setEnablePipelinedWrite(enablePipelinedWrite);
+return this;
+}
+
+@Override
+public boolean enablePipelinedWrite() {
+return dbOptions.enablePipelinedWrite();
+}
+
+@Override
+public Options setUnorderedWrite(final boolean unorderedWrite) {
+dbOptions.setUnorderedWrite(unorderedWrite);
+return this;
+}
+
+@Override
+public boolean unorderedWrite() {
+return dbOptions.unorderedWrite();
+}
+
+@Override
+public Options setSkipCheckingSstFileSizesOnDbOpen(final boolean
skipCheckingSstFileSizesOnDbOpen) {
+
dbOptions.setSkipCheckingSstFileSizesOnDbOpen(skipCheckingSstFileSizesOnDbOpen);
+return this;
+}
+
+@Override
+public boolean skipCheckingSstFileSizesOnDbOpen() {
+return dbOptions.skipCheckingSstFileSizesOnDbOpen();
+}
+
+@Override
+public Options setWalFilter(final AbstractWalFilter walFilter) {
+dbOptions.setWalFilter(walFilter);
Review comment:
Yep, in RocksDBStore we set `wOptions.setDisableWAL(true)` -- it's not
on the DB/CF options, instead it's a configuration on a separate WriteOptions
class. So we do indeed enforce that it's disabled
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [kafka] ableegoldman commented on a change in pull request #10568: KAFKA-8897: Upgrade RocksDB to 6.19.3
ableegoldman commented on a change in pull request #10568:
URL: https://github.com/apache/kafka/pull/10568#discussion_r626989130
##
File path:
streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBGenericOptionsToDbOptionsColumnFamilyOptionsAdapter.java
##
@@ -1381,6 +1364,313 @@ public WriteBufferManager writeBufferManager() {
return dbOptions.writeBufferManager();
}
+@Override
+public Options setMaxWriteBatchGroupSizeBytes(final long
maxWriteBatchGroupSizeBytes) {
+dbOptions.setMaxWriteBatchGroupSizeBytes(maxWriteBatchGroupSizeBytes);
+return this;
+}
+
+@Override
+public long maxWriteBatchGroupSizeBytes() {
+return dbOptions.maxWriteBatchGroupSizeBytes();
+}
+
+@Override
+public Options oldDefaults(final int majorVersion, final int minorVersion)
{
+columnFamilyOptions.oldDefaults(majorVersion, minorVersion);
+return this;
+}
+
+@Override
+public Options optimizeForSmallDb(final Cache cache) {
+return super.optimizeForSmallDb(cache);
+}
+
+@Override
+public AbstractCompactionFilter>
compactionFilter() {
+return columnFamilyOptions.compactionFilter();
+}
+
+@Override
+public AbstractCompactionFilterFactory> compactionFilterFactory() {
+return columnFamilyOptions.compactionFilterFactory();
+}
+
+@Override
+public Options setStatsPersistPeriodSec(final int statsPersistPeriodSec) {
+dbOptions.setStatsPersistPeriodSec(statsPersistPeriodSec);
+return this;
+}
+
+@Override
+public int statsPersistPeriodSec() {
+return dbOptions.statsPersistPeriodSec();
+}
+
+@Override
+public Options setStatsHistoryBufferSize(final long
statsHistoryBufferSize) {
+dbOptions.setStatsHistoryBufferSize(statsHistoryBufferSize);
+return this;
+}
+
+@Override
+public long statsHistoryBufferSize() {
+return dbOptions.statsHistoryBufferSize();
+}
+
+@Override
+public Options setStrictBytesPerSync(final boolean strictBytesPerSync) {
+dbOptions.setStrictBytesPerSync(strictBytesPerSync);
+return this;
+}
+
+@Override
+public boolean strictBytesPerSync() {
+return dbOptions.strictBytesPerSync();
+}
+
+@Override
+public Options setListeners(final List listeners) {
+dbOptions.setListeners(listeners);
+return this;
+}
+
+@Override
+public List listeners() {
+return dbOptions.listeners();
+}
+
+@Override
+public Options setEnablePipelinedWrite(final boolean enablePipelinedWrite)
{
+dbOptions.setEnablePipelinedWrite(enablePipelinedWrite);
+return this;
+}
+
+@Override
+public boolean enablePipelinedWrite() {
+return dbOptions.enablePipelinedWrite();
+}
+
+@Override
+public Options setUnorderedWrite(final boolean unorderedWrite) {
+dbOptions.setUnorderedWrite(unorderedWrite);
+return this;
+}
+
+@Override
+public boolean unorderedWrite() {
+return dbOptions.unorderedWrite();
+}
+
+@Override
+public Options setSkipCheckingSstFileSizesOnDbOpen(final boolean
skipCheckingSstFileSizesOnDbOpen) {
+
dbOptions.setSkipCheckingSstFileSizesOnDbOpen(skipCheckingSstFileSizesOnDbOpen);
+return this;
+}
+
+@Override
+public boolean skipCheckingSstFileSizesOnDbOpen() {
+return dbOptions.skipCheckingSstFileSizesOnDbOpen();
+}
+
+@Override
+public Options setWalFilter(final AbstractWalFilter walFilter) {
+dbOptions.setWalFilter(walFilter);
Review comment:
I thought we did actively disable it, although I'll see if I can find
where/whether this is done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [kafka] ableegoldman commented on a change in pull request #10568: KAFKA-8897: Upgrade RocksDB to 6.19.3
ableegoldman commented on a change in pull request #10568:
URL: https://github.com/apache/kafka/pull/10568#discussion_r626176038
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/GlobalStateManagerImpl.java
##
@@ -396,6 +396,21 @@ public void close() {
log.info("Skipping to close non-initialized store {}",
entry.getKey());
}
}
+for (final StateStore store : globalStateStores) {
Review comment:
Heh, @guozhangwang and I reviewed at the same time. I didn't notice that
`globalStores` would not be populated until restoration, whereas
`globalStateStores` is populated in the constructor. Imo we should just
populate `globalStores` in the constructor as well, but I guess that won't be
necessary if @guozhangwang does a quick followup to consolidate them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [kafka] ableegoldman commented on a change in pull request #10568: KAFKA-8897: Upgrade RocksDB to 6.19.3
ableegoldman commented on a change in pull request #10568:
URL: https://github.com/apache/kafka/pull/10568#discussion_r626971805
##
File path:
streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBGenericOptionsToDbOptionsColumnFamilyOptionsAdapter.java
##
@@ -1381,6 +1364,313 @@ public WriteBufferManager writeBufferManager() {
return dbOptions.writeBufferManager();
}
+@Override
+public Options setMaxWriteBatchGroupSizeBytes(final long
maxWriteBatchGroupSizeBytes) {
+dbOptions.setMaxWriteBatchGroupSizeBytes(maxWriteBatchGroupSizeBytes);
+return this;
+}
+
+@Override
+public long maxWriteBatchGroupSizeBytes() {
+return dbOptions.maxWriteBatchGroupSizeBytes();
+}
+
+@Override
+public Options oldDefaults(final int majorVersion, final int minorVersion)
{
+columnFamilyOptions.oldDefaults(majorVersion, minorVersion);
+return this;
+}
+
+@Override
+public Options optimizeForSmallDb(final Cache cache) {
+return super.optimizeForSmallDb(cache);
+}
+
+@Override
+public AbstractCompactionFilter>
compactionFilter() {
+return columnFamilyOptions.compactionFilter();
+}
+
+@Override
+public AbstractCompactionFilterFactory> compactionFilterFactory() {
+return columnFamilyOptions.compactionFilterFactory();
+}
+
+@Override
+public Options setStatsPersistPeriodSec(final int statsPersistPeriodSec) {
+dbOptions.setStatsPersistPeriodSec(statsPersistPeriodSec);
+return this;
+}
+
+@Override
+public int statsPersistPeriodSec() {
+return dbOptions.statsPersistPeriodSec();
+}
+
+@Override
+public Options setStatsHistoryBufferSize(final long
statsHistoryBufferSize) {
+dbOptions.setStatsHistoryBufferSize(statsHistoryBufferSize);
+return this;
+}
+
+@Override
+public long statsHistoryBufferSize() {
+return dbOptions.statsHistoryBufferSize();
+}
+
+@Override
+public Options setStrictBytesPerSync(final boolean strictBytesPerSync) {
+dbOptions.setStrictBytesPerSync(strictBytesPerSync);
+return this;
+}
+
+@Override
+public boolean strictBytesPerSync() {
+return dbOptions.strictBytesPerSync();
+}
+
+@Override
+public Options setListeners(final List listeners) {
+dbOptions.setListeners(listeners);
+return this;
+}
+
+@Override
+public List listeners() {
+return dbOptions.listeners();
+}
+
+@Override
+public Options setEnablePipelinedWrite(final boolean enablePipelinedWrite)
{
+dbOptions.setEnablePipelinedWrite(enablePipelinedWrite);
+return this;
+}
+
+@Override
+public boolean enablePipelinedWrite() {
+return dbOptions.enablePipelinedWrite();
+}
+
+@Override
+public Options setUnorderedWrite(final boolean unorderedWrite) {
+dbOptions.setUnorderedWrite(unorderedWrite);
+return this;
+}
+
+@Override
+public boolean unorderedWrite() {
+return dbOptions.unorderedWrite();
+}
+
+@Override
+public Options setSkipCheckingSstFileSizesOnDbOpen(final boolean
skipCheckingSstFileSizesOnDbOpen) {
+
dbOptions.setSkipCheckingSstFileSizesOnDbOpen(skipCheckingSstFileSizesOnDbOpen);
+return this;
+}
+
+@Override
+public boolean skipCheckingSstFileSizesOnDbOpen() {
+return dbOptions.skipCheckingSstFileSizesOnDbOpen();
+}
+
+@Override
+public Options setWalFilter(final AbstractWalFilter walFilter) {
+dbOptions.setWalFilter(walFilter);
+return this;
+}
+
+@Override
+public WalFilter walFilter() {
+return dbOptions.walFilter();
+}
+
+@Override
+public Options setAllowIngestBehind(final boolean allowIngestBehind) {
+dbOptions.setAllowIngestBehind(allowIngestBehind);
+return this;
+}
+
+@Override
+public boolean allowIngestBehind() {
+return dbOptions.allowIngestBehind();
+}
+
+@Override
+public Options setPreserveDeletes(final boolean preserveDeletes) {
+dbOptions.setPreserveDeletes(preserveDeletes);
+return this;
+}
+
+@Override
+public boolean preserveDeletes() {
+return dbOptions.preserveDeletes();
+}
+
+@Override
+public Options setTwoWriteQueues(final boolean twoWriteQueues) {
+dbOptions.setTwoWriteQueues(twoWriteQueues);
+return this;
+}
+
+@Override
+public boolean twoWriteQueues() {
+return dbOptions.twoWriteQueues();
+}
+
+@Override
+public Options setManualWalFlush(final boolean manualWalFlush) {
+dbOptions.setManualWalFlush(manualWalFlush);
+return this;
+}
+
+@Override
+public boolean manualWalFlush() {
+return dbOptions.manualWalFlush();
+}
+
+@Override
+public Options
[GitHub] [kafka] ableegoldman commented on a change in pull request #10568: KAFKA-8897: Upgrade RocksDB to 6.19.3
ableegoldman commented on a change in pull request #10568:
URL: https://github.com/apache/kafka/pull/10568#discussion_r626971137
##
File path:
streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBGenericOptionsToDbOptionsColumnFamilyOptionsAdapter.java
##
@@ -1381,6 +1364,313 @@ public WriteBufferManager writeBufferManager() {
return dbOptions.writeBufferManager();
}
+@Override
+public Options setMaxWriteBatchGroupSizeBytes(final long
maxWriteBatchGroupSizeBytes) {
+dbOptions.setMaxWriteBatchGroupSizeBytes(maxWriteBatchGroupSizeBytes);
+return this;
+}
+
+@Override
+public long maxWriteBatchGroupSizeBytes() {
+return dbOptions.maxWriteBatchGroupSizeBytes();
+}
+
+@Override
+public Options oldDefaults(final int majorVersion, final int minorVersion)
{
+columnFamilyOptions.oldDefaults(majorVersion, minorVersion);
+return this;
+}
+
+@Override
+public Options optimizeForSmallDb(final Cache cache) {
+return super.optimizeForSmallDb(cache);
+}
+
+@Override
+public AbstractCompactionFilter>
compactionFilter() {
+return columnFamilyOptions.compactionFilter();
+}
+
+@Override
+public AbstractCompactionFilterFactory> compactionFilterFactory() {
+return columnFamilyOptions.compactionFilterFactory();
+}
+
+@Override
+public Options setStatsPersistPeriodSec(final int statsPersistPeriodSec) {
+dbOptions.setStatsPersistPeriodSec(statsPersistPeriodSec);
+return this;
+}
+
+@Override
+public int statsPersistPeriodSec() {
+return dbOptions.statsPersistPeriodSec();
+}
+
+@Override
+public Options setStatsHistoryBufferSize(final long
statsHistoryBufferSize) {
+dbOptions.setStatsHistoryBufferSize(statsHistoryBufferSize);
+return this;
+}
+
+@Override
+public long statsHistoryBufferSize() {
+return dbOptions.statsHistoryBufferSize();
+}
+
+@Override
+public Options setStrictBytesPerSync(final boolean strictBytesPerSync) {
+dbOptions.setStrictBytesPerSync(strictBytesPerSync);
+return this;
+}
+
+@Override
+public boolean strictBytesPerSync() {
+return dbOptions.strictBytesPerSync();
+}
+
+@Override
+public Options setListeners(final List listeners) {
+dbOptions.setListeners(listeners);
+return this;
+}
+
+@Override
+public List listeners() {
+return dbOptions.listeners();
+}
+
+@Override
+public Options setEnablePipelinedWrite(final boolean enablePipelinedWrite)
{
+dbOptions.setEnablePipelinedWrite(enablePipelinedWrite);
+return this;
+}
+
+@Override
+public boolean enablePipelinedWrite() {
+return dbOptions.enablePipelinedWrite();
+}
+
+@Override
+public Options setUnorderedWrite(final boolean unorderedWrite) {
+dbOptions.setUnorderedWrite(unorderedWrite);
+return this;
+}
+
+@Override
+public boolean unorderedWrite() {
+return dbOptions.unorderedWrite();
+}
+
+@Override
+public Options setSkipCheckingSstFileSizesOnDbOpen(final boolean
skipCheckingSstFileSizesOnDbOpen) {
+
dbOptions.setSkipCheckingSstFileSizesOnDbOpen(skipCheckingSstFileSizesOnDbOpen);
+return this;
+}
+
+@Override
+public boolean skipCheckingSstFileSizesOnDbOpen() {
+return dbOptions.skipCheckingSstFileSizesOnDbOpen();
+}
+
+@Override
+public Options setWalFilter(final AbstractWalFilter walFilter) {
+dbOptions.setWalFilter(walFilter);
+return this;
+}
+
+@Override
+public WalFilter walFilter() {
+return dbOptions.walFilter();
+}
+
+@Override
+public Options setAllowIngestBehind(final boolean allowIngestBehind) {
+dbOptions.setAllowIngestBehind(allowIngestBehind);
+return this;
+}
+
+@Override
+public boolean allowIngestBehind() {
+return dbOptions.allowIngestBehind();
+}
+
+@Override
+public Options setPreserveDeletes(final boolean preserveDeletes) {
+dbOptions.setPreserveDeletes(preserveDeletes);
+return this;
+}
+
+@Override
+public boolean preserveDeletes() {
+return dbOptions.preserveDeletes();
+}
+
+@Override
+public Options setTwoWriteQueues(final boolean twoWriteQueues) {
+dbOptions.setTwoWriteQueues(twoWriteQueues);
+return this;
+}
+
+@Override
+public boolean twoWriteQueues() {
+return dbOptions.twoWriteQueues();
+}
+
+@Override
+public Options setManualWalFlush(final boolean manualWalFlush) {
+dbOptions.setManualWalFlush(manualWalFlush);
+return this;
+}
+
+@Override
+public boolean manualWalFlush() {
+return dbOptions.manualWalFlush();
+}
+
+@Override
+public Options
