[GitHub] [kafka] hachikuji commented on a change in pull request #9979: KAFKA-12238; Implement `DescribeProducers` API from KIP-664
hachikuji commented on a change in pull request #9979:
URL: https://github.com/apache/kafka/pull/9979#discussion_r565525057
##
File path: core/src/main/scala/kafka/server/KafkaApis.scala
##
@@ -3365,6 +3366,44 @@ class KafkaApis(val requestChannel: RequestChannel,
}
}
+ def handleDescribeProducersRequest(request: RequestChannel.Request): Unit = {
+val describeProducersRequest = request.body[DescribeProducersRequest]
+
+def partitionError(topicPartition: TopicPartition, error: Errors):
DescribeProducersResponseData.PartitionResponse = {
+ new DescribeProducersResponseData.PartitionResponse()
+.setPartitionIndex(topicPartition.partition)
+.setErrorCode(error.code)
+}
+
+val response = new DescribeProducersResponseData()
+describeProducersRequest.data.topics.forEach { topicRequest =>
+ val topicResponse = new DescribeProducersResponseData.TopicResponse()
+.setName(topicRequest.name)
+ val topicError = if (!authHelper.authorize(request.context, READ, TOPIC,
topicRequest.name))
+Some(Errors.TOPIC_AUTHORIZATION_FAILED)
+ else if (!metadataCache.contains(topicRequest.name))
+Some(Errors.UNKNOWN_TOPIC_OR_PARTITION)
+ else
+None
+
+ topicRequest.partitionIndexes.forEach { partitionId =>
+val topicPartition = new TopicPartition(topicRequest.name, partitionId)
+val partitionResponse = topicError match {
+ case Some(error) => partitionError(topicPartition, error)
+ case None => replicaManager.activeProducerState(topicPartition)
+}
+topicResponse.partitions.add(partitionResponse)
+ }
+
+ if (!topicResponse.partitions.isEmpty) {
+response.topics.add(topicResponse)
+ }
Review comment:
Hmm... It's been a while since I wrote this. I agree it looks a little
strange. I guess there's probably no harm echoing back the same structure that
was sent.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [kafka] hachikuji commented on a change in pull request #9979: KAFKA-12238; Implement `DescribeProducers` API from KIP-664
hachikuji commented on a change in pull request #9979:
URL: https://github.com/apache/kafka/pull/9979#discussion_r565519812
##
File path:
clients/src/main/resources/common/message/DescribeProducersResponse.json
##
@@ -0,0 +1,46 @@
+// Licensed to the Apache Software Foundation (ASF) under one or more
+// contributor license agreements. See the NOTICE file distributed with
+// this work for additional information regarding copyright ownership.
+// The ASF licenses this file to You under the Apache License, Version 2.0
+// (the "License"); you may not use this file except in compliance with
+// the License. You may obtain a copy of the License at
+//
+//http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+{
+ "apiKey": 61,
+ "type": "response",
+ "name": "DescribeProducersResponse",
+ "validVersions": "0",
+ "flexibleVersions": "0+",
+ "fields": [
+{ "name": "ThrottleTimeMs", "type": "int32", "versions": "0+",
"ignorable": true,
+ "about": "The duration in milliseconds for which the request was
throttled due to a quota violation, or zero if the request did not violate any
quota." },
+{ "name": "Topics", "type": "[]TopicResponse", "versions": "0+",
+ "about": "Each topic in the response.", "fields": [
+ { "name": "Name", "type": "string", "versions": "0+", "entityType":
"topicName",
+"about": "The topic name" },
+ { "name": "Partitions", "type": "[]PartitionResponse", "versions": "0+",
+"about": "Each partition in the response.", "fields": [
+{ "name": "PartitionIndex", "type": "int32", "versions": "0+",
+ "about": "The partition index." },
+{ "name": "ErrorCode", "type": "int16", "versions": "0+",
+ "about": "The partition error code, or 0 if there was no error." },
Review comment:
I don't feel strongly about it. Perhaps it's better to have it than not.
I will add it.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [kafka] hachikuji commented on a change in pull request #9979: KAFKA-12238; Implement `DescribeProducers` API from KIP-664
hachikuji commented on a change in pull request #9979:
URL: https://github.com/apache/kafka/pull/9979#discussion_r565517686
##
File path:
clients/src/test/java/org/apache/kafka/common/requests/RequestResponseTest.java
##
@@ -511,6 +513,9 @@ public void testSerialization() throws Exception {
checkRequest(createAlterClientQuotasRequest(), true);
checkErrorResponse(createAlterClientQuotasRequest(),
unknownServerException, true);
checkResponse(createAlterClientQuotasResponse(), 0, true);
+checkRequest(createDescribeProducersRequest(), true);
+checkErrorResponse(createDescribeProducersRequest(),
unknownServerException, true);
+checkResponse(createDescribeProducersResponse(), 0, true);
Review comment:
Sounds reasonable. I'm also not super fond of this test pattern.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
