[GitHub] [kafka] jsancio commented on a diff in pull request #13917: MINOR; Failed move should be logged at WARN
jsancio commented on code in PR #13917:
URL: https://github.com/apache/kafka/pull/13917#discussion_r1242449562
##
clients/src/main/java/org/apache/kafka/common/utils/Utils.java:
##
@@ -978,9 +978,9 @@ public static void atomicMoveWithFallback(Path source, Path
target, boolean need
Files.move(source, target, StandardCopyOption.ATOMIC_MOVE);
} catch (IOException outer) {
try {
+log.warn("Failed atomic move of {} to {} retring with a
non-atomic move", source, target, outer);
Files.move(source, target,
StandardCopyOption.REPLACE_EXISTING);
-log.debug("Non-atomic move of {} to {} succeeded after atomic
move failed due to {}", source, target,
-outer.getMessage());
+log.debug("Non-atomic move of {} to {} succeeded after atomic
move failed", source, target);
Review Comment:
Yeah. I think so. I care more about the atomic move failing and less about
the non-atomic move succeeding.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [kafka] jsancio commented on a diff in pull request #13917: MINOR; Failed move should be logged at WARN
jsancio commented on code in PR #13917:
URL: https://github.com/apache/kafka/pull/13917#discussion_r1242443198
##
clients/src/main/java/org/apache/kafka/common/utils/Utils.java:
##
@@ -979,7 +979,7 @@ public static void atomicMoveWithFallback(Path source, Path
target, boolean need
} catch (IOException outer) {
try {
Files.move(source, target,
StandardCopyOption.REPLACE_EXISTING);
-log.debug("Non-atomic move of {} to {} succeeded after atomic
move failed due to {}", source, target,
+log.warn("Non-atomic move of {} to {} succeeded after atomic
move failed due to {}", source, target,
Review Comment:
I agree. I added an WARN log message after the atomic move failed and before
the non-atomic move.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [kafka] jsancio commented on a diff in pull request #13917: MINOR; Failed move should be logged at WARN
jsancio commented on code in PR #13917:
URL: https://github.com/apache/kafka/pull/13917#discussion_r1242429861
##
clients/src/main/java/org/apache/kafka/common/utils/Utils.java:
##
@@ -979,7 +979,7 @@ public static void atomicMoveWithFallback(Path source, Path
target, boolean need
} catch (IOException outer) {
try {
Files.move(source, target,
StandardCopyOption.REPLACE_EXISTING);
-log.debug("Non-atomic move of {} to {} succeeded after atomic
move failed due to {}", source, target,
+log.warn("Non-atomic move of {} to {} succeeded after atomic
move failed due to {}", source, target,
Review Comment:
Hmm. Log levels are hard to argue. To me, it is really bad if a `move` fails
and Kafka falls back to `copy`.
There is a lot of code like the `Snaphsot.freeze` that assume `move`
semantic for correctness.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
