[GitHub] [kafka] kamalcph commented on a diff in pull request #14151: KAFKA-15083: add config with "remote.log.metadata" prefix

2023-08-05 Thread via GitHub 


kamalcph commented on code in PR #14151:
URL: https://github.com/apache/kafka/pull/14151#discussion_r1285019147


##
storage/src/main/java/org/apache/kafka/server/log/remote/storage/RemoteLogManagerConfig.java:
##
@@ -134,6 +134,8 @@ public final class RemoteLogManagerConfig {
 "less than or equal to `log.retention.bytes` value.";
 public static final Long DEFAULT_LOG_LOCAL_RETENTION_BYTES = -2L;
 
+public static final String REMOTE_LOG_METADATA_PREFIX = 
"remote.log.metadata";

Review Comment:
   We already have `REMOTE_LOG_METADATA_MANAGER_CONFIG_PREFIX_PROP`. Configs 
that are prefixed with this value will be supplied to remote log metadata 
manager. 
   
   To configure the values in the JIRA ticket:
   ```
   remote.log.storage.manager.impl.prefix=remote.log.storage.
   remote.log.metadata.manager.impl.prefix=rlmm.config.
   
   rlmm.config.remote.log.metadata.topic.num.partitions=50
   rlmm.config.remote.log.metadata.topic.replication.factor=4
   rlmm.config.remote.log.metadata.topic.retention.ms=259200
   
   remote.log.storage.s3...
   ```
   
   Let's avoid one more `Map` (remoteLogMetadataProps) in 
RemoteLogManagerConfig. 
   
   Also, we can define the default values for the config `prefix`  in this PR:
   ```
   public static final String DEFAULT_REMOTE_STORAGE_MANAGER_CONFIG_PREFIX = 
"rsm.config.";
   public static final String DEFAULT_REMOTE_LOG_METADATA_MANAGER_CONFIG_PREFIX 
= "rlmm.config.";
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [kafka] kamalcph commented on a diff in pull request #14151: KAFKA-15083: add config with "remote.log.metadata" prefix

2023-08-04 Thread via GitHub 


kamalcph commented on code in PR #14151:
URL: https://github.com/apache/kafka/pull/14151#discussion_r1284973824


##
storage/src/main/java/org/apache/kafka/server/log/remote/storage/RemoteLogManagerConfig.java:
##
@@ -134,6 +134,8 @@ public final class RemoteLogManagerConfig {
 "less than or equal to `log.retention.bytes` value.";
 public static final Long DEFAULT_LOG_LOCAL_RETENTION_BYTES = -2L;
 
+public static final String REMOTE_LOG_METADATA_PREFIX = 
"remote.log.metadata";

Review Comment:
   Should we append the `PROP` (or) `CONFIG` suffix to it?



##
storage/src/main/java/org/apache/kafka/server/log/remote/storage/RemoteLogManagerConfig.java:
##
@@ -134,6 +134,8 @@ public final class RemoteLogManagerConfig {
 "less than or equal to `log.retention.bytes` value.";
 public static final Long DEFAULT_LOG_LOCAL_RETENTION_BYTES = -2L;
 
+public static final String REMOTE_LOG_METADATA_PREFIX = 
"remote.log.metadata";

Review Comment:
   Should we have append the `_PROP` (or) `_CONFIG` suffix to it?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org