[GitHub] [kafka] satishd commented on a change in pull request #10638: KAFKA-12758 Added `server-common` module to have server side common classes.
satishd commented on a change in pull request #10638:
URL: https://github.com/apache/kafka/pull/10638#discussion_r629269557
##
File path: build.gradle
##
@@ -1345,6 +1349,62 @@ project(':raft') {
}
}
+project(':server-common') {
+ archivesBaseName = "kafka-server-common"
Review comment:
Created https://issues.apache.org/jira/browse/KAFKA-12757 to discuss
more on this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [kafka] satishd commented on a change in pull request #10638: KAFKA-12758 Added `server-common` module to have server side common classes.
satishd commented on a change in pull request #10638:
URL: https://github.com/apache/kafka/pull/10638#discussion_r628356562
##
File path: build.gradle
##
@@ -1345,6 +1349,62 @@ project(':raft') {
}
}
+project(':server-common') {
+ archivesBaseName = "kafka-server-common"
+
+ dependencies {
+implementation project(':clients')
Review comment:
Good point @ijuma. It makes sense to me to have explicit client
dependency irrespective of `server-common` dependency.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [kafka] satishd commented on a change in pull request #10638: KAFKA-12758 Added `server-common` module to have server side common classes.
satishd commented on a change in pull request #10638:
URL: https://github.com/apache/kafka/pull/10638#discussion_r628139399
##
File path: build.gradle
##
@@ -1345,6 +1349,62 @@ project(':raft') {
}
}
+project(':server-common') {
+ archivesBaseName = "kafka-server-common"
+
+ dependencies {
+implementation project(':clients')
Review comment:
I did not add `clients` as `api` dependency. We may need to do that as
the users of `server-common` need `org.apache.kafka.common.protocol` classes as
they are part of the APIs in `server-common` classes.
After this change, we can remove `clients` dependency from wherever
`server-common` module is directly used.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [kafka] satishd commented on a change in pull request #10638: KAFKA-12758 Added `server-common` module to have server side common classes.
satishd commented on a change in pull request #10638:
URL: https://github.com/apache/kafka/pull/10638#discussion_r628139847
##
File path: build.gradle
##
@@ -1345,6 +1349,62 @@ project(':raft') {
}
}
+project(':server-common') {
+ archivesBaseName = "kafka-server-common"
Review comment:
I plan to do that in another PR. I have not yet decided whether to have
a separate sub module like `server-api` or part of `server-common` module.
`server-api` module can contain all the server related public API classes
including storage, security etc.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [kafka] satishd commented on a change in pull request #10638: KAFKA-12758 Added `server-common` module to have server side common classes.
satishd commented on a change in pull request #10638:
URL: https://github.com/apache/kafka/pull/10638#discussion_r628151162
##
File path: build.gradle
##
@@ -1345,6 +1349,62 @@ project(':raft') {
}
}
+project(':server-common') {
+ archivesBaseName = "kafka-server-common"
+
+ dependencies {
+implementation project(':clients')
Review comment:
Added the change with the commit
https://github.com/apache/kafka/pull/10638/commits/1e259ffac16c4237565fa6be02c1e12df812e15a
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [kafka] satishd commented on a change in pull request #10638: KAFKA-12758 Added `server-common` module to have server side common classes.
satishd commented on a change in pull request #10638:
URL: https://github.com/apache/kafka/pull/10638#discussion_r628139847
##
File path: build.gradle
##
@@ -1345,6 +1349,62 @@ project(':raft') {
}
}
+project(':server-common') {
+ archivesBaseName = "kafka-server-common"
Review comment:
I plan to do that in another PR. I have not yet decided whether to have
a separate sub module like `server-api` or part of `server-common` module.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [kafka] satishd commented on a change in pull request #10638: KAFKA-12758 Added `server-common` module to have server side common classes.
satishd commented on a change in pull request #10638:
URL: https://github.com/apache/kafka/pull/10638#discussion_r628139621
##
File path: build.gradle
##
@@ -1070,6 +1071,7 @@ project(':metadata') {
archivesBaseName = "kafka-metadata"
dependencies {
+implementation project(':server-common')
Review comment:
Good catch. It looks like these are already copied as part of
`configurations.runtimeClasspath`. I raised
https://github.com/apache/kafka/pull/10647 to fix that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [kafka] satishd commented on a change in pull request #10638: KAFKA-12758 Added `server-common` module to have server side common classes.
satishd commented on a change in pull request #10638:
URL: https://github.com/apache/kafka/pull/10638#discussion_r628139399
##
File path: build.gradle
##
@@ -1345,6 +1349,62 @@ project(':raft') {
}
}
+project(':server-common') {
+ archivesBaseName = "kafka-server-common"
+
+ dependencies {
+implementation project(':clients')
Review comment:
We did not add `clients` as `api` dependency. We may need to do that as
the users of server-common need `org.apache.kafka.common.protocol` classes as
they are part of the APIs in `server-common` classes.
After this change, we can remove `clients` dependency from wherever
`server-common` module is directly used.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [kafka] satishd commented on a change in pull request #10638: KAFKA-12758 Added `server-common` module to have server side common classes.
satishd commented on a change in pull request #10638:
URL: https://github.com/apache/kafka/pull/10638#discussion_r628139004
##
File path: build.gradle
##
@@ -1267,11 +1269,13 @@ project(':raft') {
archivesBaseName = "kafka-raft"
dependencies {
+implementation project(':server-common')
Review comment:
Pl see the earlier
[comment](https://github.com/apache/kafka/pull/10638#discussion_r628138833).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [kafka] satishd commented on a change in pull request #10638: KAFKA-12758 Added `server-common` module to have server side common classes.
satishd commented on a change in pull request #10638:
URL: https://github.com/apache/kafka/pull/10638#discussion_r628138833
##
File path: build.gradle
##
@@ -779,6 +779,7 @@ project(':core') {
api project(':clients')
api libs.scalaLibrary
+implementation project(':server-common')
Review comment:
Right, it is needed as `server-common` is only compile/runtime
dependency of `raft` and `metadata`. But it is not a transitive dependency.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [kafka] satishd commented on a change in pull request #10638: KAFKA-12758 Added `server-common` module to have server side common classes.
satishd commented on a change in pull request #10638:
URL: https://github.com/apache/kafka/pull/10638#discussion_r628138696
##
File path: build.gradle
##
@@ -1585,6 +1644,7 @@ project(':shell') {
implementation libs.jacksonJDK8Datatypes
implementation libs.jline
implementation libs.slf4jApi
+implementation project(':server-common')
Review comment:
Right, this is needed because `core` module does not expose
`server-common` as a transitive module with gradle `api` dependency. It uses
`implementation` dependency for `server-common` to be part of `core` module's
compile/runtime classpaths.
I am not sure whether we really have usages for `server-common` classes to
be exposed as part of `core` module.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
