Re: [PR] KAFKA-15853: Refactor org.apache.kafka.server.config.Defaults to follow Java config pattern [kafka]
OmniaGM commented on PR #15260: URL: https://github.com/apache/kafka/pull/15260#issuecomment-2061522296 Am going to close this as we already started to move defaults out of Default and into the scoped config classes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] KAFKA-15853: Refactor org.apache.kafka.server.config.Defaults to follow Java config pattern [kafka]
OmniaGM closed pull request #15260: KAFKA-15853: Refactor org.apache.kafka.server.config.Defaults to follow Java config pattern URL: https://github.com/apache/kafka/pull/15260 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] KAFKA-15853: Refactor org.apache.kafka.server.config.Defaults to follow Java config pattern [kafka]
OmniaGM commented on PR #15260: URL: https://github.com/apache/kafka/pull/15260#issuecomment-1910886475 okay we can leave this one as the last pr to merge them together -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] KAFKA-15853: Refactor org.apache.kafka.server.config.Defaults to follow Java config pattern [kafka]
ijuma commented on PR #15260: URL: https://github.com/apache/kafka/pull/15260#issuecomment-1910698896 I am ok with whatever approach is easiest. I care more about the end state (assuming the intermediate state doesn't last for too long). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] KAFKA-15853: Refactor org.apache.kafka.server.config.Defaults to follow Java config pattern [kafka]
mimaison commented on PR #15260: URL: https://github.com/apache/kafka/pull/15260#issuecomment-1910237310 I agree we want to shift `Defaults` into `KafkaConfig` (in Java) but I wonder if we should keep what we have for now and keep breaking the Scala `KafkaConfig` down. It seems the bulk of this PR is basically refactoring the Scala `KafkaConfig` which we aim to remove, and causes a bunch of changes (for example the `KafkaConfig -> JKafkaConfig`) that will need to be updated again once `KafkaConfig` is fully moved. It seems we have most of the remaining changes needed to fully move `KafkaConfig` ready so I wonder if we should keep working on them and merge `Defaults/KafkaConfig` when we finally remove the Scala version. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] KAFKA-15853: Refactor org.apache.kafka.server.config.Defaults to follow Java config pattern [kafka]
OmniaGM commented on PR #15260: URL: https://github.com/apache/kafka/pull/15260#issuecomment-1910107947 @ijuma, @mimaison can one of you have a look into this pr? This is related to @ijuma comment here https://github.com/apache/kafka/pull/15158#pullrequestreview-1836760668 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] KAFKA-15853: Refactor org.apache.kafka.server.config.Defaults to follow Java config pattern [kafka]
OmniaGM opened a new pull request, #15260: URL: https://github.com/apache/kafka/pull/15260 ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status - [ ] Verify documentation (including upgrade notes) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
