Re: [PR] KAFKA-16385: Enhance documentation for retention.ms and retention.bytes configurations [kafka]
chia7712 commented on PR #15588: URL: https://github.com/apache/kafka/pull/15588#issuecomment-2022675724 @jeqo I should merge code after getting your reviews :( -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] KAFKA-16385: Enhance documentation for retention.ms and retention.bytes configurations [kafka]
brandboat commented on PR #15588: URL: https://github.com/apache/kafka/pull/15588#issuecomment-2022630053 Thank you @showuon , @jeqo . I will address the comments in the new JIRA https://issues.apache.org/jira/browse/KAFKA-16429 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] KAFKA-16385: Enhance documentation for retention.ms and retention.bytes configurations [kafka]
jeqo commented on PR #15588: URL: https://github.com/apache/kafka/pull/15588#issuecomment-2022623732 Sorry for also being later with the review. Changes look good to me overall, though I'd also add a mention on these configs that: `log.roll` configs are ignored (as well as the mentioned `segment.bytes|ms`). We could address this as part of KAFKA-16429 if you agree. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] KAFKA-16385: Enhance documentation for retention.ms and retention.bytes configurations [kafka]
showuon commented on PR #15588: URL: https://github.com/apache/kafka/pull/15588#issuecomment-2021842695 Sorry for being late for the review. But do you think we should also add some notes for these related configs? server configs: 1. log.retention.bytes 2. log.retention.hours 3. log.retention.minutes 4. log.retention.ms 5. log.roll.hours 6. log.roll.ms 7. log.roll.bytes topic configs: 1. segment.ms 2. segment.bytes WDYT? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] KAFKA-16385: Enhance documentation for retention.ms and retention.bytes configurations [kafka]
chia7712 merged PR #15588: URL: https://github.com/apache/kafka/pull/15588 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] KAFKA-16385: Enhance documentation for retention.ms and retention.bytes configurations [kafka]
chia7712 commented on PR #15588: URL: https://github.com/apache/kafka/pull/15588#issuecomment-2021795623 ```sh ./gradlew cleanTest :streams:test --tests TaskMetadataIntegrationTest.shouldReportCorrectEndOffsetInformation :storage:test --tests TransactionsWithTieredStoreTest.testBumpTransactionalEpoch :metadata:test --tests QuorumControllerTest.testFatalMetadataReplayErrorOnActive --tests QuorumControllerTest.testFenceMultipleBrokers :trogdor:test --tests CoordinatorTest.testTaskRequestWithOldStartMsGetsUpdated :server:test --tests AssignmentsManagerTest.testRequeuesFailedAssignmentPropagations :connect:mirror:test --tests IdentityReplicationIntegrationTest.testSyncTopicConfigs --tests MirrorConnectorsIntegrationTransactionsTest.testReplicateSourceDefault :core:test --tests PlaintextConsumerTest.testCoordinatorFailover --tests PlaintextConsumerTest.testAsyncCommit --tests DynamicBrokerReconfigurationTest.testLogCleanerConfig --tests DynamicBrokerReconfigurationTest.executionError --tests EdgeCaseRequestTest.initializationError --tests FetchRequestBetweenDifferentIbpTest.initializationError --tests FetchRequestMaxBytesTest.initializationError --tests FetchRequestTestDowngrade.initializationError --tests GssapiAuthenticationTest.initializationError --tests ReplicaManagerTest.testRemoteFetchExpiresPerSecMetric --tests KafkaMetricReporterClusterIdTest.initializationError --tests KafkaMetricReporterExceptionHandlingTest.initializationError --tests KafkaMetricsReporterTest.initializationError --tests KafkaServerTest.initializationError --tests ListOffsetsRequestTest.initializationError --tests LogDirFailureTest.initializationError --tests LogRecoveryTest.initializationError --tests MetadataRequestTest.initializationError --tests MultipleListenersWithDefaultJaasContextTest.initializationError --tests ProduceRequestTest.initializationError --tests RequestQuotaTest.initializationError --tests ServerGenerateBrokerIdTest.initializationError --tests ServerStartupTest.initializationError --tests TopicIdWithOldInterBrokerProtocolTest.initializationError --tests EpochDrivenReplicati onProtocolAcceptanceTest.initializationError --tests LeaderEpochIntegrationTest.initializationError --tests ReplicationUtilsTest.initializationError --tests KafkaZkClientTest.initializationError --tests ZkConfigMigrationClientTest.initializationError --tests LogDirFailureTest.testIOExceptionDuringCheckpoint --tests LogDirFailureTest.testIOExceptionDuringLogRoll :clients:test --tests SslTransportLayerTest.testUngracefulRemoteCloseDuringHandshakeRead ``` unrelated failure. will merge it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] KAFKA-16385: Enhance documentation for retention.ms and retention.bytes configurations [kafka]
brandboat commented on PR #15588: URL: https://github.com/apache/kafka/pull/15588#issuecomment-2020624400 Thanks for your time, folks ! :+1: -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] KAFKA-16385: Enhance documentation for retention.ms and retention.bytes configurations [kafka]
brandboat commented on code in PR #15588:
URL: https://github.com/apache/kafka/pull/15588#discussion_r1539034951
##
clients/src/main/java/org/apache/kafka/common/config/TopicConfig.java:
##
@@ -67,13 +67,17 @@ public class TopicConfig {
"(which consists of log segments) can grow to before we will discard
old log segments to free up space if we " +
"are using the \"delete\" retention policy. By default there is no
size limit only a time limit. " +
"Since this limit is enforced at the partition level, multiply it by
the number of partitions to compute " +
-"the topic retention in bytes.";
+"the topic retention in bytes. Additionally, retention.bytes
configuration " +
+"operates independently of \"segment.ms\" and \"segment.byte\"
configurations. " +
+"Moreover, it triggers the expiration of active segment if
retention.bytes is configured to zero.";
Review Comment:
Thanks for the feedback, I've address the comments in the latest commit,
please take a look.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] KAFKA-16385: Enhance documentation for retention.ms and retention.bytes configurations [kafka]
chia7712 commented on code in PR #15588:
URL: https://github.com/apache/kafka/pull/15588#discussion_r1539026129
##
clients/src/main/java/org/apache/kafka/common/config/TopicConfig.java:
##
@@ -67,13 +67,17 @@ public class TopicConfig {
"(which consists of log segments) can grow to before we will discard
old log segments to free up space if we " +
"are using the \"delete\" retention policy. By default there is no
size limit only a time limit. " +
"Since this limit is enforced at the partition level, multiply it by
the number of partitions to compute " +
-"the topic retention in bytes.";
+"the topic retention in bytes. Additionally, retention.bytes
configuration " +
+"operates independently of \"segment.ms\" and \"segment.byte\"
configurations. " +
+"Moreover, it triggers the expiration of active segment if
retention.bytes is configured to zero.";
Review Comment:
We should focus on that "active segment can get rolled". Introducing the new
term (expired) and complicating the docs is not the purpose of this PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] KAFKA-16385: Enhance documentation for retention.ms and retention.bytes configurations [kafka]
soarez commented on code in PR #15588:
URL: https://github.com/apache/kafka/pull/15588#discussion_r1538964419
##
clients/src/main/java/org/apache/kafka/common/config/TopicConfig.java:
##
@@ -67,13 +67,17 @@ public class TopicConfig {
"(which consists of log segments) can grow to before we will discard
old log segments to free up space if we " +
"are using the \"delete\" retention policy. By default there is no
size limit only a time limit. " +
"Since this limit is enforced at the partition level, multiply it by
the number of partitions to compute " +
-"the topic retention in bytes.";
+"the topic retention in bytes. Additionally, retention.bytes
configuration " +
+"operates independently of \"segment.ms\" and \"segment.byte\"
configurations. " +
+"Moreover, it triggers the expiration of active segment if
retention.bytes is configured to zero.";
Review Comment:
Yup, that's useful.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] KAFKA-16385: Enhance documentation for retention.ms and retention.bytes configurations [kafka]
soarez commented on code in PR #15588:
URL: https://github.com/apache/kafka/pull/15588#discussion_r1538963823
##
clients/src/main/java/org/apache/kafka/common/config/TopicConfig.java:
##
@@ -67,13 +67,17 @@ public class TopicConfig {
"(which consists of log segments) can grow to before we will discard
old log segments to free up space if we " +
"are using the \"delete\" retention policy. By default there is no
size limit only a time limit. " +
"Since this limit is enforced at the partition level, multiply it by
the number of partitions to compute " +
-"the topic retention in bytes.";
+"the topic retention in bytes. Additionally, retention.bytes
configuration " +
+"operates independently of \"segment.ms\" and \"segment.byte\"
configurations. " +
+"Moreover, it triggers the expiration of active segment if
retention.bytes is configured to zero.";
public static final String RETENTION_MS_CONFIG = "retention.ms";
public static final String RETENTION_MS_DOC = "This configuration controls
the maximum time we will retain a " +
"log before we will discard old log segments to free up space if we
are using the " +
"\"delete\" retention policy. This represents an SLA on how soon
consumers must read " +
-"their data. If set to -1, no time limit is applied.";
+"their data. If set to -1, no time limit is applied. Additionally,
retention.ms configuration " +
+"operates independently of \"segment.ms\" and \"segment.byte\"
configurations. " +
+"Moreover, it triggers the expiration of active segment.";
Review Comment:
Sounds good to me too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] KAFKA-16385: Enhance documentation for retention.ms and retention.bytes configurations [kafka]
brandboat commented on code in PR #15588:
URL: https://github.com/apache/kafka/pull/15588#discussion_r1538657567
##
clients/src/main/java/org/apache/kafka/common/config/TopicConfig.java:
##
@@ -67,13 +67,17 @@ public class TopicConfig {
"(which consists of log segments) can grow to before we will discard
old log segments to free up space if we " +
"are using the \"delete\" retention policy. By default there is no
size limit only a time limit. " +
"Since this limit is enforced at the partition level, multiply it by
the number of partitions to compute " +
-"the topic retention in bytes.";
+"the topic retention in bytes. Additionally, retention.bytes
configuration " +
+"operates independently of \"segment.ms\" and \"segment.byte\"
configurations. " +
+"Moreover, it triggers the expiration of active segment if
retention.bytes is configured to zero.";
public static final String RETENTION_MS_CONFIG = "retention.ms";
public static final String RETENTION_MS_DOC = "This configuration controls
the maximum time we will retain a " +
"log before we will discard old log segments to free up space if we
are using the " +
"\"delete\" retention policy. This represents an SLA on how soon
consumers must read " +
-"their data. If set to -1, no time limit is applied.";
+"their data. If set to -1, no time limit is applied. Additionally,
retention.ms configuration " +
+"operates independently of \"segment.ms\" and \"segment.byte\"
configurations. " +
+"Moreover, it triggers the expiration of active segment.";
Review Comment:
sounds good, @soarez , WDYT ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] KAFKA-16385: Enhance documentation for retention.ms and retention.bytes configurations [kafka]
chia7712 commented on code in PR #15588:
URL: https://github.com/apache/kafka/pull/15588#discussion_r1538656650
##
clients/src/main/java/org/apache/kafka/common/config/TopicConfig.java:
##
@@ -67,13 +67,17 @@ public class TopicConfig {
"(which consists of log segments) can grow to before we will discard
old log segments to free up space if we " +
"are using the \"delete\" retention policy. By default there is no
size limit only a time limit. " +
"Since this limit is enforced at the partition level, multiply it by
the number of partitions to compute " +
-"the topic retention in bytes.";
+"the topic retention in bytes. Additionally, retention.bytes
configuration " +
+"operates independently of \"segment.ms\" and \"segment.byte\"
configurations. " +
+"Moreover, it triggers the expiration of active segment if
retention.bytes is configured to zero.";
public static final String RETENTION_MS_CONFIG = "retention.ms";
public static final String RETENTION_MS_DOC = "This configuration controls
the maximum time we will retain a " +
"log before we will discard old log segments to free up space if we
are using the " +
"\"delete\" retention policy. This represents an SLA on how soon
consumers must read " +
-"their data. If set to -1, no time limit is applied.";
+"their data. If set to -1, no time limit is applied. Additionally,
retention.ms configuration " +
+"operates independently of \"segment.ms\" and \"segment.byte\"
configurations. " +
+"Moreover, it triggers the expiration of active segment.";
Review Comment:
How about using "roll" instead of "expired"
'It will trigger the rolling of new segment if xxx met'
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] KAFKA-16385: Enhance documentation for retention.ms and retention.bytes configurations [kafka]
brandboat commented on code in PR #15588:
URL: https://github.com/apache/kafka/pull/15588#discussion_r1538483814
##
clients/src/main/java/org/apache/kafka/common/config/TopicConfig.java:
##
@@ -67,13 +67,17 @@ public class TopicConfig {
"(which consists of log segments) can grow to before we will discard
old log segments to free up space if we " +
"are using the \"delete\" retention policy. By default there is no
size limit only a time limit. " +
"Since this limit is enforced at the partition level, multiply it by
the number of partitions to compute " +
-"the topic retention in bytes.";
+"the topic retention in bytes. Additionally, retention.bytes
configuration " +
+"operates independently of \"segment.ms\" and \"segment.byte\"
configurations. " +
+"Moreover, it triggers the expiration of active segment if
retention.bytes is configured to zero.";
public static final String RETENTION_MS_CONFIG = "retention.ms";
public static final String RETENTION_MS_DOC = "This configuration controls
the maximum time we will retain a " +
"log before we will discard old log segments to free up space if we
are using the " +
"\"delete\" retention policy. This represents an SLA on how soon
consumers must read " +
-"their data. If set to -1, no time limit is applied.";
+"their data. If set to -1, no time limit is applied. Additionally,
retention.ms configuration " +
+"operates independently of \"segment.ms\" and \"segment.byte\"
configurations. " +
+"Moreover, it triggers the expiration of active segment.";
Review Comment:
Thanks for the feedback ! Do you think this is ok ?
```
Moreover, it triggers the expiration of active segment,
segment expiration refers to the complete removal of segments from
the partition once the retention.ms condition is satisfied.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] KAFKA-16385: Enhance documentation for retention.ms and retention.bytes configurations [kafka]
brandboat commented on code in PR #15588:
URL: https://github.com/apache/kafka/pull/15588#discussion_r1538478333
##
clients/src/main/java/org/apache/kafka/common/config/TopicConfig.java:
##
@@ -67,13 +67,17 @@ public class TopicConfig {
"(which consists of log segments) can grow to before we will discard
old log segments to free up space if we " +
"are using the \"delete\" retention policy. By default there is no
size limit only a time limit. " +
"Since this limit is enforced at the partition level, multiply it by
the number of partitions to compute " +
-"the topic retention in bytes.";
+"the topic retention in bytes. Additionally, retention.bytes
configuration " +
+"operates independently of \"segment.ms\" and \"segment.byte\"
configurations. " +
+"Moreover, it triggers the expiration of active segment if
retention.bytes is configured to zero.";
Review Comment:
The segment expiration means segment is completely removed once the
retention limits are met.
Maybe add a sentence like this ?
```
Segment expiration refers to the complete removal of segments
from the partition once the retention.bytes condition is satisfied.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] KAFKA-16385: Enhance documentation for retention.ms and retention.bytes configurations [kafka]
brandboat commented on code in PR #15588:
URL: https://github.com/apache/kafka/pull/15588#discussion_r1538478333
##
clients/src/main/java/org/apache/kafka/common/config/TopicConfig.java:
##
@@ -67,13 +67,17 @@ public class TopicConfig {
"(which consists of log segments) can grow to before we will discard
old log segments to free up space if we " +
"are using the \"delete\" retention policy. By default there is no
size limit only a time limit. " +
"Since this limit is enforced at the partition level, multiply it by
the number of partitions to compute " +
-"the topic retention in bytes.";
+"the topic retention in bytes. Additionally, retention.bytes
configuration " +
+"operates independently of \"segment.ms\" and \"segment.byte\"
configurations. " +
+"Moreover, it triggers the expiration of active segment if
retention.bytes is configured to zero.";
Review Comment:
The segment expiration means segment is completely removed once the
retention limits are met.
Maybe add a sentence like this ?
```
Segment expiration refers to the complete removal of segments
from the partition once the retention conditions are satisfied.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] KAFKA-16385: Enhance documentation for retention.ms and retention.bytes configurations [kafka]
brandboat commented on code in PR #15588:
URL: https://github.com/apache/kafka/pull/15588#discussion_r1538478333
##
clients/src/main/java/org/apache/kafka/common/config/TopicConfig.java:
##
@@ -67,13 +67,17 @@ public class TopicConfig {
"(which consists of log segments) can grow to before we will discard
old log segments to free up space if we " +
"are using the \"delete\" retention policy. By default there is no
size limit only a time limit. " +
"Since this limit is enforced at the partition level, multiply it by
the number of partitions to compute " +
-"the topic retention in bytes.";
+"the topic retention in bytes. Additionally, retention.bytes
configuration " +
+"operates independently of \"segment.ms\" and \"segment.byte\"
configurations. " +
+"Moreover, it triggers the expiration of active segment if
retention.bytes is configured to zero.";
Review Comment:
The segment expiration means segment expiration are completely removed once
the retention limits are met.
Maybe add a sentence like this ?
```
Segment expiration refers to the complete removal of segments
from the partition once the retention conditions are satisfied.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] KAFKA-16385: Enhance documentation for retention.ms and retention.bytes configurations [kafka]
soarez commented on code in PR #15588:
URL: https://github.com/apache/kafka/pull/15588#discussion_r1538177857
##
clients/src/main/java/org/apache/kafka/common/config/TopicConfig.java:
##
@@ -67,13 +67,17 @@ public class TopicConfig {
"(which consists of log segments) can grow to before we will discard
old log segments to free up space if we " +
"are using the \"delete\" retention policy. By default there is no
size limit only a time limit. " +
"Since this limit is enforced at the partition level, multiply it by
the number of partitions to compute " +
-"the topic retention in bytes.";
+"the topic retention in bytes. Additionally, retention.bytes
configuration " +
+"operates independently of \"segment.ms\" and \"segment.byte\"
configurations. " +
+"Moreover, it triggers the expiration of active segment if
retention.bytes is configured to zero.";
public static final String RETENTION_MS_CONFIG = "retention.ms";
public static final String RETENTION_MS_DOC = "This configuration controls
the maximum time we will retain a " +
"log before we will discard old log segments to free up space if we
are using the " +
"\"delete\" retention policy. This represents an SLA on how soon
consumers must read " +
-"their data. If set to -1, no time limit is applied.";
+"their data. If set to -1, no time limit is applied. Additionally,
retention.ms configuration " +
+"operates independently of \"segment.ms\" and \"segment.byte\"
configurations. " +
+"Moreover, it triggers the expiration of active segment.";
Review Comment:
This sentence seems incomplete.
##
clients/src/main/java/org/apache/kafka/common/config/TopicConfig.java:
##
@@ -67,13 +67,17 @@ public class TopicConfig {
"(which consists of log segments) can grow to before we will discard
old log segments to free up space if we " +
"are using the \"delete\" retention policy. By default there is no
size limit only a time limit. " +
"Since this limit is enforced at the partition level, multiply it by
the number of partitions to compute " +
-"the topic retention in bytes.";
+"the topic retention in bytes. Additionally, retention.bytes
configuration " +
+"operates independently of \"segment.ms\" and \"segment.byte\"
configurations. " +
+"Moreover, it triggers the expiration of active segment if
retention.bytes is configured to zero.";
Review Comment:
Should we explain what "segment expiration" entails? I don't think it's
clear from the description what it would mean in practical terms for the active
segment to expire.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] KAFKA-16385: Enhance documentation for retention.ms and retention.bytes configurations [kafka]
chia7712 commented on PR #15588: URL: https://github.com/apache/kafka/pull/15588#issuecomment-2017313746 @jeqo Could you please take a look? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] KAFKA-16385: Enhance documentation for retention.ms and retention.bytes configurations [kafka]
chia7712 commented on code in PR #15588:
URL: https://github.com/apache/kafka/pull/15588#discussion_r1536745453
##
clients/src/main/java/org/apache/kafka/common/config/TopicConfig.java:
##
@@ -67,13 +67,17 @@ public class TopicConfig {
"(which consists of log segments) can grow to before we will discard
old log segments to free up space if we " +
"are using the \"delete\" retention policy. By default there is no
size limit only a time limit. " +
"Since this limit is enforced at the partition level, multiply it by
the number of partitions to compute " +
-"the topic retention in bytes.";
+"the topic retention in bytes. Additionally, retention.bytes
configuration " +
+"operates independently of \"segment.ms\" and \"segment.byte\"
configurations. " +
+"Moreover, it triggers the expiration of active segment when the
segment size is zero.";
Review Comment:
oh, sorry for my typo
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] KAFKA-16385: Enhance documentation for retention.ms and retention.bytes configurations [kafka]
brandboat commented on code in PR #15588:
URL: https://github.com/apache/kafka/pull/15588#discussion_r1536744043
##
clients/src/main/java/org/apache/kafka/common/config/TopicConfig.java:
##
@@ -67,13 +67,17 @@ public class TopicConfig {
"(which consists of log segments) can grow to before we will discard
old log segments to free up space if we " +
"are using the \"delete\" retention policy. By default there is no
size limit only a time limit. " +
"Since this limit is enforced at the partition level, multiply it by
the number of partitions to compute " +
-"the topic retention in bytes.";
+"the topic retention in bytes. Additionally, retention.bytes
configuration " +
+"operates independently of \"segment.ms\" and \"segment.byte\"
configurations. " +
+"Moreover, it triggers the expiration of active segment when the
segment size is zero.";
Review Comment:
I believe you mean retention.bytes. :smiley:
##
clients/src/main/java/org/apache/kafka/common/config/TopicConfig.java:
##
@@ -67,13 +67,17 @@ public class TopicConfig {
"(which consists of log segments) can grow to before we will discard
old log segments to free up space if we " +
"are using the \"delete\" retention policy. By default there is no
size limit only a time limit. " +
"Since this limit is enforced at the partition level, multiply it by
the number of partitions to compute " +
-"the topic retention in bytes.";
+"the topic retention in bytes. Additionally, retention.bytes
configuration " +
+"operates independently of \"segment.ms\" and \"segment.byte\"
configurations. " +
+"Moreover, it triggers the expiration of active segment when the
segment size is zero.";
Review Comment:
I believe you mean `retention.bytes`. :smiley:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] KAFKA-16385: Enhance documentation for retention.ms and retention.bytes configurations [kafka]
chia7712 commented on code in PR #15588:
URL: https://github.com/apache/kafka/pull/15588#discussion_r1536742348
##
clients/src/main/java/org/apache/kafka/common/config/TopicConfig.java:
##
@@ -67,13 +67,17 @@ public class TopicConfig {
"(which consists of log segments) can grow to before we will discard
old log segments to free up space if we " +
"are using the \"delete\" retention policy. By default there is no
size limit only a time limit. " +
"Since this limit is enforced at the partition level, multiply it by
the number of partitions to compute " +
-"the topic retention in bytes.";
+"the topic retention in bytes. Additionally, retention.bytes
configuration " +
+"operates independently of \"segment.ms\" and \"segment.byte\"
configurations. " +
+"Moreover, it triggers the expiration of active segment when the
segment size is zero.";
Review Comment:
`if segment.byte is configured to zero`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[PR] KAFKA-16385: Enhance documentation for retention.ms and retention.bytes configurations [kafka]
brandboat opened a new pull request, #15588: URL: https://github.com/apache/kafka/pull/15588 as title, add more description for retention.ms and retention.bytes configurations ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status - [ ] Verify documentation (including upgrade notes) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
