Re: [PR] KAFKA-16804: Replace archivesBaseName with archivesName. [kafka]

[via GitHub]

gharris1727 commented on PR #16016:
URL: https://github.com/apache/kafka/pull/16016#issuecomment-2127676667

   Thank you @frankvicky for the quick turnaround!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] KAFKA-16804: Replace archivesBaseName with archivesName. [kafka]

[via GitHub]

gharris1727 merged PR #16016:
URL: https://github.com/apache/kafka/pull/16016


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] KAFKA-16804: Replace archivesBaseName with archivesName. [kafka]

[via GitHub]

frankvicky commented on code in PR #16016:
URL: https://github.com/apache/kafka/pull/16016#discussion_r1609645026


##
build.gradle:
##
@@ -341,7 +341,7 @@ subprojects {
 artifact task
 }
 
-artifactId = archivesBaseName
+artifactId = 
project.extensions.findByType(BasePluginExtension)?.archivesName?.get()

Review Comment:
   Cool, this makes sense, I will modify it.
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] KAFKA-16804: Replace archivesBaseName with archivesName. [kafka]

[via GitHub]

gharris1727 commented on PR #16016:
URL: https://github.com/apache/kafka/pull/16016#issuecomment-2123252147

   I verified that this change resolves the relevant build warnings, and 
produces an identical published result as the current trunk implementation.
   
   Thank you @frankvicky for picking this up!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] KAFKA-16804: Replace archivesBaseName with archivesName. [kafka]

[via GitHub]

gharris1727 commented on code in PR #16016:
URL: https://github.com/apache/kafka/pull/16016#discussion_r1608820947


##
build.gradle:
##
@@ -341,7 +341,7 @@ subprojects {
 artifact task
 }
 
-artifactId = archivesBaseName
+artifactId = 
project.extensions.findByType(BasePluginExtension)?.archivesName?.get()

Review Comment:
   I think this has the same effect, and looks a bit better. The "safe 
navigation operator" `?` also makes me think that this could be null, when it 
really should never be null, and the publishing plugin can't handle a null.
   ```suggestion
   artifactId = base.archivesName.get()
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[PR] KAFKA-16804: Replace archivesBaseName with archivesName. [kafka]

[via GitHub]

frankvicky opened a new pull request, #16016:
URL: https://github.com/apache/kafka/pull/16016

   Due to deprecation of archivesBaseName, we need to replace it by 
archivesName.
   
   - [ ] Verify design and implementation 
   - [ ] Verify test coverage and CI build status
   - [ ] Verify documentation (including upgrade notes)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org