[jira] [Commented] (KAFKA-16959) ConfigCommand should not allow to define both `entity-default` and `entity-name`
[ https://issues.apache.org/jira/browse/KAFKA-16959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17856121#comment-17856121 ] Tai Le Manh commented on KAFKA-16959: - [~chia7712] [~m1a2st] I agree with Chia-Ping Tsai's point, making it work with both entities really makes sense. > ConfigCommand should not allow to define both `entity-default` and > `entity-name` > > > Key: KAFKA-16959 > URL: https://issues.apache.org/jira/browse/KAFKA-16959 > Project: Kafka > Issue Type: Improvement >Reporter: Chia-Ping Tsai >Assignee: 黃竣陽 >Priority: Minor > > When users input both `entity-default` and `entity-name`, only `entity-name` > will get evaluated. It seems to me that is error-prone. We should throw > exception directly. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (KAFKA-16959) ConfigCommand should not allow to define both `entity-default` and `entity-name`
[ https://issues.apache.org/jira/browse/KAFKA-16959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17856103#comment-17856103 ] Chia-Ping Tsai commented on KAFKA-16959: Another point is that other entity type can process both entities. Hence, broker entity should work for both entities too for consistency. > ConfigCommand should not allow to define both `entity-default` and > `entity-name` > > > Key: KAFKA-16959 > URL: https://issues.apache.org/jira/browse/KAFKA-16959 > Project: Kafka > Issue Type: Improvement >Reporter: Chia-Ping Tsai >Assignee: 黃竣陽 >Priority: Minor > > When users input both `entity-default` and `entity-name`, only `entity-name` > will get evaluated. It seems to me that is error-prone. We should throw > exception directly. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (KAFKA-16959) ConfigCommand should not allow to define both `entity-default` and `entity-name`
[ https://issues.apache.org/jira/browse/KAFKA-16959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17856096#comment-17856096 ] 黃竣陽 commented on KAFKA-16959: - In this sentence > Alter an entity's config by adding/updating/removing config entries. The > given entity name may either be a specific entity (via --entity-name) or, if > supported, the default config for all entities (via --entity-default). I think that we should focus on "either ... or ...", It means we should choose one kind of entity. If we can use two kind entities, we need to check adding/updating/removing config belongs to which Update Mode. Personally, It will make code complex. [~chia7712] [~tailm.asf] WDYT? > ConfigCommand should not allow to define both `entity-default` and > `entity-name` > > > Key: KAFKA-16959 > URL: https://issues.apache.org/jira/browse/KAFKA-16959 > Project: Kafka > Issue Type: Improvement >Reporter: Chia-Ping Tsai >Assignee: 黃竣陽 >Priority: Minor > > When users input both `entity-default` and `entity-name`, only `entity-name` > will get evaluated. It seems to me that is error-prone. We should throw > exception directly. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (KAFKA-16959) ConfigCommand should not allow to define both `entity-default` and `entity-name`
[
https://issues.apache.org/jira/browse/KAFKA-16959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17856093#comment-17856093
]
Chia-Ping Tsai commented on KAFKA-16959:
[~tailm.asf] nice point. KIP-543 says:
{quote}
Alter an entity's config by adding/updating/removing config entries. The given
entity name may either be a specific entity (via --entity-name) or, if
supported, the default config for all entities (via --entity-default).
{quote}
Personally, it does not explicitly declare that we can input "both" kind of
entity. Also, current implementation [0] seems to send request for the "head"
of entity only.
BUT, I feel the point from [~tailm.asf] is better than my previous intent.
Instead of throwing exception, making it work with both entities is more
valuable.
[~m1a2st] [~tailm.asf] WDYT?
[0]
https://github.com/apache/kafka/blob/e2060204fead9aa03f611b76c543b6824f8eb26b/core/src/main/scala/kafka/admin/ConfigCommand.scala#L401
> ConfigCommand should not allow to define both `entity-default` and
> `entity-name`
>
>
> Key: KAFKA-16959
> URL: https://issues.apache.org/jira/browse/KAFKA-16959
> Project: Kafka
> Issue Type: Improvement
>Reporter: Chia-Ping Tsai
>Assignee: 黃竣陽
>Priority: Minor
>
> When users input both `entity-default` and `entity-name`, only `entity-name`
> will get evaluated. It seems to me that is error-prone. We should throw
> exception directly.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (KAFKA-16959) ConfigCommand should not allow to define both `entity-default` and `entity-name`
[ https://issues.apache.org/jira/browse/KAFKA-16959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17856048#comment-17856048 ] Tai Le Manh commented on KAFKA-16959: - hm, it seems that using `entity-name` and `entity-default` at the same time is legal, it is allowed and described in [KIP-543|https://cwiki.apache.org/confluence/display/KAFKA/KIP-543%3A+Expand+ConfigCommand%27s+non-ZK+functionality] > ConfigCommand should not allow to define both `entity-default` and > `entity-name` > > > Key: KAFKA-16959 > URL: https://issues.apache.org/jira/browse/KAFKA-16959 > Project: Kafka > Issue Type: Improvement >Reporter: Chia-Ping Tsai >Assignee: 黃竣陽 >Priority: Minor > > When users input both `entity-default` and `entity-name`, only `entity-name` > will get evaluated. It seems to me that is error-prone. We should throw > exception directly. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (KAFKA-16959) ConfigCommand should not allow to define both `entity-default` and `entity-name`
[ https://issues.apache.org/jira/browse/KAFKA-16959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17855040#comment-17855040 ] 黃竣陽 commented on KAFKA-16959: - Im interesting in this issue, I want handle it. > ConfigCommand should not allow to define both `entity-default` and > `entity-name` > > > Key: KAFKA-16959 > URL: https://issues.apache.org/jira/browse/KAFKA-16959 > Project: Kafka > Issue Type: Improvement >Reporter: Chia-Ping Tsai >Assignee: Chia-Ping Tsai >Priority: Minor > > When users input both `entity-default` and `entity-name`, only `entity-name` > will get evaluated. It seems to me that is error-prone. We should throw > exception directly. -- This message was sent by Atlassian Jira (v8.20.10#820010)
