[jira] [Commented] (KAFKA-8275) NetworkClient leastLoadedNode selection should consider throttled nodes
[ https://issues.apache.org/jira/browse/KAFKA-8275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17856097#comment-17856097 ] Goufu commented on KAFKA-8275: -- The leastLoadedNode() function has a bug during the consumer process starting period. The function sendMetadataRequest() called by getTopicMetadataRequest() uses a random node which maybe faulty since every node‘s state recorded in the client thread is not ready yet. It happened in my production environment during my consumer thread restarting and meanwhile one of the KAFKA server node is dead. I'm using the kafka-client-2.0.1.jar. I have checked the source code of higher versions and the issue still exists. > NetworkClient leastLoadedNode selection should consider throttled nodes > --- > > Key: KAFKA-8275 > URL: https://issues.apache.org/jira/browse/KAFKA-8275 > Project: Kafka > Issue Type: Bug > Components: clients, network >Reporter: Jason Gustafson >Assignee: Jason Gustafson >Priority: Major > Fix For: 2.3.0 > > > The leastLoadedNode() function is intended to find any available node. It is > smart in the sense that it considers the number of inflight requests and > reconnect backoff, but it has not been updated to take into account client > throttling. If we have an available node which is not throttled, we should > use it. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (KAFKA-8275) NetworkClient leastLoadedNode selection should consider throttled nodes
[ https://issues.apache.org/jira/browse/KAFKA-8275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16835075#comment-16835075 ] ASF GitHub Bot commented on KAFKA-8275: --- hachikuji commented on pull request #6619: KAFKA-8275; Take throttling into account when choosing least loaded node URL: https://github.com/apache/kafka/pull/6619 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > NetworkClient leastLoadedNode selection should consider throttled nodes > --- > > Key: KAFKA-8275 > URL: https://issues.apache.org/jira/browse/KAFKA-8275 > Project: Kafka > Issue Type: Bug >Reporter: Jason Gustafson >Assignee: Jason Gustafson >Priority: Major > > The leastLoadedNode() function is intended to find any available node. It is > smart in the sense that it considers the number of inflight requests and > reconnect backoff, but it has not been updated to take into account client > throttling. If we have an available node which is not throttled, we should > use it. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (KAFKA-8275) NetworkClient leastLoadedNode selection should consider throttled nodes
[ https://issues.apache.org/jira/browse/KAFKA-8275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16823230#comment-16823230 ] ASF GitHub Bot commented on KAFKA-8275: --- hachikuji commented on pull request #6619: KAFKA-8275; Take throttling into account when choosing least loaded node URL: https://github.com/apache/kafka/pull/6619 If a node is currently throttled, we should take it out of the running for `leastLoadedNode`. Additionally, current logic seems to favor connecting to new nodes rather than using existing connections which have one or more in flight requests. The javadoc is slightly vague about whether this is expected, but it seems not. ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status - [ ] Verify documentation (including upgrade notes) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > NetworkClient leastLoadedNode selection should consider throttled nodes > --- > > Key: KAFKA-8275 > URL: https://issues.apache.org/jira/browse/KAFKA-8275 > Project: Kafka > Issue Type: Bug >Reporter: Jason Gustafson >Assignee: Jason Gustafson >Priority: Major > > The leastLoadedNode() function is intended to find any available node. It is > smart in the sense that it considers the number of inflight requests and > reconnect backoff, but it has not been updated to take into account client > throttling. If we have an available node which is not throttled, we should > use it. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
