Re: [josm-dev] Bug in the Preferences (rev. 935)
On Tue, 9 Sep 2008, Christoph Seitz wrote: Today I found a bug in the Preferences. If you have no plugins, you get an NullPointerException. I described it on the josm-page. http://josm.openstreetmap.de/ticket/1520 Also added a patch for this problem :) But it would not work. null deletes the preferences entry and your fix prevented this :-) I fixed the bug in SVN. btw. I'm new to OSM and JOSM but I really really like it and I want to support the project, where I can, because I found it overwhelming to see, how much of Germany has been mapped. But I also so a lots of work to do. Maybe there is some work for a Java-Programmer here. :) Sure. We have 140 bug reports. Feel free to choose and fix. Ciao -- http://www.dstoecker.eu/ (PGP key available) ___ josm-dev mailing list josm-dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/josm-dev
Re: [josm-dev] Bug in the Preferences (rev. 935)
On Tue, 9 Sep 2008, Dirk Stöcker wrote: Today I found a bug in the Preferences. If you have no plugins, you get an NullPointerException. I described it on the josm-page. http://josm.openstreetmap.de/ticket/1520 Also added a patch for this problem :) But it would not work. null deletes the preferences entry and your fix prevented this :-) I fixed the bug in SVN. Because I sometimes forget to write it and I got a remember to be more friendly, one note to you and all others: I value patches. Make them, send them, but be prepared that I do not always accept them. A note like above means in long: Thanks for your patch. I checked it. It is the right way, but there was an error with it. The error was this ..., but as it was a minor error I fixed it myself (in this case as I introduced the bug myself also). I'm waiting for your next patch. I know all beginning is hard and I myself had a hard learning time, because I needed to learn programming all by myself. Thus whenever I write a comment about a patch, it will always contain a text what was wrong and what to fix, so the author and its skills can improve. But be prepared that I sometimes forget the Thanks :-) Ciao -- http://www.dstoecker.eu/ (PGP key available)___ josm-dev mailing list josm-dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/josm-dev
Re: [josm-dev] Still looking for patch review
On Mon, 8 Sep 2008, [EMAIL PROTECTED] wrote: I'm still looking for someone to look at the patch I submitted to ticket 682[1] to add proxy server configuration to JOSM. I really like to see this patch included into JOSM so please let me know if anything is wrong with it and what I could do to fix is. Sorry. I had a look at it, but forgot about it afterwards. If I read the stuff correctly, you add a new settings menu. Correct? Please don't do that. We already have to many of these. Add the settings in the same menu, where the OSM user password is entered. There is enough space left. I did the same approach as every settings backend which encapsulates the settings within one class. But in JOSM the settings backend is decoupled from the presentation to the user. Therefore presentation is (as you suggest) on the same tab as the username+password fields. Applied. Please improve your patch a bit nevertheless: a) if the first checkbox is unckecked, all 5 elements should be disabled. b) if the second checkbox is checked, username and password should be disabled. Ciao -- http://www.dstoecker.eu/ (PGP key available) ___ josm-dev mailing list josm-dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/josm-dev
Re: [josm-dev] Bug #973 Problem with AudioMarker
On Tue, 9 Sep 2008, Christoph Seitz wrote: but I'm not sure, whether this solution is good solution. And I think, the hole thing with the audio markers should be a bit more clear. Well, that's a true word :-) E.g. I had a short wav file which had to be at the end of my GPX track. I was unable to move the synchronisation behind the end of the wav and thus could not get it synchroniced. Also sometimes it tells it synchroniced, but when I play nothing changed. There are still some bugs hidden in audio stuff waiting to be fixed. Ciao -- http://www.dstoecker.eu/ (PGP key available) ___ josm-dev mailing list josm-dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/josm-dev
Re: [josm-dev] Bug #973 Problem with AudioMarker
On 09/09/2008 10:18, Dirk Stöcker wrote: On Tue, 9 Sep 2008, Christoph Seitz wrote: but I'm not sure, whether this solution is good solution. And I think, the hole thing with the audio markers should be a bit more clear. Well, that's a true word :-) E.g. I had a short wav file which had to be at the end of my GPX track. I was unable to move the synchronisation behind the end of the wav and thus could not get it synchroniced. Also sometimes it tells it synchroniced, but when I play nothing changed. There are still some bugs hidden in audio stuff waiting to be fixed. I'm sure there are. But as the original author of this, can I say I'm not psychic. If you'd put a bug report in about the above, I could try fixing it; if this 973 had been assigned to me I might have been aware of it. Please explain move the synchronisation behind the end of the wav some more. In order to synchronise you need a both a defined point in your audio and a defined point in your GPX. Were you syncing to an explicit waypoint, or to a point on the track (with SHIFT+DRAG)? Can you let me have the files (attach them to a bug report) so I can try (please say what the word you used to sync on was if it is in German). David ___ josm-dev mailing list josm-dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/josm-dev
Re: [josm-dev] Bug #973 Problem with AudioMarker
On Tue, 9 Sep 2008, David Earl wrote: E.g. I had a short wav file which had to be at the end of my GPX track. I was unable to move the synchronisation behind the end of the wav and thus could not get it synchroniced. Also sometimes it tells it synchroniced, but when I play nothing changed. There are still some bugs hidden in audio stuff waiting to be fixed. I'm sure there are. But as the original author of this, can I say I'm not psychic. If you'd put a bug report in about the above, I could try fixing it; if this 973 had been assigned to me I might have been aware of it. A good description also needs time and I did not have it yet :-) Please explain move the synchronisation behind the end of the wav some more. In order to synchronise you need a both a defined point in your audio and a defined point in your GPX. Were you syncing to an explicit waypoint, or to a point on the track (with SHIFT+DRAG)? Can you let me have the files (attach them to a bug report) so I can try (please say what the word you used to sync on was if it is in German). Have a wave e.g. 5 minutes and a GPX trace of e.g. 2 hours. Now the 5 minutes where about the last 5 of that track. I this SHIFT-MOVE'ed the playhead to the GPS-waypoint where it belonged to, but instead of syncing a message came telling me, that I go behind the file end. But as said I had not yet the time to check details. Ciao -- http://www.dstoecker.eu/ (PGP key available) ___ josm-dev mailing list josm-dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/josm-dev
[josm-dev] wmsplugin improvements
Hi, yesterday I was using a WMS-Server, which randomly returned HTTP 500 (Internal Server Error). Unfortunately the wmsplugin failed quietly, so I couldn't see, what was happening. So I made some improvements: 1. The wms grabber tries to download the image 5 times. If it fails the 5th time, a dummy image will be generated and rendered in the layer. It's red with the black string IOException occured, so that the user knows, that this tile failed to load and will not show up. 2. Check the Content-Type of the server response. If it isn't an image, there must have been an exception. In this case the plugin prints the response body to sysout. This happens after the 5th failed attempt to download the image. 3. The grabbers are executed by an ExecutorService (FixedThreadPool with size of 10), so that the number of running threads is limited. What do you think of these improvements? Cheers Henrik ___ josm-dev mailing list josm-dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/josm-dev
[josm-dev] Questiong regarding Bug #1394
Hello, I found the bug, but it's bot really a bug. It is in the code, that pause first slows the speed down and then stop it. I can change it. But I'am not sure if it's wanted. Greetings Christoph -- Christoph Seitz GMX startet ShortView.de. Hier findest Du Leute mit Deinen Interessen! Jetzt dabei sein: http://www.shortview.de/[EMAIL PROTECTED] ___ josm-dev mailing list josm-dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/josm-dev
